{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/comments/220702097","pull_request_review_id":159172118,"id":220702097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDcwMjA5Nw==","diff_hunk":"@@ -28,6 +31,9 @@\n  */\n @Value.Immutable\n @ImmutablesStyle\n+@JsonIgnoreProperties(ignoreUnknown = true)\n+@JsonSerialize(as = ImmutableErrorType.class)\n+@JsonDeserialize(as = ImmutableErrorType.class)","path":"errors/src/main/java/com/palantir/conjure/java/api/errors/ErrorType.java","position":16,"original_position":16,"commit_id":"ea85942ad8a1dd984d14ca880bf9c5fc2f44ed0d","original_commit_id":"ea85942ad8a1dd984d14ca880bf9c5fc2f44ed0d","user":{"login":"uschi2000","id":6528449,"node_id":"MDQ6VXNlcjY1Mjg0NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528449?v=4","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"allow deserialization gives the impression that this is used as wire format, but that's not the case","created_at":"2018-09-26T19:57:00Z","updated_at":"2018-09-26T19:57:00Z","html_url":"https://github.com/palantir/conjure-java-runtime-api/pull/130#discussion_r220702097","pull_request_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/comments/220702097"},"html":{"href":"https://github.com/palantir/conjure-java-runtime-api/pull/130#discussion_r220702097"},"pull_request":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130"}},"in_reply_to_id":220658379},"pull_request":{"url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130","id":218210049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjEwMDQ5","html_url":"https://github.com/palantir/conjure-java-runtime-api/pull/130","diff_url":"https://github.com/palantir/conjure-java-runtime-api/pull/130.diff","patch_url":"https://github.com/palantir/conjure-java-runtime-api/pull/130.patch","issue_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/130","number":130,"state":"open","locked":false,"title":"Add JSON annotations to ErrorType","user":{"login":"pkoenig10","id":5273164,"node_id":"MDQ6VXNlcjUyNzMxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5273164?v=4","gravatar_id":"","url":"https://api.github.com/users/pkoenig10","html_url":"https://github.com/pkoenig10","followers_url":"https://api.github.com/users/pkoenig10/followers","following_url":"https://api.github.com/users/pkoenig10/following{/other_user}","gists_url":"https://api.github.com/users/pkoenig10/gists{/gist_id}","starred_url":"https://api.github.com/users/pkoenig10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkoenig10/subscriptions","organizations_url":"https://api.github.com/users/pkoenig10/orgs","repos_url":"https://api.github.com/users/pkoenig10/repos","events_url":"https://api.github.com/users/pkoenig10/events{/privacy}","received_events_url":"https://api.github.com/users/pkoenig10/received_events","type":"User","site_admin":false},"body":"`ErrorType` is a safe-loggable arg of a `ServiceException`. Our internal logging library logs arg values using an object mapper. However `ErrorType` does not have JSON property annotations and consequently always gets serialized as \"{}\", which is not very helpful.\r\n\r\nEDIT: Would prefer to merge https://github.com/palantir/conjure-java-runtime/pull/827 instead.\r\n","created_at":"2018-09-26T07:09:59Z","updated_at":"2018-09-26T19:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"736195e6f41840dd84f0cdce6d2e8b7aef1f1624","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130/commits","review_comments_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130/comments","review_comment_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/130/comments","statuses_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/statuses/ea85942ad8a1dd984d14ca880bf9c5fc2f44ed0d","head":{"label":"pkoenig10:errorTypeJson","ref":"errorTypeJson","sha":"ea85942ad8a1dd984d14ca880bf9c5fc2f44ed0d","user":{"login":"pkoenig10","id":5273164,"node_id":"MDQ6VXNlcjUyNzMxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5273164?v=4","gravatar_id":"","url":"https://api.github.com/users/pkoenig10","html_url":"https://github.com/pkoenig10","followers_url":"https://api.github.com/users/pkoenig10/followers","following_url":"https://api.github.com/users/pkoenig10/following{/other_user}","gists_url":"https://api.github.com/users/pkoenig10/gists{/gist_id}","starred_url":"https://api.github.com/users/pkoenig10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkoenig10/subscriptions","organizations_url":"https://api.github.com/users/pkoenig10/orgs","repos_url":"https://api.github.com/users/pkoenig10/repos","events_url":"https://api.github.com/users/pkoenig10/events{/privacy}","received_events_url":"https://api.github.com/users/pkoenig10/received_events","type":"User","site_admin":false},"repo":{"id":147971705,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5NzE3MDU=","name":"conjure-java-runtime-api","full_name":"pkoenig10/conjure-java-runtime-api","private":false,"owner":{"login":"pkoenig10","id":5273164,"node_id":"MDQ6VXNlcjUyNzMxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5273164?v=4","gravatar_id":"","url":"https://api.github.com/users/pkoenig10","html_url":"https://github.com/pkoenig10","followers_url":"https://api.github.com/users/pkoenig10/followers","following_url":"https://api.github.com/users/pkoenig10/following{/other_user}","gists_url":"https://api.github.com/users/pkoenig10/gists{/gist_id}","starred_url":"https://api.github.com/users/pkoenig10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkoenig10/subscriptions","organizations_url":"https://api.github.com/users/pkoenig10/orgs","repos_url":"https://api.github.com/users/pkoenig10/repos","events_url":"https://api.github.com/users/pkoenig10/events{/privacy}","received_events_url":"https://api.github.com/users/pkoenig10/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pkoenig10/conjure-java-runtime-api","description":"The API components of the http-remoting RPC library","fork":true,"url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api","forks_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/forks","keys_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/teams","hooks_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/hooks","issue_events_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/issues/events{/number}","events_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/events","assignees_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/assignees{/user}","branches_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/branches{/branch}","tags_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/tags","blobs_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/statuses/{sha}","languages_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/languages","stargazers_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/stargazers","contributors_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/contributors","subscribers_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/subscribers","subscription_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/subscription","commits_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/contents/{+path}","compare_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/merges","archive_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/downloads","issues_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/issues{/number}","pulls_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/pulls{/number}","milestones_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/milestones{/number}","notifications_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/labels{/name}","releases_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/releases{/id}","deployments_url":"https://api.github.com/repos/pkoenig10/conjure-java-runtime-api/deployments","created_at":"2018-09-08T21:36:19Z","updated_at":"2018-09-08T21:36:22Z","pushed_at":"2018-09-26T07:41:35Z","git_url":"git://github.com/pkoenig10/conjure-java-runtime-api.git","ssh_url":"git@github.com:pkoenig10/conjure-java-runtime-api.git","clone_url":"https://github.com/pkoenig10/conjure-java-runtime-api.git","svn_url":"https://github.com/pkoenig10/conjure-java-runtime-api","homepage":"","size":510,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"028efefa326d63967132ef7c9aceb99e2cc16091","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":81138735,"node_id":"MDEwOlJlcG9zaXRvcnk4MTEzODczNQ==","name":"conjure-java-runtime-api","full_name":"palantir/conjure-java-runtime-api","private":false,"owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/palantir/conjure-java-runtime-api","description":"The API components of the http-remoting RPC library","fork":false,"url":"https://api.github.com/repos/palantir/conjure-java-runtime-api","forks_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/forks","keys_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/teams","hooks_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/hooks","issue_events_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/events","assignees_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/tags","blobs_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/languages","stargazers_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/stargazers","contributors_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/contributors","subscribers_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/subscribers","subscription_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/subscription","commits_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/merges","archive_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/downloads","issues_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/labels{/name}","releases_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/conjure-java-runtime-api/deployments","created_at":"2017-02-06T22:08:22Z","updated_at":"2018-09-21T12:17:07Z","pushed_at":"2018-09-26T07:41:36Z","git_url":"git://github.com/palantir/conjure-java-runtime-api.git","ssh_url":"git@github.com:palantir/conjure-java-runtime-api.git","clone_url":"https://github.com/palantir/conjure-java-runtime-api.git","svn_url":"https://github.com/palantir/conjure-java-runtime-api","homepage":"","size":503,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":15,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130"},"html":{"href":"https://github.com/palantir/conjure-java-runtime-api/pull/130"},"issue":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/130"},"comments":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/conjure-java-runtime-api/statuses/ea85942ad8a1dd984d14ca880bf9c5fc2f44ed0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"uschi2000"}}