{"action":"created","comment":{"url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/comments/179561442","pull_request_review_id":109799412,"id":179561442,"diff_hunk":"@@ -8,77 +9,21 @@ namespace FutureWonder.Exercises.Configuration\n     using KVPList = IList<KeyValuePair<string, ConfigValue>>;\n     using KList = IList<string>;\n \n-    // Strongly named exceptions\n-    public class ConfigErrorException : Exception\n-    {\n-    }\n-\n-    public class User\n-    {\n-        public string Username { get; set; }\n-    }\n-\n-    public class App\n-    {\n-        public string Appname { get; set; }\n-    }\n-\n-    public interface IConfig\n-    {\n-        void Initialize();\n-        void Shutdown(); // if needed\n-\n-        #region 1. Basic operations\n-\n-        ConfigValue GetValue(string key);\n-        void SaveValue(KVP kvp);\n-        void SaveValues(KVPList kvps);\n-        KVPList GetValues(KList keys);\n-\n-        #endregion 1. Basic operations\n-\n-        #region 2. User operations\n-\n-        ConfigValue GetValue(User user, string key);\n-        KVPList GetValues(User user, KList keys);\n-        void SaveValue(User user, KVP kvp);\n-        void SaveValues(User user, KVPList kvps);\n-\n-        #endregion 2. User operations\n-\n-        #region 3a. App operations\n-\n-        ConfigValue GetValue(App app, string key);\n-        KVPList GetValues(App user, KList keys);\n-        void SaveValue(App user, KVP kvp);\n-        void SaveValues(App user, KVPList kvps);\n-\n-        #endregion 3a. App operations\n-\n-        #region 3b. App / User operations\n-\n-        ConfigValue GetValue(App app, User user, string key);\n-        KVPList GetValues(App app, User user, KList keys);\n-        void SaveValue(App app, User user, KVP kvp);\n-        void SaveValues(App app, User user, KVPList kvps);\n-\n-        #endregion 3b. App / User operations\n-    }\n \n     public class Config : IConfig\n     {\n-        private readonly ILog _log = LogManager.GetLogger(nameof(Config));\n-        private IPersistSource _persistSource;\n+        private readonly ILog _log;\n+        private readonly IPersistSource _persistSource;\n \n-        public Config(IPersistSource persistSource)\n+        public Config(IPersistSource persistSource, ILog log = null)\n         {\n             _persistSource = persistSource;\n+            _log = log ?? LogManager.GetLogger(nameof(Config));","path":"CandidateExercise/ConfigurationExercise/Config.cs","position":79,"original_position":79,"commit_id":"20cb27f5b81820b2c78a05cdfebbd676e29cb871","original_commit_id":"20cb27f5b81820b2c78a05cdfebbd676e29cb871","user":{"login":"Chase-R","id":26582647,"avatar_url":"https://avatars1.githubusercontent.com/u/26582647?v=4","gravatar_id":"","url":"https://api.github.com/users/Chase-R","html_url":"https://github.com/Chase-R","followers_url":"https://api.github.com/users/Chase-R/followers","following_url":"https://api.github.com/users/Chase-R/following{/other_user}","gists_url":"https://api.github.com/users/Chase-R/gists{/gist_id}","starred_url":"https://api.github.com/users/Chase-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chase-R/subscriptions","organizations_url":"https://api.github.com/users/Chase-R/orgs","repos_url":"https://api.github.com/users/Chase-R/repos","events_url":"https://api.github.com/users/Chase-R/events{/privacy}","received_events_url":"https://api.github.com/users/Chase-R/received_events","type":"User","site_admin":false},"body":"Nice injection.","created_at":"2018-04-05T18:37:05Z","updated_at":"2018-04-05T18:40:07Z","html_url":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3#discussion_r179561442","pull_request_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/comments/179561442"},"html":{"href":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3#discussion_r179561442"},"pull_request":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3","id":179553649,"html_url":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3","diff_url":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3.diff","patch_url":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3.patch","issue_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/3","number":3,"state":"open","locked":false,"title":"Part 1","user":{"login":"SherSpock","id":14241275,"avatar_url":"https://avatars3.githubusercontent.com/u/14241275?v=4","gravatar_id":"","url":"https://api.github.com/users/SherSpock","html_url":"https://github.com/SherSpock","followers_url":"https://api.github.com/users/SherSpock/followers","following_url":"https://api.github.com/users/SherSpock/following{/other_user}","gists_url":"https://api.github.com/users/SherSpock/gists{/gist_id}","starred_url":"https://api.github.com/users/SherSpock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SherSpock/subscriptions","organizations_url":"https://api.github.com/users/SherSpock/orgs","repos_url":"https://api.github.com/users/SherSpock/repos","events_url":"https://api.github.com/users/SherSpock/events{/privacy}","received_events_url":"https://api.github.com/users/SherSpock/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-05T01:41:15Z","updated_at":"2018-04-05T18:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7051128c44785e51bcffb2cfea7e872f1563bc8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3/commits","review_comments_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3/comments","review_comment_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/3/comments","statuses_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/statuses/20cb27f5b81820b2c78a05cdfebbd676e29cb871","head":{"label":"SherSpock:master","ref":"master","sha":"20cb27f5b81820b2c78a05cdfebbd676e29cb871","user":{"login":"SherSpock","id":14241275,"avatar_url":"https://avatars3.githubusercontent.com/u/14241275?v=4","gravatar_id":"","url":"https://api.github.com/users/SherSpock","html_url":"https://github.com/SherSpock","followers_url":"https://api.github.com/users/SherSpock/followers","following_url":"https://api.github.com/users/SherSpock/following{/other_user}","gists_url":"https://api.github.com/users/SherSpock/gists{/gist_id}","starred_url":"https://api.github.com/users/SherSpock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SherSpock/subscriptions","organizations_url":"https://api.github.com/users/SherSpock/orgs","repos_url":"https://api.github.com/users/SherSpock/repos","events_url":"https://api.github.com/users/SherSpock/events{/privacy}","received_events_url":"https://api.github.com/users/SherSpock/received_events","type":"User","site_admin":false},"repo":{"id":125795668,"name":"C_Sharp_Exercise","full_name":"SherSpock/C_Sharp_Exercise","owner":{"login":"SherSpock","id":14241275,"avatar_url":"https://avatars3.githubusercontent.com/u/14241275?v=4","gravatar_id":"","url":"https://api.github.com/users/SherSpock","html_url":"https://github.com/SherSpock","followers_url":"https://api.github.com/users/SherSpock/followers","following_url":"https://api.github.com/users/SherSpock/following{/other_user}","gists_url":"https://api.github.com/users/SherSpock/gists{/gist_id}","starred_url":"https://api.github.com/users/SherSpock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SherSpock/subscriptions","organizations_url":"https://api.github.com/users/SherSpock/orgs","repos_url":"https://api.github.com/users/SherSpock/repos","events_url":"https://api.github.com/users/SherSpock/events{/privacy}","received_events_url":"https://api.github.com/users/SherSpock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SherSpock/C_Sharp_Exercise","description":null,"fork":true,"url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise","forks_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/forks","keys_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/teams","hooks_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/hooks","issue_events_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/issues/events{/number}","events_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/events","assignees_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/assignees{/user}","branches_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/branches{/branch}","tags_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/tags","blobs_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/git/refs{/sha}","trees_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/statuses/{sha}","languages_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/languages","stargazers_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/stargazers","contributors_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/contributors","subscribers_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/subscribers","subscription_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/subscription","commits_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/commits{/sha}","git_commits_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/git/commits{/sha}","comments_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/comments{/number}","issue_comment_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/issues/comments{/number}","contents_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/contents/{+path}","compare_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/merges","archive_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/downloads","issues_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/issues{/number}","pulls_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/pulls{/number}","milestones_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/milestones{/number}","notifications_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/labels{/name}","releases_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/releases{/id}","deployments_url":"https://api.github.com/repos/SherSpock/C_Sharp_Exercise/deployments","created_at":"2018-03-19T03:20:47Z","updated_at":"2018-04-05T01:36:03Z","pushed_at":"2018-04-05T01:36:02Z","git_url":"git://github.com/SherSpock/C_Sharp_Exercise.git","ssh_url":"git@github.com:SherSpock/C_Sharp_Exercise.git","clone_url":"https://github.com/SherSpock/C_Sharp_Exercise.git","svn_url":"https://github.com/SherSpock/C_Sharp_Exercise","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FutureWonder:master","ref":"master","sha":"015d7c0789a08fa64c7116f3b1851f19cc47bced","user":{"login":"FutureWonder","id":26582519,"avatar_url":"https://avatars2.githubusercontent.com/u/26582519?v=4","gravatar_id":"","url":"https://api.github.com/users/FutureWonder","html_url":"https://github.com/FutureWonder","followers_url":"https://api.github.com/users/FutureWonder/followers","following_url":"https://api.github.com/users/FutureWonder/following{/other_user}","gists_url":"https://api.github.com/users/FutureWonder/gists{/gist_id}","starred_url":"https://api.github.com/users/FutureWonder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FutureWonder/subscriptions","organizations_url":"https://api.github.com/users/FutureWonder/orgs","repos_url":"https://api.github.com/users/FutureWonder/repos","events_url":"https://api.github.com/users/FutureWonder/events{/privacy}","received_events_url":"https://api.github.com/users/FutureWonder/received_events","type":"Organization","site_admin":false},"repo":{"id":119892232,"name":"C_Sharp_Exercise","full_name":"FutureWonder/C_Sharp_Exercise","owner":{"login":"FutureWonder","id":26582519,"avatar_url":"https://avatars2.githubusercontent.com/u/26582519?v=4","gravatar_id":"","url":"https://api.github.com/users/FutureWonder","html_url":"https://github.com/FutureWonder","followers_url":"https://api.github.com/users/FutureWonder/followers","following_url":"https://api.github.com/users/FutureWonder/following{/other_user}","gists_url":"https://api.github.com/users/FutureWonder/gists{/gist_id}","starred_url":"https://api.github.com/users/FutureWonder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FutureWonder/subscriptions","organizations_url":"https://api.github.com/users/FutureWonder/orgs","repos_url":"https://api.github.com/users/FutureWonder/repos","events_url":"https://api.github.com/users/FutureWonder/events{/privacy}","received_events_url":"https://api.github.com/users/FutureWonder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FutureWonder/C_Sharp_Exercise","description":null,"fork":false,"url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise","forks_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/forks","keys_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/teams","hooks_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/hooks","issue_events_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/events{/number}","events_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/events","assignees_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/assignees{/user}","branches_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/branches{/branch}","tags_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/tags","blobs_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/git/refs{/sha}","trees_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/statuses/{sha}","languages_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/languages","stargazers_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/stargazers","contributors_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/contributors","subscribers_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/subscribers","subscription_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/subscription","commits_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/commits{/sha}","git_commits_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/git/commits{/sha}","comments_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/comments{/number}","issue_comment_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/comments{/number}","contents_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/contents/{+path}","compare_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/merges","archive_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/downloads","issues_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues{/number}","pulls_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls{/number}","milestones_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/milestones{/number}","notifications_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/labels{/name}","releases_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/releases{/id}","deployments_url":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/deployments","created_at":"2018-02-01T20:52:41Z","updated_at":"2018-03-13T14:32:44Z","pushed_at":"2018-04-05T01:41:15Z","git_url":"git://github.com/FutureWonder/C_Sharp_Exercise.git","ssh_url":"git@github.com:FutureWonder/C_Sharp_Exercise.git","clone_url":"https://github.com/FutureWonder/C_Sharp_Exercise.git","svn_url":"https://github.com/FutureWonder/C_Sharp_Exercise","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3"},"html":{"href":"https://github.com/FutureWonder/C_Sharp_Exercise/pull/3"},"issue":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/3"},"comments":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/FutureWonder/C_Sharp_Exercise/statuses/20cb27f5b81820b2c78a05cdfebbd676e29cb871"}},"author_association":"NONE"}}
{"actor":{"display_login":"Chase-R"}}