{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/8715","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/8715/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/8715/comments","events_url":"https://api.github.com/repos/helm/charts/issues/8715/events","html_url":"https://github.com/helm/charts/pull/8715","id":373706530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTczNzY4","number":8715,"title":"[stable/kafka-manager]: add Kafka Manager chart","user":{"login":"giacomoguiulfo","id":22091600,"node_id":"MDQ6VXNlcjIyMDkxNjAw","avatar_url":"https://avatars1.githubusercontent.com/u/22091600?v=4","gravatar_id":"","url":"https://api.github.com/users/giacomoguiulfo","html_url":"https://github.com/giacomoguiulfo","followers_url":"https://api.github.com/users/giacomoguiulfo/followers","following_url":"https://api.github.com/users/giacomoguiulfo/following{/other_user}","gists_url":"https://api.github.com/users/giacomoguiulfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giacomoguiulfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giacomoguiulfo/subscriptions","organizations_url":"https://api.github.com/users/giacomoguiulfo/orgs","repos_url":"https://api.github.com/users/giacomoguiulfo/repos","events_url":"https://api.github.com/users/giacomoguiulfo/events{/privacy}","received_events_url":"https://api.github.com/users/giacomoguiulfo/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":678010043,"node_id":"MDU6TGFiZWw2NzgwMTAwNDM=","url":"https://api.github.com/repos/helm/charts/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-10-24T22:46:14Z","updated_at":"2018-11-13T12:07:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/8715","html_url":"https://github.com/helm/charts/pull/8715","diff_url":"https://github.com/helm/charts/pull/8715.diff","patch_url":"https://github.com/helm/charts/pull/8715.patch"},"body":"Signed-off-by: Giacomo Guiulfo <giacomoguiulfo@gmail.com>\r\n\r\n<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n#### What this PR does / why we need it:\r\n\r\nThis adds the Kafka Manager chart. It's is based on #2917 and [this](https://github.com/MacTynow/kafka-manager-chart), but includes several enhancements, such as:\r\n- The new image supports newer versions of Kafka (like 1.0.0+)\r\n- Service Accounts.\r\n- Highly customizable automatic cluster feeding through the API.\r\n- Enhanced liveness/readiness probes.\r\n- Documented values in the `README.md`.\r\n- **Optional** Zookeeper dependency for the setup. \r\n- And some other small chores...\r\n\r\n#### Special notes for your reviewer:\r\n\r\nAs I mentioned, this PR is similar to #2917. But I still decided to open a different one since that other one has gone stale and doesn't include as many features.\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/438243538","html_url":"https://github.com/helm/charts/pull/8715#issuecomment-438243538","issue_url":"https://api.github.com/repos/helm/charts/issues/8715","id":438243538,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODI0MzUzOA==","user":{"login":"maver1ck","id":4006010,"node_id":"MDQ6VXNlcjQwMDYwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4006010?v=4","gravatar_id":"","url":"https://api.github.com/users/maver1ck","html_url":"https://github.com/maver1ck","followers_url":"https://api.github.com/users/maver1ck/followers","following_url":"https://api.github.com/users/maver1ck/following{/other_user}","gists_url":"https://api.github.com/users/maver1ck/gists{/gist_id}","starred_url":"https://api.github.com/users/maver1ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maver1ck/subscriptions","organizations_url":"https://api.github.com/users/maver1ck/orgs","repos_url":"https://api.github.com/users/maver1ck/repos","events_url":"https://api.github.com/users/maver1ck/events{/privacy}","received_events_url":"https://api.github.com/users/maver1ck/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T12:07:25Z","updated_at":"2018-11-13T12:07:25Z","author_association":"COLLABORATOR","body":"@giacomoguiulfo \r\nOne more problem\r\n```\r\n+ curl http://kafka-manager-kafka-manager:9000/clusters -X POST -d name=default -d zkHosts=kafka-cp-zookeeper:2181 -d kafkaVersion=1.1.0 -d jmxEnabled=true -d jmxUser= -d jmxPass= -d jmxSsl=false -d logkafkaEnabled=false -d pollConsumers=true -d filterConsumers=false -d activeOffsetCacheEnabled=false -d displaySizeEnabled=false -d tuning.brokerViewUpdatePeriodSeconds=30 -d tuning.clusterManagerThreadPoolSize=2 -d tuning.clusterManagerThreadPoolQueueSize=100 -d tuning.kafkaCommandThreadPoolSize=2 -d tuning.kafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaCommandThreadPoolSize=2 -d tuning.logkafkaCommandThreadPoolQueueSize=100 -d tuning.logkafkaUpdatePeriodSeconds=30 -d tuning.partitionOffsetCacheTimeoutSecs=5 -d tuning.brokerViewThreadPoolSize=4 -d tuning.brokerViewThreadPoolQueueSize=1000 -d tuning.offsetCacheThreadPoolSize=4 -d tuning.offsetCacheThreadPoolQueueSize=1000 -d tuning.kafkaAdminClientThreadPoolSize=4 -d tuning.kafkaAdminClientThreadPoolQueueSize=1000 -d tuning.kafkaManagedOffsetMetadataCheckMillis=30000 -d tuning.kafkaManagedOffsetGroupCacheSize=1000000 -d tuning.kafkaManagedOffsetGroupExpireDays=7 -d securityProtocol=PLAINTEXT\r\n/usr/local/script/addClusters.sh: line 4: curl: command not found\r\n```"}}
{"actor":{"display_login":"maver1ck"}}