{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/6575","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/6575/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/6575/comments","events_url":"https://api.github.com/repos/istio/istio/issues/6575/events","html_url":"https://github.com/istio/istio/pull/6575","id":335082404,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODkwNjM3","number":6575,"title":"Enable summaries and filtering of Envoy side proxy-config retrieval","user":{"login":"liamawhite","id":14291598,"node_id":"MDQ6VXNlcjE0MjkxNTk4","avatar_url":"https://avatars3.githubusercontent.com/u/14291598?v=4","gravatar_id":"","url":"https://api.github.com/users/liamawhite","html_url":"https://github.com/liamawhite","followers_url":"https://api.github.com/users/liamawhite/followers","following_url":"https://api.github.com/users/liamawhite/following{/other_user}","gists_url":"https://api.github.com/users/liamawhite/gists{/gist_id}","starred_url":"https://api.github.com/users/liamawhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamawhite/subscriptions","organizations_url":"https://api.github.com/users/liamawhite/orgs","repos_url":"https://api.github.com/users/liamawhite/repos","events_url":"https://api.github.com/users/liamawhite/events{/privacy}","received_events_url":"https://api.github.com/users/liamawhite/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"assignees":[{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-23T08:47:55Z","updated_at":"2018-06-26T16:00:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6575","html_url":"https://github.com/istio/istio/pull/6575","diff_url":"https://github.com/istio/istio/pull/6575.diff","patch_url":"https://github.com/istio/istio/pull/6575.patch"},"body":"This PR completes the first stage of proxy-config work and sets a base for us to iterate on further down the line. \r\n\r\nUnfortunately, it will temporarily turn off retrieval of pilot side information but I will be turning that back on with a separate PR soon and you can identify any Pilot<->Envoy sync issues using `istioctl proxy-status`. The reason for this is that this PR is already almost 2000 lines long. I'm happy for this PR to stay open until the pilot side command PR is also open if this is deemed necessary.\r\n\r\nThe commands are as follows:\r\n\r\n```\r\nliams-mbp:istio liam$ i proxy-config -h\r\nA group of commands used to retrieve information about proxy configuration from the Envoy config dump\r\n\r\nUsage:\r\n  istioctl proxy-config [command]\r\n\r\nAliases:\r\n  proxy-config, pc\r\n\r\nExamples:\r\n  # Retrieve information about proxy configuration from an Envoy instance.\r\n  istioctl proxy-config <clusters|listeners|routes|bootstap> <pod-name>\r\n\r\nAvailable Commands:\r\n  bootstrap   Retrieves bootstrap configuration for the Envoy in the specified pod\r\n  cluster     Retrieves cluster configuration for the Envoy in the specified pod\r\n  listener    Retrieves listener configuration for the Envoy in the specified pod\r\n  route       Retrieves route configuration for the Envoy in the specified pod\r\n\r\nFlags:\r\n  -h, --help            help for proxy-config\r\n  -o, --output string   Output format: one of json|short (default \"short\")\r\n```\r\n```\r\nliams-mbp:istio liam$ i proxy-config clusters -h\r\nRetrieve information about cluster configuration for the Envoy instance in the specified pod.\r\n\r\nUsage:\r\n  istioctl proxy-config cluster <pod-name> [flags]\r\n\r\nAliases:\r\n  cluster, clusters, c\r\n\r\nExamples:\r\n  # Retrieve summary about cluster configuration for a given pod from Envoy.\r\n  istioctl proxy-config clusters <pod-name>\r\n\r\n  # Retrieve cluster summary for clusters with port 9080.\r\n  istioctl proxy-config clusters <pod-name> --port 9080\r\n\r\n  # Retrieve full cluster dump for clusters that are inbound with a FQDN of details.default.svc.cluster.local.\r\n  istioctl proxy-config clusters <pod-name> --fqdn details.default.svc.cluster.local --direction inbound -o json\r\n\r\n\r\nFlags:\r\n      --direction string   Filter clusters by Direction field\r\n      --fqdn string        Filter clusters by substring of Service FQDN field\r\n  -h, --help               help for cluster\r\n      --port int           Filter clusters by Port field\r\n      --subset string      Filter clusters by subtring of Subset field\r\n```\r\n```\r\nliams-mbp:istio liam$ i proxy-config listeners -h\r\nRetrieve information about listener configuration for the Envoy instance in the specified pod.\r\n\r\nUsage:\r\n  istioctl proxy-config listener <pod-name> [flags]\r\n\r\nAliases:\r\n  listener, listeners, l\r\n\r\nExamples:\r\n  # Retrieve summary about listener configuration for a given pod from Envoy.\r\n  istioctl proxy-config listeners <pod-name>\r\n\r\n  # Retrieve listener summary for listeners with port 9080.\r\n  istioctl proxy-config listeners <pod-name> --port 9080\r\n\r\n  # Retrieve full listener dump for HTTP listeners with a wildcard address (0.0.0.0).\r\n  istioctl proxy-config listeners <pod-name> --type HTTP --address 0.0.0.0 -o json\r\n\r\n\r\nFlags:\r\n      --address string   Filter listeners by address field\r\n  -h, --help             help for listener\r\n      --port int         Filter listeners by Port field\r\n      --type string      Filter listeners by type field\r\n```\r\n```\r\nliams-mbp:istio liam$ i proxy-config routes -h\r\nRetrieve information about route configuration for the Envoy instance in the specified pod.\r\n\r\nUsage:\r\n  istioctl proxy-config route <pod-name> [flags]\r\n\r\nAliases:\r\n  route, routes, r\r\n\r\nExamples:\r\n  # Retrieve summary about route configuration for a given pod from Envoy.\r\n  istioctl proxy-config routes <pod-name>\r\n\r\n  # Retrieve route summary for route 9080.\r\n  istioctl proxy-config route <pod-name> --name 9080\r\n\r\n  # Retrieve full route dump for route 9080\r\n  istioctl proxy-config route <pod-name> --name 9080 -o json\r\n\r\n\r\nFlags:\r\n  -h, --help          help for route\r\n      --name string   Filter listeners by route name field\r\n```\r\n```\r\nliams-mbp:istio liam$ i proxy-config bootstrap -h\r\nRetrieve information about bootstrap configuration for the Envoy instance in the specified pod.\r\n\r\nUsage:\r\n  istioctl proxy-config bootstrap <pod-name> [flags]\r\n\r\nAliases:\r\n  bootstrap, b\r\n\r\nExamples:\r\n  # Retrieve full bootstrap configuration for a given pod from Envoy.\r\n  istioctl proxy-config endpoint bootstrap <pod-name>\r\n```"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/400365907","html_url":"https://github.com/istio/istio/pull/6575#issuecomment-400365907","issue_url":"https://api.github.com/repos/istio/istio/issues/6575","id":400365907,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDM2NTkwNw==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T16:00:01Z","updated_at":"2018-06-26T16:00:01Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/6575#\" title=\"Author self-approved\">liamawhite</a>*, *<a href=\"https://github.com/istio/istio/pull/6575#pullrequestreview-132091364\" title=\"Approved\">nmittler</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **mandarjog**\n\nAssign the PR to them by writing `/assign @mandarjog` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[bin/OWNERS](https://github.com/istio/istio/blob/master/bin/OWNERS)**\n- ~~[istioctl/OWNERS](https://github.com/istio/istio/blob/master/istioctl/OWNERS)~~ [liamawhite,nmittler]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mandarjog\"]} -->"}}
{"actor":{"display_login":"istio-testing"}}