{"action":"closed","number":128,"pull_request":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128","id":182753670,"html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/128","diff_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/128.diff","patch_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/128.patch","issue_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/128","number":128,"state":"closed","locked":false,"title":"Small fixes in controller-manager manifests","user":{"login":"gonzolino","id":3019505,"avatar_url":"https://avatars1.githubusercontent.com/u/3019505?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzolino","html_url":"https://github.com/gonzolino","followers_url":"https://api.github.com/users/gonzolino/followers","following_url":"https://api.github.com/users/gonzolino/following{/other_user}","gists_url":"https://api.github.com/users/gonzolino/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzolino/subscriptions","organizations_url":"https://api.github.com/users/gonzolino/orgs","repos_url":"https://api.github.com/users/gonzolino/repos","events_url":"https://api.github.com/users/gonzolino/events{/privacy}","received_events_url":"https://api.github.com/users/gonzolino/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! -->\r\n\r\n**What this PR does / why we need it**:\r\nFix some small issues in controller-manager manifests\r\n\r\nDaemonSet manifest:\r\n- Remove double hostNetwork attribute\r\n- Set nodeSelector to only schedule pods on master nodes\r\n\r\nPod manifest:\r\n- Set correct component label","created_at":"2018-04-19T12:01:25Z","updated_at":"2018-04-25T00:48:02Z","closed_at":"2018-04-25T00:48:02Z","merged_at":"2018-04-25T00:48:02Z","merge_commit_sha":"a09914b2cb80f94699d2f8daee7449e63e8f045a","assignee":{"login":"dims","id":23304,"avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dklyle","id":2799625,"avatar_url":"https://avatars2.githubusercontent.com/u/2799625?v=4","gravatar_id":"","url":"https://api.github.com/users/dklyle","html_url":"https://github.com/dklyle","followers_url":"https://api.github.com/users/dklyle/followers","following_url":"https://api.github.com/users/dklyle/following{/other_user}","gists_url":"https://api.github.com/users/dklyle/gists{/gist_id}","starred_url":"https://api.github.com/users/dklyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dklyle/subscriptions","organizations_url":"https://api.github.com/users/dklyle/orgs","repos_url":"https://api.github.com/users/dklyle/repos","events_url":"https://api.github.com/users/dklyle/events{/privacy}","received_events_url":"https://api.github.com/users/dklyle/received_events","type":"User","site_admin":false},{"login":"edisonxiang","id":28946359,"avatar_url":"https://avatars0.githubusercontent.com/u/28946359?v=4","gravatar_id":"","url":"https://api.github.com/users/edisonxiang","html_url":"https://github.com/edisonxiang","followers_url":"https://api.github.com/users/edisonxiang/followers","following_url":"https://api.github.com/users/edisonxiang/following{/other_user}","gists_url":"https://api.github.com/users/edisonxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/edisonxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edisonxiang/subscriptions","organizations_url":"https://api.github.com/users/edisonxiang/orgs","repos_url":"https://api.github.com/users/edisonxiang/repos","events_url":"https://api.github.com/users/edisonxiang/events{/privacy}","received_events_url":"https://api.github.com/users/edisonxiang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":875380495,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":875191555,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":875381540,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":875191482,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128/commits","review_comments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128/comments","review_comment_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/128/comments","statuses_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/statuses/647c1a590db1abf1a9452215da6c1bad4c5878a0","head":{"label":"gonzolino:manifests","ref":"manifests","sha":"647c1a590db1abf1a9452215da6c1bad4c5878a0","user":{"login":"gonzolino","id":3019505,"avatar_url":"https://avatars1.githubusercontent.com/u/3019505?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzolino","html_url":"https://github.com/gonzolino","followers_url":"https://api.github.com/users/gonzolino/followers","following_url":"https://api.github.com/users/gonzolino/following{/other_user}","gists_url":"https://api.github.com/users/gonzolino/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzolino/subscriptions","organizations_url":"https://api.github.com/users/gonzolino/orgs","repos_url":"https://api.github.com/users/gonzolino/repos","events_url":"https://api.github.com/users/gonzolino/events{/privacy}","received_events_url":"https://api.github.com/users/gonzolino/received_events","type":"User","site_admin":false},"repo":{"id":126319187,"name":"cloud-provider-openstack","full_name":"gonzolino/cloud-provider-openstack","owner":{"login":"gonzolino","id":3019505,"avatar_url":"https://avatars1.githubusercontent.com/u/3019505?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzolino","html_url":"https://github.com/gonzolino","followers_url":"https://api.github.com/users/gonzolino/followers","following_url":"https://api.github.com/users/gonzolino/following{/other_user}","gists_url":"https://api.github.com/users/gonzolino/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzolino/subscriptions","organizations_url":"https://api.github.com/users/gonzolino/orgs","repos_url":"https://api.github.com/users/gonzolino/repos","events_url":"https://api.github.com/users/gonzolino/events{/privacy}","received_events_url":"https://api.github.com/users/gonzolino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gonzolino/cloud-provider-openstack","description":null,"fork":true,"url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack","forks_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/forks","keys_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/teams","hooks_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/hooks","issue_events_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/events","assignees_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/tags","blobs_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/languages","stargazers_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/stargazers","contributors_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/contributors","subscribers_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/subscribers","subscription_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/subscription","commits_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/merges","archive_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/downloads","issues_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/labels{/name}","releases_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/gonzolino/cloud-provider-openstack/deployments","created_at":"2018-03-22T10:33:23Z","updated_at":"2018-04-09T17:40:54Z","pushed_at":"2018-04-19T11:59:48Z","git_url":"git://github.com/gonzolino/cloud-provider-openstack.git","ssh_url":"git@github.com:gonzolino/cloud-provider-openstack.git","clone_url":"https://github.com/gonzolino/cloud-provider-openstack.git","svn_url":"https://github.com/gonzolino/cloud-provider-openstack","homepage":null,"size":1506,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f444646fe7ab53be9fcd54cf9bca935a9ab733c2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":126135241,"name":"cloud-provider-openstack","full_name":"kubernetes/cloud-provider-openstack","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/cloud-provider-openstack","description":null,"fork":false,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack","forks_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/forks","keys_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/teams","hooks_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/events","assignees_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/tags","blobs_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/languages","stargazers_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/subscription","commits_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/merges","archive_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/downloads","issues_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/deployments","created_at":"2018-03-21T06:46:07Z","updated_at":"2018-04-23T13:38:42Z","pushed_at":"2018-04-25T00:48:02Z","git_url":"git://github.com/kubernetes/cloud-provider-openstack.git","ssh_url":"git@github.com:kubernetes/cloud-provider-openstack.git","clone_url":"https://github.com/kubernetes/cloud-provider-openstack.git","svn_url":"https://github.com/kubernetes/cloud-provider-openstack","homepage":null,"size":1505,"stargazers_count":31,"watchers_count":31,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":36,"open_issues":35,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128"},"html":{"href":"https://github.com/kubernetes/cloud-provider-openstack/pull/128"},"issue":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/128"},"comments":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/statuses/647c1a590db1abf1a9452215da6c1bad4c5878a0"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":37,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"k8s-ci-robot"}}