{"action":"created","comment":{"url":"https://api.github.com/repos/openml/openml-python/pulls/comments/196830881","pull_request_review_id":130457670,"id":196830881,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjgzMDg4MQ==","diff_hunk":"@@ -114,7 +115,14 @@ def from_filesystem(cls, folder):\n             with open(trace_path, 'r') as fp:\n                 trace = arff.load(fp)\n                 run.trace_attributes = trace['attributes']\n-                run.trace_content = trace['data']\n+                data_tmp = trace['data']\n+                # TODO move this functionality to trace.py and serialize/deserialize the trace","path":"openml/runs/run.py","position":16,"original_position":16,"commit_id":"73c7336fbaae37467dc6a18977114c948052616b","original_commit_id":"33d6bb3cca43cb229ae5cd8ae8105af1cb7cb541","user":{"login":"janvanrijn","id":2292730,"node_id":"MDQ6VXNlcjIyOTI3MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2292730?v=4","gravatar_id":"","url":"https://api.github.com/users/janvanrijn","html_url":"https://github.com/janvanrijn","followers_url":"https://api.github.com/users/janvanrijn/followers","following_url":"https://api.github.com/users/janvanrijn/following{/other_user}","gists_url":"https://api.github.com/users/janvanrijn/gists{/gist_id}","starred_url":"https://api.github.com/users/janvanrijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvanrijn/subscriptions","organizations_url":"https://api.github.com/users/janvanrijn/orgs","repos_url":"https://api.github.com/users/janvanrijn/repos","events_url":"https://api.github.com/users/janvanrijn/events{/privacy}","received_events_url":"https://api.github.com/users/janvanrijn/received_events","type":"User","site_admin":false},"body":"I assume not, as all other columns should be float as well (the predictions per class and the 'predicted' and 'correct' class)\r\n\r\nThe thing I am mostly worried about is the 'assumptions' in the code, i.e., if we ever add one column we don't have the overview where these kind of manual patches are. Therefore I would propose to move this part to the trace file anyway (I can do this later today, if that helps)","created_at":"2018-06-20T15:37:12Z","updated_at":"2018-06-20T15:37:12Z","html_url":"https://github.com/openml/openml-python/pull/481#discussion_r196830881","pull_request_url":"https://api.github.com/repos/openml/openml-python/pulls/481","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openml/openml-python/pulls/comments/196830881"},"html":{"href":"https://github.com/openml/openml-python/pull/481#discussion_r196830881"},"pull_request":{"href":"https://api.github.com/repos/openml/openml-python/pulls/481"}},"in_reply_to_id":196799149},"pull_request":{"url":"https://api.github.com/repos/openml/openml-python/pulls/481","id":195794166,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Nzk0MTY2","html_url":"https://github.com/openml/openml-python/pull/481","diff_url":"https://github.com/openml/openml-python/pull/481.diff","patch_url":"https://github.com/openml/openml-python/pull/481.patch","issue_url":"https://api.github.com/repos/openml/openml-python/issues/481","number":481,"state":"open","locked":false,"title":"Unit test and fix for #422","user":{"login":"mfeurer","id":5320498,"node_id":"MDQ6VXNlcjUzMjA0OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5320498?v=4","gravatar_id":"","url":"https://api.github.com/users/mfeurer","html_url":"https://github.com/mfeurer","followers_url":"https://api.github.com/users/mfeurer/followers","following_url":"https://api.github.com/users/mfeurer/following{/other_user}","gists_url":"https://api.github.com/users/mfeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/mfeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfeurer/subscriptions","organizations_url":"https://api.github.com/users/mfeurer/orgs","repos_url":"https://api.github.com/users/mfeurer/repos","events_url":"https://api.github.com/users/mfeurer/events{/privacy}","received_events_url":"https://api.github.com/users/mfeurer/received_events","type":"User","site_admin":false},"body":"This PR adds a unit test for #422 which will fail with the current liac-arff release 2.2.1. Upgrading to liac-arff 2.2.2 will make the unit test work again (release is under preparation).","created_at":"2018-06-19T11:23:32Z","updated_at":"2018-06-20T15:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d5e63b52ea2456900eb6524cd1b7f33687916e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openml/openml-python/pulls/481/commits","review_comments_url":"https://api.github.com/repos/openml/openml-python/pulls/481/comments","review_comment_url":"https://api.github.com/repos/openml/openml-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openml/openml-python/issues/481/comments","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/73c7336fbaae37467dc6a18977114c948052616b","head":{"label":"openml:test#422","ref":"test#422","sha":"73c7336fbaae37467dc6a18977114c948052616b","user":{"login":"openml","id":4984562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4984562?v=4","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"repo":{"id":17939040,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzOTA0MA==","name":"openml-python","full_name":"openml/openml-python","owner":{"login":"openml","id":4984562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4984562?v=4","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openml/openml-python","description":"Python module to interface with OpenML","fork":false,"url":"https://api.github.com/repos/openml/openml-python","forks_url":"https://api.github.com/repos/openml/openml-python/forks","keys_url":"https://api.github.com/repos/openml/openml-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openml/openml-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openml/openml-python/teams","hooks_url":"https://api.github.com/repos/openml/openml-python/hooks","issue_events_url":"https://api.github.com/repos/openml/openml-python/issues/events{/number}","events_url":"https://api.github.com/repos/openml/openml-python/events","assignees_url":"https://api.github.com/repos/openml/openml-python/assignees{/user}","branches_url":"https://api.github.com/repos/openml/openml-python/branches{/branch}","tags_url":"https://api.github.com/repos/openml/openml-python/tags","blobs_url":"https://api.github.com/repos/openml/openml-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openml/openml-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openml/openml-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/openml/openml-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/{sha}","languages_url":"https://api.github.com/repos/openml/openml-python/languages","stargazers_url":"https://api.github.com/repos/openml/openml-python/stargazers","contributors_url":"https://api.github.com/repos/openml/openml-python/contributors","subscribers_url":"https://api.github.com/repos/openml/openml-python/subscribers","subscription_url":"https://api.github.com/repos/openml/openml-python/subscription","commits_url":"https://api.github.com/repos/openml/openml-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/openml/openml-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/openml/openml-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/openml/openml-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/openml/openml-python/contents/{+path}","compare_url":"https://api.github.com/repos/openml/openml-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openml/openml-python/merges","archive_url":"https://api.github.com/repos/openml/openml-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openml/openml-python/downloads","issues_url":"https://api.github.com/repos/openml/openml-python/issues{/number}","pulls_url":"https://api.github.com/repos/openml/openml-python/pulls{/number}","milestones_url":"https://api.github.com/repos/openml/openml-python/milestones{/number}","notifications_url":"https://api.github.com/repos/openml/openml-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openml/openml-python/labels{/name}","releases_url":"https://api.github.com/repos/openml/openml-python/releases{/id}","deployments_url":"https://api.github.com/repos/openml/openml-python/deployments","created_at":"2014-03-20T10:46:41Z","updated_at":"2018-06-03T18:43:52Z","pushed_at":"2018-06-20T15:21:11Z","git_url":"git://github.com/openml/openml-python.git","ssh_url":"git@github.com:openml/openml-python.git","clone_url":"https://github.com/openml/openml-python.git","svn_url":"https://github.com/openml/openml-python","homepage":null,"size":5592,"stargazers_count":98,"watchers_count":98,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":72,"watchers":98,"default_branch":"master"}},"base":{"label":"openml:develop","ref":"develop","sha":"666d4c78e96cb85a4c1e1074817ef835d6ca4e37","user":{"login":"openml","id":4984562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4984562?v=4","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"repo":{"id":17939040,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzOTA0MA==","name":"openml-python","full_name":"openml/openml-python","owner":{"login":"openml","id":4984562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4984562?v=4","gravatar_id":"","url":"https://api.github.com/users/openml","html_url":"https://github.com/openml","followers_url":"https://api.github.com/users/openml/followers","following_url":"https://api.github.com/users/openml/following{/other_user}","gists_url":"https://api.github.com/users/openml/gists{/gist_id}","starred_url":"https://api.github.com/users/openml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openml/subscriptions","organizations_url":"https://api.github.com/users/openml/orgs","repos_url":"https://api.github.com/users/openml/repos","events_url":"https://api.github.com/users/openml/events{/privacy}","received_events_url":"https://api.github.com/users/openml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openml/openml-python","description":"Python module to interface with OpenML","fork":false,"url":"https://api.github.com/repos/openml/openml-python","forks_url":"https://api.github.com/repos/openml/openml-python/forks","keys_url":"https://api.github.com/repos/openml/openml-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openml/openml-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openml/openml-python/teams","hooks_url":"https://api.github.com/repos/openml/openml-python/hooks","issue_events_url":"https://api.github.com/repos/openml/openml-python/issues/events{/number}","events_url":"https://api.github.com/repos/openml/openml-python/events","assignees_url":"https://api.github.com/repos/openml/openml-python/assignees{/user}","branches_url":"https://api.github.com/repos/openml/openml-python/branches{/branch}","tags_url":"https://api.github.com/repos/openml/openml-python/tags","blobs_url":"https://api.github.com/repos/openml/openml-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openml/openml-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openml/openml-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/openml/openml-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openml/openml-python/statuses/{sha}","languages_url":"https://api.github.com/repos/openml/openml-python/languages","stargazers_url":"https://api.github.com/repos/openml/openml-python/stargazers","contributors_url":"https://api.github.com/repos/openml/openml-python/contributors","subscribers_url":"https://api.github.com/repos/openml/openml-python/subscribers","subscription_url":"https://api.github.com/repos/openml/openml-python/subscription","commits_url":"https://api.github.com/repos/openml/openml-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/openml/openml-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/openml/openml-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/openml/openml-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/openml/openml-python/contents/{+path}","compare_url":"https://api.github.com/repos/openml/openml-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openml/openml-python/merges","archive_url":"https://api.github.com/repos/openml/openml-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openml/openml-python/downloads","issues_url":"https://api.github.com/repos/openml/openml-python/issues{/number}","pulls_url":"https://api.github.com/repos/openml/openml-python/pulls{/number}","milestones_url":"https://api.github.com/repos/openml/openml-python/milestones{/number}","notifications_url":"https://api.github.com/repos/openml/openml-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openml/openml-python/labels{/name}","releases_url":"https://api.github.com/repos/openml/openml-python/releases{/id}","deployments_url":"https://api.github.com/repos/openml/openml-python/deployments","created_at":"2014-03-20T10:46:41Z","updated_at":"2018-06-03T18:43:52Z","pushed_at":"2018-06-20T15:21:11Z","git_url":"git://github.com/openml/openml-python.git","ssh_url":"git@github.com:openml/openml-python.git","clone_url":"https://github.com/openml/openml-python.git","svn_url":"https://github.com/openml/openml-python","homepage":null,"size":5592,"stargazers_count":98,"watchers_count":98,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":72,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openml/openml-python/pulls/481"},"html":{"href":"https://github.com/openml/openml-python/pull/481"},"issue":{"href":"https://api.github.com/repos/openml/openml-python/issues/481"},"comments":{"href":"https://api.github.com/repos/openml/openml-python/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/openml/openml-python/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/openml/openml-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openml/openml-python/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/openml/openml-python/statuses/73c7336fbaae37467dc6a18977114c948052616b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janvanrijn"}}