{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/comments/228784126","pull_request_review_id":169131526,"id":228784126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc4NDEyNg==","diff_hunk":"@@ -241,11 +241,17 @@ def _map_fn(item):\n     map(_map_fn, podsJsonObject[\"items\"])\n \n \n-def collect_healthz(gauge, histogram, service_name, address, port, url):\n+def collect_healthz(gauge, histogram, service_name, address, port, url, tls, ca_path, bearer_path):\n     with histogram.time():\n         error = \"ok\"\n         try:\n-            error = requests.get(\"http://{}:{}{}\".format(address, port, url)).text\n+            if tls:\n+                with open(bearer_path, 'r') as bearer_file:","path":"src/watchdog/src/watchdog.py","position":null,"original_position":11,"commit_id":"b88176becfb8c2af0ef40dba988c4e697176c787","original_commit_id":"5915c248bede8a3b9bddd0de194646af359c2461","user":{"login":"YanjieGao","id":5576848,"node_id":"MDQ6VXNlcjU1NzY4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5576848?v=4","gravatar_id":"","url":"https://api.github.com/users/YanjieGao","html_url":"https://github.com/YanjieGao","followers_url":"https://api.github.com/users/YanjieGao/followers","following_url":"https://api.github.com/users/YanjieGao/following{/other_user}","gists_url":"https://api.github.com/users/YanjieGao/gists{/gist_id}","starred_url":"https://api.github.com/users/YanjieGao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanjieGao/subscriptions","organizations_url":"https://api.github.com/users/YanjieGao/orgs","repos_url":"https://api.github.com/users/YanjieGao/repos","events_url":"https://api.github.com/users/YanjieGao/events{/privacy}","received_events_url":"https://api.github.com/users/YanjieGao/received_events","type":"User","site_admin":false},"body":"pass content","created_at":"2018-10-29T02:46:32Z","updated_at":"2018-10-29T02:46:32Z","html_url":"https://github.com/Microsoft/pai/pull/1601#discussion_r228784126","pull_request_url":"https://api.github.com/repos/Microsoft/pai/pulls/1601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments/228784126"},"html":{"href":"https://github.com/Microsoft/pai/pull/1601#discussion_r228784126"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1601"}},"in_reply_to_id":228437695},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/1601","id":225965804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTY1ODA0","html_url":"https://github.com/Microsoft/pai/pull/1601","diff_url":"https://github.com/Microsoft/pai/pull/1601.diff","patch_url":"https://github.com/Microsoft/pai/pull/1601.patch","issue_url":"https://api.github.com/repos/Microsoft/pai/issues/1601","number":1601,"state":"open","locked":false,"title":"[AKS] api-server RBAC access for prometheus & watchdog","user":{"login":"YanjieGao","id":5576848,"node_id":"MDQ6VXNlcjU1NzY4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5576848?v=4","gravatar_id":"","url":"https://api.github.com/users/YanjieGao","html_url":"https://github.com/YanjieGao","followers_url":"https://api.github.com/users/YanjieGao/followers","following_url":"https://api.github.com/users/YanjieGao/following{/other_user}","gists_url":"https://api.github.com/users/YanjieGao/gists{/gist_id}","starred_url":"https://api.github.com/users/YanjieGao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanjieGao/subscriptions","organizations_url":"https://api.github.com/users/YanjieGao/orgs","repos_url":"https://api.github.com/users/YanjieGao/repos","events_url":"https://api.github.com/users/YanjieGao/events{/privacy}","received_events_url":"https://api.github.com/users/YanjieGao/received_events","type":"User","site_admin":false},"body":"As api-server over AKS need RBAC access, make prometheus & watchdog leverage service acccount of K8s to access api-server for this case.","created_at":"2018-10-26T03:29:19Z","updated_at":"2018-10-29T02:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215309c17b781249b2bd1c306637fd385e960c62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pai/pulls/1601/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pai/pulls/1601/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pai/issues/1601/comments","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/b88176becfb8c2af0ef40dba988c4e697176c787","head":{"label":"Microsoft:yanjga/aks-prometheus","ref":"yanjga/aks-prometheus","sha":"b88176becfb8c2af0ef40dba988c4e697176c787","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-28T14:10:53Z","pushed_at":"2018-10-29T02:43:58Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":11236,"stargazers_count":541,"watchers_count":541,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":142,"open_issues":117,"watchers":541,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4f23c079cc4b233a24485af01e5777a8a391ce70","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3NDExNjk=","name":"pai","full_name":"Microsoft/pai","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-10-28T14:10:53Z","pushed_at":"2018-10-29T02:43:58Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":11236,"stargazers_count":541,"watchers_count":541,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":142,"open_issues":117,"watchers":541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1601"},"html":{"href":"https://github.com/Microsoft/pai/pull/1601"},"issue":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1601"},"comments":{"href":"https://api.github.com/repos/Microsoft/pai/issues/1601/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1601/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/1601/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pai/statuses/b88176becfb8c2af0ef40dba988c4e697176c787"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"YanjieGao"}}