{"action":"created","issue":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/566","repository_url":"https://api.github.com/repos/sherpa/sherpa","labels_url":"https://api.github.com/repos/sherpa/sherpa/issues/566/labels{/name}","comments_url":"https://api.github.com/repos/sherpa/sherpa/issues/566/comments","events_url":"https://api.github.com/repos/sherpa/sherpa/issues/566/events","html_url":"https://github.com/sherpa/sherpa/issues/566","id":386570107,"node_id":"MDU6SXNzdWUzODY1NzAxMDc=","number":566,"title":"More oddities in Travis tests: build 3 tests now failing for numerical tolerances","user":{"login":"DougBurke","id":224638,"node_id":"MDQ6VXNlcjIyNDYzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/224638?v=4","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-02T15:30:35Z","updated_at":"2018-12-03T14:22:48Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"PRs that @dtnguyen2 and I have made this week-end are both failing for \"build 3\" on Travis, with the output below. The code we have written (eg in #562 I only added tests, not code) is not related to these tests, and we can see that it appears to be a tolerance issue.\r\n\r\nHowever, it only appears to be this run - other runs don't show the issue. I know that the XSPEC models in this version can over-write memory, so maybe there's some bizarre thing going on there. Or it's some other part of the system that has changed. One option is to remove this build, as we don't really support XSPEC 12.9.0 anymore.\r\n\r\n```\r\n================================== FAILURES ===================================\r\n___________________________ test_threads.test_histo ____________________________\r\nself = <test_astro.test_threads testMethod=test_histo>\r\n    @requires_fits\r\n    def test_histo(self):\r\n        self.run_thread('histo')\r\n        assert ui.get_fit_results().statval == approx(14.7264, rel=1e-4)\r\n        assert self.locals['g1'].fwhm.val == approx(0.0232473, rel=1e-4)\r\n        assert self.locals['g1'].pos.val == approx(1.26713, rel=1e-4)\r\n>       assert self.locals['g1'].ampl.val == approx(40.4503, rel=1e-4)\r\nE       AssertionError: assert 40.4514347531601 == 40.4503 +- 4.0e-03\r\nE        +  where 40.4514347531601 = <Parameter 'ampl' of model 'g1'>.val\r\nE        +    where <Parameter 'ampl' of model 'g1'> = <Gauss1D model instance 'g1'>.ampl\r\nE        +  and   40.4503 +- 4.0e-03 = approx(40.4503, rel=0.0001)\r\nsherpa/astro/tests/test_astro.py:418: AssertionError\r\n----------------------------- Captured stdout call -----------------------------\r\n Solar Abundance Vector set to angr:  Anders E. & Grevesse N. Geochimica et Cosmochimica Acta 53, 197 (1989)\r\n Cross Section Table set to bcmc:  Balucinska-Church and McCammon, 1998\r\n___________________________ test_threads.test_pileup ___________________________\r\nself = <test_astro.test_threads testMethod=test_pileup>\r\n    @requires_fits\r\n    @requires_xspec\r\n    def test_pileup(self):\r\n        self.run_thread('pileup')\r\n    \r\n        fr = ui.get_fit_results()\r\n        covarerr = sqrt(fr.extra_output['covar'].diagonal())\r\n>       assert covarerr[0] == approx(684.056 , rel=1e-4)\r\nE       AssertionError: assert 684.0561045288689 == 684.056 +- 6.8e-02\r\nE        +  where 684.056 +- 6.8e-02 = approx(684.056, rel=0.0001)\r\nsherpa/astro/tests/test_astro.py:219: AssertionError\r\n----------------------------- Captured stdout call -----------------------------\r\n Solar Abundance Vector set to angr:  Anders E. & Grevesse N. Geochimica et Cosmochimica Acta 53, 197 (1989)\r\n Cross Section Table set to bcmc:  Balucinska-Church and McCammon, 1998\r\n__________________________ test_threads.test_spatial ___________________________\r\nself = <test_astro.test_threads testMethod=test_spatial>\r\n    @requires_fits\r\n    def test_spatial(self):\r\n        self.run_thread('spatial')\r\n        self.assertEqualWithinTol(ui.get_fit_results().statval,\r\n                                  -59229.749441, 1e-4)\r\n        assert self.locals['g1'].fwhm.val == approx(61.5615, rel=1e-4)\r\n>       assert self.locals['g1'].xpos.val == approx(4070.45, rel=1e-4)\r\nE       AssertionError: assert 4070.4512481717043 == 4070.45 +- 4.1e-01\r\nE        +  where 4070.4512481717043 = <Parameter 'xpos' of model 'g1'>.val\r\nE        +    where <Parameter 'xpos' of model 'g1'> = <Gauss2D model instance 'g1'>.xpos\r\nE        +  and   4070.45 +- 4.1e-01 = approx(4070.45, rel=0.0001)\r\nsherpa/astro/tests/test_astro.py:201: AssertionError\r\n```"},"comment":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/comments/443726681","html_url":"https://github.com/sherpa/sherpa/issues/566#issuecomment-443726681","issue_url":"https://api.github.com/repos/sherpa/sherpa/issues/566","id":443726681,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzcyNjY4MQ==","user":{"login":"olaurino","id":5692321,"node_id":"MDQ6VXNlcjU2OTIzMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5692321?v=4","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T14:22:48Z","updated_at":"2018-12-03T14:22:48Z","author_association":"MEMBER","body":"As shown in https://travis-ci.org/olaurino/sherpa/jobs/462814929 the current master branch would fail in Travis, so as we suspected something has changed in the environment that makes those tests fail with xspec 12.9.0. I can't possibly look into it now, but there must be a difference (e.g. version of numpy or something like that) that explains the failure and that it would be good to understand even if we don't act on it."}}
{"actor":{"display_login":"olaurino"}}