{"action":"created","issue":{"url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/1","repository_url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader","labels_url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/1/comments","events_url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/1/events","html_url":"https://github.com/denniske/ngx-translate-multi-http-loader/pull/1","id":359914086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Mjk2ODcy","number":1,"title":"Deep merge","user":{"login":"nlaplante","id":141054,"node_id":"MDQ6VXNlcjE0MTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/141054?v=4","gravatar_id":"","url":"https://api.github.com/users/nlaplante","html_url":"https://github.com/nlaplante","followers_url":"https://api.github.com/users/nlaplante/followers","following_url":"https://api.github.com/users/nlaplante/following{/other_user}","gists_url":"https://api.github.com/users/nlaplante/gists{/gist_id}","starred_url":"https://api.github.com/users/nlaplante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlaplante/subscriptions","organizations_url":"https://api.github.com/users/nlaplante/orgs","repos_url":"https://api.github.com/users/nlaplante/repos","events_url":"https://api.github.com/users/nlaplante/events{/privacy}","received_events_url":"https://api.github.com/users/nlaplante/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-13T14:11:57Z","updated_at":"2018-09-17T10:06:54Z","closed_at":"2018-09-13T16:57:33Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/pulls/1","html_url":"https://github.com/denniske/ngx-translate-multi-http-loader/pull/1","diff_url":"https://github.com/denniske/ngx-translate-multi-http-loader/pull/1.diff","patch_url":"https://github.com/denniske/ngx-translate-multi-http-loader/pull/1.patch"},"body":"Currently, having the same key in multiple json files doesn't merge them together. The value from last object having a shared key will be used and will overwrite the values from the other objects under the same key.\r\n\r\nThis pull request changes this by relying on [deepmerge](https://github.com/KyleAMathews/deepmerge) to deeply merge the objects together so that the same key can exist in multiple json files.\r\n\r\nExample:\r\n\r\n#### core/en.json\r\n```javascript\r\n{\r\n  'key1': 'something',\r\n  'key2:' {\r\n    'another': 'thing'\r\n  }\r\n}\r\n```\r\n\r\n#### addons/en.json\r\n```javascript\r\n{\r\n  'key2': {\r\n    'and': 'this'\r\n  }\r\n}\r\n```\r\n\r\nwill result in:\r\n\r\n```javascript\r\n{\r\n  'key1': 'something',\r\n  'key2: {\r\n    'another': 'thing',\r\n    'and': 'this'\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/comments/421953495","html_url":"https://github.com/denniske/ngx-translate-multi-http-loader/pull/1#issuecomment-421953495","issue_url":"https://api.github.com/repos/denniske/ngx-translate-multi-http-loader/issues/1","id":421953495,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTk1MzQ5NQ==","user":{"login":"nlaplante","id":141054,"node_id":"MDQ6VXNlcjE0MTA1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/141054?v=4","gravatar_id":"","url":"https://api.github.com/users/nlaplante","html_url":"https://github.com/nlaplante","followers_url":"https://api.github.com/users/nlaplante/followers","following_url":"https://api.github.com/users/nlaplante/following{/other_user}","gists_url":"https://api.github.com/users/nlaplante/gists{/gist_id}","starred_url":"https://api.github.com/users/nlaplante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlaplante/subscriptions","organizations_url":"https://api.github.com/users/nlaplante/orgs","repos_url":"https://api.github.com/users/nlaplante/repos","events_url":"https://api.github.com/users/nlaplante/events{/privacy}","received_events_url":"https://api.github.com/users/nlaplante/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T10:06:54Z","updated_at":"2018-09-17T10:06:54Z","author_association":"NONE","body":"There seems to be some issues in package.json. First, there's no `version` tag. Additionally, the package is flagged as private (see `private: true`). I don't know if this has an effect on the issue?"}}
{"actor":{"display_login":"nlaplante"}}