{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/ci/pulls/comments/187104226","pull_request_review_id":118817397,"id":187104226,"diff_hunk":"@@ -87,6 +88,21 @@ def pushes_disabled?\n       def load_octokit_cache_stack\n         @stack ||= Faraday::RackBuilder.new do |builder|\n           builder.use(Faraday::HttpCache, serializer: Marshal, shared_cache: false)\n+          # In order to have access to SocketError and ETIMEDOUT exceptions.\n+          require \"socket\"\n+          require \"net/http\"\n+          builder.use(Faraday::Request::Retry,","path":"app/shared/models/git_repo.rb","position":15,"original_position":15,"commit_id":"9b06e3b0e2c601ea35729384fe977307c3293085","original_commit_id":"9b06e3b0e2c601ea35729384fe977307c3293085","user":{"login":"taquitos","id":1304821,"avatar_url":"https://avatars2.githubusercontent.com/u/1304821?v=4","gravatar_id":"","url":"https://api.github.com/users/taquitos","html_url":"https://github.com/taquitos","followers_url":"https://api.github.com/users/taquitos/followers","following_url":"https://api.github.com/users/taquitos/following{/other_user}","gists_url":"https://api.github.com/users/taquitos/gists{/gist_id}","starred_url":"https://api.github.com/users/taquitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taquitos/subscriptions","organizations_url":"https://api.github.com/users/taquitos/orgs","repos_url":"https://api.github.com/users/taquitos/repos","events_url":"https://api.github.com/users/taquitos/events{/privacy}","received_events_url":"https://api.github.com/users/taquitos/received_events","type":"User","site_admin":false},"body":"Instead of applying that logic here, I think we should improve the retry logic here: https://github.com/fastlane/ci/blob/master/app/shared/github_handler.rb#L36\r\n\r\nThat way we don't have multiple layers doing their own retry/backoff logic. \r\nIt's better that we have custom control over how this works in 1 single place.","created_at":"2018-05-09T16:49:16Z","updated_at":"2018-05-09T16:49:17Z","html_url":"https://github.com/fastlane/ci/pull/837#discussion_r187104226","pull_request_url":"https://api.github.com/repos/fastlane/ci/pulls/837","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments/187104226"},"html":{"href":"https://github.com/fastlane/ci/pull/837#discussion_r187104226"},"pull_request":{"href":"https://api.github.com/repos/fastlane/ci/pulls/837"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/ci/pulls/837","id":186977580,"html_url":"https://github.com/fastlane/ci/pull/837","diff_url":"https://github.com/fastlane/ci/pull/837.diff","patch_url":"https://github.com/fastlane/ci/pull/837.patch","issue_url":"https://api.github.com/repos/fastlane/ci/issues/837","number":837,"state":"open","locked":false,"title":"Use Faraday::Request::Retry to prevent crashes due to poor Internet connectivity","user":{"login":"minuscorp","id":3819883,"avatar_url":"https://avatars0.githubusercontent.com/u/3819883?v=4","gravatar_id":"","url":"https://api.github.com/users/minuscorp","html_url":"https://github.com/minuscorp","followers_url":"https://api.github.com/users/minuscorp/followers","following_url":"https://api.github.com/users/minuscorp/following{/other_user}","gists_url":"https://api.github.com/users/minuscorp/gists{/gist_id}","starred_url":"https://api.github.com/users/minuscorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuscorp/subscriptions","organizations_url":"https://api.github.com/users/minuscorp/orgs","repos_url":"https://api.github.com/users/minuscorp/repos","events_url":"https://api.github.com/users/minuscorp/events{/privacy}","received_events_url":"https://api.github.com/users/minuscorp/received_events","type":"User","site_admin":false},"body":"Fixes #798 ","created_at":"2018-05-09T16:40:52Z","updated_at":"2018-05-09T16:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c480c2957ab615345db1eb37f89320f768a774","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/ci/pulls/837/commits","review_comments_url":"https://api.github.com/repos/fastlane/ci/pulls/837/comments","review_comment_url":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/ci/issues/837/comments","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/9b06e3b0e2c601ea35729384fe977307c3293085","head":{"label":"minuscorp:retry-requests","ref":"retry-requests","sha":"9b06e3b0e2c601ea35729384fe977307c3293085","user":{"login":"minuscorp","id":3819883,"avatar_url":"https://avatars0.githubusercontent.com/u/3819883?v=4","gravatar_id":"","url":"https://api.github.com/users/minuscorp","html_url":"https://github.com/minuscorp","followers_url":"https://api.github.com/users/minuscorp/followers","following_url":"https://api.github.com/users/minuscorp/following{/other_user}","gists_url":"https://api.github.com/users/minuscorp/gists{/gist_id}","starred_url":"https://api.github.com/users/minuscorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuscorp/subscriptions","organizations_url":"https://api.github.com/users/minuscorp/orgs","repos_url":"https://api.github.com/users/minuscorp/repos","events_url":"https://api.github.com/users/minuscorp/events{/privacy}","received_events_url":"https://api.github.com/users/minuscorp/received_events","type":"User","site_admin":false},"repo":{"id":120942477,"name":"ci","full_name":"minuscorp/ci","owner":{"login":"minuscorp","id":3819883,"avatar_url":"https://avatars0.githubusercontent.com/u/3819883?v=4","gravatar_id":"","url":"https://api.github.com/users/minuscorp","html_url":"https://github.com/minuscorp","followers_url":"https://api.github.com/users/minuscorp/followers","following_url":"https://api.github.com/users/minuscorp/following{/other_user}","gists_url":"https://api.github.com/users/minuscorp/gists{/gist_id}","starred_url":"https://api.github.com/users/minuscorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuscorp/subscriptions","organizations_url":"https://api.github.com/users/minuscorp/orgs","repos_url":"https://api.github.com/users/minuscorp/repos","events_url":"https://api.github.com/users/minuscorp/events{/privacy}","received_events_url":"https://api.github.com/users/minuscorp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minuscorp/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":true,"url":"https://api.github.com/repos/minuscorp/ci","forks_url":"https://api.github.com/repos/minuscorp/ci/forks","keys_url":"https://api.github.com/repos/minuscorp/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minuscorp/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minuscorp/ci/teams","hooks_url":"https://api.github.com/repos/minuscorp/ci/hooks","issue_events_url":"https://api.github.com/repos/minuscorp/ci/issues/events{/number}","events_url":"https://api.github.com/repos/minuscorp/ci/events","assignees_url":"https://api.github.com/repos/minuscorp/ci/assignees{/user}","branches_url":"https://api.github.com/repos/minuscorp/ci/branches{/branch}","tags_url":"https://api.github.com/repos/minuscorp/ci/tags","blobs_url":"https://api.github.com/repos/minuscorp/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minuscorp/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minuscorp/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/minuscorp/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minuscorp/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/minuscorp/ci/languages","stargazers_url":"https://api.github.com/repos/minuscorp/ci/stargazers","contributors_url":"https://api.github.com/repos/minuscorp/ci/contributors","subscribers_url":"https://api.github.com/repos/minuscorp/ci/subscribers","subscription_url":"https://api.github.com/repos/minuscorp/ci/subscription","commits_url":"https://api.github.com/repos/minuscorp/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/minuscorp/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/minuscorp/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/minuscorp/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/minuscorp/ci/contents/{+path}","compare_url":"https://api.github.com/repos/minuscorp/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minuscorp/ci/merges","archive_url":"https://api.github.com/repos/minuscorp/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minuscorp/ci/downloads","issues_url":"https://api.github.com/repos/minuscorp/ci/issues{/number}","pulls_url":"https://api.github.com/repos/minuscorp/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/minuscorp/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/minuscorp/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minuscorp/ci/labels{/name}","releases_url":"https://api.github.com/repos/minuscorp/ci/releases{/id}","deployments_url":"https://api.github.com/repos/minuscorp/ci/deployments","created_at":"2018-02-09T18:45:04Z","updated_at":"2018-05-09T16:37:53Z","pushed_at":"2018-05-09T16:40:43Z","git_url":"git://github.com/minuscorp/ci.git","ssh_url":"git@github.com:minuscorp/ci.git","clone_url":"https://github.com/minuscorp/ci.git","svn_url":"https://github.com/minuscorp/ci","homepage":"https://fastlane.tools","size":2958,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"fb1f35850e9cc088372100019f8ad683bc473900","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":114287404,"name":"ci","full_name":"fastlane/ci","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":false,"url":"https://api.github.com/repos/fastlane/ci","forks_url":"https://api.github.com/repos/fastlane/ci/forks","keys_url":"https://api.github.com/repos/fastlane/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/ci/teams","hooks_url":"https://api.github.com/repos/fastlane/ci/hooks","issue_events_url":"https://api.github.com/repos/fastlane/ci/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/ci/events","assignees_url":"https://api.github.com/repos/fastlane/ci/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/ci/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/ci/tags","blobs_url":"https://api.github.com/repos/fastlane/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/ci/languages","stargazers_url":"https://api.github.com/repos/fastlane/ci/stargazers","contributors_url":"https://api.github.com/repos/fastlane/ci/contributors","subscribers_url":"https://api.github.com/repos/fastlane/ci/subscribers","subscription_url":"https://api.github.com/repos/fastlane/ci/subscription","commits_url":"https://api.github.com/repos/fastlane/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/ci/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/ci/merges","archive_url":"https://api.github.com/repos/fastlane/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/ci/downloads","issues_url":"https://api.github.com/repos/fastlane/ci/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/ci/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/ci/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/ci/deployments","created_at":"2017-12-14T19:17:22Z","updated_at":"2018-05-09T16:37:50Z","pushed_at":"2018-05-09T16:40:53Z","git_url":"git://github.com/fastlane/ci.git","ssh_url":"git@github.com:fastlane/ci.git","clone_url":"https://github.com/fastlane/ci.git","svn_url":"https://github.com/fastlane/ci","homepage":"https://fastlane.tools","size":2801,"stargazers_count":1917,"watchers_count":1917,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":65,"open_issues":104,"watchers":1917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/837"},"html":{"href":"https://github.com/fastlane/ci/pull/837"},"issue":{"href":"https://api.github.com/repos/fastlane/ci/issues/837"},"comments":{"href":"https://api.github.com/repos/fastlane/ci/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/ci/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/ci/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/ci/statuses/9b06e3b0e2c601ea35729384fe977307c3293085"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"taquitos"}}