{"action":"created","issue":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/3233","repository_url":"https://api.github.com/repos/wesnoth/wesnoth","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/3233/labels{/name}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/3233/comments","events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/3233/events","html_url":"https://github.com/wesnoth/wesnoth/pull/3233","id":331005541,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODQ4MzUy","number":3233,"title":"Don't interrupt the event after a WML error","user":{"login":"CelticMinstrel","id":578731,"node_id":"MDQ6VXNlcjU3ODczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wesnoth/wesnoth/milestones/9","html_url":"https://github.com/wesnoth/wesnoth/milestone/9","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones/9/labels","id":2570871,"node_id":"MDk6TWlsZXN0b25lMjU3MDg3MQ==","number":9,"title":"1.15.0","description":"","creator":{"login":"Vultraz","id":3558659,"node_id":"MDQ6VXNlcjM1NTg2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3558659?v=4","gravatar_id":"","url":"https://api.github.com/users/Vultraz","html_url":"https://github.com/Vultraz","followers_url":"https://api.github.com/users/Vultraz/followers","following_url":"https://api.github.com/users/Vultraz/following{/other_user}","gists_url":"https://api.github.com/users/Vultraz/gists{/gist_id}","starred_url":"https://api.github.com/users/Vultraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vultraz/subscriptions","organizations_url":"https://api.github.com/users/Vultraz/orgs","repos_url":"https://api.github.com/users/Vultraz/repos","events_url":"https://api.github.com/users/Vultraz/events{/privacy}","received_events_url":"https://api.github.com/users/Vultraz/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":18,"state":"open","created_at":"2017-06-08T05:58:07Z","updated_at":"2018-10-24T02:27:20Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-06-10T21:49:39Z","updated_at":"2018-10-24T03:02:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/3233","html_url":"https://github.com/wesnoth/wesnoth/pull/3233","diff_url":"https://github.com/wesnoth/wesnoth/pull/3233.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/3233.patch"},"body":"People have been complaining recently about how events are interrupted if a Lua error occurs, leaving the game in an unexpected state. This patch works around that by calling WML tags in a protected context, allowing the game to continue executing the event even if a single tag fails. While it would still be possible to end up in an unexpected state (for example if a tag was misspelled or a variable is missing in insert_tag), this should at least greatly reduce the chances.\r\n\r\nOf course, this also risks the game trying to execute things that depended on earlier things that were skipped due to an error, but... that's probably less undesirable than wholesale dropping the event.\r\n\r\nI'm not sure whether this should go into 1.14 (but I've opened the PR against 1.14 because that's where I worked it out). If it's decided to put it only in master, this will have to be merged (or rather, cherry-picked) manually."},"comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/432495356","html_url":"https://github.com/wesnoth/wesnoth/pull/3233#issuecomment-432495356","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/3233","id":432495356,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ5NTM1Ng==","user":{"login":"CelticMinstrel","id":578731,"node_id":"MDQ6VXNlcjU3ODczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T03:02:05Z","updated_at":"2018-10-24T03:02:05Z","author_association":"MEMBER","body":"Of the seven branches I just force-pushed, this is probably the only one that is definitely in a mergeable state, so if this change is desirable, feel free to merge anytime."}}
{"actor":{"display_login":"CelticMinstrel"}}