{"action":"opened","issue":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5822","repository_url":"https://api.github.com/repos/jupyterlab/jupyterlab","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5822/labels{/name}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5822/comments","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5822/events","html_url":"https://github.com/jupyterlab/jupyterlab/issues/5822","id":395039863,"node_id":"MDU6SXNzdWUzOTUwMzk4NjM=","number":5822,"title":"Can't set icon for launcher if it isn't in category 'Notebooks'","user":{"login":"yuvipanda","id":30430,"node_id":"MDQ6VXNlcjMwNDMw","avatar_url":"https://avatars2.githubusercontent.com/u/30430?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-31T22:59:11Z","updated_at":"2018-12-31T22:59:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I'm trying to add launcher entries (for launching RStudio / Shiny / etc) into the JupyterLab launcher. \r\n\r\nIf I do:\r\n\r\n```\r\n      launcher.add({\r\n        command: commandId,\r\n        // This is the only way to get icon URLs in here\r\n        category: 'External Applications',\r\n        kernelIconUrl: 'http://words.yuvi.in/profile.jpg'\r\n      })\r\n```\r\n\r\nI don't get a launcher icon - just blank space.\r\n\r\nIf I do:\r\n\r\n```\r\n      launcher.add({\r\n        command: commandId,\r\n        // This is the only way to get icon URLs in here\r\n        category: 'Notebook',\r\n        kernelIconUrl: 'http://words.yuvi.in/profile.jpg'\r\n      })\r\n```\r\n\r\nI do get a launcher icon. It looks like [the code](https://github.com/jupyterlab/jupyterlab/blob/2e8b715420adc683a4db2304b2de9885e4fd87c0/packages/launcher/src/index.tsx#L395) is checking if the launcher is a 'kernel' by seeing if it is in the Notebook / Console category and honoring kernelIconUrl only then? "}}
{"actor":{"display_login":"yuvipanda"}}