{"push_id":2522918499,"size":336,"distinct_size":1,"ref":"refs/heads/k8s-prod","head":"ce4e22cdfadcf65f5c0df03c61921a8113973bbb","before":"9228a1e7eec79f4026bb11f946b2bcad0b343239","commits":[{"sha":"766721a916128a212621763db123d24cbb7ad26e","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Add dynamic MakeExpr\n\nThe normalizing factory currently has a DynamicConstruct method used to\nconstruct an operator when its type isn't statically known. This PR adds\na similar method for constructing \"raw\" Exprs. The new MakeExpr method\ntakes an operator type + dynamic operands, and dispatches to the\ncorresponding MakeXXXExpr method to create the expression.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/766721a916128a212621763db123d24cbb7ad26e"},{"sha":"735c060313fc9bebf860e75dda97216513f89473","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"distsqlrun: add SetBytes to distsql benchmarks\n\nAnd fix the ones for hash and merge joiner, which were halving the\nactual input size.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/735c060313fc9bebf860e75dda97216513f89473"},{"sha":"c3b12f371d0aa860531fd2696e052f63597de815","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Fix flaky test\n\nUpdate the TestNoMallocs to use the SucceedsSoon method in order\nto repeatedly retry until zero memory allocations are detected.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/c3b12f371d0aa860531fd2696e052f63597de815"},{"sha":"592f757ee2e86022b40ec1b1b4c68d9ff910b33e","author":{"name":"Andrei Matei","email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com"},"message":"distsqlrun: remove unnecessary uglifying of errors in tableReader\n\nI assume this was left over from when tableReader and scrubTableReader\nwere sharing that code.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/592f757ee2e86022b40ec1b1b4c68d9ff910b33e"},{"sha":"e7be480ed4729613e9ed49fb21b0306040334982","author":{"name":"Alex Robinson","email":"e522668276737e0807508286ee469559f9379f53@gmail.com"},"message":"cli: Fix number of args expected by `debug gossip-values`\n\nFixes #24751\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/e7be480ed4729613e9ed49fb21b0306040334982"},{"sha":"b1fa0c30903b3935c43ecb2a1a5a0b421eff3148","author":{"name":"Alfonso Subiotto Marqués","email":"c90d2c47658527c7269e392e5667d767d36be1af@cockroachlabs.com"},"message":"distsql: add InputStatCollector to collect simple input stats\n\nWill be used by processors in future commits. Currently only counts the\nnumber of rows read but will be extended.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/b1fa0c30903b3935c43ecb2a1a5a0b421eff3148"},{"sha":"6015b7966baabab8e211627db9b9f3c215e53f05","author":{"name":"Alfonso Subiotto Marqués","email":"c90d2c47658527c7269e392e5667d767d36be1af@cockroachlabs.com"},"message":"distsql: collect tableReader stats and output to trace\n\nJust number of rows read for now. This information is only collected and\noutput if the tracing span is recording.\n\nPart of work for #19476\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/6015b7966baabab8e211627db9b9f3c215e53f05"},{"sha":"a4c0974a15befe489c6dcf42d6d8643d973bd62d","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24529 #24715 #24752\n\n24529: distsql: collect tableReader stats and output to trace r=asubiotto a=asubiotto\n\nThis PR is split into two commits. The first commit lays the groundwork for stat collection code. The stats are modeled as a proto to be sent over the wire in the future (we will be sending these stats as metadata). The second commit modifies the tableReader to use this InputStatCollector to count the number of rows it reads. Example usage:\r\n\r\n```\r\nroot@:26257/> SELECT COUNT(*) FROM test.xyz;\r\n+-------+\r\n| count |\r\n+-------+\r\n|     7 |\r\n+-------+\r\n(1 row)\r\n\r\nTime: 257.249037ms\r\n\r\nroot@:26257/> SET tracing = ON;\r\nSET\r\n\r\nTime: 362.575µs\r\n\r\nroot@:26257/> SELECT x,y,z FROM test.xyz ORDER BY x;\r\n+---+---+------+\r\n| x | y |  z   |\r\n+---+---+------+\r\n| 1 | 1 | NULL |\r\n| 1 | 1 |    2 |\r\n| 1 | 1 |    2 |\r\n| 1 | 2 |    1 |\r\n| 2 | 2 |    3 |\r\n| 4 | 5 |    6 |\r\n| 4 | 1 |    6 |\r\n+---+---+------+\r\n(7 rows)\r\n\r\nTime: 207.334037ms\r\n\r\nroot@:26257/> SHOW TRACE FOR SESSION;\r\n\r\n... rest of trace elided ...\r\n\r\n| 2018-04-05 20:53:01.571467+00:00 | 21s794ms540µs951ns | waiting for read lock                                                    | [n1,s1,r23/1:/Table/5{2-3}]                                |     | /cockroach.roachpb.Internal/Batch |   13 |\r\n| 2018-04-05 20:53:01.777272+00:00 | 22s345µs429ns      | read completed                                                           | [n1,s1,r23/1:/Table/5{2-3}]                                |     | /cockroach.roachpb.Internal/Batch |   13 |\r\n| 2018-04-05 20:53:01.777435+00:00 | 22s508µs797ns      | stat summary for tableReader input                                       | [client=[::1]:64047,user=root,n1,TableReader]              |     | table reader                      |   11 |\r\n|                                  |                    |                                                                          |                                                            |     |                                   |      |\r\n|                                  |                    |  rows read         7                                                     |                                                            |     |                                   |      |\r\n\r\n... rest of trace elided ...\r\n```\r\nAnd then through jaeger:\r\n<img width=\"1427\" alt=\"screen shot 2018-04-05 at 4 53 55 pm\" src=\"https://user-images.githubusercontent.com/10560359/38392141-740ae6d8-38f4-11e8-9406-2c167142eba6.png\">\r\n\r\nNote that we can't currently run `SHOW TRACE FOR <QUERY>` in distsql mode, which I hope to fix soon (https://github.com/cockroachdb/cockroach/issues/16562)\r\n\r\nAny suggestions to improve the output welcome.\r\n\r\ncc @knz @jordanlewis \n\n24715: opt: Fix flaky test r=andy-kimball a=andy-kimball\n\nUpdate the TestNoMallocs to use the SucceedsSoon method in order\r\nto repeatedly retry until zero memory allocations are detected.\r\n\r\nRelease note: None\n\n24752: cli: Fix number of args expected by `debug gossip-values` r=a-robinson a=a-robinson\n\nFixes #24751\r\n\r\nRelease note: None\r\n\r\nIt looks like the problem is that my original usage string (`gossip-values <directory>`) was badly copied and pasted from other debug commands, and then assumed necessary by #24399 when in reality no positional argument is used by the command.\n\nCo-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>\nCo-authored-by: Andrew Kimball <andyk@cockroachlabs.com>\nCo-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/a4c0974a15befe489c6dcf42d6d8643d973bd62d"},{"sha":"fd36f3304fb3b3e6497e6d3cb1f51928ae9ed999","author":{"name":"Nathan VanBenschoten","email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com"},"message":"storage: move store snapshot logic to store_snapshot.go\n\nThere was already a lot of snapshot-specific logic in `store.go`,\nand #16954 is going to add even more. This change moves all of this\ncode to a new `store_snapshot.go` file, which makes the transmission\nand reception of snapshots more easy to understand.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/fd36f3304fb3b3e6497e6d3cb1f51928ae9ed999"},{"sha":"ee843456105185d2f725996a62fd98c595f0833c","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24711\n\n24711: opt: Add dynamic MakeExpr r=andy-kimball a=andy-kimball\n\nThe normalizing factory currently has a DynamicConstruct method used to\r\nconstruct an operator when its type isn't statically known. This PR adds\r\na similar method for constructing \"raw\" Exprs. The new MakeExpr method\r\ntakes an operator type + dynamic operands, and dispatches to the\r\ncorresponding MakeXXXExpr method to create the expression.\r\n\r\nRelease note: None\n\nCo-authored-by: Andrew Kimball <andyk@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/ee843456105185d2f725996a62fd98c595f0833c"},{"sha":"ea95d9d7d433e25b8da28675ba3ec71dd436c530","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"sql: fix the handling of current_schema and search_path\n\nPrior to this patch, CockroachDB was following the pg docs to the\nletter regarding the relationship between `search_path` and the\n\"current schema\": the current schema was taken to always be the first\nitem in `search_path`, as indicated in\nhttps://www.postgresql.org/docs/10/static/functions-info.html\n(\"current_schema returns the name of the schema that is first in the\nsearch path (or a null value if the search path is empty).\")\n\nThis in turn impacts the creation of objects (tables, views, etc) when\nthe name is unqualified: pg also specifies that such objects are to be\ncreated in the current schema.\n\nUnfortunately the pg doc is incorrect, as pg has a more nuanced\nbehavior: only the _valid_ schemas in `search_path` are considered to\ndetermine the current schema in that way.\n\nThis was causing an unfortunate visible compatibility bug: if the user\nspecified an invalid schema in the search path, subsequent create\noperations would fail with CockroachDB and succeed with pg.\n\nThis patch corrects this issue by adopting pg's behavior.\n\nDitto for `current_schemas`.\n\nRelease note (sql change, bug fix): the built-in functions\n`current_schema` and `current_schemas` now only consider valid\nschemas, like PostgreSQL does.","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/ea95d9d7d433e25b8da28675ba3ec71dd436c530"},{"sha":"5a6051c5314f3ecc0cf78704133e5b09cb41d373","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"acceptance: Remove unused pause/stop functionality\n\nThese have been unused since 2016, so it's unlikely we'll ever need\nthem.\n\nFixes #5598\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/5a6051c5314f3ecc0cf78704133e5b09cb41d373"},{"sha":"5b51eb10f21531a8c0457be598dcf93e8748917a","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24754\n\n24754: storage: move store snapshot logic to store_snapshot.go r=nvanbenschoten a=nvanbenschoten\n\nThere was already a lot of snapshot-specific logic in `store.go`,\r\nand #16954 is going to add even more. This change moves all of this\r\ncode to a new `store_snapshot.go` file, which makes the transmission\r\nand reception of snapshots more easy to understand.\r\n\r\nPure code movement.\r\n\r\nRelease note: None\n\nCo-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/5b51eb10f21531a8c0457be598dcf93e8748917a"},{"sha":"4e4180a5ab4ee653ff72ed527e72d93c9ee68d3d","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24583\n\n24583: distsqlrun: add SetBytes to distsql benchmarks r=jordanlewis a=jordanlewis\n\nAnd fix the ones for hash and merge joiner, which were halving the\r\nactual input size.\r\n\r\nRelease note: None\n\nCo-authored-by: Jordan Lewis <jordanthelewis@gmail.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/4e4180a5ab4ee653ff72ed527e72d93c9ee68d3d"},{"sha":"6eaa8070221c9afc9fd119bd955c80d9112a36ef","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24750\n\n24750: distsqlrun: remove unnecessary uglifying of errors in tableReader r=andreimatei a=andreimatei\n\nI assume this was left over from when tableReader and scrubTableReader\r\nwere sharing that code.\r\n\r\nRelease note: None\n\nCo-authored-by: Andrei Matei <andrei@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/6eaa8070221c9afc9fd119bd955c80d9112a36ef"},{"sha":"170513d2dbfdf7a793a6d483218b12052564a45a","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24718\n\n24718: sql: fix the handling of current_schema and search_path r=knz a=knz\n\nFixes #24472.\r\n\r\nPrior to this patch, CockroachDB was following the pg docs to the\r\nletter regarding the relationship between `search_path` and the\r\n\"current schema\": the current schema was taken to always be the first\r\nitem in `search_path`, as indicated in\r\nhttps://www.postgresql.org/docs/9.6/static/functions-info.html\r\n(\"current_schema returns the name of the schema that is first in the\r\nsearch path (or a null value if the search path is empty).\")\r\n\r\nThis in turn impacts the creation of objects (tables, views, etc) when\r\nthe name is unqualified: pg also specifies that such objects are to be\r\ncreated in the current schema.\r\n\r\nUnfortunately the pg doc is incorrect, as pg has a more nuanced\r\nbehavior: only the _valid_ schemas in `search_path` are considered to\r\ndetermine the current schema in that way.\r\n\r\nThis was causing an unfortunate visible compatibility bug: if the user\r\nspecified an invalid schema in the search path, subsequent create\r\noperations would fail with CockroachDB and succeed with pg.\r\n\r\nThis patch corrects this issue by adopting pg's behavior.\r\n\r\nDitto for `current_schemas`.\r\n\r\nRelease note (sql change, bug fix): the built-in functions\r\n`current_schema` and `current_schemas` now only consider valid\r\nschemas, like PostgreSQL does.\n\nCo-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/170513d2dbfdf7a793a6d483218b12052564a45a"},{"sha":"070d1b96dcbf917d55e52029608c5b6fd8f6d69a","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24757\n\n24757: acceptance: Remove unused pause/stop functionality r=petermattis a=bdarnell\n\nThese have been unused since 2016, so it's unlikely we'll ever need\r\nthem.\r\n\r\nFixes #5598\r\n\r\nRelease note: None\n\nCo-authored-by: Ben Darnell <ben@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/070d1b96dcbf917d55e52029608c5b6fd8f6d69a"},{"sha":"8ccca54f37064e6c0f6a4c670894651c1f5c6576","author":{"name":"Matt Jibson","email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com"},"message":"cli: add admin UI URL to demo message\n\nRelease note (cli change): show admin UI URL in demo message.","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/8ccca54f37064e6c0f6a4c670894651c1f5c6576"},{"sha":"277bc9b49f81f227f82617915f50bc973bd21568","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24738\n\n24738: cli: add admin UI URL to demo message r=mjibson a=mjibson\n\nRelease note (cli change): show admin UI URL in demo message.\n\nCo-authored-by: Matt Jibson <matt.jibson@gmail.com>","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/277bc9b49f81f227f82617915f50bc973bd21568"},{"sha":"b4a032eaa5893d3327ad4814921cd5f850c8d23d","author":{"name":"Matt Jibson","email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com"},"message":"sql/jobs: fix race in tests\n\nAdd a lock to prevent the race detector from triggering.\n\nIncrease the wait time so stressrace works.\n\nRelease note: None\n\nFixes #24723\nFixes #24722\nFixes #24663\nFixes #24662\nFixes #24661","distinct":false,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/b4a032eaa5893d3327ad4814921cd5f850c8d23d"}]}
{"actor":{"display_login":"a-robinson"}}