{"action":"created","comment":{"url":"https://api.github.com/repos/nearform/react-pwa/pulls/comments/196120430","pull_request_review_id":129613836,"id":196120430,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjEyMDQzMA==","diff_hunk":"@@ -21,20 +24,23 @@ const buildLinks = pathname => {\n   return {\n     currentPage,\n     prevLinkEnabled: currentPage >= 2,\n+    nextLinkEnabled: !(currentCount < PAGE_SIZE),\n     prevLink: Number.isInteger(currentPage) && currentPage > 2 ? `/${pathParts[1]}/page/${prevPage}` : `/${pathParts[1]}`,\n     nextLink: `/${pathParts[1]}/page/${nextPage}`\n   }\n }\n \n const styles = stylesheet({\n   more: {\n-    padding: `1em 0 1em 0`,\n     background: colors.LIGHTEST_GRAY,\n     textAlign: 'right',\n     gridColumnStart: '1',\n     gridColumnEnd: '4',\n     gridRowStart: '2',\n-    marginRight: '6px'\n+    padding: '1em',\n+    borderBottom: `6px solid ${colors.NEARFORM_BRAND_MAIN}`,\n+    position: 'sticky',\n+    top: '70px' // Height of the header TODO: should be shared constant","path":"src/client/js/components/More/More.jsx","position":44,"original_position":44,"commit_id":"41d9a8195cb421f5649bd58f9028b5ff9be628de","original_commit_id":"41d9a8195cb421f5649bd58f9028b5ff9be628de","user":{"login":"fromflux","id":7273523,"node_id":"MDQ6VXNlcjcyNzM1MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7273523?v=4","gravatar_id":"","url":"https://api.github.com/users/fromflux","html_url":"https://github.com/fromflux","followers_url":"https://api.github.com/users/fromflux/followers","following_url":"https://api.github.com/users/fromflux/following{/other_user}","gists_url":"https://api.github.com/users/fromflux/gists{/gist_id}","starred_url":"https://api.github.com/users/fromflux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fromflux/subscriptions","organizations_url":"https://api.github.com/users/fromflux/orgs","repos_url":"https://api.github.com/users/fromflux/repos","events_url":"https://api.github.com/users/fromflux/events{/privacy}","received_events_url":"https://api.github.com/users/fromflux/received_events","type":"User","site_admin":false},"body":"this one would require a refactor to improve clarity and separation of concerns on the global styles, theme and layout side which should be a separate issue since it is overarching enough.","created_at":"2018-06-18T15:24:45Z","updated_at":"2018-06-18T15:24:45Z","html_url":"https://github.com/nearform/react-pwa/pull/58#discussion_r196120430","pull_request_url":"https://api.github.com/repos/nearform/react-pwa/pulls/58","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/comments/196120430"},"html":{"href":"https://github.com/nearform/react-pwa/pull/58#discussion_r196120430"},"pull_request":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/58"}},"in_reply_to_id":196102288},"pull_request":{"url":"https://api.github.com/repos/nearform/react-pwa/pulls/58","id":194952234,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTUyMjM0","html_url":"https://github.com/nearform/react-pwa/pull/58","diff_url":"https://github.com/nearform/react-pwa/pull/58.diff","patch_url":"https://github.com/nearform/react-pwa/pull/58.patch","issue_url":"https://api.github.com/repos/nearform/react-pwa/issues/58","number":58,"state":"open","locked":false,"title":"Refactor page control to prevent \"next\" on list end","user":{"login":"fromflux","id":7273523,"node_id":"MDQ6VXNlcjcyNzM1MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7273523?v=4","gravatar_id":"","url":"https://api.github.com/users/fromflux","html_url":"https://github.com/fromflux","followers_url":"https://api.github.com/users/fromflux/followers","following_url":"https://api.github.com/users/fromflux/following{/other_user}","gists_url":"https://api.github.com/users/fromflux/gists{/gist_id}","starred_url":"https://api.github.com/users/fromflux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fromflux/subscriptions","organizations_url":"https://api.github.com/users/fromflux/orgs","repos_url":"https://api.github.com/users/fromflux/repos","events_url":"https://api.github.com/users/fromflux/events{/privacy}","received_events_url":"https://api.github.com/users/fromflux/received_events","type":"User","site_admin":false},"body":"Refactor page control component out of header to allow for disabling next page when list end reached.\r\n\r\ncloses #55 ","created_at":"2018-06-14T16:35:40Z","updated_at":"2018-06-18T15:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32d35d3fe6d95de0b669de8ba3a8d74aea204a8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nearform/react-pwa/pulls/58/commits","review_comments_url":"https://api.github.com/repos/nearform/react-pwa/pulls/58/comments","review_comment_url":"https://api.github.com/repos/nearform/react-pwa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nearform/react-pwa/issues/58/comments","statuses_url":"https://api.github.com/repos/nearform/react-pwa/statuses/41d9a8195cb421f5649bd58f9028b5ff9be628de","head":{"label":"nearform:prevent_next_at_last_page","ref":"prevent_next_at_last_page","sha":"41d9a8195cb421f5649bd58f9028b5ff9be628de","user":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"repo":{"id":127111706,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxMTE3MDY=","name":"react-pwa","full_name":"nearform/react-pwa","owner":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nearform/react-pwa","description":"PWA built with React","fork":false,"url":"https://api.github.com/repos/nearform/react-pwa","forks_url":"https://api.github.com/repos/nearform/react-pwa/forks","keys_url":"https://api.github.com/repos/nearform/react-pwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearform/react-pwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearform/react-pwa/teams","hooks_url":"https://api.github.com/repos/nearform/react-pwa/hooks","issue_events_url":"https://api.github.com/repos/nearform/react-pwa/issues/events{/number}","events_url":"https://api.github.com/repos/nearform/react-pwa/events","assignees_url":"https://api.github.com/repos/nearform/react-pwa/assignees{/user}","branches_url":"https://api.github.com/repos/nearform/react-pwa/branches{/branch}","tags_url":"https://api.github.com/repos/nearform/react-pwa/tags","blobs_url":"https://api.github.com/repos/nearform/react-pwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearform/react-pwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearform/react-pwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearform/react-pwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearform/react-pwa/statuses/{sha}","languages_url":"https://api.github.com/repos/nearform/react-pwa/languages","stargazers_url":"https://api.github.com/repos/nearform/react-pwa/stargazers","contributors_url":"https://api.github.com/repos/nearform/react-pwa/contributors","subscribers_url":"https://api.github.com/repos/nearform/react-pwa/subscribers","subscription_url":"https://api.github.com/repos/nearform/react-pwa/subscription","commits_url":"https://api.github.com/repos/nearform/react-pwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearform/react-pwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearform/react-pwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearform/react-pwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearform/react-pwa/contents/{+path}","compare_url":"https://api.github.com/repos/nearform/react-pwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearform/react-pwa/merges","archive_url":"https://api.github.com/repos/nearform/react-pwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearform/react-pwa/downloads","issues_url":"https://api.github.com/repos/nearform/react-pwa/issues{/number}","pulls_url":"https://api.github.com/repos/nearform/react-pwa/pulls{/number}","milestones_url":"https://api.github.com/repos/nearform/react-pwa/milestones{/number}","notifications_url":"https://api.github.com/repos/nearform/react-pwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearform/react-pwa/labels{/name}","releases_url":"https://api.github.com/repos/nearform/react-pwa/releases{/id}","deployments_url":"https://api.github.com/repos/nearform/react-pwa/deployments","created_at":"2018-03-28T08:50:18Z","updated_at":"2018-06-14T11:54:21Z","pushed_at":"2018-06-14T16:35:41Z","git_url":"git://github.com/nearform/react-pwa.git","ssh_url":"git@github.com:nearform/react-pwa.git","clone_url":"https://github.com/nearform/react-pwa.git","svn_url":"https://github.com/nearform/react-pwa","homepage":null,"size":616,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"nearform:master","ref":"master","sha":"8fc66c43d5aea7eb10b1e69d08a54f9f6286ad6c","user":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"repo":{"id":127111706,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxMTE3MDY=","name":"react-pwa","full_name":"nearform/react-pwa","owner":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nearform/react-pwa","description":"PWA built with React","fork":false,"url":"https://api.github.com/repos/nearform/react-pwa","forks_url":"https://api.github.com/repos/nearform/react-pwa/forks","keys_url":"https://api.github.com/repos/nearform/react-pwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearform/react-pwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearform/react-pwa/teams","hooks_url":"https://api.github.com/repos/nearform/react-pwa/hooks","issue_events_url":"https://api.github.com/repos/nearform/react-pwa/issues/events{/number}","events_url":"https://api.github.com/repos/nearform/react-pwa/events","assignees_url":"https://api.github.com/repos/nearform/react-pwa/assignees{/user}","branches_url":"https://api.github.com/repos/nearform/react-pwa/branches{/branch}","tags_url":"https://api.github.com/repos/nearform/react-pwa/tags","blobs_url":"https://api.github.com/repos/nearform/react-pwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearform/react-pwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearform/react-pwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearform/react-pwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearform/react-pwa/statuses/{sha}","languages_url":"https://api.github.com/repos/nearform/react-pwa/languages","stargazers_url":"https://api.github.com/repos/nearform/react-pwa/stargazers","contributors_url":"https://api.github.com/repos/nearform/react-pwa/contributors","subscribers_url":"https://api.github.com/repos/nearform/react-pwa/subscribers","subscription_url":"https://api.github.com/repos/nearform/react-pwa/subscription","commits_url":"https://api.github.com/repos/nearform/react-pwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearform/react-pwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearform/react-pwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearform/react-pwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearform/react-pwa/contents/{+path}","compare_url":"https://api.github.com/repos/nearform/react-pwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearform/react-pwa/merges","archive_url":"https://api.github.com/repos/nearform/react-pwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearform/react-pwa/downloads","issues_url":"https://api.github.com/repos/nearform/react-pwa/issues{/number}","pulls_url":"https://api.github.com/repos/nearform/react-pwa/pulls{/number}","milestones_url":"https://api.github.com/repos/nearform/react-pwa/milestones{/number}","notifications_url":"https://api.github.com/repos/nearform/react-pwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearform/react-pwa/labels{/name}","releases_url":"https://api.github.com/repos/nearform/react-pwa/releases{/id}","deployments_url":"https://api.github.com/repos/nearform/react-pwa/deployments","created_at":"2018-03-28T08:50:18Z","updated_at":"2018-06-14T11:54:21Z","pushed_at":"2018-06-14T16:35:41Z","git_url":"git://github.com/nearform/react-pwa.git","ssh_url":"git@github.com:nearform/react-pwa.git","clone_url":"https://github.com/nearform/react-pwa.git","svn_url":"https://github.com/nearform/react-pwa","homepage":null,"size":616,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/58"},"html":{"href":"https://github.com/nearform/react-pwa/pull/58"},"issue":{"href":"https://api.github.com/repos/nearform/react-pwa/issues/58"},"comments":{"href":"https://api.github.com/repos/nearform/react-pwa/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nearform/react-pwa/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/nearform/react-pwa/statuses/41d9a8195cb421f5649bd58f9028b5ff9be628de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fromflux"}}