{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/4133","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/4133/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/4133/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/4133/events","html_url":"https://github.com/triplea-game/triplea/issues/4133","id":366294103,"node_id":"MDU6SXNzdWUzNjYyOTQxMDM=","number":4133,"title":"Incorrect handling of AA-fire and/or AA-fire casualty selection","user":{"login":"panther2","id":20812775,"node_id":"MDQ6VXNlcjIwODEyNzc1","avatar_url":"https://avatars3.githubusercontent.com/u/20812775?v=4","gravatar_id":"","url":"https://api.github.com/users/panther2","html_url":"https://github.com/panther2","followers_url":"https://api.github.com/users/panther2/followers","following_url":"https://api.github.com/users/panther2/following{/other_user}","gists_url":"https://api.github.com/users/panther2/gists{/gist_id}","starred_url":"https://api.github.com/users/panther2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panther2/subscriptions","organizations_url":"https://api.github.com/users/panther2/orgs","repos_url":"https://api.github.com/users/panther2/repos","events_url":"https://api.github.com/users/panther2/events{/privacy}","received_events_url":"https://api.github.com/users/panther2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-03T11:31:49Z","updated_at":"2018-10-04T02:52:22Z","closed_at":null,"author_association":"MEMBER","body":"### Engine version\r\nirrelevant\r\n\r\n### Map name\r\n\r\nwwII_v1, v2, v3, v3, v4, v5 , wwII_\"any\" (1940)\r\n\r\n### Can you describe how to trigger the error? (eg: what sequence of actions will recreate it?)\r\n\r\nSimply create situations that lead to AA-fire and resulting casualty selection with more than one plane of every type involved.\r\n\r\nIn brief this is what is incorrect:\r\n\r\nv1: \r\n- needs to be investigated by someone more familiar with the ruleset, most likely similar to v2\r\n\r\nv2: \r\n- incorrect timing of AA fire (different rules for OOB and LHTR apply, but both versions are affected)\r\n- AA gun does not fire against groups of air units (if possible)\r\n- attacker cannot choose casualties\r\n\r\nv3:\r\n- AA gun does not fire against groups of air units (if possible)\r\n- attacker cannot choose casualties (casualty apparently is taken out on a random basis)\r\n\r\nv4:\r\n- AA gun does not fire against groups of air units (if possible)\r\n- attacker cannot choose casualties (casualty apparently is taken out on a random basis)\r\n\r\nv5:\r\n- attacker cannot choose casualties (casualty apparently is taken out on a random basis), tested with factory-built-in AA gun against a bunch of bombers)\r\n\r\nwwII_\"any\" (1940)\r\n- attacker cannot choose casualties (casualty apparently is taken out on a random basis) (see v5)\r\n\r\n### Instead of this error, what should have happened?\r\n\r\nIn general (v1-v4) AA guns should fire against group of units if possible (e.g. against fighters as a group, against bombers as a group...). The attacker should be able to select casualties among those groups.\r\nIn v5 and 1940-games the attacker should be able to choose the casualties totally free (as long as no special rules apply).\r\n\r\nIn v2 (likely v1, too) all movement has to be plotted out before any AA fire is resolved.\r\nAlso we have AA-fire during CM, Combat and NCM phases in OOB-rules while in LHTR AA-fire takes place only during Combat.\r\n\r\n### Any additional information that may help\r\n\r\nThe background, rules and clarifications are elaborated on in detail here:\r\nhttps://forums.triplea-game.org/topic/989/aa-revised-minor-bug\r\n\r\n(Don't be irritated by the tile of that thread, actually this is far from being minor ;-) )\r\n\r\nThis issue serves more or less as an initial collection of bugs.\r\nI am happy to provide more detailled information in separate issues of course, in case someone is willing to fix them."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/426868445","html_url":"https://github.com/triplea-game/triplea/issues/4133#issuecomment-426868445","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/4133","id":426868445,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjg2ODQ0NQ==","user":{"login":"DanVanAtta","id":12397753,"node_id":"MDQ6VXNlcjEyMzk3NzUz","avatar_url":"https://avatars2.githubusercontent.com/u/12397753?v=4","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T02:52:22Z","updated_at":"2018-10-04T02:52:22Z","author_association":"MEMBER","body":"@panther2 Good list, perhaps let's start from the top and see how well we do working down?\r\n\r\nTo begin:\r\n\r\n> v2:\r\n> - incorrect timing of AA fire (different rules for OOB and LHTR apply, but both versions are affected)\r\n\r\nCan you note when the AA gun is currently firing and when it _should_ fire?\r\n\r\n> - AA gun does not fire against groups of air units (if possible)\r\n\r\nWould you mind attaching a save game that has this scenario?\r\n\r\n> - attacker cannot choose casualties\r\n\r\nSimilar, could you attach a second save game that has this scenario and note what conditions were important to create. In other words, how did you know to create that save game where attacker would not be able to choose casualties?\r\n\r\n-------------\r\n\r\nI'm hoping with the saves and extra info, this will become pretty easy for one of the team to tackle. That would knock out at least the v2 issues.\r\n\r\n\r\n"}}
{"actor":{"display_login":"DanVanAtta"}}