{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/4295","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4295/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4295/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4295/events","html_url":"https://github.com/apache/incubator-airflow/pull/4295","id":388811004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTkxMzQ3","number":4295,"title":"AIRFLOW-3452 removed an unused/dangerous display-none","user":{"login":"MarcusSorealheis","id":2353608,"node_id":"MDQ6VXNlcjIzNTM2MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2353608?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusSorealheis","html_url":"https://github.com/MarcusSorealheis","followers_url":"https://api.github.com/users/MarcusSorealheis/followers","following_url":"https://api.github.com/users/MarcusSorealheis/following{/other_user}","gists_url":"https://api.github.com/users/MarcusSorealheis/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusSorealheis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusSorealheis/subscriptions","organizations_url":"https://api.github.com/users/MarcusSorealheis/orgs","repos_url":"https://api.github.com/users/MarcusSorealheis/repos","events_url":"https://api.github.com/users/MarcusSorealheis/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusSorealheis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-07T20:57:04Z","updated_at":"2018-12-08T00:05:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4295","html_url":"https://github.com/apache/incubator-airflow/pull/4295","diff_url":"https://github.com/apache/incubator-airflow/pull/4295.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/4295.patch"},"body":"The `display-none` style that includes the DAGs table on the homepage could resurface as a bug if the mechanism that is currently overriding it is removed. A recent JIRA issue suggests that a user may have already encountered this issue.\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [AIRFLOW-3452](https://issues.apache.org/jira/browse/AIRFLOW-3452) issues and references them in the PR title. \r\n\r\n### Description\r\n\r\n- [x] I simply removed an inline CSS style that can hide DAGs on the homepage as referenced in the issue above.\r\n- [x] [Here is the picture](https://drive.google.com/open?id=1pybh-Yi_JP4-MhaM2fADVIzAqnf-K4U_)\r\n### Tests\r\n\r\n- [x] This issue does affect any existing tests and does not add new functionality. \r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n  - All the public functions and the classes in the PR contain docstrings that explain what it does\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `flake8`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/445407824","html_url":"https://github.com/apache/incubator-airflow/pull/4295#issuecomment-445407824","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4295","id":445407824,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQwNzgyNA==","user":{"login":"MarcusSorealheis","id":2353608,"node_id":"MDQ6VXNlcjIzNTM2MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2353608?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusSorealheis","html_url":"https://github.com/MarcusSorealheis","followers_url":"https://api.github.com/users/MarcusSorealheis/followers","following_url":"https://api.github.com/users/MarcusSorealheis/following{/other_user}","gists_url":"https://api.github.com/users/MarcusSorealheis/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusSorealheis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusSorealheis/subscriptions","organizations_url":"https://api.github.com/users/MarcusSorealheis/orgs","repos_url":"https://api.github.com/users/MarcusSorealheis/repos","events_url":"https://api.github.com/users/MarcusSorealheis/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusSorealheis/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T00:05:52Z","updated_at":"2018-12-08T00:05:52Z","author_association":"NONE","body":"Furthermore @OldPanda, `display:none`, though not nearly as dangerous or comprisable as something like `eval` on the front end, it should still be wholly avoided. One of the reasons we should avoid it is because `display:none` [hides all its child text from screen readers] (https://css-tricks.com/places-its-tempting-to-use-display-none-but-dont/) and that's bad. "}}
{"actor":{"display_login":"MarcusSorealheis"}}