{"action":"closed","number":2251,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251","id":203842535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODQyNTM1","html_url":"https://github.com/LiskHQ/lisk/pull/2251","diff_url":"https://github.com/LiskHQ/lisk/pull/2251.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/2251.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2251","number":2251,"state":"closed","locked":false,"title":"Validate chain on startup of the application - Closes #2249","user":{"login":"nazarhussain","id":112468,"node_id":"MDQ6VXNlcjExMjQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/112468?v=4","gravatar_id":"","url":"https://api.github.com/users/nazarhussain","html_url":"https://github.com/nazarhussain","followers_url":"https://api.github.com/users/nazarhussain/followers","following_url":"https://api.github.com/users/nazarhussain/following{/other_user}","gists_url":"https://api.github.com/users/nazarhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/nazarhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazarhussain/subscriptions","organizations_url":"https://api.github.com/users/nazarhussain/orgs","repos_url":"https://api.github.com/users/nazarhussain/repos","events_url":"https://api.github.com/users/nazarhussain/events{/privacy}","received_events_url":"https://api.github.com/users/nazarhussain/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nCurrently if any node is migrated to latest version with some delay and it contains few blocks in database which have previous version still contains in database and can't sync.\r\n\r\n### How did I fix it?\r\nCheck the block validation on startup and delete the blocks. \r\n\r\n### How to test it?\r\nRun `functional/system/loader/validate_own_chain.js` \r\n\r\n### Review checklist\r\n\r\n* The PR solves #2249\r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-07-25T13:45:34Z","updated_at":"2018-07-27T08:01:20Z","closed_at":"2018-07-27T08:01:20Z","merged_at":"2018-07-27T08:01:20Z","merge_commit_sha":"ad7836b6057283ecf8d99c4df44701ce28c1beb2","assignee":{"login":"nazarhussain","id":112468,"node_id":"MDQ6VXNlcjExMjQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/112468?v=4","gravatar_id":"","url":"https://api.github.com/users/nazarhussain","html_url":"https://github.com/nazarhussain","followers_url":"https://api.github.com/users/nazarhussain/followers","following_url":"https://api.github.com/users/nazarhussain/following{/other_user}","gists_url":"https://api.github.com/users/nazarhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/nazarhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazarhussain/subscriptions","organizations_url":"https://api.github.com/users/nazarhussain/orgs","repos_url":"https://api.github.com/users/nazarhussain/repos","events_url":"https://api.github.com/users/nazarhussain/events{/privacy}","received_events_url":"https://api.github.com/users/nazarhussain/received_events","type":"User","site_admin":false},"assignees":[{"login":"nazarhussain","id":112468,"node_id":"MDQ6VXNlcjExMjQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/112468?v=4","gravatar_id":"","url":"https://api.github.com/users/nazarhussain","html_url":"https://github.com/nazarhussain","followers_url":"https://api.github.com/users/nazarhussain/followers","following_url":"https://api.github.com/users/nazarhussain/following{/other_user}","gists_url":"https://api.github.com/users/nazarhussain/gists{/gist_id}","starred_url":"https://api.github.com/users/nazarhussain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazarhussain/subscriptions","organizations_url":"https://api.github.com/users/nazarhussain/orgs","repos_url":"https://api.github.com/users/nazarhussain/repos","events_url":"https://api.github.com/users/nazarhussain/events{/privacy}","received_events_url":"https://api.github.com/users/nazarhussain/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":377168380,"node_id":"MDU6TGFiZWwzNzcxNjgzODA=","url":"https://api.github.com/repos/LiskHQ/lisk/labels/:white_check_mark:%20ready","name":":white_check_mark: ready","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2251/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/74bc2f03587725b9855fa4d3f257ee05ac927603","head":{"label":"LiskHQ:2249-validate-chain","ref":"2249-validate-chain","sha":"74bc2f03587725b9855fa4d3f257ee05ac927603","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-07-27T07:56:34Z","pushed_at":"2018-07-27T08:01:20Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":20024,"stargazers_count":2414,"watchers_count":2414,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":380,"open_issues":106,"watchers":2414,"default_branch":"development"}},"base":{"label":"LiskHQ:1.0.0-rc.2","ref":"1.0.0-rc.2","sha":"42c4a1b7b0f4e4812dc565f4613cb6c4635ce970","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-07-27T07:56:34Z","pushed_at":"2018-07-27T08:01:20Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":20024,"stargazers_count":2414,"watchers_count":2414,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":380,"open_issues":106,"watchers":2414,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/2251"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2251"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2251/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2251/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk/statuses/74bc2f03587725b9855fa4d3f257ee05ac927603"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MaciejBaj","id":6909553,"node_id":"MDQ6VXNlcjY5MDk1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6909553?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"comments":3,"review_comments":26,"maintainer_can_modify":false,"commits":12,"additions":573,"deletions":2,"changed_files":7}}
{"actor":{"display_login":"MaciejBaj"}}