{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124","id":175524873,"html_url":"https://github.com/fnc12/sqlite_orm/pull/124","diff_url":"https://github.com/fnc12/sqlite_orm/pull/124.diff","patch_url":"https://github.com/fnc12/sqlite_orm/pull/124.patch","issue_url":"https://api.github.com/repos/fnc12/sqlite_orm/issues/124","number":124,"state":"closed","locked":false,"title":"Visual Studio 2017 warnings fix","user":{"login":"ntkernelcom","id":20592735,"avatar_url":"https://avatars1.githubusercontent.com/u/20592735?v=4","gravatar_id":"","url":"https://api.github.com/users/ntkernelcom","html_url":"https://github.com/ntkernelcom","followers_url":"https://api.github.com/users/ntkernelcom/followers","following_url":"https://api.github.com/users/ntkernelcom/following{/other_user}","gists_url":"https://api.github.com/users/ntkernelcom/gists{/gist_id}","starred_url":"https://api.github.com/users/ntkernelcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntkernelcom/subscriptions","organizations_url":"https://api.github.com/users/ntkernelcom/orgs","repos_url":"https://api.github.com/users/ntkernelcom/repos","events_url":"https://api.github.com/users/ntkernelcom/events{/privacy}","received_events_url":"https://api.github.com/users/ntkernelcom/received_events","type":"User","site_admin":false},"body":"Just a quick fix for the couple of warning generated by Visual Studio 2017 compiler:\r\n\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(3634): warning C4138: '*/' found outside of comment\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(7201): warning C4138: '*/' found outside of comment\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(4513): warning C4099: 'sqlite_orm::internal::storage_t<Ts...>': type name first seen using 'struct' now seen using 'class'\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(4547): note: see reference to class template instantiation 'sqlite_orm::internal::storage_t<Ts...>::pragma_t' being compiled\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(7234): note: see reference to class template instantiation 'sqlite_orm::internal::storage_t<Ts...>' being compiled\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(4513): warning C4099: 'sqlite_orm::internal::storage_t<sqlite_orm::table_t<sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::vector<char,std::allocator<char>>>>>': type name first seen using 'struct' now seen using 'class'\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(4292): note: see declaration of 'sqlite_orm::internal::storage_t<sqlite_orm::table_t<sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::vector<char,std::allocator<char>>>>>'\r\n1>d:\\projects\\sqlite\\sqlite_orm\\include\\sqlite_orm\\sqlite_orm.h(7233): note: see reference to class template instantiation 'sqlite_orm::internal::storage_t<sqlite_orm::table_t<sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::vector<char,std::allocator<char>>>>>::pragma_t' being compiled\r\n1>d:\\projects\\sqlite\\sqlite_test\\sqlite_test\\sqlite_test.cpp(25): note: see reference to class template instantiation 'sqlite_orm::internal::storage_t<sqlite_orm::table_t<sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::string>,sqlite_orm::internal::column_t<ErrorLogEntry,std::vector<char,std::allocator<char>>>>","created_at":"2018-03-16T12:54:30Z","updated_at":"2018-03-16T15:34:19Z","closed_at":"2018-03-16T15:34:19Z","merged_at":"2018-03-16T15:34:19Z","merge_commit_sha":"085d0c51d91c5b35ea55e3c2083ad96f1ca351f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124/commits","review_comments_url":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124/comments","review_comment_url":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fnc12/sqlite_orm/issues/124/comments","statuses_url":"https://api.github.com/repos/fnc12/sqlite_orm/statuses/70bc7bf316c8919d5dfa4641320577ea39e2f538","head":{"label":"ntkernelcom:master","ref":"master","sha":"70bc7bf316c8919d5dfa4641320577ea39e2f538","user":{"login":"ntkernelcom","id":20592735,"avatar_url":"https://avatars1.githubusercontent.com/u/20592735?v=4","gravatar_id":"","url":"https://api.github.com/users/ntkernelcom","html_url":"https://github.com/ntkernelcom","followers_url":"https://api.github.com/users/ntkernelcom/followers","following_url":"https://api.github.com/users/ntkernelcom/following{/other_user}","gists_url":"https://api.github.com/users/ntkernelcom/gists{/gist_id}","starred_url":"https://api.github.com/users/ntkernelcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntkernelcom/subscriptions","organizations_url":"https://api.github.com/users/ntkernelcom/orgs","repos_url":"https://api.github.com/users/ntkernelcom/repos","events_url":"https://api.github.com/users/ntkernelcom/events{/privacy}","received_events_url":"https://api.github.com/users/ntkernelcom/received_events","type":"User","site_admin":false},"repo":{"id":125514242,"name":"sqlite_orm","full_name":"ntkernelcom/sqlite_orm","owner":{"login":"ntkernelcom","id":20592735,"avatar_url":"https://avatars1.githubusercontent.com/u/20592735?v=4","gravatar_id":"","url":"https://api.github.com/users/ntkernelcom","html_url":"https://github.com/ntkernelcom","followers_url":"https://api.github.com/users/ntkernelcom/followers","following_url":"https://api.github.com/users/ntkernelcom/following{/other_user}","gists_url":"https://api.github.com/users/ntkernelcom/gists{/gist_id}","starred_url":"https://api.github.com/users/ntkernelcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntkernelcom/subscriptions","organizations_url":"https://api.github.com/users/ntkernelcom/orgs","repos_url":"https://api.github.com/users/ntkernelcom/repos","events_url":"https://api.github.com/users/ntkernelcom/events{/privacy}","received_events_url":"https://api.github.com/users/ntkernelcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntkernelcom/sqlite_orm","description":"SQLite ORM light header only library for modern C++","fork":true,"url":"https://api.github.com/repos/ntkernelcom/sqlite_orm","forks_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/forks","keys_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/teams","hooks_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/hooks","issue_events_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/issues/events{/number}","events_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/events","assignees_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/assignees{/user}","branches_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/branches{/branch}","tags_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/tags","blobs_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/statuses/{sha}","languages_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/languages","stargazers_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/stargazers","contributors_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/contributors","subscribers_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/subscribers","subscription_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/subscription","commits_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/contents/{+path}","compare_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/merges","archive_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/downloads","issues_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/issues{/number}","pulls_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/pulls{/number}","milestones_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/milestones{/number}","notifications_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/labels{/name}","releases_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/releases{/id}","deployments_url":"https://api.github.com/repos/ntkernelcom/sqlite_orm/deployments","created_at":"2018-03-16T12:35:55Z","updated_at":"2018-03-16T12:52:18Z","pushed_at":"2018-03-16T12:52:17Z","git_url":"git://github.com/ntkernelcom/sqlite_orm.git","ssh_url":"git@github.com:ntkernelcom/sqlite_orm.git","clone_url":"https://github.com/ntkernelcom/sqlite_orm.git","svn_url":"https://github.com/ntkernelcom/sqlite_orm","homepage":null,"size":1452,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fnc12:master","ref":"master","sha":"faf47ecb14817407d3a61088f14f9a6161eb2cff","user":{"login":"fnc12","id":6009640,"avatar_url":"https://avatars3.githubusercontent.com/u/6009640?v=4","gravatar_id":"","url":"https://api.github.com/users/fnc12","html_url":"https://github.com/fnc12","followers_url":"https://api.github.com/users/fnc12/followers","following_url":"https://api.github.com/users/fnc12/following{/other_user}","gists_url":"https://api.github.com/users/fnc12/gists{/gist_id}","starred_url":"https://api.github.com/users/fnc12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnc12/subscriptions","organizations_url":"https://api.github.com/users/fnc12/orgs","repos_url":"https://api.github.com/users/fnc12/repos","events_url":"https://api.github.com/users/fnc12/events{/privacy}","received_events_url":"https://api.github.com/users/fnc12/received_events","type":"User","site_admin":false},"repo":{"id":76951323,"name":"sqlite_orm","full_name":"fnc12/sqlite_orm","owner":{"login":"fnc12","id":6009640,"avatar_url":"https://avatars3.githubusercontent.com/u/6009640?v=4","gravatar_id":"","url":"https://api.github.com/users/fnc12","html_url":"https://github.com/fnc12","followers_url":"https://api.github.com/users/fnc12/followers","following_url":"https://api.github.com/users/fnc12/following{/other_user}","gists_url":"https://api.github.com/users/fnc12/gists{/gist_id}","starred_url":"https://api.github.com/users/fnc12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnc12/subscriptions","organizations_url":"https://api.github.com/users/fnc12/orgs","repos_url":"https://api.github.com/users/fnc12/repos","events_url":"https://api.github.com/users/fnc12/events{/privacy}","received_events_url":"https://api.github.com/users/fnc12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fnc12/sqlite_orm","description":"SQLite ORM light header only library for modern C++","fork":false,"url":"https://api.github.com/repos/fnc12/sqlite_orm","forks_url":"https://api.github.com/repos/fnc12/sqlite_orm/forks","keys_url":"https://api.github.com/repos/fnc12/sqlite_orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnc12/sqlite_orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnc12/sqlite_orm/teams","hooks_url":"https://api.github.com/repos/fnc12/sqlite_orm/hooks","issue_events_url":"https://api.github.com/repos/fnc12/sqlite_orm/issues/events{/number}","events_url":"https://api.github.com/repos/fnc12/sqlite_orm/events","assignees_url":"https://api.github.com/repos/fnc12/sqlite_orm/assignees{/user}","branches_url":"https://api.github.com/repos/fnc12/sqlite_orm/branches{/branch}","tags_url":"https://api.github.com/repos/fnc12/sqlite_orm/tags","blobs_url":"https://api.github.com/repos/fnc12/sqlite_orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnc12/sqlite_orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnc12/sqlite_orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnc12/sqlite_orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnc12/sqlite_orm/statuses/{sha}","languages_url":"https://api.github.com/repos/fnc12/sqlite_orm/languages","stargazers_url":"https://api.github.com/repos/fnc12/sqlite_orm/stargazers","contributors_url":"https://api.github.com/repos/fnc12/sqlite_orm/contributors","subscribers_url":"https://api.github.com/repos/fnc12/sqlite_orm/subscribers","subscription_url":"https://api.github.com/repos/fnc12/sqlite_orm/subscription","commits_url":"https://api.github.com/repos/fnc12/sqlite_orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnc12/sqlite_orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnc12/sqlite_orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnc12/sqlite_orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnc12/sqlite_orm/contents/{+path}","compare_url":"https://api.github.com/repos/fnc12/sqlite_orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnc12/sqlite_orm/merges","archive_url":"https://api.github.com/repos/fnc12/sqlite_orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnc12/sqlite_orm/downloads","issues_url":"https://api.github.com/repos/fnc12/sqlite_orm/issues{/number}","pulls_url":"https://api.github.com/repos/fnc12/sqlite_orm/pulls{/number}","milestones_url":"https://api.github.com/repos/fnc12/sqlite_orm/milestones{/number}","notifications_url":"https://api.github.com/repos/fnc12/sqlite_orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnc12/sqlite_orm/labels{/name}","releases_url":"https://api.github.com/repos/fnc12/sqlite_orm/releases{/id}","deployments_url":"https://api.github.com/repos/fnc12/sqlite_orm/deployments","created_at":"2016-12-20T11:35:20Z","updated_at":"2018-03-16T09:38:24Z","pushed_at":"2018-03-16T15:34:19Z","git_url":"git://github.com/fnc12/sqlite_orm.git","ssh_url":"git@github.com:fnc12/sqlite_orm.git","clone_url":"https://github.com/fnc12/sqlite_orm.git","svn_url":"https://github.com/fnc12/sqlite_orm","homepage":null,"size":1451,"stargazers_count":291,"watchers_count":291,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":37,"open_issues":10,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124"},"html":{"href":"https://github.com/fnc12/sqlite_orm/pull/124"},"issue":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/issues/124"},"comments":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/fnc12/sqlite_orm/statuses/70bc7bf316c8919d5dfa4641320577ea39e2f538"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fnc12","id":6009640,"avatar_url":"https://avatars3.githubusercontent.com/u/6009640?v=4","gravatar_id":"","url":"https://api.github.com/users/fnc12","html_url":"https://github.com/fnc12","followers_url":"https://api.github.com/users/fnc12/followers","following_url":"https://api.github.com/users/fnc12/following{/other_user}","gists_url":"https://api.github.com/users/fnc12/gists{/gist_id}","starred_url":"https://api.github.com/users/fnc12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnc12/subscriptions","organizations_url":"https://api.github.com/users/fnc12/orgs","repos_url":"https://api.github.com/users/fnc12/repos","events_url":"https://api.github.com/users/fnc12/events{/privacy}","received_events_url":"https://api.github.com/users/fnc12/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"fnc12"}}