{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/240247444","pull_request_review_id":183229869,"id":240247444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI0NzQ0NA==","diff_hunk":"@@ -6659,6 +6658,72 @@ static FnCallResult FnCallReadData(ARG_UNUSED EvalContext *ctx,\n     return (FnCallResult) { FNCALL_SUCCESS, (Rval) { json, RVAL_TYPE_CONTAINER } };\n }\n \n+static FnCallResult FnCallClassExprFilter(EvalContext *ctx,\n+                                          ARG_UNUSED Policy const *policy,\n+                                          ARG_UNUSED FnCall const *fp,\n+                                          Rlist const *args)\n+{\n+    char const *path = RlistScalarValue(args);\n+    size_t const col = IntFromString(RlistScalarValue(args->next));\n+    char const *delim = RlistScalarValue(args->next->next);\n+    bool has_heading = BooleanFromString(RlistScalarValue(args->next->next->next));\n+    int const sort_col = IntFromString(RlistScalarValue(args->next->next->next->next));\n+\n+    Seq *heading_seq = NULL;\n+    char *line;\n+    JsonElement *json = JsonArrayCreate(50);\n+","path":"libpromises/evalfunction.c","position":28,"original_position":28,"commit_id":"db43fe7e91f1902a2da827f5fe9432eaf1646179","original_commit_id":"db43fe7e91f1902a2da827f5fe9432eaf1646179","user":{"login":"craigcomstock","id":2554776,"node_id":"MDQ6VXNlcjI1NTQ3NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2554776?v=4","gravatar_id":"","url":"https://api.github.com/users/craigcomstock","html_url":"https://github.com/craigcomstock","followers_url":"https://api.github.com/users/craigcomstock/followers","following_url":"https://api.github.com/users/craigcomstock/following{/other_user}","gists_url":"https://api.github.com/users/craigcomstock/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcomstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcomstock/subscriptions","organizations_url":"https://api.github.com/users/craigcomstock/orgs","repos_url":"https://api.github.com/users/craigcomstock/repos","events_url":"https://api.github.com/users/craigcomstock/events{/privacy}","received_events_url":"https://api.github.com/users/craigcomstock/received_events","type":"User","site_admin":false},"body":"JsonArrayCreate() calls xcalloc for each element, so need to free before returning on line 6679 below or any other return paths below.","created_at":"2018-12-10T15:09:55Z","updated_at":"2018-12-10T15:23:32Z","html_url":"https://github.com/cfengine/core/pull/3463#discussion_r240247444","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/3463","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/240247444"},"html":{"href":"https://github.com/cfengine/core/pull/3463#discussion_r240247444"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/3463"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/3463","id":237262182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjYyMTgy","html_url":"https://github.com/cfengine/core/pull/3463","diff_url":"https://github.com/cfengine/core/pull/3463.diff","patch_url":"https://github.com/cfengine/core/pull/3463.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/3463","number":3463,"state":"open","locked":false,"title":"CFE-2768: Added function to filter CSV by class expressions","user":{"login":"karlhto","id":6323912,"node_id":"MDQ6VXNlcjYzMjM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6323912?v=4","gravatar_id":"","url":"https://api.github.com/users/karlhto","html_url":"https://github.com/karlhto","followers_url":"https://api.github.com/users/karlhto/followers","following_url":"https://api.github.com/users/karlhto/following{/other_user}","gists_url":"https://api.github.com/users/karlhto/gists{/gist_id}","starred_url":"https://api.github.com/users/karlhto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlhto/subscriptions","organizations_url":"https://api.github.com/users/karlhto/orgs","repos_url":"https://api.github.com/users/karlhto/repos","events_url":"https://api.github.com/users/karlhto/events{/privacy}","received_events_url":"https://api.github.com/users/karlhto/received_events","type":"User","site_admin":false},"body":"Will currently only filter data, does not remove duplicates and\r\nsuch. Also cannot sort yet.\r\n\r\nThis is not ready to be merged, but I want feedback.\r\n\r\n@nickanderson if you want to try it, you could check out my branch and compile it.","created_at":"2018-12-10T10:08:59Z","updated_at":"2018-12-10T15:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5be749fff258abdd653e6cf0866e5aea9560d25d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olehermanse","id":4048546,"node_id":"MDQ6VXNlcjQwNDg1NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4048546?v=4","gravatar_id":"","url":"https://api.github.com/users/olehermanse","html_url":"https://github.com/olehermanse","followers_url":"https://api.github.com/users/olehermanse/followers","following_url":"https://api.github.com/users/olehermanse/following{/other_user}","gists_url":"https://api.github.com/users/olehermanse/gists{/gist_id}","starred_url":"https://api.github.com/users/olehermanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olehermanse/subscriptions","organizations_url":"https://api.github.com/users/olehermanse/orgs","repos_url":"https://api.github.com/users/olehermanse/repos","events_url":"https://api.github.com/users/olehermanse/events{/privacy}","received_events_url":"https://api.github.com/users/olehermanse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":870818379,"node_id":"MDU6TGFiZWw4NzA4MTgzNzk=","url":"https://api.github.com/repos/cfengine/core/labels/WIP","name":"WIP","color":"d119c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/3463/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/3463/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/3463/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/db43fe7e91f1902a2da827f5fe9432eaf1646179","head":{"label":"karlhto:CFE-2768","ref":"CFE-2768","sha":"db43fe7e91f1902a2da827f5fe9432eaf1646179","user":{"login":"karlhto","id":6323912,"node_id":"MDQ6VXNlcjYzMjM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6323912?v=4","gravatar_id":"","url":"https://api.github.com/users/karlhto","html_url":"https://github.com/karlhto","followers_url":"https://api.github.com/users/karlhto/followers","following_url":"https://api.github.com/users/karlhto/following{/other_user}","gists_url":"https://api.github.com/users/karlhto/gists{/gist_id}","starred_url":"https://api.github.com/users/karlhto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlhto/subscriptions","organizations_url":"https://api.github.com/users/karlhto/orgs","repos_url":"https://api.github.com/users/karlhto/repos","events_url":"https://api.github.com/users/karlhto/events{/privacy}","received_events_url":"https://api.github.com/users/karlhto/received_events","type":"User","site_admin":false},"repo":{"id":138296312,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyOTYzMTI=","name":"core","full_name":"karlhto/core","private":false,"owner":{"login":"karlhto","id":6323912,"node_id":"MDQ6VXNlcjYzMjM5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6323912?v=4","gravatar_id":"","url":"https://api.github.com/users/karlhto","html_url":"https://github.com/karlhto","followers_url":"https://api.github.com/users/karlhto/followers","following_url":"https://api.github.com/users/karlhto/following{/other_user}","gists_url":"https://api.github.com/users/karlhto/gists{/gist_id}","starred_url":"https://api.github.com/users/karlhto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlhto/subscriptions","organizations_url":"https://api.github.com/users/karlhto/orgs","repos_url":"https://api.github.com/users/karlhto/repos","events_url":"https://api.github.com/users/karlhto/events{/privacy}","received_events_url":"https://api.github.com/users/karlhto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karlhto/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/karlhto/core","forks_url":"https://api.github.com/repos/karlhto/core/forks","keys_url":"https://api.github.com/repos/karlhto/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karlhto/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karlhto/core/teams","hooks_url":"https://api.github.com/repos/karlhto/core/hooks","issue_events_url":"https://api.github.com/repos/karlhto/core/issues/events{/number}","events_url":"https://api.github.com/repos/karlhto/core/events","assignees_url":"https://api.github.com/repos/karlhto/core/assignees{/user}","branches_url":"https://api.github.com/repos/karlhto/core/branches{/branch}","tags_url":"https://api.github.com/repos/karlhto/core/tags","blobs_url":"https://api.github.com/repos/karlhto/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karlhto/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karlhto/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/karlhto/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karlhto/core/statuses/{sha}","languages_url":"https://api.github.com/repos/karlhto/core/languages","stargazers_url":"https://api.github.com/repos/karlhto/core/stargazers","contributors_url":"https://api.github.com/repos/karlhto/core/contributors","subscribers_url":"https://api.github.com/repos/karlhto/core/subscribers","subscription_url":"https://api.github.com/repos/karlhto/core/subscription","commits_url":"https://api.github.com/repos/karlhto/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/karlhto/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/karlhto/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/karlhto/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/karlhto/core/contents/{+path}","compare_url":"https://api.github.com/repos/karlhto/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karlhto/core/merges","archive_url":"https://api.github.com/repos/karlhto/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karlhto/core/downloads","issues_url":"https://api.github.com/repos/karlhto/core/issues{/number}","pulls_url":"https://api.github.com/repos/karlhto/core/pulls{/number}","milestones_url":"https://api.github.com/repos/karlhto/core/milestones{/number}","notifications_url":"https://api.github.com/repos/karlhto/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karlhto/core/labels{/name}","releases_url":"https://api.github.com/repos/karlhto/core/releases{/id}","deployments_url":"https://api.github.com/repos/karlhto/core/deployments","created_at":"2018-06-22T11:44:32Z","updated_at":"2018-12-10T09:33:23Z","pushed_at":"2018-12-10T09:33:37Z","git_url":"git://github.com/karlhto/core.git","ssh_url":"git@github.com:karlhto/core.git","clone_url":"https://github.com/karlhto/core.git","svn_url":"https://github.com/karlhto/core","homepage":"https://cfengine.com/community/","size":57740,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"0327627bba4719863fb472dea88705bf2c3a12c0","user":{"login":"cfengine","id":1239823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzk4MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1239823?v=4","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQzNTQ4","name":"core","full_name":"cfengine/core","private":false,"owner":{"login":"cfengine","id":1239823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzk4MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1239823?v=4","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","deployments_url":"https://api.github.com/repos/cfengine/core/deployments","created_at":"2012-02-25T09:19:05Z","updated_at":"2018-12-10T12:34:58Z","pushed_at":"2018-12-10T15:19:07Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":58168,"stargazers_count":306,"watchers_count":306,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":172,"open_issues":15,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/3463"},"html":{"href":"https://github.com/cfengine/core/pull/3463"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/3463"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/3463/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/3463/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/3463/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/db43fe7e91f1902a2da827f5fe9432eaf1646179"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"craigcomstock"}}