{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/218772352","pull_request_review_id":156781000,"id":218772352,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc3MjM1Mg==","diff_hunk":"@@ -129,13 +129,13 @@ Module Comodality_Theory (F : Comodality).\n       := IdmapM FPM.\n     Module cip_FPM := FPM.coindpathsM FPM cmpinv_o_cmp_M idmap_FPM.\n     Module cip_FPHM <: HomotopyM FPM cmpM.PM cip_FPM.fhM cip_FPM.fkM.\n-      Definition m : forall x, cip_FPM.fhM.m@{i j} x = cip_FPM.fkM.m@{i j} x.\n+      Definition m : forall x, cip_FPM.fhM.m x = cip_FPM.fkM.m x.","path":"test-suite/bugs/closed/3956.v","position":5,"original_position":5,"commit_id":"731e824677e1fc1ab3de9ed887e56ec555b373a3","original_commit_id":"731e824677e1fc1ab3de9ed887e56ec555b373a3","user":{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"body":"I did not understand in which sense this is related to this PR.","created_at":"2018-09-19T11:50:37Z","updated_at":"2018-09-19T11:51:03Z","html_url":"https://github.com/coq/coq/pull/8059#discussion_r218772352","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/8059","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/218772352"},"html":{"href":"https://github.com/coq/coq/pull/8059#discussion_r218772352"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/8059"}}},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/8059","id":201303487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzAzNDg3","html_url":"https://github.com/coq/coq/pull/8059","diff_url":"https://github.com/coq/coq/pull/8059.diff","patch_url":"https://github.com/coq/coq/pull/8059.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/8059","number":8059,"state":"open","locked":false,"title":"Simplify code for [Definition := Eval ...]","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"body":"This fixes #3690 for real (it was added to the test suite as closed even though it was wontfix for some reason) by restricting universes after running the Eval.\r\n\r\nNote the commit touching nativenorm, I don't know if that's the right fix but without it the test for #7631 breaks with assert false. I don't know if there's a way to trigger it with the current system but it's not good for a function taking econstr to fail when the constr is not evar normal.\r\nI have further simplification in mind which would may make it suboptimal to econstr.to_constr before the eval so I avoided it but if someone strongly thinks it's better I can deal with it.","created_at":"2018-07-13T14:13:25Z","updated_at":"2018-09-19T11:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de88b39e664753bec117a1080d0139206e6098d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattam82","id":98373,"node_id":"MDQ6VXNlcjk4Mzcz","avatar_url":"https://avatars1.githubusercontent.com/u/98373?v=4","gravatar_id":"","url":"https://api.github.com/users/mattam82","html_url":"https://github.com/mattam82","followers_url":"https://api.github.com/users/mattam82/followers","following_url":"https://api.github.com/users/mattam82/following{/other_user}","gists_url":"https://api.github.com/users/mattam82/gists{/gist_id}","starred_url":"https://api.github.com/users/mattam82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattam82/subscriptions","organizations_url":"https://api.github.com/users/mattam82/orgs","repos_url":"https://api.github.com/users/mattam82/repos","events_url":"https://api.github.com/users/mattam82/events{/privacy}","received_events_url":"https://api.github.com/users/mattam82/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485985791,"node_id":"MDU6TGFiZWw0ODU5ODU3OTE=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20cleanup","name":"kind: cleanup","color":"3366ff","default":false},{"id":723611231,"node_id":"MDU6TGFiZWw3MjM2MTEyMzE=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20enhancement","name":"kind: enhancement","color":"0e8a16","default":false},{"id":485985650,"node_id":"MDU6TGFiZWw0ODU5ODU2NTA=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20fix","name":"kind: fix","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"node_id":"MDk6TWlsZXN0b25lMjY0Nzc0Mw==","number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":117,"closed_issues":439,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-09-19T11:46:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/coq/coq/pulls/8059/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/8059/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/8059/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/731e824677e1fc1ab3de9ed887e56ec555b373a3","head":{"label":"SkySkimmer:simplify-def-eval","ref":"simplify-def-eval","sha":"731e824677e1fc1ab3de9ed887e56ec555b373a3","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"repo":{"id":76260922,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI2MDkyMg==","name":"coq","full_name":"SkySkimmer/coq","private":false,"owner":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SkySkimmer/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/SkySkimmer/coq","forks_url":"https://api.github.com/repos/SkySkimmer/coq/forks","keys_url":"https://api.github.com/repos/SkySkimmer/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkySkimmer/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkySkimmer/coq/teams","hooks_url":"https://api.github.com/repos/SkySkimmer/coq/hooks","issue_events_url":"https://api.github.com/repos/SkySkimmer/coq/issues/events{/number}","events_url":"https://api.github.com/repos/SkySkimmer/coq/events","assignees_url":"https://api.github.com/repos/SkySkimmer/coq/assignees{/user}","branches_url":"https://api.github.com/repos/SkySkimmer/coq/branches{/branch}","tags_url":"https://api.github.com/repos/SkySkimmer/coq/tags","blobs_url":"https://api.github.com/repos/SkySkimmer/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkySkimmer/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkySkimmer/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkySkimmer/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkySkimmer/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/SkySkimmer/coq/languages","stargazers_url":"https://api.github.com/repos/SkySkimmer/coq/stargazers","contributors_url":"https://api.github.com/repos/SkySkimmer/coq/contributors","subscribers_url":"https://api.github.com/repos/SkySkimmer/coq/subscribers","subscription_url":"https://api.github.com/repos/SkySkimmer/coq/subscription","commits_url":"https://api.github.com/repos/SkySkimmer/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkySkimmer/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkySkimmer/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkySkimmer/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkySkimmer/coq/contents/{+path}","compare_url":"https://api.github.com/repos/SkySkimmer/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkySkimmer/coq/merges","archive_url":"https://api.github.com/repos/SkySkimmer/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkySkimmer/coq/downloads","issues_url":"https://api.github.com/repos/SkySkimmer/coq/issues{/number}","pulls_url":"https://api.github.com/repos/SkySkimmer/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/SkySkimmer/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/SkySkimmer/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkySkimmer/coq/labels{/name}","releases_url":"https://api.github.com/repos/SkySkimmer/coq/releases{/id}","deployments_url":"https://api.github.com/repos/SkySkimmer/coq/deployments","created_at":"2016-12-12T13:56:45Z","updated_at":"2018-09-19T11:15:34Z","pushed_at":"2018-09-19T11:49:55Z","git_url":"git://github.com/SkySkimmer/coq.git","ssh_url":"git@github.com:SkySkimmer/coq.git","clone_url":"https://github.com/SkySkimmer/coq.git","svn_url":"https://github.com/SkySkimmer/coq","homepage":"http://coq.inria.fr/","size":104248,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"6d74efabf11768ca1df3a2f3d5a65d25f7f95b01","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","private":false,"owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-09-19T08:29:59Z","pushed_at":"2018-09-19T11:49:56Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":115351,"stargazers_count":1464,"watchers_count":1464,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"archived":false,"open_issues_count":1825,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":271,"open_issues":1825,"watchers":1464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/8059"},"html":{"href":"https://github.com/coq/coq/pull/8059"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/8059"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/8059/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/8059/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/8059/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/731e824677e1fc1ab3de9ed887e56ec555b373a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"herbelin"}}