{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/collections/pulls/comments/176434944","pull_request_review_id":106135467,"id":176434944,"diff_hunk":"@@ -89,9 +89,22 @@ def stub_organisations_for_taxon(content_id, organisations)\n     )\n   end\n \n-  def generate_search_results(count)\n+  def generate_search_results(count, supergroup = \"default\")\n     (1..count).map do |number|\n-      rummager_document_for_slug(\"content-item-#{number}\")\n+      case supergroup","path":"test/support/rummager_helpers.rb","position":8,"original_position":8,"commit_id":"6acf32325b82710297365e385c301d14ed0c1998","original_commit_id":"6acf32325b82710297365e385c301d14ed0c1998","user":{"login":"vanitabarrett","id":29889908,"avatar_url":"https://avatars3.githubusercontent.com/u/29889908?v=4","gravatar_id":"","url":"https://api.github.com/users/vanitabarrett","html_url":"https://github.com/vanitabarrett","followers_url":"https://api.github.com/users/vanitabarrett/followers","following_url":"https://api.github.com/users/vanitabarrett/following{/other_user}","gists_url":"https://api.github.com/users/vanitabarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/vanitabarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanitabarrett/subscriptions","organizations_url":"https://api.github.com/users/vanitabarrett/orgs","repos_url":"https://api.github.com/users/vanitabarrett/repos","events_url":"https://api.github.com/users/vanitabarrett/events{/privacy}","received_events_url":"https://api.github.com/users/vanitabarrett/received_events","type":"User","site_admin":false},"body":"nstead of having a method for each supergroup, can we not continue to use the rummager_document_for_slug method, passing in the format we want? E.g:\r\n\r\nrummager_document_for_slug(\"content-item-#{number}\", format = \"local_transaction\")\r\nMaybe I'm missing something?","created_at":"2018-03-22T14:15:39Z","updated_at":"2018-03-22T14:15:42Z","html_url":"https://github.com/alphagov/collections/pull/584#discussion_r176434944","pull_request_url":"https://api.github.com/repos/alphagov/collections/pulls/584","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/collections/pulls/comments/176434944"},"html":{"href":"https://github.com/alphagov/collections/pull/584#discussion_r176434944"},"pull_request":{"href":"https://api.github.com/repos/alphagov/collections/pulls/584"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/collections/pulls/584","id":176764598,"html_url":"https://github.com/alphagov/collections/pull/584","diff_url":"https://github.com/alphagov/collections/pull/584.diff","patch_url":"https://github.com/alphagov/collections/pull/584.patch","issue_url":"https://api.github.com/repos/alphagov/collections/issues/584","number":584,"state":"open","locked":false,"title":"Show metadata based on content supergroup","user":{"login":"fmlharrison","id":20514501,"avatar_url":"https://avatars1.githubusercontent.com/u/20514501?v=4","gravatar_id":"","url":"https://api.github.com/users/fmlharrison","html_url":"https://github.com/fmlharrison","followers_url":"https://api.github.com/users/fmlharrison/followers","following_url":"https://api.github.com/users/fmlharrison/following{/other_user}","gists_url":"https://api.github.com/users/fmlharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/fmlharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmlharrison/subscriptions","organizations_url":"https://api.github.com/users/fmlharrison/orgs","repos_url":"https://api.github.com/users/fmlharrison/repos","events_url":"https://api.github.com/users/fmlharrison/events{/privacy}","received_events_url":"https://api.github.com/users/fmlharrison/received_events","type":"User","site_admin":false},"body":"This is the PR for the work @emmabeynon and I did to show the correct metadata of the list items in the supergroup sections.\r\n\r\nhttps://trello.com/c/VcOm55tS/145-show-metadata-based-on-content-supergroup","created_at":"2018-03-22T12:37:50Z","updated_at":"2018-03-22T14:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5730b3cacbeccb4ef57d250dbaf50f5d3dbe416","assignee":null,"assignees":[],"requested_reviewers":[{"login":"leenagupte","id":5793815,"avatar_url":"https://avatars2.githubusercontent.com/u/5793815?v=4","gravatar_id":"","url":"https://api.github.com/users/leenagupte","html_url":"https://github.com/leenagupte","followers_url":"https://api.github.com/users/leenagupte/followers","following_url":"https://api.github.com/users/leenagupte/following{/other_user}","gists_url":"https://api.github.com/users/leenagupte/gists{/gist_id}","starred_url":"https://api.github.com/users/leenagupte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leenagupte/subscriptions","organizations_url":"https://api.github.com/users/leenagupte/orgs","repos_url":"https://api.github.com/users/leenagupte/repos","events_url":"https://api.github.com/users/leenagupte/events{/privacy}","received_events_url":"https://api.github.com/users/leenagupte/received_events","type":"User","site_admin":false},{"login":"emmabeynon","id":13434452,"avatar_url":"https://avatars3.githubusercontent.com/u/13434452?v=4","gravatar_id":"","url":"https://api.github.com/users/emmabeynon","html_url":"https://github.com/emmabeynon","followers_url":"https://api.github.com/users/emmabeynon/followers","following_url":"https://api.github.com/users/emmabeynon/following{/other_user}","gists_url":"https://api.github.com/users/emmabeynon/gists{/gist_id}","starred_url":"https://api.github.com/users/emmabeynon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmabeynon/subscriptions","organizations_url":"https://api.github.com/users/emmabeynon/orgs","repos_url":"https://api.github.com/users/emmabeynon/repos","events_url":"https://api.github.com/users/emmabeynon/events{/privacy}","received_events_url":"https://api.github.com/users/emmabeynon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/collections/pulls/584/commits","review_comments_url":"https://api.github.com/repos/alphagov/collections/pulls/584/comments","review_comment_url":"https://api.github.com/repos/alphagov/collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/collections/issues/584/comments","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/6acf32325b82710297365e385c301d14ed0c1998","head":{"label":"alphagov:show-metadata-based-on-content-supergroup","ref":"show-metadata-based-on-content-supergroup","sha":"6acf32325b82710297365e385c301d14ed0c1998","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18403824,"name":"collections","full_name":"alphagov/collections","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/collections","description":"Serves the new navigation pages, browse, topic and services and information pages on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/collections","forks_url":"https://api.github.com/repos/alphagov/collections/forks","keys_url":"https://api.github.com/repos/alphagov/collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/collections/teams","hooks_url":"https://api.github.com/repos/alphagov/collections/hooks","issue_events_url":"https://api.github.com/repos/alphagov/collections/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/collections/events","assignees_url":"https://api.github.com/repos/alphagov/collections/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/collections/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/collections/tags","blobs_url":"https://api.github.com/repos/alphagov/collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/collections/languages","stargazers_url":"https://api.github.com/repos/alphagov/collections/stargazers","contributors_url":"https://api.github.com/repos/alphagov/collections/contributors","subscribers_url":"https://api.github.com/repos/alphagov/collections/subscribers","subscription_url":"https://api.github.com/repos/alphagov/collections/subscription","commits_url":"https://api.github.com/repos/alphagov/collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/collections/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/collections/merges","archive_url":"https://api.github.com/repos/alphagov/collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/collections/downloads","issues_url":"https://api.github.com/repos/alphagov/collections/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/collections/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/collections/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/collections/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/collections/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/collections/deployments","created_at":"2014-04-03T13:24:19Z","updated_at":"2018-03-21T08:16:41Z","pushed_at":"2018-03-22T13:46:58Z","git_url":"git://github.com/alphagov/collections.git","ssh_url":"git@github.com:alphagov/collections.git","clone_url":"https://github.com/alphagov/collections.git","svn_url":"https://github.com/alphagov/collections","homepage":"https://docs.publishing.service.gov.uk/apps/collections.html","size":2443,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":15,"watchers":5,"default_branch":"master"}},"base":{"label":"alphagov:feature/q4-topic-pages","ref":"feature/q4-topic-pages","sha":"12b67ecf71a8495ded2e33731ca5f7aff4beb5a3","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18403824,"name":"collections","full_name":"alphagov/collections","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/collections","description":"Serves the new navigation pages, browse, topic and services and information pages on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/collections","forks_url":"https://api.github.com/repos/alphagov/collections/forks","keys_url":"https://api.github.com/repos/alphagov/collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/collections/teams","hooks_url":"https://api.github.com/repos/alphagov/collections/hooks","issue_events_url":"https://api.github.com/repos/alphagov/collections/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/collections/events","assignees_url":"https://api.github.com/repos/alphagov/collections/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/collections/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/collections/tags","blobs_url":"https://api.github.com/repos/alphagov/collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/collections/languages","stargazers_url":"https://api.github.com/repos/alphagov/collections/stargazers","contributors_url":"https://api.github.com/repos/alphagov/collections/contributors","subscribers_url":"https://api.github.com/repos/alphagov/collections/subscribers","subscription_url":"https://api.github.com/repos/alphagov/collections/subscription","commits_url":"https://api.github.com/repos/alphagov/collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/collections/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/collections/merges","archive_url":"https://api.github.com/repos/alphagov/collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/collections/downloads","issues_url":"https://api.github.com/repos/alphagov/collections/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/collections/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/collections/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/collections/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/collections/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/collections/deployments","created_at":"2014-04-03T13:24:19Z","updated_at":"2018-03-21T08:16:41Z","pushed_at":"2018-03-22T13:46:58Z","git_url":"git://github.com/alphagov/collections.git","ssh_url":"git@github.com:alphagov/collections.git","clone_url":"https://github.com/alphagov/collections.git","svn_url":"https://github.com/alphagov/collections","homepage":"https://docs.publishing.service.gov.uk/apps/collections.html","size":2443,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":15,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/collections/pulls/584"},"html":{"href":"https://github.com/alphagov/collections/pull/584"},"issue":{"href":"https://api.github.com/repos/alphagov/collections/issues/584"},"comments":{"href":"https://api.github.com/repos/alphagov/collections/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/collections/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/collections/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/collections/statuses/6acf32325b82710297365e385c301d14ed0c1998"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vanitabarrett"}}