{"action":"created","issue":{"url":"https://api.github.com/repos/chanind/hanzi-writer/issues/42","repository_url":"https://api.github.com/repos/chanind/hanzi-writer","labels_url":"https://api.github.com/repos/chanind/hanzi-writer/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/chanind/hanzi-writer/issues/42/comments","events_url":"https://api.github.com/repos/chanind/hanzi-writer/issues/42/events","html_url":"https://github.com/chanind/hanzi-writer/pull/42","id":294301808,"number":42,"title":"fix: better error loading of char data","user":{"login":"vaab","id":703255,"avatar_url":"https://avatars3.githubusercontent.com/u/703255?v=4","gravatar_id":"","url":"https://api.github.com/users/vaab","html_url":"https://github.com/vaab","followers_url":"https://api.github.com/users/vaab/followers","following_url":"https://api.github.com/users/vaab/following{/other_user}","gists_url":"https://api.github.com/users/vaab/gists{/gist_id}","starred_url":"https://api.github.com/users/vaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaab/subscriptions","organizations_url":"https://api.github.com/users/vaab/orgs","repos_url":"https://api.github.com/users/vaab/repos","events_url":"https://api.github.com/users/vaab/events{/privacy}","received_events_url":"https://api.github.com/users/vaab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T07:57:05Z","updated_at":"2018-02-05T08:03:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chanind/hanzi-writer/pulls/42","html_url":"https://github.com/chanind/hanzi-writer/pull/42","diff_url":"https://github.com/chanind/hanzi-writer/pull/42.diff","patch_url":"https://github.com/chanind/hanzi-writer/pull/42.patch"},"body":"The user-defined function is now given a reject callback to trigger error\r\nconditions while loading new character data. Please note that the\r\nrunning code (not the user-defined function) is also given a chance to\r\nreject the promise (and thus trigger the calling of the error callback)\r\nwhen it receives a second loading request before the current one is\r\nfinished.\r\n\r\nThis should fix the issues with the error being reported only on next call \r\nif user-defined function doesn't handle errors itself correctly.\r\n\r\nPlease note that it doesn't provide a radical change of the API of the user defined function as I suggested in an open issue #41 ... and thus should remain mostly compatible with any custom made user function."},"comment":{"url":"https://api.github.com/repos/chanind/hanzi-writer/issues/comments/363008339","html_url":"https://github.com/chanind/hanzi-writer/pull/42#issuecomment-363008339","issue_url":"https://api.github.com/repos/chanind/hanzi-writer/issues/42","id":363008339,"user":{"login":"vaab","id":703255,"avatar_url":"https://avatars3.githubusercontent.com/u/703255?v=4","gravatar_id":"","url":"https://api.github.com/users/vaab","html_url":"https://github.com/vaab","followers_url":"https://api.github.com/users/vaab/followers","following_url":"https://api.github.com/users/vaab/following{/other_user}","gists_url":"https://api.github.com/users/vaab/gists{/gist_id}","starred_url":"https://api.github.com/users/vaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaab/subscriptions","organizations_url":"https://api.github.com/users/vaab/orgs","repos_url":"https://api.github.com/users/vaab/repos","events_url":"https://api.github.com/users/vaab/events{/privacy}","received_events_url":"https://api.github.com/users/vaab/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T08:03:44Z","updated_at":"2018-02-05T08:03:44Z","author_association":"NONE","body":"I just see that I didn't include the builds result with this patch applies (I'm talking of the new ``dist/*``). I can add them if you need them."}}
{"actor":{"display_login":"vaab"}}