{"action":"created","issue":{"url":"https://api.github.com/repos/disalvjn/faconne/issues/3","repository_url":"https://api.github.com/repos/disalvjn/faconne","labels_url":"https://api.github.com/repos/disalvjn/faconne/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/disalvjn/faconne/issues/3/comments","events_url":"https://api.github.com/repos/disalvjn/faconne/issues/3/events","html_url":"https://github.com/disalvjn/faconne/issues/3","id":376590064,"node_id":"MDU6SXNzdWUzNzY1OTAwNjQ=","number":3,"title":"1.1.0 broke code that worked on 1.0.3","user":{"login":"fmjrey","id":489016,"node_id":"MDQ6VXNlcjQ4OTAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/489016?v=4","gravatar_id":"","url":"https://api.github.com/users/fmjrey","html_url":"https://github.com/fmjrey","followers_url":"https://api.github.com/users/fmjrey/followers","following_url":"https://api.github.com/users/fmjrey/following{/other_user}","gists_url":"https://api.github.com/users/fmjrey/gists{/gist_id}","starred_url":"https://api.github.com/users/fmjrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmjrey/subscriptions","organizations_url":"https://api.github.com/users/fmjrey/orgs","repos_url":"https://api.github.com/users/fmjrey/repos","events_url":"https://api.github.com/users/fmjrey/events{/privacy}","received_events_url":"https://api.github.com/users/fmjrey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-01T22:07:46Z","updated_at":"2018-11-02T07:51:23Z","closed_at":null,"author_association":"NONE","body":"Not had time to investigate but here's the code that broke:\r\n```\r\n  (f/transform (x/parse xml)\r\n               ;; Parsed XML:\r\n               ;; <fixtures>\r\n               ;;   <fixture ...>\r\n               ;;     <team .../>\r\n               ;;     <team .../>\r\n               ;;   </fixture>\r\n               ;;   <fixture ...>\r\n               ;;     <team .../>\r\n               ;;     <team .../>\r\n               ;;   </fixture>\r\n               ;;   ...\r\n               ;;   <teams>\r\n               ;;     <team .../>\r\n               ;;     <team .../>\r\n               ;;     ...\r\n               ;;     <team .../>\r\n               ;;   </teams>\r\n               ;; </fixtures>\r\n               {:tag     :fixtures\r\n                :content [{:tag     tag,\r\n                           :attrs   attrs\r\n                           :content [{:tag   :team,\r\n                                      :attrs team1-attrs}\r\n                                     {:tag   :team,\r\n                                      :attrs team2-attrs}]}]}\r\n               ;; What we want\r\n               ;; {:fixtures [{... :teams [{} {}]}\r\n               ;;                 {... :teams [{} {}]}\r\n               ;;                 {... :teams [{} {}]}\r\n               ;;                 ...]\r\n               ;;  :teams [{} {} {} ...]}\r\n               {(case tag\r\n                  :fixture :fixtures\r\n                  :teams :teams)\r\n                (case tag\r\n                  :fixture [(assoc attrs :teams [team1-attrs team2-attrs])]\r\n                  :teams (if team2-attrs ;; nil when we have an odd number of teams\r\n                           [team1-attrs team2-attrs]\r\n                           [team1-attrs]))}))\r\n```\r\nAny advice?"},"comment":{"url":"https://api.github.com/repos/disalvjn/faconne/issues/comments/435298573","html_url":"https://github.com/disalvjn/faconne/issues/3#issuecomment-435298573","issue_url":"https://api.github.com/repos/disalvjn/faconne/issues/3","id":435298573,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTI5ODU3Mw==","user":{"login":"fmjrey","id":489016,"node_id":"MDQ6VXNlcjQ4OTAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/489016?v=4","gravatar_id":"","url":"https://api.github.com/users/fmjrey","html_url":"https://github.com/fmjrey","followers_url":"https://api.github.com/users/fmjrey/followers","following_url":"https://api.github.com/users/fmjrey/following{/other_user}","gists_url":"https://api.github.com/users/fmjrey/gists{/gist_id}","starred_url":"https://api.github.com/users/fmjrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmjrey/subscriptions","organizations_url":"https://api.github.com/users/fmjrey/orgs","repos_url":"https://api.github.com/users/fmjrey/repos","events_url":"https://api.github.com/users/fmjrey/events{/privacy}","received_events_url":"https://api.github.com/users/fmjrey/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T07:51:23Z","updated_at":"2018-11-02T07:51:23Z","author_association":"NONE","body":"Great explanation.\r\nI tried using ```` and `vector` instead of `[]` in vain.\r\n`@` sounds like a good idea then.\r\nThanks for the quick reply and also for your great lib!"}}
{"actor":{"display_login":"fmjrey"}}