{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/216448632","pull_request_review_id":153932467,"id":216448632,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ0ODYzMg==","diff_hunk":"@@ -383,6 +383,9 @@ const formConfig = {\n                     street2: {\n                       'ui:title': 'Address line 2'\n                     },\n+                    street3: {","path":"src/applications/edu-benefits/feedback-tool/config/form.js","position":13,"original_position":13,"commit_id":"7c70bc0cabff46ffd2b10734fbdf8b659df1894c","original_commit_id":"7c70bc0cabff46ffd2b10734fbdf8b659df1894c","user":{"login":"cehsu","id":16051172,"node_id":"MDQ6VXNlcjE2MDUxMTcy","avatar_url":"https://avatars1.githubusercontent.com/u/16051172?v=4","gravatar_id":"","url":"https://api.github.com/users/cehsu","html_url":"https://github.com/cehsu","followers_url":"https://api.github.com/users/cehsu/followers","following_url":"https://api.github.com/users/cehsu/following{/other_user}","gists_url":"https://api.github.com/users/cehsu/gists{/gist_id}","starred_url":"https://api.github.com/users/cehsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cehsu/subscriptions","organizations_url":"https://api.github.com/users/cehsu/orgs","repos_url":"https://api.github.com/users/cehsu/repos","events_url":"https://api.github.com/users/cehsu/events{/privacy}","received_events_url":"https://api.github.com/users/cehsu/received_events","type":"User","site_admin":false},"body":"We may need to transform this on the FE until the backend has included this transformation in its transformation list.","created_at":"2018-09-10T19:44:00Z","updated_at":"2018-09-10T19:46:11Z","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327#discussion_r216448632","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/216448632"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327#discussion_r216448632"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327","id":213649468,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjQ5NDY4","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8327","number":8327,"state":"open","locked":false,"title":"Change handling of school addresses from the search tool","user":{"login":"erikphansen","id":20728956,"node_id":"MDQ6VXNlcjIwNzI4OTU2","avatar_url":"https://avatars1.githubusercontent.com/u/20728956?v=4","gravatar_id":"","url":"https://api.github.com/users/erikphansen","html_url":"https://github.com/erikphansen","followers_url":"https://api.github.com/users/erikphansen/followers","following_url":"https://api.github.com/users/erikphansen/following{/other_user}","gists_url":"https://api.github.com/users/erikphansen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikphansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikphansen/subscriptions","organizations_url":"https://api.github.com/users/erikphansen/orgs","repos_url":"https://api.github.com/users/erikphansen/repos","events_url":"https://api.github.com/users/erikphansen/events{/privacy}","received_events_url":"https://api.github.com/users/erikphansen/received_events","type":"User","site_admin":false},"body":"## Description\r\n- [ ] Update package.json to use the new [version of JSON schema](https://github.com/department-of-veterans-affairs/vets-json-schema/pull/254) when it's ready\r\n- ~Combine the second and third address fields so no data is lost; this\r\nis especially important for some international addresses that the search\r\ntool returns as the many of those contain important address info in the\r\n`address3` field.~ We have instead moved to adding a `street3` field to the address object we send to the backend.\r\n- If the address from the search tool is domestic, transform the country\r\nto the prop enum value, \"United States\".\r\n- If the address is not domestic, send the country as-is and add the\r\n`viaSearchTool=true` field on the `address` so the backend will use the\r\nschool address schema that accepts any string for the country value.\r\n\r\n## Testing done\r\nUpdated unit tests to test handling of domestic and international addresses from the search tool.\r\n\r\n## Testing Plan\r\nThe format of addresses that come from the search tool vary widely. This calls for manual testing, especially of international addresses, to assure that the correct address data gets passed to the backend.\r\n\r\n## Screenshots\r\nN/A\r\n\r\n## Acceptance Criteria (Definition of Done)\r\n\r\n#### Unique to this PR\r\n- [x] Use the stricter schema for domestic addresses, use the more forgiving address schema for international addresses.\r\n\r\n#### Applies to all PRs\r\n\r\n- [ ] Appropriate logging\r\n- [ ] Documentation has been updated, if applicable\r\n- [x] Provide link to originating GitHub issue, or connected to it via ZenHub\r\n- [x] Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)\r\n- [ ] Provide which alerts would indicate a problem with this functionality (if applicable)","created_at":"2018-09-06T14:58:07Z","updated_at":"2018-09-10T19:46:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a19b66035e98c1ac759c14784f516349509553f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8327/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/7c70bc0cabff46ffd2b10734fbdf8b659df1894c","head":{"label":"department-of-veterans-affairs:search-tool-school-address","ref":"search-tool-school-address","sha":"7c70bc0cabff46ffd2b10734fbdf8b659df1894c","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIwMjY2Nw==","name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Frontend for Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2018-09-10T17:46:49Z","pushed_at":"2018-09-10T19:40:39Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":154284,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":57,"open_issues":107,"watchers":115,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"d3dddad6515187a795d61950818f9fca7a4ff7b3","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIwMjY2Nw==","name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Frontend for Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2018-09-10T17:46:49Z","pushed_at":"2018-09-10T19:40:39Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":154284,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":57,"open_issues":107,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/8327"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8327"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8327/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8327/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/7c70bc0cabff46ffd2b10734fbdf8b659df1894c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cehsu"}}