{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/170580403","pull_request_review_id":99286161,"id":170580403,"diff_hunk":"@@ -159,21 +169,30 @@ op_library(create_reader_op DEPS reader)\n \n # Regist multiple Kernel to pybind\n if (WITH_GPU)\n-\n-op_library(conv_op SRCS conv_op.cc conv_op.cu.cc conv_cudnn_op.cu.cc DEPS\n-    vol2col depthwise_conv)\n-\n-op_library(edit_distance_op SRCS edit_distance_op.cc edit_distance_op.cu DEPS math_function)\n-op_library(pool_op SRCS pool_op.cc pool_op.cu.cc pool_cudnn_op.cu.cc DEPS pooling)\n-op_library(conv_transpose_op SRCS conv_transpose_op.cc conv_transpose_op.cu.cc\n-  conv_transpose_cudnn_op.cu.cc DEPS vol2col)\n-file(APPEND ${pybind_file} \"USE_OP_DEVICE_KERNEL(conv2d, CUDNN);\\n\")\n-file(APPEND ${pybind_file} \"USE_OP_DEVICE_KERNEL(pool2d, CUDNN);\\n\")\n-file(APPEND ${pybind_file} \"USE_OP_DEVICE_KERNEL(conv2d_transpose, CUDNN);\\n\")\n+    op_library(edit_distance_op SRCS edit_distance_op.cc edit_distance_op.cu DEPS math_function)","path":"paddle/fluid/operators/CMakeLists.txt","position":82,"original_position":82,"commit_id":"62166662f1392432259002c48f6cb66065da1757","original_commit_id":"62166662f1392432259002c48f6cb66065da1757","user":{"login":"luotao1","id":6836917,"avatar_url":"https://avatars0.githubusercontent.com/u/6836917?v=4","gravatar_id":"","url":"https://api.github.com/users/luotao1","html_url":"https://github.com/luotao1","followers_url":"https://api.github.com/users/luotao1/followers","following_url":"https://api.github.com/users/luotao1/following{/other_user}","gists_url":"https://api.github.com/users/luotao1/gists{/gist_id}","starred_url":"https://api.github.com/users/luotao1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luotao1/subscriptions","organizations_url":"https://api.github.com/users/luotao1/orgs","repos_url":"https://api.github.com/users/luotao1/repos","events_url":"https://api.github.com/users/luotao1/events{/privacy}","received_events_url":"https://api.github.com/users/luotao1/received_events","type":"User","site_admin":false},"body":"We will pybind `USE_OP_DEVICE_KERNEL(XXX, CUDNN)` automatically in #8590, in order to make operators/CMakelists.txt much cleaner.\r\n\r\nThen, only one sentence `op_library(pool_op DEPS pooling)` will pybind CPU/CUDA/CUDNN/MKLDNN all device kernel.\r\n\r\nThus: \r\n- how about use `conv_mkldnn_op.cc` likes `conv_cudnn_op.cu.cc` instead of `conv_op.mn.cc`?\r\n- refine these codes after #8590 finished?","created_at":"2018-02-26T12:49:41Z","updated_at":"2018-02-26T12:49:42Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/8451#discussion_r170580403","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/170580403"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/8451#discussion_r170580403"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451","id":169428501,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/8451","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/8451.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/8451.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/8451","number":8451,"state":"open","locked":false,"title":"MKLDNN conv2d and pool2d OP kernels added","user":{"login":"pzelazko-intel","id":20774899,"avatar_url":"https://avatars3.githubusercontent.com/u/20774899?v=4","gravatar_id":"","url":"https://api.github.com/users/pzelazko-intel","html_url":"https://github.com/pzelazko-intel","followers_url":"https://api.github.com/users/pzelazko-intel/followers","following_url":"https://api.github.com/users/pzelazko-intel/following{/other_user}","gists_url":"https://api.github.com/users/pzelazko-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/pzelazko-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzelazko-intel/subscriptions","organizations_url":"https://api.github.com/users/pzelazko-intel/orgs","repos_url":"https://api.github.com/users/pzelazko-intel/repos","events_url":"https://api.github.com/users/pzelazko-intel/events{/privacy}","received_events_url":"https://api.github.com/users/pzelazko-intel/received_events","type":"User","site_admin":false},"body":"MKLDNN conv2d and pool2d OP kernels can be enabled with `use_mkldnn` OP flag - just like currenly present `use_cudnn` flag. It's set to `True` by default. `use_cudnn` flag has figher priority.\r\n\r\nBeside unit tests, we validated these kernels by running training and interference on MNIST dataset and comparing results with caffe library.\r\n","created_at":"2018-02-15T16:59:42Z","updated_at":"2018-02-26T12:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca9056ad756baf70894e7764be0a949e23bd8f93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tensor-tang","id":21351065,"avatar_url":"https://avatars0.githubusercontent.com/u/21351065?v=4","gravatar_id":"","url":"https://api.github.com/users/tensor-tang","html_url":"https://github.com/tensor-tang","followers_url":"https://api.github.com/users/tensor-tang/followers","following_url":"https://api.github.com/users/tensor-tang/following{/other_user}","gists_url":"https://api.github.com/users/tensor-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/tensor-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensor-tang/subscriptions","organizations_url":"https://api.github.com/users/tensor-tang/orgs","repos_url":"https://api.github.com/users/tensor-tang/repos","events_url":"https://api.github.com/users/tensor-tang/events{/privacy}","received_events_url":"https://api.github.com/users/tensor-tang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":831909412,"url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels/Intel","name":"Intel","color":"53a9d1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/8451/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/62166662f1392432259002c48f6cb66065da1757","head":{"label":"pzelazko-intel:fluid-mkldnn","ref":"fluid-mkldnn","sha":"62166662f1392432259002c48f6cb66065da1757","user":{"login":"pzelazko-intel","id":20774899,"avatar_url":"https://avatars3.githubusercontent.com/u/20774899?v=4","gravatar_id":"","url":"https://api.github.com/users/pzelazko-intel","html_url":"https://github.com/pzelazko-intel","followers_url":"https://api.github.com/users/pzelazko-intel/followers","following_url":"https://api.github.com/users/pzelazko-intel/following{/other_user}","gists_url":"https://api.github.com/users/pzelazko-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/pzelazko-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzelazko-intel/subscriptions","organizations_url":"https://api.github.com/users/pzelazko-intel/orgs","repos_url":"https://api.github.com/users/pzelazko-intel/repos","events_url":"https://api.github.com/users/pzelazko-intel/events{/privacy}","received_events_url":"https://api.github.com/users/pzelazko-intel/received_events","type":"User","site_admin":false},"repo":{"id":121651644,"name":"Paddle","full_name":"pzelazko-intel/Paddle","owner":{"login":"pzelazko-intel","id":20774899,"avatar_url":"https://avatars3.githubusercontent.com/u/20774899?v=4","gravatar_id":"","url":"https://api.github.com/users/pzelazko-intel","html_url":"https://github.com/pzelazko-intel","followers_url":"https://api.github.com/users/pzelazko-intel/followers","following_url":"https://api.github.com/users/pzelazko-intel/following{/other_user}","gists_url":"https://api.github.com/users/pzelazko-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/pzelazko-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzelazko-intel/subscriptions","organizations_url":"https://api.github.com/users/pzelazko-intel/orgs","repos_url":"https://api.github.com/users/pzelazko-intel/repos","events_url":"https://api.github.com/users/pzelazko-intel/events{/privacy}","received_events_url":"https://api.github.com/users/pzelazko-intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pzelazko-intel/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/pzelazko-intel/Paddle","forks_url":"https://api.github.com/repos/pzelazko-intel/Paddle/forks","keys_url":"https://api.github.com/repos/pzelazko-intel/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pzelazko-intel/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pzelazko-intel/Paddle/teams","hooks_url":"https://api.github.com/repos/pzelazko-intel/Paddle/hooks","issue_events_url":"https://api.github.com/repos/pzelazko-intel/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/pzelazko-intel/Paddle/events","assignees_url":"https://api.github.com/repos/pzelazko-intel/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/pzelazko-intel/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/pzelazko-intel/Paddle/tags","blobs_url":"https://api.github.com/repos/pzelazko-intel/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pzelazko-intel/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pzelazko-intel/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pzelazko-intel/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pzelazko-intel/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/pzelazko-intel/Paddle/languages","stargazers_url":"https://api.github.com/repos/pzelazko-intel/Paddle/stargazers","contributors_url":"https://api.github.com/repos/pzelazko-intel/Paddle/contributors","subscribers_url":"https://api.github.com/repos/pzelazko-intel/Paddle/subscribers","subscription_url":"https://api.github.com/repos/pzelazko-intel/Paddle/subscription","commits_url":"https://api.github.com/repos/pzelazko-intel/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pzelazko-intel/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pzelazko-intel/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pzelazko-intel/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pzelazko-intel/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/pzelazko-intel/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pzelazko-intel/Paddle/merges","archive_url":"https://api.github.com/repos/pzelazko-intel/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pzelazko-intel/Paddle/downloads","issues_url":"https://api.github.com/repos/pzelazko-intel/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/pzelazko-intel/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/pzelazko-intel/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/pzelazko-intel/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pzelazko-intel/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/pzelazko-intel/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/pzelazko-intel/Paddle/deployments","created_at":"2018-02-15T16:21:40Z","updated_at":"2018-02-15T16:21:48Z","pushed_at":"2018-02-20T17:22:56Z","git_url":"git://github.com/pzelazko-intel/Paddle.git","ssh_url":"git@github.com:pzelazko-intel/Paddle.git","clone_url":"https://github.com/pzelazko-intel/Paddle.git","svn_url":"https://github.com/pzelazko-intel/Paddle","homepage":"http://www.paddlepaddle.org/","size":92795,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"a040239d3a438f48ee05491e9f7a56fa499a2fdb","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2018-02-26T11:17:09Z","pushed_at":"2018-02-26T12:39:10Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":93591,"stargazers_count":6454,"watchers_count":6454,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1699,"mirror_url":null,"archived":false,"open_issues_count":1227,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1699,"open_issues":1227,"watchers":6454,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/8451"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/8451"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/8451/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/8451/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/62166662f1392432259002c48f6cb66065da1757"}},"author_association":"NONE"}}
{"actor":{"display_login":"luotao1"}}