{"action":"created","comment":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/comments/225650693","pull_request_review_id":165296682,"id":225650693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY1MDY5Mw==","diff_hunk":"@@ -11,7 +11,7 @@\n   \"requirements\": [\n     {\n       \"name\": \"puppet\",\n-      \"version_requirement\": \">= 4.7.1 < 6.0.0\"\n+      \"version_requirement\": \">= 4.7.1 < 7.0.0\"","path":"metadata.json","position":5,"original_position":5,"commit_id":"3ced1dab7b8cab262b57b9f366a441472be2d147","original_commit_id":"3ced1dab7b8cab262b57b9f366a441472be2d147","user":{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"do the new functions actually work with puppet 4.7.1 or do they require puppet5/4.10?","created_at":"2018-10-16T18:09:36Z","updated_at":"2018-10-16T18:10:11Z","html_url":"https://github.com/solarkennedy/puppet-consul/pull/444#discussion_r225650693","pull_request_url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/comments/225650693"},"html":{"href":"https://github.com/solarkennedy/puppet-consul/pull/444#discussion_r225650693"},"pull_request":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444","id":223226709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjI2NzA5","html_url":"https://github.com/solarkennedy/puppet-consul/pull/444","diff_url":"https://github.com/solarkennedy/puppet-consul/pull/444.diff","patch_url":"https://github.com/solarkennedy/puppet-consul/pull/444.patch","issue_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/444","number":444,"state":"open","locked":false,"title":"Puppet 6 support","user":{"login":"l-lotz","id":36542536,"node_id":"MDQ6VXNlcjM2NTQyNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36542536?v=4","gravatar_id":"","url":"https://api.github.com/users/l-lotz","html_url":"https://github.com/l-lotz","followers_url":"https://api.github.com/users/l-lotz/followers","following_url":"https://api.github.com/users/l-lotz/following{/other_user}","gists_url":"https://api.github.com/users/l-lotz/gists{/gist_id}","starred_url":"https://api.github.com/users/l-lotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-lotz/subscriptions","organizations_url":"https://api.github.com/users/l-lotz/orgs","repos_url":"https://api.github.com/users/l-lotz/repos","events_url":"https://api.github.com/users/l-lotz/events{/privacy}","received_events_url":"https://api.github.com/users/l-lotz/received_events","type":"User","site_admin":false},"body":"This pull request makes the consul module run under puppet 6. It converts the functions from the legacy puppet 3.x API to the new puppet function API. It also adds unit tests to the travis jobs for puppet6 to ensure future compatibility.","created_at":"2018-10-16T12:16:16Z","updated_at":"2018-10-16T18:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc38b01ff2ff861f9dbb9b9a8329e1cb6d65bac3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444/commits","review_comments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444/comments","review_comment_url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/444/comments","statuses_url":"https://api.github.com/repos/solarkennedy/puppet-consul/statuses/3ced1dab7b8cab262b57b9f366a441472be2d147","head":{"label":"l-lotz:puppet6","ref":"puppet6","sha":"3ced1dab7b8cab262b57b9f366a441472be2d147","user":{"login":"l-lotz","id":36542536,"node_id":"MDQ6VXNlcjM2NTQyNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36542536?v=4","gravatar_id":"","url":"https://api.github.com/users/l-lotz","html_url":"https://github.com/l-lotz","followers_url":"https://api.github.com/users/l-lotz/followers","following_url":"https://api.github.com/users/l-lotz/following{/other_user}","gists_url":"https://api.github.com/users/l-lotz/gists{/gist_id}","starred_url":"https://api.github.com/users/l-lotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-lotz/subscriptions","organizations_url":"https://api.github.com/users/l-lotz/orgs","repos_url":"https://api.github.com/users/l-lotz/repos","events_url":"https://api.github.com/users/l-lotz/events{/privacy}","received_events_url":"https://api.github.com/users/l-lotz/received_events","type":"User","site_admin":false},"repo":{"id":148321106,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMjExMDY=","name":"puppet-consul","full_name":"l-lotz/puppet-consul","private":false,"owner":{"login":"l-lotz","id":36542536,"node_id":"MDQ6VXNlcjM2NTQyNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36542536?v=4","gravatar_id":"","url":"https://api.github.com/users/l-lotz","html_url":"https://github.com/l-lotz","followers_url":"https://api.github.com/users/l-lotz/followers","following_url":"https://api.github.com/users/l-lotz/following{/other_user}","gists_url":"https://api.github.com/users/l-lotz/gists{/gist_id}","starred_url":"https://api.github.com/users/l-lotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-lotz/subscriptions","organizations_url":"https://api.github.com/users/l-lotz/orgs","repos_url":"https://api.github.com/users/l-lotz/repos","events_url":"https://api.github.com/users/l-lotz/events{/privacy}","received_events_url":"https://api.github.com/users/l-lotz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/l-lotz/puppet-consul","description":"A Puppet Module to Manage Consul","fork":true,"url":"https://api.github.com/repos/l-lotz/puppet-consul","forks_url":"https://api.github.com/repos/l-lotz/puppet-consul/forks","keys_url":"https://api.github.com/repos/l-lotz/puppet-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l-lotz/puppet-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l-lotz/puppet-consul/teams","hooks_url":"https://api.github.com/repos/l-lotz/puppet-consul/hooks","issue_events_url":"https://api.github.com/repos/l-lotz/puppet-consul/issues/events{/number}","events_url":"https://api.github.com/repos/l-lotz/puppet-consul/events","assignees_url":"https://api.github.com/repos/l-lotz/puppet-consul/assignees{/user}","branches_url":"https://api.github.com/repos/l-lotz/puppet-consul/branches{/branch}","tags_url":"https://api.github.com/repos/l-lotz/puppet-consul/tags","blobs_url":"https://api.github.com/repos/l-lotz/puppet-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l-lotz/puppet-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l-lotz/puppet-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/l-lotz/puppet-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l-lotz/puppet-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/l-lotz/puppet-consul/languages","stargazers_url":"https://api.github.com/repos/l-lotz/puppet-consul/stargazers","contributors_url":"https://api.github.com/repos/l-lotz/puppet-consul/contributors","subscribers_url":"https://api.github.com/repos/l-lotz/puppet-consul/subscribers","subscription_url":"https://api.github.com/repos/l-lotz/puppet-consul/subscription","commits_url":"https://api.github.com/repos/l-lotz/puppet-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/l-lotz/puppet-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/l-lotz/puppet-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/l-lotz/puppet-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/l-lotz/puppet-consul/contents/{+path}","compare_url":"https://api.github.com/repos/l-lotz/puppet-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l-lotz/puppet-consul/merges","archive_url":"https://api.github.com/repos/l-lotz/puppet-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l-lotz/puppet-consul/downloads","issues_url":"https://api.github.com/repos/l-lotz/puppet-consul/issues{/number}","pulls_url":"https://api.github.com/repos/l-lotz/puppet-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/l-lotz/puppet-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/l-lotz/puppet-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l-lotz/puppet-consul/labels{/name}","releases_url":"https://api.github.com/repos/l-lotz/puppet-consul/releases{/id}","deployments_url":"https://api.github.com/repos/l-lotz/puppet-consul/deployments","created_at":"2018-09-11T13:23:56Z","updated_at":"2018-10-15T12:06:29Z","pushed_at":"2018-10-16T11:19:11Z","git_url":"git://github.com/l-lotz/puppet-consul.git","ssh_url":"git@github.com:l-lotz/puppet-consul.git","clone_url":"https://github.com/l-lotz/puppet-consul.git","svn_url":"https://github.com/l-lotz/puppet-consul","homepage":null,"size":684,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solarkennedy:master","ref":"master","sha":"6b9955e038d02e11a4c95aa554d5f943cdd3600a","user":{"login":"solarkennedy","id":370205,"node_id":"MDQ6VXNlcjM3MDIwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/370205?v=4","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"repo":{"id":18902797,"node_id":"MDEwOlJlcG9zaXRvcnkxODkwMjc5Nw==","name":"puppet-consul","full_name":"solarkennedy/puppet-consul","private":false,"owner":{"login":"solarkennedy","id":370205,"node_id":"MDQ6VXNlcjM3MDIwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/370205?v=4","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/solarkennedy/puppet-consul","description":"A Puppet Module to Manage Consul","fork":false,"url":"https://api.github.com/repos/solarkennedy/puppet-consul","forks_url":"https://api.github.com/repos/solarkennedy/puppet-consul/forks","keys_url":"https://api.github.com/repos/solarkennedy/puppet-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solarkennedy/puppet-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solarkennedy/puppet-consul/teams","hooks_url":"https://api.github.com/repos/solarkennedy/puppet-consul/hooks","issue_events_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/events{/number}","events_url":"https://api.github.com/repos/solarkennedy/puppet-consul/events","assignees_url":"https://api.github.com/repos/solarkennedy/puppet-consul/assignees{/user}","branches_url":"https://api.github.com/repos/solarkennedy/puppet-consul/branches{/branch}","tags_url":"https://api.github.com/repos/solarkennedy/puppet-consul/tags","blobs_url":"https://api.github.com/repos/solarkennedy/puppet-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solarkennedy/puppet-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solarkennedy/puppet-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/solarkennedy/puppet-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solarkennedy/puppet-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/solarkennedy/puppet-consul/languages","stargazers_url":"https://api.github.com/repos/solarkennedy/puppet-consul/stargazers","contributors_url":"https://api.github.com/repos/solarkennedy/puppet-consul/contributors","subscribers_url":"https://api.github.com/repos/solarkennedy/puppet-consul/subscribers","subscription_url":"https://api.github.com/repos/solarkennedy/puppet-consul/subscription","commits_url":"https://api.github.com/repos/solarkennedy/puppet-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/solarkennedy/puppet-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/solarkennedy/puppet-consul/contents/{+path}","compare_url":"https://api.github.com/repos/solarkennedy/puppet-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solarkennedy/puppet-consul/merges","archive_url":"https://api.github.com/repos/solarkennedy/puppet-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solarkennedy/puppet-consul/downloads","issues_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues{/number}","pulls_url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/solarkennedy/puppet-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/solarkennedy/puppet-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solarkennedy/puppet-consul/labels{/name}","releases_url":"https://api.github.com/repos/solarkennedy/puppet-consul/releases{/id}","deployments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/deployments","created_at":"2014-04-18T04:42:17Z","updated_at":"2018-10-16T17:06:00Z","pushed_at":"2018-10-16T12:16:17Z","git_url":"git://github.com/solarkennedy/puppet-consul.git","ssh_url":"git@github.com:solarkennedy/puppet-consul.git","clone_url":"https://github.com/solarkennedy/puppet-consul.git","svn_url":"https://github.com/solarkennedy/puppet-consul","homepage":null,"size":682,"stargazers_count":104,"watchers_count":104,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":256,"open_issues":32,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444"},"html":{"href":"https://github.com/solarkennedy/puppet-consul/pull/444"},"issue":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/444"},"comments":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/solarkennedy/puppet-consul/statuses/3ced1dab7b8cab262b57b9f366a441472be2d147"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bastelfreak"}}