{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/187723567","pull_request_review_id":119567829,"id":187723567,"diff_hunk":"@@ -150,12 +151,24 @@ message Cluster {\n   // when picking a host in the cluster.\n   LbPolicy lb_policy = 6 [(validate.rules).enum.defined_only = true];\n \n-  // If the service discovery type is\n+  // Setting this as a requirement for clusters with discovery type\n   // :ref:`STATIC<envoy_api_enum_value_Cluster.DiscoveryType.STATIC>`,\n   // :ref:`STRICT_DNS<envoy_api_enum_value_Cluster.DiscoveryType.STRICT_DNS>`\n-  // or :ref:`LOGICAL_DNS<envoy_api_enum_value_Cluster.DiscoveryType.LOGICAL_DNS>`,\n-  // then hosts is required.\n-  repeated core.Address hosts = 7;\n+  // or :ref:`LOGICAL_DNS<envoy_api_enum_value_Cluster.DiscoveryType.LOGICAL_DNS>`\n+  // is deprecated. Set the :ref:`endpoints<envoy_api_field_Cluster.endpoints>` field\n+  // instead.\n+  repeated core.Address hosts = 7 [deprecated = true];\n+\n+  // Setting this is required for specifying members of\n+  // :ref:`STATIC<envoy_api_enum_value_Cluster.DiscoveryType.STATIC>`,\n+  // :ref:`STRICT_DNS<envoy_api_enum_value_Cluster.DiscoveryType.STRICT_DNS>`\n+  // or :ref:`LOGICAL_DNS<envoy_api_enum_value_Cluster.DiscoveryType.LOGICAL_DNS>` clusters.\n+  // This field supersedes :ref:`hosts<envoy_api_field_Cluster.hosts>` field.\n+  //\n+  // .. attention::\n+  //\n+  //   Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values.","path":"api/envoy/api/v2/cds.proto","position":32,"original_position":32,"commit_id":"675bb90f4100280dc5c0aee494e6b6ae289587d0","original_commit_id":"bd6ac4263c54aa4a0f277def1e2cb288af3b5b5f","user":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"body":"An interesting aspect of this PR is that we now support logical DNS in embedded ClusterLoadAssignments. This didn't use to work, we had a number of questions about this IIRC.","created_at":"2018-05-11T20:23:22Z","updated_at":"2018-05-11T20:35:20Z","html_url":"https://github.com/envoyproxy/envoy/pull/3261#discussion_r187723567","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/187723567"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3261#discussion_r187723567"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261"}},"in_reply_to_id":185686821},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261","id":185155448,"html_url":"https://github.com/envoyproxy/envoy/pull/3261","diff_url":"https://github.com/envoyproxy/envoy/pull/3261.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3261.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3261","number":3261,"state":"open","locked":false,"title":"upstream: add load_assigment field to Cluster","user":{"login":"dio","id":73152,"avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"body":"upstream: add load_assigment field to cds' Cluster \r\n\r\nThis patch introduces `load_assigment` field in cds' `Cluster`. \r\nThis change specifically adds the implementation of the new `load_assigment` field \r\nfor clusters with discovery-type: `STATIC`, `STRICT_DNS` and `LOGICAL_DNS`.\r\n\r\n*Risk Level*: Low, since it maintains the current behavior and tests.\r\n\r\n*Testing*: unit tests.\r\n\r\n*Docs Changes*:\r\n\r\n- This unhides docs for endpoint health check config\r\n- This adds docs for Cluster's `load_assigment` field.\r\n\r\n*Release Notes*:\r\n\r\n- *TBD* upstream: added a new load_assigment field to cds' Cluster.\r\n\r\nFixes #439 \r\n\r\nTODOs:\r\n- [ ] accomodate locality for `STATIC`\r\n- [ ] accomodate locality for `STRICT_DNS`\r\n- [ ] accomodate locality for `LOGICAL_DNS`","created_at":"2018-05-01T10:30:53Z","updated_at":"2018-05-11T20:35:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"719a4dd8e8c7c1402b9c335ee90ab7fca48f56eb","assignee":{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3261/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/675bb90f4100280dc5c0aee494e6b6ae289587d0","head":{"label":"dio:health-check-config-more","ref":"health-check-config-more","sha":"675bb90f4100280dc5c0aee494e6b6ae289587d0","user":{"login":"dio","id":73152,"avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"repo":{"id":105332260,"name":"envoy","full_name":"dio/envoy","owner":{"login":"dio","id":73152,"avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dio/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/dio/envoy","forks_url":"https://api.github.com/repos/dio/envoy/forks","keys_url":"https://api.github.com/repos/dio/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dio/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dio/envoy/teams","hooks_url":"https://api.github.com/repos/dio/envoy/hooks","issue_events_url":"https://api.github.com/repos/dio/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/dio/envoy/events","assignees_url":"https://api.github.com/repos/dio/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/dio/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/dio/envoy/tags","blobs_url":"https://api.github.com/repos/dio/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dio/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dio/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dio/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dio/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/dio/envoy/languages","stargazers_url":"https://api.github.com/repos/dio/envoy/stargazers","contributors_url":"https://api.github.com/repos/dio/envoy/contributors","subscribers_url":"https://api.github.com/repos/dio/envoy/subscribers","subscription_url":"https://api.github.com/repos/dio/envoy/subscription","commits_url":"https://api.github.com/repos/dio/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dio/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dio/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dio/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dio/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/dio/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dio/envoy/merges","archive_url":"https://api.github.com/repos/dio/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dio/envoy/downloads","issues_url":"https://api.github.com/repos/dio/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/dio/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/dio/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/dio/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dio/envoy/labels{/name}","releases_url":"https://api.github.com/repos/dio/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/dio/envoy/deployments","created_at":"2017-09-30T01:53:34Z","updated_at":"2018-05-10T09:43:43Z","pushed_at":"2018-05-11T13:55:12Z","git_url":"git://github.com/dio/envoy.git","ssh_url":"git@github.com:dio/envoy.git","clone_url":"https://github.com/dio/envoy.git","svn_url":"https://github.com/dio/envoy","homepage":"https://envoyproxy.github.io/","size":53492,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"efc5456568fce091bfeeb339ca42459ef7a1016d","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-05-11T20:24:24Z","pushed_at":"2018-05-11T20:24:20Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":15405,"stargazers_count":4852,"watchers_count":4852,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":615,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":615,"open_issues":317,"watchers":4852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3261"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3261"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3261/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3261/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/675bb90f4100280dc5c0aee494e6b6ae289587d0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"htuch"}}