{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71124","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71124/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71124/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71124/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71124","id":381540284,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDgzNjYx","number":71124,"title":"Make fluentd container runtime service configurable.","user":{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":148734819,"node_id":"MDU6TGFiZWwxNDg3MzQ4MTk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/logging","name":"area/logging","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":679979244,"node_id":"MDU6TGFiZWw2Nzk5NzkyNDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/gcp","name":"sig/gcp","color":"d2b48c","default":false},{"id":482207917,"node_id":"MDU6TGFiZWw0ODIyMDc5MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"loburm","id":7943996,"node_id":"MDQ6VXNlcjc5NDM5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7943996?v=4","gravatar_id":"","url":"https://api.github.com/users/loburm","html_url":"https://github.com/loburm","followers_url":"https://api.github.com/users/loburm/followers","following_url":"https://api.github.com/users/loburm/following{/other_user}","gists_url":"https://api.github.com/users/loburm/gists{/gist_id}","starred_url":"https://api.github.com/users/loburm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loburm/subscriptions","organizations_url":"https://api.github.com/users/loburm/orgs","repos_url":"https://api.github.com/users/loburm/repos","events_url":"https://api.github.com/users/loburm/events{/privacy}","received_events_url":"https://api.github.com/users/loburm/received_events","type":"User","site_admin":false},"assignees":[{"login":"dchen1107","id":7740897,"node_id":"MDQ6VXNlcjc3NDA4OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7740897?v=4","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},{"login":"loburm","id":7943996,"node_id":"MDQ6VXNlcjc5NDM5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7943996?v=4","gravatar_id":"","url":"https://api.github.com/users/loburm","html_url":"https://github.com/loburm","followers_url":"https://api.github.com/users/loburm/followers","following_url":"https://api.github.com/users/loburm/following{/other_user}","gists_url":"https://api.github.com/users/loburm/gists{/gist_id}","starred_url":"https://api.github.com/users/loburm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loburm/subscriptions","organizations_url":"https://api.github.com/users/loburm/orgs","repos_url":"https://api.github.com/users/loburm/repos","events_url":"https://api.github.com/users/loburm/events{/privacy}","received_events_url":"https://api.github.com/users/loburm/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},{"login":"piosz","id":10819974,"node_id":"MDQ6VXNlcjEwODE5OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40","html_url":"https://github.com/kubernetes/kubernetes/milestone/40","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40/labels","id":2913713,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMw==","number":40,"title":"v1.13","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":292,"state":"open","created_at":"2017-11-15T06:32:59Z","updated_at":"2018-11-21T01:31:25Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-11-16T10:30:22Z","updated_at":"2018-11-21T02:18:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71124","html_url":"https://github.com/kubernetes/kubernetes/pull/71124","diff_url":"https://github.com/kubernetes/kubernetes/pull/71124.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71124.patch"},"body":"This doesn't change any existing logic.\r\n\r\nThis fixes a bug on GCE, and only affects GCE.\r\n\r\nPreviously, we were using the same environment variable `CONTAINER_RUNTIME_NAME` for both [fluentd config](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L2242), and [health-monitor](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/health-monitor.sh#L31).\r\n\r\nHowever, this causes an issue on GCE and GKE that when the master is using Docker, and nodes are using other container runtimes (e.g. containerd). There is no way to set master env to configure fluentd to collect containerd logs on nodes, but still run docker health monitor on master, because there is only one `CONTAINER_RUNTIME_NAME` environment variable.\r\n\r\nThis is a critical urgent issue fix for Kubernetes on GCE.\r\n\r\n```release-note\r\nnone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/440504007","html_url":"https://github.com/kubernetes/kubernetes/pull/71124#issuecomment-440504007","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71124","id":440504007,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDUwNDAwNw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T02:18:35Z","updated_at":"2018-11-21T02:18:35Z","author_association":"CONTRIBUTOR","body":"@Random-Liu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gke | 1670b4089a82eb2cba582645d9993da3884bd360 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71124/pull-kubernetes-e2e-gke/3458/) | `/test pull-kubernetes-e2e-gke`\n\n[Full PR test history](https://gubernator.k8s.io/pr/71124). [Your PR dashboard](https://gubernator.k8s.io/pr/Random-Liu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}