{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/202255029","pull_request_review_id":136918953,"id":202255029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjI1NTAyOQ==","diff_hunk":"@@ -516,10 +545,23 @@ func edsClientCount() int {\n \treturn n\n }\n \n-// adsPushAll implements old style invalidation, generated when any rule or endpoint changes.\n+// AdsPushAll implements old style invalidation, generated when any rule or endpoint changes.\n // Primary code path is from v1 discoveryService.clearCache(), which is added as a handler\n // to the model ConfigStorageCache and Controller.\n-func adsPushAll() {\n+func AdsPushAll(s *DiscoveryServer) {\n+\tversionMutex.Lock()\n+\tversion = time.Now()\n+\tversionMutex.Unlock()\n+\n+\ts.modelMutex.RLock()\n+\tadsLog.Infof(\"XDS: Registry event, pushing. Services: %d, \"+\n+\t\t\"VirtualServices: %d, ConnectedEndpoints: %d\", len(s.services), len(s.virtualServices), edsClientCount())","path":"pilot/pkg/proxy/envoy/v2/ads.go","position":170,"original_position":170,"commit_id":"1fef3b0fd21ca0c46167ac2879971e1b08515e3a","original_commit_id":"1fef3b0fd21ca0c46167ac2879971e1b08515e3a","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"Yes, but I think it's still very useful - I greatly reduced the verbosity, but it helps to see the timing.\r\nThis one in particular is super useful - I can get rid of the individual EDS pushes for example.","created_at":"2018-07-13T06:32:15Z","updated_at":"2018-07-13T06:32:16Z","html_url":"https://github.com/istio/istio/pull/6946#discussion_r202255029","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6946","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/202255029"},"html":{"href":"https://github.com/istio/istio/pull/6946#discussion_r202255029"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6946"}},"in_reply_to_id":202219431},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6946","id":200240473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjQwNDcz","html_url":"https://github.com/istio/istio/pull/6946","diff_url":"https://github.com/istio/istio/pull/6946.diff","patch_url":"https://github.com/istio/istio/pull/6946.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6946","number":6946,"state":"open","locked":false,"title":"Polishing for messages, reporting, metrics","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"- added more info about the service, to report and possibly reject latest changes if they have conflicts\r\n- improved error messages\r\n- adding more metrics\r\n(I'll keep adding)","created_at":"2018-07-09T22:51:29Z","updated_at":"2018-07-13T06:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b259e750557b7c769f8d0b72aa42bbc70b4f4e50","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":780123031,"node_id":"MDU6TGFiZWw3ODAxMjMwMzE=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6946/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6946/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6946/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/1fef3b0fd21ca0c46167ac2879971e1b08515e3a","head":{"label":"costinm:10-version","ref":"10-version","sha":"1fef3b0fd21ca0c46167ac2879971e1b08515e3a","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"repo":{"id":100538352,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MzgzNTI=","name":"istio","full_name":"costinm/istio","owner":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/costinm/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/costinm/istio","forks_url":"https://api.github.com/repos/costinm/istio/forks","keys_url":"https://api.github.com/repos/costinm/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/costinm/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/costinm/istio/teams","hooks_url":"https://api.github.com/repos/costinm/istio/hooks","issue_events_url":"https://api.github.com/repos/costinm/istio/issues/events{/number}","events_url":"https://api.github.com/repos/costinm/istio/events","assignees_url":"https://api.github.com/repos/costinm/istio/assignees{/user}","branches_url":"https://api.github.com/repos/costinm/istio/branches{/branch}","tags_url":"https://api.github.com/repos/costinm/istio/tags","blobs_url":"https://api.github.com/repos/costinm/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/costinm/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/costinm/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/costinm/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/costinm/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/costinm/istio/languages","stargazers_url":"https://api.github.com/repos/costinm/istio/stargazers","contributors_url":"https://api.github.com/repos/costinm/istio/contributors","subscribers_url":"https://api.github.com/repos/costinm/istio/subscribers","subscription_url":"https://api.github.com/repos/costinm/istio/subscription","commits_url":"https://api.github.com/repos/costinm/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/costinm/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/costinm/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/costinm/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/costinm/istio/contents/{+path}","compare_url":"https://api.github.com/repos/costinm/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/costinm/istio/merges","archive_url":"https://api.github.com/repos/costinm/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/costinm/istio/downloads","issues_url":"https://api.github.com/repos/costinm/istio/issues{/number}","pulls_url":"https://api.github.com/repos/costinm/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/costinm/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/costinm/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/costinm/istio/labels{/name}","releases_url":"https://api.github.com/repos/costinm/istio/releases{/id}","deployments_url":"https://api.github.com/repos/costinm/istio/deployments","created_at":"2017-08-16T22:38:24Z","updated_at":"2018-04-27T23:29:00Z","pushed_at":"2018-07-13T00:26:48Z","git_url":"git://github.com/costinm/istio.git","ssh_url":"git@github.com:costinm/istio.git","clone_url":"https://github.com/costinm/istio.git","svn_url":"https://github.com/costinm/istio","homepage":"https://istio.io","size":123024,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.0","ref":"release-1.0","sha":"f19d1c6e6fe26c4c28b167e7774e1f0dbc338369","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-07-13T05:53:28Z","pushed_at":"2018-07-13T06:24:32Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":41356,"stargazers_count":9281,"watchers_count":9281,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1295,"mirror_url":null,"archived":false,"open_issues_count":797,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1295,"open_issues":797,"watchers":9281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6946"},"html":{"href":"https://github.com/istio/istio/pull/6946"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6946"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6946/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6946/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6946/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/1fef3b0fd21ca0c46167ac2879971e1b08515e3a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"costinm"}}