{"push_id":3140290178,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"204e3f1fabd133247df77c3b28bec76c6cfcc40a","before":"cc79ed28f6d6931a3c87c0d3ab397b8dae20bbbd","commits":[{"sha":"0205a4e0b51287959f329f6a00f432e4d48de346","author":{"name":"Willy Tarreau","email":"aff024fe4ab0fece4091de044c58c9ae4233383a@1wt.eu"},"message":"MINOR: tools: preset the port of fd-based \"sockets\" to zero\n\nAddresses made of a file descriptor store the file descriptor into the\naddress part of a sin_addr. Contrary to other address classes, there's\nno way to figure later based on the FD if an initialization was done\n(which is how logs initialize their FDs). The port part is currently\nleft with random data, so let's instead specifically set the port part\nto zero when creating an FD, and let the code using it set whatever\ninfo it needs there, typically an initialization state.","distinct":true,"url":"https://api.github.com/repos/haproxy/haproxy/commits/0205a4e0b51287959f329f6a00f432e4d48de346"},{"sha":"204e3f1fabd133247df77c3b28bec76c6cfcc40a","author":{"name":"Willy Tarreau","email":"aff024fe4ab0fece4091de044c58c9ae4233383a@1wt.eu"},"message":"BUG/MINOR: log: fix logging to both FD and IP\n\nPiBa-NL reported an issue affecting logs when stdout is enabled at the\nsame time as an IP address. It does not affect FD and UNIX, but does\nstill affect multiple FDs. What happens is that the condition to detect\nthat the initialization was not made relies on the FD being -1, and in\nthis case the FD points to the *unique* FD used for AF_INET sockets, so\nthe configured socket used for outgoing logs over UDP gets overwritten\nby the last configured FD. This is not appropriate, so instead we rely\non the sin_port part of the IPv4-mapped address to store the\ninitialization state for each FD.\n\nThis part deserves being significantly revamped, as IPv6 is still not\npossible due to the way the FDs are managed, and inherited FDs are a\nbit hackish.\n\nNote that this patch relies on \"MINOR: tools: preset the port of\nfd-based \"sockets\" to zero\" in order to operate properly.\n\nNo backport is needed.","distinct":true,"url":"https://api.github.com/repos/haproxy/haproxy/commits/204e3f1fabd133247df77c3b28bec76c6cfcc40a"}]}
{"actor":{"display_login":"haproxy-mirror"}}