{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/217719415","pull_request_review_id":155503706,"id":217719415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcxOTQxNQ==","diff_hunk":"@@ -28,6 +28,9 @@ rustPlatform.buildRustPackage rec {\n \n   LIBGIT2_SYS_USE_PKG_CONFIG=1;\n \n+  # fixes: the cargo feature `edition` requires a nightly version of Cargo, but this is the `stable` channel","path":"pkgs/development/compilers/rust/cargo.nix","position":4,"original_position":4,"commit_id":"ffafe959ee302fe645a77dfae9a719b5d6709fa3","original_commit_id":"ffafe959ee302fe645a77dfae9a719b5d6709fa3","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"Do they build there own rustc also with rust-nightly?","created_at":"2018-09-14T13:50:16Z","updated_at":"2018-09-14T13:50:16Z","html_url":"https://github.com/NixOS/nixpkgs/pull/46647#discussion_r217719415","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/217719415"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/46647#discussion_r217719415"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647","id":215593631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTkzNjMx","html_url":"https://github.com/NixOS/nixpkgs/pull/46647","diff_url":"https://github.com/NixOS/nixpkgs/pull/46647.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/46647.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46647","number":46647,"state":"open","locked":false,"title":"rustc: 1.27 -> 1.29","user":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nrls is buggy on 1.27\r\n\r\nChangelog: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1290-2018-09-13\r\n\r\n###### Things done\r\n\r\nI tried to build with tests enabled. It first failed on some gdb tests which depend on the gdb version. I disabled them, and the next batch of tests also contained some failing tests so I gave up.\r\n\r\nI built eog (depending on librsvg), firefox and fd (on x86_64-linux). Firefox needs a patch from upstream. cc @taku0 who has been updating firefox for some time.\r\n\r\ncc @madjar @cstrahan @wizeman @globin @havvy @wkennington as maintainers.\r\n","created_at":"2018-09-14T13:25:32Z","updated_at":"2018-09-14T13:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd48c29409ced029b34339a5729fb9eedf0b6a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LnL7","id":689294,"node_id":"MDQ6VXNlcjY4OTI5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/689294?v=4","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":731735640,"node_id":"MDU6TGFiZWw3MzE3MzU2NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20101-500","name":"10.rebuild-darwin: 101-500","color":"d93f0b","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":333381548,"node_id":"MDU6TGFiZWwzMzMzODE1NDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20rust","name":"6.topic: rust","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46647/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ffafe959ee302fe645a77dfae9a719b5d6709fa3","head":{"label":"symphorien:rust-1.29","ref":"rust-1.29","sha":"ffafe959ee302fe645a77dfae9a719b5d6709fa3","user":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"repo":{"id":77236175,"node_id":"MDEwOlJlcG9zaXRvcnk3NzIzNjE3NQ==","name":"nixpkgs","full_name":"symphorien/nixpkgs","owner":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/symphorien/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/symphorien/nixpkgs","forks_url":"https://api.github.com/repos/symphorien/nixpkgs/forks","keys_url":"https://api.github.com/repos/symphorien/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symphorien/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symphorien/nixpkgs/teams","hooks_url":"https://api.github.com/repos/symphorien/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/symphorien/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/symphorien/nixpkgs/events","assignees_url":"https://api.github.com/repos/symphorien/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/symphorien/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/symphorien/nixpkgs/tags","blobs_url":"https://api.github.com/repos/symphorien/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symphorien/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symphorien/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symphorien/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symphorien/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/symphorien/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/symphorien/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/symphorien/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/symphorien/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/symphorien/nixpkgs/subscription","commits_url":"https://api.github.com/repos/symphorien/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symphorien/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symphorien/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symphorien/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symphorien/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/symphorien/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symphorien/nixpkgs/merges","archive_url":"https://api.github.com/repos/symphorien/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symphorien/nixpkgs/downloads","issues_url":"https://api.github.com/repos/symphorien/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/symphorien/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/symphorien/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/symphorien/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symphorien/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/symphorien/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/symphorien/nixpkgs/deployments","created_at":"2016-12-23T16:05:01Z","updated_at":"2016-12-23T16:05:27Z","pushed_at":"2018-09-14T13:05:23Z","git_url":"git://github.com/symphorien/nixpkgs.git","ssh_url":"git@github.com:symphorien/nixpkgs.git","clone_url":"https://github.com/symphorien/nixpkgs.git","svn_url":"https://github.com/symphorien/nixpkgs","homepage":null,"size":766130,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"aea9db9d5044b56925b968972b1c044c46b5bf71","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-09-14T13:43:41Z","pushed_at":"2018-09-14T13:39:23Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":851752,"stargazers_count":2803,"watchers_count":2803,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3012,"mirror_url":null,"archived":false,"open_issues_count":3225,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3012,"open_issues":3225,"watchers":2803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/46647"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/46647"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/46647/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46647/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ffafe959ee302fe645a77dfae9a719b5d6709fa3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}