{"action":"created","issue":{"url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1757","repository_url":"https://api.github.com/repos/getsentry/sentry-javascript","labels_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1757/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1757/comments","events_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1757/events","html_url":"https://github.com/getsentry/sentry-javascript/issues/1757","id":382791405,"node_id":"MDU6SXNzdWUzODI3OTE0MDU=","number":1757,"title":"Critical: @sentry/browser v4.3.3 has usage of undeclared variable","user":{"login":"maxaon","id":3187207,"node_id":"MDQ6VXNlcjMxODcyMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3187207?v=4","gravatar_id":"","url":"https://api.github.com/users/maxaon","html_url":"https://github.com/maxaon","followers_url":"https://api.github.com/users/maxaon/followers","following_url":"https://api.github.com/users/maxaon/following{/other_user}","gists_url":"https://api.github.com/users/maxaon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxaon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxaon/subscriptions","organizations_url":"https://api.github.com/users/maxaon/orgs","repos_url":"https://api.github.com/users/maxaon/repos","events_url":"https://api.github.com/users/maxaon/events{/privacy}","received_events_url":"https://api.github.com/users/maxaon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-11-20T18:20:45Z","updated_at":"2018-11-21T18:23:32Z","closed_at":"2018-11-21T08:42:52Z","author_association":"NONE","body":"## Package + Version\r\n\r\n- [x] `@sentry/browser`\r\n- [ ] `@sentry/node`\r\n- [ ] `raven-js`\r\n- [ ] `raven-node` _(raven for node)_\r\n- [ ] other:\r\n\r\n### Version:\r\n\r\n```\r\n4.3.3\r\n```\r\n\r\n## Description\r\n\r\nIn version 4.3.3 main file (dist/index.js) contains function `safeJoin` and `assign` which contains for loops with usage of `tslib_1__default`.\r\n\r\nThis variable is not declared anywhere. When we try in our code use console methods we get exception.\r\n\r\nCode example: \r\n```js\r\nconsole.log('sdf')\r\n```\r\n\r\nexception: \r\n```\r\nUncaught ReferenceError: tslib_1__default is not defined\r\n    at e.safeJoin (modal?debug:13)\r\n    at console.log (modal?debug:13)\r\n    at <anonymous>:1:9\r\n```\r\n\r\n\r\nSource code of safeJoin\r\n```js\r\nfunction safeJoin(input, delimiter) {\r\n    var e_1, _a;\r\n    if (!Array.isArray(input)) {\r\n        return '';\r\n    }\r\n    var output = [];\r\n    try {\r\n        for (var input_1 = tslib_1__default.__values(input), input_1_1 = input_1.next(); !input_1_1.done; input_1_1 = input_1.next()) {\r\n            var value = input_1_1.value;\r\n            try {\r\n                output.push(String(value));\r\n            }\r\n            catch (e) {\r\n                output.push('[value cannot be serialized]');\r\n            }\r\n        }\r\n    }\r\n    catch (e_1_1) { e_1 = { error: e_1_1 }; }\r\n    finally {\r\n        try {\r\n            if (input_1_1 && !input_1_1.done && (_a = input_1.return)) _a.call(input_1);\r\n        }\r\n        finally { if (e_1) throw e_1.error; }\r\n    }\r\n    return output.join(delimiter);\r\n}\r\n```\r\nFile contain only 2 requirements \r\n```js\r\nvar tslib_1 = require('tslib');\r\nvar core = require('@sentry/core');\r\n```\r\n\r\nPlease see the file https://unpkg.com/@sentry/browser@4.3.3/dist/index.js There is no declaration of tslib_1__default and this is not a global variable"},"comment":{"url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/comments/440765249","html_url":"https://github.com/getsentry/sentry-javascript/issues/1757#issuecomment-440765249","issue_url":"https://api.github.com/repos/getsentry/sentry-javascript/issues/1757","id":440765249,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDc2NTI0OQ==","user":{"login":"munderwoods","id":8214994,"node_id":"MDQ6VXNlcjgyMTQ5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8214994?v=4","gravatar_id":"","url":"https://api.github.com/users/munderwoods","html_url":"https://github.com/munderwoods","followers_url":"https://api.github.com/users/munderwoods/followers","following_url":"https://api.github.com/users/munderwoods/following{/other_user}","gists_url":"https://api.github.com/users/munderwoods/gists{/gist_id}","starred_url":"https://api.github.com/users/munderwoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munderwoods/subscriptions","organizations_url":"https://api.github.com/users/munderwoods/orgs","repos_url":"https://api.github.com/users/munderwoods/repos","events_url":"https://api.github.com/users/munderwoods/events{/privacy}","received_events_url":"https://api.github.com/users/munderwoods/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T18:23:32Z","updated_at":"2018-11-21T18:23:32Z","author_association":"NONE","body":"Same here! Rolled back for now. "}}
{"actor":{"display_login":"munderwoods"}}