{"action":"closed","number":101,"pull_request":{"url":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101","id":165298745,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY1Mjk4NzQ1","html_url":"https://github.com/jamiebuilds/react-loadable/pull/101","diff_url":"https://github.com/jamiebuilds/react-loadable/pull/101.diff","patch_url":"https://github.com/jamiebuilds/react-loadable/pull/101.patch","issue_url":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/101","number":101,"state":"closed","locked":false,"title":"Exclude main chunk from module-bundle map","user":{"login":"tshen8","id":7621746,"node_id":"MDQ6VXNlcjc2MjE3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7621746?v=4","gravatar_id":"","url":"https://api.github.com/users/tshen8","html_url":"https://github.com/tshen8","followers_url":"https://api.github.com/users/tshen8/followers","following_url":"https://api.github.com/users/tshen8/following{/other_user}","gists_url":"https://api.github.com/users/tshen8/gists{/gist_id}","starred_url":"https://api.github.com/users/tshen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshen8/subscriptions","organizations_url":"https://api.github.com/users/tshen8/orgs","repos_url":"https://api.github.com/users/tshen8/repos","events_url":"https://api.github.com/users/tshen8/events{/privacy}","received_events_url":"https://api.github.com/users/tshen8/received_events","type":"User","site_admin":false},"body":"Does the main bundle need to be included in the module-bundle map generated by the Loadable Webpack plugin?\r\n\r\nThe nature of using dynamic `import()` with `Loadable` means that no loadable component should ever reside in the main bundle.\r\n\r\n```js\r\nReactDOMServer.renderToString(\r\n    <Loadable.Capture report={moduleName => modules.push(moduleName)}>\r\n      <App/>\r\n    </Loadable.Capture>\r\n  );\r\n```\r\n\r\nAs a result, the above shouldn't ever capture the main module of the application. \r\n\r\nBy excluding the main module in the plugin, it ensures that the output JSON **only** maps modules required by loadable components to the bundles that they reside in, instead of every single module in the app.","created_at":"2018-01-26T06:39:26Z","updated_at":"2018-08-09T14:44:13Z","closed_at":"2018-08-09T14:44:13Z","merged_at":null,"merge_commit_sha":"1e5d3fea2b23872d41fc72ca9f1614b797b48a70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101/commits","review_comments_url":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101/comments","review_comment_url":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/101/comments","statuses_url":"https://api.github.com/repos/jamiebuilds/react-loadable/statuses/9e53713f85efb6822e6f83b2c0ff815cddaf94d4","head":{"label":"tshen8:exclude-main-module-from-map","ref":"exclude-main-module-from-map","sha":"9e53713f85efb6822e6f83b2c0ff815cddaf94d4","user":{"login":"tshen8","id":7621746,"node_id":"MDQ6VXNlcjc2MjE3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7621746?v=4","gravatar_id":"","url":"https://api.github.com/users/tshen8","html_url":"https://github.com/tshen8","followers_url":"https://api.github.com/users/tshen8/followers","following_url":"https://api.github.com/users/tshen8/following{/other_user}","gists_url":"https://api.github.com/users/tshen8/gists{/gist_id}","starred_url":"https://api.github.com/users/tshen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshen8/subscriptions","organizations_url":"https://api.github.com/users/tshen8/orgs","repos_url":"https://api.github.com/users/tshen8/repos","events_url":"https://api.github.com/users/tshen8/events{/privacy}","received_events_url":"https://api.github.com/users/tshen8/received_events","type":"User","site_admin":false},"repo":{"id":118193554,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTM1NTQ=","name":"react-loadable","full_name":"tshen8/react-loadable","owner":{"login":"tshen8","id":7621746,"node_id":"MDQ6VXNlcjc2MjE3NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/7621746?v=4","gravatar_id":"","url":"https://api.github.com/users/tshen8","html_url":"https://github.com/tshen8","followers_url":"https://api.github.com/users/tshen8/followers","following_url":"https://api.github.com/users/tshen8/following{/other_user}","gists_url":"https://api.github.com/users/tshen8/gists{/gist_id}","starred_url":"https://api.github.com/users/tshen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tshen8/subscriptions","organizations_url":"https://api.github.com/users/tshen8/orgs","repos_url":"https://api.github.com/users/tshen8/repos","events_url":"https://api.github.com/users/tshen8/events{/privacy}","received_events_url":"https://api.github.com/users/tshen8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tshen8/react-loadable","description":":hourglass_flowing_sand: A higher order component for loading components with promises.","fork":true,"url":"https://api.github.com/repos/tshen8/react-loadable","forks_url":"https://api.github.com/repos/tshen8/react-loadable/forks","keys_url":"https://api.github.com/repos/tshen8/react-loadable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tshen8/react-loadable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tshen8/react-loadable/teams","hooks_url":"https://api.github.com/repos/tshen8/react-loadable/hooks","issue_events_url":"https://api.github.com/repos/tshen8/react-loadable/issues/events{/number}","events_url":"https://api.github.com/repos/tshen8/react-loadable/events","assignees_url":"https://api.github.com/repos/tshen8/react-loadable/assignees{/user}","branches_url":"https://api.github.com/repos/tshen8/react-loadable/branches{/branch}","tags_url":"https://api.github.com/repos/tshen8/react-loadable/tags","blobs_url":"https://api.github.com/repos/tshen8/react-loadable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tshen8/react-loadable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tshen8/react-loadable/git/refs{/sha}","trees_url":"https://api.github.com/repos/tshen8/react-loadable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tshen8/react-loadable/statuses/{sha}","languages_url":"https://api.github.com/repos/tshen8/react-loadable/languages","stargazers_url":"https://api.github.com/repos/tshen8/react-loadable/stargazers","contributors_url":"https://api.github.com/repos/tshen8/react-loadable/contributors","subscribers_url":"https://api.github.com/repos/tshen8/react-loadable/subscribers","subscription_url":"https://api.github.com/repos/tshen8/react-loadable/subscription","commits_url":"https://api.github.com/repos/tshen8/react-loadable/commits{/sha}","git_commits_url":"https://api.github.com/repos/tshen8/react-loadable/git/commits{/sha}","comments_url":"https://api.github.com/repos/tshen8/react-loadable/comments{/number}","issue_comment_url":"https://api.github.com/repos/tshen8/react-loadable/issues/comments{/number}","contents_url":"https://api.github.com/repos/tshen8/react-loadable/contents/{+path}","compare_url":"https://api.github.com/repos/tshen8/react-loadable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tshen8/react-loadable/merges","archive_url":"https://api.github.com/repos/tshen8/react-loadable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tshen8/react-loadable/downloads","issues_url":"https://api.github.com/repos/tshen8/react-loadable/issues{/number}","pulls_url":"https://api.github.com/repos/tshen8/react-loadable/pulls{/number}","milestones_url":"https://api.github.com/repos/tshen8/react-loadable/milestones{/number}","notifications_url":"https://api.github.com/repos/tshen8/react-loadable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tshen8/react-loadable/labels{/name}","releases_url":"https://api.github.com/repos/tshen8/react-loadable/releases{/id}","deployments_url":"https://api.github.com/repos/tshen8/react-loadable/deployments","created_at":"2018-01-20T00:27:33Z","updated_at":"2018-01-20T00:27:35Z","pushed_at":"2018-01-26T06:22:11Z","git_url":"git://github.com/tshen8/react-loadable.git","ssh_url":"git@github.com:tshen8/react-loadable.git","clone_url":"https://github.com/tshen8/react-loadable.git","svn_url":"https://github.com/tshen8/react-loadable","homepage":"","size":196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jamiebuilds:master","ref":"master","sha":"d0c5f6ffae3a8fccfdd3282d811a1c50e9265f96","user":{"login":"jamiebuilds","id":952783,"node_id":"MDQ6VXNlcjk1Mjc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/952783?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiebuilds","html_url":"https://github.com/jamiebuilds","followers_url":"https://api.github.com/users/jamiebuilds/followers","following_url":"https://api.github.com/users/jamiebuilds/following{/other_user}","gists_url":"https://api.github.com/users/jamiebuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiebuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiebuilds/subscriptions","organizations_url":"https://api.github.com/users/jamiebuilds/orgs","repos_url":"https://api.github.com/users/jamiebuilds/repos","events_url":"https://api.github.com/users/jamiebuilds/events{/privacy}","received_events_url":"https://api.github.com/users/jamiebuilds/received_events","type":"User","site_admin":false},"repo":{"id":84476389,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ3NjM4OQ==","name":"react-loadable","full_name":"jamiebuilds/react-loadable","owner":{"login":"jamiebuilds","id":952783,"node_id":"MDQ6VXNlcjk1Mjc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/952783?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiebuilds","html_url":"https://github.com/jamiebuilds","followers_url":"https://api.github.com/users/jamiebuilds/followers","following_url":"https://api.github.com/users/jamiebuilds/following{/other_user}","gists_url":"https://api.github.com/users/jamiebuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiebuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiebuilds/subscriptions","organizations_url":"https://api.github.com/users/jamiebuilds/orgs","repos_url":"https://api.github.com/users/jamiebuilds/repos","events_url":"https://api.github.com/users/jamiebuilds/events{/privacy}","received_events_url":"https://api.github.com/users/jamiebuilds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamiebuilds/react-loadable","description":":hourglass_flowing_sand: A higher order component for loading components with promises.","fork":false,"url":"https://api.github.com/repos/jamiebuilds/react-loadable","forks_url":"https://api.github.com/repos/jamiebuilds/react-loadable/forks","keys_url":"https://api.github.com/repos/jamiebuilds/react-loadable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamiebuilds/react-loadable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamiebuilds/react-loadable/teams","hooks_url":"https://api.github.com/repos/jamiebuilds/react-loadable/hooks","issue_events_url":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/events{/number}","events_url":"https://api.github.com/repos/jamiebuilds/react-loadable/events","assignees_url":"https://api.github.com/repos/jamiebuilds/react-loadable/assignees{/user}","branches_url":"https://api.github.com/repos/jamiebuilds/react-loadable/branches{/branch}","tags_url":"https://api.github.com/repos/jamiebuilds/react-loadable/tags","blobs_url":"https://api.github.com/repos/jamiebuilds/react-loadable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamiebuilds/react-loadable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamiebuilds/react-loadable/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamiebuilds/react-loadable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamiebuilds/react-loadable/statuses/{sha}","languages_url":"https://api.github.com/repos/jamiebuilds/react-loadable/languages","stargazers_url":"https://api.github.com/repos/jamiebuilds/react-loadable/stargazers","contributors_url":"https://api.github.com/repos/jamiebuilds/react-loadable/contributors","subscribers_url":"https://api.github.com/repos/jamiebuilds/react-loadable/subscribers","subscription_url":"https://api.github.com/repos/jamiebuilds/react-loadable/subscription","commits_url":"https://api.github.com/repos/jamiebuilds/react-loadable/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamiebuilds/react-loadable/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamiebuilds/react-loadable/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamiebuilds/react-loadable/contents/{+path}","compare_url":"https://api.github.com/repos/jamiebuilds/react-loadable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamiebuilds/react-loadable/merges","archive_url":"https://api.github.com/repos/jamiebuilds/react-loadable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamiebuilds/react-loadable/downloads","issues_url":"https://api.github.com/repos/jamiebuilds/react-loadable/issues{/number}","pulls_url":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls{/number}","milestones_url":"https://api.github.com/repos/jamiebuilds/react-loadable/milestones{/number}","notifications_url":"https://api.github.com/repos/jamiebuilds/react-loadable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamiebuilds/react-loadable/labels{/name}","releases_url":"https://api.github.com/repos/jamiebuilds/react-loadable/releases{/id}","deployments_url":"https://api.github.com/repos/jamiebuilds/react-loadable/deployments","created_at":"2017-03-09T18:41:17Z","updated_at":"2018-08-09T14:40:44Z","pushed_at":"2018-08-09T14:20:00Z","git_url":"git://github.com/jamiebuilds/react-loadable.git","ssh_url":"git@github.com:jamiebuilds/react-loadable.git","clone_url":"https://github.com/jamiebuilds/react-loadable.git","svn_url":"https://github.com/jamiebuilds/react-loadable","homepage":"","size":228,"stargazers_count":9395,"watchers_count":9395,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":411,"open_issues":18,"watchers":9395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101"},"html":{"href":"https://github.com/jamiebuilds/react-loadable/pull/101"},"issue":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/101"},"comments":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/jamiebuilds/react-loadable/statuses/9e53713f85efb6822e6f83b2c0ff815cddaf94d4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"tajo"}}