{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/209427833","pull_request_review_id":145447732,"id":209427833,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQyNzgzMw==","diff_hunk":"@@ -307,9 +307,12 @@ static int linelen(int *has_tab)\n     ;\n   save = *last;\n   *last = NUL;\n-  len = linetabsize(line);              /* get line length */\n-  if (has_tab != NULL)                  /* check for embedded TAB */\n-    *has_tab = (vim_strrchr(first, TAB) != NULL);\n+  // Get line length.\n+  len = linetabsize(line);\n+  // Check for embedded TAB.\n+  if (has_tab != NULL) {","path":"src/nvim/ex_cmds.c","position":10,"original_position":10,"commit_id":"6b86303a4801b36465b3b379baec5c9852e5ac31","original_commit_id":"6b86303a4801b36465b3b379baec5c9852e5ac31","user":{"login":"justinmk","id":1359421,"node_id":"MDQ6VXNlcjEzNTk0MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1359421?v=4","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"for future reference: we generally keep right-aligned comments, we don't move them to their own lines.","created_at":"2018-08-11T14:12:51Z","updated_at":"2018-08-11T14:12:51Z","html_url":"https://github.com/neovim/neovim/pull/8718#discussion_r209427833","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/8718","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/209427833"},"html":{"href":"https://github.com/neovim/neovim/pull/8718#discussion_r209427833"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/8718"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/8718","id":200532328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTMyMzI4","html_url":"https://github.com/neovim/neovim/pull/8718","diff_url":"https://github.com/neovim/neovim/pull/8718.diff","patch_url":"https://github.com/neovim/neovim/pull/8718.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/8718","number":8718,"state":"open","locked":false,"title":"[RFC] Remove vim_strrchr() and replace with strrchar()","user":{"login":"ZviRackover","id":1042786,"node_id":"MDQ6VXNlcjEwNDI3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1042786?v=4","gravatar_id":"","url":"https://api.github.com/users/ZviRackover","html_url":"https://github.com/ZviRackover","followers_url":"https://api.github.com/users/ZviRackover/followers","following_url":"https://api.github.com/users/ZviRackover/following{/other_user}","gists_url":"https://api.github.com/users/ZviRackover/gists{/gist_id}","starred_url":"https://api.github.com/users/ZviRackover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZviRackover/subscriptions","organizations_url":"https://api.github.com/users/ZviRackover/orgs","repos_url":"https://api.github.com/users/ZviRackover/repos","events_url":"https://api.github.com/users/ZviRackover/events{/privacy}","received_events_url":"https://api.github.com/users/ZviRackover/received_events","type":"User","site_admin":false},"body":"Also adding a unittest.\r\n\r\nFixes an issue mentioned in #1474","created_at":"2018-07-10T21:44:18Z","updated_at":"2018-08-11T14:12:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"535d6d8733a3e61ff733a39606d7b038438e78c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147252667,"node_id":"MDU6TGFiZWwxNDcyNTI2Njc=","url":"https://api.github.com/repos/neovim/neovim/labels/RFC","name":"RFC","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/8718/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/8718/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/8718/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/6b86303a4801b36465b3b379baec5c9852e5ac31","head":{"label":"ZviRackover:fix-strrchar","ref":"fix-strrchar","sha":"6b86303a4801b36465b3b379baec5c9852e5ac31","user":{"login":"ZviRackover","id":1042786,"node_id":"MDQ6VXNlcjEwNDI3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1042786?v=4","gravatar_id":"","url":"https://api.github.com/users/ZviRackover","html_url":"https://github.com/ZviRackover","followers_url":"https://api.github.com/users/ZviRackover/followers","following_url":"https://api.github.com/users/ZviRackover/following{/other_user}","gists_url":"https://api.github.com/users/ZviRackover/gists{/gist_id}","starred_url":"https://api.github.com/users/ZviRackover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZviRackover/subscriptions","organizations_url":"https://api.github.com/users/ZviRackover/orgs","repos_url":"https://api.github.com/users/ZviRackover/repos","events_url":"https://api.github.com/users/ZviRackover/events{/privacy}","received_events_url":"https://api.github.com/users/ZviRackover/received_events","type":"User","site_admin":false},"repo":{"id":139181983,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxODE5ODM=","name":"neovim","full_name":"ZviRackover/neovim","owner":{"login":"ZviRackover","id":1042786,"node_id":"MDQ6VXNlcjEwNDI3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1042786?v=4","gravatar_id":"","url":"https://api.github.com/users/ZviRackover","html_url":"https://github.com/ZviRackover","followers_url":"https://api.github.com/users/ZviRackover/followers","following_url":"https://api.github.com/users/ZviRackover/following{/other_user}","gists_url":"https://api.github.com/users/ZviRackover/gists{/gist_id}","starred_url":"https://api.github.com/users/ZviRackover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZviRackover/subscriptions","organizations_url":"https://api.github.com/users/ZviRackover/orgs","repos_url":"https://api.github.com/users/ZviRackover/repos","events_url":"https://api.github.com/users/ZviRackover/events{/privacy}","received_events_url":"https://api.github.com/users/ZviRackover/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZviRackover/neovim","description":"Vim-fork focused on extensibility and usability","fork":true,"url":"https://api.github.com/repos/ZviRackover/neovim","forks_url":"https://api.github.com/repos/ZviRackover/neovim/forks","keys_url":"https://api.github.com/repos/ZviRackover/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZviRackover/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZviRackover/neovim/teams","hooks_url":"https://api.github.com/repos/ZviRackover/neovim/hooks","issue_events_url":"https://api.github.com/repos/ZviRackover/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/ZviRackover/neovim/events","assignees_url":"https://api.github.com/repos/ZviRackover/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/ZviRackover/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/ZviRackover/neovim/tags","blobs_url":"https://api.github.com/repos/ZviRackover/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZviRackover/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZviRackover/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZviRackover/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZviRackover/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/ZviRackover/neovim/languages","stargazers_url":"https://api.github.com/repos/ZviRackover/neovim/stargazers","contributors_url":"https://api.github.com/repos/ZviRackover/neovim/contributors","subscribers_url":"https://api.github.com/repos/ZviRackover/neovim/subscribers","subscription_url":"https://api.github.com/repos/ZviRackover/neovim/subscription","commits_url":"https://api.github.com/repos/ZviRackover/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZviRackover/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZviRackover/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZviRackover/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZviRackover/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/ZviRackover/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZviRackover/neovim/merges","archive_url":"https://api.github.com/repos/ZviRackover/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZviRackover/neovim/downloads","issues_url":"https://api.github.com/repos/ZviRackover/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/ZviRackover/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/ZviRackover/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/ZviRackover/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZviRackover/neovim/labels{/name}","releases_url":"https://api.github.com/repos/ZviRackover/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/ZviRackover/neovim/deployments","created_at":"2018-06-29T18:19:14Z","updated_at":"2018-08-10T19:23:43Z","pushed_at":"2018-08-11T00:16:37Z","git_url":"git://github.com/ZviRackover/neovim.git","ssh_url":"git@github.com:ZviRackover/neovim.git","clone_url":"https://github.com/ZviRackover/neovim.git","svn_url":"https://github.com/ZviRackover/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":72076,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"c30812be7bff56d3a18a879240d47491c5934164","user":{"login":"neovim","id":6471485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6471485?v=4","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwODk5Mg==","name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzE0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6471485?v=4","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and usability","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2018-08-11T14:07:35Z","pushed_at":"2018-08-11T14:06:59Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":72144,"stargazers_count":28060,"watchers_count":28060,"language":"Vim script","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2014,"mirror_url":null,"archived":false,"open_issues_count":912,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2014,"open_issues":912,"watchers":28060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/8718"},"html":{"href":"https://github.com/neovim/neovim/pull/8718"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/8718"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/8718/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/8718/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/8718/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/6b86303a4801b36465b3b379baec5c9852e5ac31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"justinmk"}}