{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175976074","pull_request_review_id":105597400,"id":175976074,"diff_hunk":"@@ -152,6 +152,9 @@ func AddJoinConfigFlags(flagSet *flag.FlagSet, cfg *kubeadmapiext.NodeConfigurat\n \tflagSet.StringVar(\n \t\t&cfg.NodeName, \"node-name\", \"\",\n \t\t\"Specify the node name.\")\n+\tflagSet.StringVar(","path":"cmd/kubeadm/app/cmd/join.go","position":4,"original_position":4,"commit_id":"bc449e430a4856cb750de7cecf6c6fb2480c27b3","original_commit_id":"bc449e430a4856cb750de7cecf6c6fb2480c27b3","user":{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"body":"Set ClusterName to \"kubernetes\" by default in L104.\r\n\r\n`cfg := &kubeadmapiext. NodeConfiguration{ClusterName: \"kubernetes\"}`","created_at":"2018-03-21T03:02:19Z","updated_at":"2018-03-21T03:02:49Z","html_url":"https://github.com/kubernetes/kubernetes/pull/60852#discussion_r175976074","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175976074"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/60852#discussion_r175976074"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852","id":173264340,"html_url":"https://github.com/kubernetes/kubernetes/pull/60852","diff_url":"https://github.com/kubernetes/kubernetes/pull/60852.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60852.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60852","number":60852,"state":"open","locked":false,"title":"Add --cluster-name to kubeadm init","user":{"login":"karan","id":3261985,"avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: Adds a `--cluster-name` arg to kubeadm init.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nSee https://github.com/kubernetes/kube-deploy/issues/636\r\nCode inspired by #52470\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAdds --cluster-name to kubeadm init for specifying the cluster name in kubeconfig.\r\n```\r\n","created_at":"2018-03-06T19:56:02Z","updated_at":"2018-03-21T03:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41142b195bbbb61bce926858d49a9375e058d6b0","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dmmcquay","id":1700422,"avatar_url":"https://avatars2.githubusercontent.com/u/1700422?v=4","gravatar_id":"","url":"https://api.github.com/users/dmmcquay","html_url":"https://github.com/dmmcquay","followers_url":"https://api.github.com/users/dmmcquay/followers","following_url":"https://api.github.com/users/dmmcquay/following{/other_user}","gists_url":"https://api.github.com/users/dmmcquay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmcquay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmcquay/subscriptions","organizations_url":"https://api.github.com/users/dmmcquay/orgs","repos_url":"https://api.github.com/users/dmmcquay/repos","events_url":"https://api.github.com/users/dmmcquay/events{/privacy}","received_events_url":"https://api.github.com/users/dmmcquay/received_events","type":"User","site_admin":false},{"login":"mattmoyer","id":3210334,"avatar_url":"https://avatars3.githubusercontent.com/u/3210334?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoyer","html_url":"https://github.com/mattmoyer","followers_url":"https://api.github.com/users/mattmoyer/followers","following_url":"https://api.github.com/users/mattmoyer/following{/other_user}","gists_url":"https://api.github.com/users/mattmoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoyer/subscriptions","organizations_url":"https://api.github.com/users/mattmoyer/orgs","repos_url":"https://api.github.com/users/mattmoyer/repos","events_url":"https://api.github.com/users/mattmoyer/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoyer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60852/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bc449e430a4856cb750de7cecf6c6fb2480c27b3","head":{"label":"karan:kubeadm-cluster-name","ref":"kubeadm-cluster-name","sha":"bc449e430a4856cb750de7cecf6c6fb2480c27b3","user":{"login":"karan","id":3261985,"avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"repo":{"id":114816116,"name":"kubernetes","full_name":"karan/kubernetes","owner":{"login":"karan","id":3261985,"avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karan/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/karan/kubernetes","forks_url":"https://api.github.com/repos/karan/kubernetes/forks","keys_url":"https://api.github.com/repos/karan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karan/kubernetes/teams","hooks_url":"https://api.github.com/repos/karan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/karan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/karan/kubernetes/events","assignees_url":"https://api.github.com/repos/karan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/karan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/karan/kubernetes/tags","blobs_url":"https://api.github.com/repos/karan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/karan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/karan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/karan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/karan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/karan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/karan/kubernetes/subscription","commits_url":"https://api.github.com/repos/karan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/karan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/karan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/karan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/karan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/karan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karan/kubernetes/merges","archive_url":"https://api.github.com/repos/karan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karan/kubernetes/downloads","issues_url":"https://api.github.com/repos/karan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/karan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/karan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/karan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/karan/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/karan/kubernetes/deployments","created_at":"2017-12-19T22:11:08Z","updated_at":"2018-03-20T22:54:26Z","pushed_at":"2018-03-20T22:54:36Z","git_url":"git://github.com/karan/kubernetes.git","ssh_url":"git@github.com:karan/kubernetes.git","clone_url":"https://github.com/karan/kubernetes.git","svn_url":"https://github.com/karan/kubernetes","homepage":"http://kubernetes.io","size":543428,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"14e3efe26a82f244492d233144ef215ed0064cd8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-21T02:44:50Z","pushed_at":"2018-03-21T02:59:07Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":765483,"stargazers_count":33977,"watchers_count":33977,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12056,"mirror_url":null,"archived":false,"open_issues_count":3515,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12056,"open_issues":3515,"watchers":33977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/60852"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60852"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60852/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60852/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bc449e430a4856cb750de7cecf6c6fb2480c27b3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dixudx"}}