{"action":"closed","issue":{"url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/38","repository_url":"https://api.github.com/repos/rocket-pool/rocketpool","labels_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/38/comments","events_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/38/events","html_url":"https://github.com/rocket-pool/rocketpool/issues/38","id":322201916,"number":38,"title":"Promise style","user":{"login":"mryellow","id":213575,"avatar_url":"https://avatars1.githubusercontent.com/u/213575?v=4","gravatar_id":"","url":"https://api.github.com/users/mryellow","html_url":"https://github.com/mryellow","followers_url":"https://api.github.com/users/mryellow/followers","following_url":"https://api.github.com/users/mryellow/following{/other_user}","gists_url":"https://api.github.com/users/mryellow/gists{/gist_id}","starred_url":"https://api.github.com/users/mryellow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mryellow/subscriptions","organizations_url":"https://api.github.com/users/mryellow/orgs","repos_url":"https://api.github.com/users/mryellow/repos","events_url":"https://api.github.com/users/mryellow/events{/privacy}","received_events_url":"https://api.github.com/users/mryellow/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-11T07:50:06Z","updated_at":"2018-05-11T08:20:37Z","closed_at":"2018-05-11T08:20:37Z","author_association":"NONE","body":"I believe these promises in migrations can be made a little less deeply nested.\r\n\r\n ```\r\n       // Deploy Rocket Vault\r\n        return deployer.deploy(rocketVault, rocketStorage.address).then(() => {\r\n        // Deploy Rocket Vault Store\r\n        return deployer.deploy(rocketVaultStore, rocketStorage.address).then(() => {\r\n          // Deploy Rocket Utils\r\n          return deployer.deploy(rocketUtils, rocketStorage.address).then(() => {\r\n```\r\n\r\n```\r\n\r\n....then(() => {\r\n  // Deploy Rocket Vault\r\n  return deployer.deploy(rocketVault, rocketStorage.address);\r\n}).then(() => {\r\n  // Deploy Rocket Vault Store\r\n  return deployer.deploy(rocketVaultStore, rocketStorage.address);\r\n}).then(() => {\r\n  // Deploy Rocket Vault Store\r\n  return deployer.deploy(rocketVaultStore, rocketStorage.address);\r\n}).then(() => {\r\n  // Deploy Rocket Utils\r\n  return deployer.deploy(rocketUtils, rocketStorage.address);\r\n}).then(() => {\r\n  ...\r\n})\r\n\r\n```\r\n\r\nhttps://pouchdb.com/2015/05/18/we-have-a-problem-with-promises.html"}}
{"actor":{"display_login":"mryellow"}}