{"action":"closed","number":193,"pull_request":{"url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193","id":167114092,"html_url":"https://github.com/agherzan/meta-raspberrypi/pull/193","diff_url":"https://github.com/agherzan/meta-raspberrypi/pull/193.diff","patch_url":"https://github.com/agherzan/meta-raspberrypi/pull/193.patch","issue_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/193","number":193,"state":"closed","locked":false,"title":"[linux-firmare] fix addition of NVRAM file to image (fixes #184)","user":{"login":"hhromic","id":5802993,"avatar_url":"https://avatars3.githubusercontent.com/u/5802993?v=4","gravatar_id":"","url":"https://api.github.com/users/hhromic","html_url":"https://github.com/hhromic","followers_url":"https://api.github.com/users/hhromic/followers","following_url":"https://api.github.com/users/hhromic/following{/other_user}","gists_url":"https://api.github.com/users/hhromic/gists{/gist_id}","starred_url":"https://api.github.com/users/hhromic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhromic/subscriptions","organizations_url":"https://api.github.com/users/hhromic/orgs","repos_url":"https://api.github.com/users/hhromic/repos","events_url":"https://api.github.com/users/hhromic/events{/privacy}","received_events_url":"https://api.github.com/users/hhromic/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines.\r\n\r\nFor additional information on the contribution guidelines:\r\nhttps://wiki.yoctoproject.org/wiki/Contribution_Guidelines#General_Information\r\n\r\nIf this PR fixes an issue, make sure your description includes \"fixes #xxxx\".\r\n\r\nIf this PR connects to an issue, make sure your description includes \"connected to #xxxx\".\r\n\r\nPlease provide the following information:\r\n-->\r\nThis PR fixes #184, where the Wifi module is not brought up because of missing firmware file.\r\n\r\n**- What I did**\r\nThe NVRAM text file for the BCM firmware was not properly added in the built image. This is because the recipe `recipes-kernel/linux-firmware/linux-firmware_%.bbappend` is using `+=` for adding the extra file instead of `_append` in `FILES_${PN}-bcm43430`.\r\nThis results in only the NVRAM text file being added to the built image and not the firmware binary file (`.bin`), causing the Wifi module to not work.\r\nI tested the images also enabling the bluetooth module (as discussed in #184) to ensure this doesn't interfere with other connectivity components.\r\nAfter this fix, both files (`.txt` and `.bin`) of the firmware are now correctly installed in `/lib/firmware`.\r\n\r\n**- How I did it**\r\nI simply replaced the `+=` construction with an `_append` construction as seen in the PR.","created_at":"2018-02-05T11:00:28Z","updated_at":"2018-02-05T14:23:26Z","closed_at":"2018-02-05T14:23:26Z","merged_at":null,"merge_commit_sha":"c0f31929bf423ebea17fd7e7d7e31497038fcd06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193/commits","review_comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193/comments","review_comment_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/193/comments","statuses_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/e5df196f1d5d8a17b57a9eda6086cabb4b6e7c6d","head":{"label":"hhromic:firmware-file-fix","ref":"firmware-file-fix","sha":"e5df196f1d5d8a17b57a9eda6086cabb4b6e7c6d","user":{"login":"hhromic","id":5802993,"avatar_url":"https://avatars3.githubusercontent.com/u/5802993?v=4","gravatar_id":"","url":"https://api.github.com/users/hhromic","html_url":"https://github.com/hhromic","followers_url":"https://api.github.com/users/hhromic/followers","following_url":"https://api.github.com/users/hhromic/following{/other_user}","gists_url":"https://api.github.com/users/hhromic/gists{/gist_id}","starred_url":"https://api.github.com/users/hhromic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhromic/subscriptions","organizations_url":"https://api.github.com/users/hhromic/orgs","repos_url":"https://api.github.com/users/hhromic/repos","events_url":"https://api.github.com/users/hhromic/events{/privacy}","received_events_url":"https://api.github.com/users/hhromic/received_events","type":"User","site_admin":false},"repo":{"id":119180763,"name":"meta-raspberrypi","full_name":"hhromic/meta-raspberrypi","owner":{"login":"hhromic","id":5802993,"avatar_url":"https://avatars3.githubusercontent.com/u/5802993?v=4","gravatar_id":"","url":"https://api.github.com/users/hhromic","html_url":"https://github.com/hhromic","followers_url":"https://api.github.com/users/hhromic/followers","following_url":"https://api.github.com/users/hhromic/following{/other_user}","gists_url":"https://api.github.com/users/hhromic/gists{/gist_id}","starred_url":"https://api.github.com/users/hhromic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhromic/subscriptions","organizations_url":"https://api.github.com/users/hhromic/orgs","repos_url":"https://api.github.com/users/hhromic/repos","events_url":"https://api.github.com/users/hhromic/events{/privacy}","received_events_url":"https://api.github.com/users/hhromic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhromic/meta-raspberrypi","description":"Yocto BSP layer for the Raspberry Pi boards","fork":true,"url":"https://api.github.com/repos/hhromic/meta-raspberrypi","forks_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/forks","keys_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/teams","hooks_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/hooks","issue_events_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/issues/events{/number}","events_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/events","assignees_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/assignees{/user}","branches_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/branches{/branch}","tags_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/tags","blobs_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/statuses/{sha}","languages_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/languages","stargazers_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/stargazers","contributors_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/contributors","subscribers_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/subscribers","subscription_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/subscription","commits_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/contents/{+path}","compare_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/merges","archive_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/downloads","issues_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/issues{/number}","pulls_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/pulls{/number}","milestones_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/milestones{/number}","notifications_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/labels{/name}","releases_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/releases{/id}","deployments_url":"https://api.github.com/repos/hhromic/meta-raspberrypi/deployments","created_at":"2018-01-27T16:24:45Z","updated_at":"2018-01-27T16:24:47Z","pushed_at":"2018-02-05T14:21:13Z","git_url":"git://github.com/hhromic/meta-raspberrypi.git","ssh_url":"git@github.com:hhromic/meta-raspberrypi.git","clone_url":"https://github.com/hhromic/meta-raspberrypi.git","svn_url":"https://github.com/hhromic/meta-raspberrypi","homepage":"http://www.raspberrypi.org/","size":1330,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"agherzan:master","ref":"master","sha":"ee668d80729d093d3f2f32af6402424659d30605","user":{"login":"agherzan","id":1746941,"avatar_url":"https://avatars0.githubusercontent.com/u/1746941?v=4","gravatar_id":"","url":"https://api.github.com/users/agherzan","html_url":"https://github.com/agherzan","followers_url":"https://api.github.com/users/agherzan/followers","following_url":"https://api.github.com/users/agherzan/following{/other_user}","gists_url":"https://api.github.com/users/agherzan/gists{/gist_id}","starred_url":"https://api.github.com/users/agherzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agherzan/subscriptions","organizations_url":"https://api.github.com/users/agherzan/orgs","repos_url":"https://api.github.com/users/agherzan/repos","events_url":"https://api.github.com/users/agherzan/events{/privacy}","received_events_url":"https://api.github.com/users/agherzan/received_events","type":"User","site_admin":false},"repo":{"id":30782639,"name":"meta-raspberrypi","full_name":"agherzan/meta-raspberrypi","owner":{"login":"agherzan","id":1746941,"avatar_url":"https://avatars0.githubusercontent.com/u/1746941?v=4","gravatar_id":"","url":"https://api.github.com/users/agherzan","html_url":"https://github.com/agherzan","followers_url":"https://api.github.com/users/agherzan/followers","following_url":"https://api.github.com/users/agherzan/following{/other_user}","gists_url":"https://api.github.com/users/agherzan/gists{/gist_id}","starred_url":"https://api.github.com/users/agherzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agherzan/subscriptions","organizations_url":"https://api.github.com/users/agherzan/orgs","repos_url":"https://api.github.com/users/agherzan/repos","events_url":"https://api.github.com/users/agherzan/events{/privacy}","received_events_url":"https://api.github.com/users/agherzan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agherzan/meta-raspberrypi","description":"Yocto BSP layer for the Raspberry Pi boards","fork":false,"url":"https://api.github.com/repos/agherzan/meta-raspberrypi","forks_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/forks","keys_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/teams","hooks_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/hooks","issue_events_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/events{/number}","events_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/events","assignees_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/assignees{/user}","branches_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/branches{/branch}","tags_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/tags","blobs_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/refs{/sha}","trees_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/{sha}","languages_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/languages","stargazers_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/stargazers","contributors_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/contributors","subscribers_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/subscribers","subscription_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/subscription","commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/commits{/sha}","git_commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/commits{/sha}","comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/comments{/number}","issue_comment_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/comments{/number}","contents_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/contents/{+path}","compare_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/merges","archive_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/downloads","issues_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues{/number}","pulls_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls{/number}","milestones_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/milestones{/number}","notifications_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/labels{/name}","releases_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/releases{/id}","deployments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/deployments","created_at":"2015-02-14T00:47:35Z","updated_at":"2018-01-29T15:36:22Z","pushed_at":"2018-02-05T14:21:14Z","git_url":"git://github.com/agherzan/meta-raspberrypi.git","ssh_url":"git@github.com:agherzan/meta-raspberrypi.git","clone_url":"https://github.com/agherzan/meta-raspberrypi.git","svn_url":"https://github.com/agherzan/meta-raspberrypi","homepage":"http://www.raspberrypi.org/","size":1329,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":96,"open_issues":15,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193"},"html":{"href":"https://github.com/agherzan/meta-raspberrypi/pull/193"},"issue":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/193"},"comments":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/e5df196f1d5d8a17b57a9eda6086cabb4b6e7c6d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hhromic"}}