{"action":"created","comment":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/239794340","pull_request_review_id":182675782,"id":239794340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc5NDM0MA==","diff_hunk":"@@ -1339,13 +1339,11 @@\n     <string name=\"drone_emergency_title\">Emergency</string>\n     <!--  -->\n \n+    <!-- Runtime permission messages -->\n+    <string name=\"runtime_permission_all\">This app needs the requested permissions to function properly. E.g., the\n+Camera brick needs access to the device\\'s camera, the \"location\" formula element needs access to the device\\'s geolocation sensor.</string>","path":"catroid/src/main/res/values/strings.xml","position":6,"original_position":6,"commit_id":"fef5342ce6d8c5ef39e0c2eeee4139064bd821da","original_commit_id":"fef5342ce6d8c5ef39e0c2eeee4139064bd821da","user":{"login":"84n4n4","id":15098185,"node_id":"MDQ6VXNlcjE1MDk4MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/15098185?v=4","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"body":"regarding the SoundRecorder crash.\r\n\r\nthis is most likely due to some storage issues. with the internal storage PR that has been merged in develop already all those additional functionalities (like taking pictures, recording sounds, etc) use the apps CacheDir that should be provided by the android os. this does not require additional storage permissions, but this looks like there is a problem on certain devices in combination with target api 26 with creating the CacheDir:\r\nCatroidApplication.getAppContext().getCacheDir().getAbsolutePath()\r\n\r\ndo you have a stacktrace or log output for me? (i currently dont have a windows machine for installing bluestack) i tested this quite extensively on my device and emulators and was not able to reproduce this. i can try to reproduce on somebody elses machine on monday.\r\n\r\ni fear that there will probably more bugs like this, please consider this PR not as added functionality, but as a big bunch of fixes of stuff that gets broken with increasing target API to 26. we need more eyes and more diverse mix of devices running this to uncover the remaining problems.\r\ni would love to see this merged to develop and then \r\n- have more developers working with the state and uncover bugs on their devices and emulators\r\n- enable us to have other people work on bugs that now arise\r\n- prevent that this has to be rebased. theres a few stories in various states in jira that if merged before would require this already big PR to be rebased.","created_at":"2018-12-07T12:42:01Z","updated_at":"2018-12-07T12:42:01Z","html_url":"https://github.com/Catrobat/Catroid/pull/3025#discussion_r239794340","pull_request_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/239794340"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/3025#discussion_r239794340"},"pull_request":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025"}},"in_reply_to_id":239683128},"pull_request":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025","id":231943775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTQzNzc1","html_url":"https://github.com/Catrobat/Catroid/pull/3025","diff_url":"https://github.com/Catrobat/Catroid/pull/3025.diff","patch_url":"https://github.com/Catrobat/Catroid/pull/3025.patch","issue_url":"https://api.github.com/repos/Catrobat/Catroid/issues/3025","number":3025,"state":"open","locked":false,"title":"CATROID-13 runtime permissions for stage","user":{"login":"84n4n4","id":15098185,"node_id":"MDQ6VXNlcjE1MDk4MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/15098185?v=4","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-19T11:43:56Z","updated_at":"2018-12-07T12:42:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8ca08689e1ae770b99718f291dcacba3db22546","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025/commits","review_comments_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025/comments","review_comment_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/issues/3025/comments","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/fef5342ce6d8c5ef39e0c2eeee4139064bd821da","head":{"label":"84n4n4:CATROID-13-runtime-permissions","ref":"CATROID-13-runtime-permissions","sha":"fef5342ce6d8c5ef39e0c2eeee4139064bd821da","user":{"login":"84n4n4","id":15098185,"node_id":"MDQ6VXNlcjE1MDk4MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/15098185?v=4","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"repo":{"id":44180842,"node_id":"MDEwOlJlcG9zaXRvcnk0NDE4MDg0Mg==","name":"Catroid","full_name":"84n4n4/Catroid","private":false,"owner":{"login":"84n4n4","id":15098185,"node_id":"MDQ6VXNlcjE1MDk4MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/15098185?v=4","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"html_url":"https://github.com/84n4n4/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":true,"url":"https://api.github.com/repos/84n4n4/Catroid","forks_url":"https://api.github.com/repos/84n4n4/Catroid/forks","keys_url":"https://api.github.com/repos/84n4n4/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/84n4n4/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/84n4n4/Catroid/teams","hooks_url":"https://api.github.com/repos/84n4n4/Catroid/hooks","issue_events_url":"https://api.github.com/repos/84n4n4/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/84n4n4/Catroid/events","assignees_url":"https://api.github.com/repos/84n4n4/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/84n4n4/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/84n4n4/Catroid/tags","blobs_url":"https://api.github.com/repos/84n4n4/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/84n4n4/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/84n4n4/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/84n4n4/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/84n4n4/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/84n4n4/Catroid/languages","stargazers_url":"https://api.github.com/repos/84n4n4/Catroid/stargazers","contributors_url":"https://api.github.com/repos/84n4n4/Catroid/contributors","subscribers_url":"https://api.github.com/repos/84n4n4/Catroid/subscribers","subscription_url":"https://api.github.com/repos/84n4n4/Catroid/subscription","commits_url":"https://api.github.com/repos/84n4n4/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/84n4n4/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/84n4n4/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/84n4n4/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/84n4n4/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/84n4n4/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/84n4n4/Catroid/merges","archive_url":"https://api.github.com/repos/84n4n4/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/84n4n4/Catroid/downloads","issues_url":"https://api.github.com/repos/84n4n4/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/84n4n4/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/84n4n4/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/84n4n4/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/84n4n4/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/84n4n4/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/84n4n4/Catroid/deployments","created_at":"2015-10-13T14:11:21Z","updated_at":"2018-11-03T21:21:31Z","pushed_at":"2018-12-06T14:26:27Z","git_url":"git://github.com/84n4n4/Catroid.git","ssh_url":"git@github.com:84n4n4/Catroid.git","clone_url":"https://github.com/84n4n4/Catroid.git","svn_url":"https://github.com/84n4n4/Catroid","homepage":"https://share.catrob.at/pocketcode","size":170507,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"Catrobat:develop","ref":"develop","sha":"2a931470efbd8e74c1927368daac80b455965e4a","user":{"login":"Catrobat","id":1747223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDcyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1747223?v=4","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"repo":{"id":4475999,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc1OTk5","name":"Catroid","full_name":"Catrobat/Catroid","private":false,"owner":{"login":"Catrobat","id":1747223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDcyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1747223?v=4","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Catrobat/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":false,"url":"https://api.github.com/repos/Catrobat/Catroid","forks_url":"https://api.github.com/repos/Catrobat/Catroid/forks","keys_url":"https://api.github.com/repos/Catrobat/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Catrobat/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Catrobat/Catroid/teams","hooks_url":"https://api.github.com/repos/Catrobat/Catroid/hooks","issue_events_url":"https://api.github.com/repos/Catrobat/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/Catrobat/Catroid/events","assignees_url":"https://api.github.com/repos/Catrobat/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/Catrobat/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/Catrobat/Catroid/tags","blobs_url":"https://api.github.com/repos/Catrobat/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Catrobat/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Catrobat/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Catrobat/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/Catrobat/Catroid/languages","stargazers_url":"https://api.github.com/repos/Catrobat/Catroid/stargazers","contributors_url":"https://api.github.com/repos/Catrobat/Catroid/contributors","subscribers_url":"https://api.github.com/repos/Catrobat/Catroid/subscribers","subscription_url":"https://api.github.com/repos/Catrobat/Catroid/subscription","commits_url":"https://api.github.com/repos/Catrobat/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Catrobat/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Catrobat/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Catrobat/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/Catrobat/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Catrobat/Catroid/merges","archive_url":"https://api.github.com/repos/Catrobat/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Catrobat/Catroid/downloads","issues_url":"https://api.github.com/repos/Catrobat/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/Catrobat/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/Catrobat/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/Catrobat/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Catrobat/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/Catrobat/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/Catrobat/Catroid/deployments","created_at":"2012-05-29T00:18:04Z","updated_at":"2018-12-06T10:54:22Z","pushed_at":"2018-12-06T14:26:29Z","git_url":"git://github.com/Catrobat/Catroid.git","ssh_url":"git@github.com:Catrobat/Catroid.git","clone_url":"https://github.com/Catrobat/Catroid.git","svn_url":"https://github.com/Catrobat/Catroid","homepage":"https://share.catrob.at/pocketcode","size":153986,"stargazers_count":181,"watchers_count":181,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":310,"mirror_url":null,"archived":false,"open_issues_count":120,"license":null,"forks":310,"open_issues":120,"watchers":181,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/3025"},"issue":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/3025"},"comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/3025/comments"},"review_comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025/comments"},"review_comment":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/3025/commits"},"statuses":{"href":"https://api.github.com/repos/Catrobat/Catroid/statuses/fef5342ce6d8c5ef39e0c2eeee4139064bd821da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"84n4n4"}}