{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/238322781","pull_request_review_id":180834857,"id":238322781,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODMyMjc4MQ==","diff_hunk":"@@ -0,0 +1,177 @@\n+# Proposal: Provide feedback on push progress\n+\n+Relevant issues: [#806](https://github.com/GoogleContainerTools/jib/issues/806), [#1251](https://github.com/GoogleContainerTools/jib/issues/1251)\n+\n+## Motivation\n+\n+Currently, Jib lacks any progress feedback for layer pushes. In cases where layers take a long time to push, this lack of progress indication:\n+\n+- makes it hard to estimate how long the build will take\n+- makes it unclear as to whether the build is stuck or will complete in some reasonable amount of time\n+- may deter first-time users from continuing to use Jib \n+\n+This is especially prevalent for first-time users whose first builds would need to push all the layers, including the large base image layers.\n+\n+## Current output\n+\n+An example of the current output (as of versoin `0.10.0`) looks like:\n+\n+```\n+Containerizing application to <image>...\n+warning: Base image 'gcr.io/distroless/java' does not use a specific image digest - build may not be reproducible\n+Retrieving registry credentials for gcr.io...\n+Getting base image gcr.io/distroless/java...\n+Building dependencies layer...\n+Building resources layer...\n+Building classes layer...\n+\n+Container entrypoint set to [java, -cp, /app/resources:/app/classes:/app/libs/*, <main class>]\n+Finalizing...\n+\n+Built and pushed image as <image>\n+```\n+\n+Note that the build would pause on `Finalizing...` until all layers are finished pushing.\n+\n+## Goal\n+\n+To display fine-grained progress feedback during the build, but not clutter the log messages.\n+\n+## Design considerations\n+\n+Since Jib builds/pulls and pushes each layer independently, synchronized progress feedback (completion over all layers, such as a progress bar) could potentially limit the concurrency of the build process - but this might be negligible.\n+\n+The available information for each layer include:\n+\n+- type (classes, resources, dependencies, base image layer, etc.)\n+- digest\n+- size\n+\n+The non-available information for each layer include:\n+\n+- sizes of other layers (eg. other layers may not have finished building)\n+- number of other layers (eg. base image layers have not been resolved before starting to push an application layer)\n+\n+Therefore, the actions we can perform for progress feedback include:\n+\n+- monitor the number of bytes sent (and percentage completion)\n+\n+And the actions we cannot perform include:\n+\n+- know ahead of time how many layers will be pulled/pushed\n+\n+## Proposal\n+\n+Display an overall progress bar along with the tasks currently being executed.\n+\n+### Example\n+\n+```\n+Executing tasks: Pushing classes layer, pulling base image layer 50501d3b88f7, pushing dependencies layer, pushing base image layer 8b106a18283f","path":"proposals/progress_output.md","position":70,"original_position":70,"commit_id":"d0e5b21a875ab32bb532f0addf16e2d9a9ca32d9","original_commit_id":"d0e5b21a875ab32bb532f0addf16e2d9a9ca32d9","user":{"login":"TadCordle","id":521881,"node_id":"MDQ6VXNlcjUyMTg4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/521881?v=4","gravatar_id":"","url":"https://api.github.com/users/TadCordle","html_url":"https://github.com/TadCordle","followers_url":"https://api.github.com/users/TadCordle/followers","following_url":"https://api.github.com/users/TadCordle/following{/other_user}","gists_url":"https://api.github.com/users/TadCordle/gists{/gist_id}","starred_url":"https://api.github.com/users/TadCordle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadCordle/subscriptions","organizations_url":"https://api.github.com/users/TadCordle/orgs","repos_url":"https://api.github.com/users/TadCordle/repos","events_url":"https://api.github.com/users/TadCordle/events{/privacy}","received_events_url":"https://api.github.com/users/TadCordle/received_events","type":"User","site_admin":false},"body":"It may end up being difficult reading these log messages if we put them on one line/constantly update them; it seems like this layout would be great for serial operations, but when we have a bunch of steps executing at once, showing the log messages like this may not add a lot of value.","created_at":"2018-12-03T15:49:26Z","updated_at":"2018-12-03T15:59:27Z","html_url":"https://github.com/GoogleContainerTools/jib/pull/1262#discussion_r238322781","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/238322781"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1262#discussion_r238322781"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262","id":232397040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzk3MDQw","html_url":"https://github.com/GoogleContainerTools/jib/pull/1262","diff_url":"https://github.com/GoogleContainerTools/jib/pull/1262.diff","patch_url":"https://github.com/GoogleContainerTools/jib/pull/1262.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1262","number":1262,"state":"open","locked":false,"title":"Proposal: Provide feedback on push progress.","user":{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"body":"Regards issues: #1251, #806 \r\n\r\nPreview at: https://github.com/GoogleContainerTools/jib/blob/proposal-progress-output/proposals/progress_output.md","created_at":"2018-11-20T17:14:15Z","updated_at":"2018-12-03T15:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"086c68363b503d7f2e6d6321c60204bed1ff47d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016518109,"node_id":"MDU6TGFiZWwxMDE2NTE4MTA5","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":907711846,"node_id":"MDU6TGFiZWw5MDc3MTE4NDY=","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/proposal","name":"proposal","color":"ce3729","default":false}],"milestone":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones/27","html_url":"https://github.com/GoogleContainerTools/jib/milestone/27","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones/27/labels","id":3640981,"node_id":"MDk6TWlsZXN0b25lMzY0MDk4MQ==","number":27,"title":"v0.10.1","description":"","creator":{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":9,"state":"open","created_at":"2018-09-10T18:21:00Z","updated_at":"2018-12-03T15:27:56Z","due_on":"2018-11-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1262/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/d0e5b21a875ab32bb532f0addf16e2d9a9ca32d9","head":{"label":"GoogleContainerTools:proposal-progress-output","ref":"proposal-progress-output","sha":"d0e5b21a875ab32bb532f0addf16e2d9a9ca32d9","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-12-03T15:27:59Z","pushed_at":"2018-12-03T15:28:00Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"git@github.com:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":6281,"stargazers_count":5035,"watchers_count":5035,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":381,"open_issues":98,"watchers":5035,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"8aa0264a20fc54b92c869f35d7603a4c9aa27fdc","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-12-03T15:27:59Z","pushed_at":"2018-12-03T15:28:00Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"git@github.com:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":6281,"stargazers_count":5035,"watchers_count":5035,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":381,"open_issues":98,"watchers":5035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1262"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1262"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1262/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1262/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/d0e5b21a875ab32bb532f0addf16e2d9a9ca32d9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TadCordle"}}