{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/plugins/pulls/comments/175922195","pull_request_review_id":105535874,"id":175922195,"diff_hunk":"@@ -6,31 +6,20 @@ import 'dart:async';\n import 'dart:io';\n \n import 'package:flutter/services.dart';\n+import 'package:meta/meta.dart';\n \n /// Specifies the source where the picked image should come from.\n enum ImageSource {\n-  /// Let the user choose an image from a source they prefer.\n-  ///\n-  /// On Android, opens a new screen with a grid of images (from the users\n-  /// gallery) and a camera icon on the top right corner. The user can\n-  /// either pick an image from the image grid, or tap the camera icon\n-  /// to take a picture using the device camera.\n-  ///\n-  /// On iOS, the user is presented with an alert box with options to\n-  /// either take a photo using the device camera or pick an image from\n-  /// the photo library.\n-  askUser,","path":"packages/image_picker/lib/image_picker.dart","position":18,"original_position":18,"commit_id":"a152e850880a3b44a54c47bbaaee0d8f614299cb","original_commit_id":"a152e850880a3b44a54c47bbaaee0d8f614299cb","user":{"login":"jonahwilliams","id":8975114,"avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"Removing this feature (and thus the default value) is a breaking change - I think it would be a good idea to send an email to flutter-dev@googlegroups.com letting people know. ","created_at":"2018-03-20T21:04:48Z","updated_at":"2018-03-20T21:04:48Z","html_url":"https://github.com/flutter/plugins/pull/423#discussion_r175922195","pull_request_url":"https://api.github.com/repos/flutter/plugins/pulls/423","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/plugins/pulls/comments/175922195"},"html":{"href":"https://github.com/flutter/plugins/pull/423#discussion_r175922195"},"pull_request":{"href":"https://api.github.com/repos/flutter/plugins/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/plugins/pulls/423","id":175092264,"html_url":"https://github.com/flutter/plugins/pull/423","diff_url":"https://github.com/flutter/plugins/pull/423.diff","patch_url":"https://github.com/flutter/plugins/pull/423.patch","issue_url":"https://api.github.com/repos/flutter/plugins/issues/423","number":423,"state":"open","locked":false,"title":"Image picker plugin: use the native Android gallery / file chooser","user":{"login":"roughike","id":13744304,"avatar_url":"https://avatars0.githubusercontent.com/u/13744304?v=4","gravatar_id":"","url":"https://api.github.com/users/roughike","html_url":"https://github.com/roughike","followers_url":"https://api.github.com/users/roughike/followers","following_url":"https://api.github.com/users/roughike/following{/other_user}","gists_url":"https://api.github.com/users/roughike/gists{/gist_id}","starred_url":"https://api.github.com/users/roughike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roughike/subscriptions","organizations_url":"https://api.github.com/users/roughike/orgs","repos_url":"https://api.github.com/users/roughike/repos","events_url":"https://api.github.com/users/roughike/events{/privacy}","received_events_url":"https://api.github.com/users/roughike/received_events","type":"User","site_admin":false},"body":"Changes: \r\n* Uses the native Android gallery UI for picking images, instead of a custom one\r\n* removes the image source selection dialog on iOS\r\n* **Breaking API change:** now the `source` named parameter for the `pickImage` method is annotated with `@required`.\r\n\r\nIssues fixed:\r\n* Fixes flutter/flutter#13706\r\n* Fixes flutter/flutter#11577, except for step 4. Which could be a separate ticket.\r\n* Fixes flutter/flutter#13060, which is an old leftover issue that was actually merged a while ago, but verified working here\r\n\r\nCurrently, the image picker plugin uses a custom gallery UI from [this library](https://github.com/esafirm/android-image-picker), instead of the native one. I'll guess that the original reason for that is that picking images by using the native gallery can be quite wonky.\r\n\r\nWhile this worked fine on my emulator and Motorola Z, there might be a risk that this breaks picking images from gallery for some devices.\r\n\r\nHere's what I mean by \"native Android gallery\":\r\n\r\n![imgpick](https://user-images.githubusercontent.com/13744304/37431554-3d3a87e8-27de-11e8-8747-4d20a0070cee.gif)\r\n\r\nI also refactored the image resizing and Exif data copying logic to separate classes to make the code cleaner.","created_at":"2018-03-14T21:37:02Z","updated_at":"2018-03-20T21:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ddb66382777d52e8ecabf5ffaff1fcf8161be5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":616170846,"url":"https://api.github.com/repos/flutter/plugins/labels/cla:%20yes","name":"cla: yes","color":"FFFFFF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/plugins/pulls/423/commits","review_comments_url":"https://api.github.com/repos/flutter/plugins/pulls/423/comments","review_comment_url":"https://api.github.com/repos/flutter/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/plugins/issues/423/comments","statuses_url":"https://api.github.com/repos/flutter/plugins/statuses/a152e850880a3b44a54c47bbaaee0d8f614299cb","head":{"label":"roughike:feature/use-native-android-image-picker","ref":"feature/use-native-android-image-picker","sha":"a152e850880a3b44a54c47bbaaee0d8f614299cb","user":{"login":"roughike","id":13744304,"avatar_url":"https://avatars0.githubusercontent.com/u/13744304?v=4","gravatar_id":"","url":"https://api.github.com/users/roughike","html_url":"https://github.com/roughike","followers_url":"https://api.github.com/users/roughike/followers","following_url":"https://api.github.com/users/roughike/following{/other_user}","gists_url":"https://api.github.com/users/roughike/gists{/gist_id}","starred_url":"https://api.github.com/users/roughike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roughike/subscriptions","organizations_url":"https://api.github.com/users/roughike/orgs","repos_url":"https://api.github.com/users/roughike/repos","events_url":"https://api.github.com/users/roughike/events{/privacy}","received_events_url":"https://api.github.com/users/roughike/received_events","type":"User","site_admin":false},"repo":{"id":109948859,"name":"plugins","full_name":"roughike/plugins","owner":{"login":"roughike","id":13744304,"avatar_url":"https://avatars0.githubusercontent.com/u/13744304?v=4","gravatar_id":"","url":"https://api.github.com/users/roughike","html_url":"https://github.com/roughike","followers_url":"https://api.github.com/users/roughike/followers","following_url":"https://api.github.com/users/roughike/following{/other_user}","gists_url":"https://api.github.com/users/roughike/gists{/gist_id}","starred_url":"https://api.github.com/users/roughike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roughike/subscriptions","organizations_url":"https://api.github.com/users/roughike/orgs","repos_url":"https://api.github.com/users/roughike/repos","events_url":"https://api.github.com/users/roughike/events{/privacy}","received_events_url":"https://api.github.com/users/roughike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roughike/plugins","description":"Plugins for Flutter maintained by the Flutter team","fork":true,"url":"https://api.github.com/repos/roughike/plugins","forks_url":"https://api.github.com/repos/roughike/plugins/forks","keys_url":"https://api.github.com/repos/roughike/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roughike/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roughike/plugins/teams","hooks_url":"https://api.github.com/repos/roughike/plugins/hooks","issue_events_url":"https://api.github.com/repos/roughike/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/roughike/plugins/events","assignees_url":"https://api.github.com/repos/roughike/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/roughike/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/roughike/plugins/tags","blobs_url":"https://api.github.com/repos/roughike/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roughike/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roughike/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/roughike/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roughike/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/roughike/plugins/languages","stargazers_url":"https://api.github.com/repos/roughike/plugins/stargazers","contributors_url":"https://api.github.com/repos/roughike/plugins/contributors","subscribers_url":"https://api.github.com/repos/roughike/plugins/subscribers","subscription_url":"https://api.github.com/repos/roughike/plugins/subscription","commits_url":"https://api.github.com/repos/roughike/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/roughike/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/roughike/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/roughike/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/roughike/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/roughike/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roughike/plugins/merges","archive_url":"https://api.github.com/repos/roughike/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roughike/plugins/downloads","issues_url":"https://api.github.com/repos/roughike/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/roughike/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/roughike/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/roughike/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roughike/plugins/labels{/name}","releases_url":"https://api.github.com/repos/roughike/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/roughike/plugins/deployments","created_at":"2017-11-08T08:34:26Z","updated_at":"2018-03-15T14:45:55Z","pushed_at":"2018-03-15T17:57:51Z","git_url":"git://github.com/roughike/plugins.git","ssh_url":"git@github.com:roughike/plugins.git","clone_url":"https://github.com/roughike/plugins.git","svn_url":"https://github.com/roughike/plugins","homepage":"http://flutter.io/","size":7284,"stargazers_count":2,"watchers_count":2,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"96bfbc03fcd3b59b88f74d65342cbdadbaed0870","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":88650014,"name":"plugins","full_name":"flutter/plugins","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/plugins","description":"Plugins for Flutter, including FlutterFire, maintained by the Flutter team","fork":false,"url":"https://api.github.com/repos/flutter/plugins","forks_url":"https://api.github.com/repos/flutter/plugins/forks","keys_url":"https://api.github.com/repos/flutter/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/plugins/teams","hooks_url":"https://api.github.com/repos/flutter/plugins/hooks","issue_events_url":"https://api.github.com/repos/flutter/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/plugins/events","assignees_url":"https://api.github.com/repos/flutter/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/plugins/tags","blobs_url":"https://api.github.com/repos/flutter/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/plugins/languages","stargazers_url":"https://api.github.com/repos/flutter/plugins/stargazers","contributors_url":"https://api.github.com/repos/flutter/plugins/contributors","subscribers_url":"https://api.github.com/repos/flutter/plugins/subscribers","subscription_url":"https://api.github.com/repos/flutter/plugins/subscription","commits_url":"https://api.github.com/repos/flutter/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/plugins/merges","archive_url":"https://api.github.com/repos/flutter/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/plugins/downloads","issues_url":"https://api.github.com/repos/flutter/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/plugins/labels{/name}","releases_url":"https://api.github.com/repos/flutter/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/plugins/deployments","created_at":"2017-04-18T17:02:37Z","updated_at":"2018-03-20T19:12:48Z","pushed_at":"2018-03-20T19:12:50Z","git_url":"git://github.com/flutter/plugins.git","ssh_url":"git@github.com:flutter/plugins.git","clone_url":"https://github.com/flutter/plugins.git","svn_url":"https://github.com/flutter/plugins","homepage":"https://flutter.io/","size":7279,"stargazers_count":467,"watchers_count":467,"language":"Dart","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":204,"open_issues":9,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/plugins/pulls/423"},"html":{"href":"https://github.com/flutter/plugins/pull/423"},"issue":{"href":"https://api.github.com/repos/flutter/plugins/issues/423"},"comments":{"href":"https://api.github.com/repos/flutter/plugins/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/plugins/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/plugins/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/plugins/statuses/a152e850880a3b44a54c47bbaaee0d8f614299cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonahwilliams"}}