{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments/195430025","pull_request_review_id":128797724,"id":195430025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQzMDAyNQ==","diff_hunk":"@@ -37,7 +37,7 @@ public override bool Execute ()\n \t\t\t\treturn true;\n \t\t\t}\n \t\t\t// there could be ./AndroidManifest.xml and bin/AndroidManifest.xml, which will be the same. So, ignore \"bin\" ones.\n-\t\t\tManifestDocuments = Directory.GetFiles (TargetDirectory, \"AndroidManifest.xml\", SearchOption.AllDirectories).Where (f => !Path.GetDirectoryName (f).EndsWith (\"bin\")).Select (p => new TaskItem (p)).ToArray ();\n+\t\t\tManifestDocuments = Directory.GetFiles (TargetDirectory, \"AndroidManifest.xml\", SearchOption.AllDirectories).Where (f => !Path.GetDirectoryName (f).EndsWith (\"bin\") && !Path.GetDirectoryName (f).EndsWith (\"manifest\")).Select (p => new TaskItem (p)).ToArray ();","path":"src/Xamarin.Android.Build.Tasks/Tasks/GetImportedLibraries.cs","position":5,"original_position":5,"commit_id":"f6e094e68525f5829d36ffc3ad8edf89821234cc","original_commit_id":"f6e094e68525f5829d36ffc3ad8edf89821234cc","user":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"body":"I'll update the code. We need to skip both bin and manifest.","created_at":"2018-06-14T13:49:22Z","updated_at":"2018-06-14T13:49:23Z","html_url":"https://github.com/xamarin/xamarin-android/pull/1818#discussion_r195430025","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments/195430025"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/1818#discussion_r195430025"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818"}},"in_reply_to_id":195418229},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818","id":194853467,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODUzNDY3","html_url":"https://github.com/xamarin/xamarin-android/pull/1818","diff_url":"https://github.com/xamarin/xamarin-android/pull/1818.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/1818.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/1818","number":1818,"state":"open","locked":false,"title":"[Xamarin.Android.Build.Tasks] Fix inconsistent library cache files.","user":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"body":"Fixes #1814\r\n\r\nBoth `GetImportedLibraries` and `ResolveLibraryProjectImports` have\r\na problem where the cache files they genereate are not always\r\nconsistent between builds.\r\n\r\nIn some cases additional entries are added/removed. As a result\r\ntargets like `_UpdateAndroidResgen` will run when they really\r\ndo not need to. Here are some examples of the changes\r\n\r\n\tdiff -u old.cache Bug15162/obj/Debug/libraryprojectimports.cache\r\n\t--- old.cache\t2018-06-14 11:12:10.000000000 +0100\r\n\t+++ Bug15162/obj/Debug/libraryprojectimports.cache\t2018-06-14 11:12:28.000000000 +0100\r\n\t@@ -1,8 +1,6 @@\r\n\t ﻿<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n\t <Paths>\r\n\t   <Jars>\r\n\t-    <Jar>obj/Debug/lp/0/jl/formsviewgroup.jar</Jar>\r\n\t-    <Jar>obj/Debug/lp/7/jl/support-annotations.jar</Jar>\r\n\t     <Jar>/Users/dean/Downloads/Bug15162-1/Bug15162/obj/Debug/lp/0/jl/formsviewgroup.jar</Jar>\r\n\t     <Jar>/Users/dean/Downloads/Bug15162-1/Bug15162/obj/Debug/lp/10/jl/bin/classes.jar</Jar>\r\n\t     <Jar>/Users/dean/Downloads/Bug15162-1/Bug15162/obj/Debug/lp/11/jl/bin/classes.jar</Jar>\r\n\r\nand\r\n\r\n\tdiff -u old.cache Bug15162/obj/Debug/libraryimports.cache\r\n\t--- old.cache\t2018-06-14 11:29:41.000000000 +0100\r\n\t+++ Bug15162/obj/Debug/libraryimports.cache\t2018-06-14 11:30:42.000000000 +0100\r\n\t@@ -3,27 +3,40 @@\r\n\t   <ManifestDocuments>\r\n\t     <ManifestDocument>obj/Debug/lp/10/jl/AndroidManifest.xml</ManifestDocument>\r\n\t     <ManifestDocument>obj/Debug/lp/11/jl/AndroidManifest.xml</ManifestDocument>\r\n\t+    <ManifestDocument>obj/Debug/lp/11/jl/manifest/AndroidManifest.xml</ManifestDocument>\r\n\t     <ManifestDocument>obj/Debug/lp/12/jl/AndroidManifest.xml</ManifestDocument>\r\n\r\nIn both cases additional files are picked up or added. In the case of `ResolveLibraryProjectImports`\r\nthe extra `jars.Add` was not need because at the end of the task we add ALL the jar files\r\nwe find in the output directory. The additional `jars.Add` was responsible for adding\r\nthe non-fullpath variants of the files.\r\n\r\nThe `GetImportedLibraries` was adding the files from a `manifest` subdirectory in the `lp`\r\nintermediate directories.","created_at":"2018-06-14T10:53:39Z","updated_at":"2018-06-14T13:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce28652611dbb8d267c7472f97c34d16187b5909","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/1818/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/f6e094e68525f5829d36ffc3ad8edf89821234cc","head":{"label":"dellis1972:Issue1814","ref":"Issue1814","sha":"f6e094e68525f5829d36ffc3ad8edf89821234cc","user":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"repo":{"id":58043062,"node_id":"MDEwOlJlcG9zaXRvcnk1ODA0MzA2Mg==","name":"xamarin-android","full_name":"dellis1972/xamarin-android","owner":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dellis1972/xamarin-android","description":null,"fork":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android","forks_url":"https://api.github.com/repos/dellis1972/xamarin-android/forks","keys_url":"https://api.github.com/repos/dellis1972/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dellis1972/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dellis1972/xamarin-android/teams","hooks_url":"https://api.github.com/repos/dellis1972/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/dellis1972/xamarin-android/events","assignees_url":"https://api.github.com/repos/dellis1972/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/dellis1972/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/dellis1972/xamarin-android/tags","blobs_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dellis1972/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dellis1972/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/dellis1972/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/dellis1972/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/dellis1972/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/dellis1972/xamarin-android/subscription","commits_url":"https://api.github.com/repos/dellis1972/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dellis1972/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dellis1972/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/dellis1972/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dellis1972/xamarin-android/merges","archive_url":"https://api.github.com/repos/dellis1972/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dellis1972/xamarin-android/downloads","issues_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/dellis1972/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dellis1972/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dellis1972/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dellis1972/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/dellis1972/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/dellis1972/xamarin-android/deployments","created_at":"2016-05-04T10:18:56Z","updated_at":"2018-06-14T10:40:53Z","pushed_at":"2018-06-14T10:53:21Z","git_url":"git://github.com/dellis1972/xamarin-android.git","ssh_url":"git@github.com:dellis1972/xamarin-android.git","clone_url":"https://github.com/dellis1972/xamarin-android.git","svn_url":"https://github.com/dellis1972/xamarin-android","homepage":null,"size":14768,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"d013087593daf391ef15f6f719571ecfff881448","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":55075302,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA3NTMwMg==","name":"xamarin-android","full_name":"xamarin/xamarin-android","owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-android","description":"Xamarin.Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-android","forks_url":"https://api.github.com/repos/xamarin/xamarin-android/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-android/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-android/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-android/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-android/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-android/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-android/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-android/deployments","created_at":"2016-03-30T15:37:14Z","updated_at":"2018-06-14T13:39:55Z","pushed_at":"2018-06-14T10:53:39Z","git_url":"git://github.com/xamarin/xamarin-android.git","ssh_url":"git@github.com:xamarin/xamarin-android.git","clone_url":"https://github.com/xamarin/xamarin-android.git","svn_url":"https://github.com/xamarin/xamarin-android","homepage":"","size":15053,"stargazers_count":967,"watchers_count":967,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":282,"open_issues":179,"watchers":967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/1818"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/1818"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/1818/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1818/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-android/statuses/f6e094e68525f5829d36ffc3ad8edf89821234cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dellis1972"}}