{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/182605155","pull_request_review_id":113434095,"id":182605155,"diff_hunk":"@@ -65,5 +65,96 @@\n       [ [ \"scrap\", 1 ] ],\n       [ [ \"plastic_chunk\", 1 ] ]\n     ]\n+  },\n+  {\n+    \"type\": \"recipe\",\n+    \"result\": \"red_dot_sight\",","path":"data/json/recipes/weapon/mods.json","position":7,"original_position":7,"commit_id":"ee3c87a3e147151eef2829d45f0edd3820be11fb","original_commit_id":"ee3c87a3e147151eef2829d45f0edd3820be11fb","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars0.githubusercontent.com/u/860276?v=4","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"From wikipedia https://en.wikipedia.org/wiki/Red_dot_sight\r\n```The typical configuration for a red dot sight is a tilted spherical mirror reflector with a red light-emitting diode (LED) at its off axis focus. The mirror has a partially silvered multilayer dielectric dichroic coating designed to reflect just the red spectrum allowing it to pass through most other light.```\r\nIn short, the actual device requires a *very specific* lens, but you've substituted an arbitrary lens.\r\nIn other words, if you take a lens off of a pair of glasses, pair of binoculars, magnifying glass, or literally any other source of the lens item in the game, it will not be the right kind of lens to make a red dot sight.","created_at":"2018-04-19T00:18:43Z","updated_at":"2018-04-19T00:26:06Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536#discussion_r182605155","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/182605155"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536#discussion_r182605155"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536","id":182535491,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23536","number":23536,"state":"open","locked":false,"title":"Added scope recipes.","user":{"login":"Isaacssv552","id":5642624,"avatar_url":"https://avatars2.githubusercontent.com/u/5642624?v=4","gravatar_id":"","url":"https://api.github.com/users/Isaacssv552","html_url":"https://github.com/Isaacssv552","followers_url":"https://api.github.com/users/Isaacssv552/followers","following_url":"https://api.github.com/users/Isaacssv552/following{/other_user}","gists_url":"https://api.github.com/users/Isaacssv552/gists{/gist_id}","starred_url":"https://api.github.com/users/Isaacssv552/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isaacssv552/subscriptions","organizations_url":"https://api.github.com/users/Isaacssv552/orgs","repos_url":"https://api.github.com/users/Isaacssv552/repos","events_url":"https://api.github.com/users/Isaacssv552/events{/privacy}","received_events_url":"https://api.github.com/users/Isaacssv552/received_events","type":"User","site_admin":false},"body":"I've added recipes for certain scopes and related gun mods. Parameters are based on survivor's scope and other existing recipes.\r\n\r\nRationale:\r\n- A survivor is not capable of making telescopic lenses. However, high quality optics are obtainable through disassembly. Therefore survivors should have to capacity to craft simple (not holographic, ACOG, or rifle) scopes.\r\n- A survivor can already create laser sights for the rail or underbarrel. Allowing creation of a direct sight replacement seems reasonable.\r\n- A survivor can already craft both telescopes and properly calibrated iron sights. (In fact, survivor made si) Allowing crafting of a properly calibrated scope seems reasonable.\r\n- A survivor is already capable of creating rifle stocks. Therefore sufficient fabrication should allow the creation of pistol stocks.","created_at":"2018-04-18T16:28:51Z","updated_at":"2018-04-19T00:26:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95bc638702e5e2348ad9e5ea9f22e0c6f256da5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":513175929,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Crafting%20/%20Construction%20/%20Recipes","name":"Crafting / Construction / Recipes","color":"cf7957","default":false},{"id":340186099,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Gunmod%20/%20Toolmod","name":"Gunmod / Toolmod","color":"83e04c","default":false},{"id":235869031,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[JSON]","name":"[JSON]","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23536/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/ee3c87a3e147151eef2829d45f0edd3820be11fb","head":{"label":"Isaacssv552:scope-recipes","ref":"scope-recipes","sha":"ee3c87a3e147151eef2829d45f0edd3820be11fb","user":{"login":"Isaacssv552","id":5642624,"avatar_url":"https://avatars2.githubusercontent.com/u/5642624?v=4","gravatar_id":"","url":"https://api.github.com/users/Isaacssv552","html_url":"https://github.com/Isaacssv552","followers_url":"https://api.github.com/users/Isaacssv552/followers","following_url":"https://api.github.com/users/Isaacssv552/following{/other_user}","gists_url":"https://api.github.com/users/Isaacssv552/gists{/gist_id}","starred_url":"https://api.github.com/users/Isaacssv552/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isaacssv552/subscriptions","organizations_url":"https://api.github.com/users/Isaacssv552/orgs","repos_url":"https://api.github.com/users/Isaacssv552/repos","events_url":"https://api.github.com/users/Isaacssv552/events{/privacy}","received_events_url":"https://api.github.com/users/Isaacssv552/received_events","type":"User","site_admin":false},"repo":{"id":130082343,"name":"Cataclysm-DDA","full_name":"Isaacssv552/Cataclysm-DDA","owner":{"login":"Isaacssv552","id":5642624,"avatar_url":"https://avatars2.githubusercontent.com/u/5642624?v=4","gravatar_id":"","url":"https://api.github.com/users/Isaacssv552","html_url":"https://github.com/Isaacssv552","followers_url":"https://api.github.com/users/Isaacssv552/followers","following_url":"https://api.github.com/users/Isaacssv552/following{/other_user}","gists_url":"https://api.github.com/users/Isaacssv552/gists{/gist_id}","starred_url":"https://api.github.com/users/Isaacssv552/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isaacssv552/subscriptions","organizations_url":"https://api.github.com/users/Isaacssv552/orgs","repos_url":"https://api.github.com/users/Isaacssv552/repos","events_url":"https://api.github.com/users/Isaacssv552/events{/privacy}","received_events_url":"https://api.github.com/users/Isaacssv552/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Isaacssv552/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/Isaacssv552/Cataclysm-DDA/deployments","created_at":"2018-04-18T15:19:50Z","updated_at":"2018-04-18T15:20:02Z","pushed_at":"2018-04-18T21:09:00Z","git_url":"git://github.com/Isaacssv552/Cataclysm-DDA.git","ssh_url":"git@github.com:Isaacssv552/Cataclysm-DDA.git","clone_url":"https://github.com/Isaacssv552/Cataclysm-DDA.git","svn_url":"https://github.com/Isaacssv552/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1134017,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"e5d2149ad93adc8b78a349a4b48d0197b392e5d6","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-04-18T17:17:09Z","pushed_at":"2018-04-18T23:22:11Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1135807,"stargazers_count":1802,"watchers_count":1802,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1273,"mirror_url":null,"archived":false,"open_issues_count":767,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1273,"open_issues":767,"watchers":1802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/23536"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23536"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/23536/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/23536/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/ee3c87a3e147151eef2829d45f0edd3820be11fb"}},"author_association":"NONE"}}
{"actor":{"display_login":"kevingranade"}}