{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/226478302","pull_request_review_id":166311482,"id":226478302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ3ODMwMg==","diff_hunk":"@@ -47,8 +47,10 @@ String _localeClosure() => window.locale.toString();\n @pragma('vm:entry-point')\n _LocaleClosure _getLocaleClosure() => _localeClosure;\n \n+// BUG: https://github.com/flutter/flutter/issues/23246\n+// Change back to List<String> when fixed\n @pragma('vm:entry-point')\n-void _updateLocales(List<String> locales) {\n+void _updateLocales(List<dynamic> locales) {","path":"lib/ui/hooks.dart","position":8,"original_position":8,"commit_id":"e81943ab399b1be4c8a0aedd1a417c399766864d","original_commit_id":"e81943ab399b1be4c8a0aedd1a417c399766864d","user":{"login":"jason-simmons","id":14226037,"node_id":"MDQ6VXNlcjE0MjI2MDM3","avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"This should no longer be necessary now that https://github.com/flutter/engine/commit/2707b7433874a8b03e4a1f7341d45b5cdcc8dfc6 has landed\r\n","created_at":"2018-10-18T21:54:14Z","updated_at":"2018-10-18T21:54:20Z","html_url":"https://github.com/flutter/engine/pull/6601#discussion_r226478302","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/6601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/226478302"},"html":{"href":"https://github.com/flutter/engine/pull/6601#discussion_r226478302"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/6601"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/6601","id":224105002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTA1MDAy","html_url":"https://github.com/flutter/engine/pull/6601","diff_url":"https://github.com/flutter/engine/pull/6601.diff","patch_url":"https://github.com/flutter/engine/pull/6601.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/6601","number":6601,"state":"open","locked":false,"title":"Roll Dart to 4585b8eb449b20f492173b5b08b28fc760ee58d2","user":{"login":"aartbik","id":39774503,"node_id":"MDQ6VXNlcjM5Nzc0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/39774503?v=4","gravatar_id":"","url":"https://api.github.com/users/aartbik","html_url":"https://github.com/aartbik","followers_url":"https://api.github.com/users/aartbik/followers","following_url":"https://api.github.com/users/aartbik/following{/other_user}","gists_url":"https://api.github.com/users/aartbik/gists{/gist_id}","starred_url":"https://api.github.com/users/aartbik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aartbik/subscriptions","organizations_url":"https://api.github.com/users/aartbik/orgs","repos_url":"https://api.github.com/users/aartbik/repos","events_url":"https://api.github.com/users/aartbik/events{/privacy}","received_events_url":"https://api.github.com/users/aartbik/received_events","type":"User","site_admin":false},"body":"Note: includes\r\n(1) workaround for\r\nhttps://github.com/flutter/flutter/issues/23246\r\n(2) change in build rule\r\n\r\nDart changes included in this roll:\r\n\r\n4585b8eb44 [gardening] Mark RawDatagramSocket/any_A01_t02 co19 test flaky\r\nd04a36b4ab [infra] Fix third_party/pkg_tested step having slash in name.\r\n1061c83779 Optionally report scanner errors via errors list rather than in the token stream\r\nfed5bc62b6 [co19] DEPS and .status files updated\r\nb27e4febaf Eliminate an unnecessary boolean variable\r\na29c04953e Automatically run analysis server from source if launched with the SDK source tree\r\nd07f3edd5e [vm] Disable symbolization of Dart frames in Dart_DumpNativeStackTrace.\r\n3039fb0031 Sort LSP files\r\n0aa2dc6ead Batch 'inherit'\r\n2bb4284c63 Add a few more tests and comments for GnWorkspace\r\n5dfe3c8f94 bump to linter 0.1.69\r\n1ca91cb6db Ensure unterminated string error is reported on visible characters\r\nce1eac3800 Adapt analyzer/FE comparison logic to handle mixins with >2 superclass constraints.\r\ncc750ecec1 Revert \"Don't clone constant ASTs when running with Analysis Driver.\"\r\nc7bc970ba7 [vm/simdbc] Clean up slot for result in InlineCacheMiss\r\nd5e5842971 [vm/interpreter] Fix stack frame recording in native calls\r\n5d4ce27bea [vm] Fix race between Dart::Cleanup and VerifyBootstrapClasses.\r\n4506e1d179 add linter changes (#34817)\r\na53172cd47 [vm] Print isolate sticky_error during shutdown to let user know of unhandled exceptions.\r\n22b4ec0e78 [vm/interpreter] Clean up slot for result in InlineCacheMiss\r\nb10a36b8df [vm] Set WasCompiled at safepoint\r\n27b3f0ba6b [vm/frontend] Allow 'package:'-scheme uris as sources for frontend_server compilation.\r\na3db8a904e Support running analyzer_cli in worker mode in an isolate.\r\n3fc1f36e28 [vm] Update status files for issue 34760.\r\nf337b254ce Support running dartdevc in worker mode in an isolate.\r\n18f56e59cf [infra] Add configuration name to results.json\r\n843b4c9c23 Refactoring to prepare for serialization\r\n531bce152d Tune invariants for inferredTypesMap\r\n822fd6a1ed Remove StringLiteralJudgment\r\ncf84ce88d6 Remove StringConcatenationJudgment\r\nf0ebf05092 Remove RethrowJudgment\r\n83c6963ce2 Remove PropertyGetJudgment\r\n2a9ba09b93 Allow abstract operator == methods in switch case constants\r\n5d1832b20a Disallow factory constructors in mixin declarations.\r\n055ce6f101 fix syntax error on android\r\n130f57f7f3 missing include for android\r\nee975c89e2 [dart2js] Force --fast-startup holders to be fast objects\r\n8fb17e0b6a Missing import for some linux builds\r\n5c1a40837e Update analyzer fix sorting by priority\r\n6e23c3b3cb Support SO_REUSEPORT and IP_MULTICAST_TTL for datagram sockets.\r\n9a69a5c1ee Remove more unnecessary awaits (from analyzer)\r\n5b574415f8 Fix GnWorkspace root\r\n7f9049991b [ VM / Dart API ] Updated Dart_Invoke Dart_SetField tests to check error messages\r\n2d397d1da6 Fix for dartbug.com/34821, variable_name_contributor.dart to complete \"var SomeType |\", to \"someType\" and \"_someType\", for declarations that can be denoted private.\r\n0eb5dbffac [vm] Revert service isolate setup in main.cc\r\n445a43b58d [ VM / Testing ] Add build flags to enable code coverage\r\n6066ac83e3 Improve dartfix console output\r\nda67d58110 Remove some unnecessary await expressions\r\nf99d89b513 Update dartdoc to 0.24.0\r\n93b1955ed0 Dartfix ui tweaks.\r\n009eabf892 [Test tool] Add VM options to compiler arguments in VMKernelCompilerConfiguration\r\n984c407bb3 [build] Debug means debug!\r\n3a69805f6b Switch enums that don't have type aliases to stronger-typed values\r\n56306b90ee Fix html changes markdown syntax:\r\nf921f203f4 [vm/bytecode] Fix constant evaluation of factory constructors in bytecode\r\n20f4349951 Fix for reporting INVALID_USE_OF_PROTECTED_MEMBER in documentation comments.\r\nfade5f33f0 Regenerate code based on the server spec after updates to the generator\r\n1996e78049 Update dart2js_info in DEPS to 0.5.13\r\ndf621a1fff Fix cast exception in TypeNameResolver (issue-34809)\r\nf4ffb426c4 [Gardening] Mark flaky co19 tests and filed issue\r\n4d5c5ecdbf Update synced version of pkg:test\r\n8300248edb [VM] Ensure inferred types are set on parameters\r\n5d78509e25 Make FieldElementImpl.isCovariant a public member on FieldElement\r\n9ba152b69e Mark deprecated fields as such\r\nde6f24367a Fix build from two incompatible changes landing\r\ncfa92dc090 Remove NullJudgment\r\n9fadaec5f8 Remove NotJudgment\r\ne65ed1d143 Remove LogicalJudgment\r\n0bcd98eb76 Remove FunctionExpressionJudgment\r\n4df63225a8 Remove IsJudgment and IsNotJudgment\r\n035aad457e Remove ConstructorInvocationJudgment\r\n840afb4f9d Remove ConditionalJudgment\r\n7fa8bc3fee Remove BoolJudgment\r\n2495e2e951 [vm] Silence output from kernel::Program::ReadFromFile.\r\nc0ec6299ad Extract enums from the spec\r\nea72ba3b1d Move sorting from reading to codegen\r\nab253a8a4e Review comments for \"[vm/aot] Fix regressions from dynamic invocation forwarders in AOT.\"\r\n801f28666a Remove ThisJudgment\r\naf00f7c05d [vm/aot] Fix regressions from dynamic invocation forwarders in AOT.\r\n349adc5b1f Reland \"[VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR\"\r\ned73cc379d Increase file descriptor limit when running test.py on MacOS\r\n5ce132a912 [infra] Copy core dumps to ISOLATED_OUTDIR on shards (#34746)\r\na2aa6c8414 Consolidate DDC dependencies on front_end\r\n9137fe26ac Remove deprecated_problems.dart\r\ned7be67cab Remove CompilerOptions.onProblem\r\n18cb217840 Remove CompilerOptions.onError and CompilationMessage\r\n2084c5b2a9 Add toJson() methods\r\nd4fac1684c Remove CompilerOptions.reportMessages\r\nc6b43d9cb6 Use ansi color in the dartfix cli output.\r\nc8cf355c54 Bump package dart_internal's SDK constraint upper-bound to <2.2.0\r\n2ed614819d [vm] Fix MakeUnusedSpaceTraversable in the 'Instance' filler case\r\nc362e4862f [vm] Invalidate KernelProgramInfo caches on a reload\r\nac6d4f7e65 [vm] Disable conversion of large typed data to external when sending through a message port\r\ndea6c97a08 [vm] A couple more benchmark for kernel loading\r\nf3c51a4be0 Organize imports.\r\nae22eaa48b Remove unused import\r\nabcb84ac78 Re-order the dartdoc param.\r\n311a184cb8 Remove type merging and the only instance that used it\r\ndd59921896 Support \"{@link xxx}\" in LSP spec\r\n1f344e4ee0 Add support for \"class\" instead of interface\r\n0a6d960d66 Update bazel_worker to onDiagnostic\r\ne502edf28b Add DiagnosticMessage support API\r\n88bde88112 Add constructors and mark all fields final\r\nbf270577cc [fasta] Report errors on generic function types in type arguments\r\n06f9a9e354 [VM] Introduce function and osr entrypoints to the VM's IR\r\n22b11717ac [fasta] Fix bounds checking: non-generic types are always well-bounded\r\n0a986f3f80 Remove a few shadow nodes.\r\n490421d166 Fixed Service Workers and any Promise/Future API with a Dictionary parameter.\r\n77c5677abe Don't clone constant ASTs when running with Analysis Driver.\r\n1cabefdf5b Fix analyzer/FE comparison tool handling of mixins.\r\n45092fd0aa Improve output of analyzer/FE comparison tool.\r\na4f3df6534 [vm] Fix symlinks in test cases.\r\n180b3dd301 Remove extra spaces in copyright notices in analyzer_plugin\r\nd127ab9a27 Get rid of places that allocate lots of _Closure instances.\r\n5cff16bc75 Use single InheritanceManager2 instance for Linker.\r\nd8e52e5e82 Remove last references to InheritanceManager in analyzer/server.\r\n9f00eec55b [ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors\r\n2ec7c9cdb1 Skip the tests that require super mixin support\r\n469e1e2e64 Remove unnecessary library directives\r\n1d0d9f1d3f [vm] Fix heap corruption while reading \"kernel list\" file\r\n80cddf0d53 Rename writeOverrideOfInheritedMember() to writeOverride() in DartEditBuilder.\r\n2c352111a4 Use just TypeSystem in InheritanceManager2.\r\n977f5c2c21 Switch KytheDartVisitor to InheritanceManager2.\r\nbc2ea566f1 Auto generate more analyzer error codes\r\na2a3c36b77 Switch CREATE_MISSING_OVERRIDES to writeOverrideOfInheritedMember() and using FunctionType signatures.\r\naabc26bafe Revert \"[VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR\"\r\ndac3e0d9df [dart2js] Don't create instance call-through stubs for statics\r\ne34472db10 Remove unused import\r\n22190e4d79 [vm] In IsolateMirror.loadUri, note that a kernel file at a URI may not contain any library with that URI.\r\ndc9d6785de Report compile-time errors on invalid switch cases\r\naf8d026337 Address dartfix comments and improve output\r\n841a75698d [vm] Fix typo in previous commit\r\n5b6220d44d [vm/compiler] Start of loop framework\r\n0b1b09116a Simplify handling of non-shadow nodes in type inference\r\naa9f0f911f Update stream.dart\r\n0e001641a9 Re-write invalid ASTs and update fix to reflect new AST structure for invalid type arguments on named constructors\r\n48544cd77d Use InheritanceManager2 in InstanceMemberInferrer.\r\n29ff9e4a6a [VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR\r\n3199875231 Remove TypeSystemImpl.\r\n0b78ac7f38 [VM] Add regression test for buildbot flakiness due to smi-widening optimization in VM\r\naf7cead848 Clone default values of mixin application constructors\r\n47c55605b8 Reland: [vm] Add a library and class cache to KernelProgramInfo\r\n87a10d9811 Provide context for NotAType\r\n69cf0ec97c Signal an error if a class extends a mixin\r\n99815c8d6d Do not print --output_directory in reproduction commands\r\n9b41728b2d Remove FileParseExceptionHandler from FileSystemState.\r\neee8787a8d Generate noSuchMethod forwarders for private members inherited from a class in a foreign library.\r\n5b1fcb09df Remove d2fe ikg minimal benchmark from commit queue.\r\n54ef78b7c5 Remove non-strong vm dill files from SDK\r\n6177615d71 [kernel] Fix subtype relationship for generic function types\r\n1f4dfce179 [gardening] Mark co19 LibTest/io/HttpServer/close_A05_t01 flaky\r\n5cbb640f7c Error for type arguments after named constructor with implicit new\r\n2fa1143600 Check classes at mixin applications\r\nade528c4e6 Fixed the type alias omission in the def. of simple bounds\r\nddf67772bb Remove warning about inferring packages URI from dart2js\r\n18110717fe Move infer methods to visitor\r\nbd223d0ec4 Add consistent_type_error_test\r\nd95f63d752 Update dartfix to use new invalid type argument fix\r\n0cdd5b9ff3 Raise warning to error: duplicate key in a const map is now an error in Dart.\r\nf6ca2c1d8f Remove the Dart 1 tests.\r\n9f98f5f44c Remove instantiateToBounds parameter from FunctionTypeImpl.relate.\r\n82f31cd250 Add types to method args to avoid analysis warnings.\r\n63c9a241e3 Upgrade WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR from a warning to an error\r\n5658d406b7 Add changelog entry for integer literals in double contexts.\r\n6b67cd784b [vm] Make UBSAN happy for the code in Range::BitwiseOp\r\ne4c3fa0a9c Improve recovery when parsing named constructor invocation with invalid type arguments\r\n3e7ce992cf [vm/tfa] Implementation of type arguments tracking in TFA.\r\n001343ce06 [vm, gc] Disable reads and writes to from-space after a scavenge.\r\n97ffcd9a3d [vm] Disable incorrect widening of smis to int32\r\n1a4933715e [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A03_t01 flaky\r\ne4842a293b Remove extra spaces in headers\r\n58c90dc488 [vm] Fix bytecode in core-jit for simarm64\r\nfab5d0a50d In InheritanceManager remove unused, and deprecate used (in lints) methods.\r\n2989116219 Add some special cases for types we can't/don't need to parse\r\n49b121f20d Remove TypeParameterSerializationContext.location.\r\n244e6c7ffc Infer package URIs\r\ncc884b3449 Remove optional argument from FunctionTypeImpl.forTypedef.\r\n931202df27 Improve wrapping of lists and *notes* in LSP spec comments\r\n3e897ac3b1 [vm] Extend previous status file updates.\r\n23e7f9d1eb Handle references to other classes in comments\r\n472c898c87 [dartdevc] fix for-in loop variable shadowing a var used in initialzer\r\n3fe3106489 [gardening] Fix leaks in run_vm_tests binary detected by ASAN.\r\na6c8b62056 Remove dummy .packages files\r\n2f7e7a4b52 [vm] Update status files for vm-kernel-mac-product-x64 for issue 34760.\r\ne12538fff0 Move package bundle functionality into SummaryBaseTestStrategy.\r\n96737787e2 Add LSP spec code-gen output\r\n5e7ea5b672 [infra] Add .vpython spec to fix gsutil on the bots (#31065)\r\n3cf0008b13 [vm/bytecode] Remove dependencies on ASTs when running with bytecode\r\nfc0decc262 Improvements to the Dart code generated from the LSP spec.\r\nefcca1132b Switch ErrorVerifier and OverrideVerifier to InheritanceManager2.\r\nc347850976 [gardening] Mark co19 LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky\r\n5e1bf1d135 Create LibraryScope once per library analyzer.\r\n7c7df7bfa4 Add initial version of feature specification on interface conflicts.\r\nf2bffc6872 Revert \"[infra] Upgrade gsutil to a new version (#31065)\"\r\n1809bae318 Revert \"Ignore JSON exceptions when reading (empty) test results file\"\r\n787194e738 [infra] Upgrade gsutil to a new version (#31065)\r\n265d0d9ec1 Update status files after 8648d782\r\n23c36ed029 Elaborate that -0 means -0.0 in double context or when compiled to JS.\r\n8648d782ae Reland \"[fasta] Report errors for bounds violations\"\r\n5c9a8d8cb5 [VM] Add $target_gen_dir/gen_kernel_bytecode.dill.d to outputs of GN action, to ensure directory is created before action is run\r\n49d7fb39ac Temporarily ignore --strong option in flutter builds\r\nf0a30bc8d1 Revert \"[vm] Add a library and class cache to KernelProgramInfo\"\r\n1c2ed4ac11 [infra] Include gsutil in vm-kernel fileset to enable coredumps on shards (#31065)\r\n5b32ab3be6 Remove the word \"strongMode\" from some package:kernel libraries.\r\ndfb8e97b86 Report errors on members hiding prefixes\r\n235a918233 [vm] Remove Dart_LoadScript, Dart_LoadLibrary, Dart_LoadSource, etc.\r\n90e362f63c Deprecate the last non-deprecated EMPTY_LIST\r\n0ab8e42fea Use a special context for serializing generic function types.\r\nc47879d354 Remove one-phase summary logic.\r\nb9dd229e35 Convert element.dart to triple-slash comment style.\r\ne70a7aab8a [VM] Dead code removal - Remove dead code around creation of service isolate in gen_snapshot.cc - Create service isolate from the core snapshot - exclude sources from platform dill file (saves about 2.5MB in size)\r\n662ff7f112 [vm] Remove TokenStream, TokenValue, CompilerStats.\r\na933f42b9e [VM] Use Symbols::Empty() when there is no source for a script instead of creating new empty string objects. Change-Id: I8ec6702557b07c4c4ede2aece5a3f25b4cde1a5b Reviewed-on: https://dart-review.googlesource.com/c/79060 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>\r\n72b31316e4 [observatory] Fail gracefully when a Script lacks source code.","created_at":"2018-10-18T21:28:28Z","updated_at":"2018-10-18T21:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ccb6f2059036106a656430f9e9d68ac963c3665","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rmacnak-google","id":8495071,"node_id":"MDQ6VXNlcjg0OTUwNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8495071?v=4","gravatar_id":"","url":"https://api.github.com/users/rmacnak-google","html_url":"https://github.com/rmacnak-google","followers_url":"https://api.github.com/users/rmacnak-google/followers","following_url":"https://api.github.com/users/rmacnak-google/following{/other_user}","gists_url":"https://api.github.com/users/rmacnak-google/gists{/gist_id}","starred_url":"https://api.github.com/users/rmacnak-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmacnak-google/subscriptions","organizations_url":"https://api.github.com/users/rmacnak-google/orgs","repos_url":"https://api.github.com/users/rmacnak-google/repos","events_url":"https://api.github.com/users/rmacnak-google/events{/privacy}","received_events_url":"https://api.github.com/users/rmacnak-google/received_events","type":"User","site_admin":false},{"login":"a-siva","id":8633293,"node_id":"MDQ6VXNlcjg2MzMyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8633293?v=4","gravatar_id":"","url":"https://api.github.com/users/a-siva","html_url":"https://github.com/a-siva","followers_url":"https://api.github.com/users/a-siva/followers","following_url":"https://api.github.com/users/a-siva/following{/other_user}","gists_url":"https://api.github.com/users/a-siva/gists{/gist_id}","starred_url":"https://api.github.com/users/a-siva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-siva/subscriptions","organizations_url":"https://api.github.com/users/a-siva/orgs","repos_url":"https://api.github.com/users/a-siva/repos","events_url":"https://api.github.com/users/a-siva/events{/privacy}","received_events_url":"https://api.github.com/users/a-siva/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487933577,"node_id":"MDU6TGFiZWw0ODc5MzM1Nzc=","url":"https://api.github.com/repos/flutter/engine/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/6601/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/6601/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/6601/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/e81943ab399b1be4c8a0aedd1a417c399766864d","head":{"label":"aartbik:aart_roll","ref":"aart_roll","sha":"e81943ab399b1be4c8a0aedd1a417c399766864d","user":{"login":"aartbik","id":39774503,"node_id":"MDQ6VXNlcjM5Nzc0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/39774503?v=4","gravatar_id":"","url":"https://api.github.com/users/aartbik","html_url":"https://github.com/aartbik","followers_url":"https://api.github.com/users/aartbik/followers","following_url":"https://api.github.com/users/aartbik/following{/other_user}","gists_url":"https://api.github.com/users/aartbik/gists{/gist_id}","starred_url":"https://api.github.com/users/aartbik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aartbik/subscriptions","organizations_url":"https://api.github.com/users/aartbik/orgs","repos_url":"https://api.github.com/users/aartbik/repos","events_url":"https://api.github.com/users/aartbik/events{/privacy}","received_events_url":"https://api.github.com/users/aartbik/received_events","type":"User","site_admin":false},"repo":{"id":135739436,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3Mzk0MzY=","name":"engine","full_name":"aartbik/engine","private":false,"owner":{"login":"aartbik","id":39774503,"node_id":"MDQ6VXNlcjM5Nzc0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/39774503?v=4","gravatar_id":"","url":"https://api.github.com/users/aartbik","html_url":"https://github.com/aartbik","followers_url":"https://api.github.com/users/aartbik/followers","following_url":"https://api.github.com/users/aartbik/following{/other_user}","gists_url":"https://api.github.com/users/aartbik/gists{/gist_id}","starred_url":"https://api.github.com/users/aartbik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aartbik/subscriptions","organizations_url":"https://api.github.com/users/aartbik/orgs","repos_url":"https://api.github.com/users/aartbik/repos","events_url":"https://api.github.com/users/aartbik/events{/privacy}","received_events_url":"https://api.github.com/users/aartbik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aartbik/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/aartbik/engine","forks_url":"https://api.github.com/repos/aartbik/engine/forks","keys_url":"https://api.github.com/repos/aartbik/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aartbik/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aartbik/engine/teams","hooks_url":"https://api.github.com/repos/aartbik/engine/hooks","issue_events_url":"https://api.github.com/repos/aartbik/engine/issues/events{/number}","events_url":"https://api.github.com/repos/aartbik/engine/events","assignees_url":"https://api.github.com/repos/aartbik/engine/assignees{/user}","branches_url":"https://api.github.com/repos/aartbik/engine/branches{/branch}","tags_url":"https://api.github.com/repos/aartbik/engine/tags","blobs_url":"https://api.github.com/repos/aartbik/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aartbik/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aartbik/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/aartbik/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aartbik/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/aartbik/engine/languages","stargazers_url":"https://api.github.com/repos/aartbik/engine/stargazers","contributors_url":"https://api.github.com/repos/aartbik/engine/contributors","subscribers_url":"https://api.github.com/repos/aartbik/engine/subscribers","subscription_url":"https://api.github.com/repos/aartbik/engine/subscription","commits_url":"https://api.github.com/repos/aartbik/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/aartbik/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/aartbik/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/aartbik/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/aartbik/engine/contents/{+path}","compare_url":"https://api.github.com/repos/aartbik/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aartbik/engine/merges","archive_url":"https://api.github.com/repos/aartbik/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aartbik/engine/downloads","issues_url":"https://api.github.com/repos/aartbik/engine/issues{/number}","pulls_url":"https://api.github.com/repos/aartbik/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/aartbik/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/aartbik/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aartbik/engine/labels{/name}","releases_url":"https://api.github.com/repos/aartbik/engine/releases{/id}","deployments_url":"https://api.github.com/repos/aartbik/engine/deployments","created_at":"2018-06-01T16:18:14Z","updated_at":"2018-06-01T16:18:18Z","pushed_at":"2018-10-18T21:24:21Z","git_url":"git://github.com/aartbik/engine.git","ssh_url":"git@github.com:aartbik/engine.git","clone_url":"https://github.com/aartbik/engine.git","svn_url":"https://github.com/aartbik/engine","homepage":"http://flutter.io","size":123056,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"3860a43379fa3a7474427a671c794fa29e555c10","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"node_id":"MDEwOlJlcG9zaXRvcnkzOTIxMTMzNw==","name":"engine","full_name":"flutter/engine","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2018-10-18T21:53:52Z","pushed_at":"2018-10-18T21:53:48Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":143282,"stargazers_count":1858,"watchers_count":1858,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":688,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":688,"open_issues":19,"watchers":1858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/6601"},"html":{"href":"https://github.com/flutter/engine/pull/6601"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/6601"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/6601/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/6601/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/6601/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/e81943ab399b1be4c8a0aedd1a417c399766864d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jason-simmons"}}