{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/FACG5/voyage/pulls/20","id":214956542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTU2NTQy","html_url":"https://github.com/FACG5/voyage/pull/20","diff_url":"https://github.com/FACG5/voyage/pull/20.diff","patch_url":"https://github.com/FACG5/voyage/pull/20.patch","issue_url":"https://api.github.com/repos/FACG5/voyage/issues/20","number":20,"state":"closed","locked":false,"title":"sign up front and back relates #3","user":{"login":"ahmad1091","id":38608782,"node_id":"MDQ6VXNlcjM4NjA4Nzgy","avatar_url":"https://avatars0.githubusercontent.com/u/38608782?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmad1091","html_url":"https://github.com/ahmad1091","followers_url":"https://api.github.com/users/ahmad1091/followers","following_url":"https://api.github.com/users/ahmad1091/following{/other_user}","gists_url":"https://api.github.com/users/ahmad1091/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmad1091/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmad1091/subscriptions","organizations_url":"https://api.github.com/users/ahmad1091/orgs","repos_url":"https://api.github.com/users/ahmad1091/repos","events_url":"https://api.github.com/users/ahmad1091/events{/privacy}","received_events_url":"https://api.github.com/users/ahmad1091/received_events","type":"User","site_admin":false},"body":"signup new user which you can signup as a person or business \r\n### backend:\r\nincludes hashing the password and rendering signup.hbs and then adding data to database,\r\nthis process requires 3 queries : \r\n* addUser: which add data to mutual table ' users table'.\r\n* addPerson: which add data to person table.\r\n* addBusiness: which add data to the business table.\r\n### frontend:\r\nincludes:\r\n* dom in signup.js\r\n* validation in validation.js\r\n","created_at":"2018-09-12T13:14:48Z","updated_at":"2018-09-18T08:11:16Z","closed_at":"2018-09-18T08:11:15Z","merged_at":"2018-09-18T08:11:15Z","merge_commit_sha":"fdbc5e1d70e96bcfb00f5e771ae982bf2b846575","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FACG5/voyage/pulls/20/commits","review_comments_url":"https://api.github.com/repos/FACG5/voyage/pulls/20/comments","review_comment_url":"https://api.github.com/repos/FACG5/voyage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FACG5/voyage/issues/20/comments","statuses_url":"https://api.github.com/repos/FACG5/voyage/statuses/2c4f0752a99c36b7d8ed13320a5273667092d930","head":{"label":"FACG5:signup","ref":"signup","sha":"2c4f0752a99c36b7d8ed13320a5273667092d930","user":{"login":"FACG5","id":37267782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjY3Nzgy","avatar_url":"https://avatars2.githubusercontent.com/u/37267782?v=4","gravatar_id":"","url":"https://api.github.com/users/FACG5","html_url":"https://github.com/FACG5","followers_url":"https://api.github.com/users/FACG5/followers","following_url":"https://api.github.com/users/FACG5/following{/other_user}","gists_url":"https://api.github.com/users/FACG5/gists{/gist_id}","starred_url":"https://api.github.com/users/FACG5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FACG5/subscriptions","organizations_url":"https://api.github.com/users/FACG5/orgs","repos_url":"https://api.github.com/users/FACG5/repos","events_url":"https://api.github.com/users/FACG5/events{/privacy}","received_events_url":"https://api.github.com/users/FACG5/received_events","type":"Organization","site_admin":false},"repo":{"id":148000880,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwMDA4ODA=","name":"voyage","full_name":"FACG5/voyage","private":false,"owner":{"login":"FACG5","id":37267782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjY3Nzgy","avatar_url":"https://avatars2.githubusercontent.com/u/37267782?v=4","gravatar_id":"","url":"https://api.github.com/users/FACG5","html_url":"https://github.com/FACG5","followers_url":"https://api.github.com/users/FACG5/followers","following_url":"https://api.github.com/users/FACG5/following{/other_user}","gists_url":"https://api.github.com/users/FACG5/gists{/gist_id}","starred_url":"https://api.github.com/users/FACG5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FACG5/subscriptions","organizations_url":"https://api.github.com/users/FACG5/orgs","repos_url":"https://api.github.com/users/FACG5/repos","events_url":"https://api.github.com/users/FACG5/events{/privacy}","received_events_url":"https://api.github.com/users/FACG5/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FACG5/voyage","description":"App to collect all entertainments places at Gaza ","fork":false,"url":"https://api.github.com/repos/FACG5/voyage","forks_url":"https://api.github.com/repos/FACG5/voyage/forks","keys_url":"https://api.github.com/repos/FACG5/voyage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FACG5/voyage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FACG5/voyage/teams","hooks_url":"https://api.github.com/repos/FACG5/voyage/hooks","issue_events_url":"https://api.github.com/repos/FACG5/voyage/issues/events{/number}","events_url":"https://api.github.com/repos/FACG5/voyage/events","assignees_url":"https://api.github.com/repos/FACG5/voyage/assignees{/user}","branches_url":"https://api.github.com/repos/FACG5/voyage/branches{/branch}","tags_url":"https://api.github.com/repos/FACG5/voyage/tags","blobs_url":"https://api.github.com/repos/FACG5/voyage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FACG5/voyage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FACG5/voyage/git/refs{/sha}","trees_url":"https://api.github.com/repos/FACG5/voyage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FACG5/voyage/statuses/{sha}","languages_url":"https://api.github.com/repos/FACG5/voyage/languages","stargazers_url":"https://api.github.com/repos/FACG5/voyage/stargazers","contributors_url":"https://api.github.com/repos/FACG5/voyage/contributors","subscribers_url":"https://api.github.com/repos/FACG5/voyage/subscribers","subscription_url":"https://api.github.com/repos/FACG5/voyage/subscription","commits_url":"https://api.github.com/repos/FACG5/voyage/commits{/sha}","git_commits_url":"https://api.github.com/repos/FACG5/voyage/git/commits{/sha}","comments_url":"https://api.github.com/repos/FACG5/voyage/comments{/number}","issue_comment_url":"https://api.github.com/repos/FACG5/voyage/issues/comments{/number}","contents_url":"https://api.github.com/repos/FACG5/voyage/contents/{+path}","compare_url":"https://api.github.com/repos/FACG5/voyage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FACG5/voyage/merges","archive_url":"https://api.github.com/repos/FACG5/voyage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FACG5/voyage/downloads","issues_url":"https://api.github.com/repos/FACG5/voyage/issues{/number}","pulls_url":"https://api.github.com/repos/FACG5/voyage/pulls{/number}","milestones_url":"https://api.github.com/repos/FACG5/voyage/milestones{/number}","notifications_url":"https://api.github.com/repos/FACG5/voyage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FACG5/voyage/labels{/name}","releases_url":"https://api.github.com/repos/FACG5/voyage/releases{/id}","deployments_url":"https://api.github.com/repos/FACG5/voyage/deployments","created_at":"2018-09-09T06:56:39Z","updated_at":"2018-09-18T06:41:37Z","pushed_at":"2018-09-18T08:11:16Z","git_url":"git://github.com/FACG5/voyage.git","ssh_url":"git@github.com:FACG5/voyage.git","clone_url":"https://github.com/FACG5/voyage.git","svn_url":"https://github.com/FACG5/voyage","homepage":null,"size":213,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"base":{"label":"FACG5:master","ref":"master","sha":"6ab9decbb7b93cbcbaad7c83b9451fd13aee72b8","user":{"login":"FACG5","id":37267782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjY3Nzgy","avatar_url":"https://avatars2.githubusercontent.com/u/37267782?v=4","gravatar_id":"","url":"https://api.github.com/users/FACG5","html_url":"https://github.com/FACG5","followers_url":"https://api.github.com/users/FACG5/followers","following_url":"https://api.github.com/users/FACG5/following{/other_user}","gists_url":"https://api.github.com/users/FACG5/gists{/gist_id}","starred_url":"https://api.github.com/users/FACG5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FACG5/subscriptions","organizations_url":"https://api.github.com/users/FACG5/orgs","repos_url":"https://api.github.com/users/FACG5/repos","events_url":"https://api.github.com/users/FACG5/events{/privacy}","received_events_url":"https://api.github.com/users/FACG5/received_events","type":"Organization","site_admin":false},"repo":{"id":148000880,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwMDA4ODA=","name":"voyage","full_name":"FACG5/voyage","private":false,"owner":{"login":"FACG5","id":37267782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjY3Nzgy","avatar_url":"https://avatars2.githubusercontent.com/u/37267782?v=4","gravatar_id":"","url":"https://api.github.com/users/FACG5","html_url":"https://github.com/FACG5","followers_url":"https://api.github.com/users/FACG5/followers","following_url":"https://api.github.com/users/FACG5/following{/other_user}","gists_url":"https://api.github.com/users/FACG5/gists{/gist_id}","starred_url":"https://api.github.com/users/FACG5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FACG5/subscriptions","organizations_url":"https://api.github.com/users/FACG5/orgs","repos_url":"https://api.github.com/users/FACG5/repos","events_url":"https://api.github.com/users/FACG5/events{/privacy}","received_events_url":"https://api.github.com/users/FACG5/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FACG5/voyage","description":"App to collect all entertainments places at Gaza ","fork":false,"url":"https://api.github.com/repos/FACG5/voyage","forks_url":"https://api.github.com/repos/FACG5/voyage/forks","keys_url":"https://api.github.com/repos/FACG5/voyage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FACG5/voyage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FACG5/voyage/teams","hooks_url":"https://api.github.com/repos/FACG5/voyage/hooks","issue_events_url":"https://api.github.com/repos/FACG5/voyage/issues/events{/number}","events_url":"https://api.github.com/repos/FACG5/voyage/events","assignees_url":"https://api.github.com/repos/FACG5/voyage/assignees{/user}","branches_url":"https://api.github.com/repos/FACG5/voyage/branches{/branch}","tags_url":"https://api.github.com/repos/FACG5/voyage/tags","blobs_url":"https://api.github.com/repos/FACG5/voyage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FACG5/voyage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FACG5/voyage/git/refs{/sha}","trees_url":"https://api.github.com/repos/FACG5/voyage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FACG5/voyage/statuses/{sha}","languages_url":"https://api.github.com/repos/FACG5/voyage/languages","stargazers_url":"https://api.github.com/repos/FACG5/voyage/stargazers","contributors_url":"https://api.github.com/repos/FACG5/voyage/contributors","subscribers_url":"https://api.github.com/repos/FACG5/voyage/subscribers","subscription_url":"https://api.github.com/repos/FACG5/voyage/subscription","commits_url":"https://api.github.com/repos/FACG5/voyage/commits{/sha}","git_commits_url":"https://api.github.com/repos/FACG5/voyage/git/commits{/sha}","comments_url":"https://api.github.com/repos/FACG5/voyage/comments{/number}","issue_comment_url":"https://api.github.com/repos/FACG5/voyage/issues/comments{/number}","contents_url":"https://api.github.com/repos/FACG5/voyage/contents/{+path}","compare_url":"https://api.github.com/repos/FACG5/voyage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FACG5/voyage/merges","archive_url":"https://api.github.com/repos/FACG5/voyage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FACG5/voyage/downloads","issues_url":"https://api.github.com/repos/FACG5/voyage/issues{/number}","pulls_url":"https://api.github.com/repos/FACG5/voyage/pulls{/number}","milestones_url":"https://api.github.com/repos/FACG5/voyage/milestones{/number}","notifications_url":"https://api.github.com/repos/FACG5/voyage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FACG5/voyage/labels{/name}","releases_url":"https://api.github.com/repos/FACG5/voyage/releases{/id}","deployments_url":"https://api.github.com/repos/FACG5/voyage/deployments","created_at":"2018-09-09T06:56:39Z","updated_at":"2018-09-18T06:41:37Z","pushed_at":"2018-09-18T08:11:16Z","git_url":"git://github.com/FACG5/voyage.git","ssh_url":"git@github.com:FACG5/voyage.git","clone_url":"https://github.com/FACG5/voyage.git","svn_url":"https://github.com/FACG5/voyage","homepage":null,"size":213,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FACG5/voyage/pulls/20"},"html":{"href":"https://github.com/FACG5/voyage/pull/20"},"issue":{"href":"https://api.github.com/repos/FACG5/voyage/issues/20"},"comments":{"href":"https://api.github.com/repos/FACG5/voyage/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/FACG5/voyage/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/FACG5/voyage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FACG5/voyage/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/FACG5/voyage/statuses/2c4f0752a99c36b7d8ed13320a5273667092d930"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"FarahZaqout","id":25854070,"node_id":"MDQ6VXNlcjI1ODU0MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/25854070?v=4","gravatar_id":"","url":"https://api.github.com/users/FarahZaqout","html_url":"https://github.com/FarahZaqout","followers_url":"https://api.github.com/users/FarahZaqout/followers","following_url":"https://api.github.com/users/FarahZaqout/following{/other_user}","gists_url":"https://api.github.com/users/FarahZaqout/gists{/gist_id}","starred_url":"https://api.github.com/users/FarahZaqout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FarahZaqout/subscriptions","organizations_url":"https://api.github.com/users/FarahZaqout/orgs","repos_url":"https://api.github.com/users/FarahZaqout/repos","events_url":"https://api.github.com/users/FarahZaqout/events{/privacy}","received_events_url":"https://api.github.com/users/FarahZaqout/received_events","type":"User","site_admin":false},"comments":1,"review_comments":44,"maintainer_can_modify":false,"commits":12,"additions":422,"deletions":56,"changed_files":16}}
{"actor":{"display_login":"FarahZaqout"}}