{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/comments/174324989","pull_request_review_id":103659832,"id":174324989,"diff_hunk":"@@ -39,9 +39,33 @@ dockerTemplate {\n         }\n       }\n \n+      stage('Test') {\n+\n+        // Spawn the image just created\n+        mavenNode(mavenImage:image) {\n+          container('maven') {\n+            echo 'Container spawned successfully'\n+            sh 'cat /etc/redhat-release'\n+            sh 'hostname'\n+            sh 'java -version'\n+            sh 'mvn -version'\n+            sh 'git --version'\n+\n+            // I've no idea where the canonical source for booster apps are, so\n+            // let's clone a fork instead\n+            sh 'git clone https://github.com/jaseemabid/vertxapp'","path":"Jenkinsfile","position":18,"original_position":18,"commit_id":"9f3c2ad7446e56719cfc101bda51f81f035f7038","original_commit_id":"9f3c2ad7446e56719cfc101bda51f81f035f7038","user":{"login":"sthaha","id":3005132,"avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"body":"can this be a config? also have you considered --shallow ?","created_at":"2018-03-14T00:30:10Z","updated_at":"2018-03-14T00:31:01Z","html_url":"https://github.com/fabric8io-images/maven-builder/pull/37#discussion_r174324989","pull_request_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/comments/174324989"},"html":{"href":"https://github.com/fabric8io-images/maven-builder/pull/37#discussion_r174324989"},"pull_request":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37","id":174281291,"html_url":"https://github.com/fabric8io-images/maven-builder/pull/37","diff_url":"https://github.com/fabric8io-images/maven-builder/pull/37.diff","patch_url":"https://github.com/fabric8io-images/maven-builder/pull/37.patch","issue_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/37","number":37,"state":"open","locked":false,"title":"Basic automated testing for the image with no frills","user":{"login":"jaseemabid","id":601714,"avatar_url":"https://avatars1.githubusercontent.com/u/601714?v=4","gravatar_id":"","url":"https://api.github.com/users/jaseemabid","html_url":"https://github.com/jaseemabid","followers_url":"https://api.github.com/users/jaseemabid/followers","following_url":"https://api.github.com/users/jaseemabid/following{/other_user}","gists_url":"https://api.github.com/users/jaseemabid/gists{/gist_id}","starred_url":"https://api.github.com/users/jaseemabid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaseemabid/subscriptions","organizations_url":"https://api.github.com/users/jaseemabid/orgs","repos_url":"https://api.github.com/users/jaseemabid/repos","events_url":"https://api.github.com/users/jaseemabid/events{/privacy}","received_events_url":"https://api.github.com/users/jaseemabid/received_events","type":"User","site_admin":false},"body":"I think this is best we could do right now. This does some basic sanity testing of the image and should catch 80% of the issues with 20% effort. godog jenkins is not worth cleaning up. Triggering a test Jenkinsfile from somewhere else is going to be more work and this seems like the simplest option I can think of now. \r\n\r\n","created_at":"2018-03-12T06:23:06Z","updated_at":"2018-03-14T00:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4e9eb1591af92fa07091dbc74f6e96d361eb3a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chmouel","id":98980,"avatar_url":"https://avatars2.githubusercontent.com/u/98980?v=4","gravatar_id":"","url":"https://api.github.com/users/chmouel","html_url":"https://github.com/chmouel","followers_url":"https://api.github.com/users/chmouel/followers","following_url":"https://api.github.com/users/chmouel/following{/other_user}","gists_url":"https://api.github.com/users/chmouel/gists{/gist_id}","starred_url":"https://api.github.com/users/chmouel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmouel/subscriptions","organizations_url":"https://api.github.com/users/chmouel/orgs","repos_url":"https://api.github.com/users/chmouel/repos","events_url":"https://api.github.com/users/chmouel/events{/privacy}","received_events_url":"https://api.github.com/users/chmouel/received_events","type":"User","site_admin":false},{"login":"rupalibehera","id":4288561,"avatar_url":"https://avatars3.githubusercontent.com/u/4288561?v=4","gravatar_id":"","url":"https://api.github.com/users/rupalibehera","html_url":"https://github.com/rupalibehera","followers_url":"https://api.github.com/users/rupalibehera/followers","following_url":"https://api.github.com/users/rupalibehera/following{/other_user}","gists_url":"https://api.github.com/users/rupalibehera/gists{/gist_id}","starred_url":"https://api.github.com/users/rupalibehera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rupalibehera/subscriptions","organizations_url":"https://api.github.com/users/rupalibehera/orgs","repos_url":"https://api.github.com/users/rupalibehera/repos","events_url":"https://api.github.com/users/rupalibehera/events{/privacy}","received_events_url":"https://api.github.com/users/rupalibehera/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":864037497,"url":"https://api.github.com/repos/fabric8io-images/maven-builder/labels/DNM","name":"DNM","color":"dd1a04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37/commits","review_comments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37/comments","review_comment_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/37/comments","statuses_url":"https://api.github.com/repos/fabric8io-images/maven-builder/statuses/9f3c2ad7446e56719cfc101bda51f81f035f7038","head":{"label":"fabric8io-images:test","ref":"test","sha":"9f3c2ad7446e56719cfc101bda51f81f035f7038","user":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars2.githubusercontent.com/u/15142647?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"repo":{"id":49163408,"name":"maven-builder","full_name":"fabric8io-images/maven-builder","owner":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars2.githubusercontent.com/u/15142647?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io-images/maven-builder","description":"kubernetes-workflow pod builder image used to run maven builds","fork":false,"url":"https://api.github.com/repos/fabric8io-images/maven-builder","forks_url":"https://api.github.com/repos/fabric8io-images/maven-builder/forks","keys_url":"https://api.github.com/repos/fabric8io-images/maven-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io-images/maven-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io-images/maven-builder/teams","hooks_url":"https://api.github.com/repos/fabric8io-images/maven-builder/hooks","issue_events_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io-images/maven-builder/events","assignees_url":"https://api.github.com/repos/fabric8io-images/maven-builder/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io-images/maven-builder/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io-images/maven-builder/tags","blobs_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io-images/maven-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io-images/maven-builder/languages","stargazers_url":"https://api.github.com/repos/fabric8io-images/maven-builder/stargazers","contributors_url":"https://api.github.com/repos/fabric8io-images/maven-builder/contributors","subscribers_url":"https://api.github.com/repos/fabric8io-images/maven-builder/subscribers","subscription_url":"https://api.github.com/repos/fabric8io-images/maven-builder/subscription","commits_url":"https://api.github.com/repos/fabric8io-images/maven-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io-images/maven-builder/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io-images/maven-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io-images/maven-builder/merges","archive_url":"https://api.github.com/repos/fabric8io-images/maven-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io-images/maven-builder/downloads","issues_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io-images/maven-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io-images/maven-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io-images/maven-builder/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io-images/maven-builder/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/deployments","created_at":"2016-01-06T21:40:08Z","updated_at":"2018-02-24T22:42:52Z","pushed_at":"2018-03-13T09:52:13Z","git_url":"git://github.com/fabric8io-images/maven-builder.git","ssh_url":"git@github.com:fabric8io-images/maven-builder.git","clone_url":"https://github.com/fabric8io-images/maven-builder.git","svn_url":"https://github.com/fabric8io-images/maven-builder","homepage":null,"size":21,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":8,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"fabric8io-images:master","ref":"master","sha":"4eaaafa82e7e0f710927b1031419e64bc00480a5","user":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars2.githubusercontent.com/u/15142647?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"repo":{"id":49163408,"name":"maven-builder","full_name":"fabric8io-images/maven-builder","owner":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars2.githubusercontent.com/u/15142647?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io-images/maven-builder","description":"kubernetes-workflow pod builder image used to run maven builds","fork":false,"url":"https://api.github.com/repos/fabric8io-images/maven-builder","forks_url":"https://api.github.com/repos/fabric8io-images/maven-builder/forks","keys_url":"https://api.github.com/repos/fabric8io-images/maven-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io-images/maven-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io-images/maven-builder/teams","hooks_url":"https://api.github.com/repos/fabric8io-images/maven-builder/hooks","issue_events_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io-images/maven-builder/events","assignees_url":"https://api.github.com/repos/fabric8io-images/maven-builder/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io-images/maven-builder/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io-images/maven-builder/tags","blobs_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io-images/maven-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io-images/maven-builder/languages","stargazers_url":"https://api.github.com/repos/fabric8io-images/maven-builder/stargazers","contributors_url":"https://api.github.com/repos/fabric8io-images/maven-builder/contributors","subscribers_url":"https://api.github.com/repos/fabric8io-images/maven-builder/subscribers","subscription_url":"https://api.github.com/repos/fabric8io-images/maven-builder/subscription","commits_url":"https://api.github.com/repos/fabric8io-images/maven-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io-images/maven-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io-images/maven-builder/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io-images/maven-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io-images/maven-builder/merges","archive_url":"https://api.github.com/repos/fabric8io-images/maven-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io-images/maven-builder/downloads","issues_url":"https://api.github.com/repos/fabric8io-images/maven-builder/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io-images/maven-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io-images/maven-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io-images/maven-builder/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io-images/maven-builder/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io-images/maven-builder/deployments","created_at":"2016-01-06T21:40:08Z","updated_at":"2018-02-24T22:42:52Z","pushed_at":"2018-03-13T09:52:13Z","git_url":"git://github.com/fabric8io-images/maven-builder.git","ssh_url":"git@github.com:fabric8io-images/maven-builder.git","clone_url":"https://github.com/fabric8io-images/maven-builder.git","svn_url":"https://github.com/fabric8io-images/maven-builder","homepage":null,"size":21,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":8,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37"},"html":{"href":"https://github.com/fabric8io-images/maven-builder/pull/37"},"issue":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/37"},"comments":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io-images/maven-builder/statuses/9f3c2ad7446e56719cfc101bda51f81f035f7038"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sthaha"}}