{"action":"created","comment":{"url":"https://api.github.com/repos/shopware/shopware/pulls/comments/172128572","pull_request_review_id":101092192,"id":172128572,"diff_hunk":"@@ -254,7 +254,11 @@ private function validatePluginRequirements($prefix, \\ZipArchive $archive)\n         if ($xml = $archive->getFromName($prefix . '/plugin.xml')) {\n             $tmpFile = $this->downloadDir . '/' . uniqid() . '.xml';\n             file_put_contents($tmpFile, $xml);\n-            $this->requirementsValidator->validate($tmpFile, $this->release->getVersion());\n+            try {\n+                $this->requirementsValidator->validate($tmpFile, $this->release->getVersion());\n+            } finally {\n+                unlink($tmpFile);\n+            }\n             unlink($tmpFile);","path":"engine/Shopware/Bundle/PluginInstallerBundle/Service/PluginExtractor.php","position":null,"original_position":10,"commit_id":"146e83c19a5b34d009adda7b98e33dc9586bac89","original_commit_id":"9b392263981e3fc120a8ecf11adb611e4be94831","user":{"login":"shyim","id":6224096,"avatar_url":"https://avatars1.githubusercontent.com/u/6224096?v=4","gravatar_id":"","url":"https://api.github.com/users/shyim","html_url":"https://github.com/shyim","followers_url":"https://api.github.com/users/shyim/followers","following_url":"https://api.github.com/users/shyim/following{/other_user}","gists_url":"https://api.github.com/users/shyim/gists{/gist_id}","starred_url":"https://api.github.com/users/shyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyim/subscriptions","organizations_url":"https://api.github.com/users/shyim/orgs","repos_url":"https://api.github.com/users/shyim/repos","events_url":"https://api.github.com/users/shyim/events{/privacy}","received_events_url":"https://api.github.com/users/shyim/received_events","type":"User","site_admin":false},"body":"Mähh, i guess finally is only called when a exception is thrown. Its removed thanks :D","created_at":"2018-03-05T09:29:17Z","updated_at":"2018-03-05T09:29:17Z","html_url":"https://github.com/shopware/shopware/pull/1549#discussion_r172128572","pull_request_url":"https://api.github.com/repos/shopware/shopware/pulls/1549","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments/172128572"},"html":{"href":"https://github.com/shopware/shopware/pull/1549#discussion_r172128572"},"pull_request":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1549"}},"in_reply_to_id":172118086},"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1549","id":172037060,"html_url":"https://github.com/shopware/shopware/pull/1549","diff_url":"https://github.com/shopware/shopware/pull/1549.diff","patch_url":"https://github.com/shopware/shopware/pull/1549.patch","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1549","number":1549,"state":"open","locked":false,"title":"Dont allow upload incompatible plugins","user":{"login":"shyim","id":6224096,"avatar_url":"https://avatars1.githubusercontent.com/u/6224096?v=4","gravatar_id":"","url":"https://api.github.com/users/shyim","html_url":"https://github.com/shyim","followers_url":"https://api.github.com/users/shyim/followers","following_url":"https://api.github.com/users/shyim/following{/other_user}","gists_url":"https://api.github.com/users/shyim/gists{/gist_id}","starred_url":"https://api.github.com/users/shyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyim/subscriptions","organizations_url":"https://api.github.com/users/shyim/orgs","repos_url":"https://api.github.com/users/shyim/repos","events_url":"https://api.github.com/users/shyim/events{/privacy}","received_events_url":"https://api.github.com/users/shyim/received_events","type":"User","site_admin":false},"body":"### 1. Why is this change necessary?\r\nIts a earlier requirements check for the shop owner, to not upload incompatible plugins. Also some plugins depends on other plugins and needed installed before otherwise the shop throws a Exception #foundationplugins\r\nThe check in install is also too late, because already the plugin files are replaced. This should solve also the support requests like \"I have installed the 5.4 version of the plugin on a 5.3 shop\"\r\n\r\n### 2. What does this change do, exactly?\r\nCheck for plugin requirements before unzipping the plugin.\r\n\r\nExample screenshot ![Error](https://ipfs.io/ipfs/QmSS8JcRXaf3HA2by3pngFS2jMkYhqgL7gVFSNhpBXLfW1\r\n)\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\nSet a high minVersion in plugin.xml and try to upload it\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [ ] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [X] I have read the contribution requirements and fulfil them.\r\n\r\n200 Pull Requests 🙌 ","created_at":"2018-02-28T18:38:58Z","updated_at":"2018-03-05T09:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ae7e63d78fff19ea80f95a595c661bcdfeb668e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":571966309,"url":"https://api.github.com/repos/shopware/shopware/labels/Incomplete","name":"Incomplete","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/shopware/pulls/1549/commits","review_comments_url":"https://api.github.com/repos/shopware/shopware/pulls/1549/comments","review_comment_url":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1549/comments","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/146e83c19a5b34d009adda7b98e33dc9586bac89","head":{"label":"shyim:check-plugin-requirements","ref":"check-plugin-requirements","sha":"146e83c19a5b34d009adda7b98e33dc9586bac89","user":{"login":"shyim","id":6224096,"avatar_url":"https://avatars1.githubusercontent.com/u/6224096?v=4","gravatar_id":"","url":"https://api.github.com/users/shyim","html_url":"https://github.com/shyim","followers_url":"https://api.github.com/users/shyim/followers","following_url":"https://api.github.com/users/shyim/following{/other_user}","gists_url":"https://api.github.com/users/shyim/gists{/gist_id}","starred_url":"https://api.github.com/users/shyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyim/subscriptions","organizations_url":"https://api.github.com/users/shyim/orgs","repos_url":"https://api.github.com/users/shyim/repos","events_url":"https://api.github.com/users/shyim/events{/privacy}","received_events_url":"https://api.github.com/users/shyim/received_events","type":"User","site_admin":false},"repo":{"id":37932612,"name":"shopware","full_name":"shyim/shopware","owner":{"login":"shyim","id":6224096,"avatar_url":"https://avatars1.githubusercontent.com/u/6224096?v=4","gravatar_id":"","url":"https://api.github.com/users/shyim","html_url":"https://github.com/shyim","followers_url":"https://api.github.com/users/shyim/followers","following_url":"https://api.github.com/users/shyim/following{/other_user}","gists_url":"https://api.github.com/users/shyim/gists{/gist_id}","starred_url":"https://api.github.com/users/shyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyim/subscriptions","organizations_url":"https://api.github.com/users/shyim/orgs","repos_url":"https://api.github.com/users/shyim/repos","events_url":"https://api.github.com/users/shyim/events{/privacy}","received_events_url":"https://api.github.com/users/shyim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shyim/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/shyim/shopware","forks_url":"https://api.github.com/repos/shyim/shopware/forks","keys_url":"https://api.github.com/repos/shyim/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shyim/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shyim/shopware/teams","hooks_url":"https://api.github.com/repos/shyim/shopware/hooks","issue_events_url":"https://api.github.com/repos/shyim/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shyim/shopware/events","assignees_url":"https://api.github.com/repos/shyim/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shyim/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shyim/shopware/tags","blobs_url":"https://api.github.com/repos/shyim/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shyim/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shyim/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shyim/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shyim/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shyim/shopware/languages","stargazers_url":"https://api.github.com/repos/shyim/shopware/stargazers","contributors_url":"https://api.github.com/repos/shyim/shopware/contributors","subscribers_url":"https://api.github.com/repos/shyim/shopware/subscribers","subscription_url":"https://api.github.com/repos/shyim/shopware/subscription","commits_url":"https://api.github.com/repos/shyim/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shyim/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shyim/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shyim/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shyim/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shyim/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shyim/shopware/merges","archive_url":"https://api.github.com/repos/shyim/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shyim/shopware/downloads","issues_url":"https://api.github.com/repos/shyim/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shyim/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shyim/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shyim/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shyim/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shyim/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shyim/shopware/deployments","created_at":"2015-06-23T17:04:49Z","updated_at":"2018-02-01T12:57:32Z","pushed_at":"2018-03-05T09:28:41Z","git_url":"git://github.com/shyim/shopware.git","ssh_url":"git@github.com:shyim/shopware.git","clone_url":"https://github.com/shyim/shopware.git","svn_url":"https://github.com/shyim/shopware","homepage":"http://www.shopware.com","size":191502,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1,"open_issues":3,"watchers":0,"default_branch":"5.0"}},"base":{"label":"shopware:5.5","ref":"5.5","sha":"11926c41d04f24c0b7b64323aa401bcdf8136925","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":5682970,"name":"shopware","full_name":"shopware/shopware","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/shopware","description":"Shopware Repository","fork":false,"url":"https://api.github.com/repos/shopware/shopware","forks_url":"https://api.github.com/repos/shopware/shopware/forks","keys_url":"https://api.github.com/repos/shopware/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/shopware/teams","hooks_url":"https://api.github.com/repos/shopware/shopware/hooks","issue_events_url":"https://api.github.com/repos/shopware/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/shopware/events","assignees_url":"https://api.github.com/repos/shopware/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/shopware/tags","blobs_url":"https://api.github.com/repos/shopware/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/shopware/languages","stargazers_url":"https://api.github.com/repos/shopware/shopware/stargazers","contributors_url":"https://api.github.com/repos/shopware/shopware/contributors","subscribers_url":"https://api.github.com/repos/shopware/shopware/subscribers","subscription_url":"https://api.github.com/repos/shopware/shopware/subscription","commits_url":"https://api.github.com/repos/shopware/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/shopware/merges","archive_url":"https://api.github.com/repos/shopware/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/shopware/downloads","issues_url":"https://api.github.com/repos/shopware/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopware/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/shopware/deployments","created_at":"2012-09-05T05:32:50Z","updated_at":"2018-03-05T08:15:47Z","pushed_at":"2018-03-05T09:28:42Z","git_url":"git://github.com/shopware/shopware.git","ssh_url":"git@github.com:shopware/shopware.git","clone_url":"https://github.com/shopware/shopware.git","svn_url":"https://github.com/shopware/shopware","homepage":"http://www.shopware.com","size":202745,"stargazers_count":809,"watchers_count":809,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":577,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":577,"open_issues":167,"watchers":809,"default_branch":"5.4"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1549"},"html":{"href":"https://github.com/shopware/shopware/pull/1549"},"issue":{"href":"https://api.github.com/repos/shopware/shopware/issues/1549"},"comments":{"href":"https://api.github.com/repos/shopware/shopware/issues/1549/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1549/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1549/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/shopware/statuses/146e83c19a5b34d009adda7b98e33dc9586bac89"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shyim"}}