{"action":"created","comment":{"url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/comments/199397772","pull_request_review_id":133507472,"id":199397772,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTM5Nzc3Mg==","diff_hunk":"@@ -97,20 +97,9 @@ else()\n   message(STATUS \"Using eigen_catkin's Eigen in ${EIGEN_CATKIN_EIGEN_INCLUDE}\")\n endif()\n \n-cs_add_library(${PROJECT_NAME} src/dependency_tracker.cc)\n-\n-if(NOT USE_SYSTEM_EIGEN)\n-  add_dependencies(${PROJECT_NAME} eigen_src)\n-endif()\n-\n-cs_install()\n-\n if(NOT USE_SYSTEM_EIGEN)\n   install(DIRECTORY ${EIGEN_CATKIN_EIGEN_INCLUDE}\n     DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION}","path":"CMakeLists.txt","position":14,"original_position":14,"commit_id":"15a98fc21ee078c9aa312337fe1bbd94679f8b3e","original_commit_id":"15a98fc21ee078c9aa312337fe1bbd94679f8b3e","user":{"login":"eggerk","id":4958205,"node_id":"MDQ6VXNlcjQ5NTgyMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4958205?v=4","gravatar_id":"","url":"https://api.github.com/users/eggerk","html_url":"https://github.com/eggerk","followers_url":"https://api.github.com/users/eggerk/followers","following_url":"https://api.github.com/users/eggerk/following{/other_user}","gists_url":"https://api.github.com/users/eggerk/gists{/gist_id}","starred_url":"https://api.github.com/users/eggerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggerk/subscriptions","organizations_url":"https://api.github.com/users/eggerk/orgs","repos_url":"https://api.github.com/users/eggerk/repos","events_url":"https://api.github.com/users/eggerk/events{/privacy}","received_events_url":"https://api.github.com/users/eggerk/received_events","type":"User","site_admin":false},"body":"You're right, it currently doesn't work in both cases. I tested it in a VM with your test package. Using the system eigen variant is fine and gives the following output:\r\n```\r\neigen_catkin is using Eigen in '/usr/include/eigen3'.\r\nThe version there is 3.2.92.\r\n```\r\n\r\nHowever, creating a package with a downloaded eigen version will make your test package fail to compile as the eigen include dir isn't set correctly.","created_at":"2018-07-02T06:48:29Z","updated_at":"2018-07-02T06:48:29Z","html_url":"https://github.com/ethz-asl/eigen_catkin/pull/25#discussion_r199397772","pull_request_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/comments/199397772"},"html":{"href":"https://github.com/ethz-asl/eigen_catkin/pull/25#discussion_r199397772"},"pull_request":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25"}},"in_reply_to_id":199316965},"pull_request":{"url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25","id":198333847,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzMzODQ3","html_url":"https://github.com/ethz-asl/eigen_catkin/pull/25","diff_url":"https://github.com/ethz-asl/eigen_catkin/pull/25.diff","patch_url":"https://github.com/ethz-asl/eigen_catkin/pull/25.patch","issue_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/25","number":25,"state":"open","locked":false,"title":"Wip: Added support for catkin install","user":{"login":"eggerk","id":4958205,"node_id":"MDQ6VXNlcjQ5NTgyMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4958205?v=4","gravatar_id":"","url":"https://api.github.com/users/eggerk","html_url":"https://github.com/eggerk","followers_url":"https://api.github.com/users/eggerk/followers","following_url":"https://api.github.com/users/eggerk/following{/other_user}","gists_url":"https://api.github.com/users/eggerk/gists{/gist_id}","starred_url":"https://api.github.com/users/eggerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggerk/subscriptions","organizations_url":"https://api.github.com/users/eggerk/orgs","repos_url":"https://api.github.com/users/eggerk/repos","events_url":"https://api.github.com/users/eggerk/events{/privacy}","received_events_url":"https://api.github.com/users/eggerk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-29T14:27:26Z","updated_at":"2018-07-02T06:48:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c84ea3084917d74e36a710db2f2d3988fc46bf0d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/25/comments","statuses_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/statuses/15a98fc21ee078c9aa312337fe1bbd94679f8b3e","head":{"label":"ethz-asl:feature/install","ref":"feature/install","sha":"15a98fc21ee078c9aa312337fe1bbd94679f8b3e","user":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":19570869,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3MDg2OQ==","name":"eigen_catkin","full_name":"ethz-asl/eigen_catkin","owner":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/eigen_catkin","description":"Eigen convenience for catkin","fork":false,"url":"https://api.github.com/repos/ethz-asl/eigen_catkin","forks_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/forks","keys_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/teams","hooks_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/events","assignees_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/tags","blobs_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/subscription","commits_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/merges","archive_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/downloads","issues_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/deployments","created_at":"2014-05-08T11:21:54Z","updated_at":"2018-06-20T14:21:00Z","pushed_at":"2018-06-29T14:27:27Z","git_url":"git://github.com/ethz-asl/eigen_catkin.git","ssh_url":"git@github.com:ethz-asl/eigen_catkin.git","clone_url":"https://github.com/ethz-asl/eigen_catkin.git","svn_url":"https://github.com/ethz-asl/eigen_catkin","homepage":null,"size":25,"stargazers_count":4,"watchers_count":4,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":24,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"d0e4a65fdefa955e61691707ec7059d23b40cfa8","user":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":19570869,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3MDg2OQ==","name":"eigen_catkin","full_name":"ethz-asl/eigen_catkin","owner":{"login":"ethz-asl","id":475362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/eigen_catkin","description":"Eigen convenience for catkin","fork":false,"url":"https://api.github.com/repos/ethz-asl/eigen_catkin","forks_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/forks","keys_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/teams","hooks_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/events","assignees_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/tags","blobs_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/subscription","commits_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/merges","archive_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/downloads","issues_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/eigen_catkin/deployments","created_at":"2014-05-08T11:21:54Z","updated_at":"2018-06-20T14:21:00Z","pushed_at":"2018-06-29T14:27:27Z","git_url":"git://github.com/ethz-asl/eigen_catkin.git","ssh_url":"git@github.com:ethz-asl/eigen_catkin.git","clone_url":"https://github.com/ethz-asl/eigen_catkin.git","svn_url":"https://github.com/ethz-asl/eigen_catkin","homepage":null,"size":25,"stargazers_count":4,"watchers_count":4,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":24,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25"},"html":{"href":"https://github.com/ethz-asl/eigen_catkin/pull/25"},"issue":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/25"},"comments":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/eigen_catkin/statuses/15a98fc21ee078c9aa312337fe1bbd94679f8b3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eggerk"}}