{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/18","id":203319980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzE5OTgw","html_url":"https://github.com/unicode-org/icu/pull/18","diff_url":"https://github.com/unicode-org/icu/pull/18.diff","patch_url":"https://github.com/unicode-org/icu/pull/18.patch","issue_url":"https://api.github.com/repos/unicode-org/icu/issues/18","number":18,"state":"closed","locked":false,"title":"ICU-20043 ICU-13214 ICU-13764 MSVC W3 and W4 warning cleanup","user":{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false},"body":"These changes remove all of the MSVC W3 warnings and most of the W4 warnings in the common and i18n projects.","created_at":"2018-07-23T19:30:58Z","updated_at":"2018-08-10T23:48:39Z","closed_at":"2018-08-10T23:48:39Z","merged_at":"2018-08-10T23:48:39Z","merge_commit_sha":"5bca8f158eaf83cf865d2d5c3a4f974d97815950","assignee":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"assignees":[{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"markusicu","id":12720407,"node_id":"MDQ6VXNlcjEyNzIwNDA3","avatar_url":"https://avatars2.githubusercontent.com/u/12720407?v=4","gravatar_id":"","url":"https://api.github.com/users/markusicu","html_url":"https://github.com/markusicu","followers_url":"https://api.github.com/users/markusicu/followers","following_url":"https://api.github.com/users/markusicu/following{/other_user}","gists_url":"https://api.github.com/users/markusicu/gists{/gist_id}","starred_url":"https://api.github.com/users/markusicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusicu/subscriptions","organizations_url":"https://api.github.com/users/markusicu/orgs","repos_url":"https://api.github.com/users/markusicu/repos","events_url":"https://api.github.com/users/markusicu/events{/privacy}","received_events_url":"https://api.github.com/users/markusicu/received_events","type":"User","site_admin":false},{"login":"aheninger","id":22674053,"node_id":"MDQ6VXNlcjIyNjc0MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/22674053?v=4","gravatar_id":"","url":"https://api.github.com/users/aheninger","html_url":"https://github.com/aheninger","followers_url":"https://api.github.com/users/aheninger/followers","following_url":"https://api.github.com/users/aheninger/following{/other_user}","gists_url":"https://api.github.com/users/aheninger/gists{/gist_id}","starred_url":"https://api.github.com/users/aheninger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheninger/subscriptions","organizations_url":"https://api.github.com/users/aheninger/orgs","repos_url":"https://api.github.com/users/aheninger/repos","events_url":"https://api.github.com/users/aheninger/events{/privacy}","received_events_url":"https://api.github.com/users/aheninger/received_events","type":"User","site_admin":false},{"login":"axelandrejs","id":36940647,"node_id":"MDQ6VXNlcjM2OTQwNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/36940647?v=4","gravatar_id":"","url":"https://api.github.com/users/axelandrejs","html_url":"https://github.com/axelandrejs","followers_url":"https://api.github.com/users/axelandrejs/followers","following_url":"https://api.github.com/users/axelandrejs/following{/other_user}","gists_url":"https://api.github.com/users/axelandrejs/gists{/gist_id}","starred_url":"https://api.github.com/users/axelandrejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelandrejs/subscriptions","organizations_url":"https://api.github.com/users/axelandrejs/orgs","repos_url":"https://api.github.com/users/axelandrejs/repos","events_url":"https://api.github.com/users/axelandrejs/events{/privacy}","received_events_url":"https://api.github.com/users/axelandrejs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicode-org/icu/pulls/18/commits","review_comments_url":"https://api.github.com/repos/unicode-org/icu/pulls/18/comments","review_comment_url":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicode-org/icu/issues/18/comments","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/3e6937f82e5606f6f465879b524fec58785184f0","head":{"label":"daniel-ju:master","ref":"master","sha":"3e6937f82e5606f6f465879b524fec58785184f0","user":{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false},"repo":{"id":141208414,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDg0MTQ=","name":"icu","full_name":"daniel-ju/icu","owner":{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-ju/icu","description":":construction: WIP new home of ICU :construction: -:warning: WARNING: The repo will be rebased in the future!","fork":true,"url":"https://api.github.com/repos/daniel-ju/icu","forks_url":"https://api.github.com/repos/daniel-ju/icu/forks","keys_url":"https://api.github.com/repos/daniel-ju/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-ju/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-ju/icu/teams","hooks_url":"https://api.github.com/repos/daniel-ju/icu/hooks","issue_events_url":"https://api.github.com/repos/daniel-ju/icu/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-ju/icu/events","assignees_url":"https://api.github.com/repos/daniel-ju/icu/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-ju/icu/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-ju/icu/tags","blobs_url":"https://api.github.com/repos/daniel-ju/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-ju/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-ju/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-ju/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-ju/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-ju/icu/languages","stargazers_url":"https://api.github.com/repos/daniel-ju/icu/stargazers","contributors_url":"https://api.github.com/repos/daniel-ju/icu/contributors","subscribers_url":"https://api.github.com/repos/daniel-ju/icu/subscribers","subscription_url":"https://api.github.com/repos/daniel-ju/icu/subscription","commits_url":"https://api.github.com/repos/daniel-ju/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-ju/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-ju/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-ju/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-ju/icu/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-ju/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-ju/icu/merges","archive_url":"https://api.github.com/repos/daniel-ju/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-ju/icu/downloads","issues_url":"https://api.github.com/repos/daniel-ju/icu/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-ju/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-ju/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-ju/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-ju/icu/labels{/name}","releases_url":"https://api.github.com/repos/daniel-ju/icu/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-ju/icu/deployments","created_at":"2018-07-17T00:12:01Z","updated_at":"2018-08-10T17:11:57Z","pushed_at":"2018-08-10T17:11:55Z","git_url":"git://github.com/daniel-ju/icu.git","ssh_url":"git@github.com:daniel-ju/icu.git","clone_url":"https://github.com/daniel-ju/icu.git","svn_url":"https://github.com/daniel-ju/icu","homepage":"http://icu-project.org","size":225772,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unicode-org:master","ref":"master","sha":"e878d9d81409896952b45f77ce7815921d779ac5","user":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"repo":{"id":49244766,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI0NDc2Ng==","name":"icu","full_name":"unicode-org/icu","owner":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicode-org/icu","description":"The new home of the ICU project source code.","fork":false,"url":"https://api.github.com/repos/unicode-org/icu","forks_url":"https://api.github.com/repos/unicode-org/icu/forks","keys_url":"https://api.github.com/repos/unicode-org/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicode-org/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicode-org/icu/teams","hooks_url":"https://api.github.com/repos/unicode-org/icu/hooks","issue_events_url":"https://api.github.com/repos/unicode-org/icu/issues/events{/number}","events_url":"https://api.github.com/repos/unicode-org/icu/events","assignees_url":"https://api.github.com/repos/unicode-org/icu/assignees{/user}","branches_url":"https://api.github.com/repos/unicode-org/icu/branches{/branch}","tags_url":"https://api.github.com/repos/unicode-org/icu/tags","blobs_url":"https://api.github.com/repos/unicode-org/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicode-org/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicode-org/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicode-org/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/unicode-org/icu/languages","stargazers_url":"https://api.github.com/repos/unicode-org/icu/stargazers","contributors_url":"https://api.github.com/repos/unicode-org/icu/contributors","subscribers_url":"https://api.github.com/repos/unicode-org/icu/subscribers","subscription_url":"https://api.github.com/repos/unicode-org/icu/subscription","commits_url":"https://api.github.com/repos/unicode-org/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicode-org/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicode-org/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicode-org/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicode-org/icu/contents/{+path}","compare_url":"https://api.github.com/repos/unicode-org/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicode-org/icu/merges","archive_url":"https://api.github.com/repos/unicode-org/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicode-org/icu/downloads","issues_url":"https://api.github.com/repos/unicode-org/icu/issues{/number}","pulls_url":"https://api.github.com/repos/unicode-org/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/unicode-org/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/unicode-org/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicode-org/icu/labels{/name}","releases_url":"https://api.github.com/repos/unicode-org/icu/releases{/id}","deployments_url":"https://api.github.com/repos/unicode-org/icu/deployments","created_at":"2016-01-08T02:42:32Z","updated_at":"2018-08-10T16:32:49Z","pushed_at":"2018-08-10T23:48:39Z","git_url":"git://github.com/unicode-org/icu.git","ssh_url":"git@github.com:unicode-org/icu.git","clone_url":"https://github.com/unicode-org/icu.git","svn_url":"https://github.com/unicode-org/icu","homepage":"http://icu-project.org","size":238546,"stargazers_count":110,"watchers_count":110,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":41,"open_issues":11,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/18"},"html":{"href":"https://github.com/unicode-org/icu/pull/18"},"issue":{"href":"https://api.github.com/repos/unicode-org/icu/issues/18"},"comments":{"href":"https://api.github.com/repos/unicode-org/icu/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/unicode-org/icu/statuses/3e6937f82e5606f6f465879b524fec58785184f0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false},"comments":22,"review_comments":23,"maintainer_can_modify":false,"commits":16,"additions":548,"deletions":553,"changed_files":93}}
{"actor":{"display_login":"daniel-ju"}}