{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/boost/pulls/comments/241016385","pull_request_review_id":184180210,"id":241016385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAxNjM4NQ==","diff_hunk":"@@ -0,0 +1,99 @@\n+/*******************************************************************************\n+ * Copyright (c) 2018 IBM Corporation and others.\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ *\n+ * Contributors:\n+ *     IBM Corporation - initial API and implementation\n+ *******************************************************************************/\n+package io.openliberty.boost.common.config;\n+\n+import io.openliberty.boost.common.config.BoosterPackConfigurator;\n+\n+import static io.openliberty.boost.common.config.ConfigConstants.*;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import org.w3c.dom.Document;\n+import org.w3c.dom.Element;\n+import org.w3c.dom.NodeList;\n+\n+public class JDBCBoosterPackConfigurator extends BoosterPackConfigurator {\n+    \n+\t/**\n+     * The artifactId of the dependency for this booster that needs to be copied to the server\n+     */\n+    private final String DEPENDENCY_ARTIFACT = \"org.apache.derby:derby:10.14.2.0\";\n+\n+    String libertyFeature = null;\n+\n+    /**\n+     * retrieves the default boost feature string for the jdbc dependency\n+     */\n+    public String getFeature() {\n+        return libertyFeature;\n+    }\n+\n+    /**\n+     * writes out jdbc default config data when selected by the presence of a jdbc\n+     * boost dependency\n+     */\n+    public void addServerConfig(Document doc) {\n+\n+    \tElement serverRoot = doc.getDocumentElement();\n+    \t\n+        // Find the root server element\n+        NodeList list = doc.getChildNodes();\n+        for (int i = 0; i < list.getLength(); i++) {\n+            if (list.item(i).getNodeName().equals(\"server\")) {\n+                serverRoot = (Element) list.item(i);\n+            }\n+        }\n+     \n+    \t// Add library\n+    \tElement lib = doc.createElement(LIBRARY);\n+    \tlib.setAttribute(\"id\", \"DerbyLib\");\n+        Element fileLoc = doc.createElement(FILESET);\n+        fileLoc.setAttribute(\"dir\", \"resources\");\n+        fileLoc.setAttribute(\"includes\", \"derby*.jar\");\n+        lib.appendChild(fileLoc);\n+        serverRoot.appendChild(lib);\n+        \n+        // Add datasource\n+        Element dataSource = doc.createElement(DATASOURCE);    \t\n+        dataSource.setAttribute(\"id\", \"DefaultDataSource\");","path":"boost-common/src/main/java/io/openliberty/boost/common/config/JDBCBoosterPackConfigurator.java","position":67,"original_position":67,"commit_id":"08cb3ad99683cedba1071a05568aa668e3525b1e","original_commit_id":"08cb3ad99683cedba1071a05568aa668e3525b1e","user":{"login":"awisniew90","id":20706237,"node_id":"MDQ6VXNlcjIwNzA2MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/20706237?v=4","gravatar_id":"","url":"https://api.github.com/users/awisniew90","html_url":"https://github.com/awisniew90","followers_url":"https://api.github.com/users/awisniew90/followers","following_url":"https://api.github.com/users/awisniew90/following{/other_user}","gists_url":"https://api.github.com/users/awisniew90/gists{/gist_id}","starred_url":"https://api.github.com/users/awisniew90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awisniew90/subscriptions","organizations_url":"https://api.github.com/users/awisniew90/orgs","repos_url":"https://api.github.com/users/awisniew90/repos","events_url":"https://api.github.com/users/awisniew90/events{/privacy}","received_events_url":"https://api.github.com/users/awisniew90/received_events","type":"User","site_admin":false},"body":"Will address this in the next item. ","created_at":"2018-12-12T13:38:40Z","updated_at":"2018-12-12T13:38:40Z","html_url":"https://github.com/OpenLiberty/boost/pull/218#discussion_r241016385","pull_request_url":"https://api.github.com/repos/OpenLiberty/boost/pulls/218","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/comments/241016385"},"html":{"href":"https://github.com/OpenLiberty/boost/pull/218#discussion_r241016385"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/218"}},"in_reply_to_id":240796634},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/boost/pulls/218","id":234424861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDI0ODYx","html_url":"https://github.com/OpenLiberty/boost/pull/218","diff_url":"https://github.com/OpenLiberty/boost/pull/218.diff","patch_url":"https://github.com/OpenLiberty/boost/pull/218.patch","issue_url":"https://api.github.com/repos/OpenLiberty/boost/issues/218","number":218,"state":"open","locked":false,"title":"Add JDBC booster and refactor booster configuration","user":{"login":"awisniew90","id":20706237,"node_id":"MDQ6VXNlcjIwNzA2MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/20706237?v=4","gravatar_id":"","url":"https://api.github.com/users/awisniew90","html_url":"https://github.com/awisniew90","followers_url":"https://api.github.com/users/awisniew90/followers","following_url":"https://api.github.com/users/awisniew90/following{/other_user}","gists_url":"https://api.github.com/users/awisniew90/gists{/gist_id}","starred_url":"https://api.github.com/users/awisniew90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awisniew90/subscriptions","organizations_url":"https://api.github.com/users/awisniew90/orgs","repos_url":"https://api.github.com/users/awisniew90/repos","events_url":"https://api.github.com/users/awisniew90/events{/privacy}","received_events_url":"https://api.github.com/users/awisniew90/received_events","type":"User","site_admin":false},"body":"1. Refactored Booster logic to common\r\n2. Added booster dependency copy functionality\r\n3. Added JDBC booster with Derby dataSource\r\n4. Added JDBC booster test","created_at":"2018-11-28T21:09:49Z","updated_at":"2018-12-12T13:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c9af1a97c7133cac4f60a07bda4733443252adb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chyt","id":3202957,"node_id":"MDQ6VXNlcjMyMDI5NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3202957?v=4","gravatar_id":"","url":"https://api.github.com/users/chyt","html_url":"https://github.com/chyt","followers_url":"https://api.github.com/users/chyt/followers","following_url":"https://api.github.com/users/chyt/following{/other_user}","gists_url":"https://api.github.com/users/chyt/gists{/gist_id}","starred_url":"https://api.github.com/users/chyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chyt/subscriptions","organizations_url":"https://api.github.com/users/chyt/orgs","repos_url":"https://api.github.com/users/chyt/repos","events_url":"https://api.github.com/users/chyt/events{/privacy}","received_events_url":"https://api.github.com/users/chyt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/boost/pulls/218/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/boost/pulls/218/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/boost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/boost/issues/218/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/boost/statuses/08cb3ad99683cedba1071a05568aa668e3525b1e","head":{"label":"awisniew90:jdbcBooster","ref":"jdbcBooster","sha":"08cb3ad99683cedba1071a05568aa668e3525b1e","user":{"login":"awisniew90","id":20706237,"node_id":"MDQ6VXNlcjIwNzA2MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/20706237?v=4","gravatar_id":"","url":"https://api.github.com/users/awisniew90","html_url":"https://github.com/awisniew90","followers_url":"https://api.github.com/users/awisniew90/followers","following_url":"https://api.github.com/users/awisniew90/following{/other_user}","gists_url":"https://api.github.com/users/awisniew90/gists{/gist_id}","starred_url":"https://api.github.com/users/awisniew90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awisniew90/subscriptions","organizations_url":"https://api.github.com/users/awisniew90/orgs","repos_url":"https://api.github.com/users/awisniew90/repos","events_url":"https://api.github.com/users/awisniew90/events{/privacy}","received_events_url":"https://api.github.com/users/awisniew90/received_events","type":"User","site_admin":false},"repo":{"id":141443240,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NDMyNDA=","name":"boost","full_name":"awisniew90/boost","private":false,"owner":{"login":"awisniew90","id":20706237,"node_id":"MDQ6VXNlcjIwNzA2MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/20706237?v=4","gravatar_id":"","url":"https://api.github.com/users/awisniew90","html_url":"https://github.com/awisniew90","followers_url":"https://api.github.com/users/awisniew90/followers","following_url":"https://api.github.com/users/awisniew90/following{/other_user}","gists_url":"https://api.github.com/users/awisniew90/gists{/gist_id}","starred_url":"https://api.github.com/users/awisniew90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awisniew90/subscriptions","organizations_url":"https://api.github.com/users/awisniew90/orgs","repos_url":"https://api.github.com/users/awisniew90/repos","events_url":"https://api.github.com/users/awisniew90/events{/privacy}","received_events_url":"https://api.github.com/users/awisniew90/received_events","type":"User","site_admin":false},"html_url":"https://github.com/awisniew90/boost","description":"Liberty Boost","fork":true,"url":"https://api.github.com/repos/awisniew90/boost","forks_url":"https://api.github.com/repos/awisniew90/boost/forks","keys_url":"https://api.github.com/repos/awisniew90/boost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awisniew90/boost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awisniew90/boost/teams","hooks_url":"https://api.github.com/repos/awisniew90/boost/hooks","issue_events_url":"https://api.github.com/repos/awisniew90/boost/issues/events{/number}","events_url":"https://api.github.com/repos/awisniew90/boost/events","assignees_url":"https://api.github.com/repos/awisniew90/boost/assignees{/user}","branches_url":"https://api.github.com/repos/awisniew90/boost/branches{/branch}","tags_url":"https://api.github.com/repos/awisniew90/boost/tags","blobs_url":"https://api.github.com/repos/awisniew90/boost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awisniew90/boost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awisniew90/boost/git/refs{/sha}","trees_url":"https://api.github.com/repos/awisniew90/boost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awisniew90/boost/statuses/{sha}","languages_url":"https://api.github.com/repos/awisniew90/boost/languages","stargazers_url":"https://api.github.com/repos/awisniew90/boost/stargazers","contributors_url":"https://api.github.com/repos/awisniew90/boost/contributors","subscribers_url":"https://api.github.com/repos/awisniew90/boost/subscribers","subscription_url":"https://api.github.com/repos/awisniew90/boost/subscription","commits_url":"https://api.github.com/repos/awisniew90/boost/commits{/sha}","git_commits_url":"https://api.github.com/repos/awisniew90/boost/git/commits{/sha}","comments_url":"https://api.github.com/repos/awisniew90/boost/comments{/number}","issue_comment_url":"https://api.github.com/repos/awisniew90/boost/issues/comments{/number}","contents_url":"https://api.github.com/repos/awisniew90/boost/contents/{+path}","compare_url":"https://api.github.com/repos/awisniew90/boost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awisniew90/boost/merges","archive_url":"https://api.github.com/repos/awisniew90/boost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awisniew90/boost/downloads","issues_url":"https://api.github.com/repos/awisniew90/boost/issues{/number}","pulls_url":"https://api.github.com/repos/awisniew90/boost/pulls{/number}","milestones_url":"https://api.github.com/repos/awisniew90/boost/milestones{/number}","notifications_url":"https://api.github.com/repos/awisniew90/boost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awisniew90/boost/labels{/name}","releases_url":"https://api.github.com/repos/awisniew90/boost/releases{/id}","deployments_url":"https://api.github.com/repos/awisniew90/boost/deployments","created_at":"2018-07-18T14:06:26Z","updated_at":"2018-10-29T17:37:05Z","pushed_at":"2018-12-11T20:09:06Z","git_url":"git://github.com/awisniew90/boost.git","ssh_url":"git@github.com:awisniew90/boost.git","clone_url":"https://github.com/awisniew90/boost.git","svn_url":"https://github.com/awisniew90/boost","homepage":null,"size":672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenLiberty:master","ref":"master","sha":"a722674ada9c249a203232dcdfb2ba8370fa2ff8","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":140440583,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0NDA1ODM=","name":"boost","full_name":"OpenLiberty/boost","private":false,"owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenLiberty/boost","description":"Liberty Boost plugins for Maven and Gradle","fork":false,"url":"https://api.github.com/repos/OpenLiberty/boost","forks_url":"https://api.github.com/repos/OpenLiberty/boost/forks","keys_url":"https://api.github.com/repos/OpenLiberty/boost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/boost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/boost/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/boost/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/boost/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/boost/events","assignees_url":"https://api.github.com/repos/OpenLiberty/boost/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/boost/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/boost/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/boost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/boost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/boost/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/boost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/boost/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/boost/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/boost/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/boost/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/boost/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/boost/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/boost/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/boost/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/boost/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/boost/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/boost/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/boost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/boost/merges","archive_url":"https://api.github.com/repos/OpenLiberty/boost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/boost/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/boost/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/boost/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/boost/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/boost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/boost/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/boost/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/boost/deployments","created_at":"2018-07-10T14:00:03Z","updated_at":"2018-12-11T11:01:28Z","pushed_at":"2018-12-11T20:09:07Z","git_url":"git://github.com/OpenLiberty/boost.git","ssh_url":"git@github.com:OpenLiberty/boost.git","clone_url":"https://github.com/OpenLiberty/boost.git","svn_url":"https://github.com/OpenLiberty/boost","homepage":"","size":668,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":10,"open_issues":54,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/218"},"html":{"href":"https://github.com/OpenLiberty/boost/pull/218"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/boost/issues/218"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/boost/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/boost/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/boost/statuses/08cb3ad99683cedba1071a05568aa668e3525b1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"awisniew90"}}