{"action":"opened","issue":{"url":"https://api.github.com/repos/nosinha/pwp-capstones/issues/1","repository_url":"https://api.github.com/repos/nosinha/pwp-capstones","labels_url":"https://api.github.com/repos/nosinha/pwp-capstones/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/nosinha/pwp-capstones/issues/1/comments","events_url":"https://api.github.com/repos/nosinha/pwp-capstones/issues/1/events","html_url":"https://github.com/nosinha/pwp-capstones/issues/1","id":387840946,"node_id":"MDU6SXNzdWUzODc4NDA5NDY=","number":1,"title":"Murder Mystery Review","user":{"login":"franfranfranfran","id":17259515,"node_id":"MDQ6VXNlcjE3MjU5NTE1","avatar_url":"https://avatars3.githubusercontent.com/u/17259515?v=4","gravatar_id":"","url":"https://api.github.com/users/franfranfranfran","html_url":"https://github.com/franfranfranfran","followers_url":"https://api.github.com/users/franfranfranfran/followers","following_url":"https://api.github.com/users/franfranfranfran/following{/other_user}","gists_url":"https://api.github.com/users/franfranfranfran/gists{/gist_id}","starred_url":"https://api.github.com/users/franfranfranfran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franfranfranfran/subscriptions","organizations_url":"https://api.github.com/users/franfranfranfran/orgs","repos_url":"https://api.github.com/users/franfranfranfran/repos","events_url":"https://api.github.com/users/franfranfranfran/events{/privacy}","received_events_url":"https://api.github.com/users/franfranfranfran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-05T16:33:11Z","updated_at":"2018-12-05T16:33:11Z","closed_at":null,"author_association":"NONE","body":"## Rubric Score\r\n \r\n### Criteria 1: Valid Python Code\r\n* _Score Level:_ 4\r\n* _Comment(s):_ Code included runs without any errors!\r\n \r\n### Criteria 2: Implementation of Project Requirements\r\n* _Score Level:_ 4\r\n* _Comment(s):_ Code produces the suite of functions and classes required of it and calls them in an appropriate order.\r\n \r\n### Criteria 3: Software Architecture\r\n* _Score Level:_ 3\r\n* _Comment(s):_ Great job creating the separate functions and classes necessary to do the analysis for this project. One area to take a look at for improvement is the find_text_similiarity function. According to the instructions, this function should take two TextSamples as input, instead of two bits of raw text. With TextSamples as inputs, you don’t have to reconstruct frequency tables and prepare the text all over again - all of that is already done when you create a TextSample from some raw text. \r\n \r\n### Criteria 4: Uses Python Language Features\r\n* _Score Level:_ 3\r\n* _Comment(s):_ Nice use of various built-in python methods like split, replace and others throughout your program. In the get_average_sentence_length function, instead of using a second for loop, try making use of the [sum](https://www.programiz.com/python-programming/methods/built-in/sum) method to add it all up for you in one line!\r\nAlso, no need to use the keys method in places like the for loops of the frequency_comparison function. Using - for key in table1 - will work how you expect it to.\r\nNot necessarily a 'language feature' but perhaps a way to clean up your code a bit - consider restructuring your if else chunk in this function as well. Can you avoid checking the same conditions twice? It could also be helpful to create a couple local variables here to hold the table1 and table2 values associated with key, so that you don't have to repeatedly access them.\r\n\r\n### Criteria 5: Produces Accurate Output\r\n* _Score Level:_ 3\r\n* _Comment(s):_ Great formatted output and the overall result seems to be correct! However, the actual result data is a teeny tiny bit off. Double check your frequency_comparison function. What happens if table1[key] == table2[key]? As you think about how to restructure this if else block, make sure to include this case. \r\n \r\n### Overall Score: 17/20\r\nGreat work on this project! With a few small tweaks, the results will be perfect and your code will be as well. \r\nAs a next step, take an extra look at your frequency_comparison function and see if you can get accurate results while making the code more concise and readable.\r\nHave fun and keep up the good work!\r\n"}}
{"actor":{"display_login":"franfranfranfran"}}