{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/233455447","pull_request_review_id":174870599,"id":233455447,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzQ1NTQ0Nw==","diff_hunk":"@@ -125,6 +182,10 @@ struct uart_driver_api {\n \t/** Console I/O function */\n \tint (*err_check)(struct device *dev);\n \n+\t/** UART configuration functions */\n+\tint (*configure)(struct device *dev, struct uart_config *cfg);","path":"include/uart.h","position":74,"original_position":74,"commit_id":"119f274cd08cf09c97c6ef083a6f9af7079bb3d6","original_commit_id":"119f274cd08cf09c97c6ef083a6f9af7079bb3d6","user":{"login":"anangl","id":16913290,"node_id":"MDQ6VXNlcjE2OTEzMjkw","avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false},"body":"It should be `const struct uart_config *cfg`.","created_at":"2018-11-14T13:55:34Z","updated_at":"2018-11-14T13:56:36Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11185#discussion_r233455447","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/233455447"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/11185#discussion_r233455447"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185","id":229060703,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDYwNzAz","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11185","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11185.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11185.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11185","number":11185,"state":"open","locked":false,"title":"api: uart: Add configure functions for UART.","user":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"body":"Allow UART configuration to be altered during runtime.\r\n\r\nThis PR is follow up to #10820 it adds configuration part of it.","created_at":"2018-11-07T15:12:58Z","updated_at":"2018-11-14T13:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c3c632d829155213fcdbdb56ff1984bca57d13","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"jarz-nordic","id":34125330,"node_id":"MDQ6VXNlcjM0MTI1MzMw","avatar_url":"https://avatars1.githubusercontent.com/u/34125330?v=4","gravatar_id":"","url":"https://api.github.com/users/jarz-nordic","html_url":"https://github.com/jarz-nordic","followers_url":"https://api.github.com/users/jarz-nordic/followers","following_url":"https://api.github.com/users/jarz-nordic/following{/other_user}","gists_url":"https://api.github.com/users/jarz-nordic/gists{/gist_id}","starred_url":"https://api.github.com/users/jarz-nordic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarz-nordic/subscriptions","organizations_url":"https://api.github.com/users/jarz-nordic/orgs","repos_url":"https://api.github.com/users/jarz-nordic/repos","events_url":"https://api.github.com/users/jarz-nordic/events{/privacy}","received_events_url":"https://api.github.com/users/jarz-nordic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":796963297,"node_id":"MDU6TGFiZWw3OTY5NjMyOTc=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/API","name":"API","color":"d65e51","default":false},{"id":700753301,"node_id":"MDU6TGFiZWw3MDA3NTMzMDE=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20UART","name":"area: UART","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11185/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/119f274cd08cf09c97c6ef083a6f9af7079bb3d6","head":{"label":"Mierunski:uart_configure_api","ref":"uart_configure_api","sha":"119f274cd08cf09c97c6ef083a6f9af7079bb3d6","user":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"repo":{"id":134420444,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MjA0NDQ=","name":"zephyr","full_name":"Mierunski/zephyr","private":false,"owner":{"login":"Mierunski","id":19541298,"node_id":"MDQ6VXNlcjE5NTQxMjk4","avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Mierunski/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/Mierunski/zephyr","forks_url":"https://api.github.com/repos/Mierunski/zephyr/forks","keys_url":"https://api.github.com/repos/Mierunski/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mierunski/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mierunski/zephyr/teams","hooks_url":"https://api.github.com/repos/Mierunski/zephyr/hooks","issue_events_url":"https://api.github.com/repos/Mierunski/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/Mierunski/zephyr/events","assignees_url":"https://api.github.com/repos/Mierunski/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/Mierunski/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/Mierunski/zephyr/tags","blobs_url":"https://api.github.com/repos/Mierunski/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mierunski/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mierunski/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mierunski/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mierunski/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/Mierunski/zephyr/languages","stargazers_url":"https://api.github.com/repos/Mierunski/zephyr/stargazers","contributors_url":"https://api.github.com/repos/Mierunski/zephyr/contributors","subscribers_url":"https://api.github.com/repos/Mierunski/zephyr/subscribers","subscription_url":"https://api.github.com/repos/Mierunski/zephyr/subscription","commits_url":"https://api.github.com/repos/Mierunski/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mierunski/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mierunski/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mierunski/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mierunski/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/Mierunski/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mierunski/zephyr/merges","archive_url":"https://api.github.com/repos/Mierunski/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mierunski/zephyr/downloads","issues_url":"https://api.github.com/repos/Mierunski/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/Mierunski/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/Mierunski/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/Mierunski/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mierunski/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/Mierunski/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/Mierunski/zephyr/deployments","created_at":"2018-05-22T13:36:49Z","updated_at":"2018-05-22T13:37:30Z","pushed_at":"2018-11-13T08:07:08Z","git_url":"git://github.com/Mierunski/zephyr.git","ssh_url":"git@github.com:Mierunski/zephyr.git","clone_url":"https://github.com/Mierunski/zephyr.git","svn_url":"https://github.com/Mierunski/zephyr","homepage":"https://docs.zephyrproject.org","size":156337,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"64eb47e03290617f0e2095499661f9ada14bb1e1","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-11-14T13:54:51Z","pushed_at":"2018-11-14T13:56:19Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":157259,"stargazers_count":1362,"watchers_count":1362,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":885,"mirror_url":null,"archived":false,"open_issues_count":1142,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":885,"open_issues":1142,"watchers":1362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/11185"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11185"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11185/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11185/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/119f274cd08cf09c97c6ef083a6f9af7079bb3d6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anangl"}}