{"action":"created","issue":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14874","repository_url":"https://api.github.com/repos/PaddlePaddle/Paddle","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14874/labels{/name}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14874/comments","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14874/events","html_url":"https://github.com/PaddlePaddle/Paddle/pull/14874","id":390241244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDQ5NDQ2","number":14874,"title":"[WIP] MKLDNN residual connection fuse: fixing accuracy problem","user":{"login":"tpatejko","id":22833753,"node_id":"MDQ6VXNlcjIyODMzNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/22833753?v=4","gravatar_id":"","url":"https://api.github.com/users/tpatejko","html_url":"https://github.com/tpatejko","followers_url":"https://api.github.com/users/tpatejko/followers","following_url":"https://api.github.com/users/tpatejko/following{/other_user}","gists_url":"https://api.github.com/users/tpatejko/gists{/gist_id}","starred_url":"https://api.github.com/users/tpatejko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpatejko/subscriptions","organizations_url":"https://api.github.com/users/tpatejko/orgs","repos_url":"https://api.github.com/users/tpatejko/repos","events_url":"https://api.github.com/users/tpatejko/events{/privacy}","received_events_url":"https://api.github.com/users/tpatejko/received_events","type":"User","site_admin":false},"labels":[{"id":831909412,"node_id":"MDU6TGFiZWw4MzE5MDk0MTI=","url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels/Intel","name":"Intel","color":"53a9d1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-12T14:06:36Z","updated_at":"2018-12-13T14:46:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14874","html_url":"https://github.com/PaddlePaddle/Paddle/pull/14874","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/14874.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/14874.patch"},"body":"This PR attempts fixing problems with accuracy caused by incorrect fusion in conv+elementwise_add fuse pass."},"comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments/446993518","html_url":"https://github.com/PaddlePaddle/Paddle/pull/14874#issuecomment-446993518","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14874","id":446993518,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk5MzUxOA==","user":{"login":"tpatejko","id":22833753,"node_id":"MDQ6VXNlcjIyODMzNzUz","avatar_url":"https://avatars1.githubusercontent.com/u/22833753?v=4","gravatar_id":"","url":"https://api.github.com/users/tpatejko","html_url":"https://github.com/tpatejko","followers_url":"https://api.github.com/users/tpatejko/followers","following_url":"https://api.github.com/users/tpatejko/following{/other_user}","gists_url":"https://api.github.com/users/tpatejko/gists{/gist_id}","starred_url":"https://api.github.com/users/tpatejko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpatejko/subscriptions","organizations_url":"https://api.github.com/users/tpatejko/orgs","repos_url":"https://api.github.com/users/tpatejko/repos","events_url":"https://api.github.com/users/tpatejko/events{/privacy}","received_events_url":"https://api.github.com/users/tpatejko/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T14:46:17Z","updated_at":"2018-12-13T14:46:17Z","author_association":"CONTRIBUTOR","body":"@luotao1 Could you run it once again? I added some prints printing the value of `fuse_residual_conn` variable.\r\n\r\nIn the code, attribute `fuse_residual_connection` is set to `true` for both types of connections:\r\n* for identity connection:\r\nhttps://github.com/tpatejko/Paddle/blob/tpatejko/fix-for-conv-elementwise-fusion/paddle/fluid/framework/ir/conv_elementwise_add_mkldnn_fuse_pass.cc#L156\r\n* for projection connection:\r\nhttps://github.com/tpatejko/Paddle/blob/tpatejko/fix-for-conv-elementwise-fusion/paddle/fluid/framework/ir/conv_elementwise_add_mkldnn_fuse_pass.cc#L224\r\n\r\nIf `fuse_residual_conn` is set to `false` then MKLDNN will not sum convolution results with values from identity branch. "}}
{"actor":{"display_login":"tpatejko"}}