{"action":"created","comment":{"url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/comments/239072271","pull_request_review_id":181765610,"id":239072271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTA3MjI3MQ==","diff_hunk":"@@ -231,9 +231,11 @@ export const getCartDetails = (payload = {}) => {\n \n             // for each item in the cart, look up its image in the cache\n             // and merge it into the item object\n+            // then assign its options from the totals subResource\n             if (imageCache && Array.isArray(items) && items.length) {\n-                items.forEach(item => {\n+                items.forEach((item, i) => {\n                     item.image = item.image || imageCache[item.sku] || {};\n+                    item.options = totals.items ? totals.items[i].options : [];","path":"packages/venia-concept/src/actions/cart/asyncActions.js","position":9,"original_position":9,"commit_id":"a3482e26d66e8981650e9e9fc5c24f7f78034684","original_commit_id":"a3482e26d66e8981650e9e9fc5c24f7f78034684","user":{"login":"JStein92","id":27716099,"node_id":"MDQ6VXNlcjI3NzE2MDk5","avatar_url":"https://avatars0.githubusercontent.com/u/27716099?v=4","gravatar_id":"","url":"https://api.github.com/users/JStein92","html_url":"https://github.com/JStein92","followers_url":"https://api.github.com/users/JStein92/followers","following_url":"https://api.github.com/users/JStein92/following{/other_user}","gists_url":"https://api.github.com/users/JStein92/gists{/gist_id}","starred_url":"https://api.github.com/users/JStein92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JStein92/subscriptions","organizations_url":"https://api.github.com/users/JStein92/orgs","repos_url":"https://api.github.com/users/JStein92/repos","events_url":"https://api.github.com/users/JStein92/events{/privacy}","received_events_url":"https://api.github.com/users/JStein92/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n                    item.options = totals.items.find(t => t.item_id === item.item_id).options;\r\n```\r\nInteresting point - although it does seem to always be in the same order, I suppose I don't know for sure that it will always be. How about matching the item Id instead?","created_at":"2018-12-05T13:55:33Z","updated_at":"2018-12-05T13:55:34Z","html_url":"https://github.com/magento-research/pwa-studio/pull/588#discussion_r239072271","pull_request_url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/comments/239072271"},"html":{"href":"https://github.com/magento-research/pwa-studio/pull/588#discussion_r239072271"},"pull_request":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588"}},"in_reply_to_id":238866912},"pull_request":{"url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588","id":235563495,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTYzNDk1","html_url":"https://github.com/magento-research/pwa-studio/pull/588","diff_url":"https://github.com/magento-research/pwa-studio/pull/588.diff","patch_url":"https://github.com/magento-research/pwa-studio/pull/588.patch","issue_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/588","number":588,"state":"open","locked":false,"title":"add configurable information to minicart item display - issue #553","user":{"login":"JStein92","id":27716099,"node_id":"MDQ6VXNlcjI3NzE2MDk5","avatar_url":"https://avatars0.githubusercontent.com/u/27716099?v=4","gravatar_id":"","url":"https://api.github.com/users/JStein92","html_url":"https://github.com/JStein92","followers_url":"https://api.github.com/users/JStein92/followers","following_url":"https://api.github.com/users/JStein92/following{/other_user}","gists_url":"https://api.github.com/users/JStein92/gists{/gist_id}","starred_url":"https://api.github.com/users/JStein92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JStein92/subscriptions","organizations_url":"https://api.github.com/users/JStein92/orgs","repos_url":"https://api.github.com/users/JStein92/repos","events_url":"https://api.github.com/users/JStein92/events{/privacy}","received_events_url":"https://api.github.com/users/JStein92/received_events","type":"User","site_admin":false},"body":"<!-- (REQUIRED) What is the nature of this PR? -->\r\n\r\n## This PR is a:\r\n\r\n[ x ] New feature\r\n[ ] Enhancement/Optimization\r\n[ ] Refactor\r\n[ ] Bugfix\r\n[ ] Test for existing code\r\n[ ] Documentation\r\n\r\n<!-- (REQUIRED) What does this PR change? -->\r\n\r\n## Summary\r\n\r\nWhen this pull request is merged, it will add configurable options to the minicart item display.\r\n\r\n<!-- (OPTIONAL) What other information can you provide about this PR? -->\r\n\r\n## Additional information\r\n\r\nI added a max height + scroll to the configurable options block. So if an item has 4+ options, it will scroll instead of making the entire item display larger.\r\n\r\nI also changed it so the quantity block is flex-end, to make it consistent with @soumya-ashok's mockup for configurable items.\r\n\r\n![image](https://user-images.githubusercontent.com/27716099/49396472-0ddc7080-f6ee-11e8-8854-f9e0459c12b5.png)\r\n\r\n\r\n<!--\r\nThank you for your contribution!\r\n\r\nBefore submitting this pull request, please make sure you have read our Contribution Guidelines and your PR meets our contribution standards:\r\nhttps://github.com/magento-research/pwa-studio/blob/master/.github/CONTRIBUTION.md\r\n\r\nPlease fill out as much information as you can about your PR to help speed up the review process.\r\nIf your PR addresses an existing GitHub Issue, please refer to it in the title or Additional Information section to make the connection.\r\n\r\nWe may ask you for changes in your PR in order to meet the standards set in our Contribution Guidelines. PR's that do not comply with our guidelines may be closed at the maintainers' discretion.\r\n\r\nFeel free to remove this section before creating this PR.\r\n-->\r\n","created_at":"2018-12-03T19:25:36Z","updated_at":"2018-12-05T13:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4d11f613f7bdf57e865b86c2d995758e580fe21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588/commits","review_comments_url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588/comments","review_comment_url":"https://api.github.com/repos/magento-research/pwa-studio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/588/comments","statuses_url":"https://api.github.com/repos/magento-research/pwa-studio/statuses/a3482e26d66e8981650e9e9fc5c24f7f78034684","head":{"label":"bargreenellingson:variant-display","ref":"variant-display","sha":"a3482e26d66e8981650e9e9fc5c24f7f78034684","user":{"login":"bargreenellingson","id":14302431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzAyNDMx","avatar_url":"https://avatars2.githubusercontent.com/u/14302431?v=4","gravatar_id":"","url":"https://api.github.com/users/bargreenellingson","html_url":"https://github.com/bargreenellingson","followers_url":"https://api.github.com/users/bargreenellingson/followers","following_url":"https://api.github.com/users/bargreenellingson/following{/other_user}","gists_url":"https://api.github.com/users/bargreenellingson/gists{/gist_id}","starred_url":"https://api.github.com/users/bargreenellingson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bargreenellingson/subscriptions","organizations_url":"https://api.github.com/users/bargreenellingson/orgs","repos_url":"https://api.github.com/users/bargreenellingson/repos","events_url":"https://api.github.com/users/bargreenellingson/events{/privacy}","received_events_url":"https://api.github.com/users/bargreenellingson/received_events","type":"Organization","site_admin":false},"repo":{"id":145859607,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NTk2MDc=","name":"pwa-studio","full_name":"bargreenellingson/pwa-studio","private":false,"owner":{"login":"bargreenellingson","id":14302431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzAyNDMx","avatar_url":"https://avatars2.githubusercontent.com/u/14302431?v=4","gravatar_id":"","url":"https://api.github.com/users/bargreenellingson","html_url":"https://github.com/bargreenellingson","followers_url":"https://api.github.com/users/bargreenellingson/followers","following_url":"https://api.github.com/users/bargreenellingson/following{/other_user}","gists_url":"https://api.github.com/users/bargreenellingson/gists{/gist_id}","starred_url":"https://api.github.com/users/bargreenellingson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bargreenellingson/subscriptions","organizations_url":"https://api.github.com/users/bargreenellingson/orgs","repos_url":"https://api.github.com/users/bargreenellingson/repos","events_url":"https://api.github.com/users/bargreenellingson/events{/privacy}","received_events_url":"https://api.github.com/users/bargreenellingson/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bargreenellingson/pwa-studio","description":"🛠A collection of tools that enables developers to build complex Progressive Web Applications for Magento 2 stores.","fork":true,"url":"https://api.github.com/repos/bargreenellingson/pwa-studio","forks_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/forks","keys_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/teams","hooks_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/hooks","issue_events_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/issues/events{/number}","events_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/events","assignees_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/assignees{/user}","branches_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/branches{/branch}","tags_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/tags","blobs_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/languages","stargazers_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/stargazers","contributors_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/contributors","subscribers_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/subscribers","subscription_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/subscription","commits_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/contents/{+path}","compare_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/merges","archive_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/downloads","issues_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/issues{/number}","pulls_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/labels{/name}","releases_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/releases{/id}","deployments_url":"https://api.github.com/repos/bargreenellingson/pwa-studio/deployments","created_at":"2018-08-23T13:45:42Z","updated_at":"2018-09-24T17:41:48Z","pushed_at":"2018-12-05T13:41:42Z","git_url":"git://github.com/bargreenellingson/pwa-studio.git","ssh_url":"git@github.com:bargreenellingson/pwa-studio.git","clone_url":"https://github.com/bargreenellingson/pwa-studio.git","svn_url":"https://github.com/bargreenellingson/pwa-studio","homepage":"https://magento-research.github.io/pwa-studio/","size":10614,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magento-research:release/2.0","ref":"release/2.0","sha":"2d64c572ba02d610b88c093f91eac2cb16822be0","user":{"login":"magento-research","id":26729824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzI5ODI0","avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"repo":{"id":137249745,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNDk3NDU=","name":"pwa-studio","full_name":"magento-research/pwa-studio","private":false,"owner":{"login":"magento-research","id":26729824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzI5ODI0","avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento-research/pwa-studio","description":"🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.","fork":false,"url":"https://api.github.com/repos/magento-research/pwa-studio","forks_url":"https://api.github.com/repos/magento-research/pwa-studio/forks","keys_url":"https://api.github.com/repos/magento-research/pwa-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-research/pwa-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-research/pwa-studio/teams","hooks_url":"https://api.github.com/repos/magento-research/pwa-studio/hooks","issue_events_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/events{/number}","events_url":"https://api.github.com/repos/magento-research/pwa-studio/events","assignees_url":"https://api.github.com/repos/magento-research/pwa-studio/assignees{/user}","branches_url":"https://api.github.com/repos/magento-research/pwa-studio/branches{/branch}","tags_url":"https://api.github.com/repos/magento-research/pwa-studio/tags","blobs_url":"https://api.github.com/repos/magento-research/pwa-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-research/pwa-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-research/pwa-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-research/pwa-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-research/pwa-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-research/pwa-studio/languages","stargazers_url":"https://api.github.com/repos/magento-research/pwa-studio/stargazers","contributors_url":"https://api.github.com/repos/magento-research/pwa-studio/contributors","subscribers_url":"https://api.github.com/repos/magento-research/pwa-studio/subscribers","subscription_url":"https://api.github.com/repos/magento-research/pwa-studio/subscription","commits_url":"https://api.github.com/repos/magento-research/pwa-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-research/pwa-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-research/pwa-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-research/pwa-studio/contents/{+path}","compare_url":"https://api.github.com/repos/magento-research/pwa-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-research/pwa-studio/merges","archive_url":"https://api.github.com/repos/magento-research/pwa-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-research/pwa-studio/downloads","issues_url":"https://api.github.com/repos/magento-research/pwa-studio/issues{/number}","pulls_url":"https://api.github.com/repos/magento-research/pwa-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-research/pwa-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-research/pwa-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-research/pwa-studio/labels{/name}","releases_url":"https://api.github.com/repos/magento-research/pwa-studio/releases{/id}","deployments_url":"https://api.github.com/repos/magento-research/pwa-studio/deployments","created_at":"2018-06-13T17:35:05Z","updated_at":"2018-12-05T10:08:35Z","pushed_at":"2018-12-05T13:41:44Z","git_url":"git://github.com/magento-research/pwa-studio.git","ssh_url":"git@github.com:magento-research/pwa-studio.git","clone_url":"https://github.com/magento-research/pwa-studio.git","svn_url":"https://github.com/magento-research/pwa-studio","homepage":"http://pwastudio.io","size":12011,"stargazers_count":186,"watchers_count":186,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":203,"watchers":186,"default_branch":"release/2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588"},"html":{"href":"https://github.com/magento-research/pwa-studio/pull/588"},"issue":{"href":"https://api.github.com/repos/magento-research/pwa-studio/issues/588"},"comments":{"href":"https://api.github.com/repos/magento-research/pwa-studio/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento-research/pwa-studio/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/magento-research/pwa-studio/statuses/a3482e26d66e8981650e9e9fc5c24f7f78034684"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JStein92"}}