{"action":"created","comment":{"url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/comments/193459912","pull_request_review_id":126436902,"id":193459912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ1OTkxMg==","diff_hunk":"@@ -4,23 +4,22 @@ use core::hash::Hasher;\n use std::hash::Hasher;\n \n pub use util::make_table_crc16 as make_table;\n+pub use util::CalcType;\n \n include!(concat!(env!(\"OUT_DIR\"), \"/crc16_constants.rs\"));\n \n-/// Structure that holds all of the important values for calculating a CRC\n-///\n-/// # Definitions\n-///\n-/// * **table:** Holds the table values based on the supplied polynomial for the fast CRC calculations\n-/// * **initial:** The initial input value. AKA *reflect_in*\n-/// * **value:** Holds the current value of the CRC\n-/// * **reflect:** Chooses whether or not the CRC math is normal or reflected\n-/// * **final_xor:** Final value to XOR with when calling Digest::sum16\n+/// Structure that holds all of the important values for calculating a CRC.\n+/// ### Details\n+/// - **table**: Holds the table values based on the supplied polynomial for the fast CRC calculations\n+/// - **initial**: The initial input value. AKA *reflect_in*\n+/// - **value**: Holds the current value of the CRC\n+/// - **reflect**: Chooses whether or not the CRC math is *Normal* or *Reverse*\n+/// - **final_xor**: Final value to XOR with when calling `Digest::sum16()`. AKA *reflect_out*\n pub struct Digest {\n     table: [u16; 256],\n     initial: u16,\n     value: u16,\n-    reflect: bool,\n+    reflect: CalcType,","path":"src/crc16.rs","position":29,"original_position":29,"commit_id":"47e000be30574f7ba593c498aa80de88a723e610","original_commit_id":"47e000be30574f7ba593c498aa80de88a723e610","user":{"login":"CLomanno","id":10702563,"node_id":"MDQ6VXNlcjEwNzAyNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/10702563?v=4","gravatar_id":"","url":"https://api.github.com/users/CLomanno","html_url":"https://github.com/CLomanno","followers_url":"https://api.github.com/users/CLomanno/followers","following_url":"https://api.github.com/users/CLomanno/following{/other_user}","gists_url":"https://api.github.com/users/CLomanno/gists{/gist_id}","starred_url":"https://api.github.com/users/CLomanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLomanno/subscriptions","organizations_url":"https://api.github.com/users/CLomanno/orgs","repos_url":"https://api.github.com/users/CLomanno/repos","events_url":"https://api.github.com/users/CLomanno/events{/privacy}","received_events_url":"https://api.github.com/users/CLomanno/received_events","type":"User","site_admin":false},"body":"\"reflect\" is the word that is used in other generic CRC algorithms.  You can change it if you want, but I'm not sure it makes a huge difference.","created_at":"2018-06-06T15:44:19Z","updated_at":"2018-06-06T15:44:19Z","html_url":"https://github.com/mrhooray/crc-rs/pull/36#discussion_r193459912","pull_request_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/comments/193459912"},"html":{"href":"https://github.com/mrhooray/crc-rs/pull/36#discussion_r193459912"},"pull_request":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36"}},"in_reply_to_id":193307212},"pull_request":{"url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36","id":192880983,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODgwOTgz","html_url":"https://github.com/mrhooray/crc-rs/pull/36","diff_url":"https://github.com/mrhooray/crc-rs/pull/36.diff","patch_url":"https://github.com/mrhooray/crc-rs/pull/36.patch","issue_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/36","number":36,"state":"open","locked":false,"title":"Reverse compat","user":{"login":"CLomanno","id":10702563,"node_id":"MDQ6VXNlcjEwNzAyNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/10702563?v=4","gravatar_id":"","url":"https://api.github.com/users/CLomanno","html_url":"https://github.com/CLomanno","followers_url":"https://api.github.com/users/CLomanno/followers","following_url":"https://api.github.com/users/CLomanno/following{/other_user}","gists_url":"https://api.github.com/users/CLomanno/gists{/gist_id}","starred_url":"https://api.github.com/users/CLomanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLomanno/subscriptions","organizations_url":"https://api.github.com/users/CLomanno/orgs","repos_url":"https://api.github.com/users/CLomanno/repos","events_url":"https://api.github.com/users/CLomanno/events{/privacy}","received_events_url":"https://api.github.com/users/CLomanno/received_events","type":"User","site_admin":false},"body":"Added support for reverse compatibility.  Users can choose `CalcType::Normal` or `CalcType::Reverse` for `new_custom()`.  `CalcType::Compat` is used internally.","created_at":"2018-06-06T02:02:48Z","updated_at":"2018-06-06T15:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32a21707912ec1c3c76a7576b77857908ef8e81","assignee":{"login":"CLomanno","id":10702563,"node_id":"MDQ6VXNlcjEwNzAyNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/10702563?v=4","gravatar_id":"","url":"https://api.github.com/users/CLomanno","html_url":"https://github.com/CLomanno","followers_url":"https://api.github.com/users/CLomanno/followers","following_url":"https://api.github.com/users/CLomanno/following{/other_user}","gists_url":"https://api.github.com/users/CLomanno/gists{/gist_id}","starred_url":"https://api.github.com/users/CLomanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLomanno/subscriptions","organizations_url":"https://api.github.com/users/CLomanno/orgs","repos_url":"https://api.github.com/users/CLomanno/repos","events_url":"https://api.github.com/users/CLomanno/events{/privacy}","received_events_url":"https://api.github.com/users/CLomanno/received_events","type":"User","site_admin":false},"assignees":[{"login":"CLomanno","id":10702563,"node_id":"MDQ6VXNlcjEwNzAyNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/10702563?v=4","gravatar_id":"","url":"https://api.github.com/users/CLomanno","html_url":"https://github.com/CLomanno","followers_url":"https://api.github.com/users/CLomanno/followers","following_url":"https://api.github.com/users/CLomanno/following{/other_user}","gists_url":"https://api.github.com/users/CLomanno/gists{/gist_id}","starred_url":"https://api.github.com/users/CLomanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLomanno/subscriptions","organizations_url":"https://api.github.com/users/CLomanno/orgs","repos_url":"https://api.github.com/users/CLomanno/repos","events_url":"https://api.github.com/users/CLomanno/events{/privacy}","received_events_url":"https://api.github.com/users/CLomanno/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36/commits","review_comments_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36/comments","review_comment_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/36/comments","statuses_url":"https://api.github.com/repos/mrhooray/crc-rs/statuses/47e000be30574f7ba593c498aa80de88a723e610","head":{"label":"mrhooray:reverse_compat","ref":"reverse_compat","sha":"47e000be30574f7ba593c498aa80de88a723e610","user":{"login":"mrhooray","id":2237317,"node_id":"MDQ6VXNlcjIyMzczMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2237317?v=4","gravatar_id":"","url":"https://api.github.com/users/mrhooray","html_url":"https://github.com/mrhooray","followers_url":"https://api.github.com/users/mrhooray/followers","following_url":"https://api.github.com/users/mrhooray/following{/other_user}","gists_url":"https://api.github.com/users/mrhooray/gists{/gist_id}","starred_url":"https://api.github.com/users/mrhooray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrhooray/subscriptions","organizations_url":"https://api.github.com/users/mrhooray/orgs","repos_url":"https://api.github.com/users/mrhooray/repos","events_url":"https://api.github.com/users/mrhooray/events{/privacy}","received_events_url":"https://api.github.com/users/mrhooray/received_events","type":"User","site_admin":false},"repo":{"id":32252710,"node_id":"MDEwOlJlcG9zaXRvcnkzMjI1MjcxMA==","name":"crc-rs","full_name":"mrhooray/crc-rs","owner":{"login":"mrhooray","id":2237317,"node_id":"MDQ6VXNlcjIyMzczMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2237317?v=4","gravatar_id":"","url":"https://api.github.com/users/mrhooray","html_url":"https://github.com/mrhooray","followers_url":"https://api.github.com/users/mrhooray/followers","following_url":"https://api.github.com/users/mrhooray/following{/other_user}","gists_url":"https://api.github.com/users/mrhooray/gists{/gist_id}","starred_url":"https://api.github.com/users/mrhooray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrhooray/subscriptions","organizations_url":"https://api.github.com/users/mrhooray/orgs","repos_url":"https://api.github.com/users/mrhooray/repos","events_url":"https://api.github.com/users/mrhooray/events{/privacy}","received_events_url":"https://api.github.com/users/mrhooray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrhooray/crc-rs","description":"Rust implementation of CRC(16, 32, 64) with support of various standards","fork":false,"url":"https://api.github.com/repos/mrhooray/crc-rs","forks_url":"https://api.github.com/repos/mrhooray/crc-rs/forks","keys_url":"https://api.github.com/repos/mrhooray/crc-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrhooray/crc-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrhooray/crc-rs/teams","hooks_url":"https://api.github.com/repos/mrhooray/crc-rs/hooks","issue_events_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mrhooray/crc-rs/events","assignees_url":"https://api.github.com/repos/mrhooray/crc-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mrhooray/crc-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mrhooray/crc-rs/tags","blobs_url":"https://api.github.com/repos/mrhooray/crc-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrhooray/crc-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrhooray/crc-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrhooray/crc-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrhooray/crc-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mrhooray/crc-rs/languages","stargazers_url":"https://api.github.com/repos/mrhooray/crc-rs/stargazers","contributors_url":"https://api.github.com/repos/mrhooray/crc-rs/contributors","subscribers_url":"https://api.github.com/repos/mrhooray/crc-rs/subscribers","subscription_url":"https://api.github.com/repos/mrhooray/crc-rs/subscription","commits_url":"https://api.github.com/repos/mrhooray/crc-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrhooray/crc-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrhooray/crc-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrhooray/crc-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mrhooray/crc-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrhooray/crc-rs/merges","archive_url":"https://api.github.com/repos/mrhooray/crc-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrhooray/crc-rs/downloads","issues_url":"https://api.github.com/repos/mrhooray/crc-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mrhooray/crc-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mrhooray/crc-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrhooray/crc-rs/labels{/name}","releases_url":"https://api.github.com/repos/mrhooray/crc-rs/releases{/id}","deployments_url":"https://api.github.com/repos/mrhooray/crc-rs/deployments","created_at":"2015-03-15T09:22:04Z","updated_at":"2018-06-05T02:31:59Z","pushed_at":"2018-06-06T03:43:52Z","git_url":"git://github.com/mrhooray/crc-rs.git","ssh_url":"git@github.com:mrhooray/crc-rs.git","clone_url":"https://github.com/mrhooray/crc-rs.git","svn_url":"https://github.com/mrhooray/crc-rs","homepage":"","size":58,"stargazers_count":26,"watchers_count":26,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":2,"watchers":26,"default_branch":"master"}},"base":{"label":"mrhooray:master","ref":"master","sha":"35dab7a6804f009779e2e90b930ef87868521a6d","user":{"login":"mrhooray","id":2237317,"node_id":"MDQ6VXNlcjIyMzczMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2237317?v=4","gravatar_id":"","url":"https://api.github.com/users/mrhooray","html_url":"https://github.com/mrhooray","followers_url":"https://api.github.com/users/mrhooray/followers","following_url":"https://api.github.com/users/mrhooray/following{/other_user}","gists_url":"https://api.github.com/users/mrhooray/gists{/gist_id}","starred_url":"https://api.github.com/users/mrhooray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrhooray/subscriptions","organizations_url":"https://api.github.com/users/mrhooray/orgs","repos_url":"https://api.github.com/users/mrhooray/repos","events_url":"https://api.github.com/users/mrhooray/events{/privacy}","received_events_url":"https://api.github.com/users/mrhooray/received_events","type":"User","site_admin":false},"repo":{"id":32252710,"node_id":"MDEwOlJlcG9zaXRvcnkzMjI1MjcxMA==","name":"crc-rs","full_name":"mrhooray/crc-rs","owner":{"login":"mrhooray","id":2237317,"node_id":"MDQ6VXNlcjIyMzczMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2237317?v=4","gravatar_id":"","url":"https://api.github.com/users/mrhooray","html_url":"https://github.com/mrhooray","followers_url":"https://api.github.com/users/mrhooray/followers","following_url":"https://api.github.com/users/mrhooray/following{/other_user}","gists_url":"https://api.github.com/users/mrhooray/gists{/gist_id}","starred_url":"https://api.github.com/users/mrhooray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrhooray/subscriptions","organizations_url":"https://api.github.com/users/mrhooray/orgs","repos_url":"https://api.github.com/users/mrhooray/repos","events_url":"https://api.github.com/users/mrhooray/events{/privacy}","received_events_url":"https://api.github.com/users/mrhooray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrhooray/crc-rs","description":"Rust implementation of CRC(16, 32, 64) with support of various standards","fork":false,"url":"https://api.github.com/repos/mrhooray/crc-rs","forks_url":"https://api.github.com/repos/mrhooray/crc-rs/forks","keys_url":"https://api.github.com/repos/mrhooray/crc-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrhooray/crc-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrhooray/crc-rs/teams","hooks_url":"https://api.github.com/repos/mrhooray/crc-rs/hooks","issue_events_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mrhooray/crc-rs/events","assignees_url":"https://api.github.com/repos/mrhooray/crc-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mrhooray/crc-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mrhooray/crc-rs/tags","blobs_url":"https://api.github.com/repos/mrhooray/crc-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrhooray/crc-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrhooray/crc-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrhooray/crc-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrhooray/crc-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mrhooray/crc-rs/languages","stargazers_url":"https://api.github.com/repos/mrhooray/crc-rs/stargazers","contributors_url":"https://api.github.com/repos/mrhooray/crc-rs/contributors","subscribers_url":"https://api.github.com/repos/mrhooray/crc-rs/subscribers","subscription_url":"https://api.github.com/repos/mrhooray/crc-rs/subscription","commits_url":"https://api.github.com/repos/mrhooray/crc-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrhooray/crc-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrhooray/crc-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrhooray/crc-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrhooray/crc-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mrhooray/crc-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrhooray/crc-rs/merges","archive_url":"https://api.github.com/repos/mrhooray/crc-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrhooray/crc-rs/downloads","issues_url":"https://api.github.com/repos/mrhooray/crc-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mrhooray/crc-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mrhooray/crc-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mrhooray/crc-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrhooray/crc-rs/labels{/name}","releases_url":"https://api.github.com/repos/mrhooray/crc-rs/releases{/id}","deployments_url":"https://api.github.com/repos/mrhooray/crc-rs/deployments","created_at":"2015-03-15T09:22:04Z","updated_at":"2018-06-05T02:31:59Z","pushed_at":"2018-06-06T03:43:52Z","git_url":"git://github.com/mrhooray/crc-rs.git","ssh_url":"git@github.com:mrhooray/crc-rs.git","clone_url":"https://github.com/mrhooray/crc-rs.git","svn_url":"https://github.com/mrhooray/crc-rs","homepage":"","size":58,"stargazers_count":26,"watchers_count":26,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36"},"html":{"href":"https://github.com/mrhooray/crc-rs/pull/36"},"issue":{"href":"https://api.github.com/repos/mrhooray/crc-rs/issues/36"},"comments":{"href":"https://api.github.com/repos/mrhooray/crc-rs/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrhooray/crc-rs/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/mrhooray/crc-rs/statuses/47e000be30574f7ba593c498aa80de88a723e610"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CLomanno"}}