{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/3470","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/3470/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3470/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/3470/events","html_url":"https://github.com/kubernetes/kops/issues/3470","id":261493618,"node_id":"MDU6SXNzdWUyNjE0OTM2MTg=","number":3470,"title":"segfault validating cluster update after changing cluster name","user":{"login":"erickt","id":84711,"node_id":"MDQ6VXNlcjg0NzEx","avatar_url":"https://avatars3.githubusercontent.com/u/84711?v=4","gravatar_id":"","url":"https://api.github.com/users/erickt","html_url":"https://github.com/erickt","followers_url":"https://api.github.com/users/erickt/followers","following_url":"https://api.github.com/users/erickt/following{/other_user}","gists_url":"https://api.github.com/users/erickt/gists{/gist_id}","starred_url":"https://api.github.com/users/erickt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickt/subscriptions","organizations_url":"https://api.github.com/users/erickt/orgs","repos_url":"https://api.github.com/users/erickt/repos","events_url":"https://api.github.com/users/erickt/events{/privacy}","received_events_url":"https://api.github.com/users/erickt/received_events","type":"User","site_admin":false},"labels":[{"id":778139396,"node_id":"MDU6TGFiZWw3NzgxMzkzOTY=","url":"https://api.github.com/repos/kubernetes/kops/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/18","html_url":"https://github.com/kubernetes/kops/milestone/18","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/18/labels","id":3128157,"node_id":"MDk6TWlsZXN0b25lMzEyODE1Nw==","number":18,"title":"1.10","description":null,"creator":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":79,"state":"open","created_at":"2018-02-19T21:49:17Z","updated_at":"2018-07-20T15:02:14Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2017-09-28T23:47:28Z","updated_at":"2018-07-20T15:02:14Z","closed_at":"2018-07-20T15:02:14Z","author_association":"CONTRIBUTOR","body":"I just tried to rename a cluster with kops with commit ea314784b5b515f5cc2a56abc6f1452f3637e93b and I got a segfault or nil pointer dereference. I did `kops edit cluster` and then changed the the metadata from:\r\n\r\n```\r\n...\r\nmetadata:\r\n  name: <SOME_DOMAIN>\r\n...\r\n```\r\n\r\nTo:\r\n\r\n```\r\n...\r\nmetadata:\r\n  name: cluster.<SOME_DOMAIN>\r\n...\r\n```\r\n\r\nKops produced this backtrace:\r\n\r\n```\r\npanic: runtime error: invalid memory address or nil pointer dereference\r\n[signal SIGSEGV: segmentation violation code=0x1 addr=0x2c0 pc=0x1e97532]\r\n\r\ngoroutine 1 [running]:\r\nk8s.io/kops/pkg/apis/kops/validation.ValidateClusterUpdate(0xc420246700, 0xc4201c4c20, 0x0, 0x0, 0x0, 0x0)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/pkg/apis/kops/validation/cluster.go:39 +0x262\r\nk8s.io/kops/pkg/client/simple/vfsclientset.(*ClusterVFS).Update(0xc4207bdcc0, 0xc420246700, 0xc4201c4c20, 0xc4207bdb80, 0xc420d5f1b8, 0xc420d5f1b8)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/pkg/client/simple/vfsclientset/cluster.go:125 +0xd6\r\nk8s.io/kops/pkg/client/simple/vfsclientset.(*VFSClientset).UpdateCluster(0xc4207f7650, 0xc420246700, 0xc4201c4c20, 0x0, 0x0, 0x0)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/pkg/client/simple/vfsclientset/clientset.go:44 +0x4d\r\nmain.RunEditCluster(0xc420822460, 0xc420058fc0, 0xc4207f74a0, 0x0, 0x1, 0x5aeb180, 0xc42000e018, 0x5cb0060, 0x1, 0xc42000e528)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/cmd/kops/edit_cluster.go:247 +0x1221\r\nmain.NewCmdEditCluster.func1(0xc420058fc0, 0xc4207f74a0, 0x0, 0x1)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/cmd/kops/edit_cluster.go:70 +0x71\r\nk8s.io/kops/vendor/github.com/spf13/cobra.(*Command).execute(0xc420058fc0, 0xc4207f7490, 0x1, 0x1, 0xc420058fc0, 0xc4207f7490)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:603 +0x234\r\nk8s.io/kops/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x5c7b8e0, 0x385bc00, 0x0, 0x0)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:689 +0x2fe\r\nk8s.io/kops/vendor/github.com/spf13/cobra.(*Command).Execute(0x5c7b8e0, 0x5cb0060, 0x0)\r\n\t/Users/erickt/gopath/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:648 +0x2b\r\nmain.Execute()\r\n\t/Users/erickt/gopath/src/k8s.io/kops/cmd/kops/root.go:98 +0x91\r\nmain.main()\r\n\t/Users/erickt/gopath/src/k8s.io/kops/cmd/kops/main.go:25 +0x20\r\n```"}}
{"actor":{"display_login":"k8s-ci-robot"}}