{"action":"created","issue":{"url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/99","repository_url":"https://api.github.com/repos/bitnami-labs/sealed-secrets","labels_url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/99/comments","events_url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/99/events","html_url":"https://github.com/bitnami-labs/sealed-secrets/pull/99","id":321600318,"number":99,"title":"Support GKE / change the default controller namespace","user":{"login":"c-knowles","id":3053013,"avatar_url":"https://avatars3.githubusercontent.com/u/3053013?v=4","gravatar_id":"","url":"https://api.github.com/users/c-knowles","html_url":"https://github.com/c-knowles","followers_url":"https://api.github.com/users/c-knowles/followers","following_url":"https://api.github.com/users/c-knowles/following{/other_user}","gists_url":"https://api.github.com/users/c-knowles/gists{/gist_id}","starred_url":"https://api.github.com/users/c-knowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-knowles/subscriptions","organizations_url":"https://api.github.com/users/c-knowles/orgs","repos_url":"https://api.github.com/users/c-knowles/repos","events_url":"https://api.github.com/users/c-knowles/events{/privacy}","received_events_url":"https://api.github.com/users/c-knowles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-09T14:44:58Z","updated_at":"2018-05-10T06:13:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/pulls/99","html_url":"https://github.com/bitnami-labs/sealed-secrets/pull/99","diff_url":"https://github.com/bitnami-labs/sealed-secrets/pull/99.diff","patch_url":"https://github.com/bitnami-labs/sealed-secrets/pull/99.patch"},"body":"Separating it also means we have a little bit more clarity over access to the encryption private key and it's entirely separate from any system components which might have admin permissions (say, the kubernetes dashboard).\r\n\r\nFixes https://github.com/bitnami-labs/sealed-secrets/issues/90."},"comment":{"url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/comments/387962489","html_url":"https://github.com/bitnami-labs/sealed-secrets/pull/99#issuecomment-387962489","issue_url":"https://api.github.com/repos/bitnami-labs/sealed-secrets/issues/99","id":387962489,"user":{"login":"anguslees","id":224224,"avatar_url":"https://avatars0.githubusercontent.com/u/224224?v=4","gravatar_id":"","url":"https://api.github.com/users/anguslees","html_url":"https://github.com/anguslees","followers_url":"https://api.github.com/users/anguslees/followers","following_url":"https://api.github.com/users/anguslees/following{/other_user}","gists_url":"https://api.github.com/users/anguslees/gists{/gist_id}","starred_url":"https://api.github.com/users/anguslees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anguslees/subscriptions","organizations_url":"https://api.github.com/users/anguslees/orgs","repos_url":"https://api.github.com/users/anguslees/repos","events_url":"https://api.github.com/users/anguslees/events{/privacy}","received_events_url":"https://api.github.com/users/anguslees/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T06:13:44Z","updated_at":"2018-05-10T06:13:44Z","author_association":"CONTRIBUTOR","body":"Wat :man_facepalming:  I turned on extra kubectl debugging in #100.  I learned:\r\n- `kubectl` delays the error responses and prints them after trying to create everything - it does not abort at the first error.  So the ordering of output messages/errors is misleading.\r\n- `kubectl` does no sorting of input, it just tries them in order (I knew this).\r\n- `kubecfg` does *not* sort the `show` output in dependency order.  I distinctly remember adding this code a long time ago, and just assumed that this was how `kubecfg` behaved - but I can't find any mention of it now in the kubecfg git log.  This is the real error here :(\r\n\r\nI will fix this in kubecfg, but I'd like to not block this PR on waiting for a kubecfg release.\r\nOur options are:\r\n1. Use `kubecfg update controller.yaml` rather than `kubectl create -f`.  This is tempting, but I would like to test our published install instructions here, so we can uncover problems (like this one!)\r\n2. Run an explicit separate `kubectl create namespace sealed-secrets` command first.\r\n3. Change the way we generate the `controller-*.yaml` files so that we place the Namespace before any namespaced resources, without relying on `kubecfg` to do this for us.  This probably means (temporarily) removing the Namespace from jsonnet, and adding it using a shell cat or similar in the make rule.\r\n4. Wait until a fixed kubecfg is released that sorts the namespace early in YAML output.\r\n\r\nWhatever we do, we should update the install instructions similarly - since this CI failure is showing us what users will experience when they try the same.  I think this means I'd prefer (3) (generate the right yaml somehow), since that contains the hackery within that small build step and doesn't affect users."}}
{"actor":{"display_login":"anguslees"}}