{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/190834820","pull_request_review_id":123288536,"id":190834820,"diff_hunk":"@@ -515,6 +518,27 @@ Furthermore, containers doing lots of disk I/O (such as Kafka broker containers)\n for use as operating system page cache. On such containers, the request memory should be substantially more than the\n memory used by the JVM.\n \n+[[kafka_rack]]\n+===== Kafka rack\n+\n+It is possible to enable Kafka rack-awareness by specifying a JSON string for the `kafka-rack` field in the cluster ConfigMap.","path":"documentation/book/cluster-operator.adoc","position":19,"original_position":19,"commit_id":"0a0b8dafd329540b067a5935efb9ad5978e5b6a0","original_commit_id":"0a0b8dafd329540b067a5935efb9ad5978e5b6a0","user":{"login":"scholzj","id":5658439,"avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"I think Rack awareness is something not understandable to everyone. We should either explain a bit more or link to Kafka docu?","created_at":"2018-05-25T09:10:03Z","updated_at":"2018-05-25T09:26:26Z","html_url":"https://github.com/strimzi/strimzi/pull/461#discussion_r190834820","pull_request_url":"https://api.github.com/repos/strimzi/strimzi/pulls/461","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/190834820"},"html":{"href":"https://github.com/strimzi/strimzi/pull/461#discussion_r190834820"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/461","id":189723264,"html_url":"https://github.com/strimzi/strimzi/pull/461","diff_url":"https://github.com/strimzi/strimzi/pull/461.diff","patch_url":"https://github.com/strimzi/strimzi/pull/461.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi/issues/461","number":461,"state":"closed","locked":false,"title":"Add support for `broker.rack`","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n_Select the type of your PR_\r\n\r\n- Enhancement / new feature\r\n\r\n### Description\r\n\r\nThis PR is about #36 for adding broker.rack support.\r\nI need to think about tests for that but it's better opening the PR now because it's not so trivial to review.\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Write tests\r\n- [ ] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n\r\n","created_at":"2018-05-22T16:32:23Z","updated_at":"2018-05-25T09:26:26Z","closed_at":"2018-05-24T13:49:59Z","merged_at":"2018-05-24T13:49:59Z","merge_commit_sha":"4df595e1972755c9ac57dc7f4149e5ea8580f546","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/strimzi/strimzi/milestones/4","html_url":"https://github.com/strimzi/strimzi/milestone/4","labels_url":"https://api.github.com/repos/strimzi/strimzi/milestones/4/labels","id":3333700,"number":4,"title":"0.5.0","description":"","creator":{"login":"scholzj","id":5658439,"avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":20,"state":"open","created_at":"2018-05-09T16:31:12Z","updated_at":"2018-05-24T13:50:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/strimzi/strimzi/pulls/461/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi/pulls/461/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi/issues/461/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/0a0b8dafd329540b067a5935efb9ad5978e5b6a0","head":{"label":"strimzi:rack-support","ref":"rack-support","sha":"0a0b8dafd329540b067a5935efb9ad5978e5b6a0","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-05-25T06:27:03Z","pushed_at":"2018-05-25T09:22:12Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":10749,"stargazers_count":273,"watchers_count":273,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":54,"open_issues":68,"watchers":273,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"55de89cb876057fe05734721133aaee5fc2c0d1e","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-05-25T06:27:03Z","pushed_at":"2018-05-25T09:22:12Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"http://strimzi.io/","size":10749,"stargazers_count":273,"watchers_count":273,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":54,"open_issues":68,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/461"},"html":{"href":"https://github.com/strimzi/strimzi/pull/461"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/461"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi/statuses/0a0b8dafd329540b067a5935efb9ad5978e5b6a0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scholzj"}}