{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/comments/179806711","pull_request_review_id":110123559,"id":179806711,"diff_hunk":"@@ -503,10 +510,16 @@ export default Ember.Service.extend({\n  */\n function babelOpts(moduleName) {\n   return {\n-    modules: 'amdStrict',\n+    presets: ['es2017'],\n     moduleIds: true,\n     moduleId: moduleName,\n-    plugins: [ hbsPlugin ]\n+    plugins: [\n+      ['transform-es2015-modules-amd', {\n+        loose: true,\n+        noInterop: false","path":"app/services/ember-cli.js","position":null,"original_position":35,"commit_id":"d37a4766f7db200a695ef0a86435f236ce8cd8e1","original_commit_id":"bbd4da68d96e22b16005f55af3b7d0ca482b9d5e","user":{"login":"Gaurav0","id":313960,"avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"body":"Needed for compat with addons compiled with babel@5 using modules: 'amdStrict'","created_at":"2018-04-06T16:15:34Z","updated_at":"2018-04-06T16:15:34Z","html_url":"https://github.com/ember-cli/ember-twiddle/pull/594#discussion_r179806711","pull_request_url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/comments/179806711"},"html":{"href":"https://github.com/ember-cli/ember-twiddle/pull/594#discussion_r179806711"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594"}},"in_reply_to_id":179793720},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594","id":179818218,"html_url":"https://github.com/ember-cli/ember-twiddle/pull/594","diff_url":"https://github.com/ember-cli/ember-twiddle/pull/594.diff","patch_url":"https://github.com/ember-cli/ember-twiddle/pull/594.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/594","number":594,"state":"open","locked":false,"title":"Babel upgrade","user":{"login":"Gaurav0","id":313960,"avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"body":"For issue #593 \r\n\r\n- [x] 1. Upgrade ember-twiddle to use Babel 6 for its own transpilation\r\n- [x] 2. Send to client Babel 6 runtime from ember-cli-build.js\r\n- [x] 3. Change how modules are compiled on client in [ember-cli.js](https://github.com/ember-cli/ember-cli/blob/37fcddc7b75cd71ee148bee98fec603ce1516195/lib/broccoli/babel-process-modules-only.js#L18-L25)\r\n- [x] 4. Get most tests working - ensure compilation is correct.\r\n- [x] 5. Ensure addons still work even if compiled with Babel 5\r\n- [x] 6. Fix hbs plugin\r\n- [x] 7. Ensure tests still work on client (enable_testing: true).\r\n- [x] 8. Fix remaining tests.","created_at":"2018-04-05T22:59:01Z","updated_at":"2018-04-06T16:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e65b5f4abec66a313b29e3a96edc866e22fc2b4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/594/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-twiddle/statuses/d37a4766f7db200a695ef0a86435f236ce8cd8e1","head":{"label":"Gaurav0:babel_upgrade","ref":"babel_upgrade","sha":"d37a4766f7db200a695ef0a86435f236ce8cd8e1","user":{"login":"Gaurav0","id":313960,"avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"repo":{"id":38789280,"name":"ember-twiddle","full_name":"Gaurav0/ember-twiddle","owner":{"login":"Gaurav0","id":313960,"avatar_url":"https://avatars2.githubusercontent.com/u/313960?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaurav0","html_url":"https://github.com/Gaurav0","followers_url":"https://api.github.com/users/Gaurav0/followers","following_url":"https://api.github.com/users/Gaurav0/following{/other_user}","gists_url":"https://api.github.com/users/Gaurav0/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaurav0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaurav0/subscriptions","organizations_url":"https://api.github.com/users/Gaurav0/orgs","repos_url":"https://api.github.com/users/Gaurav0/repos","events_url":"https://api.github.com/users/Gaurav0/events{/privacy}","received_events_url":"https://api.github.com/users/Gaurav0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gaurav0/ember-twiddle","description":"JSFiddle type thing for ember-cli style code","fork":true,"url":"https://api.github.com/repos/Gaurav0/ember-twiddle","forks_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/forks","keys_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/teams","hooks_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/hooks","issue_events_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/issues/events{/number}","events_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/events","assignees_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/assignees{/user}","branches_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/branches{/branch}","tags_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/tags","blobs_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/statuses/{sha}","languages_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/languages","stargazers_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/stargazers","contributors_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/contributors","subscribers_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/subscribers","subscription_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/subscription","commits_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/contents/{+path}","compare_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/merges","archive_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/downloads","issues_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/issues{/number}","pulls_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/pulls{/number}","milestones_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/milestones{/number}","notifications_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/labels{/name}","releases_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/releases{/id}","deployments_url":"https://api.github.com/repos/Gaurav0/ember-twiddle/deployments","created_at":"2015-07-09T01:22:43Z","updated_at":"2018-04-04T15:37:21Z","pushed_at":"2018-04-06T16:14:37Z","git_url":"git://github.com/Gaurav0/ember-twiddle.git","ssh_url":"git@github.com:Gaurav0/ember-twiddle.git","clone_url":"https://github.com/Gaurav0/ember-twiddle.git","svn_url":"https://github.com/Gaurav0/ember-twiddle","homepage":null,"size":1525,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"2e7da69e1cb9caa806bf2f752ade45ae03886f24","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":31795341,"name":"ember-twiddle","full_name":"ember-cli/ember-twiddle","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-twiddle","description":"JSFiddle type thing for ember-cli style code","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-twiddle","forks_url":"https://api.github.com/repos/ember-cli/ember-twiddle/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-twiddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-twiddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-twiddle/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-twiddle/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-twiddle/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-twiddle/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-twiddle/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-twiddle/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-twiddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-twiddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-twiddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-twiddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-twiddle/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-twiddle/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-twiddle/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-twiddle/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-twiddle/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-twiddle/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-twiddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-twiddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-twiddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-twiddle/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-twiddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-twiddle/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-twiddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-twiddle/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-twiddle/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-twiddle/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-twiddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-twiddle/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-twiddle/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-twiddle/deployments","created_at":"2015-03-07T00:29:26Z","updated_at":"2018-04-04T20:22:39Z","pushed_at":"2018-04-06T16:14:39Z","git_url":"git://github.com/ember-cli/ember-twiddle.git","ssh_url":"git@github.com:ember-cli/ember-twiddle.git","clone_url":"https://github.com/ember-cli/ember-twiddle.git","svn_url":"https://github.com/ember-cli/ember-twiddle","homepage":"https://ember-twiddle.com","size":1323,"stargazers_count":255,"watchers_count":255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":88,"open_issues":54,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594"},"html":{"href":"https://github.com/ember-cli/ember-twiddle/pull/594"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/594"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-twiddle/statuses/d37a4766f7db200a695ef0a86435f236ce8cd8e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Gaurav0"}}