{"action":"created","issue":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5413","repository_url":"https://api.github.com/repos/gitextensions/gitextensions","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5413/labels{/name}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5413/comments","events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5413/events","html_url":"https://github.com/gitextensions/gitextensions/pull/5413","id":358328149,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTE0Njc2","number":5413,"title":"Leave only two rebase options in RevisionGridControl","user":{"login":"mdonatas","id":483659,"node_id":"MDQ6VXNlcjQ4MzY1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/483659?v=4","gravatar_id":"","url":"https://api.github.com/users/mdonatas","html_url":"https://github.com/mdonatas","followers_url":"https://api.github.com/users/mdonatas/followers","following_url":"https://api.github.com/users/mdonatas/following{/other_user}","gists_url":"https://api.github.com/users/mdonatas/gists{/gist_id}","starred_url":"https://api.github.com/users/mdonatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdonatas/subscriptions","organizations_url":"https://api.github.com/users/mdonatas/orgs","repos_url":"https://api.github.com/users/mdonatas/repos","events_url":"https://api.github.com/users/mdonatas/events{/privacy}","received_events_url":"https://api.github.com/users/mdonatas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2018-09-08T21:09:38Z","updated_at":"2018-09-14T15:56:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5413","html_url":"https://github.com/gitextensions/gitextensions/pull/5413","diff_url":"https://github.com/gitextensions/gitextensions/pull/5413.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/5413.patch"},"body":"- Problem\r\nWith addition of this advanced option (which is off by default!):\r\n![image](https://user-images.githubusercontent.com/483659/45258506-8e2a5880-b3c1-11e8-8219-ba0625a24339.png)\r\nThese two menu items both open rebase dialog with the only difference of `Interactive Rebase` being checked or not. This seems sub-optimal and also three menu items for the same action with different params is overcomplicated.\r\n![image](https://user-images.githubusercontent.com/483659/45258580-a5b61100-b3c2-11e8-8f11-ff8e79167a9f.png)\r\n\r\nChanges proposed in this pull request:\r\n- Leave only two rebase options in RevisionGridControl\r\n  - `Selected commit` starting simple rebase immediately\r\n  - `Selected commit with advanced options...` opening rebase dialog with `Interactive rebase` checked based on Advanced option\r\n- Replace current advanced option with a new one showing whether Rebase dialog has Interactive checked by default or not\r\n \r\nScreenshots after:\r\n![image](https://user-images.githubusercontent.com/483659/45258619-3b51a080-b3c3-11e8-9fa0-48452c478f75.png)\r\n![image](https://user-images.githubusercontent.com/483659/45258629-5a503280-b3c3-11e8-9071-88fd6753cd5b.png)\r\n"},"comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments/421403403","html_url":"https://github.com/gitextensions/gitextensions/pull/5413#issuecomment-421403403","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5413","id":421403403,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQwMzQwMw==","user":{"login":"mdonatas","id":483659,"node_id":"MDQ6VXNlcjQ4MzY1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/483659?v=4","gravatar_id":"","url":"https://api.github.com/users/mdonatas","html_url":"https://github.com/mdonatas","followers_url":"https://api.github.com/users/mdonatas/followers","following_url":"https://api.github.com/users/mdonatas/following{/other_user}","gists_url":"https://api.github.com/users/mdonatas/gists{/gist_id}","starred_url":"https://api.github.com/users/mdonatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdonatas/subscriptions","organizations_url":"https://api.github.com/users/mdonatas/orgs","repos_url":"https://api.github.com/users/mdonatas/repos","events_url":"https://api.github.com/users/mdonatas/events{/privacy}","received_events_url":"https://api.github.com/users/mdonatas/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T15:56:13Z","updated_at":"2018-09-14T15:56:13Z","author_association":"CONTRIBUTOR","body":"This has turned into a [bike-shed problem](https://en.wikipedia.org/wiki/Law_of_triviality). How about we leave just the separator in this PR?"}}
{"actor":{"display_login":"mdonatas"}}