{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/rfcs/pulls/comments/177777817","pull_request_review_id":107712882,"id":177777817,"diff_hunk":"@@ -0,0 +1,127 @@\n+---\n+feature: nix-release-model\n+start-date: 2018-03-28\n+author: Shea Levy <shea@shealevy.com>\n+co-authors: (find a buddy later to help our with the RFC)\n+related-issues: (will contain links to implementation PRs)\n+---\n+\n+# Summary\n+[summary]: #summary\n+\n+A model of when, what, and how to make new releases of Nix.\n+\n+# Motivation\n+[motivation]: #motivation\n+\n+We want to set clear expectations for users, provide guidance for\n+developers, and provide both groups the benefits of easy availability\n+of new improvements.\n+\n+# Detailed design\n+[design]: #detailed-design\n+\n+The proposed process contains a number of interrelated components.\n+I've numbered them for ease of reference and discussion, not to\n+indicate any meaningful ordering. Any aspect of this can be suspended\n+at the security team's discretion when handling a vulnerability. Items\n+marked with a * need technical work to implement.\n+\n+1. Keep `master` as close to release readiness as possible. This\n+   includes testing, documentation, changelog entries, etc. being\n+   ready *before* merge.\n+2. *Use code review and automated checks, enforced through branch\n+    protection, to ensure point 1 (and generally improve quality and\n+    increase knowledge spread).\n+3. Follow semver. In light of 1, this includes ensuring any necessary\n+   semver bumps happen before a relevant change is merged.\n+4. Any community member may request a new release by opening an issue\n+   on GitHub. If any Nix core team member (who isn't the requestor)\n+   thinks a release is warranted, they can assign themselves the\n+   ticket and assume release manager responsibilities for the release.\n+5. There will be at least one mainline release before each `NixOS`\n+   stable release.\n+6. The release manager will branch off a `#-stabilization` branch\n+   (e.g. `2.0.1-stabilization`) in advance of any release.\n+7. Changes aimed at getting the release ready (fixing bugs, improving\n+   docs, etc.) should target the `#-stabilization` branch and then\n+   be merged forward into `master`. No commit should exist on the\n+   `#-stabilization` branch without very soon thereafter being merged\n+   into `master`.","path":"rfcs/0028-nix-release-model.md","position":50,"original_position":50,"commit_id":"3ad3031fb756def6af8bd0ac53a13644d5fc9f02","original_commit_id":"3ad3031fb756def6af8bd0ac53a13644d5fc9f02","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars3.githubusercontent.com/u/487050?v=4","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"body":"So you're imagining a) we branch off a stabilization branch b) we remove derivation files on master*, c) we need a fix on stabilization that involves derivation files? I think that kind of thing is unlikely enough that we can just tell people to wait for stabilization... Maybe we should revisit if/when this arises.\r\n\r\n*: IMO if we do remove derivation files it should still be possible to serialize derivations somehow, just maybe not by default.","created_at":"2018-03-28T14:51:36Z","updated_at":"2018-03-28T14:51:36Z","html_url":"https://github.com/NixOS/rfcs/pull/28#discussion_r177777817","pull_request_url":"https://api.github.com/repos/NixOS/rfcs/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/comments/177777817"},"html":{"href":"https://github.com/NixOS/rfcs/pull/28#discussion_r177777817"},"pull_request":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/28"}},"in_reply_to_id":177770703},"pull_request":{"url":"https://api.github.com/repos/NixOS/rfcs/pulls/28","id":178029009,"html_url":"https://github.com/NixOS/rfcs/pull/28","diff_url":"https://github.com/NixOS/rfcs/pull/28.diff","patch_url":"https://github.com/NixOS/rfcs/pull/28.patch","issue_url":"https://api.github.com/repos/NixOS/rfcs/issues/28","number":28,"state":"open","locked":false,"title":"[RFC 0028] Nix Release Model","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars3.githubusercontent.com/u/487050?v=4","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"body":"[Rendered](https://github.com/shlevy/rfcs/blob/nix-release-model/rfcs/0028-nix-release-model.md)","created_at":"2018-03-28T12:54:29Z","updated_at":"2018-03-28T14:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f278f5357665f2e84d0ff32354455191d3cac841","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/rfcs/pulls/28/commits","review_comments_url":"https://api.github.com/repos/NixOS/rfcs/pulls/28/comments","review_comment_url":"https://api.github.com/repos/NixOS/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/rfcs/issues/28/comments","statuses_url":"https://api.github.com/repos/NixOS/rfcs/statuses/3ad3031fb756def6af8bd0ac53a13644d5fc9f02","head":{"label":"shlevy:nix-release-model","ref":"nix-release-model","sha":"3ad3031fb756def6af8bd0ac53a13644d5fc9f02","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars3.githubusercontent.com/u/487050?v=4","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"repo":{"id":86925745,"name":"rfcs","full_name":"shlevy/rfcs","owner":{"login":"shlevy","id":487050,"avatar_url":"https://avatars3.githubusercontent.com/u/487050?v=4","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shlevy/rfcs","description":"The Nix community RFCs","fork":true,"url":"https://api.github.com/repos/shlevy/rfcs","forks_url":"https://api.github.com/repos/shlevy/rfcs/forks","keys_url":"https://api.github.com/repos/shlevy/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlevy/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlevy/rfcs/teams","hooks_url":"https://api.github.com/repos/shlevy/rfcs/hooks","issue_events_url":"https://api.github.com/repos/shlevy/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/shlevy/rfcs/events","assignees_url":"https://api.github.com/repos/shlevy/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/shlevy/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/shlevy/rfcs/tags","blobs_url":"https://api.github.com/repos/shlevy/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlevy/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlevy/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlevy/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlevy/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/shlevy/rfcs/languages","stargazers_url":"https://api.github.com/repos/shlevy/rfcs/stargazers","contributors_url":"https://api.github.com/repos/shlevy/rfcs/contributors","subscribers_url":"https://api.github.com/repos/shlevy/rfcs/subscribers","subscription_url":"https://api.github.com/repos/shlevy/rfcs/subscription","commits_url":"https://api.github.com/repos/shlevy/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlevy/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlevy/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlevy/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlevy/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/shlevy/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlevy/rfcs/merges","archive_url":"https://api.github.com/repos/shlevy/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlevy/rfcs/downloads","issues_url":"https://api.github.com/repos/shlevy/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/shlevy/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/shlevy/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/shlevy/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlevy/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/shlevy/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/shlevy/rfcs/deployments","created_at":"2017-04-01T16:12:43Z","updated_at":"2017-03-29T21:15:23Z","pushed_at":"2018-03-28T12:55:14Z","git_url":"git://github.com/shlevy/rfcs.git","ssh_url":"git@github.com:shlevy/rfcs.git","clone_url":"https://github.com/shlevy/rfcs.git","svn_url":"https://github.com/shlevy/rfcs","homepage":"","size":59,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"5d91defc4dd574a43daf9b41aaa3ad51e4c04bb2","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":81662501,"name":"rfcs","full_name":"NixOS/rfcs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/rfcs","description":"The Nix community RFCs","fork":false,"url":"https://api.github.com/repos/NixOS/rfcs","forks_url":"https://api.github.com/repos/NixOS/rfcs/forks","keys_url":"https://api.github.com/repos/NixOS/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/rfcs/teams","hooks_url":"https://api.github.com/repos/NixOS/rfcs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/rfcs/events","assignees_url":"https://api.github.com/repos/NixOS/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/rfcs/tags","blobs_url":"https://api.github.com/repos/NixOS/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/rfcs/languages","stargazers_url":"https://api.github.com/repos/NixOS/rfcs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/rfcs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/rfcs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/rfcs/subscription","commits_url":"https://api.github.com/repos/NixOS/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/rfcs/merges","archive_url":"https://api.github.com/repos/NixOS/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/rfcs/downloads","issues_url":"https://api.github.com/repos/NixOS/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/rfcs/deployments","created_at":"2017-02-11T15:41:27Z","updated_at":"2018-03-07T08:53:58Z","pushed_at":"2018-03-28T12:55:15Z","git_url":"git://github.com/NixOS/rfcs.git","ssh_url":"git@github.com:NixOS/rfcs.git","clone_url":"https://github.com/NixOS/rfcs.git","svn_url":"https://github.com/NixOS/rfcs","homepage":"","size":40,"stargazers_count":45,"watchers_count":45,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0"},"forks":24,"open_issues":16,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/28"},"html":{"href":"https://github.com/NixOS/rfcs/pull/28"},"issue":{"href":"https://api.github.com/repos/NixOS/rfcs/issues/28"},"comments":{"href":"https://api.github.com/repos/NixOS/rfcs/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/rfcs/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/rfcs/statuses/3ad3031fb756def6af8bd0ac53a13644d5fc9f02"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shlevy"}}