{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/199956438","pull_request_review_id":134172105,"id":199956438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk1NjQzOA==","diff_hunk":"@@ -582,7 +596,7 @@ public Subscription subscription(final Set<String> topics) {\n \n         // construct the global partition assignment per host map\n         final Map<HostInfo, Set<TopicPartition>> partitionsByHostState = new HashMap<>();\n-        if (minReceivedMetadataVersion == 2 || minReceivedMetadataVersion == 3) {\n+        if (minReceivedMetadataVersion >= 2) {","path":"streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java","position":35,"original_position":35,"commit_id":"09450464f63fcfd8ba5be2b440e8527fbcd92743","original_commit_id":"09450464f63fcfd8ba5be2b440e8527fbcd92743","user":{"login":"guozhangwang","id":10729597,"node_id":"MDQ6VXNlcjEwNzI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"body":"Again this is another meta comment: the member decoding and handling leader's propagated assignment is in `onAssignment`, in which the we decode `AssignmentInfo` from `Assignment#userData`. In that function we should check the returned error code in `AssignmentInfo`, and if it is not NONE we should \"gracefully\" shutdown than just throwing a runtime exception: for example, we can set a flag indicating we need to error out, and then in `onPartitionsAssigned` callback we can check this flag and then decide to shutdown if necessary.","created_at":"2018-07-03T21:33:15Z","updated_at":"2018-07-03T21:33:30Z","html_url":"https://github.com/apache/kafka/pull/5322#discussion_r199956438","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5322","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/199956438"},"html":{"href":"https://github.com/apache/kafka/pull/5322#discussion_r199956438"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5322"}},"in_reply_to_id":199955030},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5322","id":198867797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODY3Nzk3","html_url":"https://github.com/apache/kafka/pull/5322","diff_url":"https://github.com/apache/kafka/pull/5322.diff","patch_url":"https://github.com/apache/kafka/pull/5322.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5322","number":5322,"state":"open","locked":false,"title":"KAFKA-5037 Infinite loop if all input topics are unknown at startup","user":{"login":"tedyu","id":235188,"node_id":"MDQ6VXNlcjIzNTE4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/235188?v=4","gravatar_id":"","url":"https://api.github.com/users/tedyu","html_url":"https://github.com/tedyu","followers_url":"https://api.github.com/users/tedyu/followers","following_url":"https://api.github.com/users/tedyu/following{/other_user}","gists_url":"https://api.github.com/users/tedyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tedyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedyu/subscriptions","organizations_url":"https://api.github.com/users/tedyu/orgs","repos_url":"https://api.github.com/users/tedyu/repos","events_url":"https://api.github.com/users/tedyu/events{/privacy}","received_events_url":"https://api.github.com/users/tedyu/received_events","type":"User","site_admin":false},"body":"1. At the beginning of assign, we first check that all the non-repartition source topics are included in the metadata. If not, we log an error at the leader and set an error in the Assignment userData bytes, indicating that leader cannot complete assignment and the error code would indicate the root cause of it.\r\n\r\n2. Upon receiving the assignment, if the error is not NONE the streams will shutdown itself with a log entry re-stating the root cause interpreted from the error code.\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-07-03T07:05:22Z","updated_at":"2018-07-03T21:33:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ac58143d079e3ad4b0d05646a3b962ae73335d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5322/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5322/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5322/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/09450464f63fcfd8ba5be2b440e8527fbcd92743","head":{"label":"tedyu:trunk","ref":"trunk","sha":"09450464f63fcfd8ba5be2b440e8527fbcd92743","user":{"login":"tedyu","id":235188,"node_id":"MDQ6VXNlcjIzNTE4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/235188?v=4","gravatar_id":"","url":"https://api.github.com/users/tedyu","html_url":"https://github.com/tedyu","followers_url":"https://api.github.com/users/tedyu/followers","following_url":"https://api.github.com/users/tedyu/following{/other_user}","gists_url":"https://api.github.com/users/tedyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tedyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedyu/subscriptions","organizations_url":"https://api.github.com/users/tedyu/orgs","repos_url":"https://api.github.com/users/tedyu/repos","events_url":"https://api.github.com/users/tedyu/events{/privacy}","received_events_url":"https://api.github.com/users/tedyu/received_events","type":"User","site_admin":false},"repo":{"id":139510250,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1MTAyNTA=","name":"kafka","full_name":"tedyu/kafka","owner":{"login":"tedyu","id":235188,"node_id":"MDQ6VXNlcjIzNTE4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/235188?v=4","gravatar_id":"","url":"https://api.github.com/users/tedyu","html_url":"https://github.com/tedyu","followers_url":"https://api.github.com/users/tedyu/followers","following_url":"https://api.github.com/users/tedyu/following{/other_user}","gists_url":"https://api.github.com/users/tedyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tedyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedyu/subscriptions","organizations_url":"https://api.github.com/users/tedyu/orgs","repos_url":"https://api.github.com/users/tedyu/repos","events_url":"https://api.github.com/users/tedyu/events{/privacy}","received_events_url":"https://api.github.com/users/tedyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tedyu/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/tedyu/kafka","forks_url":"https://api.github.com/repos/tedyu/kafka/forks","keys_url":"https://api.github.com/repos/tedyu/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tedyu/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tedyu/kafka/teams","hooks_url":"https://api.github.com/repos/tedyu/kafka/hooks","issue_events_url":"https://api.github.com/repos/tedyu/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/tedyu/kafka/events","assignees_url":"https://api.github.com/repos/tedyu/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/tedyu/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/tedyu/kafka/tags","blobs_url":"https://api.github.com/repos/tedyu/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tedyu/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tedyu/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/tedyu/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tedyu/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/tedyu/kafka/languages","stargazers_url":"https://api.github.com/repos/tedyu/kafka/stargazers","contributors_url":"https://api.github.com/repos/tedyu/kafka/contributors","subscribers_url":"https://api.github.com/repos/tedyu/kafka/subscribers","subscription_url":"https://api.github.com/repos/tedyu/kafka/subscription","commits_url":"https://api.github.com/repos/tedyu/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/tedyu/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/tedyu/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/tedyu/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/tedyu/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/tedyu/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tedyu/kafka/merges","archive_url":"https://api.github.com/repos/tedyu/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tedyu/kafka/downloads","issues_url":"https://api.github.com/repos/tedyu/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/tedyu/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/tedyu/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/tedyu/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tedyu/kafka/labels{/name}","releases_url":"https://api.github.com/repos/tedyu/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/tedyu/kafka/deployments","created_at":"2018-07-03T00:56:12Z","updated_at":"2018-07-03T07:04:20Z","pushed_at":"2018-07-03T07:04:15Z","git_url":"git://github.com/tedyu/kafka.git","ssh_url":"git@github.com:tedyu/kafka.git","clone_url":"https://github.com/tedyu/kafka.git","svn_url":"https://github.com/tedyu/kafka","homepage":null,"size":68980,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"8250738ae41f6f0a87dc1e21e7623c5d69cae148","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-07-03T18:44:21Z","pushed_at":"2018-07-03T20:52:41Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":69014,"stargazers_count":8813,"watchers_count":8813,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5071,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5071,"open_issues":460,"watchers":8813,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5322"},"html":{"href":"https://github.com/apache/kafka/pull/5322"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5322"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5322/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5322/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5322/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/09450464f63fcfd8ba5be2b440e8527fbcd92743"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"guozhangwang"}}