{"action":"created","issue":{"url":"https://api.github.com/repos/trailofbits/slither/issues/96","repository_url":"https://api.github.com/repos/trailofbits/slither","labels_url":"https://api.github.com/repos/trailofbits/slither/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/trailofbits/slither/issues/96/comments","events_url":"https://api.github.com/repos/trailofbits/slither/issues/96/events","html_url":"https://github.com/trailofbits/slither/issues/96","id":389063072,"node_id":"MDU6SXNzdWUzODkwNjMwNzI=","number":96,"title":"detector (old solc) only checks 0.4.23, 0.4.24 ","user":{"login":"ktb88","id":2957373,"node_id":"MDQ6VXNlcjI5NTczNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2957373?v=4","gravatar_id":"","url":"https://api.github.com/users/ktb88","html_url":"https://github.com/ktb88","followers_url":"https://api.github.com/users/ktb88/followers","following_url":"https://api.github.com/users/ktb88/following{/other_user}","gists_url":"https://api.github.com/users/ktb88/gists{/gist_id}","starred_url":"https://api.github.com/users/ktb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktb88/subscriptions","organizations_url":"https://api.github.com/users/ktb88/orgs","repos_url":"https://api.github.com/users/ktb88/repos","events_url":"https://api.github.com/users/ktb88/events{/privacy}","received_events_url":"https://api.github.com/users/ktb88/received_events","type":"User","site_admin":false},"labels":[{"id":1047160702,"node_id":"MDU6TGFiZWwxMDQ3MTYwNzAy","url":"https://api.github.com/repos/trailofbits/slither/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-09T20:54:52Z","updated_at":"2018-12-10T10:53:54Z","closed_at":null,"author_association":"NONE","body":"slither version: 0.3.1\r\n\r\nin /slither/attributes/old_solc.py\r\n```python\r\nold_pragma = [p for p in pragma if self._convert_pragma(p.version) not in ['0.4.23', '0.4.24']]\r\nif old_pragma:\r\n  # detected old pragma\r\n```\r\n\r\nIt detects only \"0.4.23\", \"0.4.24\" as safe version. (even test solidity uses 0.4.25, it detected as old version)\r\n\r\nshould it be changed like under 0.4.25 is unsafe version? and also it will be great to support 0.5.X versions :)"},"comment":{"url":"https://api.github.com/repos/trailofbits/slither/issues/comments/445773985","html_url":"https://github.com/trailofbits/slither/issues/96#issuecomment-445773985","issue_url":"https://api.github.com/repos/trailofbits/slither/issues/96","id":445773985,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTc3Mzk4NQ==","user":{"login":"ktb88","id":2957373,"node_id":"MDQ6VXNlcjI5NTczNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2957373?v=4","gravatar_id":"","url":"https://api.github.com/users/ktb88","html_url":"https://github.com/ktb88","followers_url":"https://api.github.com/users/ktb88/followers","following_url":"https://api.github.com/users/ktb88/following{/other_user}","gists_url":"https://api.github.com/users/ktb88/gists{/gist_id}","starred_url":"https://api.github.com/users/ktb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktb88/subscriptions","organizations_url":"https://api.github.com/users/ktb88/orgs","repos_url":"https://api.github.com/users/ktb88/repos","events_url":"https://api.github.com/users/ktb88/events{/privacy}","received_events_url":"https://api.github.com/users/ktb88/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T10:53:54Z","updated_at":"2018-12-10T10:53:54Z","author_association":"NONE","body":"I thought this issue more carefully, this is not that easy to resolve because the versioning issues are not depend on pragma syntax but solc binary (--solc option or default solc).\r\n\r\nOne straightforward way to handle this issue is that every detectors have their own affected version list (solc binary version). But I think this way is hard to maintain to refresh all the detectors on every version update of solc.\r\n\r\nSo, I've researching and testing for versioning issue especially slither detectors and if I found good way (reduce false alarm, easy maintain), then I'll put the result in here."}}
{"actor":{"display_login":"ktb88"}}