{"action":"closed","number":839,"pull_request":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839","id":184009965,"html_url":"https://github.com/fluentassertions/fluentassertions/pull/839","diff_url":"https://github.com/fluentassertions/fluentassertions/pull/839.diff","patch_url":"https://github.com/fluentassertions/fluentassertions/pull/839.patch","issue_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/839","number":839,"state":"closed","locked":false,"title":"Custom analysis rules","user":{"login":"jnyrup","id":919634,"avatar_url":"https://avatars1.githubusercontent.com/u/919634?v=4","gravatar_id":"","url":"https://api.github.com/users/jnyrup","html_url":"https://github.com/jnyrup","followers_url":"https://api.github.com/users/jnyrup/followers","following_url":"https://api.github.com/users/jnyrup/following{/other_user}","gists_url":"https://api.github.com/users/jnyrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnyrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnyrup/subscriptions","organizations_url":"https://api.github.com/users/jnyrup/orgs","repos_url":"https://api.github.com/users/jnyrup/repos","events_url":"https://api.github.com/users/jnyrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnyrup/received_events","type":"User","site_admin":false},"body":"This PR adds custom analysis rulesets to both Core and Test projects.\r\nThe ruleset for Tests is more relaxed, as we e.g. intentionally box an int to exercise specific code paths.\r\n\r\n* Some standard rules are raised to errors, such as e.g. [CS0162 Unreachable code detected](https://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0162).\r\n* Som rules from third-party analyzers are now ignored.\r\n  * [Roslynator](https://github.com/JosefPihrt/Roslynator)\r\n  * [U2U Consult Performance Analyzers for C# 7](https://github.com/u2uconsult/codeanalyzers).\r\n\r\nThis makes the warnings from analyzers that we actually care about more visible in the error list - at least to me.\r\n\r\nHaving a trimmed error list revealed some spots that could be improved with e.g. pattern matching.","created_at":"2018-04-25T11:52:55Z","updated_at":"2018-05-14T16:58:47Z","closed_at":"2018-05-14T16:58:47Z","merged_at":"2018-05-14T16:58:47Z","merge_commit_sha":"282de0d19ab9e5217d66d212fe760bd6c1a5dd84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839/commits","review_comments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839/comments","review_comment_url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/839/comments","statuses_url":"https://api.github.com/repos/fluentassertions/fluentassertions/statuses/13c7c04be55f2ba74af0497bb61ac2a62b15283f","head":{"label":"jnyrup:cleanup","ref":"cleanup","sha":"13c7c04be55f2ba74af0497bb61ac2a62b15283f","user":{"login":"jnyrup","id":919634,"avatar_url":"https://avatars1.githubusercontent.com/u/919634?v=4","gravatar_id":"","url":"https://api.github.com/users/jnyrup","html_url":"https://github.com/jnyrup","followers_url":"https://api.github.com/users/jnyrup/followers","following_url":"https://api.github.com/users/jnyrup/following{/other_user}","gists_url":"https://api.github.com/users/jnyrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnyrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnyrup/subscriptions","organizations_url":"https://api.github.com/users/jnyrup/orgs","repos_url":"https://api.github.com/users/jnyrup/repos","events_url":"https://api.github.com/users/jnyrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnyrup/received_events","type":"User","site_admin":false},"repo":{"id":89954081,"name":"fluentassertions","full_name":"jnyrup/fluentassertions","owner":{"login":"jnyrup","id":919634,"avatar_url":"https://avatars1.githubusercontent.com/u/919634?v=4","gravatar_id":"","url":"https://api.github.com/users/jnyrup","html_url":"https://github.com/jnyrup","followers_url":"https://api.github.com/users/jnyrup/followers","following_url":"https://api.github.com/users/jnyrup/following{/other_user}","gists_url":"https://api.github.com/users/jnyrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnyrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnyrup/subscriptions","organizations_url":"https://api.github.com/users/jnyrup/orgs","repos_url":"https://api.github.com/users/jnyrup/repos","events_url":"https://api.github.com/users/jnyrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnyrup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnyrup/fluentassertions","description":"Fluent Assertions is a set of .NET extension methods that allow you to more naturally specify the expected outcome of a TDD or BDD-style test. We currently use it in all our internal and client projects, and it is used in many open-source projects. It runs on .NET 4.0, 4.5, 4.6, CoreClr, .NET Native, Windows 8.1, Silverlight 5, Windows Phone 8.0 and UWP. It supports the unit test frameworks MSTest, MSTest2, NUnit, XUnit, MBUnit, Gallio, NSpec and MSpec.","fork":true,"url":"https://api.github.com/repos/jnyrup/fluentassertions","forks_url":"https://api.github.com/repos/jnyrup/fluentassertions/forks","keys_url":"https://api.github.com/repos/jnyrup/fluentassertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnyrup/fluentassertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnyrup/fluentassertions/teams","hooks_url":"https://api.github.com/repos/jnyrup/fluentassertions/hooks","issue_events_url":"https://api.github.com/repos/jnyrup/fluentassertions/issues/events{/number}","events_url":"https://api.github.com/repos/jnyrup/fluentassertions/events","assignees_url":"https://api.github.com/repos/jnyrup/fluentassertions/assignees{/user}","branches_url":"https://api.github.com/repos/jnyrup/fluentassertions/branches{/branch}","tags_url":"https://api.github.com/repos/jnyrup/fluentassertions/tags","blobs_url":"https://api.github.com/repos/jnyrup/fluentassertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnyrup/fluentassertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnyrup/fluentassertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnyrup/fluentassertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnyrup/fluentassertions/statuses/{sha}","languages_url":"https://api.github.com/repos/jnyrup/fluentassertions/languages","stargazers_url":"https://api.github.com/repos/jnyrup/fluentassertions/stargazers","contributors_url":"https://api.github.com/repos/jnyrup/fluentassertions/contributors","subscribers_url":"https://api.github.com/repos/jnyrup/fluentassertions/subscribers","subscription_url":"https://api.github.com/repos/jnyrup/fluentassertions/subscription","commits_url":"https://api.github.com/repos/jnyrup/fluentassertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnyrup/fluentassertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnyrup/fluentassertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnyrup/fluentassertions/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnyrup/fluentassertions/contents/{+path}","compare_url":"https://api.github.com/repos/jnyrup/fluentassertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnyrup/fluentassertions/merges","archive_url":"https://api.github.com/repos/jnyrup/fluentassertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnyrup/fluentassertions/downloads","issues_url":"https://api.github.com/repos/jnyrup/fluentassertions/issues{/number}","pulls_url":"https://api.github.com/repos/jnyrup/fluentassertions/pulls{/number}","milestones_url":"https://api.github.com/repos/jnyrup/fluentassertions/milestones{/number}","notifications_url":"https://api.github.com/repos/jnyrup/fluentassertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnyrup/fluentassertions/labels{/name}","releases_url":"https://api.github.com/repos/jnyrup/fluentassertions/releases{/id}","deployments_url":"https://api.github.com/repos/jnyrup/fluentassertions/deployments","created_at":"2017-05-01T19:09:36Z","updated_at":"2018-04-29T09:07:51Z","pushed_at":"2018-05-11T06:34:07Z","git_url":"git://github.com/jnyrup/fluentassertions.git","ssh_url":"git@github.com:jnyrup/fluentassertions.git","clone_url":"https://github.com/jnyrup/fluentassertions.git","svn_url":"https://github.com/jnyrup/fluentassertions","homepage":"http://www.fluentassertions.com","size":21941,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"fluentassertions:master","ref":"master","sha":"418842bbef3ecee23170098c05ba6e2be986aa92","user":{"login":"fluentassertions","id":25584770,"avatar_url":"https://avatars1.githubusercontent.com/u/25584770?v=4","gravatar_id":"","url":"https://api.github.com/users/fluentassertions","html_url":"https://github.com/fluentassertions","followers_url":"https://api.github.com/users/fluentassertions/followers","following_url":"https://api.github.com/users/fluentassertions/following{/other_user}","gists_url":"https://api.github.com/users/fluentassertions/gists{/gist_id}","starred_url":"https://api.github.com/users/fluentassertions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluentassertions/subscriptions","organizations_url":"https://api.github.com/users/fluentassertions/orgs","repos_url":"https://api.github.com/users/fluentassertions/repos","events_url":"https://api.github.com/users/fluentassertions/events{/privacy}","received_events_url":"https://api.github.com/users/fluentassertions/received_events","type":"Organization","site_admin":false},"repo":{"id":11718424,"name":"fluentassertions","full_name":"fluentassertions/fluentassertions","owner":{"login":"fluentassertions","id":25584770,"avatar_url":"https://avatars1.githubusercontent.com/u/25584770?v=4","gravatar_id":"","url":"https://api.github.com/users/fluentassertions","html_url":"https://github.com/fluentassertions","followers_url":"https://api.github.com/users/fluentassertions/followers","following_url":"https://api.github.com/users/fluentassertions/following{/other_user}","gists_url":"https://api.github.com/users/fluentassertions/gists{/gist_id}","starred_url":"https://api.github.com/users/fluentassertions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluentassertions/subscriptions","organizations_url":"https://api.github.com/users/fluentassertions/orgs","repos_url":"https://api.github.com/users/fluentassertions/repos","events_url":"https://api.github.com/users/fluentassertions/events{/privacy}","received_events_url":"https://api.github.com/users/fluentassertions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluentassertions/fluentassertions","description":"Fluent API for asserting the results of unit tests that targets .NET Framework 4.5, 4.7, .NET Standard 1.3, 1.6 and 2.0. Supports the unit test frameworks MSTest, MSTest2, Gallio, NUnit, XUnit, MBunit, MSpec, and NSpec.","fork":false,"url":"https://api.github.com/repos/fluentassertions/fluentassertions","forks_url":"https://api.github.com/repos/fluentassertions/fluentassertions/forks","keys_url":"https://api.github.com/repos/fluentassertions/fluentassertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluentassertions/fluentassertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluentassertions/fluentassertions/teams","hooks_url":"https://api.github.com/repos/fluentassertions/fluentassertions/hooks","issue_events_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/events{/number}","events_url":"https://api.github.com/repos/fluentassertions/fluentassertions/events","assignees_url":"https://api.github.com/repos/fluentassertions/fluentassertions/assignees{/user}","branches_url":"https://api.github.com/repos/fluentassertions/fluentassertions/branches{/branch}","tags_url":"https://api.github.com/repos/fluentassertions/fluentassertions/tags","blobs_url":"https://api.github.com/repos/fluentassertions/fluentassertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluentassertions/fluentassertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluentassertions/fluentassertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluentassertions/fluentassertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluentassertions/fluentassertions/statuses/{sha}","languages_url":"https://api.github.com/repos/fluentassertions/fluentassertions/languages","stargazers_url":"https://api.github.com/repos/fluentassertions/fluentassertions/stargazers","contributors_url":"https://api.github.com/repos/fluentassertions/fluentassertions/contributors","subscribers_url":"https://api.github.com/repos/fluentassertions/fluentassertions/subscribers","subscription_url":"https://api.github.com/repos/fluentassertions/fluentassertions/subscription","commits_url":"https://api.github.com/repos/fluentassertions/fluentassertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluentassertions/fluentassertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluentassertions/fluentassertions/contents/{+path}","compare_url":"https://api.github.com/repos/fluentassertions/fluentassertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluentassertions/fluentassertions/merges","archive_url":"https://api.github.com/repos/fluentassertions/fluentassertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluentassertions/fluentassertions/downloads","issues_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues{/number}","pulls_url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls{/number}","milestones_url":"https://api.github.com/repos/fluentassertions/fluentassertions/milestones{/number}","notifications_url":"https://api.github.com/repos/fluentassertions/fluentassertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluentassertions/fluentassertions/labels{/name}","releases_url":"https://api.github.com/repos/fluentassertions/fluentassertions/releases{/id}","deployments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/deployments","created_at":"2013-07-28T10:35:25Z","updated_at":"2018-05-12T18:44:04Z","pushed_at":"2018-05-14T16:58:47Z","git_url":"git://github.com/fluentassertions/fluentassertions.git","ssh_url":"git@github.com:fluentassertions/fluentassertions.git","clone_url":"https://github.com/fluentassertions/fluentassertions.git","svn_url":"https://github.com/fluentassertions/fluentassertions","homepage":"https://www.fluentassertions.com","size":21889,"stargazers_count":1097,"watchers_count":1097,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":250,"open_issues":85,"watchers":1097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839"},"html":{"href":"https://github.com/fluentassertions/fluentassertions/pull/839"},"issue":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/839"},"comments":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/839/comments"},"review_comments":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839/comments"},"review_comment":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/839/commits"},"statuses":{"href":"https://api.github.com/repos/fluentassertions/fluentassertions/statuses/13c7c04be55f2ba74af0497bb61ac2a62b15283f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jnyrup","id":919634,"avatar_url":"https://avatars1.githubusercontent.com/u/919634?v=4","gravatar_id":"","url":"https://api.github.com/users/jnyrup","html_url":"https://github.com/jnyrup","followers_url":"https://api.github.com/users/jnyrup/followers","following_url":"https://api.github.com/users/jnyrup/following{/other_user}","gists_url":"https://api.github.com/users/jnyrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnyrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnyrup/subscriptions","organizations_url":"https://api.github.com/users/jnyrup/orgs","repos_url":"https://api.github.com/users/jnyrup/repos","events_url":"https://api.github.com/users/jnyrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnyrup/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":326,"deletions":240,"changed_files":78}}
{"actor":{"display_login":"jnyrup"}}