{"action":"opened","number":5618,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618","id":172137952,"html_url":"https://github.com/bbatsov/rubocop/pull/5618","diff_url":"https://github.com/bbatsov/rubocop/pull/5618.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/5618.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5618","number":5618,"state":"open","locked":false,"title":"[Fix #5615] Fix false positive `Rails/FilePath` when using `File::SEPARATOR` string","user":{"login":"koic","id":13203,"avatar_url":"https://avatars3.githubusercontent.com/u/13203?v=4","gravatar_id":"","url":"https://api.github.com/users/koic","html_url":"https://github.com/koic","followers_url":"https://api.github.com/users/koic/followers","following_url":"https://api.github.com/users/koic/following{/other_user}","gists_url":"https://api.github.com/users/koic/gists{/gist_id}","starred_url":"https://api.github.com/users/koic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koic/subscriptions","organizations_url":"https://api.github.com/users/koic/orgs","repos_url":"https://api.github.com/users/koic/repos","events_url":"https://api.github.com/users/koic/events{/privacy}","received_events_url":"https://api.github.com/users/koic/received_events","type":"User","site_admin":false},"body":"Fixes #5615.\r\n\r\nThis PR fixes a false positive in `Rails/FilePath` cop when using `File::SEPARATOR` string (e.g. `'/'`) without `Rails.root.join`.\r\n\r\nThis regression was due to #5461.\r\nSince this is a regression for changes that have not yet been released, it is not described in CHANGELOG.md.\r\n\r\nCc @bquorning \r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [ ] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [x] Run `rake default` or `rake parallel`. It executes all tests and RuboCop for itself, and generates the documentation.\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/\r\n","created_at":"2018-03-01T04:00:37Z","updated_at":"2018-03-01T04:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5618/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/e5fdf72c1da0b789f5dd6a74b3b37927e7b44686","head":{"label":"koic:fix_rails_file_path_when_using_file_separator","ref":"fix_rails_file_path_when_using_file_separator","sha":"e5fdf72c1da0b789f5dd6a74b3b37927e7b44686","user":{"login":"koic","id":13203,"avatar_url":"https://avatars3.githubusercontent.com/u/13203?v=4","gravatar_id":"","url":"https://api.github.com/users/koic","html_url":"https://github.com/koic","followers_url":"https://api.github.com/users/koic/followers","following_url":"https://api.github.com/users/koic/following{/other_user}","gists_url":"https://api.github.com/users/koic/gists{/gist_id}","starred_url":"https://api.github.com/users/koic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koic/subscriptions","organizations_url":"https://api.github.com/users/koic/orgs","repos_url":"https://api.github.com/users/koic/repos","events_url":"https://api.github.com/users/koic/events{/privacy}","received_events_url":"https://api.github.com/users/koic/received_events","type":"User","site_admin":false},"repo":{"id":68358055,"name":"rubocop","full_name":"koic/rubocop","owner":{"login":"koic","id":13203,"avatar_url":"https://avatars3.githubusercontent.com/u/13203?v=4","gravatar_id":"","url":"https://api.github.com/users/koic","html_url":"https://github.com/koic","followers_url":"https://api.github.com/users/koic/followers","following_url":"https://api.github.com/users/koic/following{/other_user}","gists_url":"https://api.github.com/users/koic/gists{/gist_id}","starred_url":"https://api.github.com/users/koic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koic/subscriptions","organizations_url":"https://api.github.com/users/koic/orgs","repos_url":"https://api.github.com/users/koic/repos","events_url":"https://api.github.com/users/koic/events{/privacy}","received_events_url":"https://api.github.com/users/koic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koic/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/koic/rubocop","forks_url":"https://api.github.com/repos/koic/rubocop/forks","keys_url":"https://api.github.com/repos/koic/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koic/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koic/rubocop/teams","hooks_url":"https://api.github.com/repos/koic/rubocop/hooks","issue_events_url":"https://api.github.com/repos/koic/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/koic/rubocop/events","assignees_url":"https://api.github.com/repos/koic/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/koic/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/koic/rubocop/tags","blobs_url":"https://api.github.com/repos/koic/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koic/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koic/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/koic/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koic/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/koic/rubocop/languages","stargazers_url":"https://api.github.com/repos/koic/rubocop/stargazers","contributors_url":"https://api.github.com/repos/koic/rubocop/contributors","subscribers_url":"https://api.github.com/repos/koic/rubocop/subscribers","subscription_url":"https://api.github.com/repos/koic/rubocop/subscription","commits_url":"https://api.github.com/repos/koic/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/koic/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/koic/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/koic/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/koic/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/koic/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koic/rubocop/merges","archive_url":"https://api.github.com/repos/koic/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koic/rubocop/downloads","issues_url":"https://api.github.com/repos/koic/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/koic/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/koic/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/koic/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koic/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/koic/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/koic/rubocop/deployments","created_at":"2016-09-16T06:35:14Z","updated_at":"2016-09-16T06:35:17Z","pushed_at":"2018-03-01T04:00:27Z","git_url":"git://github.com/koic/rubocop.git","ssh_url":"git@github.com:koic/rubocop.git","clone_url":"https://github.com/koic/rubocop.git","svn_url":"https://github.com/koic/rubocop","homepage":"http://rubocop.readthedocs.io","size":20039,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"6c3ea4753bbb9f1ffb0f2ee60400fd0b432ede3f","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2018-03-01T03:40:55Z","pushed_at":"2018-02-28T21:22:22Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":20236,"stargazers_count":8760,"watchers_count":8760,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1659,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1659,"open_issues":316,"watchers":8760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/5618"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5618"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5618/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5618/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/e5fdf72c1da0b789f5dd6a74b3b37927e7b44686"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"koic"}}