{"action":"opened","number":1731,"pull_request":{"url":"https://api.github.com/repos/yt-project/yt/pulls/1731","id":175941441,"html_url":"https://github.com/yt-project/yt/pull/1731","diff_url":"https://github.com/yt-project/yt/pull/1731.diff","patch_url":"https://github.com/yt-project/yt/pull/1731.patch","issue_url":"https://api.github.com/repos/yt-project/yt/issues/1731","number":1731,"state":"open","locked":false,"title":"set default inset box arguments to None instead of {}","user":{"login":"ngoldbaum","id":3126246,"avatar_url":"https://avatars2.githubusercontent.com/u/3126246?v=4","gravatar_id":"","url":"https://api.github.com/users/ngoldbaum","html_url":"https://github.com/ngoldbaum","followers_url":"https://api.github.com/users/ngoldbaum/followers","following_url":"https://api.github.com/users/ngoldbaum/following{/other_user}","gists_url":"https://api.github.com/users/ngoldbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoldbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoldbaum/subscriptions","organizations_url":"https://api.github.com/users/ngoldbaum/orgs","repos_url":"https://api.github.com/users/ngoldbaum/repos","events_url":"https://api.github.com/users/ngoldbaum/events{/privacy}","received_events_url":"https://api.github.com/users/ngoldbaum/received_events","type":"User","site_admin":false},"body":"As reported on IRC by Josh Wall, currently when you do, e.g. something like this:\r\n\r\n```\r\nplot = yt.SlicePlot(ds, 2, 'density')\r\nplot.annotate_text((0, 0), 'text!', coord_system='plot')\r\nplot.save()\r\n```\r\n\r\nYou end up with a plot that has an inset box, even though the default `inset_box_args` is None. The problem is that `None` gets replaced by `{}` in the `TextLabelCallback`, which gets interpreted by matplotlib as \"please draw an inset box with the default arguments\".\r\n\r\nThe fix is not to replace the default `None` value with an empty dict.","created_at":"2018-03-19T15:46:16Z","updated_at":"2018-03-19T15:46:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yt-project/yt/pulls/1731/commits","review_comments_url":"https://api.github.com/repos/yt-project/yt/pulls/1731/comments","review_comment_url":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yt-project/yt/issues/1731/comments","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/02961936bc2c5106f06ed4af8ea03a7b2b04c9f1","head":{"label":"ngoldbaum:inset-box-fix","ref":"inset-box-fix","sha":"02961936bc2c5106f06ed4af8ea03a7b2b04c9f1","user":{"login":"ngoldbaum","id":3126246,"avatar_url":"https://avatars2.githubusercontent.com/u/3126246?v=4","gravatar_id":"","url":"https://api.github.com/users/ngoldbaum","html_url":"https://github.com/ngoldbaum","followers_url":"https://api.github.com/users/ngoldbaum/followers","following_url":"https://api.github.com/users/ngoldbaum/following{/other_user}","gists_url":"https://api.github.com/users/ngoldbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoldbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoldbaum/subscriptions","organizations_url":"https://api.github.com/users/ngoldbaum/orgs","repos_url":"https://api.github.com/users/ngoldbaum/repos","events_url":"https://api.github.com/users/ngoldbaum/events{/privacy}","received_events_url":"https://api.github.com/users/ngoldbaum/received_events","type":"User","site_admin":false},"repo":{"id":89933921,"name":"yt","full_name":"ngoldbaum/yt","owner":{"login":"ngoldbaum","id":3126246,"avatar_url":"https://avatars2.githubusercontent.com/u/3126246?v=4","gravatar_id":"","url":"https://api.github.com/users/ngoldbaum","html_url":"https://github.com/ngoldbaum","followers_url":"https://api.github.com/users/ngoldbaum/followers","following_url":"https://api.github.com/users/ngoldbaum/following{/other_user}","gists_url":"https://api.github.com/users/ngoldbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoldbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoldbaum/subscriptions","organizations_url":"https://api.github.com/users/ngoldbaum/orgs","repos_url":"https://api.github.com/users/ngoldbaum/repos","events_url":"https://api.github.com/users/ngoldbaum/events{/privacy}","received_events_url":"https://api.github.com/users/ngoldbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngoldbaum/yt","description":"Main yt repository","fork":true,"url":"https://api.github.com/repos/ngoldbaum/yt","forks_url":"https://api.github.com/repos/ngoldbaum/yt/forks","keys_url":"https://api.github.com/repos/ngoldbaum/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngoldbaum/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngoldbaum/yt/teams","hooks_url":"https://api.github.com/repos/ngoldbaum/yt/hooks","issue_events_url":"https://api.github.com/repos/ngoldbaum/yt/issues/events{/number}","events_url":"https://api.github.com/repos/ngoldbaum/yt/events","assignees_url":"https://api.github.com/repos/ngoldbaum/yt/assignees{/user}","branches_url":"https://api.github.com/repos/ngoldbaum/yt/branches{/branch}","tags_url":"https://api.github.com/repos/ngoldbaum/yt/tags","blobs_url":"https://api.github.com/repos/ngoldbaum/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngoldbaum/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngoldbaum/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngoldbaum/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngoldbaum/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/ngoldbaum/yt/languages","stargazers_url":"https://api.github.com/repos/ngoldbaum/yt/stargazers","contributors_url":"https://api.github.com/repos/ngoldbaum/yt/contributors","subscribers_url":"https://api.github.com/repos/ngoldbaum/yt/subscribers","subscription_url":"https://api.github.com/repos/ngoldbaum/yt/subscription","commits_url":"https://api.github.com/repos/ngoldbaum/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngoldbaum/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngoldbaum/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngoldbaum/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngoldbaum/yt/contents/{+path}","compare_url":"https://api.github.com/repos/ngoldbaum/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngoldbaum/yt/merges","archive_url":"https://api.github.com/repos/ngoldbaum/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngoldbaum/yt/downloads","issues_url":"https://api.github.com/repos/ngoldbaum/yt/issues{/number}","pulls_url":"https://api.github.com/repos/ngoldbaum/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/ngoldbaum/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/ngoldbaum/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngoldbaum/yt/labels{/name}","releases_url":"https://api.github.com/repos/ngoldbaum/yt/releases{/id}","deployments_url":"https://api.github.com/repos/ngoldbaum/yt/deployments","created_at":"2017-05-01T15:03:22Z","updated_at":"2018-03-19T15:41:28Z","pushed_at":"2018-03-19T15:42:37Z","git_url":"git://github.com/ngoldbaum/yt.git","ssh_url":"git@github.com:ngoldbaum/yt.git","clone_url":"https://github.com/ngoldbaum/yt.git","svn_url":"https://github.com/ngoldbaum/yt","homepage":"http://yt-project.org","size":266895,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yt-project:master","ref":"master","sha":"deacb518d38be90d0f41c08f4004b9e832566f3e","user":{"login":"yt-project","id":20566579,"avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"repo":{"id":88776493,"name":"yt","full_name":"yt-project/yt","owner":{"login":"yt-project","id":20566579,"avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yt-project/yt","description":"Main yt repository","fork":false,"url":"https://api.github.com/repos/yt-project/yt","forks_url":"https://api.github.com/repos/yt-project/yt/forks","keys_url":"https://api.github.com/repos/yt-project/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yt-project/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yt-project/yt/teams","hooks_url":"https://api.github.com/repos/yt-project/yt/hooks","issue_events_url":"https://api.github.com/repos/yt-project/yt/issues/events{/number}","events_url":"https://api.github.com/repos/yt-project/yt/events","assignees_url":"https://api.github.com/repos/yt-project/yt/assignees{/user}","branches_url":"https://api.github.com/repos/yt-project/yt/branches{/branch}","tags_url":"https://api.github.com/repos/yt-project/yt/tags","blobs_url":"https://api.github.com/repos/yt-project/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yt-project/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yt-project/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yt-project/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/yt-project/yt/languages","stargazers_url":"https://api.github.com/repos/yt-project/yt/stargazers","contributors_url":"https://api.github.com/repos/yt-project/yt/contributors","subscribers_url":"https://api.github.com/repos/yt-project/yt/subscribers","subscription_url":"https://api.github.com/repos/yt-project/yt/subscription","commits_url":"https://api.github.com/repos/yt-project/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yt-project/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yt-project/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yt-project/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yt-project/yt/contents/{+path}","compare_url":"https://api.github.com/repos/yt-project/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yt-project/yt/merges","archive_url":"https://api.github.com/repos/yt-project/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yt-project/yt/downloads","issues_url":"https://api.github.com/repos/yt-project/yt/issues{/number}","pulls_url":"https://api.github.com/repos/yt-project/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/yt-project/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/yt-project/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yt-project/yt/labels{/name}","releases_url":"https://api.github.com/repos/yt-project/yt/releases{/id}","deployments_url":"https://api.github.com/repos/yt-project/yt/deployments","created_at":"2017-04-19T18:16:11Z","updated_at":"2018-03-16T21:54:23Z","pushed_at":"2018-03-18T01:41:42Z","git_url":"git://github.com/yt-project/yt.git","ssh_url":"git@github.com:yt-project/yt.git","clone_url":"https://github.com/yt-project/yt.git","svn_url":"https://github.com/yt-project/yt","homepage":"http://yt-project.org","size":262773,"stargazers_count":100,"watchers_count":100,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":152,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":77,"open_issues":152,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1731"},"html":{"href":"https://github.com/yt-project/yt/pull/1731"},"issue":{"href":"https://api.github.com/repos/yt-project/yt/issues/1731"},"comments":{"href":"https://api.github.com/repos/yt-project/yt/issues/1731/comments"},"review_comments":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1731/comments"},"review_comment":{"href":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1731/commits"},"statuses":{"href":"https://api.github.com/repos/yt-project/yt/statuses/02961936bc2c5106f06ed4af8ea03a7b2b04c9f1"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ngoldbaum"}}