{"action":"created","comment":{"url":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments/230886560","pull_request_review_id":171727308,"id":230886560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDg4NjU2MA==","diff_hunk":"@@ -5,8 +5,15 @@ describe('aria-errormessage', function() {\n \tvar shadowSupported = axe.testUtils.shadowSupport.v1;\n \tvar shadowCheckSetup = axe.testUtils.shadowCheckSetup;\n \tvar checkContext = axe.testUtils.MockCheckContext();\n+\tvar attrData = Object.assign(\n+\t\t{},\n+\t\taxe.commons.aria.lookupTable.attributes['aria-errormessage']\n+\t);\n \n \tafterEach(function() {\n+\t\taxe.commons.aria.lookupTable.attributes[","path":"test/checks/aria/errormessage.js","position":10,"original_position":10,"commit_id":"cdf66410c3983541c8b3fe166eb2a4887f833837","original_commit_id":"cdf66410c3983541c8b3fe166eb2a4887f833837","user":{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false},"body":"Not that I know of.","created_at":"2018-11-05T19:44:58Z","updated_at":"2018-11-05T19:44:59Z","html_url":"https://github.com/dequelabs/axe-core/pull/1154#discussion_r230886560","pull_request_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments/230886560"},"html":{"href":"https://github.com/dequelabs/axe-core/pull/1154#discussion_r230886560"},"pull_request":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154"}},"in_reply_to_id":227061958},"pull_request":{"url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154","id":216956781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTU2Nzgx","html_url":"https://github.com/dequelabs/axe-core/pull/1154","diff_url":"https://github.com/dequelabs/axe-core/pull/1154.diff","patch_url":"https://github.com/dequelabs/axe-core/pull/1154.patch","issue_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1154","number":1154,"state":"open","locked":false,"title":"feat: Add allowEmpty option for aria-valid-attr-value","user":{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false},"body":"Allow specifying per ARIA attribute which ones are allowed to be empty. Changes include:\r\n- aria-haspopup: Now allowed to be empty\r\n- aria-invalid: Now allowed to be empty\r\n- aria-current: Now allowed to be empty\r\n- aria-valuetext: No longer allowed to be empty\r\n\r\nCloses #994\r\n\r\n## Reviewer checks\r\n\r\n**Required fields, to be filled out by PR reviewer(s)**\r\n- [x] Follows the commit message policy, appropriate for next version\r\n- [x] Has documentation updated, a DU ticket, or requires no documentation change\r\n- [x] Includes new tests, or was unnecessary\r\n- [x] Code is reviewed for security by: Jey\r\n","created_at":"2018-09-20T12:39:39Z","updated_at":"2018-11-05T19:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17e6ce0ca4a56c7e1efdbb74372b881470f8499d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154/commits","review_comments_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154/comments","review_comment_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1154/comments","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/cdf66410c3983541c8b3fe166eb2a4887f833837","head":{"label":"dequelabs:aria-allowEmpty","ref":"aria-allowEmpty","sha":"cdf66410c3983541c8b3fe166eb2a4887f833837","user":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37205440,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNTQ0MA==","name":"axe-core","full_name":"dequelabs/axe-core","private":false,"owner":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dequelabs/axe-core","description":"Accessibility engine for automated Web UI testing","fork":false,"url":"https://api.github.com/repos/dequelabs/axe-core","forks_url":"https://api.github.com/repos/dequelabs/axe-core/forks","keys_url":"https://api.github.com/repos/dequelabs/axe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dequelabs/axe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dequelabs/axe-core/teams","hooks_url":"https://api.github.com/repos/dequelabs/axe-core/hooks","issue_events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/events{/number}","events_url":"https://api.github.com/repos/dequelabs/axe-core/events","assignees_url":"https://api.github.com/repos/dequelabs/axe-core/assignees{/user}","branches_url":"https://api.github.com/repos/dequelabs/axe-core/branches{/branch}","tags_url":"https://api.github.com/repos/dequelabs/axe-core/tags","blobs_url":"https://api.github.com/repos/dequelabs/axe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dequelabs/axe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dequelabs/axe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dequelabs/axe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dequelabs/axe-core/languages","stargazers_url":"https://api.github.com/repos/dequelabs/axe-core/stargazers","contributors_url":"https://api.github.com/repos/dequelabs/axe-core/contributors","subscribers_url":"https://api.github.com/repos/dequelabs/axe-core/subscribers","subscription_url":"https://api.github.com/repos/dequelabs/axe-core/subscription","commits_url":"https://api.github.com/repos/dequelabs/axe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dequelabs/axe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dequelabs/axe-core/contents/{+path}","compare_url":"https://api.github.com/repos/dequelabs/axe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dequelabs/axe-core/merges","archive_url":"https://api.github.com/repos/dequelabs/axe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dequelabs/axe-core/downloads","issues_url":"https://api.github.com/repos/dequelabs/axe-core/issues{/number}","pulls_url":"https://api.github.com/repos/dequelabs/axe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dequelabs/axe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dequelabs/axe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dequelabs/axe-core/labels{/name}","releases_url":"https://api.github.com/repos/dequelabs/axe-core/releases{/id}","deployments_url":"https://api.github.com/repos/dequelabs/axe-core/deployments","created_at":"2015-06-10T15:26:45Z","updated_at":"2018-11-05T03:38:32Z","pushed_at":"2018-11-05T18:44:35Z","git_url":"git://github.com/dequelabs/axe-core.git","ssh_url":"git@github.com:dequelabs/axe-core.git","clone_url":"https://github.com/dequelabs/axe-core.git","svn_url":"https://github.com/dequelabs/axe-core","homepage":"https://www.deque.com/axe/","size":4909,"stargazers_count":1788,"watchers_count":1788,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":250,"open_issues":175,"watchers":1788,"default_branch":"develop"}},"base":{"label":"dequelabs:develop","ref":"develop","sha":"031f798d60a6617de3abd4b860d37abce5d66a14","user":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37205440,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNTQ0MA==","name":"axe-core","full_name":"dequelabs/axe-core","private":false,"owner":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dequelabs/axe-core","description":"Accessibility engine for automated Web UI testing","fork":false,"url":"https://api.github.com/repos/dequelabs/axe-core","forks_url":"https://api.github.com/repos/dequelabs/axe-core/forks","keys_url":"https://api.github.com/repos/dequelabs/axe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dequelabs/axe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dequelabs/axe-core/teams","hooks_url":"https://api.github.com/repos/dequelabs/axe-core/hooks","issue_events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/events{/number}","events_url":"https://api.github.com/repos/dequelabs/axe-core/events","assignees_url":"https://api.github.com/repos/dequelabs/axe-core/assignees{/user}","branches_url":"https://api.github.com/repos/dequelabs/axe-core/branches{/branch}","tags_url":"https://api.github.com/repos/dequelabs/axe-core/tags","blobs_url":"https://api.github.com/repos/dequelabs/axe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dequelabs/axe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dequelabs/axe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dequelabs/axe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dequelabs/axe-core/languages","stargazers_url":"https://api.github.com/repos/dequelabs/axe-core/stargazers","contributors_url":"https://api.github.com/repos/dequelabs/axe-core/contributors","subscribers_url":"https://api.github.com/repos/dequelabs/axe-core/subscribers","subscription_url":"https://api.github.com/repos/dequelabs/axe-core/subscription","commits_url":"https://api.github.com/repos/dequelabs/axe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dequelabs/axe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dequelabs/axe-core/contents/{+path}","compare_url":"https://api.github.com/repos/dequelabs/axe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dequelabs/axe-core/merges","archive_url":"https://api.github.com/repos/dequelabs/axe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dequelabs/axe-core/downloads","issues_url":"https://api.github.com/repos/dequelabs/axe-core/issues{/number}","pulls_url":"https://api.github.com/repos/dequelabs/axe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dequelabs/axe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dequelabs/axe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dequelabs/axe-core/labels{/name}","releases_url":"https://api.github.com/repos/dequelabs/axe-core/releases{/id}","deployments_url":"https://api.github.com/repos/dequelabs/axe-core/deployments","created_at":"2015-06-10T15:26:45Z","updated_at":"2018-11-05T03:38:32Z","pushed_at":"2018-11-05T18:44:35Z","git_url":"git://github.com/dequelabs/axe-core.git","ssh_url":"git@github.com:dequelabs/axe-core.git","clone_url":"https://github.com/dequelabs/axe-core.git","svn_url":"https://github.com/dequelabs/axe-core","homepage":"https://www.deque.com/axe/","size":4909,"stargazers_count":1788,"watchers_count":1788,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":250,"open_issues":175,"watchers":1788,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154"},"html":{"href":"https://github.com/dequelabs/axe-core/pull/1154"},"issue":{"href":"https://api.github.com/repos/dequelabs/axe-core/issues/1154"},"comments":{"href":"https://api.github.com/repos/dequelabs/axe-core/issues/1154/comments"},"review_comments":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154/comments"},"review_comment":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1154/commits"},"statuses":{"href":"https://api.github.com/repos/dequelabs/axe-core/statuses/cdf66410c3983541c8b3fe166eb2a4887f833837"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"WilcoFiers"}}