{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/238257532","pull_request_review_id":180751591,"id":238257532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODI1NzUzMg==","diff_hunk":"@@ -1088,6 +1088,15 @@ const clivalue_t valueTable[] = {\n     { \"osd_log_status_pos\",         VAR_UINT16  | MASTER_VALUE, .config.minmax = { 0, OSD_POSCFG_MAX }, PG_OSD_CONFIG, offsetof(osdConfig_t, item_pos[OSD_LOG_STATUS]) },\n #endif\n \n+#ifdef USE_OSD_STICK_OVERLAY\n+    { \"osd_stick_overlay_left\",      VAR_UINT16  | MASTER_VALUE, .config.minmax = { 0, OSD_POSCFG_MAX }, PG_OSD_CONFIG, offsetof(osdConfig_t, item_pos[OSD_STICK_OVERLAY_LEFT]) },\n+    { \"osd_stick_overlay_right\",     VAR_UINT16  | MASTER_VALUE, .config.minmax = { 0, OSD_POSCFG_MAX }, PG_OSD_CONFIG, offsetof(osdConfig_t, item_pos[OSD_STICK_OVERLAY_RIGHT]) },\n+    { \"osd_horizontal_char\",         VAR_UINT8   | MASTER_VALUE, .config.minmax = { 0, 255 }, PG_OSD_CONFIG, offsetof(osdConfig_t, overlay_horizontal_char) },","path":"src/main/interface/settings.c","position":7,"original_position":7,"commit_id":"7b004520b5cc5b4a71b48a10d7b80b06c976bdd9","original_commit_id":"cbb1963bf94b1d1ea4829edfd9aaa60a0fceb58f","user":{"login":"mikeller","id":4742747,"node_id":"MDQ6VXNlcjQ3NDI3NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4742747?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"body":"I still think we should not try to address this by introducing parameters for the characters to be used. How about this: We hardcode on '-', '|', and '+' for now, and start working on adding better glyphs to the fonts (there are unused characters available). Once we have the updated fonts published in configurator, we'll change the defines in the firmware for the glyphs to be used to use the new custom made ones?","created_at":"2018-12-03T12:56:47Z","updated_at":"2018-12-03T12:56:47Z","html_url":"https://github.com/betaflight/betaflight/pull/7167#discussion_r238257532","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/238257532"},"html":{"href":"https://github.com/betaflight/betaflight/pull/7167#discussion_r238257532"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7167"}},"in_reply_to_id":238199507},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/7167","id":235378308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mzc4MzA4","html_url":"https://github.com/betaflight/betaflight/pull/7167","diff_url":"https://github.com/betaflight/betaflight/pull/7167.diff","patch_url":"https://github.com/betaflight/betaflight/pull/7167.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/7167","number":7167,"state":"open","locked":false,"title":"Add stick overlays to OSD","user":{"login":"pkruger","id":1901127,"node_id":"MDQ6VXNlcjE5MDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1901127?v=4","gravatar_id":"","url":"https://api.github.com/users/pkruger","html_url":"https://github.com/pkruger","followers_url":"https://api.github.com/users/pkruger/followers","following_url":"https://api.github.com/users/pkruger/following{/other_user}","gists_url":"https://api.github.com/users/pkruger/gists{/gist_id}","starred_url":"https://api.github.com/users/pkruger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkruger/subscriptions","organizations_url":"https://api.github.com/users/pkruger/orgs","repos_url":"https://api.github.com/users/pkruger/repos","events_url":"https://api.github.com/users/pkruger/events{/privacy}","received_events_url":"https://api.github.com/users/pkruger/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T09:32:38Z","updated_at":"2018-12-03T12:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36da117ded079a1226c42388006894016cf845c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664780299,"node_id":"MDU6TGFiZWw2NjQ3ODAyOTk=","url":"https://api.github.com/repos/betaflight/betaflight/labels/RN:%20MINOR%20FEATURE","name":"RN: MINOR FEATURE","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/betaflight/betaflight/milestones/20","html_url":"https://github.com/betaflight/betaflight/milestone/20","labels_url":"https://api.github.com/repos/betaflight/betaflight/milestones/20/labels","id":3370188,"node_id":"MDk6TWlsZXN0b25lMzM3MDE4OA==","number":20,"title":"4.0","description":"","creator":{"login":"mikeller","id":4742747,"node_id":"MDQ6VXNlcjQ3NDI3NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4742747?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":240,"state":"open","created_at":"2018-05-23T21:17:48Z","updated_at":"2018-12-03T12:40:37Z","due_on":"2019-01-01T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7167/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7167/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/7167/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/7b004520b5cc5b4a71b48a10d7b80b06c976bdd9","head":{"label":"pkruger:3988-feature-add-sticks-verlay-to-in-flight-OSD","ref":"3988-feature-add-sticks-verlay-to-in-flight-OSD","sha":"7b004520b5cc5b4a71b48a10d7b80b06c976bdd9","user":{"login":"pkruger","id":1901127,"node_id":"MDQ6VXNlcjE5MDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1901127?v=4","gravatar_id":"","url":"https://api.github.com/users/pkruger","html_url":"https://github.com/pkruger","followers_url":"https://api.github.com/users/pkruger/followers","following_url":"https://api.github.com/users/pkruger/following{/other_user}","gists_url":"https://api.github.com/users/pkruger/gists{/gist_id}","starred_url":"https://api.github.com/users/pkruger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkruger/subscriptions","organizations_url":"https://api.github.com/users/pkruger/orgs","repos_url":"https://api.github.com/users/pkruger/repos","events_url":"https://api.github.com/users/pkruger/events{/privacy}","received_events_url":"https://api.github.com/users/pkruger/received_events","type":"User","site_admin":false},"repo":{"id":145848829,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NDg4Mjk=","name":"betaflight","full_name":"pkruger/betaflight","private":false,"owner":{"login":"pkruger","id":1901127,"node_id":"MDQ6VXNlcjE5MDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1901127?v=4","gravatar_id":"","url":"https://api.github.com/users/pkruger","html_url":"https://github.com/pkruger","followers_url":"https://api.github.com/users/pkruger/followers","following_url":"https://api.github.com/users/pkruger/following{/other_user}","gists_url":"https://api.github.com/users/pkruger/gists{/gist_id}","starred_url":"https://api.github.com/users/pkruger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkruger/subscriptions","organizations_url":"https://api.github.com/users/pkruger/orgs","repos_url":"https://api.github.com/users/pkruger/repos","events_url":"https://api.github.com/users/pkruger/events{/privacy}","received_events_url":"https://api.github.com/users/pkruger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pkruger/betaflight","description":"Open Source Flight Controller Firmware","fork":true,"url":"https://api.github.com/repos/pkruger/betaflight","forks_url":"https://api.github.com/repos/pkruger/betaflight/forks","keys_url":"https://api.github.com/repos/pkruger/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkruger/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkruger/betaflight/teams","hooks_url":"https://api.github.com/repos/pkruger/betaflight/hooks","issue_events_url":"https://api.github.com/repos/pkruger/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/pkruger/betaflight/events","assignees_url":"https://api.github.com/repos/pkruger/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/pkruger/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/pkruger/betaflight/tags","blobs_url":"https://api.github.com/repos/pkruger/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkruger/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkruger/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkruger/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkruger/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/pkruger/betaflight/languages","stargazers_url":"https://api.github.com/repos/pkruger/betaflight/stargazers","contributors_url":"https://api.github.com/repos/pkruger/betaflight/contributors","subscribers_url":"https://api.github.com/repos/pkruger/betaflight/subscribers","subscription_url":"https://api.github.com/repos/pkruger/betaflight/subscription","commits_url":"https://api.github.com/repos/pkruger/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkruger/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkruger/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkruger/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkruger/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/pkruger/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkruger/betaflight/merges","archive_url":"https://api.github.com/repos/pkruger/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkruger/betaflight/downloads","issues_url":"https://api.github.com/repos/pkruger/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/pkruger/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/pkruger/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/pkruger/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkruger/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/pkruger/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/pkruger/betaflight/deployments","created_at":"2018-08-23T12:13:44Z","updated_at":"2018-12-03T09:31:35Z","pushed_at":"2018-12-03T11:39:28Z","git_url":"git://github.com/pkruger/betaflight.git","ssh_url":"git@github.com:pkruger/betaflight.git","clone_url":"https://github.com/pkruger/betaflight.git","svn_url":"https://github.com/pkruger/betaflight","homepage":"","size":233584,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"76e3722a174aed77801274fbb6f58e90549e46f0","user":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA2MDg1Mg==","name":"betaflight","full_name":"betaflight/betaflight","private":false,"owner":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betaflight/betaflight","description":"Open Source Flight Controller Firmware","fork":false,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2018-12-03T10:33:16Z","pushed_at":"2018-12-03T12:40:38Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":233755,"stargazers_count":2242,"watchers_count":2242,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1080,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1080,"open_issues":197,"watchers":2242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7167"},"html":{"href":"https://github.com/betaflight/betaflight/pull/7167"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/7167"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/7167/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7167/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7167/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/7b004520b5cc5b4a71b48a10d7b80b06c976bdd9"}},"author_association":"NONE"}}
{"actor":{"display_login":"mikeller"}}