{"action":"created","comment":{"url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/comments/196660423","pull_request_review_id":130253756,"id":196660423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjY2MDQyMw==","diff_hunk":"@@ -8,6 +8,9 @@ module.exports = {\n \n   parserOptions: {\n     ecmaVersion: 2018,\n+    ecmaFeatures: {\n+      experimentalObjectRestSpread: true,","path":"index.js","position":5,"original_position":5,"commit_id":"c4f0820276bf6ba309c39dbb5d12f91236096701","original_commit_id":"c4f0820276bf6ba309c39dbb5d12f91236096701","user":{"login":"tdumitrescu","id":855881,"node_id":"MDQ6VXNlcjg1NTg4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/855881?v=4","gravatar_id":"","url":"https://api.github.com/users/tdumitrescu","html_url":"https://github.com/tdumitrescu","followers_url":"https://api.github.com/users/tdumitrescu/followers","following_url":"https://api.github.com/users/tdumitrescu/following{/other_user}","gists_url":"https://api.github.com/users/tdumitrescu/gists{/gist_id}","starred_url":"https://api.github.com/users/tdumitrescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdumitrescu/subscriptions","organizations_url":"https://api.github.com/users/tdumitrescu/orgs","repos_url":"https://api.github.com/users/tdumitrescu/repos","events_url":"https://api.github.com/users/tdumitrescu/events{/privacy}","received_events_url":"https://api.github.com/users/tdumitrescu/received_events","type":"User","site_admin":false},"body":"Looking at this now in context: are you sure you're running the right version of eslint? According to https://eslint.org/docs/user-guide/configuring#deprecated, \"This syntax has been supported in ecmaVersion: 2018. This option will be removed in the future.\" So with `ecmaVersion: 2018` on L10 above this should be unnecessary (and indeed we've been using this feature in a lot of places without linter complaints so far). @jalack I recall having had this conversation with you before, do you remember what the issue was?","created_at":"2018-06-20T06:28:49Z","updated_at":"2018-06-20T06:28:50Z","html_url":"https://github.com/mixpanel/eslint-config/pull/21#discussion_r196660423","pull_request_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/comments/196660423"},"html":{"href":"https://github.com/mixpanel/eslint-config/pull/21#discussion_r196660423"},"pull_request":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21","id":196016978,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDE2OTc4","html_url":"https://github.com/mixpanel/eslint-config/pull/21","diff_url":"https://github.com/mixpanel/eslint-config/pull/21.diff","patch_url":"https://github.com/mixpanel/eslint-config/pull/21.patch","issue_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/21","number":21,"state":"open","locked":false,"title":"Add support for object rest spread syntax","user":{"login":"themacguffinman","id":1560444,"node_id":"MDQ6VXNlcjE1NjA0NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1560444?v=4","gravatar_id":"","url":"https://api.github.com/users/themacguffinman","html_url":"https://github.com/themacguffinman","followers_url":"https://api.github.com/users/themacguffinman/followers","following_url":"https://api.github.com/users/themacguffinman/following{/other_user}","gists_url":"https://api.github.com/users/themacguffinman/gists{/gist_id}","starred_url":"https://api.github.com/users/themacguffinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themacguffinman/subscriptions","organizations_url":"https://api.github.com/users/themacguffinman/orgs","repos_url":"https://api.github.com/users/themacguffinman/repos","events_url":"https://api.github.com/users/themacguffinman/events{/privacy}","received_events_url":"https://api.github.com/users/themacguffinman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-20T04:07:44Z","updated_at":"2018-06-20T06:28:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b65c8413e99836a2421835d15f4e836f8eb7a79c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21/commits","review_comments_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21/comments","review_comment_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/21/comments","statuses_url":"https://api.github.com/repos/mixpanel/eslint-config/statuses/c4f0820276bf6ba309c39dbb5d12f91236096701","head":{"label":"mixpanel:jt-rest-spread","ref":"jt-rest-spread","sha":"c4f0820276bf6ba309c39dbb5d12f91236096701","user":{"login":"mixpanel","id":63653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjUz","avatar_url":"https://avatars2.githubusercontent.com/u/63653?v=4","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":65404874,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQwNDg3NA==","name":"eslint-config","full_name":"mixpanel/eslint-config","owner":{"login":"mixpanel","id":63653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjUz","avatar_url":"https://avatars2.githubusercontent.com/u/63653?v=4","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/eslint-config","description":"Mixpanel's JavaScript style.","fork":false,"url":"https://api.github.com/repos/mixpanel/eslint-config","forks_url":"https://api.github.com/repos/mixpanel/eslint-config/forks","keys_url":"https://api.github.com/repos/mixpanel/eslint-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/eslint-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/eslint-config/teams","hooks_url":"https://api.github.com/repos/mixpanel/eslint-config/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/eslint-config/events","assignees_url":"https://api.github.com/repos/mixpanel/eslint-config/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/eslint-config/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/eslint-config/tags","blobs_url":"https://api.github.com/repos/mixpanel/eslint-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/eslint-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/eslint-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/eslint-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/eslint-config/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/eslint-config/languages","stargazers_url":"https://api.github.com/repos/mixpanel/eslint-config/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/eslint-config/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/eslint-config/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/eslint-config/subscription","commits_url":"https://api.github.com/repos/mixpanel/eslint-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/eslint-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/eslint-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/eslint-config/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/eslint-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/eslint-config/merges","archive_url":"https://api.github.com/repos/mixpanel/eslint-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/eslint-config/downloads","issues_url":"https://api.github.com/repos/mixpanel/eslint-config/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/eslint-config/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/eslint-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/eslint-config/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/eslint-config/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/eslint-config/deployments","created_at":"2016-08-10T18:01:31Z","updated_at":"2018-05-17T00:29:33Z","pushed_at":"2018-06-20T04:07:45Z","git_url":"git://github.com/mixpanel/eslint-config.git","ssh_url":"git@github.com:mixpanel/eslint-config.git","clone_url":"https://github.com/mixpanel/eslint-config.git","svn_url":"https://github.com/mixpanel/eslint-config","homepage":"","size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mixpanel:master","ref":"master","sha":"3e8d380a511ba21860af208ddd9198a4b592295b","user":{"login":"mixpanel","id":63653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjUz","avatar_url":"https://avatars2.githubusercontent.com/u/63653?v=4","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":65404874,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQwNDg3NA==","name":"eslint-config","full_name":"mixpanel/eslint-config","owner":{"login":"mixpanel","id":63653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjUz","avatar_url":"https://avatars2.githubusercontent.com/u/63653?v=4","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/eslint-config","description":"Mixpanel's JavaScript style.","fork":false,"url":"https://api.github.com/repos/mixpanel/eslint-config","forks_url":"https://api.github.com/repos/mixpanel/eslint-config/forks","keys_url":"https://api.github.com/repos/mixpanel/eslint-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/eslint-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/eslint-config/teams","hooks_url":"https://api.github.com/repos/mixpanel/eslint-config/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/eslint-config/events","assignees_url":"https://api.github.com/repos/mixpanel/eslint-config/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/eslint-config/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/eslint-config/tags","blobs_url":"https://api.github.com/repos/mixpanel/eslint-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/eslint-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/eslint-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/eslint-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/eslint-config/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/eslint-config/languages","stargazers_url":"https://api.github.com/repos/mixpanel/eslint-config/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/eslint-config/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/eslint-config/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/eslint-config/subscription","commits_url":"https://api.github.com/repos/mixpanel/eslint-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/eslint-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/eslint-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/eslint-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/eslint-config/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/eslint-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/eslint-config/merges","archive_url":"https://api.github.com/repos/mixpanel/eslint-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/eslint-config/downloads","issues_url":"https://api.github.com/repos/mixpanel/eslint-config/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/eslint-config/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/eslint-config/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/eslint-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/eslint-config/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/eslint-config/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/eslint-config/deployments","created_at":"2016-08-10T18:01:31Z","updated_at":"2018-05-17T00:29:33Z","pushed_at":"2018-06-20T04:07:45Z","git_url":"git://github.com/mixpanel/eslint-config.git","ssh_url":"git@github.com:mixpanel/eslint-config.git","clone_url":"https://github.com/mixpanel/eslint-config.git","svn_url":"https://github.com/mixpanel/eslint-config","homepage":"","size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21"},"html":{"href":"https://github.com/mixpanel/eslint-config/pull/21"},"issue":{"href":"https://api.github.com/repos/mixpanel/eslint-config/issues/21"},"comments":{"href":"https://api.github.com/repos/mixpanel/eslint-config/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixpanel/eslint-config/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/mixpanel/eslint-config/statuses/c4f0820276bf6ba309c39dbb5d12f91236096701"}},"author_association":"NONE"}}
{"actor":{"display_login":"tdumitrescu"}}