{"action":"created","comment":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/comments/225213646","pull_request_review_id":164766264,"id":225213646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTIxMzY0Ng==","diff_hunk":"@@ -437,6 +437,46 @@ public function rebuildStoreCategoryIndexPage($storeId, $collectionDefault, $pag\n         }\n     }\n \n+    /**\n+     * Check if product can be index on Algolia\n+     *\n+     * @param Mage_Catalog_Model_Product $product\n+     * @param int     $storeId\n+     *\n+     * @return bool\n+     *\n+     */\n+    public function canProductBeReindexed(Mage_Catalog_Model_Product $product, $storeId)","path":"app/code/community/Algolia/Algoliasearch/Helper/Data.php","position":13,"original_position":13,"commit_id":"33c74d98c19a5c0c5c823372f84c84f2435d45ec","original_commit_id":"33c74d98c19a5c0c5c823372f84c84f2435d45ec","user":{"login":"bsuravech","id":7048136,"node_id":"MDQ6VXNlcjcwNDgxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7048136?v=4","gravatar_id":"","url":"https://api.github.com/users/bsuravech","html_url":"https://github.com/bsuravech","followers_url":"https://api.github.com/users/bsuravech/followers","following_url":"https://api.github.com/users/bsuravech/following{/other_user}","gists_url":"https://api.github.com/users/bsuravech/gists{/gist_id}","starred_url":"https://api.github.com/users/bsuravech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsuravech/subscriptions","organizations_url":"https://api.github.com/users/bsuravech/orgs","repos_url":"https://api.github.com/users/bsuravech/repos","events_url":"https://api.github.com/users/bsuravech/events{/privacy}","received_events_url":"https://api.github.com/users/bsuravech/received_events","type":"User","site_admin":false},"body":"We could move that over there! We should consider that as well for M2 feature if we want to keep it the same. ","created_at":"2018-10-15T15:35:57Z","updated_at":"2018-10-15T15:35:57Z","html_url":"https://github.com/algolia/algoliasearch-magento/pull/1061#discussion_r225213646","pull_request_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/comments/225213646"},"html":{"href":"https://github.com/algolia/algoliasearch-magento/pull/1061#discussion_r225213646"},"pull_request":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061"}},"in_reply_to_id":224824079},"pull_request":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061","id":222413001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDEzMDAx","html_url":"https://github.com/algolia/algoliasearch-magento/pull/1061","diff_url":"https://github.com/algolia/algoliasearch-magento/pull/1061.diff","patch_url":"https://github.com/algolia/algoliasearch-magento/pull/1061.patch","issue_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/1061","number":1061,"state":"open","locked":false,"title":"Reindex SKU(s) Feature ","user":{"login":"bsuravech","id":7048136,"node_id":"MDQ6VXNlcjcwNDgxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7048136?v=4","gravatar_id":"","url":"https://api.github.com/users/bsuravech","html_url":"https://github.com/bsuravech","followers_url":"https://api.github.com/users/bsuravech/followers","following_url":"https://api.github.com/users/bsuravech/following{/other_user}","gists_url":"https://api.github.com/users/bsuravech/gists{/gist_id}","starred_url":"https://api.github.com/users/bsuravech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsuravech/subscriptions","organizations_url":"https://api.github.com/users/bsuravech/orgs","repos_url":"https://api.github.com/users/bsuravech/repos","events_url":"https://api.github.com/users/bsuravech/events{/privacy}","received_events_url":"https://api.github.com/users/bsuravech/received_events","type":"User","site_admin":false},"body":"**Summary**\r\nBackport the M2 feature for Reindexing Product SKUs in admin. Changes to match:\r\nhttps://github.com/algolia/algoliasearch-magento-2/pull/536\r\n\r\n**Result**\r\n+ Adding new admin menu section for Algolia Search under System to include quick link to Algolia's system configuration section and to the reindex SKU(s) feature.  \r\n+ Adminhtml controller directory Algoliasearch has been added for proper url structure and in result updated queue controller links for notifications. \r\n+ ACL has been added for Reindex SKU feature.\r\n+ Created new exception classes to match M2 with update to UnknownSkuException to ProductUnknownSkuException naming. \r\n+ Updated reindexPostAction logic to load collection instead of loading products individually as best practice for optimisation. \r\n+ Updated parameter $skus filter to preg_split array_map('trim') array_filter (to knock out spacing and blank entries)\r\n+ Updated ProductNotVisibleException catch to not retry parent product in the catch handle but on the checkAndReindex() method to retry there (this is to prevent Exception Inception where if the parent product threw an error it won't throw a fatal error within the Exception catch)\r\n+ Added and updated canProductBeReindexed method in data helper to match M1 products requirements.","created_at":"2018-10-12T09:57:26Z","updated_at":"2018-10-15T15:35:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf93a78a8ffb31f7bea6cfd083ed7d8d1e7cb92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061/commits","review_comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061/comments","review_comment_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/1061/comments","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-magento/statuses/33c74d98c19a5c0c5c823372f84c84f2435d45ec","head":{"label":"algolia:admin-reindex-sku","ref":"admin-reindex-sku","sha":"33c74d98c19a5c0c5c823372f84c84f2435d45ec","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":16968096,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk2ODA5Ng==","name":"algoliasearch-magento","full_name":"algolia/algoliasearch-magento","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/algoliasearch-magento","description":"Algolia Search integration for Magento 1.6+","fork":false,"url":"https://api.github.com/repos/algolia/algoliasearch-magento","forks_url":"https://api.github.com/repos/algolia/algoliasearch-magento/forks","keys_url":"https://api.github.com/repos/algolia/algoliasearch-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/algoliasearch-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/algoliasearch-magento/teams","hooks_url":"https://api.github.com/repos/algolia/algoliasearch-magento/hooks","issue_events_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/algoliasearch-magento/events","assignees_url":"https://api.github.com/repos/algolia/algoliasearch-magento/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/algoliasearch-magento/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento/tags","blobs_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/algoliasearch-magento/languages","stargazers_url":"https://api.github.com/repos/algolia/algoliasearch-magento/stargazers","contributors_url":"https://api.github.com/repos/algolia/algoliasearch-magento/contributors","subscribers_url":"https://api.github.com/repos/algolia/algoliasearch-magento/subscribers","subscription_url":"https://api.github.com/repos/algolia/algoliasearch-magento/subscription","commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/algoliasearch-magento/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/algoliasearch-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/algoliasearch-magento/merges","archive_url":"https://api.github.com/repos/algolia/algoliasearch-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/algoliasearch-magento/downloads","issues_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/algoliasearch-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/algoliasearch-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/algoliasearch-magento/labels{/name}","releases_url":"https://api.github.com/repos/algolia/algoliasearch-magento/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/deployments","created_at":"2014-02-18T23:49:42Z","updated_at":"2018-10-09T03:34:10Z","pushed_at":"2018-10-12T09:57:26Z","git_url":"git://github.com/algolia/algoliasearch-magento.git","ssh_url":"git@github.com:algolia/algoliasearch-magento.git","clone_url":"https://github.com/algolia/algoliasearch-magento.git","svn_url":"https://github.com/algolia/algoliasearch-magento","homepage":"https://community.algolia.com/magento","size":92473,"stargazers_count":150,"watchers_count":150,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":103,"open_issues":20,"watchers":150,"default_branch":"master"}},"base":{"label":"algolia:develop","ref":"develop","sha":"81bcce43948ecce3a2f0b589e0ffce5e3074fd27","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":16968096,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk2ODA5Ng==","name":"algoliasearch-magento","full_name":"algolia/algoliasearch-magento","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/algoliasearch-magento","description":"Algolia Search integration for Magento 1.6+","fork":false,"url":"https://api.github.com/repos/algolia/algoliasearch-magento","forks_url":"https://api.github.com/repos/algolia/algoliasearch-magento/forks","keys_url":"https://api.github.com/repos/algolia/algoliasearch-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/algoliasearch-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/algoliasearch-magento/teams","hooks_url":"https://api.github.com/repos/algolia/algoliasearch-magento/hooks","issue_events_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/algoliasearch-magento/events","assignees_url":"https://api.github.com/repos/algolia/algoliasearch-magento/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/algoliasearch-magento/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento/tags","blobs_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/algoliasearch-magento/languages","stargazers_url":"https://api.github.com/repos/algolia/algoliasearch-magento/stargazers","contributors_url":"https://api.github.com/repos/algolia/algoliasearch-magento/contributors","subscribers_url":"https://api.github.com/repos/algolia/algoliasearch-magento/subscribers","subscription_url":"https://api.github.com/repos/algolia/algoliasearch-magento/subscription","commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/algoliasearch-magento/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/algoliasearch-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/algoliasearch-magento/merges","archive_url":"https://api.github.com/repos/algolia/algoliasearch-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/algoliasearch-magento/downloads","issues_url":"https://api.github.com/repos/algolia/algoliasearch-magento/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/algoliasearch-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/algoliasearch-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/algoliasearch-magento/labels{/name}","releases_url":"https://api.github.com/repos/algolia/algoliasearch-magento/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/algoliasearch-magento/deployments","created_at":"2014-02-18T23:49:42Z","updated_at":"2018-10-09T03:34:10Z","pushed_at":"2018-10-12T09:57:26Z","git_url":"git://github.com/algolia/algoliasearch-magento.git","ssh_url":"git@github.com:algolia/algoliasearch-magento.git","clone_url":"https://github.com/algolia/algoliasearch-magento.git","svn_url":"https://github.com/algolia/algoliasearch-magento","homepage":"https://community.algolia.com/magento","size":92473,"stargazers_count":150,"watchers_count":150,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":103,"open_issues":20,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061"},"html":{"href":"https://github.com/algolia/algoliasearch-magento/pull/1061"},"issue":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/1061"},"comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/issues/1061/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/pulls/1061/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento/statuses/33c74d98c19a5c0c5c823372f84c84f2435d45ec"}},"author_association":"NONE"}}
{"actor":{"display_login":"bsuravech"}}