{"action":"created","issue":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1321","repository_url":"https://api.github.com/repos/boutproject/BOUT-dev","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1321/labels{/name}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1321/comments","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1321/events","html_url":"https://github.com/boutproject/BOUT-dev/pull/1321","id":369836561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjcyNjk3","number":1321,"title":"Deprecate mergeYupYdown(), rename splitYupYdown() to createYupYdown()","user":{"login":"johnomotani","id":3958036,"node_id":"MDQ6VXNlcjM5NTgwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3958036?v=4","gravatar_id":"","url":"https://api.github.com/users/johnomotani","html_url":"https://github.com/johnomotani","followers_url":"https://api.github.com/users/johnomotani/followers","following_url":"https://api.github.com/users/johnomotani/following{/other_user}","gists_url":"https://api.github.com/users/johnomotani/gists{/gist_id}","starred_url":"https://api.github.com/users/johnomotani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnomotani/subscriptions","organizations_url":"https://api.github.com/users/johnomotani/orgs","repos_url":"https://api.github.com/users/johnomotani/repos","events_url":"https://api.github.com/users/johnomotani/events{/privacy}","received_events_url":"https://api.github.com/users/johnomotani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-13T20:08:22Z","updated_at":"2018-10-15T12:36:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1321","html_url":"https://github.com/boutproject/BOUT-dev/pull/1321","diff_url":"https://github.com/boutproject/BOUT-dev/pull/1321.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/1321.patch"},"body":"splitYupYdown() is still present, but also deprecated.\r\n\r\nThese are deprecated so we can remove them in v4.3, see PR #1287.\r\n\r\nMoving ParalllelTransformIdentity::calcYupYdown() to a .cxx file, because otherwise 'make' gets noisy due to paralleltransform.hxx being included in most files."},"comment":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments/429836441","html_url":"https://github.com/boutproject/BOUT-dev/pull/1321#issuecomment-429836441","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1321","id":429836441,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTgzNjQ0MQ==","user":{"login":"ZedThree","id":1486942,"node_id":"MDQ6VXNlcjE0ODY5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1486942?v=4","gravatar_id":"","url":"https://api.github.com/users/ZedThree","html_url":"https://github.com/ZedThree","followers_url":"https://api.github.com/users/ZedThree/followers","following_url":"https://api.github.com/users/ZedThree/following{/other_user}","gists_url":"https://api.github.com/users/ZedThree/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedThree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedThree/subscriptions","organizations_url":"https://api.github.com/users/ZedThree/orgs","repos_url":"https://api.github.com/users/ZedThree/repos","events_url":"https://api.github.com/users/ZedThree/events{/privacy}","received_events_url":"https://api.github.com/users/ZedThree/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T12:36:30Z","updated_at":"2018-10-15T12:36:30Z","author_association":"CONTRIBUTOR","body":"After a bit more thinking and some discussion with @d7919, I think this is hiding the real issue which is that we still haven't implemented multiple yup fields.\r\n\r\nIf we handle the identity transform using the field-aligned branches, we'll be doing two unnecessary copies each time (although copy-on-write will reduce the pain of this a lot).\r\n\r\nSorting out the multiple yup fields should be a priority for 4.3.\r\n"}}
{"actor":{"display_login":"ZedThree"}}