{"action":"closed","number":1546,"pull_request":{"url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546","id":236644804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NjQ0ODA0","html_url":"https://github.com/cds-snc/vac-benefits-directory/pull/1546","diff_url":"https://github.com/cds-snc/vac-benefits-directory/pull/1546.diff","patch_url":"https://github.com/cds-snc/vac-benefits-directory/pull/1546.patch","issue_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/1546","number":1546,"state":"closed","locked":false,"title":"GE Edit navigation","user":{"login":"smcmurtry","id":5498428,"node_id":"MDQ6VXNlcjU0OTg0Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/5498428?v=4","gravatar_id":"","url":"https://api.github.com/users/smcmurtry","html_url":"https://github.com/smcmurtry","followers_url":"https://api.github.com/users/smcmurtry/followers","following_url":"https://api.github.com/users/smcmurtry/following{/other_user}","gists_url":"https://api.github.com/users/smcmurtry/gists{/gist_id}","starred_url":"https://api.github.com/users/smcmurtry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcmurtry/subscriptions","organizations_url":"https://api.github.com/users/smcmurtry/orgs","repos_url":"https://api.github.com/users/smcmurtry/repos","events_url":"https://api.github.com/users/smcmurtry/events{/privacy}","received_events_url":"https://api.github.com/users/smcmurtry/received_events","type":"User","site_admin":false},"body":"Closes #1529 \r\n\r\nI changed the clear questions behaviour so that only un-displayable questions are cleared (whenever you click back/next/skip). This prevents bad eligibility paths from being saved in redux. This now happens by modifying the url that is navigated to, by getting query params for questions we want to clear, then adding in the existing logic on top of that. Convoluted but I think it works.","created_at":"2018-12-06T19:28:48Z","updated_at":"2018-12-06T20:01:20Z","closed_at":"2018-12-06T20:01:19Z","merged_at":"2018-12-06T20:01:19Z","merge_commit_sha":"43afac94a899a7baee5c59a9d3a9db22a49988a3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brdunfield","id":5032149,"node_id":"MDQ6VXNlcjUwMzIxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5032149?v=4","gravatar_id":"","url":"https://api.github.com/users/brdunfield","html_url":"https://github.com/brdunfield","followers_url":"https://api.github.com/users/brdunfield/followers","following_url":"https://api.github.com/users/brdunfield/following{/other_user}","gists_url":"https://api.github.com/users/brdunfield/gists{/gist_id}","starred_url":"https://api.github.com/users/brdunfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brdunfield/subscriptions","organizations_url":"https://api.github.com/users/brdunfield/orgs","repos_url":"https://api.github.com/users/brdunfield/repos","events_url":"https://api.github.com/users/brdunfield/events{/privacy}","received_events_url":"https://api.github.com/users/brdunfield/received_events","type":"User","site_admin":false},{"login":"sastels","id":8228248,"node_id":"MDQ6VXNlcjgyMjgyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8228248?v=4","gravatar_id":"","url":"https://api.github.com/users/sastels","html_url":"https://github.com/sastels","followers_url":"https://api.github.com/users/sastels/followers","following_url":"https://api.github.com/users/sastels/following{/other_user}","gists_url":"https://api.github.com/users/sastels/gists{/gist_id}","starred_url":"https://api.github.com/users/sastels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sastels/subscriptions","organizations_url":"https://api.github.com/users/sastels/orgs","repos_url":"https://api.github.com/users/sastels/repos","events_url":"https://api.github.com/users/sastels/events{/privacy}","received_events_url":"https://api.github.com/users/sastels/received_events","type":"User","site_admin":false},{"login":"SupeDeDupe","id":17673146,"node_id":"MDQ6VXNlcjE3NjczMTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/17673146?v=4","gravatar_id":"","url":"https://api.github.com/users/SupeDeDupe","html_url":"https://github.com/SupeDeDupe","followers_url":"https://api.github.com/users/SupeDeDupe/followers","following_url":"https://api.github.com/users/SupeDeDupe/following{/other_user}","gists_url":"https://api.github.com/users/SupeDeDupe/gists{/gist_id}","starred_url":"https://api.github.com/users/SupeDeDupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SupeDeDupe/subscriptions","organizations_url":"https://api.github.com/users/SupeDeDupe/orgs","repos_url":"https://api.github.com/users/SupeDeDupe/repos","events_url":"https://api.github.com/users/SupeDeDupe/events{/privacy}","received_events_url":"https://api.github.com/users/SupeDeDupe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/1546/comments","statuses_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/statuses/6d5a79414f8ea631ebf55f5bd46367375324be1f","head":{"label":"cds-snc:ge_edit_nav","ref":"ge_edit_nav","sha":"6d5a79414f8ea631ebf55f5bd46367375324be1f","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":127031604,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzE2MDQ=","name":"vac-benefits-directory","full_name":"cds-snc/vac-benefits-directory","private":false,"owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cds-snc/vac-benefits-directory","description":"VAC project proof of concept","fork":false,"url":"https://api.github.com/repos/cds-snc/vac-benefits-directory","forks_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/forks","keys_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/teams","hooks_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/events","assignees_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/tags","blobs_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/languages","stargazers_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/subscription","commits_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/merges","archive_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/downloads","issues_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/deployments","created_at":"2018-03-27T18:47:50Z","updated_at":"2018-12-06T19:29:47Z","pushed_at":"2018-12-06T20:01:19Z","git_url":"git://github.com/cds-snc/vac-benefits-directory.git","ssh_url":"git@github.com:cds-snc/vac-benefits-directory.git","clone_url":"https://github.com/cds-snc/vac-benefits-directory.git","svn_url":"https://github.com/cds-snc/vac-benefits-directory","homepage":"https://vac-benefits-finder.cds-snc.ca/","size":2999,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":56,"watchers":7,"default_branch":"master"}},"base":{"label":"cds-snc:master","ref":"master","sha":"7973f017eac70b83eda24c54c06a07db24bc1dcf","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":127031604,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzE2MDQ=","name":"vac-benefits-directory","full_name":"cds-snc/vac-benefits-directory","private":false,"owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cds-snc/vac-benefits-directory","description":"VAC project proof of concept","fork":false,"url":"https://api.github.com/repos/cds-snc/vac-benefits-directory","forks_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/forks","keys_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/teams","hooks_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/events","assignees_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/tags","blobs_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/languages","stargazers_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/subscription","commits_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/merges","archive_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/downloads","issues_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/vac-benefits-directory/deployments","created_at":"2018-03-27T18:47:50Z","updated_at":"2018-12-06T19:29:47Z","pushed_at":"2018-12-06T20:01:19Z","git_url":"git://github.com/cds-snc/vac-benefits-directory.git","ssh_url":"git@github.com:cds-snc/vac-benefits-directory.git","clone_url":"https://github.com/cds-snc/vac-benefits-directory.git","svn_url":"https://github.com/cds-snc/vac-benefits-directory","homepage":"https://vac-benefits-finder.cds-snc.ca/","size":2999,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":56,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546"},"html":{"href":"https://github.com/cds-snc/vac-benefits-directory/pull/1546"},"issue":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/1546"},"comments":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/cds-snc/vac-benefits-directory/statuses/6d5a79414f8ea631ebf55f5bd46367375324be1f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"smcmurtry","id":5498428,"node_id":"MDQ6VXNlcjU0OTg0Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/5498428?v=4","gravatar_id":"","url":"https://api.github.com/users/smcmurtry","html_url":"https://github.com/smcmurtry","followers_url":"https://api.github.com/users/smcmurtry/followers","following_url":"https://api.github.com/users/smcmurtry/following{/other_user}","gists_url":"https://api.github.com/users/smcmurtry/gists{/gist_id}","starred_url":"https://api.github.com/users/smcmurtry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcmurtry/subscriptions","organizations_url":"https://api.github.com/users/smcmurtry/orgs","repos_url":"https://api.github.com/users/smcmurtry/repos","events_url":"https://api.github.com/users/smcmurtry/events{/privacy}","received_events_url":"https://api.github.com/users/smcmurtry/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":63,"deletions":63,"changed_files":4}}
{"actor":{"display_login":"smcmurtry"}}