{"action":"created","issue":{"url":"https://api.github.com/repos/rscada/libmbus/issues/133","repository_url":"https://api.github.com/repos/rscada/libmbus","labels_url":"https://api.github.com/repos/rscada/libmbus/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/rscada/libmbus/issues/133/comments","events_url":"https://api.github.com/repos/rscada/libmbus/issues/133/events","html_url":"https://github.com/rscada/libmbus/pull/133","id":304299765,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc0MzE0NjYy","number":133,"title":"WIP/RequestForFeedback/Discussion PR to add MSVC build capability","user":{"login":"Apollon77","id":11976694,"node_id":"MDQ6VXNlcjExOTc2Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/11976694?v=4","gravatar_id":"","url":"https://api.github.com/users/Apollon77","html_url":"https://github.com/Apollon77","followers_url":"https://api.github.com/users/Apollon77/followers","following_url":"https://api.github.com/users/Apollon77/following{/other_user}","gists_url":"https://api.github.com/users/Apollon77/gists{/gist_id}","starred_url":"https://api.github.com/users/Apollon77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apollon77/subscriptions","organizations_url":"https://api.github.com/users/Apollon77/orgs","repos_url":"https://api.github.com/users/Apollon77/repos","events_url":"https://api.github.com/users/Apollon77/events{/privacy}","received_events_url":"https://api.github.com/users/Apollon77/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-12T09:42:45Z","updated_at":"2018-07-17T11:15:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rscada/libmbus/pulls/133","html_url":"https://github.com/rscada/libmbus/pull/133","diff_url":"https://github.com/rscada/libmbus/pull/133.diff","patch_url":"https://github.com/rscada/libmbus/pull/133.patch"},"body":"Hi,\r\n\r\nthis PR is not really for \"accepting\" but to start a feedback/discussion/enhancement round :-)\r\nI hope this is ok.\r\n\r\nWhile working on my nodejs native module for libmbus (https://github.com/Apollon77/node-mbus) I also started liiking into windows build capability and I managed to get it build on windows (currently the lib only, but adding the executables should be no big deal if someone knows how :-))\r\n\r\nI did the following (and those are the changes in this PR):\r\n* content of my PR #132 is in too (so mainly timestamp and build/config changes)\r\n* added appveyor testing for build (result see: https://ci.appveyor.com/project/Apollon77/libmbus)\r\n* added very basic (and to be honest from node-gyp creates-stripped-down) vcxproj file to build library. SO here is work to be done by ideally someone with MSVC knowledge\r\n* defined  __PRETTY_FUNCTION__ in all files when Windows build\r\n* main changes in mbus-serial and mbus-tcp mostly in includes at the beginning \r\n* especially for serial stuff I added a compat layer for termios.h (termiWin), found https://github.com/ChristianVisintin/termiWin which helped a lot. Alternative would be an own \"mbus-erial-windows\" :-)\r\n* during real tests and also from other repos adjusted default timeout settings for serial because some real-life devices need time to respond\r\n* smaller logging enhancements that were useful during debug/development\r\n\r\nWith these changes I was able to work with Serial and TCP on Windows too and I use this branch in my nodejs native module already.\r\n\r\nIt would be great to get feedback from you on this ... Especially about what your opinion if for Win support and such :-)\r\n\r\nIngo"},"comment":{"url":"https://api.github.com/repos/rscada/libmbus/issues/comments/405546937","html_url":"https://github.com/rscada/libmbus/pull/133#issuecomment-405546937","issue_url":"https://api.github.com/repos/rscada/libmbus/issues/133","id":405546937,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTU0NjkzNw==","user":{"login":"sympthom","id":11585226,"node_id":"MDQ6VXNlcjExNTg1MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/11585226?v=4","gravatar_id":"","url":"https://api.github.com/users/sympthom","html_url":"https://github.com/sympthom","followers_url":"https://api.github.com/users/sympthom/followers","following_url":"https://api.github.com/users/sympthom/following{/other_user}","gists_url":"https://api.github.com/users/sympthom/gists{/gist_id}","starred_url":"https://api.github.com/users/sympthom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympthom/subscriptions","organizations_url":"https://api.github.com/users/sympthom/orgs","repos_url":"https://api.github.com/users/sympthom/repos","events_url":"https://api.github.com/users/sympthom/events{/privacy}","received_events_url":"https://api.github.com/users/sympthom/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T11:15:43Z","updated_at":"2018-07-17T11:15:43Z","author_association":"NONE","body":"Great work on the port to Windows! Fingers crossed. :)"}}
{"actor":{"display_login":"sympthom"}}