{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/comments/231703417","pull_request_review_id":172730959,"id":231703417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTcwMzQxNw==","diff_hunk":"@@ -771,6 +772,21 @@ systemCallMethods.waitForDevice = async function (appDeviceReadyTimeout = 30) {\n   });\n };\n \n+systemCallMethods.privilegedShell = async function (args) {","path":"lib/tools/system-calls.js","position":12,"original_position":12,"commit_id":"de90e455fd6ca9d5347f2d19da5be88ffa63b7a9","original_commit_id":"de90e455fd6ca9d5347f2d19da5be88ffa63b7a9","user":{"login":"jlipps","id":605053,"node_id":"MDQ6VXNlcjYwNTA1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/605053?v=4","gravatar_id":"","url":"https://api.github.com/users/jlipps","html_url":"https://github.com/jlipps","followers_url":"https://api.github.com/users/jlipps/followers","following_url":"https://api.github.com/users/jlipps/following{/other_user}","gists_url":"https://api.github.com/users/jlipps/gists{/gist_id}","starred_url":"https://api.github.com/users/jlipps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlipps/subscriptions","organizations_url":"https://api.github.com/users/jlipps/orgs","repos_url":"https://api.github.com/users/jlipps/repos","events_url":"https://api.github.com/users/jlipps/events{/privacy}","received_events_url":"https://api.github.com/users/jlipps/received_events","type":"User","site_admin":false},"body":"maybe `elevateShellPrivileges` or similar?","created_at":"2018-11-07T22:31:13Z","updated_at":"2018-11-07T22:31:16Z","html_url":"https://github.com/appium/appium-adb/pull/376#discussion_r231703417","pull_request_url":"https://api.github.com/repos/appium/appium-adb/pulls/376","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments/231703417"},"html":{"href":"https://github.com/appium/appium-adb/pull/376#discussion_r231703417"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/376"}},"in_reply_to_id":231694117},"pull_request":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/376","id":228836532,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODM2NTMy","html_url":"https://github.com/appium/appium-adb/pull/376","diff_url":"https://github.com/appium/appium-adb/pull/376.diff","patch_url":"https://github.com/appium/appium-adb/pull/376.patch","issue_url":"https://api.github.com/repos/appium/appium-adb/issues/376","number":376,"state":"open","locked":false,"title":"Fix reboot for Android O","user":{"login":"vrunoa","id":329957,"node_id":"MDQ6VXNlcjMyOTk1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/329957?v=4","gravatar_id":"","url":"https://api.github.com/users/vrunoa","html_url":"https://github.com/vrunoa","followers_url":"https://api.github.com/users/vrunoa/followers","following_url":"https://api.github.com/users/vrunoa/following{/other_user}","gists_url":"https://api.github.com/users/vrunoa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrunoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrunoa/subscriptions","organizations_url":"https://api.github.com/users/vrunoa/orgs","repos_url":"https://api.github.com/users/vrunoa/repos","events_url":"https://api.github.com/users/vrunoa/events{/privacy}","received_events_url":"https://api.github.com/users/vrunoa/received_events","type":"User","site_admin":false},"body":"In Android O emulators reboot it's failing due to root issues. \r\n\r\n```bash\r\nError: Error executing adbExec. Original error: 'Command '/mnt/android/android-sdk-linux/platform-tools/adb -P 5037 shell start' exited with code 1'; Stderr: 'start: must be root'; Code: '1'\r\n    Error: Error executing adbExec. Original error: 'Command '/mnt/android/android-sdk-linux/platform-tools/adb -P 5037 shell start' exited with code 1'; Stderr: 'start: must be root'; Code: '1'\r\n2018/11/06 16:43:53 ui:     at ADB.execFunc$ (/tmp/chromeInstaller/node_modules/appium-adb/lib/tools/system-calls.js:317:13)\r\n ```\r\n\r\nAdding root before calling shell starts fixes the issue. ","created_at":"2018-11-06T21:14:03Z","updated_at":"2018-11-07T22:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71f8072c514feaee1016bb4eda75e8eaebb99b6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-adb/pulls/376/commits","review_comments_url":"https://api.github.com/repos/appium/appium-adb/pulls/376/comments","review_comment_url":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-adb/issues/376/comments","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/de90e455fd6ca9d5347f2d19da5be88ffa63b7a9","head":{"label":"vrunoa:fix-reboot-android-o","ref":"fix-reboot-android-o","sha":"de90e455fd6ca9d5347f2d19da5be88ffa63b7a9","user":{"login":"vrunoa","id":329957,"node_id":"MDQ6VXNlcjMyOTk1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/329957?v=4","gravatar_id":"","url":"https://api.github.com/users/vrunoa","html_url":"https://github.com/vrunoa","followers_url":"https://api.github.com/users/vrunoa/followers","following_url":"https://api.github.com/users/vrunoa/following{/other_user}","gists_url":"https://api.github.com/users/vrunoa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrunoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrunoa/subscriptions","organizations_url":"https://api.github.com/users/vrunoa/orgs","repos_url":"https://api.github.com/users/vrunoa/repos","events_url":"https://api.github.com/users/vrunoa/events{/privacy}","received_events_url":"https://api.github.com/users/vrunoa/received_events","type":"User","site_admin":false},"repo":{"id":53951106,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk1MTEwNg==","name":"appium-adb","full_name":"vrunoa/appium-adb","private":false,"owner":{"login":"vrunoa","id":329957,"node_id":"MDQ6VXNlcjMyOTk1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/329957?v=4","gravatar_id":"","url":"https://api.github.com/users/vrunoa","html_url":"https://github.com/vrunoa","followers_url":"https://api.github.com/users/vrunoa/followers","following_url":"https://api.github.com/users/vrunoa/following{/other_user}","gists_url":"https://api.github.com/users/vrunoa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrunoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrunoa/subscriptions","organizations_url":"https://api.github.com/users/vrunoa/orgs","repos_url":"https://api.github.com/users/vrunoa/repos","events_url":"https://api.github.com/users/vrunoa/events{/privacy}","received_events_url":"https://api.github.com/users/vrunoa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vrunoa/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":true,"url":"https://api.github.com/repos/vrunoa/appium-adb","forks_url":"https://api.github.com/repos/vrunoa/appium-adb/forks","keys_url":"https://api.github.com/repos/vrunoa/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrunoa/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrunoa/appium-adb/teams","hooks_url":"https://api.github.com/repos/vrunoa/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/vrunoa/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/vrunoa/appium-adb/events","assignees_url":"https://api.github.com/repos/vrunoa/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/vrunoa/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/vrunoa/appium-adb/tags","blobs_url":"https://api.github.com/repos/vrunoa/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrunoa/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrunoa/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrunoa/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrunoa/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/vrunoa/appium-adb/languages","stargazers_url":"https://api.github.com/repos/vrunoa/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/vrunoa/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/vrunoa/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/vrunoa/appium-adb/subscription","commits_url":"https://api.github.com/repos/vrunoa/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrunoa/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrunoa/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrunoa/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrunoa/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/vrunoa/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrunoa/appium-adb/merges","archive_url":"https://api.github.com/repos/vrunoa/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrunoa/appium-adb/downloads","issues_url":"https://api.github.com/repos/vrunoa/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/vrunoa/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/vrunoa/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/vrunoa/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrunoa/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/vrunoa/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/vrunoa/appium-adb/deployments","created_at":"2016-03-15T14:26:54Z","updated_at":"2016-03-15T14:26:56Z","pushed_at":"2018-11-07T21:34:00Z","git_url":"git://github.com/vrunoa/appium-adb.git","ssh_url":"git@github.com:vrunoa/appium-adb.git","clone_url":"https://github.com/vrunoa/appium-adb.git","svn_url":"https://github.com/vrunoa/appium-adb","homepage":null,"size":31196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"7ab6c017c508eaf12c3184229f19868111f5500a","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":17339088,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMzOTA4OA==","name":"appium-adb","full_name":"appium/appium-adb","private":false,"owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appium/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":false,"url":"https://api.github.com/repos/appium/appium-adb","forks_url":"https://api.github.com/repos/appium/appium-adb/forks","keys_url":"https://api.github.com/repos/appium/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-adb/teams","hooks_url":"https://api.github.com/repos/appium/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-adb/events","assignees_url":"https://api.github.com/repos/appium/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-adb/tags","blobs_url":"https://api.github.com/repos/appium/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-adb/languages","stargazers_url":"https://api.github.com/repos/appium/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-adb/subscription","commits_url":"https://api.github.com/repos/appium/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-adb/merges","archive_url":"https://api.github.com/repos/appium/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-adb/downloads","issues_url":"https://api.github.com/repos/appium/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-adb/deployments","created_at":"2014-03-02T14:20:10Z","updated_at":"2018-11-07T22:11:54Z","pushed_at":"2018-11-07T22:11:55Z","git_url":"git://github.com/appium/appium-adb.git","ssh_url":"git@github.com:appium/appium-adb.git","clone_url":"https://github.com/appium/appium-adb.git","svn_url":"https://github.com/appium/appium-adb","homepage":null,"size":31117,"stargazers_count":106,"watchers_count":106,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":109,"open_issues":3,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/376"},"html":{"href":"https://github.com/appium/appium-adb/pull/376"},"issue":{"href":"https://api.github.com/repos/appium/appium-adb/issues/376"},"comments":{"href":"https://api.github.com/repos/appium/appium-adb/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-adb/statuses/de90e455fd6ca9d5347f2d19da5be88ffa63b7a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlipps"}}