{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/openresty/pulls/comments/183921130","pull_request_review_id":115012793,"id":183921130,"diff_hunk":"@@ -370,7 +366,7 @@ push @make_install_cmds,\n \n if ($platform ne 'msys') {\n     push @make_install_cmds,\n-        \"ln -sf $ngx_sbin \\$(DESTDIR)$prefix/bin/openresty\";\n+        \"ln -sf \\$(DESTDIR)$ngx_sbin \\$(DESTDIR)$prefix/bin/openresty\";","path":"util/configure","position":133,"original_position":133,"commit_id":"f645a6fa30c89f8ad56e1dba6b770db46f105e32","original_commit_id":"62cb8713c4164626552733fea13f22248e115d29","user":{"login":"mclyne","id":523671,"avatar_url":"https://avatars0.githubusercontent.com/u/523671?v=4","gravatar_id":"","url":"https://api.github.com/users/mclyne","html_url":"https://github.com/mclyne","followers_url":"https://api.github.com/users/mclyne/followers","following_url":"https://api.github.com/users/mclyne/following{/other_user}","gists_url":"https://api.github.com/users/mclyne/gists{/gist_id}","starred_url":"https://api.github.com/users/mclyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclyne/subscriptions","organizations_url":"https://api.github.com/users/mclyne/orgs","repos_url":"https://api.github.com/users/mclyne/repos","events_url":"https://api.github.com/users/mclyne/events{/privacy}","received_events_url":"https://api.github.com/users/mclyne/received_events","type":"User","site_admin":false},"body":"I wasn't confusing DESTDIR with PREFIX, however I wasn't thinking of it being used in that way.  Thanks for the explanation.","created_at":"2018-04-25T01:01:11Z","updated_at":"2018-04-25T01:01:12Z","html_url":"https://github.com/openresty/openresty/pull/362#discussion_r183921130","pull_request_url":"https://api.github.com/repos/openresty/openresty/pulls/362","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openresty/openresty/pulls/comments/183921130"},"html":{"href":"https://github.com/openresty/openresty/pull/362#discussion_r183921130"},"pull_request":{"href":"https://api.github.com/repos/openresty/openresty/pulls/362"}},"in_reply_to_id":183909804},"pull_request":{"url":"https://api.github.com/repos/openresty/openresty/pulls/362","id":183170081,"html_url":"https://github.com/openresty/openresty/pull/362","diff_url":"https://github.com/openresty/openresty/pull/362.diff","patch_url":"https://github.com/openresty/openresty/pull/362.patch","issue_url":"https://api.github.com/repos/openresty/openresty/issues/362","number":362,"state":"open","locked":false,"title":"configure: put lua-resty libs into a list, and make all operations on lua-resty opts use that list","user":{"login":"mclyne","id":523671,"avatar_url":"https://avatars0.githubusercontent.com/u/523671?v=4","gravatar_id":"","url":"https://api.github.com/users/mclyne","html_url":"https://github.com/mclyne","followers_url":"https://api.github.com/users/mclyne/followers","following_url":"https://api.github.com/users/mclyne/following{/other_user}","gists_url":"https://api.github.com/users/mclyne/gists{/gist_id}","starred_url":"https://api.github.com/users/mclyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclyne/subscriptions","organizations_url":"https://api.github.com/users/mclyne/orgs","repos_url":"https://api.github.com/users/mclyne/repos","events_url":"https://api.github.com/users/mclyne/events{/privacy}","received_events_url":"https://api.github.com/users/mclyne/received_events","type":"User","site_admin":false},"body":"Reason for patch\r\n=============\r\nThe configure file now has quite a large number of included lua-resty-[name] libs, with all references to them statically included in the following places:\r\n\r\n1) Configure option parsing (each --without-lua_resty_xxx option)\r\n2) Including the make files (a static list)\r\n3) Configure usage message\r\n\r\nThis is both more prone to errors, and is inefficient when adding new libs in the future.\r\n\r\nWhat this patch does\r\n================\r\n1) Puts all the lua-resty-[name] libs into a list (underneath the list of modules)\r\n2) Uses the list to generate a regex to test for --without-lua_resty_[name] configure options\r\n3) Uses the list to add the lua-resty-[name] libs to the whole $make process\r\n4) Uses the list to generate the relevant parts of the ./configure --help message\r\n5) A few very minor edits that improve clarity / formatting consistency (that make no changes to the actions)\r\n\r\nThis makes the whole configure script a bit easier to read, makes it quicker to add new lua-resty-[name] libs to OpenResty, and reduces the possibility for bugs in future edits.\r\n\r\nWhat else you might want to change\r\n============================\r\nI've ordered the lua-resty-[name] modules alphabetically, because I think they're easier to read that way.  Given that the modules are not listed alphabetically in the ./configure --help, you might want to : \r\n\r\n- Re-order the list of lua-resty-[name] libs\r\n- Modify the ./configure script to display the help with the --with-[name]_module and --without-[name]_module so they display alphabetically\r\n\r\nI didn't want to presume your choice about this, but if you'd like me to do a quick patch to change that as well, I'm happy to do so.","created_at":"2018-04-20T21:02:51Z","updated_at":"2018-04-25T01:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0157aba47a2a65d091137e017f5227bf3eafdc26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/openresty/pulls/362/commits","review_comments_url":"https://api.github.com/repos/openresty/openresty/pulls/362/comments","review_comment_url":"https://api.github.com/repos/openresty/openresty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/openresty/issues/362/comments","statuses_url":"https://api.github.com/repos/openresty/openresty/statuses/f645a6fa30c89f8ad56e1dba6b770db46f105e32","head":{"label":"mclyne:master","ref":"master","sha":"f645a6fa30c89f8ad56e1dba6b770db46f105e32","user":{"login":"mclyne","id":523671,"avatar_url":"https://avatars0.githubusercontent.com/u/523671?v=4","gravatar_id":"","url":"https://api.github.com/users/mclyne","html_url":"https://github.com/mclyne","followers_url":"https://api.github.com/users/mclyne/followers","following_url":"https://api.github.com/users/mclyne/following{/other_user}","gists_url":"https://api.github.com/users/mclyne/gists{/gist_id}","starred_url":"https://api.github.com/users/mclyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclyne/subscriptions","organizations_url":"https://api.github.com/users/mclyne/orgs","repos_url":"https://api.github.com/users/mclyne/repos","events_url":"https://api.github.com/users/mclyne/events{/privacy}","received_events_url":"https://api.github.com/users/mclyne/received_events","type":"User","site_admin":false},"repo":{"id":130411906,"name":"openresty","full_name":"mclyne/openresty","owner":{"login":"mclyne","id":523671,"avatar_url":"https://avatars0.githubusercontent.com/u/523671?v=4","gravatar_id":"","url":"https://api.github.com/users/mclyne","html_url":"https://github.com/mclyne","followers_url":"https://api.github.com/users/mclyne/followers","following_url":"https://api.github.com/users/mclyne/following{/other_user}","gists_url":"https://api.github.com/users/mclyne/gists{/gist_id}","starred_url":"https://api.github.com/users/mclyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclyne/subscriptions","organizations_url":"https://api.github.com/users/mclyne/orgs","repos_url":"https://api.github.com/users/mclyne/repos","events_url":"https://api.github.com/users/mclyne/events{/privacy}","received_events_url":"https://api.github.com/users/mclyne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mclyne/openresty","description":"Turning Nginx into a Full-Fledged Scriptable Web Platform","fork":true,"url":"https://api.github.com/repos/mclyne/openresty","forks_url":"https://api.github.com/repos/mclyne/openresty/forks","keys_url":"https://api.github.com/repos/mclyne/openresty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mclyne/openresty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mclyne/openresty/teams","hooks_url":"https://api.github.com/repos/mclyne/openresty/hooks","issue_events_url":"https://api.github.com/repos/mclyne/openresty/issues/events{/number}","events_url":"https://api.github.com/repos/mclyne/openresty/events","assignees_url":"https://api.github.com/repos/mclyne/openresty/assignees{/user}","branches_url":"https://api.github.com/repos/mclyne/openresty/branches{/branch}","tags_url":"https://api.github.com/repos/mclyne/openresty/tags","blobs_url":"https://api.github.com/repos/mclyne/openresty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mclyne/openresty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mclyne/openresty/git/refs{/sha}","trees_url":"https://api.github.com/repos/mclyne/openresty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mclyne/openresty/statuses/{sha}","languages_url":"https://api.github.com/repos/mclyne/openresty/languages","stargazers_url":"https://api.github.com/repos/mclyne/openresty/stargazers","contributors_url":"https://api.github.com/repos/mclyne/openresty/contributors","subscribers_url":"https://api.github.com/repos/mclyne/openresty/subscribers","subscription_url":"https://api.github.com/repos/mclyne/openresty/subscription","commits_url":"https://api.github.com/repos/mclyne/openresty/commits{/sha}","git_commits_url":"https://api.github.com/repos/mclyne/openresty/git/commits{/sha}","comments_url":"https://api.github.com/repos/mclyne/openresty/comments{/number}","issue_comment_url":"https://api.github.com/repos/mclyne/openresty/issues/comments{/number}","contents_url":"https://api.github.com/repos/mclyne/openresty/contents/{+path}","compare_url":"https://api.github.com/repos/mclyne/openresty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mclyne/openresty/merges","archive_url":"https://api.github.com/repos/mclyne/openresty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mclyne/openresty/downloads","issues_url":"https://api.github.com/repos/mclyne/openresty/issues{/number}","pulls_url":"https://api.github.com/repos/mclyne/openresty/pulls{/number}","milestones_url":"https://api.github.com/repos/mclyne/openresty/milestones{/number}","notifications_url":"https://api.github.com/repos/mclyne/openresty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mclyne/openresty/labels{/name}","releases_url":"https://api.github.com/repos/mclyne/openresty/releases{/id}","deployments_url":"https://api.github.com/repos/mclyne/openresty/deployments","created_at":"2018-04-20T20:41:02Z","updated_at":"2018-04-25T00:07:58Z","pushed_at":"2018-04-25T00:07:55Z","git_url":"git://github.com/mclyne/openresty.git","ssh_url":"git@github.com:mclyne/openresty.git","clone_url":"https://github.com/mclyne/openresty.git","svn_url":"https://github.com/mclyne/openresty","homepage":"https://openresty.org","size":1742,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"eccf26672cfc1e740cf3bedd1a0cd960b404c2ca","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":480080,"name":"openresty","full_name":"openresty/openresty","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/openresty","description":"Turning Nginx into a Full-Fledged Scriptable Web Platform","fork":false,"url":"https://api.github.com/repos/openresty/openresty","forks_url":"https://api.github.com/repos/openresty/openresty/forks","keys_url":"https://api.github.com/repos/openresty/openresty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/openresty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/openresty/teams","hooks_url":"https://api.github.com/repos/openresty/openresty/hooks","issue_events_url":"https://api.github.com/repos/openresty/openresty/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/openresty/events","assignees_url":"https://api.github.com/repos/openresty/openresty/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/openresty/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/openresty/tags","blobs_url":"https://api.github.com/repos/openresty/openresty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/openresty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/openresty/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/openresty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/openresty/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/openresty/languages","stargazers_url":"https://api.github.com/repos/openresty/openresty/stargazers","contributors_url":"https://api.github.com/repos/openresty/openresty/contributors","subscribers_url":"https://api.github.com/repos/openresty/openresty/subscribers","subscription_url":"https://api.github.com/repos/openresty/openresty/subscription","commits_url":"https://api.github.com/repos/openresty/openresty/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/openresty/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/openresty/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/openresty/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/openresty/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/openresty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/openresty/merges","archive_url":"https://api.github.com/repos/openresty/openresty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/openresty/downloads","issues_url":"https://api.github.com/repos/openresty/openresty/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/openresty/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/openresty/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/openresty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/openresty/labels{/name}","releases_url":"https://api.github.com/repos/openresty/openresty/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/openresty/deployments","created_at":"2010-01-20T03:57:59Z","updated_at":"2018-04-24T23:40:39Z","pushed_at":"2018-04-25T00:07:57Z","git_url":"git://github.com/openresty/openresty.git","ssh_url":"git@github.com:openresty/openresty.git","clone_url":"https://github.com/openresty/openresty.git","svn_url":"https://github.com/openresty/openresty","homepage":"https://openresty.org","size":1744,"stargazers_count":5158,"watchers_count":5158,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":771,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":771,"open_issues":65,"watchers":5158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/openresty/pulls/362"},"html":{"href":"https://github.com/openresty/openresty/pull/362"},"issue":{"href":"https://api.github.com/repos/openresty/openresty/issues/362"},"comments":{"href":"https://api.github.com/repos/openresty/openresty/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/openresty/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/openresty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/openresty/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/openresty/statuses/f645a6fa30c89f8ad56e1dba6b770db46f105e32"}},"author_association":"NONE"}}
{"actor":{"display_login":"mclyne"}}