{"action":"closed","issue":{"url":"https://api.github.com/repos/spesmilo/electrum/issues/4164","repository_url":"https://api.github.com/repos/spesmilo/electrum","labels_url":"https://api.github.com/repos/spesmilo/electrum/issues/4164/labels{/name}","comments_url":"https://api.github.com/repos/spesmilo/electrum/issues/4164/comments","events_url":"https://api.github.com/repos/spesmilo/electrum/issues/4164/events","html_url":"https://github.com/spesmilo/electrum/issues/4164","id":307797578,"number":4164,"title":"Hardware device name connection dialog box","user":{"login":"charlespax","id":281642,"avatar_url":"https://avatars0.githubusercontent.com/u/281642?v=4","gravatar_id":"","url":"https://api.github.com/users/charlespax","html_url":"https://github.com/charlespax","followers_url":"https://api.github.com/users/charlespax/followers","following_url":"https://api.github.com/users/charlespax/following{/other_user}","gists_url":"https://api.github.com/users/charlespax/gists{/gist_id}","starred_url":"https://api.github.com/users/charlespax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlespax/subscriptions","organizations_url":"https://api.github.com/users/charlespax/orgs","repos_url":"https://api.github.com/users/charlespax/repos","events_url":"https://api.github.com/users/charlespax/events{/privacy}","received_events_url":"https://api.github.com/users/charlespax/received_events","type":"User","site_admin":false},"labels":[{"id":10740360,"url":"https://api.github.com/repos/spesmilo/electrum/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":283532611,"url":"https://api.github.com/repos/spesmilo/electrum/labels/hw-trezor","name":"hw-trezor","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T20:13:03Z","updated_at":"2018-03-22T20:49:06Z","closed_at":"2018-03-22T20:49:06Z","author_association":"NONE","body":"I have an Electrum (commit cd19f788ccedd7ac050141cdd15c9905011c951e) 2of4 multisig wallet using three Trezor devices: 'My name is Amy', 'My name is Bill', 'My name is Carlo' with password 1, and 'My name is Carlo' with password 2.\r\n\r\nWhen signing a transaction Electrum asks me to connect a Trezor device, but does not specify which one. It would be good to remove the ambiguity. I tested my wallet by signing with 'Amy' and 'Bill', which worked, but things would not work when using a Trezor with a password. I spent several hours on this before I discovered that Electrum was requesting the devices in a specific order. Because the dialog indicated only, \"TREZOR\", I assumed any Trezor would do.\r\n\r\nAnway, here is the normal dialog box:\r\n![screenshot from 2018-03-22 16-02-31](https://user-images.githubusercontent.com/281642/37795290-7420f532-2dea-11e8-929b-20078befb5d1.png)\r\n\r\nI dug into the code a bit to give an example of the expected behavior. Here is what I feel the dialog box should look like:\r\n![screenshot from 2018-03-22 16-03-06](https://user-images.githubusercontent.com/281642/37795339-91fcdc4c-2dea-11e8-9747-31f9c716afb7.png)\r\n\r\nIn `lib/plugins.py` line 485 change this:\r\n```\r\n            msg = _('Please insert your {}.  Verify the cable is '\r\n                    'connected and that no other application is using it.\\n\\n'\r\n                    'Try to connect again?').format(plugin.device)\r\n```\r\nto this:\r\n```\r\n            msg = _('Please insert your {} \\'{}\\'.  Verify the cable is '\r\n                    'connected and that no other application is using it.\\n\\n'\r\n                    'Try to connect again?').format(plugin.device, keystore.label)\r\n```\r\n\r\nI have not tested with any other devices and I am not familiar with Electrum code, so I am not submitting a pull request."}}
{"actor":{"display_login":"SomberNight"}}