{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/558","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/558/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/558/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/558/events","html_url":"https://github.com/StrikeNP/trac_test/issues/558","id":334635255,"node_id":"MDU6SXNzdWUzMzQ2MzUyNTU=","number":558,"title":"SILHS RICO case does not converge as of 26 Mar 2013 (Trac #558)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":971577014,"node_id":"MDU6TGFiZWw5NzE1NzcwMTQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":971577274,"node_id":"MDU6TGFiZWw5NzE1NzcyNzQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":971577020,"node_id":"MDU6TGFiZWw5NzE1NzcwMjA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/defect","name":"defect","color":"FFFFFF","default":false},{"id":971649570,"node_id":"MDU6TGFiZWw5NzE2NDk1NzA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/raut@uwm.edu","name":"raut@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/8","html_url":"https://github.com/StrikeNP/trac_test/milestone/8","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/8/labels","id":3442840,"node_id":"MDk6TWlsZXN0b25lMzQ0Mjg0MA==","number":8,"title":"Improve SILHS","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":38,"state":"open","created_at":"2018-06-21T18:03:51Z","updated_at":"2018-06-23T08:35:22Z","due_on":null,"closed_at":null},"comments":127,"created_at":"2018-06-21T19:56:58Z","updated_at":"2018-06-23T10:00:27Z","closed_at":null,"author_association":"OWNER","body":"\nKenny Chowdhary at Sandia would like to compare SILHS vs. their Gaussian-Legendre integration method.\n\nSILHS no longer converges to KK for the RICO case. It converged as of 3 Jul 2012 (ticket:506), but it no longer converges.  Partly this is probably just an issue of configuration.  E.g., in the nightly tests, rico and rico_lh have different timesteps, different PDFs for Nc, and sedimentation of the mean vs. sedimentation variability.  \n\nBrian, could you please note on this ticket, in order to achieve an apples-to-apples comparison, what lines of code need to be commented out and what flag needs to be set for a lognormal Nc.\n\nOnce we restore convergence, we should devise a nightly test that will make it obvious if convergence breaks in the future.  We already plot both rico and rico_LH in the nightly tests.  Perhaps we could simply overplot the two cases?  Or perhaps we could develop text-based output that checks whether the profiles agree to within some tolerance?\n\nAttachments:\n\n[plot_explicit_ta_configs.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_explicit_ta_configs.maff)\n[plot_new_pdf_config_1_plot_2.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_config_1_plot_2.maff)\n[plot_combo_pdf_run_3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_combo_pdf_run_3.maff)\n[plot_input_fields_rtp3_thlp3_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_input_fields_rtp3_thlp3_1.maff)\n[plot_new_pdf_20180522_test_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_20180522_test_1.maff)\n[plot_attempts_8_10.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempts_8_10.maff)\n[plot_attempt_8_only.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempt_8_only.maff)\n[plot_beta_1p3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3.maff)\n[plot_beta_1p3_all.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3_all.maff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/558\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2014-07-10T22:03:35\", \n    \"description\": \"\\nKenny Chowdhary at Sandia would like to compare SILHS vs. their Gaussian-Legendre integration method.\\n\\nSILHS no longer converges to KK for the RICO case. It converged as of 3 Jul 2012 (ticket:506), but it no longer converges.  Partly this is probably just an issue of configuration.  E.g., in the nightly tests, rico and rico_lh have different timesteps, different PDFs for Nc, and sedimentation of the mean vs. sedimentation variability.  \\n\\nBrian, could you please note on this ticket, in order to achieve an apples-to-apples comparison, what lines of code need to be commented out and what flag needs to be set for a lognormal Nc.\\n\\nOnce we restore convergence, we should devise a nightly test that will make it obvious if convergence breaks in the future.  We already plot both rico and rico_LH in the nightly tests.  Perhaps we could simply overplot the two cases?  Or perhaps we could develop text-based output that checks whether the profiles agree to within some tolerance?\", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, dschanen@uwm.edu, charlass@uwm.edu, katec@ucar.edu, janhft@uwm.edu\", \n    \"resolution\": \"worksforme\", \n    \"_ts\": \"1405029815654410\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"SILHS RICO case does not converge as of 26 Mar 2013\", \n    \"priority\": \"major\", \n    \"keywords\": \"\", \n    \"time\": \"2013-03-26T20:35:57\", \n    \"milestone\": \"Improve SILHS\", \n    \"owner\": \"raut@uwm.edu\", \n    \"type\": \"defect\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/399660227","html_url":"https://github.com/StrikeNP/trac_test/issues/558#issuecomment-399660227","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/558","id":399660227,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTY2MDIyNw==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-23T10:00:27Z","updated_at":"2018-06-23T10:00:27Z","author_association":"OWNER","body":"**Trac update on 2013/07/31 at 22:18**\n**janhft@uwm.edu commented:**\n\nReplying to [comment:77 raut@…]:\n> Perhaps one problem with the `l_use_modified_corr` code is that SILHS expects the means and sigmas of all variables except s, t, and w to be in log-normal space (see [browser:/trunk/src/Latin_hypercube/generate_lh_sample_module.F90?rev=6438#L332 line 332] and [browser:/trunk/src/Latin_hypercube/generate_lh_sample_module.F90?rev=6438#L1278 line 1278] of `generate_lh_sample_module.F90`), whereas the modified code passes in all variables in the normal space (after normalizing them; see [browser:/trunk/src/setup_clubb_pdf_params.F90?rev=6438#L548 line 548] of `setup_clubb_pdf_params.F90`.\n> \n> On second thought, it looks like the code in `setup_clubb_pdf_params.F90` is doing the exact same thing on [browser:/trunk/src/setup_clubb_pdf_params.F90?rev=6438#L3797 line 3797].\n\n\nThat's a good point, Eric! It seems like the old code passed the correlations/means/stddevs of the hydrometeors to ```sample_points``` as log-normal variables, then the code samples the points in ```gaus_mixt_points```, and finally converts the sample points of the  log-normal variables into normal space (if  ```l_d_variable_lognormal(ivar)``` is .true.). Whereas in the new code the correlations/means/stddevs of the hydrometeors are already normalized when we feed them into ```sample_points```. Hence we don't need to convert the resulting sample points. So we should set ```l_d_variable_lognormal``` in ```generate_LH_sample_mod``` to .false. for all variables.\n\n\n"}}
{"actor":{"display_login":"StrikeNP"}}