{"action":"created","comment":{"url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/comments/209217701","pull_request_review_id":145189118,"id":209217701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIxNzcwMQ==","diff_hunk":"@@ -312,11 +312,21 @@ impl BytesReader {\n     }\n \n     #[inline(always)]\n-    fn read_len<'a, M, F>(&mut self, bytes: &'a [u8], mut read: F) -> Result<M>\n+    fn read_len<'a, M, F>(&mut self, bytes: &'a [u8], read: F) -> Result<M>\n     where\n         F: FnMut(&mut BytesReader, &'a [u8]) -> Result<M>,\n     {\n         let len = self.read_varint32(bytes)? as usize;\n+        self.read_len_size(bytes, read, len)\n+    }\n+\n+\n+    #[inline(always)]\n+    fn read_len_size<'a, M, F>(&mut self, bytes: &'a [u8], mut read: F, len: usize) -> Result<M>\n+        where\n+            F: FnMut(&mut BytesReader, &'a [u8]) -> Result<M>,\n+    {\n+        println!(\"{}\", len);","path":"src/reader.rs","position":19,"original_position":19,"commit_id":"a92d7d665c73c322820d04aa51c9a2a36d287914","original_commit_id":"a92d7d665c73c322820d04aa51c9a2a36d287914","user":{"login":"tafia","id":7351502,"node_id":"MDQ6VXNlcjczNTE1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7351502?v=4","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"body":"Could you remove it?","created_at":"2018-08-10T10:36:26Z","updated_at":"2018-08-10T10:46:51Z","html_url":"https://github.com/tafia/quick-protobuf/pull/109#discussion_r209217701","pull_request_url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/comments/209217701"},"html":{"href":"https://github.com/tafia/quick-protobuf/pull/109#discussion_r209217701"},"pull_request":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109","id":207534823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTM0ODIz","html_url":"https://github.com/tafia/quick-protobuf/pull/109","diff_url":"https://github.com/tafia/quick-protobuf/pull/109.diff","patch_url":"https://github.com/tafia/quick-protobuf/pull/109.patch","issue_url":"https://api.github.com/repos/tafia/quick-protobuf/issues/109","number":109,"state":"open","locked":false,"title":"Add possibility to read message with speciefied length","user":{"login":"foesi","id":20044386,"node_id":"MDQ6VXNlcjIwMDQ0Mzg2","avatar_url":"https://avatars1.githubusercontent.com/u/20044386?v=4","gravatar_id":"","url":"https://api.github.com/users/foesi","html_url":"https://github.com/foesi","followers_url":"https://api.github.com/users/foesi/followers","following_url":"https://api.github.com/users/foesi/following{/other_user}","gists_url":"https://api.github.com/users/foesi/gists{/gist_id}","starred_url":"https://api.github.com/users/foesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foesi/subscriptions","organizations_url":"https://api.github.com/users/foesi/orgs","repos_url":"https://api.github.com/users/foesi/repos","events_url":"https://api.github.com/users/foesi/events{/privacy}","received_events_url":"https://api.github.com/users/foesi/received_events","type":"User","site_admin":false},"body":"As you can read in https://developers.google.com/protocol-buffers/docs/techniques\r\nthe protobuf protocol does not specify the format how the length of a message\r\nis stated. If you communicate with an entity which does not encode it's message\r\nlength in varints you are not able to read them. Therfore this fix should enable\r\nyou to read your own format of message size and read the message of specified\r\nlength.\r\n\r\nThis should fix #108 \r\n\r\nIf you merge this it would be nice if you can publish it soon because I am relying on this fix and currently depending on a local Version of quick-protobuf. Thank you.","created_at":"2018-08-10T07:59:47Z","updated_at":"2018-08-10T10:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520a90841f7da99aade52912c17e5e7b439d3687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109/commits","review_comments_url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109/comments","review_comment_url":"https://api.github.com/repos/tafia/quick-protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tafia/quick-protobuf/issues/109/comments","statuses_url":"https://api.github.com/repos/tafia/quick-protobuf/statuses/a92d7d665c73c322820d04aa51c9a2a36d287914","head":{"label":"foesi:master","ref":"master","sha":"a92d7d665c73c322820d04aa51c9a2a36d287914","user":{"login":"foesi","id":20044386,"node_id":"MDQ6VXNlcjIwMDQ0Mzg2","avatar_url":"https://avatars1.githubusercontent.com/u/20044386?v=4","gravatar_id":"","url":"https://api.github.com/users/foesi","html_url":"https://github.com/foesi","followers_url":"https://api.github.com/users/foesi/followers","following_url":"https://api.github.com/users/foesi/following{/other_user}","gists_url":"https://api.github.com/users/foesi/gists{/gist_id}","starred_url":"https://api.github.com/users/foesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foesi/subscriptions","organizations_url":"https://api.github.com/users/foesi/orgs","repos_url":"https://api.github.com/users/foesi/repos","events_url":"https://api.github.com/users/foesi/events{/privacy}","received_events_url":"https://api.github.com/users/foesi/received_events","type":"User","site_admin":false},"repo":{"id":143303331,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMDMzMzE=","name":"quick-protobuf","full_name":"foesi/quick-protobuf","owner":{"login":"foesi","id":20044386,"node_id":"MDQ6VXNlcjIwMDQ0Mzg2","avatar_url":"https://avatars1.githubusercontent.com/u/20044386?v=4","gravatar_id":"","url":"https://api.github.com/users/foesi","html_url":"https://github.com/foesi","followers_url":"https://api.github.com/users/foesi/followers","following_url":"https://api.github.com/users/foesi/following{/other_user}","gists_url":"https://api.github.com/users/foesi/gists{/gist_id}","starred_url":"https://api.github.com/users/foesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foesi/subscriptions","organizations_url":"https://api.github.com/users/foesi/orgs","repos_url":"https://api.github.com/users/foesi/repos","events_url":"https://api.github.com/users/foesi/events{/privacy}","received_events_url":"https://api.github.com/users/foesi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foesi/quick-protobuf","description":"A rust implementation of protobuf parser","fork":true,"url":"https://api.github.com/repos/foesi/quick-protobuf","forks_url":"https://api.github.com/repos/foesi/quick-protobuf/forks","keys_url":"https://api.github.com/repos/foesi/quick-protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foesi/quick-protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foesi/quick-protobuf/teams","hooks_url":"https://api.github.com/repos/foesi/quick-protobuf/hooks","issue_events_url":"https://api.github.com/repos/foesi/quick-protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/foesi/quick-protobuf/events","assignees_url":"https://api.github.com/repos/foesi/quick-protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/foesi/quick-protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/foesi/quick-protobuf/tags","blobs_url":"https://api.github.com/repos/foesi/quick-protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foesi/quick-protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foesi/quick-protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/foesi/quick-protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foesi/quick-protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/foesi/quick-protobuf/languages","stargazers_url":"https://api.github.com/repos/foesi/quick-protobuf/stargazers","contributors_url":"https://api.github.com/repos/foesi/quick-protobuf/contributors","subscribers_url":"https://api.github.com/repos/foesi/quick-protobuf/subscribers","subscription_url":"https://api.github.com/repos/foesi/quick-protobuf/subscription","commits_url":"https://api.github.com/repos/foesi/quick-protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/foesi/quick-protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/foesi/quick-protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/foesi/quick-protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/foesi/quick-protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/foesi/quick-protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foesi/quick-protobuf/merges","archive_url":"https://api.github.com/repos/foesi/quick-protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foesi/quick-protobuf/downloads","issues_url":"https://api.github.com/repos/foesi/quick-protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/foesi/quick-protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/foesi/quick-protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/foesi/quick-protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foesi/quick-protobuf/labels{/name}","releases_url":"https://api.github.com/repos/foesi/quick-protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/foesi/quick-protobuf/deployments","created_at":"2018-08-02T14:09:08Z","updated_at":"2018-08-10T07:37:32Z","pushed_at":"2018-08-10T07:37:31Z","git_url":"git://github.com/foesi/quick-protobuf.git","ssh_url":"git@github.com:foesi/quick-protobuf.git","clone_url":"https://github.com/foesi/quick-protobuf.git","svn_url":"https://github.com/foesi/quick-protobuf","homepage":null,"size":370,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tafia:master","ref":"master","sha":"9f1e406163820879cb3aeaea374d6881b0ca95c4","user":{"login":"tafia","id":7351502,"node_id":"MDQ6VXNlcjczNTE1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7351502?v=4","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"repo":{"id":78842487,"node_id":"MDEwOlJlcG9zaXRvcnk3ODg0MjQ4Nw==","name":"quick-protobuf","full_name":"tafia/quick-protobuf","owner":{"login":"tafia","id":7351502,"node_id":"MDQ6VXNlcjczNTE1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7351502?v=4","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tafia/quick-protobuf","description":"A rust implementation of protobuf parser","fork":false,"url":"https://api.github.com/repos/tafia/quick-protobuf","forks_url":"https://api.github.com/repos/tafia/quick-protobuf/forks","keys_url":"https://api.github.com/repos/tafia/quick-protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tafia/quick-protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tafia/quick-protobuf/teams","hooks_url":"https://api.github.com/repos/tafia/quick-protobuf/hooks","issue_events_url":"https://api.github.com/repos/tafia/quick-protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/tafia/quick-protobuf/events","assignees_url":"https://api.github.com/repos/tafia/quick-protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/tafia/quick-protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/tafia/quick-protobuf/tags","blobs_url":"https://api.github.com/repos/tafia/quick-protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tafia/quick-protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tafia/quick-protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tafia/quick-protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tafia/quick-protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/tafia/quick-protobuf/languages","stargazers_url":"https://api.github.com/repos/tafia/quick-protobuf/stargazers","contributors_url":"https://api.github.com/repos/tafia/quick-protobuf/contributors","subscribers_url":"https://api.github.com/repos/tafia/quick-protobuf/subscribers","subscription_url":"https://api.github.com/repos/tafia/quick-protobuf/subscription","commits_url":"https://api.github.com/repos/tafia/quick-protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tafia/quick-protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tafia/quick-protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tafia/quick-protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tafia/quick-protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/tafia/quick-protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tafia/quick-protobuf/merges","archive_url":"https://api.github.com/repos/tafia/quick-protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tafia/quick-protobuf/downloads","issues_url":"https://api.github.com/repos/tafia/quick-protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/tafia/quick-protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/tafia/quick-protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/tafia/quick-protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tafia/quick-protobuf/labels{/name}","releases_url":"https://api.github.com/repos/tafia/quick-protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/tafia/quick-protobuf/deployments","created_at":"2017-01-13T11:10:14Z","updated_at":"2018-08-08T02:48:33Z","pushed_at":"2018-08-10T07:59:48Z","git_url":"git://github.com/tafia/quick-protobuf.git","ssh_url":"git@github.com:tafia/quick-protobuf.git","clone_url":"https://github.com/tafia/quick-protobuf.git","svn_url":"https://github.com/tafia/quick-protobuf","homepage":null,"size":363,"stargazers_count":110,"watchers_count":110,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":29,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109"},"html":{"href":"https://github.com/tafia/quick-protobuf/pull/109"},"issue":{"href":"https://api.github.com/repos/tafia/quick-protobuf/issues/109"},"comments":{"href":"https://api.github.com/repos/tafia/quick-protobuf/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tafia/quick-protobuf/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/tafia/quick-protobuf/statuses/a92d7d665c73c322820d04aa51c9a2a36d287914"}},"author_association":"NONE"}}
{"actor":{"display_login":"tafia"}}