{"action":"created","comment":{"url":"https://api.github.com/repos/magento/magento2/pulls/comments/222463953","pull_request_review_id":161357550,"id":222463953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ2Mzk1Mw==","diff_hunk":"@@ -276,4 +280,22 @@ public function saveFileToTmpDir($fileId)\n \n         return $result;\n     }\n+\n+    /**\n+     * Get the final filename to use when the image is saved\n+     * @param string $imageName\n+     * @return string\n+     */\n+    public function getFinalImageName($imageName)","path":"app/code/Magento/Catalog/Model/ImageUploader.php","position":48,"original_position":48,"commit_id":"0ba92016ffbbc3b10c449d3dbf129985499b9c82","original_commit_id":"0ba92016ffbbc3b10c449d3dbf129985499b9c82","user":{"login":"slavvka","id":9741905,"node_id":"MDQ6VXNlcjk3NDE5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/9741905?v=4","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false},"body":"It is the backward incompatible breaking change (which also is impossible to backport to Magento 2.2). Consider refactoring the code to eliminate it. Please refer to the guide https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/","created_at":"2018-10-03T20:53:27Z","updated_at":"2018-10-03T20:53:36Z","html_url":"https://github.com/magento/magento2/pull/17674#discussion_r222463953","pull_request_url":"https://api.github.com/repos/magento/magento2/pulls/17674","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/222463953"},"html":{"href":"https://github.com/magento/magento2/pull/17674#discussion_r222463953"},"pull_request":{"href":"https://api.github.com/repos/magento/magento2/pulls/17674"}}},"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/17674","id":209264104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjY0MTA0","html_url":"https://github.com/magento/magento2/pull/17674","diff_url":"https://github.com/magento/magento2/pull/17674.diff","patch_url":"https://github.com/magento/magento2/pull/17674.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/17674","number":17674,"state":"open","locked":false,"title":"Prevent category image filename collisions","user":{"login":"Spaggel","id":1824950,"node_id":"MDQ6VXNlcjE4MjQ5NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1824950?v=4","gravatar_id":"","url":"https://api.github.com/users/Spaggel","html_url":"https://github.com/Spaggel","followers_url":"https://api.github.com/users/Spaggel/followers","following_url":"https://api.github.com/users/Spaggel/following{/other_user}","gists_url":"https://api.github.com/users/Spaggel/gists{/gist_id}","starred_url":"https://api.github.com/users/Spaggel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spaggel/subscriptions","organizations_url":"https://api.github.com/users/Spaggel/orgs","repos_url":"https://api.github.com/users/Spaggel/repos","events_url":"https://api.github.com/users/Spaggel/events{/privacy}","received_events_url":"https://api.github.com/users/Spaggel/received_events","type":"User","site_admin":false},"body":"<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\nI've added a check to prevent saving a new category image over an already existing one. See: #17661 \r\n\r\n**Help wanted**\r\n_This fix introduces a new issue: the image file name is already set on the category model before the file is actually moved to it's final destination. A `@TODO` is added for this. Could you tell me how to handle this? I wanted to create a new event but I'm not quite sure if it's the way to go._\r\n**Update 20-08-2018**: Fixed the incorrect attribute value\r\n### Fixed Issues (if relevant)\r\n\r\n1. magento/magento2#17661\r\n\r\n\r\n### Contribution checklist\r\n - [X] Pull request has a meaningful description of its purpose\r\n - [X] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-08-17T21:41:06Z","updated_at":"2018-10-03T20:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a8f829ffc7ffbca650f7deaffde98b7dded9f06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":374038437,"node_id":"MDU6TGFiZWwzNzQwMzg0Mzc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Catalog","name":"Component: Catalog","color":"7fb703","default":false},{"id":952289455,"node_id":"MDU6TGFiZWw5NTIyODk0NTU=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Guapa","name":"Partner: Guapa","color":"f9d0c4","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/23","html_url":"https://github.com/magento/magento2/milestone/23","labels_url":"https://api.github.com/repos/magento/magento2/milestones/23/labels","id":3664445,"node_id":"MDk6TWlsZXN0b25lMzY2NDQ0NQ==","number":23,"title":"Release: 2.3.1","description":"Community pull requests delivered to Release: 2.3.1 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":32,"state":"open","created_at":"2018-09-18T07:31:32Z","updated_at":"2018-10-03T17:06:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/magento/magento2/pulls/17674/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/17674/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/17674/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/0ba92016ffbbc3b10c449d3dbf129985499b9c82","head":{"label":"Spaggel:17661-fix-category-image-overwrite","ref":"17661-fix-category-image-overwrite","sha":"0ba92016ffbbc3b10c449d3dbf129985499b9c82","user":{"login":"Spaggel","id":1824950,"node_id":"MDQ6VXNlcjE4MjQ5NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1824950?v=4","gravatar_id":"","url":"https://api.github.com/users/Spaggel","html_url":"https://github.com/Spaggel","followers_url":"https://api.github.com/users/Spaggel/followers","following_url":"https://api.github.com/users/Spaggel/following{/other_user}","gists_url":"https://api.github.com/users/Spaggel/gists{/gist_id}","starred_url":"https://api.github.com/users/Spaggel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spaggel/subscriptions","organizations_url":"https://api.github.com/users/Spaggel/orgs","repos_url":"https://api.github.com/users/Spaggel/repos","events_url":"https://api.github.com/users/Spaggel/events{/privacy}","received_events_url":"https://api.github.com/users/Spaggel/received_events","type":"User","site_admin":false},"repo":{"id":145101448,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMDE0NDg=","name":"magento2","full_name":"Spaggel/magento2","private":false,"owner":{"login":"Spaggel","id":1824950,"node_id":"MDQ6VXNlcjE4MjQ5NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1824950?v=4","gravatar_id":"","url":"https://api.github.com/users/Spaggel","html_url":"https://github.com/Spaggel","followers_url":"https://api.github.com/users/Spaggel/followers","following_url":"https://api.github.com/users/Spaggel/following{/other_user}","gists_url":"https://api.github.com/users/Spaggel/gists{/gist_id}","starred_url":"https://api.github.com/users/Spaggel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spaggel/subscriptions","organizations_url":"https://api.github.com/users/Spaggel/orgs","repos_url":"https://api.github.com/users/Spaggel/repos","events_url":"https://api.github.com/users/Spaggel/events{/privacy}","received_events_url":"https://api.github.com/users/Spaggel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Spaggel/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/Spaggel/magento2","forks_url":"https://api.github.com/repos/Spaggel/magento2/forks","keys_url":"https://api.github.com/repos/Spaggel/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spaggel/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spaggel/magento2/teams","hooks_url":"https://api.github.com/repos/Spaggel/magento2/hooks","issue_events_url":"https://api.github.com/repos/Spaggel/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/Spaggel/magento2/events","assignees_url":"https://api.github.com/repos/Spaggel/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/Spaggel/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/Spaggel/magento2/tags","blobs_url":"https://api.github.com/repos/Spaggel/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spaggel/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spaggel/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spaggel/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spaggel/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/Spaggel/magento2/languages","stargazers_url":"https://api.github.com/repos/Spaggel/magento2/stargazers","contributors_url":"https://api.github.com/repos/Spaggel/magento2/contributors","subscribers_url":"https://api.github.com/repos/Spaggel/magento2/subscribers","subscription_url":"https://api.github.com/repos/Spaggel/magento2/subscription","commits_url":"https://api.github.com/repos/Spaggel/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spaggel/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spaggel/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spaggel/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spaggel/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/Spaggel/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spaggel/magento2/merges","archive_url":"https://api.github.com/repos/Spaggel/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spaggel/magento2/downloads","issues_url":"https://api.github.com/repos/Spaggel/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/Spaggel/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/Spaggel/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/Spaggel/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spaggel/magento2/labels{/name}","releases_url":"https://api.github.com/repos/Spaggel/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/Spaggel/magento2/deployments","created_at":"2018-08-17T09:33:07Z","updated_at":"2018-08-17T09:43:21Z","pushed_at":"2018-09-14T08:30:25Z","git_url":"git://github.com/Spaggel/magento2.git","ssh_url":"git@github.com:Spaggel/magento2.git","clone_url":"https://github.com/Spaggel/magento2.git","svn_url":"https://github.com/Spaggel/magento2","homepage":"http://www.magento.com","size":478905,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"7fac89a447f11edd75e323879c289d411062dea3","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-10-03T20:00:44Z","pushed_at":"2018-10-03T19:37:41Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":484876,"stargazers_count":6178,"watchers_count":6178,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5326,"mirror_url":null,"archived":false,"open_issues_count":1274,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5326,"open_issues":1274,"watchers":6178,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/17674"},"html":{"href":"https://github.com/magento/magento2/pull/17674"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/17674"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/17674/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/17674/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/17674/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/0ba92016ffbbc3b10c449d3dbf129985499b9c82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slavvka"}}