{"action":"created","issue":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10640","repository_url":"https://api.github.com/repos/cockpit-project/cockpit","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10640/labels{/name}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10640/comments","events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10640/events","html_url":"https://github.com/cockpit-project/cockpit/pull/10640","id":383401014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODc0OTc4","number":10640,"title":"test: Ignore unhandled browser exceptions during screenshots","user":{"login":"stefwalter","id":795070,"node_id":"MDQ6VXNlcjc5NTA3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/795070?v=4","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"labels":[{"id":88467047,"node_id":"MDU6TGFiZWw4ODQ2NzA0Nw==","url":"https://api.github.com/repos/cockpit-project/cockpit/labels/needswork","name":"needswork","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-22T06:48:21Z","updated_at":"2018-11-25T20:12:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10640","html_url":"https://github.com/cockpit-project/cockpit/pull/10640","diff_url":"https://github.com/cockpit-project/cockpit/pull/10640.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/10640.patch"},"body":"When getting screenshots or HTML dumps, after a test fails,\r\nignore any unhandled browser exceptions.\r\n\r\nOtherwise we get awkward errors like this in the logs, and no\r\nscreenshot or HTML dump:\r\n\r\n    ...\r\n    testlib.Error: timeout\r\n    wait_js_cond(ph_is_visible(\"#login\")): #login not found\r\n\r\n    not ok 248 testFirewallPage (check_networking_firewall.TestFirewall)\r\n    Traceback (most recent call last):\r\n      File \"/build/cockpit/test/common/testlib.py\", line 692, in intercept\r\n        self.snapshot(\"FAIL\")\r\n      File \"/build/cockpit/test/common/testlib.py\", line 964, in snapshot\r\n        self.browser.snapshot(title, label)\r\n      File \"/build/cockpit/test/common/testlib.py\", line 482, in snapshot\r\n        ret = self.cdp.invoke(\"Page.captureScreenshot\", no_trace=True)\r\n      File \"/build/cockpit/test/common/cdp.py\", line 85, in invoke\r\n        res = self.command(cmd)\r\n      File \"/build/cockpit/test/common/cdp.py\", line 112, in command\r\n        raise RuntimeError(res[\"error\"])\r\n    RuntimeError: #login not found\r\n    not ok 248 testFirewallPage (check_networking_firewall.TestFirewall)"},"comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments/441469051","html_url":"https://github.com/cockpit-project/cockpit/pull/10640#issuecomment-441469051","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10640","id":441469051,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ2OTA1MQ==","user":{"login":"martinpitt","id":200109,"node_id":"MDQ6VXNlcjIwMDEwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T20:12:37Z","updated_at":"2018-11-25T20:12:37Z","author_association":"MEMBER","body":"Same failure [here](https://fedorapeople.org/groups/cockpit/logs/pull-10640-20181124-115757-63329eea-verify-fedora-29/log.html#249) and [here](https://fedorapeople.org/groups/cockpit/logs/pull-10640-20181124-120000-63329eea-verify-debian-testing/log.html#24)"}}
{"actor":{"display_login":"martinpitt"}}