{"action":"created","comment":{"url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/comments/186270280","pull_request_review_id":117823051,"id":186270280,"diff_hunk":"@@ -76,31 +78,31 @@ export class LoginPageComponent implements OnInit {\n         }\n     }\n \n-    getFirstNameErrorMessage() {\n+    getFirstNameErrorMessage(): string {\n         if (this.userForm.get('firstName').hasError('required')) {\n             return 'Field required.';\n         }\n     }\n \n-    getLastNameErrorMessage() {\n+    getLastNameErrorMessage(): string {\n         if (this.userForm.get('lastName').hasError('required')) {\n             return 'Field required.';\n         }\n     }\n \n-    getEmailErrorMessage() {\n+    getEmailErrorMessage(): string {\n         return this.userForm.get('email').hasError('required') ? 'Field required.' :\n             this.userForm.get('email').hasError('email') ? 'Invalid email.' :\n                 '';\n     }\n \n-    getPasswordErrorMessage() {\n-        if (this.userForm.get('password').hasError('required')) {\n-            return 'Field required.';\n-        }\n+    getPasswordErrorMessage(): string {\n+        return this.userForm.get('password').hasError('required') ? 'Field required.' :\n+            this.userForm.get('password').hasError('minlength') ? 'Password should be longer than 8 characters.' :","path":"frontend/src/app/pages/login-page/login-page.component.ts","position":49,"original_position":49,"commit_id":"377f9ff8f5a2973db108a94dae9eca21280b266d","original_commit_id":"377f9ff8f5a2973db108a94dae9eca21280b266d","user":{"login":"Darkoon","id":15706349,"avatar_url":"https://avatars1.githubusercontent.com/u/15706349?v=4","gravatar_id":"","url":"https://api.github.com/users/Darkoon","html_url":"https://github.com/Darkoon","followers_url":"https://api.github.com/users/Darkoon/followers","following_url":"https://api.github.com/users/Darkoon/following{/other_user}","gists_url":"https://api.github.com/users/Darkoon/gists{/gist_id}","starred_url":"https://api.github.com/users/Darkoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darkoon/subscriptions","organizations_url":"https://api.github.com/users/Darkoon/orgs","repos_url":"https://api.github.com/users/Darkoon/repos","events_url":"https://api.github.com/users/Darkoon/events{/privacy}","received_events_url":"https://api.github.com/users/Darkoon/received_events","type":"User","site_admin":false},"body":"Please use const value for error message.","created_at":"2018-05-05T19:35:19Z","updated_at":"2018-05-05T19:37:41Z","html_url":"https://github.com/jpowie01/MedTagger/pull/201#discussion_r186270280","pull_request_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/comments/186270280"},"html":{"href":"https://github.com/jpowie01/MedTagger/pull/201#discussion_r186270280"},"pull_request":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201","id":184793082,"html_url":"https://github.com/jpowie01/MedTagger/pull/201","diff_url":"https://github.com/jpowie01/MedTagger/pull/201.diff","patch_url":"https://github.com/jpowie01/MedTagger/pull/201.patch","issue_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/201","number":201,"state":"open","locked":false,"title":"Display error messsage when user provides password that does not fulfill requirements ","user":{"login":"juliapacula","id":22871925,"avatar_url":"https://avatars1.githubusercontent.com/u/22871925?v=4","gravatar_id":"","url":"https://api.github.com/users/juliapacula","html_url":"https://github.com/juliapacula","followers_url":"https://api.github.com/users/juliapacula/followers","following_url":"https://api.github.com/users/juliapacula/following{/other_user}","gists_url":"https://api.github.com/users/juliapacula/gists{/gist_id}","starred_url":"https://api.github.com/users/juliapacula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliapacula/subscriptions","organizations_url":"https://api.github.com/users/juliapacula/orgs","repos_url":"https://api.github.com/users/juliapacula/repos","events_url":"https://api.github.com/users/juliapacula/events{/privacy}","received_events_url":"https://api.github.com/users/juliapacula/received_events","type":"User","site_admin":false},"body":"Fixes #81\r\n\r\n## Proposed Changes\r\n\r\n- provide error message for shorter passwords instead of doing no action\r\n- fix error checking for lastName field in register form\r\n\r\n","created_at":"2018-04-28T16:02:55Z","updated_at":"2018-05-05T19:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22fa058f3631ad9b4f5d8cd0280119cce2a1dda4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201/commits","review_comments_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201/comments","review_comment_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/201/comments","statuses_url":"https://api.github.com/repos/jpowie01/MedTagger/statuses/377f9ff8f5a2973db108a94dae9eca21280b266d","head":{"label":"jpowie01:fix_registration_error","ref":"fix_registration_error","sha":"377f9ff8f5a2973db108a94dae9eca21280b266d","user":{"login":"jpowie01","id":6514553,"avatar_url":"https://avatars1.githubusercontent.com/u/6514553?v=4","gravatar_id":"","url":"https://api.github.com/users/jpowie01","html_url":"https://github.com/jpowie01","followers_url":"https://api.github.com/users/jpowie01/followers","following_url":"https://api.github.com/users/jpowie01/following{/other_user}","gists_url":"https://api.github.com/users/jpowie01/gists{/gist_id}","starred_url":"https://api.github.com/users/jpowie01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpowie01/subscriptions","organizations_url":"https://api.github.com/users/jpowie01/orgs","repos_url":"https://api.github.com/users/jpowie01/repos","events_url":"https://api.github.com/users/jpowie01/events{/privacy}","received_events_url":"https://api.github.com/users/jpowie01/received_events","type":"User","site_admin":false},"repo":{"id":113898428,"name":"MedTagger","full_name":"jpowie01/MedTagger","owner":{"login":"jpowie01","id":6514553,"avatar_url":"https://avatars1.githubusercontent.com/u/6514553?v=4","gravatar_id":"","url":"https://api.github.com/users/jpowie01","html_url":"https://github.com/jpowie01","followers_url":"https://api.github.com/users/jpowie01/followers","following_url":"https://api.github.com/users/jpowie01/following{/other_user}","gists_url":"https://api.github.com/users/jpowie01/gists{/gist_id}","starred_url":"https://api.github.com/users/jpowie01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpowie01/subscriptions","organizations_url":"https://api.github.com/users/jpowie01/orgs","repos_url":"https://api.github.com/users/jpowie01/repos","events_url":"https://api.github.com/users/jpowie01/events{/privacy}","received_events_url":"https://api.github.com/users/jpowie01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpowie01/MedTagger","description":"A collaborative framework for annotating medical datasets.","fork":false,"url":"https://api.github.com/repos/jpowie01/MedTagger","forks_url":"https://api.github.com/repos/jpowie01/MedTagger/forks","keys_url":"https://api.github.com/repos/jpowie01/MedTagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpowie01/MedTagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpowie01/MedTagger/teams","hooks_url":"https://api.github.com/repos/jpowie01/MedTagger/hooks","issue_events_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/events{/number}","events_url":"https://api.github.com/repos/jpowie01/MedTagger/events","assignees_url":"https://api.github.com/repos/jpowie01/MedTagger/assignees{/user}","branches_url":"https://api.github.com/repos/jpowie01/MedTagger/branches{/branch}","tags_url":"https://api.github.com/repos/jpowie01/MedTagger/tags","blobs_url":"https://api.github.com/repos/jpowie01/MedTagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpowie01/MedTagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpowie01/MedTagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpowie01/MedTagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpowie01/MedTagger/statuses/{sha}","languages_url":"https://api.github.com/repos/jpowie01/MedTagger/languages","stargazers_url":"https://api.github.com/repos/jpowie01/MedTagger/stargazers","contributors_url":"https://api.github.com/repos/jpowie01/MedTagger/contributors","subscribers_url":"https://api.github.com/repos/jpowie01/MedTagger/subscribers","subscription_url":"https://api.github.com/repos/jpowie01/MedTagger/subscription","commits_url":"https://api.github.com/repos/jpowie01/MedTagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpowie01/MedTagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpowie01/MedTagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpowie01/MedTagger/contents/{+path}","compare_url":"https://api.github.com/repos/jpowie01/MedTagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpowie01/MedTagger/merges","archive_url":"https://api.github.com/repos/jpowie01/MedTagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpowie01/MedTagger/downloads","issues_url":"https://api.github.com/repos/jpowie01/MedTagger/issues{/number}","pulls_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls{/number}","milestones_url":"https://api.github.com/repos/jpowie01/MedTagger/milestones{/number}","notifications_url":"https://api.github.com/repos/jpowie01/MedTagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpowie01/MedTagger/labels{/name}","releases_url":"https://api.github.com/repos/jpowie01/MedTagger/releases{/id}","deployments_url":"https://api.github.com/repos/jpowie01/MedTagger/deployments","created_at":"2017-12-11T19:18:04Z","updated_at":"2018-05-05T16:21:30Z","pushed_at":"2018-05-05T17:32:36Z","git_url":"git://github.com/jpowie01/MedTagger.git","ssh_url":"git@github.com:jpowie01/MedTagger.git","clone_url":"https://github.com/jpowie01/MedTagger.git","svn_url":"https://github.com/jpowie01/MedTagger","homepage":"","size":30005,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":75,"watchers":8,"default_branch":"master"}},"base":{"label":"jpowie01:master","ref":"master","sha":"42d5fe5c2af4d5ad87fc8286d8365d09ef3d909a","user":{"login":"jpowie01","id":6514553,"avatar_url":"https://avatars1.githubusercontent.com/u/6514553?v=4","gravatar_id":"","url":"https://api.github.com/users/jpowie01","html_url":"https://github.com/jpowie01","followers_url":"https://api.github.com/users/jpowie01/followers","following_url":"https://api.github.com/users/jpowie01/following{/other_user}","gists_url":"https://api.github.com/users/jpowie01/gists{/gist_id}","starred_url":"https://api.github.com/users/jpowie01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpowie01/subscriptions","organizations_url":"https://api.github.com/users/jpowie01/orgs","repos_url":"https://api.github.com/users/jpowie01/repos","events_url":"https://api.github.com/users/jpowie01/events{/privacy}","received_events_url":"https://api.github.com/users/jpowie01/received_events","type":"User","site_admin":false},"repo":{"id":113898428,"name":"MedTagger","full_name":"jpowie01/MedTagger","owner":{"login":"jpowie01","id":6514553,"avatar_url":"https://avatars1.githubusercontent.com/u/6514553?v=4","gravatar_id":"","url":"https://api.github.com/users/jpowie01","html_url":"https://github.com/jpowie01","followers_url":"https://api.github.com/users/jpowie01/followers","following_url":"https://api.github.com/users/jpowie01/following{/other_user}","gists_url":"https://api.github.com/users/jpowie01/gists{/gist_id}","starred_url":"https://api.github.com/users/jpowie01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpowie01/subscriptions","organizations_url":"https://api.github.com/users/jpowie01/orgs","repos_url":"https://api.github.com/users/jpowie01/repos","events_url":"https://api.github.com/users/jpowie01/events{/privacy}","received_events_url":"https://api.github.com/users/jpowie01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpowie01/MedTagger","description":"A collaborative framework for annotating medical datasets.","fork":false,"url":"https://api.github.com/repos/jpowie01/MedTagger","forks_url":"https://api.github.com/repos/jpowie01/MedTagger/forks","keys_url":"https://api.github.com/repos/jpowie01/MedTagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpowie01/MedTagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpowie01/MedTagger/teams","hooks_url":"https://api.github.com/repos/jpowie01/MedTagger/hooks","issue_events_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/events{/number}","events_url":"https://api.github.com/repos/jpowie01/MedTagger/events","assignees_url":"https://api.github.com/repos/jpowie01/MedTagger/assignees{/user}","branches_url":"https://api.github.com/repos/jpowie01/MedTagger/branches{/branch}","tags_url":"https://api.github.com/repos/jpowie01/MedTagger/tags","blobs_url":"https://api.github.com/repos/jpowie01/MedTagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpowie01/MedTagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpowie01/MedTagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpowie01/MedTagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpowie01/MedTagger/statuses/{sha}","languages_url":"https://api.github.com/repos/jpowie01/MedTagger/languages","stargazers_url":"https://api.github.com/repos/jpowie01/MedTagger/stargazers","contributors_url":"https://api.github.com/repos/jpowie01/MedTagger/contributors","subscribers_url":"https://api.github.com/repos/jpowie01/MedTagger/subscribers","subscription_url":"https://api.github.com/repos/jpowie01/MedTagger/subscription","commits_url":"https://api.github.com/repos/jpowie01/MedTagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpowie01/MedTagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpowie01/MedTagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpowie01/MedTagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpowie01/MedTagger/contents/{+path}","compare_url":"https://api.github.com/repos/jpowie01/MedTagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpowie01/MedTagger/merges","archive_url":"https://api.github.com/repos/jpowie01/MedTagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpowie01/MedTagger/downloads","issues_url":"https://api.github.com/repos/jpowie01/MedTagger/issues{/number}","pulls_url":"https://api.github.com/repos/jpowie01/MedTagger/pulls{/number}","milestones_url":"https://api.github.com/repos/jpowie01/MedTagger/milestones{/number}","notifications_url":"https://api.github.com/repos/jpowie01/MedTagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpowie01/MedTagger/labels{/name}","releases_url":"https://api.github.com/repos/jpowie01/MedTagger/releases{/id}","deployments_url":"https://api.github.com/repos/jpowie01/MedTagger/deployments","created_at":"2017-12-11T19:18:04Z","updated_at":"2018-05-05T16:21:30Z","pushed_at":"2018-05-05T17:32:36Z","git_url":"git://github.com/jpowie01/MedTagger.git","ssh_url":"git@github.com:jpowie01/MedTagger.git","clone_url":"https://github.com/jpowie01/MedTagger.git","svn_url":"https://github.com/jpowie01/MedTagger","homepage":"","size":30005,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":75,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201"},"html":{"href":"https://github.com/jpowie01/MedTagger/pull/201"},"issue":{"href":"https://api.github.com/repos/jpowie01/MedTagger/issues/201"},"comments":{"href":"https://api.github.com/repos/jpowie01/MedTagger/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpowie01/MedTagger/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/jpowie01/MedTagger/statuses/377f9ff8f5a2973db108a94dae9eca21280b266d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Darkoon"}}