{"action":"opened","number":334,"pull_request":{"url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334","id":233417731,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDE3NzMx","html_url":"https://github.com/haskell-distributed/distributed-process/pull/334","diff_url":"https://github.com/haskell-distributed/distributed-process/pull/334.diff","patch_url":"https://github.com/haskell-distributed/distributed-process/pull/334.patch","issue_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/334","number":334,"state":"open","locked":false,"title":"RFC on this approach - NB: this pull request is incomplete","user":{"login":"hyperthunk","id":36876,"node_id":"MDQ6VXNlcjM2ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/36876?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperthunk","html_url":"https://github.com/hyperthunk","followers_url":"https://api.github.com/users/hyperthunk/followers","following_url":"https://api.github.com/users/hyperthunk/following{/other_user}","gists_url":"https://api.github.com/users/hyperthunk/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperthunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperthunk/subscriptions","organizations_url":"https://api.github.com/users/hyperthunk/orgs","repos_url":"https://api.github.com/users/hyperthunk/repos","events_url":"https://api.github.com/users/hyperthunk/events{/privacy}","received_events_url":"https://api.github.com/users/hyperthunk/received_events","type":"User","site_admin":false},"body":"I _think_ the approach outlined in this patch set is a reasonable solution for #333. I would envisage moving a few of the more racy/flaky test cases over to this approach. I'd like some feedback on the general advisability if possible, before moving a few other test cases and merging.\r\n\r\nIt would be worth seeing if my argument in #333 about the scheduler creating the failure conditions for our test case, holds up to scrutiny. \r\n\r\nI would prefer if this were ultimately in some kind of integration-test package, executed on a build pipeline once the regular test suites are complete. Sadly travis doesn't really have a proper notion of pipelines (frankly, apart from Jenkins/Hudson and Bamboo, I've seen for CI systems that offer a strong build pipeline capability, and none for free)...\r\n\r\nAnd before someone says it, I *absolutely* think we should start doing model based testing in addition to this approach. I've been looking at https://github.com/advancedtelematic/quickcheck-state-machine-distributed, and considering some other options.\r\n\r\nAnyway... Does this patch make sense, and do you agree with my thoughts in #333? Because if you think I'm barking up the wrong tree, then this is a pointless additional of technical debt, and complicates the CI build quite a bit. ","created_at":"2018-11-26T01:41:17Z","updated_at":"2018-11-26T01:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334/commits","review_comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334/comments","review_comment_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/334/comments","statuses_url":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/1d75227009d1bd0b7268eb553c77908ddb2a66bd","head":{"label":"haskell-distributed:tw/multi-os-proc-tests","ref":"tw/multi-os-proc-tests","sha":"1d75227009d1bd0b7268eb553c77908ddb2a66bd","user":{"login":"haskell-distributed","id":1215670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTU2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1215670?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":2836059,"node_id":"MDEwOlJlcG9zaXRvcnkyODM2MDU5","name":"distributed-process","full_name":"haskell-distributed/distributed-process","private":false,"owner":{"login":"haskell-distributed","id":1215670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTU2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1215670?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/haskell-distributed/distributed-process","description":"Cloud Haskell core library","fork":false,"url":"https://api.github.com/repos/haskell-distributed/distributed-process","forks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/forks","keys_url":"https://api.github.com/repos/haskell-distributed/distributed-process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-distributed/distributed-process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-distributed/distributed-process/teams","hooks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/hooks","issue_events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/events","assignees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-distributed/distributed-process/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/tags","blobs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-distributed/distributed-process/languages","stargazers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/stargazers","contributors_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contributors","subscribers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscribers","subscription_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscription","commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-distributed/distributed-process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-distributed/distributed-process/merges","archive_url":"https://api.github.com/repos/haskell-distributed/distributed-process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-distributed/distributed-process/downloads","issues_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-distributed/distributed-process/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-distributed/distributed-process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-distributed/distributed-process/labels{/name}","releases_url":"https://api.github.com/repos/haskell-distributed/distributed-process/releases{/id}","deployments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/deployments","created_at":"2011-11-23T13:59:00Z","updated_at":"2018-11-25T12:43:47Z","pushed_at":"2018-11-26T01:30:34Z","git_url":"git://github.com/haskell-distributed/distributed-process.git","ssh_url":"git@github.com:haskell-distributed/distributed-process.git","clone_url":"https://github.com/haskell-distributed/distributed-process.git","svn_url":"https://github.com/haskell-distributed/distributed-process","homepage":"http://haskell-distributed.github.com","size":4587,"stargazers_count":574,"watchers_count":574,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":78,"open_issues":67,"watchers":574,"default_branch":"master"}},"base":{"label":"haskell-distributed:master","ref":"master","sha":"c04f637309d40e8598b7a1139ed4178353eb50de","user":{"login":"haskell-distributed","id":1215670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTU2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1215670?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":2836059,"node_id":"MDEwOlJlcG9zaXRvcnkyODM2MDU5","name":"distributed-process","full_name":"haskell-distributed/distributed-process","private":false,"owner":{"login":"haskell-distributed","id":1215670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTU2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1215670?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/haskell-distributed/distributed-process","description":"Cloud Haskell core library","fork":false,"url":"https://api.github.com/repos/haskell-distributed/distributed-process","forks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/forks","keys_url":"https://api.github.com/repos/haskell-distributed/distributed-process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-distributed/distributed-process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-distributed/distributed-process/teams","hooks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/hooks","issue_events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/events","assignees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-distributed/distributed-process/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/tags","blobs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-distributed/distributed-process/languages","stargazers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/stargazers","contributors_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contributors","subscribers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscribers","subscription_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscription","commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-distributed/distributed-process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-distributed/distributed-process/merges","archive_url":"https://api.github.com/repos/haskell-distributed/distributed-process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-distributed/distributed-process/downloads","issues_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-distributed/distributed-process/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-distributed/distributed-process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-distributed/distributed-process/labels{/name}","releases_url":"https://api.github.com/repos/haskell-distributed/distributed-process/releases{/id}","deployments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/deployments","created_at":"2011-11-23T13:59:00Z","updated_at":"2018-11-25T12:43:47Z","pushed_at":"2018-11-26T01:30:34Z","git_url":"git://github.com/haskell-distributed/distributed-process.git","ssh_url":"git@github.com:haskell-distributed/distributed-process.git","clone_url":"https://github.com/haskell-distributed/distributed-process.git","svn_url":"https://github.com/haskell-distributed/distributed-process","homepage":"http://haskell-distributed.github.com","size":4587,"stargazers_count":574,"watchers_count":574,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":78,"open_issues":67,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334"},"html":{"href":"https://github.com/haskell-distributed/distributed-process/pull/334"},"issue":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/334"},"comments":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/1d75227009d1bd0b7268eb553c77908ddb2a66bd"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":263,"deletions":8,"changed_files":6}}
{"actor":{"display_login":"hyperthunk"}}