{"action":"created","issue":{"url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/125","repository_url":"https://api.github.com/repos/NCAR/ccpp-physics","labels_url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/125/comments","events_url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/125/events","html_url":"https://github.com/NCAR/ccpp-physics/pull/125","id":342086369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDcxMDE2","number":125,"title":"update to deep convection interstitials","user":{"login":"grantfirl","id":25489104,"node_id":"MDQ6VXNlcjI1NDg5MTA0","avatar_url":"https://avatars0.githubusercontent.com/u/25489104?v=4","gravatar_id":"","url":"https://api.github.com/users/grantfirl","html_url":"https://github.com/grantfirl","followers_url":"https://api.github.com/users/grantfirl/followers","following_url":"https://api.github.com/users/grantfirl/following{/other_user}","gists_url":"https://api.github.com/users/grantfirl/gists{/gist_id}","starred_url":"https://api.github.com/users/grantfirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantfirl/subscriptions","organizations_url":"https://api.github.com/users/grantfirl/orgs","repos_url":"https://api.github.com/users/grantfirl/repos","events_url":"https://api.github.com/users/grantfirl/events{/privacy}","received_events_url":"https://api.github.com/users/grantfirl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-17T21:11:07Z","updated_at":"2018-07-18T16:57:54Z","closed_at":"2018-07-18T16:55:33Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NCAR/ccpp-physics/pulls/125","html_url":"https://github.com/NCAR/ccpp-physics/pull/125","diff_url":"https://github.com/NCAR/ccpp-physics/pull/125.diff","patch_url":"https://github.com/NCAR/ccpp-physics/pull/125.patch"},"body":"I updated GFS_DCNV_generic_pre/post to no longer use GFS DDTs since their use limited other models in their data organization. This required passing in many new variables that had previously been part of DDTs. Some corresponding new standard names were added in GFS_typedefs in FV3 and in gmtb_scm_type_defs in SCM. In addition, there was a code stanza added to not break gocart functionality (even though this is not operational) since it would have needed to have been done at some point anyway! Code related to determining array indices for the 'phy_f3d' variable was removed since it was already included in a subroutine within GFS_typedefs during initialization. Instead, the correct portion of phy_f3d is passed in to the routine (using the previously calculated value of ncnvw)."},"comment":{"url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/comments/406002338","html_url":"https://github.com/NCAR/ccpp-physics/pull/125#issuecomment-406002338","issue_url":"https://api.github.com/repos/NCAR/ccpp-physics/issues/125","id":406002338,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjAwMjMzOA==","user":{"login":"grantfirl","id":25489104,"node_id":"MDQ6VXNlcjI1NDg5MTA0","avatar_url":"https://avatars0.githubusercontent.com/u/25489104?v=4","gravatar_id":"","url":"https://api.github.com/users/grantfirl","html_url":"https://github.com/grantfirl","followers_url":"https://api.github.com/users/grantfirl/followers","following_url":"https://api.github.com/users/grantfirl/following{/other_user}","gists_url":"https://api.github.com/users/grantfirl/gists{/gist_id}","starred_url":"https://api.github.com/users/grantfirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantfirl/subscriptions","organizations_url":"https://api.github.com/users/grantfirl/orgs","repos_url":"https://api.github.com/users/grantfirl/repos","events_url":"https://api.github.com/users/grantfirl/events{/privacy}","received_events_url":"https://api.github.com/users/grantfirl/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T16:57:53Z","updated_at":"2018-07-18T16:57:53Z","author_association":"COLLABORATOR","body":"I agree with your reasoning and solution. I see that you merged and will\naddress this in another PR.\n\nOn Wed, Jul 18, 2018, 9:24 AM Dom Heinzeller <notifications@github.com>\nwrote:\n\n> *@climbfuji* commented on this pull request.\n> ------------------------------\n>\n> In physics/GFS_DCNV_generic.f90\n> <https://github.com/NCAR/ccpp-physics/pull/125#discussion_r203423147>:\n>\n> >\n> -      real(kind=kind_phys), intent(in) :: frain\n> -      real(kind=kind_phys), dimension(size(Grid%xlon,1)), intent(in) :: rain1, cld1d\n> -      real(kind=kind_phys), dimension(size(Grid%xlon,1),Model%levs), intent(in) :: save_u, save_v, save_t, save_qv\n> -      real(kind=kind_phys), dimension(size(Grid%xlon,1),Model%levs), intent(in) :: ud_mf, dd_mf, dt_mf\n> -      real(kind=kind_phys), dimension(size(Grid%xlon,1),Model%levs), intent(in) :: cnvw, cnvc\n> +      real(kind=kind_phys), dimension(im), intent(inout) :: rainc, cldwrk, cnvprcp, cnvprcpb\n> +      real(kind=kind_phys), dimension(im, levs), intent(inout) :: dt3dt, dq3dt, du3dt, dv3dt\n>\n> I think we should play safe here and not specify the dimension extents for\n> arrays that might be allocated or not, depending on certain switches. For\n> instance, dt3dt is only allocated if ldiag3d is true:\n>\n>     if (Model%ldiag3d) then\n>       allocate (Diag%du3dt  (IM,Model%levs,4))\n>       allocate (Diag%dv3dt  (IM,Model%levs,4))\n>       allocate (Diag%dt3dt  (IM,Model%levs,6))\n>       allocate (Diag%dq3dt  (IM,Model%levs,oz_coeff+5))\n> !--- needed to allocate GoCart coupling fields\n>       allocate (Diag%upd_mf (IM,Model%levs))\n>       allocate (Diag%dwn_mf (IM,Model%levs))\n>       allocate (Diag%det_mf (IM,Model%levs))\n>       allocate (Diag%cldcov (IM,Model%levs))\n>     endif\n>\n> I would not specify the dimensional extent, for example\n>\n> real(kind=kind_phys), dimension(:, :), intent(inout) :: dt3dt, dq3dt,\n> du3dt, dv3dt\n>\n> to be on the safe side.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/NCAR/ccpp-physics/pull/125#pullrequestreview-138308919>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AYTu0HVtrOkwEtv5SHrS2FFSevGc2V5qks5uH1MqgaJpZM4VTkqo>\n> .\n>\n"}}
{"actor":{"display_login":"grantfirl"}}