{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/199974548","pull_request_review_id":134198299,"id":199974548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk3NDU0OA==","diff_hunk":"@@ -23,6 +24,13 @@ const jujuMachineKey = \"juju-machine-id\"\n // being upgraded.\n func BootstrapRaft(context Context) error {\n \tagentConfig := context.AgentConfig()\n+\tstorageDir := filepath.Join(agentConfig.DataDir(), \"raft\")","path":"upgrades/raft.go","position":12,"original_position":12,"commit_id":"fc8a1378ccb8ddac77737c1ec0e30477c63aba5d","original_commit_id":"fc8a1378ccb8ddac77737c1ec0e30477c63aba5d","user":{"login":"howbazaar","id":1744247,"node_id":"MDQ6VXNlcjE3NDQyNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1744247?v=4","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"Do you think that just looking for the directory is sufficient?","created_at":"2018-07-03T23:20:14Z","updated_at":"2018-07-03T23:20:36Z","html_url":"https://github.com/juju/juju/pull/8886#discussion_r199974548","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8886","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/199974548"},"html":{"href":"https://github.com/juju/juju/pull/8886#discussion_r199974548"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8886"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8886","id":199099708,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDk5NzA4","html_url":"https://github.com/juju/juju/pull/8886","diff_url":"https://github.com/juju/juju/pull/8886.diff","patch_url":"https://github.com/juju/juju/pull/8886.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8886","number":8886,"state":"open","locked":false,"title":"Make raft upgrade step idempotent","user":{"login":"babbageclunk","id":563399,"node_id":"MDQ6VXNlcjU2MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/563399?v=4","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"body":"## Description of change\r\nUpgrade steps should be idempotent because they get rerun when upgrading from (for example) pre-release versions or earlier minor versions. In this case the upgrade step to bootstrap the raft cluster needed to check that it hadn't already been done, either by bootstrapping or upgrading to 2.4-rc3. \r\n\r\n## QA steps\r\n* Bootstrap with 2.4-rc3 - this will initialise the raft cluster. Then upgrade to a version with this fix. The upgrade will skip trying to bootstrap the raft cluster again, so the upgrade should succeed and raft should still be running.\r\n* Bootstrap with 2.3.8 and upgrade to a version with this fix - the upgrade should bootstrap the raft cluster.\r\n\r\n## Bug reference\r\nhttps://bugs.launchpad.net/juju/+bug/1779904\r\n","created_at":"2018-07-03T22:37:55Z","updated_at":"2018-07-03T23:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbda036e48309628873fb6ef2cbf16ca41669f0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8886/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8886/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8886/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/fc8a1378ccb8ddac77737c1ec0e30477c63aba5d","head":{"label":"babbageclunk:fix-raft-upgrade","ref":"fix-raft-upgrade","sha":"fc8a1378ccb8ddac77737c1ec0e30477c63aba5d","user":{"login":"babbageclunk","id":563399,"node_id":"MDQ6VXNlcjU2MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/563399?v=4","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"repo":{"id":54490872,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQ5MDg3Mg==","name":"juju","full_name":"babbageclunk/juju","owner":{"login":"babbageclunk","id":563399,"node_id":"MDQ6VXNlcjU2MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/563399?v=4","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babbageclunk/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/babbageclunk/juju","forks_url":"https://api.github.com/repos/babbageclunk/juju/forks","keys_url":"https://api.github.com/repos/babbageclunk/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babbageclunk/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babbageclunk/juju/teams","hooks_url":"https://api.github.com/repos/babbageclunk/juju/hooks","issue_events_url":"https://api.github.com/repos/babbageclunk/juju/issues/events{/number}","events_url":"https://api.github.com/repos/babbageclunk/juju/events","assignees_url":"https://api.github.com/repos/babbageclunk/juju/assignees{/user}","branches_url":"https://api.github.com/repos/babbageclunk/juju/branches{/branch}","tags_url":"https://api.github.com/repos/babbageclunk/juju/tags","blobs_url":"https://api.github.com/repos/babbageclunk/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babbageclunk/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babbageclunk/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/babbageclunk/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babbageclunk/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/babbageclunk/juju/languages","stargazers_url":"https://api.github.com/repos/babbageclunk/juju/stargazers","contributors_url":"https://api.github.com/repos/babbageclunk/juju/contributors","subscribers_url":"https://api.github.com/repos/babbageclunk/juju/subscribers","subscription_url":"https://api.github.com/repos/babbageclunk/juju/subscription","commits_url":"https://api.github.com/repos/babbageclunk/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/babbageclunk/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/babbageclunk/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/babbageclunk/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/babbageclunk/juju/contents/{+path}","compare_url":"https://api.github.com/repos/babbageclunk/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babbageclunk/juju/merges","archive_url":"https://api.github.com/repos/babbageclunk/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babbageclunk/juju/downloads","issues_url":"https://api.github.com/repos/babbageclunk/juju/issues{/number}","pulls_url":"https://api.github.com/repos/babbageclunk/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/babbageclunk/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/babbageclunk/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babbageclunk/juju/labels{/name}","releases_url":"https://api.github.com/repos/babbageclunk/juju/releases{/id}","deployments_url":"https://api.github.com/repos/babbageclunk/juju/deployments","created_at":"2016-03-22T16:26:25Z","updated_at":"2016-03-22T16:26:34Z","pushed_at":"2018-07-03T22:28:36Z","git_url":"git://github.com/babbageclunk/juju.git","ssh_url":"git@github.com:babbageclunk/juju.git","clone_url":"https://github.com/babbageclunk/juju.git","svn_url":"https://github.com/babbageclunk/juju","homepage":"juju.ubuntu.com","size":213258,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:2.4","ref":"2.4","sha":"f5be98c47800b20126f5bec38817dc4015164a92","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-07-03T04:36:04Z","pushed_at":"2018-07-03T23:14:36Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":213700,"stargazers_count":1177,"watchers_count":1177,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":273,"open_issues":23,"watchers":1177,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8886"},"html":{"href":"https://github.com/juju/juju/pull/8886"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8886"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8886/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8886/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8886/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/fc8a1378ccb8ddac77737c1ec0e30477c63aba5d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"howbazaar"}}