{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/8427","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/8427/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/8427/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/8427/events","html_url":"https://github.com/librenms/librenms/pull/8427","id":306921727,"number":8427,"title":"fix: Apply divisor / multiplier to high/low limits in sensors","user":{"login":"laf","id":3941142,"avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"labels":[{"id":62946216,"url":"https://api.github.com/repos/librenms/librenms/labels/Bug%20:beetle:","name":"Bug :beetle:","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-20T15:41:09Z","updated_at":"2018-04-10T21:35:49Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/8427","html_url":"https://github.com/librenms/librenms/pull/8427","diff_url":"https://github.com/librenms/librenms/pull/8427.diff","patch_url":"https://github.com/librenms/librenms/pull/8427.patch"},"body":"DO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n\r\nFixes: #8163 \r\n\r\nIf a numeric value is provided for _limits then it's used as is. If not, we apply the divisor / multiplier to those limits. I've been through all the yaml files and the only one which will have an issue with this is the one I've changed to hard coded limits. The devices value requires a divisor but the _limits don't.\r\n\r\nUncommented the _limit values from the yaml that the issue references as it was commented out due to this.\r\n\r\nThis will fix some high/low limits for yaml files where it should have been applied to but isn't."},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/380254833","html_url":"https://github.com/librenms/librenms/pull/8427#issuecomment-380254833","issue_url":"https://api.github.com/repos/librenms/librenms/issues/8427","id":380254833,"user":{"login":"laf","id":3941142,"avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T21:35:49Z","updated_at":"2018-04-10T21:35:49Z","author_association":"OWNER","body":"Finally!"}}
{"actor":{"display_login":"laf"}}