{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/68","repository_url":"https://api.github.com/repos/Microsoft/BotBuilder-V3","labels_url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/68/comments","events_url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/68/events","html_url":"https://github.com/Microsoft/BotBuilder-V3/issues/68","id":381731708,"node_id":"MDU6SXNzdWUzODE3MzE3MDg=","number":68,"title":"AdalAuthenticator does not accept empty MicrosoftAppId and MicrosoftAppPassword","user":{"login":"EricDahlvang","id":11055362,"node_id":"MDQ6VXNlcjExMDU1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/11055362?v=4","gravatar_id":"","url":"https://api.github.com/users/EricDahlvang","html_url":"https://github.com/EricDahlvang","followers_url":"https://api.github.com/users/EricDahlvang/followers","following_url":"https://api.github.com/users/EricDahlvang/following{/other_user}","gists_url":"https://api.github.com/users/EricDahlvang/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDahlvang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDahlvang/subscriptions","organizations_url":"https://api.github.com/users/EricDahlvang/orgs","repos_url":"https://api.github.com/users/EricDahlvang/repos","events_url":"https://api.github.com/users/EricDahlvang/events{/privacy}","received_events_url":"https://api.github.com/users/EricDahlvang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"EricDahlvang","id":11055362,"node_id":"MDQ6VXNlcjExMDU1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/11055362?v=4","gravatar_id":"","url":"https://api.github.com/users/EricDahlvang","html_url":"https://github.com/EricDahlvang","followers_url":"https://api.github.com/users/EricDahlvang/followers","following_url":"https://api.github.com/users/EricDahlvang/following{/other_user}","gists_url":"https://api.github.com/users/EricDahlvang/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDahlvang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDahlvang/subscriptions","organizations_url":"https://api.github.com/users/EricDahlvang/orgs","repos_url":"https://api.github.com/users/EricDahlvang/repos","events_url":"https://api.github.com/users/EricDahlvang/events{/privacy}","received_events_url":"https://api.github.com/users/EricDahlvang/received_events","type":"User","site_admin":false},"assignees":[{"login":"EricDahlvang","id":11055362,"node_id":"MDQ6VXNlcjExMDU1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/11055362?v=4","gravatar_id":"","url":"https://api.github.com/users/EricDahlvang","html_url":"https://github.com/EricDahlvang","followers_url":"https://api.github.com/users/EricDahlvang/followers","following_url":"https://api.github.com/users/EricDahlvang/following{/other_user}","gists_url":"https://api.github.com/users/EricDahlvang/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDahlvang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDahlvang/subscriptions","organizations_url":"https://api.github.com/users/EricDahlvang/orgs","repos_url":"https://api.github.com/users/EricDahlvang/repos","events_url":"https://api.github.com/users/EricDahlvang/events{/privacy}","received_events_url":"https://api.github.com/users/EricDahlvang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-16T19:33:09Z","updated_at":"2018-11-20T01:50:48Z","closed_at":"2018-11-20T01:50:48Z","author_association":"COLLABORATOR","body":"## Version\r\nClean pull of the repository.\r\n\r\n## Describe the bug\r\nArgumentNullException when messaging a bot without MicrosoftAppId and MicrosoftAppPassword\r\n\r\n## To Reproduce\r\nSteps to reproduce the behavior:\r\n1. download the source\r\n2. set EchoBot as the startup project\r\n3. remove the MicrosoftAppId and MicrosoftAppPassword from web.config\r\n4. run the bot\r\n5. connect to the local bot from the emulator without appid and password\r\n6. send the bot a message and observe exception\r\n\r\n> System.ArgumentNullException: 'Value cannot be null.\r\n> Parameter name: clientId'\r\n> \r\n> \r\n\r\nStack Trace:\r\n \r\n\r\n>   at Microsoft.IdentityModel.Clients.ActiveDirectory.ClientCredential..ctor(String clientId, String clientSecret)\r\n>    at Microsoft.Bot.Connector.MicrosoftAppCredentials..ctor(String appId, String password) in C:\\work\\v3\\clean11.16.2018\\BotBuilder-V3\\CSharp\\Library\\Microsoft.Bot.Connector.Shared\\MicrosoftAppCredentials.cs:line 65\r\n>    at lambda_method(Closure , Object[] )\r\n>    at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate()\r\n\r\n## Expected behavior\r\nCommunicating with a bot from the emulator without an appid and password in bot or emulator should work\r\n\r\n## Screenshots\r\n![image](https://user-images.githubusercontent.com/11055362/48642964-3dbc1200-e993-11e8-9d48-84209c87c86e.png)\r\n\r\n\r\n## Additional context\r\nIntroduced with https://github.com/Microsoft/BotBuilder-V3/pull/53\r\n\r\n[bug]\r\n[dotnet]\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/comments/440107361","html_url":"https://github.com/Microsoft/BotBuilder-V3/issues/68#issuecomment-440107361","issue_url":"https://api.github.com/repos/Microsoft/BotBuilder-V3/issues/68","id":440107361,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDEwNzM2MQ==","user":{"login":"EricDahlvang","id":11055362,"node_id":"MDQ6VXNlcjExMDU1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/11055362?v=4","gravatar_id":"","url":"https://api.github.com/users/EricDahlvang","html_url":"https://github.com/EricDahlvang","followers_url":"https://api.github.com/users/EricDahlvang/followers","following_url":"https://api.github.com/users/EricDahlvang/following{/other_user}","gists_url":"https://api.github.com/users/EricDahlvang/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDahlvang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDahlvang/subscriptions","organizations_url":"https://api.github.com/users/EricDahlvang/orgs","repos_url":"https://api.github.com/users/EricDahlvang/repos","events_url":"https://api.github.com/users/EricDahlvang/events{/privacy}","received_events_url":"https://api.github.com/users/EricDahlvang/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T01:50:48Z","updated_at":"2018-11-20T01:50:48Z","author_association":"COLLABORATOR","body":"Fixed!"}}
{"actor":{"display_login":"EricDahlvang"}}