{"action":"closed","issue":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1491","repository_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1491/labels{/name}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1491/comments","events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/1491/events","html_url":"https://github.com/OpenBazaar/openbazaar-desktop/issues/1491","id":345893516,"node_id":"MDU6SXNzdWUzNDU4OTM1MTY=","number":1491,"title":"Multicoin Integration - Settings ","user":{"login":"jjeffryes","id":1584275,"node_id":"MDQ6VXNlcjE1ODQyNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1584275?v=4","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"labels":[{"id":491955016,"node_id":"MDU6TGFiZWw0OTE5NTUwMTY=","url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/labels/requirements","name":"requirements","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":{"login":"jjeffryes","id":1584275,"node_id":"MDQ6VXNlcjE1ODQyNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1584275?v=4","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"assignees":[{"login":"jjeffryes","id":1584275,"node_id":"MDQ6VXNlcjE1ODQyNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1584275?v=4","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/milestones/16","html_url":"https://github.com/OpenBazaar/openbazaar-desktop/milestone/16","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/milestones/16/labels","id":3520361,"node_id":"MDk6TWlsZXN0b25lMzUyMDM2MQ==","number":16,"title":"2.3","description":"Integration with the multi-coin API based wallet.","creator":{"login":"jjeffryes","id":1584275,"node_id":"MDQ6VXNlcjE1ODQyNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1584275?v=4","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":4,"state":"open","created_at":"2018-07-24T16:46:53Z","updated_at":"2018-10-29T20:25:53Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-30T19:07:06Z","updated_at":"2018-10-29T20:25:53Z","closed_at":"2018-10-29T20:25:53Z","author_association":"CONTRIBUTOR","body":"## User Story\r\n- As a seller, I want to be able to save a set of preferred coins I will accept, so I don't have to set them manually each time I create a listing.\r\n- As a seller, I shouldn't be able to add a moderator to my store if they don't support at least one of my coins.\r\n- As a seller, I would like to know if a moderator's list of accepted coins overlaps with at least one coin on my list of preferred coins.\r\n- As a moderator, I would like to be only added as a moderator to orders for coins I can support.\r\n\r\n## Functional Requirements\r\n\r\n### Settings/Store\r\n- [ ] Add a section to the tab for the seller's list of preferred coins.\r\n    - [ ] The seller should be able to toggle on or off any of the coins their wallets support. This could be a list of coins with checkboxes, a select list that allows selecting multiple values, or any other control.\r\n    - Save to settings.preferredCurrencies.\r\n    - Pull this list from the Config api.\r\n\r\n- There are 3 lists for moderators that need to be updated.\r\n    - The list of current moderators.\r\n    - The search by ID section (it's a list of one moderator at most, but it's still a list).\r\n    - The browse moderators list.\r\n\r\n- [ ] The moderators in the current moderators list might have changed their accepted coins since they were added. If they no longer support at least one of the seller's preferred coins, they should be marked as not matching.\r\n   - This check is currently already in place, but only checks a single coin, and isn't based on the preferred list.\r\n    - This situation should be extremely rare until plug-in wallets become available.\r\n\r\n- [ ] Moderators that don't accept at least one of the seller's preferred coins should still appear in the add by ID section (so it's clear their data was loaded), but should be marked as not matching.\r\n\r\n- [ ] Moderators that don’t accept at least one of the seller’s preferred coins should not be shown in the browse section.\r\n    - Should there be a toggle to show moderators that accept at least one of the seller's supported coins (ie: the seller prefers BTC, but can accept BTC, BCH and ETH, the toggle would show moderators that support at least one of BTC, BCH, or ETH).\r\n    - Should there be a toggle for 100% vs. partial match? In other words, \"accepts all my preferred coins\" vs. \"accepts at least one of my preferred coins\"?\r\n\r\n- [ ] It would be ideal if there was a way to show how much of a match the moderator's accepted list is to the seller's preferred list. For example, a 1 coin overlap should be shown differently from a 100% 5 coin overlap.\r\n    - It would be nice if this was visible on the moderator card, without having to open the moderator details modal to see what coins the moderator supports.\r\n\r\nNOTE: A seller may have BTC, LTC and ZEC on their preferred list, but decide to sell a new listing with BCH. At that point they might not have any moderators that support BCH (unless some of them happen to also have BCH on their accepted lists). The seller wouldn't have an easy way to add a moderator that accepts BCH, unless they temporarily added BCH to their preferred list.\r\n\r\n### Moderator Card\r\n- This will need changes based on how we decide to show the coin matching.\r\n\r\n## API Changes\r\n- [ ] ob/settings\r\n    - Add a preferredCurrencies list to settings.\r\n    - It should be validated to only contains currency codes for coins the user has wallets for.\r\n- [ ] ob/moderators\r\n    - accept a list of coins, only return moderators that support the coins\r\n   - accept a parameter for all or some. ie: if the list is BTC, BCH, LTC, and the parameter is some, return any moderator that matches at least one. If it is all, return only moderators that match all of the coin codes.\r\n- [ ] ob/profile\r\n - When a moderator is saved to the moderators list on the profile, the server should verify that the moderator has at least one compatible supported coin.\r\n- moderatorInfo should accept an acceptedCurrencies field as a list of currency codes. \r\n    - It should be validated to ensure the moderator can actually support all of the saved codes.\r\n    - The acceptedCurrencies list should be populated automatically by the server, since we're not exposing it in the client."}}
{"actor":{"display_login":"jjeffryes"}}