{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/229410336","pull_request_review_id":169905265,"id":229410336,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQxMDMzNg==","diff_hunk":"@@ -582,7 +582,7 @@ class DNSPacketMangler\n     : d_packet(packet), d_length(length), d_notyouroffset(12), d_offset(d_notyouroffset)\n   {}\n   \n-  void skipLabel()\n+  void skipDomainName()","path":"pdns/dnsparser.cc","position":5,"original_position":5,"commit_id":"c1780c41c89cbf31e4c34808f9c07b402e6da939","original_commit_id":"c1780c41c89cbf31e4c34808f9c07b402e6da939","user":{"login":"pieterlexis","id":731232,"node_id":"MDQ6VXNlcjczMTIzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/731232?v=4","gravatar_id":"","url":"https://api.github.com/users/pieterlexis","html_url":"https://github.com/pieterlexis","followers_url":"https://api.github.com/users/pieterlexis/followers","following_url":"https://api.github.com/users/pieterlexis/following{/other_user}","gists_url":"https://api.github.com/users/pieterlexis/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterlexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterlexis/subscriptions","organizations_url":"https://api.github.com/users/pieterlexis/orgs","repos_url":"https://api.github.com/users/pieterlexis/repos","events_url":"https://api.github.com/users/pieterlexis/events{/privacy}","received_events_url":"https://api.github.com/users/pieterlexis/received_events","type":"User","site_admin":false},"body":"It would make sense to add a docblock above the function as well, so the next person who stumbles unto this does not have to figure out what this function _exactly_ does, regardless of the name","created_at":"2018-10-30T17:31:47Z","updated_at":"2018-10-30T17:31:48Z","html_url":"https://github.com/PowerDNS/pdns/pull/7111#discussion_r229410336","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/229410336"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7111#discussion_r229410336"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111","id":226364890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzY0ODkw","html_url":"https://github.com/PowerDNS/pdns/pull/7111","diff_url":"https://github.com/PowerDNS/pdns/pull/7111.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/7111.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7111","number":7111,"state":"open","locked":false,"title":"Rename skipLabel function to skipDomainName","user":{"login":"gibson042","id":1199584,"node_id":"MDQ6VXNlcjExOTk1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1199584?v=4","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"### Short description\r\nRename the `skipLabel` function to `skipDomainName`, since that's what it actually does. I found the parser code very confusing until I figured this out.\r\n\r\n### Checklist\r\nI have:\r\n- [x] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [x] compiled this code\r\n- [x] tested this code\r\n- [ ] included documentation (including possible behaviour changes)\r\n- [x] documented the code\r\n- [ ] added or modified regression test(s)\r\n- [ ] added or modified unit test(s)","created_at":"2018-10-28T12:54:18Z","updated_at":"2018-10-30T17:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"964fad384cc8d80adcc098200ee3de6e23bfd6ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37445974,"node_id":"MDU6TGFiZWwzNzQ0NTk3NA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/auth","name":"auth","color":"eb6420","default":false},{"id":205755699,"node_id":"MDU6TGFiZWwyMDU3NTU2OTk=","url":"https://api.github.com/repos/PowerDNS/pdns/labels/dnsdist","name":"dnsdist","color":"bfd4f2","default":false},{"id":37446008,"node_id":"MDU6TGFiZWwzNzQ0NjAwOA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/enhancement","name":"enhancement","color":"cccccc","default":true},{"id":37445984,"node_id":"MDU6TGFiZWwzNzQ0NTk4NA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/rec","name":"rec","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7111/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/c1780c41c89cbf31e4c34808f9c07b402e6da939","head":{"label":"gibson042:2018-10-skipDomainName","ref":"2018-10-skipDomainName","sha":"c1780c41c89cbf31e4c34808f9c07b402e6da939","user":{"login":"gibson042","id":1199584,"node_id":"MDQ6VXNlcjExOTk1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1199584?v=4","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"repo":{"id":146137890,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxMzc4OTA=","name":"pdns","full_name":"gibson042/pdns","private":false,"owner":{"login":"gibson042","id":1199584,"node_id":"MDQ6VXNlcjExOTk1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1199584?v=4","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gibson042/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/gibson042/pdns","forks_url":"https://api.github.com/repos/gibson042/pdns/forks","keys_url":"https://api.github.com/repos/gibson042/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibson042/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibson042/pdns/teams","hooks_url":"https://api.github.com/repos/gibson042/pdns/hooks","issue_events_url":"https://api.github.com/repos/gibson042/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/gibson042/pdns/events","assignees_url":"https://api.github.com/repos/gibson042/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/gibson042/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/gibson042/pdns/tags","blobs_url":"https://api.github.com/repos/gibson042/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibson042/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibson042/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibson042/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibson042/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/gibson042/pdns/languages","stargazers_url":"https://api.github.com/repos/gibson042/pdns/stargazers","contributors_url":"https://api.github.com/repos/gibson042/pdns/contributors","subscribers_url":"https://api.github.com/repos/gibson042/pdns/subscribers","subscription_url":"https://api.github.com/repos/gibson042/pdns/subscription","commits_url":"https://api.github.com/repos/gibson042/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibson042/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibson042/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibson042/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibson042/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/gibson042/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibson042/pdns/merges","archive_url":"https://api.github.com/repos/gibson042/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibson042/pdns/downloads","issues_url":"https://api.github.com/repos/gibson042/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/gibson042/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/gibson042/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/gibson042/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibson042/pdns/labels{/name}","releases_url":"https://api.github.com/repos/gibson042/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/gibson042/pdns/deployments","created_at":"2018-08-25T23:55:54Z","updated_at":"2018-10-27T19:22:27Z","pushed_at":"2018-10-28T12:51:21Z","git_url":"git://github.com/gibson042/pdns.git","ssh_url":"git@github.com:gibson042/pdns.git","clone_url":"https://github.com/gibson042/pdns.git","svn_url":"https://github.com/gibson042/pdns","homepage":null,"size":45294,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"a44e5233c468fe6434b83ff766b77a562c69ad44","user":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkzNTM0","name":"pdns","full_name":"PowerDNS/pdns","private":false,"owner":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2018-10-30T09:15:05Z","pushed_at":"2018-10-30T16:33:52Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":45699,"stargazers_count":1385,"watchers_count":1385,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":651,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":458,"open_issues":651,"watchers":1385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7111"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7111"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7111/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7111/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/c1780c41c89cbf31e4c34808f9c07b402e6da939"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pieterlexis"}}