{"action":"created","comment":{"url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/comments/233567260","pull_request_review_id":175012761,"id":233567260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzU2NzI2MA==","diff_hunk":"@@ -26,7 +29,24 @@ export function FormulaParserProvider() {\n \n     // Redefine binary operators to work with series.\n     each(parser.binaryOps, (func, funcName) => {\n-      const fn = func;\n+      let fn = func;\n+\n+      if (funcName === '/') {\n+        fn = (a, b) => {\n+          // Javascript have some weird behaviour concerning division.\n+          // - 0/0 => NaN\n+          // - x/0 | x <> 0 => -/+Infinity\n+          // We want NaN for both.\n+          if(b === 0) {\n+            notify.warning('Divide by 0 occured. Please ensure the denominator is non-zero.');","path":"public/decorators/lib/formula_parser.js","position":25,"original_position":25,"commit_id":"d6af73c89328c416f2184ca6e20258416ab7a797","original_commit_id":"d6af73c89328c416f2184ca6e20258416ab7a797","user":{"login":"RachelJsonar","id":16544701,"node_id":"MDQ6VXNlcjE2NTQ0NzAx","avatar_url":"https://avatars0.githubusercontent.com/u/16544701?v=4","gravatar_id":"","url":"https://api.github.com/users/RachelJsonar","html_url":"https://github.com/RachelJsonar","followers_url":"https://api.github.com/users/RachelJsonar/followers","following_url":"https://api.github.com/users/RachelJsonar/following{/other_user}","gists_url":"https://api.github.com/users/RachelJsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/RachelJsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RachelJsonar/subscriptions","organizations_url":"https://api.github.com/users/RachelJsonar/orgs","repos_url":"https://api.github.com/users/RachelJsonar/repos","events_url":"https://api.github.com/users/RachelJsonar/events{/privacy}","received_events_url":"https://api.github.com/users/RachelJsonar/received_events","type":"User","site_admin":false},"body":"I don't think this is the correct behaviour. \r\nThe user doesn't have control over the data that they get, it may have zeros. If it's a zero just return a null (or NaN I guess if kibana handles it) and that point won't be on the graph.","created_at":"2018-11-14T18:31:40Z","updated_at":"2018-11-14T18:31:40Z","html_url":"https://github.com/jsonar/kibana-datasweet-formula/pull/2#discussion_r233567260","pull_request_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/comments/233567260"},"html":{"href":"https://github.com/jsonar/kibana-datasweet-formula/pull/2#discussion_r233567260"},"pull_request":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2","id":229759354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzU5MzU0","html_url":"https://github.com/jsonar/kibana-datasweet-formula/pull/2","diff_url":"https://github.com/jsonar/kibana-datasweet-formula/pull/2.diff","patch_url":"https://github.com/jsonar/kibana-datasweet-formula/pull/2.patch","issue_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/2","number":2,"state":"open","locked":false,"title":"32: Warning on divide by 0.","user":{"login":"joeyJsonar","id":33907626,"node_id":"MDQ6VXNlcjMzOTA3NjI2","avatar_url":"https://avatars3.githubusercontent.com/u/33907626?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyJsonar","html_url":"https://github.com/joeyJsonar","followers_url":"https://api.github.com/users/joeyJsonar/followers","following_url":"https://api.github.com/users/joeyJsonar/following{/other_user}","gists_url":"https://api.github.com/users/joeyJsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyJsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyJsonar/subscriptions","organizations_url":"https://api.github.com/users/joeyJsonar/orgs","repos_url":"https://api.github.com/users/joeyJsonar/repos","events_url":"https://api.github.com/users/joeyJsonar/events{/privacy}","received_events_url":"https://api.github.com/users/joeyJsonar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-09T17:05:41Z","updated_at":"2018-11-14T18:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7460143f0ee389316f1ba6037118ffe499104ed3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/2/comments","statuses_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/statuses/d6af73c89328c416f2184ca6e20258416ab7a797","head":{"label":"jsonar:32","ref":"32","sha":"d6af73c89328c416f2184ca6e20258416ab7a797","user":{"login":"jsonar","id":5613482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTM0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5613482?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonar","html_url":"https://github.com/jsonar","followers_url":"https://api.github.com/users/jsonar/followers","following_url":"https://api.github.com/users/jsonar/following{/other_user}","gists_url":"https://api.github.com/users/jsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonar/subscriptions","organizations_url":"https://api.github.com/users/jsonar/orgs","repos_url":"https://api.github.com/users/jsonar/repos","events_url":"https://api.github.com/users/jsonar/events{/privacy}","received_events_url":"https://api.github.com/users/jsonar/received_events","type":"Organization","site_admin":false},"repo":{"id":147375958,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczNzU5NTg=","name":"kibana-datasweet-formula","full_name":"jsonar/kibana-datasweet-formula","private":false,"owner":{"login":"jsonar","id":5613482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTM0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5613482?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonar","html_url":"https://github.com/jsonar","followers_url":"https://api.github.com/users/jsonar/followers","following_url":"https://api.github.com/users/jsonar/following{/other_user}","gists_url":"https://api.github.com/users/jsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonar/subscriptions","organizations_url":"https://api.github.com/users/jsonar/orgs","repos_url":"https://api.github.com/users/jsonar/repos","events_url":"https://api.github.com/users/jsonar/events{/privacy}","received_events_url":"https://api.github.com/users/jsonar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jsonar/kibana-datasweet-formula","description":"This Kibana plugin allows calculated metrics on any standard kibana visualizations.","fork":true,"url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula","forks_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/forks","keys_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/teams","hooks_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/hooks","issue_events_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/events{/number}","events_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/events","assignees_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/assignees{/user}","branches_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/branches{/branch}","tags_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/tags","blobs_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/languages","stargazers_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/stargazers","contributors_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/contributors","subscribers_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/subscribers","subscription_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/subscription","commits_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/contents/{+path}","compare_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/merges","archive_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/downloads","issues_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues{/number}","pulls_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/labels{/name}","releases_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/releases{/id}","deployments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/deployments","created_at":"2018-09-04T16:29:33Z","updated_at":"2018-09-04T16:44:17Z","pushed_at":"2018-11-09T17:07:32Z","git_url":"git://github.com/jsonar/kibana-datasweet-formula.git","ssh_url":"git@github.com:jsonar/kibana-datasweet-formula.git","clone_url":"https://github.com/jsonar/kibana-datasweet-formula.git","svn_url":"https://github.com/jsonar/kibana-datasweet-formula","homepage":null,"size":12260,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"jsonar:development","ref":"development","sha":"0baa1a9171d43a778a2de8fd50858c087d640ca0","user":{"login":"jsonar","id":5613482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTM0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5613482?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonar","html_url":"https://github.com/jsonar","followers_url":"https://api.github.com/users/jsonar/followers","following_url":"https://api.github.com/users/jsonar/following{/other_user}","gists_url":"https://api.github.com/users/jsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonar/subscriptions","organizations_url":"https://api.github.com/users/jsonar/orgs","repos_url":"https://api.github.com/users/jsonar/repos","events_url":"https://api.github.com/users/jsonar/events{/privacy}","received_events_url":"https://api.github.com/users/jsonar/received_events","type":"Organization","site_admin":false},"repo":{"id":147375958,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczNzU5NTg=","name":"kibana-datasweet-formula","full_name":"jsonar/kibana-datasweet-formula","private":false,"owner":{"login":"jsonar","id":5613482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MTM0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5613482?v=4","gravatar_id":"","url":"https://api.github.com/users/jsonar","html_url":"https://github.com/jsonar","followers_url":"https://api.github.com/users/jsonar/followers","following_url":"https://api.github.com/users/jsonar/following{/other_user}","gists_url":"https://api.github.com/users/jsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonar/subscriptions","organizations_url":"https://api.github.com/users/jsonar/orgs","repos_url":"https://api.github.com/users/jsonar/repos","events_url":"https://api.github.com/users/jsonar/events{/privacy}","received_events_url":"https://api.github.com/users/jsonar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jsonar/kibana-datasweet-formula","description":"This Kibana plugin allows calculated metrics on any standard kibana visualizations.","fork":true,"url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula","forks_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/forks","keys_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/teams","hooks_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/hooks","issue_events_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/events{/number}","events_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/events","assignees_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/assignees{/user}","branches_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/branches{/branch}","tags_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/tags","blobs_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/languages","stargazers_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/stargazers","contributors_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/contributors","subscribers_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/subscribers","subscription_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/subscription","commits_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/contents/{+path}","compare_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/merges","archive_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/downloads","issues_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues{/number}","pulls_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/labels{/name}","releases_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/releases{/id}","deployments_url":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/deployments","created_at":"2018-09-04T16:29:33Z","updated_at":"2018-09-04T16:44:17Z","pushed_at":"2018-11-09T17:07:32Z","git_url":"git://github.com/jsonar/kibana-datasweet-formula.git","ssh_url":"git@github.com:jsonar/kibana-datasweet-formula.git","clone_url":"https://github.com/jsonar/kibana-datasweet-formula.git","svn_url":"https://github.com/jsonar/kibana-datasweet-formula","homepage":null,"size":12260,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2"},"html":{"href":"https://github.com/jsonar/kibana-datasweet-formula/pull/2"},"issue":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/2"},"comments":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jsonar/kibana-datasweet-formula/statuses/d6af73c89328c416f2184ca6e20258416ab7a797"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"RachelJsonar"}}