{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/16254","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/16254/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/16254/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/16254/events","html_url":"https://github.com/magento/magento2/pull/16254","id":333854240,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTcwMDU1","number":16254,"title":"Customer group extension attributes not carried over on save","user":{"login":"JosephMaxwell","id":1151186,"node_id":"MDQ6VXNlcjExNTExODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1151186?v=4","gravatar_id":"","url":"https://api.github.com/users/JosephMaxwell","html_url":"https://github.com/JosephMaxwell","followers_url":"https://api.github.com/users/JosephMaxwell/followers","following_url":"https://api.github.com/users/JosephMaxwell/following{/other_user}","gists_url":"https://api.github.com/users/JosephMaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephMaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephMaxwell/subscriptions","organizations_url":"https://api.github.com/users/JosephMaxwell/orgs","repos_url":"https://api.github.com/users/JosephMaxwell/repos","events_url":"https://api.github.com/users/JosephMaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/JosephMaxwell/received_events","type":"User","site_admin":false},"labels":[{"id":374015207,"node_id":"MDU6TGFiZWwzNzQwMTUyMDc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Customer","name":"Component: Customer","color":"7fb703","default":false}],"state":"open","locked":false,"assignee":{"login":"phoenix128","id":10189093,"node_id":"MDQ6VXNlcjEwMTg5MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/10189093?v=4","gravatar_id":"","url":"https://api.github.com/users/phoenix128","html_url":"https://github.com/phoenix128","followers_url":"https://api.github.com/users/phoenix128/followers","following_url":"https://api.github.com/users/phoenix128/following{/other_user}","gists_url":"https://api.github.com/users/phoenix128/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenix128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenix128/subscriptions","organizations_url":"https://api.github.com/users/phoenix128/orgs","repos_url":"https://api.github.com/users/phoenix128/repos","events_url":"https://api.github.com/users/phoenix128/events{/privacy}","received_events_url":"https://api.github.com/users/phoenix128/received_events","type":"User","site_admin":false},"assignees":[{"login":"phoenix128","id":10189093,"node_id":"MDQ6VXNlcjEwMTg5MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/10189093?v=4","gravatar_id":"","url":"https://api.github.com/users/phoenix128","html_url":"https://github.com/phoenix128","followers_url":"https://api.github.com/users/phoenix128/followers","following_url":"https://api.github.com/users/phoenix128/following{/other_user}","gists_url":"https://api.github.com/users/phoenix128/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenix128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenix128/subscriptions","organizations_url":"https://api.github.com/users/phoenix128/orgs","repos_url":"https://api.github.com/users/phoenix128/repos","events_url":"https://api.github.com/users/phoenix128/events{/privacy}","received_events_url":"https://api.github.com/users/phoenix128/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-19T21:58:55Z","updated_at":"2018-06-21T17:16:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/16254","html_url":"https://github.com/magento/magento2/pull/16254","diff_url":"https://github.com/magento/magento2/pull/16254.diff","patch_url":"https://github.com/magento/magento2/pull/16254.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\nWhen saving a customer group, extension attributes should be copied to the new data model that is returned. Unfortunately, this action was not completed and results in unexpected behavior.\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. Ensure that saving a customer group does not throw any errors.\r\n2. Ensure that utilizing extension attributes for a customer group now carries over through the save process.\r\n\r\n### Contribution checklist\r\n - [X] Pull request has a meaningful description of its purpose\r\n - [X] All commits are accompanied by meaningful commit messages\r\n - [X] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/399178709","html_url":"https://github.com/magento/magento2/pull/16254#issuecomment-399178709","issue_url":"https://api.github.com/repos/magento/magento2/issues/16254","id":399178709,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTE3ODcwOQ==","user":{"login":"phoenix128","id":10189093,"node_id":"MDQ6VXNlcjEwMTg5MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/10189093?v=4","gravatar_id":"","url":"https://api.github.com/users/phoenix128","html_url":"https://github.com/phoenix128","followers_url":"https://api.github.com/users/phoenix128/followers","following_url":"https://api.github.com/users/phoenix128/following{/other_user}","gists_url":"https://api.github.com/users/phoenix128/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenix128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenix128/subscriptions","organizations_url":"https://api.github.com/users/phoenix128/orgs","repos_url":"https://api.github.com/users/phoenix128/repos","events_url":"https://api.github.com/users/phoenix128/events{/privacy}","received_events_url":"https://api.github.com/users/phoenix128/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T17:16:20Z","updated_at":"2018-06-21T17:16:20Z","author_association":"CONTRIBUTOR","body":"Hello @JosephMaxwell ,\r\nthank you for your contribution and for your time. I am not sure this is an issue, extension attribute persistence should not be handled by the entity itself. You should create an `afterGet` and `afterSave` plugin.\r\n\r\nPlease refer to:\r\nhttps://devdocs.magento.com/guides/v2.2/extension-dev-guide/extension_attributes/adding-attributes.html#add-plugin-to-product-repository .\r\n\r\n"}}
{"actor":{"display_login":"phoenix128"}}