{"action":"created","comment":{"url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/comments/216946704","pull_request_review_id":154544062,"id":216946704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjk0NjcwNA==","diff_hunk":"@@ -101,3 +126,23 @@ address, indicating that you agree to the `Developer Certificate of Origin\n \t    this project or the open source license(s) involved.\n \n Use ``git commit -s`` to add the Signed-off-by tag.\n+\n+\n+Releasing\n+---------\n+\n+When cutting a new release, follow these steps:\n+\n+* update the version in ``fedora_messaging/__init__.py``\n+* update the version in ``docs/conf.py``","path":"docs/contributing.rst","position":44,"original_position":44,"commit_id":"f9898ce08c6586b019076a58902ff09b2033f48e","original_commit_id":"cbe12d41890ea88bb39fda59606228365a2367c2","user":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"body":"That that looks cool. So this line isn't necessary anymore.","created_at":"2018-09-12T08:50:05Z","updated_at":"2018-09-12T08:50:05Z","html_url":"https://github.com/fedora-infra/fedora-messaging/pull/67#discussion_r216946704","pull_request_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/comments/216946704"},"html":{"href":"https://github.com/fedora-infra/fedora-messaging/pull/67#discussion_r216946704"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67"}},"in_reply_to_id":216379752},"pull_request":{"url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67","id":214265211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjY1MjEx","html_url":"https://github.com/fedora-infra/fedora-messaging/pull/67","diff_url":"https://github.com/fedora-infra/fedora-messaging/pull/67.diff","patch_url":"https://github.com/fedora-infra/fedora-messaging/pull/67.patch","issue_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/67","number":67,"state":"open","locked":false,"title":"Use towncrier to generate the changelog","user":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"body":"Towncrier lets us generate release notes in a much more convenient way than what we currently do. Each PR just has to create a file with the line that should end up in the release notes, and the ``changelog.rst`` file can be automatically generated before each release.\r\n\r\nI have added documentation in the ``contributing.rst`` file for more usage info.\r\n\r\n@jeremycline I would also like you to verify that the releasing process I have documented in ``contributing.rst`` is correct, please.","created_at":"2018-09-10T10:20:53Z","updated_at":"2018-09-12T08:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33ac4cc822e00debc67111927aed57852538bedd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67/commits","review_comments_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67/comments","review_comment_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/67/comments","statuses_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/statuses/f9898ce08c6586b019076a58902ff09b2033f48e","head":{"label":"abompard:towncrier","ref":"towncrier","sha":"f9898ce08c6586b019076a58902ff09b2033f48e","user":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"repo":{"id":141156384,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExNTYzODQ=","name":"fedora-messaging","full_name":"abompard/fedora-messaging","owner":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abompard/fedora-messaging","description":"A library for sending AMQP messages with JSON schema in Fedora infrastructure","fork":true,"url":"https://api.github.com/repos/abompard/fedora-messaging","forks_url":"https://api.github.com/repos/abompard/fedora-messaging/forks","keys_url":"https://api.github.com/repos/abompard/fedora-messaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abompard/fedora-messaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abompard/fedora-messaging/teams","hooks_url":"https://api.github.com/repos/abompard/fedora-messaging/hooks","issue_events_url":"https://api.github.com/repos/abompard/fedora-messaging/issues/events{/number}","events_url":"https://api.github.com/repos/abompard/fedora-messaging/events","assignees_url":"https://api.github.com/repos/abompard/fedora-messaging/assignees{/user}","branches_url":"https://api.github.com/repos/abompard/fedora-messaging/branches{/branch}","tags_url":"https://api.github.com/repos/abompard/fedora-messaging/tags","blobs_url":"https://api.github.com/repos/abompard/fedora-messaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abompard/fedora-messaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abompard/fedora-messaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/abompard/fedora-messaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abompard/fedora-messaging/statuses/{sha}","languages_url":"https://api.github.com/repos/abompard/fedora-messaging/languages","stargazers_url":"https://api.github.com/repos/abompard/fedora-messaging/stargazers","contributors_url":"https://api.github.com/repos/abompard/fedora-messaging/contributors","subscribers_url":"https://api.github.com/repos/abompard/fedora-messaging/subscribers","subscription_url":"https://api.github.com/repos/abompard/fedora-messaging/subscription","commits_url":"https://api.github.com/repos/abompard/fedora-messaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/abompard/fedora-messaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/abompard/fedora-messaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/abompard/fedora-messaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/abompard/fedora-messaging/contents/{+path}","compare_url":"https://api.github.com/repos/abompard/fedora-messaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abompard/fedora-messaging/merges","archive_url":"https://api.github.com/repos/abompard/fedora-messaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abompard/fedora-messaging/downloads","issues_url":"https://api.github.com/repos/abompard/fedora-messaging/issues{/number}","pulls_url":"https://api.github.com/repos/abompard/fedora-messaging/pulls{/number}","milestones_url":"https://api.github.com/repos/abompard/fedora-messaging/milestones{/number}","notifications_url":"https://api.github.com/repos/abompard/fedora-messaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abompard/fedora-messaging/labels{/name}","releases_url":"https://api.github.com/repos/abompard/fedora-messaging/releases{/id}","deployments_url":"https://api.github.com/repos/abompard/fedora-messaging/deployments","created_at":"2018-07-16T15:17:33Z","updated_at":"2018-08-22T06:19:39Z","pushed_at":"2018-09-10T16:23:36Z","git_url":"git://github.com/abompard/fedora-messaging.git","ssh_url":"git@github.com:abompard/fedora-messaging.git","clone_url":"https://github.com/abompard/fedora-messaging.git","svn_url":"https://github.com/abompard/fedora-messaging","homepage":"","size":328,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fedora-infra:master","ref":"master","sha":"2f5a9763e99e867fe0470261669f9e4bfac31428","user":{"login":"fedora-infra","id":3316637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY2Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3316637?v=4","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":132087972,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwODc5NzI=","name":"fedora-messaging","full_name":"fedora-infra/fedora-messaging","owner":{"login":"fedora-infra","id":3316637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY2Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3316637?v=4","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedora-infra/fedora-messaging","description":"A library for sending AMQP messages with JSON schema in Fedora infrastructure","fork":false,"url":"https://api.github.com/repos/fedora-infra/fedora-messaging","forks_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/forks","keys_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/teams","hooks_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/hooks","issue_events_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/events{/number}","events_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/events","assignees_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/assignees{/user}","branches_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/branches{/branch}","tags_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/tags","blobs_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/statuses/{sha}","languages_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/languages","stargazers_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/stargazers","contributors_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/contributors","subscribers_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/subscribers","subscription_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/subscription","commits_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/contents/{+path}","compare_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/merges","archive_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/downloads","issues_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues{/number}","pulls_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls{/number}","milestones_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/milestones{/number}","notifications_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/labels{/name}","releases_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/releases{/id}","deployments_url":"https://api.github.com/repos/fedora-infra/fedora-messaging/deployments","created_at":"2018-05-04T04:42:33Z","updated_at":"2018-09-10T19:58:23Z","pushed_at":"2018-09-10T19:58:21Z","git_url":"git://github.com/fedora-infra/fedora-messaging.git","ssh_url":"git@github.com:fedora-infra/fedora-messaging.git","clone_url":"https://github.com/fedora-infra/fedora-messaging.git","svn_url":"https://github.com/fedora-infra/fedora-messaging","homepage":"","size":337,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":6,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67"},"html":{"href":"https://github.com/fedora-infra/fedora-messaging/pull/67"},"issue":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/67"},"comments":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/fedora-infra/fedora-messaging/statuses/f9898ce08c6586b019076a58902ff09b2033f48e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abompard"}}