{"action":"created","comment":{"url":"https://api.github.com/repos/criteo-forks/presto/pulls/comments/206996322","pull_request_review_id":142513141,"id":206996322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk5NjMyMg==","diff_hunk":"@@ -0,0 +1,57 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.hive.metastore.thrift;\n+\n+import io.airlift.configuration.Config;\n+import io.airlift.configuration.ConfigDescription;\n+\n+import javax.validation.constraints.NotNull;\n+\n+import java.net.URI;\n+\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.","path":"presto-hive/src/main/java/com/facebook/presto/hive/metastore/thrift/DiscoveryHiveClusterConfig.java","position":25,"original_position":25,"commit_id":"898b8f1e77adf7e4f1e084229db522f64fe02187","original_commit_id":"898b8f1e77adf7e4f1e084229db522f64fe02187","user":{"login":"piyushnarang","id":9885908,"node_id":"MDQ6VXNlcjk4ODU5MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/9885908?v=4","gravatar_id":"","url":"https://api.github.com/users/piyushnarang","html_url":"https://github.com/piyushnarang","followers_url":"https://api.github.com/users/piyushnarang/followers","following_url":"https://api.github.com/users/piyushnarang/following{/other_user}","gists_url":"https://api.github.com/users/piyushnarang/gists{/gist_id}","starred_url":"https://api.github.com/users/piyushnarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyushnarang/subscriptions","organizations_url":"https://api.github.com/users/piyushnarang/orgs","repos_url":"https://api.github.com/users/piyushnarang/repos","events_url":"https://api.github.com/users/piyushnarang/events{/privacy}","received_events_url":"https://api.github.com/users/piyushnarang/received_events","type":"User","site_admin":false},"body":"this license isn't needed right? just the one at the top","created_at":"2018-08-01T19:01:20Z","updated_at":"2018-08-01T19:17:30Z","html_url":"https://github.com/criteo-forks/presto/pull/3#discussion_r206996322","pull_request_url":"https://api.github.com/repos/criteo-forks/presto/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/comments/206996322"},"html":{"href":"https://github.com/criteo-forks/presto/pull/3#discussion_r206996322"},"pull_request":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/criteo-forks/presto/pulls/3","id":205502912,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTAyOTEy","html_url":"https://github.com/criteo-forks/presto/pull/3","diff_url":"https://github.com/criteo-forks/presto/pull/3.diff","patch_url":"https://github.com/criteo-forks/presto/pull/3.patch","issue_url":"https://api.github.com/repos/criteo-forks/presto/issues/3","number":3,"state":"open","locked":false,"title":"Migrate Presto to use Hive on Mesos.","user":{"login":"szehonCriteo","id":20555759,"node_id":"MDQ6VXNlcjIwNTU1NzU5","avatar_url":"https://avatars0.githubusercontent.com/u/20555759?v=4","gravatar_id":"","url":"https://api.github.com/users/szehonCriteo","html_url":"https://github.com/szehonCriteo","followers_url":"https://api.github.com/users/szehonCriteo/followers","following_url":"https://api.github.com/users/szehonCriteo/following{/other_user}","gists_url":"https://api.github.com/users/szehonCriteo/gists{/gist_id}","starred_url":"https://api.github.com/users/szehonCriteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szehonCriteo/subscriptions","organizations_url":"https://api.github.com/users/szehonCriteo/orgs","repos_url":"https://api.github.com/users/szehonCriteo/repos","events_url":"https://api.github.com/users/szehonCriteo/events{/privacy}","received_events_url":"https://api.github.com/users/szehonCriteo/received_events","type":"User","site_admin":false},"body":"Tested locally and works.","created_at":"2018-08-01T17:49:05Z","updated_at":"2018-08-01T19:17:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e959143022217aada392ac9693dfb59b5ab95df0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/criteo-forks/presto/pulls/3/commits","review_comments_url":"https://api.github.com/repos/criteo-forks/presto/pulls/3/comments","review_comment_url":"https://api.github.com/repos/criteo-forks/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/criteo-forks/presto/issues/3/comments","statuses_url":"https://api.github.com/repos/criteo-forks/presto/statuses/898b8f1e77adf7e4f1e084229db522f64fe02187","head":{"label":"szehonCriteo:criteo-master","ref":"criteo-master","sha":"898b8f1e77adf7e4f1e084229db522f64fe02187","user":{"login":"szehonCriteo","id":20555759,"node_id":"MDQ6VXNlcjIwNTU1NzU5","avatar_url":"https://avatars0.githubusercontent.com/u/20555759?v=4","gravatar_id":"","url":"https://api.github.com/users/szehonCriteo","html_url":"https://github.com/szehonCriteo","followers_url":"https://api.github.com/users/szehonCriteo/followers","following_url":"https://api.github.com/users/szehonCriteo/following{/other_user}","gists_url":"https://api.github.com/users/szehonCriteo/gists{/gist_id}","starred_url":"https://api.github.com/users/szehonCriteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szehonCriteo/subscriptions","organizations_url":"https://api.github.com/users/szehonCriteo/orgs","repos_url":"https://api.github.com/users/szehonCriteo/repos","events_url":"https://api.github.com/users/szehonCriteo/events{/privacy}","received_events_url":"https://api.github.com/users/szehonCriteo/received_events","type":"User","site_admin":false},"repo":{"id":143188896,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxODg4OTY=","name":"presto","full_name":"szehonCriteo/presto","owner":{"login":"szehonCriteo","id":20555759,"node_id":"MDQ6VXNlcjIwNTU1NzU5","avatar_url":"https://avatars0.githubusercontent.com/u/20555759?v=4","gravatar_id":"","url":"https://api.github.com/users/szehonCriteo","html_url":"https://github.com/szehonCriteo","followers_url":"https://api.github.com/users/szehonCriteo/followers","following_url":"https://api.github.com/users/szehonCriteo/following{/other_user}","gists_url":"https://api.github.com/users/szehonCriteo/gists{/gist_id}","starred_url":"https://api.github.com/users/szehonCriteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szehonCriteo/subscriptions","organizations_url":"https://api.github.com/users/szehonCriteo/orgs","repos_url":"https://api.github.com/users/szehonCriteo/repos","events_url":"https://api.github.com/users/szehonCriteo/events{/privacy}","received_events_url":"https://api.github.com/users/szehonCriteo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szehonCriteo/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/szehonCriteo/presto","forks_url":"https://api.github.com/repos/szehonCriteo/presto/forks","keys_url":"https://api.github.com/repos/szehonCriteo/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szehonCriteo/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szehonCriteo/presto/teams","hooks_url":"https://api.github.com/repos/szehonCriteo/presto/hooks","issue_events_url":"https://api.github.com/repos/szehonCriteo/presto/issues/events{/number}","events_url":"https://api.github.com/repos/szehonCriteo/presto/events","assignees_url":"https://api.github.com/repos/szehonCriteo/presto/assignees{/user}","branches_url":"https://api.github.com/repos/szehonCriteo/presto/branches{/branch}","tags_url":"https://api.github.com/repos/szehonCriteo/presto/tags","blobs_url":"https://api.github.com/repos/szehonCriteo/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szehonCriteo/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szehonCriteo/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/szehonCriteo/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szehonCriteo/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/szehonCriteo/presto/languages","stargazers_url":"https://api.github.com/repos/szehonCriteo/presto/stargazers","contributors_url":"https://api.github.com/repos/szehonCriteo/presto/contributors","subscribers_url":"https://api.github.com/repos/szehonCriteo/presto/subscribers","subscription_url":"https://api.github.com/repos/szehonCriteo/presto/subscription","commits_url":"https://api.github.com/repos/szehonCriteo/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/szehonCriteo/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/szehonCriteo/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/szehonCriteo/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/szehonCriteo/presto/contents/{+path}","compare_url":"https://api.github.com/repos/szehonCriteo/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szehonCriteo/presto/merges","archive_url":"https://api.github.com/repos/szehonCriteo/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szehonCriteo/presto/downloads","issues_url":"https://api.github.com/repos/szehonCriteo/presto/issues{/number}","pulls_url":"https://api.github.com/repos/szehonCriteo/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/szehonCriteo/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/szehonCriteo/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szehonCriteo/presto/labels{/name}","releases_url":"https://api.github.com/repos/szehonCriteo/presto/releases{/id}","deployments_url":"https://api.github.com/repos/szehonCriteo/presto/deployments","created_at":"2018-08-01T17:42:01Z","updated_at":"2018-08-01T17:42:20Z","pushed_at":"2018-08-01T18:26:07Z","git_url":"git://github.com/szehonCriteo/presto.git","ssh_url":"git@github.com:szehonCriteo/presto.git","clone_url":"https://github.com/szehonCriteo/presto.git","svn_url":"https://github.com/szehonCriteo/presto","homepage":"https://prestodb.io","size":89625,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"criteo-forks:criteo-master","ref":"criteo-master","sha":"319f44f7434b8685cdd6129f1e06529f1e5999cc","user":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":128825178,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MjUxNzg=","name":"presto","full_name":"criteo-forks/presto","owner":{"login":"criteo-forks","id":9960514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjA1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-forks/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/criteo-forks/presto","forks_url":"https://api.github.com/repos/criteo-forks/presto/forks","keys_url":"https://api.github.com/repos/criteo-forks/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-forks/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-forks/presto/teams","hooks_url":"https://api.github.com/repos/criteo-forks/presto/hooks","issue_events_url":"https://api.github.com/repos/criteo-forks/presto/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-forks/presto/events","assignees_url":"https://api.github.com/repos/criteo-forks/presto/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-forks/presto/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-forks/presto/tags","blobs_url":"https://api.github.com/repos/criteo-forks/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-forks/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-forks/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-forks/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-forks/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-forks/presto/languages","stargazers_url":"https://api.github.com/repos/criteo-forks/presto/stargazers","contributors_url":"https://api.github.com/repos/criteo-forks/presto/contributors","subscribers_url":"https://api.github.com/repos/criteo-forks/presto/subscribers","subscription_url":"https://api.github.com/repos/criteo-forks/presto/subscription","commits_url":"https://api.github.com/repos/criteo-forks/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-forks/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-forks/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-forks/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/criteo-forks/presto/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-forks/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-forks/presto/merges","archive_url":"https://api.github.com/repos/criteo-forks/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-forks/presto/downloads","issues_url":"https://api.github.com/repos/criteo-forks/presto/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-forks/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-forks/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-forks/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-forks/presto/labels{/name}","releases_url":"https://api.github.com/repos/criteo-forks/presto/releases{/id}","deployments_url":"https://api.github.com/repos/criteo-forks/presto/deployments","created_at":"2018-04-09T19:46:28Z","updated_at":"2018-04-20T18:34:32Z","pushed_at":"2018-08-01T18:26:09Z","git_url":"git://github.com/criteo-forks/presto.git","ssh_url":"git@github.com:criteo-forks/presto.git","clone_url":"https://github.com/criteo-forks/presto.git","svn_url":"https://github.com/criteo-forks/presto","homepage":"https://prestodb.io","size":89843,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/3"},"html":{"href":"https://github.com/criteo-forks/presto/pull/3"},"issue":{"href":"https://api.github.com/repos/criteo-forks/presto/issues/3"},"comments":{"href":"https://api.github.com/repos/criteo-forks/presto/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/criteo-forks/presto/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/criteo-forks/presto/statuses/898b8f1e77adf7e4f1e084229db522f64fe02187"}},"author_association":"NONE"}}
{"actor":{"display_login":"piyushnarang"}}