{"action":"closed","number":211,"pull_request":{"url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211","id":172618045,"html_url":"https://github.com/dockstore/dockstore-ui2/pull/211","diff_url":"https://github.com/dockstore/dockstore-ui2/pull/211.diff","patch_url":"https://github.com/dockstore/dockstore-ui2/pull/211.patch","issue_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/211","number":211,"state":"closed","locked":false,"title":"Fix broken DAG #1199","user":{"login":"coverbeck","id":1049340,"avatar_url":"https://avatars3.githubusercontent.com/u/1049340?v=4","gravatar_id":"","url":"https://api.github.com/users/coverbeck","html_url":"https://github.com/coverbeck","followers_url":"https://api.github.com/users/coverbeck/followers","following_url":"https://api.github.com/users/coverbeck/following{/other_user}","gists_url":"https://api.github.com/users/coverbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/coverbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coverbeck/subscriptions","organizations_url":"https://api.github.com/users/coverbeck/orgs","repos_url":"https://api.github.com/users/coverbeck/repos","events_url":"https://api.github.com/users/coverbeck/events{/privacy}","received_events_url":"https://api.github.com/users/coverbeck/received_events","type":"User","site_admin":false},"body":"It was only failing in Angular prod mode.\r\n\r\nUsing source maps, I saw it was failing in cytoscape.min.js, so then\r\nI tried the non-minified version to see exactly what the problem was,\r\nand the problem went away.\r\n\r\nThe problem seems to be unrelated to the CWL Viewer DAG work, as I could\r\nstill reproduce the problem in prod mode if I rolled back the CWL\r\nViewer commits locally.\r\n\r\nWith this change, the generated bundles only seem to contain minified\r\ncode; it looks like the difference is that Angular preforms the\r\nminification at build time.\r\n\r\nga4gh/dockstore#1199","created_at":"2018-03-02T22:15:11Z","updated_at":"2018-03-03T01:02:28Z","closed_at":"2018-03-03T01:02:27Z","merged_at":"2018-03-03T01:02:27Z","merge_commit_sha":"911541e39441102d2718e8b520ba4400f269ef97","assignee":{"login":"denis-yuen","id":1730679,"avatar_url":"https://avatars0.githubusercontent.com/u/1730679?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-yuen","html_url":"https://github.com/denis-yuen","followers_url":"https://api.github.com/users/denis-yuen/followers","following_url":"https://api.github.com/users/denis-yuen/following{/other_user}","gists_url":"https://api.github.com/users/denis-yuen/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-yuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-yuen/subscriptions","organizations_url":"https://api.github.com/users/denis-yuen/orgs","repos_url":"https://api.github.com/users/denis-yuen/repos","events_url":"https://api.github.com/users/denis-yuen/events{/privacy}","received_events_url":"https://api.github.com/users/denis-yuen/received_events","type":"User","site_admin":false},"assignees":[{"login":"denis-yuen","id":1730679,"avatar_url":"https://avatars0.githubusercontent.com/u/1730679?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-yuen","html_url":"https://github.com/denis-yuen","followers_url":"https://api.github.com/users/denis-yuen/followers","following_url":"https://api.github.com/users/denis-yuen/following{/other_user}","gists_url":"https://api.github.com/users/denis-yuen/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-yuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-yuen/subscriptions","organizations_url":"https://api.github.com/users/denis-yuen/orgs","repos_url":"https://api.github.com/users/denis-yuen/repos","events_url":"https://api.github.com/users/denis-yuen/events{/privacy}","received_events_url":"https://api.github.com/users/denis-yuen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"denis-yuen","id":1730679,"avatar_url":"https://avatars0.githubusercontent.com/u/1730679?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-yuen","html_url":"https://github.com/denis-yuen","followers_url":"https://api.github.com/users/denis-yuen/followers","following_url":"https://api.github.com/users/denis-yuen/following{/other_user}","gists_url":"https://api.github.com/users/denis-yuen/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-yuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-yuen/subscriptions","organizations_url":"https://api.github.com/users/denis-yuen/orgs","repos_url":"https://api.github.com/users/denis-yuen/repos","events_url":"https://api.github.com/users/denis-yuen/events{/privacy}","received_events_url":"https://api.github.com/users/denis-yuen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211/commits","review_comments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211/comments","review_comment_url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/211/comments","statuses_url":"https://api.github.com/repos/dockstore/dockstore-ui2/statuses/821eca15fa3d42fa67209d258239a9da950e10ba","head":{"label":"dockstore:feature/1199/brokendag","ref":"feature/1199/brokendag","sha":"821eca15fa3d42fa67209d258239a9da950e10ba","user":{"login":"dockstore","id":25392449,"avatar_url":"https://avatars0.githubusercontent.com/u/25392449?v=4","gravatar_id":"","url":"https://api.github.com/users/dockstore","html_url":"https://github.com/dockstore","followers_url":"https://api.github.com/users/dockstore/followers","following_url":"https://api.github.com/users/dockstore/following{/other_user}","gists_url":"https://api.github.com/users/dockstore/gists{/gist_id}","starred_url":"https://api.github.com/users/dockstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockstore/subscriptions","organizations_url":"https://api.github.com/users/dockstore/orgs","repos_url":"https://api.github.com/users/dockstore/repos","events_url":"https://api.github.com/users/dockstore/events{/privacy}","received_events_url":"https://api.github.com/users/dockstore/received_events","type":"Organization","site_admin":false},"repo":{"id":85749030,"name":"dockstore-ui2","full_name":"dockstore/dockstore-ui2","owner":{"login":"dockstore","id":25392449,"avatar_url":"https://avatars0.githubusercontent.com/u/25392449?v=4","gravatar_id":"","url":"https://api.github.com/users/dockstore","html_url":"https://github.com/dockstore","followers_url":"https://api.github.com/users/dockstore/followers","following_url":"https://api.github.com/users/dockstore/following{/other_user}","gists_url":"https://api.github.com/users/dockstore/gists{/gist_id}","starred_url":"https://api.github.com/users/dockstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockstore/subscriptions","organizations_url":"https://api.github.com/users/dockstore/orgs","repos_url":"https://api.github.com/users/dockstore/repos","events_url":"https://api.github.com/users/dockstore/events{/privacy}","received_events_url":"https://api.github.com/users/dockstore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockstore/dockstore-ui2","description":"A repo for migrating dockstore-ui from AngularJS to Angular2 and implementing search","fork":false,"url":"https://api.github.com/repos/dockstore/dockstore-ui2","forks_url":"https://api.github.com/repos/dockstore/dockstore-ui2/forks","keys_url":"https://api.github.com/repos/dockstore/dockstore-ui2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockstore/dockstore-ui2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockstore/dockstore-ui2/teams","hooks_url":"https://api.github.com/repos/dockstore/dockstore-ui2/hooks","issue_events_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/events{/number}","events_url":"https://api.github.com/repos/dockstore/dockstore-ui2/events","assignees_url":"https://api.github.com/repos/dockstore/dockstore-ui2/assignees{/user}","branches_url":"https://api.github.com/repos/dockstore/dockstore-ui2/branches{/branch}","tags_url":"https://api.github.com/repos/dockstore/dockstore-ui2/tags","blobs_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockstore/dockstore-ui2/statuses/{sha}","languages_url":"https://api.github.com/repos/dockstore/dockstore-ui2/languages","stargazers_url":"https://api.github.com/repos/dockstore/dockstore-ui2/stargazers","contributors_url":"https://api.github.com/repos/dockstore/dockstore-ui2/contributors","subscribers_url":"https://api.github.com/repos/dockstore/dockstore-ui2/subscribers","subscription_url":"https://api.github.com/repos/dockstore/dockstore-ui2/subscription","commits_url":"https://api.github.com/repos/dockstore/dockstore-ui2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockstore/dockstore-ui2/contents/{+path}","compare_url":"https://api.github.com/repos/dockstore/dockstore-ui2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockstore/dockstore-ui2/merges","archive_url":"https://api.github.com/repos/dockstore/dockstore-ui2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockstore/dockstore-ui2/downloads","issues_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues{/number}","pulls_url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls{/number}","milestones_url":"https://api.github.com/repos/dockstore/dockstore-ui2/milestones{/number}","notifications_url":"https://api.github.com/repos/dockstore/dockstore-ui2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockstore/dockstore-ui2/labels{/name}","releases_url":"https://api.github.com/repos/dockstore/dockstore-ui2/releases{/id}","deployments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/deployments","created_at":"2017-03-21T20:17:13Z","updated_at":"2017-09-28T21:20:55Z","pushed_at":"2018-03-03T01:02:27Z","git_url":"git://github.com/dockstore/dockstore-ui2.git","ssh_url":"git@github.com:dockstore/dockstore-ui2.git","clone_url":"https://github.com/dockstore/dockstore-ui2.git","svn_url":"https://github.com/dockstore/dockstore-ui2","homepage":"","size":21701,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":5,"watchers":4,"default_branch":"develop"}},"base":{"label":"dockstore:develop","ref":"develop","sha":"3b9fcc5dd6ec73198b9e146f55ca975045fd4f25","user":{"login":"dockstore","id":25392449,"avatar_url":"https://avatars0.githubusercontent.com/u/25392449?v=4","gravatar_id":"","url":"https://api.github.com/users/dockstore","html_url":"https://github.com/dockstore","followers_url":"https://api.github.com/users/dockstore/followers","following_url":"https://api.github.com/users/dockstore/following{/other_user}","gists_url":"https://api.github.com/users/dockstore/gists{/gist_id}","starred_url":"https://api.github.com/users/dockstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockstore/subscriptions","organizations_url":"https://api.github.com/users/dockstore/orgs","repos_url":"https://api.github.com/users/dockstore/repos","events_url":"https://api.github.com/users/dockstore/events{/privacy}","received_events_url":"https://api.github.com/users/dockstore/received_events","type":"Organization","site_admin":false},"repo":{"id":85749030,"name":"dockstore-ui2","full_name":"dockstore/dockstore-ui2","owner":{"login":"dockstore","id":25392449,"avatar_url":"https://avatars0.githubusercontent.com/u/25392449?v=4","gravatar_id":"","url":"https://api.github.com/users/dockstore","html_url":"https://github.com/dockstore","followers_url":"https://api.github.com/users/dockstore/followers","following_url":"https://api.github.com/users/dockstore/following{/other_user}","gists_url":"https://api.github.com/users/dockstore/gists{/gist_id}","starred_url":"https://api.github.com/users/dockstore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockstore/subscriptions","organizations_url":"https://api.github.com/users/dockstore/orgs","repos_url":"https://api.github.com/users/dockstore/repos","events_url":"https://api.github.com/users/dockstore/events{/privacy}","received_events_url":"https://api.github.com/users/dockstore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockstore/dockstore-ui2","description":"A repo for migrating dockstore-ui from AngularJS to Angular2 and implementing search","fork":false,"url":"https://api.github.com/repos/dockstore/dockstore-ui2","forks_url":"https://api.github.com/repos/dockstore/dockstore-ui2/forks","keys_url":"https://api.github.com/repos/dockstore/dockstore-ui2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockstore/dockstore-ui2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockstore/dockstore-ui2/teams","hooks_url":"https://api.github.com/repos/dockstore/dockstore-ui2/hooks","issue_events_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/events{/number}","events_url":"https://api.github.com/repos/dockstore/dockstore-ui2/events","assignees_url":"https://api.github.com/repos/dockstore/dockstore-ui2/assignees{/user}","branches_url":"https://api.github.com/repos/dockstore/dockstore-ui2/branches{/branch}","tags_url":"https://api.github.com/repos/dockstore/dockstore-ui2/tags","blobs_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockstore/dockstore-ui2/statuses/{sha}","languages_url":"https://api.github.com/repos/dockstore/dockstore-ui2/languages","stargazers_url":"https://api.github.com/repos/dockstore/dockstore-ui2/stargazers","contributors_url":"https://api.github.com/repos/dockstore/dockstore-ui2/contributors","subscribers_url":"https://api.github.com/repos/dockstore/dockstore-ui2/subscribers","subscription_url":"https://api.github.com/repos/dockstore/dockstore-ui2/subscription","commits_url":"https://api.github.com/repos/dockstore/dockstore-ui2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockstore/dockstore-ui2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockstore/dockstore-ui2/contents/{+path}","compare_url":"https://api.github.com/repos/dockstore/dockstore-ui2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockstore/dockstore-ui2/merges","archive_url":"https://api.github.com/repos/dockstore/dockstore-ui2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockstore/dockstore-ui2/downloads","issues_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues{/number}","pulls_url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls{/number}","milestones_url":"https://api.github.com/repos/dockstore/dockstore-ui2/milestones{/number}","notifications_url":"https://api.github.com/repos/dockstore/dockstore-ui2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockstore/dockstore-ui2/labels{/name}","releases_url":"https://api.github.com/repos/dockstore/dockstore-ui2/releases{/id}","deployments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/deployments","created_at":"2017-03-21T20:17:13Z","updated_at":"2017-09-28T21:20:55Z","pushed_at":"2018-03-03T01:02:27Z","git_url":"git://github.com/dockstore/dockstore-ui2.git","ssh_url":"git@github.com:dockstore/dockstore-ui2.git","clone_url":"https://github.com/dockstore/dockstore-ui2.git","svn_url":"https://github.com/dockstore/dockstore-ui2","homepage":"","size":21701,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":5,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211"},"html":{"href":"https://github.com/dockstore/dockstore-ui2/pull/211"},"issue":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/211"},"comments":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/dockstore/dockstore-ui2/statuses/821eca15fa3d42fa67209d258239a9da950e10ba"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"coverbeck","id":1049340,"avatar_url":"https://avatars3.githubusercontent.com/u/1049340?v=4","gravatar_id":"","url":"https://api.github.com/users/coverbeck","html_url":"https://github.com/coverbeck","followers_url":"https://api.github.com/users/coverbeck/followers","following_url":"https://api.github.com/users/coverbeck/following{/other_user}","gists_url":"https://api.github.com/users/coverbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/coverbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coverbeck/subscriptions","organizations_url":"https://api.github.com/users/coverbeck/orgs","repos_url":"https://api.github.com/users/coverbeck/repos","events_url":"https://api.github.com/users/coverbeck/events{/privacy}","received_events_url":"https://api.github.com/users/coverbeck/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"coverbeck"}}