{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/177921134","pull_request_review_id":107887665,"id":177921134,"diff_hunk":"@@ -3437,6 +3437,45 @@ void CWallet::ListLockedCoins(std::vector<COutPoint>& vOutpts)\n     }\n }\n \n+\n+// Note Locking Operations\n+\n+void CWallet::LockNote(JSOutPoint& output)\n+{\n+    AssertLockHeld(cs_wallet); // setLockedNotes\n+    setLockedNotes.insert(output);\n+}\n+\n+void CWallet::UnlockNote(JSOutPoint& output)\n+{\n+    AssertLockHeld(cs_wallet); // setLockedNotes\n+    setLockedNotes.erase(output);\n+}\n+\n+void CWallet::UnlockAllNotes()\n+{\n+    AssertLockHeld(cs_wallet); // setLockedNotes\n+    setLockedNotes.clear();\n+}\n+\n+bool CWallet::IsLockedNote(uint256 hash, size_t js, uint8_t n) const\n+{\n+    AssertLockHeld(cs_wallet); // setLockedNotes\n+    JSOutPoint outpt(hash, js, n);\n+\n+    return (setLockedNotes.count(outpt) > 0);\n+}\n+\n+void CWallet::ListLockedNotes(std::vector<JSOutPoint>& vOutpts)","path":"src/wallet/wallet.cpp","position":33,"original_position":33,"commit_id":"df420d1737d05582dbac68239827f6d2d3a2dd31","original_commit_id":"df420d1737d05582dbac68239827f6d2d3a2dd31","user":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"body":"It doesn't look like ListLockedNotes is being used anywhere, this is for a future call such as listlockunspentnotes, right?\r\n\r\nIf the intent is to get a copy of setLockedNotes as a vector, you can do this:\r\n```\r\nstd::vector v( setLockedNotes.begin(), setLockedNotes.end() );\r\nreturn v;\r\n```\r\nOr if you want to append to an existing vector passed in as a parameter:\r\n```\r\nstd::copy(setLockedNotes.begin(), setLockedNotes.end(), std::back_inserter(vOutpts));\r\n```\r\n\r\n","created_at":"2018-03-28T23:45:34Z","updated_at":"2018-03-28T23:54:02Z","html_url":"https://github.com/zcash/zcash/pull/3106#discussion_r177921134","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/3106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/177921134"},"html":{"href":"https://github.com/zcash/zcash/pull/3106#discussion_r177921134"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3106"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3106","id":176648604,"html_url":"https://github.com/zcash/zcash/pull/3106","diff_url":"https://github.com/zcash/zcash/pull/3106.diff","patch_url":"https://github.com/zcash/zcash/pull/3106.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3106","number":3106,"state":"open","locked":false,"title":"Add Note Locking to z_mergetoaddress","user":{"login":"braddmiller","id":7740524,"avatar_url":"https://avatars1.githubusercontent.com/u/7740524?v=4","gravatar_id":"","url":"https://api.github.com/users/braddmiller","html_url":"https://github.com/braddmiller","followers_url":"https://api.github.com/users/braddmiller/followers","following_url":"https://api.github.com/users/braddmiller/following{/other_user}","gists_url":"https://api.github.com/users/braddmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/braddmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddmiller/subscriptions","organizations_url":"https://api.github.com/users/braddmiller/orgs","repos_url":"https://api.github.com/users/braddmiller/repos","events_url":"https://api.github.com/users/braddmiller/events{/privacy}","received_events_url":"https://api.github.com/users/braddmiller/received_events","type":"User","site_admin":false},"body":"Adds note locking to `z_mergetoaddress` allowing it to be invoked multiple times before previous `z_mergetoaddress` operations have finished. \r\n\r\nReference issue [#3046](https://github.com/zcash/zcash/issues/3046)\r\n\r\nCo-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>","created_at":"2018-03-22T00:55:00Z","updated_at":"2018-03-28T23:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bed58b655fdcf9047a370640ba6667efb192093","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daira","id":643204,"avatar_url":"https://avatars2.githubusercontent.com/u/643204?v=4","gravatar_id":"","url":"https://api.github.com/users/daira","html_url":"https://github.com/daira","followers_url":"https://api.github.com/users/daira/followers","following_url":"https://api.github.com/users/daira/following{/other_user}","gists_url":"https://api.github.com/users/daira/gists{/gist_id}","starred_url":"https://api.github.com/users/daira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daira/subscriptions","organizations_url":"https://api.github.com/users/daira/orgs","repos_url":"https://api.github.com/users/daira/repos","events_url":"https://api.github.com/users/daira/events{/privacy}","received_events_url":"https://api.github.com/users/daira/received_events","type":"User","site_admin":false},{"login":"mdr0id","id":36639405,"avatar_url":"https://avatars1.githubusercontent.com/u/36639405?v=4","gravatar_id":"","url":"https://api.github.com/users/mdr0id","html_url":"https://github.com/mdr0id","followers_url":"https://api.github.com/users/mdr0id/followers","following_url":"https://api.github.com/users/mdr0id/following{/other_user}","gists_url":"https://api.github.com/users/mdr0id/gists{/gist_id}","starred_url":"https://api.github.com/users/mdr0id/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdr0id/subscriptions","organizations_url":"https://api.github.com/users/mdr0id/orgs","repos_url":"https://api.github.com/users/mdr0id/repos","events_url":"https://api.github.com/users/mdr0id/events{/privacy}","received_events_url":"https://api.github.com/users/mdr0id/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":336611909,"url":"https://api.github.com/repos/zcash/zcash/labels/RPC%20interface","name":"RPC interface","color":"ffd0b7","default":false},{"id":150272745,"url":"https://api.github.com/repos/zcash/zcash/labels/bug","name":"bug","color":"fc4949","default":true},{"id":161973760,"url":"https://api.github.com/repos/zcash/zcash/labels/performance","name":"performance","color":"b495f9","default":false}],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/70","html_url":"https://github.com/zcash/zcash/milestone/70","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/70/labels","id":3037460,"number":70,"title":"v1.1.0","description":"First Overwinter-compatible release, containing the main-net activation height.","creator":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":28,"state":"open","created_at":"2018-01-15T22:36:32Z","updated_at":"2018-03-28T23:28:50Z","due_on":"2018-04-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/3106/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/3106/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3106/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/df420d1737d05582dbac68239827f6d2d3a2dd31","head":{"label":"braddmiller:3046-mergetoaddress-concurrent","ref":"3046-mergetoaddress-concurrent","sha":"df420d1737d05582dbac68239827f6d2d3a2dd31","user":{"login":"braddmiller","id":7740524,"avatar_url":"https://avatars1.githubusercontent.com/u/7740524?v=4","gravatar_id":"","url":"https://api.github.com/users/braddmiller","html_url":"https://github.com/braddmiller","followers_url":"https://api.github.com/users/braddmiller/followers","following_url":"https://api.github.com/users/braddmiller/following{/other_user}","gists_url":"https://api.github.com/users/braddmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/braddmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddmiller/subscriptions","organizations_url":"https://api.github.com/users/braddmiller/orgs","repos_url":"https://api.github.com/users/braddmiller/repos","events_url":"https://api.github.com/users/braddmiller/events{/privacy}","received_events_url":"https://api.github.com/users/braddmiller/received_events","type":"User","site_admin":false},"repo":{"id":123334502,"name":"zcash","full_name":"braddmiller/zcash","owner":{"login":"braddmiller","id":7740524,"avatar_url":"https://avatars1.githubusercontent.com/u/7740524?v=4","gravatar_id":"","url":"https://api.github.com/users/braddmiller","html_url":"https://github.com/braddmiller","followers_url":"https://api.github.com/users/braddmiller/followers","following_url":"https://api.github.com/users/braddmiller/following{/other_user}","gists_url":"https://api.github.com/users/braddmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/braddmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braddmiller/subscriptions","organizations_url":"https://api.github.com/users/braddmiller/orgs","repos_url":"https://api.github.com/users/braddmiller/repos","events_url":"https://api.github.com/users/braddmiller/events{/privacy}","received_events_url":"https://api.github.com/users/braddmiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/braddmiller/zcash","description":"Zcash - Internet Money","fork":true,"url":"https://api.github.com/repos/braddmiller/zcash","forks_url":"https://api.github.com/repos/braddmiller/zcash/forks","keys_url":"https://api.github.com/repos/braddmiller/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/braddmiller/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/braddmiller/zcash/teams","hooks_url":"https://api.github.com/repos/braddmiller/zcash/hooks","issue_events_url":"https://api.github.com/repos/braddmiller/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/braddmiller/zcash/events","assignees_url":"https://api.github.com/repos/braddmiller/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/braddmiller/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/braddmiller/zcash/tags","blobs_url":"https://api.github.com/repos/braddmiller/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/braddmiller/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/braddmiller/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/braddmiller/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/braddmiller/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/braddmiller/zcash/languages","stargazers_url":"https://api.github.com/repos/braddmiller/zcash/stargazers","contributors_url":"https://api.github.com/repos/braddmiller/zcash/contributors","subscribers_url":"https://api.github.com/repos/braddmiller/zcash/subscribers","subscription_url":"https://api.github.com/repos/braddmiller/zcash/subscription","commits_url":"https://api.github.com/repos/braddmiller/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/braddmiller/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/braddmiller/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/braddmiller/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/braddmiller/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/braddmiller/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/braddmiller/zcash/merges","archive_url":"https://api.github.com/repos/braddmiller/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/braddmiller/zcash/downloads","issues_url":"https://api.github.com/repos/braddmiller/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/braddmiller/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/braddmiller/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/braddmiller/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/braddmiller/zcash/labels{/name}","releases_url":"https://api.github.com/repos/braddmiller/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/braddmiller/zcash/deployments","created_at":"2018-02-28T19:50:55Z","updated_at":"2018-02-28T19:51:00Z","pushed_at":"2018-03-22T20:53:09Z","git_url":"git://github.com/braddmiller/zcash.git","ssh_url":"git@github.com:braddmiller/zcash.git","clone_url":"https://github.com/braddmiller/zcash.git","svn_url":"https://github.com/braddmiller/zcash","homepage":"https://z.cash/","size":52594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zcash:master","ref":"master","sha":"8ed0346284339e6f766e53da4d35226f930b40b5","user":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2018-03-28T19:13:26Z","pushed_at":"2018-03-28T20:53:37Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":52631,"stargazers_count":3607,"watchers_count":3607,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1114,"mirror_url":null,"archived":false,"open_issues_count":800,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1114,"open_issues":800,"watchers":3607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3106"},"html":{"href":"https://github.com/zcash/zcash/pull/3106"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/3106"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/3106/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3106/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3106/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/df420d1737d05582dbac68239827f6d2d3a2dd31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bitcartel"}}