{"action":"created","issue":{"url":"https://api.github.com/repos/cilium/cilium/issues/5515","repository_url":"https://api.github.com/repos/cilium/cilium","labels_url":"https://api.github.com/repos/cilium/cilium/issues/5515/labels{/name}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5515/comments","events_url":"https://api.github.com/repos/cilium/cilium/issues/5515/events","html_url":"https://github.com/cilium/cilium/pull/5515","id":358836836,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDc2Njcw","number":5515,"title":"endpoint: remove revision check around L4 policy calculation","user":{"login":"ianvernon","id":3858271,"node_id":"MDQ6VXNlcjM4NTgyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"labels":[{"id":746643464,"node_id":"MDU6TGFiZWw3NDY2NDM0NjQ=","url":"https://api.github.com/repos/cilium/cilium/labels/area/policy","name":"area/policy","color":"c9f97a","default":false},{"id":968882676,"node_id":"MDU6TGFiZWw5Njg4ODI2NzY=","url":"https://api.github.com/repos/cilium/cilium/labels/backport-pending/1.1","name":"backport-pending/1.1","color":"0e8a16","default":false},{"id":1007719222,"node_id":"MDU6TGFiZWwxMDA3NzE5MjIy","url":"https://api.github.com/repos/cilium/cilium/labels/backport-pending/1.2","name":"backport-pending/1.2","color":"0e8a16","default":false},{"id":930690043,"node_id":"MDU6TGFiZWw5MzA2OTAwNDM=","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.0","name":"needs-backport/1.0","color":"59f7df","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":627462913,"node_id":"MDU6TGFiZWw2Mjc0NjI5MTM=","url":"https://api.github.com/repos/cilium/cilium/labels/priority/high","name":"priority/high","color":"b60205","default":false},{"id":732924468,"node_id":"MDU6TGFiZWw3MzI5MjQ0Njg=","url":"https://api.github.com/repos/cilium/cilium/labels/release-note/bug","name":"release-note/bug","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/16","html_url":"https://github.com/cilium/cilium/milestone/16","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/16/labels","id":3566848,"node_id":"MDk6TWlsZXN0b25lMzU2Njg0OA==","number":16,"title":"1.3-bugfix","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":54,"state":"open","created_at":"2018-08-13T19:59:18Z","updated_at":"2018-09-12T15:48:11Z","due_on":"2018-09-21T07:00:00Z","closed_at":null},"comments":11,"created_at":"2018-09-10T23:58:51Z","updated_at":"2018-09-12T19:11:11Z","closed_at":"2018-09-12T05:11:12Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5515","html_url":"https://github.com/cilium/cilium/pull/5515","diff_url":"https://github.com/cilium/cilium/pull/5515.diff","patch_url":"https://github.com/cilium/cilium/pull/5515.patch"},"body":"Endpoint policy regeneration logic would check if the policy repository revision\r\nchanged from the endpoint's prior policy calculation to determine if the\r\nendpoint's L4 policy should be calculated. However, endpoint L4 policy should be\r\ncalculated for a variety of other reasons, including endpoint identity change.\r\nThus, short-circuiting endpoint L4 policy regeneration only based of the\r\ndifference of the endpoint's policy revision and the policy repository's\r\nrevision is incorrect and could lead to cases where L4 policy for an endpoint is\r\nnot calculated.\r\n\r\nSigned-off by: Ian Vernon <ian@cilium.io>\r\n\r\n```release-note\r\nAlways recalculate endpoint L4 policy when regeneratePolicy is called\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5515)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cilium/cilium/issues/comments/420764170","html_url":"https://github.com/cilium/cilium/pull/5515#issuecomment-420764170","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5515","id":420764170,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDc2NDE3MA==","user":{"login":"ianvernon","id":3858271,"node_id":"MDQ6VXNlcjM4NTgyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T19:11:11Z","updated_at":"2018-09-12T19:11:11Z","author_association":"CONTRIBUTOR","body":"Confirmed locally that the issue does not affect v1.0. Removing according backport label."}}
{"actor":{"display_login":"ianvernon"}}