{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/206290855","pull_request_review_id":141679227,"id":206290855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjI5MDg1NQ==","diff_hunk":"@@ -0,0 +1,96 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.arrow.vector.ipc.message;\n+\n+import java.nio.ByteBuffer;\n+\n+import org.apache.arrow.flatbuf.Message;\n+\n+/**\n+ * Class to hold resulting Message metadata and buffer containing the serialized Flatbuffer\n+ * message when reading messages from a ReadChannel. This handles Message metadata only and\n+ * does not include the message body data, which should be subsequently read into an ArrowBuf.\n+ */\n+public class MessageMetadataResult {\n+\n+  /**\n+   * Construct a container to hold a deserialized Message metadata, and buffer\n+   * with the serialized Message as read from a ReadChannel.\n+   *\n+   * @param messageLength the length of the serialized Flatbuffer message in bytes\n+   * @param messageBuffer contains the serialized Flatbuffer Message metadata\n+   * @param message the deserialized Flatbuffer Message metadata description\n+   */\n+  MessageMetadataResult(int messageLength, ByteBuffer messageBuffer, Message message) {\n+    this.messageLength = messageLength;\n+    this.messageBuffer = messageBuffer;\n+    this.message = message;","path":"java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageMetadataResult.java","position":43,"original_position":43,"commit_id":"cbb9c7de595bade08f16fba144d311f8af2d5722","original_commit_id":"cbb9c7de595bade08f16fba144d311f8af2d5722","user":{"login":"icexelloss","id":793516,"node_id":"MDQ6VXNlcjc5MzUxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/793516?v=4","gravatar_id":"","url":"https://api.github.com/users/icexelloss","html_url":"https://github.com/icexelloss","followers_url":"https://api.github.com/users/icexelloss/followers","following_url":"https://api.github.com/users/icexelloss/following{/other_user}","gists_url":"https://api.github.com/users/icexelloss/gists{/gist_id}","starred_url":"https://api.github.com/users/icexelloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icexelloss/subscriptions","organizations_url":"https://api.github.com/users/icexelloss/orgs","repos_url":"https://api.github.com/users/icexelloss/repos","events_url":"https://api.github.com/users/icexelloss/events{/privacy}","received_events_url":"https://api.github.com/users/icexelloss/received_events","type":"User","site_admin":false},"body":"It's up to you. I think verifying these will help catch bugs if people create an object incorrectly but it's not absolutely necessary. ","created_at":"2018-07-30T19:20:19Z","updated_at":"2018-07-30T19:20:19Z","html_url":"https://github.com/apache/arrow/pull/2340#discussion_r206290855","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/2340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/206290855"},"html":{"href":"https://github.com/apache/arrow/pull/2340#discussion_r206290855"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/2340"}},"in_reply_to_id":206255562},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/2340","id":204668050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjY4MDUw","html_url":"https://github.com/apache/arrow/pull/2340","diff_url":"https://github.com/apache/arrow/pull/2340.diff","patch_url":"https://github.com/apache/arrow/pull/2340.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/2340","number":2340,"state":"open","locked":false,"title":"ARROW-2937: [Java] Followup to ARROW-2704. Make MessageReader classes immutable and clarify docs ","user":{"login":"BryanCutler","id":4534389,"node_id":"MDQ6VXNlcjQ1MzQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4534389?v=4","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"body":"Changed MessageReader to return an immutable MessageResult, fixed up API wording to better describe the Message metadata as used in related classes and functions, and distinguish from actual Message data.","created_at":"2018-07-29T23:45:07Z","updated_at":"2018-07-30T19:20:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"569e57bd142ad78d739e6b92af295a1f863c9cd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/2340/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/2340/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/2340/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/cbb9c7de595bade08f16fba144d311f8af2d5722","head":{"label":"BryanCutler:java-MessageReader-followup-ARROW-2704","ref":"java-MessageReader-followup-ARROW-2704","sha":"cbb9c7de595bade08f16fba144d311f8af2d5722","user":{"login":"BryanCutler","id":4534389,"node_id":"MDQ6VXNlcjQ1MzQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4534389?v=4","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"repo":{"id":71180837,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE4MDgzNw==","name":"arrow","full_name":"BryanCutler/arrow","owner":{"login":"BryanCutler","id":4534389,"node_id":"MDQ6VXNlcjQ1MzQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/4534389?v=4","gravatar_id":"","url":"https://api.github.com/users/BryanCutler","html_url":"https://github.com/BryanCutler","followers_url":"https://api.github.com/users/BryanCutler/followers","following_url":"https://api.github.com/users/BryanCutler/following{/other_user}","gists_url":"https://api.github.com/users/BryanCutler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanCutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanCutler/subscriptions","organizations_url":"https://api.github.com/users/BryanCutler/orgs","repos_url":"https://api.github.com/users/BryanCutler/repos","events_url":"https://api.github.com/users/BryanCutler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanCutler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BryanCutler/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/BryanCutler/arrow","forks_url":"https://api.github.com/repos/BryanCutler/arrow/forks","keys_url":"https://api.github.com/repos/BryanCutler/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BryanCutler/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BryanCutler/arrow/teams","hooks_url":"https://api.github.com/repos/BryanCutler/arrow/hooks","issue_events_url":"https://api.github.com/repos/BryanCutler/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/BryanCutler/arrow/events","assignees_url":"https://api.github.com/repos/BryanCutler/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/BryanCutler/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/BryanCutler/arrow/tags","blobs_url":"https://api.github.com/repos/BryanCutler/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BryanCutler/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BryanCutler/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/BryanCutler/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BryanCutler/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/BryanCutler/arrow/languages","stargazers_url":"https://api.github.com/repos/BryanCutler/arrow/stargazers","contributors_url":"https://api.github.com/repos/BryanCutler/arrow/contributors","subscribers_url":"https://api.github.com/repos/BryanCutler/arrow/subscribers","subscription_url":"https://api.github.com/repos/BryanCutler/arrow/subscription","commits_url":"https://api.github.com/repos/BryanCutler/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/BryanCutler/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/BryanCutler/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/BryanCutler/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/BryanCutler/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/BryanCutler/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BryanCutler/arrow/merges","archive_url":"https://api.github.com/repos/BryanCutler/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BryanCutler/arrow/downloads","issues_url":"https://api.github.com/repos/BryanCutler/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/BryanCutler/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/BryanCutler/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/BryanCutler/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BryanCutler/arrow/labels{/name}","releases_url":"https://api.github.com/repos/BryanCutler/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/BryanCutler/arrow/deployments","created_at":"2016-10-17T21:00:55Z","updated_at":"2018-01-25T00:50:24Z","pushed_at":"2018-07-30T16:58:21Z","git_url":"git://github.com/BryanCutler/arrow.git","ssh_url":"git@github.com:BryanCutler/arrow.git","clone_url":"https://github.com/BryanCutler/arrow.git","svn_url":"https://github.com/BryanCutler/arrow","homepage":null,"size":14314,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7ffb6c5c346016b54884f58cbf79341fce8f1d13","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-07-30T16:49:56Z","pushed_at":"2018-07-30T18:07:09Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":14073,"stargazers_count":2244,"watchers_count":2244,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":611,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":611,"open_issues":43,"watchers":2244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/2340"},"html":{"href":"https://github.com/apache/arrow/pull/2340"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/2340"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/2340/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/2340/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/2340/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/cbb9c7de595bade08f16fba144d311f8af2d5722"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"icexelloss"}}