{"action":"created","comment":{"url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/comments/183551163","pull_request_review_id":114571661,"id":183551163,"diff_hunk":"@@ -27,14 +27,16 @@ import Data.Traversable (traverse)\n -- | set (ix 1) 8888 [0, 1, 2] == [0,8888,2]\n -- | ```\n -- |\n--- | Note the use of `preview` rather `view`.\n+-- | Note the use of `preview` rather `view`. That's because the optic is \n+-- | a `Data.Lens.Traversal` tailored to the case where there's a single element\n+-- | of interest.","path":"src/Data/Lens/Index.purs","position":null,"original_position":16,"commit_id":"9dd4432590a50f05574d7369eb96184195b88803","original_commit_id":"9dd4432590a50f05574d7369eb96184195b88803","user":{"login":"marick","id":71909,"avatar_url":"https://avatars3.githubusercontent.com/u/71909?v=4","gravatar_id":"","url":"https://api.github.com/users/marick","html_url":"https://github.com/marick","followers_url":"https://api.github.com/users/marick/followers","following_url":"https://api.github.com/users/marick/following{/other_user}","gists_url":"https://api.github.com/users/marick/gists{/gist_id}","starred_url":"https://api.github.com/users/marick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marick/subscriptions","organizations_url":"https://api.github.com/users/marick/orgs","repos_url":"https://api.github.com/users/marick/repos","events_url":"https://api.github.com/users/marick/events{/privacy}","received_events_url":"https://api.github.com/users/marick/received_events","type":"User","site_admin":false},"body":"The problem is that `Index` and `At` are closely linked by usage. From the point of view of a person choosing between them, they *both* can return a `Nothing`. That the mechanism is different is not the sort of detail we should force users to learn, at least not in the quick reference.","created_at":"2018-04-23T22:02:14Z","updated_at":"2018-04-23T22:02:14Z","html_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84#discussion_r183551163","pull_request_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/comments/183551163"},"html":{"href":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84#discussion_r183551163"},"pull_request":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84"}},"in_reply_to_id":183358453},"pull_request":{"url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84","id":177262308,"html_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84","diff_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84.diff","patch_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84.patch","issue_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/84","number":84,"state":"open","locked":false,"title":"A start at documentation","user":{"login":"marick","id":71909,"avatar_url":"https://avatars3.githubusercontent.com/u/71909?v=4","gravatar_id":"","url":"https://api.github.com/users/marick","html_url":"https://github.com/marick","followers_url":"https://api.github.com/users/marick/followers","following_url":"https://api.github.com/users/marick/following{/other_user}","gists_url":"https://api.github.com/users/marick/gists{/gist_id}","starred_url":"https://api.github.com/users/marick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marick/subscriptions","organizations_url":"https://api.github.com/users/marick/orgs","repos_url":"https://api.github.com/users/marick/repos","events_url":"https://api.github.com/users/marick/events{/privacy}","received_events_url":"https://api.github.com/users/marick/received_events","type":"User","site_admin":false},"body":"This pull request shows the sort of documentation I (as a beginner) would have liked to see when I started using this package. See #82.\r\n\r\nThere are two sorts of changes:\r\n\r\n1. I added commentary, with examples, to type classes, types, and functions.\r\n2. I reordered definitions so the more important functions came first. (For example, I really think a reader should encounter `lens` before `lens'`. \r\n\r\n\r\n\r\n","created_at":"2018-03-24T22:33:00Z","updated_at":"2018-04-23T22:02:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e6e8e869c87416257e653d4f2e1365cc746d8af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84/commits","review_comments_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84/comments","review_comment_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/84/comments","statuses_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/statuses/9dd4432590a50f05574d7369eb96184195b88803","head":{"label":"marick:master","ref":"master","sha":"9dd4432590a50f05574d7369eb96184195b88803","user":{"login":"marick","id":71909,"avatar_url":"https://avatars3.githubusercontent.com/u/71909?v=4","gravatar_id":"","url":"https://api.github.com/users/marick","html_url":"https://github.com/marick","followers_url":"https://api.github.com/users/marick/followers","following_url":"https://api.github.com/users/marick/following{/other_user}","gists_url":"https://api.github.com/users/marick/gists{/gist_id}","starred_url":"https://api.github.com/users/marick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marick/subscriptions","organizations_url":"https://api.github.com/users/marick/orgs","repos_url":"https://api.github.com/users/marick/repos","events_url":"https://api.github.com/users/marick/events{/privacy}","received_events_url":"https://api.github.com/users/marick/received_events","type":"User","site_admin":false},"repo":{"id":124440034,"name":"purescript-profunctor-lenses","full_name":"marick/purescript-profunctor-lenses","owner":{"login":"marick","id":71909,"avatar_url":"https://avatars3.githubusercontent.com/u/71909?v=4","gravatar_id":"","url":"https://api.github.com/users/marick","html_url":"https://github.com/marick","followers_url":"https://api.github.com/users/marick/followers","following_url":"https://api.github.com/users/marick/following{/other_user}","gists_url":"https://api.github.com/users/marick/gists{/gist_id}","starred_url":"https://api.github.com/users/marick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marick/subscriptions","organizations_url":"https://api.github.com/users/marick/orgs","repos_url":"https://api.github.com/users/marick/repos","events_url":"https://api.github.com/users/marick/events{/privacy}","received_events_url":"https://api.github.com/users/marick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marick/purescript-profunctor-lenses","description":"Pure profunctor lenses","fork":true,"url":"https://api.github.com/repos/marick/purescript-profunctor-lenses","forks_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/forks","keys_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/teams","hooks_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/hooks","issue_events_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/issues/events{/number}","events_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/events","assignees_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/assignees{/user}","branches_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/branches{/branch}","tags_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/tags","blobs_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/git/refs{/sha}","trees_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/statuses/{sha}","languages_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/languages","stargazers_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/stargazers","contributors_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/contributors","subscribers_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/subscribers","subscription_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/subscription","commits_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/commits{/sha}","git_commits_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/git/commits{/sha}","comments_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/comments{/number}","issue_comment_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/issues/comments{/number}","contents_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/contents/{+path}","compare_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/merges","archive_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/downloads","issues_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/issues{/number}","pulls_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/pulls{/number}","milestones_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/milestones{/number}","notifications_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/labels{/name}","releases_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/releases{/id}","deployments_url":"https://api.github.com/repos/marick/purescript-profunctor-lenses/deployments","created_at":"2018-03-08T19:46:37Z","updated_at":"2018-04-22T22:27:40Z","pushed_at":"2018-04-22T22:27:38Z","git_url":"git://github.com/marick/purescript-profunctor-lenses.git","ssh_url":"git@github.com:marick/purescript-profunctor-lenses.git","clone_url":"https://github.com/marick/purescript-profunctor-lenses.git","svn_url":"https://github.com/marick/purescript-profunctor-lenses","homepage":null,"size":134,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript-contrib:master","ref":"master","sha":"d093f3bbe7dc102ffb3978fde367931d2d1ecc19","user":{"login":"purescript-contrib","id":7391813,"avatar_url":"https://avatars0.githubusercontent.com/u/7391813?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript-contrib","html_url":"https://github.com/purescript-contrib","followers_url":"https://api.github.com/users/purescript-contrib/followers","following_url":"https://api.github.com/users/purescript-contrib/following{/other_user}","gists_url":"https://api.github.com/users/purescript-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript-contrib/subscriptions","organizations_url":"https://api.github.com/users/purescript-contrib/orgs","repos_url":"https://api.github.com/users/purescript-contrib/repos","events_url":"https://api.github.com/users/purescript-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/purescript-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":41980997,"name":"purescript-profunctor-lenses","full_name":"purescript-contrib/purescript-profunctor-lenses","owner":{"login":"purescript-contrib","id":7391813,"avatar_url":"https://avatars0.githubusercontent.com/u/7391813?v=4","gravatar_id":"","url":"https://api.github.com/users/purescript-contrib","html_url":"https://github.com/purescript-contrib","followers_url":"https://api.github.com/users/purescript-contrib/followers","following_url":"https://api.github.com/users/purescript-contrib/following{/other_user}","gists_url":"https://api.github.com/users/purescript-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript-contrib/subscriptions","organizations_url":"https://api.github.com/users/purescript-contrib/orgs","repos_url":"https://api.github.com/users/purescript-contrib/repos","events_url":"https://api.github.com/users/purescript-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/purescript-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses","description":"Pure profunctor lenses","fork":false,"url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses","forks_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/forks","keys_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/teams","hooks_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/hooks","issue_events_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/events{/number}","events_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/events","assignees_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/assignees{/user}","branches_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/branches{/branch}","tags_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/tags","blobs_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/languages","stargazers_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/stargazers","contributors_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/contributors","subscribers_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/subscribers","subscription_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/subscription","commits_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/contents/{+path}","compare_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/merges","archive_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/downloads","issues_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues{/number}","pulls_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/labels{/name}","releases_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/releases{/id}","deployments_url":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/deployments","created_at":"2015-09-06T00:50:25Z","updated_at":"2018-04-11T10:31:00Z","pushed_at":"2018-04-22T22:27:39Z","git_url":"git://github.com/purescript-contrib/purescript-profunctor-lenses.git","ssh_url":"git@github.com:purescript-contrib/purescript-profunctor-lenses.git","clone_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses.git","svn_url":"https://github.com/purescript-contrib/purescript-profunctor-lenses","homepage":null,"size":129,"stargazers_count":55,"watchers_count":55,"language":"PureScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":30,"open_issues":19,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84"},"html":{"href":"https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/84"},"issue":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/84"},"comments":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/purescript-contrib/purescript-profunctor-lenses/statuses/9dd4432590a50f05574d7369eb96184195b88803"}},"author_association":"NONE"}}
{"actor":{"display_login":"marick"}}