{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786/events","html_url":"https://github.com/StrikeNP/trac_test/issues/786","id":330469363,"node_id":"MDU6SXNzdWUzMzA0NjkzNjM=","number":786,"title":"Tuner broken for RICO (and probably other cases that use microphysics) (Trac #786)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":958019852,"node_id":"MDU6TGFiZWw5NTgwMTk4NTI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":958042830,"node_id":"MDU6TGFiZWw5NTgwNDI4MzA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":958019855,"node_id":"MDU6TGFiZWw5NTgwMTk4NTU=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/defect","name":"defect","color":"FFFFFF","default":false},{"id":958114258,"node_id":"MDU6TGFiZWw5NTgxMTQyNTg=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/raut@uwm.edu","name":"raut@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/13","html_url":"https://github.com/StrikeNP/trac_test/milestone/13","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/13/labels","id":3408915,"node_id":"MDk6TWlsZXN0b25lMzQwODkxNQ==","number":13,"title":"4. Fix bugs","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":36,"state":"open","created_at":"2018-06-07T20:16:29Z","updated_at":"2018-06-10T14:10:10Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-06-07T23:24:35Z","updated_at":"2018-06-10T14:14:36Z","closed_at":null,"author_association":"OWNER","body":"The tuner is broken for the RICO case.  This is not reflected on the nightly tests because the nightly run is for FIRE, which does not use microphysics.  However, the RICO tuner fails with the following error message:\n\n\n```text\nAt line 757 of file ../src/microphys_init_cleanup.F90\nFortran runtime error: Attempting to allocate already allocated array 'l_hydromet_sed'\n```\n\nI assume that ```l_hydromet_sed``` is not being deallocated, so that during the next tuning set, the attempt to allocate an already allocated variable causes the problem.\n\nHowever, there is code in place that deallocates ```l_hydromet_sed```.  It looks to me like this is normally called.\n\nI put a print statement in the code to see if that piece of code that deallocates ```l_hydromet_sed``` is called.  It normally is, however, at one point during the tuning, a parameter set failed and apparently that code was not called as a result.\n\nThe tuner was working for me recently.  It was only after I svn updated that the problems started.  I don't know if a recent change affected this, or if this is a long standing issue, because I don't think I had a parameter set fail when I was tuning before.  It could be a long standing issue because the nightly tests run a case that doesn't use microphysics, and this is a microphysics-related issue.\n\nAttachments:\n\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/786/RICO_tuner_diff.diff\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/786\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2016-04-26T18:27:25\", \n    \"description\": \"The tuner is broken for the RICO case.  This is not reflected on the nightly tests because the nightly run is for FIRE, which does not use microphysics.  However, the RICO tuner fails with the following error message:\\n\\n{{{\\nAt line 757 of file ../src/microphys_init_cleanup.F90\\nFortran runtime error: Attempting to allocate already allocated array 'l_hydromet_sed'\\n}}}\\n\\nI assume that {{{l_hydromet_sed}}} is not being deallocated, so that during the next tuning set, the attempt to allocate an already allocated variable causes the problem.\\n\\nHowever, there is code in place that deallocates {{{l_hydromet_sed}}}.  It looks to me like this is normally called.\\n\\nI put a print statement in the code to see if that piece of code that deallocates {{{l_hydromet_sed}}} is called.  It normally is, however, at one point during the tuning, a parameter set failed and apparently that code was not called as a result.\\n\\nThe tuner was working for me recently.  It was only after I svn updated that the problems started.  I don't know if a recent change affected this, or if this is a long standing issue, because I don't think I had a parameter set fail when I was tuning before.  It could be a long standing issue because the nightly tests run a case that doesn't use microphysics, and this is a microphysics-related issue.\", \n    \"reporter\": \"bmg2@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, raut@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1461695245674668\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Tuner broken for RICO (and probably other cases that use microphysics)\", \n    \"priority\": \"minor\", \n    \"keywords\": \"tuner RICO\", \n    \"time\": \"2016-03-21T18:43:05\", \n    \"milestone\": \"4. Fix bugs\", \n    \"owner\": \"raut@uwm.edu\", \n    \"type\": \"defect\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/396052462","html_url":"https://github.com/StrikeNP/trac_test/issues/786#issuecomment-396052462","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/786","id":396052462,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA1MjQ2Mg==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T14:14:36Z","updated_at":"2018-06-10T14:14:36Z","author_association":"OWNER","body":"Trac update at 2016/03/22 at 20:13\n\nraut@uwm.edu commented:\n\nReplying to [comment:10 vlarson@…]:\n> Replying to [comment:7 bmg2@…]:\n> > To prevent things like this from happening in the future, we should change the nightly test.  Perhaps we could even do something as simple as turning on SILHS with Morrison microphysics for the FIRE case for the nightly tuning run.  It won't have much of an effect.  The point is just to monitor for problems that crop up.\n> Yes, that sounds like a worthwhile thing to do.  Eric, could you do this?\n\n\nSure, I will add it to my list.\n\n"}}
{"actor":{"display_login":"StrikeNP"}}