{"action":"created","comment":{"url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/comments/178555411","pull_request_review_id":108627061,"id":178555411,"diff_hunk":"@@ -14,8 +14,57 @@ the packages individually, for example:\n     make -C debs/xenial/archivematica\n     make -C debs/xenial/archivematica-storage-service\n \n-### Test packages\n+#### Using parameters\n \n+Most makefiles support parameters in the form of environment variables. They \n+may be a bit different between packages, but the most common are ``BRANCH``,\n+``VERSION`` and ``RELEASE``.\n+\n+So in order to build a specific branch / version, this command can be used from\n+the folder of the package we want to build:\n+\n+    make BRANCH=qa/1.x VERSION=1.7.0 RELEASE=rc5\n+\n+Keep in mind that the Makefiles are a bit recursive, they will invoke docker, ","path":"README.md","position":16,"original_position":16,"commit_id":"7da156fc1af3a36cd9021c8080c3dd046655223d","original_commit_id":"7da156fc1af3a36cd9021c8080c3dd046655223d","user":{"login":"sevein","id":606459,"avatar_url":"https://avatars2.githubusercontent.com/u/606459?v=4","gravatar_id":"","url":"https://api.github.com/users/sevein","html_url":"https://github.com/sevein","followers_url":"https://api.github.com/users/sevein/followers","following_url":"https://api.github.com/users/sevein/following{/other_user}","gists_url":"https://api.github.com/users/sevein/gists{/gist_id}","starred_url":"https://api.github.com/users/sevein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevein/subscriptions","organizations_url":"https://api.github.com/users/sevein/orgs","repos_url":"https://api.github.com/users/sevein/repos","events_url":"https://api.github.com/users/sevein/events{/privacy}","received_events_url":"https://api.github.com/users/sevein/received_events","type":"User","site_admin":false},"body":"In L33 you wrote \"Some makefiles\", here reads \"the Makefiles\". Not sure which one is correct but I suggest to pick one and be consistent.","created_at":"2018-04-02T14:31:39Z","updated_at":"2018-04-02T14:49:54Z","html_url":"https://github.com/artefactual-labs/am-packbuild/pull/142#discussion_r178555411","pull_request_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/comments/178555411"},"html":{"href":"https://github.com/artefactual-labs/am-packbuild/pull/142#discussion_r178555411"},"pull_request":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142","id":177389385,"html_url":"https://github.com/artefactual-labs/am-packbuild/pull/142","diff_url":"https://github.com/artefactual-labs/am-packbuild/pull/142.diff","patch_url":"https://github.com/artefactual-labs/am-packbuild/pull/142.patch","issue_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/142","number":142,"state":"open","locked":false,"title":"README Updates","user":{"login":"scollazo","id":2728070,"avatar_url":"https://avatars0.githubusercontent.com/u/2728070?v=4","gravatar_id":"","url":"https://api.github.com/users/scollazo","html_url":"https://github.com/scollazo","followers_url":"https://api.github.com/users/scollazo/followers","following_url":"https://api.github.com/users/scollazo/following{/other_user}","gists_url":"https://api.github.com/users/scollazo/gists{/gist_id}","starred_url":"https://api.github.com/users/scollazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scollazo/subscriptions","organizations_url":"https://api.github.com/users/scollazo/orgs","repos_url":"https://api.github.com/users/scollazo/repos","events_url":"https://api.github.com/users/scollazo/events{/privacy}","received_events_url":"https://api.github.com/users/scollazo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-26T09:32:29Z","updated_at":"2018-04-02T14:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd3c54981fc6c065337702478b1aa0b8f36d7ec4","assignee":{"login":"scollazo","id":2728070,"avatar_url":"https://avatars0.githubusercontent.com/u/2728070?v=4","gravatar_id":"","url":"https://api.github.com/users/scollazo","html_url":"https://github.com/scollazo","followers_url":"https://api.github.com/users/scollazo/followers","following_url":"https://api.github.com/users/scollazo/following{/other_user}","gists_url":"https://api.github.com/users/scollazo/gists{/gist_id}","starred_url":"https://api.github.com/users/scollazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scollazo/subscriptions","organizations_url":"https://api.github.com/users/scollazo/orgs","repos_url":"https://api.github.com/users/scollazo/repos","events_url":"https://api.github.com/users/scollazo/events{/privacy}","received_events_url":"https://api.github.com/users/scollazo/received_events","type":"User","site_admin":false},"assignees":[{"login":"scollazo","id":2728070,"avatar_url":"https://avatars0.githubusercontent.com/u/2728070?v=4","gravatar_id":"","url":"https://api.github.com/users/scollazo","html_url":"https://github.com/scollazo","followers_url":"https://api.github.com/users/scollazo/followers","following_url":"https://api.github.com/users/scollazo/following{/other_user}","gists_url":"https://api.github.com/users/scollazo/gists{/gist_id}","starred_url":"https://api.github.com/users/scollazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scollazo/subscriptions","organizations_url":"https://api.github.com/users/scollazo/orgs","repos_url":"https://api.github.com/users/scollazo/repos","events_url":"https://api.github.com/users/scollazo/events{/privacy}","received_events_url":"https://api.github.com/users/scollazo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142/commits","review_comments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142/comments","review_comment_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/142/comments","statuses_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/statuses/7da156fc1af3a36cd9021c8080c3dd046655223d","head":{"label":"artefactual-labs:dev/update-readme","ref":"dev/update-readme","sha":"7da156fc1af3a36cd9021c8080c3dd046655223d","user":{"login":"artefactual-labs","id":11890453,"avatar_url":"https://avatars0.githubusercontent.com/u/11890453?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual-labs","html_url":"https://github.com/artefactual-labs","followers_url":"https://api.github.com/users/artefactual-labs/followers","following_url":"https://api.github.com/users/artefactual-labs/following{/other_user}","gists_url":"https://api.github.com/users/artefactual-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual-labs/subscriptions","organizations_url":"https://api.github.com/users/artefactual-labs/orgs","repos_url":"https://api.github.com/users/artefactual-labs/repos","events_url":"https://api.github.com/users/artefactual-labs/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":29562586,"name":"am-packbuild","full_name":"artefactual-labs/am-packbuild","owner":{"login":"artefactual-labs","id":11890453,"avatar_url":"https://avatars0.githubusercontent.com/u/11890453?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual-labs","html_url":"https://github.com/artefactual-labs","followers_url":"https://api.github.com/users/artefactual-labs/followers","following_url":"https://api.github.com/users/artefactual-labs/following{/other_user}","gists_url":"https://api.github.com/users/artefactual-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual-labs/subscriptions","organizations_url":"https://api.github.com/users/artefactual-labs/orgs","repos_url":"https://api.github.com/users/artefactual-labs/repos","events_url":"https://api.github.com/users/artefactual-labs/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual-labs/am-packbuild","description":"Archivematica package building scripts","fork":false,"url":"https://api.github.com/repos/artefactual-labs/am-packbuild","forks_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/forks","keys_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/teams","hooks_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/hooks","issue_events_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/events","assignees_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/tags","blobs_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/languages","stargazers_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/stargazers","contributors_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/contributors","subscribers_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/subscribers","subscription_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/subscription","commits_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/merges","archive_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/downloads","issues_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/labels{/name}","releases_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/deployments","created_at":"2015-01-21T00:20:29Z","updated_at":"2018-04-02T10:52:34Z","pushed_at":"2018-04-02T14:03:18Z","git_url":"git://github.com/artefactual-labs/am-packbuild.git","ssh_url":"git@github.com:artefactual-labs/am-packbuild.git","clone_url":"https://github.com/artefactual-labs/am-packbuild.git","svn_url":"https://github.com/artefactual-labs/am-packbuild","homepage":null,"size":13862,"stargazers_count":3,"watchers_count":3,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":32,"watchers":3,"default_branch":"master"}},"base":{"label":"artefactual-labs:master","ref":"master","sha":"600321b630422898ef5b3dd48073ae6fdfc89d28","user":{"login":"artefactual-labs","id":11890453,"avatar_url":"https://avatars0.githubusercontent.com/u/11890453?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual-labs","html_url":"https://github.com/artefactual-labs","followers_url":"https://api.github.com/users/artefactual-labs/followers","following_url":"https://api.github.com/users/artefactual-labs/following{/other_user}","gists_url":"https://api.github.com/users/artefactual-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual-labs/subscriptions","organizations_url":"https://api.github.com/users/artefactual-labs/orgs","repos_url":"https://api.github.com/users/artefactual-labs/repos","events_url":"https://api.github.com/users/artefactual-labs/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":29562586,"name":"am-packbuild","full_name":"artefactual-labs/am-packbuild","owner":{"login":"artefactual-labs","id":11890453,"avatar_url":"https://avatars0.githubusercontent.com/u/11890453?v=4","gravatar_id":"","url":"https://api.github.com/users/artefactual-labs","html_url":"https://github.com/artefactual-labs","followers_url":"https://api.github.com/users/artefactual-labs/followers","following_url":"https://api.github.com/users/artefactual-labs/following{/other_user}","gists_url":"https://api.github.com/users/artefactual-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual-labs/subscriptions","organizations_url":"https://api.github.com/users/artefactual-labs/orgs","repos_url":"https://api.github.com/users/artefactual-labs/repos","events_url":"https://api.github.com/users/artefactual-labs/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual-labs/am-packbuild","description":"Archivematica package building scripts","fork":false,"url":"https://api.github.com/repos/artefactual-labs/am-packbuild","forks_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/forks","keys_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/teams","hooks_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/hooks","issue_events_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/events","assignees_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/tags","blobs_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/languages","stargazers_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/stargazers","contributors_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/contributors","subscribers_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/subscribers","subscription_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/subscription","commits_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/merges","archive_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/downloads","issues_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/labels{/name}","releases_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual-labs/am-packbuild/deployments","created_at":"2015-01-21T00:20:29Z","updated_at":"2018-04-02T10:52:34Z","pushed_at":"2018-04-02T14:03:18Z","git_url":"git://github.com/artefactual-labs/am-packbuild.git","ssh_url":"git@github.com:artefactual-labs/am-packbuild.git","clone_url":"https://github.com/artefactual-labs/am-packbuild.git","svn_url":"https://github.com/artefactual-labs/am-packbuild","homepage":null,"size":13862,"stargazers_count":3,"watchers_count":3,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":32,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142"},"html":{"href":"https://github.com/artefactual-labs/am-packbuild/pull/142"},"issue":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/142"},"comments":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual-labs/am-packbuild/statuses/7da156fc1af3a36cd9021c8080c3dd046655223d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sevein"}}