{"action":"created","comment":{"url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/comments/179756776","pull_request_review_id":110060406,"id":179756776,"diff_hunk":"@@ -110,6 +119,31 @@ public ValidationResult validate(BidRequest bidRequest) {\n         return ValidationResult.success();\n     }\n \n+    private void validateBidAdjustmentFactors(Map<String, BigDecimal> adjustmentFactors, Map<String, String> aliases)\n+            throws ValidationException {\n+\n+        for (Map.Entry<String, BigDecimal> bidderAdjustment : adjustmentFactors.entrySet()) {\n+            final String bidder = bidderAdjustment.getKey();\n+            final BigDecimal adjustmentFactor = bidderAdjustment.getValue();","path":"src/main/java/org/prebid/server/validation/RequestValidator.java","position":46,"original_position":46,"commit_id":"626fb4918f77c846fbb2e1700eac7cf3339bc5ee","original_commit_id":"626fb4918f77c846fbb2e1700eac7cf3339bc5ee","user":{"login":"rpanchyk","id":29976213,"avatar_url":"https://avatars2.githubusercontent.com/u/29976213?v=4","gravatar_id":"","url":"https://api.github.com/users/rpanchyk","html_url":"https://github.com/rpanchyk","followers_url":"https://api.github.com/users/rpanchyk/followers","following_url":"https://api.github.com/users/rpanchyk/following{/other_user}","gists_url":"https://api.github.com/users/rpanchyk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpanchyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpanchyk/subscriptions","organizations_url":"https://api.github.com/users/rpanchyk/orgs","repos_url":"https://api.github.com/users/rpanchyk/repos","events_url":"https://api.github.com/users/rpanchyk/events{/privacy}","received_events_url":"https://api.github.com/users/rpanchyk/received_events","type":"User","site_admin":false},"body":"Minor. We can move down adjustmentFactor before `if(...)` statement.","created_at":"2018-04-06T13:28:39Z","updated_at":"2018-04-06T13:39:33Z","html_url":"https://github.com/rubicon-project/prebid-server-java/pull/6#discussion_r179756776","pull_request_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/comments/179756776"},"html":{"href":"https://github.com/rubicon-project/prebid-server-java/pull/6#discussion_r179756776"},"pull_request":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6","id":179727239,"html_url":"https://github.com/rubicon-project/prebid-server-java/pull/6","diff_url":"https://github.com/rubicon-project/prebid-server-java/pull/6.diff","patch_url":"https://github.com/rubicon-project/prebid-server-java/pull/6.patch","issue_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/6","number":6,"state":"open","locked":false,"title":"Implemented bid price adjustment","user":{"login":"anestere","id":5513677,"avatar_url":"https://avatars3.githubusercontent.com/u/5513677?v=4","gravatar_id":"","url":"https://api.github.com/users/anestere","html_url":"https://github.com/anestere","followers_url":"https://api.github.com/users/anestere/followers","following_url":"https://api.github.com/users/anestere/following{/other_user}","gists_url":"https://api.github.com/users/anestere/gists{/gist_id}","starred_url":"https://api.github.com/users/anestere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anestere/subscriptions","organizations_url":"https://api.github.com/users/anestere/orgs","repos_url":"https://api.github.com/users/anestere/repos","events_url":"https://api.github.com/users/anestere/events{/privacy}","received_events_url":"https://api.github.com/users/anestere/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-05T16:17:22Z","updated_at":"2018-04-06T13:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e36778c9cf33023752fa8fd50fa11c2696bb757c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6/commits","review_comments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6/comments","review_comment_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/6/comments","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/statuses/626fb4918f77c846fbb2e1700eac7cf3339bc5ee","head":{"label":"rubicon-project:bid-cpm-adjustment","ref":"bid-cpm-adjustment","sha":"626fb4918f77c846fbb2e1700eac7cf3339bc5ee","user":{"login":"rubicon-project","id":367823,"avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"repo":{"id":124555222,"name":"prebid-server-java","full_name":"rubicon-project/prebid-server-java","owner":{"login":"rubicon-project","id":367823,"avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubicon-project/prebid-server-java","description":"Java version of Prebid Server","fork":false,"url":"https://api.github.com/repos/rubicon-project/prebid-server-java","forks_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/forks","keys_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/teams","hooks_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/hooks","issue_events_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/events{/number}","events_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/events","assignees_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/assignees{/user}","branches_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/branches{/branch}","tags_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/tags","blobs_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/statuses/{sha}","languages_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/languages","stargazers_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/stargazers","contributors_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/contributors","subscribers_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/subscribers","subscription_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/subscription","commits_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/contents/{+path}","compare_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/merges","archive_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/downloads","issues_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues{/number}","pulls_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls{/number}","milestones_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/milestones{/number}","notifications_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/labels{/name}","releases_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/releases{/id}","deployments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/deployments","created_at":"2018-03-09T15:05:17Z","updated_at":"2018-04-05T09:48:12Z","pushed_at":"2018-04-06T12:03:04Z","git_url":"git://github.com/rubicon-project/prebid-server-java.git","ssh_url":"git@github.com:rubicon-project/prebid-server-java.git","clone_url":"https://github.com/rubicon-project/prebid-server-java.git","svn_url":"https://github.com/rubicon-project/prebid-server-java","homepage":null,"size":2444,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"rubicon-project:master","ref":"master","sha":"57f6d01a5aa50a1442b098d718639a27ddf58c7b","user":{"login":"rubicon-project","id":367823,"avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"repo":{"id":124555222,"name":"prebid-server-java","full_name":"rubicon-project/prebid-server-java","owner":{"login":"rubicon-project","id":367823,"avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubicon-project/prebid-server-java","description":"Java version of Prebid Server","fork":false,"url":"https://api.github.com/repos/rubicon-project/prebid-server-java","forks_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/forks","keys_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/teams","hooks_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/hooks","issue_events_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/events{/number}","events_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/events","assignees_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/assignees{/user}","branches_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/branches{/branch}","tags_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/tags","blobs_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/statuses/{sha}","languages_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/languages","stargazers_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/stargazers","contributors_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/contributors","subscribers_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/subscribers","subscription_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/subscription","commits_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/contents/{+path}","compare_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/merges","archive_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/downloads","issues_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues{/number}","pulls_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls{/number}","milestones_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/milestones{/number}","notifications_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/labels{/name}","releases_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/releases{/id}","deployments_url":"https://api.github.com/repos/rubicon-project/prebid-server-java/deployments","created_at":"2018-03-09T15:05:17Z","updated_at":"2018-04-05T09:48:12Z","pushed_at":"2018-04-06T12:03:04Z","git_url":"git://github.com/rubicon-project/prebid-server-java.git","ssh_url":"git@github.com:rubicon-project/prebid-server-java.git","clone_url":"https://github.com/rubicon-project/prebid-server-java.git","svn_url":"https://github.com/rubicon-project/prebid-server-java","homepage":null,"size":2444,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6"},"html":{"href":"https://github.com/rubicon-project/prebid-server-java/pull/6"},"issue":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/6"},"comments":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/rubicon-project/prebid-server-java/statuses/626fb4918f77c846fbb2e1700eac7cf3339bc5ee"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rpanchyk"}}