{"action":"created","comment":{"url":"https://api.github.com/repos/davisking/dlib/pulls/comments/182214135","pull_request_review_id":112977504,"id":182214135,"diff_hunk":"@@ -24,17 +34,26 @@ def get_test_face_chips():\n def get_test_face_chip():\n     rgb_img, shape = get_test_image_and_shape()\n     return dlib.get_face_chip(rgb_img, shape)\n- \n+\n+# The tests below will be skipped for Python 2.7 as there is a pickle issue","path":"tools/python/test/test_numpy_returns.py","position":null,"original_position":41,"commit_id":"0b578f7305eb2bea744883890441a52a8bd0afef","original_commit_id":"0b578f7305eb2bea744883890441a52a8bd0afef","user":{"login":"davisking","id":6259399,"avatar_url":"https://avatars1.githubusercontent.com/u/6259399?v=4","gravatar_id":"","url":"https://api.github.com/users/davisking","html_url":"https://github.com/davisking","followers_url":"https://api.github.com/users/davisking/followers","following_url":"https://api.github.com/users/davisking/following{/other_user}","gists_url":"https://api.github.com/users/davisking/gists{/gist_id}","starred_url":"https://api.github.com/users/davisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisking/subscriptions","organizations_url":"https://api.github.com/users/davisking/orgs","repos_url":"https://api.github.com/users/davisking/repos","events_url":"https://api.github.com/users/davisking/events{/privacy}","received_events_url":"https://api.github.com/users/davisking/received_events","type":"User","site_admin":false},"body":"If you use cPickle and a call like .dumps(variable,2) it works.  See http://pybind11.readthedocs.io/en/stable/advanced/classes.html#pickling-support","created_at":"2018-04-17T20:25:33Z","updated_at":"2018-04-17T20:25:33Z","html_url":"https://github.com/davisking/dlib/pull/1258#discussion_r182214135","pull_request_url":"https://api.github.com/repos/davisking/dlib/pulls/1258","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/davisking/dlib/pulls/comments/182214135"},"html":{"href":"https://github.com/davisking/dlib/pull/1258#discussion_r182214135"},"pull_request":{"href":"https://api.github.com/repos/davisking/dlib/pulls/1258"}},"in_reply_to_id":182210600},"pull_request":{"url":"https://api.github.com/repos/davisking/dlib/pulls/1258","id":182121015,"html_url":"https://github.com/davisking/dlib/pull/1258","diff_url":"https://github.com/davisking/dlib/pull/1258.diff","patch_url":"https://github.com/davisking/dlib/pull/1258.patch","issue_url":"https://api.github.com/repos/davisking/dlib/issues/1258","number":1258,"state":"open","locked":false,"title":"Add basic image io and remove python C-API refs from numpy_returns.cpp","user":{"login":"visionworkz","id":31665404,"avatar_url":"https://avatars2.githubusercontent.com/u/31665404?v=4","gravatar_id":"","url":"https://api.github.com/users/visionworkz","html_url":"https://github.com/visionworkz","followers_url":"https://api.github.com/users/visionworkz/followers","following_url":"https://api.github.com/users/visionworkz/following{/other_user}","gists_url":"https://api.github.com/users/visionworkz/gists{/gist_id}","starred_url":"https://api.github.com/users/visionworkz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visionworkz/subscriptions","organizations_url":"https://api.github.com/users/visionworkz/orgs","repos_url":"https://api.github.com/users/visionworkz/repos","events_url":"https://api.github.com/users/visionworkz/events{/privacy}","received_events_url":"https://api.github.com/users/visionworkz/received_events","type":"User","site_admin":false},"body":"This is a consolidation of the discussion in https://github.com/davisking/dlib/pull/1249\r\n\r\nFor your review @davisking and @supervacuus \r\n\r\n@davisking I tried to fix the build but it cannot load the image in the test folder. I verified that the image exists. Maybe an issue related to DLIB_JPEG_SUPPORT flag?\r\n\r\nThere is further impact due to https://github.com/davisking/dlib/issues/1252\r\n\r\n@aldanor if this PR is merged before your PR, you might wish to `ifdef` some portions of the code in this PR as well.","created_at":"2018-04-17T10:30:19Z","updated_at":"2018-04-17T20:25:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9309d4932c9f189c631aa760e4dd68b6cdcf24e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/davisking/dlib/pulls/1258/commits","review_comments_url":"https://api.github.com/repos/davisking/dlib/pulls/1258/comments","review_comment_url":"https://api.github.com/repos/davisking/dlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davisking/dlib/issues/1258/comments","statuses_url":"https://api.github.com/repos/davisking/dlib/statuses/0b578f7305eb2bea744883890441a52a8bd0afef","head":{"label":"visionworkz:master","ref":"master","sha":"0b578f7305eb2bea744883890441a52a8bd0afef","user":{"login":"visionworkz","id":31665404,"avatar_url":"https://avatars2.githubusercontent.com/u/31665404?v=4","gravatar_id":"","url":"https://api.github.com/users/visionworkz","html_url":"https://github.com/visionworkz","followers_url":"https://api.github.com/users/visionworkz/followers","following_url":"https://api.github.com/users/visionworkz/following{/other_user}","gists_url":"https://api.github.com/users/visionworkz/gists{/gist_id}","starred_url":"https://api.github.com/users/visionworkz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visionworkz/subscriptions","organizations_url":"https://api.github.com/users/visionworkz/orgs","repos_url":"https://api.github.com/users/visionworkz/repos","events_url":"https://api.github.com/users/visionworkz/events{/privacy}","received_events_url":"https://api.github.com/users/visionworkz/received_events","type":"User","site_admin":false},"repo":{"id":111954725,"name":"dlib","full_name":"visionworkz/dlib","owner":{"login":"visionworkz","id":31665404,"avatar_url":"https://avatars2.githubusercontent.com/u/31665404?v=4","gravatar_id":"","url":"https://api.github.com/users/visionworkz","html_url":"https://github.com/visionworkz","followers_url":"https://api.github.com/users/visionworkz/followers","following_url":"https://api.github.com/users/visionworkz/following{/other_user}","gists_url":"https://api.github.com/users/visionworkz/gists{/gist_id}","starred_url":"https://api.github.com/users/visionworkz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/visionworkz/subscriptions","organizations_url":"https://api.github.com/users/visionworkz/orgs","repos_url":"https://api.github.com/users/visionworkz/repos","events_url":"https://api.github.com/users/visionworkz/events{/privacy}","received_events_url":"https://api.github.com/users/visionworkz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/visionworkz/dlib","description":"A toolkit for making real world machine learning and data analysis applications in C++","fork":true,"url":"https://api.github.com/repos/visionworkz/dlib","forks_url":"https://api.github.com/repos/visionworkz/dlib/forks","keys_url":"https://api.github.com/repos/visionworkz/dlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/visionworkz/dlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/visionworkz/dlib/teams","hooks_url":"https://api.github.com/repos/visionworkz/dlib/hooks","issue_events_url":"https://api.github.com/repos/visionworkz/dlib/issues/events{/number}","events_url":"https://api.github.com/repos/visionworkz/dlib/events","assignees_url":"https://api.github.com/repos/visionworkz/dlib/assignees{/user}","branches_url":"https://api.github.com/repos/visionworkz/dlib/branches{/branch}","tags_url":"https://api.github.com/repos/visionworkz/dlib/tags","blobs_url":"https://api.github.com/repos/visionworkz/dlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/visionworkz/dlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/visionworkz/dlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/visionworkz/dlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/visionworkz/dlib/statuses/{sha}","languages_url":"https://api.github.com/repos/visionworkz/dlib/languages","stargazers_url":"https://api.github.com/repos/visionworkz/dlib/stargazers","contributors_url":"https://api.github.com/repos/visionworkz/dlib/contributors","subscribers_url":"https://api.github.com/repos/visionworkz/dlib/subscribers","subscription_url":"https://api.github.com/repos/visionworkz/dlib/subscription","commits_url":"https://api.github.com/repos/visionworkz/dlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/visionworkz/dlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/visionworkz/dlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/visionworkz/dlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/visionworkz/dlib/contents/{+path}","compare_url":"https://api.github.com/repos/visionworkz/dlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/visionworkz/dlib/merges","archive_url":"https://api.github.com/repos/visionworkz/dlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/visionworkz/dlib/downloads","issues_url":"https://api.github.com/repos/visionworkz/dlib/issues{/number}","pulls_url":"https://api.github.com/repos/visionworkz/dlib/pulls{/number}","milestones_url":"https://api.github.com/repos/visionworkz/dlib/milestones{/number}","notifications_url":"https://api.github.com/repos/visionworkz/dlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/visionworkz/dlib/labels{/name}","releases_url":"https://api.github.com/repos/visionworkz/dlib/releases{/id}","deployments_url":"https://api.github.com/repos/visionworkz/dlib/deployments","created_at":"2017-11-24T20:52:14Z","updated_at":"2018-04-17T20:07:31Z","pushed_at":"2018-04-17T20:07:27Z","git_url":"git://github.com/visionworkz/dlib.git","ssh_url":"git@github.com:visionworkz/dlib.git","clone_url":"https://github.com/visionworkz/dlib.git","svn_url":"https://github.com/visionworkz/dlib","homepage":"dlib.net","size":20256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davisking:master","ref":"master","sha":"59483b28ce3f62851cfe9723db4994e082b08843","user":{"login":"davisking","id":6259399,"avatar_url":"https://avatars1.githubusercontent.com/u/6259399?v=4","gravatar_id":"","url":"https://api.github.com/users/davisking","html_url":"https://github.com/davisking","followers_url":"https://api.github.com/users/davisking/followers","following_url":"https://api.github.com/users/davisking/following{/other_user}","gists_url":"https://api.github.com/users/davisking/gists{/gist_id}","starred_url":"https://api.github.com/users/davisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisking/subscriptions","organizations_url":"https://api.github.com/users/davisking/orgs","repos_url":"https://api.github.com/users/davisking/repos","events_url":"https://api.github.com/users/davisking/events{/privacy}","received_events_url":"https://api.github.com/users/davisking/received_events","type":"User","site_admin":false},"repo":{"id":16331291,"name":"dlib","full_name":"davisking/dlib","owner":{"login":"davisking","id":6259399,"avatar_url":"https://avatars1.githubusercontent.com/u/6259399?v=4","gravatar_id":"","url":"https://api.github.com/users/davisking","html_url":"https://github.com/davisking","followers_url":"https://api.github.com/users/davisking/followers","following_url":"https://api.github.com/users/davisking/following{/other_user}","gists_url":"https://api.github.com/users/davisking/gists{/gist_id}","starred_url":"https://api.github.com/users/davisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisking/subscriptions","organizations_url":"https://api.github.com/users/davisking/orgs","repos_url":"https://api.github.com/users/davisking/repos","events_url":"https://api.github.com/users/davisking/events{/privacy}","received_events_url":"https://api.github.com/users/davisking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davisking/dlib","description":"A toolkit for making real world machine learning and data analysis applications in C++","fork":false,"url":"https://api.github.com/repos/davisking/dlib","forks_url":"https://api.github.com/repos/davisking/dlib/forks","keys_url":"https://api.github.com/repos/davisking/dlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davisking/dlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davisking/dlib/teams","hooks_url":"https://api.github.com/repos/davisking/dlib/hooks","issue_events_url":"https://api.github.com/repos/davisking/dlib/issues/events{/number}","events_url":"https://api.github.com/repos/davisking/dlib/events","assignees_url":"https://api.github.com/repos/davisking/dlib/assignees{/user}","branches_url":"https://api.github.com/repos/davisking/dlib/branches{/branch}","tags_url":"https://api.github.com/repos/davisking/dlib/tags","blobs_url":"https://api.github.com/repos/davisking/dlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davisking/dlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davisking/dlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/davisking/dlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davisking/dlib/statuses/{sha}","languages_url":"https://api.github.com/repos/davisking/dlib/languages","stargazers_url":"https://api.github.com/repos/davisking/dlib/stargazers","contributors_url":"https://api.github.com/repos/davisking/dlib/contributors","subscribers_url":"https://api.github.com/repos/davisking/dlib/subscribers","subscription_url":"https://api.github.com/repos/davisking/dlib/subscription","commits_url":"https://api.github.com/repos/davisking/dlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/davisking/dlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/davisking/dlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/davisking/dlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/davisking/dlib/contents/{+path}","compare_url":"https://api.github.com/repos/davisking/dlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davisking/dlib/merges","archive_url":"https://api.github.com/repos/davisking/dlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davisking/dlib/downloads","issues_url":"https://api.github.com/repos/davisking/dlib/issues{/number}","pulls_url":"https://api.github.com/repos/davisking/dlib/pulls{/number}","milestones_url":"https://api.github.com/repos/davisking/dlib/milestones{/number}","notifications_url":"https://api.github.com/repos/davisking/dlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davisking/dlib/labels{/name}","releases_url":"https://api.github.com/repos/davisking/dlib/releases{/id}","deployments_url":"https://api.github.com/repos/davisking/dlib/deployments","created_at":"2014-01-29T00:45:33Z","updated_at":"2018-04-17T19:56:40Z","pushed_at":"2018-04-17T20:07:30Z","git_url":"git://github.com/davisking/dlib.git","ssh_url":"git@github.com:davisking/dlib.git","clone_url":"https://github.com/davisking/dlib.git","svn_url":"https://github.com/davisking/dlib","homepage":"dlib.net","size":20250,"stargazers_count":4677,"watchers_count":4677,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1410,"mirror_url":null,"archived":false,"open_issues_count":142,"license":null,"forks":1410,"open_issues":142,"watchers":4677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davisking/dlib/pulls/1258"},"html":{"href":"https://github.com/davisking/dlib/pull/1258"},"issue":{"href":"https://api.github.com/repos/davisking/dlib/issues/1258"},"comments":{"href":"https://api.github.com/repos/davisking/dlib/issues/1258/comments"},"review_comments":{"href":"https://api.github.com/repos/davisking/dlib/pulls/1258/comments"},"review_comment":{"href":"https://api.github.com/repos/davisking/dlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davisking/dlib/pulls/1258/commits"},"statuses":{"href":"https://api.github.com/repos/davisking/dlib/statuses/0b578f7305eb2bea744883890441a52a8bd0afef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davisking"}}