{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/180","repository_url":"https://api.github.com/repos/supercollider/sc3-plugins","labels_url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/180/comments","events_url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/180/events","html_url":"https://github.com/supercollider/sc3-plugins/issues/180","id":292260853,"node_id":"MDU6SXNzdWUyOTIyNjA4NTM=","number":180,"title":"clang warnings","user":{"login":"yurivict","id":271906,"node_id":"MDQ6VXNlcjI3MTkwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/271906?v=4","gravatar_id":"","url":"https://api.github.com/users/yurivict","html_url":"https://github.com/yurivict","followers_url":"https://api.github.com/users/yurivict/followers","following_url":"https://api.github.com/users/yurivict/following{/other_user}","gists_url":"https://api.github.com/users/yurivict/gists{/gist_id}","starred_url":"https://api.github.com/users/yurivict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurivict/subscriptions","organizations_url":"https://api.github.com/users/yurivict/orgs","repos_url":"https://api.github.com/users/yurivict/repos","events_url":"https://api.github.com/users/yurivict/events{/privacy}","received_events_url":"https://api.github.com/users/yurivict/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-29T01:39:32Z","updated_at":"2018-12-16T18:55:31Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Getting these warnings on FreeBSD with clang-40.\r\n\r\n\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/NCAnalysisUGens/MedianSeparation.cpp:385:26: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]\r\n            if ((bufnum1 >= 0) && (bufnum2 >= 0) ) {\r\n                 ~~~~~~~ ^  ~\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/NCAnalysisUGens/MedianSeparation.cpp:385:44: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]\r\n            if ((bufnum1 >= 0) && (bufnum2 >= 0) ) {\r\n                                   ~~~~~~~ ^  ~\r\n2 warnings generated.\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/PitchDetection/Qitch.cpp:194:53: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]\r\n        if (!((ampbufnum > world->mNumSndBufs) || ampbufnum<0)) {\r\n                                                  ~~~~~~~~~^~\r\n1 warning generated.\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/OteyPianoUGens/OteyPiano.cpp:223:3: warning: delete called on 'Hammer' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]\r\n  delete hammer;\r\n  ^\r\n1 warning generated.\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/RFWUGens/RFWUGens.cpp:186:51: warning: unsequenced modification and access to 'count' [-Wunsequenced]\r\n        average = ((count * average) + *(in+i)) / ++count;\r\n                    ~~~~~                         ^\r\n1 warning generated.\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/BlackrainUGens/BlackrainUGens.cpp:250:14: warning: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value]\r\n  float x1 = fabsf( input + _limit );\r\n             ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/BlackrainUGens/BlackrainUGens.cpp:250:14: note: use function 'std::abs' instead\r\n  float x1 = fabsf( input + _limit );\r\n             ^~~~~\r\n             std::abs\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/BlackrainUGens/BlackrainUGens.cpp:251:14: warning: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value]\r\n  float x2 = fabsf( input - _limit );\r\n             ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/BlackrainUGens/BlackrainUGens.cpp:251:14: note: use function 'std::abs' instead\r\n  float x2 = fabsf( input - _limit );\r\n             ^~~~~\r\n             std::abs\r\n2 warnings generated.\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:6739:9: warning: 'GRAIN_BUF' macro redefined [-Wmacro-redefined]\r\n#define GRAIN_BUF                                                                                                       \\\r\n        ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:731:9: note: previous definition is here\r\n#define GRAIN_BUF \\\r\n        ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:6815:9: warning: 'GRAIN_LOOP_BODY_4' macro redefined [-Wmacro-redefined]\r\n#define GRAIN_LOOP_BODY_4                                                                               \\\r\n        ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:746:9: note: previous definition is here\r\n#define GRAIN_LOOP_BODY_4 \\\r\n        ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:6844:9: warning: 'GRAIN_LOOP_BODY_2' macro redefined [-Wmacro-redefined]\r\n#define GRAIN_LOOP_BODY_2                                                               \\\r\n        ^\r\n/usr/ports/audio/sc3-plugins/work/sc3-plugins-Version-3.9.0/source/JoshUGens/JoshGrainUGens.cpp:776:9: note: previous definition is here\r\n#define GRAIN_LOOP_BODY_2 \\\r\n        ^\r\n"},"comment":{"url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/comments/447666861","html_url":"https://github.com/supercollider/sc3-plugins/issues/180#issuecomment-447666861","issue_url":"https://api.github.com/repos/supercollider/sc3-plugins/issues/180","id":447666861,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzY2Njg2MQ==","user":{"login":"brianlheim","id":15369640,"node_id":"MDQ6VXNlcjE1MzY5NjQw","avatar_url":"https://avatars3.githubusercontent.com/u/15369640?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlheim","html_url":"https://github.com/brianlheim","followers_url":"https://api.github.com/users/brianlheim/followers","following_url":"https://api.github.com/users/brianlheim/following{/other_user}","gists_url":"https://api.github.com/users/brianlheim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlheim/subscriptions","organizations_url":"https://api.github.com/users/brianlheim/orgs","repos_url":"https://api.github.com/users/brianlheim/repos","events_url":"https://api.github.com/users/brianlheim/events{/privacy}","received_events_url":"https://api.github.com/users/brianlheim/received_events","type":"User","site_admin":false},"created_at":"2018-12-16T18:55:31Z","updated_at":"2018-12-16T18:55:31Z","author_association":"MEMBER","body":"i'm sure it would. there are also tons of warnings reported by msvc (implicit double-to-float conversion) that could be fixed if someone wanted to spend the time to do it. with this repo i only have an interest in fixing what is very problematic. if you would like more warnings silenced such as those produced with `-Wall` on gcc or clang i would encourage you to open a PR instead of a ticket, as the code quality here is not expected to be very high and many plugins are abandoned by their original author."}}
{"actor":{"display_login":"brianlheim"}}