{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/145","repository_url":"https://api.github.com/repos/openshift/machine-config-operator","labels_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/145/comments","events_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/145/events","html_url":"https://github.com/openshift/machine-config-operator/pull/145","id":374064041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODUxMzMz","number":145,"title":"mcd: fix race condition for annotation updates","user":{"login":"yuqi-zhang","id":19409726,"node_id":"MDQ6VXNlcjE5NDA5NzI2","avatar_url":"https://avatars2.githubusercontent.com/u/19409726?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqi-zhang","html_url":"https://github.com/yuqi-zhang","followers_url":"https://api.github.com/users/yuqi-zhang/followers","following_url":"https://api.github.com/users/yuqi-zhang/following{/other_user}","gists_url":"https://api.github.com/users/yuqi-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqi-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqi-zhang/subscriptions","organizations_url":"https://api.github.com/users/yuqi-zhang/orgs","repos_url":"https://api.github.com/users/yuqi-zhang/repos","events_url":"https://api.github.com/users/yuqi-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/yuqi-zhang/received_events","type":"User","site_admin":false},"labels":[{"id":1005850192,"node_id":"MDU6TGFiZWwxMDA1ODUwMTky","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1005849393,"node_id":"MDU6TGFiZWwxMDA1ODQ5Mzkz","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1005849749,"node_id":"MDU6TGFiZWwxMDA1ODQ5NzQ5","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-25T18:00:39Z","updated_at":"2018-10-25T22:57:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/145","html_url":"https://github.com/openshift/machine-config-operator/pull/145","diff_url":"https://github.com/openshift/machine-config-operator/pull/145.diff","patch_url":"https://github.com/openshift/machine-config-operator/pull/145.patch"},"body":"Currently when we finish an update, we re-check the desired config\r\nand indiscriminately set the current config to it. This can cause\r\nan update to be lost since the desired config may have changed\r\ninbetween the isDesired check and when the map is updated. Instead\r\nwe should be updating the config to the one we checked for in\r\nisDesired.\r\n\r\nTested the update process, seems fine to work."},"comment":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/comments/433232625","html_url":"https://github.com/openshift/machine-config-operator/pull/145#issuecomment-433232625","issue_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/145","id":433232625,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzIzMjYyNQ==","user":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T22:57:07Z","updated_at":"2018-10-25T22:57:07Z","author_association":"CONTRIBUTOR","body":"/retest\n\nPlease review the [full test history](https://openshift-gce-devel.appspot.com/pr/openshift_machine-config-operator/145) for this PR and help us cut down flakes."}}
{"actor":{"display_login":"openshift-merge-robot"}}