{"action":"closed","issue":{"url":"https://api.github.com/repos/facebook/folly/issues/841","repository_url":"https://api.github.com/repos/facebook/folly","labels_url":"https://api.github.com/repos/facebook/folly/issues/841/labels{/name}","comments_url":"https://api.github.com/repos/facebook/folly/issues/841/comments","events_url":"https://api.github.com/repos/facebook/folly/issues/841/events","html_url":"https://github.com/facebook/folly/issues/841","id":320500832,"number":841,"title":"Seems like a BUG in folly::synchronization::ParkingLot::Bucket","user":{"login":"SimonCqk","id":19202395,"avatar_url":"https://avatars3.githubusercontent.com/u/19202395?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonCqk","html_url":"https://github.com/SimonCqk","followers_url":"https://api.github.com/users/SimonCqk/followers","following_url":"https://api.github.com/users/SimonCqk/following{/other_user}","gists_url":"https://api.github.com/users/SimonCqk/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonCqk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonCqk/subscriptions","organizations_url":"https://api.github.com/users/SimonCqk/orgs","repos_url":"https://api.github.com/users/SimonCqk/repos","events_url":"https://api.github.com/users/SimonCqk/events{/privacy}","received_events_url":"https://api.github.com/users/SimonCqk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-05T11:09:46Z","updated_at":"2018-05-05T20:56:34Z","closed_at":"2018-05-05T20:56:34Z","author_association":"NONE","body":"Hey team,\r\nI'm reading some code segaments while I may find a bug in `folly::synchronization::ParkingLot::Bucket`.\r\nInside the struct `Bucket`, there maintains a var named `count_` which means size of Bucket, I guess, and in the last of  `::erase()`:\r\n\r\n> https://github.com/facebook/folly/blob/master/folly/synchronization/ParkingLot.h#L122\r\n\r\n`count_.fetch_sub(1)` is done, but in `::push_back()`:\r\n\r\n> https://github.com/facebook/folly/blob/master/folly/synchronization/ParkingLot.h#L87\r\n\r\nthere is no corresponding op like `count_.fetch_add(1)`, which really confused me.\r\n"}}
{"actor":{"display_login":"yfeldblum"}}