{"action":"created","comment":{"url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/comments/208199138","pull_request_review_id":143956376,"id":208199138,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE5OTEzOA==","diff_hunk":"@@ -540,6 +569,30 @@ void processJnc() {\n     }\n   }\n \n+  void processJg() {\n+    if(!carry && !zero) {\n+      processJmp();\n+    }\n+  }\n+\n+  void processJge() {\n+    if((!carry && !zero) || (!carry && zero)) {\n+      processJmp();\n+    }\n+  }\n+\n+  void processJl() {\n+    if(carry && !zero) {\n+      processJmp();\n+    }\n+  }\n+\n+  void processJle() {","path":"src/main/java/net/torocraft/minecoprocessors/processor/Processor.java","position":182,"original_position":72,"commit_id":"19876696b581e099a5ce3f28400d159152129b8f","original_commit_id":"4fc77bab9f4460b25b8a302aeccb30807e522311","user":{"login":"frodare","id":795621,"node_id":"MDQ6VXNlcjc5NTYyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/795621?v=4","gravatar_id":"","url":"https://api.github.com/users/frodare","html_url":"https://github.com/frodare","followers_url":"https://api.github.com/users/frodare/followers","following_url":"https://api.github.com/users/frodare/following{/other_user}","gists_url":"https://api.github.com/users/frodare/gists{/gist_id}","starred_url":"https://api.github.com/users/frodare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodare/subscriptions","organizations_url":"https://api.github.com/users/frodare/orgs","repos_url":"https://api.github.com/users/frodare/repos","events_url":"https://api.github.com/users/frodare/events{/privacy}","received_events_url":"https://api.github.com/users/frodare/received_events","type":"User","site_admin":false},"body":"I am going keep them as is for now, and update them and many other instructions if or when a SF and OF (maybe even a PF) are added ","created_at":"2018-08-07T11:45:20Z","updated_at":"2018-08-07T11:45:20Z","html_url":"https://github.com/ToroCraft/Minecoprocessors/pull/53#discussion_r208199138","pull_request_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/comments/208199138"},"html":{"href":"https://github.com/ToroCraft/Minecoprocessors/pull/53#discussion_r208199138"},"pull_request":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53"}},"in_reply_to_id":208085483},"pull_request":{"url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53","id":206361583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzYxNTgz","html_url":"https://github.com/ToroCraft/Minecoprocessors/pull/53","diff_url":"https://github.com/ToroCraft/Minecoprocessors/pull/53.diff","patch_url":"https://github.com/ToroCraft/Minecoprocessors/pull/53.patch","issue_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/53","number":53,"state":"closed","locked":false,"title":"Quality of life tweaks","user":{"login":"Ciastex","id":4654533,"node_id":"MDQ6VXNlcjQ2NTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/4654533?v=4","gravatar_id":"","url":"https://api.github.com/users/Ciastex","html_url":"https://github.com/Ciastex","followers_url":"https://api.github.com/users/Ciastex/followers","following_url":"https://api.github.com/users/Ciastex/following{/other_user}","gists_url":"https://api.github.com/users/Ciastex/gists{/gist_id}","starred_url":"https://api.github.com/users/Ciastex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ciastex/subscriptions","organizations_url":"https://api.github.com/users/Ciastex/orgs","repos_url":"https://api.github.com/users/Ciastex/repos","events_url":"https://api.github.com/users/Ciastex/events{/privacy}","received_events_url":"https://api.github.com/users/Ciastex/received_events","type":"User","site_admin":false},"body":"So I thought I'd add a few cents myself, since I'm using this mod like there's no tomorrow. The list of chages are as follows.\r\n\r\n### Additional conditonal jumps\r\n**JE/JNE** - Aliases for JZ/JNZ\r\n**JG/JGE** - Jump if Greater / or Equal\r\n**JL/JLE** - Jump if Lesser / or Equal\r\n\r\n### Additional push/pop instructions\r\n**PUSHA** - Pushes all GPRs onto stack in the following order: A B C D\r\n**POPA** - Pops 4 values from the stack into GPRs in the following order: D C B A\r\n\r\n### CMP instruction\r\nThe CMP instruction works like it does in x86 architecture, i.e. allows for JG/JL jumps; doesn't break existing code relying on JZ/JNZ.\r\n\r\nNew behavior of **CMP a, b**:\r\n```\r\na == b -> ZF = 1, CF = 0\r\n a < b -> ZF = 0, CF = 1\r\n a > b -> ZF = 0, CF = 0\r\n```\r\n### Code book tweaks\r\nCode book now has a primitive indentation support for tab key - inserts 2 spaces at the current cursor position.\r\n\r\n### Processor fault codes\r\nWhen a processor sets its fault flag it also sets a fault code that can be seen when hovering the mouse cursor over the fault flag in GUI.\r\n![image](https://user-images.githubusercontent.com/4654533/43712595-fd91932e-9976-11e8-9dca-11761ffa4802.png)\r\n\r\nProcessor fault codes are as follows:\r\n**0x00** - Division by zero.\r\n**0x01** - Stack underflow (pop when stack empty).\r\n**0x02** - Stack overflow.\r\n**0x03** - Undefined instruction pointer location.\r\n**0x04** - Code load error.\r\n**0x05** - Out of bounds error.\r\n**0xFE** - Processor stopped using HLT instruction.\r\n**0xFF** - Processor operating correctly (default state).\r\n\r\n","created_at":"2018-08-06T10:55:19Z","updated_at":"2018-08-07T11:45:20Z","closed_at":"2018-08-07T00:38:36Z","merged_at":"2018-08-07T00:38:36Z","merge_commit_sha":"382113323d8727c610a7b09854e66fdc209d9b31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53/commits","review_comments_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53/comments","review_comment_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/53/comments","statuses_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/statuses/19876696b581e099a5ce3f28400d159152129b8f","head":{"label":"Ciastex:master","ref":"master","sha":"19876696b581e099a5ce3f28400d159152129b8f","user":{"login":"Ciastex","id":4654533,"node_id":"MDQ6VXNlcjQ2NTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/4654533?v=4","gravatar_id":"","url":"https://api.github.com/users/Ciastex","html_url":"https://github.com/Ciastex","followers_url":"https://api.github.com/users/Ciastex/followers","following_url":"https://api.github.com/users/Ciastex/following{/other_user}","gists_url":"https://api.github.com/users/Ciastex/gists{/gist_id}","starred_url":"https://api.github.com/users/Ciastex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ciastex/subscriptions","organizations_url":"https://api.github.com/users/Ciastex/orgs","repos_url":"https://api.github.com/users/Ciastex/repos","events_url":"https://api.github.com/users/Ciastex/events{/privacy}","received_events_url":"https://api.github.com/users/Ciastex/received_events","type":"User","site_admin":false},"repo":{"id":143680562,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2ODA1NjI=","name":"Minecoprocessors","full_name":"Ciastex/Minecoprocessors","owner":{"login":"Ciastex","id":4654533,"node_id":"MDQ6VXNlcjQ2NTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/4654533?v=4","gravatar_id":"","url":"https://api.github.com/users/Ciastex","html_url":"https://github.com/Ciastex","followers_url":"https://api.github.com/users/Ciastex/followers","following_url":"https://api.github.com/users/Ciastex/following{/other_user}","gists_url":"https://api.github.com/users/Ciastex/gists{/gist_id}","starred_url":"https://api.github.com/users/Ciastex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ciastex/subscriptions","organizations_url":"https://api.github.com/users/Ciastex/orgs","repos_url":"https://api.github.com/users/Ciastex/repos","events_url":"https://api.github.com/users/Ciastex/events{/privacy}","received_events_url":"https://api.github.com/users/Ciastex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ciastex/Minecoprocessors","description":"Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!","fork":true,"url":"https://api.github.com/repos/Ciastex/Minecoprocessors","forks_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/forks","keys_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/teams","hooks_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/hooks","issue_events_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/issues/events{/number}","events_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/events","assignees_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/assignees{/user}","branches_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/branches{/branch}","tags_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/tags","blobs_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/statuses/{sha}","languages_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/languages","stargazers_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/stargazers","contributors_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/contributors","subscribers_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/subscribers","subscription_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/subscription","commits_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/contents/{+path}","compare_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/merges","archive_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/downloads","issues_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/issues{/number}","pulls_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/pulls{/number}","milestones_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/milestones{/number}","notifications_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/labels{/name}","releases_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/releases{/id}","deployments_url":"https://api.github.com/repos/Ciastex/Minecoprocessors/deployments","created_at":"2018-08-06T05:31:03Z","updated_at":"2018-08-06T14:11:35Z","pushed_at":"2018-08-07T06:11:18Z","git_url":"git://github.com/Ciastex/Minecoprocessors.git","ssh_url":"git@github.com:Ciastex/Minecoprocessors.git","clone_url":"https://github.com/Ciastex/Minecoprocessors.git","svn_url":"https://github.com/Ciastex/Minecoprocessors","homepage":"https://minecraft.curseforge.com/projects/minecoprocessors","size":406,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ToroCraft:master","ref":"master","sha":"739e3f6a09efd2758fcddd55434db855d6bc3a6f","user":{"login":"ToroCraft","id":19350780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzUwNzgw","avatar_url":"https://avatars1.githubusercontent.com/u/19350780?v=4","gravatar_id":"","url":"https://api.github.com/users/ToroCraft","html_url":"https://github.com/ToroCraft","followers_url":"https://api.github.com/users/ToroCraft/followers","following_url":"https://api.github.com/users/ToroCraft/following{/other_user}","gists_url":"https://api.github.com/users/ToroCraft/gists{/gist_id}","starred_url":"https://api.github.com/users/ToroCraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToroCraft/subscriptions","organizations_url":"https://api.github.com/users/ToroCraft/orgs","repos_url":"https://api.github.com/users/ToroCraft/repos","events_url":"https://api.github.com/users/ToroCraft/events{/privacy}","received_events_url":"https://api.github.com/users/ToroCraft/received_events","type":"Organization","site_admin":false},"repo":{"id":90309489,"node_id":"MDEwOlJlcG9zaXRvcnk5MDMwOTQ4OQ==","name":"Minecoprocessors","full_name":"ToroCraft/Minecoprocessors","owner":{"login":"ToroCraft","id":19350780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzUwNzgw","avatar_url":"https://avatars1.githubusercontent.com/u/19350780?v=4","gravatar_id":"","url":"https://api.github.com/users/ToroCraft","html_url":"https://github.com/ToroCraft","followers_url":"https://api.github.com/users/ToroCraft/followers","following_url":"https://api.github.com/users/ToroCraft/following{/other_user}","gists_url":"https://api.github.com/users/ToroCraft/gists{/gist_id}","starred_url":"https://api.github.com/users/ToroCraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToroCraft/subscriptions","organizations_url":"https://api.github.com/users/ToroCraft/orgs","repos_url":"https://api.github.com/users/ToroCraft/repos","events_url":"https://api.github.com/users/ToroCraft/events{/privacy}","received_events_url":"https://api.github.com/users/ToroCraft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ToroCraft/Minecoprocessors","description":"Increase your redstone possibilities and learn assembly programming at the same time with the Minecoprocessors Minecraft Mod!","fork":false,"url":"https://api.github.com/repos/ToroCraft/Minecoprocessors","forks_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/forks","keys_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/teams","hooks_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/hooks","issue_events_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/events{/number}","events_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/events","assignees_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/assignees{/user}","branches_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/branches{/branch}","tags_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/tags","blobs_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/git/refs{/sha}","trees_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/statuses/{sha}","languages_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/languages","stargazers_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/stargazers","contributors_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/contributors","subscribers_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/subscribers","subscription_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/subscription","commits_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/commits{/sha}","git_commits_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/git/commits{/sha}","comments_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/comments{/number}","issue_comment_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/comments{/number}","contents_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/contents/{+path}","compare_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/merges","archive_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/downloads","issues_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues{/number}","pulls_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls{/number}","milestones_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/milestones{/number}","notifications_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/labels{/name}","releases_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/releases{/id}","deployments_url":"https://api.github.com/repos/ToroCraft/Minecoprocessors/deployments","created_at":"2017-05-04T21:03:39Z","updated_at":"2018-08-07T03:14:18Z","pushed_at":"2018-08-07T03:14:17Z","git_url":"git://github.com/ToroCraft/Minecoprocessors.git","ssh_url":"git@github.com:ToroCraft/Minecoprocessors.git","clone_url":"https://github.com/ToroCraft/Minecoprocessors.git","svn_url":"https://github.com/ToroCraft/Minecoprocessors","homepage":"https://minecraft.curseforge.com/projects/minecoprocessors","size":397,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53"},"html":{"href":"https://github.com/ToroCraft/Minecoprocessors/pull/53"},"issue":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/53"},"comments":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/ToroCraft/Minecoprocessors/statuses/19876696b581e099a5ce3f28400d159152129b8f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"frodare"}}