{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/183605612","pull_request_review_id":114633244,"id":183605612,"diff_hunk":"@@ -158,11 +158,11 @@ object FiberCacheManager extends Logging {\n \n     val statusRawData = dataFibers.groupBy(_.file).map {\n       case (dataFile, fiberSet) =>\n-        val fileMeta = DataFileHandleCacheManager(dataFile).asInstanceOf[OapDataFileHandle]\n-        val fiberBitSet = new BitSet(fileMeta.groupCount * fileMeta.fieldCount)\n+        val fileMeta: DataFileHandle = DataFileHandleCacheManager(dataFile)\n+        val fiberBitSet = new BitSet(fileMeta.getGroupCount * fileMeta.getFieldCount)\n         fiberSet.foreach(fiber =>\n-          fiberBitSet.set(fiber.columnIndex + fileMeta.fieldCount * fiber.rowGroupId))\n-        FiberCacheStatus(dataFile.path, fiberBitSet, fileMeta)\n+          fiberBitSet.set(fiber.columnIndex + fileMeta.getFieldCount * fiber.rowGroupId))","path":"src/main/scala/org/apache/spark/sql/execution/datasources/oap/filecache/FiberCacheManager.scala","position":11,"original_position":11,"commit_id":"baf63fa2fd6267d4da5a589eb27323e87a397f32","original_commit_id":"baf63fa2fd6267d4da5a589eb27323e87a397f32","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars0.githubusercontent.com/u/3078910?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"Thanks, this is quite clear, how about adding a comment here? :)","created_at":"2018-04-24T05:03:09Z","updated_at":"2018-04-24T05:03:09Z","html_url":"https://github.com/Intel-bigdata/OAP/pull/715#discussion_r183605612","pull_request_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/183605612"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/715#discussion_r183605612"},"pull_request":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715"}},"in_reply_to_id":183595621},"pull_request":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715","id":183610250,"html_url":"https://github.com/Intel-bigdata/OAP/pull/715","diff_url":"https://github.com/Intel-bigdata/OAP/pull/715.diff","patch_url":"https://github.com/Intel-bigdata/OAP/pull/715.patch","issue_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/715","number":715,"state":"open","locked":false,"title":"FiberSensor supports Parquet Cache","user":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nFix #702 \r\nThis PR enables ParquetDataFileHandle support in FiberCacheStatus.\r\n\r\n## How was this patch tested?\r\n\r\nCurrent UT\r\n\r\n","created_at":"2018-04-24T03:15:52Z","updated_at":"2018-04-24T05:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36d686e25010142625b03cc45e9db3ca1a2f4a85","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carsonwang","id":9278199,"avatar_url":"https://avatars2.githubusercontent.com/u/9278199?v=4","gravatar_id":"","url":"https://api.github.com/users/carsonwang","html_url":"https://github.com/carsonwang","followers_url":"https://api.github.com/users/carsonwang/followers","following_url":"https://api.github.com/users/carsonwang/following{/other_user}","gists_url":"https://api.github.com/users/carsonwang/gists{/gist_id}","starred_url":"https://api.github.com/users/carsonwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsonwang/subscriptions","organizations_url":"https://api.github.com/users/carsonwang/orgs","repos_url":"https://api.github.com/users/carsonwang/repos","events_url":"https://api.github.com/users/carsonwang/events{/privacy}","received_events_url":"https://api.github.com/users/carsonwang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715/commits","review_comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715/comments","review_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/715/comments","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/baf63fa2fd6267d4da5a589eb27323e87a397f32","head":{"label":"linhong-intel:parquet-cache-fix","ref":"parquet-cache-fix","sha":"baf63fa2fd6267d4da5a589eb27323e87a397f32","user":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"repo":{"id":93349790,"name":"OAP","full_name":"linhong-intel/OAP","owner":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linhong-intel/OAP","description":"Optimized Analytics Package for Spark Platform","fork":true,"url":"https://api.github.com/repos/linhong-intel/OAP","forks_url":"https://api.github.com/repos/linhong-intel/OAP/forks","keys_url":"https://api.github.com/repos/linhong-intel/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linhong-intel/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linhong-intel/OAP/teams","hooks_url":"https://api.github.com/repos/linhong-intel/OAP/hooks","issue_events_url":"https://api.github.com/repos/linhong-intel/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/linhong-intel/OAP/events","assignees_url":"https://api.github.com/repos/linhong-intel/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/linhong-intel/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/linhong-intel/OAP/tags","blobs_url":"https://api.github.com/repos/linhong-intel/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linhong-intel/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linhong-intel/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/linhong-intel/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linhong-intel/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/linhong-intel/OAP/languages","stargazers_url":"https://api.github.com/repos/linhong-intel/OAP/stargazers","contributors_url":"https://api.github.com/repos/linhong-intel/OAP/contributors","subscribers_url":"https://api.github.com/repos/linhong-intel/OAP/subscribers","subscription_url":"https://api.github.com/repos/linhong-intel/OAP/subscription","commits_url":"https://api.github.com/repos/linhong-intel/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/linhong-intel/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/linhong-intel/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/linhong-intel/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/linhong-intel/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/linhong-intel/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linhong-intel/OAP/merges","archive_url":"https://api.github.com/repos/linhong-intel/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linhong-intel/OAP/downloads","issues_url":"https://api.github.com/repos/linhong-intel/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/linhong-intel/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/linhong-intel/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/linhong-intel/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linhong-intel/OAP/labels{/name}","releases_url":"https://api.github.com/repos/linhong-intel/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/linhong-intel/OAP/deployments","created_at":"2017-06-05T00:22:18Z","updated_at":"2018-03-21T09:26:30Z","pushed_at":"2018-04-24T03:12:30Z","git_url":"git://github.com/linhong-intel/OAP.git","ssh_url":"git@github.com:linhong-intel/OAP.git","clone_url":"https://github.com/linhong-intel/OAP.git","svn_url":"https://github.com/linhong-intel/OAP","homepage":"","size":136780,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-bigdata:master","ref":"master","sha":"33e6514f441fc513bb9bda33ee28ea60edea4291","user":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"repo":{"id":54008218,"name":"OAP","full_name":"Intel-bigdata/OAP","owner":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Intel-bigdata/OAP","description":"Optimized Analytics Package for Spark Platform","fork":false,"url":"https://api.github.com/repos/Intel-bigdata/OAP","forks_url":"https://api.github.com/repos/Intel-bigdata/OAP/forks","keys_url":"https://api.github.com/repos/Intel-bigdata/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-bigdata/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-bigdata/OAP/teams","hooks_url":"https://api.github.com/repos/Intel-bigdata/OAP/hooks","issue_events_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-bigdata/OAP/events","assignees_url":"https://api.github.com/repos/Intel-bigdata/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-bigdata/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/tags","blobs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-bigdata/OAP/languages","stargazers_url":"https://api.github.com/repos/Intel-bigdata/OAP/stargazers","contributors_url":"https://api.github.com/repos/Intel-bigdata/OAP/contributors","subscribers_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscribers","subscription_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscription","commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-bigdata/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-bigdata/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-bigdata/OAP/merges","archive_url":"https://api.github.com/repos/Intel-bigdata/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-bigdata/OAP/downloads","issues_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-bigdata/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-bigdata/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-bigdata/OAP/labels{/name}","releases_url":"https://api.github.com/repos/Intel-bigdata/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-bigdata/OAP/deployments","created_at":"2016-03-16T06:56:47Z","updated_at":"2018-04-24T03:24:35Z","pushed_at":"2018-04-24T03:24:31Z","git_url":"git://github.com/Intel-bigdata/OAP.git","ssh_url":"git@github.com:Intel-bigdata/OAP.git","clone_url":"https://github.com/Intel-bigdata/OAP.git","svn_url":"https://github.com/Intel-bigdata/OAP","homepage":"","size":136790,"stargazers_count":113,"watchers_count":113,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":35,"open_issues":86,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/715"},"issue":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/715"},"comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/baf63fa2fd6267d4da5a589eb27323e87a397f32"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adrian-wang"}}