{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/jenkins/pulls/comments/171735505","pull_request_review_id":100642724,"id":171735505,"diff_hunk":"@@ -281,6 +354,8 @@ else\n   fi  \n fi\n \n+echo ${OPENSHIFT_JENKINS_IMAGE_VERSION} > ${JENKINS_HOME}/image-version","path":"2/contrib/s2i/run","position":113,"original_position":102,"commit_id":"a069127d3de0954c853dde9d4d45cc36079bf94a","original_commit_id":"d1c362868cbbc3fd4bcf68541be37c71de33f3ba","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"sorry missed that one ... agreed, will push momentarily","created_at":"2018-03-02T00:23:11Z","updated_at":"2018-03-02T00:23:11Z","html_url":"https://github.com/openshift/jenkins/pull/516#discussion_r171735505","pull_request_url":"https://api.github.com/repos/openshift/jenkins/pulls/516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/comments/171735505"},"html":{"href":"https://github.com/openshift/jenkins/pull/516#discussion_r171735505"},"pull_request":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/516"}},"in_reply_to_id":171418073},"pull_request":{"url":"https://api.github.com/repos/openshift/jenkins/pulls/516","id":172096909,"html_url":"https://github.com/openshift/jenkins/pull/516","diff_url":"https://github.com/openshift/jenkins/pull/516.diff","patch_url":"https://github.com/openshift/jenkins/pull/516.patch","issue_url":"https://api.github.com/repos/openshift/jenkins/issues/516","number":516,"state":"open","locked":false,"title":"Fix migration rhel","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"@openshift/sig-developer-experience fyi / ptal\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1550193\r\n\r\nturns our a post 3.7 GA fix broke previous fixes to git image migration working with the openshift jenkins rhel image on PVs\r\n\r\ni.e.\r\n1) someone has deployed the 3.6 or 3.7 image to a PV\r\n2) they then update their image stream to point to the 3.9 image\r\n\r\n@bparees I don't have the env override we just talked about in place yet; I wanted to start getting input on the core changes, and validate the manual test runs from the AWS rhel instance match what the CI system will produce.\r\n\r\nI'll add the env override (including README) once we get over the hump with the initial review\r\n\r\nNOTE: will also need to backport this to 3.6 and 3.7 branches.","created_at":"2018-02-28T22:51:37Z","updated_at":"2018-03-02T00:23:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc3590b351197cab8646164557bf4a987f0e195b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717680517,"url":"https://api.github.com/repos/openshift/jenkins/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/jenkins/pulls/516/commits","review_comments_url":"https://api.github.com/repos/openshift/jenkins/pulls/516/comments","review_comment_url":"https://api.github.com/repos/openshift/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/jenkins/issues/516/comments","statuses_url":"https://api.github.com/repos/openshift/jenkins/statuses/a069127d3de0954c853dde9d4d45cc36079bf94a","head":{"label":"gabemontero:fix-migration-rhel","ref":"fix-migration-rhel","sha":"a069127d3de0954c853dde9d4d45cc36079bf94a","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":41333599,"name":"jenkins","full_name":"gabemontero/jenkins","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/jenkins","description":null,"fork":true,"url":"https://api.github.com/repos/gabemontero/jenkins","forks_url":"https://api.github.com/repos/gabemontero/jenkins/forks","keys_url":"https://api.github.com/repos/gabemontero/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/jenkins/teams","hooks_url":"https://api.github.com/repos/gabemontero/jenkins/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/jenkins/events","assignees_url":"https://api.github.com/repos/gabemontero/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/jenkins/tags","blobs_url":"https://api.github.com/repos/gabemontero/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/jenkins/languages","stargazers_url":"https://api.github.com/repos/gabemontero/jenkins/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/jenkins/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/jenkins/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/jenkins/subscription","commits_url":"https://api.github.com/repos/gabemontero/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/jenkins/merges","archive_url":"https://api.github.com/repos/gabemontero/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/jenkins/downloads","issues_url":"https://api.github.com/repos/gabemontero/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/jenkins/deployments","created_at":"2015-08-25T00:20:31Z","updated_at":"2016-10-27T19:55:51Z","pushed_at":"2018-03-01T21:10:26Z","git_url":"git://github.com/gabemontero/jenkins.git","ssh_url":"git@github.com:gabemontero/jenkins.git","clone_url":"https://github.com/gabemontero/jenkins.git","svn_url":"https://github.com/gabemontero/jenkins","homepage":null,"size":24764,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"814dfbb824cc324ba504aa9e463de2abafaa3284","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":27453817,"name":"jenkins","full_name":"openshift/jenkins","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/jenkins","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/jenkins","forks_url":"https://api.github.com/repos/openshift/jenkins/forks","keys_url":"https://api.github.com/repos/openshift/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/jenkins/teams","hooks_url":"https://api.github.com/repos/openshift/jenkins/hooks","issue_events_url":"https://api.github.com/repos/openshift/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/jenkins/events","assignees_url":"https://api.github.com/repos/openshift/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/jenkins/tags","blobs_url":"https://api.github.com/repos/openshift/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/jenkins/languages","stargazers_url":"https://api.github.com/repos/openshift/jenkins/stargazers","contributors_url":"https://api.github.com/repos/openshift/jenkins/contributors","subscribers_url":"https://api.github.com/repos/openshift/jenkins/subscribers","subscription_url":"https://api.github.com/repos/openshift/jenkins/subscription","commits_url":"https://api.github.com/repos/openshift/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/jenkins/merges","archive_url":"https://api.github.com/repos/openshift/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/jenkins/downloads","issues_url":"https://api.github.com/repos/openshift/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/openshift/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/jenkins/deployments","created_at":"2014-12-02T21:15:10Z","updated_at":"2018-02-27T23:22:04Z","pushed_at":"2018-03-01T21:10:28Z","git_url":"git://github.com/openshift/jenkins.git","ssh_url":"git@github.com:openshift/jenkins.git","clone_url":"https://github.com/openshift/jenkins.git","svn_url":"https://github.com/openshift/jenkins","homepage":null,"size":24776,"stargazers_count":103,"watchers_count":103,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":214,"open_issues":7,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/516"},"html":{"href":"https://github.com/openshift/jenkins/pull/516"},"issue":{"href":"https://api.github.com/repos/openshift/jenkins/issues/516"},"comments":{"href":"https://api.github.com/repos/openshift/jenkins/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/jenkins/statuses/a069127d3de0954c853dde9d4d45cc36079bf94a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gabemontero"}}