{"push_id":2306655367,"size":14,"distinct_size":1,"ref":"refs/heads/eid-56-validate-metadata","head":"af6faabff2389a9761c0069e1a0899714ced1837","before":"98e8fbd7eae709f5bd140e1aac67c61c888ecbf3","commits":[{"sha":"64d0544e0b07e564eff1305039dcc2a463449a37","author":{"name":"James Howes","email":"4bc7e551ff32f26792add659c82aefbc5fa07fe9@digital.cabinet-office.gov.uk"},"message":"EID-344 - Refactoring the HubResponseTranslator, by extracting code to a new EidasResponseBuilder so it can be shared.\n@JHjava @Hugh-Emerson","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/64d0544e0b07e564eff1305039dcc2a463449a37"},{"sha":"3210227ac355557aaea34efbebeb0ff22f5ff2e7","author":{"name":"Hugh Emerson","email":"b55bf5a880b1648a4e3fe35628efa1b638f1fd64@digital.cabinet-office.gov.uk"},"message":"EID-344: attribute builder doesn't need to be given a hub response container\n\nAuthors: @hugh-emerson, @JHJava","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/3210227ac355557aaea34efbebeb0ff22f5ff2e7"},{"sha":"2d25d6383f190e2602952a07a950799aa5a8a3fb","author":{"name":"James Howes","email":"4bc7e551ff32f26792add659c82aefbc5fa07fe9@digital.cabinet-office.gov.uk"},"message":"EID-344 - Adding test for EidasReponseBuilder\n@JHjava @Hugh-Emerson","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/2d25d6383f190e2602952a07a950799aa5a8a3fb"},{"sha":"f18fa761d364c46c3b22c922ce576e2819bb877f","author":{"name":"James Howes","email":"4bc7e551ff32f26792add659c82aefbc5fa07fe9@digital.cabinet-office.gov.uk"},"message":"EID-344 - Refactoring HubResponseTranslatorTest and completing EidasResponseBuilderTest\n\nAdd a middle name to the HubResponseTranslatorTest\n\n@JHjava @Hugh-Emerson","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/f18fa761d364c46c3b22c922ce576e2819bb877f"},{"sha":"58173658aec0489bffa93f5f267a2066b4df3985","author":{"name":"Minno Dang","email":"fbed492d5624867d61ab1bda366f679590546a71@digital.cabinet-office.gov.uk"},"message":"BAU: moved local-acceptance to jenkins build step\n\npre commit will now only run unit tests,\njenkins build will run everything + local acceptance tests\nPaaS will deploy and run acceptance tests against PaaS\n\nAuthors: @cobainc0 @minhngocd","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/58173658aec0489bffa93f5f267a2066b4df3985"},{"sha":"aac714c91f8e465a4cfe8b004abc6f950399fa2f","author":{"name":"Minno Dang","email":"fbed492d5624867d61ab1bda366f679590546a71@digital.cabinet-office.gov.uk"},"message":"BAU: build docker to run local acceptance tests on jenkins\n\nPair: @cobainc0 @minhngocd","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/aac714c91f8e465a4cfe8b004abc6f950399fa2f"},{"sha":"2af0675f5d0f4ada7117bb53135b3c5858e919e0","author":{"name":"Minno Dang","email":"fbed492d5624867d61ab1bda366f679590546a71@digital.cabinet-office.gov.uk"},"message":"BAU: reverting running local-acceptance on jenkins\n\nbecause jenkins does not support docker version and couldn't pull docker\nimage\n\nPair: @cobainc0 @minhngocd","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/2af0675f5d0f4ada7117bb53135b3c5858e919e0"},{"sha":"8b16585bdddc3a0a6dd02369b18c763ba7c555b4","author":{"name":"Hugh Emerson","email":"b55bf5a880b1648a4e3fe35628efa1b638f1fd64@digital.cabinet-office.gov.uk"},"message":"EID-344: remove the connectorNodeUrl from the EidasResponseBuilder ctor\n\nMake it a parameter of the create response method instead.\n\nAuthors: @hugh-emerson, @JHJava","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/8b16585bdddc3a0a6dd02369b18c763ba7c555b4"},{"sha":"9b23e177f7033a86bc07ea181392f5ea4061f3e1","author":{"name":"Andy Paine","email":"b435ebaaadd49d7ab63ee46ac137b1d4a9ffe39b@outlook.com"},"message":"BAU: Change gradle property name\n\nStub IDP gradle task now uses a comma separated list of directories\nto package in distZip so changed key to reflect that\n\nAuthors: @andy-paine @SKeerthana","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/9b23e177f7033a86bc07ea181392f5ea4061f3e1"},{"sha":"aae3ada72b13c52ea7d431a01e034f5ce21d7f46","author":{"name":"Minno Dang","email":"fbed492d5624867d61ab1bda366f679590546a71@digital.cabinet-office.gov.uk"},"message":"BAU: fixed missing values in stub-idp configs\n\n@minhngocd","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/aae3ada72b13c52ea7d431a01e034f5ce21d7f46"},{"sha":"5c12c21a5da7a442aa317d1421573ff53c24f47d","author":{"name":"Anshul Sirur","email":"54ec4a08bfa64df291d024e299d5c7af564c5207@digital.cabinet-office.gov.uk"},"message":"BAU: Make sure repos get updated when rebuilding docker images\n\nAuthors: @vixus0 @adrianw1832","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/5c12c21a5da7a442aa317d1421573ff53c24f47d"},{"sha":"f035d365dbaa97fdff725ac9eecdd419976805de","author":{"name":"Hugh Emerson","email":"b55bf5a880b1648a4e3fe35628efa1b638f1fd64@digital.cabinet-office.gov.uk"},"message":"EID-344: move proxyNodeMetadataForConnectorNodeUrl property from the builder to the translator\n\n@hugh-emerson","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/f035d365dbaa97fdff725ac9eecdd419976805de"},{"sha":"3960d7f94c8c2433666741b239c0b040bcb95152","author":{"name":"Hugh Emerson","email":"b55bf5a880b1648a4e3fe35628efa1b638f1fd64@digital.cabinet-office.gov.uk"},"message":"BAU: update stub idp config\n\n@hugh-emerson","distinct":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/3960d7f94c8c2433666741b239c0b040bcb95152"},{"sha":"af6faabff2389a9761c0069e1a0899714ced1837","author":{"name":"Adrian Wong","email":"cab22d2e7b6a9c7549f8e56f8d539d2c3d51ebe8@thoughtworks.com"},"message":"EIDAS-56 EIDAS-3: Validate hub metadata\n\n- Use saml-metadata-bindings to consume hub metadata and validate the\nmetadata signatures using a truststore containing the metadata CA\ncertificates.\n- Add `hub_metadata.ts` truststores containing Hub metadata CA certs.\n- Fetch stub IDP's signing credential from metadata and use that to\nvalidate the Hub (Stub IDP) SAML Response signature.\n\nChanges in the AppRule tests:\n\n- Using test metadata from saml-metadata-bindings-test and generating\nthe truststore using builders in common-test-utils.\n- Test PKI comes from verify-dev-pki instead of using TestKeyPair.\n\nAlso removed EidasResponseGeneratorTest and\nHubAuthnRequestGeneratorTest since the same code flow was covered by the AppRule tests.\n\nAuthors: @vixus0 @adrianw1832","distinct":true,"url":"https://api.github.com/repos/alphagov/verify-eidas-notification/commits/af6faabff2389a9761c0069e1a0899714ced1837"}]}
{"actor":{"display_login":"vixus0"}}