{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/186238781","pull_request_review_id":117788345,"id":186238781,"diff_hunk":"@@ -1883,8 +1883,12 @@ var Pontoon = (function (my) {\n         // Tab: Select suggestions\n         if (!$('.menu').is(':visible') && key === 9 && !e.ctrlKey) {\n \n-          // Rich FTL editor with complex message: ignore tab key\n-          if (self.fluent.isFTLEditorEnabled() && self.fluent.isComplexFTL()) {\n+          // Rich FTL editor with complex message and last element not focused: ignore tab key\n+          if (\n+            self.fluent.isFTLEditorEnabled() &&\n+            self.fluent.isComplexFTL() &&\n+            !$('#editor textarea:visible:last').is(\":focus\")","path":"pontoon/base/static/js/translate.js","position":10,"original_position":10,"commit_id":"3ff86152def06fb80519406639e23c80adbe8ec8","original_commit_id":"3ff86152def06fb80519406639e23c80adbe8ec8","user":{"login":"jotes","id":8784972,"avatar_url":"https://avatars2.githubusercontent.com/u/8784972?v=4","gravatar_id":"","url":"https://api.github.com/users/jotes","html_url":"https://github.com/jotes","followers_url":"https://api.github.com/users/jotes/followers","following_url":"https://api.github.com/users/jotes/following{/other_user}","gists_url":"https://api.github.com/users/jotes/gists{/gist_id}","starred_url":"https://api.github.com/users/jotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotes/subscriptions","organizations_url":"https://api.github.com/users/jotes/orgs","repos_url":"https://api.github.com/users/jotes/repos","events_url":"https://api.github.com/users/jotes/events{/privacy}","received_events_url":"https://api.github.com/users/jotes/received_events","type":"User","site_admin":false},"body":"[nit] `'focus'`? ","created_at":"2018-05-04T22:55:03Z","updated_at":"2018-05-04T22:55:04Z","html_url":"https://github.com/mozilla/pontoon/pull/946#discussion_r186238781","pull_request_url":"https://api.github.com/repos/mozilla/pontoon/pulls/946","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/186238781"},"html":{"href":"https://github.com/mozilla/pontoon/pull/946#discussion_r186238781"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/946"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/946","id":186040026,"html_url":"https://github.com/mozilla/pontoon/pull/946","diff_url":"https://github.com/mozilla/pontoon/pull/946.diff","patch_url":"https://github.com/mozilla/pontoon/pull/946.patch","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/946","number":946,"state":"open","locked":false,"title":"Fix bug 1450505: [FTL] Re-enable Tab to copy from helpers","user":{"login":"mathjazz","id":626716,"avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"body":"In complex FTL strings, multiple fields are present, and we use Tab to\r\nnavigate between them, as this is the browser default shortcut. We also\r\nuse Tab to navigate between helper suggestions (history, machinery,\r\nlocales), as many other CAT tools do.\r\n\r\nThis patch re-enables Tab for navigating helper suggestions for complex\r\nFTL strings when the focus is in the last field. After the suggestion\r\nis copied, we keep the focus in the last field to make moving to next\r\nsuggestion with subsequent Tabs easier.\r\n\r\n@jotes r?","created_at":"2018-05-04T16:56:14Z","updated_at":"2018-05-04T22:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"433b0bbfbe8a8b242570363cc10997c259b39637","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pontoon/pulls/946/commits","review_comments_url":"https://api.github.com/repos/mozilla/pontoon/pulls/946/comments","review_comment_url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/946/comments","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/3ff86152def06fb80519406639e23c80adbe8ec8","head":{"label":"mathjazz:bug-1450505-ftl-tab","ref":"bug-1450505-ftl-tab","sha":"3ff86152def06fb80519406639e23c80adbe8ec8","user":{"login":"mathjazz","id":626716,"avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"repo":{"id":35116849,"name":"pontoon","full_name":"mathjazz/pontoon","owner":{"login":"mathjazz","id":626716,"avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathjazz/pontoon","description":"In-place localization tool","fork":true,"url":"https://api.github.com/repos/mathjazz/pontoon","forks_url":"https://api.github.com/repos/mathjazz/pontoon/forks","keys_url":"https://api.github.com/repos/mathjazz/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathjazz/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathjazz/pontoon/teams","hooks_url":"https://api.github.com/repos/mathjazz/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mathjazz/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mathjazz/pontoon/events","assignees_url":"https://api.github.com/repos/mathjazz/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mathjazz/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mathjazz/pontoon/tags","blobs_url":"https://api.github.com/repos/mathjazz/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathjazz/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathjazz/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathjazz/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathjazz/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mathjazz/pontoon/languages","stargazers_url":"https://api.github.com/repos/mathjazz/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mathjazz/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mathjazz/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mathjazz/pontoon/subscription","commits_url":"https://api.github.com/repos/mathjazz/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathjazz/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathjazz/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathjazz/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathjazz/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mathjazz/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathjazz/pontoon/merges","archive_url":"https://api.github.com/repos/mathjazz/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathjazz/pontoon/downloads","issues_url":"https://api.github.com/repos/mathjazz/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mathjazz/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mathjazz/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mathjazz/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathjazz/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mathjazz/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mathjazz/pontoon/deployments","created_at":"2015-05-05T18:28:58Z","updated_at":"2018-05-04T15:49:44Z","pushed_at":"2018-05-04T17:25:04Z","git_url":"git://github.com/mathjazz/pontoon.git","ssh_url":"git@github.com:mathjazz/pontoon.git","clone_url":"https://github.com/mathjazz/pontoon.git","svn_url":"https://github.com/mathjazz/pontoon","homepage":"https://pontoon.mozilla.org/","size":22613,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"429aeeb0ed88bd46705bdce890c251610421287e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1385890,"name":"pontoon","full_name":"mozilla/pontoon","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pontoon","description":"Localization tool used at Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla/pontoon","forks_url":"https://api.github.com/repos/mozilla/pontoon/forks","keys_url":"https://api.github.com/repos/mozilla/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pontoon/teams","hooks_url":"https://api.github.com/repos/mozilla/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pontoon/events","assignees_url":"https://api.github.com/repos/mozilla/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pontoon/tags","blobs_url":"https://api.github.com/repos/mozilla/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pontoon/languages","stargazers_url":"https://api.github.com/repos/mozilla/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pontoon/subscription","commits_url":"https://api.github.com/repos/mozilla/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pontoon/merges","archive_url":"https://api.github.com/repos/mozilla/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pontoon/downloads","issues_url":"https://api.github.com/repos/mozilla/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pontoon/deployments","created_at":"2011-02-19T11:25:51Z","updated_at":"2018-05-04T15:48:59Z","pushed_at":"2018-05-04T17:25:31Z","git_url":"git://github.com/mozilla/pontoon.git","ssh_url":"git@github.com:mozilla/pontoon.git","clone_url":"https://github.com/mozilla/pontoon.git","svn_url":"https://github.com/mozilla/pontoon","homepage":"https://pontoon.mozilla.org/","size":22500,"stargazers_count":383,"watchers_count":383,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":114,"open_issues":9,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/946"},"html":{"href":"https://github.com/mozilla/pontoon/pull/946"},"issue":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/946"},"comments":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pontoon/statuses/3ff86152def06fb80519406639e23c80adbe8ec8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jotes"}}