{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66816","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66816/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66816/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66816/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66816","id":346094510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDQwMzM0","number":66816,"title":"Revert \"Passing `KUBE_TEST_ARGS` variable to make through process environment\"","user":{"login":"cofyc","id":91730,"node_id":"MDQ6VXNlcjkxNzMw","avatar_url":"https://avatars3.githubusercontent.com/u/91730?v=4","gravatar_id":"","url":"https://api.github.com/users/cofyc","html_url":"https://github.com/cofyc","followers_url":"https://api.github.com/users/cofyc/followers","following_url":"https://api.github.com/users/cofyc/following{/other_user}","gists_url":"https://api.github.com/users/cofyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cofyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cofyc/subscriptions","organizations_url":"https://api.github.com/users/cofyc/orgs","repos_url":"https://api.github.com/users/cofyc/repos","events_url":"https://api.github.com/users/cofyc/events{/privacy}","received_events_url":"https://api.github.com/users/cofyc/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"resouer","id":1701782,"node_id":"MDQ6VXNlcjE3MDE3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1701782?v=4","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"assignees":[{"login":"resouer","id":1701782,"node_id":"MDQ6VXNlcjE3MDE3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1701782?v=4","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-07-31T08:54:38Z","updated_at":"2018-07-31T09:07:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66816","html_url":"https://github.com/kubernetes/kubernetes/pull/66816","diff_url":"https://github.com/kubernetes/kubernetes/pull/66816.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66816.patch"},"body":"This reverts commit fda0edcd1c853f08ce3c3d8662d38cd8ed84512d.\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #66782\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/409150749","html_url":"https://github.com/kubernetes/kubernetes/pull/66816#issuecomment-409150749","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66816","id":409150749,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTE1MDc0OQ==","user":{"login":"cofyc","id":91730,"node_id":"MDQ6VXNlcjkxNzMw","avatar_url":"https://avatars3.githubusercontent.com/u/91730?v=4","gravatar_id":"","url":"https://api.github.com/users/cofyc","html_url":"https://github.com/cofyc","followers_url":"https://api.github.com/users/cofyc/followers","following_url":"https://api.github.com/users/cofyc/following{/other_user}","gists_url":"https://api.github.com/users/cofyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cofyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cofyc/subscriptions","organizations_url":"https://api.github.com/users/cofyc/orgs","repos_url":"https://api.github.com/users/cofyc/repos","events_url":"https://api.github.com/users/cofyc/events{/privacy}","received_events_url":"https://api.github.com/users/cofyc/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T09:07:21Z","updated_at":"2018-07-31T09:07:21Z","author_association":"CONTRIBUTOR","body":"/assign @cblecker \r\n\r\nWe need to revert #66061.\r\n\r\n`VAR=NEWVAL make test` or `export VAR=NEWVAL; make test` cannot change VAR in sub-make because [make get its variables from `MAKEFLAGS` variable](https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html#Options_002fRecursion.), so isub-makes will always use `KUBE_TEST_ARGS` in command line args.\r\n\r\nTo fix special use case when KUBE_TEST_ARGS contains `$`, we need find another way (escaping `$` or hacking with new variable names)."}}
{"actor":{"display_login":"cofyc"}}