{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169616861","pull_request_review_id":98169021,"id":169616861,"diff_hunk":"@@ -145,6 +145,16 @@ ENABLE_CLUSTER_MONITORING=\"${KUBE_ENABLE_CLUSTER_MONITORING:-influxdb}\"\n # TODO(piosz) remove this option once Metrics Server became a stable thing.\n ENABLE_METRICS_SERVER=\"${KUBE_ENABLE_METRICS_SERVER:-true}\"\n \n+# Optional: Metadata agent to setup as part of the cluster bring up:\n+#   none        - No metadata agent\n+#   stackdriver - Stackdriver metadata agent\n+# Metadata agent is a daemon set that provides metadata of kubernetes objects\n+# running on the same node for exporting metrics and logs.\n+ENABLE_METADATA_AGENT=\"${KUBE_ENABLE_METADATA_AGENT:-none}\"","path":"cluster/gce/config-test.sh","position":9,"original_position":9,"commit_id":"599210f5567766964ac777e0bad69032a68cd9a7","original_commit_id":"599210f5567766964ac777e0bad69032a68cd9a7","user":{"login":"kawych","id":1265228,"avatar_url":"https://avatars3.githubusercontent.com/u/1265228?v=4","gravatar_id":"","url":"https://api.github.com/users/kawych","html_url":"https://github.com/kawych","followers_url":"https://api.github.com/users/kawych/followers","following_url":"https://api.github.com/users/kawych/following{/other_user}","gists_url":"https://api.github.com/users/kawych/gists{/gist_id}","starred_url":"https://api.github.com/users/kawych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawych/subscriptions","organizations_url":"https://api.github.com/users/kawych/orgs","repos_url":"https://api.github.com/users/kawych/repos","events_url":"https://api.github.com/users/kawych/events{/privacy}","received_events_url":"https://api.github.com/users/kawych/received_events","type":"User","site_admin":false},"body":"It is enabled specifically for instrumentation tests: https://github.com/kubernetes/test-infra/blob/master/jobs/env/ci-kubernetes-e2e-gce-stackdriver.env","created_at":"2018-02-21T12:05:34Z","updated_at":"2018-02-21T12:05:35Z","html_url":"https://github.com/kubernetes/kubernetes/pull/59973#discussion_r169616861","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169616861"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59973#discussion_r169616861"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973"}},"in_reply_to_id":169616399},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973","id":169649705,"html_url":"https://github.com/kubernetes/kubernetes/pull/59973","diff_url":"https://github.com/kubernetes/kubernetes/pull/59973.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59973.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59973","number":59973,"state":"open","locked":false,"title":"Introduce e2e test for Stackdriver Metadata Agent","user":{"login":"kawych","id":1265228,"avatar_url":"https://avatars3.githubusercontent.com/u/1265228?v=4","gravatar_id":"","url":"https://api.github.com/users/kawych","html_url":"https://github.com/kawych","followers_url":"https://api.github.com/users/kawych/followers","following_url":"https://api.github.com/users/kawych/following{/other_user}","gists_url":"https://api.github.com/users/kawych/gists{/gist_id}","starred_url":"https://api.github.com/users/kawych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawych/subscriptions","organizations_url":"https://api.github.com/users/kawych/orgs","repos_url":"https://api.github.com/users/kawych/repos","events_url":"https://api.github.com/users/kawych/events{/privacy}","received_events_url":"https://api.github.com/users/kawych/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nIntroduce e2e test for Stackdriver Metadata Agent\r\n\r\n**Release note**:\r\n```release-note\r\nNone\r\n```\r\n","created_at":"2018-02-16T15:18:54Z","updated_at":"2018-02-21T12:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"392ed5fa85f7c126683c37a27e3cd66f588dff8d","assignee":{"login":"x13n","id":706544,"avatar_url":"https://avatars0.githubusercontent.com/u/706544?v=4","gravatar_id":"","url":"https://api.github.com/users/x13n","html_url":"https://github.com/x13n","followers_url":"https://api.github.com/users/x13n/followers","following_url":"https://api.github.com/users/x13n/following{/other_user}","gists_url":"https://api.github.com/users/x13n/gists{/gist_id}","starred_url":"https://api.github.com/users/x13n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x13n/subscriptions","organizations_url":"https://api.github.com/users/x13n/orgs","repos_url":"https://api.github.com/users/x13n/repos","events_url":"https://api.github.com/users/x13n/events{/privacy}","received_events_url":"https://api.github.com/users/x13n/received_events","type":"User","site_admin":false},"assignees":[{"login":"x13n","id":706544,"avatar_url":"https://avatars0.githubusercontent.com/u/706544?v=4","gravatar_id":"","url":"https://api.github.com/users/x13n","html_url":"https://github.com/x13n","followers_url":"https://api.github.com/users/x13n/followers","following_url":"https://api.github.com/users/x13n/following{/other_user}","gists_url":"https://api.github.com/users/x13n/gists{/gist_id}","starred_url":"https://api.github.com/users/x13n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x13n/subscriptions","organizations_url":"https://api.github.com/users/x13n/orgs","repos_url":"https://api.github.com/users/x13n/repos","events_url":"https://api.github.com/users/x13n/events{/privacy}","received_events_url":"https://api.github.com/users/x13n/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"piosz","id":10819974,"avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59973/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/599210f5567766964ac777e0bad69032a68cd9a7","head":{"label":"kawych:e2e","ref":"e2e","sha":"599210f5567766964ac777e0bad69032a68cd9a7","user":{"login":"kawych","id":1265228,"avatar_url":"https://avatars3.githubusercontent.com/u/1265228?v=4","gravatar_id":"","url":"https://api.github.com/users/kawych","html_url":"https://github.com/kawych","followers_url":"https://api.github.com/users/kawych/followers","following_url":"https://api.github.com/users/kawych/following{/other_user}","gists_url":"https://api.github.com/users/kawych/gists{/gist_id}","starred_url":"https://api.github.com/users/kawych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawych/subscriptions","organizations_url":"https://api.github.com/users/kawych/orgs","repos_url":"https://api.github.com/users/kawych/repos","events_url":"https://api.github.com/users/kawych/events{/privacy}","received_events_url":"https://api.github.com/users/kawych/received_events","type":"User","site_admin":false},"repo":{"id":95458610,"name":"kubernetes","full_name":"kawych/kubernetes","owner":{"login":"kawych","id":1265228,"avatar_url":"https://avatars3.githubusercontent.com/u/1265228?v=4","gravatar_id":"","url":"https://api.github.com/users/kawych","html_url":"https://github.com/kawych","followers_url":"https://api.github.com/users/kawych/followers","following_url":"https://api.github.com/users/kawych/following{/other_user}","gists_url":"https://api.github.com/users/kawych/gists{/gist_id}","starred_url":"https://api.github.com/users/kawych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawych/subscriptions","organizations_url":"https://api.github.com/users/kawych/orgs","repos_url":"https://api.github.com/users/kawych/repos","events_url":"https://api.github.com/users/kawych/events{/privacy}","received_events_url":"https://api.github.com/users/kawych/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kawych/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/kawych/kubernetes","forks_url":"https://api.github.com/repos/kawych/kubernetes/forks","keys_url":"https://api.github.com/repos/kawych/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kawych/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kawych/kubernetes/teams","hooks_url":"https://api.github.com/repos/kawych/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kawych/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kawych/kubernetes/events","assignees_url":"https://api.github.com/repos/kawych/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kawych/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kawych/kubernetes/tags","blobs_url":"https://api.github.com/repos/kawych/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kawych/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kawych/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kawych/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kawych/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kawych/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kawych/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kawych/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kawych/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kawych/kubernetes/subscription","commits_url":"https://api.github.com/repos/kawych/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kawych/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kawych/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kawych/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kawych/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kawych/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kawych/kubernetes/merges","archive_url":"https://api.github.com/repos/kawych/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kawych/kubernetes/downloads","issues_url":"https://api.github.com/repos/kawych/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kawych/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kawych/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kawych/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kawych/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kawych/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kawych/kubernetes/deployments","created_at":"2017-06-26T14:59:56Z","updated_at":"2017-06-26T15:00:36Z","pushed_at":"2018-02-21T11:51:07Z","git_url":"git://github.com/kawych/kubernetes.git","ssh_url":"git@github.com:kawych/kubernetes.git","clone_url":"https://github.com/kawych/kubernetes.git","svn_url":"https://github.com/kawych/kubernetes","homepage":"http://kubernetes.io","size":533833,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"89156e7abf07f6213b92fb4266f9bd009e92bd53","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-21T11:57:44Z","pushed_at":"2018-02-21T11:55:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":754808,"stargazers_count":32735,"watchers_count":32735,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11540,"mirror_url":null,"archived":false,"open_issues_count":4661,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11540,"open_issues":4661,"watchers":32735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59973"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59973"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59973/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59973/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/599210f5567766964ac777e0bad69032a68cd9a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kawych"}}