{"action":"created","comment":{"url":"https://api.github.com/repos/wilddima/logux_rails/pulls/comments/219466912","pull_request_review_id":157651157,"id":219466912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ2NjkxMg==","diff_hunk":"@@ -66,10 +69,6 @@ def self.process_batch(stream:, batch:)\n     Logux::Process::Batch.new(stream: stream, batch: batch).call\n   end\n \n-  def self.logger","path":"lib/logux.rb","position":42,"original_position":42,"commit_id":"47648da0b62e56f7566b443fcbd9139e87f4a596","original_commit_id":"47648da0b62e56f7566b443fcbd9139e87f4a596","user":{"login":"wilddima","id":12773329,"node_id":"MDQ6VXNlcjEyNzczMzI5","avatar_url":"https://avatars2.githubusercontent.com/u/12773329?v=4","gravatar_id":"","url":"https://api.github.com/users/wilddima","html_url":"https://github.com/wilddima","followers_url":"https://api.github.com/users/wilddima/followers","following_url":"https://api.github.com/users/wilddima/following{/other_user}","gists_url":"https://api.github.com/users/wilddima/gists{/gist_id}","starred_url":"https://api.github.com/users/wilddima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilddima/subscriptions","organizations_url":"https://api.github.com/users/wilddima/orgs","repos_url":"https://api.github.com/users/wilddima/repos","events_url":"https://api.github.com/users/wilddima/events{/privacy}","received_events_url":"https://api.github.com/users/wilddima/received_events","type":"User","site_admin":false},"body":"Why did you decide to remove this method? It looks more straightforward to use just `logger` method. Also, your approach a little bit harder to maintain, in the case when we want to replace the logger with external implementation(in that case, we should replace it on every call, instead of just in one method). I think better to replace the content of this method with a link to your class.","created_at":"2018-09-21T11:33:26Z","updated_at":"2018-09-21T11:33:27Z","html_url":"https://github.com/wilddima/logux_rails/pull/10#discussion_r219466912","pull_request_url":"https://api.github.com/repos/wilddima/logux_rails/pulls/10","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/comments/219466912"},"html":{"href":"https://github.com/wilddima/logux_rails/pull/10#discussion_r219466912"},"pull_request":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/wilddima/logux_rails/pulls/10","id":216972283,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTcyMjgz","html_url":"https://github.com/wilddima/logux_rails/pull/10","diff_url":"https://github.com/wilddima/logux_rails/pull/10.diff","patch_url":"https://github.com/wilddima/logux_rails/pull/10.patch","issue_url":"https://api.github.com/repos/wilddima/logux_rails/issues/10","number":10,"state":"open","locked":false,"title":"Colorized output","user":{"login":"paderinandrey","id":14351695,"node_id":"MDQ6VXNlcjE0MzUxNjk1","avatar_url":"https://avatars1.githubusercontent.com/u/14351695?v=4","gravatar_id":"","url":"https://api.github.com/users/paderinandrey","html_url":"https://github.com/paderinandrey","followers_url":"https://api.github.com/users/paderinandrey/followers","following_url":"https://api.github.com/users/paderinandrey/following{/other_user}","gists_url":"https://api.github.com/users/paderinandrey/gists{/gist_id}","starred_url":"https://api.github.com/users/paderinandrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paderinandrey/subscriptions","organizations_url":"https://api.github.com/users/paderinandrey/orgs","repos_url":"https://api.github.com/users/paderinandrey/repos","events_url":"https://api.github.com/users/paderinandrey/events{/privacy}","received_events_url":"https://api.github.com/users/paderinandrey/received_events","type":"User","site_admin":false},"body":"Added color output in console https://cultofmartians.com/tasks/logux-rails-log.html\r\nAlso moved the logic of logging in a separate class","created_at":"2018-09-20T13:29:27Z","updated_at":"2018-09-21T11:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c69000ae0700ad2187a20c1e16aa465f5dc715e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wilddima/logux_rails/pulls/10/commits","review_comments_url":"https://api.github.com/repos/wilddima/logux_rails/pulls/10/comments","review_comment_url":"https://api.github.com/repos/wilddima/logux_rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wilddima/logux_rails/issues/10/comments","statuses_url":"https://api.github.com/repos/wilddima/logux_rails/statuses/47648da0b62e56f7566b443fcbd9139e87f4a596","head":{"label":"paderinandrey:colorized_output","ref":"colorized_output","sha":"47648da0b62e56f7566b443fcbd9139e87f4a596","user":{"login":"paderinandrey","id":14351695,"node_id":"MDQ6VXNlcjE0MzUxNjk1","avatar_url":"https://avatars1.githubusercontent.com/u/14351695?v=4","gravatar_id":"","url":"https://api.github.com/users/paderinandrey","html_url":"https://github.com/paderinandrey","followers_url":"https://api.github.com/users/paderinandrey/followers","following_url":"https://api.github.com/users/paderinandrey/following{/other_user}","gists_url":"https://api.github.com/users/paderinandrey/gists{/gist_id}","starred_url":"https://api.github.com/users/paderinandrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paderinandrey/subscriptions","organizations_url":"https://api.github.com/users/paderinandrey/orgs","repos_url":"https://api.github.com/users/paderinandrey/repos","events_url":"https://api.github.com/users/paderinandrey/events{/privacy}","received_events_url":"https://api.github.com/users/paderinandrey/received_events","type":"User","site_admin":false},"repo":{"id":149491692,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0OTE2OTI=","name":"logux_rails","full_name":"paderinandrey/logux_rails","private":false,"owner":{"login":"paderinandrey","id":14351695,"node_id":"MDQ6VXNlcjE0MzUxNjk1","avatar_url":"https://avatars1.githubusercontent.com/u/14351695?v=4","gravatar_id":"","url":"https://api.github.com/users/paderinandrey","html_url":"https://github.com/paderinandrey","followers_url":"https://api.github.com/users/paderinandrey/followers","following_url":"https://api.github.com/users/paderinandrey/following{/other_user}","gists_url":"https://api.github.com/users/paderinandrey/gists{/gist_id}","starred_url":"https://api.github.com/users/paderinandrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paderinandrey/subscriptions","organizations_url":"https://api.github.com/users/paderinandrey/orgs","repos_url":"https://api.github.com/users/paderinandrey/repos","events_url":"https://api.github.com/users/paderinandrey/events{/privacy}","received_events_url":"https://api.github.com/users/paderinandrey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paderinandrey/logux_rails","description":"Rails client for logux server","fork":true,"url":"https://api.github.com/repos/paderinandrey/logux_rails","forks_url":"https://api.github.com/repos/paderinandrey/logux_rails/forks","keys_url":"https://api.github.com/repos/paderinandrey/logux_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paderinandrey/logux_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paderinandrey/logux_rails/teams","hooks_url":"https://api.github.com/repos/paderinandrey/logux_rails/hooks","issue_events_url":"https://api.github.com/repos/paderinandrey/logux_rails/issues/events{/number}","events_url":"https://api.github.com/repos/paderinandrey/logux_rails/events","assignees_url":"https://api.github.com/repos/paderinandrey/logux_rails/assignees{/user}","branches_url":"https://api.github.com/repos/paderinandrey/logux_rails/branches{/branch}","tags_url":"https://api.github.com/repos/paderinandrey/logux_rails/tags","blobs_url":"https://api.github.com/repos/paderinandrey/logux_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paderinandrey/logux_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paderinandrey/logux_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/paderinandrey/logux_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paderinandrey/logux_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/paderinandrey/logux_rails/languages","stargazers_url":"https://api.github.com/repos/paderinandrey/logux_rails/stargazers","contributors_url":"https://api.github.com/repos/paderinandrey/logux_rails/contributors","subscribers_url":"https://api.github.com/repos/paderinandrey/logux_rails/subscribers","subscription_url":"https://api.github.com/repos/paderinandrey/logux_rails/subscription","commits_url":"https://api.github.com/repos/paderinandrey/logux_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/paderinandrey/logux_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/paderinandrey/logux_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/paderinandrey/logux_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/paderinandrey/logux_rails/contents/{+path}","compare_url":"https://api.github.com/repos/paderinandrey/logux_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paderinandrey/logux_rails/merges","archive_url":"https://api.github.com/repos/paderinandrey/logux_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paderinandrey/logux_rails/downloads","issues_url":"https://api.github.com/repos/paderinandrey/logux_rails/issues{/number}","pulls_url":"https://api.github.com/repos/paderinandrey/logux_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/paderinandrey/logux_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/paderinandrey/logux_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paderinandrey/logux_rails/labels{/name}","releases_url":"https://api.github.com/repos/paderinandrey/logux_rails/releases{/id}","deployments_url":"https://api.github.com/repos/paderinandrey/logux_rails/deployments","created_at":"2018-09-19T18:01:34Z","updated_at":"2018-09-19T18:01:36Z","pushed_at":"2018-09-20T22:15:00Z","git_url":"git://github.com/paderinandrey/logux_rails.git","ssh_url":"git@github.com:paderinandrey/logux_rails.git","clone_url":"https://github.com/paderinandrey/logux_rails.git","svn_url":"https://github.com/paderinandrey/logux_rails","homepage":"","size":128,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wilddima:master","ref":"master","sha":"23ffbc6c1f565236ffca8e709e9e2f9e390441cf","user":{"login":"wilddima","id":12773329,"node_id":"MDQ6VXNlcjEyNzczMzI5","avatar_url":"https://avatars2.githubusercontent.com/u/12773329?v=4","gravatar_id":"","url":"https://api.github.com/users/wilddima","html_url":"https://github.com/wilddima","followers_url":"https://api.github.com/users/wilddima/followers","following_url":"https://api.github.com/users/wilddima/following{/other_user}","gists_url":"https://api.github.com/users/wilddima/gists{/gist_id}","starred_url":"https://api.github.com/users/wilddima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilddima/subscriptions","organizations_url":"https://api.github.com/users/wilddima/orgs","repos_url":"https://api.github.com/users/wilddima/repos","events_url":"https://api.github.com/users/wilddima/events{/privacy}","received_events_url":"https://api.github.com/users/wilddima/received_events","type":"User","site_admin":false},"repo":{"id":136374319,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNzQzMTk=","name":"logux_rails","full_name":"wilddima/logux_rails","private":false,"owner":{"login":"wilddima","id":12773329,"node_id":"MDQ6VXNlcjEyNzczMzI5","avatar_url":"https://avatars2.githubusercontent.com/u/12773329?v=4","gravatar_id":"","url":"https://api.github.com/users/wilddima","html_url":"https://github.com/wilddima","followers_url":"https://api.github.com/users/wilddima/followers","following_url":"https://api.github.com/users/wilddima/following{/other_user}","gists_url":"https://api.github.com/users/wilddima/gists{/gist_id}","starred_url":"https://api.github.com/users/wilddima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilddima/subscriptions","organizations_url":"https://api.github.com/users/wilddima/orgs","repos_url":"https://api.github.com/users/wilddima/repos","events_url":"https://api.github.com/users/wilddima/events{/privacy}","received_events_url":"https://api.github.com/users/wilddima/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wilddima/logux_rails","description":"Rails client for logux server","fork":false,"url":"https://api.github.com/repos/wilddima/logux_rails","forks_url":"https://api.github.com/repos/wilddima/logux_rails/forks","keys_url":"https://api.github.com/repos/wilddima/logux_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilddima/logux_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilddima/logux_rails/teams","hooks_url":"https://api.github.com/repos/wilddima/logux_rails/hooks","issue_events_url":"https://api.github.com/repos/wilddima/logux_rails/issues/events{/number}","events_url":"https://api.github.com/repos/wilddima/logux_rails/events","assignees_url":"https://api.github.com/repos/wilddima/logux_rails/assignees{/user}","branches_url":"https://api.github.com/repos/wilddima/logux_rails/branches{/branch}","tags_url":"https://api.github.com/repos/wilddima/logux_rails/tags","blobs_url":"https://api.github.com/repos/wilddima/logux_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilddima/logux_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilddima/logux_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilddima/logux_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilddima/logux_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/wilddima/logux_rails/languages","stargazers_url":"https://api.github.com/repos/wilddima/logux_rails/stargazers","contributors_url":"https://api.github.com/repos/wilddima/logux_rails/contributors","subscribers_url":"https://api.github.com/repos/wilddima/logux_rails/subscribers","subscription_url":"https://api.github.com/repos/wilddima/logux_rails/subscription","commits_url":"https://api.github.com/repos/wilddima/logux_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilddima/logux_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilddima/logux_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilddima/logux_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilddima/logux_rails/contents/{+path}","compare_url":"https://api.github.com/repos/wilddima/logux_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilddima/logux_rails/merges","archive_url":"https://api.github.com/repos/wilddima/logux_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilddima/logux_rails/downloads","issues_url":"https://api.github.com/repos/wilddima/logux_rails/issues{/number}","pulls_url":"https://api.github.com/repos/wilddima/logux_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/wilddima/logux_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/wilddima/logux_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilddima/logux_rails/labels{/name}","releases_url":"https://api.github.com/repos/wilddima/logux_rails/releases{/id}","deployments_url":"https://api.github.com/repos/wilddima/logux_rails/deployments","created_at":"2018-06-06T19:04:23Z","updated_at":"2018-09-19T18:16:36Z","pushed_at":"2018-09-20T22:15:02Z","git_url":"git://github.com/wilddima/logux_rails.git","ssh_url":"git@github.com:wilddima/logux_rails.git","clone_url":"https://github.com/wilddima/logux_rails.git","svn_url":"https://github.com/wilddima/logux_rails","homepage":"","size":124,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/10"},"html":{"href":"https://github.com/wilddima/logux_rails/pull/10"},"issue":{"href":"https://api.github.com/repos/wilddima/logux_rails/issues/10"},"comments":{"href":"https://api.github.com/repos/wilddima/logux_rails/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wilddima/logux_rails/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/wilddima/logux_rails/statuses/47648da0b62e56f7566b443fcbd9139e87f4a596"}},"author_association":"NONE"}}
{"actor":{"display_login":"wilddima"}}