{"action":"created","comment":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments/225243654","pull_request_review_id":164803457,"id":225243654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTI0MzY1NA==","diff_hunk":"@@ -0,0 +1,37 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+namespace Microsoft.Toolkit.Uwp.UI.Controls\n+{\n+    /// <summary>\n+    /// The behavior to use for navigating between the <see cref=\"MasterDetailsView\"/> master and details views\n+    /// </summary>\n+    public enum BackButtonBehavior\n+    {\n+        /// <summary>\n+        /// Automatically determine the best approach to use.\n+        /// </summary>\n+        /// <remarks>\n+        /// If the back button controlled by <see cref=\"Windows.UI.Core.SystemNavigationManager\"/> is already visible, the <see cref=\"MasterDetailsView\"/> will hook into that button.\n+        /// If the new NavigationView provided by the Windows UI nuget package is used, the <see cref=\"MasterDetailsView\"/> will enable and show that button.\n+        /// Otherwise the inline button is used.\n+        /// </remarks>\n+        Automatic,","path":"Microsoft.Toolkit.Uwp.UI.Controls/MasterDetailsView/BackButtonBehavior.cs","position":20,"original_position":20,"commit_id":"52792fb6ffbd25ecdd31b662c0a6a52719ca2fb6","original_commit_id":"9a8fee3168fa1a8021a03edf588f6999158e191a","user":{"login":"skendrot","id":1594689,"node_id":"MDQ6VXNlcjE1OTQ2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1594689?v=4","gravatar_id":"","url":"https://api.github.com/users/skendrot","html_url":"https://github.com/skendrot","followers_url":"https://api.github.com/users/skendrot/followers","following_url":"https://api.github.com/users/skendrot/following{/other_user}","gists_url":"https://api.github.com/users/skendrot/gists{/gist_id}","starred_url":"https://api.github.com/users/skendrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skendrot/subscriptions","organizations_url":"https://api.github.com/users/skendrot/orgs","repos_url":"https://api.github.com/users/skendrot/repos","events_url":"https://api.github.com/users/skendrot/events{/privacy}","received_events_url":"https://api.github.com/users/skendrot/received_events","type":"User","site_admin":false},"body":"I like descriptive names","created_at":"2018-10-15T17:02:27Z","updated_at":"2018-10-15T17:02:28Z","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561#discussion_r225243654","pull_request_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments/225243654"},"html":{"href":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561#discussion_r225243654"},"pull_request":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561"}},"in_reply_to_id":225230566},"pull_request":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561","id":222600025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjAwMDI1","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561","diff_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561.diff","patch_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561.patch","issue_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2561","number":2561,"state":"open","locked":false,"title":"Master details back button behavior","user":{"login":"skendrot","id":1594689,"node_id":"MDQ6VXNlcjE1OTQ2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1594689?v=4","gravatar_id":"","url":"https://api.github.com/users/skendrot","html_url":"https://github.com/skendrot","followers_url":"https://api.github.com/users/skendrot/followers","following_url":"https://api.github.com/users/skendrot/following{/other_user}","gists_url":"https://api.github.com/users/skendrot/gists{/gist_id}","starred_url":"https://api.github.com/users/skendrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skendrot/subscriptions","organizations_url":"https://api.github.com/users/skendrot/orgs","repos_url":"https://api.github.com/users/skendrot/repos","events_url":"https://api.github.com/users/skendrot/events{/privacy}","received_events_url":"https://api.github.com/users/skendrot/received_events","type":"User","site_admin":false},"body":"Issue: #2475\r\n<!-- Link to relevant issue. All PRs should be associated with an issue -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please uncomment one ore more that apply to this PR -->\r\n\r\n<!-- - Bugfix -->\r\n- Feature\r\n<!-- - Code style update (formatting) -->\r\n<!-- - Refactoring (no functional changes, no api changes) -->\r\n<!-- - Build or CI related changes -->\r\n<!-- - Documentation content changes -->\r\n<!-- - Sample app changes -->\r\n<!-- - Other... Please describe: -->\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nThe MasterDetailsView only works with the system back button. If applications are using the NavigationView from Windows UI or their own back button this makes it confusing which button to press\r\n\r\n## What is the new behavior?\r\nThe MasterDetailsView introduces a new BackButtonBehavior to control how the MasterDetailsView should work with and display a back button when in a narrow view\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] Tested code with current [supported SDKs](../readme.md#supported)\r\n- [x] Docs have been added/updated which fit [documentation template](https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/master/docs/.template.md). (for bug fixes / features)\r\n- [ ] Sample in sample app has been added / updated (for bug fixes / features)\r\n    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [x] Header has been added to all new source files (run *build/UpdateHeaders.bat*)\r\n- [x] Contains **NO** breaking changes\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n     Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\nAlso add a new DetailsHeader and DetailsHeaderTemplate property to use with the MasterDetailsView. This allows applications to put content where the inline back button is. \r\n\r\nSample app was not updated as we do not use the new NavigationView and we use the system back button for navigation.","created_at":"2018-10-12T22:18:17Z","updated_at":"2018-10-15T17:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca2abb7f5e15d99783035a6f3de79f5cdb442f2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561/commits","review_comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561/comments","review_comment_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2561/comments","statuses_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/52792fb6ffbd25ecdd31b662c0a6a52719ca2fb6","head":{"label":"skendrot:MasterDetailsBackButtonBehavior","ref":"MasterDetailsBackButtonBehavior","sha":"52792fb6ffbd25ecdd31b662c0a6a52719ca2fb6","user":{"login":"skendrot","id":1594689,"node_id":"MDQ6VXNlcjE1OTQ2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1594689?v=4","gravatar_id":"","url":"https://api.github.com/users/skendrot","html_url":"https://github.com/skendrot","followers_url":"https://api.github.com/users/skendrot/followers","following_url":"https://api.github.com/users/skendrot/following{/other_user}","gists_url":"https://api.github.com/users/skendrot/gists{/gist_id}","starred_url":"https://api.github.com/users/skendrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skendrot/subscriptions","organizations_url":"https://api.github.com/users/skendrot/orgs","repos_url":"https://api.github.com/users/skendrot/repos","events_url":"https://api.github.com/users/skendrot/events{/privacy}","received_events_url":"https://api.github.com/users/skendrot/received_events","type":"User","site_admin":false},"repo":{"id":70832006,"node_id":"MDEwOlJlcG9zaXRvcnk3MDgzMjAwNg==","name":"UWPCommunityToolkit","full_name":"skendrot/UWPCommunityToolkit","private":false,"owner":{"login":"skendrot","id":1594689,"node_id":"MDQ6VXNlcjE1OTQ2ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1594689?v=4","gravatar_id":"","url":"https://api.github.com/users/skendrot","html_url":"https://github.com/skendrot","followers_url":"https://api.github.com/users/skendrot/followers","following_url":"https://api.github.com/users/skendrot/following{/other_user}","gists_url":"https://api.github.com/users/skendrot/gists{/gist_id}","starred_url":"https://api.github.com/users/skendrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skendrot/subscriptions","organizations_url":"https://api.github.com/users/skendrot/orgs","repos_url":"https://api.github.com/users/skendrot/repos","events_url":"https://api.github.com/users/skendrot/events{/privacy}","received_events_url":"https://api.github.com/users/skendrot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skendrot/UWPCommunityToolkit","description":"The UWP Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":true,"url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit","forks_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/forks","keys_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/events","assignees_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/merges","archive_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/skendrot/UWPCommunityToolkit/deployments","created_at":"2016-10-13T17:39:13Z","updated_at":"2018-10-12T17:03:11Z","pushed_at":"2018-10-15T17:00:40Z","git_url":"git://github.com/skendrot/UWPCommunityToolkit.git","ssh_url":"git@github.com:skendrot/UWPCommunityToolkit.git","clone_url":"https://github.com/skendrot/UWPCommunityToolkit.git","svn_url":"https://github.com/skendrot/UWPCommunityToolkit","homepage":"http://docs.uwpcommunitytoolkit.com","size":396705,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windows-toolkit:master","ref":"master","sha":"cc4eaaa7af455048b46ee5df1cef4391d466b3c4","user":{"login":"windows-toolkit","id":41346473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ2NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/41346473?v=4","gravatar_id":"","url":"https://api.github.com/users/windows-toolkit","html_url":"https://github.com/windows-toolkit","followers_url":"https://api.github.com/users/windows-toolkit/followers","following_url":"https://api.github.com/users/windows-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/windows-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/windows-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windows-toolkit/subscriptions","organizations_url":"https://api.github.com/users/windows-toolkit/orgs","repos_url":"https://api.github.com/users/windows-toolkit/repos","events_url":"https://api.github.com/users/windows-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/windows-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":61403402,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQwMzQwMg==","name":"WindowsCommunityToolkit","full_name":"windows-toolkit/WindowsCommunityToolkit","private":false,"owner":{"login":"windows-toolkit","id":41346473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ2NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/41346473?v=4","gravatar_id":"","url":"https://api.github.com/users/windows-toolkit","html_url":"https://github.com/windows-toolkit","followers_url":"https://api.github.com/users/windows-toolkit/followers","following_url":"https://api.github.com/users/windows-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/windows-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/windows-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windows-toolkit/subscriptions","organizations_url":"https://api.github.com/users/windows-toolkit/orgs","repos_url":"https://api.github.com/users/windows-toolkit/repos","events_url":"https://api.github.com/users/windows-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/windows-toolkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit","description":"The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":false,"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit","forks_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/forks","keys_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/events","assignees_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/merges","archive_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/deployments","created_at":"2016-06-17T21:29:46Z","updated_at":"2018-10-15T06:13:35Z","pushed_at":"2018-10-15T17:00:42Z","git_url":"git://github.com/windows-toolkit/WindowsCommunityToolkit.git","ssh_url":"git@github.com:windows-toolkit/WindowsCommunityToolkit.git","clone_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit.git","svn_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit","homepage":"https://docs.microsoft.com/windows/communitytoolkit/","size":416144,"stargazers_count":2679,"watchers_count":2679,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":741,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":741,"open_issues":218,"watchers":2679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561"},"html":{"href":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2561"},"issue":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2561"},"comments":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2561/comments"},"review_comments":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561/comments"},"review_comment":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2561/commits"},"statuses":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/52792fb6ffbd25ecdd31b662c0a6a52719ca2fb6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"skendrot"}}