{"action":"created","issue":{"url":"https://api.github.com/repos/node-red/node-red/issues/1881","repository_url":"https://api.github.com/repos/node-red/node-red","labels_url":"https://api.github.com/repos/node-red/node-red/issues/1881/labels{/name}","comments_url":"https://api.github.com/repos/node-red/node-red/issues/1881/comments","events_url":"https://api.github.com/repos/node-red/node-red/issues/1881/events","html_url":"https://github.com/node-red/node-red/pull/1881","id":358178380,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDE0MjU4","number":1881,"title":"Add support for MQTT over web sockets.","user":{"login":"tboman","id":3968533,"node_id":"MDQ6VXNlcjM5Njg1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3968533?v=4","gravatar_id":"","url":"https://api.github.com/users/tboman","html_url":"https://github.com/tboman","followers_url":"https://api.github.com/users/tboman/followers","following_url":"https://api.github.com/users/tboman/following{/other_user}","gists_url":"https://api.github.com/users/tboman/gists{/gist_id}","starred_url":"https://api.github.com/users/tboman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboman/subscriptions","organizations_url":"https://api.github.com/users/tboman/orgs","repos_url":"https://api.github.com/users/tboman/repos","events_url":"https://api.github.com/users/tboman/events{/privacy}","received_events_url":"https://api.github.com/users/tboman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T19:05:54Z","updated_at":"2018-09-07T19:12:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/node-red/node-red/pulls/1881","html_url":"https://github.com/node-red/node-red/pull/1881","diff_url":"https://github.com/node-red/node-red/pull/1881.diff","patch_url":"https://github.com/node-red/node-red/pull/1881.patch"},"body":"## Types of changes\r\n\r\n- [ ] Bugfix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n## Proposed changes\r\n\r\nIt appears that explicit UI support for MQTT over Web Sockets was intended, as some dead code already exists.  This code adds a checkbox on the MQTT configuration screen following the same pattern as for \"use TLS\".  If unchecked, current behavior stays the same.  If checked, MQTT requests default to use ws:// instead of mqtt:// for the run-time connection to the queue.\r\n\r\nThe workaround today is to include the URL scheme in the server field.\r\nhttps://discourse.nodered.org/t/mqtt-broken-url-and-port/1275\r\n\r\nI am holding off on creating unit tests for MQTT node, since there is no coverage at all at this time.  If people agree this is a good idea, I'll create tests for the full node.\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [contribution guidelines](https://github.com/node-red/node-red/blob/master/CONTRIBUTING.md)\r\n- [x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.\r\n- [x] I have run `grunt` to verify the unit tests pass\r\n- [ ] I have added suitable unit tests to cover the new/changed functionality\r\n"},"comment":{"url":"https://api.github.com/repos/node-red/node-red/issues/comments/419537719","html_url":"https://github.com/node-red/node-red/pull/1881#issuecomment-419537719","issue_url":"https://api.github.com/repos/node-red/node-red/issues/1881","id":419537719,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUzNzcxOQ==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T19:12:09Z","updated_at":"2018-09-07T19:12:09Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/18887309/badge)](https://coveralls.io/builds/18887309)\n\nCoverage increased (+0.05%) to 76.362% when pulling **748d2041a86da0485402144a6a7077818ae91547 on tboman:topic/MQTT-over-ws-2** into **ca77842b5baab3d3aa93e1629f74c68dfd0cbf5a on node-red:master**.\n"}}
{"actor":{"display_login":"coveralls"}}