{"action":"created","comment":{"url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/comments/222810570","pull_request_review_id":161789051,"id":222810570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjgxMDU3MA==","diff_hunk":"@@ -29,12 +30,15 @@ def __init__(\n \n         self.loop = loop\n \n-        self.session = aiohttp.ClientSession(\n-            connector=aiohttp.TCPConnector(\n-                use_dns_cache=False,\n-                loop=self.loop,\n-            ),\n-        )\n+        if not isinstance(session, aiohttp.ClientSession):","path":"aioslacker/__init__.py","position":18,"original_position":18,"commit_id":"cbd1d304068c49ebd674ebf9c07bf1ae56d43a06","original_commit_id":"cbd1d304068c49ebd674ebf9c07bf1ae56d43a06","user":{"login":"hellysmile","id":1834317,"node_id":"MDQ6VXNlcjE4MzQzMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1834317?v=4","gravatar_id":"","url":"https://api.github.com/users/hellysmile","html_url":"https://github.com/hellysmile","followers_url":"https://api.github.com/users/hellysmile/followers","following_url":"https://api.github.com/users/hellysmile/following{/other_user}","gists_url":"https://api.github.com/users/hellysmile/gists{/gist_id}","starred_url":"https://api.github.com/users/hellysmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellysmile/subscriptions","organizations_url":"https://api.github.com/users/hellysmile/orgs","repos_url":"https://api.github.com/users/hellysmile/repos","events_url":"https://api.github.com/users/hellysmile/events{/privacy}","received_events_url":"https://api.github.com/users/hellysmile/received_events","type":"User","site_admin":false},"body":"This check makes no sense, as well can hard to debug, just remove this check, please. ","created_at":"2018-10-04T20:09:44Z","updated_at":"2018-10-04T20:12:58Z","html_url":"https://github.com/aio-libs/aioslacker/pull/12#discussion_r222810570","pull_request_url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/comments/222810570"},"html":{"href":"https://github.com/aio-libs/aioslacker/pull/12#discussion_r222810570"},"pull_request":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12","id":220486886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDg2ODg2","html_url":"https://github.com/aio-libs/aioslacker/pull/12","diff_url":"https://github.com/aio-libs/aioslacker/pull/12.diff","patch_url":"https://github.com/aio-libs/aioslacker/pull/12.patch","issue_url":"https://api.github.com/repos/aio-libs/aioslacker/issues/12","number":12,"state":"open","locked":false,"title":"Added capability to pass client session in API","user":{"login":"hzlmn","id":8246283,"node_id":"MDQ6VXNlcjgyNDYyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/8246283?v=4","gravatar_id":"","url":"https://api.github.com/users/hzlmn","html_url":"https://github.com/hzlmn","followers_url":"https://api.github.com/users/hzlmn/followers","following_url":"https://api.github.com/users/hzlmn/following{/other_user}","gists_url":"https://api.github.com/users/hzlmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hzlmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzlmn/subscriptions","organizations_url":"https://api.github.com/users/hzlmn/orgs","repos_url":"https://api.github.com/users/hzlmn/repos","events_url":"https://api.github.com/users/hzlmn/events{/privacy}","received_events_url":"https://api.github.com/users/hzlmn/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-04T19:13:10Z","updated_at":"2018-10-04T20:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc7ae41029e9acc2ac36f807e45294bed60f5f73","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12/commits","review_comments_url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12/comments","review_comment_url":"https://api.github.com/repos/aio-libs/aioslacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aio-libs/aioslacker/issues/12/comments","statuses_url":"https://api.github.com/repos/aio-libs/aioslacker/statuses/cbd1d304068c49ebd674ebf9c07bf1ae56d43a06","head":{"label":"hzlmn:share_session","ref":"share_session","sha":"cbd1d304068c49ebd674ebf9c07bf1ae56d43a06","user":{"login":"hzlmn","id":8246283,"node_id":"MDQ6VXNlcjgyNDYyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/8246283?v=4","gravatar_id":"","url":"https://api.github.com/users/hzlmn","html_url":"https://github.com/hzlmn","followers_url":"https://api.github.com/users/hzlmn/followers","following_url":"https://api.github.com/users/hzlmn/following{/other_user}","gists_url":"https://api.github.com/users/hzlmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hzlmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzlmn/subscriptions","organizations_url":"https://api.github.com/users/hzlmn/orgs","repos_url":"https://api.github.com/users/hzlmn/repos","events_url":"https://api.github.com/users/hzlmn/events{/privacy}","received_events_url":"https://api.github.com/users/hzlmn/received_events","type":"User","site_admin":false},"repo":{"id":151617488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MTc0ODg=","name":"aioslacker","full_name":"hzlmn/aioslacker","private":false,"owner":{"login":"hzlmn","id":8246283,"node_id":"MDQ6VXNlcjgyNDYyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/8246283?v=4","gravatar_id":"","url":"https://api.github.com/users/hzlmn","html_url":"https://github.com/hzlmn","followers_url":"https://api.github.com/users/hzlmn/followers","following_url":"https://api.github.com/users/hzlmn/following{/other_user}","gists_url":"https://api.github.com/users/hzlmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hzlmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzlmn/subscriptions","organizations_url":"https://api.github.com/users/hzlmn/orgs","repos_url":"https://api.github.com/users/hzlmn/repos","events_url":"https://api.github.com/users/hzlmn/events{/privacy}","received_events_url":"https://api.github.com/users/hzlmn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hzlmn/aioslacker","description":"slacker wrapper for asyncio","fork":true,"url":"https://api.github.com/repos/hzlmn/aioslacker","forks_url":"https://api.github.com/repos/hzlmn/aioslacker/forks","keys_url":"https://api.github.com/repos/hzlmn/aioslacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzlmn/aioslacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzlmn/aioslacker/teams","hooks_url":"https://api.github.com/repos/hzlmn/aioslacker/hooks","issue_events_url":"https://api.github.com/repos/hzlmn/aioslacker/issues/events{/number}","events_url":"https://api.github.com/repos/hzlmn/aioslacker/events","assignees_url":"https://api.github.com/repos/hzlmn/aioslacker/assignees{/user}","branches_url":"https://api.github.com/repos/hzlmn/aioslacker/branches{/branch}","tags_url":"https://api.github.com/repos/hzlmn/aioslacker/tags","blobs_url":"https://api.github.com/repos/hzlmn/aioslacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzlmn/aioslacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzlmn/aioslacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzlmn/aioslacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzlmn/aioslacker/statuses/{sha}","languages_url":"https://api.github.com/repos/hzlmn/aioslacker/languages","stargazers_url":"https://api.github.com/repos/hzlmn/aioslacker/stargazers","contributors_url":"https://api.github.com/repos/hzlmn/aioslacker/contributors","subscribers_url":"https://api.github.com/repos/hzlmn/aioslacker/subscribers","subscription_url":"https://api.github.com/repos/hzlmn/aioslacker/subscription","commits_url":"https://api.github.com/repos/hzlmn/aioslacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzlmn/aioslacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzlmn/aioslacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzlmn/aioslacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzlmn/aioslacker/contents/{+path}","compare_url":"https://api.github.com/repos/hzlmn/aioslacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzlmn/aioslacker/merges","archive_url":"https://api.github.com/repos/hzlmn/aioslacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzlmn/aioslacker/downloads","issues_url":"https://api.github.com/repos/hzlmn/aioslacker/issues{/number}","pulls_url":"https://api.github.com/repos/hzlmn/aioslacker/pulls{/number}","milestones_url":"https://api.github.com/repos/hzlmn/aioslacker/milestones{/number}","notifications_url":"https://api.github.com/repos/hzlmn/aioslacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzlmn/aioslacker/labels{/name}","releases_url":"https://api.github.com/repos/hzlmn/aioslacker/releases{/id}","deployments_url":"https://api.github.com/repos/hzlmn/aioslacker/deployments","created_at":"2018-10-04T18:24:50Z","updated_at":"2018-10-04T18:24:52Z","pushed_at":"2018-10-04T19:24:10Z","git_url":"git://github.com/hzlmn/aioslacker.git","ssh_url":"git@github.com:hzlmn/aioslacker.git","clone_url":"https://github.com/hzlmn/aioslacker.git","svn_url":"https://github.com/hzlmn/aioslacker","homepage":"https://pypi.python.org/pypi/aioslacker","size":33,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aio-libs:master","ref":"master","sha":"1a5ee403f3bc32aaac271bb25e52ce4ee96489ce","user":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":87016276,"node_id":"MDEwOlJlcG9zaXRvcnk4NzAxNjI3Ng==","name":"aioslacker","full_name":"aio-libs/aioslacker","private":false,"owner":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aio-libs/aioslacker","description":"slacker wrapper for asyncio","fork":false,"url":"https://api.github.com/repos/aio-libs/aioslacker","forks_url":"https://api.github.com/repos/aio-libs/aioslacker/forks","keys_url":"https://api.github.com/repos/aio-libs/aioslacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aioslacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aioslacker/teams","hooks_url":"https://api.github.com/repos/aio-libs/aioslacker/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aioslacker/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aioslacker/events","assignees_url":"https://api.github.com/repos/aio-libs/aioslacker/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aioslacker/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aioslacker/tags","blobs_url":"https://api.github.com/repos/aio-libs/aioslacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aioslacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aioslacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aioslacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aioslacker/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aioslacker/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aioslacker/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aioslacker/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aioslacker/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aioslacker/subscription","commits_url":"https://api.github.com/repos/aio-libs/aioslacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aioslacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aioslacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aioslacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aioslacker/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aioslacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aioslacker/merges","archive_url":"https://api.github.com/repos/aio-libs/aioslacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aioslacker/downloads","issues_url":"https://api.github.com/repos/aio-libs/aioslacker/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aioslacker/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aioslacker/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aioslacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aioslacker/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aioslacker/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aioslacker/deployments","created_at":"2017-04-02T21:07:29Z","updated_at":"2018-10-04T16:11:41Z","pushed_at":"2018-10-04T19:24:12Z","git_url":"git://github.com/aio-libs/aioslacker.git","ssh_url":"git@github.com:aio-libs/aioslacker.git","clone_url":"https://github.com/aio-libs/aioslacker.git","svn_url":"https://github.com/aio-libs/aioslacker","homepage":"https://pypi.python.org/pypi/aioslacker","size":31,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12"},"html":{"href":"https://github.com/aio-libs/aioslacker/pull/12"},"issue":{"href":"https://api.github.com/repos/aio-libs/aioslacker/issues/12"},"comments":{"href":"https://api.github.com/repos/aio-libs/aioslacker/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aio-libs/aioslacker/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/aio-libs/aioslacker/statuses/cbd1d304068c49ebd674ebf9c07bf1ae56d43a06"}},"author_association":"NONE"}}
{"actor":{"display_login":"hellysmile"}}