{"action":"created","issue":{"url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/1550","repository_url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd","labels_url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/1550/labels{/name}","comments_url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/1550/comments","events_url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/1550/events","html_url":"https://github.com/NG-ZORRO/ng-zorro-antd/pull/1550","id":327530444,"number":1550,"title":"fix:(module:upload): prevent upload using nzBeforeUpload as Observable ","user":{"login":"skix123","id":10488552,"avatar_url":"https://avatars0.githubusercontent.com/u/10488552?v=4","gravatar_id":"","url":"https://api.github.com/users/skix123","html_url":"https://github.com/skix123","followers_url":"https://api.github.com/users/skix123/followers","following_url":"https://api.github.com/users/skix123/following{/other_user}","gists_url":"https://api.github.com/users/skix123/gists{/gist_id}","starred_url":"https://api.github.com/users/skix123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skix123/subscriptions","organizations_url":"https://api.github.com/users/skix123/orgs","repos_url":"https://api.github.com/users/skix123/repos","events_url":"https://api.github.com/users/skix123/events{/privacy}","received_events_url":"https://api.github.com/users/skix123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-30T00:19:01Z","updated_at":"2018-05-30T10:05:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/pulls/1550","html_url":"https://github.com/NG-ZORRO/ng-zorro-antd/pull/1550","diff_url":"https://github.com/NG-ZORRO/ng-zorro-antd/pull/1550.diff","patch_url":"https://github.com/NG-ZORRO/ng-zorro-antd/pull/1550.patch"},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features) - english only\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[x] Feature?\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Application (the showcase website) / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\nWhen using `nzBeforeUpload` as Observable, you can't prevent the upload.\r\n\r\n\r\n## What is the new behavior?\r\nReturn boolean or Observable<boolean> `false` to prevent file to upload - [preview](https://deploy-preview-1550--ng-zorro-master.netlify.com/components/upload/en#components-upload-demo-observable).\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/comments/393105357","html_url":"https://github.com/NG-ZORRO/ng-zorro-antd/pull/1550#issuecomment-393105357","issue_url":"https://api.github.com/repos/NG-ZORRO/ng-zorro-antd/issues/1550","id":393105357,"user":{"login":"vthinkxie","id":1506722,"avatar_url":"https://avatars1.githubusercontent.com/u/1506722?v=4","gravatar_id":"","url":"https://api.github.com/users/vthinkxie","html_url":"https://github.com/vthinkxie","followers_url":"https://api.github.com/users/vthinkxie/followers","following_url":"https://api.github.com/users/vthinkxie/following{/other_user}","gists_url":"https://api.github.com/users/vthinkxie/gists{/gist_id}","starred_url":"https://api.github.com/users/vthinkxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vthinkxie/subscriptions","organizations_url":"https://api.github.com/users/vthinkxie/orgs","repos_url":"https://api.github.com/users/vthinkxie/repos","events_url":"https://api.github.com/users/vthinkxie/events{/privacy}","received_events_url":"https://api.github.com/users/vthinkxie/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T10:05:18Z","updated_at":"2018-05-30T10:05:18Z","author_association":"MEMBER","body":"thanks for your pr.\r\nplease submit an issue to describe the feat or bug you want to add or fix before pr."}}
{"actor":{"display_login":"vthinkxie"}}