{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26759","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26759/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26759/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26759/events","html_url":"https://github.com/cockroachdb/cockroach/pull/26759","id":332930901,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mjk2MDg0","number":26759,"title":"opt: improve null col extraction from constraints","user":{"login":"RaduBerinde","id":16544120,"node_id":"MDQ6VXNlcjE2NTQ0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-15T22:28:33Z","updated_at":"2018-06-17T12:15:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26759","html_url":"https://github.com/cockroachdb/cockroach/pull/26759","diff_url":"https://github.com/cockroachdb/cockroach/pull/26759.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/26759.patch"},"body":"For constrained scans, we weren't extracting not-null columns from the\r\nconstraint. This change fixes that and improves the not-null\r\nextraction to work on descending columns and to look at more than the\r\nfirst column.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/397874830","html_url":"https://github.com/cockroachdb/cockroach/pull/26759#issuecomment-397874830","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26759","id":397874830,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg3NDgzMA==","user":{"login":"RaduBerinde","id":16544120,"node_id":"MDQ6VXNlcjE2NTQ0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T12:15:09Z","updated_at":"2018-06-17T12:15:09Z","author_association":"MEMBER","body":"\n\n\n\nReview status: :shipit: complete! 1 of 0 LGTMs obtained\n\n---\n\n*[pkg/sql/opt/constraint/constraint.go, line 470 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/26759#-LFAXi0J6ZtT-aEuf6OK:-LFCcCqP-2KTN4kyrSwg:b-fois7j) ([raw file](https://github.com/cockroachdb/cockroach/blob/a29dad182670038112577bb1cf2674828f435311/pkg/sql/opt/constraint/constraint.go#L470)):*\n<details><summary><i>Previously, andy-kimball (Andy Kimball) wrote…</i></summary><blockquote>\n\nDid you consider calling `ExactPrefix` where, and then re-looping over cols to check for the `hasNull` case? Logic might be cleaner.\n</blockquote></details>\n\n`ExactPrefix` is more strict - it wants all spans to have the *same* values on the prefix. For example, the ExactPrefix of the example here `[/1/1/1 - /1/1/2] [/3/3/3 - /3/3/4]` is 0.\nI added an example to `ExactPrefix` to make this clearer.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/cockroachdb/cockroach/26759)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"RaduBerinde"}}