{"action":"created","comment":{"url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/comments/232225800","pull_request_review_id":173375334,"id":232225800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjIyNTgwMA==","diff_hunk":"@@ -56,18 +56,21 @@ def convert_quantity(str_qty):\n     value = None\n     unit = None\n     dict_qty = {'val': value, 'unit': unit}\n+    \n     try:\n         lst_qty = str_qty.split(',')","path":"off_mgt.py","position":6,"original_position":6,"commit_id":"15acc4071f9ad0120f6490711aabd39c044210a8","original_commit_id":"15acc4071f9ad0120f6490711aabd39c044210a8","user":{"login":"aoifeadk","id":38290843,"node_id":"MDQ6VXNlcjM4MjkwODQz","avatar_url":"https://avatars2.githubusercontent.com/u/38290843?v=4","gravatar_id":"","url":"https://api.github.com/users/aoifeadk","html_url":"https://github.com/aoifeadk","followers_url":"https://api.github.com/users/aoifeadk/followers","following_url":"https://api.github.com/users/aoifeadk/following{/other_user}","gists_url":"https://api.github.com/users/aoifeadk/gists{/gist_id}","starred_url":"https://api.github.com/users/aoifeadk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoifeadk/subscriptions","organizations_url":"https://api.github.com/users/aoifeadk/orgs","repos_url":"https://api.github.com/users/aoifeadk/repos","events_url":"https://api.github.com/users/aoifeadk/events{/privacy}","received_events_url":"https://api.github.com/users/aoifeadk/received_events","type":"User","site_admin":false},"body":"@thito514 @frgfm pourquoi il y a cette ligne `str_qty.split(',')` ? est-ce que c'est parce que vous avez trouvé des `quantity` qui étaient en fait des listes de produits ? genre `400g, 600g, 1 kg` ?\r\n\r\nca pose problème quand il y a des produits OFF où le `quantity` contient une virgule au lieu d'un point, du genre `0,6 kg` \r\n\r\non peut faire un regex qui ne splitte pas sur les virgules sans espace ni à droit ni à gauche, mais je veux juste d'abord comprendre tous les use case que vous avez vus ?","created_at":"2018-11-09T11:39:45Z","updated_at":"2018-11-09T11:39:45Z","html_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3#discussion_r232225800","pull_request_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/comments/232225800"},"html":{"href":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3#discussion_r232225800"},"pull_request":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3","id":229189381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTg5Mzgx","html_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3","diff_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3.diff","patch_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3.patch","issue_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/3","number":3,"state":"open","locked":false,"title":"cleaned errors on quantity estimations","user":{"login":"thito514","id":42751120,"node_id":"MDQ6VXNlcjQyNzUxMTIw","avatar_url":"https://avatars1.githubusercontent.com/u/42751120?v=4","gravatar_id":"","url":"https://api.github.com/users/thito514","html_url":"https://github.com/thito514","followers_url":"https://api.github.com/users/thito514/followers","following_url":"https://api.github.com/users/thito514/following{/other_user}","gists_url":"https://api.github.com/users/thito514/gists{/gist_id}","starred_url":"https://api.github.com/users/thito514/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thito514/subscriptions","organizations_url":"https://api.github.com/users/thito514/orgs","repos_url":"https://api.github.com/users/thito514/repos","events_url":"https://api.github.com/users/thito514/events{/privacy}","received_events_url":"https://api.github.com/users/thito514/received_events","type":"User","site_admin":false},"body":"J'ai appliqué la fonction sur  toute la base de données OFF et les réponses sont un peu mieux. Je vous laisse prendre le relais","created_at":"2018-11-07T22:27:21Z","updated_at":"2018-11-09T11:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62c266f32f5dbba2b781a63b4fea02883597f291","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3/commits","review_comments_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3/comments","review_comment_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/3/comments","statuses_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/statuses/15acc4071f9ad0120f6490711aabd39c044210a8","head":{"label":"thito514:master","ref":"master","sha":"15acc4071f9ad0120f6490711aabd39c044210a8","user":{"login":"thito514","id":42751120,"node_id":"MDQ6VXNlcjQyNzUxMTIw","avatar_url":"https://avatars1.githubusercontent.com/u/42751120?v=4","gravatar_id":"","url":"https://api.github.com/users/thito514","html_url":"https://github.com/thito514","followers_url":"https://api.github.com/users/thito514/followers","following_url":"https://api.github.com/users/thito514/following{/other_user}","gists_url":"https://api.github.com/users/thito514/gists{/gist_id}","starred_url":"https://api.github.com/users/thito514/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thito514/subscriptions","organizations_url":"https://api.github.com/users/thito514/orgs","repos_url":"https://api.github.com/users/thito514/repos","events_url":"https://api.github.com/users/thito514/events{/privacy}","received_events_url":"https://api.github.com/users/thito514/received_events","type":"User","site_admin":false},"repo":{"id":156297114,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYyOTcxMTQ=","name":"batch5_phenix_happymeal","full_name":"thito514/batch5_phenix_happymeal","private":false,"owner":{"login":"thito514","id":42751120,"node_id":"MDQ6VXNlcjQyNzUxMTIw","avatar_url":"https://avatars1.githubusercontent.com/u/42751120?v=4","gravatar_id":"","url":"https://api.github.com/users/thito514","html_url":"https://github.com/thito514","followers_url":"https://api.github.com/users/thito514/followers","following_url":"https://api.github.com/users/thito514/following{/other_user}","gists_url":"https://api.github.com/users/thito514/gists{/gist_id}","starred_url":"https://api.github.com/users/thito514/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thito514/subscriptions","organizations_url":"https://api.github.com/users/thito514/orgs","repos_url":"https://api.github.com/users/thito514/repos","events_url":"https://api.github.com/users/thito514/events{/privacy}","received_events_url":"https://api.github.com/users/thito514/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thito514/batch5_phenix_happymeal","description":"Meal balancing algorithm for unsold food redistribution","fork":true,"url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal","forks_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/forks","keys_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/teams","hooks_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/hooks","issue_events_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/issues/events{/number}","events_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/events","assignees_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/assignees{/user}","branches_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/branches{/branch}","tags_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/tags","blobs_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/git/refs{/sha}","trees_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/statuses/{sha}","languages_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/languages","stargazers_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/stargazers","contributors_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/contributors","subscribers_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/subscribers","subscription_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/subscription","commits_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/commits{/sha}","git_commits_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/git/commits{/sha}","comments_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/comments{/number}","issue_comment_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/issues/comments{/number}","contents_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/contents/{+path}","compare_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/merges","archive_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/downloads","issues_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/issues{/number}","pulls_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/pulls{/number}","milestones_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/milestones{/number}","notifications_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/labels{/name}","releases_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/releases{/id}","deployments_url":"https://api.github.com/repos/thito514/batch5_phenix_happymeal/deployments","created_at":"2018-11-05T23:25:28Z","updated_at":"2018-11-06T23:24:43Z","pushed_at":"2018-11-06T23:24:41Z","git_url":"git://github.com/thito514/batch5_phenix_happymeal.git","ssh_url":"git@github.com:thito514/batch5_phenix_happymeal.git","clone_url":"https://github.com/thito514/batch5_phenix_happymeal.git","svn_url":"https://github.com/thito514/batch5_phenix_happymeal","homepage":"","size":16,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dataforgoodfr:master","ref":"master","sha":"98be4f59467644fe42cd6d38e1c9b95ad984c1e9","user":{"login":"dataforgoodfr","id":11797105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk3MTA1","avatar_url":"https://avatars0.githubusercontent.com/u/11797105?v=4","gravatar_id":"","url":"https://api.github.com/users/dataforgoodfr","html_url":"https://github.com/dataforgoodfr","followers_url":"https://api.github.com/users/dataforgoodfr/followers","following_url":"https://api.github.com/users/dataforgoodfr/following{/other_user}","gists_url":"https://api.github.com/users/dataforgoodfr/gists{/gist_id}","starred_url":"https://api.github.com/users/dataforgoodfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataforgoodfr/subscriptions","organizations_url":"https://api.github.com/users/dataforgoodfr/orgs","repos_url":"https://api.github.com/users/dataforgoodfr/repos","events_url":"https://api.github.com/users/dataforgoodfr/events{/privacy}","received_events_url":"https://api.github.com/users/dataforgoodfr/received_events","type":"Organization","site_admin":false},"repo":{"id":155621170,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2MjExNzA=","name":"batch5_phenix_happymeal","full_name":"dataforgoodfr/batch5_phenix_happymeal","private":false,"owner":{"login":"dataforgoodfr","id":11797105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk3MTA1","avatar_url":"https://avatars0.githubusercontent.com/u/11797105?v=4","gravatar_id":"","url":"https://api.github.com/users/dataforgoodfr","html_url":"https://github.com/dataforgoodfr","followers_url":"https://api.github.com/users/dataforgoodfr/followers","following_url":"https://api.github.com/users/dataforgoodfr/following{/other_user}","gists_url":"https://api.github.com/users/dataforgoodfr/gists{/gist_id}","starred_url":"https://api.github.com/users/dataforgoodfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataforgoodfr/subscriptions","organizations_url":"https://api.github.com/users/dataforgoodfr/orgs","repos_url":"https://api.github.com/users/dataforgoodfr/repos","events_url":"https://api.github.com/users/dataforgoodfr/events{/privacy}","received_events_url":"https://api.github.com/users/dataforgoodfr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal","description":"Meal balancing algorithm for unsold food redistribution","fork":false,"url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal","forks_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/forks","keys_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/teams","hooks_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/hooks","issue_events_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/events{/number}","events_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/events","assignees_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/assignees{/user}","branches_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/branches{/branch}","tags_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/tags","blobs_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/git/refs{/sha}","trees_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/statuses/{sha}","languages_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/languages","stargazers_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/stargazers","contributors_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/contributors","subscribers_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/subscribers","subscription_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/subscription","commits_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/commits{/sha}","git_commits_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/git/commits{/sha}","comments_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/comments{/number}","issue_comment_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/comments{/number}","contents_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/contents/{+path}","compare_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/merges","archive_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/downloads","issues_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues{/number}","pulls_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls{/number}","milestones_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/milestones{/number}","notifications_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/labels{/name}","releases_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/releases{/id}","deployments_url":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/deployments","created_at":"2018-10-31T20:45:48Z","updated_at":"2018-11-08T19:11:28Z","pushed_at":"2018-11-08T19:11:26Z","git_url":"git://github.com/dataforgoodfr/batch5_phenix_happymeal.git","ssh_url":"git@github.com:dataforgoodfr/batch5_phenix_happymeal.git","clone_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal.git","svn_url":"https://github.com/dataforgoodfr/batch5_phenix_happymeal","homepage":"","size":799,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3"},"html":{"href":"https://github.com/dataforgoodfr/batch5_phenix_happymeal/pull/3"},"issue":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/3"},"comments":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/dataforgoodfr/batch5_phenix_happymeal/statuses/15acc4071f9ad0120f6490711aabd39c044210a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aoifeadk"}}