{"action":"closed","number":24907,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/24907","id":190403945,"html_url":"https://github.com/odoo/odoo/pull/24907","diff_url":"https://github.com/odoo/odoo/pull/24907.diff","patch_url":"https://github.com/odoo/odoo/pull/24907.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/24907","number":24907,"state":"closed","locked":false,"title":"[REF] models: name_get - Use prefetched or avoid prefetch","user":{"login":"moylop260","id":6644187,"avatar_url":"https://avatars0.githubusercontent.com/u/6644187?v=4","gravatar_id":"","url":"https://api.github.com/users/moylop260","html_url":"https://github.com/moylop260","followers_url":"https://api.github.com/users/moylop260/followers","following_url":"https://api.github.com/users/moylop260/following{/other_user}","gists_url":"https://api.github.com/users/moylop260/gists{/gist_id}","starred_url":"https://api.github.com/users/moylop260/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moylop260/subscriptions","organizations_url":"https://api.github.com/users/moylop260/orgs","repos_url":"https://api.github.com/users/moylop260/repos","events_url":"https://api.github.com/users/moylop260/events{/privacy}","received_events_url":"https://api.github.com/users/moylop260/received_events","type":"User","site_admin":false},"body":"name_get method is a critical one to performance issues since that is used in all views for m2* fields.\r\n\r\nThen avoid get all fields if the view just is showing one field.\r\nBut if previously the cache is prefetch was filled then re-use it if not then don't read all other fields.\r\n\r\nAvoid access to `if name in self._fields: self._fields[name]` 2 times\r\nBetter use `field_name = self._fields.get(name) if field_name` used just one time.","created_at":"2018-05-24T20:01:42Z","updated_at":"2018-05-24T20:37:18Z","closed_at":"2018-05-24T20:37:18Z","merged_at":null,"merge_commit_sha":"fa010fd69c04290f0db891ae382c49880996c8b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/24907/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/24907/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/24907/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/d252a66d33bf257e7709495a57f4c447e44ed76c","head":{"label":"vauxoo-dev:master-name-get-moy","ref":"master-name-get-moy","sha":"d252a66d33bf257e7709495a57f4c447e44ed76c","user":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":23670214,"name":"odoo","full_name":"vauxoo-dev/odoo","owner":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vauxoo-dev/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":true,"url":"https://api.github.com/repos/vauxoo-dev/odoo","forks_url":"https://api.github.com/repos/vauxoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/vauxoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vauxoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vauxoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/vauxoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/vauxoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/vauxoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/vauxoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/vauxoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/vauxoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/vauxoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vauxoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vauxoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vauxoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vauxoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/vauxoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/vauxoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/vauxoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/vauxoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/vauxoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/vauxoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vauxoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vauxoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vauxoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/vauxoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/vauxoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vauxoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/vauxoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vauxoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/vauxoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/vauxoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/vauxoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/vauxoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vauxoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/vauxoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/vauxoo-dev/odoo/deployments","created_at":"2014-09-04T16:26:36Z","updated_at":"2017-07-17T07:14:13Z","pushed_at":"2018-05-24T19:59:28Z","git_url":"git://github.com/vauxoo-dev/odoo.git","ssh_url":"git@github.com:vauxoo-dev/odoo.git","clone_url":"https://github.com/vauxoo-dev/odoo.git","svn_url":"https://github.com/vauxoo-dev/odoo","homepage":"https://www.odoo.com","size":1976875,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"58acf26ea43a6dfbd30c06b5e3c196305019e462","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-05-24T20:16:56Z","pushed_at":"2018-05-24T20:31:07Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2034153,"stargazers_count":9658,"watchers_count":9658,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8167,"mirror_url":null,"archived":false,"open_issues_count":1613,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8167,"open_issues":1613,"watchers":9658,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24907"},"html":{"href":"https://github.com/odoo/odoo/pull/24907"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/24907"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/24907/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24907/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24907/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/d252a66d33bf257e7709495a57f4c447e44ed76c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"moylop260"}}