{"action":"created","comment":{"url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/comments/183226691","pull_request_review_id":114190830,"id":183226691,"diff_hunk":"@@ -18,28 +19,18 @@ class MFACredentials(object):\n     \"\"\"\n \n     def __init__(self):\n-        self._device_index = None\n-        self._devices = []\n-        self._otp = None","path":"onelogin_aws_cli/credentials.py","position":14,"original_position":14,"commit_id":"92b8ae657bf72ee793471a3217ab0c5a23dc1fe4","original_commit_id":"92b8ae657bf72ee793471a3217ab0c5a23dc1fe4","user":{"login":"drewsonne","id":233054,"avatar_url":"https://avatars3.githubusercontent.com/u/233054?v=4","gravatar_id":"","url":"https://api.github.com/users/drewsonne","html_url":"https://github.com/drewsonne","followers_url":"https://api.github.com/users/drewsonne/followers","following_url":"https://api.github.com/users/drewsonne/following{/other_user}","gists_url":"https://api.github.com/users/drewsonne/gists{/gist_id}","starred_url":"https://api.github.com/users/drewsonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewsonne/subscriptions","organizations_url":"https://api.github.com/users/drewsonne/orgs","repos_url":"https://api.github.com/users/drewsonne/repos","events_url":"https://api.github.com/users/drewsonne/events{/privacy}","received_events_url":"https://api.github.com/users/drewsonne/received_events","type":"User","site_admin":false},"body":"We're still using `self._otp` and `self._devices`, so they probably shouldn't be deleted.","created_at":"2018-04-22T06:23:42Z","updated_at":"2018-04-22T06:33:00Z","html_url":"https://github.com/physera/onelogin-aws-cli/pull/96#discussion_r183226691","pull_request_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/comments/183226691"},"html":{"href":"https://github.com/physera/onelogin-aws-cli/pull/96#discussion_r183226691"},"pull_request":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96","id":183248191,"html_url":"https://github.com/physera/onelogin-aws-cli/pull/96","diff_url":"https://github.com/physera/onelogin-aws-cli/pull/96.diff","patch_url":"https://github.com/physera/onelogin-aws-cli/pull/96.patch","issue_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/96","number":96,"state":"open","locked":false,"title":"Get all prompts to use user_choice","user":{"login":"slycoder","id":524989,"avatar_url":"https://avatars0.githubusercontent.com/u/524989?v=4","gravatar_id":"","url":"https://api.github.com/users/slycoder","html_url":"https://github.com/slycoder","followers_url":"https://api.github.com/users/slycoder/followers","following_url":"https://api.github.com/users/slycoder/following{/other_user}","gists_url":"https://api.github.com/users/slycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/slycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slycoder/subscriptions","organizations_url":"https://api.github.com/users/slycoder/orgs","repos_url":"https://api.github.com/users/slycoder/repos","events_url":"https://api.github.com/users/slycoder/events{/privacy}","received_events_url":"https://api.github.com/users/slycoder/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nIn preparation for being able to save prompt selections, this moves more of the prompts to use user_choice.  The function is extended to allow custom renderers, and adds the behavior we have in most prompts (e.g., automatic selection if only one option is available); this way we can kill a bunch of redundant code.\r\n\r\nThis also simplifies the way we store the current device somewhat.\r\n\r\n<!--- Describe your changes in detail -->\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nDoesn't directly resolve any issues, but will handle #62 and #82 eventually.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nSee above\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nUnittests\r\n\r\n## Screenshots (if appropriate):\r\n","created_at":"2018-04-22T00:07:53Z","updated_at":"2018-04-22T06:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8e2efd2de562473fe0196ed942028d238d187d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96/commits","review_comments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96/comments","review_comment_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/96/comments","statuses_url":"https://api.github.com/repos/physera/onelogin-aws-cli/statuses/92b8ae657bf72ee793471a3217ab0c5a23dc1fe4","head":{"label":"physera:user-choice-ification","ref":"user-choice-ification","sha":"92b8ae657bf72ee793471a3217ab0c5a23dc1fe4","user":{"login":"physera","id":20317028,"avatar_url":"https://avatars0.githubusercontent.com/u/20317028?v=4","gravatar_id":"","url":"https://api.github.com/users/physera","html_url":"https://github.com/physera","followers_url":"https://api.github.com/users/physera/followers","following_url":"https://api.github.com/users/physera/following{/other_user}","gists_url":"https://api.github.com/users/physera/gists{/gist_id}","starred_url":"https://api.github.com/users/physera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physera/subscriptions","organizations_url":"https://api.github.com/users/physera/orgs","repos_url":"https://api.github.com/users/physera/repos","events_url":"https://api.github.com/users/physera/events{/privacy}","received_events_url":"https://api.github.com/users/physera/received_events","type":"Organization","site_admin":false},"repo":{"id":85412987,"name":"onelogin-aws-cli","full_name":"physera/onelogin-aws-cli","owner":{"login":"physera","id":20317028,"avatar_url":"https://avatars0.githubusercontent.com/u/20317028?v=4","gravatar_id":"","url":"https://api.github.com/users/physera","html_url":"https://github.com/physera","followers_url":"https://api.github.com/users/physera/followers","following_url":"https://api.github.com/users/physera/following{/other_user}","gists_url":"https://api.github.com/users/physera/gists{/gist_id}","starred_url":"https://api.github.com/users/physera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physera/subscriptions","organizations_url":"https://api.github.com/users/physera/orgs","repos_url":"https://api.github.com/users/physera/repos","events_url":"https://api.github.com/users/physera/events{/privacy}","received_events_url":"https://api.github.com/users/physera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/physera/onelogin-aws-cli","description":"Assume an AWS Role and cache credentials using Onelogin","fork":false,"url":"https://api.github.com/repos/physera/onelogin-aws-cli","forks_url":"https://api.github.com/repos/physera/onelogin-aws-cli/forks","keys_url":"https://api.github.com/repos/physera/onelogin-aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/physera/onelogin-aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/physera/onelogin-aws-cli/teams","hooks_url":"https://api.github.com/repos/physera/onelogin-aws-cli/hooks","issue_events_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/physera/onelogin-aws-cli/events","assignees_url":"https://api.github.com/repos/physera/onelogin-aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/physera/onelogin-aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/physera/onelogin-aws-cli/tags","blobs_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/physera/onelogin-aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/physera/onelogin-aws-cli/languages","stargazers_url":"https://api.github.com/repos/physera/onelogin-aws-cli/stargazers","contributors_url":"https://api.github.com/repos/physera/onelogin-aws-cli/contributors","subscribers_url":"https://api.github.com/repos/physera/onelogin-aws-cli/subscribers","subscription_url":"https://api.github.com/repos/physera/onelogin-aws-cli/subscription","commits_url":"https://api.github.com/repos/physera/onelogin-aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/physera/onelogin-aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/physera/onelogin-aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/physera/onelogin-aws-cli/merges","archive_url":"https://api.github.com/repos/physera/onelogin-aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/physera/onelogin-aws-cli/downloads","issues_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/physera/onelogin-aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/physera/onelogin-aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/physera/onelogin-aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/physera/onelogin-aws-cli/releases{/id}","deployments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/deployments","created_at":"2017-03-18T15:48:33Z","updated_at":"2018-04-21T21:42:48Z","pushed_at":"2018-04-22T00:07:54Z","git_url":"git://github.com/physera/onelogin-aws-cli.git","ssh_url":"git@github.com:physera/onelogin-aws-cli.git","clone_url":"https://github.com/physera/onelogin-aws-cli.git","svn_url":"https://github.com/physera/onelogin-aws-cli","homepage":null,"size":95,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"physera:master","ref":"master","sha":"75287768fe555190b51f452c24c0383ca7045bdc","user":{"login":"physera","id":20317028,"avatar_url":"https://avatars0.githubusercontent.com/u/20317028?v=4","gravatar_id":"","url":"https://api.github.com/users/physera","html_url":"https://github.com/physera","followers_url":"https://api.github.com/users/physera/followers","following_url":"https://api.github.com/users/physera/following{/other_user}","gists_url":"https://api.github.com/users/physera/gists{/gist_id}","starred_url":"https://api.github.com/users/physera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physera/subscriptions","organizations_url":"https://api.github.com/users/physera/orgs","repos_url":"https://api.github.com/users/physera/repos","events_url":"https://api.github.com/users/physera/events{/privacy}","received_events_url":"https://api.github.com/users/physera/received_events","type":"Organization","site_admin":false},"repo":{"id":85412987,"name":"onelogin-aws-cli","full_name":"physera/onelogin-aws-cli","owner":{"login":"physera","id":20317028,"avatar_url":"https://avatars0.githubusercontent.com/u/20317028?v=4","gravatar_id":"","url":"https://api.github.com/users/physera","html_url":"https://github.com/physera","followers_url":"https://api.github.com/users/physera/followers","following_url":"https://api.github.com/users/physera/following{/other_user}","gists_url":"https://api.github.com/users/physera/gists{/gist_id}","starred_url":"https://api.github.com/users/physera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physera/subscriptions","organizations_url":"https://api.github.com/users/physera/orgs","repos_url":"https://api.github.com/users/physera/repos","events_url":"https://api.github.com/users/physera/events{/privacy}","received_events_url":"https://api.github.com/users/physera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/physera/onelogin-aws-cli","description":"Assume an AWS Role and cache credentials using Onelogin","fork":false,"url":"https://api.github.com/repos/physera/onelogin-aws-cli","forks_url":"https://api.github.com/repos/physera/onelogin-aws-cli/forks","keys_url":"https://api.github.com/repos/physera/onelogin-aws-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/physera/onelogin-aws-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/physera/onelogin-aws-cli/teams","hooks_url":"https://api.github.com/repos/physera/onelogin-aws-cli/hooks","issue_events_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/events{/number}","events_url":"https://api.github.com/repos/physera/onelogin-aws-cli/events","assignees_url":"https://api.github.com/repos/physera/onelogin-aws-cli/assignees{/user}","branches_url":"https://api.github.com/repos/physera/onelogin-aws-cli/branches{/branch}","tags_url":"https://api.github.com/repos/physera/onelogin-aws-cli/tags","blobs_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/physera/onelogin-aws-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/physera/onelogin-aws-cli/languages","stargazers_url":"https://api.github.com/repos/physera/onelogin-aws-cli/stargazers","contributors_url":"https://api.github.com/repos/physera/onelogin-aws-cli/contributors","subscribers_url":"https://api.github.com/repos/physera/onelogin-aws-cli/subscribers","subscription_url":"https://api.github.com/repos/physera/onelogin-aws-cli/subscription","commits_url":"https://api.github.com/repos/physera/onelogin-aws-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/physera/onelogin-aws-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/physera/onelogin-aws-cli/contents/{+path}","compare_url":"https://api.github.com/repos/physera/onelogin-aws-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/physera/onelogin-aws-cli/merges","archive_url":"https://api.github.com/repos/physera/onelogin-aws-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/physera/onelogin-aws-cli/downloads","issues_url":"https://api.github.com/repos/physera/onelogin-aws-cli/issues{/number}","pulls_url":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/physera/onelogin-aws-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/physera/onelogin-aws-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/physera/onelogin-aws-cli/labels{/name}","releases_url":"https://api.github.com/repos/physera/onelogin-aws-cli/releases{/id}","deployments_url":"https://api.github.com/repos/physera/onelogin-aws-cli/deployments","created_at":"2017-03-18T15:48:33Z","updated_at":"2018-04-21T21:42:48Z","pushed_at":"2018-04-22T00:07:54Z","git_url":"git://github.com/physera/onelogin-aws-cli.git","ssh_url":"git@github.com:physera/onelogin-aws-cli.git","clone_url":"https://github.com/physera/onelogin-aws-cli.git","svn_url":"https://github.com/physera/onelogin-aws-cli","homepage":null,"size":95,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96"},"html":{"href":"https://github.com/physera/onelogin-aws-cli/pull/96"},"issue":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/96"},"comments":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/physera/onelogin-aws-cli/statuses/92b8ae657bf72ee793471a3217ab0c5a23dc1fe4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drewsonne"}}