{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252","repository_url":"https://api.github.com/repos/w3c/web-roadmaps","labels_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252/comments","events_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252/events","html_url":"https://github.com/w3c/web-roadmaps/pull/252","id":319861666,"number":252,"title":"[Framework] Localize date strings in pages","user":{"login":"tidoust","id":1122927,"avatar_url":"https://avatars2.githubusercontent.com/u/1122927?v=4","gravatar_id":"","url":"https://api.github.com/users/tidoust","html_url":"https://github.com/tidoust","followers_url":"https://api.github.com/users/tidoust/followers","following_url":"https://api.github.com/users/tidoust/following{/other_user}","gists_url":"https://api.github.com/users/tidoust/gists{/gist_id}","starred_url":"https://api.github.com/users/tidoust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidoust/subscriptions","organizations_url":"https://api.github.com/users/tidoust/orgs","repos_url":"https://api.github.com/users/tidoust/repos","events_url":"https://api.github.com/users/tidoust/events{/privacy}","received_events_url":"https://api.github.com/users/tidoust/received_events","type":"User","site_admin":false},"labels":[{"id":736688697,"url":"https://api.github.com/repos/w3c/web-roadmaps/labels/framework","name":"framework","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T10:15:30Z","updated_at":"2018-05-03T11:52:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252","html_url":"https://github.com/w3c/web-roadmaps/pull/252","diff_url":"https://github.com/w3c/web-roadmaps/pull/252.diff","patch_url":"https://github.com/w3c/web-roadmaps/pull/252.patch"},"body":"Last modified dates and publication dates were always formatted in English. They should now be formatted according to the language of the page.\r\n\r\nUnder the hoods, the `toLocaleDateString` method gets used to format the date. Note browsers may only support a subset of locale settings in practice (and may for instance only support locale settings that are actually local to the user), so that mechanism may not always work.\r\n\r\nIn particular, JSDOM, used to generate all roadmap pages in batch, does not seem to support Chinese, so rules for Chinese are hardcoded if JSDOM is detected.\r\n\r\nThis commit is a fix for:\r\nhttps://github.com/w3c/web-roadmaps/issues/213#issuecomment-386197580"},"comment":{"url":"https://api.github.com/repos/w3c/web-roadmaps/issues/comments/386269788","html_url":"https://github.com/w3c/web-roadmaps/pull/252#issuecomment-386269788","issue_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252","id":386269788,"user":{"login":"xfq","id":2863444,"avatar_url":"https://avatars2.githubusercontent.com/u/2863444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfq","html_url":"https://github.com/xfq","followers_url":"https://api.github.com/users/xfq/followers","following_url":"https://api.github.com/users/xfq/following{/other_user}","gists_url":"https://api.github.com/users/xfq/gists{/gist_id}","starred_url":"https://api.github.com/users/xfq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfq/subscriptions","organizations_url":"https://api.github.com/users/xfq/orgs","repos_url":"https://api.github.com/users/xfq/repos","events_url":"https://api.github.com/users/xfq/events{/privacy}","received_events_url":"https://api.github.com/users/xfq/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T11:52:13Z","updated_at":"2018-05-03T11:52:13Z","author_association":"COLLABORATOR","body":"LGTM.\r\n\r\nWe can also switch to [intl](https://www.npmjs.com/package/intl) (which implements ECMA-402) if we would like to support more languages/locales. Merging."}}
{"actor":{"display_login":"xfq"}}