{"action":"created","issue":{"url":"https://api.github.com/repos/open-mpi/ompi/issues/5546","repository_url":"https://api.github.com/repos/open-mpi/ompi","labels_url":"https://api.github.com/repos/open-mpi/ompi/issues/5546/labels{/name}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/5546/comments","events_url":"https://api.github.com/repos/open-mpi/ompi/issues/5546/events","html_url":"https://github.com/open-mpi/ompi/pull/5546","id":350669138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDYxNjAz","number":5546,"title":"Fix the detection of 128 bits atomics.","user":{"login":"bosilca","id":642701,"node_id":"MDQ6VXNlcjY0MjcwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/642701?v=4","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"labels":[{"id":659687073,"node_id":"MDU6TGFiZWw2NTk2ODcwNzM=","url":"https://api.github.com/repos/open-mpi/ompi/labels/Target:%20master","name":"Target: master","color":"fbca04","default":false},{"id":129998417,"node_id":"MDU6TGFiZWwxMjk5OTg0MTc=","url":"https://api.github.com/repos/open-mpi/ompi/labels/blocker","name":"blocker","color":"e11d21","default":false},{"id":129984007,"node_id":"MDU6TGFiZWwxMjk5ODQwMDc=","url":"https://api.github.com/repos/open-mpi/ompi/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"bosilca","id":642701,"node_id":"MDQ6VXNlcjY0MjcwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/642701?v=4","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"assignees":[{"login":"bosilca","id":642701,"node_id":"MDQ6VXNlcjY0MjcwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/642701?v=4","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-15T03:01:11Z","updated_at":"2018-08-15T23:14:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/5546","html_url":"https://github.com/open-mpi/ompi/pull/5546","diff_url":"https://github.com/open-mpi/ompi/pull/5546.diff","patch_url":"https://github.com/open-mpi/ompi/pull/5546.patch"},"body":"Thanks to @flang-cavium for identifying this issue and providing a proof-of-concept patch and a very accurate description of the issue in #5529.\r\n\r\nIt turns out we were missing the check for -latomic to get support for 128-bits atomics. Second we need to unset the local variables (_save) to avoid a conflict in OPAL_CHECK_SYNC_BUILTIN_CSWAP_INT128.\r\n\r\nThis patch might conflict with #5445, they are complementary and should be merged.\r\n\r\nSigned-off-by: George Bosilca <bosilca@icl.utk.edu>"},"comment":{"url":"https://api.github.com/repos/open-mpi/ompi/issues/comments/413368876","html_url":"https://github.com/open-mpi/ompi/pull/5546#issuecomment-413368876","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/5546","id":413368876,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzM2ODg3Ng==","user":{"login":"hjelmn","id":1226817,"node_id":"MDQ6VXNlcjEyMjY4MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1226817?v=4","gravatar_id":"","url":"https://api.github.com/users/hjelmn","html_url":"https://github.com/hjelmn","followers_url":"https://api.github.com/users/hjelmn/followers","following_url":"https://api.github.com/users/hjelmn/following{/other_user}","gists_url":"https://api.github.com/users/hjelmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hjelmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjelmn/subscriptions","organizations_url":"https://api.github.com/users/hjelmn/orgs","repos_url":"https://api.github.com/users/hjelmn/repos","events_url":"https://api.github.com/users/hjelmn/events{/privacy}","received_events_url":"https://api.github.com/users/hjelmn/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T23:14:46Z","updated_at":"2018-08-15T23:14:46Z","author_association":"MEMBER","body":"And you are correct. A compiler may have a lock-free CAS-128 in libatomic so there is no problem with this PR."}}
{"actor":{"display_login":"hjelmn"}}