{"action":"created","issue":{"url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/382","repository_url":"https://api.github.com/repos/jean-emmanuel/open-stage-control","labels_url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/382/comments","events_url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/382/events","html_url":"https://github.com/jean-emmanuel/open-stage-control/pull/382","id":368633666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzY0MDM4","number":382,"title":"WIP  : editor traversing shortcuts","user":{"login":"MartinHN","id":1666045,"node_id":"MDQ6VXNlcjE2NjYwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1666045?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinHN","html_url":"https://github.com/MartinHN","followers_url":"https://api.github.com/users/MartinHN/followers","following_url":"https://api.github.com/users/MartinHN/following{/other_user}","gists_url":"https://api.github.com/users/MartinHN/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHN/subscriptions","organizations_url":"https://api.github.com/users/MartinHN/orgs","repos_url":"https://api.github.com/users/MartinHN/repos","events_url":"https://api.github.com/users/MartinHN/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHN/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-10T12:07:30Z","updated_at":"2018-10-10T12:56:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/pulls/382","html_url":"https://github.com/jean-emmanuel/open-stage-control/pull/382","diff_url":"https://github.com/jean-emmanuel/open-stage-control/pull/382.diff","patch_url":"https://github.com/jean-emmanuel/open-stage-control/pull/382.patch"},"body":"this allow to quickly change selected widget in editor\r\nmostly needed when having panel without label : the panel is \"invisible\" so selecting one or the other has to be done via side panel...\r\n\r\nmod + up/down => edit parent / child\r\nmod + left / right => edit siblings\r\n\r\nthis PR looks functional to me but is still marked as WIP because : \r\n\r\n* the way I have to resolve child objects is kind of hacky because getProps('widgets') return Object (not widgets) without the hash info so I have to identify them by asserting equality with ('id','top','left','right') although even in case of multiple object sharing these, it wont generate bug\r\n\r\n* another way is to use childrenHashes, but its filled with nested childrens too\r\n\r\n* to navigate through siblings i use widget.container.offsetLeft, not sure thats the best though...\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/comments/428560486","html_url":"https://github.com/jean-emmanuel/open-stage-control/pull/382#issuecomment-428560486","issue_url":"https://api.github.com/repos/jean-emmanuel/open-stage-control/issues/382","id":428560486,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODU2MDQ4Ng==","user":{"login":"MartinHN","id":1666045,"node_id":"MDQ6VXNlcjE2NjYwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1666045?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinHN","html_url":"https://github.com/MartinHN","followers_url":"https://api.github.com/users/MartinHN/followers","following_url":"https://api.github.com/users/MartinHN/following{/other_user}","gists_url":"https://api.github.com/users/MartinHN/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHN/subscriptions","organizations_url":"https://api.github.com/users/MartinHN/orgs","repos_url":"https://api.github.com/users/MartinHN/repos","events_url":"https://api.github.com/users/MartinHN/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHN/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T12:56:05Z","updated_at":"2018-10-10T12:56:05Z","author_association":"CONTRIBUTOR","body":"one remaining problem to use this pr at its full potential,\r\nonce a panel is selected, right clicking on it (hovering a widget inside) will trigger selection of the widget inside.\r\nI realize right now thats a bigger conceptual problem. \r\nas right click should allow selecting at the same time,  let me know if you see a way out.\r\nmay be a keyboard shortcut, allowing to trigger context menu for the current selected item"}}
{"actor":{"display_login":"MartinHN"}}