{"action":"created","comment":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/214538842","pull_request_review_id":151618963,"id":214538842,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUzODg0Mg==","diff_hunk":"@@ -540,7 +540,7 @@ def test_http_request_parser_two_slashes(parser):\n \n def test_http_request_parser_bad_method(parser):\n     with pytest.raises(http_exceptions.BadStatusLine):\n-        parser.feed_data(b'!12%()+=~$ /get HTTP/1.1\\r\\n\\r\\n')\n+        parser.feed_data(b'=\":<G>(e),[T];?\" /get HTTP/1.1\\r\\n\\r\\n')","path":"tests/test_http_parser.py","position":5,"original_position":5,"commit_id":"7351a1f9a40bd5cbc2e26bc60e76eaceb58746bf","original_commit_id":"7ac7e4d3c5024187f615bd3202c19e2a302c6e4e","user":{"login":"asvetlov","id":356399,"node_id":"MDQ6VXNlcjM1NjM5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"body":"`with pytest.raises` at least.\r\nPersonally I dont insist on pytest parametrization","created_at":"2018-09-02T12:17:03Z","updated_at":"2018-09-02T12:17:03Z","html_url":"https://github.com/aio-libs/aiohttp/pull/3235#discussion_r214538842","pull_request_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/214538842"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3235#discussion_r214538842"},"pull_request":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235"}},"in_reply_to_id":214536641},"pull_request":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235","id":212576028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTc2MDI4","html_url":"https://github.com/aio-libs/aiohttp/pull/3235","diff_url":"https://github.com/aio-libs/aiohttp/pull/3235.diff","patch_url":"https://github.com/aio-libs/aiohttp/pull/3235.patch","issue_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3235","number":3235,"state":"open","locked":false,"title":"Make METHRE RFC-7230 compliant","user":{"login":"kxepal","id":785983,"node_id":"MDQ6VXNlcjc4NTk4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/785983?v=4","gravatar_id":"","url":"https://api.github.com/users/kxepal","html_url":"https://github.com/kxepal","followers_url":"https://api.github.com/users/kxepal/followers","following_url":"https://api.github.com/users/kxepal/following{/other_user}","gists_url":"https://api.github.com/users/kxepal/gists{/gist_id}","starred_url":"https://api.github.com/users/kxepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxepal/subscriptions","organizations_url":"https://api.github.com/users/kxepal/orgs","repos_url":"https://api.github.com/users/kxepal/repos","events_url":"https://api.github.com/users/kxepal/events{/privacy}","received_events_url":"https://api.github.com/users/kxepal/received_events","type":"User","site_admin":false},"body":"Definition of method is:\r\n```\r\n    method = token\r\n    tchar = \"!\" / \"#\" / \"$\" / \"%\" / \"&\" / \"'\" / \"*\" / \"+\" / \"-\" / \".\" /\r\n            \"^\" / \"_\" / \"`\" / \"|\" / \"~\" / DIGIT / ALPHA\r\n    token = 1*tchar\r\n```\r\n\r\nSo he had two issues:\r\n1. Not all the characters were allowed.\r\n2. Actually, we did allowed too much characters since `$-_` parsed as:\r\n\"all characters in range between code 36 ($) and code 95 (_)\" instead of\r\n\"characters with codes 36, 45 and 95\". So we did match methods like\r\n`[GET]` which are malformed according the spec.\r\n","created_at":"2018-09-02T04:53:25Z","updated_at":"2018-09-02T12:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67dad1446308b412232587bb910cb4f4a1a08ba3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asvetlov","id":356399,"node_id":"MDQ6VXNlcjM1NjM5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235/commits","review_comments_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235/comments","review_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3235/comments","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/7351a1f9a40bd5cbc2e26bc60e76eaceb58746bf","head":{"label":"kxepal:fix-methodre","ref":"fix-methodre","sha":"7351a1f9a40bd5cbc2e26bc60e76eaceb58746bf","user":{"login":"kxepal","id":785983,"node_id":"MDQ6VXNlcjc4NTk4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/785983?v=4","gravatar_id":"","url":"https://api.github.com/users/kxepal","html_url":"https://github.com/kxepal","followers_url":"https://api.github.com/users/kxepal/followers","following_url":"https://api.github.com/users/kxepal/following{/other_user}","gists_url":"https://api.github.com/users/kxepal/gists{/gist_id}","starred_url":"https://api.github.com/users/kxepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxepal/subscriptions","organizations_url":"https://api.github.com/users/kxepal/orgs","repos_url":"https://api.github.com/users/kxepal/repos","events_url":"https://api.github.com/users/kxepal/events{/privacy}","received_events_url":"https://api.github.com/users/kxepal/received_events","type":"User","site_admin":false},"repo":{"id":123023712,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMjM3MTI=","name":"aiohttp","full_name":"kxepal/aiohttp","owner":{"login":"kxepal","id":785983,"node_id":"MDQ6VXNlcjc4NTk4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/785983?v=4","gravatar_id":"","url":"https://api.github.com/users/kxepal","html_url":"https://github.com/kxepal","followers_url":"https://api.github.com/users/kxepal/followers","following_url":"https://api.github.com/users/kxepal/following{/other_user}","gists_url":"https://api.github.com/users/kxepal/gists{/gist_id}","starred_url":"https://api.github.com/users/kxepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxepal/subscriptions","organizations_url":"https://api.github.com/users/kxepal/orgs","repos_url":"https://api.github.com/users/kxepal/repos","events_url":"https://api.github.com/users/kxepal/events{/privacy}","received_events_url":"https://api.github.com/users/kxepal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kxepal/aiohttp","description":"HTTP client/server framework for asyncio ","fork":true,"url":"https://api.github.com/repos/kxepal/aiohttp","forks_url":"https://api.github.com/repos/kxepal/aiohttp/forks","keys_url":"https://api.github.com/repos/kxepal/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kxepal/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kxepal/aiohttp/teams","hooks_url":"https://api.github.com/repos/kxepal/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/kxepal/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/kxepal/aiohttp/events","assignees_url":"https://api.github.com/repos/kxepal/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/kxepal/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/kxepal/aiohttp/tags","blobs_url":"https://api.github.com/repos/kxepal/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kxepal/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kxepal/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kxepal/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kxepal/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/kxepal/aiohttp/languages","stargazers_url":"https://api.github.com/repos/kxepal/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/kxepal/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/kxepal/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/kxepal/aiohttp/subscription","commits_url":"https://api.github.com/repos/kxepal/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kxepal/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kxepal/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kxepal/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kxepal/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/kxepal/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kxepal/aiohttp/merges","archive_url":"https://api.github.com/repos/kxepal/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kxepal/aiohttp/downloads","issues_url":"https://api.github.com/repos/kxepal/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/kxepal/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/kxepal/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/kxepal/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kxepal/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/kxepal/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/kxepal/aiohttp/deployments","created_at":"2018-02-26T20:04:50Z","updated_at":"2018-02-26T20:04:52Z","pushed_at":"2018-09-02T11:23:17Z","git_url":"git://github.com/kxepal/aiohttp.git","ssh_url":"git@github.com:kxepal/aiohttp.git","clone_url":"https://github.com/kxepal/aiohttp.git","svn_url":"https://github.com/kxepal/aiohttp","homepage":"http://docs.aiohttp.org","size":12880,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aio-libs:master","ref":"master","sha":"7b7130274465518f17ae61cb4c6d415f29b6c4da","user":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1ODAzOQ==","name":"aiohttp","full_name":"aio-libs/aiohttp","owner":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aio-libs/aiohttp","description":"HTTP client/server framework for asyncio ","fork":false,"url":"https://api.github.com/repos/aio-libs/aiohttp","forks_url":"https://api.github.com/repos/aio-libs/aiohttp/forks","keys_url":"https://api.github.com/repos/aio-libs/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aiohttp/teams","hooks_url":"https://api.github.com/repos/aio-libs/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aiohttp/events","assignees_url":"https://api.github.com/repos/aio-libs/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aiohttp/tags","blobs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aiohttp/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aiohttp/subscription","commits_url":"https://api.github.com/repos/aio-libs/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aiohttp/merges","archive_url":"https://api.github.com/repos/aio-libs/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aiohttp/downloads","issues_url":"https://api.github.com/repos/aio-libs/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2018-09-02T06:47:26Z","pushed_at":"2018-09-02T11:23:18Z","git_url":"git://github.com/aio-libs/aiohttp.git","ssh_url":"git@github.com:aio-libs/aiohttp.git","clone_url":"https://github.com/aio-libs/aiohttp.git","svn_url":"https://github.com/aio-libs/aiohttp","homepage":"http://docs.aiohttp.org","size":12953,"stargazers_count":5902,"watchers_count":5902,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":926,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":926,"open_issues":158,"watchers":5902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3235"},"issue":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3235"},"comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3235/comments"},"review_comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235/comments"},"review_comment":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3235/commits"},"statuses":{"href":"https://api.github.com/repos/aio-libs/aiohttp/statuses/7351a1f9a40bd5cbc2e26bc60e76eaceb58746bf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asvetlov"}}