{"action":"created","comment":{"url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/comments/197621248","pull_request_review_id":131404249,"id":197621248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYyMTI0OA==","diff_hunk":"@@ -1,19 +0,0 @@\n-<?xml version=\"1.0\"?>\n-<package >\n-  <metadata>\n-    <id>Microsoft.MixedReality.Toolkit.Examples</id>","path":"Assets/MixedRealityToolkit-Examples/MixedReality.Toolkit.Examples.nuspec","position":4,"original_position":4,"commit_id":"d916e531e26874b55e476fcb5acf0d125948bcbc","original_commit_id":"d916e531e26874b55e476fcb5acf0d125948bcbc","user":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"body":"I need to revert this.","created_at":"2018-06-23T19:56:37Z","updated_at":"2018-06-23T19:56:37Z","html_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2#discussion_r197621248","pull_request_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/comments/197621248"},"html":{"href":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2#discussion_r197621248"},"pull_request":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2","id":196916939,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTE2OTM5","html_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2","diff_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2.diff","patch_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2.patch","issue_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/2","number":2,"state":"open","locked":false,"title":"Graph CRs","user":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"body":"~~Updated the Graph to have the latest from MRTK-Version-Next so there will be a lot of changes until you pull that into your local branch.~~\r\n\r\nHigh level overview:\r\n---\r\nRefactored everything, and all that was left in MRTK-Core was the Microsoft.Identity.Client plugins, GraphConnectorProfile.cs, and IGraphAuthentication.cs.\r\n\r\nLow level overview:\r\n---\r\nI ended up removing the custom response types to keep the base classes generic and flexible to dev needs.  I think the examples of how to use the Rest.Response are good, and having them wrapped up the way they were was nice, but somewhat veiled what was actually going on.  As for generic types from JSON, I think that might be a very useful thing to put in the Rest utilities itself. (I might do that in a later PR sometime).\r\n\r\nThe GraphConnector is now a scriptable object to follow our pattern we've been laying out. This enables greater flexibility for developers, as they can have as many GraphConnectors as you'd like and you're able to swap them out at any time.\r\n\r\nI also updated the script icons to match the MRTK and renamed a few classes for clarity.\r\n\r\nTested builds and both .NET and IL2CPP pass with 4.x and Net Standard 2 in master configuration.","created_at":"2018-06-23T19:18:44Z","updated_at":"2018-06-23T19:56:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6f52c166176742bc6b59b8984bce7ac4fdc6c3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2/commits","review_comments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2/comments","review_comment_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/2/comments","statuses_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/statuses/d916e531e26874b55e476fcb5acf0d125948bcbc","head":{"label":"StephenHodgson:MRTK-vNEXT-Graph","ref":"MRTK-vNEXT-Graph","sha":"d916e531e26874b55e476fcb5acf0d125948bcbc","user":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"repo":{"id":106016192,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMTYxOTI=","name":"MixedRealityToolkit-Unity","full_name":"StephenHodgson/MixedRealityToolkit-Unity","owner":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StephenHodgson/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":true,"url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/StephenHodgson/MixedRealityToolkit-Unity/deployments","created_at":"2017-10-06T14:48:10Z","updated_at":"2018-06-03T23:17:47Z","pushed_at":"2018-06-23T19:55:16Z","git_url":"git://github.com/StephenHodgson/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:StephenHodgson/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/StephenHodgson/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/StephenHodgson/MixedRealityToolkit-Unity","homepage":"","size":613620,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"MRTK-vNEXT-Dev"}},"base":{"label":"joaocpaiva:MRTK-Version-Next-GraphToolkit","ref":"MRTK-Version-Next-GraphToolkit","sha":"ce97f3afe37fded354be7b6528f5c796fe603f64","user":{"login":"joaocpaiva","id":24846248,"node_id":"MDQ6VXNlcjI0ODQ2MjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/24846248?v=4","gravatar_id":"","url":"https://api.github.com/users/joaocpaiva","html_url":"https://github.com/joaocpaiva","followers_url":"https://api.github.com/users/joaocpaiva/followers","following_url":"https://api.github.com/users/joaocpaiva/following{/other_user}","gists_url":"https://api.github.com/users/joaocpaiva/gists{/gist_id}","starred_url":"https://api.github.com/users/joaocpaiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaocpaiva/subscriptions","organizations_url":"https://api.github.com/users/joaocpaiva/orgs","repos_url":"https://api.github.com/users/joaocpaiva/repos","events_url":"https://api.github.com/users/joaocpaiva/events{/privacy}","received_events_url":"https://api.github.com/users/joaocpaiva/received_events","type":"User","site_admin":false},"repo":{"id":126214416,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMTQ0MTY=","name":"MixedRealityToolkit-Unity","full_name":"joaocpaiva/MixedRealityToolkit-Unity","owner":{"login":"joaocpaiva","id":24846248,"node_id":"MDQ6VXNlcjI0ODQ2MjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/24846248?v=4","gravatar_id":"","url":"https://api.github.com/users/joaocpaiva","html_url":"https://github.com/joaocpaiva","followers_url":"https://api.github.com/users/joaocpaiva/followers","following_url":"https://api.github.com/users/joaocpaiva/following{/other_user}","gists_url":"https://api.github.com/users/joaocpaiva/gists{/gist_id}","starred_url":"https://api.github.com/users/joaocpaiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaocpaiva/subscriptions","organizations_url":"https://api.github.com/users/joaocpaiva/orgs","repos_url":"https://api.github.com/users/joaocpaiva/repos","events_url":"https://api.github.com/users/joaocpaiva/events{/privacy}","received_events_url":"https://api.github.com/users/joaocpaiva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":true,"url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/deployments","created_at":"2018-03-21T17:12:47Z","updated_at":"2018-05-14T18:45:44Z","pushed_at":"2018-06-23T19:55:17Z","git_url":"git://github.com/joaocpaiva/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:joaocpaiva/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity","homepage":"","size":604570,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2"},"html":{"href":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity/pull/2"},"issue":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/2"},"comments":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/statuses/d916e531e26874b55e476fcb5acf0d125948bcbc"}},"author_association":"NONE"}}
{"actor":{"display_login":"StephenHodgson"}}