{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/5127","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/5127/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/5127/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/5127/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/5127","id":387987703,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzU1ODA1","number":5127,"title":"Add workflow translation id to classification metadata","user":{"login":"mcbouslog","id":12118751,"node_id":"MDQ6VXNlcjEyMTE4NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/12118751?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbouslog","html_url":"https://github.com/mcbouslog","followers_url":"https://api.github.com/users/mcbouslog/followers","following_url":"https://api.github.com/users/mcbouslog/following{/other_user}","gists_url":"https://api.github.com/users/mcbouslog/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbouslog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbouslog/subscriptions","organizations_url":"https://api.github.com/users/mcbouslog/orgs","repos_url":"https://api.github.com/users/mcbouslog/repos","events_url":"https://api.github.com/users/mcbouslog/events{/privacy}","received_events_url":"https://api.github.com/users/mcbouslog/received_events","type":"User","site_admin":false},"labels":[{"id":923145422,"node_id":"MDU6TGFiZWw5MjMxNDU0MjI=","url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/labels/High%20Priority","name":"High Priority","color":"0e8a16","default":false},{"id":231208622,"node_id":"MDU6TGFiZWwyMzEyMDg2MjI=","url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/labels/classifier","name":"classifier","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-05T23:15:29Z","updated_at":"2018-12-06T15:53:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/5127","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/5127","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/5127.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/5127.patch"},"body":"Staging branch URL: https://pr-5127.pfe-preview.zooniverse.org/\r\n\r\nTowards #5125.\r\n\r\n- adds translation resource id to corresponding translations store strings type\r\n- adds action/reducer in classify store to save workflow translation id\r\n- adds workflow translation id to classification metadata at classification creation\r\n- on classify page mount or update sets workflow translation id in classify store\r\n\r\nQuestions\r\n- [ ] **would this record the necessary info so we could search classifications and check for mismatched workflow translations?**\r\n- [ ] I'm unclear how to handle [`loadTranslations`](https://github.com/zooniverse/Panoptes-Front-End/blob/master/app/redux/ducks/translations.js#L151) (vs [`load`](https://github.com/zooniverse/Panoptes-Front-End/blob/master/app/redux/ducks/translations.js#L110) which I think is ok) in the translations duck, but I think this may only be related to `project_pages` (About, Research, etc.) so maybe it's not necessary for now? I think [the workflow translation is always set via load](https://github.com/zooniverse/Panoptes-Front-End/blob/master/app/pages/project/workflow-selection.jsx#L95), not `loadTranslations`, another reason I think ok to pass on for now.\r\n- [ ] add workflow translation id to metadata at classification creation ok? alternative would be at classification completion. \r\n- [ ] preferred default `null`? could be empty string or something else. some of my default/initial settings might not be necessary.\r\n\r\nApologies for the excessive commits, if merging please squash.\r\n\r\n# Required Manual Testing\r\n\r\n- [ ] Does the non-logged in home page render correctly?\r\n- [ ] Does the logged in home page render correctly?\r\n- [ ] Does the projects page render correctly?\r\n- [ ] Can you load project home pages?\r\n- [ ] Can you load the classification page?\r\n- [ ] Can you submit a classification?\r\n- [ ] Does talk load correctly?\r\n- [ ] Can you post a talk comment?\r\n\r\n# Review Checklist\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [ ] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?\r\n- [ ] Are the tests passing locally and on Travis?\r\n\r\n# Optional\r\n\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you [resized and compressed](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/image-optimization) any image you've added?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?\r\n- [ ] Have you followed the [Springer guidelines for commit messages](https://github.com/springernature/frontend-playbook/blob/master/git/git.md#commit-messages)?\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/444920188","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/5127#issuecomment-444920188","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/5127","id":444920188,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDkyMDE4OA==","user":{"login":"mcbouslog","id":12118751,"node_id":"MDQ6VXNlcjEyMTE4NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/12118751?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbouslog","html_url":"https://github.com/mcbouslog","followers_url":"https://api.github.com/users/mcbouslog/followers","following_url":"https://api.github.com/users/mcbouslog/following{/other_user}","gists_url":"https://api.github.com/users/mcbouslog/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbouslog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbouslog/subscriptions","organizations_url":"https://api.github.com/users/mcbouslog/orgs","repos_url":"https://api.github.com/users/mcbouslog/repos","events_url":"https://api.github.com/users/mcbouslog/events{/privacy}","received_events_url":"https://api.github.com/users/mcbouslog/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T15:53:10Z","updated_at":"2018-12-06T15:53:10Z","author_association":"CONTRIBUTOR","body":"I think the action can be removed if saving on completion.\r\n\r\nThis is likely overkill, not necessary, but do we want to save the workflow translation id at creation and then separately at completion? I don't think so, but thought I'd ask."}}
{"actor":{"display_login":"mcbouslog"}}