{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/240194052","pull_request_review_id":183165117,"id":240194052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE5NDA1Mg==","diff_hunk":"@@ -121,7 +121,12 @@ endfunction(glslang_set_link_args)\n # We depend on these for later projects, so they should come first.\n add_subdirectory(External)\n \n-if(NOT TARGET SPIRV-Tools-opt)\n+find_package(PkgConfig)\n+if(PkgConfig_FOUND)\n+    pkg_check_modules(SPIRV-Tools SPIRV-Tools)\n+endif()\n+# Former would be system-installed, later is from External\n+if(NOT SPIRV-Tools_FOUND OR TARGET SPIRV-Tools-opt)","path":"CMakeLists.txt","position":10,"original_position":10,"commit_id":"0062834c63317c83368fe3b2eeee8938c7b4ebb9","original_commit_id":"0062834c63317c83368fe3b2eeee8938c7b4ebb9","user":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"body":"Forgot a `NOT` here, will push a fixup.","created_at":"2018-12-10T12:38:58Z","updated_at":"2018-12-10T12:38:58Z","html_url":"https://github.com/KhronosGroup/glslang/pull/1621#discussion_r240194052","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/240194052"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/1621#discussion_r240194052"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621","id":237297900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Mjk3OTAw","html_url":"https://github.com/KhronosGroup/glslang/pull/1621","diff_url":"https://github.com/KhronosGroup/glslang/pull/1621.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/1621.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/1621","number":1621,"state":"open","locked":false,"title":"CMake: Allow linking against system-installed SPIRV-Tools","user":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"body":"Fixes #1585.\r\n\r\n@kyrios123 Can you confirm that it works for your use case too?\r\n\r\nOutput on my system:\r\n```\r\n+ CFLAGS='-O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables'\r\n+ export CFLAGS\r\n+ CXXFLAGS='-O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables'\r\n+ export CXXFLAGS\r\n+ FFLAGS='-O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables'\r\n+ export FFLAGS\r\n+ LDFLAGS=' -Wl,--as-needed -Wl,-z,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags'\r\n+ export LDFLAGS\r\n+ mkdir -p build\r\n+ cd build\r\n+ /usr/bin/cmake .. -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64 -DCMAKE_INSTALL_LIBEXECDIR:PATH=/usr/libexec -DCMAKE_INSTALL_SYSCONFDIR:PATH=/etc -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-DNDEBUG -DCMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-DNDEBUG -DLIB_SUFFIX=64 -DCMAKE_SKIP_RPATH:BOOL=ON -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON '-DCMAKE_MODULE_LINKER_FLAGS=-Wl,--as-needed -Wl,-z,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags' -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF\r\n-- The C compiler identification is GNU 8.2.1\r\n-- The CXX compiler identification is GNU 8.2.1\r\n-- Check for working C compiler: /usr/bin/cc\r\n-- Check for working C compiler: /usr/bin/cc -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Detecting C compile features\r\n-- Detecting C compile features - done\r\n-- Check for working CXX compiler: /usr/bin/c++\r\n-- Check for working CXX compiler: /usr/bin/c++ -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- Detecting CXX compile features\r\n-- Detecting CXX compile features - done\r\n-- Google Mock was not found - tests based on that will not build\r\n-- Found PkgConfig: /usr/bin/pkg-config (found version \"1.4.2\") \r\n-- Checking for module 'SPIRV-Tools'\r\n--   Found SPIRV-Tools, version 2018.6.1\r\n-- optimizer enabled\r\n-- Configuring done\r\n-- Generating done\r\n```\r\nAnd tests:\r\n```\r\n+ pushd Test\r\n~/Mageia/Sandbox/_rpm/BUILD/glslang-7.10.2984/Test ~/Mageia/Sandbox/_rpm/BUILD/glslang-7.10.2984\r\n+ LD_LIBRARY_PATH=/home/akien/Mageia/Sandbox/_rpm/BUILDROOT/glslang-7.10.2984-1.mga7.x86_64/usr/lib64\r\n+ ./runtests\r\nRunning reflection...\r\nComparing single thread to multithread for all tests in current directory...\r\nRunning entry-point renaming tests\r\nRunning ill-defined uncalled function\r\nTests Succeeded.\r\nRunning explicit stage test and compound suffix tests\r\nRunning hlsl offsets\r\nRunning hlsl offsets\r\nConfiguring HLSL descriptor set and binding number manually\r\nTesting per-descriptor-set IO map shift\r\nTesting SPV no location\r\nTesting SPV Debug Information\r\nTesting Includer\r\nTesting -D and -U\r\nTesting --client and --target-env\r\nspv.targetVulkan.vert\r\nspv.targetOpenGL.vert\r\nspv.targetVulkan.vert\r\nspv.targetVulkan.vert\r\nspv.targetOpenGL.vert\r\nspv.targetVulkan.vert\r\nspv.targetOpenGL.vert\r\nspv.targetVulkan.vert\r\nTesting GLSL entry point rename\r\nTesting remapper error handling\r\nTesting position Y inversion\r\nTesting hlsl_functionality1\r\nTesting HLSL-specific PP feature expansion\r\nTests Succeeded.\r\n```","created_at":"2018-12-10T12:10:43Z","updated_at":"2018-12-10T12:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a77bccdc15d976cc1504e1a05a57b2539f4a3df6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/1621/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/0062834c63317c83368fe3b2eeee8938c7b4ebb9","head":{"label":"akien-mga:system-spirv-tools","ref":"system-spirv-tools","sha":"0062834c63317c83368fe3b2eeee8938c7b4ebb9","user":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"repo":{"id":161151758,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNTE3NTg=","name":"glslang","full_name":"akien-mga/glslang","private":false,"owner":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akien-mga/glslang","description":"Khronos reference front-end for GLSL and ESSL, and sample SPIR-V generator","fork":true,"url":"https://api.github.com/repos/akien-mga/glslang","forks_url":"https://api.github.com/repos/akien-mga/glslang/forks","keys_url":"https://api.github.com/repos/akien-mga/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akien-mga/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akien-mga/glslang/teams","hooks_url":"https://api.github.com/repos/akien-mga/glslang/hooks","issue_events_url":"https://api.github.com/repos/akien-mga/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/akien-mga/glslang/events","assignees_url":"https://api.github.com/repos/akien-mga/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/akien-mga/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/akien-mga/glslang/tags","blobs_url":"https://api.github.com/repos/akien-mga/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akien-mga/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akien-mga/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/akien-mga/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akien-mga/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/akien-mga/glslang/languages","stargazers_url":"https://api.github.com/repos/akien-mga/glslang/stargazers","contributors_url":"https://api.github.com/repos/akien-mga/glslang/contributors","subscribers_url":"https://api.github.com/repos/akien-mga/glslang/subscribers","subscription_url":"https://api.github.com/repos/akien-mga/glslang/subscription","commits_url":"https://api.github.com/repos/akien-mga/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/akien-mga/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/akien-mga/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/akien-mga/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/akien-mga/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/akien-mga/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akien-mga/glslang/merges","archive_url":"https://api.github.com/repos/akien-mga/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akien-mga/glslang/downloads","issues_url":"https://api.github.com/repos/akien-mga/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/akien-mga/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/akien-mga/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/akien-mga/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akien-mga/glslang/labels{/name}","releases_url":"https://api.github.com/repos/akien-mga/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/akien-mga/glslang/deployments","created_at":"2018-12-10T09:42:38Z","updated_at":"2018-12-10T09:42:45Z","pushed_at":"2018-12-10T12:35:07Z","git_url":"git://github.com/akien-mga/glslang.git","ssh_url":"git@github.com:akien-mga/glslang.git","clone_url":"https://github.com/akien-mga/glslang.git","svn_url":"https://github.com/akien-mga/glslang","homepage":"","size":48104,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"dc4fe2d6481f305b403db6f15fe52509a15dc0e8","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"node_id":"MDEwOlJlcG9zaXRvcnkzODA2NDkzMg==","name":"glslang","full_name":"KhronosGroup/glslang","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL, and sample SPIR-V generator","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/glslang/deployments","created_at":"2015-06-25T17:54:39Z","updated_at":"2018-12-08T18:06:31Z","pushed_at":"2018-12-10T12:35:41Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":"","size":48191,"stargazers_count":918,"watchers_count":918,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"archived":false,"open_issues_count":181,"license":null,"forks":293,"open_issues":181,"watchers":918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/1621"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/1621"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/1621/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1621/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/0062834c63317c83368fe3b2eeee8938c7b4ebb9"}},"author_association":"NONE"}}
{"actor":{"display_login":"akien-mga"}}