{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments/198921005","pull_request_review_id":132941527,"id":198921005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODkyMTAwNQ==","diff_hunk":"@@ -39,6 +39,9 @@ type CRDInstallOptions struct {\n \t// CRDs is a list of CRDs to install\n \tCRDs []*apiextensionsv1beta1.CustomResourceDefinition\n \n+\t// ErrorIfPathMissing will cause an error if a Path does not exist\n+\tErrorIfPathMissing bool","path":"pkg/envtest/crd.go","position":5,"original_position":5,"commit_id":"edd907322ed681c3fb576bd1f8d773e566a2feb4","original_commit_id":"edd907322ed681c3fb576bd1f8d773e566a2feb4","user":{"login":"pwittrock","id":7882754,"node_id":"MDQ6VXNlcjc4ODI3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"This is necessary for scaffolded projects without custom resources.  I ran into this when creating a new controller-only project for deployments.  The scaffolded test tried to read the crds, but the directory didn't exist because there were no user defined resources.\r\n","created_at":"2018-06-28T17:22:19Z","updated_at":"2018-06-28T17:22:19Z","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/65#discussion_r198921005","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments/198921005"},"html":{"href":"https://github.com/kubernetes-sigs/controller-runtime/pull/65#discussion_r198921005"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65"}},"in_reply_to_id":198914412},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65","id":197915092,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTE1MDky","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/65","diff_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/65.diff","patch_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/65.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/65","number":65,"state":"open","locked":false,"title":"Don't fail envtest if directory is missing","user":{"login":"pwittrock","id":7882754,"node_id":"MDQ6VXNlcjc4ODI3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-28T04:36:06Z","updated_at":"2018-06-28T17:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25b383d2109b5e2ced2c612defaddfa8d13895b0","assignee":{"login":"droot","id":172029,"node_id":"MDQ6VXNlcjE3MjAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"assignees":[{"login":"droot","id":172029,"node_id":"MDQ6VXNlcjE3MjAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":957854387,"node_id":"MDU6TGFiZWw5NTc4NTQzODc=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":957926585,"node_id":"MDU6TGFiZWw5NTc5MjY1ODU=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/65/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/edd907322ed681c3fb576bd1f8d773e566a2feb4","head":{"label":"pwittrock:operator","ref":"operator","sha":"edd907322ed681c3fb576bd1f8d773e566a2feb4","user":{"login":"pwittrock","id":7882754,"node_id":"MDQ6VXNlcjc4ODI3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"repo":{"id":136500453,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MDA0NTM=","name":"controller-runtime","full_name":"pwittrock/controller-runtime","owner":{"login":"pwittrock","id":7882754,"node_id":"MDQ6VXNlcjc4ODI3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwittrock/controller-runtime","description":"Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)","fork":true,"url":"https://api.github.com/repos/pwittrock/controller-runtime","forks_url":"https://api.github.com/repos/pwittrock/controller-runtime/forks","keys_url":"https://api.github.com/repos/pwittrock/controller-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwittrock/controller-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwittrock/controller-runtime/teams","hooks_url":"https://api.github.com/repos/pwittrock/controller-runtime/hooks","issue_events_url":"https://api.github.com/repos/pwittrock/controller-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/pwittrock/controller-runtime/events","assignees_url":"https://api.github.com/repos/pwittrock/controller-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/pwittrock/controller-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/pwittrock/controller-runtime/tags","blobs_url":"https://api.github.com/repos/pwittrock/controller-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwittrock/controller-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwittrock/controller-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwittrock/controller-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwittrock/controller-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/pwittrock/controller-runtime/languages","stargazers_url":"https://api.github.com/repos/pwittrock/controller-runtime/stargazers","contributors_url":"https://api.github.com/repos/pwittrock/controller-runtime/contributors","subscribers_url":"https://api.github.com/repos/pwittrock/controller-runtime/subscribers","subscription_url":"https://api.github.com/repos/pwittrock/controller-runtime/subscription","commits_url":"https://api.github.com/repos/pwittrock/controller-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwittrock/controller-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwittrock/controller-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwittrock/controller-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwittrock/controller-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/pwittrock/controller-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwittrock/controller-runtime/merges","archive_url":"https://api.github.com/repos/pwittrock/controller-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwittrock/controller-runtime/downloads","issues_url":"https://api.github.com/repos/pwittrock/controller-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/pwittrock/controller-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/pwittrock/controller-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/pwittrock/controller-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwittrock/controller-runtime/labels{/name}","releases_url":"https://api.github.com/repos/pwittrock/controller-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/pwittrock/controller-runtime/deployments","created_at":"2018-06-07T15:56:59Z","updated_at":"2018-06-17T17:32:55Z","pushed_at":"2018-06-28T04:35:24Z","git_url":"git://github.com/pwittrock/controller-runtime.git","ssh_url":"git@github.com:pwittrock/controller-runtime.git","clone_url":"https://github.com/pwittrock/controller-runtime.git","svn_url":"https://github.com/pwittrock/controller-runtime","homepage":null,"size":20808,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"875e0e1f8d3fd831a8fbe6ac5fcb23bd952dccbf","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":136494223,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0OTQyMjM=","name":"controller-runtime","full_name":"kubernetes-sigs/controller-runtime","owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/controller-runtime","description":"Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime","forks_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/deployments","created_at":"2018-06-07T15:08:03Z","updated_at":"2018-06-28T16:52:24Z","pushed_at":"2018-06-28T16:52:22Z","git_url":"git://github.com/kubernetes-sigs/controller-runtime.git","ssh_url":"git@github.com:kubernetes-sigs/controller-runtime.git","clone_url":"https://github.com/kubernetes-sigs/controller-runtime.git","svn_url":"https://github.com/kubernetes-sigs/controller-runtime","homepage":null,"size":20841,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65"},"html":{"href":"https://github.com/kubernetes-sigs/controller-runtime/pull/65"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/65"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/edd907322ed681c3fb576bd1f8d773e566a2feb4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pwittrock"}}