{"action":"created","comment":{"url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/comments/212175299","pull_request_review_id":148747645,"id":212175299,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjE3NTI5OQ==","diff_hunk":"@@ -27,10 +27,13 @@ def headers(callname)\n   end\n \n   def errors_for(response)\n-    [response.dig(\"errorMessage\", \"error\")]\n-      .flatten\n-      .compact\n-      .map { |err| [err[\"severity\"], err[\"errorId\"], err[\"message\"]] }\n+    [response.dig(\"errorMessage\", \"error\")].flatten.compact.map do |error|\n+      EbayRequest::ErrorItem.new(","path":"lib/ebay_request/finding.rb","position":9,"original_position":9,"commit_id":"8d847ff5aca614235b10839dabd73240b2face8b","original_commit_id":"8d847ff5aca614235b10839dabd73240b2face8b","user":{"login":"nepalez","id":1526628,"node_id":"MDQ6VXNlcjE1MjY2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/1526628?v=4","gravatar_id":"","url":"https://api.github.com/users/nepalez","html_url":"https://github.com/nepalez","followers_url":"https://api.github.com/users/nepalez/followers","following_url":"https://api.github.com/users/nepalez/following{/other_user}","gists_url":"https://api.github.com/users/nepalez/gists{/gist_id}","starred_url":"https://api.github.com/users/nepalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nepalez/subscriptions","organizations_url":"https://api.github.com/users/nepalez/orgs","repos_url":"https://api.github.com/users/nepalez/repos","events_url":"https://api.github.com/users/nepalez/events{/privacy}","received_events_url":"https://api.github.com/users/nepalez/received_events","type":"User","site_admin":false},"body":"With dry-initializer-based item you can use just:\r\n\r\n```ruby\r\nEbayRequest::ErrorItem.new(error)\r\n```","created_at":"2018-08-23T03:48:58Z","updated_at":"2018-08-23T03:50:38Z","html_url":"https://github.com/gzigzigzeo/ebay_request/pull/19#discussion_r212175299","pull_request_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/comments/212175299"},"html":{"href":"https://github.com/gzigzigzeo/ebay_request/pull/19#discussion_r212175299"},"pull_request":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19","id":203557176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTU3MTc2","html_url":"https://github.com/gzigzigzeo/ebay_request/pull/19","diff_url":"https://github.com/gzigzigzeo/ebay_request/pull/19.diff","patch_url":"https://github.com/gzigzigzeo/ebay_request/pull/19.patch","issue_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/19","number":19,"state":"open","locked":false,"title":"Rework errors to store code, message, severity, and variable parts","user":{"login":"Envek","id":264400,"node_id":"MDQ6VXNlcjI2NDQwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/264400?v=4","gravatar_id":"","url":"https://api.github.com/users/Envek","html_url":"https://github.com/Envek","followers_url":"https://api.github.com/users/Envek/followers","following_url":"https://api.github.com/users/Envek/following{/other_user}","gists_url":"https://api.github.com/users/Envek/gists{/gist_id}","starred_url":"https://api.github.com/users/Envek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Envek/subscriptions","organizations_url":"https://api.github.com/users/Envek/orgs","repos_url":"https://api.github.com/users/Envek/repos","events_url":"https://api.github.com/users/Envek/events{/privacy}","received_events_url":"https://api.github.com/users/Envek/received_events","type":"User","site_admin":false},"body":"To support translation of error messages\r\n\r\nError params stores names of specifics, amounts of money, etc.\r\n\r\nI've bumped version as this is breaking change. The way of how errors stored inside exceptions is changed.","created_at":"2018-07-24T14:58:25Z","updated_at":"2018-08-23T03:50:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"335feceb93ff198cfd448eb6a7c9de2ad86022ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19/commits","review_comments_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19/comments","review_comment_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/19/comments","statuses_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/statuses/8d847ff5aca614235b10839dabd73240b2face8b","head":{"label":"Envek:store-message-params-in-errors","ref":"store-message-params-in-errors","sha":"8d847ff5aca614235b10839dabd73240b2face8b","user":{"login":"Envek","id":264400,"node_id":"MDQ6VXNlcjI2NDQwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/264400?v=4","gravatar_id":"","url":"https://api.github.com/users/Envek","html_url":"https://github.com/Envek","followers_url":"https://api.github.com/users/Envek/followers","following_url":"https://api.github.com/users/Envek/following{/other_user}","gists_url":"https://api.github.com/users/Envek/gists{/gist_id}","starred_url":"https://api.github.com/users/Envek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Envek/subscriptions","organizations_url":"https://api.github.com/users/Envek/orgs","repos_url":"https://api.github.com/users/Envek/repos","events_url":"https://api.github.com/users/Envek/events{/privacy}","received_events_url":"https://api.github.com/users/Envek/received_events","type":"User","site_admin":false},"repo":{"id":93840593,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg0MDU5Mw==","name":"ebay_request","full_name":"Envek/ebay_request","owner":{"login":"Envek","id":264400,"node_id":"MDQ6VXNlcjI2NDQwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/264400?v=4","gravatar_id":"","url":"https://api.github.com/users/Envek","html_url":"https://github.com/Envek","followers_url":"https://api.github.com/users/Envek/followers","following_url":"https://api.github.com/users/Envek/following{/other_user}","gists_url":"https://api.github.com/users/Envek/gists{/gist_id}","starred_url":"https://api.github.com/users/Envek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Envek/subscriptions","organizations_url":"https://api.github.com/users/Envek/orgs","repos_url":"https://api.github.com/users/Envek/repos","events_url":"https://api.github.com/users/Envek/events{/privacy}","received_events_url":"https://api.github.com/users/Envek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Envek/ebay_request","description":"eBay API request interface","fork":true,"url":"https://api.github.com/repos/Envek/ebay_request","forks_url":"https://api.github.com/repos/Envek/ebay_request/forks","keys_url":"https://api.github.com/repos/Envek/ebay_request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Envek/ebay_request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Envek/ebay_request/teams","hooks_url":"https://api.github.com/repos/Envek/ebay_request/hooks","issue_events_url":"https://api.github.com/repos/Envek/ebay_request/issues/events{/number}","events_url":"https://api.github.com/repos/Envek/ebay_request/events","assignees_url":"https://api.github.com/repos/Envek/ebay_request/assignees{/user}","branches_url":"https://api.github.com/repos/Envek/ebay_request/branches{/branch}","tags_url":"https://api.github.com/repos/Envek/ebay_request/tags","blobs_url":"https://api.github.com/repos/Envek/ebay_request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Envek/ebay_request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Envek/ebay_request/git/refs{/sha}","trees_url":"https://api.github.com/repos/Envek/ebay_request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Envek/ebay_request/statuses/{sha}","languages_url":"https://api.github.com/repos/Envek/ebay_request/languages","stargazers_url":"https://api.github.com/repos/Envek/ebay_request/stargazers","contributors_url":"https://api.github.com/repos/Envek/ebay_request/contributors","subscribers_url":"https://api.github.com/repos/Envek/ebay_request/subscribers","subscription_url":"https://api.github.com/repos/Envek/ebay_request/subscription","commits_url":"https://api.github.com/repos/Envek/ebay_request/commits{/sha}","git_commits_url":"https://api.github.com/repos/Envek/ebay_request/git/commits{/sha}","comments_url":"https://api.github.com/repos/Envek/ebay_request/comments{/number}","issue_comment_url":"https://api.github.com/repos/Envek/ebay_request/issues/comments{/number}","contents_url":"https://api.github.com/repos/Envek/ebay_request/contents/{+path}","compare_url":"https://api.github.com/repos/Envek/ebay_request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Envek/ebay_request/merges","archive_url":"https://api.github.com/repos/Envek/ebay_request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Envek/ebay_request/downloads","issues_url":"https://api.github.com/repos/Envek/ebay_request/issues{/number}","pulls_url":"https://api.github.com/repos/Envek/ebay_request/pulls{/number}","milestones_url":"https://api.github.com/repos/Envek/ebay_request/milestones{/number}","notifications_url":"https://api.github.com/repos/Envek/ebay_request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Envek/ebay_request/labels{/name}","releases_url":"https://api.github.com/repos/Envek/ebay_request/releases{/id}","deployments_url":"https://api.github.com/repos/Envek/ebay_request/deployments","created_at":"2017-06-09T09:07:27Z","updated_at":"2017-06-09T09:07:28Z","pushed_at":"2018-07-24T14:19:04Z","git_url":"git://github.com/Envek/ebay_request.git","ssh_url":"git@github.com:Envek/ebay_request.git","clone_url":"https://github.com/Envek/ebay_request.git","svn_url":"https://github.com/Envek/ebay_request","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gzigzigzeo:master","ref":"master","sha":"135d57a0275be10091f67dd6a361c7c225b08f67","user":{"login":"gzigzigzeo","id":27830,"node_id":"MDQ6VXNlcjI3ODMw","avatar_url":"https://avatars0.githubusercontent.com/u/27830?v=4","gravatar_id":"","url":"https://api.github.com/users/gzigzigzeo","html_url":"https://github.com/gzigzigzeo","followers_url":"https://api.github.com/users/gzigzigzeo/followers","following_url":"https://api.github.com/users/gzigzigzeo/following{/other_user}","gists_url":"https://api.github.com/users/gzigzigzeo/gists{/gist_id}","starred_url":"https://api.github.com/users/gzigzigzeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzigzigzeo/subscriptions","organizations_url":"https://api.github.com/users/gzigzigzeo/orgs","repos_url":"https://api.github.com/users/gzigzigzeo/repos","events_url":"https://api.github.com/users/gzigzigzeo/events{/privacy}","received_events_url":"https://api.github.com/users/gzigzigzeo/received_events","type":"User","site_admin":false},"repo":{"id":55236208,"node_id":"MDEwOlJlcG9zaXRvcnk1NTIzNjIwOA==","name":"ebay_request","full_name":"gzigzigzeo/ebay_request","owner":{"login":"gzigzigzeo","id":27830,"node_id":"MDQ6VXNlcjI3ODMw","avatar_url":"https://avatars0.githubusercontent.com/u/27830?v=4","gravatar_id":"","url":"https://api.github.com/users/gzigzigzeo","html_url":"https://github.com/gzigzigzeo","followers_url":"https://api.github.com/users/gzigzigzeo/followers","following_url":"https://api.github.com/users/gzigzigzeo/following{/other_user}","gists_url":"https://api.github.com/users/gzigzigzeo/gists{/gist_id}","starred_url":"https://api.github.com/users/gzigzigzeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzigzigzeo/subscriptions","organizations_url":"https://api.github.com/users/gzigzigzeo/orgs","repos_url":"https://api.github.com/users/gzigzigzeo/repos","events_url":"https://api.github.com/users/gzigzigzeo/events{/privacy}","received_events_url":"https://api.github.com/users/gzigzigzeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gzigzigzeo/ebay_request","description":"eBay API request interface","fork":false,"url":"https://api.github.com/repos/gzigzigzeo/ebay_request","forks_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/forks","keys_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/teams","hooks_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/hooks","issue_events_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/events{/number}","events_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/events","assignees_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/assignees{/user}","branches_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/branches{/branch}","tags_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/tags","blobs_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/git/refs{/sha}","trees_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/statuses/{sha}","languages_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/languages","stargazers_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/stargazers","contributors_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/contributors","subscribers_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/subscribers","subscription_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/subscription","commits_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/commits{/sha}","git_commits_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/git/commits{/sha}","comments_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/comments{/number}","issue_comment_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/comments{/number}","contents_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/contents/{+path}","compare_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/merges","archive_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/downloads","issues_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues{/number}","pulls_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls{/number}","milestones_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/milestones{/number}","notifications_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/labels{/name}","releases_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/releases{/id}","deployments_url":"https://api.github.com/repos/gzigzigzeo/ebay_request/deployments","created_at":"2016-04-01T13:56:12Z","updated_at":"2018-07-23T14:51:35Z","pushed_at":"2018-08-01T11:59:54Z","git_url":"git://github.com/gzigzigzeo/ebay_request.git","ssh_url":"git@github.com:gzigzigzeo/ebay_request.git","clone_url":"https://github.com/gzigzigzeo/ebay_request.git","svn_url":"https://github.com/gzigzigzeo/ebay_request","homepage":null,"size":114,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19"},"html":{"href":"https://github.com/gzigzigzeo/ebay_request/pull/19"},"issue":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/19"},"comments":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/gzigzigzeo/ebay_request/statuses/8d847ff5aca614235b10839dabd73240b2face8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nepalez"}}