{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/cli-build-app/pulls/comments/201148345","pull_request_review_id":135594141,"id":201148345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE0ODM0NQ==","diff_hunk":"@@ -0,0 +1,17 @@\n+import { WebAppIcon, WebAppManifest } from '../interfaces';","path":"src/util/pwa.ts","position":null,"original_position":1,"commit_id":"07bd2acb47577b12de8426df94f61bc23c42ed43","original_commit_id":"3d708b2d3c31b590a7b981ea294f04d5d3c4480e","user":{"login":"mwistrand","id":3423657,"node_id":"MDQ6VXNlcjM0MjM2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3423657?v=4","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"body":"That's a good point; that function is simple enough that it can be inlined.","created_at":"2018-07-09T21:11:06Z","updated_at":"2018-07-09T21:11:06Z","html_url":"https://github.com/dojo/cli-build-app/pull/108#discussion_r201148345","pull_request_url":"https://api.github.com/repos/dojo/cli-build-app/pulls/108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/comments/201148345"},"html":{"href":"https://github.com/dojo/cli-build-app/pull/108#discussion_r201148345"},"pull_request":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/108"}},"in_reply_to_id":201131558},"pull_request":{"url":"https://api.github.com/repos/dojo/cli-build-app/pulls/108","id":200189370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTg5Mzcw","html_url":"https://github.com/dojo/cli-build-app/pull/108","diff_url":"https://github.com/dojo/cli-build-app/pull/108.diff","patch_url":"https://github.com/dojo/cli-build-app/pull/108.patch","issue_url":"https://api.github.com/repos/dojo/cli-build-app/issues/108","number":108,"state":"open","locked":false,"title":"Inject Apple PWA meta tags into index.html","user":{"login":"mwistrand","id":3423657,"node_id":"MDQ6VXNlcjM0MjM2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3423657?v=4","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"body":"Resolves #96, and tested both on Windows and macOS with a simple sandbox application created with `@dojo/cli-create-app`.\r\n\r\n- Updates webpack-pwa-manifest to the latests version and adds the new \"ios\" flag to its options so that Apple-specific meta tags are added to index.html.\r\n- Moves the webpack-pwa-manifest plugin invocation out of base.config and into dev.config and dist.config, both to ensure that is applied after the html-webpack-plugin and to prevent it from running in test mode.\r\n- Updates the `pwa.manifest` section of the README.","created_at":"2018-07-09T18:56:31Z","updated_at":"2018-07-09T21:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d029e4214b5e9d2c1d7844f9f3751fa7c436827","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/cli-build-app/pulls/108/commits","review_comments_url":"https://api.github.com/repos/dojo/cli-build-app/pulls/108/comments","review_comment_url":"https://api.github.com/repos/dojo/cli-build-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/cli-build-app/issues/108/comments","statuses_url":"https://api.github.com/repos/dojo/cli-build-app/statuses/07bd2acb47577b12de8426df94f61bc23c42ed43","head":{"label":"mwistrand:96-apple-touch-icon","ref":"96-apple-touch-icon","sha":"07bd2acb47577b12de8426df94f61bc23c42ed43","user":{"login":"mwistrand","id":3423657,"node_id":"MDQ6VXNlcjM0MjM2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3423657?v=4","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"repo":{"id":112789181,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3ODkxODE=","name":"cli-build-app","full_name":"mwistrand/cli-build-app","owner":{"login":"mwistrand","id":3423657,"node_id":"MDQ6VXNlcjM0MjM2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3423657?v=4","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwistrand/cli-build-app","description":"Command for building Dojo 2 applications","fork":true,"url":"https://api.github.com/repos/mwistrand/cli-build-app","forks_url":"https://api.github.com/repos/mwistrand/cli-build-app/forks","keys_url":"https://api.github.com/repos/mwistrand/cli-build-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwistrand/cli-build-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwistrand/cli-build-app/teams","hooks_url":"https://api.github.com/repos/mwistrand/cli-build-app/hooks","issue_events_url":"https://api.github.com/repos/mwistrand/cli-build-app/issues/events{/number}","events_url":"https://api.github.com/repos/mwistrand/cli-build-app/events","assignees_url":"https://api.github.com/repos/mwistrand/cli-build-app/assignees{/user}","branches_url":"https://api.github.com/repos/mwistrand/cli-build-app/branches{/branch}","tags_url":"https://api.github.com/repos/mwistrand/cli-build-app/tags","blobs_url":"https://api.github.com/repos/mwistrand/cli-build-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwistrand/cli-build-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwistrand/cli-build-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwistrand/cli-build-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwistrand/cli-build-app/statuses/{sha}","languages_url":"https://api.github.com/repos/mwistrand/cli-build-app/languages","stargazers_url":"https://api.github.com/repos/mwistrand/cli-build-app/stargazers","contributors_url":"https://api.github.com/repos/mwistrand/cli-build-app/contributors","subscribers_url":"https://api.github.com/repos/mwistrand/cli-build-app/subscribers","subscription_url":"https://api.github.com/repos/mwistrand/cli-build-app/subscription","commits_url":"https://api.github.com/repos/mwistrand/cli-build-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwistrand/cli-build-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwistrand/cli-build-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwistrand/cli-build-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwistrand/cli-build-app/contents/{+path}","compare_url":"https://api.github.com/repos/mwistrand/cli-build-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwistrand/cli-build-app/merges","archive_url":"https://api.github.com/repos/mwistrand/cli-build-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwistrand/cli-build-app/downloads","issues_url":"https://api.github.com/repos/mwistrand/cli-build-app/issues{/number}","pulls_url":"https://api.github.com/repos/mwistrand/cli-build-app/pulls{/number}","milestones_url":"https://api.github.com/repos/mwistrand/cli-build-app/milestones{/number}","notifications_url":"https://api.github.com/repos/mwistrand/cli-build-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwistrand/cli-build-app/labels{/name}","releases_url":"https://api.github.com/repos/mwistrand/cli-build-app/releases{/id}","deployments_url":"https://api.github.com/repos/mwistrand/cli-build-app/deployments","created_at":"2017-12-01T21:34:59Z","updated_at":"2018-07-09T15:09:14Z","pushed_at":"2018-07-09T21:10:40Z","git_url":"git://github.com/mwistrand/cli-build-app.git","ssh_url":"git@github.com:mwistrand/cli-build-app.git","clone_url":"https://github.com/mwistrand/cli-build-app.git","svn_url":"https://github.com/mwistrand/cli-build-app","homepage":null,"size":12050,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"4ef517ef0f554744e4b8a1241686287744946eff","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":111814339,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MTQzMzk=","name":"cli-build-app","full_name":"dojo/cli-build-app","owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/cli-build-app","description":"Command for building Dojo 2 applications","fork":false,"url":"https://api.github.com/repos/dojo/cli-build-app","forks_url":"https://api.github.com/repos/dojo/cli-build-app/forks","keys_url":"https://api.github.com/repos/dojo/cli-build-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/cli-build-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/cli-build-app/teams","hooks_url":"https://api.github.com/repos/dojo/cli-build-app/hooks","issue_events_url":"https://api.github.com/repos/dojo/cli-build-app/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/cli-build-app/events","assignees_url":"https://api.github.com/repos/dojo/cli-build-app/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/cli-build-app/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/cli-build-app/tags","blobs_url":"https://api.github.com/repos/dojo/cli-build-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/cli-build-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/cli-build-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/cli-build-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/cli-build-app/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/cli-build-app/languages","stargazers_url":"https://api.github.com/repos/dojo/cli-build-app/stargazers","contributors_url":"https://api.github.com/repos/dojo/cli-build-app/contributors","subscribers_url":"https://api.github.com/repos/dojo/cli-build-app/subscribers","subscription_url":"https://api.github.com/repos/dojo/cli-build-app/subscription","commits_url":"https://api.github.com/repos/dojo/cli-build-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/cli-build-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/cli-build-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/cli-build-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/cli-build-app/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/cli-build-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/cli-build-app/merges","archive_url":"https://api.github.com/repos/dojo/cli-build-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/cli-build-app/downloads","issues_url":"https://api.github.com/repos/dojo/cli-build-app/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/cli-build-app/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/cli-build-app/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/cli-build-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/cli-build-app/labels{/name}","releases_url":"https://api.github.com/repos/dojo/cli-build-app/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/cli-build-app/deployments","created_at":"2017-11-23T13:44:22Z","updated_at":"2018-07-06T10:36:03Z","pushed_at":"2018-07-09T21:10:42Z","git_url":"git://github.com/dojo/cli-build-app.git","ssh_url":"git@github.com:dojo/cli-build-app.git","clone_url":"https://github.com/dojo/cli-build-app.git","svn_url":"https://github.com/dojo/cli-build-app","homepage":null,"size":11513,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":27,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/108"},"html":{"href":"https://github.com/dojo/cli-build-app/pull/108"},"issue":{"href":"https://api.github.com/repos/dojo/cli-build-app/issues/108"},"comments":{"href":"https://api.github.com/repos/dojo/cli-build-app/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/cli-build-app/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/cli-build-app/statuses/07bd2acb47577b12de8426df94f61bc23c42ed43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mwistrand"}}