{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/3563","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3563/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3563/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3563/events","html_url":"https://github.com/mne-tools/mne-python/pull/3563","id":174756667,"node_id":"MDExOlB1bGxSZXF1ZXN0ODM3OTkyMzU=","number":3563,"title":"WIP: refactor XDawn to use rERP","user":{"login":"jona-sassenhagen","id":4321826,"node_id":"MDQ6VXNlcjQzMjE4MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/4321826?v=4","gravatar_id":"","url":"https://api.github.com/users/jona-sassenhagen","html_url":"https://github.com/jona-sassenhagen","followers_url":"https://api.github.com/users/jona-sassenhagen/followers","following_url":"https://api.github.com/users/jona-sassenhagen/following{/other_user}","gists_url":"https://api.github.com/users/jona-sassenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/jona-sassenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jona-sassenhagen/subscriptions","organizations_url":"https://api.github.com/users/jona-sassenhagen/orgs","repos_url":"https://api.github.com/users/jona-sassenhagen/repos","events_url":"https://api.github.com/users/jona-sassenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/jona-sassenhagen/received_events","type":"User","site_admin":false},"labels":[{"id":106206066,"node_id":"MDU6TGFiZWwxMDYyMDYwNjY=","url":"https://api.github.com/repos/mne-tools/mne-python/labels/mne%20sprint","name":"mne sprint","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":53,"created_at":"2016-09-02T13:12:50Z","updated_at":"2018-07-30T16:47:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3563","html_url":"https://github.com/mne-tools/mne-python/pull/3563","diff_url":"https://github.com/mne-tools/mne-python/pull/3563.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3563.patch"},"body":"Internally, XDawn and linear_regression_raw (rERP) do basically the same thing. rERP is currently set up to do some things that aren't required of XDawn (particularly continuous predictors), so it makes sense to have XDawn call rERP \"under the hood\" instead of the reverse. This PR begins to do so.\n\nI assume a bunch of stuff doesn't work so far, but at least _some_ tests pass and the main example works:\n\n![screen shot 2016-09-02 at 15 10 34](https://cloud.githubusercontent.com/assets/4321826/18204936/b17ae106-711f-11e6-987f-d469b7aad208.png)\n\ncloses #2332\nAn issue over 1 year old!\n\n@alexandrebarachant  @kingjr \n"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/408931880","html_url":"https://github.com/mne-tools/mne-python/pull/3563#issuecomment-408931880","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3563","id":408931880,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODkzMTg4MA==","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T16:47:34Z","updated_at":"2018-07-30T16:47:34Z","author_association":"MEMBER","body":"There is a `linalg.pinv` in the `_least_square_evoked` step, I was thinking of a subsequent call to `linalg.eigh`... So should `_least_square_evoked` be used by both / do the same things?"}}
{"actor":{"display_login":"larsoner"}}