{"action":"opened","number":2013,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013","id":176253484,"html_url":"https://github.com/snapcore/snapcraft/pull/2013","diff_url":"https://github.com/snapcore/snapcraft/pull/2013.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2013.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2013","number":2013,"state":"open","locked":false,"title":"tests: run tests on Trusty on Travis","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh unit`?\r\n\r\n-----\r\nThis PR adds a stage to Travis for running `tests/integration/general`, `tests/integration/store` and `tests.integration.plugins_catkin` on **Trusty** natively - due to [LP: #1628289](https://bugs.launchpad.net/snappy/+bug/1628289/comments/18) we can't use a Trusty container.\r\nThe script `tools/travis/run_tests.sh` gains a new optional **image** argument which can currently be `ubuntu:xenial` (the default) or `native` to run the tests on the host.\r\n\r\n**Note on testing**: As follows I did some sanity checks. But since this PR is using Travis to pull in Python 3.6, tests won't run properly out of the box on Trusty.\r\n\r\nI locally tested the scripts like so, on a Trusty VM and Xenial:\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit ubuntu:xenial`\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit native`\r\n\r\nManual test steps:\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit ubuntu:trusty`\r\n - Observe `Invalid image: ubuntu:trusty`\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit ubuntu:xenial`\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit`\r\n - `sudo -H ./tools/travis/run_tests.sh tests/unit native`\r\n\r\n**Note:** Run these commands before each attempt at running the non-native tests if you're not running from a new machine. Stop any other containers that you may have running, otherwise removing the network device will fail - errors `not found` and `The device doesn't exist` are safe to ignore.\r\n - `lxc delete --force test-runner; lxc network delete testbr0; lxc profile device remove default eth0`","created_at":"2018-03-20T16:44:25Z","updated_at":"2018-03-20T16:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2013/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/5c20598742f8ae568c4adbed1d96ad6f0d7cec65","head":{"label":"kalikiana:travis-trusty-py3.6","ref":"travis-trusty-py3.6","sha":"5c20598742f8ae568c4adbed1d96ad6f0d7cec65","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"repo":{"id":73799360,"name":"snapcraft","full_name":"kalikiana/snapcraft","owner":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalikiana/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/kalikiana/snapcraft","forks_url":"https://api.github.com/repos/kalikiana/snapcraft/forks","keys_url":"https://api.github.com/repos/kalikiana/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalikiana/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalikiana/snapcraft/teams","hooks_url":"https://api.github.com/repos/kalikiana/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/kalikiana/snapcraft/events","assignees_url":"https://api.github.com/repos/kalikiana/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/kalikiana/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/kalikiana/snapcraft/tags","blobs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalikiana/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalikiana/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalikiana/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/kalikiana/snapcraft/languages","stargazers_url":"https://api.github.com/repos/kalikiana/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/kalikiana/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/kalikiana/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/kalikiana/snapcraft/subscription","commits_url":"https://api.github.com/repos/kalikiana/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalikiana/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalikiana/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalikiana/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/kalikiana/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalikiana/snapcraft/merges","archive_url":"https://api.github.com/repos/kalikiana/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalikiana/snapcraft/downloads","issues_url":"https://api.github.com/repos/kalikiana/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/kalikiana/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/kalikiana/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/kalikiana/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalikiana/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/kalikiana/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/kalikiana/snapcraft/deployments","created_at":"2016-11-15T09:45:46Z","updated_at":"2016-11-15T09:45:48Z","pushed_at":"2018-03-20T16:40:39Z","git_url":"git://github.com/kalikiana/snapcraft.git","ssh_url":"git@github.com:kalikiana/snapcraft.git","clone_url":"https://github.com/kalikiana/snapcraft.git","svn_url":"https://github.com/kalikiana/snapcraft","homepage":null,"size":9815,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"c22d7e253abd07fc745ee48ca02c81f90608170a","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2018-03-19T23:47:52Z","pushed_at":"2018-03-20T16:39:30Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":9191,"stargazers_count":544,"watchers_count":544,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":244,"open_issues":91,"watchers":544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2013"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2013"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2013/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2013/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/5c20598742f8ae568c4adbed1d96ad6f0d7cec65"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":39,"deletions":17,"changed_files":2}}
{"actor":{"display_login":"kalikiana"}}