{"action":"created","comment":{"url":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments/236042320","pull_request_review_id":178047797,"id":236042320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA0MjMyMA==","diff_hunk":"@@ -0,0 +1,22 @@\n+let unsupported;\n+if (node.hasAttributes()) {\n+\tunsupported = [].slice\n+\t\t.call(node.attributes)\n+\t\t.filter(candidate => {\n+\t\t\t// skip non-ARIA attributes\n+\t\t\tif (/aria-/.test(candidate.name)) {\n+\t\t\t\t// filter out unsupported attributes\n+\t\t\t\treturn !axe.commons.aria.validateAttr(candidate.name, {\n+\t\t\t\t\tflagUnsupported: true\n+\t\t\t\t});\n+\t\t\t}\n+\t\t})\n+\t\t.map(candidate => {\n+\t\t\treturn candidate.name.toString();\n+\t\t});\n+}\n+if (unsupported.length) {\n+\tthis.data(unsupported);\n+\treturn true;\n+}\n+return false;","path":"lib/checks/aria/unsupportedattr.js","position":22,"original_position":22,"commit_id":"1af5f9341451adea541df7649820a3c0f54c162a","original_commit_id":"1af5f9341451adea541df7649820a3c0f54c162a","user":{"login":"WilcoFiers","id":530687,"node_id":"MDQ6VXNlcjUzMDY4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530687?v=4","gravatar_id":"","url":"https://api.github.com/users/WilcoFiers","html_url":"https://github.com/WilcoFiers","followers_url":"https://api.github.com/users/WilcoFiers/followers","following_url":"https://api.github.com/users/WilcoFiers/following{/other_user}","gists_url":"https://api.github.com/users/WilcoFiers/gists{/gist_id}","starred_url":"https://api.github.com/users/WilcoFiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilcoFiers/subscriptions","organizations_url":"https://api.github.com/users/WilcoFiers/orgs","repos_url":"https://api.github.com/users/WilcoFiers/repos","events_url":"https://api.github.com/users/WilcoFiers/events{/privacy}","received_events_url":"https://api.github.com/users/WilcoFiers/received_events","type":"User","site_admin":false},"body":"I'm not sure the logic works here. Shouldn't you return `true` when this passes? I would also think that this needs to be in `all` instead of `any` in the rule. That decision may be why you  used this strange logic.","created_at":"2018-11-24T13:17:58Z","updated_at":"2018-11-24T13:18:06Z","html_url":"https://github.com/dequelabs/axe-core/pull/1254#discussion_r236042320","pull_request_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments/236042320"},"html":{"href":"https://github.com/dequelabs/axe-core/pull/1254#discussion_r236042320"},"pull_request":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254"}}},"pull_request":{"url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254","id":232819744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODE5NzQ0","html_url":"https://github.com/dequelabs/axe-core/pull/1254","diff_url":"https://github.com/dequelabs/axe-core/pull/1254.diff","patch_url":"https://github.com/dequelabs/axe-core/pull/1254.patch","issue_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1254","number":1254,"state":"open","locked":false,"title":"WIP: ARIA supported checks","user":{"login":"marcysutton","id":1045233,"node_id":"MDQ6VXNlcjEwNDUyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1045233?v=4","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE. This work-in-progress branch adds a new check to report unsupported ARIA attributes to the user. We have to make a decision on how to modify the rule to support it, which you can find discussed in #918.\r\n\r\nCloses issue: https://github.com/dequelabs/axe-core/issues/918\r\n\r\n## Reviewer checks\r\n\r\n**Required fields, to be filled out by PR reviewer(s)**\r\n- [ ] Follows the commit message policy, appropriate for next version\r\n- [ ] Has documentation updated, a DU ticket, or requires no documentation change\r\n- [ ] Includes new tests, or was unnecessary\r\n- [ ] Code is reviewed for security by: << Name here >>\r\n","created_at":"2018-11-21T23:07:31Z","updated_at":"2018-11-24T13:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ff3e374ce371ca8b535081c932c9ed76e6262c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254/commits","review_comments_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254/comments","review_comment_url":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/issues/1254/comments","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/1af5f9341451adea541df7649820a3c0f54c162a","head":{"label":"dequelabs:aria-supported-checks","ref":"aria-supported-checks","sha":"1af5f9341451adea541df7649820a3c0f54c162a","user":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37205440,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNTQ0MA==","name":"axe-core","full_name":"dequelabs/axe-core","private":false,"owner":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dequelabs/axe-core","description":"Accessibility engine for automated Web UI testing","fork":false,"url":"https://api.github.com/repos/dequelabs/axe-core","forks_url":"https://api.github.com/repos/dequelabs/axe-core/forks","keys_url":"https://api.github.com/repos/dequelabs/axe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dequelabs/axe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dequelabs/axe-core/teams","hooks_url":"https://api.github.com/repos/dequelabs/axe-core/hooks","issue_events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/events{/number}","events_url":"https://api.github.com/repos/dequelabs/axe-core/events","assignees_url":"https://api.github.com/repos/dequelabs/axe-core/assignees{/user}","branches_url":"https://api.github.com/repos/dequelabs/axe-core/branches{/branch}","tags_url":"https://api.github.com/repos/dequelabs/axe-core/tags","blobs_url":"https://api.github.com/repos/dequelabs/axe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dequelabs/axe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dequelabs/axe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dequelabs/axe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dequelabs/axe-core/languages","stargazers_url":"https://api.github.com/repos/dequelabs/axe-core/stargazers","contributors_url":"https://api.github.com/repos/dequelabs/axe-core/contributors","subscribers_url":"https://api.github.com/repos/dequelabs/axe-core/subscribers","subscription_url":"https://api.github.com/repos/dequelabs/axe-core/subscription","commits_url":"https://api.github.com/repos/dequelabs/axe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dequelabs/axe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dequelabs/axe-core/contents/{+path}","compare_url":"https://api.github.com/repos/dequelabs/axe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dequelabs/axe-core/merges","archive_url":"https://api.github.com/repos/dequelabs/axe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dequelabs/axe-core/downloads","issues_url":"https://api.github.com/repos/dequelabs/axe-core/issues{/number}","pulls_url":"https://api.github.com/repos/dequelabs/axe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dequelabs/axe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dequelabs/axe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dequelabs/axe-core/labels{/name}","releases_url":"https://api.github.com/repos/dequelabs/axe-core/releases{/id}","deployments_url":"https://api.github.com/repos/dequelabs/axe-core/deployments","created_at":"2015-06-10T15:26:45Z","updated_at":"2018-11-24T12:22:38Z","pushed_at":"2018-11-23T14:34:44Z","git_url":"git://github.com/dequelabs/axe-core.git","ssh_url":"git@github.com:dequelabs/axe-core.git","clone_url":"https://github.com/dequelabs/axe-core.git","svn_url":"https://github.com/dequelabs/axe-core","homepage":"https://www.deque.com/axe/","size":5055,"stargazers_count":1807,"watchers_count":1807,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":164,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":255,"open_issues":164,"watchers":1807,"default_branch":"develop"}},"base":{"label":"dequelabs:develop","ref":"develop","sha":"b1657f88e9446ee4cb9ec3d725beb09db53d13bb","user":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37205440,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNTQ0MA==","name":"axe-core","full_name":"dequelabs/axe-core","private":false,"owner":{"login":"dequelabs","id":4094299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4094299?v=4","gravatar_id":"","url":"https://api.github.com/users/dequelabs","html_url":"https://github.com/dequelabs","followers_url":"https://api.github.com/users/dequelabs/followers","following_url":"https://api.github.com/users/dequelabs/following{/other_user}","gists_url":"https://api.github.com/users/dequelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dequelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequelabs/subscriptions","organizations_url":"https://api.github.com/users/dequelabs/orgs","repos_url":"https://api.github.com/users/dequelabs/repos","events_url":"https://api.github.com/users/dequelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dequelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dequelabs/axe-core","description":"Accessibility engine for automated Web UI testing","fork":false,"url":"https://api.github.com/repos/dequelabs/axe-core","forks_url":"https://api.github.com/repos/dequelabs/axe-core/forks","keys_url":"https://api.github.com/repos/dequelabs/axe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dequelabs/axe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dequelabs/axe-core/teams","hooks_url":"https://api.github.com/repos/dequelabs/axe-core/hooks","issue_events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/events{/number}","events_url":"https://api.github.com/repos/dequelabs/axe-core/events","assignees_url":"https://api.github.com/repos/dequelabs/axe-core/assignees{/user}","branches_url":"https://api.github.com/repos/dequelabs/axe-core/branches{/branch}","tags_url":"https://api.github.com/repos/dequelabs/axe-core/tags","blobs_url":"https://api.github.com/repos/dequelabs/axe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dequelabs/axe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dequelabs/axe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dequelabs/axe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dequelabs/axe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dequelabs/axe-core/languages","stargazers_url":"https://api.github.com/repos/dequelabs/axe-core/stargazers","contributors_url":"https://api.github.com/repos/dequelabs/axe-core/contributors","subscribers_url":"https://api.github.com/repos/dequelabs/axe-core/subscribers","subscription_url":"https://api.github.com/repos/dequelabs/axe-core/subscription","commits_url":"https://api.github.com/repos/dequelabs/axe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dequelabs/axe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dequelabs/axe-core/contents/{+path}","compare_url":"https://api.github.com/repos/dequelabs/axe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dequelabs/axe-core/merges","archive_url":"https://api.github.com/repos/dequelabs/axe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dequelabs/axe-core/downloads","issues_url":"https://api.github.com/repos/dequelabs/axe-core/issues{/number}","pulls_url":"https://api.github.com/repos/dequelabs/axe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dequelabs/axe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dequelabs/axe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dequelabs/axe-core/labels{/name}","releases_url":"https://api.github.com/repos/dequelabs/axe-core/releases{/id}","deployments_url":"https://api.github.com/repos/dequelabs/axe-core/deployments","created_at":"2015-06-10T15:26:45Z","updated_at":"2018-11-24T12:22:38Z","pushed_at":"2018-11-23T14:34:44Z","git_url":"git://github.com/dequelabs/axe-core.git","ssh_url":"git@github.com:dequelabs/axe-core.git","clone_url":"https://github.com/dequelabs/axe-core.git","svn_url":"https://github.com/dequelabs/axe-core","homepage":"https://www.deque.com/axe/","size":5055,"stargazers_count":1807,"watchers_count":1807,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":164,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":255,"open_issues":164,"watchers":1807,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254"},"html":{"href":"https://github.com/dequelabs/axe-core/pull/1254"},"issue":{"href":"https://api.github.com/repos/dequelabs/axe-core/issues/1254"},"comments":{"href":"https://api.github.com/repos/dequelabs/axe-core/issues/1254/comments"},"review_comments":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254/comments"},"review_comment":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dequelabs/axe-core/pulls/1254/commits"},"statuses":{"href":"https://api.github.com/repos/dequelabs/axe-core/statuses/1af5f9341451adea541df7649820a3c0f54c162a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"WilcoFiers"}}