{"action":"created","comment":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/225491707","pull_request_review_id":165099696,"id":225491707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ5MTcwNw==","diff_hunk":"@@ -261,6 +279,14 @@ void DirectoryService::ComputeNewCandidateLeader() {\n         m_mediator.m_DSCommittee->at(m_viewChangeCounter).second;\n   }\n \n+  // Compute the CommitteeHash member of the BlockHeaderBase\n+  CommitteeHash committeeHash;\n+  if (!Messenger::GetDSCommitteeHash(*m_mediator.m_DSCommittee,\n+                                     committeeHash)) {\n+    LOG_EPOCH(WARNING, to_string(m_mediator.m_currentEpochNum).c_str(),\n+              \"Messenger::GetDSCommitteeHash failed.\");","path":"src/libDirectoryService/ViewChangePreProcessing.cpp","position":56,"original_position":41,"commit_id":"56496428a8f948bf67de5ecb1345bbf3d762c038","original_commit_id":"1f321134f11109d3f9791e63187a9bd6087ec8fd","user":{"login":"kaikawaliu","id":12387256,"node_id":"MDQ6VXNlcjEyMzg3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/12387256?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikawaliu","html_url":"https://github.com/kaikawaliu","followers_url":"https://api.github.com/users/kaikawaliu/followers","following_url":"https://api.github.com/users/kaikawaliu/following{/other_user}","gists_url":"https://api.github.com/users/kaikawaliu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikawaliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikawaliu/subscriptions","organizations_url":"https://api.github.com/users/kaikawaliu/orgs","repos_url":"https://api.github.com/users/kaikawaliu/repos","events_url":"https://api.github.com/users/kaikawaliu/events{/privacy}","received_events_url":"https://api.github.com/users/kaikawaliu/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-10-16T10:57:18Z","updated_at":"2018-10-16T10:57:18Z","html_url":"https://github.com/Zilliqa/Zilliqa/pull/696#discussion_r225491707","pull_request_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/225491707"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/696#discussion_r225491707"},"pull_request":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696"}},"in_reply_to_id":225439493},"pull_request":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696","id":223111400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTExNDAw","html_url":"https://github.com/Zilliqa/Zilliqa/pull/696","diff_url":"https://github.com/Zilliqa/Zilliqa/pull/696.diff","patch_url":"https://github.com/Zilliqa/Zilliqa/pull/696.patch","issue_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/696","number":696,"state":"open","locked":false,"title":"Add checker of CommiteeHash for Tx/FB/VC/Micro blocks","user":{"login":"kaikawaliu","id":12387256,"node_id":"MDQ6VXNlcjEyMzg3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/12387256?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikawaliu","html_url":"https://github.com/kaikawaliu","followers_url":"https://api.github.com/users/kaikawaliu/followers","following_url":"https://api.github.com/users/kaikawaliu/following{/other_user}","gists_url":"https://api.github.com/users/kaikawaliu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikawaliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikawaliu/subscriptions","organizations_url":"https://api.github.com/users/kaikawaliu/orgs","repos_url":"https://api.github.com/users/kaikawaliu/repos","events_url":"https://api.github.com/users/kaikawaliu/events{/privacy}","received_events_url":"https://api.github.com/users/kaikawaliu/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!-- What is the overall goal of your pull request? -->\r\n<!-- What is the context of your pull request? -->\r\n<!-- What are the related issues and pull requests? -->\r\nAdd checker of CommiteeHash for Tx/FB/VC/Micro blocks, which used to be dummy value.\r\n\r\n## Review Suggestion\r\n<!-- How should the reviewers get started on reviewing your pull request-->\r\n<!-- How can the reviewers verify the pull request is working as expected -->\r\n\r\n## Status\r\n\r\n### Implementation\r\n<!-- Add more TODOs before \"ready for review\", if any  -->\r\n- [X] **ready for review**\r\n\r\n### Integration Test (Core Team)\r\n<!-- This is for core team only, ignore this if you are a community contributor -->\r\n\r\n<!-- append the commit digest to inform the others of the versions you have tested -->\r\n- [x] local machine test\r\n<!-- - [ ] local machine test (commit: bbbbbbbb) -->\r\n<!-- - [ ] local machine test (commit: cccccccc) -->\r\n<!-- - [ ] local machine test (commit: dddddddd) -->\r\n- [x] 200 nodes cloud test\r\n<!-- - [ ] small-scale cloud test (commit: bbbbbbbb) -->\r\n<!-- - [ ] small-scale cloud test (commit: cccccccc) -->\r\n<!-- - [ ] small-scale cloud test (commit: dddddddd) -->\r\n","created_at":"2018-10-16T04:26:15Z","updated_at":"2018-10-16T10:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"549584c975b19b1fd2d92521316df91c0c164657","assignee":{"login":"kaikawaliu","id":12387256,"node_id":"MDQ6VXNlcjEyMzg3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/12387256?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikawaliu","html_url":"https://github.com/kaikawaliu","followers_url":"https://api.github.com/users/kaikawaliu/followers","following_url":"https://api.github.com/users/kaikawaliu/following{/other_user}","gists_url":"https://api.github.com/users/kaikawaliu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikawaliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikawaliu/subscriptions","organizations_url":"https://api.github.com/users/kaikawaliu/orgs","repos_url":"https://api.github.com/users/kaikawaliu/repos","events_url":"https://api.github.com/users/kaikawaliu/events{/privacy}","received_events_url":"https://api.github.com/users/kaikawaliu/received_events","type":"User","site_admin":false},"assignees":[{"login":"kaikawaliu","id":12387256,"node_id":"MDQ6VXNlcjEyMzg3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/12387256?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikawaliu","html_url":"https://github.com/kaikawaliu","followers_url":"https://api.github.com/users/kaikawaliu/followers","following_url":"https://api.github.com/users/kaikawaliu/following{/other_user}","gists_url":"https://api.github.com/users/kaikawaliu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikawaliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikawaliu/subscriptions","organizations_url":"https://api.github.com/users/kaikawaliu/orgs","repos_url":"https://api.github.com/users/kaikawaliu/repos","events_url":"https://api.github.com/users/kaikawaliu/events{/privacy}","received_events_url":"https://api.github.com/users/kaikawaliu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":990370924,"node_id":"MDU6TGFiZWw5OTAzNzA5MjQ=","url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels/Ready","name":"Ready","color":"8ded6a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696/commits","review_comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696/comments","review_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/696/comments","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/56496428a8f948bf67de5ecb1345bbf3d762c038","head":{"label":"Zilliqa:feature/fbcommhashcheck","ref":"feature/fbcommhashcheck","sha":"56496428a8f948bf67de5ecb1345bbf3d762c038","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-10-16T09:32:14Z","pushed_at":"2018-10-16T10:46:32Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":21122,"stargazers_count":654,"watchers_count":654,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":142,"open_issues":73,"watchers":654,"default_branch":"master"}},"base":{"label":"Zilliqa:master","ref":"master","sha":"f8ecaf31fa516cb2da8652cbb85265661283eb03","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-10-16T09:32:14Z","pushed_at":"2018-10-16T10:46:32Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":21122,"stargazers_count":654,"watchers_count":654,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":142,"open_issues":73,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/696"},"issue":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/696"},"comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/56496428a8f948bf67de5ecb1345bbf3d762c038"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaikawaliu"}}