{"action":"created","comment":{"url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/comments/168468579","pull_request_review_id":96838211,"id":168468579,"diff_hunk":"@@ -3,3 +3,10 @@ Section \"OutputClass\"\n     MatchDriver \"tegra\"\n     Driver \"opentegra\"\n EndSection\n+","path":"opentegra.conf","position":4,"original_position":4,"commit_id":"4c440dc6d39d41c1fecfec96c455b10bf2b36932","original_commit_id":"4c440dc6d39d41c1fecfec96c455b10bf2b36932","user":{"login":"digetx","id":1242749,"avatar_url":"https://avatars2.githubusercontent.com/u/1242749?v=4","gravatar_id":"","url":"https://api.github.com/users/digetx","html_url":"https://github.com/digetx","followers_url":"https://api.github.com/users/digetx/followers","following_url":"https://api.github.com/users/digetx/following{/other_user}","gists_url":"https://api.github.com/users/digetx/gists{/gist_id}","starred_url":"https://api.github.com/users/digetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digetx/subscriptions","organizations_url":"https://api.github.com/users/digetx/orgs","repos_url":"https://api.github.com/users/digetx/repos","events_url":"https://api.github.com/users/digetx/events{/privacy}","received_events_url":"https://api.github.com/users/digetx/received_events","type":"User","site_admin":false},"body":"OutputClass isn't the right place for these options, you'll get invalid config error from Xorg if you'll try to do it.\r\n\r\nScreen section won't be used by anything other than opentegra because it has Identifier that links it to correct driver. But you are right, should be better to comment out it completely .\r\n\r\nAlso I'm thinking again that these options should be in the Device section, even if they are parsed from Screen section too.","created_at":"2018-02-15T13:03:23Z","updated_at":"2018-02-15T13:03:23Z","html_url":"https://github.com/grate-driver/xf86-video-opentegra/pull/30#discussion_r168468579","pull_request_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/comments/168468579"},"html":{"href":"https://github.com/grate-driver/xf86-video-opentegra/pull/30#discussion_r168468579"},"pull_request":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30"}},"in_reply_to_id":168419633},"pull_request":{"url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30","id":166391807,"html_url":"https://github.com/grate-driver/xf86-video-opentegra/pull/30","diff_url":"https://github.com/grate-driver/xf86-video-opentegra/pull/30.diff","patch_url":"https://github.com/grate-driver/xf86-video-opentegra/pull/30.patch","issue_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/30","number":30,"state":"open","locked":false,"title":"EXA: Implement accelerated compositing","user":{"login":"digetx","id":1242749,"avatar_url":"https://avatars2.githubusercontent.com/u/1242749?v=4","gravatar_id":"","url":"https://api.github.com/users/digetx","html_url":"https://github.com/digetx","followers_url":"https://api.github.com/users/digetx/followers","following_url":"https://api.github.com/users/digetx/following{/other_user}","gists_url":"https://api.github.com/users/digetx/gists{/gist_id}","starred_url":"https://api.github.com/users/digetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digetx/subscriptions","organizations_url":"https://api.github.com/users/digetx/orgs","repos_url":"https://api.github.com/users/digetx/repos","events_url":"https://api.github.com/users/digetx/events{/privacy}","received_events_url":"https://api.github.com/users/digetx/received_events","type":"User","site_admin":false},"body":"Basically it is a bunch of GR3D shaders written in grate's asm that perform the pixmaps blending. In general there is a noticeable performance improvement, although there is a room for improvements as well. Compositing passes rendercheck and cairo tests on T20 and T30. There is one caveat in regards to 3D, turned out that a `Read-Done` commands stream synchronization (waitcheck) is required before starting to render, otherwise there are glitches like a cropped text. I hope we could get waitchecks and BO reservations upstreamed ASAP as we require them more and more.","created_at":"2018-01-31T22:17:01Z","updated_at":"2018-02-15T13:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1167870f97be6902d9b4362d19f3391870c261ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30/commits","review_comments_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30/comments","review_comment_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/30/comments","statuses_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/statuses/4c440dc6d39d41c1fecfec96c455b10bf2b36932","head":{"label":"digetx:exa-compositing","ref":"exa-compositing","sha":"4c440dc6d39d41c1fecfec96c455b10bf2b36932","user":{"login":"digetx","id":1242749,"avatar_url":"https://avatars2.githubusercontent.com/u/1242749?v=4","gravatar_id":"","url":"https://api.github.com/users/digetx","html_url":"https://github.com/digetx","followers_url":"https://api.github.com/users/digetx/followers","following_url":"https://api.github.com/users/digetx/following{/other_user}","gists_url":"https://api.github.com/users/digetx/gists{/gist_id}","starred_url":"https://api.github.com/users/digetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digetx/subscriptions","organizations_url":"https://api.github.com/users/digetx/orgs","repos_url":"https://api.github.com/users/digetx/repos","events_url":"https://api.github.com/users/digetx/events{/privacy}","received_events_url":"https://api.github.com/users/digetx/received_events","type":"User","site_admin":false},"repo":{"id":68133410,"name":"xf86-video-opentegra","full_name":"digetx/xf86-video-opentegra","owner":{"login":"digetx","id":1242749,"avatar_url":"https://avatars2.githubusercontent.com/u/1242749?v=4","gravatar_id":"","url":"https://api.github.com/users/digetx","html_url":"https://github.com/digetx","followers_url":"https://api.github.com/users/digetx/followers","following_url":"https://api.github.com/users/digetx/following{/other_user}","gists_url":"https://api.github.com/users/digetx/gists{/gist_id}","starred_url":"https://api.github.com/users/digetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digetx/subscriptions","organizations_url":"https://api.github.com/users/digetx/orgs","repos_url":"https://api.github.com/users/digetx/repos","events_url":"https://api.github.com/users/digetx/events{/privacy}","received_events_url":"https://api.github.com/users/digetx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digetx/xf86-video-opentegra","description":"X.Org video driver for NVIDIA Tegra","fork":true,"url":"https://api.github.com/repos/digetx/xf86-video-opentegra","forks_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/forks","keys_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/teams","hooks_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/hooks","issue_events_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/issues/events{/number}","events_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/events","assignees_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/assignees{/user}","branches_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/branches{/branch}","tags_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/tags","blobs_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/git/refs{/sha}","trees_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/statuses/{sha}","languages_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/languages","stargazers_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/stargazers","contributors_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/contributors","subscribers_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/subscribers","subscription_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/subscription","commits_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/commits{/sha}","git_commits_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/git/commits{/sha}","comments_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/comments{/number}","issue_comment_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/issues/comments{/number}","contents_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/contents/{+path}","compare_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/merges","archive_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/downloads","issues_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/issues{/number}","pulls_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/pulls{/number}","milestones_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/milestones{/number}","notifications_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/labels{/name}","releases_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/releases{/id}","deployments_url":"https://api.github.com/repos/digetx/xf86-video-opentegra/deployments","created_at":"2016-09-13T17:56:50Z","updated_at":"2016-09-13T17:56:51Z","pushed_at":"2018-02-14T22:03:58Z","git_url":"git://github.com/digetx/xf86-video-opentegra.git","ssh_url":"git@github.com:digetx/xf86-video-opentegra.git","clone_url":"https://github.com/digetx/xf86-video-opentegra.git","svn_url":"https://github.com/digetx/xf86-video-opentegra","homepage":null,"size":591,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grate-driver:master","ref":"master","sha":"96acfc480669adc9cf9092003b01e909c3a14513","user":{"login":"grate-driver","id":3780138,"avatar_url":"https://avatars0.githubusercontent.com/u/3780138?v=4","gravatar_id":"","url":"https://api.github.com/users/grate-driver","html_url":"https://github.com/grate-driver","followers_url":"https://api.github.com/users/grate-driver/followers","following_url":"https://api.github.com/users/grate-driver/following{/other_user}","gists_url":"https://api.github.com/users/grate-driver/gists{/gist_id}","starred_url":"https://api.github.com/users/grate-driver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grate-driver/subscriptions","organizations_url":"https://api.github.com/users/grate-driver/orgs","repos_url":"https://api.github.com/users/grate-driver/repos","events_url":"https://api.github.com/users/grate-driver/events{/privacy}","received_events_url":"https://api.github.com/users/grate-driver/received_events","type":"Organization","site_admin":false},"repo":{"id":16490830,"name":"xf86-video-opentegra","full_name":"grate-driver/xf86-video-opentegra","owner":{"login":"grate-driver","id":3780138,"avatar_url":"https://avatars0.githubusercontent.com/u/3780138?v=4","gravatar_id":"","url":"https://api.github.com/users/grate-driver","html_url":"https://github.com/grate-driver","followers_url":"https://api.github.com/users/grate-driver/followers","following_url":"https://api.github.com/users/grate-driver/following{/other_user}","gists_url":"https://api.github.com/users/grate-driver/gists{/gist_id}","starred_url":"https://api.github.com/users/grate-driver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grate-driver/subscriptions","organizations_url":"https://api.github.com/users/grate-driver/orgs","repos_url":"https://api.github.com/users/grate-driver/repos","events_url":"https://api.github.com/users/grate-driver/events{/privacy}","received_events_url":"https://api.github.com/users/grate-driver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grate-driver/xf86-video-opentegra","description":"X.Org video driver for NVIDIA Tegra","fork":false,"url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra","forks_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/forks","keys_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/teams","hooks_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/hooks","issue_events_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/events{/number}","events_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/events","assignees_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/assignees{/user}","branches_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/branches{/branch}","tags_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/tags","blobs_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/git/refs{/sha}","trees_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/statuses/{sha}","languages_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/languages","stargazers_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/stargazers","contributors_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/contributors","subscribers_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/subscribers","subscription_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/subscription","commits_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/commits{/sha}","git_commits_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/git/commits{/sha}","comments_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/comments{/number}","issue_comment_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/comments{/number}","contents_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/contents/{+path}","compare_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/merges","archive_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/downloads","issues_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues{/number}","pulls_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls{/number}","milestones_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/milestones{/number}","notifications_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/labels{/name}","releases_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/releases{/id}","deployments_url":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/deployments","created_at":"2014-02-03T19:47:03Z","updated_at":"2018-01-21T00:30:30Z","pushed_at":"2018-02-14T22:03:59Z","git_url":"git://github.com/grate-driver/xf86-video-opentegra.git","ssh_url":"git@github.com:grate-driver/xf86-video-opentegra.git","clone_url":"https://github.com/grate-driver/xf86-video-opentegra.git","svn_url":"https://github.com/grate-driver/xf86-video-opentegra","homepage":null,"size":274,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30"},"html":{"href":"https://github.com/grate-driver/xf86-video-opentegra/pull/30"},"issue":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/30"},"comments":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/grate-driver/xf86-video-opentegra/statuses/4c440dc6d39d41c1fecfec96c455b10bf2b36932"}},"author_association":"OWNER"}}
{"actor":{"display_login":"digetx"}}