{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/comments/167524636","pull_request_review_id":95754468,"id":167524636,"diff_hunk":"@@ -1,45 +1,52 @@\n ### Workflow\n \n-#### Contributions\n-\n-All code changes and additions to Mbed OS are handled through GitHub. If you want to contribute, either by adding features or by fixing bugs, please follow the guidelines for [new features](#contributing-new-features-to-mbed-os) and [bugs](#reporting-and-fixing-bugs). In both cases, please follow the [code style guide and GitHub pull request guidelines](/docs/v5.7/reference/guidelines.html#style)</a>. Please also read the [CLA](/docs/v5.7/reference/guidelines.html#cla) guidelines because we will immediately close pull requests submitted without a CLA.\n+All code changes and additions to Mbed OS are handled through GitHub. If you want to contribute, either by adding features or by fixing bugs, please follow the guidelines for [new features](#features) and [bugs](#reporting-bugs). In both cases, please follow the [code style guide and GitHub pull request guidelines](/docs/v5.7/reference/guidelines.html#style). Please also read the [Contributor License Agreement (CLA)](/docs/v5.7/reference/guidelines.html#cla) guidelines because we will immediately close pull requests submitted without a CLA.\n \n-#### Contributing new features to Mbed OS\n-\n-Before contributing an enhancement (new feature, new port and so on), please [discuss it on the forums](https://os.mbed.com/forum/bugs-suggestions/) to avoid duplication of work, as we or others might be working on a related feature.\n+#### Mbed OS maintainers\n \n-Patch contributions can only be accepted through GitHub by creating a pull request from forked versions of our repositories. This allows us to review the contributions in a user friendly and reliable way, under public scrutiny.\n+The maintainers are a small group of Mbed OS engineers who are responsible for the Mbed OS codebase. Their primary role is to progress contributions, both internal and external, from the initial pull request state through to released code. \n \n-Please create separate pull requests for each concern; each pull request should have a clear unity of purpose. In particular, separate code formatting and style changes from functional changes. This makes each patch’s true contribution clearer and therefore quicker and easier to review.\n+Responsibilities:\n \n-#### Reporting and fixing bugs\n+1. Check for CLA compliance.\n+1. Ensure the relevant stakeholders review pull requests.\n+1. Guide contributors both technically and procedurally.\n+1. Run pull requests through the CI systems.\n+1. Put label version.\n+1. Merge pull requests into the requested branches.\n+1. Make periodic patch and feature releases.\n \n-Before submitting a bug report or a bug fix, please [discuss it on the forums](https://os.mbed.com/forum/bugs-suggestions/) to avoid duplication of work, as we or others might be working on it already.\n+The current maintainers are:\n \n-##### Bug reports (issues) on GitHub\n+* [Anna Bridge](https://os.mbed.com/users/AnnaBridge).","path":"docs/reference/contributing/guidelines/workflow.md","position":32,"original_position":32,"commit_id":"a898fe41e2aa155511d30ffb38f62762c490ab6e","original_commit_id":"a898fe41e2aa155511d30ffb38f62762c490ab6e","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"We will have a group soon (not on mbed.os though). Once done, we can update it separately","created_at":"2018-02-12T11:12:53Z","updated_at":"2018-02-12T11:12:53Z","html_url":"https://github.com/ARMmbed/Handbook/pull/377#discussion_r167524636","pull_request_url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/comments/167524636"},"html":{"href":"https://github.com/ARMmbed/Handbook/pull/377#discussion_r167524636"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377"}},"in_reply_to_id":167349423},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377","id":164571989,"html_url":"https://github.com/ARMmbed/Handbook/pull/377","diff_url":"https://github.com/ARMmbed/Handbook/pull/377.diff","patch_url":"https://github.com/ARMmbed/Handbook/pull/377.patch","issue_url":"https://api.github.com/repos/ARMmbed/Handbook/issues/377","number":377,"state":"open","locked":false,"title":"Workflow document update","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"There are lot of changes (I can split some restructuring from this if that would make it easier but the changes are not that significant to the text itself). I can rebase after the review (squash fix typos and similar commits).\r\n\r\nRendered file [here](https://github.com/0xc0170/Handbook/blob/dbb470799ba8ef58823a3c8670fcf50ac778232c/docs/reference/contributing/guidelines/workflow.md)\r\n\r\nThe new structure is:\r\n\r\n- gatekeepers (maintainers + stakeholders)\r\n- contributions\r\n- pull requests categories and states\r\n- additional labels\r\n\r\nNew additions here:\r\n\r\n- introducing feature branches\r\n- stakeholders (feature owners or module owners)\r\n- time boxes for each pull request stage\r\n\r\nPlease assign for review maintainers (@theotherjimmy @adbridge @cmonr )\r\n\r\n@studavekar (there is one reference to CI that is currently empty and would like to have a page that explains our CI. I can remove the reference for now, but should be added later).","created_at":"2018-01-23T13:12:27Z","updated_at":"2018-02-12T11:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"567cfcb7b64cc4c52eb5b12aca29f38d3dbae96b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/Handbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/Handbook/issues/377/comments","statuses_url":"https://api.github.com/repos/ARMmbed/Handbook/statuses/a898fe41e2aa155511d30ffb38f62762c490ab6e","head":{"label":"0xc0170:dev_workflow_impr","ref":"dev_workflow_impr","sha":"a898fe41e2aa155511d30ffb38f62762c490ab6e","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"repo":{"id":85845710,"name":"Handbook","full_name":"0xc0170/Handbook","owner":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xc0170/Handbook","description":"New version of the handbook","fork":true,"url":"https://api.github.com/repos/0xc0170/Handbook","forks_url":"https://api.github.com/repos/0xc0170/Handbook/forks","keys_url":"https://api.github.com/repos/0xc0170/Handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xc0170/Handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xc0170/Handbook/teams","hooks_url":"https://api.github.com/repos/0xc0170/Handbook/hooks","issue_events_url":"https://api.github.com/repos/0xc0170/Handbook/issues/events{/number}","events_url":"https://api.github.com/repos/0xc0170/Handbook/events","assignees_url":"https://api.github.com/repos/0xc0170/Handbook/assignees{/user}","branches_url":"https://api.github.com/repos/0xc0170/Handbook/branches{/branch}","tags_url":"https://api.github.com/repos/0xc0170/Handbook/tags","blobs_url":"https://api.github.com/repos/0xc0170/Handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xc0170/Handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xc0170/Handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xc0170/Handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xc0170/Handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/0xc0170/Handbook/languages","stargazers_url":"https://api.github.com/repos/0xc0170/Handbook/stargazers","contributors_url":"https://api.github.com/repos/0xc0170/Handbook/contributors","subscribers_url":"https://api.github.com/repos/0xc0170/Handbook/subscribers","subscription_url":"https://api.github.com/repos/0xc0170/Handbook/subscription","commits_url":"https://api.github.com/repos/0xc0170/Handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xc0170/Handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xc0170/Handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xc0170/Handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xc0170/Handbook/contents/{+path}","compare_url":"https://api.github.com/repos/0xc0170/Handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xc0170/Handbook/merges","archive_url":"https://api.github.com/repos/0xc0170/Handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xc0170/Handbook/downloads","issues_url":"https://api.github.com/repos/0xc0170/Handbook/issues{/number}","pulls_url":"https://api.github.com/repos/0xc0170/Handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/0xc0170/Handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/0xc0170/Handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xc0170/Handbook/labels{/name}","releases_url":"https://api.github.com/repos/0xc0170/Handbook/releases{/id}","deployments_url":"https://api.github.com/repos/0xc0170/Handbook/deployments","created_at":"2017-03-22T15:37:47Z","updated_at":"2017-02-06T05:43:15Z","pushed_at":"2018-02-07T13:42:20Z","git_url":"git://github.com/0xc0170/Handbook.git","ssh_url":"git@github.com:0xc0170/Handbook.git","clone_url":"https://github.com/0xc0170/Handbook.git","svn_url":"https://github.com/0xc0170/Handbook","homepage":null,"size":18725,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:5.7","ref":"5.7","sha":"0fdf7ca48ef9a4660e2021fcf40c34fa5c38b23a","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":31957877,"name":"Handbook","full_name":"ARMmbed/Handbook","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/Handbook","description":"New version of the handbook","fork":false,"url":"https://api.github.com/repos/ARMmbed/Handbook","forks_url":"https://api.github.com/repos/ARMmbed/Handbook/forks","keys_url":"https://api.github.com/repos/ARMmbed/Handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/Handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/Handbook/teams","hooks_url":"https://api.github.com/repos/ARMmbed/Handbook/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/Handbook/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/Handbook/events","assignees_url":"https://api.github.com/repos/ARMmbed/Handbook/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/Handbook/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/Handbook/tags","blobs_url":"https://api.github.com/repos/ARMmbed/Handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/Handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/Handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/Handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/Handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/Handbook/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/Handbook/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/Handbook/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/Handbook/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/Handbook/subscription","commits_url":"https://api.github.com/repos/ARMmbed/Handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/Handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/Handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/Handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/Handbook/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/Handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/Handbook/merges","archive_url":"https://api.github.com/repos/ARMmbed/Handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/Handbook/downloads","issues_url":"https://api.github.com/repos/ARMmbed/Handbook/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/Handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/Handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/Handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/Handbook/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/Handbook/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/Handbook/deployments","created_at":"2015-03-10T13:06:41Z","updated_at":"2018-01-17T22:33:29Z","pushed_at":"2018-02-09T12:38:11Z","git_url":"git://github.com/ARMmbed/Handbook.git","ssh_url":"git@github.com:ARMmbed/Handbook.git","clone_url":"https://github.com/ARMmbed/Handbook.git","svn_url":"https://github.com/ARMmbed/Handbook","homepage":null,"size":19376,"stargazers_count":22,"watchers_count":22,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":65,"open_issues":28,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377"},"html":{"href":"https://github.com/ARMmbed/Handbook/pull/377"},"issue":{"href":"https://api.github.com/repos/ARMmbed/Handbook/issues/377"},"comments":{"href":"https://api.github.com/repos/ARMmbed/Handbook/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/Handbook/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/Handbook/statuses/a898fe41e2aa155511d30ffb38f62762c490ab6e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"0xc0170"}}