{"action":"created","issue":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/353","repository_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET","labels_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/353/comments","events_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/353/events","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/353","id":385838347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzE4MTU3","number":353,"title":"epanet toolkit api versioning","user":{"login":"michaeltryby","id":6942309,"node_id":"MDQ6VXNlcjY5NDIzMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6942309?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltryby","html_url":"https://github.com/michaeltryby","followers_url":"https://api.github.com/users/michaeltryby/followers","following_url":"https://api.github.com/users/michaeltryby/following{/other_user}","gists_url":"https://api.github.com/users/michaeltryby/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltryby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltryby/subscriptions","organizations_url":"https://api.github.com/users/michaeltryby/orgs","repos_url":"https://api.github.com/users/michaeltryby/repos","events_url":"https://api.github.com/users/michaeltryby/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltryby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-29T17:11:05Z","updated_at":"2018-11-29T22:05:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/353","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/353","diff_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/353.diff","patch_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/353.patch"},"body":"Separates new \"EN_\" Toolkit API functions into their own header `epanet2_2.h` and implementation file `epanet.c`. Legacy \"EN*\" API is located in `epanet2.h` and `epanet2.c`.\r\n\r\nChanges name of library target in cmake build from `epanet` to `epanet2`. \r\n \r\nClose Issue #333 \r\nClose Issue #352 \r\n "},"comment":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/comments/443011036","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/353#issuecomment-443011036","issue_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/353","id":443011036,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzAxMTAzNg==","user":{"login":"michaeltryby","id":6942309,"node_id":"MDQ6VXNlcjY5NDIzMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6942309?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltryby","html_url":"https://github.com/michaeltryby","followers_url":"https://api.github.com/users/michaeltryby/followers","following_url":"https://api.github.com/users/michaeltryby/following{/other_user}","gists_url":"https://api.github.com/users/michaeltryby/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltryby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltryby/subscriptions","organizations_url":"https://api.github.com/users/michaeltryby/orgs","repos_url":"https://api.github.com/users/michaeltryby/repos","events_url":"https://api.github.com/users/michaeltryby/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltryby/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T22:05:26Z","updated_at":"2018-11-29T22:05:26Z","author_association":"NONE","body":"I think this PR came out pretty well. Keeping the legacy Toolkit API in `epanet2.h` was a good call. We need a better name for the `epanet2_2.h` implementation file though. Right now its `epanet.c`. Any thoughts or preferences? "}}
{"actor":{"display_login":"michaeltryby"}}