{"action":"created","issue":{"url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/22","repository_url":"https://api.github.com/repos/DeFacto-UW/DeMark","labels_url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/22/comments","events_url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/22/events","html_url":"https://github.com/DeFacto-UW/DeMark/issues/22","id":324498857,"number":22,"title":"Fix code style","user":{"login":"avidant","id":18059186,"avatar_url":"https://avatars3.githubusercontent.com/u/18059186?v=4","gravatar_id":"","url":"https://api.github.com/users/avidant","html_url":"https://github.com/avidant","followers_url":"https://api.github.com/users/avidant/followers","following_url":"https://api.github.com/users/avidant/following{/other_user}","gists_url":"https://api.github.com/users/avidant/gists{/gist_id}","starred_url":"https://api.github.com/users/avidant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avidant/subscriptions","organizations_url":"https://api.github.com/users/avidant/orgs","repos_url":"https://api.github.com/users/avidant/repos","events_url":"https://api.github.com/users/avidant/events{/privacy}","received_events_url":"https://api.github.com/users/avidant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-18T17:51:57Z","updated_at":"2018-05-18T19:15:51Z","closed_at":null,"author_association":"NONE","body":"- [ ] Class comments need to be added to all Classes\r\n- [ ] Comments need to be added to most fields and methods\r\n- [ ] Some method names need to be clearer. Eg- `isDemarked()` checks if a line is a Demark line, but it is misread as `isMarked()`\r\n- [ ] All Pull Requests should require a Code Review and Approval before merging.\r\n- [ ] Lines with over 100 characters of code should be split between 2 lines. Eg- `ClearAllAction.java` line 30/31\r\n- [ ] Tests should be runnable through IntelliJ. Not sure what’s going wrong. Are more instructions needed to run tests?\r\n- [ ] Test data should contain larger projects, not only programs upto 20 lines of code. Maybe a stress test with a larger program as test data would be a good idea.\r\n- [ ] Test should be documented documentation as this compounds the inability to run tests.\r\n\r\nThis code review is part of [Project 8 of CSE 403](https://courses.cs.washington.edu/courses/cse403/18sp/projects/proj08b-address-feedback.html)\r\n"},"comment":{"url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/comments/390305986","html_url":"https://github.com/DeFacto-UW/DeMark/issues/22#issuecomment-390305986","issue_url":"https://api.github.com/repos/DeFacto-UW/DeMark/issues/22","id":390305986,"user":{"login":"avidant","id":18059186,"avatar_url":"https://avatars3.githubusercontent.com/u/18059186?v=4","gravatar_id":"","url":"https://api.github.com/users/avidant","html_url":"https://github.com/avidant","followers_url":"https://api.github.com/users/avidant/followers","following_url":"https://api.github.com/users/avidant/following{/other_user}","gists_url":"https://api.github.com/users/avidant/gists{/gist_id}","starred_url":"https://api.github.com/users/avidant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avidant/subscriptions","organizations_url":"https://api.github.com/users/avidant/orgs","repos_url":"https://api.github.com/users/avidant/repos","events_url":"https://api.github.com/users/avidant/events{/privacy}","received_events_url":"https://api.github.com/users/avidant/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T19:15:51Z","updated_at":"2018-05-18T19:15:51Z","author_association":"NONE","body":"1. When we originally reviewed the code, there were no class comments. I see that you fixed this in commits yesterday, so this no longer applies.\r\n3. I think the issue with that is just that it's very confusing as to do you mean unmarked? Or part of the DeMark project? I would recommend `isDemarkLine()`.\r\n6. I did try that, but was not able to run the tests still. I am guessing this is an issue with my setup as I don't typically use Gradle."}}
{"actor":{"display_login":"avidant"}}