{"action":"created","comment":{"url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments/234101338","pull_request_review_id":175671314,"id":234101338,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDEwMTMzOA==","diff_hunk":"@@ -120,6 +120,12 @@ func (p *provider) getConfig(s v1alpha1.ProviderConfig) (*Config, *providerconfi\n \tif err != nil {\n \t\treturn nil, nil, nil, fmt.Errorf(\"failed to get the value of \\\"password\\\" field, error = %v\", err)\n \t}\n+\t// Ignore Region not found as Region might not be found and we can default it later\n+\tc.Region, err = p.configVarResolver.GetConfigVarStringValueOrEnv(rawConfig.Region, \"OS_REGION_NAME\")\n+        if err != nil {\n+\t\tglog.V(0).Infof(\"Region from configuration or environment variable not found\")","path":"pkg/cloudprovider/provider/openstack/provider.go","position":39,"original_position":39,"commit_id":"fd90455c2124132e243edf4dd37449a92fc7db87","original_commit_id":"fd90455c2124132e243edf4dd37449a92fc7db87","user":{"login":"jichenjc","id":17615805,"node_id":"MDQ6VXNlcjE3NjE1ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/17615805?v=4","gravatar_id":"","url":"https://api.github.com/users/jichenjc","html_url":"https://github.com/jichenjc","followers_url":"https://api.github.com/users/jichenjc/followers","following_url":"https://api.github.com/users/jichenjc/following{/other_user}","gists_url":"https://api.github.com/users/jichenjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jichenjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jichenjc/subscriptions","organizations_url":"https://api.github.com/users/jichenjc/orgs","repos_url":"https://api.github.com/users/jichenjc/repos","events_url":"https://api.github.com/users/jichenjc/events{/privacy}","received_events_url":"https://api.github.com/users/jichenjc/received_events","type":"User","site_admin":false},"body":"ok, will do","created_at":"2018-11-16T06:29:23Z","updated_at":"2018-11-16T06:29:23Z","html_url":"https://github.com/kubermatic/machine-controller/pull/403#discussion_r234101338","pull_request_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments/234101338"},"html":{"href":"https://github.com/kubermatic/machine-controller/pull/403#discussion_r234101338"},"pull_request":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403"}},"in_reply_to_id":233732934},"pull_request":{"url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403","id":230046837,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDQ2ODM3","html_url":"https://github.com/kubermatic/machine-controller/pull/403","diff_url":"https://github.com/kubermatic/machine-controller/pull/403.diff","patch_url":"https://github.com/kubermatic/machine-controller/pull/403.patch","issue_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/403","number":403,"state":"open","locked":false,"title":"Move region into secret of openstack","user":{"login":"jichenjc","id":17615805,"node_id":"MDQ6VXNlcjE3NjE1ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/17615805?v=4","gravatar_id":"","url":"https://api.github.com/users/jichenjc","html_url":"https://github.com/jichenjc","followers_url":"https://api.github.com/users/jichenjc/followers","following_url":"https://api.github.com/users/jichenjc/following{/other_user}","gists_url":"https://api.github.com/users/jichenjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jichenjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jichenjc/subscriptions","organizations_url":"https://api.github.com/users/jichenjc/orgs","repos_url":"https://api.github.com/users/jichenjc/repos","events_url":"https://api.github.com/users/jichenjc/events{/privacy}","received_events_url":"https://api.github.com/users/jichenjc/received_events","type":"User","site_admin":false},"body":"Openstack Region should be put into secret..\r\n\r\n**What this PR does / why we need it**:\r\n'Region' is secret in openrc file (params to link to keystone of openstack)\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n```\r\nRegion should be a secret , not a common user settings\r\n```\r\n","created_at":"2018-11-12T08:01:34Z","updated_at":"2018-11-16T06:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18f640f25cd67390dcacbc681ce765c98cd85709","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1097473318,"node_id":"MDU6TGFiZWwxMDk3NDczMzE4","url":"https://api.github.com/repos/kubermatic/machine-controller/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":1101208842,"node_id":"MDU6TGFiZWwxMTAxMjA4ODQy","url":"https://api.github.com/repos/kubermatic/machine-controller/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":1101208813,"node_id":"MDU6TGFiZWwxMTAxMjA4ODEz","url":"https://api.github.com/repos/kubermatic/machine-controller/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403/commits","review_comments_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403/comments","review_comment_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/403/comments","statuses_url":"https://api.github.com/repos/kubermatic/machine-controller/statuses/fd90455c2124132e243edf4dd37449a92fc7db87","head":{"label":"jichenjc:move_region","ref":"move_region","sha":"fd90455c2124132e243edf4dd37449a92fc7db87","user":{"login":"jichenjc","id":17615805,"node_id":"MDQ6VXNlcjE3NjE1ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/17615805?v=4","gravatar_id":"","url":"https://api.github.com/users/jichenjc","html_url":"https://github.com/jichenjc","followers_url":"https://api.github.com/users/jichenjc/followers","following_url":"https://api.github.com/users/jichenjc/following{/other_user}","gists_url":"https://api.github.com/users/jichenjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jichenjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jichenjc/subscriptions","organizations_url":"https://api.github.com/users/jichenjc/orgs","repos_url":"https://api.github.com/users/jichenjc/repos","events_url":"https://api.github.com/users/jichenjc/events{/privacy}","received_events_url":"https://api.github.com/users/jichenjc/received_events","type":"User","site_admin":false},"repo":{"id":156822625,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY4MjI2MjU=","name":"machine-controller","full_name":"jichenjc/machine-controller","private":false,"owner":{"login":"jichenjc","id":17615805,"node_id":"MDQ6VXNlcjE3NjE1ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/17615805?v=4","gravatar_id":"","url":"https://api.github.com/users/jichenjc","html_url":"https://github.com/jichenjc","followers_url":"https://api.github.com/users/jichenjc/followers","following_url":"https://api.github.com/users/jichenjc/following{/other_user}","gists_url":"https://api.github.com/users/jichenjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jichenjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jichenjc/subscriptions","organizations_url":"https://api.github.com/users/jichenjc/orgs","repos_url":"https://api.github.com/users/jichenjc/repos","events_url":"https://api.github.com/users/jichenjc/events{/privacy}","received_events_url":"https://api.github.com/users/jichenjc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jichenjc/machine-controller","description":null,"fork":true,"url":"https://api.github.com/repos/jichenjc/machine-controller","forks_url":"https://api.github.com/repos/jichenjc/machine-controller/forks","keys_url":"https://api.github.com/repos/jichenjc/machine-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jichenjc/machine-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jichenjc/machine-controller/teams","hooks_url":"https://api.github.com/repos/jichenjc/machine-controller/hooks","issue_events_url":"https://api.github.com/repos/jichenjc/machine-controller/issues/events{/number}","events_url":"https://api.github.com/repos/jichenjc/machine-controller/events","assignees_url":"https://api.github.com/repos/jichenjc/machine-controller/assignees{/user}","branches_url":"https://api.github.com/repos/jichenjc/machine-controller/branches{/branch}","tags_url":"https://api.github.com/repos/jichenjc/machine-controller/tags","blobs_url":"https://api.github.com/repos/jichenjc/machine-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jichenjc/machine-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jichenjc/machine-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/jichenjc/machine-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jichenjc/machine-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/jichenjc/machine-controller/languages","stargazers_url":"https://api.github.com/repos/jichenjc/machine-controller/stargazers","contributors_url":"https://api.github.com/repos/jichenjc/machine-controller/contributors","subscribers_url":"https://api.github.com/repos/jichenjc/machine-controller/subscribers","subscription_url":"https://api.github.com/repos/jichenjc/machine-controller/subscription","commits_url":"https://api.github.com/repos/jichenjc/machine-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/jichenjc/machine-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/jichenjc/machine-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/jichenjc/machine-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/jichenjc/machine-controller/contents/{+path}","compare_url":"https://api.github.com/repos/jichenjc/machine-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jichenjc/machine-controller/merges","archive_url":"https://api.github.com/repos/jichenjc/machine-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jichenjc/machine-controller/downloads","issues_url":"https://api.github.com/repos/jichenjc/machine-controller/issues{/number}","pulls_url":"https://api.github.com/repos/jichenjc/machine-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/jichenjc/machine-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/jichenjc/machine-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jichenjc/machine-controller/labels{/name}","releases_url":"https://api.github.com/repos/jichenjc/machine-controller/releases{/id}","deployments_url":"https://api.github.com/repos/jichenjc/machine-controller/deployments","created_at":"2018-11-09T06:55:14Z","updated_at":"2018-11-09T06:55:16Z","pushed_at":"2018-11-16T05:31:03Z","git_url":"git://github.com/jichenjc/machine-controller.git","ssh_url":"git@github.com:jichenjc/machine-controller.git","clone_url":"https://github.com/jichenjc/machine-controller.git","svn_url":"https://github.com/jichenjc/machine-controller","homepage":null,"size":10236,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubermatic:master","ref":"master","sha":"3c310aa06d1a71983280e9bcdf2e9638a0bc17cf","user":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"repo":{"id":115267126,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyNjcxMjY=","name":"machine-controller","full_name":"kubermatic/machine-controller","private":false,"owner":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubermatic/machine-controller","description":null,"fork":false,"url":"https://api.github.com/repos/kubermatic/machine-controller","forks_url":"https://api.github.com/repos/kubermatic/machine-controller/forks","keys_url":"https://api.github.com/repos/kubermatic/machine-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubermatic/machine-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubermatic/machine-controller/teams","hooks_url":"https://api.github.com/repos/kubermatic/machine-controller/hooks","issue_events_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/events{/number}","events_url":"https://api.github.com/repos/kubermatic/machine-controller/events","assignees_url":"https://api.github.com/repos/kubermatic/machine-controller/assignees{/user}","branches_url":"https://api.github.com/repos/kubermatic/machine-controller/branches{/branch}","tags_url":"https://api.github.com/repos/kubermatic/machine-controller/tags","blobs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubermatic/machine-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubermatic/machine-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubermatic/machine-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/kubermatic/machine-controller/languages","stargazers_url":"https://api.github.com/repos/kubermatic/machine-controller/stargazers","contributors_url":"https://api.github.com/repos/kubermatic/machine-controller/contributors","subscribers_url":"https://api.github.com/repos/kubermatic/machine-controller/subscribers","subscription_url":"https://api.github.com/repos/kubermatic/machine-controller/subscription","commits_url":"https://api.github.com/repos/kubermatic/machine-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubermatic/machine-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubermatic/machine-controller/contents/{+path}","compare_url":"https://api.github.com/repos/kubermatic/machine-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubermatic/machine-controller/merges","archive_url":"https://api.github.com/repos/kubermatic/machine-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubermatic/machine-controller/downloads","issues_url":"https://api.github.com/repos/kubermatic/machine-controller/issues{/number}","pulls_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/kubermatic/machine-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/kubermatic/machine-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubermatic/machine-controller/labels{/name}","releases_url":"https://api.github.com/repos/kubermatic/machine-controller/releases{/id}","deployments_url":"https://api.github.com/repos/kubermatic/machine-controller/deployments","created_at":"2017-12-24T14:12:56Z","updated_at":"2018-11-14T16:12:20Z","pushed_at":"2018-11-16T05:31:05Z","git_url":"git://github.com/kubermatic/machine-controller.git","ssh_url":"git@github.com:kubermatic/machine-controller.git","clone_url":"https://github.com/kubermatic/machine-controller.git","svn_url":"https://github.com/kubermatic/machine-controller","homepage":null,"size":10279,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":29,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403"},"html":{"href":"https://github.com/kubermatic/machine-controller/pull/403"},"issue":{"href":"https://api.github.com/repos/kubermatic/machine-controller/issues/403"},"comments":{"href":"https://api.github.com/repos/kubermatic/machine-controller/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/kubermatic/machine-controller/statuses/fd90455c2124132e243edf4dd37449a92fc7db87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jichenjc"}}