{"action":"opened","number":555,"pull_request":{"url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555","id":199851307,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODUxMzA3","html_url":"https://github.com/grails-plugins/grails-spring-security-core/pull/555","diff_url":"https://github.com/grails-plugins/grails-spring-security-core/pull/555.diff","patch_url":"https://github.com/grails-plugins/grails-spring-security-core/pull/555.patch","issue_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/555","number":555,"state":"open","locked":false,"title":"Issue #554: Grails params missing values with PUT and PATCH after add spring security core","user":{"login":"ddelponte","id":95676,"node_id":"MDQ6VXNlcjk1Njc2","avatar_url":"https://avatars3.githubusercontent.com/u/95676?v=4","gravatar_id":"","url":"https://api.github.com/users/ddelponte","html_url":"https://github.com/ddelponte","followers_url":"https://api.github.com/users/ddelponte/followers","following_url":"https://api.github.com/users/ddelponte/following{/other_user}","gists_url":"https://api.github.com/users/ddelponte/gists{/gist_id}","starred_url":"https://api.github.com/users/ddelponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddelponte/subscriptions","organizations_url":"https://api.github.com/users/ddelponte/orgs","repos_url":"https://api.github.com/users/ddelponte/repos","events_url":"https://api.github.com/users/ddelponte/events{/privacy}","received_events_url":"https://api.github.com/users/ddelponte/received_events","type":"User","site_admin":false},"body":"Issue #554: Grails params missing values with PUT and PATCH after add spring security core\r\n\r\nPUT requests with content-type `application/x-www-form-urlencoded` were not returning parameters when grails-spring-security-core was enabled.\r\n\r\nThe reason is that the `HttpPutFormContentFilter` was not registered.  Registering it allows for PUT requests to work as expected.\r\n\r\nThis commit registers the filter and updates existing tests that the change broke.\r\n\r\nSummary:\r\n\r\n- added `testCompile \"org.grails:grails-datastore-rest-client:5.0.0.RC2\"`to `build.gradle` so that I may have access to `RestBuilder` from within functional tests\r\n- added tests for `PUT` and `PATCH` requests that verify parameters are available for content-types of \"application/x-www-form-urlencoded\"\r\n- added a test controller for use during functional tests\r\n- fixed broken Travis CI build","created_at":"2018-07-06T21:28:53Z","updated_at":"2018-07-06T21:28:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555/commits","review_comments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555/comments","review_comment_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/555/comments","statuses_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/statuses/9274e824101f1ec36a922537a8f824491cd10e75","head":{"label":"grails-plugins:issue554","ref":"issue554","sha":"9274e824101f1ec36a922537a8f824491cd10e75","user":{"login":"grails-plugins","id":72412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/72412?v=4","gravatar_id":"","url":"https://api.github.com/users/grails-plugins","html_url":"https://github.com/grails-plugins","followers_url":"https://api.github.com/users/grails-plugins/followers","following_url":"https://api.github.com/users/grails-plugins/following{/other_user}","gists_url":"https://api.github.com/users/grails-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/grails-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails-plugins/subscriptions","organizations_url":"https://api.github.com/users/grails-plugins/orgs","repos_url":"https://api.github.com/users/grails-plugins/repos","events_url":"https://api.github.com/users/grails-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/grails-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":574359,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQzNTk=","name":"grails-spring-security-core","full_name":"grails-plugins/grails-spring-security-core","owner":{"login":"grails-plugins","id":72412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/72412?v=4","gravatar_id":"","url":"https://api.github.com/users/grails-plugins","html_url":"https://github.com/grails-plugins","followers_url":"https://api.github.com/users/grails-plugins/followers","following_url":"https://api.github.com/users/grails-plugins/following{/other_user}","gists_url":"https://api.github.com/users/grails-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/grails-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails-plugins/subscriptions","organizations_url":"https://api.github.com/users/grails-plugins/orgs","repos_url":"https://api.github.com/users/grails-plugins/repos","events_url":"https://api.github.com/users/grails-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/grails-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails-plugins/grails-spring-security-core","description":"Grails Spring Security Core Plugin","fork":false,"url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core","forks_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/forks","keys_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/teams","hooks_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/hooks","issue_events_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/events","assignees_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/tags","blobs_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/languages","stargazers_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/stargazers","contributors_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/contributors","subscribers_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/subscribers","subscription_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/subscription","commits_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/merges","archive_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/downloads","issues_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/labels{/name}","releases_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/releases{/id}","deployments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/deployments","created_at":"2010-03-22T17:44:03Z","updated_at":"2018-07-02T12:18:33Z","pushed_at":"2018-07-06T21:21:39Z","git_url":"git://github.com/grails-plugins/grails-spring-security-core.git","ssh_url":"git@github.com:grails-plugins/grails-spring-security-core.git","clone_url":"https://github.com/grails-plugins/grails-spring-security-core.git","svn_url":"https://github.com/grails-plugins/grails-spring-security-core","homepage":"","size":25831,"stargazers_count":220,"watchers_count":220,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":197,"open_issues":38,"watchers":220,"default_branch":"master"}},"base":{"label":"grails-plugins:master","ref":"master","sha":"60f8fe70cd7bad8ba017671bb0da9d8f85de2008","user":{"login":"grails-plugins","id":72412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/72412?v=4","gravatar_id":"","url":"https://api.github.com/users/grails-plugins","html_url":"https://github.com/grails-plugins","followers_url":"https://api.github.com/users/grails-plugins/followers","following_url":"https://api.github.com/users/grails-plugins/following{/other_user}","gists_url":"https://api.github.com/users/grails-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/grails-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails-plugins/subscriptions","organizations_url":"https://api.github.com/users/grails-plugins/orgs","repos_url":"https://api.github.com/users/grails-plugins/repos","events_url":"https://api.github.com/users/grails-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/grails-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":574359,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQzNTk=","name":"grails-spring-security-core","full_name":"grails-plugins/grails-spring-security-core","owner":{"login":"grails-plugins","id":72412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/72412?v=4","gravatar_id":"","url":"https://api.github.com/users/grails-plugins","html_url":"https://github.com/grails-plugins","followers_url":"https://api.github.com/users/grails-plugins/followers","following_url":"https://api.github.com/users/grails-plugins/following{/other_user}","gists_url":"https://api.github.com/users/grails-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/grails-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails-plugins/subscriptions","organizations_url":"https://api.github.com/users/grails-plugins/orgs","repos_url":"https://api.github.com/users/grails-plugins/repos","events_url":"https://api.github.com/users/grails-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/grails-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails-plugins/grails-spring-security-core","description":"Grails Spring Security Core Plugin","fork":false,"url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core","forks_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/forks","keys_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/teams","hooks_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/hooks","issue_events_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/events","assignees_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/tags","blobs_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/languages","stargazers_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/stargazers","contributors_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/contributors","subscribers_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/subscribers","subscription_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/subscription","commits_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/merges","archive_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/downloads","issues_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/labels{/name}","releases_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/releases{/id}","deployments_url":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/deployments","created_at":"2010-03-22T17:44:03Z","updated_at":"2018-07-02T12:18:33Z","pushed_at":"2018-07-06T21:21:39Z","git_url":"git://github.com/grails-plugins/grails-spring-security-core.git","ssh_url":"git@github.com:grails-plugins/grails-spring-security-core.git","clone_url":"https://github.com/grails-plugins/grails-spring-security-core.git","svn_url":"https://github.com/grails-plugins/grails-spring-security-core","homepage":"","size":25831,"stargazers_count":220,"watchers_count":220,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":197,"open_issues":38,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555"},"html":{"href":"https://github.com/grails-plugins/grails-spring-security-core/pull/555"},"issue":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/555"},"comments":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/grails-plugins/grails-spring-security-core/statuses/9274e824101f1ec36a922537a8f824491cd10e75"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":170,"deletions":6,"changed_files":7}}
{"actor":{"display_login":"ddelponte"}}