{"action":"created","issue":{"url":"https://api.github.com/repos/fossasia/pslab-android/issues/1197","repository_url":"https://api.github.com/repos/fossasia/pslab-android","labels_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1197/labels{/name}","comments_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1197/comments","events_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1197/events","html_url":"https://github.com/fossasia/pslab-android/pull/1197","id":339141894,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODk0NTQ1","number":1197,"title":"fix : implemented setting fragment inside setting activity","user":{"login":"Avjeet","id":20573611,"node_id":"MDQ6VXNlcjIwNTczNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/20573611?v=4","gravatar_id":"","url":"https://api.github.com/users/Avjeet","html_url":"https://github.com/Avjeet","followers_url":"https://api.github.com/users/Avjeet/followers","following_url":"https://api.github.com/users/Avjeet/following{/other_user}","gists_url":"https://api.github.com/users/Avjeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Avjeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avjeet/subscriptions","organizations_url":"https://api.github.com/users/Avjeet/orgs","repos_url":"https://api.github.com/users/Avjeet/repos","events_url":"https://api.github.com/users/Avjeet/events{/privacy}","received_events_url":"https://api.github.com/users/Avjeet/received_events","type":"User","site_admin":false},"labels":[{"id":945443198,"node_id":"MDU6TGFiZWw5NDU0NDMxOTg=","url":"https://api.github.com/repos/fossasia/pslab-android/labels/review-required","name":"review-required","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"Avjeet","id":20573611,"node_id":"MDQ6VXNlcjIwNTczNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/20573611?v=4","gravatar_id":"","url":"https://api.github.com/users/Avjeet","html_url":"https://github.com/Avjeet","followers_url":"https://api.github.com/users/Avjeet/followers","following_url":"https://api.github.com/users/Avjeet/following{/other_user}","gists_url":"https://api.github.com/users/Avjeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Avjeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avjeet/subscriptions","organizations_url":"https://api.github.com/users/Avjeet/orgs","repos_url":"https://api.github.com/users/Avjeet/repos","events_url":"https://api.github.com/users/Avjeet/events{/privacy}","received_events_url":"https://api.github.com/users/Avjeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"Avjeet","id":20573611,"node_id":"MDQ6VXNlcjIwNTczNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/20573611?v=4","gravatar_id":"","url":"https://api.github.com/users/Avjeet","html_url":"https://github.com/Avjeet","followers_url":"https://api.github.com/users/Avjeet/followers","following_url":"https://api.github.com/users/Avjeet/following{/other_user}","gists_url":"https://api.github.com/users/Avjeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Avjeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avjeet/subscriptions","organizations_url":"https://api.github.com/users/Avjeet/orgs","repos_url":"https://api.github.com/users/Avjeet/repos","events_url":"https://api.github.com/users/Avjeet/events{/privacy}","received_events_url":"https://api.github.com/users/Avjeet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-07-07T12:18:09Z","updated_at":"2018-07-13T21:36:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1197","html_url":"https://github.com/fossasia/pslab-android/pull/1197","diff_url":"https://github.com/fossasia/pslab-android/pull/1197.diff","patch_url":"https://github.com/fossasia/pslab-android/pull/1197.patch"},"body":"Fixes #1196 \r\nFirst steps in #1195 \r\n\r\n**Changes**: \r\n\r\n- Created new setting activity\r\n- Implemented setting fragment inside setting activity\r\n- Created setting option in menu for lux meter\r\n- Clicking setting in navigation now opens setting activity\r\n\r\nNow setting activity can be opened through any activity by simply using intents.\r\n\r\n**To do in further PR**\r\n\r\n- Create checkbox option in settings fragment to include the location in the csv file for sensors\r\n\r\n**Screenshot/s for the changes**: \r\nsetting option in overflow menu\r\n![image](https://user-images.githubusercontent.com/20573611/42410729-3d56c6aa-820c-11e8-9c95-0967b4749ef4.png)\r\n\r\n\r\n**Checklist**: [Please tick following check boxes with `[x]` if the respective task is completed]\r\n- [x] I have used resources from `strings.xml`, `dimens.xml` and `colors.xml` without hard-coding them\r\n- [x] No modifications done at the end of resource files `strings.xml`, `dimens.xml` or `colors.xml`\r\n- [x] I have reformatted code in every file included in this PR [<kbd>CTRL</kbd>+<kbd>ALT</kbd>+<kbd>L</kbd>]\r\n- [x] My code does not contain any extra lines or extra spaces\r\n- [x] I have requested reviews from other members\r\n\r\n**APK for testing**: \r\n[avi_setting.zip](https://github.com/fossasia/pslab-android/files/2173511/avi_setting.zip)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fossasia/pslab-android/issues/comments/404960429","html_url":"https://github.com/fossasia/pslab-android/pull/1197#issuecomment-404960429","issue_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1197","id":404960429,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDk2MDQyOQ==","user":{"login":"Avjeet","id":20573611,"node_id":"MDQ6VXNlcjIwNTczNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/20573611?v=4","gravatar_id":"","url":"https://api.github.com/users/Avjeet","html_url":"https://github.com/Avjeet","followers_url":"https://api.github.com/users/Avjeet/followers","following_url":"https://api.github.com/users/Avjeet/following{/other_user}","gists_url":"https://api.github.com/users/Avjeet/gists{/gist_id}","starred_url":"https://api.github.com/users/Avjeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avjeet/subscriptions","organizations_url":"https://api.github.com/users/Avjeet/orgs","repos_url":"https://api.github.com/users/Avjeet/repos","events_url":"https://api.github.com/users/Avjeet/events{/privacy}","received_events_url":"https://api.github.com/users/Avjeet/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T21:36:55Z","updated_at":"2018-07-13T21:36:55Z","author_association":"CONTRIBUTOR","body":"@harsh-2711 @abhinavraj23 @cweitat Plz review this all other PRs are dependent on this."}}
{"actor":{"display_login":"Avjeet"}}