{"action":"closed","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/11859","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/11859/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/11859/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/11859/events","html_url":"https://github.com/flutter/flutter/issues/11859","id":254171393,"number":11859,"title":"Many of our flutter widget tests are failing, when the widget under test is not wrapped in MaterialApp","user":{"login":"yyoon","id":1309817,"avatar_url":"https://avatars1.githubusercontent.com/u/1309817?v=4","gravatar_id":"","url":"https://api.github.com/users/yyoon","html_url":"https://github.com/yyoon","followers_url":"https://api.github.com/users/yyoon/followers","following_url":"https://api.github.com/users/yyoon/following{/other_user}","gists_url":"https://api.github.com/users/yyoon/gists{/gist_id}","starred_url":"https://api.github.com/users/yyoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyoon/subscriptions","organizations_url":"https://api.github.com/users/yyoon/orgs","repos_url":"https://api.github.com/users/yyoon/repos","events_url":"https://api.github.com/users/yyoon/events{/privacy}","received_events_url":"https://api.github.com/users/yyoon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-08-31T00:12:25Z","updated_at":"2018-05-18T20:43:08Z","closed_at":"2018-05-18T20:43:08Z","author_association":"CONTRIBUTOR","body":"## Steps to Reproduce\r\n\r\nI discovered that many of our flutter widget tests are broken, with a lot of exceptions generated like below:\r\nhttps://gist.github.com/yyoon/cdb7fd3dc7f408866c123bd1f25f754f\r\n\r\nThe above exceptions were generated by running the test file here:\r\nhttps://github.com/fuchsia-mirror/modules-email/blob/1296d9d0005092e3287c4afe350f306acefcefe9/modules/composer/test/message_text_input_test.dart\r\n\r\nI haven't tried this everywhere, wrapping the widget inside the `pumpWidget` call with a `MaterialApp` widget seems to resolve this issue.\r\n\r\nSince we can't run these tests in our CI yet, I don't know when this started to happen exactly.\r\n\r\nAnother related issue:\r\nThe [example test code](https://flutter.io/testing/#widget-testing) shown in the official webpage is also broken in a similar way. Wrapping the widget with a `Directionality` or a `MaterialApp` fixes the problem there.\r\n\r\n## Flutter Doctor\r\n\r\n```\r\n[✓] Flutter (on Linux, locale en_US.UTF-8, channel unknown)\r\n    • Flutter at /usr/local/google/home/youngseokyoon/Programming/fuchsia/lib/flutter\r\n    • Framework revision f0bf7b5c8c (2 hours ago), 2017-08-30 15:37:35 -0700\r\n    • Engine revision f9e00a7c72\r\n    • Tools Dart version 1.25.0-dev.11.0\r\n\r\n[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)\r\n    • Android SDK at /usr/local/google/home/youngseokyoon/Android/Sdk\r\n    • Platform android-25, build-tools 25.0.3\r\n    • Java binary at: /opt/android-studio-2.3/jre/bin/java\r\n    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)\r\n\r\n[✓] Android Studio (version 2.3)\r\n    • Android Studio at /opt/android-studio-2.3\r\n    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)\r\n\r\n[-] IntelliJ IDEA Community Edition (version 2017.1)\r\n    ✗ Flutter plugin version 13.1 - the recommended minimum version is 16.0.0\r\n    • Dart plugin version 171.4424\r\n    • For information about installing plugins, see\r\n      https://flutter.io/intellij-setup/#installing-the-plugins\r\n\r\n[✓] Connected devices\r\n    • None\r\n```\r\n"}}
{"actor":{"display_login":"Hixie"}}