{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/24350","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24350/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24350/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24350/events","html_url":"https://github.com/pandas-dev/pandas/pull/24350","id":392599283,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODMzODky","number":24350,"title":"ENH: ExtensionArray.searchsorted","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"labels":[{"id":849023693,"node_id":"MDU6TGFiZWw4NDkwMjM2OTM=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/ExtensionArray","name":"ExtensionArray","color":"6138b5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":1642,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-12-20T14:47:36Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"comments":3,"created_at":"2018-12-19T13:22:05Z","updated_at":"2018-12-20T18:20:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/24350","html_url":"https://github.com/pandas-dev/pandas/pull/24350","diff_url":"https://github.com/pandas-dev/pandas/pull/24350.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/24350.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/449090086","html_url":"https://github.com/pandas-dev/pandas/pull/24350#issuecomment-449090086","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/24350","id":449090086,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTA5MDA4Ng==","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T18:20:35Z","updated_at":"2018-12-20T18:20:35Z","author_association":"CONTRIBUTOR","body":"Hmm, I'm not sure what to do then. ExtensionArrays are more at the level of\nan ndarray than a Series.\n\n@shoyer, if I were writing an ExtensionArray that also wanted to implement\n`__array_function__`, is it OK for the name of positional arguments to\ndiffer?\n\nOn Thu, Dec 20, 2018 at 12:05 PM topper-123 <notifications@github.com>\nwrote:\n\n> *@topper-123* commented on this pull request.\n> ------------------------------\n>\n> In pandas/core/arrays/base.py\n> <https://github.com/pandas-dev/pandas/pull/24350#discussion_r243366588>:\n>\n> > @@ -505,6 +506,54 @@ def unique(self):\n>\n>          uniques = unique(self.astype(object))\n>\n>          return self._from_sequence(uniques, dtype=self.dtype)\n>\n>\n>\n> +    def searchsorted(self, v, side=\"left\", sorter=None):\n>\n>\n> Sorry, meant value, as that is the name used in Series.searchsorted and\n> various other searchsorted implementations in pandas (\n> Categorical.searchsorted at least, haven’t checked all impl.).\n>\n> I think it`s inconsistent to follow numpy naming here, when pandas’s is\n> better:-)\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/pandas-dev/pandas/pull/24350#discussion_r243366588>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABQHIsqBJDEwwMDdqbdFzQEupGtUfVF7ks5u69GFgaJpZM4ZaO7Y>\n> .\n>\n"}}
{"actor":{"display_login":"TomAugspurger"}}