{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/angular/issues/901","repository_url":"https://api.github.com/repos/dart-lang/angular","labels_url":"https://api.github.com/repos/dart-lang/angular/issues/901/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/angular/issues/901/comments","events_url":"https://api.github.com/repos/dart-lang/angular/issues/901/events","html_url":"https://github.com/dart-lang/angular/issues/901","id":297678016,"number":901,"title":"Eliminate arbitrary token types (not Type, not OpaqueToken)","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"labels":[{"id":623409198,"url":"https://api.github.com/repos/dart-lang/angular/labels/area:%20compiler","name":"area: compiler","color":"fad8c7","default":false},{"id":830394148,"url":"https://api.github.com/repos/dart-lang/angular/labels/%E2%98%95%20migrate%20internal%20users","name":"☕ migrate internal users","color":"a7eeef","default":false},{"id":623417530,"url":"https://api.github.com/repos/dart-lang/angular/labels/%E2%9B%91%20breaking%20change","name":"⛑ breaking change","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"assignees":[{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dart-lang/angular/milestones/5","html_url":"https://github.com/dart-lang/angular/milestone/5","labels_url":"https://api.github.com/repos/dart-lang/angular/milestones/5/labels","id":2516430,"number":5,"title":"=5.0.0","description":"","creator":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":38,"state":"open","created_at":"2017-05-12T00:02:16Z","updated_at":"2018-03-09T02:33:02Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-02-16T04:20:48Z","updated_at":"2018-03-09T05:38:34Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"From an internal customer after https://github.com/dart-lang/angular/pull/898/commits/6d37665ac2ba166727c6720994a887321797227d, they hit:\r\n\r\n> ```\r\n> Error: Constructor is not a 'const' constructor.\r\n>     const [const _ngRef.Inject(const SomeToken())],\r\n>                                      ^^^^^^^^^^\r\n> ```\r\n\r\nThis is a bug. We shouldn't have impacted existing code. They had code like this:\r\n\r\n```dart\r\n/// Annotation used to qualify [SomeToken] value.\r\nclass SomeToken {\r\n  const SomeToken();\r\n}\r\n\r\nvar providers = [\r\n   new Provider(prefix.SomeToken, useValue: someValue),\r\n];\r\n\r\n@Injectable()\r\nclass Service {\r\n  Service(@Inject(prefix.SomeToken) var someValue) { ... }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/dart-lang/angular/issues/comments/371718817","html_url":"https://github.com/dart-lang/angular/issues/901#issuecomment-371718817","issue_url":"https://api.github.com/repos/dart-lang/angular/issues/901","id":371718817,"user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T05:38:34Z","updated_at":"2018-03-09T05:38:34Z","author_association":"CONTRIBUTOR","body":"Down to the last 1-2 uses internally.\r\n\r\nI'll start on the PR that removes the test cases and throws instead."}}
{"actor":{"display_login":"matanlurey"}}