{"action":"created","comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/191398652","pull_request_review_id":123961084,"id":191398652,"diff_hunk":"@@ -0,0 +1,44 @@\n+{*\n+/**\n+ *\n+ * SugarCRM Community Edition is a customer relationship management program developed by","path":"include/SugarFields/Fields/Html/EditView.tpl","position":4,"original_position":4,"commit_id":"2f217a166f3f769b8f56af2434a3eec71a9c85f1","original_commit_id":"2f217a166f3f769b8f56af2434a3eec71a9c85f1","user":{"login":"Dillon-Brown","id":26431166,"avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"body":"I'm not entirely certain but it's my understanding that any modifications to core (even if it's a new file) would \"inherit\" the AGPL and thus require the license. Definitely something to investigate / discuss further though!","created_at":"2018-05-29T12:06:31Z","updated_at":"2018-05-29T12:06:31Z","html_url":"https://github.com/salesagility/SuiteCRM/pull/5945#discussion_r191398652","pull_request_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/191398652"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5945#discussion_r191398652"},"pull_request":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945"}},"in_reply_to_id":191371220},"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945","id":190614817,"html_url":"https://github.com/salesagility/SuiteCRM/pull/5945","diff_url":"https://github.com/salesagility/SuiteCRM/pull/5945.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/5945.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5945","number":5945,"state":"open","locked":false,"title":"Makes html fields non editable and disables inline edit box in studio","user":{"login":"PedroErnst","id":34056696,"avatar_url":"https://avatars0.githubusercontent.com/u/34056696?v=4","gravatar_id":"","url":"https://api.github.com/users/PedroErnst","html_url":"https://github.com/PedroErnst","followers_url":"https://api.github.com/users/PedroErnst/followers","following_url":"https://api.github.com/users/PedroErnst/following{/other_user}","gists_url":"https://api.github.com/users/PedroErnst/gists{/gist_id}","starred_url":"https://api.github.com/users/PedroErnst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PedroErnst/subscriptions","organizations_url":"https://api.github.com/users/PedroErnst/orgs","repos_url":"https://api.github.com/users/PedroErnst/repos","events_url":"https://api.github.com/users/PedroErnst/events{/privacy}","received_events_url":"https://api.github.com/users/PedroErnst/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nReverses a recent change which made html fields editable / not display their static content.\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nHtml fields are designed just to show pre defined html, not to be editable.\r\nWith this change html fields will display their static value in detail and editview, and inline editing will be disabled by default.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nFixes #4957 \r\nFixes #3400 \r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-05-25T14:58:27Z","updated_at":"2018-05-29T12:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0828f0ca000beb1613e12041f4f1ded16475f5d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":488084356,"url":"https://api.github.com/repos/salesagility/SuiteCRM/labels/Assessed","name":"Assessed","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5945/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/2f217a166f3f769b8f56af2434a3eec71a9c85f1","head":{"label":"PedroErnst:fix/4957-html-fields-display","ref":"fix/4957-html-fields-display","sha":"2f217a166f3f769b8f56af2434a3eec71a9c85f1","user":{"login":"PedroErnst","id":34056696,"avatar_url":"https://avatars0.githubusercontent.com/u/34056696?v=4","gravatar_id":"","url":"https://api.github.com/users/PedroErnst","html_url":"https://github.com/PedroErnst","followers_url":"https://api.github.com/users/PedroErnst/followers","following_url":"https://api.github.com/users/PedroErnst/following{/other_user}","gists_url":"https://api.github.com/users/PedroErnst/gists{/gist_id}","starred_url":"https://api.github.com/users/PedroErnst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PedroErnst/subscriptions","organizations_url":"https://api.github.com/users/PedroErnst/orgs","repos_url":"https://api.github.com/users/PedroErnst/repos","events_url":"https://api.github.com/users/PedroErnst/events{/privacy}","received_events_url":"https://api.github.com/users/PedroErnst/received_events","type":"User","site_admin":false},"repo":{"id":113328484,"name":"SuiteCRM","full_name":"PedroErnst/SuiteCRM","owner":{"login":"PedroErnst","id":34056696,"avatar_url":"https://avatars0.githubusercontent.com/u/34056696?v=4","gravatar_id":"","url":"https://api.github.com/users/PedroErnst","html_url":"https://github.com/PedroErnst","followers_url":"https://api.github.com/users/PedroErnst/followers","following_url":"https://api.github.com/users/PedroErnst/following{/other_user}","gists_url":"https://api.github.com/users/PedroErnst/gists{/gist_id}","starred_url":"https://api.github.com/users/PedroErnst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PedroErnst/subscriptions","organizations_url":"https://api.github.com/users/PedroErnst/orgs","repos_url":"https://api.github.com/users/PedroErnst/repos","events_url":"https://api.github.com/users/PedroErnst/events{/privacy}","received_events_url":"https://api.github.com/users/PedroErnst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PedroErnst/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/PedroErnst/SuiteCRM","forks_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/forks","keys_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/events","assignees_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/merges","archive_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/PedroErnst/SuiteCRM/deployments","created_at":"2017-12-06T14:46:33Z","updated_at":"2018-03-16T13:59:32Z","pushed_at":"2018-05-29T11:05:39Z","git_url":"git://github.com/PedroErnst/SuiteCRM.git","ssh_url":"git@github.com:PedroErnst/SuiteCRM.git","clone_url":"https://github.com/PedroErnst/SuiteCRM.git","svn_url":"https://github.com/PedroErnst/SuiteCRM","homepage":"http://www.suitecrm.com","size":92551,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"7fe45afea523954821c597a27661063fd2fa3d68","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-05-29T01:24:01Z","pushed_at":"2018-05-29T12:04:03Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":92069,"stargazers_count":1015,"watchers_count":1015,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":800,"mirror_url":null,"archived":false,"open_issues_count":970,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":800,"open_issues":970,"watchers":1015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5945"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5945"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5945/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5945/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/2f217a166f3f769b8f56af2434a3eec71a9c85f1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Dillon-Brown"}}