{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/186123294","pull_request_review_id":117656128,"id":186123294,"diff_hunk":"@@ -306,35 +306,27 @@ For more information, see xref:../troubleshooting/troubleshooting-driver-plugins\n \n . Verify that you pair the virtual switch with a network card (wired or wireless) that is connected to the network.\n \n-. Set the environment variable `HYPERV_VIRTUAL_SWITCH` to the name of the external virtual switch you want to use for {project}.\n+. Use the configuration option `hyperv-virtual-switch` or startup flag `--hyperv-virtual-switch` to set the name of the external virtual switch you want to use for {project}.\n +\n-For example, on Command Prompt use:\n+For example, on PowerShell use\n +\n ----\n-C:\\> set HYPERV_VIRTUAL_SWITCH=External (Wireless)\n+PS> minishift config set hyperv-virtual-switch \"External (Wireless)\"\n ----\n-+\n-Note that using quotes in Command Prompt results in the following error:\n-+\n-----\n-C:\\> set HYPERV_VIRTUAL_SWITCH=\"External (Wireless)\"\n-Error creating the VM. Error with pre-create check: \"vswitch \\\"\\\\\\\"External (Wireless)\\\\\\\"\\\" not found\"\n-----\n-+\n-PowerShell, however, requires the quotes:\n+or\n +\n ----\n-PS> $env:HYPERV_VIRTUAL_SWITCH=\"External (Wireless)\"\n+PS> minishift start --hyperv-virtual-switch \"External (Wireless)\"\n ----\n +\n-Using `set` in Command Prompt or `$env` in PowerShell will only affect the currently running shell session.\n-You may use the `setx` utility to persist this environment variable across shell instances and system restarts.\n-Quotes must be used with `setx` for both Command Prompt and PowerShell.\n-For example:\n-+\n-----\n-C:\\> setx HYPERV_VIRTUAL_SWITCH \"External (Wireless)\"\n-----\n+[NOTE]\n+====\n+The use of the environment variable `HYPERV_VIRTUAL_SWITCH` has been deprecated. Instead `MINISHIFT_HYPERV_VIRTUAL_SWITCH` can be used as a configuration option, although this is not recommended as environment variables on Windows do not support non-ASCII characters.\n+====\n+[NOTE]","path":"docs/source/getting-started/setting-up-virtualization-environment.adoc","position":42,"original_position":42,"commit_id":"a58bf5b54f35dcb81a3664eceadc390e93912d88","original_commit_id":"a58bf5b54f35dcb81a3664eceadc390e93912d88","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2018-05-04T15:45:12Z","updated_at":"2018-05-04T15:45:12Z","html_url":"https://github.com/minishift/minishift/pull/2291#discussion_r186123294","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/2291","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/186123294"},"html":{"href":"https://github.com/minishift/minishift/pull/2291#discussion_r186123294"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2291"}},"in_reply_to_id":184987234},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/2291","id":181784332,"html_url":"https://github.com/minishift/minishift/pull/2291","diff_url":"https://github.com/minishift/minishift/pull/2291.diff","patch_url":"https://github.com/minishift/minishift/pull/2291.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/2291","number":2291,"state":"open","locked":false,"title":"Issue #2258 Use config option for Virtual Switch","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"Fixes #2258 \r\n\r\nNote: using same option names as minikube...","created_at":"2018-04-16T08:20:21Z","updated_at":"2018-05-04T15:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"737edb2516042c5bfab239f4a9b7e38b714b67b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/2291/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/2291/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/2291/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/a58bf5b54f35dcb81a3664eceadc390e93912d88","head":{"label":"gbraad:hyperv-config","ref":"hyperv-config","sha":"a58bf5b54f35dcb81a3664eceadc390e93912d88","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"repo":{"id":69309326,"name":"minishift","full_name":"gbraad/minishift","owner":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbraad/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/gbraad/minishift","forks_url":"https://api.github.com/repos/gbraad/minishift/forks","keys_url":"https://api.github.com/repos/gbraad/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbraad/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbraad/minishift/teams","hooks_url":"https://api.github.com/repos/gbraad/minishift/hooks","issue_events_url":"https://api.github.com/repos/gbraad/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/gbraad/minishift/events","assignees_url":"https://api.github.com/repos/gbraad/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/gbraad/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/gbraad/minishift/tags","blobs_url":"https://api.github.com/repos/gbraad/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbraad/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbraad/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbraad/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbraad/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/gbraad/minishift/languages","stargazers_url":"https://api.github.com/repos/gbraad/minishift/stargazers","contributors_url":"https://api.github.com/repos/gbraad/minishift/contributors","subscribers_url":"https://api.github.com/repos/gbraad/minishift/subscribers","subscription_url":"https://api.github.com/repos/gbraad/minishift/subscription","commits_url":"https://api.github.com/repos/gbraad/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbraad/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbraad/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbraad/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbraad/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/gbraad/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbraad/minishift/merges","archive_url":"https://api.github.com/repos/gbraad/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbraad/minishift/downloads","issues_url":"https://api.github.com/repos/gbraad/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/gbraad/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/gbraad/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/gbraad/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbraad/minishift/labels{/name}","releases_url":"https://api.github.com/repos/gbraad/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/gbraad/minishift/deployments","created_at":"2016-09-27T01:55:22Z","updated_at":"2017-08-10T04:00:14Z","pushed_at":"2018-05-04T12:26:47Z","git_url":"git://github.com/gbraad/minishift.git","ssh_url":"git@github.com:gbraad/minishift.git","clone_url":"https://github.com/gbraad/minishift.git","svn_url":"https://github.com/gbraad/minishift","homepage":null,"size":159981,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"fork"}},"base":{"label":"minishift:master","ref":"master","sha":"1dce6615497d013cdd218f027728fa7e84d2a78d","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2018-05-04T12:31:37Z","pushed_at":"2018-05-04T12:31:35Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":159921,"stargazers_count":994,"watchers_count":994,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":222,"open_issues":212,"watchers":994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2291"},"html":{"href":"https://github.com/minishift/minishift/pull/2291"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/2291"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/2291/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2291/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2291/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/a58bf5b54f35dcb81a3664eceadc390e93912d88"}},"author_association":"OWNER"}}
{"actor":{"display_login":"gbraad"}}