{"action":"created","comment":{"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/comments/177616580","pull_request_review_id":107519190,"id":177616580,"diff_hunk":"@@ -170,18 +188,42 @@ app.get('/server/questions', questionAuthoringAuth, function(request, response){\n \n \n // Write audio responses\n-app.post('/teachermoments/wav', AudioEndpoints.post(s3));\n+app.post('/teachermoments/wav', AudioEndpoints.post(config.s3));\n \n \n // Related to the read path for reviewing responses, and for fetching audio files\n-app.post('/server/reviews/create', ReviewLoginEndpoint.createReview({queryDatabase, mailgunEnv}));","path":"server/index.js","position":49,"original_position":49,"commit_id":"dfa68d2dddf8970aa3952739c2128d707c069f89","original_commit_id":"6563ae281ab12b6df94768f054c95973c42c39a1","user":{"login":"keving17","id":11862658,"avatar_url":"https://avatars0.githubusercontent.com/u/11862658?v=4","gravatar_id":"","url":"https://api.github.com/users/keving17","html_url":"https://github.com/keving17","followers_url":"https://api.github.com/users/keving17/followers","following_url":"https://api.github.com/users/keving17/following{/other_user}","gists_url":"https://api.github.com/users/keving17/gists{/gist_id}","starred_url":"https://api.github.com/users/keving17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keving17/subscriptions","organizations_url":"https://api.github.com/users/keving17/orgs","repos_url":"https://api.github.com/users/keving17/repos","events_url":"https://api.github.com/users/keving17/events{/privacy}","received_events_url":"https://api.github.com/users/keving17/received_events","type":"User","site_admin":false},"body":"ahh yes, I talked a bit about this with relation to the mailgunEnv and s3 variables. After moving those within the config, these calls broke when I used config.mailgunEnv instead of mailgunEnv. I don't really understand what restrictions the curly brackets enforce but I noticed that by removing the curly brackets, things worked fine again. I'm still not sure why this happens so if we feel strongly about having the curly brackets, I can look into this more?","created_at":"2018-03-28T01:17:16Z","updated_at":"2018-03-28T01:17:16Z","html_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348#discussion_r177616580","pull_request_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/comments/177616580"},"html":{"href":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348#discussion_r177616580"},"pull_request":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348"}},"in_reply_to_id":176394341},"pull_request":{"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348","id":176054025,"html_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348","diff_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348.diff","patch_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348.patch","issue_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/348","number":348,"state":"open","locked":false,"title":"Feature/authentication","user":{"login":"keving17","id":11862658,"avatar_url":"https://avatars0.githubusercontent.com/u/11862658?v=4","gravatar_id":"","url":"https://api.github.com/users/keving17","html_url":"https://github.com/keving17","followers_url":"https://api.github.com/users/keving17/followers","following_url":"https://api.github.com/users/keving17/following{/other_user}","gists_url":"https://api.github.com/users/keving17/gists{/gist_id}","starred_url":"https://api.github.com/users/keving17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keving17/subscriptions","organizations_url":"https://api.github.com/users/keving17/orgs","repos_url":"https://api.github.com/users/keving17/repos","events_url":"https://api.github.com/users/keving17/events{/privacy}","received_events_url":"https://api.github.com/users/keving17/received_events","type":"User","site_admin":false},"body":"This pull request fixes the authentication feature that was pushed earlier. CSS formatting and configuration is fixed so the login portal is functional. When someone logs in, they should be able to access data directly from the online database. For now, I've limited this to only pull data with the location \"localhost:3000/teachermoments/turner?KevinTesting20180319\"\r\n\r\nAccessing my test data\r\n<img width=\"1427\" alt=\"screen shot 2018-03-19 at 7 18 47 pm\" src=\"https://user-images.githubusercontent.com/11862658/37627473-f36c7ba0-2baa-11e8-9c5b-57fbabc2900e.png\">\r\n\r\nNo access to other data\r\n<img width=\"840\" alt=\"screen shot 2018-03-19 at 7 38 40 pm\" src=\"https://user-images.githubusercontent.com/11862658/37627923-2868b830-2bad-11e8-8fb0-501f33c8a75a.png\">\r\n\r\nSomething that I am unsure about is how to get the consent-latest.json file into the system.","created_at":"2018-03-19T23:39:44Z","updated_at":"2018-03-28T01:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2995a197f7764026bd99a7b9c15f5d1f7a3bea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348/commits","review_comments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348/comments","review_comment_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/348/comments","statuses_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/statuses/dfa68d2dddf8970aa3952739c2128d707c069f89","head":{"label":"mit-teaching-systems-lab:feature/authentication","ref":"feature/authentication","sha":"dfa68d2dddf8970aa3952739c2128d707c069f89","user":{"login":"mit-teaching-systems-lab","id":19670919,"avatar_url":"https://avatars3.githubusercontent.com/u/19670919?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-teaching-systems-lab","html_url":"https://github.com/mit-teaching-systems-lab","followers_url":"https://api.github.com/users/mit-teaching-systems-lab/followers","following_url":"https://api.github.com/users/mit-teaching-systems-lab/following{/other_user}","gists_url":"https://api.github.com/users/mit-teaching-systems-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-teaching-systems-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-teaching-systems-lab/subscriptions","organizations_url":"https://api.github.com/users/mit-teaching-systems-lab/orgs","repos_url":"https://api.github.com/users/mit-teaching-systems-lab/repos","events_url":"https://api.github.com/users/mit-teaching-systems-lab/events{/privacy}","received_events_url":"https://api.github.com/users/mit-teaching-systems-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":61143637,"name":"threeflows","full_name":"mit-teaching-systems-lab/threeflows","owner":{"login":"mit-teaching-systems-lab","id":19670919,"avatar_url":"https://avatars3.githubusercontent.com/u/19670919?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-teaching-systems-lab","html_url":"https://github.com/mit-teaching-systems-lab","followers_url":"https://api.github.com/users/mit-teaching-systems-lab/followers","following_url":"https://api.github.com/users/mit-teaching-systems-lab/following{/other_user}","gists_url":"https://api.github.com/users/mit-teaching-systems-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-teaching-systems-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-teaching-systems-lab/subscriptions","organizations_url":"https://api.github.com/users/mit-teaching-systems-lab/orgs","repos_url":"https://api.github.com/users/mit-teaching-systems-lab/repos","events_url":"https://api.github.com/users/mit-teaching-systems-lab/events{/privacy}","received_events_url":"https://api.github.com/users/mit-teaching-systems-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-teaching-systems-lab/threeflows","description":"Practice spaces for teacher preparation programs","fork":false,"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows","forks_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/forks","keys_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/teams","hooks_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/hooks","issue_events_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/events{/number}","events_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/events","assignees_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/assignees{/user}","branches_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/branches{/branch}","tags_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/tags","blobs_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/languages","stargazers_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/stargazers","contributors_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/contributors","subscribers_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/subscribers","subscription_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/subscription","commits_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/contents/{+path}","compare_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/merges","archive_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/downloads","issues_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues{/number}","pulls_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/labels{/name}","releases_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/releases{/id}","deployments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/deployments","created_at":"2016-06-14T17:49:59Z","updated_at":"2018-03-14T01:31:23Z","pushed_at":"2018-03-28T00:21:22Z","git_url":"git://github.com/mit-teaching-systems-lab/threeflows.git","ssh_url":"git@github.com:mit-teaching-systems-lab/threeflows.git","clone_url":"https://github.com/mit-teaching-systems-lab/threeflows.git","svn_url":"https://github.com/mit-teaching-systems-lab/threeflows","homepage":"http://tsl.mit.edu/practice-spaces-for-teacher-preparation/","size":4265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-teaching-systems-lab:master","ref":"master","sha":"89e53bbcda55cf4c0c184fc7176b6c21a23f03bd","user":{"login":"mit-teaching-systems-lab","id":19670919,"avatar_url":"https://avatars3.githubusercontent.com/u/19670919?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-teaching-systems-lab","html_url":"https://github.com/mit-teaching-systems-lab","followers_url":"https://api.github.com/users/mit-teaching-systems-lab/followers","following_url":"https://api.github.com/users/mit-teaching-systems-lab/following{/other_user}","gists_url":"https://api.github.com/users/mit-teaching-systems-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-teaching-systems-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-teaching-systems-lab/subscriptions","organizations_url":"https://api.github.com/users/mit-teaching-systems-lab/orgs","repos_url":"https://api.github.com/users/mit-teaching-systems-lab/repos","events_url":"https://api.github.com/users/mit-teaching-systems-lab/events{/privacy}","received_events_url":"https://api.github.com/users/mit-teaching-systems-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":61143637,"name":"threeflows","full_name":"mit-teaching-systems-lab/threeflows","owner":{"login":"mit-teaching-systems-lab","id":19670919,"avatar_url":"https://avatars3.githubusercontent.com/u/19670919?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-teaching-systems-lab","html_url":"https://github.com/mit-teaching-systems-lab","followers_url":"https://api.github.com/users/mit-teaching-systems-lab/followers","following_url":"https://api.github.com/users/mit-teaching-systems-lab/following{/other_user}","gists_url":"https://api.github.com/users/mit-teaching-systems-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-teaching-systems-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-teaching-systems-lab/subscriptions","organizations_url":"https://api.github.com/users/mit-teaching-systems-lab/orgs","repos_url":"https://api.github.com/users/mit-teaching-systems-lab/repos","events_url":"https://api.github.com/users/mit-teaching-systems-lab/events{/privacy}","received_events_url":"https://api.github.com/users/mit-teaching-systems-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-teaching-systems-lab/threeflows","description":"Practice spaces for teacher preparation programs","fork":false,"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows","forks_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/forks","keys_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/teams","hooks_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/hooks","issue_events_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/events{/number}","events_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/events","assignees_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/assignees{/user}","branches_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/branches{/branch}","tags_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/tags","blobs_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/languages","stargazers_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/stargazers","contributors_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/contributors","subscribers_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/subscribers","subscription_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/subscription","commits_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/contents/{+path}","compare_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/merges","archive_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/downloads","issues_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues{/number}","pulls_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/labels{/name}","releases_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/releases{/id}","deployments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/deployments","created_at":"2016-06-14T17:49:59Z","updated_at":"2018-03-14T01:31:23Z","pushed_at":"2018-03-28T00:21:22Z","git_url":"git://github.com/mit-teaching-systems-lab/threeflows.git","ssh_url":"git@github.com:mit-teaching-systems-lab/threeflows.git","clone_url":"https://github.com/mit-teaching-systems-lab/threeflows.git","svn_url":"https://github.com/mit-teaching-systems-lab/threeflows","homepage":"http://tsl.mit.edu/practice-spaces-for-teacher-preparation/","size":4265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348"},"html":{"href":"https://github.com/mit-teaching-systems-lab/threeflows/pull/348"},"issue":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/348"},"comments":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/statuses/dfa68d2dddf8970aa3952739c2128d707c069f89"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keving17"}}