{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/styx/issues/602","repository_url":"https://api.github.com/repos/spotify/styx","labels_url":"https://api.github.com/repos/spotify/styx/issues/602/labels{/name}","comments_url":"https://api.github.com/repos/spotify/styx/issues/602/comments","events_url":"https://api.github.com/repos/spotify/styx/issues/602/events","html_url":"https://github.com/spotify/styx/pull/602","id":365941123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzM3MDI3","number":602,"title":"Unhalt backfill","user":{"login":"honnix","id":158892,"node_id":"MDQ6VXNlcjE1ODg5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/158892?v=4","gravatar_id":"","url":"https://api.github.com/users/honnix","html_url":"https://github.com/honnix","followers_url":"https://api.github.com/users/honnix/followers","following_url":"https://api.github.com/users/honnix/following{/other_user}","gists_url":"https://api.github.com/users/honnix/gists{/gist_id}","starred_url":"https://api.github.com/users/honnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honnix/subscriptions","organizations_url":"https://api.github.com/users/honnix/orgs","repos_url":"https://api.github.com/users/honnix/repos","events_url":"https://api.github.com/users/honnix/events{/privacy}","received_events_url":"https://api.github.com/users/honnix/received_events","type":"User","site_admin":false},"labels":[{"id":1054146289,"node_id":"MDU6TGFiZWwxMDU0MTQ2Mjg5","url":"https://api.github.com/repos/spotify/styx/labels/wip","name":"wip","color":"f7df0c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-02T15:01:24Z","updated_at":"2018-10-11T10:53:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spotify/styx/pulls/602","html_url":"https://github.com/spotify/styx/pull/602","diff_url":"https://github.com/spotify/styx/pull/602.diff","patch_url":"https://github.com/spotify/styx/pull/602.patch"},"body":"# Hey, I just made a Pull Request!\r\n\r\n## Description\r\n<!--- Describe your changes -->\r\nSupport unhalting a halted backfill.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nUsers halt a running backfill for certain reason and afterwards might want to unhalt it instead of creating a new one and trying to figure out what partitions have been backfilled already manually.\r\n\r\nA caveat is halted instances will NOT be revived. So this unhalting may not be that useful after all.\r\n\r\n## Have you tested this? If so, how?\r\n<!--- Valid responses are \"I have included unit tests.\" or --> \r\n<!--- \"I ran my jobs with this code and it works for me.\" -->\r\nunit test and running cil manually.\r\n\r\n## Checklist for PR author(s)\r\n<!--- Put an `x` in all the boxes that apply: -->\r\n- [x] Changes are covered by unit test\r\n- [ ] All tests pass\r\n- [ ] Code coverage check passes\r\n- [ ] Error handling is tested\r\n- [ ] Errors are handled at the appropriate layer\r\n- [ ] Errors that cannot be handled where they occur are propagated\r\n- [ ] (optional) Changes are covered by system test\r\n- [ ] Relevant documentation updated\r\n- [ ] This PR has NO breaking change to public API\r\n- [ ] This PR has breaking change to public API and it is documented\r\n\r\n## Checklist for PR reviewer(s)\r\n<!--- Put an `x` in all the boxes that apply: -->\r\n- [ ] This PR has been incorporated in release note for the coming version\r\n- [ ] Risky changes introduced by this PR have been all considered\r\n\r\n<!---\r\nfor more information on how to submit valuable contributions,\r\nsee https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/spotify/styx/issues/comments/428911090","html_url":"https://github.com/spotify/styx/pull/602#issuecomment-428911090","issue_url":"https://api.github.com/repos/spotify/styx/issues/602","id":428911090,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODkxMTA5MA==","user":{"login":"honnix","id":158892,"node_id":"MDQ6VXNlcjE1ODg5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/158892?v=4","gravatar_id":"","url":"https://api.github.com/users/honnix","html_url":"https://github.com/honnix","followers_url":"https://api.github.com/users/honnix/followers","following_url":"https://api.github.com/users/honnix/following{/other_user}","gists_url":"https://api.github.com/users/honnix/gists{/gist_id}","starred_url":"https://api.github.com/users/honnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honnix/subscriptions","organizations_url":"https://api.github.com/users/honnix/orgs","repos_url":"https://api.github.com/users/honnix/repos","events_url":"https://api.github.com/users/honnix/events{/privacy}","received_events_url":"https://api.github.com/users/honnix/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T10:53:25Z","updated_at":"2018-10-11T10:53:25Z","author_association":"CONTRIBUTOR","body":"Basically users don't want to have that bad caveat. However halting backfill without halting instances are also bad because that would leave those instances running for nothing; and after resuming, those instances may have already finished (with wrong logic possibly)."}}
{"actor":{"display_login":"honnix"}}