{"action":"created","issue":{"url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/756","repository_url":"https://api.github.com/repos/30-seconds/30-seconds-of-code","labels_url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/756/labels{/name}","comments_url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/756/comments","events_url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/756/events","html_url":"https://github.com/30-seconds/30-seconds-of-code/pull/756","id":365006639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDU5MzUw","number":756,"title":"Avoid confusing prototype methods for static methods","user":{"login":"mathiasbynens","id":81942,"node_id":"MDQ6VXNlcjgxOTQy","avatar_url":"https://avatars1.githubusercontent.com/u/81942?v=4","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T19:07:25Z","updated_at":"2018-09-28T19:42:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/pulls/756","html_url":"https://github.com/30-seconds/30-seconds-of-code/pull/756","diff_url":"https://github.com/30-seconds/30-seconds-of-code/pull/756.diff","patch_url":"https://github.com/30-seconds/30-seconds-of-code/pull/756.patch"},"body":"This repository confuses static methods such as `Array.from` with prototype methods such as `Array.prototype.join` by describing them using the same notation:\r\n\r\n- `Array.from` (correct)\r\n- `Array.join` (incorrect/confusing)\r\n\r\nThis patch uses the common `#` notation to denote `.prototype.`:\r\n\r\n- `Array.from`\r\n- `Array#join`\r\n\r\n\r\n<!-- Use a descriptive title, prefix it with [FIX], [FEATURE] or [ENHANCEMENT] if applicable (use only one) -->\r\n\r\n## Description\r\n<!-- Write a detailed description of your changes/additions here -->\r\n<!-- If your PR resolves an issue, please state \"Resolves #(issue number)\" to help maintainers process it faster -->\r\n<!-- If you think your PR will cause breaking changes, require changes in the documention etc, please be so kind as to explain what, where and how -->\r\n\r\n## PR Type\r\n- [x] Snippets, Tests & Tags (new snippets, updated snippets, re-tagging of snippets, added/updated tests)\r\n- [ ] Scripts & Website & Meta (anything related to files in the [scripts folder](https://github.com/30-seconds/30-seconds-of-code/tree/master/scripts), how the repository's automated procedures work and the website)\r\n- [ ] Glossary & Secondary Features (anything related to the glossary, such as new or updated terms or other secondary features)\r\n- [x] General, Typos, Misc. & Meta (everything else, typos, general stuff and meta files in the repository - e.g. the issue template)\r\n\r\n## Guidelines\r\n- [x] I have read the guidelines in the [CONTRIBUTING](https://github.com/30-seconds/30-seconds-of-code/blob/master/CONTRIBUTING.md) document. \r\n"},"comment":{"url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/comments/425544992","html_url":"https://github.com/30-seconds/30-seconds-of-code/pull/756#issuecomment-425544992","issue_url":"https://api.github.com/repos/30-seconds/30-seconds-of-code/issues/756","id":425544992,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTU0NDk5Mg==","user":{"login":"mathiasbynens","id":81942,"node_id":"MDQ6VXNlcjgxOTQy","avatar_url":"https://avatars1.githubusercontent.com/u/81942?v=4","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T19:42:21Z","updated_at":"2018-09-28T19:42:21Z","author_association":"NONE","body":"Done."}}
{"actor":{"display_login":"mathiasbynens"}}