{"action":"closed","number":3406,"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3406","id":206739638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzM5NjM4","html_url":"https://github.com/tikv/tikv/pull/3406","diff_url":"https://github.com/tikv/tikv/pull/3406.diff","patch_url":"https://github.com/tikv/tikv/pull/3406.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3406","number":3406,"state":"closed","locked":false,"title":"expr/builtin_fncall: implement math.Sin","user":{"login":"liufuyang","id":161689,"node_id":"MDQ6VXNlcjE2MTY4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/161689?v=4","gravatar_id":"","url":"https://api.github.com/users/liufuyang","html_url":"https://github.com/liufuyang","followers_url":"https://api.github.com/users/liufuyang/followers","following_url":"https://api.github.com/users/liufuyang/following{/other_user}","gists_url":"https://api.github.com/users/liufuyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liufuyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liufuyang/subscriptions","organizations_url":"https://api.github.com/users/liufuyang/orgs","repos_url":"https://api.github.com/users/liufuyang/repos","events_url":"https://api.github.com/users/liufuyang/events{/privacy}","received_events_url":"https://api.github.com/users/liufuyang/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nPlease explain **IN DETAIL** what the changes are in this PR and why they are needed:\r\n- add math.Sin, as suggested [here](https://pingcap.github.io/blog/adding-built-in-functions-to-tikv/)\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\nThe currently defined types are listed below, please pick one of the types for this PR by removing the others:\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nunit test\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nno\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nno\r\n\r\n## Refer to a related PR or issue link (optional)\r\nhttps://github.com/tikv/tikv/issues/3275\r\n\r\nThe related source in tidb: https://github.com/pingcap/tidb/blob/55d8eff75859814114f9c6aa3efe2e3f69f7981f/expression/builtin_math.go#L1676\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n","created_at":"2018-08-07T15:32:36Z","updated_at":"2018-09-03T23:48:32Z","closed_at":"2018-09-03T23:48:32Z","merged_at":"2018-09-03T23:48:32Z","merge_commit_sha":"aa01f25437abd8c8f9a0b4d84e881a8fb976dd65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hicqu","id":8407317,"node_id":"MDQ6VXNlcjg0MDczMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":526233180,"node_id":"MDU6TGFiZWw1MjYyMzMxODA=","url":"https://api.github.com/repos/tikv/tikv/labels/C:%20Copr","name":"C: Copr","color":"9df9d7","default":false},{"id":1015578892,"node_id":"MDU6TGFiZWwxMDE1NTc4ODky","url":"https://api.github.com/repos/tikv/tikv/labels/S:%20LGT1","name":"S: LGT1","color":"fbca04","default":false},{"id":1013338313,"node_id":"MDU6TGFiZWwxMDEzMzM4MzEz","url":"https://api.github.com/repos/tikv/tikv/labels/T:%20Contributor","name":"T: Contributor","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3406/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3406/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3406/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/b95b3500ec57b07bdee03fcbb5eeff65be3327ba","head":{"label":"liufuyang:tidb-buildin-math-sin-to-tikv","ref":"tidb-buildin-math-sin-to-tikv","sha":"b95b3500ec57b07bdee03fcbb5eeff65be3327ba","user":{"login":"liufuyang","id":161689,"node_id":"MDQ6VXNlcjE2MTY4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/161689?v=4","gravatar_id":"","url":"https://api.github.com/users/liufuyang","html_url":"https://github.com/liufuyang","followers_url":"https://api.github.com/users/liufuyang/followers","following_url":"https://api.github.com/users/liufuyang/following{/other_user}","gists_url":"https://api.github.com/users/liufuyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liufuyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liufuyang/subscriptions","organizations_url":"https://api.github.com/users/liufuyang/orgs","repos_url":"https://api.github.com/users/liufuyang/repos","events_url":"https://api.github.com/users/liufuyang/events{/privacy}","received_events_url":"https://api.github.com/users/liufuyang/received_events","type":"User","site_admin":false},"repo":{"id":143872433,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4NzI0MzM=","name":"tikv","full_name":"liufuyang/tikv","owner":{"login":"liufuyang","id":161689,"node_id":"MDQ6VXNlcjE2MTY4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/161689?v=4","gravatar_id":"","url":"https://api.github.com/users/liufuyang","html_url":"https://github.com/liufuyang","followers_url":"https://api.github.com/users/liufuyang/followers","following_url":"https://api.github.com/users/liufuyang/following{/other_user}","gists_url":"https://api.github.com/users/liufuyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liufuyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liufuyang/subscriptions","organizations_url":"https://api.github.com/users/liufuyang/orgs","repos_url":"https://api.github.com/users/liufuyang/repos","events_url":"https://api.github.com/users/liufuyang/events{/privacy}","received_events_url":"https://api.github.com/users/liufuyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liufuyang/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/liufuyang/tikv","forks_url":"https://api.github.com/repos/liufuyang/tikv/forks","keys_url":"https://api.github.com/repos/liufuyang/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liufuyang/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liufuyang/tikv/teams","hooks_url":"https://api.github.com/repos/liufuyang/tikv/hooks","issue_events_url":"https://api.github.com/repos/liufuyang/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/liufuyang/tikv/events","assignees_url":"https://api.github.com/repos/liufuyang/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/liufuyang/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/liufuyang/tikv/tags","blobs_url":"https://api.github.com/repos/liufuyang/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liufuyang/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liufuyang/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/liufuyang/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liufuyang/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/liufuyang/tikv/languages","stargazers_url":"https://api.github.com/repos/liufuyang/tikv/stargazers","contributors_url":"https://api.github.com/repos/liufuyang/tikv/contributors","subscribers_url":"https://api.github.com/repos/liufuyang/tikv/subscribers","subscription_url":"https://api.github.com/repos/liufuyang/tikv/subscription","commits_url":"https://api.github.com/repos/liufuyang/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/liufuyang/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/liufuyang/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/liufuyang/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/liufuyang/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/liufuyang/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liufuyang/tikv/merges","archive_url":"https://api.github.com/repos/liufuyang/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liufuyang/tikv/downloads","issues_url":"https://api.github.com/repos/liufuyang/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/liufuyang/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/liufuyang/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/liufuyang/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liufuyang/tikv/labels{/name}","releases_url":"https://api.github.com/repos/liufuyang/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/liufuyang/tikv/deployments","created_at":"2018-08-07T12:48:29Z","updated_at":"2018-08-07T12:48:33Z","pushed_at":"2018-09-03T17:07:38Z","git_url":"git://github.com/liufuyang/tikv.git","ssh_url":"git@github.com:liufuyang/tikv.git","clone_url":"https://github.com/liufuyang/tikv.git","svn_url":"https://github.com/liufuyang/tikv","homepage":"https://pingcap.com","size":15660,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"0faa80794c572f807c66cf648e41c541375d5151","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key-value database, originally created to complement TiDB","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-09-03T22:25:38Z","pushed_at":"2018-09-03T23:48:32Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"","size":15965,"stargazers_count":3619,"watchers_count":3619,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":493,"mirror_url":null,"archived":false,"open_issues_count":264,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":493,"open_issues":264,"watchers":3619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3406"},"html":{"href":"https://github.com/tikv/tikv/pull/3406"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3406"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3406/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3406/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3406/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/b95b3500ec57b07bdee03fcbb5eeff65be3327ba"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"solotzg","id":9016847,"node_id":"MDQ6VXNlcjkwMTY4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/9016847?v=4","gravatar_id":"","url":"https://api.github.com/users/solotzg","html_url":"https://github.com/solotzg","followers_url":"https://api.github.com/users/solotzg/followers","following_url":"https://api.github.com/users/solotzg/following{/other_user}","gists_url":"https://api.github.com/users/solotzg/gists{/gist_id}","starred_url":"https://api.github.com/users/solotzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solotzg/subscriptions","organizations_url":"https://api.github.com/users/solotzg/orgs","repos_url":"https://api.github.com/users/solotzg/repos","events_url":"https://api.github.com/users/solotzg/events{/privacy}","received_events_url":"https://api.github.com/users/solotzg/received_events","type":"User","site_admin":false},"comments":13,"review_comments":12,"maintainer_can_modify":false,"commits":8,"additions":39,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"solotzg"}}