{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/184774660","pull_request_review_id":116036952,"id":184774660,"diff_hunk":"@@ -23,6 +23,10 @@\n     <EmbeddedResource Remove=\"Stratis.Bitcoin.Features.Miner\\**\" />\n     <None Remove=\"Stratis.Bitcoin.Features.Miner\\**\" />\n   </ItemGroup>\n+\n+  <ItemGroup>","path":"src/Stratis.Bitcoin.Features.Miner/Stratis.Bitcoin.Features.Miner.csproj","position":5,"original_position":5,"commit_id":"21ff59ddc8e5871556698c4e4e5c7c49d9bd82e5","original_commit_id":"21ff59ddc8e5871556698c4e4e5c7c49d9bd82e5","user":{"login":"noescape00","id":10259355,"avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"This change is probably not needed since AssemblerFactory was removed. ","created_at":"2018-04-27T18:42:38Z","updated_at":"2018-04-27T18:42:43Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347#discussion_r184774660","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/184774660"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347#discussion_r184774660"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347","id":184554374,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1347","number":1347,"state":"open","locked":false,"title":"[SmartContracts] Refactor Block Assemblers Part #1","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"body":"This is the first PR refactoring the block assemblers to implement a better inheritance strategy, primarily to facilitate integrating the smart contract feature into the full node. This is also key to moving smart contracts to proof of stake after alpha release.\r\n\r\nCurrently the POS assembler inherits from the POW assembler. In the smart contract branch we also inherit from the POW assembler. We need to move base logic to a abstract base block assembler so that all the different block assemblers are logically more modular.\r\n\r\nThe next PR will rename the block assemblers to block builders and then we will move the assemblers to individual folder and create the base class. ","created_at":"2018-04-27T08:20:31Z","updated_at":"2018-04-27T18:42:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8731565eb58a0d48f426ea8b9cd058427eb662d6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bokobza","id":1867877,"avatar_url":"https://avatars3.githubusercontent.com/u/1867877?v=4","gravatar_id":"","url":"https://api.github.com/users/bokobza","html_url":"https://github.com/bokobza","followers_url":"https://api.github.com/users/bokobza/followers","following_url":"https://api.github.com/users/bokobza/following{/other_user}","gists_url":"https://api.github.com/users/bokobza/gists{/gist_id}","starred_url":"https://api.github.com/users/bokobza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokobza/subscriptions","organizations_url":"https://api.github.com/users/bokobza/orgs","repos_url":"https://api.github.com/users/bokobza/repos","events_url":"https://api.github.com/users/bokobza/events{/privacy}","received_events_url":"https://api.github.com/users/bokobza/received_events","type":"User","site_admin":false},{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},{"login":"Aprogiena","id":30052221,"avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":435911031,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/Refactor","name":"Refactor","color":"e6e6e6","default":false},{"id":435911029,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/improvement","name":"improvement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1347/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/21ff59ddc8e5871556698c4e4e5c7c49d9bd82e5","head":{"label":"fassadlr:blockassembler-refactor-part1","ref":"blockassembler-refactor-part1","sha":"21ff59ddc8e5871556698c4e4e5c7c49d9bd82e5","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"repo":{"id":102562819,"name":"StratisBitcoinFullNode","full_name":"fassadlr/StratisBitcoinFullNode","owner":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fassadlr/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/fassadlr/StratisBitcoinFullNode/deployments","created_at":"2017-09-06T04:31:20Z","updated_at":"2018-04-26T06:22:07Z","pushed_at":"2018-04-27T09:38:52Z","git_url":"git://github.com/fassadlr/StratisBitcoinFullNode.git","ssh_url":"git@github.com:fassadlr/StratisBitcoinFullNode.git","clone_url":"https://github.com/fassadlr/StratisBitcoinFullNode.git","svn_url":"https://github.com/fassadlr/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":10835,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"632ad44e4ca987e63b8735e27d477f6bafdebd5c","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-04-27T15:01:00Z","pushed_at":"2018-04-27T17:07:19Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":10669,"stargazers_count":443,"watchers_count":443,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":184,"open_issues":100,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1347"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1347"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1347/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1347/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/21ff59ddc8e5871556698c4e4e5c7c49d9bd82e5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"noescape00"}}