{"action":"created","issue":{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/249","repository_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay","labels_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/249/comments","events_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/249/events","html_url":"https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/issues/249","id":321281411,"number":249,"title":"Accidentals carrying over into next measure","user":{"login":"SevenBlocks","id":8278755,"avatar_url":"https://avatars2.githubusercontent.com/u/8278755?v=4","gravatar_id":"","url":"https://api.github.com/users/SevenBlocks","html_url":"https://github.com/SevenBlocks","followers_url":"https://api.github.com/users/SevenBlocks/followers","following_url":"https://api.github.com/users/SevenBlocks/following{/other_user}","gists_url":"https://api.github.com/users/SevenBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/SevenBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SevenBlocks/subscriptions","organizations_url":"https://api.github.com/users/SevenBlocks/orgs","repos_url":"https://api.github.com/users/SevenBlocks/repos","events_url":"https://api.github.com/users/SevenBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/SevenBlocks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-08T17:42:37Z","updated_at":"2018-05-08T19:51:39Z","closed_at":null,"author_association":"NONE","body":"Accidentals (sharps or flats not in the key signature) should only persist for the measure they appear in. In the two-note example below, a Gb in measure 1 is followed by a G natural in measure 2. This is the key of C with no sharps or flats. When this is rendered, a natural sign is placed in the second measure even though it should not be.\r\n\r\n[test.txt](https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/files/1985015/test.txt)\r\n\r\n\r\n```\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<!DOCTYPE score-partwise PUBLIC \"-//Recordare//DTD MusicXML 3.0 Partwise//EN\" \"http://www.musicxml.org/dtds/partwise.dtd\">\r\n<score-partwise>\r\n  <part-list>\r\n    <score-part id=\"P1\">\r\n      <part-name>Piano</part-name>\r\n      <score-instrument id=\"P1-I1\">\r\n        <instrument-name>Piano</instrument-name>\r\n        </score-instrument>\r\n      </score-part>\r\n    </part-list>\r\n  <part id=\"P1\">\r\n    <measure number=\"1\" width=\"200.80\">\r\n      <attributes>\r\n        <divisions>1</divisions>\r\n        <key>\r\n          <fifths>0</fifths>\r\n          </key>\r\n        <time>\r\n          <beats>4</beats>\r\n          <beat-type>4</beat-type>\r\n          </time>\r\n        <staves>2</staves>\r\n        <clef number=\"1\">\r\n          <sign>G</sign>\r\n          <line>2</line>\r\n          </clef>\r\n        <clef number=\"2\">\r\n          <sign>G</sign>\r\n          <line>2</line>\r\n          </clef>\r\n        </attributes>\r\n      <note default-x=\"80.88\" default-y=\"-30.00\">\r\n        <pitch>\r\n          <step>G</step>\r\n          <alter>-1</alter>\r\n          <octave>4</octave>\r\n          </pitch>\r\n        <duration>4</duration>\r\n        <voice>1</voice>\r\n        <type>whole</type>\r\n        <accidental>flat</accidental>\r\n        <staff>1</staff>\r\n        </note>\r\n      <backup>\r\n        <duration>4</duration>\r\n        </backup>\r\n      <note>\r\n        <rest/>\r\n        <duration>4</duration>\r\n        <voice>5</voice>\r\n        <staff>2</staff>\r\n        </note>\r\n      </measure>\r\n    <measure number=\"2\" width=\"138.60\">\r\n      <note default-x=\"12.00\" default-y=\"-30.00\">\r\n        <pitch>\r\n          <step>G</step>\r\n          <octave>4</octave>\r\n          </pitch>\r\n        <duration>4</duration>\r\n        <voice>1</voice>\r\n        <type>whole</type>\r\n        <staff>1</staff>\r\n        </note>\r\n      <backup>\r\n        <duration>4</duration>\r\n        </backup>\r\n      <note>\r\n        <rest/>\r\n        <duration>4</duration>\r\n        <voice>5</voice>\r\n        <staff>2</staff>\r\n        </note>\r\n      </measure>\r\n    </part>\r\n  </score-partwise>\r\n```"},"comment":{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/comments/387521776","html_url":"https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/issues/249#issuecomment-387521776","issue_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/249","id":387521776,"user":{"login":"matt-uib","id":17180665,"avatar_url":"https://avatars1.githubusercontent.com/u/17180665?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-uib","html_url":"https://github.com/matt-uib","followers_url":"https://api.github.com/users/matt-uib/followers","following_url":"https://api.github.com/users/matt-uib/following{/other_user}","gists_url":"https://api.github.com/users/matt-uib/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-uib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-uib/subscriptions","organizations_url":"https://api.github.com/users/matt-uib/orgs","repos_url":"https://api.github.com/users/matt-uib/repos","events_url":"https://api.github.com/users/matt-uib/events{/privacy}","received_events_url":"https://api.github.com/users/matt-uib/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T19:51:39Z","updated_at":"2018-05-08T19:51:39Z","author_association":"COLLABORATOR","body":"Dear @SevenBlocks , this is completely on purpose and actually a feature, which is also often (not always) used in modern music notation. For all off-key accidentals that occur in some earlier measure, a natural sign is shown when the same note comes without this accidental again - reason is to remind the musician that now he/she has to play the normal note again.\r\nSo we had actually some effort to add this, but it might make sense to add a flag to switch it off, if not wanted."}}
{"actor":{"display_login":"matt-uib"}}