{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2613","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2613/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2613/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2613/events","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2613","id":374509811,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTk2Njcz","number":2613,"title":"WIP: Governance Proposal Refactor","user":{"login":"mossid","id":18329646,"node_id":"MDQ6VXNlcjE4MzI5NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/18329646?v=4","gravatar_id":"","url":"https://api.github.com/users/mossid","html_url":"https://github.com/mossid","followers_url":"https://api.github.com/users/mossid/followers","following_url":"https://api.github.com/users/mossid/following{/other_user}","gists_url":"https://api.github.com/users/mossid/gists{/gist_id}","starred_url":"https://api.github.com/users/mossid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossid/subscriptions","organizations_url":"https://api.github.com/users/mossid/orgs","repos_url":"https://api.github.com/users/mossid/repos","events_url":"https://api.github.com/users/mossid/events{/privacy}","received_events_url":"https://api.github.com/users/mossid/received_events","type":"User","site_admin":false},"labels":[{"id":965477353,"node_id":"MDU6TGFiZWw5NjU0NzczNTM=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/wip","name":"wip","color":"fafad2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-26T19:04:54Z","updated_at":"2018-11-01T16:19:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2613","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2613","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/2613.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/2613.patch"},"body":"<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺\r\nv                               ✰  Thanks for creating a PR! ✰    \r\nv    Before smashing the submit button please review the checkboxes.\r\nv    If a checkbox is n/a - please still include it but + a little note why\r\n☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->\r\n\r\n- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/develop/CONTRIBUTING.md#pr-targeting))\r\n\r\n- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.\r\n- [ ] Wrote tests\r\n- [ ] Updated relevant documentation (`docs/`)\r\n- [ ] Added entries in `PENDING.md` with issue # \r\n- [ ] rereviewed `Files changed` in the github PR explorer\r\n\r\nSplit from: #2571 \r\n\r\nThis PR refactors Gov module's proposal design.\r\n\r\nProposals are split into two parts, `Proposal` and `ProposalInfo`. `ProposalInfo` describes the mutable state of a proposal, which is not related to the proposal's content itself, but rather its status in the queue, created and managed internally. `Proposal` is an interface that has two methods, `GetProposalAbstract` and `Enact`. `GetProposalAbstract` returns `ProposalAbstract`, which is a struct with human-readable information describing the proposal. `Enact` is called when the proposal passes. It is useful when the proposal needs to trigger an event automatically.\r\n\r\n`ProposalQueue` has been changed to `InfoQueue` so we don't have to unmarshal the whole proposal each time(consider the case where a TextProposal has a very long description). Unlike `ProposalInfo` where it gets pruned after the `VotingPeriod`, `Proposal` is immutable after its creation, so the user can always query the `Proposal`. \r\n____\r\n\r\nFor Admin Use:\r\n- Added appropriate labels to PR (ex. wip, ready-for-review, docs)\r\n- Reviewers Assigned\r\n- Squashed all commits, uses message \"Merge pull request #XYZ: [title]\" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))\r\n"},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/435096137","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2613#issuecomment-435096137","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2613","id":435096137,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTA5NjEzNw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-01T16:19:54Z","updated_at":"2018-11-01T16:19:54Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/cosmos/cosmos-sdk/pull/2613?src=pr&el=h1) Report\n> Merging [#2613](https://codecov.io/gh/cosmos/cosmos-sdk/pull/2613?src=pr&el=desc) into [joon/paramstore-subkey](https://codecov.io/gh/cosmos/cosmos-sdk/commit/8c673bb871e352b5952d53b96aefabdc4a2567d1?src=pr&el=desc) will **increase** coverage by `1.31%`.\n> The diff coverage is `73.37%`.\n\n\n```diff\n@@                    Coverage Diff                     @@\n##           joon/paramstore-subkey    #2613      +/-   ##\n==========================================================\n+ Coverage                   58.68%   59.99%   +1.31%     \n==========================================================\n  Files                         152      146       -6     \n  Lines                        9446     8426    -1020     \n==========================================================\n- Hits                         5543     5055     -488     \n+ Misses                       3533     3026     -507     \n+ Partials                      370      345      -25\n```\n"}}
{"actor":{"display_login":"codecov"}}