{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67899","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67899/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67899/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67899/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67899","id":354358727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTM5NzY5","number":67899,"title":"Graduate Schedule daemon set pods  by default scheduler to beta and fix tests","user":{"login":"ravisantoshgudimetla","id":11657829,"node_id":"MDQ6VXNlcjExNjU3ODI5","avatar_url":"https://avatars3.githubusercontent.com/u/11657829?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"janetkuo","id":4876867,"node_id":"MDQ6VXNlcjQ4NzY4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"assignees":[{"login":"janetkuo","id":4876867,"node_id":"MDQ6VXNlcjQ4NzY4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"bsalamat","id":14308438,"node_id":"MDQ6VXNlcjE0MzA4NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2018-08-27T15:09:18Z","updated_at":"2018-09-03T14:50:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67899","html_url":"https://github.com/kubernetes/kubernetes/pull/67899","diff_url":"https://github.com/kubernetes/kubernetes/pull/67899.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67899.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\n\r\nThe main idea here is when ScheduleDSPods in enabled, even when there is a resource crunch, DSController would still create pod. Previously(before this feature), we would not allow that to happen. \r\n\r\nAs part of this PR, \r\n- Updating tests which does resource checks and fail to create/delete pods to run as before by unsetting ScheduleDSPod flag so that they can continue testing old code path. These tests are not relevant when ScheduleDSPods feature is enabled and would result in test failures.\r\n- Updating the create/delete pod events to reflect the new changes.\r\n\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nPromote ScheduleDaemonSetPods by default scheduler to beta\r\n```\r\n\r\n/cc @bsalamat @aveshagarwal @Huang-Wei @k82cn "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/418136953","html_url":"https://github.com/kubernetes/kubernetes/pull/67899#issuecomment-418136953","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67899","id":418136953,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODEzNjk1Mw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T14:50:47Z","updated_at":"2018-09-03T14:50:47Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/67899#pullrequestreview-151133980\" title=\"LGTM\">bsalamat</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/67899#\" title=\"Author self-approved\">ravisantoshgudimetla</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **janetkuo**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @janetkuo` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)**\n- ~~[pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/OWNERS)~~ [bsalamat]\n- **[test/integration/daemonset/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/daemonset/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"janetkuo\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}