{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/187778472","pull_request_review_id":119632041,"id":187778472,"diff_hunk":"@@ -576,14 +579,25 @@ local function handle_give_command(cmd, giver, receiver, stackstring)\n \t-- The actual item stack string may be different from what the \"giver\"\n \t-- entered (e.g. big numbers are always interpreted as 2^16-1).\n \tstackstring = itemstack:to_string()\n+\t-- Air is not that useful as an item, but it also does no real harm.\n+\tlocal you_hacker = itemstack:get_name() == \"air\"","path":"builtin/game/chatcommands.lua","position":15,"original_position":15,"commit_id":"82a4190a8ab28da0fe273cd59456b065d2d770c1","original_commit_id":"82a4190a8ab28da0fe273cd59456b065d2d770c1","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"Please remove all 'you hacker' stuff as it's unnecessary code bloat. Then i'll be +1.","created_at":"2018-05-12T17:33:30Z","updated_at":"2018-05-12T17:33:31Z","html_url":"https://github.com/minetest/minetest/pull/7305#discussion_r187778472","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7305","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/187778472"},"html":{"href":"https://github.com/minetest/minetest/pull/7305#discussion_r187778472"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7305"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7305","id":186510526,"html_url":"https://github.com/minetest/minetest/pull/7305","diff_url":"https://github.com/minetest/minetest/pull/7305.diff","patch_url":"https://github.com/minetest/minetest/pull/7305.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7305","number":7305,"state":"open","locked":false,"title":"Small usage changes for air and ignore items","user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars1.githubusercontent.com/u/1675853?v=4","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"body":"This PR makes some tweaks to air and ignore (in item form):\r\n\r\nThe “you hacker you!” in the `description` is removed. Instead, this message appears on `/give` and `/giveme`.\r\nReason: To keep the tooltip clean, and because the `description` might be parsed by mods like `doc` to display item names in a list, so the `description` should be general-purpose.\r\n\r\nThe placement of `ignore` is prevented straight in `builtin` with a custom error message directed at the player.\r\nReason: To catch the placement before it goes to the engine, which would cause massive error message spam with cryptic messages.","created_at":"2018-05-08T02:21:18Z","updated_at":"2018-05-12T17:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae7516efef8098c9c3f772ac63e3fcc6f9ffc98a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":73368921,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Server%20/%20Client%20/%20Env.","name":"@ Server / Client / Env.","color":"0e8a16","default":false},{"id":372290178,"url":"https://api.github.com/repos/minetest/minetest/labels/Bugfix","name":"Bugfix","color":"c5def5","default":false},{"id":336502596,"url":"https://api.github.com/repos/minetest/minetest/labels/One%20approval","name":"One approval","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7305/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7305/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7305/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/82a4190a8ab28da0fe273cd59456b065d2d770c1","head":{"label":"Wuzzy2:air_ignore_rework","ref":"air_ignore_rework","sha":"82a4190a8ab28da0fe273cd59456b065d2d770c1","user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars1.githubusercontent.com/u/1675853?v=4","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"repo":{"id":21471271,"name":"minetest","full_name":"Wuzzy2/minetest","owner":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars1.githubusercontent.com/u/1675853?v=4","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wuzzy2/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/Wuzzy2/minetest","forks_url":"https://api.github.com/repos/Wuzzy2/minetest/forks","keys_url":"https://api.github.com/repos/Wuzzy2/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wuzzy2/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wuzzy2/minetest/teams","hooks_url":"https://api.github.com/repos/Wuzzy2/minetest/hooks","issue_events_url":"https://api.github.com/repos/Wuzzy2/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/Wuzzy2/minetest/events","assignees_url":"https://api.github.com/repos/Wuzzy2/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/Wuzzy2/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/Wuzzy2/minetest/tags","blobs_url":"https://api.github.com/repos/Wuzzy2/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wuzzy2/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wuzzy2/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wuzzy2/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wuzzy2/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/Wuzzy2/minetest/languages","stargazers_url":"https://api.github.com/repos/Wuzzy2/minetest/stargazers","contributors_url":"https://api.github.com/repos/Wuzzy2/minetest/contributors","subscribers_url":"https://api.github.com/repos/Wuzzy2/minetest/subscribers","subscription_url":"https://api.github.com/repos/Wuzzy2/minetest/subscription","commits_url":"https://api.github.com/repos/Wuzzy2/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wuzzy2/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wuzzy2/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wuzzy2/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wuzzy2/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/Wuzzy2/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wuzzy2/minetest/merges","archive_url":"https://api.github.com/repos/Wuzzy2/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wuzzy2/minetest/downloads","issues_url":"https://api.github.com/repos/Wuzzy2/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/Wuzzy2/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/Wuzzy2/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/Wuzzy2/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wuzzy2/minetest/labels{/name}","releases_url":"https://api.github.com/repos/Wuzzy2/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/Wuzzy2/minetest/deployments","created_at":"2014-07-03T17:34:21Z","updated_at":"2017-05-27T18:08:09Z","pushed_at":"2018-05-12T11:53:56Z","git_url":"git://github.com/Wuzzy2/minetest.git","ssh_url":"git@github.com:Wuzzy2/minetest.git","clone_url":"https://github.com/Wuzzy2/minetest.git","svn_url":"https://github.com/Wuzzy2/minetest","homepage":"http://minetest.net/","size":56914,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"a292d19fd0726cdd192469fbfc5f85770d5819e3","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine with support for survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-05-12T16:52:12Z","pushed_at":"2018-05-12T16:44:38Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":57141,"stargazers_count":3268,"watchers_count":3268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":871,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":901,"open_issues":871,"watchers":3268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7305"},"html":{"href":"https://github.com/minetest/minetest/pull/7305"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7305"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7305/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7305/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7305/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/82a4190a8ab28da0fe273cd59456b065d2d770c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paramat"}}