{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/222323594","pull_request_review_id":161180897,"id":222323594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjMyMzU5NA==","diff_hunk":"@@ -69,8 +69,8 @@ module.exports = class ArtworkAuctionView extends Backbone.View\n \n     loggedInUser = CurrentUser.orNull()\n \n-    # Show the new buy now flow if you have the lab feature enabled\n-    if loggedInUser?.hasLabFeature('New Buy Now Flow')\n+    # Show the new buy now flow if the feature flag is enabled\n+    if ENABLE_NEW_BUY_NOW_FLOW","path":"src/desktop/apps/artwork/components/auction/view.coffee","position":15,"original_position":15,"commit_id":"05d5045493ca1482638f4356679fddb9f5e8007a","original_commit_id":"05d5045493ca1482638f4356679fddb9f5e8007a","user":{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false},"body":"I'll point these out, but for some of the cases here it would be really beneficial to include _both_ the lab feature and the feature flag so that we can continue to test the important pieces in production.\r\n\r\nSo, here `if ENABLE_NEW_BUY_NOW_FLOW || loggedInUser?.hasLabFeature('New Buy Now Flow')`","created_at":"2018-10-03T14:06:01Z","updated_at":"2018-10-03T14:06:01Z","html_url":"https://github.com/artsy/force/pull/2958#discussion_r222323594","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/2958","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/222323594"},"html":{"href":"https://github.com/artsy/force/pull/2958#discussion_r222323594"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/2958"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/2958","id":219880527,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODgwNTI3","html_url":"https://github.com/artsy/force/pull/2958","diff_url":"https://github.com/artsy/force/pull/2958.diff","patch_url":"https://github.com/artsy/force/pull/2958.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/2958","number":2958,"state":"open","locked":false,"title":"@sweir27 => Include a feature flag for BNMO, make accessible in Sharify","user":{"login":"mzikherman","id":1457859,"node_id":"MDQ6VXNlcjE0NTc4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1457859?v=4","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},"body":"Using https://github.com/artsy/reaction/pull/1353 and `yarn link`, this minimal exposing of a feature flag worked, when set I saw the new artwork brick style, new BNMO filters on artist page, etc. When unset, those were back to their current display.","created_at":"2018-10-03T00:04:56Z","updated_at":"2018-10-03T14:06:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83bbea726f63bc01b7e50245f20c8588523133f6","assignee":{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false},"assignees":[{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/2958/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/2958/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/2958/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/05d5045493ca1482638f4356679fddb9f5e8007a","head":{"label":"artsy:bnmo_feat_flag","ref":"bnmo_feat_flag","sha":"05d5045493ca1482638f4356679fddb9f5e8007a","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzQwNA==","name":"force","full_name":"artsy/force","private":false,"owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-10-03T00:45:31Z","pushed_at":"2018-10-03T12:54:12Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":131024,"stargazers_count":252,"watchers_count":252,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":88,"open_issues":49,"watchers":252,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"7c9ff54e431fa83e91ba25d99c41c818e4e08cfe","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzQwNA==","name":"force","full_name":"artsy/force","private":false,"owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-10-03T00:45:31Z","pushed_at":"2018-10-03T12:54:12Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":131024,"stargazers_count":252,"watchers_count":252,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":88,"open_issues":49,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/2958"},"html":{"href":"https://github.com/artsy/force/pull/2958"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/2958"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/2958/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/2958/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/2958/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/05d5045493ca1482638f4356679fddb9f5e8007a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sweir27"}}