{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/14947","repository_url":"https://api.github.com/repos/ionic-team/ionic","labels_url":"https://api.github.com/repos/ionic-team/ionic/issues/14947/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/14947/comments","events_url":"https://api.github.com/repos/ionic-team/ionic/issues/14947/events","html_url":"https://github.com/ionic-team/ionic/pull/14947","id":346025657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTg5MTg4","number":14947,"title":"Fix #7417","user":{"login":"iva2k","id":416092,"node_id":"MDQ6VXNlcjQxNjA5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/416092?v=4","gravatar_id":"","url":"https://api.github.com/users/iva2k","html_url":"https://github.com/iva2k","followers_url":"https://api.github.com/users/iva2k/followers","following_url":"https://api.github.com/users/iva2k/following{/other_user}","gists_url":"https://api.github.com/users/iva2k/gists{/gist_id}","starred_url":"https://api.github.com/users/iva2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iva2k/subscriptions","organizations_url":"https://api.github.com/users/iva2k/orgs","repos_url":"https://api.github.com/users/iva2k/repos","events_url":"https://api.github.com/users/iva2k/events{/privacy}","received_events_url":"https://api.github.com/users/iva2k/received_events","type":"User","site_admin":false},"labels":[{"id":571285183,"node_id":"MDU6TGFiZWw1NzEyODUxODM=","url":"https://api.github.com/repos/ionic-team/ionic/labels/v3","name":"v3","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-31T03:55:32Z","updated_at":"2018-10-18T23:10:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/14947","html_url":"https://github.com/ionic-team/ionic/pull/14947","diff_url":"https://github.com/ionic-team/ionic/pull/14947.diff","patch_url":"https://github.com/ionic-team/ionic/pull/14947.patch"},"body":"#### Short description of what this resolves:\r\nFixes disappearing menuToggle when hideBackButton is true or swipeBackEnable is false.\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Match the code to the intent described in the comment\r\n\r\n**Ionic Version**: 3.x\r\n\r\n**Fixes**: #7417\r\n\r\n**Details**: \r\n\r\nUse of Array.some() with the given filter function is not achieving the goal stated in the comment, filter returns \"true\" on self, contradicting the stated purpose. That results in menu getting disabled even in a single menu configuration, while the intent is to find x>1, while Array.some() finds x>=1.\r\n\r\nThe fix is to either exclude self from consideration (that is a bit convoluted change to either filter function or the Array), or convert ```!Array.some()``` to ```Array.filter().length < 2``` in proposed fix.\r\n\r\nBug in the code was introduced by https://github.com/ionic-team/ionic/commit/ff24152524fabb1aaca0ab7314e2e8ca2bbb7af7\r\n\r\nHowever, the issue seems to be conditional on CSS being applied for \"back button\" removal, entangling it with hideBackButton and [swipeBackEnabled]=\"false\". Another way to \"fix the issue\" is remove hideBackButton or [swipeBackEnabled]=\"false\", but it only masks the bug."},"comment":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/comments/431193902","html_url":"https://github.com/ionic-team/ionic/pull/14947#issuecomment-431193902","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/14947","id":431193902,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTE5MzkwMg==","user":{"login":"ionic-issue-bot[bot]","id":35967572,"node_id":"MDM6Qm90MzU5Njc1NzI=","avatar_url":"https://avatars1.githubusercontent.com/in/8640?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D","html_url":"https://github.com/apps/ionic-issue-bot","followers_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/followers","following_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/repos","events_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-issue-bot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-18T23:10:45Z","updated_at":"2018-10-18T23:10:45Z","author_association":"NONE","body":"\n## Screenshot Report :mag_right::iphone:\n\n- :bookmark_tabs: Comparing <a href=\"https://github.com/ionic-team/ionic/commit/fa554eba41c346e140d741ee340828595ed17c80\" target=\"_blank\">`fa554eb`</a> → <a href=\"https://github.com/ionic-team/ionic/commit/af0cf6cc2ac9a078410ebbec01f39fa261c7fac6\" target=\"_blank\">`af0cf6c`</a>\n- :bar_chart: 0 / 0 screenshots mismatched\n- :crystal_ball: See the <a href=\"https://screenshot.ionicframework.com/fa554eb/af0cf6c\" target=\"_blank\">full comparison</a>\n\nNo comparison data found!\n\n\n---\n:blue_heart: - Ionitron\n"}}
{"actor":{"display_login":"ionic-issue-bot"}}