{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/14286","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/14286/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/14286/comments","events_url":"https://api.github.com/repos/electron/electron/issues/14286/events","html_url":"https://github.com/electron/electron/pull/14286","id":353603792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjExOTcy","number":14286,"title":"refactor: use std::string instead of base::string16 for IPC channel names","user":{"login":"miniak","id":1281234,"node_id":"MDQ6VXNlcjEyODEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1281234?v=4","gravatar_id":"","url":"https://api.github.com/users/miniak","html_url":"https://github.com/miniak","followers_url":"https://api.github.com/users/miniak/followers","following_url":"https://api.github.com/users/miniak/following{/other_user}","gists_url":"https://api.github.com/users/miniak/gists{/gist_id}","starred_url":"https://api.github.com/users/miniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miniak/subscriptions","organizations_url":"https://api.github.com/users/miniak/orgs","repos_url":"https://api.github.com/users/miniak/repos","events_url":"https://api.github.com/users/miniak/events{/privacy}","received_events_url":"https://api.github.com/users/miniak/received_events","type":"User","site_admin":false},"labels":[{"id":35575880,"node_id":"MDU6TGFiZWwzNTU3NTg4MA==","url":"https://api.github.com/repos/electron/electron/labels/enhancement%20:sparkles:","name":"enhancement :sparkles:","color":"84b6eb","default":false},{"id":759869934,"node_id":"MDU6TGFiZWw3NTk4Njk5MzQ=","url":"https://api.github.com/repos/electron/electron/labels/platform/all","name":"platform/all","color":"c5def5","default":false},{"id":867930517,"node_id":"MDU6TGFiZWw4Njc5MzA1MTc=","url":"https://api.github.com/repos/electron/electron/labels/semver/breaking-change","name":"semver/breaking-change","color":"6ac2dd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-24T00:45:06Z","updated_at":"2018-08-24T06:41:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/14286","html_url":"https://github.com/electron/electron/pull/14286","diff_url":"https://github.com/electron/electron/pull/14286.diff","patch_url":"https://github.com/electron/electron/pull/14286.patch"},"body":"##### Description of Change\r\nThere is no need to use UTF-16 for IPC channel names, as they are almost always ASCII strings (UTF-8 is therefore more efficient). This change makes IPC messages slightly smaller, which should improve performance slightly.\r\n\r\n##### Checklist\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] PR title follows semantic [commit guidelines]\r\n\r\n##### Release Notes\r\nNotes: no-notes"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/415666870","html_url":"https://github.com/electron/electron/pull/14286#issuecomment-415666870","issue_url":"https://api.github.com/repos/electron/electron/issues/14286","id":415666870,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTY2Njg3MA==","user":{"login":"miniak","id":1281234,"node_id":"MDQ6VXNlcjEyODEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1281234?v=4","gravatar_id":"","url":"https://api.github.com/users/miniak","html_url":"https://github.com/miniak","followers_url":"https://api.github.com/users/miniak/followers","following_url":"https://api.github.com/users/miniak/following{/other_user}","gists_url":"https://api.github.com/users/miniak/gists{/gist_id}","starred_url":"https://api.github.com/users/miniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miniak/subscriptions","organizations_url":"https://api.github.com/users/miniak/orgs","repos_url":"https://api.github.com/users/miniak/repos","events_url":"https://api.github.com/users/miniak/events{/privacy}","received_events_url":"https://api.github.com/users/miniak/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T06:41:48Z","updated_at":"2018-08-24T06:41:48Z","author_association":"CONTRIBUTOR","body":"@ckerr this should not be a breaking change, it's just changing an implementation detail"}}
{"actor":{"display_login":"miniak"}}