{"action":"opened","number":2008,"pull_request":{"url":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008","id":226740185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzQwMTg1","html_url":"https://github.com/aws-amplify/amplify-js/pull/2008","diff_url":"https://github.com/aws-amplify/amplify-js/pull/2008.diff","patch_url":"https://github.com/aws-amplify/amplify-js/pull/2008.patch","issue_url":"https://api.github.com/repos/aws-amplify/amplify-js/issues/2008","number":2008,"state":"open","locked":false,"title":"fix(PubSub): allow for #-wildcard in topics","user":{"login":"Pwntus","id":854759,"node_id":"MDQ6VXNlcjg1NDc1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/854759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pwntus","html_url":"https://github.com/Pwntus","followers_url":"https://api.github.com/users/Pwntus/followers","following_url":"https://api.github.com/users/Pwntus/following{/other_user}","gists_url":"https://api.github.com/users/Pwntus/gists{/gist_id}","starred_url":"https://api.github.com/users/Pwntus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pwntus/subscriptions","organizations_url":"https://api.github.com/users/Pwntus/orgs","repos_url":"https://api.github.com/users/Pwntus/repos","events_url":"https://api.github.com/users/Pwntus/events{/privacy}","received_events_url":"https://api.github.com/users/Pwntus/received_events","type":"User","site_admin":false},"body":"*Issue #1998, #993*\r\n**Partially** fixes the problem.\r\n\r\n*Description of changes:*\r\nIterate observer topics and normalize topic with incoming message topic for comparison. Observer topic `/foo/#` will match any incoming topic beginning with `/foo/`.\r\n\r\nThis is most likely an ugly solution, and I don't know about the side-effects it may cause, but I want to initiate a complete fix for this issue.\r\n\r\nThe + (plus) wildcard is yet to be supported.\r\n\r\nMore info in MQTT topics & best practices: https://www.hivemq.com/blog/mqtt-essentials-part-5-mqtt-topics-best-practices\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-10-29T22:56:16Z","updated_at":"2018-10-29T22:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008/commits","review_comments_url":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008/comments","review_comment_url":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws-amplify/amplify-js/issues/2008/comments","statuses_url":"https://api.github.com/repos/aws-amplify/amplify-js/statuses/3f47fccc6f38a9d12a95a81324700cc4afb44f73","head":{"label":"Pwntus:fix/issue-1998","ref":"fix/issue-1998","sha":"3f47fccc6f38a9d12a95a81324700cc4afb44f73","user":{"login":"Pwntus","id":854759,"node_id":"MDQ6VXNlcjg1NDc1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/854759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pwntus","html_url":"https://github.com/Pwntus","followers_url":"https://api.github.com/users/Pwntus/followers","following_url":"https://api.github.com/users/Pwntus/following{/other_user}","gists_url":"https://api.github.com/users/Pwntus/gists{/gist_id}","starred_url":"https://api.github.com/users/Pwntus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pwntus/subscriptions","organizations_url":"https://api.github.com/users/Pwntus/orgs","repos_url":"https://api.github.com/users/Pwntus/repos","events_url":"https://api.github.com/users/Pwntus/events{/privacy}","received_events_url":"https://api.github.com/users/Pwntus/received_events","type":"User","site_admin":false},"repo":{"id":155074213,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUwNzQyMTM=","name":"amplify-js","full_name":"Pwntus/amplify-js","private":false,"owner":{"login":"Pwntus","id":854759,"node_id":"MDQ6VXNlcjg1NDc1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/854759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pwntus","html_url":"https://github.com/Pwntus","followers_url":"https://api.github.com/users/Pwntus/followers","following_url":"https://api.github.com/users/Pwntus/following{/other_user}","gists_url":"https://api.github.com/users/Pwntus/gists{/gist_id}","starred_url":"https://api.github.com/users/Pwntus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pwntus/subscriptions","organizations_url":"https://api.github.com/users/Pwntus/orgs","repos_url":"https://api.github.com/users/Pwntus/repos","events_url":"https://api.github.com/users/Pwntus/events{/privacy}","received_events_url":"https://api.github.com/users/Pwntus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Pwntus/amplify-js","description":"A declarative JavaScript library for application development using cloud services.","fork":true,"url":"https://api.github.com/repos/Pwntus/amplify-js","forks_url":"https://api.github.com/repos/Pwntus/amplify-js/forks","keys_url":"https://api.github.com/repos/Pwntus/amplify-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pwntus/amplify-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pwntus/amplify-js/teams","hooks_url":"https://api.github.com/repos/Pwntus/amplify-js/hooks","issue_events_url":"https://api.github.com/repos/Pwntus/amplify-js/issues/events{/number}","events_url":"https://api.github.com/repos/Pwntus/amplify-js/events","assignees_url":"https://api.github.com/repos/Pwntus/amplify-js/assignees{/user}","branches_url":"https://api.github.com/repos/Pwntus/amplify-js/branches{/branch}","tags_url":"https://api.github.com/repos/Pwntus/amplify-js/tags","blobs_url":"https://api.github.com/repos/Pwntus/amplify-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pwntus/amplify-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pwntus/amplify-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pwntus/amplify-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pwntus/amplify-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Pwntus/amplify-js/languages","stargazers_url":"https://api.github.com/repos/Pwntus/amplify-js/stargazers","contributors_url":"https://api.github.com/repos/Pwntus/amplify-js/contributors","subscribers_url":"https://api.github.com/repos/Pwntus/amplify-js/subscribers","subscription_url":"https://api.github.com/repos/Pwntus/amplify-js/subscription","commits_url":"https://api.github.com/repos/Pwntus/amplify-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pwntus/amplify-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pwntus/amplify-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pwntus/amplify-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pwntus/amplify-js/contents/{+path}","compare_url":"https://api.github.com/repos/Pwntus/amplify-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pwntus/amplify-js/merges","archive_url":"https://api.github.com/repos/Pwntus/amplify-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pwntus/amplify-js/downloads","issues_url":"https://api.github.com/repos/Pwntus/amplify-js/issues{/number}","pulls_url":"https://api.github.com/repos/Pwntus/amplify-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Pwntus/amplify-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Pwntus/amplify-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pwntus/amplify-js/labels{/name}","releases_url":"https://api.github.com/repos/Pwntus/amplify-js/releases{/id}","deployments_url":"https://api.github.com/repos/Pwntus/amplify-js/deployments","created_at":"2018-10-28T13:29:59Z","updated_at":"2018-10-28T13:30:05Z","pushed_at":"2018-10-29T22:49:13Z","git_url":"git://github.com/Pwntus/amplify-js.git","ssh_url":"git@github.com:Pwntus/amplify-js.git","clone_url":"https://github.com/Pwntus/amplify-js.git","svn_url":"https://github.com/Pwntus/amplify-js","homepage":"https://aws-amplify.github.io/","size":111703,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws-amplify:master","ref":"master","sha":"b20baabd6026610f49c0b7cf68e33d17ad512621","user":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"repo":{"id":105590837,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTA4Mzc=","name":"amplify-js","full_name":"aws-amplify/amplify-js","private":false,"owner":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws-amplify/amplify-js","description":"A declarative JavaScript library for application development using cloud services.","fork":false,"url":"https://api.github.com/repos/aws-amplify/amplify-js","forks_url":"https://api.github.com/repos/aws-amplify/amplify-js/forks","keys_url":"https://api.github.com/repos/aws-amplify/amplify-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws-amplify/amplify-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws-amplify/amplify-js/teams","hooks_url":"https://api.github.com/repos/aws-amplify/amplify-js/hooks","issue_events_url":"https://api.github.com/repos/aws-amplify/amplify-js/issues/events{/number}","events_url":"https://api.github.com/repos/aws-amplify/amplify-js/events","assignees_url":"https://api.github.com/repos/aws-amplify/amplify-js/assignees{/user}","branches_url":"https://api.github.com/repos/aws-amplify/amplify-js/branches{/branch}","tags_url":"https://api.github.com/repos/aws-amplify/amplify-js/tags","blobs_url":"https://api.github.com/repos/aws-amplify/amplify-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws-amplify/amplify-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws-amplify/amplify-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws-amplify/amplify-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws-amplify/amplify-js/statuses/{sha}","languages_url":"https://api.github.com/repos/aws-amplify/amplify-js/languages","stargazers_url":"https://api.github.com/repos/aws-amplify/amplify-js/stargazers","contributors_url":"https://api.github.com/repos/aws-amplify/amplify-js/contributors","subscribers_url":"https://api.github.com/repos/aws-amplify/amplify-js/subscribers","subscription_url":"https://api.github.com/repos/aws-amplify/amplify-js/subscription","commits_url":"https://api.github.com/repos/aws-amplify/amplify-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws-amplify/amplify-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws-amplify/amplify-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws-amplify/amplify-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws-amplify/amplify-js/contents/{+path}","compare_url":"https://api.github.com/repos/aws-amplify/amplify-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws-amplify/amplify-js/merges","archive_url":"https://api.github.com/repos/aws-amplify/amplify-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws-amplify/amplify-js/downloads","issues_url":"https://api.github.com/repos/aws-amplify/amplify-js/issues{/number}","pulls_url":"https://api.github.com/repos/aws-amplify/amplify-js/pulls{/number}","milestones_url":"https://api.github.com/repos/aws-amplify/amplify-js/milestones{/number}","notifications_url":"https://api.github.com/repos/aws-amplify/amplify-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws-amplify/amplify-js/labels{/name}","releases_url":"https://api.github.com/repos/aws-amplify/amplify-js/releases{/id}","deployments_url":"https://api.github.com/repos/aws-amplify/amplify-js/deployments","created_at":"2017-10-02T22:17:14Z","updated_at":"2018-10-29T22:39:23Z","pushed_at":"2018-10-29T22:39:11Z","git_url":"git://github.com/aws-amplify/amplify-js.git","ssh_url":"git@github.com:aws-amplify/amplify-js.git","clone_url":"https://github.com/aws-amplify/amplify-js.git","svn_url":"https://github.com/aws-amplify/amplify-js","homepage":"https://aws-amplify.github.io/","size":111785,"stargazers_count":4037,"watchers_count":4037,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":560,"mirror_url":null,"archived":false,"open_issues_count":575,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":560,"open_issues":575,"watchers":4037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008"},"html":{"href":"https://github.com/aws-amplify/amplify-js/pull/2008"},"issue":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/issues/2008"},"comments":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/issues/2008/comments"},"review_comments":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008/comments"},"review_comment":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/pulls/2008/commits"},"statuses":{"href":"https://api.github.com/repos/aws-amplify/amplify-js/statuses/3f47fccc6f38a9d12a95a81324700cc4afb44f73"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Pwntus"}}