{"action":"created","issue":{"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/3983","repository_url":"https://api.github.com/repos/valor-software/ngx-bootstrap","labels_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/3983/labels{/name}","comments_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/3983/comments","events_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/3983/events","html_url":"https://github.com/valor-software/ngx-bootstrap/pull/3983","id":304935356,"number":3983,"title":" feat(typeahead) stop selecting first result when displaying matches ","user":{"login":"maurizi","id":4432106,"avatar_url":"https://avatars3.githubusercontent.com/u/4432106?v=4","gravatar_id":"","url":"https://api.github.com/users/maurizi","html_url":"https://github.com/maurizi","followers_url":"https://api.github.com/users/maurizi/followers","following_url":"https://api.github.com/users/maurizi/following{/other_user}","gists_url":"https://api.github.com/users/maurizi/gists{/gist_id}","starred_url":"https://api.github.com/users/maurizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurizi/subscriptions","organizations_url":"https://api.github.com/users/maurizi/orgs","repos_url":"https://api.github.com/users/maurizi/repos","events_url":"https://api.github.com/users/maurizi/events{/privacy}","received_events_url":"https://api.github.com/users/maurizi/received_events","type":"User","site_admin":false},"labels":[{"id":411828022,"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/comp(typeahead)","name":"comp(typeahead)","color":"0e8a16","default":false},{"id":493161782,"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/needs%20review","name":"needs review","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"valorkin","id":1107171,"avatar_url":"https://avatars0.githubusercontent.com/u/1107171?v=4","gravatar_id":"","url":"https://api.github.com/users/valorkin","html_url":"https://github.com/valorkin","followers_url":"https://api.github.com/users/valorkin/followers","following_url":"https://api.github.com/users/valorkin/following{/other_user}","gists_url":"https://api.github.com/users/valorkin/gists{/gist_id}","starred_url":"https://api.github.com/users/valorkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valorkin/subscriptions","organizations_url":"https://api.github.com/users/valorkin/orgs","repos_url":"https://api.github.com/users/valorkin/repos","events_url":"https://api.github.com/users/valorkin/events{/privacy}","received_events_url":"https://api.github.com/users/valorkin/received_events","type":"User","site_admin":false},"assignees":[{"login":"valorkin","id":1107171,"avatar_url":"https://avatars0.githubusercontent.com/u/1107171?v=4","gravatar_id":"","url":"https://api.github.com/users/valorkin","html_url":"https://github.com/valorkin","followers_url":"https://api.github.com/users/valorkin/followers","following_url":"https://api.github.com/users/valorkin/following{/other_user}","gists_url":"https://api.github.com/users/valorkin/gists{/gist_id}","starred_url":"https://api.github.com/users/valorkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valorkin/subscriptions","organizations_url":"https://api.github.com/users/valorkin/orgs","repos_url":"https://api.github.com/users/valorkin/repos","events_url":"https://api.github.com/users/valorkin/events{/privacy}","received_events_url":"https://api.github.com/users/valorkin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-03-13T21:05:29Z","updated_at":"2018-04-18T19:09:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/pulls/3983","html_url":"https://github.com/valor-software/ngx-bootstrap/pull/3983","diff_url":"https://github.com/valor-software/ngx-bootstrap/pull/3983.diff","patch_url":"https://github.com/valor-software/ngx-bootstrap/pull/3983.patch"},"body":"The main intent behind this feature is to improve the user experience for navigating through the an application with keyboard while using a typeahead with `[typeaheadMinLength]=\"0\"` .\r\n\r\nTo do so, I changed the way that active items are selected via the keyboard, requiring that up/down arrows be pressed before an item is active and can be selected with tab/enter.\r\n\r\nWithout this feature, tabbing through a typeahead with `minLength` set to 0 will on the first tab select the first item, and then on the second tab move to the next field.\r\n\r\nI also added a few other items as well:\r\n - Fixed a few comment typos\r\n - Added a `typeaheadMinLength` example to the documentation.\r\n\r\n# PR Checklist\r\nBefore creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.\r\n\r\n - [x] read and followed the [CONTRIBUTING.md](https://github.com/valor-software/ngx-bootstrap/blob/development/CONTRIBUTING.md) guide.\r\n - [x] built and tested the changes locally.\r\n - [x] added/updated tests.\r\n - [ ] added/updated API documentation.\r\n - [x] added/updated demos.\r\n\r\nCloses #3965"},"comment":{"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/comments/382496744","html_url":"https://github.com/valor-software/ngx-bootstrap/pull/3983#issuecomment-382496744","issue_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/3983","id":382496744,"user":{"login":"calebeno","id":9387933,"avatar_url":"https://avatars1.githubusercontent.com/u/9387933?v=4","gravatar_id":"","url":"https://api.github.com/users/calebeno","html_url":"https://github.com/calebeno","followers_url":"https://api.github.com/users/calebeno/followers","following_url":"https://api.github.com/users/calebeno/following{/other_user}","gists_url":"https://api.github.com/users/calebeno/gists{/gist_id}","starred_url":"https://api.github.com/users/calebeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebeno/subscriptions","organizations_url":"https://api.github.com/users/calebeno/orgs","repos_url":"https://api.github.com/users/calebeno/repos","events_url":"https://api.github.com/users/calebeno/events{/privacy}","received_events_url":"https://api.github.com/users/calebeno/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T19:09:31Z","updated_at":"2018-04-18T19:09:31Z","author_association":"NONE","body":"@maurizi Any updates on this?"}}
{"actor":{"display_login":"calebeno"}}