{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/208347742","pull_request_review_id":144138477,"id":208347742,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM0Nzc0Mg==","diff_hunk":"@@ -93,6 +93,7 @@ rules:\n       - admissionregistration.k8s.io\n     resources:\n       - validatingwebhookconfigurations\n+      - mutatingwebhookconfigurations","path":"manifests/dev/rbac.authorization.k8s.yaml.in","position":4,"original_position":4,"commit_id":"6890474f51bde5583c7b5a2244fa594cac80850f","original_commit_id":"6890474f51bde5583c7b5a2244fa594cac80850f","user":{"login":"davidvossel","id":683713,"node_id":"MDQ6VXNlcjY4MzcxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/683713?v=4","gravatar_id":"","url":"https://api.github.com/users/davidvossel","html_url":"https://github.com/davidvossel","followers_url":"https://api.github.com/users/davidvossel/followers","following_url":"https://api.github.com/users/davidvossel/following{/other_user}","gists_url":"https://api.github.com/users/davidvossel/gists{/gist_id}","starred_url":"https://api.github.com/users/davidvossel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidvossel/subscriptions","organizations_url":"https://api.github.com/users/davidvossel/orgs","repos_url":"https://api.github.com/users/davidvossel/repos","events_url":"https://api.github.com/users/davidvossel/events{/privacy}","received_events_url":"https://api.github.com/users/davidvossel/received_events","type":"User","site_admin":false},"body":"@cynepco3hahue  i figured out why. We have issues with our RBAC rules. #1415 will fix it. We'll need the mutation webhook privilege for virt-api in both once my PR gets merged","created_at":"2018-08-07T18:57:08Z","updated_at":"2018-08-07T18:57:08Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1410#discussion_r208347742","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/208347742"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1410#discussion_r208347742"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410"}},"in_reply_to_id":207981405},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410","id":206466479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDY2NDc5","html_url":"https://github.com/kubevirt/kubevirt/pull/1410","diff_url":"https://github.com/kubevirt/kubevirt/pull/1410.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1410.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1410","number":1410,"state":"open","locked":false,"title":"[WIP] Add mutating webhook","user":{"login":"cynepco3hahue","id":4704810,"node_id":"MDQ6VXNlcjQ3MDQ4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4704810?v=4","gravatar_id":"","url":"https://api.github.com/users/cynepco3hahue","html_url":"https://github.com/cynepco3hahue","followers_url":"https://api.github.com/users/cynepco3hahue/followers","following_url":"https://api.github.com/users/cynepco3hahue/following{/other_user}","gists_url":"https://api.github.com/users/cynepco3hahue/gists{/gist_id}","starred_url":"https://api.github.com/users/cynepco3hahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynepco3hahue/subscriptions","organizations_url":"https://api.github.com/users/cynepco3hahue/orgs","repos_url":"https://api.github.com/users/cynepco3hahue/repos","events_url":"https://api.github.com/users/cynepco3hahue/events{/privacy}","received_events_url":"https://api.github.com/users/cynepco3hahue/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n- [x] set VMI defaults from mutating webhook\r\n- [ ] apply presets\r\n- [ ] apply cluster defaults\r\n- [ ] add unittests\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #1278\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nIntroduce mutating webhook\r\n```\r\n\r\nSigned-off-by: Artyom Lukianov <alukiano@redhat.com>","created_at":"2018-08-06T17:29:32Z","updated_at":"2018-08-07T18:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6effad296202603fcbbe878ef1bd956d28d26f70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1410/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/6890474f51bde5583c7b5a2244fa594cac80850f","head":{"label":"cynepco3hahue:mutating_webhook","ref":"mutating_webhook","sha":"6890474f51bde5583c7b5a2244fa594cac80850f","user":{"login":"cynepco3hahue","id":4704810,"node_id":"MDQ6VXNlcjQ3MDQ4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4704810?v=4","gravatar_id":"","url":"https://api.github.com/users/cynepco3hahue","html_url":"https://github.com/cynepco3hahue","followers_url":"https://api.github.com/users/cynepco3hahue/followers","following_url":"https://api.github.com/users/cynepco3hahue/following{/other_user}","gists_url":"https://api.github.com/users/cynepco3hahue/gists{/gist_id}","starred_url":"https://api.github.com/users/cynepco3hahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynepco3hahue/subscriptions","organizations_url":"https://api.github.com/users/cynepco3hahue/orgs","repos_url":"https://api.github.com/users/cynepco3hahue/repos","events_url":"https://api.github.com/users/cynepco3hahue/events{/privacy}","received_events_url":"https://api.github.com/users/cynepco3hahue/received_events","type":"User","site_admin":false},"repo":{"id":93745194,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzc0NTE5NA==","name":"kubevirt","full_name":"cynepco3hahue/kubevirt","owner":{"login":"cynepco3hahue","id":4704810,"node_id":"MDQ6VXNlcjQ3MDQ4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4704810?v=4","gravatar_id":"","url":"https://api.github.com/users/cynepco3hahue","html_url":"https://github.com/cynepco3hahue","followers_url":"https://api.github.com/users/cynepco3hahue/followers","following_url":"https://api.github.com/users/cynepco3hahue/following{/other_user}","gists_url":"https://api.github.com/users/cynepco3hahue/gists{/gist_id}","starred_url":"https://api.github.com/users/cynepco3hahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynepco3hahue/subscriptions","organizations_url":"https://api.github.com/users/cynepco3hahue/orgs","repos_url":"https://api.github.com/users/cynepco3hahue/repos","events_url":"https://api.github.com/users/cynepco3hahue/events{/privacy}","received_events_url":"https://api.github.com/users/cynepco3hahue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cynepco3hahue/kubevirt","description":"KubeVirt is a virtual machine management add-on for Kubernetes.","fork":true,"url":"https://api.github.com/repos/cynepco3hahue/kubevirt","forks_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/forks","keys_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/teams","hooks_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/events","assignees_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/tags","blobs_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/languages","stargazers_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/subscription","commits_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/merges","archive_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/downloads","issues_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/cynepco3hahue/kubevirt/deployments","created_at":"2017-06-08T12:09:09Z","updated_at":"2018-08-07T08:13:02Z","pushed_at":"2018-08-07T14:57:46Z","git_url":"git://github.com/cynepco3hahue/kubevirt.git","ssh_url":"git@github.com:cynepco3hahue/kubevirt.git","clone_url":"https://github.com/cynepco3hahue/kubevirt.git","svn_url":"https://github.com/cynepco3hahue/kubevirt","homepage":"","size":83530,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"ef22a121a69b57a1ead6cc20458a0d94e7eedcef","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-08-07T13:12:25Z","pushed_at":"2018-08-07T18:55:33Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":83603,"stargazers_count":789,"watchers_count":789,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":166,"open_issues":158,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1410"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1410"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1410/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1410/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/6890474f51bde5583c7b5a2244fa594cac80850f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidvossel"}}