{"action":"created","issue":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/1551","repository_url":"https://api.github.com/repos/gammapy/gammapy","labels_url":"https://api.github.com/repos/gammapy/gammapy/issues/1551/labels{/name}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/1551/comments","events_url":"https://api.github.com/repos/gammapy/gammapy/issues/1551/events","html_url":"https://github.com/gammapy/gammapy/issues/1551","id":343071903,"node_id":"MDU6SXNzdWUzNDMwNzE5MDM=","number":1551,"title":"Finish clean-up of gammapy.scripts","user":{"login":"cdeil","id":852409,"node_id":"MDQ6VXNlcjg1MjQwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"labels":[{"id":52741016,"node_id":"MDU6TGFiZWw1Mjc0MTAxNg==","url":"https://api.github.com/repos/gammapy/gammapy/labels/cleanup","name":"cleanup","color":"5319e7","default":false},{"id":113697265,"node_id":"MDU6TGFiZWwxMTM2OTcyNjU=","url":"https://api.github.com/repos/gammapy/gammapy/labels/effort-medium","name":"effort-medium","color":"fef2c0","default":false},{"id":39740773,"node_id":"MDU6TGFiZWwzOTc0MDc3Mw==","url":"https://api.github.com/repos/gammapy/gammapy/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"registerrier","id":5047091,"node_id":"MDQ6VXNlcjUwNDcwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5047091?v=4","gravatar_id":"","url":"https://api.github.com/users/registerrier","html_url":"https://github.com/registerrier","followers_url":"https://api.github.com/users/registerrier/followers","following_url":"https://api.github.com/users/registerrier/following{/other_user}","gists_url":"https://api.github.com/users/registerrier/gists{/gist_id}","starred_url":"https://api.github.com/users/registerrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/registerrier/subscriptions","organizations_url":"https://api.github.com/users/registerrier/orgs","repos_url":"https://api.github.com/users/registerrier/repos","events_url":"https://api.github.com/users/registerrier/events{/privacy}","received_events_url":"https://api.github.com/users/registerrier/received_events","type":"User","site_admin":false},"assignees":[{"login":"registerrier","id":5047091,"node_id":"MDQ6VXNlcjUwNDcwOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5047091?v=4","gravatar_id":"","url":"https://api.github.com/users/registerrier","html_url":"https://github.com/registerrier","followers_url":"https://api.github.com/users/registerrier/followers","following_url":"https://api.github.com/users/registerrier/following{/other_user}","gists_url":"https://api.github.com/users/registerrier/gists{/gist_id}","starred_url":"https://api.github.com/users/registerrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/registerrier/subscriptions","organizations_url":"https://api.github.com/users/registerrier/orgs","repos_url":"https://api.github.com/users/registerrier/repos","events_url":"https://api.github.com/users/registerrier/events{/privacy}","received_events_url":"https://api.github.com/users/registerrier/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/12","html_url":"https://github.com/gammapy/gammapy/milestone/12","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/12/labels","id":3288050,"node_id":"MDk6TWlsZXN0b25lMzI4ODA1MA==","number":12,"title":"0.9","description":"","creator":{"login":"cdeil","id":852409,"node_id":"MDQ6VXNlcjg1MjQwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":5,"state":"open","created_at":"2018-04-23T07:23:54Z","updated_at":"2018-07-27T10:33:04Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-20T11:24:53Z","updated_at":"2018-07-27T10:36:50Z","closed_at":null,"author_association":"MEMBER","body":"This issue is to continue the cleanup and discussion started in #1517 of gammapy.scripts.\r\n\r\nWhat's there?\r\n* In v0.7: http://docs.gammapy.org/0.7/scripts/index.html#module-gammapy.scripts\r\n* In dev: http://docs.gammapy.org/dev/scripts/index.html#module-gammapy.scripts\r\n\r\nI removed the `CTAObservationSimulation` and `ObservationParameters` and `Target` class in #1517, and would also like to remove the remaining `BgRateTable`, `Psf68Table`, `SensitivityTable`, `CTAIrf` and  `CTAPerf`.\r\n\r\nThere would be no loss in functionality really, but the users of those classes will have to adapt their scripts. From what I can see, the main remaining tasks here are:\r\n- Relatively small changes to `gammapy.spactrum.SpectrumSimulation` #876 , and update of [cta_simulation.ipynb](http://docs.gammapy.org/dev/notebooks/cta_simulation.html) to load and plot the IRFs directly an use `SpectrumSimulation`.\r\n- Introduce a helper function to load all four IRFs and put them on an object (like the current `CTAIrf` or the `Observation` in #1546) or for now just in a dict. We could also update `SpectrumSimulation` to take such an object, instead of IRFs separately. Note that this is already possible now, you just have to write 5 lines to load each IRF separately. \r\n\r\nI think the `BgRateTable`, `Psf68Table` and `SensitivityTable` should be removed without replacement. What they do is to wrap a Table with two columns, do linear interpolation and plotting. We can show with a docs example how to do that with a few lines, but I don't think we should maintain code for this in Gammapy.\r\n\r\nAnother major question is when to do this. IMO it can only be either next week (things removed / improved in v0.8) or the week after (things still available in v0.8, gone then in v0.9). I don't see how keeping this code longer is helpful for users, and it's a drag for us Gammapy developers. We need to focus our resources on building something great, quickly (see e.g. #1546), and we need \"all hands on deck\", both users for testing and devs not to be distracted by old stuff.\r\n\r\n@jjlk - who is using this? is there anyone that wants or needs this in v0.8? Is using v0.7 an option? Or is updating your script to the new code and using v0.8, v0.9, ... an option?\r\n\r\nI'm willing to compromise here and put it back for v0.8, of course our goal is to already now support CTA users and ongoing studies. But only if it's really needed / helpful. If you anyways want to keep doing these simulations / studies for the next months / years and want to keep using Gammapy, then you'll have to update your scripts. I'm available to help / pair code on this in the next 2 weeks to help with the transition."},"comment":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/comments/408381049","html_url":"https://github.com/gammapy/gammapy/issues/1551#issuecomment-408381049","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/1551","id":408381049,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODM4MTA0OQ==","user":{"login":"cdeil","id":852409,"node_id":"MDQ6VXNlcjg1MjQwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T10:36:50Z","updated_at":"2018-07-27T10:36:50Z","author_association":"MEMBER","body":"Discussed in the Gammapy call today. @registerrier insisted to keep this for v0.8, and to first talk to @jjlk before cleaning this up, and promised to do the clean-up for v0.9. I would hope rather to do it directly after the v0.8 release, so that we can focus developments on obs sim / IRF to the right place for August / September already, not leave this \"to the fall\".\r\n\r\nI'll put the CTASpectrumSimulation class back for now in a follow-up PR.\r\n"}}
{"actor":{"display_login":"cdeil"}}