{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/10046","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/10046/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/10046/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/10046/events","html_url":"https://github.com/sequelize/sequelize/pull/10046","id":371952524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjgzMTg5","number":10046,"title":"chore(*): misc cleanup","user":{"login":"SimonSchick","id":3259089,"node_id":"MDQ6VXNlcjMyNTkwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3259089?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonSchick","html_url":"https://github.com/SimonSchick","followers_url":"https://api.github.com/users/SimonSchick/followers","following_url":"https://api.github.com/users/SimonSchick/following{/other_user}","gists_url":"https://api.github.com/users/SimonSchick/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSchick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSchick/subscriptions","organizations_url":"https://api.github.com/users/SimonSchick/orgs","repos_url":"https://api.github.com/users/SimonSchick/repos","events_url":"https://api.github.com/users/SimonSchick/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSchick/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-19T13:14:49Z","updated_at":"2018-10-19T16:48:58Z","closed_at":"2018-10-19T16:48:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/10046","html_url":"https://github.com/sequelize/sequelize/pull/10046","diff_url":"https://github.com/sequelize/sequelize/pull/10046.diff","patch_url":"https://github.com/sequelize/sequelize/pull/10046.patch"},"body":"\r\n### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [ ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [ ] Have you added new tests to prevent regressions?\r\n- [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [ ] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)?\r\n\r\n### Description of change\r\n\r\nMany things:\r\nIn my last PR I missed updating the `test` folder so this PR also includes these.\r\nMoved various lodash usage to the native counterpart (indexOf, includes, forEach, etc.).\r\nRemoved all usage of `self = this` (one exception) related `promise.bind()` use and `.then(function` use.\r\nUpdate docs to suggest modern es6 usage.\r\n\r\nI currently have some tests failing, trying to see if the occur on CI as well!\r\n"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/431426764","html_url":"https://github.com/sequelize/sequelize/pull/10046#issuecomment-431426764","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/10046","id":431426764,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQyNjc2NA==","user":{"login":"sushantdhiman","id":9989487,"node_id":"MDQ6VXNlcjk5ODk0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/9989487?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T16:48:58Z","updated_at":"2018-10-19T16:48:58Z","author_association":"MEMBER","body":"Thanks @SimonSchick :+1: "}}
{"actor":{"display_login":"sushantdhiman"}}