{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64931","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64931/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64931/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64931/events","html_url":"https://github.com/kubernetes/kubernetes/pull/64931","id":330813135,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzMxMTQy","number":64931,"title":"Ensure /etc/hosts has a header always - Fix conformance test","user":{"login":"dghubble","id":2253428,"node_id":"MDQ6VXNlcjIyNTM0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2253428?v=4","gravatar_id":"","url":"https://api.github.com/users/dghubble","html_url":"https://github.com/dghubble","followers_url":"https://api.github.com/users/dghubble/followers","following_url":"https://api.github.com/users/dghubble/following{/other_user}","gists_url":"https://api.github.com/users/dghubble/gists{/gist_id}","starred_url":"https://api.github.com/users/dghubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dghubble/subscriptions","organizations_url":"https://api.github.com/users/dghubble/orgs","repos_url":"https://api.github.com/users/dghubble/repos","events_url":"https://api.github.com/users/dghubble/events{/privacy}","received_events_url":"https://api.github.com/users/dghubble/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680154135,"node_id":"MDU6TGFiZWw2ODAxNTQxMzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/cherry-pick-not-approved","name":"do-not-merge/cherry-pick-not-approved","color":"e11d21","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-06-08T21:50:32Z","updated_at":"2018-06-13T12:51:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64931","html_url":"https://github.com/kubernetes/kubernetes/pull/64931","diff_url":"https://github.com/kubernetes/kubernetes/pull/64931.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64931.patch"},"body":"We have 2 scenarios where we copy /etc/hosts\r\n- with host network (we just copy the /etc/hosts from node)\r\n- without host network (create a fresh /etc/hosts from pod info)\r\n\r\nWe are having trouble figuring out whether a /etc/hosts in a\r\npod/container has been \"fixed-up\" or not. And whether we used\r\nhost network or a fresh /etc/hosts in the various ways we start\r\nup the tests which are:\r\n\r\n- VM/box against a remote cluster\r\n- As a container inside the k8s cluster\r\n- DIND scenario in CI where test runs inside a managed container\r\n\r\nPlease see previous mis-guided attempt to fix this problem at\r\nba20e63446815f8bcab4fc4c6e07eab2e2a9e121 In this commit we revert\r\nthe code from there as well.\r\n\r\nSo we should make sure:\r\n- we always add a header if we touched the file\r\n- we add slightly different headers so we can figure out if we used the\r\n  host network or not.\r\n\r\nUpdate the test case to inject /etc/hosts from node to another path\r\n(/etc/hosts-original) as well and use that to compare.\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/396925767","html_url":"https://github.com/kubernetes/kubernetes/pull/64931#issuecomment-396925767","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64931","id":396925767,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjkyNTc2Nw==","user":{"login":"MaciekPytel","id":7901030,"node_id":"MDQ6VXNlcjc5MDEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T12:51:02Z","updated_at":"2018-06-13T12:51:02Z","author_association":"CONTRIBUTOR","body":"@dghubble Does that fix any user visible problem, or is it just for fixing tests? If it's the former it needs release note. If the latter it probably still needs a release note, as the change is not limited to test code."}}
{"actor":{"display_login":"MaciekPytel"}}