{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/179829123","pull_request_review_id":110150884,"id":179829123,"diff_hunk":"@@ -102,11 +102,21 @@ angular.module('calcentral.controllers').controller('FinancesLinksController', f\n     $scope.summerEstimatorLink = _.get(links, 'summerEstimator');\n   };\n \n+  var parseSirStatuses = function(response) {\n+    var hasUndergraduateRole = userService.profile.roles.undergrad;\n+    var sirStatuses = _.get(response, 'data.sirStatuses');\n+    var hasUndergraduateSir = !!_.find(sirStatuses, {\n+      isUndergraduate: true\n+    });\n+    $scope.canViewSummerEstimatorLink = hasUndergraduateRole || hasUndergraduateSir;\n+  };\n+\n+  var setSummerEstimatorVisibility = sirFactory.getSirStatuses().then(parseSirStatuses);","path":"src/assets/javascripts/angular/controllers/widgets/financesLinksController.js","position":22,"original_position":22,"commit_id":"eeb876f3e6c95f0aa5eff1614767f54648a31d80","original_commit_id":"eeb876f3e6c95f0aa5eff1614767f54648a31d80","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars1.githubusercontent.com/u/12127480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"body":"@redconfetti That makes a ton of sense.  Nice catch, will amend.","created_at":"2018-04-06T17:46:19Z","updated_at":"2018-04-06T17:46:19Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/7073#discussion_r179829123","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/179829123"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/7073#discussion_r179829123"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073"}},"in_reply_to_id":179828878},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073","id":180007768,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/7073","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/7073.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/7073.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/7073","number":7073,"state":"open","locked":false,"title":"SISRP-39790 - Summer Estimator - CalCentral Dev","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars1.githubusercontent.com/u/12127480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-39790\r\n\r\n* The requirement was not just \"undergrads\", but \"new admit undergrads\", which are not assigned the \"undergrad\" role until they are matriculated\r\n* So, we have to see if the user has any undergraduate SIR offers\r\n* Also moves all of the conditional links within an `if` block, so we don't needlessly make the proxy call","created_at":"2018-04-06T17:25:54Z","updated_at":"2018-04-06T17:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52242a7c7664a336b3693cbe8d60c3a75fcc9cab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/7073/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/eeb876f3e6c95f0aa5eff1614767f54648a31d80","head":{"label":"davidlimcheng:SISRP-39790","ref":"SISRP-39790","sha":"eeb876f3e6c95f0aa5eff1614767f54648a31d80","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars1.githubusercontent.com/u/12127480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"repo":{"id":34630716,"name":"calcentral","full_name":"davidlimcheng/calcentral","owner":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars1.githubusercontent.com/u/12127480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidlimcheng/calcentral","description":null,"fork":true,"url":"https://api.github.com/repos/davidlimcheng/calcentral","forks_url":"https://api.github.com/repos/davidlimcheng/calcentral/forks","keys_url":"https://api.github.com/repos/davidlimcheng/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidlimcheng/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidlimcheng/calcentral/teams","hooks_url":"https://api.github.com/repos/davidlimcheng/calcentral/hooks","issue_events_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/davidlimcheng/calcentral/events","assignees_url":"https://api.github.com/repos/davidlimcheng/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/davidlimcheng/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/davidlimcheng/calcentral/tags","blobs_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidlimcheng/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/davidlimcheng/calcentral/languages","stargazers_url":"https://api.github.com/repos/davidlimcheng/calcentral/stargazers","contributors_url":"https://api.github.com/repos/davidlimcheng/calcentral/contributors","subscribers_url":"https://api.github.com/repos/davidlimcheng/calcentral/subscribers","subscription_url":"https://api.github.com/repos/davidlimcheng/calcentral/subscription","commits_url":"https://api.github.com/repos/davidlimcheng/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidlimcheng/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidlimcheng/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/davidlimcheng/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidlimcheng/calcentral/merges","archive_url":"https://api.github.com/repos/davidlimcheng/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidlimcheng/calcentral/downloads","issues_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/davidlimcheng/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/davidlimcheng/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/davidlimcheng/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidlimcheng/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/davidlimcheng/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/davidlimcheng/calcentral/deployments","created_at":"2015-04-26T20:47:36Z","updated_at":"2015-04-26T20:47:39Z","pushed_at":"2018-04-06T17:41:03Z","git_url":"git://github.com/davidlimcheng/calcentral.git","ssh_url":"git@github.com:davidlimcheng/calcentral.git","clone_url":"https://github.com/davidlimcheng/calcentral.git","svn_url":"https://github.com/davidlimcheng/calcentral","homepage":"https://calcentral.berkeley.edu","size":28109,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"245fc3ff23ae046912203ea4b3f4a35d04abdf8a","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":null,"fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2018-04-05T22:51:31Z","pushed_at":"2018-04-06T17:41:05Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":30227,"stargazers_count":83,"watchers_count":83,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":69,"open_issues":5,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/7073"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/7073"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/7073/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/7073/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/eeb876f3e6c95f0aa5eff1614767f54648a31d80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidlimcheng"}}