{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/cartopy/pulls/comments/235343487","pull_request_review_id":177184916,"id":235343487,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTM0MzQ4Nw==","diff_hunk":"@@ -54,19 +55,22 @@ def test_default(self):\n                              5434177.81588539, 5434177.81588539),\n                             decimal=4)\n \n-    def test_eccentric_globe(self):\n-        globe = ccrs.Globe(semimajor_axis=10000, semiminor_axis=5000,\n-                           ellipse=None)\n-        geos = self.test_class(satellite_height=50000,\n-                               globe=globe)\n-        other_args = {'a=10000', 'b=5000', 'h=50000', 'lat_0=0.0', 'lon_0=0.0',\n-                      'x_0=0', 'y_0=0'}\n+    def test_low_orbit(self):\n+        geos = self.test_class(satellite_height=700000)\n+        other_args = {'h=700000', 'lat_0=0.0', 'lon_0=0.0', 'x_0=0', 'y_0=0',\n+                      'ellps=WGS84'}\n         self.adjust_expected_params(other_args)\n \n         check_proj4_params(self.expected_proj_name, geos, other_args)\n \n         assert_almost_equal(geos.boundary.bounds,\n-                            (-8372.4040, -4171.5043, 8372.4040, 4171.5043),\n+                            (-785616.1189, -785616.1189,\n+                             785616.1189, 785616.1189),\n+                            decimal=4)\n+\n+        # Checking that this isn't just a simple elliptical border\n+        assert_almost_equal(np.array(geos.boundary.coords)[7],\n+                            (697323.205 , -453041.0626),","path":"lib/cartopy/tests/crs/test_geostationary.py","position":35,"original_position":35,"commit_id":"357166a4c8e98e4ccd1974d9c858694da6e8de8e","original_commit_id":"357166a4c8e98e4ccd1974d9c858694da6e8de8e","user":{"login":"stickler-ci","id":16011037,"node_id":"MDQ6VXNlcjE2MDExMDM3","avatar_url":"https://avatars3.githubusercontent.com/u/16011037?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"E203 whitespace before ','","created_at":"2018-11-21T11:05:14Z","updated_at":"2018-11-21T11:05:15Z","html_url":"https://github.com/SciTools/cartopy/pull/1216#discussion_r235343487","pull_request_url":"https://api.github.com/repos/SciTools/cartopy/pulls/1216","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/comments/235343487"},"html":{"href":"https://github.com/SciTools/cartopy/pull/1216#discussion_r235343487"},"pull_request":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/1216"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/cartopy/pulls/1216","id":232622351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjIyMzUx","html_url":"https://github.com/SciTools/cartopy/pull/1216","diff_url":"https://github.com/SciTools/cartopy/pull/1216.diff","patch_url":"https://github.com/SciTools/cartopy/pull/1216.patch","issue_url":"https://api.github.com/repos/SciTools/cartopy/issues/1216","number":1216,"state":"open","locked":false,"title":"Fix Geostationary projection boundary","user":{"login":"dopplershift","id":221526,"node_id":"MDQ6VXNlcjIyMTUyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/221526?v=4","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"body":"Finally put together enough spherical trigonometry to work out the proper boundary for the `Geostationary` projection.\r\n\r\nBefore:\r\n\r\n![before](https://user-images.githubusercontent.com/221526/46894272-25575580-ce31-11e8-9b05-54902c4a8063.png)\r\n\r\nAfter:\r\n\r\n![after](https://user-images.githubusercontent.com/221526/48837341-4ff6d100-ed42-11e8-8e99-b99a2c92c35c.png)\r\n\r\n(See #1144 for sample plotting code.)","created_at":"2018-11-21T11:05:05Z","updated_at":"2018-11-21T11:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcd5707ab3945c370de9a71f4c04ae1a191f2ce4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/cartopy/pulls/1216/commits","review_comments_url":"https://api.github.com/repos/SciTools/cartopy/pulls/1216/comments","review_comment_url":"https://api.github.com/repos/SciTools/cartopy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/cartopy/issues/1216/comments","statuses_url":"https://api.github.com/repos/SciTools/cartopy/statuses/357166a4c8e98e4ccd1974d9c858694da6e8de8e","head":{"label":"dopplershift:fix-geos","ref":"fix-geos","sha":"357166a4c8e98e4ccd1974d9c858694da6e8de8e","user":{"login":"dopplershift","id":221526,"node_id":"MDQ6VXNlcjIyMTUyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/221526?v=4","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"repo":{"id":61330241,"node_id":"MDEwOlJlcG9zaXRvcnk2MTMzMDI0MQ==","name":"cartopy","full_name":"dopplershift/cartopy","private":false,"owner":{"login":"dopplershift","id":221526,"node_id":"MDQ6VXNlcjIyMTUyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/221526?v=4","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dopplershift/cartopy","description":"Cartopy - a cartographic python library with matplotlib support","fork":true,"url":"https://api.github.com/repos/dopplershift/cartopy","forks_url":"https://api.github.com/repos/dopplershift/cartopy/forks","keys_url":"https://api.github.com/repos/dopplershift/cartopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dopplershift/cartopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dopplershift/cartopy/teams","hooks_url":"https://api.github.com/repos/dopplershift/cartopy/hooks","issue_events_url":"https://api.github.com/repos/dopplershift/cartopy/issues/events{/number}","events_url":"https://api.github.com/repos/dopplershift/cartopy/events","assignees_url":"https://api.github.com/repos/dopplershift/cartopy/assignees{/user}","branches_url":"https://api.github.com/repos/dopplershift/cartopy/branches{/branch}","tags_url":"https://api.github.com/repos/dopplershift/cartopy/tags","blobs_url":"https://api.github.com/repos/dopplershift/cartopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dopplershift/cartopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dopplershift/cartopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dopplershift/cartopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dopplershift/cartopy/statuses/{sha}","languages_url":"https://api.github.com/repos/dopplershift/cartopy/languages","stargazers_url":"https://api.github.com/repos/dopplershift/cartopy/stargazers","contributors_url":"https://api.github.com/repos/dopplershift/cartopy/contributors","subscribers_url":"https://api.github.com/repos/dopplershift/cartopy/subscribers","subscription_url":"https://api.github.com/repos/dopplershift/cartopy/subscription","commits_url":"https://api.github.com/repos/dopplershift/cartopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dopplershift/cartopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dopplershift/cartopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dopplershift/cartopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dopplershift/cartopy/contents/{+path}","compare_url":"https://api.github.com/repos/dopplershift/cartopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dopplershift/cartopy/merges","archive_url":"https://api.github.com/repos/dopplershift/cartopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dopplershift/cartopy/downloads","issues_url":"https://api.github.com/repos/dopplershift/cartopy/issues{/number}","pulls_url":"https://api.github.com/repos/dopplershift/cartopy/pulls{/number}","milestones_url":"https://api.github.com/repos/dopplershift/cartopy/milestones{/number}","notifications_url":"https://api.github.com/repos/dopplershift/cartopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dopplershift/cartopy/labels{/name}","releases_url":"https://api.github.com/repos/dopplershift/cartopy/releases{/id}","deployments_url":"https://api.github.com/repos/dopplershift/cartopy/deployments","created_at":"2016-06-16T22:39:18Z","updated_at":"2016-06-16T22:39:20Z","pushed_at":"2018-11-21T10:48:10Z","git_url":"git://github.com/dopplershift/cartopy.git","ssh_url":"git@github.com:dopplershift/cartopy.git","clone_url":"https://github.com/dopplershift/cartopy.git","svn_url":"https://github.com/dopplershift/cartopy","homepage":"http://scitools.org.uk/cartopy/","size":42378,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"b75c692797b08f7ce79a1899591228b2135215b4","user":{"login":"SciTools","id":1391487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5282596,"node_id":"MDEwOlJlcG9zaXRvcnk1MjgyNTk2","name":"cartopy","full_name":"SciTools/cartopy","private":false,"owner":{"login":"SciTools","id":1391487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1391487?v=4","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SciTools/cartopy","description":"Cartopy - a cartographic python library with matplotlib support","fork":false,"url":"https://api.github.com/repos/SciTools/cartopy","forks_url":"https://api.github.com/repos/SciTools/cartopy/forks","keys_url":"https://api.github.com/repos/SciTools/cartopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/cartopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/cartopy/teams","hooks_url":"https://api.github.com/repos/SciTools/cartopy/hooks","issue_events_url":"https://api.github.com/repos/SciTools/cartopy/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/cartopy/events","assignees_url":"https://api.github.com/repos/SciTools/cartopy/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/cartopy/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/cartopy/tags","blobs_url":"https://api.github.com/repos/SciTools/cartopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/cartopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/cartopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/cartopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/cartopy/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/cartopy/languages","stargazers_url":"https://api.github.com/repos/SciTools/cartopy/stargazers","contributors_url":"https://api.github.com/repos/SciTools/cartopy/contributors","subscribers_url":"https://api.github.com/repos/SciTools/cartopy/subscribers","subscription_url":"https://api.github.com/repos/SciTools/cartopy/subscription","commits_url":"https://api.github.com/repos/SciTools/cartopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/cartopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/cartopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/cartopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/cartopy/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/cartopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/cartopy/merges","archive_url":"https://api.github.com/repos/SciTools/cartopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/cartopy/downloads","issues_url":"https://api.github.com/repos/SciTools/cartopy/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/cartopy/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/cartopy/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/cartopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/cartopy/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/cartopy/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/cartopy/deployments","created_at":"2012-08-03T07:43:59Z","updated_at":"2018-11-21T09:09:42Z","pushed_at":"2018-11-21T11:05:06Z","git_url":"git://github.com/SciTools/cartopy.git","ssh_url":"git@github.com:SciTools/cartopy.git","clone_url":"https://github.com/SciTools/cartopy.git","svn_url":"https://github.com/SciTools/cartopy","homepage":"https://scitools.org.uk/cartopy/docs/latest","size":42366,"stargazers_count":451,"watchers_count":451,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":168,"open_issues":158,"watchers":451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/1216"},"html":{"href":"https://github.com/SciTools/cartopy/pull/1216"},"issue":{"href":"https://api.github.com/repos/SciTools/cartopy/issues/1216"},"comments":{"href":"https://api.github.com/repos/SciTools/cartopy/issues/1216/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/1216/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/1216/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/cartopy/statuses/357166a4c8e98e4ccd1974d9c858694da6e8de8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stickler-ci"}}