{"action":"created","issue":{"url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/51","repository_url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary","labels_url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/51/comments","events_url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/51/events","html_url":"https://github.com/KONNEKTING/KonnektingDeviceLibrary/pull/51","id":319181311,"number":51,"title":"compiles now warning free. fixed bugs in dpt conversion.","user":{"login":"holgerfriedrich","id":2121139,"avatar_url":"https://avatars3.githubusercontent.com/u/2121139?v=4","gravatar_id":"","url":"https://api.github.com/users/holgerfriedrich","html_url":"https://github.com/holgerfriedrich","followers_url":"https://api.github.com/users/holgerfriedrich/followers","following_url":"https://api.github.com/users/holgerfriedrich/following{/other_user}","gists_url":"https://api.github.com/users/holgerfriedrich/gists{/gist_id}","starred_url":"https://api.github.com/users/holgerfriedrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holgerfriedrich/subscriptions","organizations_url":"https://api.github.com/users/holgerfriedrich/orgs","repos_url":"https://api.github.com/users/holgerfriedrich/repos","events_url":"https://api.github.com/users/holgerfriedrich/events{/privacy}","received_events_url":"https://api.github.com/users/holgerfriedrich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-01T12:02:11Z","updated_at":"2018-05-03T06:36:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/pulls/51","html_url":"https://github.com/KONNEKTING/KonnektingDeviceLibrary/pull/51","diff_url":"https://github.com/KONNEKTING/KonnektingDeviceLibrary/pull/51.diff","patch_url":"https://github.com/KONNEKTING/KonnektingDeviceLibrary/pull/51.patch"},"body":"ConvertFromDpt and ConvertToDpt were broken in error condition (reaches end of function, no return value set).\r\nFurthermore, KnxDevice::begin had a double assignment to _lastTXTimeMicros. I thought it might be useful to set _lastRXTimeMicros here to have it initialized to a useful value.\r\n\r\nFinally, I managed to get this compiling without any compiler warning.\r\nIn addition, cppcheck --enable=all is down to 2 (not relevant) warnings now.\r\nMinor performance and style changes (use initialization lists for ctors, added some consts, moved a few ifdefs to avoid unused variables, moved variables to a smaller scope).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/comments/386203084","html_url":"https://github.com/KONNEKTING/KonnektingDeviceLibrary/pull/51#issuecomment-386203084","issue_url":"https://api.github.com/repos/KONNEKTING/KonnektingDeviceLibrary/issues/51","id":386203084,"user":{"login":"tuxedo0801","id":2862906,"avatar_url":"https://avatars2.githubusercontent.com/u/2862906?v=4","gravatar_id":"","url":"https://api.github.com/users/tuxedo0801","html_url":"https://github.com/tuxedo0801","followers_url":"https://api.github.com/users/tuxedo0801/followers","following_url":"https://api.github.com/users/tuxedo0801/following{/other_user}","gists_url":"https://api.github.com/users/tuxedo0801/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxedo0801/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxedo0801/subscriptions","organizations_url":"https://api.github.com/users/tuxedo0801/orgs","repos_url":"https://api.github.com/users/tuxedo0801/repos","events_url":"https://api.github.com/users/tuxedo0801/events{/privacy}","received_events_url":"https://api.github.com/users/tuxedo0801/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T06:36:03Z","updated_at":"2018-05-03T06:36:03Z","author_association":"OWNER","body":"> Hi, thanks for considering this pull request. \r\n\r\nYou're welcome, and your PR too. In the near future I would like to see automated builds. And there it makes sense to have almost no false-positive in warnings. "}}
{"actor":{"display_login":"tuxedo0801"}}