{"action":"created","comment":{"url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/comments/232985379","pull_request_review_id":174298776,"id":232985379,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk4NTM3OQ==","diff_hunk":"@@ -160,7 +160,25 @@ class NetworkInterface: public DNS {\n      *  @return         NSAPI_ERROR_OK on success, negative error code on failure.\n      */\n     virtual nsapi_error_t gethostbyname(const char *host,\n-                                        SocketAddress *address, const char *interface_name, nsapi_version_t version = NSAPI_UNSPEC);\n+                                        SocketAddress *address, nsapi_version_t version = NSAPI_UNSPEC);\n+\n+    /** Translate a hostname to an IP address with specific version using network interface name.\n+         *","path":"features/netsocket/NetworkInterface.h","position":null,"original_position":8,"commit_id":"9055eddd24d13d9b038306947cb814d35d3017d1","original_commit_id":"a715f208d558ee1a8ac07cc7a319d92948ec21e2","user":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-11-13T10:46:51Z","updated_at":"2018-11-13T10:46:51Z","html_url":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2#discussion_r232985379","pull_request_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/comments/232985379"},"html":{"href":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2#discussion_r232985379"},"pull_request":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2"}},"in_reply_to_id":232157985},"pull_request":{"url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2","id":228781970,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzgxOTcw","html_url":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2","diff_url":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2.diff","patch_url":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2.patch","issue_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/2","number":2,"state":"open","locked":false,"title":"ONME-3859 Update network interface to have new address and interface …","user":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"body":" \r\n\r\n### Description\r\n\r\n ONME-3859 Update network interface to have new address and interface name interfaces\r\n ONME-3858 Implement socket interface binding to device (SO_BINDTODEVICE) to lwip\r\nTo do : ip_route and DNS\r\n\r\n\r\n### Pull request type\r\n\r\n \r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ X] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-11-06T17:56:05Z","updated_at":"2018-11-13T10:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c603e82d45753bb9958482b88b2a98097bb18e63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2/commits","review_comments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2/comments","review_comment_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/2/comments","statuses_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/statuses/9055eddd24d13d9b038306947cb814d35d3017d1","head":{"label":"tymoteuszblochmobica:SocketBind","ref":"SocketBind","sha":"9055eddd24d13d9b038306947cb814d35d3017d1","user":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"repo":{"id":156373796,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNzM3OTY=","name":"mbed-os","full_name":"tymoteuszblochmobica/mbed-os","private":false,"owner":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tymoteuszblochmobica/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os","forks_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/forks","keys_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/teams","hooks_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/events","assignees_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/tags","blobs_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/languages","stargazers_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/subscription","commits_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/merges","archive_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/downloads","issues_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/deployments","created_at":"2018-11-06T11:33:13Z","updated_at":"2018-11-12T10:58:03Z","pushed_at":"2018-11-12T18:47:41Z","git_url":"git://github.com/tymoteuszblochmobica/mbed-os.git","ssh_url":"git@github.com:tymoteuszblochmobica/mbed-os.git","clone_url":"https://github.com/tymoteuszblochmobica/mbed-os.git","svn_url":"https://github.com/tymoteuszblochmobica/mbed-os","homepage":"https://mbed.com","size":238294,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tymoteuszblochmobica:L3_interface","ref":"L3_interface","sha":"14eb7a5c43d90daf5244724c7086261652ed7d80","user":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"repo":{"id":156373796,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNzM3OTY=","name":"mbed-os","full_name":"tymoteuszblochmobica/mbed-os","private":false,"owner":{"login":"tymoteuszblochmobica","id":42803401,"node_id":"MDQ6VXNlcjQyODAzNDAx","avatar_url":"https://avatars2.githubusercontent.com/u/42803401?v=4","gravatar_id":"","url":"https://api.github.com/users/tymoteuszblochmobica","html_url":"https://github.com/tymoteuszblochmobica","followers_url":"https://api.github.com/users/tymoteuszblochmobica/followers","following_url":"https://api.github.com/users/tymoteuszblochmobica/following{/other_user}","gists_url":"https://api.github.com/users/tymoteuszblochmobica/gists{/gist_id}","starred_url":"https://api.github.com/users/tymoteuszblochmobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymoteuszblochmobica/subscriptions","organizations_url":"https://api.github.com/users/tymoteuszblochmobica/orgs","repos_url":"https://api.github.com/users/tymoteuszblochmobica/repos","events_url":"https://api.github.com/users/tymoteuszblochmobica/events{/privacy}","received_events_url":"https://api.github.com/users/tymoteuszblochmobica/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tymoteuszblochmobica/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os","forks_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/forks","keys_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/teams","hooks_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/events","assignees_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/tags","blobs_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/languages","stargazers_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/subscription","commits_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/merges","archive_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/downloads","issues_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/deployments","created_at":"2018-11-06T11:33:13Z","updated_at":"2018-11-12T10:58:03Z","pushed_at":"2018-11-12T18:47:41Z","git_url":"git://github.com/tymoteuszblochmobica/mbed-os.git","ssh_url":"git@github.com:tymoteuszblochmobica/mbed-os.git","clone_url":"https://github.com/tymoteuszblochmobica/mbed-os.git","svn_url":"https://github.com/tymoteuszblochmobica/mbed-os","homepage":"https://mbed.com","size":238294,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2"},"html":{"href":"https://github.com/tymoteuszblochmobica/mbed-os/pull/2"},"issue":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/2"},"comments":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/tymoteuszblochmobica/mbed-os/statuses/9055eddd24d13d9b038306947cb814d35d3017d1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tymoteuszblochmobica"}}