{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/211006083","pull_request_review_id":147347208,"id":211006083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTAwNjA4Mw==","diff_hunk":"@@ -238,8 +238,9 @@ def create_identifier(self, preprint, category, status='public', include_relatio\n         else:\n             raise NotImplementedError()\n \n-    def update_identifier(self, preprint, category):\n-        status = self.get_status(preprint)\n+    def update_identifier(self, preprint, category, status=None):\n+        if status is None:","path":"website/identifiers/clients/crossref.py","position":7,"original_position":7,"commit_id":"b45a00838d59ad8db779b498e30d9453f9e41c1e","original_commit_id":"b45a00838d59ad8db779b498e30d9453f9e41c1e","user":{"login":"mfraezz","id":5659262,"node_id":"MDQ6VXNlcjU2NTkyNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5659262?v=4","gravatar_id":"","url":"https://api.github.com/users/mfraezz","html_url":"https://github.com/mfraezz","followers_url":"https://api.github.com/users/mfraezz/followers","following_url":"https://api.github.com/users/mfraezz/following{/other_user}","gists_url":"https://api.github.com/users/mfraezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfraezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfraezz/subscriptions","organizations_url":"https://api.github.com/users/mfraezz/orgs","repos_url":"https://api.github.com/users/mfraezz/repos","events_url":"https://api.github.com/users/mfraezz/events{/privacy}","received_events_url":"https://api.github.com/users/mfraezz/received_events","type":"User","site_admin":false},"body":"Minor: this could be replaced with conditional assignment like `status = status or self.get_status(preprint)`","created_at":"2018-08-17T19:05:48Z","updated_at":"2018-08-17T19:06:07Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/8639#discussion_r211006083","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/211006083"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/8639#discussion_r211006083"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639","id":209224630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjI0NjMw","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/8639","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/8639.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/8639.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8639","number":8639,"state":"open","locked":false,"title":"[IN-282][OSF] Fix issue with updating preprint DOI metadata","user":{"login":"fabmiz","id":4511563,"node_id":"MDQ6VXNlcjQ1MTE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4511563?v=4","gravatar_id":"","url":"https://api.github.com/users/fabmiz","html_url":"https://github.com/fabmiz","followers_url":"https://api.github.com/users/fabmiz/followers","following_url":"https://api.github.com/users/fabmiz/following{/other_user}","gists_url":"https://api.github.com/users/fabmiz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabmiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabmiz/subscriptions","organizations_url":"https://api.github.com/users/fabmiz/orgs","repos_url":"https://api.github.com/users/fabmiz/repos","events_url":"https://api.github.com/users/fabmiz/events{/privacy}","received_events_url":"https://api.github.com/users/fabmiz/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nFix issue where updating preprint DOI metadata\r\nupon withdrawal, deletion, etc. fail\r\n\r\n## Changes\r\n\r\nPass `status` down to `request_identifier_update` instead of\r\ndoing a db query. We suspect a stale data somehow where preprint doi status is still\r\npublic (`verified_publishable`) after  withdrawal, deletion\r\n\r\n## QA Notes\r\nCreate a preprint and make sure it gets crossref doi, checking at `test.crossref.org` using the preprint doi to retrieve the submission xml. The status should be 'resolved' and you should be able to see the following fields `item_number`, `title`, `description`, `description`, etc elements in the submission xml file.\r\n\r\nCreate a withdrawal request and approve it, make sure that (may take a while) the fields mentioned above don't show in the submission xml file.\r\n\r\n## Documentation\r\n\r\n## Side Effects\r\n\r\n\r\n## Ticket\r\n\r\n[[IN-282]](https://openscience.atlassian.net/browse/IN-282)\r\n","created_at":"2018-08-17T18:29:29Z","updated_at":"2018-08-17T19:06:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9729a53c89c1ccc6074ba1f79591bacec3130a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8639/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/b45a00838d59ad8db779b498e30d9453f9e41c1e","head":{"label":"fabmiz:feature/IN-282-ADD","ref":"feature/IN-282-ADD","sha":"b45a00838d59ad8db779b498e30d9453f9e41c1e","user":{"login":"fabmiz","id":4511563,"node_id":"MDQ6VXNlcjQ1MTE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4511563?v=4","gravatar_id":"","url":"https://api.github.com/users/fabmiz","html_url":"https://github.com/fabmiz","followers_url":"https://api.github.com/users/fabmiz/followers","following_url":"https://api.github.com/users/fabmiz/following{/other_user}","gists_url":"https://api.github.com/users/fabmiz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabmiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabmiz/subscriptions","organizations_url":"https://api.github.com/users/fabmiz/orgs","repos_url":"https://api.github.com/users/fabmiz/repos","events_url":"https://api.github.com/users/fabmiz/events{/privacy}","received_events_url":"https://api.github.com/users/fabmiz/received_events","type":"User","site_admin":false},"repo":{"id":84862157,"node_id":"MDEwOlJlcG9zaXRvcnk4NDg2MjE1Nw==","name":"osf.io","full_name":"fabmiz/osf.io","owner":{"login":"fabmiz","id":4511563,"node_id":"MDQ6VXNlcjQ1MTE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4511563?v=4","gravatar_id":"","url":"https://api.github.com/users/fabmiz","html_url":"https://github.com/fabmiz","followers_url":"https://api.github.com/users/fabmiz/followers","following_url":"https://api.github.com/users/fabmiz/following{/other_user}","gists_url":"https://api.github.com/users/fabmiz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabmiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabmiz/subscriptions","organizations_url":"https://api.github.com/users/fabmiz/orgs","repos_url":"https://api.github.com/users/fabmiz/repos","events_url":"https://api.github.com/users/fabmiz/events{/privacy}","received_events_url":"https://api.github.com/users/fabmiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabmiz/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/fabmiz/osf.io","forks_url":"https://api.github.com/repos/fabmiz/osf.io/forks","keys_url":"https://api.github.com/repos/fabmiz/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabmiz/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabmiz/osf.io/teams","hooks_url":"https://api.github.com/repos/fabmiz/osf.io/hooks","issue_events_url":"https://api.github.com/repos/fabmiz/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/fabmiz/osf.io/events","assignees_url":"https://api.github.com/repos/fabmiz/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/fabmiz/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/fabmiz/osf.io/tags","blobs_url":"https://api.github.com/repos/fabmiz/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabmiz/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabmiz/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabmiz/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabmiz/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/fabmiz/osf.io/languages","stargazers_url":"https://api.github.com/repos/fabmiz/osf.io/stargazers","contributors_url":"https://api.github.com/repos/fabmiz/osf.io/contributors","subscribers_url":"https://api.github.com/repos/fabmiz/osf.io/subscribers","subscription_url":"https://api.github.com/repos/fabmiz/osf.io/subscription","commits_url":"https://api.github.com/repos/fabmiz/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabmiz/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabmiz/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabmiz/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabmiz/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/fabmiz/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabmiz/osf.io/merges","archive_url":"https://api.github.com/repos/fabmiz/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabmiz/osf.io/downloads","issues_url":"https://api.github.com/repos/fabmiz/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/fabmiz/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/fabmiz/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/fabmiz/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabmiz/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/fabmiz/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/fabmiz/osf.io/deployments","created_at":"2017-03-13T18:42:50Z","updated_at":"2017-03-13T18:43:01Z","pushed_at":"2018-08-17T18:18:33Z","git_url":"git://github.com/fabmiz/osf.io.git","ssh_url":"git@github.com:fabmiz/osf.io.git","clone_url":"https://github.com/fabmiz/osf.io.git","svn_url":"https://github.com/fabmiz/osf.io","homepage":"https://osf.io","size":173544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:release/next-interfaces","ref":"release/next-interfaces","sha":"ad4fc64b6b4e23d51674123c8fb363d7afc7675d","user":{"login":"CenterForOpenScience","id":3344584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDQ1ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5OTU5OQ==","name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDQ1ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/deployments","created_at":"2013-05-21T15:53:37Z","updated_at":"2018-08-17T15:46:57Z","pushed_at":"2018-08-17T18:29:30Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"https://osf.io","size":174936,"stargazers_count":454,"watchers_count":454,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":255,"open_issues":231,"watchers":454,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/8639"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8639"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/8639/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/8639/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/b45a00838d59ad8db779b498e30d9453f9e41c1e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mfraezz"}}