{"action":"created","issue":{"url":"https://api.github.com/repos/wix/react-native-navigation/issues/3954","repository_url":"https://api.github.com/repos/wix/react-native-navigation","labels_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3954/labels{/name}","comments_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3954/comments","events_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3954/events","html_url":"https://github.com/wix/react-native-navigation/issues/3954","id":359430507,"node_id":"MDU6SXNzdWUzNTk0MzA1MDc=","number":3954,"title":"[V2] Ability to add a stack to an overlay","user":{"login":"steve228uk","id":1169297,"node_id":"MDQ6VXNlcjExNjkyOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1169297?v=4","gravatar_id":"","url":"https://api.github.com/users/steve228uk","html_url":"https://github.com/steve228uk","followers_url":"https://api.github.com/users/steve228uk/followers","following_url":"https://api.github.com/users/steve228uk/following{/other_user}","gists_url":"https://api.github.com/users/steve228uk/gists{/gist_id}","starred_url":"https://api.github.com/users/steve228uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steve228uk/subscriptions","organizations_url":"https://api.github.com/users/steve228uk/orgs","repos_url":"https://api.github.com/users/steve228uk/repos","events_url":"https://api.github.com/users/steve228uk/events{/privacy}","received_events_url":"https://api.github.com/users/steve228uk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-12T11:07:31Z","updated_at":"2018-10-10T13:21:12Z","closed_at":null,"author_association":"NONE","body":"### Issue Description\r\n\r\nCurrently it's only possible to present a single component as an overlay on RNN v2. It would be great to be able to include a navigation stack within the overlay. This would make non-fullscreen modals easy to implement.\r\n\r\nThis is certainly possible natively on iOS but I'm not 100% it's viable on Android yet.\r\n\r\n### Steps to Reproduce / Code Snippets / Screenshots\r\n\r\nCurrent:\r\n\r\n```js\r\nNavigation.showOverlay({\r\n    component: {\r\n        name: componentName,\r\n        passProps: passProps,\r\n        options: options\r\n    }\r\n});\r\n```\r\n\r\nProposed:\r\n\r\n```js\r\nNavigation.showOverlay({\r\n    stack: {\r\n        children: [{\r\n            component: {\r\n                name: componentName,\r\n                passProps: passProps,\r\n                options: options\r\n            }\r\n        }]\r\n    }\r\n});\r\n```\r\n\r\nThis replicates the existing modal API.\r\n\r\n---\r\n### Environment\r\n* React Native Navigation version: 2.0.2521\r\n* React Native version: 0.56.0\r\n* Platform(s) (iOS, Android, or both?): Both\r\n* Device info (Simulator/Device? OS version? Debug/Release?): Simulator + Debug\r\n"},"comment":{"url":"https://api.github.com/repos/wix/react-native-navigation/issues/comments/428568680","html_url":"https://github.com/wix/react-native-navigation/issues/3954#issuecomment-428568680","issue_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3954","id":428568680,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODU2ODY4MA==","user":{"login":"guyca","id":12352397,"node_id":"MDQ6VXNlcjEyMzUyMzk3","avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T13:21:12Z","updated_at":"2018-10-10T13:21:12Z","author_association":"COLLABORATOR","body":"@steve228uk Would be cool if you add an e2e, to confirm this is indeed fixed, to [ComplexLayout.js](https://github.com/wix/react-native-navigation/blob/v2/playground/src/screens/ComplexLayout.js).\r\nIf dismissing the overlay doesn't work - then please add a failing e2e and we'll address this ASAP."}}
{"actor":{"display_login":"guyca"}}