{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/22694","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/22694/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22694/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/22694/events","html_url":"https://github.com/elastic/kibana/pull/22694","id":356982939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTA5MTcy","number":22694,"title":"Migrate base path APIs and UiSettings client to new platform","user":{"login":"spalger","id":1329312,"node_id":"MDQ6VXNlcjEzMjkzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"labels":[{"id":635458035,"node_id":"MDU6TGFiZWw2MzU0NTgwMzU=","url":"https://api.github.com/repos/elastic/kibana/labels/:New%20Platform","name":":New Platform","color":"009800","default":false},{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/:Platform","name":":Platform","color":"fef2c0","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-09-04T21:28:57Z","updated_at":"2018-09-08T04:06:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22694","html_url":"https://github.com/elastic/kibana/pull/22694","diff_url":"https://github.com/elastic/kibana/pull/22694.diff","patch_url":"https://github.com/elastic/kibana/pull/22694.patch"},"body":"Fixes #20697\r\n\r\nThis PR migrates the base path related methods from `ui/chrome` to `core.basePath` and the uiSettings to `core.uiSettings`. The two are not split into separate PRs because I'm kinda cramped for time right now so rather I split the changes up into two commits so that you can review them separately if you like. If you'd like I can submit them as separate PRs but the basePath PR will block the uiSettings PR either way.\r\n\r\nThere shouldn't be any API changes except one thing, since the existing implementation is so close to what we'd want from the new platform API I made the one change that is inconsistent with what we've been doing so far and moved `uiSettings.subscribe()` to `uiSettings.getUpdate$().subscribe()`. This method isn't super commonly used, but it is a breaking change that will likely impact plugins so I'll notify some folks if we decide to move forward this way. I can also make a super-light wrapper for angular that just updates this method if you prefer."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/419610924","html_url":"https://github.com/elastic/kibana/pull/22694#issuecomment-419610924","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22694","id":419610924,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTYxMDkyNA==","user":{"login":"elasticmachine","id":15837671,"node_id":"MDQ6VXNlcjE1ODM3Njcx","avatar_url":"https://avatars3.githubusercontent.com/u/15837671?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticmachine","html_url":"https://github.com/elasticmachine","followers_url":"https://api.github.com/users/elasticmachine/followers","following_url":"https://api.github.com/users/elasticmachine/following{/other_user}","gists_url":"https://api.github.com/users/elasticmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticmachine/subscriptions","organizations_url":"https://api.github.com/users/elasticmachine/orgs","repos_url":"https://api.github.com/users/elasticmachine/repos","events_url":"https://api.github.com/users/elasticmachine/events{/privacy}","received_events_url":"https://api.github.com/users/elasticmachine/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T04:06:03Z","updated_at":"2018-09-08T04:06:03Z","author_association":"NONE","body":"## :green_heart: Build Succeeded\n* [continuous-integration/kibana-ci/pull-request](https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/2107/)\n\n"}}
{"actor":{"display_login":"elasticmachine"}}