{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1","id":190185918,"html_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1","diff_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1.diff","patch_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1","number":1,"state":"open","locked":false,"title":"This gets the demo into a working state.","user":{"login":"jdotrjs","id":37101247,"avatar_url":"https://avatars0.githubusercontent.com/u/37101247?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotrjs","html_url":"https://github.com/jdotrjs","followers_url":"https://api.github.com/users/jdotrjs/followers","following_url":"https://api.github.com/users/jdotrjs/following{/other_user}","gists_url":"https://api.github.com/users/jdotrjs/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotrjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotrjs/subscriptions","organizations_url":"https://api.github.com/users/jdotrjs/orgs","repos_url":"https://api.github.com/users/jdotrjs/repos","events_url":"https://api.github.com/users/jdotrjs/events{/privacy}","received_events_url":"https://api.github.com/users/jdotrjs/received_events","type":"User","site_admin":false},"body":"I left in some of my debugging jank that wasn't game stopping (so no `debugger` calls) which we'll probably want to pull out. (I'm mostly talking about `bulletID`). I also didn't test anything _except_ the default demo so there are likely some bugs still left to clean out.\r\n\r\nSome comments I have that still need to be cleaned up in my code:\r\n\r\n- Instead of making a deep call into the bullet manager like so: `this.data.bulletManager.eventEmitter.emit('kill', this);`I might handle this by passing a function that can be called to report a kill; this makes the structure of bulletManager less visible to the bullet. I also didn't comb the codebase for other uses of the old style signal stuff (`onKill.dispatch`)\r\n- all the console.log needs to go\r\n- the bulletID stuff is maybe useful but unnecessary; i used it just to make sure my theory of reusing the first bullet in the pool was correct\r\n- `Bullet#update` is a shitshow right now :shame_hat:. I added a comment but basically I just inline create a new Rectangle which is not the right thing to do; a bit of spelunking is in order\r\n\r\nThoughts on future work -- interactions with the signaling and physics systems are pretty different in v3 than v2 so I think we'll need to pay specific attention to those edges before calling it done.\r\n\r\nAll in all this feels really good, I'm glad you decided to pick up porting it and I'm pretty excited to drop it into my next game when it's ready to go live, <3!\r\n\r\nThanks @16patsle!\r\n\r\n(random ps. I reflowed the text because of my editor but forgot to roll it back; sorry about that 😿)","created_at":"2018-05-24T06:51:47Z","updated_at":"2018-05-24T06:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/statuses/6da55f3b480bb4cd9511dfe0bf7d3936a3561a95","head":{"label":"jdotrjs:jdotrjs/debugging","ref":"jdotrjs/debugging","sha":"6da55f3b480bb4cd9511dfe0bf7d3936a3561a95","user":{"login":"jdotrjs","id":37101247,"avatar_url":"https://avatars0.githubusercontent.com/u/37101247?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotrjs","html_url":"https://github.com/jdotrjs","followers_url":"https://api.github.com/users/jdotrjs/followers","following_url":"https://api.github.com/users/jdotrjs/following{/other_user}","gists_url":"https://api.github.com/users/jdotrjs/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotrjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotrjs/subscriptions","organizations_url":"https://api.github.com/users/jdotrjs/orgs","repos_url":"https://api.github.com/users/jdotrjs/repos","events_url":"https://api.github.com/users/jdotrjs/events{/privacy}","received_events_url":"https://api.github.com/users/jdotrjs/received_events","type":"User","site_admin":false},"repo":{"id":134602686,"name":"phaser3-weapon-plugin","full_name":"jdotrjs/phaser3-weapon-plugin","owner":{"login":"jdotrjs","id":37101247,"avatar_url":"https://avatars0.githubusercontent.com/u/37101247?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotrjs","html_url":"https://github.com/jdotrjs","followers_url":"https://api.github.com/users/jdotrjs/followers","following_url":"https://api.github.com/users/jdotrjs/following{/other_user}","gists_url":"https://api.github.com/users/jdotrjs/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotrjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotrjs/subscriptions","organizations_url":"https://api.github.com/users/jdotrjs/orgs","repos_url":"https://api.github.com/users/jdotrjs/repos","events_url":"https://api.github.com/users/jdotrjs/events{/privacy}","received_events_url":"https://api.github.com/users/jdotrjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdotrjs/phaser3-weapon-plugin","description":"Weapon Plugin for Phaser 3","fork":true,"url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin","forks_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/forks","keys_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/teams","hooks_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/hooks","issue_events_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/events","assignees_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/tags","blobs_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/languages","stargazers_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/stargazers","contributors_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/contributors","subscribers_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/subscribers","subscription_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/subscription","commits_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/merges","archive_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/downloads","issues_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jdotrjs/phaser3-weapon-plugin/deployments","created_at":"2018-05-23T17:16:56Z","updated_at":"2018-05-23T17:16:58Z","pushed_at":"2018-05-24T06:39:18Z","git_url":"git://github.com/jdotrjs/phaser3-weapon-plugin.git","ssh_url":"git@github.com:jdotrjs/phaser3-weapon-plugin.git","clone_url":"https://github.com/jdotrjs/phaser3-weapon-plugin.git","svn_url":"https://github.com/jdotrjs/phaser3-weapon-plugin","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"16patsle:master","ref":"master","sha":"7fb9b685e4e30edf666ab1ebe2ed3a649038cfa0","user":{"login":"16patsle","id":7686840,"avatar_url":"https://avatars1.githubusercontent.com/u/7686840?v=4","gravatar_id":"","url":"https://api.github.com/users/16patsle","html_url":"https://github.com/16patsle","followers_url":"https://api.github.com/users/16patsle/followers","following_url":"https://api.github.com/users/16patsle/following{/other_user}","gists_url":"https://api.github.com/users/16patsle/gists{/gist_id}","starred_url":"https://api.github.com/users/16patsle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/16patsle/subscriptions","organizations_url":"https://api.github.com/users/16patsle/orgs","repos_url":"https://api.github.com/users/16patsle/repos","events_url":"https://api.github.com/users/16patsle/events{/privacy}","received_events_url":"https://api.github.com/users/16patsle/received_events","type":"User","site_admin":false},"repo":{"id":134062348,"name":"phaser3-weapon-plugin","full_name":"16patsle/phaser3-weapon-plugin","owner":{"login":"16patsle","id":7686840,"avatar_url":"https://avatars1.githubusercontent.com/u/7686840?v=4","gravatar_id":"","url":"https://api.github.com/users/16patsle","html_url":"https://github.com/16patsle","followers_url":"https://api.github.com/users/16patsle/followers","following_url":"https://api.github.com/users/16patsle/following{/other_user}","gists_url":"https://api.github.com/users/16patsle/gists{/gist_id}","starred_url":"https://api.github.com/users/16patsle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/16patsle/subscriptions","organizations_url":"https://api.github.com/users/16patsle/orgs","repos_url":"https://api.github.com/users/16patsle/repos","events_url":"https://api.github.com/users/16patsle/events{/privacy}","received_events_url":"https://api.github.com/users/16patsle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/16patsle/phaser3-weapon-plugin","description":"Weapon Plugin for Phaser 3","fork":false,"url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin","forks_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/forks","keys_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/teams","hooks_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/hooks","issue_events_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/events","assignees_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/tags","blobs_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/languages","stargazers_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/stargazers","contributors_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/contributors","subscribers_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/subscribers","subscription_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/subscription","commits_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/merges","archive_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/downloads","issues_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/labels{/name}","releases_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/deployments","created_at":"2018-05-19T13:02:37Z","updated_at":"2018-05-23T16:53:55Z","pushed_at":"2018-05-23T16:53:54Z","git_url":"git://github.com/16patsle/phaser3-weapon-plugin.git","ssh_url":"git@github.com:16patsle/phaser3-weapon-plugin.git","clone_url":"https://github.com/16patsle/phaser3-weapon-plugin.git","svn_url":"https://github.com/16patsle/phaser3-weapon-plugin","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1"},"html":{"href":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/statuses/6da55f3b480bb4cd9511dfe0bf7d3936a3561a95"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":181,"deletions":85,"changed_files":7}}
{"actor":{"display_login":"jdotrjs"}}