{"action":"created","comment":{"url":"https://api.github.com/repos/google/brotli/pulls/comments/178805047","pull_request_review_id":108924298,"id":178805047,"diff_hunk":"@@ -47,7 +55,7 @@\n #define BROTLI_MODERN_COMPILER 0\n #endif\n \n-#if defined(BROTLI_SHARED_COMPILATION) && defined(_WIN32)\n+#if defined(BROTLI_SHARED_COMPILATION) && (__has_declspec_attribute(dllexport) && __has_declspec_attribute(dllimport))","path":"c/include/brotli/port.h","position":20,"original_position":20,"commit_id":"228ee3c2693a352abfd7a3eb52e92ce5ad7e2160","original_commit_id":"228ee3c2693a352abfd7a3eb52e92ce5ad7e2160","user":{"login":"eustas","id":203457,"avatar_url":"https://avatars1.githubusercontent.com/u/203457?v=4","gravatar_id":"","url":"https://api.github.com/users/eustas","html_url":"https://github.com/eustas","followers_url":"https://api.github.com/users/eustas/followers","following_url":"https://api.github.com/users/eustas/following{/other_user}","gists_url":"https://api.github.com/users/eustas/gists{/gist_id}","starred_url":"https://api.github.com/users/eustas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eustas/subscriptions","organizations_url":"https://api.github.com/users/eustas/orgs","repos_url":"https://api.github.com/users/eustas/repos","events_url":"https://api.github.com/users/eustas/events{/privacy}","received_events_url":"https://api.github.com/users/eustas/received_events","type":"User","site_admin":false},"body":"Also, for more uniform code, it is better to use semantic derivative of check - i.e. define\r\nBROTLI_DLLIMPORT and BROTLI_DLLEXPORT (like here http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/LanguageExtensions.rst?view=diff&r1=223466&r2=223467&pathrev=223467) and use them in place of __declspec(xxx)","created_at":"2018-04-03T12:25:23Z","updated_at":"2018-04-03T12:25:23Z","html_url":"https://github.com/google/brotli/pull/647#discussion_r178805047","pull_request_url":"https://api.github.com/repos/google/brotli/pulls/647","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/brotli/pulls/comments/178805047"},"html":{"href":"https://github.com/google/brotli/pull/647#discussion_r178805047"},"pull_request":{"href":"https://api.github.com/repos/google/brotli/pulls/647"}}},"pull_request":{"url":"https://api.github.com/repos/google/brotli/pulls/647","id":173844426,"html_url":"https://github.com/google/brotli/pull/647","diff_url":"https://github.com/google/brotli/pull/647.diff","patch_url":"https://github.com/google/brotli/pull/647.patch","issue_url":"https://api.github.com/repos/google/brotli/issues/647","number":647,"state":"open","locked":false,"title":"Use __has_declspec_attribute to determine support","user":{"login":"donny-dont","id":666297,"avatar_url":"https://avatars0.githubusercontent.com/u/666297?v=4","gravatar_id":"","url":"https://api.github.com/users/donny-dont","html_url":"https://github.com/donny-dont","followers_url":"https://api.github.com/users/donny-dont/followers","following_url":"https://api.github.com/users/donny-dont/following{/other_user}","gists_url":"https://api.github.com/users/donny-dont/gists{/gist_id}","starred_url":"https://api.github.com/users/donny-dont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donny-dont/subscriptions","organizations_url":"https://api.github.com/users/donny-dont/orgs","repos_url":"https://api.github.com/users/donny-dont/repos","events_url":"https://api.github.com/users/donny-dont/events{/privacy}","received_events_url":"https://api.github.com/users/donny-dont/received_events","type":"User","site_admin":false},"body":"Clang has support for `__declspec` attributes and provides a mechanism to query whether it supports them through `__has_declspec_attribute`. \r\n\r\nhttps://clang.llvm.org/docs/LanguageExtensions.html#has-declspec-attribute","created_at":"2018-03-08T20:40:14Z","updated_at":"2018-04-03T12:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe9f90b6a03a6e4357e7b3d839b99be41ebc2d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/brotli/pulls/647/commits","review_comments_url":"https://api.github.com/repos/google/brotli/pulls/647/comments","review_comment_url":"https://api.github.com/repos/google/brotli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/brotli/issues/647/comments","statuses_url":"https://api.github.com/repos/google/brotli/statuses/228ee3c2693a352abfd7a3eb52e92ce5ad7e2160","head":{"label":"donny-dont:patch-1","ref":"patch-1","sha":"228ee3c2693a352abfd7a3eb52e92ce5ad7e2160","user":{"login":"donny-dont","id":666297,"avatar_url":"https://avatars0.githubusercontent.com/u/666297?v=4","gravatar_id":"","url":"https://api.github.com/users/donny-dont","html_url":"https://github.com/donny-dont","followers_url":"https://api.github.com/users/donny-dont/followers","following_url":"https://api.github.com/users/donny-dont/following{/other_user}","gists_url":"https://api.github.com/users/donny-dont/gists{/gist_id}","starred_url":"https://api.github.com/users/donny-dont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donny-dont/subscriptions","organizations_url":"https://api.github.com/users/donny-dont/orgs","repos_url":"https://api.github.com/users/donny-dont/repos","events_url":"https://api.github.com/users/donny-dont/events{/privacy}","received_events_url":"https://api.github.com/users/donny-dont/received_events","type":"User","site_admin":false},"repo":{"id":124445167,"name":"brotli","full_name":"donny-dont/brotli","owner":{"login":"donny-dont","id":666297,"avatar_url":"https://avatars0.githubusercontent.com/u/666297?v=4","gravatar_id":"","url":"https://api.github.com/users/donny-dont","html_url":"https://github.com/donny-dont","followers_url":"https://api.github.com/users/donny-dont/followers","following_url":"https://api.github.com/users/donny-dont/following{/other_user}","gists_url":"https://api.github.com/users/donny-dont/gists{/gist_id}","starred_url":"https://api.github.com/users/donny-dont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donny-dont/subscriptions","organizations_url":"https://api.github.com/users/donny-dont/orgs","repos_url":"https://api.github.com/users/donny-dont/repos","events_url":"https://api.github.com/users/donny-dont/events{/privacy}","received_events_url":"https://api.github.com/users/donny-dont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donny-dont/brotli","description":"Brotli compression format","fork":true,"url":"https://api.github.com/repos/donny-dont/brotli","forks_url":"https://api.github.com/repos/donny-dont/brotli/forks","keys_url":"https://api.github.com/repos/donny-dont/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donny-dont/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donny-dont/brotli/teams","hooks_url":"https://api.github.com/repos/donny-dont/brotli/hooks","issue_events_url":"https://api.github.com/repos/donny-dont/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/donny-dont/brotli/events","assignees_url":"https://api.github.com/repos/donny-dont/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/donny-dont/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/donny-dont/brotli/tags","blobs_url":"https://api.github.com/repos/donny-dont/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donny-dont/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donny-dont/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/donny-dont/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donny-dont/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/donny-dont/brotli/languages","stargazers_url":"https://api.github.com/repos/donny-dont/brotli/stargazers","contributors_url":"https://api.github.com/repos/donny-dont/brotli/contributors","subscribers_url":"https://api.github.com/repos/donny-dont/brotli/subscribers","subscription_url":"https://api.github.com/repos/donny-dont/brotli/subscription","commits_url":"https://api.github.com/repos/donny-dont/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/donny-dont/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/donny-dont/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/donny-dont/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/donny-dont/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/donny-dont/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donny-dont/brotli/merges","archive_url":"https://api.github.com/repos/donny-dont/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donny-dont/brotli/downloads","issues_url":"https://api.github.com/repos/donny-dont/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/donny-dont/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/donny-dont/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/donny-dont/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donny-dont/brotli/labels{/name}","releases_url":"https://api.github.com/repos/donny-dont/brotli/releases{/id}","deployments_url":"https://api.github.com/repos/donny-dont/brotli/deployments","created_at":"2018-03-08T20:35:50Z","updated_at":"2018-03-08T20:35:53Z","pushed_at":"2018-03-08T20:38:40Z","git_url":"git://github.com/donny-dont/brotli.git","ssh_url":"git@github.com:donny-dont/brotli.git","clone_url":"https://github.com/donny-dont/brotli.git","svn_url":"https://github.com/donny-dont/brotli","homepage":"","size":30946,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"533843e3546cd24c8344eaa899c6b0b681c8d222","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":24993138,"name":"brotli","full_name":"google/brotli","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/brotli","description":"Brotli compression format","fork":false,"url":"https://api.github.com/repos/google/brotli","forks_url":"https://api.github.com/repos/google/brotli/forks","keys_url":"https://api.github.com/repos/google/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/brotli/teams","hooks_url":"https://api.github.com/repos/google/brotli/hooks","issue_events_url":"https://api.github.com/repos/google/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/google/brotli/events","assignees_url":"https://api.github.com/repos/google/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/google/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/google/brotli/tags","blobs_url":"https://api.github.com/repos/google/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/google/brotli/languages","stargazers_url":"https://api.github.com/repos/google/brotli/stargazers","contributors_url":"https://api.github.com/repos/google/brotli/contributors","subscribers_url":"https://api.github.com/repos/google/brotli/subscribers","subscription_url":"https://api.github.com/repos/google/brotli/subscription","commits_url":"https://api.github.com/repos/google/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/google/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/brotli/merges","archive_url":"https://api.github.com/repos/google/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/brotli/downloads","issues_url":"https://api.github.com/repos/google/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/google/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/google/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/google/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/brotli/labels{/name}","releases_url":"https://api.github.com/repos/google/brotli/releases{/id}","deployments_url":"https://api.github.com/repos/google/brotli/deployments","created_at":"2014-10-09T14:35:14Z","updated_at":"2018-04-03T11:35:56Z","pushed_at":"2018-03-29T08:37:11Z","git_url":"git://github.com/google/brotli.git","ssh_url":"git@github.com:google/brotli.git","clone_url":"https://github.com/google/brotli.git","svn_url":"https://github.com/google/brotli","homepage":"","size":30989,"stargazers_count":5816,"watchers_count":5816,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":601,"open_issues":23,"watchers":5816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/brotli/pulls/647"},"html":{"href":"https://github.com/google/brotli/pull/647"},"issue":{"href":"https://api.github.com/repos/google/brotli/issues/647"},"comments":{"href":"https://api.github.com/repos/google/brotli/issues/647/comments"},"review_comments":{"href":"https://api.github.com/repos/google/brotli/pulls/647/comments"},"review_comment":{"href":"https://api.github.com/repos/google/brotli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/brotli/pulls/647/commits"},"statuses":{"href":"https://api.github.com/repos/google/brotli/statuses/228ee3c2693a352abfd7a3eb52e92ce5ad7e2160"}},"author_association":"NONE"}}
{"actor":{"display_login":"eustas"}}