{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/208468697","pull_request_review_id":144282257,"id":208468697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQ2ODY5Nw==","diff_hunk":"@@ -50,6 +50,24 @@ private[spark] class MesosRestServer(\n     new MesosKillRequestServlet(scheduler, masterConf)\n   protected override val statusRequestServlet =\n     new MesosStatusRequestServlet(scheduler, masterConf)\n+\n+  override def isServerHealthy(): Boolean = !scheduler.isSchedulerDriverStopped()\n+\n+  override def serverStatus(): ServerStatusResponse = {\n+    val s = new ServerStatusResponse\n+    s.schedulerDriverStopped = scheduler.isSchedulerDriverStopped()\n+    s.queuedDrivers = scheduler.getQueuedDriversSize\n+    s.launchedDrivers = scheduler.getLaunchedDriversSize\n+    s.pendingRetryDrivers = scheduler.getPendingRetryDriversSize\n+    s.success = true\n+    s.message = \"iamok\"","path":"resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala","position":14,"original_position":14,"commit_id":"dc06283885aed247391280a12e2cca1f6c6c22ff","original_commit_id":"dc06283885aed247391280a12e2cca1f6c6c22ff","user":{"login":"tnachen","id":67244,"node_id":"MDQ6VXNlcjY3MjQ0","avatar_url":"https://avatars2.githubusercontent.com/u/67244?v=4","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"body":"How about leaving this blank?","created_at":"2018-08-08T06:29:44Z","updated_at":"2018-08-08T06:29:45Z","html_url":"https://github.com/apache/spark/pull/21027#discussion_r208468697","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21027","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/208468697"},"html":{"href":"https://github.com/apache/spark/pull/21027#discussion_r208468697"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21027"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21027","id":180624977,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwNjI0OTc3","html_url":"https://github.com/apache/spark/pull/21027","diff_url":"https://github.com/apache/spark/pull/21027.diff","patch_url":"https://github.com/apache/spark/pull/21027.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21027","number":21027,"state":"open","locked":false,"title":"[SPARK-23943][MESOS][DEPLOY] Improve observability of MesosRestServer/MesosClusterDi…","user":{"login":"pmackles","id":1900673,"node_id":"MDQ6VXNlcjE5MDA2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1900673?v=4","gravatar_id":"","url":"https://api.github.com/users/pmackles","html_url":"https://github.com/pmackles","followers_url":"https://api.github.com/users/pmackles/followers","following_url":"https://api.github.com/users/pmackles/following{/other_user}","gists_url":"https://api.github.com/users/pmackles/gists{/gist_id}","starred_url":"https://api.github.com/users/pmackles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmackles/subscriptions","organizations_url":"https://api.github.com/users/pmackles/orgs","repos_url":"https://api.github.com/users/pmackles/repos","events_url":"https://api.github.com/users/pmackles/events{/privacy}","received_events_url":"https://api.github.com/users/pmackles/received_events","type":"User","site_admin":false},"body":"See https://issues.apache.org/jira/browse/SPARK-23943 for details on proposed changes\r\n\r\nTested manually on branch-2.3\r\n","created_at":"2018-04-10T14:38:29Z","updated_at":"2018-08-08T06:29:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7ce9e39053ba098c58d683d19d45ab93af60c60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21027/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21027/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21027/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/dc06283885aed247391280a12e2cca1f6c6c22ff","head":{"label":"pmackles:new-SPARK-23943","ref":"new-SPARK-23943","sha":"dc06283885aed247391280a12e2cca1f6c6c22ff","user":{"login":"pmackles","id":1900673,"node_id":"MDQ6VXNlcjE5MDA2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1900673?v=4","gravatar_id":"","url":"https://api.github.com/users/pmackles","html_url":"https://github.com/pmackles","followers_url":"https://api.github.com/users/pmackles/followers","following_url":"https://api.github.com/users/pmackles/following{/other_user}","gists_url":"https://api.github.com/users/pmackles/gists{/gist_id}","starred_url":"https://api.github.com/users/pmackles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmackles/subscriptions","organizations_url":"https://api.github.com/users/pmackles/orgs","repos_url":"https://api.github.com/users/pmackles/repos","events_url":"https://api.github.com/users/pmackles/events{/privacy}","received_events_url":"https://api.github.com/users/pmackles/received_events","type":"User","site_admin":false},"repo":{"id":104940182,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NDAxODI=","name":"spark","full_name":"pmackles/spark","owner":{"login":"pmackles","id":1900673,"node_id":"MDQ6VXNlcjE5MDA2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1900673?v=4","gravatar_id":"","url":"https://api.github.com/users/pmackles","html_url":"https://github.com/pmackles","followers_url":"https://api.github.com/users/pmackles/followers","following_url":"https://api.github.com/users/pmackles/following{/other_user}","gists_url":"https://api.github.com/users/pmackles/gists{/gist_id}","starred_url":"https://api.github.com/users/pmackles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmackles/subscriptions","organizations_url":"https://api.github.com/users/pmackles/orgs","repos_url":"https://api.github.com/users/pmackles/repos","events_url":"https://api.github.com/users/pmackles/events{/privacy}","received_events_url":"https://api.github.com/users/pmackles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmackles/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/pmackles/spark","forks_url":"https://api.github.com/repos/pmackles/spark/forks","keys_url":"https://api.github.com/repos/pmackles/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmackles/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmackles/spark/teams","hooks_url":"https://api.github.com/repos/pmackles/spark/hooks","issue_events_url":"https://api.github.com/repos/pmackles/spark/issues/events{/number}","events_url":"https://api.github.com/repos/pmackles/spark/events","assignees_url":"https://api.github.com/repos/pmackles/spark/assignees{/user}","branches_url":"https://api.github.com/repos/pmackles/spark/branches{/branch}","tags_url":"https://api.github.com/repos/pmackles/spark/tags","blobs_url":"https://api.github.com/repos/pmackles/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmackles/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmackles/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmackles/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmackles/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/pmackles/spark/languages","stargazers_url":"https://api.github.com/repos/pmackles/spark/stargazers","contributors_url":"https://api.github.com/repos/pmackles/spark/contributors","subscribers_url":"https://api.github.com/repos/pmackles/spark/subscribers","subscription_url":"https://api.github.com/repos/pmackles/spark/subscription","commits_url":"https://api.github.com/repos/pmackles/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmackles/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmackles/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmackles/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmackles/spark/contents/{+path}","compare_url":"https://api.github.com/repos/pmackles/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmackles/spark/merges","archive_url":"https://api.github.com/repos/pmackles/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmackles/spark/downloads","issues_url":"https://api.github.com/repos/pmackles/spark/issues{/number}","pulls_url":"https://api.github.com/repos/pmackles/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/pmackles/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/pmackles/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmackles/spark/labels{/name}","releases_url":"https://api.github.com/repos/pmackles/spark/releases{/id}","deployments_url":"https://api.github.com/repos/pmackles/spark/deployments","created_at":"2017-09-26T21:36:36Z","updated_at":"2017-09-26T21:37:07Z","pushed_at":"2018-04-16T00:00:55Z","git_url":"git://github.com/pmackles/spark.git","ssh_url":"git@github.com:pmackles/spark.git","clone_url":"https://github.com/pmackles/spark.git","svn_url":"https://github.com/pmackles/spark","homepage":null,"size":265716,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"95034af69623bb8be5b9f5eabf50980bdeca48e6","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-08T05:42:52Z","pushed_at":"2018-08-08T05:47:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":278972,"stargazers_count":18339,"watchers_count":18339,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16606,"mirror_url":null,"archived":false,"open_issues_count":487,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16606,"open_issues":487,"watchers":18339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21027"},"html":{"href":"https://github.com/apache/spark/pull/21027"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21027"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21027/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21027/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21027/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/dc06283885aed247391280a12e2cca1f6c6c22ff"}},"author_association":"NONE"}}
{"actor":{"display_login":"tnachen"}}