{"action":"created","issue":{"url":"https://api.github.com/repos/NaluCFD/Nalu/issues/327","repository_url":"https://api.github.com/repos/NaluCFD/Nalu","labels_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/327/comments","events_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/327/events","html_url":"https://github.com/NaluCFD/Nalu/pull/327","id":296011449,"number":327,"title":"Adding options to enable warnings","user":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-09T21:04:35Z","updated_at":"2018-02-12T18:53:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/327","html_url":"https://github.com/NaluCFD/Nalu/pull/327","diff_url":"https://github.com/NaluCFD/Nalu/pull/327.diff","patch_url":"https://github.com/NaluCFD/Nalu/pull/327.patch"},"body":"Since I've been looking at warnings today, I've just remembered that `-Wall` is not enabled by default, which is what I have the testing set for. To get everyone on the same page regarding warnings, this pull request sets `-Wall` by default and includes an option for adding `-Wextra`. These options are fairly portable across compilers."},"comment":{"url":"https://api.github.com/repos/NaluCFD/Nalu/issues/comments/365024255","html_url":"https://github.com/NaluCFD/Nalu/pull/327#issuecomment-365024255","issue_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/327","id":365024255,"user":{"login":"jrood-nrel","id":23264326,"avatar_url":"https://avatars1.githubusercontent.com/u/23264326?v=4","gravatar_id":"","url":"https://api.github.com/users/jrood-nrel","html_url":"https://github.com/jrood-nrel","followers_url":"https://api.github.com/users/jrood-nrel/followers","following_url":"https://api.github.com/users/jrood-nrel/following{/other_user}","gists_url":"https://api.github.com/users/jrood-nrel/gists{/gist_id}","starred_url":"https://api.github.com/users/jrood-nrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrood-nrel/subscriptions","organizations_url":"https://api.github.com/users/jrood-nrel/orgs","repos_url":"https://api.github.com/users/jrood-nrel/repos","events_url":"https://api.github.com/users/jrood-nrel/events{/privacy}","received_events_url":"https://api.github.com/users/jrood-nrel/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T18:53:10Z","updated_at":"2018-02-12T18:53:10Z","author_association":"CONTRIBUTOR","body":"@sayerhs I tested the flags with `icc` and it doesn't error, and I researched warnings in general with Intel. As far as I know `-Wall -Wextra -pedantic` is fine. I'm not sure it uses `-pedantic`, but I'm pretty sure it uses `-Wall -Wextra` as expected, and at least adding these shouldn't cause problems when compiling with Intel."}}
{"actor":{"display_login":"jrood-nrel"}}