{"action":"created","comment":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/182909249","pull_request_review_id":113806670,"id":182909249,"diff_hunk":"@@ -81,7 +81,7 @@ jobs:\n   ui_test:\n     <<: *container_config\n     docker:\n-      - image: circleci/node:7.10.0-browsers\n+      - image: circleci/node:8.11.1-browsers","path":".circleci/config.yml","position":5,"original_position":5,"commit_id":"76cb9810bc58549a81ab4a6e43019657d3884588","original_commit_id":"76cb9810bc58549a81ab4a6e43019657d3884588","user":{"login":"halprin","id":16943066,"avatar_url":"https://avatars0.githubusercontent.com/u/16943066?v=4","gravatar_id":"","url":"https://api.github.com/users/halprin","html_url":"https://github.com/halprin","followers_url":"https://api.github.com/users/halprin/followers","following_url":"https://api.github.com/users/halprin/following{/other_user}","gists_url":"https://api.github.com/users/halprin/gists{/gist_id}","starred_url":"https://api.github.com/users/halprin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halprin/subscriptions","organizations_url":"https://api.github.com/users/halprin/orgs","repos_url":"https://api.github.com/users/halprin/repos","events_url":"https://api.github.com/users/halprin/events{/privacy}","received_events_url":"https://api.github.com/users/halprin/received_events","type":"User","site_admin":false},"body":"Good idea!","created_at":"2018-04-19T23:08:12Z","updated_at":"2018-04-19T23:08:13Z","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/710#discussion_r182909249","pull_request_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/182909249"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/710#discussion_r182909249"},"pull_request":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710"}},"in_reply_to_id":182903249},"pull_request":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710","id":182849423,"html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/710","diff_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/710.diff","patch_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/710.patch","issue_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/710","number":710,"state":"open","locked":false,"title":"QPPCT-825: Update deployment version of yarn","user":{"login":"halprin","id":16943066,"avatar_url":"https://avatars0.githubusercontent.com/u/16943066?v=4","gravatar_id":"","url":"https://api.github.com/users/halprin","html_url":"https://github.com/halprin","followers_url":"https://api.github.com/users/halprin/followers","following_url":"https://api.github.com/users/halprin/following{/other_user}","gists_url":"https://api.github.com/users/halprin/gists{/gist_id}","starred_url":"https://api.github.com/users/halprin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halprin/subscriptions","organizations_url":"https://api.github.com/users/halprin/orgs","repos_url":"https://api.github.com/users/halprin/repos","events_url":"https://api.github.com/users/halprin/events{/privacy}","received_events_url":"https://api.github.com/users/halprin/received_events","type":"User","site_admin":false},"body":"### Information\r\n- JIRA story QPPCT-825.\r\n\r\n### Changes proposed in this PR:\r\n- Upgraded to a newer version of CircleCI's Node Docker image.  This uses a new version of Yarn that passes the command line arguments to Angular CLI (`ng`).\r\n- I tested this by running the same commands in our `ui_deployment` CircleCI job associated with building the frontend in a `circleci/node:8.11.1-browsers` Docker container.  I then inspected the output to make sure the base href was set correctly.\r\n\r\n### Checklist \r\n- [x] All JUnit tests pass (`mvn clean verify`).\r\n- [x] New unit tests written to cover new functionality.\r\n- [x] Added and updated JavaDocs for non-test classes and methods.\r\n- [x] No local design debt. Do you feel that something is \"ugly\" after your changes?\r\n- [x] Updated documentation (`README.md`, etc.) depending if the changes require it.","created_at":"2018-04-19T17:42:35Z","updated_at":"2018-04-19T23:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"049ecd4e28776d630a5e7ec2be8d2b7bb50cb167","assignee":null,"assignees":[],"requested_reviewers":[{"login":"clydet","id":1957663,"avatar_url":"https://avatars0.githubusercontent.com/u/1957663?v=4","gravatar_id":"","url":"https://api.github.com/users/clydet","html_url":"https://github.com/clydet","followers_url":"https://api.github.com/users/clydet/followers","following_url":"https://api.github.com/users/clydet/following{/other_user}","gists_url":"https://api.github.com/users/clydet/gists{/gist_id}","starred_url":"https://api.github.com/users/clydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clydet/subscriptions","organizations_url":"https://api.github.com/users/clydet/orgs","repos_url":"https://api.github.com/users/clydet/repos","events_url":"https://api.github.com/users/clydet/events{/privacy}","received_events_url":"https://api.github.com/users/clydet/received_events","type":"User","site_admin":false},{"login":"saquino0827","id":26700499,"avatar_url":"https://avatars3.githubusercontent.com/u/26700499?v=4","gravatar_id":"","url":"https://api.github.com/users/saquino0827","html_url":"https://github.com/saquino0827","followers_url":"https://api.github.com/users/saquino0827/followers","following_url":"https://api.github.com/users/saquino0827/following{/other_user}","gists_url":"https://api.github.com/users/saquino0827/gists{/gist_id}","starred_url":"https://api.github.com/users/saquino0827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquino0827/subscriptions","organizations_url":"https://api.github.com/users/saquino0827/orgs","repos_url":"https://api.github.com/users/saquino0827/repos","events_url":"https://api.github.com/users/saquino0827/events{/privacy}","received_events_url":"https://api.github.com/users/saquino0827/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710/commits","review_comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710/comments","review_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/710/comments","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/76cb9810bc58549a81ab4a6e43019657d3884588","head":{"label":"CMSgov:story-825-yarn","ref":"story-825-yarn","sha":"76cb9810bc58549a81ab4a6e43019657d3884588","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-04-19T21:27:44Z","pushed_at":"2018-04-19T22:31:22Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":23239,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":16,"open_issues":8,"watchers":9,"default_branch":"develop"}},"base":{"label":"CMSgov:develop","ref":"develop","sha":"c145a45d9609bdf3401b337bc3055cd38c9cb157","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-04-19T21:27:44Z","pushed_at":"2018-04-19T22:31:22Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":23239,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":16,"open_issues":8,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/710"},"issue":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/710"},"comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/76cb9810bc58549a81ab4a6e43019657d3884588"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"halprin"}}