{"action":"created","comment":{"url":"https://api.github.com/repos/telus/tds-community/pulls/comments/238011466","pull_request_review_id":180455993,"id":238011466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAxMTQ2Ng==","diff_hunk":"@@ -108,47 +111,80 @@ TDS Components must follow [semantic versioning](https://semver.org/) in order f\n \n Due to the subjectivity of versioning front-end components, keep these suggestions in mind when making conventional commits:\n \n-* **Breaking changes** are removals of features such as props, changes that affect the [box model](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model), or dramatic changes in branding or appearance\n-* **Minor changes** are new features, animations, props, or visual options\n-* **Patches** are defect fixes that do not remove features, alter pixel dimensions related to the box model, nor add new features. If an intended feature was not working in a previous release, changing that feature to match the original design counts as a patch even if it affects the box model\n+- **Breaking changes** are removals of features such as props, changes that affect the [box model](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model), or dramatic changes in branding or appearance\n+- **Minor changes** are new features, animations, props, or visual options\n+- **Patches** are defect fixes that do not remove features, alter pixel dimensions related to the box model, nor add new features. If an intended feature was not working in a previous release, changing that feature to match the original design counts as a patch even if it affects the box model\n+\n+Commits should always be in the following format:\n+\n+```\n+type(scope): commit message here\n+```\n+\n+This format always includes:\n+\n+- Commit type\n+- Commit scope in brackets, followed by a colon\n+- A message describing what the commit is, preferably written in present tense with no capital letters\n+\n+#### Commit types\n+\n+| Type     | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |\n+| -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n+| feat     | Indicates a **minor, public-facing change**. A change is considered minor if it adds new functionality in a backwards-compatible manner. It must also be perceivable by consumers of TDS Community, and not just a change that only impacts developers of TDS Community. Additionally, it may be used if functionality is being **deprecated**. If a commit of this type contains a public-facing **breaking change**, add the text `BREAKING CHANGE:` to your commit’s body, followed by a description of what the breaking change is. |\n+| fix      | Indicates a patch level, **public-facing** change. Generally, this is used for backwards-compatible bug fixes. There should be no consumer-facing API changes at all in patches. It must also be perceivable by consumers of TDS, and not just a change that only impacts developers of TDS Community.                                                                                                                                                                                                                                  |\n+| test     | Used for commits that only modify/add **unit tests** or anything test related, such as **snapshots**, **screenshots**, or **test scripts**.                                                                                                                                                                                                                                                                                                                                                                                             |\n+| refactor | Used if code has been refactored **without any modifications to functionality or behaviour**. If your refactor also fixes a bug, please use the `fix` type. A common scenario for using this type would be “preventative maintenance” to code. This is also useful when iterating on changes due to PR reviews or other factors. Only one commit may be labeled as a `fix` or `feat` for any one change, so commits following that to iterate on the same feature will either be a `chore` or `refactor`.                               |\n+| docs     | Indicates a modification to **documentation**. Changes to the .md files of components, or changes to the documentation site use this type.                                                                                                                                                                                                                                                                                                                                                                                              |\n+| chore    | A type for **miscellaneous** changes. Anything not covered here is considered a chore. Additionally, this is useful when iterating on changes due to PR reviews or other factors. Only one commit may be labeled as a `fix` or `feat` for any one change, so commits following that to iterate on the same feature will either be a `chore` or `refactor`.                                                                                                                                                                              |\n+\n+#### Commit scopes\n+\n+There are two things that could be used as a commit scope:\n+\n+- If modifying a component, use the full package name of said component. Example: `(community-sample-pilter)`.","path":".github/CONTRIBUTING.md","position":141,"original_position":141,"commit_id":"23bbe2919321a965256f8fe40f32098cb916d308","original_commit_id":"23bbe2919321a965256f8fe40f32098cb916d308","user":{"login":"theetrain","id":12798751,"node_id":"MDQ6VXNlcjEyNzk4NzUx","avatar_url":"https://avatars0.githubusercontent.com/u/12798751?v=4","gravatar_id":"","url":"https://api.github.com/users/theetrain","html_url":"https://github.com/theetrain","followers_url":"https://api.github.com/users/theetrain/followers","following_url":"https://api.github.com/users/theetrain/following{/other_user}","gists_url":"https://api.github.com/users/theetrain/gists{/gist_id}","starred_url":"https://api.github.com/users/theetrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theetrain/subscriptions","organizations_url":"https://api.github.com/users/theetrain/orgs","repos_url":"https://api.github.com/users/theetrain/repos","events_url":"https://api.github.com/users/theetrain/events{/privacy}","received_events_url":"https://api.github.com/users/theetrain/received_events","type":"User","site_admin":false},"body":"This can be a numbered list","created_at":"2018-11-30T21:44:11Z","updated_at":"2018-11-30T21:46:14Z","html_url":"https://github.com/telus/tds-community/pull/145#discussion_r238011466","pull_request_url":"https://api.github.com/repos/telus/tds-community/pulls/145","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telus/tds-community/pulls/comments/238011466"},"html":{"href":"https://github.com/telus/tds-community/pull/145#discussion_r238011466"},"pull_request":{"href":"https://api.github.com/repos/telus/tds-community/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/telus/tds-community/pulls/145","id":235115428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTE1NDI4","html_url":"https://github.com/telus/tds-community/pull/145","diff_url":"https://github.com/telus/tds-community/pull/145.diff","patch_url":"https://github.com/telus/tds-community/pull/145.patch","issue_url":"https://api.github.com/repos/telus/tds-community/issues/145","number":145,"state":"open","locked":false,"title":"docs(github): enhance contributing guide and pr template","user":{"login":"marcod1419","id":10531523,"node_id":"MDQ6VXNlcjEwNTMxNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/10531523?v=4","gravatar_id":"","url":"https://api.github.com/users/marcod1419","html_url":"https://github.com/marcod1419","followers_url":"https://api.github.com/users/marcod1419/followers","following_url":"https://api.github.com/users/marcod1419/following{/other_user}","gists_url":"https://api.github.com/users/marcod1419/gists{/gist_id}","starred_url":"https://api.github.com/users/marcod1419/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcod1419/subscriptions","organizations_url":"https://api.github.com/users/marcod1419/orgs","repos_url":"https://api.github.com/users/marcod1419/repos","events_url":"https://api.github.com/users/marcod1419/events{/privacy}","received_events_url":"https://api.github.com/users/marcod1419/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis adds some extra info to the contributing guide. Additionally, this updates the pull request template to account for TravisCI and TDSBot.\r\n\r\n## Checklist before submitting pull request\r\n\r\n- Commits follow our [Developer Guide](https://github.com/telus/tds-community/blob/chore/template-hints/.github/CONTRIBUTING.md)\r\n- [x] New code is unit tested\r\n- [x] For code changes, run `yarn prepr` locally\r\n  - make sure visual and accessibility tests pass\r\n  - paste the lerna version output\r\n","created_at":"2018-11-30T21:07:28Z","updated_at":"2018-11-30T21:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c737aae68665a4d8c93b2328830312f454f0dcf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"simpleimpulse","id":2739819,"node_id":"MDQ6VXNlcjI3Mzk4MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2739819?v=4","gravatar_id":"","url":"https://api.github.com/users/simpleimpulse","html_url":"https://github.com/simpleimpulse","followers_url":"https://api.github.com/users/simpleimpulse/followers","following_url":"https://api.github.com/users/simpleimpulse/following{/other_user}","gists_url":"https://api.github.com/users/simpleimpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/simpleimpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpleimpulse/subscriptions","organizations_url":"https://api.github.com/users/simpleimpulse/orgs","repos_url":"https://api.github.com/users/simpleimpulse/repos","events_url":"https://api.github.com/users/simpleimpulse/events{/privacy}","received_events_url":"https://api.github.com/users/simpleimpulse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telus/tds-community/pulls/145/commits","review_comments_url":"https://api.github.com/repos/telus/tds-community/pulls/145/comments","review_comment_url":"https://api.github.com/repos/telus/tds-community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telus/tds-community/issues/145/comments","statuses_url":"https://api.github.com/repos/telus/tds-community/statuses/23bbe2919321a965256f8fe40f32098cb916d308","head":{"label":"telus:docs/contributing-guide","ref":"docs/contributing-guide","sha":"23bbe2919321a965256f8fe40f32098cb916d308","user":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"repo":{"id":121262617,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNjI2MTc=","name":"tds-community","full_name":"telus/tds-community","private":false,"owner":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telus/tds-community","description":"TELUS Design System Community Components","fork":false,"url":"https://api.github.com/repos/telus/tds-community","forks_url":"https://api.github.com/repos/telus/tds-community/forks","keys_url":"https://api.github.com/repos/telus/tds-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telus/tds-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telus/tds-community/teams","hooks_url":"https://api.github.com/repos/telus/tds-community/hooks","issue_events_url":"https://api.github.com/repos/telus/tds-community/issues/events{/number}","events_url":"https://api.github.com/repos/telus/tds-community/events","assignees_url":"https://api.github.com/repos/telus/tds-community/assignees{/user}","branches_url":"https://api.github.com/repos/telus/tds-community/branches{/branch}","tags_url":"https://api.github.com/repos/telus/tds-community/tags","blobs_url":"https://api.github.com/repos/telus/tds-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telus/tds-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telus/tds-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/telus/tds-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telus/tds-community/statuses/{sha}","languages_url":"https://api.github.com/repos/telus/tds-community/languages","stargazers_url":"https://api.github.com/repos/telus/tds-community/stargazers","contributors_url":"https://api.github.com/repos/telus/tds-community/contributors","subscribers_url":"https://api.github.com/repos/telus/tds-community/subscribers","subscription_url":"https://api.github.com/repos/telus/tds-community/subscription","commits_url":"https://api.github.com/repos/telus/tds-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/telus/tds-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/telus/tds-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/telus/tds-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/telus/tds-community/contents/{+path}","compare_url":"https://api.github.com/repos/telus/tds-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telus/tds-community/merges","archive_url":"https://api.github.com/repos/telus/tds-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telus/tds-community/downloads","issues_url":"https://api.github.com/repos/telus/tds-community/issues{/number}","pulls_url":"https://api.github.com/repos/telus/tds-community/pulls{/number}","milestones_url":"https://api.github.com/repos/telus/tds-community/milestones{/number}","notifications_url":"https://api.github.com/repos/telus/tds-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telus/tds-community/labels{/name}","releases_url":"https://api.github.com/repos/telus/tds-community/releases{/id}","deployments_url":"https://api.github.com/repos/telus/tds-community/deployments","created_at":"2018-02-12T15:18:07Z","updated_at":"2018-11-27T15:15:56Z","pushed_at":"2018-11-30T21:08:14Z","git_url":"git://github.com/telus/tds-community.git","ssh_url":"git@github.com:telus/tds-community.git","clone_url":"https://github.com/telus/tds-community.git","svn_url":"https://github.com/telus/tds-community","homepage":"","size":1755,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":57,"watchers":4,"default_branch":"master"}},"base":{"label":"telus:master","ref":"master","sha":"b5b243a72183e09f08b6cf8d574a462a5b124b01","user":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"repo":{"id":121262617,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNjI2MTc=","name":"tds-community","full_name":"telus/tds-community","private":false,"owner":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telus/tds-community","description":"TELUS Design System Community Components","fork":false,"url":"https://api.github.com/repos/telus/tds-community","forks_url":"https://api.github.com/repos/telus/tds-community/forks","keys_url":"https://api.github.com/repos/telus/tds-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telus/tds-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telus/tds-community/teams","hooks_url":"https://api.github.com/repos/telus/tds-community/hooks","issue_events_url":"https://api.github.com/repos/telus/tds-community/issues/events{/number}","events_url":"https://api.github.com/repos/telus/tds-community/events","assignees_url":"https://api.github.com/repos/telus/tds-community/assignees{/user}","branches_url":"https://api.github.com/repos/telus/tds-community/branches{/branch}","tags_url":"https://api.github.com/repos/telus/tds-community/tags","blobs_url":"https://api.github.com/repos/telus/tds-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telus/tds-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telus/tds-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/telus/tds-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telus/tds-community/statuses/{sha}","languages_url":"https://api.github.com/repos/telus/tds-community/languages","stargazers_url":"https://api.github.com/repos/telus/tds-community/stargazers","contributors_url":"https://api.github.com/repos/telus/tds-community/contributors","subscribers_url":"https://api.github.com/repos/telus/tds-community/subscribers","subscription_url":"https://api.github.com/repos/telus/tds-community/subscription","commits_url":"https://api.github.com/repos/telus/tds-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/telus/tds-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/telus/tds-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/telus/tds-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/telus/tds-community/contents/{+path}","compare_url":"https://api.github.com/repos/telus/tds-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telus/tds-community/merges","archive_url":"https://api.github.com/repos/telus/tds-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telus/tds-community/downloads","issues_url":"https://api.github.com/repos/telus/tds-community/issues{/number}","pulls_url":"https://api.github.com/repos/telus/tds-community/pulls{/number}","milestones_url":"https://api.github.com/repos/telus/tds-community/milestones{/number}","notifications_url":"https://api.github.com/repos/telus/tds-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telus/tds-community/labels{/name}","releases_url":"https://api.github.com/repos/telus/tds-community/releases{/id}","deployments_url":"https://api.github.com/repos/telus/tds-community/deployments","created_at":"2018-02-12T15:18:07Z","updated_at":"2018-11-27T15:15:56Z","pushed_at":"2018-11-30T21:08:14Z","git_url":"git://github.com/telus/tds-community.git","ssh_url":"git@github.com:telus/tds-community.git","clone_url":"https://github.com/telus/tds-community.git","svn_url":"https://github.com/telus/tds-community","homepage":"","size":1755,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":57,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telus/tds-community/pulls/145"},"html":{"href":"https://github.com/telus/tds-community/pull/145"},"issue":{"href":"https://api.github.com/repos/telus/tds-community/issues/145"},"comments":{"href":"https://api.github.com/repos/telus/tds-community/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/telus/tds-community/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/telus/tds-community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telus/tds-community/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/telus/tds-community/statuses/23bbe2919321a965256f8fe40f32098cb916d308"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theetrain"}}