{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/170960326","pull_request_review_id":99728430,"id":170960326,"diff_hunk":"@@ -42,10 +54,15 @@ def exception_handler(exception_type, exception, exception_traceback, *,\n     exit_code = 1\n     is_snapcraft_error = issubclass(exception_type, errors.SnapcraftError)\n \n-    if debug or not is_snapcraft_error:\n+    if debug:\n         traceback.print_exception(\n             exception_type, exception, exception_traceback)\n \n+    if not is_snapcraft_error:\n+        echo.error('Sorry, Snapcraft had an internal error.')\n+        if RavenClient is not None and _is_environment_ok():\n+            _submit_trace(exception)","path":"snapcraft/cli/_errors.py","position":45,"original_position":45,"commit_id":"048ba78c1916608cd6d91f2c60f773ca0a4ec3eb","original_commit_id":"048ba78c1916608cd6d91f2c60f773ca0a4ec3eb","user":{"login":"elopio","id":617831,"avatar_url":"https://avatars3.githubusercontent.com/u/617831?v=4","gravatar_id":"","url":"https://api.github.com/users/elopio","html_url":"https://github.com/elopio","followers_url":"https://api.github.com/users/elopio/followers","following_url":"https://api.github.com/users/elopio/following{/other_user}","gists_url":"https://api.github.com/users/elopio/gists{/gist_id}","starred_url":"https://api.github.com/users/elopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopio/subscriptions","organizations_url":"https://api.github.com/users/elopio/orgs","repos_url":"https://api.github.com/users/elopio/repos","events_url":"https://api.github.com/users/elopio/events{/privacy}","received_events_url":"https://api.github.com/users/elopio/received_events","type":"User","site_admin":false},"body":"When raven is not available, the message about sorry feels very empty. Shouldn't we give a link to report the issue, at least? Or point people to the forum to talk about it.","created_at":"2018-02-27T15:28:48Z","updated_at":"2018-02-27T15:28:48Z","html_url":"https://github.com/snapcore/snapcraft/pull/1947#discussion_r170960326","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/170960326"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1947#discussion_r170960326"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947","id":170538708,"html_url":"https://github.com/snapcore/snapcraft/pull/1947","diff_url":"https://github.com/snapcore/snapcraft/pull/1947.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/1947.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1947","number":1947,"state":"open","locked":false,"title":"errors: add ability to send stack traces to sentry","user":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"Adds the ability to send reports, asking for confirmation before doing\r\nso.\r\n\r\nCloses: #1918\r\n\r\n- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh unit`?\r\n\r\n-----\r\n","created_at":"2018-02-21T17:33:33Z","updated_at":"2018-02-27T15:28:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8536e2328130ef67c9b91dbb3453c914ec24bac6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1947/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/048ba78c1916608cd6d91f2c60f773ca0a4ec3eb","head":{"label":"sergiusens:sentry","ref":"sentry","sha":"048ba78c1916608cd6d91f2c60f773ca0a4ec3eb","user":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"repo":{"id":45202272,"name":"snapcraft","full_name":"sergiusens/snapcraft","owner":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergiusens/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/sergiusens/snapcraft","forks_url":"https://api.github.com/repos/sergiusens/snapcraft/forks","keys_url":"https://api.github.com/repos/sergiusens/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergiusens/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergiusens/snapcraft/teams","hooks_url":"https://api.github.com/repos/sergiusens/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/sergiusens/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/sergiusens/snapcraft/events","assignees_url":"https://api.github.com/repos/sergiusens/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/sergiusens/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/sergiusens/snapcraft/tags","blobs_url":"https://api.github.com/repos/sergiusens/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergiusens/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergiusens/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergiusens/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergiusens/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/sergiusens/snapcraft/languages","stargazers_url":"https://api.github.com/repos/sergiusens/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/sergiusens/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/sergiusens/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/sergiusens/snapcraft/subscription","commits_url":"https://api.github.com/repos/sergiusens/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergiusens/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergiusens/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergiusens/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergiusens/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/sergiusens/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergiusens/snapcraft/merges","archive_url":"https://api.github.com/repos/sergiusens/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergiusens/snapcraft/downloads","issues_url":"https://api.github.com/repos/sergiusens/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/sergiusens/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/sergiusens/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/sergiusens/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergiusens/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/sergiusens/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/sergiusens/snapcraft/deployments","created_at":"2015-10-29T18:19:58Z","updated_at":"2016-01-28T18:31:38Z","pushed_at":"2018-02-27T14:17:58Z","git_url":"git://github.com/sergiusens/snapcraft.git","ssh_url":"git@github.com:sergiusens/snapcraft.git","clone_url":"https://github.com/sergiusens/snapcraft.git","svn_url":"https://github.com/sergiusens/snapcraft","homepage":null,"size":9065,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:reports","ref":"reports","sha":"55ad11ccc4f35856278748ca74618431f0687d04","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2018-02-26T20:21:30Z","pushed_at":"2018-02-27T14:41:40Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8999,"stargazers_count":528,"watchers_count":528,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":242,"open_issues":90,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1947"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1947"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/048ba78c1916608cd6d91f2c60f773ca0a4ec3eb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elopio"}}