{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/236905196","pull_request_review_id":179080804,"id":236905196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjkwNTE5Ng==","diff_hunk":"@@ -2043,30 +2062,28 @@ DefExpr* buildClassDefExpr(const char*  name,\n                            BlockStmt*   decls,\n                            Flag         isExtern,\n                            const char*  docs) {\n-  AggregateType* ct = new AggregateType(tag);\n+  AggregateType* ct = NULL;\n+  TypeSymbol* ts = NULL;\n+\n+  ct = new AggregateType(tag);\n \n   // Hook the string type in the modules\n   // to avoid duplication with dtString created in initPrimitiveTypes().\n   // gatherWellKnownTypes runs too late to help.\n-  if (strcmp(\"string\", name) == 0) {\n-    *dtString = *ct;\n-\n-    // These fields get overwritten with `ct` by the assignment.\n-    // These fields are set to `this` by the AggregateType constructor\n-    // so they should still be `dtString`. Fix them back up.\n-    dtString->fields.parent   = dtString;\n-    dtString->inherits.parent = dtString;\n-\n-    gAggregateTypes.remove(gAggregateTypes.index(ct));\n-\n-    delete ct;\n-\n-    ct = dtString;\n+  if (strcmp(\"_string\", name) == 0) {\n+    gdbShouldBreakHere();","path":"compiler/AST/build.cpp","position":78,"original_position":78,"commit_id":"a0e01b0c41da71844f16fcd241331914aed70c0f","original_commit_id":"a0e01b0c41da71844f16fcd241331914aed70c0f","user":{"login":"bradcray","id":7536222,"node_id":"MDQ6VXNlcjc1MzYyMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7536222?v=4","gravatar_id":"","url":"https://api.github.com/users/bradcray","html_url":"https://github.com/bradcray","followers_url":"https://api.github.com/users/bradcray/followers","following_url":"https://api.github.com/users/bradcray/following{/other_user}","gists_url":"https://api.github.com/users/bradcray/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcray/subscriptions","organizations_url":"https://api.github.com/users/bradcray/orgs","repos_url":"https://api.github.com/users/bradcray/repos","events_url":"https://api.github.com/users/bradcray/events{/privacy}","received_events_url":"https://api.github.com/users/bradcray/received_events","type":"User","site_admin":false},"body":"Should these gdbShouldBreakHere() calls be removed now?  (were they debugging code?)","created_at":"2018-11-28T00:52:15Z","updated_at":"2018-11-28T00:52:15Z","html_url":"https://github.com/chapel-lang/chapel/pull/11405#discussion_r236905196","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/236905196"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/11405#discussion_r236905196"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405","id":224096792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDk2Nzky","html_url":"https://github.com/chapel-lang/chapel/pull/11405","diff_url":"https://github.com/chapel-lang/chapel/pull/11405.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/11405.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11405","number":11405,"state":"open","locked":false,"title":"Reserve int etc. and improve error messages for var int","user":{"login":"mppf","id":3653132,"node_id":"MDQ6VXNlcjM2NTMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"This PR makes `int` `real` etc. reserved words in the language.\r\n\r\nAdditionally it improves error reporting when declaring a variable, argument, function, or class using one of the reserved types. It reports an error at parse-time in that event.\r\n\r\nChanges to the lexer:\r\n * add TBOOL TCOMPLEX TIMAG TINT TREAL TSTRING TUINT TTHIS TLOCALE\r\n\r\nChanges to the parser:\r\n * add the new tokens, alphabetize tokens with separate lines for different first letters\r\n * splits uses of ident into several new nonterminals:\r\n     * ident_def, for places that would redefine it. This nonterminal parses reserved types like `int` but will raise an error if it finds them. The nonterminal internal_type_ident_def is just a list of the reserved types.\r\n     * ident_fn_def, like ident_def but allows `this` (since we can make methods with that name)\r\n     * opt_label_ident, for `break` and `continue` labels. For simplicity this just optionally contains a TIDENT.\r\n     * ident_use, for uses of an identifier that need a string\r\n    * scalar_type, for uses of `int` e.g., where an Expr* can be returned\r\n    * reserved_type_ident_use, for uses of `borrowed`, `sync`, etc. These need a slightly different strategy from `scalar_type` in order to avoid parser conflicts. This nonterminal allows simplification of some repeated code for sync/single/...\r\n   * use assignop_ident to simplify some repetition in assignment_stmt\r\n\r\nFuture work:\r\n * better error for `for bool in 1..10`\r\n * better error for `f(int=3)`\r\n * better error for `break int;`\r\n * better error for `something.int`\r\n\r\n- [x] pull strcmps out\r\n- [x] rebase onto master\r\n- [ ] regerenate parser\r\n- [ ] passed full local testing (except for some ipe failures)\r\n- [ ] merge #11310 first, or fix the ipe issue\r\n- [x] add locale","created_at":"2018-10-18T20:57:23Z","updated_at":"2018-11-28T00:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b674c1bf1c492cc573688954158c392751127367","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":195153428,"node_id":"MDU6TGFiZWwxOTUxNTM0Mjg=","url":"https://api.github.com/repos/chapel-lang/chapel/labels/stat:%20Work%20in%20Progress","name":"stat: Work in Progress","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11405/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/a0e01b0c41da71844f16fcd241331914aed70c0f","head":{"label":"mppf:reservePrimTypes","ref":"reservePrimTypes","sha":"a0e01b0c41da71844f16fcd241331914aed70c0f","user":{"login":"mppf","id":3653132,"node_id":"MDQ6VXNlcjM2NTMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"repo":{"id":22106313,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEwNjMxMw==","name":"chapel","full_name":"mppf/chapel","private":false,"owner":{"login":"mppf","id":3653132,"node_id":"MDQ6VXNlcjM2NTMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mppf/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/mppf/chapel","forks_url":"https://api.github.com/repos/mppf/chapel/forks","keys_url":"https://api.github.com/repos/mppf/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mppf/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mppf/chapel/teams","hooks_url":"https://api.github.com/repos/mppf/chapel/hooks","issue_events_url":"https://api.github.com/repos/mppf/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/mppf/chapel/events","assignees_url":"https://api.github.com/repos/mppf/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/mppf/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/mppf/chapel/tags","blobs_url":"https://api.github.com/repos/mppf/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mppf/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mppf/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mppf/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mppf/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/mppf/chapel/languages","stargazers_url":"https://api.github.com/repos/mppf/chapel/stargazers","contributors_url":"https://api.github.com/repos/mppf/chapel/contributors","subscribers_url":"https://api.github.com/repos/mppf/chapel/subscribers","subscription_url":"https://api.github.com/repos/mppf/chapel/subscription","commits_url":"https://api.github.com/repos/mppf/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mppf/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mppf/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mppf/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mppf/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/mppf/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mppf/chapel/merges","archive_url":"https://api.github.com/repos/mppf/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mppf/chapel/downloads","issues_url":"https://api.github.com/repos/mppf/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/mppf/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/mppf/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/mppf/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mppf/chapel/labels{/name}","releases_url":"https://api.github.com/repos/mppf/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/mppf/chapel/deployments","created_at":"2014-07-22T14:05:45Z","updated_at":"2018-10-01T13:22:37Z","pushed_at":"2018-11-27T17:53:44Z","git_url":"git://github.com/mppf/chapel.git","ssh_url":"git@github.com:mppf/chapel.git","clone_url":"https://github.com/mppf/chapel.git","svn_url":"https://github.com/mppf/chapel","homepage":"http://chapel.cray.com/","size":549281,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"6252fda0af489e21b9818299ca92fd2a9869a19e","user":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2MzI4NQ==","name":"chapel","full_name":"chapel-lang/chapel","private":false,"owner":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2018-11-28T00:36:25Z","pushed_at":"2018-11-28T00:36:20Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"https://chapel-lang.org","size":554311,"stargazers_count":732,"watchers_count":732,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":1249,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":195,"open_issues":1249,"watchers":732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/11405"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/11405"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/11405/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/11405/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/a0e01b0c41da71844f16fcd241331914aed70c0f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bradcray"}}