{"action":"created","comment":{"url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/comments/185080295","pull_request_review_id":116401017,"id":185080295,"diff_hunk":"@@ -7,8 +7,10 @@ RUN mkdir /etc/service/mysql && \\\n     apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*\n \n COPY my.cnf /etc/mysql/my.cnf\n+COPY mysql.mk /usr/share/tugboat/mysql.mk","path":"mysql/Dockerfile","position":4,"original_position":4,"commit_id":"a71b40f0876620f38be51b16cb810c295eb708d9","original_commit_id":"a71b40f0876620f38be51b16cb810c295eb708d9","user":{"login":"bchavet","id":1538360,"avatar_url":"https://avatars3.githubusercontent.com/u/1538360?v=4","gravatar_id":"","url":"https://api.github.com/users/bchavet","html_url":"https://github.com/bchavet","followers_url":"https://api.github.com/users/bchavet/followers","following_url":"https://api.github.com/users/bchavet/following{/other_user}","gists_url":"https://api.github.com/users/bchavet/gists{/gist_id}","starred_url":"https://api.github.com/users/bchavet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchavet/subscriptions","organizations_url":"https://api.github.com/users/bchavet/orgs","repos_url":"https://api.github.com/users/bchavet/repos","events_url":"https://api.github.com/users/bchavet/events{/privacy}","received_events_url":"https://api.github.com/users/bchavet/received_events","type":"User","site_admin":false},"body":"If the primary MySQL service doesn't have the version you want, you could use the vanilla \"ubuntu\" image, and install the one you want.\r\n\r\nAlso, if for some strange reason your code expects MySQL to be at localhost, we should allow users to install it on the webhead, even if we think it's not a great idea.\r\n\r\nBasically, there's no harm in allowing the flexibility of having this available on all services, so there's no good reason to impose restrictions of where we think it _should_ be used.","created_at":"2018-04-30T19:10:02Z","updated_at":"2018-04-30T19:10:02Z","html_url":"https://github.com/Lullabot/tugboat-registry/pull/34#discussion_r185080295","pull_request_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/comments/185080295"},"html":{"href":"https://github.com/Lullabot/tugboat-registry/pull/34#discussion_r185080295"},"pull_request":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34"}},"in_reply_to_id":185077852},"pull_request":{"url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34","id":185009817,"html_url":"https://github.com/Lullabot/tugboat-registry/pull/34","diff_url":"https://github.com/Lullabot/tugboat-registry/pull/34.diff","patch_url":"https://github.com/Lullabot/tugboat-registry/pull/34.patch","issue_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/34","number":34,"state":"open","locked":false,"title":"Add a MySQL 5.6 image","user":{"login":"q0rban","id":66118,"avatar_url":"https://avatars3.githubusercontent.com/u/66118?v=4","gravatar_id":"","url":"https://api.github.com/users/q0rban","html_url":"https://github.com/q0rban","followers_url":"https://api.github.com/users/q0rban/followers","following_url":"https://api.github.com/users/q0rban/following{/other_user}","gists_url":"https://api.github.com/users/q0rban/gists{/gist_id}","starred_url":"https://api.github.com/users/q0rban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/q0rban/subscriptions","organizations_url":"https://api.github.com/users/q0rban/orgs","repos_url":"https://api.github.com/users/q0rban/repos","events_url":"https://api.github.com/users/q0rban/events{/privacy}","received_events_url":"https://api.github.com/users/q0rban/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-04-30T17:01:29Z","updated_at":"2018-04-30T19:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a036256fe1ef7d358947341b02f5ff377e9c5cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/34/comments","statuses_url":"https://api.github.com/repos/Lullabot/tugboat-registry/statuses/a71b40f0876620f38be51b16cb810c295eb708d9","head":{"label":"Lullabot:q0rban/mysql56","ref":"q0rban/mysql56","sha":"a71b40f0876620f38be51b16cb810c295eb708d9","user":{"login":"Lullabot","id":321267,"avatar_url":"https://avatars0.githubusercontent.com/u/321267?v=4","gravatar_id":"","url":"https://api.github.com/users/Lullabot","html_url":"https://github.com/Lullabot","followers_url":"https://api.github.com/users/Lullabot/followers","following_url":"https://api.github.com/users/Lullabot/following{/other_user}","gists_url":"https://api.github.com/users/Lullabot/gists{/gist_id}","starred_url":"https://api.github.com/users/Lullabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lullabot/subscriptions","organizations_url":"https://api.github.com/users/Lullabot/orgs","repos_url":"https://api.github.com/users/Lullabot/repos","events_url":"https://api.github.com/users/Lullabot/events{/privacy}","received_events_url":"https://api.github.com/users/Lullabot/received_events","type":"Organization","site_admin":false},"repo":{"id":48123331,"name":"tugboat-registry","full_name":"Lullabot/tugboat-registry","owner":{"login":"Lullabot","id":321267,"avatar_url":"https://avatars0.githubusercontent.com/u/321267?v=4","gravatar_id":"","url":"https://api.github.com/users/Lullabot","html_url":"https://github.com/Lullabot","followers_url":"https://api.github.com/users/Lullabot/followers","following_url":"https://api.github.com/users/Lullabot/following{/other_user}","gists_url":"https://api.github.com/users/Lullabot/gists{/gist_id}","starred_url":"https://api.github.com/users/Lullabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lullabot/subscriptions","organizations_url":"https://api.github.com/users/Lullabot/orgs","repos_url":"https://api.github.com/users/Lullabot/repos","events_url":"https://api.github.com/users/Lullabot/events{/privacy}","received_events_url":"https://api.github.com/users/Lullabot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lullabot/tugboat-registry","description":"Docker build scripts for the Tugboat registry","fork":false,"url":"https://api.github.com/repos/Lullabot/tugboat-registry","forks_url":"https://api.github.com/repos/Lullabot/tugboat-registry/forks","keys_url":"https://api.github.com/repos/Lullabot/tugboat-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lullabot/tugboat-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lullabot/tugboat-registry/teams","hooks_url":"https://api.github.com/repos/Lullabot/tugboat-registry/hooks","issue_events_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/events{/number}","events_url":"https://api.github.com/repos/Lullabot/tugboat-registry/events","assignees_url":"https://api.github.com/repos/Lullabot/tugboat-registry/assignees{/user}","branches_url":"https://api.github.com/repos/Lullabot/tugboat-registry/branches{/branch}","tags_url":"https://api.github.com/repos/Lullabot/tugboat-registry/tags","blobs_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lullabot/tugboat-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/Lullabot/tugboat-registry/languages","stargazers_url":"https://api.github.com/repos/Lullabot/tugboat-registry/stargazers","contributors_url":"https://api.github.com/repos/Lullabot/tugboat-registry/contributors","subscribers_url":"https://api.github.com/repos/Lullabot/tugboat-registry/subscribers","subscription_url":"https://api.github.com/repos/Lullabot/tugboat-registry/subscription","commits_url":"https://api.github.com/repos/Lullabot/tugboat-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lullabot/tugboat-registry/contents/{+path}","compare_url":"https://api.github.com/repos/Lullabot/tugboat-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lullabot/tugboat-registry/merges","archive_url":"https://api.github.com/repos/Lullabot/tugboat-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lullabot/tugboat-registry/downloads","issues_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues{/number}","pulls_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/Lullabot/tugboat-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/Lullabot/tugboat-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lullabot/tugboat-registry/labels{/name}","releases_url":"https://api.github.com/repos/Lullabot/tugboat-registry/releases{/id}","deployments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/deployments","created_at":"2015-12-16T16:56:00Z","updated_at":"2018-04-04T13:55:22Z","pushed_at":"2018-04-30T17:22:16Z","git_url":"git://github.com/Lullabot/tugboat-registry.git","ssh_url":"git@github.com:Lullabot/tugboat-registry.git","clone_url":"https://github.com/Lullabot/tugboat-registry.git","svn_url":"https://github.com/Lullabot/tugboat-registry","homepage":"","size":483,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"Lullabot:master","ref":"master","sha":"481052deda06b6f24fef235de3155d8f2231158d","user":{"login":"Lullabot","id":321267,"avatar_url":"https://avatars0.githubusercontent.com/u/321267?v=4","gravatar_id":"","url":"https://api.github.com/users/Lullabot","html_url":"https://github.com/Lullabot","followers_url":"https://api.github.com/users/Lullabot/followers","following_url":"https://api.github.com/users/Lullabot/following{/other_user}","gists_url":"https://api.github.com/users/Lullabot/gists{/gist_id}","starred_url":"https://api.github.com/users/Lullabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lullabot/subscriptions","organizations_url":"https://api.github.com/users/Lullabot/orgs","repos_url":"https://api.github.com/users/Lullabot/repos","events_url":"https://api.github.com/users/Lullabot/events{/privacy}","received_events_url":"https://api.github.com/users/Lullabot/received_events","type":"Organization","site_admin":false},"repo":{"id":48123331,"name":"tugboat-registry","full_name":"Lullabot/tugboat-registry","owner":{"login":"Lullabot","id":321267,"avatar_url":"https://avatars0.githubusercontent.com/u/321267?v=4","gravatar_id":"","url":"https://api.github.com/users/Lullabot","html_url":"https://github.com/Lullabot","followers_url":"https://api.github.com/users/Lullabot/followers","following_url":"https://api.github.com/users/Lullabot/following{/other_user}","gists_url":"https://api.github.com/users/Lullabot/gists{/gist_id}","starred_url":"https://api.github.com/users/Lullabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lullabot/subscriptions","organizations_url":"https://api.github.com/users/Lullabot/orgs","repos_url":"https://api.github.com/users/Lullabot/repos","events_url":"https://api.github.com/users/Lullabot/events{/privacy}","received_events_url":"https://api.github.com/users/Lullabot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lullabot/tugboat-registry","description":"Docker build scripts for the Tugboat registry","fork":false,"url":"https://api.github.com/repos/Lullabot/tugboat-registry","forks_url":"https://api.github.com/repos/Lullabot/tugboat-registry/forks","keys_url":"https://api.github.com/repos/Lullabot/tugboat-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lullabot/tugboat-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lullabot/tugboat-registry/teams","hooks_url":"https://api.github.com/repos/Lullabot/tugboat-registry/hooks","issue_events_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/events{/number}","events_url":"https://api.github.com/repos/Lullabot/tugboat-registry/events","assignees_url":"https://api.github.com/repos/Lullabot/tugboat-registry/assignees{/user}","branches_url":"https://api.github.com/repos/Lullabot/tugboat-registry/branches{/branch}","tags_url":"https://api.github.com/repos/Lullabot/tugboat-registry/tags","blobs_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lullabot/tugboat-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/Lullabot/tugboat-registry/languages","stargazers_url":"https://api.github.com/repos/Lullabot/tugboat-registry/stargazers","contributors_url":"https://api.github.com/repos/Lullabot/tugboat-registry/contributors","subscribers_url":"https://api.github.com/repos/Lullabot/tugboat-registry/subscribers","subscription_url":"https://api.github.com/repos/Lullabot/tugboat-registry/subscription","commits_url":"https://api.github.com/repos/Lullabot/tugboat-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lullabot/tugboat-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lullabot/tugboat-registry/contents/{+path}","compare_url":"https://api.github.com/repos/Lullabot/tugboat-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lullabot/tugboat-registry/merges","archive_url":"https://api.github.com/repos/Lullabot/tugboat-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lullabot/tugboat-registry/downloads","issues_url":"https://api.github.com/repos/Lullabot/tugboat-registry/issues{/number}","pulls_url":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/Lullabot/tugboat-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/Lullabot/tugboat-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lullabot/tugboat-registry/labels{/name}","releases_url":"https://api.github.com/repos/Lullabot/tugboat-registry/releases{/id}","deployments_url":"https://api.github.com/repos/Lullabot/tugboat-registry/deployments","created_at":"2015-12-16T16:56:00Z","updated_at":"2018-04-04T13:55:22Z","pushed_at":"2018-04-30T17:22:16Z","git_url":"git://github.com/Lullabot/tugboat-registry.git","ssh_url":"git@github.com:Lullabot/tugboat-registry.git","clone_url":"https://github.com/Lullabot/tugboat-registry.git","svn_url":"https://github.com/Lullabot/tugboat-registry","homepage":"","size":483,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34"},"html":{"href":"https://github.com/Lullabot/tugboat-registry/pull/34"},"issue":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/34"},"comments":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Lullabot/tugboat-registry/statuses/a71b40f0876620f38be51b16cb810c295eb708d9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bchavet"}}