{"action":"created","issue":{"url":"https://api.github.com/repos/zalando/skipper/issues/704","repository_url":"https://api.github.com/repos/zalando/skipper","labels_url":"https://api.github.com/repos/zalando/skipper/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/zalando/skipper/issues/704/comments","events_url":"https://api.github.com/repos/zalando/skipper/issues/704/events","html_url":"https://github.com/zalando/skipper/issues/704","id":339432889,"node_id":"MDU6SXNzdWUzMzk0MzI4ODk=","number":704,"title":"Consider: filter to put a specific header to the opentracing span as a tag","user":{"login":"aryszka","id":733217,"node_id":"MDQ6VXNlcjczMzIxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/733217?v=4","gravatar_id":"","url":"https://api.github.com/users/aryszka","html_url":"https://github.com/aryszka","followers_url":"https://api.github.com/users/aryszka/followers","following_url":"https://api.github.com/users/aryszka/following{/other_user}","gists_url":"https://api.github.com/users/aryszka/gists{/gist_id}","starred_url":"https://api.github.com/users/aryszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryszka/subscriptions","organizations_url":"https://api.github.com/users/aryszka/orgs","repos_url":"https://api.github.com/users/aryszka/repos","events_url":"https://api.github.com/users/aryszka/events{/privacy}","received_events_url":"https://api.github.com/users/aryszka/received_events","type":"User","site_admin":false},"labels":[{"id":234268905,"node_id":"MDU6TGFiZWwyMzQyNjg5MDU=","url":"https://api.github.com/repos/zalando/skipper/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"lmineiro","id":4234681,"node_id":"MDQ6VXNlcjQyMzQ2ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4234681?v=4","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"assignees":[{"login":"lmineiro","id":4234681,"node_id":"MDQ6VXNlcjQyMzQ2ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4234681?v=4","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-09T12:41:31Z","updated_at":"2018-07-11T10:55:50Z","closed_at":null,"author_association":"MEMBER","body":"Would it make sense to create a filter that takes a request header and puts it into the current span? E.g:\r\n\r\n```\r\nsetTracingTag(\"X-Flow-ID\", \"http.flow_id\")\r\n```\r\n\r\nwould take the value of the X-Flow-ID header if any and set it as the http.flow_id tag in the ingress span."},"comment":{"url":"https://api.github.com/repos/zalando/skipper/issues/comments/404129109","html_url":"https://github.com/zalando/skipper/issues/704#issuecomment-404129109","issue_url":"https://api.github.com/repos/zalando/skipper/issues/704","id":404129109,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDEyOTEwOQ==","user":{"login":"aryszka","id":733217,"node_id":"MDQ6VXNlcjczMzIxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/733217?v=4","gravatar_id":"","url":"https://api.github.com/users/aryszka","html_url":"https://github.com/aryszka","followers_url":"https://api.github.com/users/aryszka/followers","following_url":"https://api.github.com/users/aryszka/following{/other_user}","gists_url":"https://api.github.com/users/aryszka/gists{/gist_id}","starred_url":"https://api.github.com/users/aryszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryszka/subscriptions","organizations_url":"https://api.github.com/users/aryszka/orgs","repos_url":"https://api.github.com/users/aryszka/repos","events_url":"https://api.github.com/users/aryszka/events{/privacy}","received_events_url":"https://api.github.com/users/aryszka/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T10:55:50Z","updated_at":"2018-07-11T10:55:50Z","author_association":"MEMBER","body":"+1 for both tracing logs and the naming.\r\n\r\nthe reason for using tag in the example was that some vendors implement querying only for the tag, and thought it can be useful to find a trace starting from having a flow id only. Not sure how realistic this is."}}
{"actor":{"display_login":"aryszka"}}