{"action":"created","comment":{"url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments/222208774","pull_request_review_id":161038079,"id":222208774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjIwODc3NA==","diff_hunk":"@@ -36,7 +36,9 @@ objects:\n                     alwaysPullImage: true,\n                     workingDir: '/tmp',\n                     privileged: true,\n-                    args: '${computer.jnlpmac} ${computer.name}'\n+                    args: '${computer.jnlpmac} ${computer.name}',\n+                    resourceRequestCpu: '2',\n+                    resourceRequestMemory: '5Gi'","path":"seed-job/buildtemplate.yaml","position":7,"original_position":7,"commit_id":"df530e3427b6581dde3ab5035df54e7073f8d035","original_commit_id":"df530e3427b6581dde3ab5035df54e7073f8d035","user":{"login":"navidshaikh","id":2510184,"node_id":"MDQ6VXNlcjI1MTAxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2510184?v=4","gravatar_id":"","url":"https://api.github.com/users/navidshaikh","html_url":"https://github.com/navidshaikh","followers_url":"https://api.github.com/users/navidshaikh/followers","following_url":"https://api.github.com/users/navidshaikh/following{/other_user}","gists_url":"https://api.github.com/users/navidshaikh/gists{/gist_id}","starred_url":"https://api.github.com/users/navidshaikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navidshaikh/subscriptions","organizations_url":"https://api.github.com/users/navidshaikh/orgs","repos_url":"https://api.github.com/users/navidshaikh/repos","events_url":"https://api.github.com/users/navidshaikh/events{/privacy}","received_events_url":"https://api.github.com/users/navidshaikh/received_events","type":"User","site_admin":false},"body":"I think the requirement on memory for seed-job is on higher side ?\r\n\r\nAlso - how about using these values from parameters ?","created_at":"2018-10-03T07:30:11Z","updated_at":"2018-10-03T07:30:11Z","html_url":"https://github.com/CentOS/container-pipeline-service/pull/646#discussion_r222208774","pull_request_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments/222208774"},"html":{"href":"https://github.com/CentOS/container-pipeline-service/pull/646#discussion_r222208774"},"pull_request":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646"}}},"pull_request":{"url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646","id":219345792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzQ1Nzky","html_url":"https://github.com/CentOS/container-pipeline-service/pull/646","diff_url":"https://github.com/CentOS/container-pipeline-service/pull/646.diff","patch_url":"https://github.com/CentOS/container-pipeline-service/pull/646.patch","issue_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/646","number":646,"state":"open","locked":false,"title":"Specify resource requests in pod template","user":{"login":"dharmit","id":713521,"node_id":"MDQ6VXNlcjcxMzUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/713521?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmit","html_url":"https://github.com/dharmit","followers_url":"https://api.github.com/users/dharmit/followers","following_url":"https://api.github.com/users/dharmit/following{/other_user}","gists_url":"https://api.github.com/users/dharmit/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmit/subscriptions","organizations_url":"https://api.github.com/users/dharmit/orgs","repos_url":"https://api.github.com/users/dharmit/repos","events_url":"https://api.github.com/users/dharmit/events{/privacy}","received_events_url":"https://api.github.com/users/dharmit/received_events","type":"User","site_admin":false},"body":"This PR adds resource requests for Jenkins slave pods which will ensure that a Jenkins slave pod spins up on an OpenShift node if and only if the resources it needs are available.\r\n\r\nLong term, we can see how this behaves when a base image with numerous child images is rebuilt and the subsequent child rebuilds are handled. If it works well, we can *possibly* get away from reliance on batch processing.","created_at":"2018-10-01T11:41:40Z","updated_at":"2018-10-03T07:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2422cadc8f52751d86221b4986f1ca11720c3631","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646/commits","review_comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646/comments","review_comment_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/646/comments","statuses_url":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/df530e3427b6581dde3ab5035df54e7073f8d035","head":{"label":"dharmit:templates","ref":"templates","sha":"df530e3427b6581dde3ab5035df54e7073f8d035","user":{"login":"dharmit","id":713521,"node_id":"MDQ6VXNlcjcxMzUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/713521?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmit","html_url":"https://github.com/dharmit","followers_url":"https://api.github.com/users/dharmit/followers","following_url":"https://api.github.com/users/dharmit/following{/other_user}","gists_url":"https://api.github.com/users/dharmit/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmit/subscriptions","organizations_url":"https://api.github.com/users/dharmit/orgs","repos_url":"https://api.github.com/users/dharmit/repos","events_url":"https://api.github.com/users/dharmit/events{/privacy}","received_events_url":"https://api.github.com/users/dharmit/received_events","type":"User","site_admin":false},"repo":{"id":63308960,"node_id":"MDEwOlJlcG9zaXRvcnk2MzMwODk2MA==","name":"container-pipeline-service","full_name":"dharmit/container-pipeline-service","private":false,"owner":{"login":"dharmit","id":713521,"node_id":"MDQ6VXNlcjcxMzUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/713521?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmit","html_url":"https://github.com/dharmit","followers_url":"https://api.github.com/users/dharmit/followers","following_url":"https://api.github.com/users/dharmit/following{/other_user}","gists_url":"https://api.github.com/users/dharmit/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmit/subscriptions","organizations_url":"https://api.github.com/users/dharmit/orgs","repos_url":"https://api.github.com/users/dharmit/repos","events_url":"https://api.github.com/users/dharmit/events{/privacy}","received_events_url":"https://api.github.com/users/dharmit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dharmit/container-pipeline-service","description":"Code, infrastructure and deployment backend for the CentOS Container Pipeline","fork":true,"url":"https://api.github.com/repos/dharmit/container-pipeline-service","forks_url":"https://api.github.com/repos/dharmit/container-pipeline-service/forks","keys_url":"https://api.github.com/repos/dharmit/container-pipeline-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dharmit/container-pipeline-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dharmit/container-pipeline-service/teams","hooks_url":"https://api.github.com/repos/dharmit/container-pipeline-service/hooks","issue_events_url":"https://api.github.com/repos/dharmit/container-pipeline-service/issues/events{/number}","events_url":"https://api.github.com/repos/dharmit/container-pipeline-service/events","assignees_url":"https://api.github.com/repos/dharmit/container-pipeline-service/assignees{/user}","branches_url":"https://api.github.com/repos/dharmit/container-pipeline-service/branches{/branch}","tags_url":"https://api.github.com/repos/dharmit/container-pipeline-service/tags","blobs_url":"https://api.github.com/repos/dharmit/container-pipeline-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dharmit/container-pipeline-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dharmit/container-pipeline-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/dharmit/container-pipeline-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dharmit/container-pipeline-service/statuses/{sha}","languages_url":"https://api.github.com/repos/dharmit/container-pipeline-service/languages","stargazers_url":"https://api.github.com/repos/dharmit/container-pipeline-service/stargazers","contributors_url":"https://api.github.com/repos/dharmit/container-pipeline-service/contributors","subscribers_url":"https://api.github.com/repos/dharmit/container-pipeline-service/subscribers","subscription_url":"https://api.github.com/repos/dharmit/container-pipeline-service/subscription","commits_url":"https://api.github.com/repos/dharmit/container-pipeline-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/dharmit/container-pipeline-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/dharmit/container-pipeline-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/dharmit/container-pipeline-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/dharmit/container-pipeline-service/contents/{+path}","compare_url":"https://api.github.com/repos/dharmit/container-pipeline-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dharmit/container-pipeline-service/merges","archive_url":"https://api.github.com/repos/dharmit/container-pipeline-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dharmit/container-pipeline-service/downloads","issues_url":"https://api.github.com/repos/dharmit/container-pipeline-service/issues{/number}","pulls_url":"https://api.github.com/repos/dharmit/container-pipeline-service/pulls{/number}","milestones_url":"https://api.github.com/repos/dharmit/container-pipeline-service/milestones{/number}","notifications_url":"https://api.github.com/repos/dharmit/container-pipeline-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dharmit/container-pipeline-service/labels{/name}","releases_url":"https://api.github.com/repos/dharmit/container-pipeline-service/releases{/id}","deployments_url":"https://api.github.com/repos/dharmit/container-pipeline-service/deployments","created_at":"2016-07-14T06:33:26Z","updated_at":"2018-04-27T04:19:21Z","pushed_at":"2018-10-01T10:07:53Z","git_url":"git://github.com/dharmit/container-pipeline-service.git","ssh_url":"git@github.com:dharmit/container-pipeline-service.git","clone_url":"https://github.com/dharmit/container-pipeline-service.git","svn_url":"https://github.com/dharmit/container-pipeline-service","homepage":null,"size":2438,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CentOS:openshift","ref":"openshift","sha":"75e57677abf9fc3a5d32d80e4431f82f7f0f9cb0","user":{"login":"CentOS","id":79192,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTky","avatar_url":"https://avatars0.githubusercontent.com/u/79192?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS","html_url":"https://github.com/CentOS","followers_url":"https://api.github.com/users/CentOS/followers","following_url":"https://api.github.com/users/CentOS/following{/other_user}","gists_url":"https://api.github.com/users/CentOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS/subscriptions","organizations_url":"https://api.github.com/users/CentOS/orgs","repos_url":"https://api.github.com/users/CentOS/repos","events_url":"https://api.github.com/users/CentOS/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS/received_events","type":"Organization","site_admin":false},"repo":{"id":63242015,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI0MjAxNQ==","name":"container-pipeline-service","full_name":"CentOS/container-pipeline-service","private":false,"owner":{"login":"CentOS","id":79192,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTky","avatar_url":"https://avatars0.githubusercontent.com/u/79192?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS","html_url":"https://github.com/CentOS","followers_url":"https://api.github.com/users/CentOS/followers","following_url":"https://api.github.com/users/CentOS/following{/other_user}","gists_url":"https://api.github.com/users/CentOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS/subscriptions","organizations_url":"https://api.github.com/users/CentOS/orgs","repos_url":"https://api.github.com/users/CentOS/repos","events_url":"https://api.github.com/users/CentOS/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CentOS/container-pipeline-service","description":"Code, infrastructure and deployment backend for the CentOS Container Pipeline","fork":false,"url":"https://api.github.com/repos/CentOS/container-pipeline-service","forks_url":"https://api.github.com/repos/CentOS/container-pipeline-service/forks","keys_url":"https://api.github.com/repos/CentOS/container-pipeline-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CentOS/container-pipeline-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CentOS/container-pipeline-service/teams","hooks_url":"https://api.github.com/repos/CentOS/container-pipeline-service/hooks","issue_events_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/events{/number}","events_url":"https://api.github.com/repos/CentOS/container-pipeline-service/events","assignees_url":"https://api.github.com/repos/CentOS/container-pipeline-service/assignees{/user}","branches_url":"https://api.github.com/repos/CentOS/container-pipeline-service/branches{/branch}","tags_url":"https://api.github.com/repos/CentOS/container-pipeline-service/tags","blobs_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/{sha}","languages_url":"https://api.github.com/repos/CentOS/container-pipeline-service/languages","stargazers_url":"https://api.github.com/repos/CentOS/container-pipeline-service/stargazers","contributors_url":"https://api.github.com/repos/CentOS/container-pipeline-service/contributors","subscribers_url":"https://api.github.com/repos/CentOS/container-pipeline-service/subscribers","subscription_url":"https://api.github.com/repos/CentOS/container-pipeline-service/subscription","commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/CentOS/container-pipeline-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/CentOS/container-pipeline-service/contents/{+path}","compare_url":"https://api.github.com/repos/CentOS/container-pipeline-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CentOS/container-pipeline-service/merges","archive_url":"https://api.github.com/repos/CentOS/container-pipeline-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CentOS/container-pipeline-service/downloads","issues_url":"https://api.github.com/repos/CentOS/container-pipeline-service/issues{/number}","pulls_url":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls{/number}","milestones_url":"https://api.github.com/repos/CentOS/container-pipeline-service/milestones{/number}","notifications_url":"https://api.github.com/repos/CentOS/container-pipeline-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CentOS/container-pipeline-service/labels{/name}","releases_url":"https://api.github.com/repos/CentOS/container-pipeline-service/releases{/id}","deployments_url":"https://api.github.com/repos/CentOS/container-pipeline-service/deployments","created_at":"2016-07-13T11:55:19Z","updated_at":"2018-09-27T14:17:47Z","pushed_at":"2018-10-03T06:44:10Z","git_url":"git://github.com/CentOS/container-pipeline-service.git","ssh_url":"git@github.com:CentOS/container-pipeline-service.git","clone_url":"https://github.com/CentOS/container-pipeline-service.git","svn_url":"https://github.com/CentOS/container-pipeline-service","homepage":null,"size":2434,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":93,"license":null,"forks":19,"open_issues":93,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646"},"html":{"href":"https://github.com/CentOS/container-pipeline-service/pull/646"},"issue":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/646"},"comments":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/CentOS/container-pipeline-service/statuses/df530e3427b6581dde3ab5035df54e7073f8d035"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"navidshaikh"}}