{"action":"created","comment":{"url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/comments/189815400","pull_request_review_id":122064829,"id":189815400,"diff_hunk":"@@ -129,4 +129,20 @@ describe(\"QMLEngine.properties\", function() {\n       QmlWeb.engine.$basePath + \"remoteBinding.png\");\n     expect(qml.remoteSet).toBe(QmlWeb.engine.$basePath + \"remoteSet.png\");\n   });\n+\n+  it(\"Property and signal can have the same names\", function() {\n+    var qml = load(\"AndSignalsWithTheSameNames\", this.div);\n+    //expect(qml.pressed).toBe(false);","path":"tests/QMLEngine/properties.js","position":7,"original_position":7,"commit_id":"4f91382686cb0ef3b94655516f92ed7dd564530b","original_commit_id":"4f91382686cb0ef3b94655516f92ed7dd564530b","user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars2.githubusercontent.com/u/291301?v=4","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"body":"Why is this comment needed?","created_at":"2018-05-22T08:28:02Z","updated_at":"2018-05-22T08:28:02Z","html_url":"https://github.com/qmlweb/qmlweb/pull/440#discussion_r189815400","pull_request_url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/comments/189815400"},"html":{"href":"https://github.com/qmlweb/qmlweb/pull/440#discussion_r189815400"},"pull_request":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440","id":189537434,"html_url":"https://github.com/qmlweb/qmlweb/pull/440","diff_url":"https://github.com/qmlweb/qmlweb/pull/440.diff","patch_url":"https://github.com/qmlweb/qmlweb/pull/440.patch","issue_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/440","number":440,"state":"open","locked":false,"title":"Properties and signals naming conflicts","user":{"login":"bessorion","id":26327038,"avatar_url":"https://avatars3.githubusercontent.com/u/26327038?v=4","gravatar_id":"","url":"https://api.github.com/users/bessorion","html_url":"https://github.com/bessorion","followers_url":"https://api.github.com/users/bessorion/followers","following_url":"https://api.github.com/users/bessorion/following{/other_user}","gists_url":"https://api.github.com/users/bessorion/gists{/gist_id}","starred_url":"https://api.github.com/users/bessorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bessorion/subscriptions","organizations_url":"https://api.github.com/users/bessorion/orgs","repos_url":"https://api.github.com/users/bessorion/repos","events_url":"https://api.github.com/users/bessorion/events{/privacy}","received_events_url":"https://api.github.com/users/bessorion/received_events","type":"User","site_admin":false},"body":"Added failingTests to show naming conflicts between properties and signals. \r\nQML allows such behavior. Without this feature we cannot fully implement MouseArea QML type (and maybe some more items) which contains both property and signal with \"pressed\" names.\r\nhttp://doc.qt.io/qt-5/qml-qtquick-mousearea.html","created_at":"2018-05-22T03:14:47Z","updated_at":"2018-05-22T08:28:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9873b0059907ef2aace5d040a4a0de5f6d3477a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440/commits","review_comments_url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440/comments","review_comment_url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/440/comments","statuses_url":"https://api.github.com/repos/qmlweb/qmlweb/statuses/4f91382686cb0ef3b94655516f92ed7dd564530b","head":{"label":"bessorion:properties-and-signals-naming-conflicts","ref":"properties-and-signals-naming-conflicts","sha":"4f91382686cb0ef3b94655516f92ed7dd564530b","user":{"login":"bessorion","id":26327038,"avatar_url":"https://avatars3.githubusercontent.com/u/26327038?v=4","gravatar_id":"","url":"https://api.github.com/users/bessorion","html_url":"https://github.com/bessorion","followers_url":"https://api.github.com/users/bessorion/followers","following_url":"https://api.github.com/users/bessorion/following{/other_user}","gists_url":"https://api.github.com/users/bessorion/gists{/gist_id}","starred_url":"https://api.github.com/users/bessorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bessorion/subscriptions","organizations_url":"https://api.github.com/users/bessorion/orgs","repos_url":"https://api.github.com/users/bessorion/repos","events_url":"https://api.github.com/users/bessorion/events{/privacy}","received_events_url":"https://api.github.com/users/bessorion/received_events","type":"User","site_admin":false},"repo":{"id":133276916,"name":"qmlweb","full_name":"bessorion/qmlweb","owner":{"login":"bessorion","id":26327038,"avatar_url":"https://avatars3.githubusercontent.com/u/26327038?v=4","gravatar_id":"","url":"https://api.github.com/users/bessorion","html_url":"https://github.com/bessorion","followers_url":"https://api.github.com/users/bessorion/followers","following_url":"https://api.github.com/users/bessorion/following{/other_user}","gists_url":"https://api.github.com/users/bessorion/gists{/gist_id}","starred_url":"https://api.github.com/users/bessorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bessorion/subscriptions","organizations_url":"https://api.github.com/users/bessorion/orgs","repos_url":"https://api.github.com/users/bessorion/repos","events_url":"https://api.github.com/users/bessorion/events{/privacy}","received_events_url":"https://api.github.com/users/bessorion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bessorion/qmlweb","description":"A QML engine in a web browser. Current state: fixing things…","fork":true,"url":"https://api.github.com/repos/bessorion/qmlweb","forks_url":"https://api.github.com/repos/bessorion/qmlweb/forks","keys_url":"https://api.github.com/repos/bessorion/qmlweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bessorion/qmlweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bessorion/qmlweb/teams","hooks_url":"https://api.github.com/repos/bessorion/qmlweb/hooks","issue_events_url":"https://api.github.com/repos/bessorion/qmlweb/issues/events{/number}","events_url":"https://api.github.com/repos/bessorion/qmlweb/events","assignees_url":"https://api.github.com/repos/bessorion/qmlweb/assignees{/user}","branches_url":"https://api.github.com/repos/bessorion/qmlweb/branches{/branch}","tags_url":"https://api.github.com/repos/bessorion/qmlweb/tags","blobs_url":"https://api.github.com/repos/bessorion/qmlweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bessorion/qmlweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bessorion/qmlweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bessorion/qmlweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bessorion/qmlweb/statuses/{sha}","languages_url":"https://api.github.com/repos/bessorion/qmlweb/languages","stargazers_url":"https://api.github.com/repos/bessorion/qmlweb/stargazers","contributors_url":"https://api.github.com/repos/bessorion/qmlweb/contributors","subscribers_url":"https://api.github.com/repos/bessorion/qmlweb/subscribers","subscription_url":"https://api.github.com/repos/bessorion/qmlweb/subscription","commits_url":"https://api.github.com/repos/bessorion/qmlweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bessorion/qmlweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bessorion/qmlweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bessorion/qmlweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bessorion/qmlweb/contents/{+path}","compare_url":"https://api.github.com/repos/bessorion/qmlweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bessorion/qmlweb/merges","archive_url":"https://api.github.com/repos/bessorion/qmlweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bessorion/qmlweb/downloads","issues_url":"https://api.github.com/repos/bessorion/qmlweb/issues{/number}","pulls_url":"https://api.github.com/repos/bessorion/qmlweb/pulls{/number}","milestones_url":"https://api.github.com/repos/bessorion/qmlweb/milestones{/number}","notifications_url":"https://api.github.com/repos/bessorion/qmlweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bessorion/qmlweb/labels{/name}","releases_url":"https://api.github.com/repos/bessorion/qmlweb/releases{/id}","deployments_url":"https://api.github.com/repos/bessorion/qmlweb/deployments","created_at":"2018-05-13T21:48:55Z","updated_at":"2018-05-22T02:55:02Z","pushed_at":"2018-05-22T03:03:31Z","git_url":"git://github.com/bessorion/qmlweb.git","ssh_url":"git@github.com:bessorion/qmlweb.git","clone_url":"https://github.com/bessorion/qmlweb.git","svn_url":"https://github.com/bessorion/qmlweb","homepage":"https://qmlweb.github.io/","size":5431,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qmlweb:master","ref":"master","sha":"012321c9d7aebf3baa57dda1920ad1129870759f","user":{"login":"qmlweb","id":17229645,"avatar_url":"https://avatars0.githubusercontent.com/u/17229645?v=4","gravatar_id":"","url":"https://api.github.com/users/qmlweb","html_url":"https://github.com/qmlweb","followers_url":"https://api.github.com/users/qmlweb/followers","following_url":"https://api.github.com/users/qmlweb/following{/other_user}","gists_url":"https://api.github.com/users/qmlweb/gists{/gist_id}","starred_url":"https://api.github.com/users/qmlweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmlweb/subscriptions","organizations_url":"https://api.github.com/users/qmlweb/orgs","repos_url":"https://api.github.com/users/qmlweb/repos","events_url":"https://api.github.com/users/qmlweb/events{/privacy}","received_events_url":"https://api.github.com/users/qmlweb/received_events","type":"Organization","site_admin":false},"repo":{"id":51682254,"name":"qmlweb","full_name":"qmlweb/qmlweb","owner":{"login":"qmlweb","id":17229645,"avatar_url":"https://avatars0.githubusercontent.com/u/17229645?v=4","gravatar_id":"","url":"https://api.github.com/users/qmlweb","html_url":"https://github.com/qmlweb","followers_url":"https://api.github.com/users/qmlweb/followers","following_url":"https://api.github.com/users/qmlweb/following{/other_user}","gists_url":"https://api.github.com/users/qmlweb/gists{/gist_id}","starred_url":"https://api.github.com/users/qmlweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmlweb/subscriptions","organizations_url":"https://api.github.com/users/qmlweb/orgs","repos_url":"https://api.github.com/users/qmlweb/repos","events_url":"https://api.github.com/users/qmlweb/events{/privacy}","received_events_url":"https://api.github.com/users/qmlweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qmlweb/qmlweb","description":"A QML engine in a web browser. Current state: fixing things…","fork":false,"url":"https://api.github.com/repos/qmlweb/qmlweb","forks_url":"https://api.github.com/repos/qmlweb/qmlweb/forks","keys_url":"https://api.github.com/repos/qmlweb/qmlweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmlweb/qmlweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmlweb/qmlweb/teams","hooks_url":"https://api.github.com/repos/qmlweb/qmlweb/hooks","issue_events_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/events{/number}","events_url":"https://api.github.com/repos/qmlweb/qmlweb/events","assignees_url":"https://api.github.com/repos/qmlweb/qmlweb/assignees{/user}","branches_url":"https://api.github.com/repos/qmlweb/qmlweb/branches{/branch}","tags_url":"https://api.github.com/repos/qmlweb/qmlweb/tags","blobs_url":"https://api.github.com/repos/qmlweb/qmlweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmlweb/qmlweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmlweb/qmlweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmlweb/qmlweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmlweb/qmlweb/statuses/{sha}","languages_url":"https://api.github.com/repos/qmlweb/qmlweb/languages","stargazers_url":"https://api.github.com/repos/qmlweb/qmlweb/stargazers","contributors_url":"https://api.github.com/repos/qmlweb/qmlweb/contributors","subscribers_url":"https://api.github.com/repos/qmlweb/qmlweb/subscribers","subscription_url":"https://api.github.com/repos/qmlweb/qmlweb/subscription","commits_url":"https://api.github.com/repos/qmlweb/qmlweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmlweb/qmlweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmlweb/qmlweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmlweb/qmlweb/contents/{+path}","compare_url":"https://api.github.com/repos/qmlweb/qmlweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmlweb/qmlweb/merges","archive_url":"https://api.github.com/repos/qmlweb/qmlweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmlweb/qmlweb/downloads","issues_url":"https://api.github.com/repos/qmlweb/qmlweb/issues{/number}","pulls_url":"https://api.github.com/repos/qmlweb/qmlweb/pulls{/number}","milestones_url":"https://api.github.com/repos/qmlweb/qmlweb/milestones{/number}","notifications_url":"https://api.github.com/repos/qmlweb/qmlweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmlweb/qmlweb/labels{/name}","releases_url":"https://api.github.com/repos/qmlweb/qmlweb/releases{/id}","deployments_url":"https://api.github.com/repos/qmlweb/qmlweb/deployments","created_at":"2016-02-14T06:06:03Z","updated_at":"2018-05-21T21:06:39Z","pushed_at":"2018-05-22T03:14:48Z","git_url":"git://github.com/qmlweb/qmlweb.git","ssh_url":"git@github.com:qmlweb/qmlweb.git","clone_url":"https://github.com/qmlweb/qmlweb.git","svn_url":"https://github.com/qmlweb/qmlweb","homepage":"https://qmlweb.github.io/","size":5428,"stargazers_count":507,"watchers_count":507,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":63,"open_issues":78,"watchers":507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440"},"html":{"href":"https://github.com/qmlweb/qmlweb/pull/440"},"issue":{"href":"https://api.github.com/repos/qmlweb/qmlweb/issues/440"},"comments":{"href":"https://api.github.com/repos/qmlweb/qmlweb/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmlweb/qmlweb/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/qmlweb/qmlweb/statuses/4f91382686cb0ef3b94655516f92ed7dd564530b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChALkeR"}}