{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/4989","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/4989/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/4989/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/4989/events","html_url":"https://github.com/GoogleChrome/lighthouse/pull/4989","id":315561412,"number":4989,"title":"core(estimated-input-latency): use a 5s rolling window","user":{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars2.githubusercontent.com/u/2301202?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false},"labels":[{"id":895902837,"url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels/I/O-Expedite","name":"I/O-Expedite","color":"bdf47a","default":false},{"id":721845343,"url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels/waiting4reviewer","name":"waiting4reviewer","color":"5e1596","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-18T16:52:51Z","updated_at":"2018-04-20T15:26:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/4989","html_url":"https://github.com/GoogleChrome/lighthouse/pull/4989","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/4989.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/4989.patch"},"body":"chose a 5s window because that's what TTI uses and it gave the right \"feel\" on several test sites, CNN gets ~1s and is punished harshly, pwa.rocks gets ~17ms, 1s was a bit too small and harsh 10s is forgiving of 1s long tasks which is just too lenient"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/383132434","html_url":"https://github.com/GoogleChrome/lighthouse/pull/4989#issuecomment-383132434","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/4989","id":383132434,"user":{"login":"patrickhulce","id":2301202,"avatar_url":"https://avatars2.githubusercontent.com/u/2301202?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickhulce","html_url":"https://github.com/patrickhulce","followers_url":"https://api.github.com/users/patrickhulce/followers","following_url":"https://api.github.com/users/patrickhulce/following{/other_user}","gists_url":"https://api.github.com/users/patrickhulce/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhulce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhulce/subscriptions","organizations_url":"https://api.github.com/users/patrickhulce/orgs","repos_url":"https://api.github.com/users/patrickhulce/repos","events_url":"https://api.github.com/users/patrickhulce/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhulce/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T15:26:32Z","updated_at":"2018-04-20T15:26:32Z","author_association":"MEMBER","body":"> if we're only concerned with speed there are easier ways of making this faster than sprinkling filters everywhere :P\r\n\r\nSpeed is a major concern right now. In the unit test which has 20s of CPU time split between 1000 start times and 10000 small tasks it takes ~40-50ms. Of the 200ms for CNN 180 of those are spent in trace-of-tab, not here. We're not filtering because we absolutely have to, it's more why do useless work. I don't really care either way. 1ms and 10ms don't seem to hurt anything speed-wise or have any meaningful impact accuracy-wise."}}
{"actor":{"display_login":"patrickhulce"}}