{"action":"created","issue":{"url":"https://api.github.com/repos/octobox/octobox/issues/575","repository_url":"https://api.github.com/repos/octobox/octobox","labels_url":"https://api.github.com/repos/octobox/octobox/issues/575/labels{/name}","comments_url":"https://api.github.com/repos/octobox/octobox/issues/575/comments","events_url":"https://api.github.com/repos/octobox/octobox/issues/575/events","html_url":"https://github.com/octobox/octobox/pull/575","id":308674346,"number":575,"title":"Store and use github_id on labels","user":{"login":"andrew","id":1060,"avatar_url":"https://avatars2.githubusercontent.com/u/1060?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-26T17:56:21Z","updated_at":"2018-03-27T10:29:18Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/octobox/octobox/pulls/575","html_url":"https://github.com/octobox/octobox/pull/575","diff_url":"https://github.com/octobox/octobox/pull/575.diff","patch_url":"https://github.com/octobox/octobox/pull/575.patch"},"body":"WIP fixes #561\r\n\r\nAs mentioned in https://github.com/octobox/octobox/issues/561#issuecomment-376222137, this separates the remote id from github and the local id.\r\n\r\nThe main thing I've not tested here is the migration path for users who've been running the existing (broken) label support, I think we'll need to either:\r\n\r\n- also look up labels by name+colour to make sure we don't get dupes (may require extra indexes)\r\n- just delete all existing labels during the database migration to add the github_id column, that way everyone just redownloads all labels on subjects next time the subject changes.\r\n\r\nEither way we might want a rake task that will update the labels on all subjects for a smooth upgrade path for people who've ran into issues."},"comment":{"url":"https://api.github.com/repos/octobox/octobox/issues/comments/376476284","html_url":"https://github.com/octobox/octobox/pull/575#issuecomment-376476284","issue_url":"https://api.github.com/repos/octobox/octobox/issues/575","id":376476284,"user":{"login":"andrew","id":1060,"avatar_url":"https://avatars2.githubusercontent.com/u/1060?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T10:29:18Z","updated_at":"2018-03-27T10:29:18Z","author_association":"OWNER","body":"@rhuss thanks for checking it out, I've added a line to the migration that will delete any existing labels which should avoid getting any duplicates for anyone who's been running master for the past week. \r\n\r\nI also added a little speed up when loading labels in the UI 💯 "}}
{"actor":{"display_login":"andrew"}}