{"action":"created","comment":{"url":"https://api.github.com/repos/apple/turicreate/pulls/comments/211059239","pull_request_review_id":147413394,"id":211059239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA1OTIzOQ==","diff_hunk":"@@ -42,6 +41,12 @@ else()\n   message(\"Skipping python libraries.\")\n endif()\n \n+if(NOT APPLE)","path":"CMakeLists.txt","position":11,"original_position":11,"commit_id":"a1920616f485a7fbe1b12eb5b2926f727f5031a3","original_commit_id":"a1920616f485a7fbe1b12eb5b2926f727f5031a3","user":{"login":"TobyRoseman","id":5420744,"node_id":"MDQ6VXNlcjU0MjA3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5420744?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyRoseman","html_url":"https://github.com/TobyRoseman","followers_url":"https://api.github.com/users/TobyRoseman/followers","following_url":"https://api.github.com/users/TobyRoseman/following{/other_user}","gists_url":"https://api.github.com/users/TobyRoseman/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyRoseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyRoseman/subscriptions","organizations_url":"https://api.github.com/users/TobyRoseman/orgs","repos_url":"https://api.github.com/users/TobyRoseman/repos","events_url":"https://api.github.com/users/TobyRoseman/events{/privacy}","received_events_url":"https://api.github.com/users/TobyRoseman/received_events","type":"User","site_admin":false},"body":"Yes, I believe so. It seems we never use BLAS or LAPACK directly. It's just a dependency of armadillo. [It looks like](https://github.com/apple/turicreate/blob/master/src/external/armadillo/CMakeLists.txt#L162) on macOS armadillo uses the Accelerate Framework instead of the BLAS and LAPACK.\r\n\r\n@hoytak or @srikris - can you confirm?","created_at":"2018-08-18T00:47:48Z","updated_at":"2018-08-18T00:47:48Z","html_url":"https://github.com/apple/turicreate/pull/1001#discussion_r211059239","pull_request_url":"https://api.github.com/repos/apple/turicreate/pulls/1001","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments/211059239"},"html":{"href":"https://github.com/apple/turicreate/pull/1001#discussion_r211059239"},"pull_request":{"href":"https://api.github.com/repos/apple/turicreate/pulls/1001"}},"in_reply_to_id":211058397},"pull_request":{"url":"https://api.github.com/repos/apple/turicreate/pulls/1001","id":209265189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjY1MTg5","html_url":"https://github.com/apple/turicreate/pull/1001","diff_url":"https://github.com/apple/turicreate/pull/1001.diff","patch_url":"https://github.com/apple/turicreate/pull/1001.patch","issue_url":"https://api.github.com/repos/apple/turicreate/issues/1001","number":1001,"state":"open","locked":false,"title":"Build should error out if no lapack","user":{"login":"TobyRoseman","id":5420744,"node_id":"MDQ6VXNlcjU0MjA3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5420744?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyRoseman","html_url":"https://github.com/TobyRoseman","followers_url":"https://api.github.com/users/TobyRoseman/followers","following_url":"https://api.github.com/users/TobyRoseman/following{/other_user}","gists_url":"https://api.github.com/users/TobyRoseman/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyRoseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyRoseman/subscriptions","organizations_url":"https://api.github.com/users/TobyRoseman/orgs","repos_url":"https://api.github.com/users/TobyRoseman/repos","events_url":"https://api.github.com/users/TobyRoseman/events{/privacy}","received_events_url":"https://api.github.com/users/TobyRoseman/received_events","type":"User","site_admin":false},"body":"fixes #175 ","created_at":"2018-08-17T21:47:35Z","updated_at":"2018-08-18T00:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ebfcfdb16b8a30609557c053f211498981c6dba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hoytak","id":56061,"node_id":"MDQ6VXNlcjU2MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/56061?v=4","gravatar_id":"","url":"https://api.github.com/users/hoytak","html_url":"https://github.com/hoytak","followers_url":"https://api.github.com/users/hoytak/followers","following_url":"https://api.github.com/users/hoytak/following{/other_user}","gists_url":"https://api.github.com/users/hoytak/gists{/gist_id}","starred_url":"https://api.github.com/users/hoytak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoytak/subscriptions","organizations_url":"https://api.github.com/users/hoytak/orgs","repos_url":"https://api.github.com/users/hoytak/repos","events_url":"https://api.github.com/users/hoytak/events{/privacy}","received_events_url":"https://api.github.com/users/hoytak/received_events","type":"User","site_admin":false},{"login":"srikris","id":1875987,"node_id":"MDQ6VXNlcjE4NzU5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1875987?v=4","gravatar_id":"","url":"https://api.github.com/users/srikris","html_url":"https://github.com/srikris","followers_url":"https://api.github.com/users/srikris/followers","following_url":"https://api.github.com/users/srikris/following{/other_user}","gists_url":"https://api.github.com/users/srikris/gists{/gist_id}","starred_url":"https://api.github.com/users/srikris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srikris/subscriptions","organizations_url":"https://api.github.com/users/srikris/orgs","repos_url":"https://api.github.com/users/srikris/repos","events_url":"https://api.github.com/users/srikris/events{/privacy}","received_events_url":"https://api.github.com/users/srikris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/turicreate/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/apple/turicreate/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/turicreate/issues/1001/comments","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/a1920616f485a7fbe1b12eb5b2926f727f5031a3","head":{"label":"TobyRoseman:error-if-no-lapack","ref":"error-if-no-lapack","sha":"a1920616f485a7fbe1b12eb5b2926f727f5031a3","user":{"login":"TobyRoseman","id":5420744,"node_id":"MDQ6VXNlcjU0MjA3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5420744?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyRoseman","html_url":"https://github.com/TobyRoseman","followers_url":"https://api.github.com/users/TobyRoseman/followers","following_url":"https://api.github.com/users/TobyRoseman/following{/other_user}","gists_url":"https://api.github.com/users/TobyRoseman/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyRoseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyRoseman/subscriptions","organizations_url":"https://api.github.com/users/TobyRoseman/orgs","repos_url":"https://api.github.com/users/TobyRoseman/repos","events_url":"https://api.github.com/users/TobyRoseman/events{/privacy}","received_events_url":"https://api.github.com/users/TobyRoseman/received_events","type":"User","site_admin":false},"repo":{"id":113904132,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5MDQxMzI=","name":"turicreate","full_name":"TobyRoseman/turicreate","owner":{"login":"TobyRoseman","id":5420744,"node_id":"MDQ6VXNlcjU0MjA3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5420744?v=4","gravatar_id":"","url":"https://api.github.com/users/TobyRoseman","html_url":"https://github.com/TobyRoseman","followers_url":"https://api.github.com/users/TobyRoseman/followers","following_url":"https://api.github.com/users/TobyRoseman/following{/other_user}","gists_url":"https://api.github.com/users/TobyRoseman/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyRoseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyRoseman/subscriptions","organizations_url":"https://api.github.com/users/TobyRoseman/orgs","repos_url":"https://api.github.com/users/TobyRoseman/repos","events_url":"https://api.github.com/users/TobyRoseman/events{/privacy}","received_events_url":"https://api.github.com/users/TobyRoseman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TobyRoseman/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":true,"url":"https://api.github.com/repos/TobyRoseman/turicreate","forks_url":"https://api.github.com/repos/TobyRoseman/turicreate/forks","keys_url":"https://api.github.com/repos/TobyRoseman/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TobyRoseman/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TobyRoseman/turicreate/teams","hooks_url":"https://api.github.com/repos/TobyRoseman/turicreate/hooks","issue_events_url":"https://api.github.com/repos/TobyRoseman/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/TobyRoseman/turicreate/events","assignees_url":"https://api.github.com/repos/TobyRoseman/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/TobyRoseman/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/TobyRoseman/turicreate/tags","blobs_url":"https://api.github.com/repos/TobyRoseman/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TobyRoseman/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TobyRoseman/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/TobyRoseman/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TobyRoseman/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/TobyRoseman/turicreate/languages","stargazers_url":"https://api.github.com/repos/TobyRoseman/turicreate/stargazers","contributors_url":"https://api.github.com/repos/TobyRoseman/turicreate/contributors","subscribers_url":"https://api.github.com/repos/TobyRoseman/turicreate/subscribers","subscription_url":"https://api.github.com/repos/TobyRoseman/turicreate/subscription","commits_url":"https://api.github.com/repos/TobyRoseman/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/TobyRoseman/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/TobyRoseman/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/TobyRoseman/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/TobyRoseman/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/TobyRoseman/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TobyRoseman/turicreate/merges","archive_url":"https://api.github.com/repos/TobyRoseman/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TobyRoseman/turicreate/downloads","issues_url":"https://api.github.com/repos/TobyRoseman/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/TobyRoseman/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/TobyRoseman/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/TobyRoseman/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TobyRoseman/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/TobyRoseman/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/TobyRoseman/turicreate/deployments","created_at":"2017-12-11T20:16:51Z","updated_at":"2018-08-17T22:08:41Z","pushed_at":"2018-08-17T23:35:20Z","git_url":"git://github.com/TobyRoseman/turicreate.git","ssh_url":"git@github.com:TobyRoseman/turicreate.git","clone_url":"https://github.com/TobyRoseman/turicreate.git","svn_url":"https://github.com/TobyRoseman/turicreate","homepage":"","size":122907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e5489eeeb6e70980cb1e0bd0da9d08b1caafbffe","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":112676803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NzY4MDM=","name":"turicreate","full_name":"apple/turicreate","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/turicreate","description":"Turi Create simplifies the development of custom machine learning models.","fork":false,"url":"https://api.github.com/repos/apple/turicreate","forks_url":"https://api.github.com/repos/apple/turicreate/forks","keys_url":"https://api.github.com/repos/apple/turicreate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/turicreate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/turicreate/teams","hooks_url":"https://api.github.com/repos/apple/turicreate/hooks","issue_events_url":"https://api.github.com/repos/apple/turicreate/issues/events{/number}","events_url":"https://api.github.com/repos/apple/turicreate/events","assignees_url":"https://api.github.com/repos/apple/turicreate/assignees{/user}","branches_url":"https://api.github.com/repos/apple/turicreate/branches{/branch}","tags_url":"https://api.github.com/repos/apple/turicreate/tags","blobs_url":"https://api.github.com/repos/apple/turicreate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/turicreate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/turicreate/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/turicreate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/turicreate/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/turicreate/languages","stargazers_url":"https://api.github.com/repos/apple/turicreate/stargazers","contributors_url":"https://api.github.com/repos/apple/turicreate/contributors","subscribers_url":"https://api.github.com/repos/apple/turicreate/subscribers","subscription_url":"https://api.github.com/repos/apple/turicreate/subscription","commits_url":"https://api.github.com/repos/apple/turicreate/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/turicreate/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/turicreate/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/turicreate/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/turicreate/contents/{+path}","compare_url":"https://api.github.com/repos/apple/turicreate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/turicreate/merges","archive_url":"https://api.github.com/repos/apple/turicreate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/turicreate/downloads","issues_url":"https://api.github.com/repos/apple/turicreate/issues{/number}","pulls_url":"https://api.github.com/repos/apple/turicreate/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/turicreate/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/turicreate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/turicreate/labels{/name}","releases_url":"https://api.github.com/repos/apple/turicreate/releases{/id}","deployments_url":"https://api.github.com/repos/apple/turicreate/deployments","created_at":"2017-12-01T00:42:04Z","updated_at":"2018-08-18T00:34:46Z","pushed_at":"2018-08-18T00:34:42Z","git_url":"git://github.com/apple/turicreate.git","ssh_url":"git@github.com:apple/turicreate.git","clone_url":"https://github.com/apple/turicreate.git","svn_url":"https://github.com/apple/turicreate","homepage":"","size":122608,"stargazers_count":7239,"watchers_count":7239,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":663,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":663,"open_issues":204,"watchers":7239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/turicreate/pulls/1001"},"html":{"href":"https://github.com/apple/turicreate/pull/1001"},"issue":{"href":"https://api.github.com/repos/apple/turicreate/issues/1001"},"comments":{"href":"https://api.github.com/repos/apple/turicreate/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/turicreate/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/turicreate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/turicreate/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/apple/turicreate/statuses/a1920616f485a7fbe1b12eb5b2926f727f5031a3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"TobyRoseman"}}