{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/54","repository_url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/54/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/54/events","html_url":"https://github.com/vaadin/vaadin-dialog-flow/issues/54","id":309459544,"number":54,"title":"opening/closing dialog produces extra request to server ","user":{"login":"manolo","id":161853,"avatar_url":"https://avatars1.githubusercontent.com/u/161853?v=4","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"labels":[{"id":835142825,"url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/labels/app%20starter","name":"app starter","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-28T17:26:53Z","updated_at":"2018-03-29T07:29:40Z","closed_at":null,"author_association":"MEMBER","body":"Any request that opens or closes the dialog causes an extra request to server because of the `opened-changed` listener in `Dialog.java` constructor. This is very noticeable in slow 3G networks.\r\n\r\nMakes not sense that setting the `opened` property from server side needs an extra request notifying server something that it should already know.\r\n\r\nProbably Flow should be aware of this fact and prevent sending standard setters events when changes come from server side.\r\n\r\nRelated with https://github.com/vaadin/flow/issues/3772  "},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/comments/377148216","html_url":"https://github.com/vaadin/vaadin-dialog-flow/issues/54#issuecomment-377148216","issue_url":"https://api.github.com/repos/vaadin/vaadin-dialog-flow/issues/54","id":377148216,"user":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T07:29:40Z","updated_at":"2018-03-29T07:29:40Z","author_association":"MEMBER","body":"Seems like that particular listener should only be added in the cases when it's actually needed (i.e. the case that sets the `autoAddedToTheUi` flag), and then the listener should be removed when the dialog  is closed again.\r\n\r\nFurthermore, closing from the server should handle everything eagerly instead of having to wait for an additional round trip. In that case, we might not even need any additional Flow features for dealing with this issue."}}
{"actor":{"display_login":"Legioth"}}