{"action":"created","comment":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/219015188","pull_request_review_id":157082889,"id":219015188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTAxNTE4OA==","diff_hunk":"@@ -541,7 +428,35 @@ contract('CoreIssuanceOrder', accounts => {\n           }\n         });\n \n-        expect(transferAddresses).to.not.include(relayerAddress);\n+        expect(transferAddresses).to.not.include(order.relayerAddress);\n+      });\n+    });\n+\n+    describe.only('when there is a taker relayer fee', async () => {\n+      before(async () => {\n+        issuanceOrderTakerRelayerFee = ether(1);\n+      });\n+\n+      before(async () => {","path":"test/core/extensions/coreIssuanceOrder.spec.ts","position":726,"original_position":726,"commit_id":"186a9ae98129ac22606edcc9cf1d073a481599c4","original_commit_id":"186a9ae98129ac22606edcc9cf1d073a481599c4","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"How come there are two `before` blocks?","created_at":"2018-09-20T02:01:34Z","updated_at":"2018-09-20T02:16:16Z","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/208#discussion_r219015188","pull_request_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/219015188"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/208#discussion_r219015188"},"pull_request":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208","id":216820976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODIwOTc2","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/208","diff_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/208.diff","patch_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/208.patch","issue_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/208","number":208,"state":"open","locked":false,"title":"Refactor core issuance spec","user":{"login":"asoong","id":3453571,"node_id":"MDQ6VXNlcjM0NTM1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3453571?v=4","gravatar_id":"","url":"https://api.github.com/users/asoong","html_url":"https://github.com/asoong","followers_url":"https://api.github.com/users/asoong/followers","following_url":"https://api.github.com/users/asoong/following{/other_user}","gists_url":"https://api.github.com/users/asoong/gists{/gist_id}","starred_url":"https://api.github.com/users/asoong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asoong/subscriptions","organizations_url":"https://api.github.com/users/asoong/orgs","repos_url":"https://api.github.com/users/asoong/repos","events_url":"https://api.github.com/users/asoong/events{/privacy}","received_events_url":"https://api.github.com/users/asoong/received_events","type":"User","site_admin":false},"body":"Refactor core issuance order specs for clarity and to make room to easily add a kyber order.\r\n\r\n- Use set protocol utils to generate the order data, slowly phasing out local utils/orders\r\n- Clean up deployment, no more transferring of tokens\r\n- Base case now uses 1 taker wallet order and 1 0x order, instead of a set of tests with 2x taker wallet followed by a set of tests with 2x 0x orders","created_at":"2018-09-20T01:36:59Z","updated_at":"2018-09-20T02:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdc79827c480e1882b3469676dd1f3147b62d3a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208/commits","review_comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208/comments","review_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/208/comments","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/186a9ae98129ac22606edcc9cf1d073a481599c4","head":{"label":"SetProtocol:alex/refactor_core_issuance_spec","ref":"alex/refactor_core_issuance_spec","sha":"186a9ae98129ac22606edcc9cf1d073a481599c4","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"🎛 Set Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-09-18T17:04:34Z","pushed_at":"2018-09-20T01:42:35Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"https://www.setprotocol.com","size":8060,"stargazers_count":71,"watchers_count":71,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":2,"watchers":71,"default_branch":"master"}},"base":{"label":"SetProtocol:master","ref":"master","sha":"92bfcd389780fabeb98e450e32f0a0276d562621","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"🎛 Set Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-09-18T17:04:34Z","pushed_at":"2018-09-20T01:42:35Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"https://www.setprotocol.com","size":8060,"stargazers_count":71,"watchers_count":71,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":2,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/208"},"issue":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/208"},"comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/186a9ae98129ac22606edcc9cf1d073a481599c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"felix2feng"}}