{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/204230072","pull_request_review_id":139277747,"id":204230072,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIzMDA3Mg==","diff_hunk":"@@ -428,7 +428,8 @@ def dedent(text):\n     # all lines.\n     margin = None\n     text = _whitespace_only_re.sub('', text)\n-    indents = _leading_whitespace_re.findall(text)\n+    indents = [line[:-len(line.lstrip())] for line in text.splitlines() if","path":"Lib/textwrap.py","position":5,"original_position":5,"commit_id":"249f65a3a8cd58e2e542b85a2d3fd9b584048962","original_commit_id":"249f65a3a8cd58e2e542b85a2d3fd9b584048962","user":{"login":"CuriousLearner","id":8039608,"node_id":"MDQ6VXNlcjgwMzk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8039608?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousLearner","html_url":"https://github.com/CuriousLearner","followers_url":"https://api.github.com/users/CuriousLearner/followers","following_url":"https://api.github.com/users/CuriousLearner/following{/other_user}","gists_url":"https://api.github.com/users/CuriousLearner/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousLearner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousLearner/subscriptions","organizations_url":"https://api.github.com/users/CuriousLearner/orgs","repos_url":"https://api.github.com/users/CuriousLearner/repos","events_url":"https://api.github.com/users/CuriousLearner/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousLearner/received_events","type":"User","site_admin":false},"body":"We would still need the indent list here. I've made the changes taking into account your review about calculating `line.lstrip()` twice by converting the list comprehension to a straightforward loop.\r\n\r\nLet me know if this looks now :)","created_at":"2018-07-22T07:06:01Z","updated_at":"2018-07-22T07:06:02Z","html_url":"https://github.com/python/cpython/pull/5051#discussion_r204230072","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/5051","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/204230072"},"html":{"href":"https://github.com/python/cpython/pull/5051#discussion_r204230072"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/5051"}},"in_reply_to_id":159164422},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/5051","id":160593272,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYwNTkzMjcy","html_url":"https://github.com/python/cpython/pull/5051","diff_url":"https://github.com/python/cpython/pull/5051.diff","patch_url":"https://github.com/python/cpython/pull/5051.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/5051","number":5051,"state":"open","locked":false,"title":"bpo-15045: Make textwrap.dedent() consistent with str.splitlines(True) and str.strip()","user":{"login":"CuriousLearner","id":8039608,"node_id":"MDQ6VXNlcjgwMzk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8039608?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousLearner","html_url":"https://github.com/CuriousLearner","followers_url":"https://api.github.com/users/CuriousLearner/followers","following_url":"https://api.github.com/users/CuriousLearner/following{/other_user}","gists_url":"https://api.github.com/users/CuriousLearner/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousLearner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousLearner/subscriptions","organizations_url":"https://api.github.com/users/CuriousLearner/orgs","repos_url":"https://api.github.com/users/CuriousLearner/repos","events_url":"https://api.github.com/users/CuriousLearner/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousLearner/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: bpo-15045 -->\nhttps://bugs.python.org/issue15045\n<!-- /issue-number -->\n","created_at":"2017-12-30T16:08:17Z","updated_at":"2018-07-22T07:06:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d8838852f029c88869c550cfc9096573c62b256","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"node_id":"MDU6TGFiZWw2NjY5Nzk4MjE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/5051/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/5051/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/5051/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/249f65a3a8cd58e2e542b85a2d3fd9b584048962","head":{"label":"CuriousLearner:fix-issue15045","ref":"fix-issue15045","sha":"249f65a3a8cd58e2e542b85a2d3fd9b584048962","user":{"login":"CuriousLearner","id":8039608,"node_id":"MDQ6VXNlcjgwMzk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8039608?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousLearner","html_url":"https://github.com/CuriousLearner","followers_url":"https://api.github.com/users/CuriousLearner/followers","following_url":"https://api.github.com/users/CuriousLearner/following{/other_user}","gists_url":"https://api.github.com/users/CuriousLearner/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousLearner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousLearner/subscriptions","organizations_url":"https://api.github.com/users/CuriousLearner/orgs","repos_url":"https://api.github.com/users/CuriousLearner/repos","events_url":"https://api.github.com/users/CuriousLearner/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousLearner/received_events","type":"User","site_admin":false},"repo":{"id":81937151,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNzE1MQ==","name":"cpython","full_name":"CuriousLearner/cpython","owner":{"login":"CuriousLearner","id":8039608,"node_id":"MDQ6VXNlcjgwMzk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8039608?v=4","gravatar_id":"","url":"https://api.github.com/users/CuriousLearner","html_url":"https://github.com/CuriousLearner","followers_url":"https://api.github.com/users/CuriousLearner/followers","following_url":"https://api.github.com/users/CuriousLearner/following{/other_user}","gists_url":"https://api.github.com/users/CuriousLearner/gists{/gist_id}","starred_url":"https://api.github.com/users/CuriousLearner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CuriousLearner/subscriptions","organizations_url":"https://api.github.com/users/CuriousLearner/orgs","repos_url":"https://api.github.com/users/CuriousLearner/repos","events_url":"https://api.github.com/users/CuriousLearner/events{/privacy}","received_events_url":"https://api.github.com/users/CuriousLearner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CuriousLearner/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/CuriousLearner/cpython","forks_url":"https://api.github.com/repos/CuriousLearner/cpython/forks","keys_url":"https://api.github.com/repos/CuriousLearner/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CuriousLearner/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CuriousLearner/cpython/teams","hooks_url":"https://api.github.com/repos/CuriousLearner/cpython/hooks","issue_events_url":"https://api.github.com/repos/CuriousLearner/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/CuriousLearner/cpython/events","assignees_url":"https://api.github.com/repos/CuriousLearner/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/CuriousLearner/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/CuriousLearner/cpython/tags","blobs_url":"https://api.github.com/repos/CuriousLearner/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CuriousLearner/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CuriousLearner/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/CuriousLearner/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CuriousLearner/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/CuriousLearner/cpython/languages","stargazers_url":"https://api.github.com/repos/CuriousLearner/cpython/stargazers","contributors_url":"https://api.github.com/repos/CuriousLearner/cpython/contributors","subscribers_url":"https://api.github.com/repos/CuriousLearner/cpython/subscribers","subscription_url":"https://api.github.com/repos/CuriousLearner/cpython/subscription","commits_url":"https://api.github.com/repos/CuriousLearner/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/CuriousLearner/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/CuriousLearner/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/CuriousLearner/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/CuriousLearner/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/CuriousLearner/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CuriousLearner/cpython/merges","archive_url":"https://api.github.com/repos/CuriousLearner/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CuriousLearner/cpython/downloads","issues_url":"https://api.github.com/repos/CuriousLearner/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/CuriousLearner/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/CuriousLearner/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/CuriousLearner/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CuriousLearner/cpython/labels{/name}","releases_url":"https://api.github.com/repos/CuriousLearner/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/CuriousLearner/cpython/deployments","created_at":"2017-02-14T11:09:55Z","updated_at":"2018-07-14T13:37:15Z","pushed_at":"2018-07-21T08:55:33Z","git_url":"git://github.com/CuriousLearner/cpython.git","ssh_url":"git@github.com:CuriousLearner/cpython.git","clone_url":"https://github.com/CuriousLearner/cpython.git","svn_url":"https://github.com/CuriousLearner/cpython","homepage":"https://www.python.org/","size":228597,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"1634fc289a13b0e1fdad4694d5cae7dab55f7186","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-07-22T03:18:34Z","pushed_at":"2018-07-22T06:13:58Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":243947,"stargazers_count":18826,"watchers_count":18826,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6114,"mirror_url":null,"archived":false,"open_issues_count":801,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6114,"open_issues":801,"watchers":18826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/5051"},"html":{"href":"https://github.com/python/cpython/pull/5051"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/5051"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/5051/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/5051/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/5051/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/249f65a3a8cd58e2e542b85a2d3fd9b584048962"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CuriousLearner"}}