{"action":"created","comment":{"url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/comments/196922626","pull_request_review_id":130564659,"id":196922626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkyMjYyNg==","diff_hunk":"@@ -101,19 +95,19 @@ where\n             let err = io::Error::new(io::ErrorKind::Other, \"HTTPS scheme forced but can't be used\");\n             return HttpsConnecting(Box::new(future::err(err)));\n         }\n-        \n         let host = dst.host().to_owned();\n         let connecting = self.http.connect(dst);\n-        let tls = self.tls.clone();\n-        let verification = self.hostname_verification;\n         let fut: BoxedFut<T::Transport> = if is_https {\n+\n+            let tls = match TlsConnector::builder()","path":"src/client.rs","position":70,"original_position":70,"commit_id":"8370cde1122e1da68c3eb79ef577904dbbf37d7a","original_commit_id":"8370cde1122e1da68c3eb79ef577904dbbf37d7a","user":{"login":"seanmonstar","id":51479,"node_id":"MDQ6VXNlcjUxNDc5","avatar_url":"https://avatars1.githubusercontent.com/u/51479?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"I'd be fine with changing the mutator on `HttpsConnector` to be a constructor instead. But, I believe we still need to allow users to provide a `TlsConnector`, since that's the only way to allow them setup certificate chains or identities.\r\n\r\nAs for if it was unsafe: if it *was* unsafe, then definitely `TlsConnector::connect{_async}` should consume it, and it shouldn't implement `Clone`. I suspect that unsafety is actually abstracted away.","created_at":"2018-06-20T19:58:20Z","updated_at":"2018-06-20T19:58:20Z","html_url":"https://github.com/hyperium/hyper-tls/pull/24#discussion_r196922626","pull_request_url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/comments/196922626"},"html":{"href":"https://github.com/hyperium/hyper-tls/pull/24#discussion_r196922626"},"pull_request":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24"}},"in_reply_to_id":196592188},"pull_request":{"url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24","id":195907427,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTA3NDI3","html_url":"https://github.com/hyperium/hyper-tls/pull/24","diff_url":"https://github.com/hyperium/hyper-tls/pull/24.diff","patch_url":"https://github.com/hyperium/hyper-tls/pull/24.patch","issue_url":"https://api.github.com/repos/hyperium/hyper-tls/issues/24","number":24,"state":"open","locked":false,"title":"prepare for native-tls 0.2","user":{"login":"aep","id":136926,"node_id":"MDQ6VXNlcjEzNjkyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/136926?v=4","gravatar_id":"","url":"https://api.github.com/users/aep","html_url":"https://github.com/aep","followers_url":"https://api.github.com/users/aep/followers","following_url":"https://api.github.com/users/aep/following{/other_user}","gists_url":"https://api.github.com/users/aep/gists{/gist_id}","starred_url":"https://api.github.com/users/aep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aep/subscriptions","organizations_url":"https://api.github.com/users/aep/orgs","repos_url":"https://api.github.com/users/aep/repos","events_url":"https://api.github.com/users/aep/events{/privacy}","received_events_url":"https://api.github.com/users/aep/received_events","type":"User","site_admin":false},"body":"part of https://github.com/sfackler/rust-native-tls/issues/98","created_at":"2018-06-19T17:47:27Z","updated_at":"2018-06-20T19:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7cda735819ded4c285cc8942d9c70f8a6ccd755","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24/commits","review_comments_url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24/comments","review_comment_url":"https://api.github.com/repos/hyperium/hyper-tls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperium/hyper-tls/issues/24/comments","statuses_url":"https://api.github.com/repos/hyperium/hyper-tls/statuses/8370cde1122e1da68c3eb79ef577904dbbf37d7a","head":{"label":"aep:native-tls-0.2","ref":"native-tls-0.2","sha":"8370cde1122e1da68c3eb79ef577904dbbf37d7a","user":{"login":"aep","id":136926,"node_id":"MDQ6VXNlcjEzNjkyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/136926?v=4","gravatar_id":"","url":"https://api.github.com/users/aep","html_url":"https://github.com/aep","followers_url":"https://api.github.com/users/aep/followers","following_url":"https://api.github.com/users/aep/following{/other_user}","gists_url":"https://api.github.com/users/aep/gists{/gist_id}","starred_url":"https://api.github.com/users/aep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aep/subscriptions","organizations_url":"https://api.github.com/users/aep/orgs","repos_url":"https://api.github.com/users/aep/repos","events_url":"https://api.github.com/users/aep/events{/privacy}","received_events_url":"https://api.github.com/users/aep/received_events","type":"User","site_admin":false},"repo":{"id":137886440,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4ODY0NDA=","name":"hyper-tls","full_name":"aep/hyper-tls","owner":{"login":"aep","id":136926,"node_id":"MDQ6VXNlcjEzNjkyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/136926?v=4","gravatar_id":"","url":"https://api.github.com/users/aep","html_url":"https://github.com/aep","followers_url":"https://api.github.com/users/aep/followers","following_url":"https://api.github.com/users/aep/following{/other_user}","gists_url":"https://api.github.com/users/aep/gists{/gist_id}","starred_url":"https://api.github.com/users/aep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aep/subscriptions","organizations_url":"https://api.github.com/users/aep/orgs","repos_url":"https://api.github.com/users/aep/repos","events_url":"https://api.github.com/users/aep/events{/privacy}","received_events_url":"https://api.github.com/users/aep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aep/hyper-tls","description":null,"fork":true,"url":"https://api.github.com/repos/aep/hyper-tls","forks_url":"https://api.github.com/repos/aep/hyper-tls/forks","keys_url":"https://api.github.com/repos/aep/hyper-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aep/hyper-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aep/hyper-tls/teams","hooks_url":"https://api.github.com/repos/aep/hyper-tls/hooks","issue_events_url":"https://api.github.com/repos/aep/hyper-tls/issues/events{/number}","events_url":"https://api.github.com/repos/aep/hyper-tls/events","assignees_url":"https://api.github.com/repos/aep/hyper-tls/assignees{/user}","branches_url":"https://api.github.com/repos/aep/hyper-tls/branches{/branch}","tags_url":"https://api.github.com/repos/aep/hyper-tls/tags","blobs_url":"https://api.github.com/repos/aep/hyper-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aep/hyper-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aep/hyper-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/aep/hyper-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aep/hyper-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/aep/hyper-tls/languages","stargazers_url":"https://api.github.com/repos/aep/hyper-tls/stargazers","contributors_url":"https://api.github.com/repos/aep/hyper-tls/contributors","subscribers_url":"https://api.github.com/repos/aep/hyper-tls/subscribers","subscription_url":"https://api.github.com/repos/aep/hyper-tls/subscription","commits_url":"https://api.github.com/repos/aep/hyper-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/aep/hyper-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/aep/hyper-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/aep/hyper-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/aep/hyper-tls/contents/{+path}","compare_url":"https://api.github.com/repos/aep/hyper-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aep/hyper-tls/merges","archive_url":"https://api.github.com/repos/aep/hyper-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aep/hyper-tls/downloads","issues_url":"https://api.github.com/repos/aep/hyper-tls/issues{/number}","pulls_url":"https://api.github.com/repos/aep/hyper-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/aep/hyper-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/aep/hyper-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aep/hyper-tls/labels{/name}","releases_url":"https://api.github.com/repos/aep/hyper-tls/releases{/id}","deployments_url":"https://api.github.com/repos/aep/hyper-tls/deployments","created_at":"2018-06-19T12:08:51Z","updated_at":"2018-06-19T12:08:53Z","pushed_at":"2018-06-19T17:45:04Z","git_url":"git://github.com/aep/hyper-tls.git","ssh_url":"git@github.com:aep/hyper-tls.git","clone_url":"https://github.com/aep/hyper-tls.git","svn_url":"https://github.com/aep/hyper-tls","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperium:master","ref":"master","sha":"16bcecdd9a9f4bb00b30912d422af376c41a7868","user":{"login":"hyperium","id":8730506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzA1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8730506?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"repo":{"id":78690338,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY5MDMzOA==","name":"hyper-tls","full_name":"hyperium/hyper-tls","owner":{"login":"hyperium","id":8730506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MzA1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8730506?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperium/hyper-tls","description":null,"fork":false,"url":"https://api.github.com/repos/hyperium/hyper-tls","forks_url":"https://api.github.com/repos/hyperium/hyper-tls/forks","keys_url":"https://api.github.com/repos/hyperium/hyper-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperium/hyper-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperium/hyper-tls/teams","hooks_url":"https://api.github.com/repos/hyperium/hyper-tls/hooks","issue_events_url":"https://api.github.com/repos/hyperium/hyper-tls/issues/events{/number}","events_url":"https://api.github.com/repos/hyperium/hyper-tls/events","assignees_url":"https://api.github.com/repos/hyperium/hyper-tls/assignees{/user}","branches_url":"https://api.github.com/repos/hyperium/hyper-tls/branches{/branch}","tags_url":"https://api.github.com/repos/hyperium/hyper-tls/tags","blobs_url":"https://api.github.com/repos/hyperium/hyper-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperium/hyper-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperium/hyper-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperium/hyper-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperium/hyper-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperium/hyper-tls/languages","stargazers_url":"https://api.github.com/repos/hyperium/hyper-tls/stargazers","contributors_url":"https://api.github.com/repos/hyperium/hyper-tls/contributors","subscribers_url":"https://api.github.com/repos/hyperium/hyper-tls/subscribers","subscription_url":"https://api.github.com/repos/hyperium/hyper-tls/subscription","commits_url":"https://api.github.com/repos/hyperium/hyper-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperium/hyper-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperium/hyper-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperium/hyper-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperium/hyper-tls/contents/{+path}","compare_url":"https://api.github.com/repos/hyperium/hyper-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperium/hyper-tls/merges","archive_url":"https://api.github.com/repos/hyperium/hyper-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperium/hyper-tls/downloads","issues_url":"https://api.github.com/repos/hyperium/hyper-tls/issues{/number}","pulls_url":"https://api.github.com/repos/hyperium/hyper-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperium/hyper-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperium/hyper-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperium/hyper-tls/labels{/name}","releases_url":"https://api.github.com/repos/hyperium/hyper-tls/releases{/id}","deployments_url":"https://api.github.com/repos/hyperium/hyper-tls/deployments","created_at":"2017-01-11T23:45:35Z","updated_at":"2018-06-15T07:05:50Z","pushed_at":"2018-06-19T17:47:28Z","git_url":"git://github.com/hyperium/hyper-tls.git","ssh_url":"git@github.com:hyperium/hyper-tls.git","clone_url":"https://github.com/hyperium/hyper-tls.git","svn_url":"https://github.com/hyperium/hyper-tls","homepage":null,"size":22,"stargazers_count":41,"watchers_count":41,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":4,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24"},"html":{"href":"https://github.com/hyperium/hyper-tls/pull/24"},"issue":{"href":"https://api.github.com/repos/hyperium/hyper-tls/issues/24"},"comments":{"href":"https://api.github.com/repos/hyperium/hyper-tls/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperium/hyper-tls/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/hyperium/hyper-tls/statuses/8370cde1122e1da68c3eb79ef577904dbbf37d7a"}},"author_association":"NONE"}}
{"actor":{"display_login":"seanmonstar"}}