{"action":"opened","number":1056,"pull_request":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/1056","id":182635200,"html_url":"https://github.com/novnc/noVNC/pull/1056","diff_url":"https://github.com/novnc/noVNC/pull/1056.diff","patch_url":"https://github.com/novnc/noVNC/pull/1056.patch","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/1056","number":1056,"state":"open","locked":false,"title":"Prefix websocket path with server path","user":{"login":"ryanlovett","id":10248125,"avatar_url":"https://avatars0.githubusercontent.com/u/10248125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanlovett","html_url":"https://github.com/ryanlovett","followers_url":"https://api.github.com/users/ryanlovett/followers","following_url":"https://api.github.com/users/ryanlovett/following{/other_user}","gists_url":"https://api.github.com/users/ryanlovett/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlovett/subscriptions","organizations_url":"https://api.github.com/users/ryanlovett/orgs","repos_url":"https://api.github.com/users/ryanlovett/repos","events_url":"https://api.github.com/users/ryanlovett/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlovett/received_events","type":"User","site_admin":false},"body":"If noVNC is not served at the root path, prefix the websocket path with the server path.  This makes the path to the websocket consistent with the path to all the other web assets. This is convenient so that users do not need to manually change the path setting, though they still can override it.\r\n\r\nFor example if the websockify server is at /some/sub/dir, with this patch noVNC will connect to /some/sub/dir/websockify rather than /websockify.","created_at":"2018-04-19T00:11:59Z","updated_at":"2018-04-19T00:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/novnc/noVNC/pulls/1056/commits","review_comments_url":"https://api.github.com/repos/novnc/noVNC/pulls/1056/comments","review_comment_url":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/1056/comments","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/783dab48788a42fbb2929d9d3a73c2cb76167d8d","head":{"label":"ryanlovett:patch-2","ref":"patch-2","sha":"783dab48788a42fbb2929d9d3a73c2cb76167d8d","user":{"login":"ryanlovett","id":10248125,"avatar_url":"https://avatars0.githubusercontent.com/u/10248125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanlovett","html_url":"https://github.com/ryanlovett","followers_url":"https://api.github.com/users/ryanlovett/followers","following_url":"https://api.github.com/users/ryanlovett/following{/other_user}","gists_url":"https://api.github.com/users/ryanlovett/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlovett/subscriptions","organizations_url":"https://api.github.com/users/ryanlovett/orgs","repos_url":"https://api.github.com/users/ryanlovett/repos","events_url":"https://api.github.com/users/ryanlovett/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlovett/received_events","type":"User","site_admin":false},"repo":{"id":130011560,"name":"noVNC","full_name":"ryanlovett/noVNC","owner":{"login":"ryanlovett","id":10248125,"avatar_url":"https://avatars0.githubusercontent.com/u/10248125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanlovett","html_url":"https://github.com/ryanlovett","followers_url":"https://api.github.com/users/ryanlovett/followers","following_url":"https://api.github.com/users/ryanlovett/following{/other_user}","gists_url":"https://api.github.com/users/ryanlovett/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlovett/subscriptions","organizations_url":"https://api.github.com/users/ryanlovett/orgs","repos_url":"https://api.github.com/users/ryanlovett/repos","events_url":"https://api.github.com/users/ryanlovett/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlovett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanlovett/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/ryanlovett/noVNC","forks_url":"https://api.github.com/repos/ryanlovett/noVNC/forks","keys_url":"https://api.github.com/repos/ryanlovett/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanlovett/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanlovett/noVNC/teams","hooks_url":"https://api.github.com/repos/ryanlovett/noVNC/hooks","issue_events_url":"https://api.github.com/repos/ryanlovett/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/ryanlovett/noVNC/events","assignees_url":"https://api.github.com/repos/ryanlovett/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/ryanlovett/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/ryanlovett/noVNC/tags","blobs_url":"https://api.github.com/repos/ryanlovett/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanlovett/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanlovett/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanlovett/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanlovett/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanlovett/noVNC/languages","stargazers_url":"https://api.github.com/repos/ryanlovett/noVNC/stargazers","contributors_url":"https://api.github.com/repos/ryanlovett/noVNC/contributors","subscribers_url":"https://api.github.com/repos/ryanlovett/noVNC/subscribers","subscription_url":"https://api.github.com/repos/ryanlovett/noVNC/subscription","commits_url":"https://api.github.com/repos/ryanlovett/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanlovett/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanlovett/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanlovett/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanlovett/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/ryanlovett/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanlovett/noVNC/merges","archive_url":"https://api.github.com/repos/ryanlovett/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanlovett/noVNC/downloads","issues_url":"https://api.github.com/repos/ryanlovett/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/ryanlovett/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanlovett/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanlovett/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanlovett/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/ryanlovett/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/ryanlovett/noVNC/deployments","created_at":"2018-04-18T06:01:34Z","updated_at":"2018-04-18T06:01:37Z","pushed_at":"2018-04-19T00:10:14Z","git_url":"git://github.com/ryanlovett/noVNC.git","ssh_url":"git@github.com:ryanlovett/noVNC.git","clone_url":"https://github.com/ryanlovett/noVNC.git","svn_url":"https://github.com/ryanlovett/noVNC","homepage":"novnc.com","size":9043,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"novnc:master","ref":"master","sha":"24231f1ae3a20d3cb14b1aba1ffc0b7a110caa41","user":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"repo":{"id":598164,"name":"noVNC","full_name":"novnc/noVNC","owner":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novnc/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/novnc/noVNC","forks_url":"https://api.github.com/repos/novnc/noVNC/forks","keys_url":"https://api.github.com/repos/novnc/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novnc/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novnc/noVNC/teams","hooks_url":"https://api.github.com/repos/novnc/noVNC/hooks","issue_events_url":"https://api.github.com/repos/novnc/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/novnc/noVNC/events","assignees_url":"https://api.github.com/repos/novnc/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/novnc/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/novnc/noVNC/tags","blobs_url":"https://api.github.com/repos/novnc/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novnc/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novnc/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/novnc/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/novnc/noVNC/languages","stargazers_url":"https://api.github.com/repos/novnc/noVNC/stargazers","contributors_url":"https://api.github.com/repos/novnc/noVNC/contributors","subscribers_url":"https://api.github.com/repos/novnc/noVNC/subscribers","subscription_url":"https://api.github.com/repos/novnc/noVNC/subscription","commits_url":"https://api.github.com/repos/novnc/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/novnc/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/novnc/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/novnc/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/novnc/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/novnc/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novnc/noVNC/merges","archive_url":"https://api.github.com/repos/novnc/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novnc/noVNC/downloads","issues_url":"https://api.github.com/repos/novnc/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/novnc/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/novnc/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/novnc/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novnc/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/novnc/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/novnc/noVNC/deployments","created_at":"2010-04-07T01:55:44Z","updated_at":"2018-04-18T14:13:17Z","pushed_at":"2018-04-18T19:54:22Z","git_url":"git://github.com/novnc/noVNC.git","ssh_url":"git@github.com:novnc/noVNC.git","clone_url":"https://github.com/novnc/noVNC.git","svn_url":"https://github.com/novnc/noVNC","homepage":"novnc.com","size":9054,"stargazers_count":4202,"watchers_count":4202,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":921,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":921,"open_issues":45,"watchers":4202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1056"},"html":{"href":"https://github.com/novnc/noVNC/pull/1056"},"issue":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1056"},"comments":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1056/comments"},"review_comments":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1056/comments"},"review_comment":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1056/commits"},"statuses":{"href":"https://api.github.com/repos/novnc/noVNC/statuses/783dab48788a42fbb2929d9d3a73c2cb76167d8d"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":15,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ryanlovett"}}