{"action":"created","comment":{"url":"https://api.github.com/repos/abo-abo/swiper/pulls/comments/169877937","pull_request_review_id":98473385,"id":169877937,"diff_hunk":"@@ -1256,7 +1256,7 @@ files in a project.\")\n   \"Default defun to calculate `counsel--git-grep-count'.\"\n   (if (eq system-type 'windows-nt)\n       0\n-    (read (shell-command-to-string \"du -s\"))))","path":"counsel.el","position":null,"original_position":4,"commit_id":"536dc82f75d6e22c2d3cf5ed69cec8dbb72f9dbf","original_commit_id":"536dc82f75d6e22c2d3cf5ed69cec8dbb72f9dbf","user":{"login":"abo-abo","id":2937359,"avatar_url":"https://avatars3.githubusercontent.com/u/2937359?v=4","gravatar_id":"","url":"https://api.github.com/users/abo-abo","html_url":"https://github.com/abo-abo","followers_url":"https://api.github.com/users/abo-abo/followers","following_url":"https://api.github.com/users/abo-abo/following{/other_user}","gists_url":"https://api.github.com/users/abo-abo/gists{/gist_id}","starred_url":"https://api.github.com/users/abo-abo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abo-abo/subscriptions","organizations_url":"https://api.github.com/users/abo-abo/orgs","repos_url":"https://api.github.com/users/abo-abo/repos","events_url":"https://api.github.com/users/abo-abo/events{/privacy}","received_events_url":"https://api.github.com/users/abo-abo/received_events","type":"User","site_admin":false},"body":"I agree that not piping it all through the shell is a bit more efficient.\r\n\r\nOn the other hand, using the shell is a lot more flexible:\r\n\r\n- You can copy paste the command into an actual shell to test it\r\n- You can add/remove flags more easily, since it's just in the shell format\r\n","created_at":"2018-02-22T07:59:58Z","updated_at":"2018-02-22T07:59:58Z","html_url":"https://github.com/abo-abo/swiper/pull/1470#discussion_r169877937","pull_request_url":"https://api.github.com/repos/abo-abo/swiper/pulls/1470","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/comments/169877937"},"html":{"href":"https://github.com/abo-abo/swiper/pull/1470#discussion_r169877937"},"pull_request":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/1470"}},"in_reply_to_id":169725899},"pull_request":{"url":"https://api.github.com/repos/abo-abo/swiper/pulls/1470","id":170333608,"html_url":"https://github.com/abo-abo/swiper/pull/1470","diff_url":"https://github.com/abo-abo/swiper/pull/1470.diff","patch_url":"https://github.com/abo-abo/swiper/pull/1470.patch","issue_url":"https://api.github.com/repos/abo-abo/swiper/issues/1470","number":1470,"state":"open","locked":false,"title":"provide hooks to customize counsel-git-grep behavior on large repos","user":{"login":"articuluxe","id":3206473,"avatar_url":"https://avatars3.githubusercontent.com/u/3206473?v=4","gravatar_id":"","url":"https://api.github.com/users/articuluxe","html_url":"https://github.com/articuluxe","followers_url":"https://api.github.com/users/articuluxe/followers","following_url":"https://api.github.com/users/articuluxe/following{/other_user}","gists_url":"https://api.github.com/users/articuluxe/gists{/gist_id}","starred_url":"https://api.github.com/users/articuluxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/articuluxe/subscriptions","organizations_url":"https://api.github.com/users/articuluxe/orgs","repos_url":"https://api.github.com/users/articuluxe/repos","events_url":"https://api.github.com/users/articuluxe/events{/privacy}","received_events_url":"https://api.github.com/users/articuluxe/received_events","type":"User","site_admin":false},"body":"I hope these (non-breaking) changes are OK.  The current solution (du -s) can take from 7 - 24 sec. on a medium-size repo, which already takes so long that it doesn't matter that we limit the minimum input to 3 characters.  These changes just provide a customization point for users to change this behavior.","created_at":"2018-02-20T23:01:41Z","updated_at":"2018-02-22T07:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24790b3281201057dc1f1968b6246add5cae3260","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/abo-abo/swiper/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/abo-abo/swiper/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/abo-abo/swiper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abo-abo/swiper/issues/1470/comments","statuses_url":"https://api.github.com/repos/abo-abo/swiper/statuses/536dc82f75d6e22c2d3cf5ed69cec8dbb72f9dbf","head":{"label":"articuluxe:feature/counsel-git-grep","ref":"feature/counsel-git-grep","sha":"536dc82f75d6e22c2d3cf5ed69cec8dbb72f9dbf","user":{"login":"articuluxe","id":3206473,"avatar_url":"https://avatars3.githubusercontent.com/u/3206473?v=4","gravatar_id":"","url":"https://api.github.com/users/articuluxe","html_url":"https://github.com/articuluxe","followers_url":"https://api.github.com/users/articuluxe/followers","following_url":"https://api.github.com/users/articuluxe/following{/other_user}","gists_url":"https://api.github.com/users/articuluxe/gists{/gist_id}","starred_url":"https://api.github.com/users/articuluxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/articuluxe/subscriptions","organizations_url":"https://api.github.com/users/articuluxe/orgs","repos_url":"https://api.github.com/users/articuluxe/repos","events_url":"https://api.github.com/users/articuluxe/events{/privacy}","received_events_url":"https://api.github.com/users/articuluxe/received_events","type":"User","site_admin":false},"repo":{"id":122265012,"name":"swiper","full_name":"articuluxe/swiper","owner":{"login":"articuluxe","id":3206473,"avatar_url":"https://avatars3.githubusercontent.com/u/3206473?v=4","gravatar_id":"","url":"https://api.github.com/users/articuluxe","html_url":"https://github.com/articuluxe","followers_url":"https://api.github.com/users/articuluxe/followers","following_url":"https://api.github.com/users/articuluxe/following{/other_user}","gists_url":"https://api.github.com/users/articuluxe/gists{/gist_id}","starred_url":"https://api.github.com/users/articuluxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/articuluxe/subscriptions","organizations_url":"https://api.github.com/users/articuluxe/orgs","repos_url":"https://api.github.com/users/articuluxe/repos","events_url":"https://api.github.com/users/articuluxe/events{/privacy}","received_events_url":"https://api.github.com/users/articuluxe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/articuluxe/swiper","description":"Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!","fork":true,"url":"https://api.github.com/repos/articuluxe/swiper","forks_url":"https://api.github.com/repos/articuluxe/swiper/forks","keys_url":"https://api.github.com/repos/articuluxe/swiper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/articuluxe/swiper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/articuluxe/swiper/teams","hooks_url":"https://api.github.com/repos/articuluxe/swiper/hooks","issue_events_url":"https://api.github.com/repos/articuluxe/swiper/issues/events{/number}","events_url":"https://api.github.com/repos/articuluxe/swiper/events","assignees_url":"https://api.github.com/repos/articuluxe/swiper/assignees{/user}","branches_url":"https://api.github.com/repos/articuluxe/swiper/branches{/branch}","tags_url":"https://api.github.com/repos/articuluxe/swiper/tags","blobs_url":"https://api.github.com/repos/articuluxe/swiper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/articuluxe/swiper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/articuluxe/swiper/git/refs{/sha}","trees_url":"https://api.github.com/repos/articuluxe/swiper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/articuluxe/swiper/statuses/{sha}","languages_url":"https://api.github.com/repos/articuluxe/swiper/languages","stargazers_url":"https://api.github.com/repos/articuluxe/swiper/stargazers","contributors_url":"https://api.github.com/repos/articuluxe/swiper/contributors","subscribers_url":"https://api.github.com/repos/articuluxe/swiper/subscribers","subscription_url":"https://api.github.com/repos/articuluxe/swiper/subscription","commits_url":"https://api.github.com/repos/articuluxe/swiper/commits{/sha}","git_commits_url":"https://api.github.com/repos/articuluxe/swiper/git/commits{/sha}","comments_url":"https://api.github.com/repos/articuluxe/swiper/comments{/number}","issue_comment_url":"https://api.github.com/repos/articuluxe/swiper/issues/comments{/number}","contents_url":"https://api.github.com/repos/articuluxe/swiper/contents/{+path}","compare_url":"https://api.github.com/repos/articuluxe/swiper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/articuluxe/swiper/merges","archive_url":"https://api.github.com/repos/articuluxe/swiper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/articuluxe/swiper/downloads","issues_url":"https://api.github.com/repos/articuluxe/swiper/issues{/number}","pulls_url":"https://api.github.com/repos/articuluxe/swiper/pulls{/number}","milestones_url":"https://api.github.com/repos/articuluxe/swiper/milestones{/number}","notifications_url":"https://api.github.com/repos/articuluxe/swiper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/articuluxe/swiper/labels{/name}","releases_url":"https://api.github.com/repos/articuluxe/swiper/releases{/id}","deployments_url":"https://api.github.com/repos/articuluxe/swiper/deployments","created_at":"2018-02-20T22:33:54Z","updated_at":"2018-02-20T22:33:56Z","pushed_at":"2018-02-21T16:41:16Z","git_url":"git://github.com/articuluxe/swiper.git","ssh_url":"git@github.com:articuluxe/swiper.git","clone_url":"https://github.com/articuluxe/swiper.git","svn_url":"https://github.com/articuluxe/swiper","homepage":"http://oremacs.com/swiper/","size":3845,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abo-abo:master","ref":"master","sha":"b022886c0392bd7a04d8296a2c6c68d2d858d841","user":{"login":"abo-abo","id":2937359,"avatar_url":"https://avatars3.githubusercontent.com/u/2937359?v=4","gravatar_id":"","url":"https://api.github.com/users/abo-abo","html_url":"https://github.com/abo-abo","followers_url":"https://api.github.com/users/abo-abo/followers","following_url":"https://api.github.com/users/abo-abo/following{/other_user}","gists_url":"https://api.github.com/users/abo-abo/gists{/gist_id}","starred_url":"https://api.github.com/users/abo-abo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abo-abo/subscriptions","organizations_url":"https://api.github.com/users/abo-abo/orgs","repos_url":"https://api.github.com/users/abo-abo/repos","events_url":"https://api.github.com/users/abo-abo/events{/privacy}","received_events_url":"https://api.github.com/users/abo-abo/received_events","type":"User","site_admin":false},"repo":{"id":31918222,"name":"swiper","full_name":"abo-abo/swiper","owner":{"login":"abo-abo","id":2937359,"avatar_url":"https://avatars3.githubusercontent.com/u/2937359?v=4","gravatar_id":"","url":"https://api.github.com/users/abo-abo","html_url":"https://github.com/abo-abo","followers_url":"https://api.github.com/users/abo-abo/followers","following_url":"https://api.github.com/users/abo-abo/following{/other_user}","gists_url":"https://api.github.com/users/abo-abo/gists{/gist_id}","starred_url":"https://api.github.com/users/abo-abo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abo-abo/subscriptions","organizations_url":"https://api.github.com/users/abo-abo/orgs","repos_url":"https://api.github.com/users/abo-abo/repos","events_url":"https://api.github.com/users/abo-abo/events{/privacy}","received_events_url":"https://api.github.com/users/abo-abo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abo-abo/swiper","description":"Ivy - a generic completion frontend for Emacs, Swiper - isearch with an overview, and more. Oh, man!","fork":false,"url":"https://api.github.com/repos/abo-abo/swiper","forks_url":"https://api.github.com/repos/abo-abo/swiper/forks","keys_url":"https://api.github.com/repos/abo-abo/swiper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abo-abo/swiper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abo-abo/swiper/teams","hooks_url":"https://api.github.com/repos/abo-abo/swiper/hooks","issue_events_url":"https://api.github.com/repos/abo-abo/swiper/issues/events{/number}","events_url":"https://api.github.com/repos/abo-abo/swiper/events","assignees_url":"https://api.github.com/repos/abo-abo/swiper/assignees{/user}","branches_url":"https://api.github.com/repos/abo-abo/swiper/branches{/branch}","tags_url":"https://api.github.com/repos/abo-abo/swiper/tags","blobs_url":"https://api.github.com/repos/abo-abo/swiper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abo-abo/swiper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abo-abo/swiper/git/refs{/sha}","trees_url":"https://api.github.com/repos/abo-abo/swiper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abo-abo/swiper/statuses/{sha}","languages_url":"https://api.github.com/repos/abo-abo/swiper/languages","stargazers_url":"https://api.github.com/repos/abo-abo/swiper/stargazers","contributors_url":"https://api.github.com/repos/abo-abo/swiper/contributors","subscribers_url":"https://api.github.com/repos/abo-abo/swiper/subscribers","subscription_url":"https://api.github.com/repos/abo-abo/swiper/subscription","commits_url":"https://api.github.com/repos/abo-abo/swiper/commits{/sha}","git_commits_url":"https://api.github.com/repos/abo-abo/swiper/git/commits{/sha}","comments_url":"https://api.github.com/repos/abo-abo/swiper/comments{/number}","issue_comment_url":"https://api.github.com/repos/abo-abo/swiper/issues/comments{/number}","contents_url":"https://api.github.com/repos/abo-abo/swiper/contents/{+path}","compare_url":"https://api.github.com/repos/abo-abo/swiper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abo-abo/swiper/merges","archive_url":"https://api.github.com/repos/abo-abo/swiper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abo-abo/swiper/downloads","issues_url":"https://api.github.com/repos/abo-abo/swiper/issues{/number}","pulls_url":"https://api.github.com/repos/abo-abo/swiper/pulls{/number}","milestones_url":"https://api.github.com/repos/abo-abo/swiper/milestones{/number}","notifications_url":"https://api.github.com/repos/abo-abo/swiper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abo-abo/swiper/labels{/name}","releases_url":"https://api.github.com/repos/abo-abo/swiper/releases{/id}","deployments_url":"https://api.github.com/repos/abo-abo/swiper/deployments","created_at":"2015-03-09T19:29:06Z","updated_at":"2018-02-21T20:06:44Z","pushed_at":"2018-02-21T18:14:57Z","git_url":"git://github.com/abo-abo/swiper.git","ssh_url":"git@github.com:abo-abo/swiper.git","clone_url":"https://github.com/abo-abo/swiper.git","svn_url":"https://github.com/abo-abo/swiper","homepage":"http://oremacs.com/swiper/","size":3898,"stargazers_count":792,"watchers_count":792,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":199,"license":null,"forks":166,"open_issues":199,"watchers":792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/1470"},"html":{"href":"https://github.com/abo-abo/swiper/pull/1470"},"issue":{"href":"https://api.github.com/repos/abo-abo/swiper/issues/1470"},"comments":{"href":"https://api.github.com/repos/abo-abo/swiper/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abo-abo/swiper/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/abo-abo/swiper/statuses/536dc82f75d6e22c2d3cf5ed69cec8dbb72f9dbf"}},"author_association":"NONE"}}
{"actor":{"display_login":"abo-abo"}}