{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments/233332401","pull_request_review_id":174719416,"id":233332401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzMzMjQwMQ==","diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+ * Copyright (c) 2018, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.\n+ *\n+ * WSO2 Inc. licenses this file to you under the Apache License,\n+ *  Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.wso2.carbon.identity.sso.saml.model;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+import javax.servlet.http.HttpServletRequest;\n+import javax.servlet.http.HttpServletRequestWrapper;\n+\n+/**\n+ * This request wrapper wraps the request to the samlsso servlet from the ecp servlet.\n+ */\n+public class SamlSSORequestWrapper extends HttpServletRequestWrapper {\n+\n+    private Map extraParameters;\n+\n+    public SamlSSORequestWrapper(HttpServletRequest request) {\n+        super(request);\n+        extraParameters = new HashMap();\n+\n+    }\n+\n+    public String getParameter(String name) {\n+\n+        if (extraParameters.containsKey(name)) {\n+            return (String) extraParameters.get(name);\n+        } else {\n+            return super.getParameter(name);\n+        }\n+    }\n+\n+    public void setParameter(String name, String value) {\n+        extraParameters.put(name, value);\n+\n+    }\n+\n+","path":"components/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/model/SamlSSORequestWrapper.java","position":53,"original_position":53,"commit_id":"99f29e716989ee369897866edb71dd249745b89d","original_commit_id":"99f29e716989ee369897866edb71dd249745b89d","user":{"login":"hasinthaindrajee","id":3666100,"node_id":"MDQ6VXNlcjM2NjYxMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3666100?v=4","gravatar_id":"","url":"https://api.github.com/users/hasinthaindrajee","html_url":"https://github.com/hasinthaindrajee","followers_url":"https://api.github.com/users/hasinthaindrajee/followers","following_url":"https://api.github.com/users/hasinthaindrajee/following{/other_user}","gists_url":"https://api.github.com/users/hasinthaindrajee/gists{/gist_id}","starred_url":"https://api.github.com/users/hasinthaindrajee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasinthaindrajee/subscriptions","organizations_url":"https://api.github.com/users/hasinthaindrajee/orgs","repos_url":"https://api.github.com/users/hasinthaindrajee/repos","events_url":"https://api.github.com/users/hasinthaindrajee/events{/privacy}","received_events_url":"https://api.github.com/users/hasinthaindrajee/received_events","type":"User","site_admin":false},"body":"Remove unnecessary new lines","created_at":"2018-11-14T07:06:48Z","updated_at":"2018-11-14T07:06:49Z","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196#discussion_r233332401","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments/233332401"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196#discussion_r233332401"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196","id":226843932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODQzOTMy","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196","diff_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196.diff","patch_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/196","number":196,"state":"open","locked":false,"title":"Add SAML ECP profile ","user":{"login":"WinmaH","id":25497216,"node_id":"MDQ6VXNlcjI1NDk3MjE2","avatar_url":"https://avatars1.githubusercontent.com/u/25497216?v=4","gravatar_id":"","url":"https://api.github.com/users/WinmaH","html_url":"https://github.com/WinmaH","followers_url":"https://api.github.com/users/WinmaH/followers","following_url":"https://api.github.com/users/WinmaH/following{/other_user}","gists_url":"https://api.github.com/users/WinmaH/gists{/gist_id}","starred_url":"https://api.github.com/users/WinmaH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinmaH/subscriptions","organizations_url":"https://api.github.com/users/WinmaH/orgs","repos_url":"https://api.github.com/users/WinmaH/repos","events_url":"https://api.github.com/users/WinmaH/events{/privacy}","received_events_url":"https://api.github.com/users/WinmaH/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\nThis modification adds SAML ECP support to the Identity Server. It creates a new servlet to handle SOAP bound SAML requests from clients , validates and forwards the request to samlsso servlet, and  sends SOAP bound SAML responses to the client.\r\n\r\n### When should this PR be merged\r\n\r\nThis  PR should me merged after merging the following\r\nhttps://github.com/wso2/carbon-identity-framework/pull/1960\r\n\r\n#### Tests\r\n\r\nUnit tests            - Created unit test cases to check the SOAP utils function properly \r\nIntegration tests - Created Integration tests to automate the functionality of the SAML ECP profile\r\n","created_at":"2018-10-30T09:18:45Z","updated_at":"2018-11-14T07:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ad8aad77423497b240620ff4941edbc981a966b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mefarazath","id":5237653,"node_id":"MDQ6VXNlcjUyMzc2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5237653?v=4","gravatar_id":"","url":"https://api.github.com/users/mefarazath","html_url":"https://github.com/mefarazath","followers_url":"https://api.github.com/users/mefarazath/followers","following_url":"https://api.github.com/users/mefarazath/following{/other_user}","gists_url":"https://api.github.com/users/mefarazath/gists{/gist_id}","starred_url":"https://api.github.com/users/mefarazath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefarazath/subscriptions","organizations_url":"https://api.github.com/users/mefarazath/orgs","repos_url":"https://api.github.com/users/mefarazath/repos","events_url":"https://api.github.com/users/mefarazath/events{/privacy}","received_events_url":"https://api.github.com/users/mefarazath/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/196/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/99f29e716989ee369897866edb71dd249745b89d","head":{"label":"WinmaH:ecp-servlet","ref":"ecp-servlet","sha":"99f29e716989ee369897866edb71dd249745b89d","user":{"login":"WinmaH","id":25497216,"node_id":"MDQ6VXNlcjI1NDk3MjE2","avatar_url":"https://avatars1.githubusercontent.com/u/25497216?v=4","gravatar_id":"","url":"https://api.github.com/users/WinmaH","html_url":"https://github.com/WinmaH","followers_url":"https://api.github.com/users/WinmaH/followers","following_url":"https://api.github.com/users/WinmaH/following{/other_user}","gists_url":"https://api.github.com/users/WinmaH/gists{/gist_id}","starred_url":"https://api.github.com/users/WinmaH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinmaH/subscriptions","organizations_url":"https://api.github.com/users/WinmaH/orgs","repos_url":"https://api.github.com/users/WinmaH/repos","events_url":"https://api.github.com/users/WinmaH/events{/privacy}","received_events_url":"https://api.github.com/users/WinmaH/received_events","type":"User","site_admin":false},"repo":{"id":146742235,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3NDIyMzU=","name":"identity-inbound-auth-saml","full_name":"WinmaH/identity-inbound-auth-saml","private":false,"owner":{"login":"WinmaH","id":25497216,"node_id":"MDQ6VXNlcjI1NDk3MjE2","avatar_url":"https://avatars1.githubusercontent.com/u/25497216?v=4","gravatar_id":"","url":"https://api.github.com/users/WinmaH","html_url":"https://github.com/WinmaH","followers_url":"https://api.github.com/users/WinmaH/followers","following_url":"https://api.github.com/users/WinmaH/following{/other_user}","gists_url":"https://api.github.com/users/WinmaH/gists{/gist_id}","starred_url":"https://api.github.com/users/WinmaH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinmaH/subscriptions","organizations_url":"https://api.github.com/users/WinmaH/orgs","repos_url":"https://api.github.com/users/WinmaH/repos","events_url":"https://api.github.com/users/WinmaH/events{/privacy}","received_events_url":"https://api.github.com/users/WinmaH/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WinmaH/identity-inbound-auth-saml","description":null,"fork":true,"url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml","forks_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/forks","keys_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/teams","hooks_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/hooks","issue_events_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/issues/events{/number}","events_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/events","assignees_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/assignees{/user}","branches_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/branches{/branch}","tags_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/tags","blobs_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/languages","stargazers_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/stargazers","contributors_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/contributors","subscribers_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/subscribers","subscription_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/subscription","commits_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/contents/{+path}","compare_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/merges","archive_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/downloads","issues_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/issues{/number}","pulls_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/labels{/name}","releases_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/releases{/id}","deployments_url":"https://api.github.com/repos/WinmaH/identity-inbound-auth-saml/deployments","created_at":"2018-08-30T11:51:29Z","updated_at":"2018-08-30T11:51:32Z","pushed_at":"2018-11-12T17:17:15Z","git_url":"git://github.com/WinmaH/identity-inbound-auth-saml.git","ssh_url":"git@github.com:WinmaH/identity-inbound-auth-saml.git","clone_url":"https://github.com/WinmaH/identity-inbound-auth-saml.git","svn_url":"https://github.com/WinmaH/identity-inbound-auth-saml","homepage":null,"size":2362,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"ebae3f6b58e5ec7a208bc8eeb002ccb5728e4262","user":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52759151,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjc1OTE1MQ==","name":"identity-inbound-auth-saml","full_name":"wso2-extensions/identity-inbound-auth-saml","private":false,"owner":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml","forks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/deployments","created_at":"2016-02-29T02:49:36Z","updated_at":"2018-10-15T05:52:56Z","pushed_at":"2018-11-12T17:17:16Z","git_url":"git://github.com/wso2-extensions/identity-inbound-auth-saml.git","ssh_url":"git@github.com:wso2-extensions/identity-inbound-auth-saml.git","clone_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml.git","svn_url":"https://github.com/wso2-extensions/identity-inbound-auth-saml","homepage":null,"size":2257,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":64,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-saml/pull/196"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/196"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-saml/statuses/99f29e716989ee369897866edb71dd249745b89d"}},"author_association":"NONE"}}
{"actor":{"display_login":"hasinthaindrajee"}}