{"action":"created","issue":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/900","repository_url":"https://api.github.com/repos/smartdevicelink/sdl_android","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/900/labels{/name}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/900/comments","events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/900/events","html_url":"https://github.com/smartdevicelink/sdl_android/pull/900","id":368509064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjY5NjE3","number":900,"title":"Fix: make sure `MultiplexTcpTransport` creates a TCP socket over Wi-Fi network","user":{"login":"shoamano83","id":26382896,"node_id":"MDQ6VXNlcjI2MzgyODk2","avatar_url":"https://avatars1.githubusercontent.com/u/26382896?v=4","gravatar_id":"","url":"https://api.github.com/users/shoamano83","html_url":"https://github.com/shoamano83","followers_url":"https://api.github.com/users/shoamano83/followers","following_url":"https://api.github.com/users/shoamano83/following{/other_user}","gists_url":"https://api.github.com/users/shoamano83/gists{/gist_id}","starred_url":"https://api.github.com/users/shoamano83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoamano83/subscriptions","organizations_url":"https://api.github.com/users/shoamano83/orgs","repos_url":"https://api.github.com/users/shoamano83/repos","events_url":"https://api.github.com/users/shoamano83/events{/privacy}","received_events_url":"https://api.github.com/users/shoamano83/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-10T06:15:18Z","updated_at":"2018-10-11T17:06:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/900","html_url":"https://github.com/smartdevicelink/sdl_android/pull/900","diff_url":"https://github.com/smartdevicelink/sdl_android/pull/900.diff","patch_url":"https://github.com/smartdevicelink/sdl_android/pull/900.patch"},"body":"Fixes https://github.com/smartdevicelink/sdl_android/issues/899\r\n\r\nThis PR is **[ready]** for review.\r\n\r\n### Risk\r\nThis PR makes **[no]** API changes.\r\nThis PR only affects `MultiplexTcpTransport` class.\r\n\r\n### Testing Plan\r\nRepeat the steps mentioned in my comment https://github.com/smartdevicelink/sdl_android/issues/899#issuecomment-428445159 and make sure that the library establishes a TCP connection to Core.\r\n\r\n### Summary\r\nThis PR updates `MultiplexTcpTransport` to make sure it creates a `Socket` instance which is bound to Wi-Fi network.\r\n\r\n### Changelog\r\n##### Breaking Changes\r\n* None.\r\n\r\n##### Enhancements\r\n* None.\r\n\r\n##### Bug Fixes\r\n* fixes `MultiplexTcpTransport` opening a TCP socket via mobile network when the head unit has no Internet connectivity over Wi-Fi network and the phone is associated with cellular network.\r\n\r\n### Tasks Remaining:\r\n- None\r\n\r\n### CLA\r\n- [X] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)"},"comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/comments/429038146","html_url":"https://github.com/smartdevicelink/sdl_android/pull/900#issuecomment-429038146","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/900","id":429038146,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAzODE0Ng==","user":{"login":"joeygrover","id":6579474,"node_id":"MDQ6VXNlcjY1Nzk0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6579474?v=4","gravatar_id":"","url":"https://api.github.com/users/joeygrover","html_url":"https://github.com/joeygrover","followers_url":"https://api.github.com/users/joeygrover/followers","following_url":"https://api.github.com/users/joeygrover/following{/other_user}","gists_url":"https://api.github.com/users/joeygrover/gists{/gist_id}","starred_url":"https://api.github.com/users/joeygrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeygrover/subscriptions","organizations_url":"https://api.github.com/users/joeygrover/orgs","repos_url":"https://api.github.com/users/joeygrover/repos","events_url":"https://api.github.com/users/joeygrover/events{/privacy}","received_events_url":"https://api.github.com/users/joeygrover/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T17:06:14Z","updated_at":"2018-10-11T17:06:14Z","author_association":"MEMBER","body":"@shoamano83 you are right. I will have to revisit why we added that permission to the guide, because I can't think of where it is used off hand. That makes this PR easier to accept with the changes we agreed upon. "}}
{"actor":{"display_login":"joeygrover"}}