{"action":"closed","number":1467,"pull_request":{"url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467","id":237570496,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTcwNDk2","html_url":"https://github.com/harfbuzz/harfbuzz/pull/1467","diff_url":"https://github.com/harfbuzz/harfbuzz/pull/1467.diff","patch_url":"https://github.com/harfbuzz/harfbuzz/pull/1467.patch","issue_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/1467","number":1467,"state":"closed","locked":false,"title":"[CFF] minimized assert usage","user":{"login":"blueshade7","id":28452355,"node_id":"MDQ6VXNlcjI4NDUyMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/28452355?v=4","gravatar_id":"","url":"https://api.github.com/users/blueshade7","html_url":"https://github.com/blueshade7","followers_url":"https://api.github.com/users/blueshade7/followers","following_url":"https://api.github.com/users/blueshade7/following{/other_user}","gists_url":"https://api.github.com/users/blueshade7/gists{/gist_id}","starred_url":"https://api.github.com/users/blueshade7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueshade7/subscriptions","organizations_url":"https://api.github.com/users/blueshade7/orgs","repos_url":"https://api.github.com/users/blueshade7/repos","events_url":"https://api.github.com/users/blueshade7/events{/privacy}","received_events_url":"https://api.github.com/users/blueshade7/received_events","type":"User","site_admin":false},"body":"Minimized usage of `assert()` in CFF code, either by:\r\n\r\n(1) handle a failure condition as an error if it may ever happen with bad/unexpected input\r\n(2) removed, if a failure shouldn't happen and cannot be easily handled as an error\r\n(3) leave assert, if a failure shouldn't happen","created_at":"2018-12-11T07:02:11Z","updated_at":"2018-12-11T20:20:21Z","closed_at":"2018-12-11T20:20:21Z","merged_at":"2018-12-11T20:20:21Z","merge_commit_sha":"333586245cb37668c8a29af17920474c09667f4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467/commits","review_comments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467/comments","review_comment_url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/1467/comments","statuses_url":"https://api.github.com/repos/harfbuzz/harfbuzz/statuses/b8364788dd21b38104646d0cebbb109d26e81e49","head":{"label":"harfbuzz:cff-no-assert","ref":"cff-no-assert","sha":"b8364788dd21b38104646d0cebbb109d26e81e49","user":{"login":"harfbuzz","id":33817416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE3NDE2","avatar_url":"https://avatars1.githubusercontent.com/u/33817416?v=4","gravatar_id":"","url":"https://api.github.com/users/harfbuzz","html_url":"https://github.com/harfbuzz","followers_url":"https://api.github.com/users/harfbuzz/followers","following_url":"https://api.github.com/users/harfbuzz/following{/other_user}","gists_url":"https://api.github.com/users/harfbuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/harfbuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfbuzz/subscriptions","organizations_url":"https://api.github.com/users/harfbuzz/orgs","repos_url":"https://api.github.com/users/harfbuzz/repos","events_url":"https://api.github.com/users/harfbuzz/events{/privacy}","received_events_url":"https://api.github.com/users/harfbuzz/received_events","type":"Organization","site_admin":false},"repo":{"id":5050525,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUwNTI1","name":"harfbuzz","full_name":"harfbuzz/harfbuzz","private":false,"owner":{"login":"harfbuzz","id":33817416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE3NDE2","avatar_url":"https://avatars1.githubusercontent.com/u/33817416?v=4","gravatar_id":"","url":"https://api.github.com/users/harfbuzz","html_url":"https://github.com/harfbuzz","followers_url":"https://api.github.com/users/harfbuzz/followers","following_url":"https://api.github.com/users/harfbuzz/following{/other_user}","gists_url":"https://api.github.com/users/harfbuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/harfbuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfbuzz/subscriptions","organizations_url":"https://api.github.com/users/harfbuzz/orgs","repos_url":"https://api.github.com/users/harfbuzz/repos","events_url":"https://api.github.com/users/harfbuzz/events{/privacy}","received_events_url":"https://api.github.com/users/harfbuzz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harfbuzz/harfbuzz","description":"HarfBuzz text shaping engine","fork":false,"url":"https://api.github.com/repos/harfbuzz/harfbuzz","forks_url":"https://api.github.com/repos/harfbuzz/harfbuzz/forks","keys_url":"https://api.github.com/repos/harfbuzz/harfbuzz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harfbuzz/harfbuzz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harfbuzz/harfbuzz/teams","hooks_url":"https://api.github.com/repos/harfbuzz/harfbuzz/hooks","issue_events_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/events{/number}","events_url":"https://api.github.com/repos/harfbuzz/harfbuzz/events","assignees_url":"https://api.github.com/repos/harfbuzz/harfbuzz/assignees{/user}","branches_url":"https://api.github.com/repos/harfbuzz/harfbuzz/branches{/branch}","tags_url":"https://api.github.com/repos/harfbuzz/harfbuzz/tags","blobs_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/refs{/sha}","trees_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harfbuzz/harfbuzz/statuses/{sha}","languages_url":"https://api.github.com/repos/harfbuzz/harfbuzz/languages","stargazers_url":"https://api.github.com/repos/harfbuzz/harfbuzz/stargazers","contributors_url":"https://api.github.com/repos/harfbuzz/harfbuzz/contributors","subscribers_url":"https://api.github.com/repos/harfbuzz/harfbuzz/subscribers","subscription_url":"https://api.github.com/repos/harfbuzz/harfbuzz/subscription","commits_url":"https://api.github.com/repos/harfbuzz/harfbuzz/commits{/sha}","git_commits_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/commits{/sha}","comments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/comments{/number}","issue_comment_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/comments{/number}","contents_url":"https://api.github.com/repos/harfbuzz/harfbuzz/contents/{+path}","compare_url":"https://api.github.com/repos/harfbuzz/harfbuzz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harfbuzz/harfbuzz/merges","archive_url":"https://api.github.com/repos/harfbuzz/harfbuzz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harfbuzz/harfbuzz/downloads","issues_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues{/number}","pulls_url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls{/number}","milestones_url":"https://api.github.com/repos/harfbuzz/harfbuzz/milestones{/number}","notifications_url":"https://api.github.com/repos/harfbuzz/harfbuzz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harfbuzz/harfbuzz/labels{/name}","releases_url":"https://api.github.com/repos/harfbuzz/harfbuzz/releases{/id}","deployments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/deployments","created_at":"2012-07-14T19:50:26Z","updated_at":"2018-12-11T19:32:57Z","pushed_at":"2018-12-11T20:20:21Z","git_url":"git://github.com/harfbuzz/harfbuzz.git","ssh_url":"git@github.com:harfbuzz/harfbuzz.git","clone_url":"https://github.com/harfbuzz/harfbuzz.git","svn_url":"https://github.com/harfbuzz/harfbuzz","homepage":"http://harfbuzz.org/","size":34177,"stargazers_count":838,"watchers_count":838,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":242,"open_issues":101,"watchers":838,"default_branch":"master"}},"base":{"label":"harfbuzz:master","ref":"master","sha":"b225593d6baf3455e1ac951efc0df5015fdf7c69","user":{"login":"harfbuzz","id":33817416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE3NDE2","avatar_url":"https://avatars1.githubusercontent.com/u/33817416?v=4","gravatar_id":"","url":"https://api.github.com/users/harfbuzz","html_url":"https://github.com/harfbuzz","followers_url":"https://api.github.com/users/harfbuzz/followers","following_url":"https://api.github.com/users/harfbuzz/following{/other_user}","gists_url":"https://api.github.com/users/harfbuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/harfbuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfbuzz/subscriptions","organizations_url":"https://api.github.com/users/harfbuzz/orgs","repos_url":"https://api.github.com/users/harfbuzz/repos","events_url":"https://api.github.com/users/harfbuzz/events{/privacy}","received_events_url":"https://api.github.com/users/harfbuzz/received_events","type":"Organization","site_admin":false},"repo":{"id":5050525,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUwNTI1","name":"harfbuzz","full_name":"harfbuzz/harfbuzz","private":false,"owner":{"login":"harfbuzz","id":33817416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE3NDE2","avatar_url":"https://avatars1.githubusercontent.com/u/33817416?v=4","gravatar_id":"","url":"https://api.github.com/users/harfbuzz","html_url":"https://github.com/harfbuzz","followers_url":"https://api.github.com/users/harfbuzz/followers","following_url":"https://api.github.com/users/harfbuzz/following{/other_user}","gists_url":"https://api.github.com/users/harfbuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/harfbuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfbuzz/subscriptions","organizations_url":"https://api.github.com/users/harfbuzz/orgs","repos_url":"https://api.github.com/users/harfbuzz/repos","events_url":"https://api.github.com/users/harfbuzz/events{/privacy}","received_events_url":"https://api.github.com/users/harfbuzz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harfbuzz/harfbuzz","description":"HarfBuzz text shaping engine","fork":false,"url":"https://api.github.com/repos/harfbuzz/harfbuzz","forks_url":"https://api.github.com/repos/harfbuzz/harfbuzz/forks","keys_url":"https://api.github.com/repos/harfbuzz/harfbuzz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harfbuzz/harfbuzz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harfbuzz/harfbuzz/teams","hooks_url":"https://api.github.com/repos/harfbuzz/harfbuzz/hooks","issue_events_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/events{/number}","events_url":"https://api.github.com/repos/harfbuzz/harfbuzz/events","assignees_url":"https://api.github.com/repos/harfbuzz/harfbuzz/assignees{/user}","branches_url":"https://api.github.com/repos/harfbuzz/harfbuzz/branches{/branch}","tags_url":"https://api.github.com/repos/harfbuzz/harfbuzz/tags","blobs_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/refs{/sha}","trees_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harfbuzz/harfbuzz/statuses/{sha}","languages_url":"https://api.github.com/repos/harfbuzz/harfbuzz/languages","stargazers_url":"https://api.github.com/repos/harfbuzz/harfbuzz/stargazers","contributors_url":"https://api.github.com/repos/harfbuzz/harfbuzz/contributors","subscribers_url":"https://api.github.com/repos/harfbuzz/harfbuzz/subscribers","subscription_url":"https://api.github.com/repos/harfbuzz/harfbuzz/subscription","commits_url":"https://api.github.com/repos/harfbuzz/harfbuzz/commits{/sha}","git_commits_url":"https://api.github.com/repos/harfbuzz/harfbuzz/git/commits{/sha}","comments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/comments{/number}","issue_comment_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/comments{/number}","contents_url":"https://api.github.com/repos/harfbuzz/harfbuzz/contents/{+path}","compare_url":"https://api.github.com/repos/harfbuzz/harfbuzz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harfbuzz/harfbuzz/merges","archive_url":"https://api.github.com/repos/harfbuzz/harfbuzz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harfbuzz/harfbuzz/downloads","issues_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues{/number}","pulls_url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls{/number}","milestones_url":"https://api.github.com/repos/harfbuzz/harfbuzz/milestones{/number}","notifications_url":"https://api.github.com/repos/harfbuzz/harfbuzz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harfbuzz/harfbuzz/labels{/name}","releases_url":"https://api.github.com/repos/harfbuzz/harfbuzz/releases{/id}","deployments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/deployments","created_at":"2012-07-14T19:50:26Z","updated_at":"2018-12-11T19:32:57Z","pushed_at":"2018-12-11T20:20:21Z","git_url":"git://github.com/harfbuzz/harfbuzz.git","ssh_url":"git@github.com:harfbuzz/harfbuzz.git","clone_url":"https://github.com/harfbuzz/harfbuzz.git","svn_url":"https://github.com/harfbuzz/harfbuzz","homepage":"http://harfbuzz.org/","size":34177,"stargazers_count":838,"watchers_count":838,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":242,"open_issues":101,"watchers":838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467"},"html":{"href":"https://github.com/harfbuzz/harfbuzz/pull/1467"},"issue":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/1467"},"comments":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/1467/comments"},"review_comments":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467/comments"},"review_comment":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/1467/commits"},"statuses":{"href":"https://api.github.com/repos/harfbuzz/harfbuzz/statuses/b8364788dd21b38104646d0cebbb109d26e81e49"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"behdad","id":142891,"node_id":"MDQ6VXNlcjE0Mjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/142891?v=4","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":41,"deletions":16,"changed_files":6}}
{"actor":{"display_login":"behdad"}}