{"action":"closed","number":11073,"pull_request":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/11073","id":114434708,"html_url":"https://github.com/ionic-team/ionic/pull/11073","diff_url":"https://github.com/ionic-team/ionic/pull/11073.diff","patch_url":"https://github.com/ionic-team/ionic/pull/11073.patch","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/11073","number":11073,"state":"closed","locked":false,"title":"fix(alert): change alert content max-height","user":{"login":"tagmat","id":5375462,"avatar_url":"https://avatars1.githubusercontent.com/u/5375462?v=4","gravatar_id":"","url":"https://api.github.com/users/tagmat","html_url":"https://github.com/tagmat","followers_url":"https://api.github.com/users/tagmat/followers","following_url":"https://api.github.com/users/tagmat/following{/other_user}","gists_url":"https://api.github.com/users/tagmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tagmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagmat/subscriptions","organizations_url":"https://api.github.com/users/tagmat/orgs","repos_url":"https://api.github.com/users/tagmat/repos","events_url":"https://api.github.com/users/tagmat/events{/privacy}","received_events_url":"https://api.github.com/users/tagmat/received_events","type":"User","site_admin":false},"body":"Alert dialog with some content pushes bottom buttons to out of screen. max-height should be set to a lower value to make sure the buttons stay visible as the content is scrollable.\r\n\r\n**Ionic Version**: 3.x\r\n\r\n**Fixes**: #6326","created_at":"2017-04-05T17:48:22Z","updated_at":"2018-03-12T21:40:25Z","closed_at":"2018-03-12T21:40:25Z","merged_at":null,"merge_commit_sha":"f630486fedda74ed03d484c9854ca5a51faf728f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":864910704,"url":"https://api.github.com/repos/ionic-team/ionic/labels/closed%20by%20v4","name":"closed by v4","color":"31d6aa","default":false},{"id":609070198,"url":"https://api.github.com/repos/ionic-team/ionic/labels/fix","name":"fix","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ionic-team/ionic/pulls/11073/commits","review_comments_url":"https://api.github.com/repos/ionic-team/ionic/pulls/11073/comments","review_comment_url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/11073/comments","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/595a3467b2251f450975eae8e3188f821e52a9bd","head":{"label":"tagmat:tagmat","ref":"tagmat","sha":"595a3467b2251f450975eae8e3188f821e52a9bd","user":{"login":"tagmat","id":5375462,"avatar_url":"https://avatars1.githubusercontent.com/u/5375462?v=4","gravatar_id":"","url":"https://api.github.com/users/tagmat","html_url":"https://github.com/tagmat","followers_url":"https://api.github.com/users/tagmat/followers","following_url":"https://api.github.com/users/tagmat/following{/other_user}","gists_url":"https://api.github.com/users/tagmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tagmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagmat/subscriptions","organizations_url":"https://api.github.com/users/tagmat/orgs","repos_url":"https://api.github.com/users/tagmat/repos","events_url":"https://api.github.com/users/tagmat/events{/privacy}","received_events_url":"https://api.github.com/users/tagmat/received_events","type":"User","site_admin":false},"repo":{"id":87337674,"name":"ionic","full_name":"tagmat/ionic","owner":{"login":"tagmat","id":5375462,"avatar_url":"https://avatars1.githubusercontent.com/u/5375462?v=4","gravatar_id":"","url":"https://api.github.com/users/tagmat","html_url":"https://github.com/tagmat","followers_url":"https://api.github.com/users/tagmat/followers","following_url":"https://api.github.com/users/tagmat/following{/other_user}","gists_url":"https://api.github.com/users/tagmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tagmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagmat/subscriptions","organizations_url":"https://api.github.com/users/tagmat/orgs","repos_url":"https://api.github.com/users/tagmat/repos","events_url":"https://api.github.com/users/tagmat/events{/privacy}","received_events_url":"https://api.github.com/users/tagmat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tagmat/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/tagmat/ionic","forks_url":"https://api.github.com/repos/tagmat/ionic/forks","keys_url":"https://api.github.com/repos/tagmat/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tagmat/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tagmat/ionic/teams","hooks_url":"https://api.github.com/repos/tagmat/ionic/hooks","issue_events_url":"https://api.github.com/repos/tagmat/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/tagmat/ionic/events","assignees_url":"https://api.github.com/repos/tagmat/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/tagmat/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/tagmat/ionic/tags","blobs_url":"https://api.github.com/repos/tagmat/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tagmat/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tagmat/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tagmat/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tagmat/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/tagmat/ionic/languages","stargazers_url":"https://api.github.com/repos/tagmat/ionic/stargazers","contributors_url":"https://api.github.com/repos/tagmat/ionic/contributors","subscribers_url":"https://api.github.com/repos/tagmat/ionic/subscribers","subscription_url":"https://api.github.com/repos/tagmat/ionic/subscription","commits_url":"https://api.github.com/repos/tagmat/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tagmat/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tagmat/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tagmat/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tagmat/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/tagmat/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tagmat/ionic/merges","archive_url":"https://api.github.com/repos/tagmat/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tagmat/ionic/downloads","issues_url":"https://api.github.com/repos/tagmat/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/tagmat/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/tagmat/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/tagmat/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tagmat/ionic/labels{/name}","releases_url":"https://api.github.com/repos/tagmat/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/tagmat/ionic/deployments","created_at":"2017-04-05T17:29:01Z","updated_at":"2017-04-05T17:29:08Z","pushed_at":"2017-04-05T17:42:17Z","git_url":"git://github.com/tagmat/ionic.git","ssh_url":"git@github.com:tagmat/ionic.git","clone_url":"https://github.com/tagmat/ionic.git","svn_url":"https://github.com/tagmat/ionic","homepage":"http://ionicframework.com/","size":71176,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ionic-team:master","ref":"master","sha":"6e2a9c936de3231e149ebd9516b4036ce2149503","user":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"name":"ionic","full_name":"ionic-team/ionic","owner":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ionic-team/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/ionic-team/ionic","forks_url":"https://api.github.com/repos/ionic-team/ionic/forks","keys_url":"https://api.github.com/repos/ionic-team/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/ionic/teams","hooks_url":"https://api.github.com/repos/ionic-team/ionic/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/ionic/events","assignees_url":"https://api.github.com/repos/ionic-team/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/ionic/tags","blobs_url":"https://api.github.com/repos/ionic-team/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/ionic/languages","stargazers_url":"https://api.github.com/repos/ionic-team/ionic/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/ionic/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/ionic/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/ionic/subscription","commits_url":"https://api.github.com/repos/ionic-team/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/ionic/merges","archive_url":"https://api.github.com/repos/ionic-team/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/ionic/downloads","issues_url":"https://api.github.com/repos/ionic-team/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/ionic/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2018-03-12T21:36:49Z","pushed_at":"2018-03-12T20:02:36Z","git_url":"git://github.com/ionic-team/ionic.git","ssh_url":"git@github.com:ionic-team/ionic.git","clone_url":"https://github.com/ionic-team/ionic.git","svn_url":"https://github.com/ionic-team/ionic","homepage":"https://ionicframework.com/","size":82822,"stargazers_count":33538,"watchers_count":33538,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10500,"mirror_url":null,"archived":false,"open_issues_count":1163,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10500,"open_issues":1163,"watchers":33538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/11073"},"html":{"href":"https://github.com/ionic-team/ionic/pull/11073"},"issue":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/11073"},"comments":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/11073/comments"},"review_comments":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/11073/comments"},"review_comment":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/11073/commits"},"statuses":{"href":"https://api.github.com/repos/ionic-team/ionic/statuses/595a3467b2251f450975eae8e3188f821e52a9bd"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Ionitron"}}