{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/192849997","pull_request_review_id":125705391,"id":192849997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg0OTk5Nw==","diff_hunk":"@@ -631,6 +631,12 @@ func resourceAwsLbTargetGroupCustomizeDiff(diff *schema.ResourceDiff, v interfac\n \t}\n \n \tif protocol == \"TCP\" {\n+\t\tif diff.HasChange(\"health_check.0.protocol\") {\n+\t\t\told, new := diff.GetChange(\"health_check.0.protocol\")\n+\t\t\treturn fmt.Errorf(\"Health check protocol cannot be updated from %d to %d for TCP based Target Group %s\"+","path":"aws/resource_aws_lb_target_group.go","position":6,"original_position":6,"commit_id":"79178bef8828ee7631d22c9b0d92badf942c2db1","original_commit_id":"79178bef8828ee7631d22c9b0d92badf942c2db1","user":{"login":"iancward","id":18687001,"node_id":"MDQ6VXNlcjE4Njg3MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18687001?v=4","gravatar_id":"","url":"https://api.github.com/users/iancward","html_url":"https://github.com/iancward","followers_url":"https://api.github.com/users/iancward/followers","following_url":"https://api.github.com/users/iancward/following{/other_user}","gists_url":"https://api.github.com/users/iancward/gists{/gist_id}","starred_url":"https://api.github.com/users/iancward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancward/subscriptions","organizations_url":"https://api.github.com/users/iancward/orgs","repos_url":"https://api.github.com/users/iancward/repos","events_url":"https://api.github.com/users/iancward/events{/privacy}","received_events_url":"https://api.github.com/users/iancward/received_events","type":"User","site_admin":false},"body":"Ah, it looks like I can do something like this: https://github.com/terraform-providers/terraform-provider-aws/blob/37860355dc6210a987819c7d79a699f2b56e15d8/aws/resource_aws_api_gateway_authorizer.go#L263-L265\r\n\r\nI guess the only thing to consider is that this kind of change will destroy and re-recreate the load balancer target group, which the end-user might not expect. I assume we trust the end-user to do a `plan` first and notice the change?","created_at":"2018-06-04T19:11:22Z","updated_at":"2018-06-04T19:11:22Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568#discussion_r192849997","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/192849997"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568#discussion_r192849997"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568"}},"in_reply_to_id":189140975},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568","id":188789591,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4Nzg5NTkx","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/4568","number":4568,"state":"open","locked":false,"title":"r/lb_target_group health chk proto chg req taint","user":{"login":"iancward","id":18687001,"node_id":"MDQ6VXNlcjE4Njg3MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18687001?v=4","gravatar_id":"","url":"https://api.github.com/users/iancward","html_url":"https://github.com/iancward","followers_url":"https://api.github.com/users/iancward/followers","following_url":"https://api.github.com/users/iancward/following{/other_user}","gists_url":"https://api.github.com/users/iancward/gists{/gist_id}","starred_url":"https://api.github.com/users/iancward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancward/subscriptions","organizations_url":"https://api.github.com/users/iancward/orgs","repos_url":"https://api.github.com/users/iancward/repos","events_url":"https://api.github.com/users/iancward/events{/privacy}","received_events_url":"https://api.github.com/users/iancward/received_events","type":"User","site_admin":false},"body":"Notify users of TCP lb target groups that changes to health check protocol\r\nrequire the user to taint the resource and let terraform re-create it.\r\nThis commit Fixes #4150.","created_at":"2018-05-17T16:12:42Z","updated_at":"2018-06-04T19:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65f441c77ef8ff2f0e6d06089f00ac420f8ceff0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316239,"node_id":"MDU6TGFiZWw2MjAzMTYyMzk=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/bug","name":"bug","color":"f7c6c7","default":true},{"id":801363986,"node_id":"MDU6TGFiZWw4MDEzNjM5ODY=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/elbv2","name":"service/elbv2","color":"bfd4f2","default":false},{"id":737832219,"node_id":"MDU6TGFiZWw3Mzc4MzIyMTk=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XS","name":"size/XS","color":"ffffff","default":false},{"id":623647943,"node_id":"MDU6TGFiZWw2MjM2NDc5NDM=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/waiting-response","name":"waiting-response","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/4568/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/79178bef8828ee7631d22c9b0d92badf942c2db1","head":{"label":"iancward:GH-4150","ref":"GH-4150","sha":"79178bef8828ee7631d22c9b0d92badf942c2db1","user":{"login":"iancward","id":18687001,"node_id":"MDQ6VXNlcjE4Njg3MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18687001?v=4","gravatar_id":"","url":"https://api.github.com/users/iancward","html_url":"https://github.com/iancward","followers_url":"https://api.github.com/users/iancward/followers","following_url":"https://api.github.com/users/iancward/following{/other_user}","gists_url":"https://api.github.com/users/iancward/gists{/gist_id}","starred_url":"https://api.github.com/users/iancward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancward/subscriptions","organizations_url":"https://api.github.com/users/iancward/orgs","repos_url":"https://api.github.com/users/iancward/repos","events_url":"https://api.github.com/users/iancward/events{/privacy}","received_events_url":"https://api.github.com/users/iancward/received_events","type":"User","site_admin":false},"repo":{"id":129301378,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMDEzNzg=","name":"terraform-provider-aws","full_name":"iancward/terraform-provider-aws","owner":{"login":"iancward","id":18687001,"node_id":"MDQ6VXNlcjE4Njg3MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18687001?v=4","gravatar_id":"","url":"https://api.github.com/users/iancward","html_url":"https://github.com/iancward","followers_url":"https://api.github.com/users/iancward/followers","following_url":"https://api.github.com/users/iancward/following{/other_user}","gists_url":"https://api.github.com/users/iancward/gists{/gist_id}","starred_url":"https://api.github.com/users/iancward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancward/subscriptions","organizations_url":"https://api.github.com/users/iancward/orgs","repos_url":"https://api.github.com/users/iancward/repos","events_url":"https://api.github.com/users/iancward/events{/privacy}","received_events_url":"https://api.github.com/users/iancward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iancward/terraform-provider-aws","description":"Terraform AWS provider","fork":true,"url":"https://api.github.com/repos/iancward/terraform-provider-aws","forks_url":"https://api.github.com/repos/iancward/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/iancward/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iancward/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iancward/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/iancward/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/iancward/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/iancward/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/iancward/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/iancward/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/iancward/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/iancward/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iancward/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iancward/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/iancward/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iancward/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/iancward/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/iancward/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/iancward/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/iancward/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/iancward/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/iancward/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/iancward/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/iancward/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/iancward/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/iancward/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/iancward/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iancward/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/iancward/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iancward/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/iancward/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/iancward/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/iancward/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/iancward/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iancward/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/iancward/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/iancward/terraform-provider-aws/deployments","created_at":"2018-04-12T19:27:51Z","updated_at":"2018-05-17T16:22:48Z","pushed_at":"2018-05-17T16:26:58Z","git_url":"git://github.com/iancward/terraform-provider-aws.git","ssh_url":"git@github.com:iancward/terraform-provider-aws.git","clone_url":"https://github.com/iancward/terraform-provider-aws.git","svn_url":"https://github.com/iancward/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":38522,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"063cb7c30e69f53a84ddea38ffa62cd6d78393bc","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NDYxNQ==","name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-06-04T17:35:14Z","pushed_at":"2018-06-04T18:25:29Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":40340,"stargazers_count":1192,"watchers_count":1192,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1041,"mirror_url":null,"archived":false,"open_issues_count":1787,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1041,"open_issues":1787,"watchers":1192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/4568"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/4568"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/4568/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/4568/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/79178bef8828ee7631d22c9b0d92badf942c2db1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"iancward"}}