{"action":"created","comment":{"url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/comments/183109530","pull_request_review_id":114050741,"id":183109530,"diff_hunk":"@@ -24,25 +25,41 @@ const (\n )\n \n // Set is the basic structure for storing metrics.\n-type Set map[string]interface{}\n+type Set struct {\n+\t// The storer is required for deltas and rates, but forces us overriding marshaller and makes unmarshaller","path":"metric/metrics.go","position":14,"original_position":14,"commit_id":"bc22c8ac1213250923f5e1634c4065fa15a50bb4","original_commit_id":"bc22c8ac1213250923f5e1634c4065fa15a50bb4","user":{"login":"smoya","id":1083296,"avatar_url":"https://avatars1.githubusercontent.com/u/1083296?v=4","gravatar_id":"","url":"https://api.github.com/users/smoya","html_url":"https://github.com/smoya","followers_url":"https://api.github.com/users/smoya/followers","following_url":"https://api.github.com/users/smoya/following{/other_user}","gists_url":"https://api.github.com/users/smoya/gists{/gist_id}","starred_url":"https://api.github.com/users/smoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoya/subscriptions","organizations_url":"https://api.github.com/users/smoya/orgs","repos_url":"https://api.github.com/users/smoya/repos","events_url":"https://api.github.com/users/smoya/events{/privacy}","received_events_url":"https://api.github.com/users/smoya/received_events","type":"User","site_admin":false},"body":"I don't get the point about `makes unmarshaller impossible.`. The same way we implement the `MarshalJSON` it could implement `UnmarshalJSON`. I'm missing something?","created_at":"2018-04-20T16:50:22Z","updated_at":"2018-04-20T16:50:22Z","html_url":"https://github.com/newrelic/infra-integrations-sdk/pull/66#discussion_r183109530","pull_request_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/comments/183109530"},"html":{"href":"https://github.com/newrelic/infra-integrations-sdk/pull/66#discussion_r183109530"},"pull_request":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66","id":183087019,"html_url":"https://github.com/newrelic/infra-integrations-sdk/pull/66","diff_url":"https://github.com/newrelic/infra-integrations-sdk/pull/66.diff","patch_url":"https://github.com/newrelic/infra-integrations-sdk/pull/66.patch","issue_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/66","number":66,"state":"open","locked":false,"title":"Removed global cache","user":{"login":"mariomac","id":939550,"avatar_url":"https://avatars3.githubusercontent.com/u/939550?v=4","gravatar_id":"","url":"https://api.github.com/users/mariomac","html_url":"https://github.com/mariomac","followers_url":"https://api.github.com/users/mariomac/followers","following_url":"https://api.github.com/users/mariomac/following{/other_user}","gists_url":"https://api.github.com/users/mariomac/gists{/gist_id}","starred_url":"https://api.github.com/users/mariomac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariomac/subscriptions","organizations_url":"https://api.github.com/users/mariomac/orgs","repos_url":"https://api.github.com/users/mariomac/repos","events_url":"https://api.github.com/users/mariomac/events{/privacy}","received_events_url":"https://api.github.com/users/mariomac/received_events","type":"User","site_admin":false},"body":"#### Description of the changes\r\n\r\nThis implies that the MetricsSet has to have now its own instance\r\nof the cache. In consequence:\r\n\r\n- the type metrics.Set is now a struct, now it has to be returned as a pointer.\r\n- the type metrics.Set overrides now the MarshalJSON function to only marshall\r\n  the actual metrics, according to the v2 protocol.\r\n\r\n#### PR Review Checklist\r\n### Author\r\n\r\n- [ ] add a risk label after carefully considering the \"blast radius\" of your changes\r\n- [ ] describe the _intent_ of your changes in the description. don't just rewrite your code in prose\r\n- [ ] assign at least one reviewer\r\n\r\n### Reviewer\r\n\r\n- [ ] review code for readability\r\n- [ ] verify that high risk behavior changes are well tested\r\n- [ ] check license for any new external dependency\r\n- [ ] ask questions about anything that isn't clear and obvious\r\n- [ ] approve the PR when you consider it's good to merge\r\n","created_at":"2018-04-20T14:54:48Z","updated_at":"2018-04-20T16:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4495b756cab30baf0d866d20c4c82196453d8d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"areina","id":10852,"avatar_url":"https://avatars1.githubusercontent.com/u/10852?v=4","gravatar_id":"","url":"https://api.github.com/users/areina","html_url":"https://github.com/areina","followers_url":"https://api.github.com/users/areina/followers","following_url":"https://api.github.com/users/areina/following{/other_user}","gists_url":"https://api.github.com/users/areina/gists{/gist_id}","starred_url":"https://api.github.com/users/areina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/areina/subscriptions","organizations_url":"https://api.github.com/users/areina/orgs","repos_url":"https://api.github.com/users/areina/repos","events_url":"https://api.github.com/users/areina/events{/privacy}","received_events_url":"https://api.github.com/users/areina/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":610576101,"url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/labels/risk:low","name":"risk:low","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66/commits","review_comments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66/comments","review_comment_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/66/comments","statuses_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/statuses/bc22c8ac1213250923f5e1634c4065fa15a50bb4","head":{"label":"newrelic:mmacias/rmcache","ref":"mmacias/rmcache","sha":"bc22c8ac1213250923f5e1634c4065fa15a50bb4","user":{"login":"newrelic","id":31739,"avatar_url":"https://avatars0.githubusercontent.com/u/31739?v=4","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"repo":{"id":91324707,"name":"infra-integrations-sdk","full_name":"newrelic/infra-integrations-sdk","owner":{"login":"newrelic","id":31739,"avatar_url":"https://avatars0.githubusercontent.com/u/31739?v=4","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newrelic/infra-integrations-sdk","description":"New Relic Infrastructure Integrations SDK","fork":false,"url":"https://api.github.com/repos/newrelic/infra-integrations-sdk","forks_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/forks","keys_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/teams","hooks_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/hooks","issue_events_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/events","assignees_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/tags","blobs_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/languages","stargazers_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/stargazers","contributors_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/contributors","subscribers_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/subscribers","subscription_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/subscription","commits_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/merges","archive_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/downloads","issues_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/labels{/name}","releases_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/deployments","created_at":"2017-05-15T10:19:47Z","updated_at":"2018-04-20T14:41:54Z","pushed_at":"2018-04-20T15:57:18Z","git_url":"git://github.com/newrelic/infra-integrations-sdk.git","ssh_url":"git@github.com:newrelic/infra-integrations-sdk.git","clone_url":"https://github.com/newrelic/infra-integrations-sdk.git","svn_url":"https://github.com/newrelic/infra-integrations-sdk","homepage":"","size":972,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":3,"watchers":14,"default_branch":"master"}},"base":{"label":"newrelic:master","ref":"master","sha":"f0f51a20d18c87df93948bbdddfc076735473c3d","user":{"login":"newrelic","id":31739,"avatar_url":"https://avatars0.githubusercontent.com/u/31739?v=4","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"repo":{"id":91324707,"name":"infra-integrations-sdk","full_name":"newrelic/infra-integrations-sdk","owner":{"login":"newrelic","id":31739,"avatar_url":"https://avatars0.githubusercontent.com/u/31739?v=4","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newrelic/infra-integrations-sdk","description":"New Relic Infrastructure Integrations SDK","fork":false,"url":"https://api.github.com/repos/newrelic/infra-integrations-sdk","forks_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/forks","keys_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/teams","hooks_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/hooks","issue_events_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/events","assignees_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/tags","blobs_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/languages","stargazers_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/stargazers","contributors_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/contributors","subscribers_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/subscribers","subscription_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/subscription","commits_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/merges","archive_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/downloads","issues_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/labels{/name}","releases_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/newrelic/infra-integrations-sdk/deployments","created_at":"2017-05-15T10:19:47Z","updated_at":"2018-04-20T14:41:54Z","pushed_at":"2018-04-20T15:57:18Z","git_url":"git://github.com/newrelic/infra-integrations-sdk.git","ssh_url":"git@github.com:newrelic/infra-integrations-sdk.git","clone_url":"https://github.com/newrelic/infra-integrations-sdk.git","svn_url":"https://github.com/newrelic/infra-integrations-sdk","homepage":"","size":972,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66"},"html":{"href":"https://github.com/newrelic/infra-integrations-sdk/pull/66"},"issue":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/66"},"comments":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/newrelic/infra-integrations-sdk/statuses/bc22c8ac1213250923f5e1634c4065fa15a50bb4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smoya"}}