{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/192426039","pull_request_review_id":125205889,"id":192426039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQyNjAzOQ==","diff_hunk":"@@ -0,0 +1,26 @@\n+# Overview\n+\n+Purpose of docker container, which is to be generated from this folder, is to test, if Iroha system can build, when all dependencies are installed into custom, separated directories.\n+\n+# How to build:\n+1. Build docker image:\n+    - ```cd $IROHA_ROOT/docker/dependencies```\n+    - ```docker build --build-arg PARALLELISM=$DESIRED_THREADS_AMOUNT -t iroha-dpnd .```\n+    - Now, you have container named \"iroha-dpnd\", containing all necessary dependencies in /opt/dependencies folder\n+2. Get into the container:\n+    - for the first time:\n+        - run image: ```docker run -dit iroha-dpnd```","path":"docker/dependencies/README.md","position":12,"original_position":12,"commit_id":"b78e16ceb54b445ff64ebd92229be61bec489049","original_commit_id":"b78e16ceb54b445ff64ebd92229be61bec489049","user":{"login":"Akvinikym","id":16174976,"node_id":"MDQ6VXNlcjE2MTc0OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/16174976?v=4","gravatar_id":"","url":"https://api.github.com/users/Akvinikym","html_url":"https://github.com/Akvinikym","followers_url":"https://api.github.com/users/Akvinikym/followers","following_url":"https://api.github.com/users/Akvinikym/following{/other_user}","gists_url":"https://api.github.com/users/Akvinikym/gists{/gist_id}","starred_url":"https://api.github.com/users/Akvinikym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akvinikym/subscriptions","organizations_url":"https://api.github.com/users/Akvinikym/orgs","repos_url":"https://api.github.com/users/Akvinikym/repos","events_url":"https://api.github.com/users/Akvinikym/events{/privacy}","received_events_url":"https://api.github.com/users/Akvinikym/received_events","type":"User","site_admin":false},"body":"I thought, that reusing the container without rebuilding it for test each time is useful. Dependencies rarely change, as I understand, so maybe just pulling new version of Iroha and then building it is enough? ","created_at":"2018-06-01T15:08:26Z","updated_at":"2018-06-01T15:08:27Z","html_url":"https://github.com/hyperledger/iroha/pull/1404#discussion_r192426039","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1404","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/192426039"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1404#discussion_r192426039"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1404"}},"in_reply_to_id":192401892},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1404","id":192013869,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDEzODY5","html_url":"https://github.com/hyperledger/iroha/pull/1404","diff_url":"https://github.com/hyperledger/iroha/pull/1404.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1404.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1404","number":1404,"state":"open","locked":false,"title":"Fix/dockerfile with separate dependencies","user":{"login":"Akvinikym","id":16174976,"node_id":"MDQ6VXNlcjE2MTc0OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/16174976?v=4","gravatar_id":"","url":"https://api.github.com/users/Akvinikym","html_url":"https://github.com/Akvinikym","followers_url":"https://api.github.com/users/Akvinikym/followers","following_url":"https://api.github.com/users/Akvinikym/following{/other_user}","gists_url":"https://api.github.com/users/Akvinikym/gists{/gist_id}","starred_url":"https://api.github.com/users/Akvinikym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akvinikym/subscriptions","organizations_url":"https://api.github.com/users/Akvinikym/orgs","repos_url":"https://api.github.com/users/Akvinikym/repos","events_url":"https://api.github.com/users/Akvinikym/events{/privacy}","received_events_url":"https://api.github.com/users/Akvinikym/received_events","type":"User","site_admin":false},"body":"<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\n\r\nThis pull request adds a new test, which task is to make a Docker container with all Iroha dependencies, to build it inside. The thing is that all dependencies are located in non-default, separated folders, so Iroha's ability to build in such conditions is tested.\r\n\r\n### Benefits\r\n\r\nTest, which will help to find bugs, located mostly in cmake files.\r\n\r\n### Possible Drawbacks \r\n\r\nThis is a complex test, which can take a couple of hours or more.","created_at":"2018-06-01T11:57:45Z","updated_at":"2018-06-01T15:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"155f0d92900835fffecc833de2d15fce4c36549f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bakhtin","id":8650477,"node_id":"MDQ6VXNlcjg2NTA0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8650477?v=4","gravatar_id":"","url":"https://api.github.com/users/bakhtin","html_url":"https://github.com/bakhtin","followers_url":"https://api.github.com/users/bakhtin/followers","following_url":"https://api.github.com/users/bakhtin/following{/other_user}","gists_url":"https://api.github.com/users/bakhtin/gists{/gist_id}","starred_url":"https://api.github.com/users/bakhtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakhtin/subscriptions","organizations_url":"https://api.github.com/users/bakhtin/orgs","repos_url":"https://api.github.com/users/bakhtin/repos","events_url":"https://api.github.com/users/bakhtin/events{/privacy}","received_events_url":"https://api.github.com/users/bakhtin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1404/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1404/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1404/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/b78e16ceb54b445ff64ebd92229be61bec489049","head":{"label":"hyperledger:refactor/dependencies_to_docker","ref":"refactor/dependencies_to_docker","sha":"b78e16ceb54b445ff64ebd92229be61bec489049","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-05-31T22:20:04Z","pushed_at":"2018-06-01T15:02:08Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48194,"stargazers_count":804,"watchers_count":804,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":249,"open_issues":48,"watchers":804,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"c337f09a2f54960f86ec3028c7101ca181800d24","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-05-31T22:20:04Z","pushed_at":"2018-06-01T15:02:08Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48194,"stargazers_count":804,"watchers_count":804,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":249,"open_issues":48,"watchers":804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1404"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1404"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1404"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1404/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1404/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1404/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/b78e16ceb54b445ff64ebd92229be61bec489049"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Akvinikym"}}