{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/216623087","pull_request_review_id":154144613,"id":216623087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjYyMzA4Nw==","diff_hunk":"@@ -110,10 +111,9 @@ private void createAdditionalContainerOnLogserverHost(Admin admin, HostResource\n         admin.addAndInitializeService(hostResource, container);\n     }\n \n-    // TODO: Wire in handler for getting logs\n     private void addLogHandler(ContainerCluster cluster) {\n-        Handler<?> logHandler = Handler.fromClassName(\"TODO\");\n-        //logHandler.addServerBindings(\"http://*/logs/\", \"https://*/logs/\");\n+        Handler<?> logHandler = Handler.fromClassName(\"com.yahoo.container.handlerLogHandler\");","path":"config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomAdminV4Builder.java","position":16,"original_position":16,"commit_id":"231444c0a4205b31c18fdfbfee31b7edf7f1e6cc","original_commit_id":"231444c0a4205b31c18fdfbfee31b7edf7f1e6cc","user":{"login":"olaaun","id":8686748,"node_id":"MDQ6VXNlcjg2ODY3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8686748?v=4","gravatar_id":"","url":"https://api.github.com/users/olaaun","html_url":"https://github.com/olaaun","followers_url":"https://api.github.com/users/olaaun/followers","following_url":"https://api.github.com/users/olaaun/following{/other_user}","gists_url":"https://api.github.com/users/olaaun/gists{/gist_id}","starred_url":"https://api.github.com/users/olaaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaaun/subscriptions","organizations_url":"https://api.github.com/users/olaaun/orgs","repos_url":"https://api.github.com/users/olaaun/repos","events_url":"https://api.github.com/users/olaaun/events{/privacy}","received_events_url":"https://api.github.com/users/olaaun/received_events","type":"User","site_admin":false},"body":"Missing dot?","created_at":"2018-09-11T10:40:07Z","updated_at":"2018-09-11T10:40:07Z","html_url":"https://github.com/vespa-engine/vespa/pull/6888#discussion_r216623087","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/216623087"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6888#discussion_r216623087"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888"}}},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888","id":214539355,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTM5MzU1","html_url":"https://github.com/vespa-engine/vespa/pull/6888","diff_url":"https://github.com/vespa-engine/vespa/pull/6888.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/6888.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6888","number":6888,"state":"open","locked":false,"title":"Wire in handler for getting logs","user":{"login":"hmusum","id":19365553,"node_id":"MDQ6VXNlcjE5MzY1NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/19365553?v=4","gravatar_id":"","url":"https://api.github.com/users/hmusum","html_url":"https://github.com/hmusum","followers_url":"https://api.github.com/users/hmusum/followers","following_url":"https://api.github.com/users/hmusum/following{/other_user}","gists_url":"https://api.github.com/users/hmusum/gists{/gist_id}","starred_url":"https://api.github.com/users/hmusum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmusum/subscriptions","organizations_url":"https://api.github.com/users/hmusum/orgs","repos_url":"https://api.github.com/users/hmusum/repos","events_url":"https://api.github.com/users/hmusum/events{/privacy}","received_events_url":"https://api.github.com/users/hmusum/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-11T07:37:39Z","updated_at":"2018-09-11T10:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2da7b6045e23003e1e66d7551159833aa4bc3c91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6888/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/231444c0a4205b31c18fdfbfee31b7edf7f1e6cc","head":{"label":"vespa-engine:hmusum/wire-in-handler-for-getting-logs","ref":"hmusum/wire-in-handler-for-getting-logs","sha":"231444c0a4205b31c18fdfbfee31b7edf7f1e6cc","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-09-11T10:23:09Z","pushed_at":"2018-09-11T10:31:50Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":76486,"stargazers_count":2582,"watchers_count":2582,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":306,"open_issues":58,"watchers":2582,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"fbcc8ba8640529047809dc0a73b99364f4647802","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-09-11T10:23:09Z","pushed_at":"2018-09-11T10:31:50Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":76486,"stargazers_count":2582,"watchers_count":2582,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":306,"open_issues":58,"watchers":2582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6888"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6888"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6888/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6888/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/231444c0a4205b31c18fdfbfee31b7edf7f1e6cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"olaaun"}}