{"action":"created","comment":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/165653940","pull_request_review_id":93631514,"id":165653940,"diff_hunk":"@@ -222,23 +238,60 @@ issue_2857_5: {\n         comparisons: true,\n     }\n     input: {\n-        p && a === undefined || a === null;\n-        p && a === undefined || a !== null;\n-        p && a !== undefined || a === null;\n-        p && a !== undefined || a !== null;\n-        p && a === undefined && a === null;\n-        p && a === undefined && a !== null;\n-        p && a !== undefined && a === null;\n-        p && a !== undefined && a !== null;\n+        function f(a, p) {\n+            p && a === undefined || a === null;\n+            p && a === undefined || a !== null;\n+            p && a !== undefined || a === null;\n+            p && a !== undefined || a !== null;\n+            p && a === undefined && a === null;\n+            p && a === undefined && a !== null;\n+            p && a !== undefined && a === null;\n+            p && a !== undefined && a !== null;\n+        }\n+    }\n+    expect: {\n+        function f(a, p) {\n+            p && void 0 === a || null === a;\n+            p && void 0 === a || null !== a;\n+            p && void 0 !== a || null === a;\n+            p && void 0 !== a || null !== a;\n+            p && void 0 === a && null === a;\n+            p && void 0 === a && null !== a;\n+            p && void 0 !== a && null === a;\n+            p && null != a;\n+        }\n+    }\n+}\n+\n+issue_2857_6: {\n+    options = {\n+        comparisons: true,\n+        pure_getters: \"strict\",\n+        reduce_vars: true,\n+    }\n+    input: {\n+        function f(a) {\n+            if (({}).b === undefined || {}.b === null)\n+                return a.b !== undefined && a.b !== null;\n+        }\n+        console.log(f({\n+            a: [ null ],\n+            get b() {\n+                return this.a.shift();\n+            }\n+        }));","path":"test/compress/comparing.js","position":253,"original_position":233,"commit_id":"8f46d1fb67b4023f3dbafec88bd6076821064f0b","original_commit_id":"f41141750d7acd778c1133875688e4eb2b408667","user":{"login":"Skalman","id":138395,"avatar_url":"https://avatars0.githubusercontent.com/u/138395?v=4","gravatar_id":"","url":"https://api.github.com/users/Skalman","html_url":"https://github.com/Skalman","followers_url":"https://api.github.com/users/Skalman/followers","following_url":"https://api.github.com/users/Skalman/following{/other_user}","gists_url":"https://api.github.com/users/Skalman/gists{/gist_id}","starred_url":"https://api.github.com/users/Skalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skalman/subscriptions","organizations_url":"https://api.github.com/users/Skalman/orgs","repos_url":"https://api.github.com/users/Skalman/repos","events_url":"https://api.github.com/users/Skalman/events{/privacy}","received_events_url":"https://api.github.com/users/Skalman/received_events","type":"User","site_admin":false},"body":"Good to have it as a test!","created_at":"2018-02-02T14:11:38Z","updated_at":"2018-02-02T14:11:38Z","html_url":"https://github.com/mishoo/UglifyJS2/pull/2863#discussion_r165653940","pull_request_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/165653940"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/2863#discussion_r165653940"},"pull_request":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863"}},"in_reply_to_id":165304902},"pull_request":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863","id":166489603,"html_url":"https://github.com/mishoo/UglifyJS2/pull/2863","diff_url":"https://github.com/mishoo/UglifyJS2/pull/2863.diff","patch_url":"https://github.com/mishoo/UglifyJS2/pull/2863.patch","issue_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/2863","number":2863,"state":"closed","locked":false,"title":"account for side-effects in `comparisons` of `null` & `undefined`","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars3.githubusercontent.com/u/1898413?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"body":"https://github.com/mishoo/UglifyJS2/pull/2862#issuecomment-362207611","created_at":"2018-02-01T09:54:38Z","updated_at":"2018-02-02T14:11:38Z","closed_at":"2018-02-01T11:15:18Z","merged_at":"2018-02-01T11:15:18Z","merge_commit_sha":"c3a002ff9739b60ec1836719c1e240df22a67830","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863/commits","review_comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863/comments","review_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/2863/comments","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/8f46d1fb67b4023f3dbafec88bd6076821064f0b","head":{"label":"alexlamsl:fixup-2862","ref":"fixup-2862","sha":"8f46d1fb67b4023f3dbafec88bd6076821064f0b","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars3.githubusercontent.com/u/1898413?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"repo":{"id":79024614,"name":"UglifyJS2","full_name":"alexlamsl/UglifyJS2","owner":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars3.githubusercontent.com/u/1898413?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlamsl/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":true,"url":"https://api.github.com/repos/alexlamsl/UglifyJS2","forks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/forks","keys_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/events","assignees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/merges","archive_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/deployments","created_at":"2017-01-15T10:31:17Z","updated_at":"2017-01-15T10:31:20Z","pushed_at":"2018-02-02T10:11:02Z","git_url":"git://github.com/alexlamsl/UglifyJS2.git","ssh_url":"git@github.com:alexlamsl/UglifyJS2.git","clone_url":"https://github.com/alexlamsl/UglifyJS2.git","svn_url":"https://github.com/alexlamsl/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":7360,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mishoo:master","ref":"master","sha":"fad6766a905350574b698af707958294e22184f3","user":{"login":"mishoo","id":334725,"avatar_url":"https://avatars2.githubusercontent.com/u/334725?v=4","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"repo":{"id":5569059,"name":"UglifyJS2","full_name":"mishoo/UglifyJS2","owner":{"login":"mishoo","id":334725,"avatar_url":"https://avatars2.githubusercontent.com/u/334725?v=4","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishoo/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":false,"url":"https://api.github.com/repos/mishoo/UglifyJS2","forks_url":"https://api.github.com/repos/mishoo/UglifyJS2/forks","keys_url":"https://api.github.com/repos/mishoo/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishoo/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishoo/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/mishoo/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/mishoo/UglifyJS2/events","assignees_url":"https://api.github.com/repos/mishoo/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/mishoo/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishoo/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/mishoo/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/mishoo/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishoo/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/mishoo/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishoo/UglifyJS2/merges","archive_url":"https://api.github.com/repos/mishoo/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishoo/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishoo/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishoo/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishoo/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/mishoo/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/mishoo/UglifyJS2/deployments","created_at":"2012-08-27T09:31:03Z","updated_at":"2018-02-02T13:14:45Z","pushed_at":"2018-02-02T10:11:03Z","git_url":"git://github.com/mishoo/UglifyJS2.git","ssh_url":"git@github.com:mishoo/UglifyJS2.git","clone_url":"https://github.com/mishoo/UglifyJS2.git","svn_url":"https://github.com/mishoo/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":7286,"stargazers_count":8086,"watchers_count":8086,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":881,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":881,"open_issues":47,"watchers":8086,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/2863"},"issue":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/2863"},"comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/2863/comments"},"review_comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863/comments"},"review_comment":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/2863/commits"},"statuses":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/8f46d1fb67b4023f3dbafec88bd6076821064f0b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Skalman"}}