{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/224936368","pull_request_review_id":164435711,"id":224936368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDkzNjM2OA==","diff_hunk":"@@ -1,16 +1,21 @@\n+import { BuyQuote } from '@0xproject/asset-buyer';\n import { BigNumber } from '@0xproject/utils';\n import * as _ from 'lodash';\n \n-import { Action, ActionTypes } from '../types';\n+import { Action, ActionTypes, AsyncProcessState } from '../types';\n \n export interface State {","path":"packages/instant/src/redux/reducer.ts","position":11,"original_position":8,"commit_id":"f39541436a5088e928660b61bde7cef5153bc7a1","original_commit_id":"19f61906d3075391efb32c17c99c2cba1f7a3858","user":{"login":"fragosti","id":3066135,"node_id":"MDQ6VXNlcjMwNjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3066135?v=4","gravatar_id":"","url":"https://api.github.com/users/fragosti","html_url":"https://github.com/fragosti","followers_url":"https://api.github.com/users/fragosti/followers","following_url":"https://api.github.com/users/fragosti/following{/other_user}","gists_url":"https://api.github.com/users/fragosti/gists{/gist_id}","starred_url":"https://api.github.com/users/fragosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragosti/subscriptions","organizations_url":"https://api.github.com/users/fragosti/orgs","repos_url":"https://api.github.com/users/fragosti/repos","events_url":"https://api.github.com/users/fragosti/events{/privacy}","received_events_url":"https://api.github.com/users/fragosti/received_events","type":"User","site_admin":false},"body":"Not going to do this for now. Should be done when we implement different wallets.","created_at":"2018-10-12T23:16:49Z","updated_at":"2018-10-12T23:16:50Z","html_url":"https://github.com/0xProject/0x-monorepo/pull/1131#discussion_r224936368","pull_request_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/224936368"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1131#discussion_r224936368"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131"}},"in_reply_to_id":224291571},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131","id":221980972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTgwOTcy","html_url":"https://github.com/0xProject/0x-monorepo/pull/1131","diff_url":"https://github.com/0xProject/0x-monorepo/pull/1131.diff","patch_url":"https://github.com/0xProject/0x-monorepo/pull/1131.patch","issue_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1131","number":1131,"state":"open","locked":false,"title":"[instant][types][order-utils] Move over and clean up features from zrx-buyer","user":{"login":"fragosti","id":3066135,"node_id":"MDQ6VXNlcjMwNjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3066135?v=4","gravatar_id":"","url":"https://api.github.com/users/fragosti","html_url":"https://github.com/fragosti","followers_url":"https://api.github.com/users/fragosti/followers","following_url":"https://api.github.com/users/fragosti/following{/other_user}","gists_url":"https://api.github.com/users/fragosti/gists{/gist_id}","starred_url":"https://api.github.com/users/fragosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragosti/subscriptions","organizations_url":"https://api.github.com/users/fragosti/orgs","repos_url":"https://api.github.com/users/fragosti/repos","events_url":"https://api.github.com/users/fragosti/events{/privacy}","received_events_url":"https://api.github.com/users/fragosti/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nStraight port of features:\r\n- Abstraction for fetching async data, and fetching ETH-USD price from coinbase.\r\n- Connecting InstantHeading and BuyButton to the redux store.\r\n- Instantiate provider, asset buyer, web3wrapper etc...\r\n- Display the buy quote and allow the buy button to execute the buy quote.\r\n- Add notion of dynamic `assetData` and `assetMetaData`.\r\n- Add some utils for formatting eth price and eth-usd price. \r\n- Populate the order details section. \r\n- Add debouncing to fetches that result from input changes.\r\n- Make redux actions type-safe.\r\n\r\nI also changed some types but then ended up not needing the change... but still seems like a good change? Basically we should control all unions of different asset data types, such that the build fails if we add a type to that union, assuming we are using a switch statement in the implementation of the function that is meant to handle all asset data types.\r\n\r\n<img width=\"503\" alt=\"screen shot 2018-10-12 at 4 11 58 pm\" src=\"https://user-images.githubusercontent.com/3066135/46897799-d235d080-ce39-11e8-9ed8-f24ff9396bf3.png\">\r\n\r\n\r\n## Testing instructions\r\n\r\n<!--- Please describe how reviewers can test your changes -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Uncomment all the bullets that apply: -->\r\n\r\n<!-- * Bug fix (non-breaking change which fixes an issue) -->\r\n\r\n<!-- * New feature (non-breaking change which adds functionality) -->\r\n\r\n<!-- * Breaking change (fix or feature that would cause existing functionality to change) -->\r\n\r\n## Checklist:\r\n\r\n<!--- The following points should be used to indicate the progress of your PR.  Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress.  If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n*   [ ] Prefix PR title with `[WIP]` if necessary.\r\n*   [ ] Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: `[sol-cov] Fixed bug`.\r\n*   [ ] Add tests to cover changes as needed.\r\n*   [ ] Update documentation as needed.\r\n*   [ ] Add new entries to the relevant CHANGELOG.jsons.\r\n","created_at":"2018-10-11T01:37:07Z","updated_at":"2018-10-12T23:16:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d622517cf62b0282654ae03074abd95eb52ddf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"steveklebanoff","id":210914,"node_id":"MDQ6VXNlcjIxMDkxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/210914?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklebanoff","html_url":"https://github.com/steveklebanoff","followers_url":"https://api.github.com/users/steveklebanoff/followers","following_url":"https://api.github.com/users/steveklebanoff/following{/other_user}","gists_url":"https://api.github.com/users/steveklebanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklebanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklebanoff/subscriptions","organizations_url":"https://api.github.com/users/steveklebanoff/orgs","repos_url":"https://api.github.com/users/steveklebanoff/repos","events_url":"https://api.github.com/users/steveklebanoff/events{/privacy}","received_events_url":"https://api.github.com/users/steveklebanoff/received_events","type":"User","site_admin":false},{"login":"BMillman19","id":1141340,"node_id":"MDQ6VXNlcjExNDEzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1141340?v=4","gravatar_id":"","url":"https://api.github.com/users/BMillman19","html_url":"https://github.com/BMillman19","followers_url":"https://api.github.com/users/BMillman19/followers","following_url":"https://api.github.com/users/BMillman19/following{/other_user}","gists_url":"https://api.github.com/users/BMillman19/gists{/gist_id}","starred_url":"https://api.github.com/users/BMillman19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BMillman19/subscriptions","organizations_url":"https://api.github.com/users/BMillman19/orgs","repos_url":"https://api.github.com/users/BMillman19/repos","events_url":"https://api.github.com/users/BMillman19/events{/privacy}","received_events_url":"https://api.github.com/users/BMillman19/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1077385218,"node_id":"MDU6TGFiZWwxMDc3Mzg1MjE4","url":"https://api.github.com/repos/0xProject/0x-monorepo/labels/instant","name":"instant","color":"fbca04","default":false},{"id":1012866243,"node_id":"MDU6TGFiZWwxMDEyODY2MjQz","url":"https://api.github.com/repos/0xProject/0x-monorepo/labels/order-utils","name":"order-utils","color":"db613f","default":false},{"id":844777240,"node_id":"MDU6TGFiZWw4NDQ3NzcyNDA=","url":"https://api.github.com/repos/0xProject/0x-monorepo/labels/types","name":"types","color":"f7cda8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1131/comments","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/f39541436a5088e928660b61bde7cef5153bc7a1","head":{"label":"0xProject:feature/instant/move-features-over-from-zrx-buyer","ref":"feature/instant/move-features-over-from-zrx-buyer","sha":"f39541436a5088e928660b61bde7cef5153bc7a1","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-10-12T22:07:03Z","pushed_at":"2018-10-12T23:11:41Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":60227,"stargazers_count":842,"watchers_count":842,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":230,"open_issues":53,"watchers":842,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"a5a033c359a1a00a144ae0655080b4e6d0e43c88","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-10-12T22:07:03Z","pushed_at":"2018-10-12T23:11:41Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":60227,"stargazers_count":842,"watchers_count":842,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":230,"open_issues":53,"watchers":842,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1131"},"issue":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1131"},"comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/f39541436a5088e928660b61bde7cef5153bc7a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fragosti"}}