{"action":"created","comment":{"url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/comments/225476145","pull_request_review_id":165069672,"id":225476145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ3NjE0NQ==","diff_hunk":"@@ -29,20 +29,22 @@\n     private final Map<String, String> properties;\n     private final Long jobId;\n     private final PodState state;\n+    private final ElasticProfileSettings settings;\n \n-    public KubernetesInstance(DateTime createdAt, String environment, String name, Map<String, String> properties, Long jobId, PodState state) {\n+    public KubernetesInstance(DateTime createdAt, ElasticProfileSettings settings,String environment, String name, Map<String, String> properties, Long jobId, PodState state) {\n         this.createdAt = createdAt.withZone(DateTimeZone.UTC);\n         this.environment = environment;\n         this.name = name;\n         this.properties = properties;\n         this.jobId = jobId;\n         this.state = state;\n+        this.settings = settings;","path":"src/main/java/cd/go/contrib/elasticagent/KubernetesInstance.java","position":14,"original_position":14,"commit_id":"bc2db10317f3fd0eec25132824e3606d3d192554","original_commit_id":"bc2db10317f3fd0eec25132824e3606d3d192554","user":{"login":"GaneshSPatil","id":15275847,"node_id":"MDQ6VXNlcjE1Mjc1ODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/15275847?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshSPatil","html_url":"https://github.com/GaneshSPatil","followers_url":"https://api.github.com/users/GaneshSPatil/followers","following_url":"https://api.github.com/users/GaneshSPatil/following{/other_user}","gists_url":"https://api.github.com/users/GaneshSPatil/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshSPatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshSPatil/subscriptions","organizations_url":"https://api.github.com/users/GaneshSPatil/orgs","repos_url":"https://api.github.com/users/GaneshSPatil/repos","events_url":"https://api.github.com/users/GaneshSPatil/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshSPatil/received_events","type":"User","site_admin":false},"body":"Duplicate Information.\r\n`properties` and `settings` field will have duplicate information about `security-token`, `namespace` and `auto-register-timeout`.\r\n\r\nAlso, storing settings on the instance is a bad idea as it will contain stale information if setting has changed after the instance is created.","created_at":"2018-10-16T10:04:18Z","updated_at":"2018-10-16T10:09:20Z","html_url":"https://github.com/gocd/kubernetes-elastic-agents/pull/60#discussion_r225476145","pull_request_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/comments/225476145"},"html":{"href":"https://github.com/gocd/kubernetes-elastic-agents/pull/60#discussion_r225476145"},"pull_request":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60","id":216930790,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTMwNzkw","html_url":"https://github.com/gocd/kubernetes-elastic-agents/pull/60","diff_url":"https://github.com/gocd/kubernetes-elastic-agents/pull/60.diff","patch_url":"https://github.com/gocd/kubernetes-elastic-agents/pull/60.patch","issue_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/60","number":60,"state":"open","locked":false,"title":"Elastic profile enhancement","user":{"login":"saifally","id":2938948,"node_id":"MDQ6VXNlcjI5Mzg5NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2938948?v=4","gravatar_id":"","url":"https://api.github.com/users/saifally","html_url":"https://github.com/saifally","followers_url":"https://api.github.com/users/saifally/followers","following_url":"https://api.github.com/users/saifally/following{/other_user}","gists_url":"https://api.github.com/users/saifally/gists{/gist_id}","starred_url":"https://api.github.com/users/saifally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saifally/subscriptions","organizations_url":"https://api.github.com/users/saifally/orgs","repos_url":"https://api.github.com/users/saifally/repos","events_url":"https://api.github.com/users/saifally/events{/privacy}","received_events_url":"https://api.github.com/users/saifally/received_events","type":"User","site_admin":false},"body":"Enhancements for having these 3 things at Elastic Profile level\r\n- Agent auto-register timeout\r\n- Name space \r\n- Security Token\r\n\r\nIf these are not specified , the default values from Plugin are used.\r\nHowever if they are specified the Elastic profile ones take precedence.\r\n","created_at":"2018-09-20T11:03:54Z","updated_at":"2018-10-16T10:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8675826953b2088729f32f16eef2048142c4812","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60/commits","review_comments_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60/comments","review_comment_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/60/comments","statuses_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/statuses/bc2db10317f3fd0eec25132824e3606d3d192554","head":{"label":"saifally:master","ref":"master","sha":"bc2db10317f3fd0eec25132824e3606d3d192554","user":{"login":"saifally","id":2938948,"node_id":"MDQ6VXNlcjI5Mzg5NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2938948?v=4","gravatar_id":"","url":"https://api.github.com/users/saifally","html_url":"https://github.com/saifally","followers_url":"https://api.github.com/users/saifally/followers","following_url":"https://api.github.com/users/saifally/following{/other_user}","gists_url":"https://api.github.com/users/saifally/gists{/gist_id}","starred_url":"https://api.github.com/users/saifally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saifally/subscriptions","organizations_url":"https://api.github.com/users/saifally/orgs","repos_url":"https://api.github.com/users/saifally/repos","events_url":"https://api.github.com/users/saifally/events{/privacy}","received_events_url":"https://api.github.com/users/saifally/received_events","type":"User","site_admin":false},"repo":{"id":148878964,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4Nzg5NjQ=","name":"kubernetes-elastic-agents","full_name":"saifally/kubernetes-elastic-agents","private":false,"owner":{"login":"saifally","id":2938948,"node_id":"MDQ6VXNlcjI5Mzg5NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2938948?v=4","gravatar_id":"","url":"https://api.github.com/users/saifally","html_url":"https://github.com/saifally","followers_url":"https://api.github.com/users/saifally/followers","following_url":"https://api.github.com/users/saifally/following{/other_user}","gists_url":"https://api.github.com/users/saifally/gists{/gist_id}","starred_url":"https://api.github.com/users/saifally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saifally/subscriptions","organizations_url":"https://api.github.com/users/saifally/orgs","repos_url":"https://api.github.com/users/saifally/repos","events_url":"https://api.github.com/users/saifally/events{/privacy}","received_events_url":"https://api.github.com/users/saifally/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saifally/kubernetes-elastic-agents","description":"Kubernetes Elastic agent plugin for https://www.gocd.org","fork":true,"url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents","forks_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/forks","keys_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/teams","hooks_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/hooks","issue_events_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/issues/events{/number}","events_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/events","assignees_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/assignees{/user}","branches_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/branches{/branch}","tags_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/tags","blobs_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/languages","stargazers_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/stargazers","contributors_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/contributors","subscribers_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/subscribers","subscription_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/subscription","commits_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/contents/{+path}","compare_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/merges","archive_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/downloads","issues_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/issues{/number}","pulls_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/labels{/name}","releases_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/releases{/id}","deployments_url":"https://api.github.com/repos/saifally/kubernetes-elastic-agents/deployments","created_at":"2018-09-15T07:12:37Z","updated_at":"2018-09-20T10:53:54Z","pushed_at":"2018-09-20T10:53:52Z","git_url":"git://github.com/saifally/kubernetes-elastic-agents.git","ssh_url":"git@github.com:saifally/kubernetes-elastic-agents.git","clone_url":"https://github.com/saifally/kubernetes-elastic-agents.git","svn_url":"https://github.com/saifally/kubernetes-elastic-agents","homepage":"","size":1103,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"4ad2f92f77ef39bebef699e3eb45b8e8ed1e1fdf","user":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":108257114,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNTcxMTQ=","name":"kubernetes-elastic-agents","full_name":"gocd/kubernetes-elastic-agents","private":false,"owner":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gocd/kubernetes-elastic-agents","description":"Kubernetes Elastic agent plugin for https://www.gocd.org","fork":false,"url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents","forks_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/forks","keys_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/teams","hooks_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/hooks","issue_events_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/events","assignees_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/tags","blobs_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/languages","stargazers_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/stargazers","contributors_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/contributors","subscribers_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/subscribers","subscription_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/subscription","commits_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/merges","archive_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/downloads","issues_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/labels{/name}","releases_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/releases{/id}","deployments_url":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/deployments","created_at":"2017-10-25T10:50:05Z","updated_at":"2018-10-15T09:10:10Z","pushed_at":"2018-10-15T12:27:08Z","git_url":"git://github.com/gocd/kubernetes-elastic-agents.git","ssh_url":"git@github.com:gocd/kubernetes-elastic-agents.git","clone_url":"https://github.com/gocd/kubernetes-elastic-agents.git","svn_url":"https://github.com/gocd/kubernetes-elastic-agents","homepage":"","size":1090,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":14,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60"},"html":{"href":"https://github.com/gocd/kubernetes-elastic-agents/pull/60"},"issue":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/60"},"comments":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/kubernetes-elastic-agents/statuses/bc2db10317f3fd0eec25132824e3606d3d192554"}},"author_association":"NONE"}}
{"actor":{"display_login":"GaneshSPatil"}}