{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/godot/issues/20541","repository_url":"https://api.github.com/repos/godotengine/godot","labels_url":"https://api.github.com/repos/godotengine/godot/issues/20541/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/20541/comments","events_url":"https://api.github.com/repos/godotengine/godot/issues/20541/events","html_url":"https://github.com/godotengine/godot/pull/20541","id":345442396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTg5ODQ4","number":20541,"title":"Added new scaling modes to splash screen","user":{"login":"samuelpedrajas","id":8157352,"node_id":"MDQ6VXNlcjgxNTczNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8157352?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelpedrajas","html_url":"https://github.com/samuelpedrajas","followers_url":"https://api.github.com/users/samuelpedrajas/followers","following_url":"https://api.github.com/users/samuelpedrajas/following{/other_user}","gists_url":"https://api.github.com/users/samuelpedrajas/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelpedrajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelpedrajas/subscriptions","organizations_url":"https://api.github.com/users/samuelpedrajas/orgs","repos_url":"https://api.github.com/users/samuelpedrajas/repos","events_url":"https://api.github.com/users/samuelpedrajas/events{/privacy}","received_events_url":"https://api.github.com/users/samuelpedrajas/received_events","type":"User","site_admin":false},"labels":[{"id":73330066,"node_id":"MDU6TGFiZWw3MzMzMDA2Ng==","url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"44bbff","default":true},{"id":279097966,"node_id":"MDU6TGFiZWwyNzkwOTc5NjY=","url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffdd44","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/7","html_url":"https://github.com/godotengine/godot/milestone/7","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/7/labels","id":2529217,"node_id":"MDk6TWlsZXN0b25lMjUyOTIxNw==","number":7,"title":"3.1","description":"","creator":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":922,"closed_issues":3586,"state":"open","created_at":"2017-05-18T13:33:56Z","updated_at":"2018-09-27T17:00:45Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-07-28T11:46:07Z","updated_at":"2018-09-27T18:21:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/20541","html_url":"https://github.com/godotengine/godot/pull/20541","diff_url":"https://github.com/godotengine/godot/pull/20541.diff","patch_url":"https://github.com/godotengine/godot/pull/20541.patch"},"body":"The only way to scale the boot splash image is the option \"Application/Boot Splash/fullsize\" in the project settings. This PR adds 4 new ways of scaling: keep_width, keep_height, cover and expand and keeps the previous one (calling it full_size).\r\n\r\nThe old fullsize option looked like this:\r\n![fullsize_option](https://user-images.githubusercontent.com/8157352/43356151-9a4e94fe-926b-11e8-914d-cdd455b33321.png)\r\n\r\nAnd I replaced it for a new option I called \"scale\":\r\n![new_scaling_modes](https://user-images.githubusercontent.com/8157352/43356154-ac65bd5c-926b-11e8-84b2-bc1ccf9752c9.png)\r\n\r\nHere I show some pictures to illustrate how each scaling mode works. In each case an icon with size 64x64 is used:\r\n\r\n| Scaling Mode | Horizontal (960x540) | Vertical (540x960) |\r\n| ------------- | ------------- | ------------- |\r\n| disabled  | ![h_fullsize_off](https://user-images.githubusercontent.com/8157352/43355917-985f0818-9266-11e8-85e0-3e76241e3cc0.png) | ![v_fullsize_off](https://user-images.githubusercontent.com/8157352/43355920-acea9b44-9266-11e8-9eec-0f8483652ede.png) |\r\n| keep_width  | ![h_keep_width](https://user-images.githubusercontent.com/8157352/43355935-dd389bf2-9266-11e8-8f16-69b363d3c5a5.png)  | ![v_fullsize_on](https://user-images.githubusercontent.com/8157352/43355943-f0a2d144-9266-11e8-94c6-131086427154.png)  |\r\n| keep_height  | ![h_fullsize_on](https://user-images.githubusercontent.com/8157352/43355939-ee6ae6be-9266-11e8-9186-2ee769baa5c9.png)  | ![v_keep_height](https://user-images.githubusercontent.com/8157352/43355944-f0d9b8ee-9266-11e8-9fe1-f2c2dfcc3401.png)  |\r\n| cover | ![h_keep_width](https://user-images.githubusercontent.com/8157352/43355935-dd389bf2-9266-11e8-8f16-69b363d3c5a5.png)  | ![v_keep_height](https://user-images.githubusercontent.com/8157352/43355944-f0d9b8ee-9266-11e8-9fe1-f2c2dfcc3401.png)  |\r\n| expand  | ![h_expand](https://user-images.githubusercontent.com/8157352/43355937-ee2b2326-9266-11e8-87c9-83af89423e21.png) | ![v_expand](https://user-images.githubusercontent.com/8157352/43355940-eed1dc7a-9266-11e8-87c9-05c7e358db77.png)  |\r\n| full_size  | ![h_fullsize_on](https://user-images.githubusercontent.com/8157352/43355939-ee6ae6be-9266-11e8-9186-2ee769baa5c9.png) | ![v_fullsize_on](https://user-images.githubusercontent.com/8157352/43355943-f0a2d144-9266-11e8-94c6-131086427154.png) |\r\n\r\nThe last one scales in the same way as the previous \"fullsize\" boolean option.\r\n\r\nI updated both `rasterizer_gles2.cpp` and `rasterizer_gles3.cpp`. I also realised that the old \"fullsize\" option was not working when using GLES2.\r\n\r\nThis is my first PR so any tips, suggestions, recommendations... about anything are very welcome, specially if it's code-related."},"comment":{"url":"https://api.github.com/repos/godotengine/godot/issues/comments/425194381","html_url":"https://github.com/godotengine/godot/pull/20541#issuecomment-425194381","issue_url":"https://api.github.com/repos/godotengine/godot/issues/20541","id":425194381,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE5NDM4MQ==","user":{"login":"samuelpedrajas","id":8157352,"node_id":"MDQ6VXNlcjgxNTczNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8157352?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelpedrajas","html_url":"https://github.com/samuelpedrajas","followers_url":"https://api.github.com/users/samuelpedrajas/followers","following_url":"https://api.github.com/users/samuelpedrajas/following{/other_user}","gists_url":"https://api.github.com/users/samuelpedrajas/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelpedrajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelpedrajas/subscriptions","organizations_url":"https://api.github.com/users/samuelpedrajas/orgs","repos_url":"https://api.github.com/users/samuelpedrajas/repos","events_url":"https://api.github.com/users/samuelpedrajas/events{/privacy}","received_events_url":"https://api.github.com/users/samuelpedrajas/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T18:21:40Z","updated_at":"2018-09-27T18:21:40Z","author_association":"NONE","body":"I finally opened a new PR (because as I said I can't edit this PR anymore) here: https://github.com/godotengine/godot/pull/22488. I think that now this one becomes obsolete and can be rejected."}}
{"actor":{"display_login":"samuelpedrajas"}}