{"action":"closed","number":14179,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179","id":214150607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTUwNjA3","html_url":"https://github.com/bitcoin/bitcoin/pull/14179","diff_url":"https://github.com/bitcoin/bitcoin/pull/14179.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14179.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14179","number":14179,"state":"closed","locked":false,"title":"qa: Fixups to \"Run all tests even if wallet is not compiled\"","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"Currently the functional tests require the wallet module to be compiled into the Bitcoin Core executable. For example the premine (or datadir cache) to speed up tests when run in parallel would mine a bunch of blocks and store the private keys to sign the coinbase tx outputs in a wallet. There is no need to have the overhead of the whole wallet module by using keys that are deterministic for all runs.\r\n\r\nNote that this change most likely requires the `./test/cache/` to be cleared.","created_at":"2018-09-09T15:33:25Z","updated_at":"2018-09-13T21:47:52Z","closed_at":"2018-09-13T21:47:52Z","merged_at":"2018-09-13T21:47:52Z","merge_commit_sha":"fa8433e3797a574937009c1b0843f44d8d7b5358","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14179/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa8433e3797a574937009c1b0843f44d8d7b5358","head":{"label":"MarcoFalke:Mf1809-qaPremine","ref":"Mf1809-qaPremine","sha":"fa8433e3797a574937009c1b0843f44d8d7b5358","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"repo":{"id":40046254,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA0NjI1NA==","name":"bitcoin","full_name":"MarcoFalke/bitcoin","owner":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoFalke/bitcoin","description":"Development fork of https://github.com/bitcoin/bitcoin","fork":true,"url":"https://api.github.com/repos/MarcoFalke/bitcoin","forks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/forks","keys_url":"https://api.github.com/repos/MarcoFalke/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoFalke/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoFalke/bitcoin/teams","hooks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/events","assignees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoFalke/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/tags","blobs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoFalke/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoFalke/bitcoin/languages","stargazers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscription","commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoFalke/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoFalke/bitcoin/merges","archive_url":"https://api.github.com/repos/MarcoFalke/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoFalke/bitcoin/downloads","issues_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoFalke/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoFalke/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoFalke/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoFalke/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MarcoFalke/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/deployments","created_at":"2015-08-01T12:42:47Z","updated_at":"2018-09-13T15:49:35Z","pushed_at":"2018-09-13T20:07:56Z","git_url":"git://github.com/MarcoFalke/bitcoin.git","ssh_url":"git@github.com:MarcoFalke/bitcoin.git","clone_url":"https://github.com/MarcoFalke/bitcoin.git","svn_url":"https://github.com/MarcoFalke/bitcoin","homepage":"","size":103701,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"b9ed2fd026926cafe38a1ee23d47eb891a94ddb1","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-09-13T21:47:18Z","pushed_at":"2018-09-13T21:46:45Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":113787,"stargazers_count":34679,"watchers_count":34679,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20995,"mirror_url":null,"archived":false,"open_issues_count":825,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20995,"open_issues":825,"watchers":34679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14179"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14179"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14179/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14179/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa8433e3797a574937009c1b0843f44d8d7b5358"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"comments":1,"review_comments":13,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"MarcoFalke"}}