{"action":"closed","number":7680,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7680","id":206555794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTU1Nzk0","html_url":"https://github.com/istio/istio/pull/7680","diff_url":"https://github.com/istio/istio/pull/7680.diff","patch_url":"https://github.com/istio/istio/pull/7680.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/7680","number":7680,"state":"closed","locked":false,"title":"ShellCheck: Enable and fix SC1117","user":{"login":"Tahler","id":10715719,"node_id":"MDQ6VXNlcjEwNzE1NzE5","avatar_url":"https://avatars3.githubusercontent.com/u/10715719?v=4","gravatar_id":"","url":"https://api.github.com/users/Tahler","html_url":"https://github.com/Tahler","followers_url":"https://api.github.com/users/Tahler/followers","following_url":"https://api.github.com/users/Tahler/following{/other_user}","gists_url":"https://api.github.com/users/Tahler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tahler/subscriptions","organizations_url":"https://api.github.com/users/Tahler/orgs","repos_url":"https://api.github.com/users/Tahler/repos","events_url":"https://api.github.com/users/Tahler/events{/privacy}","received_events_url":"https://api.github.com/users/Tahler/received_events","type":"User","site_admin":false},"body":"Enable and fix [SC1117](https://github.com/koalaman/shellcheck/wiki/SC1117): Backslash is literal in \"\\n\". Prefer explicit escaping: \"\\\\n\".\r\n\r\nIn other words, escape backslashes when it is non-obvious that it is a literal '\\'.\r\n\r\n/cc @mandarjog\r\n/assign @mandarjog","created_at":"2018-08-07T01:20:48Z","updated_at":"2018-08-07T19:44:41Z","closed_at":"2018-08-07T19:44:41Z","merged_at":"2018-08-07T19:44:41Z","merge_commit_sha":"44829b01373b05842e05f1c4847bf92245dbc5e8","assignee":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/7680/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/7680/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/7680/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/6019fdd31c5c04ef66189842cf3d0b2688435b72","head":{"label":"Tahler:shellcheck-1117","ref":"shellcheck-1117","sha":"6019fdd31c5c04ef66189842cf3d0b2688435b72","user":{"login":"Tahler","id":10715719,"node_id":"MDQ6VXNlcjEwNzE1NzE5","avatar_url":"https://avatars3.githubusercontent.com/u/10715719?v=4","gravatar_id":"","url":"https://api.github.com/users/Tahler","html_url":"https://github.com/Tahler","followers_url":"https://api.github.com/users/Tahler/followers","following_url":"https://api.github.com/users/Tahler/following{/other_user}","gists_url":"https://api.github.com/users/Tahler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tahler/subscriptions","organizations_url":"https://api.github.com/users/Tahler/orgs","repos_url":"https://api.github.com/users/Tahler/repos","events_url":"https://api.github.com/users/Tahler/events{/privacy}","received_events_url":"https://api.github.com/users/Tahler/received_events","type":"User","site_admin":false},"repo":{"id":129006680,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMDY2ODA=","name":"istio","full_name":"Tahler/istio","owner":{"login":"Tahler","id":10715719,"node_id":"MDQ6VXNlcjEwNzE1NzE5","avatar_url":"https://avatars3.githubusercontent.com/u/10715719?v=4","gravatar_id":"","url":"https://api.github.com/users/Tahler","html_url":"https://github.com/Tahler","followers_url":"https://api.github.com/users/Tahler/followers","following_url":"https://api.github.com/users/Tahler/following{/other_user}","gists_url":"https://api.github.com/users/Tahler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tahler/subscriptions","organizations_url":"https://api.github.com/users/Tahler/orgs","repos_url":"https://api.github.com/users/Tahler/repos","events_url":"https://api.github.com/users/Tahler/events{/privacy}","received_events_url":"https://api.github.com/users/Tahler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tahler/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/Tahler/istio","forks_url":"https://api.github.com/repos/Tahler/istio/forks","keys_url":"https://api.github.com/repos/Tahler/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tahler/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tahler/istio/teams","hooks_url":"https://api.github.com/repos/Tahler/istio/hooks","issue_events_url":"https://api.github.com/repos/Tahler/istio/issues/events{/number}","events_url":"https://api.github.com/repos/Tahler/istio/events","assignees_url":"https://api.github.com/repos/Tahler/istio/assignees{/user}","branches_url":"https://api.github.com/repos/Tahler/istio/branches{/branch}","tags_url":"https://api.github.com/repos/Tahler/istio/tags","blobs_url":"https://api.github.com/repos/Tahler/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tahler/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tahler/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tahler/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tahler/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/Tahler/istio/languages","stargazers_url":"https://api.github.com/repos/Tahler/istio/stargazers","contributors_url":"https://api.github.com/repos/Tahler/istio/contributors","subscribers_url":"https://api.github.com/repos/Tahler/istio/subscribers","subscription_url":"https://api.github.com/repos/Tahler/istio/subscription","commits_url":"https://api.github.com/repos/Tahler/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tahler/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tahler/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tahler/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tahler/istio/contents/{+path}","compare_url":"https://api.github.com/repos/Tahler/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tahler/istio/merges","archive_url":"https://api.github.com/repos/Tahler/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tahler/istio/downloads","issues_url":"https://api.github.com/repos/Tahler/istio/issues{/number}","pulls_url":"https://api.github.com/repos/Tahler/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/Tahler/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/Tahler/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tahler/istio/labels{/name}","releases_url":"https://api.github.com/repos/Tahler/istio/releases{/id}","deployments_url":"https://api.github.com/repos/Tahler/istio/deployments","created_at":"2018-04-10T23:30:58Z","updated_at":"2018-08-07T18:48:09Z","pushed_at":"2018-08-07T18:53:11Z","git_url":"git://github.com/Tahler/istio.git","ssh_url":"git@github.com:Tahler/istio.git","clone_url":"https://github.com/Tahler/istio.git","svn_url":"https://github.com/Tahler/istio","homepage":"https://istio.io","size":42232,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"c3d749f0a1cc4fb7fdd76623bfdf9f1facd805e4","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-08-07T19:36:26Z","pushed_at":"2018-08-07T19:44:41Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":42745,"stargazers_count":10570,"watchers_count":10570,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1477,"mirror_url":null,"archived":false,"open_issues_count":865,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1477,"open_issues":865,"watchers":10570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/7680"},"html":{"href":"https://github.com/istio/istio/pull/7680"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/7680"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/7680/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/7680/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/7680/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/6019fdd31c5c04ef66189842cf3d0b2688435b72"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":37,"changed_files":15}}
{"actor":{"display_login":"istio-testing"}}