{"action":"created","comment":{"url":"https://api.github.com/repos/angular/protractor/pulls/comments/231715047","pull_request_review_id":172741258,"id":231715047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTcxNTA0Nw==","diff_hunk":"@@ -1,255 +1,250 @@\n-var EC = protractor.ExpectedConditions;\n+const EC = protractor.ExpectedConditions;\n \n-describe('expected conditions', function() {\n-  beforeEach(function() {\n-    browser.get('index.html#/form');\n+describe('expected conditions', () => {\n+  beforeEach(async () => {\n+    await browser.get('index.html#/form');\n   });\n \n-  it('should have alertIsPresent', function() {\n-    var alertIsPresent = EC.alertIsPresent();\n+  it('should have alertIsPresent', async () => {\n+    const alertIsPresent = await EC.alertIsPresent();\n     expect(alertIsPresent.call()).toBe(false);\n \n-    var alertButton = $('#alertbutton');\n-    alertButton.click();\n-    browser.wait(protractor.ExpectedConditions.alertIsPresent(), 5000);\n-    browser.switchTo().alert().accept();\n+    const alertButton = $('#alertbutton');\n+    await alertButton.click();\n+    await browser.wait(protractor.ExpectedConditions.alertIsPresent(), 5000);\n+    await browser.switchTo().alert().accept();\n   });\n \n-  it('should have presenceOf', function() {\n-    var presenceOfInvalid = EC.presenceOf($('#INVALID'));\n-    var presenceOfHideable = EC.presenceOf($('#shower'));\n+  it('should have presenceOf', async () => {\n+    const presenceOfInvalid = await EC.presenceOf($('#INVALID'));\n+    const presenceOfHideable = await EC.presenceOf($('#shower'));\n \n     expect(presenceOfInvalid.call()).toBe(false);\n     expect(presenceOfHideable.call()).toBe(true);\n-    element(by.model('show')).click();\n+    await element(by.model('show')).click();\n     expect(presenceOfHideable.call()).toBe(true); // Should be able to reuse.\n   });\n \n-  it('should have stalenessOf', function() {\n-    var stalenessOfInvalid = EC.stalenessOf($('#INVALID'));\n-    var stalenessOfHideable = EC.stalenessOf($('#shower'));\n+  it('should have stalenessOf', async () => {\n+    const stalenessOfInvalid = await EC.stalenessOf($('#INVALID'));\n+    const stalenessOfHideable = await EC.stalenessOf($('#shower'));\n \n     expect(stalenessOfInvalid.call()).toBe(true);\n     expect(stalenessOfHideable.call()).toBe(false);\n-    element(by.model('show')).click();\n+    await element(by.model('show')).click();\n     expect(stalenessOfHideable.call()).toBe(false);\n   });\n \n-  it('should have visibilityOf', function() {\n-    var visibilityOfInvalid = EC.visibilityOf($('#INVALID'));\n-    var visibilityOfHideable = EC.visibilityOf($('#shower'));\n+  it('should have visibilityOf', async () => {\n+    const visibilityOfInvalid = await EC.visibilityOf($('#INVALID'));\n+    const visibilityOfHideable = await EC.visibilityOf($('#shower'));\n \n     expect(visibilityOfInvalid.call()).toBe(false);\n     expect(visibilityOfHideable.call()).toBe(true);\n-    element(by.model('show')).click();\n+    await element(by.model('show')).click();\n     expect(visibilityOfHideable.call()).toBe(false);\n   });\n \n-  it('should have invisibilityOf', function() {\n-    var invisibilityOfInvalid = EC.invisibilityOf($('#INVALID'));\n-    var invisibilityOfHideable = EC.invisibilityOf($('#shower'));\n+  it('should have invisibilityOf', async () => {\n+    const invisibilityOfInvalid = await EC.invisibilityOf($('#INVALID'));","path":"spec/basic/expected_conditions_spec.js","position":74,"original_position":74,"commit_id":"51d42960f8b9bf1789703dd74bb3df8f13fdbfaf","original_commit_id":"51d42960f8b9bf1789703dd74bb3df8f13fdbfaf","user":{"login":"cnishina","id":1559007,"node_id":"MDQ6VXNlcjE1NTkwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1559007?v=4","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"Similar issue as above.\r\n\r\nhttps://github.com/angular/protractor/blob/master/lib/expectedConditions.ts#L399-L416","created_at":"2018-11-07T23:17:43Z","updated_at":"2018-11-07T23:20:24Z","html_url":"https://github.com/angular/protractor/pull/5006#discussion_r231715047","pull_request_url":"https://api.github.com/repos/angular/protractor/pulls/5006","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments/231715047"},"html":{"href":"https://github.com/angular/protractor/pull/5006#discussion_r231715047"},"pull_request":{"href":"https://api.github.com/repos/angular/protractor/pulls/5006"}}},"pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/5006","id":229196487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTk2NDg3","html_url":"https://github.com/angular/protractor/pull/5006","diff_url":"https://github.com/angular/protractor/pull/5006.diff","patch_url":"https://github.com/angular/protractor/pull/5006.patch","issue_url":"https://api.github.com/repos/angular/protractor/issues/5006","number":5006,"state":"open","locked":false,"title":"chore(test): move expected_conditions_spec.js off of the control flow","user":{"login":"CrispusDH","id":12623263,"node_id":"MDQ6VXNlcjEyNjIzMjYz","avatar_url":"https://avatars0.githubusercontent.com/u/12623263?v=4","gravatar_id":"","url":"https://api.github.com/users/CrispusDH","html_url":"https://github.com/CrispusDH","followers_url":"https://api.github.com/users/CrispusDH/followers","following_url":"https://api.github.com/users/CrispusDH/following{/other_user}","gists_url":"https://api.github.com/users/CrispusDH/gists{/gist_id}","starred_url":"https://api.github.com/users/CrispusDH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrispusDH/subscriptions","organizations_url":"https://api.github.com/users/CrispusDH/orgs","repos_url":"https://api.github.com/users/CrispusDH/repos","events_url":"https://api.github.com/users/CrispusDH/events{/privacy}","received_events_url":"https://api.github.com/users/CrispusDH/received_events","type":"User","site_admin":false},"body":"- update`expected_conditions_spec`\r\n- I'm not sure what to do with `cripts/test.js`","created_at":"2018-11-07T22:57:45Z","updated_at":"2018-11-07T23:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58195c3a8c5dbd293b3bc80909736aaeac1f1284","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":70978687,"node_id":"MDU6TGFiZWw3MDk3ODY4Nw==","url":"https://api.github.com/repos/angular/protractor/labels/cla:%20yes","name":"cla: yes","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/protractor/pulls/5006/commits","review_comments_url":"https://api.github.com/repos/angular/protractor/pulls/5006/comments","review_comment_url":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/protractor/issues/5006/comments","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/51d42960f8b9bf1789703dd74bb3df8f13fdbfaf","head":{"label":"CrispusDH:expected_conditions_spec","ref":"expected_conditions_spec","sha":"51d42960f8b9bf1789703dd74bb3df8f13fdbfaf","user":{"login":"CrispusDH","id":12623263,"node_id":"MDQ6VXNlcjEyNjIzMjYz","avatar_url":"https://avatars0.githubusercontent.com/u/12623263?v=4","gravatar_id":"","url":"https://api.github.com/users/CrispusDH","html_url":"https://github.com/CrispusDH","followers_url":"https://api.github.com/users/CrispusDH/followers","following_url":"https://api.github.com/users/CrispusDH/following{/other_user}","gists_url":"https://api.github.com/users/CrispusDH/gists{/gist_id}","starred_url":"https://api.github.com/users/CrispusDH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrispusDH/subscriptions","organizations_url":"https://api.github.com/users/CrispusDH/orgs","repos_url":"https://api.github.com/users/CrispusDH/repos","events_url":"https://api.github.com/users/CrispusDH/events{/privacy}","received_events_url":"https://api.github.com/users/CrispusDH/received_events","type":"User","site_admin":false},"repo":{"id":156518255,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1MTgyNTU=","name":"protractor","full_name":"CrispusDH/protractor","private":false,"owner":{"login":"CrispusDH","id":12623263,"node_id":"MDQ6VXNlcjEyNjIzMjYz","avatar_url":"https://avatars0.githubusercontent.com/u/12623263?v=4","gravatar_id":"","url":"https://api.github.com/users/CrispusDH","html_url":"https://github.com/CrispusDH","followers_url":"https://api.github.com/users/CrispusDH/followers","following_url":"https://api.github.com/users/CrispusDH/following{/other_user}","gists_url":"https://api.github.com/users/CrispusDH/gists{/gist_id}","starred_url":"https://api.github.com/users/CrispusDH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrispusDH/subscriptions","organizations_url":"https://api.github.com/users/CrispusDH/orgs","repos_url":"https://api.github.com/users/CrispusDH/repos","events_url":"https://api.github.com/users/CrispusDH/events{/privacy}","received_events_url":"https://api.github.com/users/CrispusDH/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CrispusDH/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/CrispusDH/protractor","forks_url":"https://api.github.com/repos/CrispusDH/protractor/forks","keys_url":"https://api.github.com/repos/CrispusDH/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CrispusDH/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CrispusDH/protractor/teams","hooks_url":"https://api.github.com/repos/CrispusDH/protractor/hooks","issue_events_url":"https://api.github.com/repos/CrispusDH/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/CrispusDH/protractor/events","assignees_url":"https://api.github.com/repos/CrispusDH/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/CrispusDH/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/CrispusDH/protractor/tags","blobs_url":"https://api.github.com/repos/CrispusDH/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CrispusDH/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CrispusDH/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/CrispusDH/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CrispusDH/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/CrispusDH/protractor/languages","stargazers_url":"https://api.github.com/repos/CrispusDH/protractor/stargazers","contributors_url":"https://api.github.com/repos/CrispusDH/protractor/contributors","subscribers_url":"https://api.github.com/repos/CrispusDH/protractor/subscribers","subscription_url":"https://api.github.com/repos/CrispusDH/protractor/subscription","commits_url":"https://api.github.com/repos/CrispusDH/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/CrispusDH/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/CrispusDH/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/CrispusDH/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/CrispusDH/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/CrispusDH/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CrispusDH/protractor/merges","archive_url":"https://api.github.com/repos/CrispusDH/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CrispusDH/protractor/downloads","issues_url":"https://api.github.com/repos/CrispusDH/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/CrispusDH/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/CrispusDH/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/CrispusDH/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CrispusDH/protractor/labels{/name}","releases_url":"https://api.github.com/repos/CrispusDH/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/CrispusDH/protractor/deployments","created_at":"2018-11-07T08:59:24Z","updated_at":"2018-11-07T08:59:27Z","pushed_at":"2018-11-07T22:58:26Z","git_url":"git://github.com/CrispusDH/protractor.git","ssh_url":"git@github.com:CrispusDH/protractor.git","clone_url":"https://github.com/CrispusDH/protractor.git","svn_url":"https://github.com/CrispusDH/protractor","homepage":"http://www.protractortest.org","size":8711,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:selenium4","ref":"selenium4","sha":"f11cdf453aebdc0d8ceb127eddee5b5c80147b63","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":7639232,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5MjMy","name":"protractor","full_name":"angular/protractor","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/protractor","description":"E2E test framework for Angular apps","fork":false,"url":"https://api.github.com/repos/angular/protractor","forks_url":"https://api.github.com/repos/angular/protractor/forks","keys_url":"https://api.github.com/repos/angular/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/protractor/teams","hooks_url":"https://api.github.com/repos/angular/protractor/hooks","issue_events_url":"https://api.github.com/repos/angular/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/angular/protractor/events","assignees_url":"https://api.github.com/repos/angular/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/angular/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/angular/protractor/tags","blobs_url":"https://api.github.com/repos/angular/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/protractor/languages","stargazers_url":"https://api.github.com/repos/angular/protractor/stargazers","contributors_url":"https://api.github.com/repos/angular/protractor/contributors","subscribers_url":"https://api.github.com/repos/angular/protractor/subscribers","subscription_url":"https://api.github.com/repos/angular/protractor/subscription","commits_url":"https://api.github.com/repos/angular/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/angular/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/protractor/merges","archive_url":"https://api.github.com/repos/angular/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/protractor/downloads","issues_url":"https://api.github.com/repos/angular/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/angular/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/protractor/labels{/name}","releases_url":"https://api.github.com/repos/angular/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/angular/protractor/deployments","created_at":"2013-01-16T04:30:53Z","updated_at":"2018-11-07T14:06:28Z","pushed_at":"2018-11-07T22:58:27Z","git_url":"git://github.com/angular/protractor.git","ssh_url":"git@github.com:angular/protractor.git","clone_url":"https://github.com/angular/protractor.git","svn_url":"https://github.com/angular/protractor","homepage":"http://www.protractortest.org","size":8920,"stargazers_count":7871,"watchers_count":7871,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2086,"mirror_url":null,"archived":false,"open_issues_count":436,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2086,"open_issues":436,"watchers":7871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/5006"},"html":{"href":"https://github.com/angular/protractor/pull/5006"},"issue":{"href":"https://api.github.com/repos/angular/protractor/issues/5006"},"comments":{"href":"https://api.github.com/repos/angular/protractor/issues/5006/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/protractor/pulls/5006/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/protractor/pulls/5006/commits"},"statuses":{"href":"https://api.github.com/repos/angular/protractor/statuses/51d42960f8b9bf1789703dd74bb3df8f13fdbfaf"}},"author_association":"NONE"}}
{"actor":{"display_login":"cnishina"}}