{"action":"opened","number":7067,"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7067","id":177248588,"html_url":"https://github.com/coq/coq/pull/7067","diff_url":"https://github.com/coq/coq/pull/7067.diff","patch_url":"https://github.com/coq/coq/pull/7067.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/7067","number":7067,"state":"open","locked":false,"title":"Porting congruence further to new tactic engine and econstr + fix prim. proj.","user":{"login":"herbelin","id":460771,"avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"body":"**Kind:** cleanup, fix\r\n\r\nThis PR is about the implementation of `congruence`. It includes three components:\r\n- getting rid of a call to a V82 layer of the proof engine (see commit message for explanation)\r\n- moving hashtables from constr to econstr (we represent terms by a pair (sigma,term) so that we can use EConstr equality to compare the terms indexing the tables)\r\n- fixing what seems a bug with primitive projections (there was a special treatment of primitive projections constant which seems buggy and redundant; at least removing this code makes congruence working more with primitive projections; @mattam82, am I missing something? do you remember the intent of this code? maybe the objective was to make the projections compact again after expansion? If so, the fix should be improved)\r\n\r\nAs a consequence, `abort_on_undefined_evars:false` should not be needed anymore in plugin `cc` for #6454.","created_at":"2018-03-24T17:27:28Z","updated_at":"2018-03-24T17:27:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/7067/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/7067/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/7067/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/ab55bef02b6ab703ec2140057668ac34c960be9e","head":{"label":"herbelin:master+congruence-econstr-tactic-engine-update","ref":"master+congruence-econstr-tactic-engine-update","sha":"ab55bef02b6ab703ec2140057668ac34c960be9e","user":{"login":"herbelin","id":460771,"avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"repo":{"id":38120719,"name":"github-coq","full_name":"herbelin/github-coq","owner":{"login":"herbelin","id":460771,"avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/herbelin/github-coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/herbelin/github-coq","forks_url":"https://api.github.com/repos/herbelin/github-coq/forks","keys_url":"https://api.github.com/repos/herbelin/github-coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/herbelin/github-coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/herbelin/github-coq/teams","hooks_url":"https://api.github.com/repos/herbelin/github-coq/hooks","issue_events_url":"https://api.github.com/repos/herbelin/github-coq/issues/events{/number}","events_url":"https://api.github.com/repos/herbelin/github-coq/events","assignees_url":"https://api.github.com/repos/herbelin/github-coq/assignees{/user}","branches_url":"https://api.github.com/repos/herbelin/github-coq/branches{/branch}","tags_url":"https://api.github.com/repos/herbelin/github-coq/tags","blobs_url":"https://api.github.com/repos/herbelin/github-coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/herbelin/github-coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/herbelin/github-coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/herbelin/github-coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/herbelin/github-coq/statuses/{sha}","languages_url":"https://api.github.com/repos/herbelin/github-coq/languages","stargazers_url":"https://api.github.com/repos/herbelin/github-coq/stargazers","contributors_url":"https://api.github.com/repos/herbelin/github-coq/contributors","subscribers_url":"https://api.github.com/repos/herbelin/github-coq/subscribers","subscription_url":"https://api.github.com/repos/herbelin/github-coq/subscription","commits_url":"https://api.github.com/repos/herbelin/github-coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/herbelin/github-coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/herbelin/github-coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/herbelin/github-coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/herbelin/github-coq/contents/{+path}","compare_url":"https://api.github.com/repos/herbelin/github-coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/herbelin/github-coq/merges","archive_url":"https://api.github.com/repos/herbelin/github-coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/herbelin/github-coq/downloads","issues_url":"https://api.github.com/repos/herbelin/github-coq/issues{/number}","pulls_url":"https://api.github.com/repos/herbelin/github-coq/pulls{/number}","milestones_url":"https://api.github.com/repos/herbelin/github-coq/milestones{/number}","notifications_url":"https://api.github.com/repos/herbelin/github-coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/herbelin/github-coq/labels{/name}","releases_url":"https://api.github.com/repos/herbelin/github-coq/releases{/id}","deployments_url":"https://api.github.com/repos/herbelin/github-coq/deployments","created_at":"2015-06-26T16:13:10Z","updated_at":"2016-01-14T13:45:40Z","pushed_at":"2018-03-24T17:20:45Z","git_url":"git://github.com/herbelin/github-coq.git","ssh_url":"git@github.com:herbelin/github-coq.git","clone_url":"https://github.com/herbelin/github-coq.git","svn_url":"https://github.com/herbelin/github-coq","homepage":"http://coq.inria.fr/","size":96473,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"coq:master","ref":"master","sha":"e128900aee63c972d7977fd47e3fd21649b63409","user":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-03-24T07:49:02Z","pushed_at":"2018-03-24T12:35:38Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":107587,"stargazers_count":1077,"watchers_count":1077,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":1469,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":236,"open_issues":1469,"watchers":1077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/7067"},"html":{"href":"https://github.com/coq/coq/pull/7067"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/7067"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/7067/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/7067/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/7067/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/ab55bef02b6ab703ec2140057668ac34c960be9e"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":84,"deletions":115,"changed_files":8}}
{"actor":{"display_login":"herbelin"}}