{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/170843576","pull_request_review_id":99590198,"id":170843576,"diff_hunk":"@@ -46,10 +46,10 @@ create the catalog that will be returned::\n                 }\n             }\n \n-            $catalogue = new MessageCatalogue($locale);\n-            $catalogue->add($messages, $domain);\n+            $messageCatalogue = new MessageCatalogue($locale);","path":"components/translation/custom_formats.rst","position":6,"original_position":6,"commit_id":"cbb509b74ecb7fa98956dc2f347ddd92cc44d1b5","original_commit_id":"cbb509b74ecb7fa98956dc2f347ddd92cc44d1b5","user":{"login":"kunicmarko20","id":13528674,"avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false},"body":"Not sure really, the other place was importing the translations I thought that it was appropriate to rename it like that and here we are working with `$messageCatalogue`, I can change it but I am not sure?","created_at":"2018-02-27T08:18:46Z","updated_at":"2018-02-27T08:18:46Z","html_url":"https://github.com/symfony/symfony-docs/pull/9354#discussion_r170843576","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/170843576"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/9354#discussion_r170843576"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354"}},"in_reply_to_id":170840534},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354","id":171511391,"html_url":"https://github.com/symfony/symfony-docs/pull/9354","diff_url":"https://github.com/symfony/symfony-docs/pull/9354.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/9354.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/9354","number":9354,"state":"open","locked":false,"title":"Improve naming in documentation","user":{"login":"kunicmarko20","id":13528674,"avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false},"body":"As the title says, I am trying to improve the naming of variables and some functions in the documentation. This started as just removing the abbreviations but while I needed to go through all files I tried to improve naming of everything that made sense to me.","created_at":"2018-02-26T22:33:37Z","updated_at":"2018-02-27T08:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ed647c4e9ec408fe280544ba48741b179f74668","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390692613,"url":"https://api.github.com/repos/symfony/symfony-docs/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/9354/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/cbb509b74ecb7fa98956dc2f347ddd92cc44d1b5","head":{"label":"kunicmarko20:improve_naming","ref":"improve_naming","sha":"cbb509b74ecb7fa98956dc2f347ddd92cc44d1b5","user":{"login":"kunicmarko20","id":13528674,"avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false},"repo":{"id":123013939,"name":"symfony-docs","full_name":"kunicmarko20/symfony-docs","owner":{"login":"kunicmarko20","id":13528674,"avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kunicmarko20/symfony-docs","description":"The Symfony documentation","fork":true,"url":"https://api.github.com/repos/kunicmarko20/symfony-docs","forks_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/forks","keys_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/teams","hooks_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/events","assignees_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/tags","blobs_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/subscription","commits_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/merges","archive_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/downloads","issues_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/releases{/id}","deployments_url":"https://api.github.com/repos/kunicmarko20/symfony-docs/deployments","created_at":"2018-02-26T18:41:07Z","updated_at":"2018-02-26T18:41:12Z","pushed_at":"2018-02-26T22:28:58Z","git_url":"git://github.com/kunicmarko20/symfony-docs.git","ssh_url":"git@github.com:kunicmarko20/symfony-docs.git","clone_url":"https://github.com/kunicmarko20/symfony-docs.git","svn_url":"https://github.com/kunicmarko20/symfony-docs","homepage":"http://symfony.com/doc","size":43744,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"541ab968de8909ba0a37f8fbd0d7ee1e90ef3118","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony-docs/deployments","created_at":"2010-02-17T08:43:51Z","updated_at":"2018-02-25T10:00:41Z","pushed_at":"2018-02-26T22:33:38Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc","size":45036,"stargazers_count":1366,"watchers_count":1366,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3412,"mirror_url":null,"archived":false,"open_issues_count":335,"license":null,"forks":3412,"open_issues":335,"watchers":1366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/9354"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/9354"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/9354/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/9354/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/cbb509b74ecb7fa98956dc2f347ddd92cc44d1b5"}},"author_association":"NONE"}}
{"actor":{"display_login":"kunicmarko20"}}