{"action":"created","issue":{"url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/46","repository_url":"https://api.github.com/repos/kaisalmen/WWOBJLoader","labels_url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/46/comments","events_url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/46/events","html_url":"https://github.com/kaisalmen/WWOBJLoader/pull/46","id":365185150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTgwNDgx","number":46,"title":"Support NodeJS","user":{"login":"Cobertos","id":6759176,"node_id":"MDQ6VXNlcjY3NTkxNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6759176?v=4","gravatar_id":"","url":"https://api.github.com/users/Cobertos","html_url":"https://github.com/Cobertos","followers_url":"https://api.github.com/users/Cobertos/followers","following_url":"https://api.github.com/users/Cobertos/following{/other_user}","gists_url":"https://api.github.com/users/Cobertos/gists{/gist_id}","starred_url":"https://api.github.com/users/Cobertos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cobertos/subscriptions","organizations_url":"https://api.github.com/users/Cobertos/orgs","repos_url":"https://api.github.com/users/Cobertos/repos","events_url":"https://api.github.com/users/Cobertos/events{/privacy}","received_events_url":"https://api.github.com/users/Cobertos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-30T02:37:43Z","updated_at":"2018-10-04T20:49:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/pulls/46","html_url":"https://github.com/kaisalmen/WWOBJLoader/pull/46","diff_url":"https://github.com/kaisalmen/WWOBJLoader/pull/46.diff","patch_url":"https://github.com/kaisalmen/WWOBJLoader/pull/46.patch"},"body":"This PR utilizes [the support that NodeJS added in `v10.5.0` for Workers](https://nodejs.org/api/worker_threads.html#worker_threads_new_worker_filename_options) to allow `LoaderWorkerSupport` and subsequently `WWOBJLoader2` to run in a NodeJS environment.\r\n\r\n- [x] Wrap all `window` usages in `if(typeof window !== \"undefined\")`\r\n- [x] Add branch for NodeJS specific code for all `Worker` related code.\r\n- [ ] Test it out in Nodejs environment\r\n- [ ] Test it out in Webpack environment\r\n\r\nLet me know if there's anything else you'd want me to add to this to fit the rest of the codebase!"},"comment":{"url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/comments/427164200","html_url":"https://github.com/kaisalmen/WWOBJLoader/pull/46#issuecomment-427164200","issue_url":"https://api.github.com/repos/kaisalmen/WWOBJLoader/issues/46","id":427164200,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE2NDIwMA==","user":{"login":"kaisalmen","id":21079138,"node_id":"MDQ6VXNlcjIxMDc5MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/21079138?v=4","gravatar_id":"","url":"https://api.github.com/users/kaisalmen","html_url":"https://github.com/kaisalmen","followers_url":"https://api.github.com/users/kaisalmen/followers","following_url":"https://api.github.com/users/kaisalmen/following{/other_user}","gists_url":"https://api.github.com/users/kaisalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/kaisalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaisalmen/subscriptions","organizations_url":"https://api.github.com/users/kaisalmen/orgs","repos_url":"https://api.github.com/users/kaisalmen/repos","events_url":"https://api.github.com/users/kaisalmen/events{/privacy}","received_events_url":"https://api.github.com/users/kaisalmen/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T20:49:00Z","updated_at":"2018-10-04T20:49:00Z","author_association":"OWNER","body":"I pushed an update and will merge now.\r\nNodeLoaderWorker must be contained inside WorkerSupport otherwise LoaderWorker cannot be found. Both are in \"private\" scope of \"WorkerSupport\".\r\nApart from this there are only code style fixes.\r\nThanks!\r\n"}}
{"actor":{"display_login":"kaisalmen"}}