{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/frappe/pulls/comments/179992021","pull_request_review_id":110333493,"id":179992021,"diff_hunk":"@@ -111,6 +111,8 @@ frappe.ui.notifications = {\n \t\tlet route = frappe.get_route();\n \t\tif(route[0]===\"List\" && route[1]===doctype) {\n \t\t\tfrappe.set_route(\"List\", doctype);\n+\t\t} else {\n+\t\t\tfrappe.set_route(\"List\", doctype);","path":"frappe/public/js/frappe/ui/toolbar/notifications.js","position":5,"original_position":5,"commit_id":"0309e37d453b838a679c07c474964e8c85bf9218","original_commit_id":"0309e37d453b838a679c07c474964e8c85bf9218","user":{"login":"rmehta","id":140076,"avatar_url":"https://avatars1.githubusercontent.com/u/140076?v=4","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"body":"what are you trying to fix? \r\n\r\nCheck your code... if / else has same routing!","created_at":"2018-04-09T05:47:09Z","updated_at":"2018-04-09T05:47:13Z","html_url":"https://github.com/frappe/frappe/pull/5411#discussion_r179992021","pull_request_url":"https://api.github.com/repos/frappe/frappe/pulls/5411","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments/179992021"},"html":{"href":"https://github.com/frappe/frappe/pull/5411#discussion_r179992021"},"pull_request":{"href":"https://api.github.com/repos/frappe/frappe/pulls/5411"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/5411","id":180212478,"html_url":"https://github.com/frappe/frappe/pull/5411","diff_url":"https://github.com/frappe/frappe/pull/5411.diff","patch_url":"https://github.com/frappe/frappe/pull/5411.patch","issue_url":"https://api.github.com/repos/frappe/frappe/issues/5411","number":5411,"state":"open","locked":false,"title":"[ Minor ] Routing issue on click of notification","user":{"login":"Zlash65","id":11695402,"avatar_url":"https://avatars0.githubusercontent.com/u/11695402?v=4","gravatar_id":"","url":"https://api.github.com/users/Zlash65","html_url":"https://github.com/Zlash65","followers_url":"https://api.github.com/users/Zlash65/followers","following_url":"https://api.github.com/users/Zlash65/following{/other_user}","gists_url":"https://api.github.com/users/Zlash65/gists{/gist_id}","starred_url":"https://api.github.com/users/Zlash65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zlash65/subscriptions","organizations_url":"https://api.github.com/users/Zlash65/orgs","repos_url":"https://api.github.com/users/Zlash65/repos","events_url":"https://api.github.com/users/Zlash65/events{/privacy}","received_events_url":"https://api.github.com/users/Zlash65/received_events","type":"User","site_admin":false},"body":"Issue - https://github.com/frappe/erpnext/issues/13560\r\n\r\nFix:- \r\n![fix-noti](https://user-images.githubusercontent.com/11695402/38480328-b804c03e-3be2-11e8-9989-4e249acc00bc.gif)\r\n","created_at":"2018-04-09T05:14:18Z","updated_at":"2018-04-09T05:47:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b431fd142700f1b7c4be9db6b5556956ba16b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/frappe/pulls/5411/commits","review_comments_url":"https://api.github.com/repos/frappe/frappe/pulls/5411/comments","review_comment_url":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/5411/comments","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/0309e37d453b838a679c07c474964e8c85bf9218","head":{"label":"Zlash65:notifix","ref":"notifix","sha":"0309e37d453b838a679c07c474964e8c85bf9218","user":{"login":"Zlash65","id":11695402,"avatar_url":"https://avatars0.githubusercontent.com/u/11695402?v=4","gravatar_id":"","url":"https://api.github.com/users/Zlash65","html_url":"https://github.com/Zlash65","followers_url":"https://api.github.com/users/Zlash65/followers","following_url":"https://api.github.com/users/Zlash65/following{/other_user}","gists_url":"https://api.github.com/users/Zlash65/gists{/gist_id}","starred_url":"https://api.github.com/users/Zlash65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zlash65/subscriptions","organizations_url":"https://api.github.com/users/Zlash65/orgs","repos_url":"https://api.github.com/users/Zlash65/repos","events_url":"https://api.github.com/users/Zlash65/events{/privacy}","received_events_url":"https://api.github.com/users/Zlash65/received_events","type":"User","site_admin":false},"repo":{"id":96340748,"name":"frappe","full_name":"Zlash65/frappe","owner":{"login":"Zlash65","id":11695402,"avatar_url":"https://avatars0.githubusercontent.com/u/11695402?v=4","gravatar_id":"","url":"https://api.github.com/users/Zlash65","html_url":"https://github.com/Zlash65","followers_url":"https://api.github.com/users/Zlash65/followers","following_url":"https://api.github.com/users/Zlash65/following{/other_user}","gists_url":"https://api.github.com/users/Zlash65/gists{/gist_id}","starred_url":"https://api.github.com/users/Zlash65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zlash65/subscriptions","organizations_url":"https://api.github.com/users/Zlash65/orgs","repos_url":"https://api.github.com/users/Zlash65/repos","events_url":"https://api.github.com/users/Zlash65/events{/privacy}","received_events_url":"https://api.github.com/users/Zlash65/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zlash65/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":true,"url":"https://api.github.com/repos/Zlash65/frappe","forks_url":"https://api.github.com/repos/Zlash65/frappe/forks","keys_url":"https://api.github.com/repos/Zlash65/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zlash65/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zlash65/frappe/teams","hooks_url":"https://api.github.com/repos/Zlash65/frappe/hooks","issue_events_url":"https://api.github.com/repos/Zlash65/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/Zlash65/frappe/events","assignees_url":"https://api.github.com/repos/Zlash65/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/Zlash65/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/Zlash65/frappe/tags","blobs_url":"https://api.github.com/repos/Zlash65/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zlash65/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zlash65/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zlash65/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zlash65/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/Zlash65/frappe/languages","stargazers_url":"https://api.github.com/repos/Zlash65/frappe/stargazers","contributors_url":"https://api.github.com/repos/Zlash65/frappe/contributors","subscribers_url":"https://api.github.com/repos/Zlash65/frappe/subscribers","subscription_url":"https://api.github.com/repos/Zlash65/frappe/subscription","commits_url":"https://api.github.com/repos/Zlash65/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zlash65/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zlash65/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zlash65/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zlash65/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/Zlash65/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zlash65/frappe/merges","archive_url":"https://api.github.com/repos/Zlash65/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zlash65/frappe/downloads","issues_url":"https://api.github.com/repos/Zlash65/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/Zlash65/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/Zlash65/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/Zlash65/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zlash65/frappe/labels{/name}","releases_url":"https://api.github.com/repos/Zlash65/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/Zlash65/frappe/deployments","created_at":"2017-07-05T16:43:03Z","updated_at":"2018-04-09T04:18:56Z","pushed_at":"2018-04-09T05:09:29Z","git_url":"git://github.com/Zlash65/frappe.git","ssh_url":"git@github.com:Zlash65/frappe.git","clone_url":"https://github.com/Zlash65/frappe.git","svn_url":"https://github.com/Zlash65/frappe","homepage":"http://frappe.io","size":162025,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"00ebc34d39e71450fa968202badfa0e303a00e43","user":{"login":"frappe","id":836974,"avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864194,"name":"frappe","full_name":"frappe/frappe","owner":{"login":"frappe","id":836974,"avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":false,"url":"https://api.github.com/repos/frappe/frappe","forks_url":"https://api.github.com/repos/frappe/frappe/forks","keys_url":"https://api.github.com/repos/frappe/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/frappe/teams","hooks_url":"https://api.github.com/repos/frappe/frappe/hooks","issue_events_url":"https://api.github.com/repos/frappe/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/frappe/events","assignees_url":"https://api.github.com/repos/frappe/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/frappe/tags","blobs_url":"https://api.github.com/repos/frappe/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/frappe/languages","stargazers_url":"https://api.github.com/repos/frappe/frappe/stargazers","contributors_url":"https://api.github.com/repos/frappe/frappe/contributors","subscribers_url":"https://api.github.com/repos/frappe/frappe/subscribers","subscription_url":"https://api.github.com/repos/frappe/frappe/subscription","commits_url":"https://api.github.com/repos/frappe/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/frappe/merges","archive_url":"https://api.github.com/repos/frappe/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/frappe/downloads","issues_url":"https://api.github.com/repos/frappe/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/frappe/labels{/name}","releases_url":"https://api.github.com/repos/frappe/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/frappe/deployments","created_at":"2011-06-08T08:14:16Z","updated_at":"2018-04-09T05:29:31Z","pushed_at":"2018-04-09T05:42:33Z","git_url":"git://github.com/frappe/frappe.git","ssh_url":"git@github.com:frappe/frappe.git","clone_url":"https://github.com/frappe/frappe.git","svn_url":"https://github.com/frappe/frappe","homepage":"http://frappe.io","size":157671,"stargazers_count":863,"watchers_count":863,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":684,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":684,"open_issues":251,"watchers":863,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/5411"},"html":{"href":"https://github.com/frappe/frappe/pull/5411"},"issue":{"href":"https://api.github.com/repos/frappe/frappe/issues/5411"},"comments":{"href":"https://api.github.com/repos/frappe/frappe/issues/5411/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/frappe/pulls/5411/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/frappe/pulls/5411/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/frappe/statuses/0309e37d453b838a679c07c474964e8c85bf9218"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rmehta"}}