{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/506","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/506/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/506/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/506/events","html_url":"https://github.com/StrikeNP/trac_test/issues/506","id":330447998,"node_id":"MDU6SXNzdWUzMzA0NDc5OTg=","number":506,"title":"Latin hypercube: Troubleshoot convergence of RICO with KK microphysics (Trac #506)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":958019852,"node_id":"MDU6TGFiZWw5NTgwMTk4NTI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":958042830,"node_id":"MDU6TGFiZWw5NTgwNDI4MzA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":958019855,"node_id":"MDU6TGFiZWw5NTgwMTk4NTU=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/defect","name":"defect","color":"FFFFFF","default":false},{"id":958042829,"node_id":"MDU6TGFiZWw5NTgwNDI4Mjk=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/dschanen@uwm.edu","name":"dschanen@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/8","html_url":"https://github.com/StrikeNP/trac_test/milestone/8","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/8/labels","id":3408876,"node_id":"MDk6TWlsZXN0b25lMzQwODg3Ng==","number":8,"title":"Improve SILHS","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":34,"state":"open","created_at":"2018-06-07T19:59:06Z","updated_at":"2018-06-09T06:09:47Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-06-07T21:48:38Z","updated_at":"2018-06-09T06:12:50Z","closed_at":null,"author_association":"OWNER","body":"\nDave recently discovered that Latin hypercube doesn't converge when running RICO using KK microphysics (https://github.com/larson-group/clubb/issues/498).  \n\nWe should try to find the bug.  It used to work.\n\nAttachments:\n\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/506/lh_rrainmc.png\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/506\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2012-07-03T19:19:21\", \n    \"description\": \"\\nDave recently discovered that Latin hypercube doesn't converge when running RICO using KK microphysics (comment:27:ticket:498).  \\n\\nWe should try to find the bug.  It used to work.\", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1341343161761514\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Latin hypercube: Troubleshoot convergence of RICO with KK microphysics\", \n    \"priority\": \"critical\", \n    \"keywords\": \"\", \n    \"time\": \"2012-04-19T21:53:29\", \n    \"milestone\": \"Improve SILHS\", \n    \"owner\": \"dschanen@uwm.edu\", \n    \"type\": \"defect\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/395943626","html_url":"https://github.com/StrikeNP/trac_test/issues/506#issuecomment-395943626","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/506","id":395943626,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk0MzYyNg==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T06:12:50Z","updated_at":"2018-06-09T06:12:50Z","author_association":"OWNER","body":"Trac update at 2012/05/02 at 22:24\n\nvlarson@uwm.edu commented:\n\nReplying to [comment:5 dschanen@…]:\n> Replying to [comment:4 dschanen@…]:\n> > I've further isolated the problem and it appears to have happened after 5669.  I have a hypothesis as to what the nature of the problem is.  For the purposes of testing convergence we set the correlation of s and Nc to 0, because we lacked correlations between Nc and the other variables and the matrix couldn't be decomposed otherwise.  In clubb:changeset:5675 I removed the variable corr_sNc_cloud and corr_tNc_cloud, but those values were already inconsistent with values in the file corr_rico_cloud.in and corr_rico_below.in and had been for some time.  I tried setting the correlation of s and Nc to 0 in those files using the current code, but RICO still isn't converging.\n> After further testing and some debugging I've found there were two separate issues.  First, the correlation matrix files were inconsistent with the values from namelists (e.g. corr_sNc_cloud) and when the inconsistent namelist variables were removed in r5678 this led to the first bug that caused divergence.  This was corrected in r5691 and if we set the correlation between s and Nc to 0 in that version of the code will still converge.  Our current issue is with a change I made in r5713 when I removed Ncm from hydromet when l_predictnc is false.  We did this in order to prevent Ncm from being diffused in the Khairoutdinov Kogan case and then subsequently reset to the fixed value; this led to a very confusing budget for Ncm. See ticket #490 for more unresolved issues with the handling of Ncm vs. Nc in cloud.\n> The problem seems to be the following:\n> 1. We want Ncm and s to be uncorrelated in both cases, since latin hypercube can't handle it.  However, we have a software engineering problem with Ncm , since sometimes we want it in the hydromet array and sometimes we don't.\n> 2. In the r5713 I set the variable Ncm_in_cloud based the value of the rc_column, but this is obviously the wrong thing to do since RICO no longer converges with that assumption;  it seems to create an implicit correlation between s and Nc.  Furthermore, we probably don't want the Ncm_in_cloud variable in the code if it's not actually the in cloud value in the KK code.\n> \n> The fix for this isn't obvious to me.  I think basically we want to generate uncorrelated Ncm points, but then keep those points out of our other arrays for just the KK case.  It would also be nice to have an option to fix the correlation of s and t within the analytic code for convergence testing.\n\nDave and I discussed this.  We think that we should have two separate Nc variables: the Nc that's embedded in hydromet when (and only when) l_predictnc = .true., and another Nc variable (Ncm_diagnosed) which will do nothing when l_predictnc = .true. but hold the Latin hypercube samples when l_predictnc = .false..  If we're not using Latin hypercube and l_predictnc = .false., then Ncm_diagnosed is our value of Ncm.  \n\n"}}
{"actor":{"display_login":"StrikeNP"}}