{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/219775235","pull_request_review_id":158026332,"id":219775235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTc3NTIzNQ==","diff_hunk":"@@ -363,3 +365,25 @@ def get_declared_placeholders_for_obj(obj):\n     if not hasattr(obj, 'get_template'):\n         raise NotImplementedError('%s should implement get_template' % obj.__class__.__name__)\n     return get_placeholders(obj.get_template())\n+\n+\n+def run_placeholder_container_checks(container, user):\n+    \"\"\"\n+    Get all of the placeholders from the parents and","path":"cms/utils/placeholder.py","position":22,"original_position":22,"commit_id":"4a427490b878fb66ae2aaf52bf6387f8b5282978","original_commit_id":"4a427490b878fb66ae2aaf52bf6387f8b5282978","user":{"login":"chaosk","id":99521,"node_id":"MDQ6VXNlcjk5NTIx","avatar_url":"https://avatars2.githubusercontent.com/u/99521?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosk","html_url":"https://github.com/chaosk","followers_url":"https://api.github.com/users/chaosk/followers","following_url":"https://api.github.com/users/chaosk/following{/other_user}","gists_url":"https://api.github.com/users/chaosk/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosk/subscriptions","organizations_url":"https://api.github.com/users/chaosk/orgs","repos_url":"https://api.github.com/users/chaosk/repos","events_url":"https://api.github.com/users/chaosk/events{/privacy}","received_events_url":"https://api.github.com/users/chaosk/received_events","type":"User","site_admin":false},"body":"all of placeholders linked to container? I'd also rename container to source here, as that's the name used in a bunch of places already","created_at":"2018-09-24T09:28:22Z","updated_at":"2018-09-24T09:29:48Z","html_url":"https://github.com/divio/django-cms/pull/6529#discussion_r219775235","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/6529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/219775235"},"html":{"href":"https://github.com/divio/django-cms/pull/6529#discussion_r219775235"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6529"}}},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/6529","id":217225018,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjI1MDE4","html_url":"https://github.com/divio/django-cms/pull/6529","diff_url":"https://github.com/divio/django-cms/pull/6529.diff","patch_url":"https://github.com/divio/django-cms/pull/6529.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/6529","number":6529,"state":"open","locked":false,"title":"Edit endpoint checks integration","user":{"login":"Aiky30","id":12543977,"node_id":"MDQ6VXNlcjEyNTQzOTc3","avatar_url":"https://avatars2.githubusercontent.com/u/12543977?v=4","gravatar_id":"","url":"https://api.github.com/users/Aiky30","html_url":"https://github.com/Aiky30","followers_url":"https://api.github.com/users/Aiky30/followers","following_url":"https://api.github.com/users/Aiky30/following{/other_user}","gists_url":"https://api.github.com/users/Aiky30/gists{/gist_id}","starred_url":"https://api.github.com/users/Aiky30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aiky30/subscriptions","organizations_url":"https://api.github.com/users/Aiky30/orgs","repos_url":"https://api.github.com/users/Aiky30/repos","events_url":"https://api.github.com/users/Aiky30/events{/privacy}","received_events_url":"https://api.github.com/users/Aiky30/received_events","type":"User","site_admin":false},"body":"\r\n### Documentation checklist\r\n\r\n* [ ] I have updated CHANGELOG.txt if appropriate\r\n* [ ] I have updated the release notes document if appropriate, with:\r\n    * [ ] general notes\r\n    * [ ] bug-fixes\r\n    * [ ] improvements/new features\r\n    * [ ] backwards-incompatible changes\r\n    * [ ] required upgrade steps\r\n    * [ ] names of contributors\r\n* [ ] I have updated other documentation\r\n* [ ] I have added my name to the AUTHORS file\r\n* [ ] This PR's documentation has been approved by Daniele Procida\r\n","created_at":"2018-09-21T09:32:42Z","updated_at":"2018-09-24T09:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"556905001d6d46f63a5bb584e2ddc467be95dd96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/6529/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/6529/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/6529/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/4a427490b878fb66ae2aaf52bf6387f8b5282978","head":{"label":"FidelityInternational:feature/edit-endpoint-checks-integration","ref":"feature/edit-endpoint-checks-integration","sha":"4a427490b878fb66ae2aaf52bf6387f8b5282978","user":{"login":"FidelityInternational","id":17474425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDc0NDI1","avatar_url":"https://avatars1.githubusercontent.com/u/17474425?v=4","gravatar_id":"","url":"https://api.github.com/users/FidelityInternational","html_url":"https://github.com/FidelityInternational","followers_url":"https://api.github.com/users/FidelityInternational/followers","following_url":"https://api.github.com/users/FidelityInternational/following{/other_user}","gists_url":"https://api.github.com/users/FidelityInternational/gists{/gist_id}","starred_url":"https://api.github.com/users/FidelityInternational/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FidelityInternational/subscriptions","organizations_url":"https://api.github.com/users/FidelityInternational/orgs","repos_url":"https://api.github.com/users/FidelityInternational/repos","events_url":"https://api.github.com/users/FidelityInternational/events{/privacy}","received_events_url":"https://api.github.com/users/FidelityInternational/received_events","type":"Organization","site_admin":false},"repo":{"id":138866204,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NjYyMDQ=","name":"django-cms","full_name":"FidelityInternational/django-cms","private":false,"owner":{"login":"FidelityInternational","id":17474425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDc0NDI1","avatar_url":"https://avatars1.githubusercontent.com/u/17474425?v=4","gravatar_id":"","url":"https://api.github.com/users/FidelityInternational","html_url":"https://github.com/FidelityInternational","followers_url":"https://api.github.com/users/FidelityInternational/followers","following_url":"https://api.github.com/users/FidelityInternational/following{/other_user}","gists_url":"https://api.github.com/users/FidelityInternational/gists{/gist_id}","starred_url":"https://api.github.com/users/FidelityInternational/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FidelityInternational/subscriptions","organizations_url":"https://api.github.com/users/FidelityInternational/orgs","repos_url":"https://api.github.com/users/FidelityInternational/repos","events_url":"https://api.github.com/users/FidelityInternational/events{/privacy}","received_events_url":"https://api.github.com/users/FidelityInternational/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FidelityInternational/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":true,"url":"https://api.github.com/repos/FidelityInternational/django-cms","forks_url":"https://api.github.com/repos/FidelityInternational/django-cms/forks","keys_url":"https://api.github.com/repos/FidelityInternational/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FidelityInternational/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FidelityInternational/django-cms/teams","hooks_url":"https://api.github.com/repos/FidelityInternational/django-cms/hooks","issue_events_url":"https://api.github.com/repos/FidelityInternational/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/FidelityInternational/django-cms/events","assignees_url":"https://api.github.com/repos/FidelityInternational/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/FidelityInternational/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/FidelityInternational/django-cms/tags","blobs_url":"https://api.github.com/repos/FidelityInternational/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FidelityInternational/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FidelityInternational/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/FidelityInternational/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FidelityInternational/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/FidelityInternational/django-cms/languages","stargazers_url":"https://api.github.com/repos/FidelityInternational/django-cms/stargazers","contributors_url":"https://api.github.com/repos/FidelityInternational/django-cms/contributors","subscribers_url":"https://api.github.com/repos/FidelityInternational/django-cms/subscribers","subscription_url":"https://api.github.com/repos/FidelityInternational/django-cms/subscription","commits_url":"https://api.github.com/repos/FidelityInternational/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/FidelityInternational/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/FidelityInternational/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/FidelityInternational/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/FidelityInternational/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/FidelityInternational/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FidelityInternational/django-cms/merges","archive_url":"https://api.github.com/repos/FidelityInternational/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FidelityInternational/django-cms/downloads","issues_url":"https://api.github.com/repos/FidelityInternational/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/FidelityInternational/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/FidelityInternational/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/FidelityInternational/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FidelityInternational/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/FidelityInternational/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/FidelityInternational/django-cms/deployments","created_at":"2018-06-27T10:24:20Z","updated_at":"2018-06-27T10:24:26Z","pushed_at":"2018-09-21T16:11:57Z","git_url":"git://github.com/FidelityInternational/django-cms.git","ssh_url":"git@github.com:FidelityInternational/django-cms.git","clone_url":"https://github.com/FidelityInternational/django-cms.git","svn_url":"https://github.com/FidelityInternational/django-cms","homepage":"http://www.django-cms.org","size":80849,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"divio:release/4.0.x","ref":"release/4.0.x","sha":"aa363d356667836ad553688be00e111324a29f1e","user":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1ODA=","name":"django-cms","full_name":"divio/django-cms","private":false,"owner":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/divio/django-cms/deployments","created_at":"2009-03-05T10:14:18Z","updated_at":"2018-09-24T01:48:48Z","pushed_at":"2018-09-24T08:31:57Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":80695,"stargazers_count":6198,"watchers_count":6198,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2177,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2177,"open_issues":248,"watchers":6198,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6529"},"html":{"href":"https://github.com/divio/django-cms/pull/6529"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/6529"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/6529/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6529/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6529/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/4a427490b878fb66ae2aaf52bf6387f8b5282978"}},"author_association":"NONE"}}
{"actor":{"display_login":"chaosk"}}