{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104","id":234098073,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDk4MDcz","html_url":"https://github.com/c3bottles/c3bottles/pull/104","diff_url":"https://github.com/c3bottles/c3bottles/pull/104.diff","patch_url":"https://github.com/c3bottles/c3bottles/pull/104.patch","issue_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/104","number":104,"state":"closed","locked":false,"title":"Change Dockerfile to better cache build steps","user":{"login":"der-michik","id":6341204,"node_id":"MDQ6VXNlcjYzNDEyMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6341204?v=4","gravatar_id":"","url":"https://api.github.com/users/der-michik","html_url":"https://github.com/der-michik","followers_url":"https://api.github.com/users/der-michik/followers","following_url":"https://api.github.com/users/der-michik/following{/other_user}","gists_url":"https://api.github.com/users/der-michik/gists{/gist_id}","starred_url":"https://api.github.com/users/der-michik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-michik/subscriptions","organizations_url":"https://api.github.com/users/der-michik/orgs","repos_url":"https://api.github.com/users/der-michik/repos","events_url":"https://api.github.com/users/der-michik/events{/privacy}","received_events_url":"https://api.github.com/users/der-michik/received_events","type":"User","site_admin":false},"body":"The Dockerfile now has different steps for installing the system dependencies,\r\ninstalling the Python dependencies and installing the JavaScript dependencies.\r\nOnly after that, the actual frontend build takes place.\r\n\r\nThis allows for quick rebuilds of the image on code changes as we first copy\r\nrequirements.txt and package.json step by step, so the Python venv will only\r\nbe rebuilt when requirements.txt changes and the Node dependencies are only\r\ninstalled again if either the Python venv changes (which is the most\r\ntime-consuming step of the build process anyway, so the JS stuff doesn't\r\nreally matter here) or package.json/yarn.lock change.\r\n\r\nentrypoint.sh is not needed if we call Gunicorn directly from within the venv.","created_at":"2018-11-27T23:32:13Z","updated_at":"2018-11-28T20:12:35Z","closed_at":"2018-11-28T20:12:35Z","merged_at":"2018-11-28T20:12:35Z","merge_commit_sha":"b74e710bd014377b201e322ff23e72b2709c1c10","assignee":null,"assignees":[],"requested_reviewers":[{"login":"J-Ha","id":7397248,"node_id":"MDQ6VXNlcjczOTcyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7397248?v=4","gravatar_id":"","url":"https://api.github.com/users/J-Ha","html_url":"https://github.com/J-Ha","followers_url":"https://api.github.com/users/J-Ha/followers","following_url":"https://api.github.com/users/J-Ha/following{/other_user}","gists_url":"https://api.github.com/users/J-Ha/gists{/gist_id}","starred_url":"https://api.github.com/users/J-Ha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-Ha/subscriptions","organizations_url":"https://api.github.com/users/J-Ha/orgs","repos_url":"https://api.github.com/users/J-Ha/repos","events_url":"https://api.github.com/users/J-Ha/events{/privacy}","received_events_url":"https://api.github.com/users/J-Ha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104/commits","review_comments_url":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104/comments","review_comment_url":"https://api.github.com/repos/c3bottles/c3bottles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/104/comments","statuses_url":"https://api.github.com/repos/c3bottles/c3bottles/statuses/1de23cd2503407022239a462fc9d92922d57dea0","head":{"label":"c3bottles:docker-build-steps","ref":"docker-build-steps","sha":"1de23cd2503407022239a462fc9d92922d57dea0","user":{"login":"c3bottles","id":34207107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA3MTA3","avatar_url":"https://avatars2.githubusercontent.com/u/34207107?v=4","gravatar_id":"","url":"https://api.github.com/users/c3bottles","html_url":"https://github.com/c3bottles","followers_url":"https://api.github.com/users/c3bottles/followers","following_url":"https://api.github.com/users/c3bottles/following{/other_user}","gists_url":"https://api.github.com/users/c3bottles/gists{/gist_id}","starred_url":"https://api.github.com/users/c3bottles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3bottles/subscriptions","organizations_url":"https://api.github.com/users/c3bottles/orgs","repos_url":"https://api.github.com/users/c3bottles/repos","events_url":"https://api.github.com/users/c3bottles/events{/privacy}","received_events_url":"https://api.github.com/users/c3bottles/received_events","type":"Organization","site_admin":false},"repo":{"id":32449036,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ0OTAzNg==","name":"c3bottles","full_name":"c3bottles/c3bottles","private":false,"owner":{"login":"c3bottles","id":34207107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA3MTA3","avatar_url":"https://avatars2.githubusercontent.com/u/34207107?v=4","gravatar_id":"","url":"https://api.github.com/users/c3bottles","html_url":"https://github.com/c3bottles","followers_url":"https://api.github.com/users/c3bottles/followers","following_url":"https://api.github.com/users/c3bottles/following{/other_user}","gists_url":"https://api.github.com/users/c3bottles/gists{/gist_id}","starred_url":"https://api.github.com/users/c3bottles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3bottles/subscriptions","organizations_url":"https://api.github.com/users/c3bottles/orgs","repos_url":"https://api.github.com/users/c3bottles/repos","events_url":"https://api.github.com/users/c3bottles/events{/privacy}","received_events_url":"https://api.github.com/users/c3bottles/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/c3bottles/c3bottles","description":"Bottle drop and collection management system for chaos events","fork":false,"url":"https://api.github.com/repos/c3bottles/c3bottles","forks_url":"https://api.github.com/repos/c3bottles/c3bottles/forks","keys_url":"https://api.github.com/repos/c3bottles/c3bottles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c3bottles/c3bottles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c3bottles/c3bottles/teams","hooks_url":"https://api.github.com/repos/c3bottles/c3bottles/hooks","issue_events_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/events{/number}","events_url":"https://api.github.com/repos/c3bottles/c3bottles/events","assignees_url":"https://api.github.com/repos/c3bottles/c3bottles/assignees{/user}","branches_url":"https://api.github.com/repos/c3bottles/c3bottles/branches{/branch}","tags_url":"https://api.github.com/repos/c3bottles/c3bottles/tags","blobs_url":"https://api.github.com/repos/c3bottles/c3bottles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c3bottles/c3bottles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c3bottles/c3bottles/git/refs{/sha}","trees_url":"https://api.github.com/repos/c3bottles/c3bottles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c3bottles/c3bottles/statuses/{sha}","languages_url":"https://api.github.com/repos/c3bottles/c3bottles/languages","stargazers_url":"https://api.github.com/repos/c3bottles/c3bottles/stargazers","contributors_url":"https://api.github.com/repos/c3bottles/c3bottles/contributors","subscribers_url":"https://api.github.com/repos/c3bottles/c3bottles/subscribers","subscription_url":"https://api.github.com/repos/c3bottles/c3bottles/subscription","commits_url":"https://api.github.com/repos/c3bottles/c3bottles/commits{/sha}","git_commits_url":"https://api.github.com/repos/c3bottles/c3bottles/git/commits{/sha}","comments_url":"https://api.github.com/repos/c3bottles/c3bottles/comments{/number}","issue_comment_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/comments{/number}","contents_url":"https://api.github.com/repos/c3bottles/c3bottles/contents/{+path}","compare_url":"https://api.github.com/repos/c3bottles/c3bottles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c3bottles/c3bottles/merges","archive_url":"https://api.github.com/repos/c3bottles/c3bottles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c3bottles/c3bottles/downloads","issues_url":"https://api.github.com/repos/c3bottles/c3bottles/issues{/number}","pulls_url":"https://api.github.com/repos/c3bottles/c3bottles/pulls{/number}","milestones_url":"https://api.github.com/repos/c3bottles/c3bottles/milestones{/number}","notifications_url":"https://api.github.com/repos/c3bottles/c3bottles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c3bottles/c3bottles/labels{/name}","releases_url":"https://api.github.com/repos/c3bottles/c3bottles/releases{/id}","deployments_url":"https://api.github.com/repos/c3bottles/c3bottles/deployments","created_at":"2015-03-18T09:19:37Z","updated_at":"2018-11-28T20:01:39Z","pushed_at":"2018-11-28T20:12:35Z","git_url":"git://github.com/c3bottles/c3bottles.git","ssh_url":"git@github.com:c3bottles/c3bottles.git","clone_url":"https://github.com/c3bottles/c3bottles.git","svn_url":"https://github.com/c3bottles/c3bottles","homepage":null,"size":25192,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":7,"watchers":18,"default_branch":"master"}},"base":{"label":"c3bottles:master","ref":"master","sha":"773b9c1bdbb51ed8aeee2becdcdc30f2081bbf3f","user":{"login":"c3bottles","id":34207107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA3MTA3","avatar_url":"https://avatars2.githubusercontent.com/u/34207107?v=4","gravatar_id":"","url":"https://api.github.com/users/c3bottles","html_url":"https://github.com/c3bottles","followers_url":"https://api.github.com/users/c3bottles/followers","following_url":"https://api.github.com/users/c3bottles/following{/other_user}","gists_url":"https://api.github.com/users/c3bottles/gists{/gist_id}","starred_url":"https://api.github.com/users/c3bottles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3bottles/subscriptions","organizations_url":"https://api.github.com/users/c3bottles/orgs","repos_url":"https://api.github.com/users/c3bottles/repos","events_url":"https://api.github.com/users/c3bottles/events{/privacy}","received_events_url":"https://api.github.com/users/c3bottles/received_events","type":"Organization","site_admin":false},"repo":{"id":32449036,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ0OTAzNg==","name":"c3bottles","full_name":"c3bottles/c3bottles","private":false,"owner":{"login":"c3bottles","id":34207107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA3MTA3","avatar_url":"https://avatars2.githubusercontent.com/u/34207107?v=4","gravatar_id":"","url":"https://api.github.com/users/c3bottles","html_url":"https://github.com/c3bottles","followers_url":"https://api.github.com/users/c3bottles/followers","following_url":"https://api.github.com/users/c3bottles/following{/other_user}","gists_url":"https://api.github.com/users/c3bottles/gists{/gist_id}","starred_url":"https://api.github.com/users/c3bottles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c3bottles/subscriptions","organizations_url":"https://api.github.com/users/c3bottles/orgs","repos_url":"https://api.github.com/users/c3bottles/repos","events_url":"https://api.github.com/users/c3bottles/events{/privacy}","received_events_url":"https://api.github.com/users/c3bottles/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/c3bottles/c3bottles","description":"Bottle drop and collection management system for chaos events","fork":false,"url":"https://api.github.com/repos/c3bottles/c3bottles","forks_url":"https://api.github.com/repos/c3bottles/c3bottles/forks","keys_url":"https://api.github.com/repos/c3bottles/c3bottles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c3bottles/c3bottles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c3bottles/c3bottles/teams","hooks_url":"https://api.github.com/repos/c3bottles/c3bottles/hooks","issue_events_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/events{/number}","events_url":"https://api.github.com/repos/c3bottles/c3bottles/events","assignees_url":"https://api.github.com/repos/c3bottles/c3bottles/assignees{/user}","branches_url":"https://api.github.com/repos/c3bottles/c3bottles/branches{/branch}","tags_url":"https://api.github.com/repos/c3bottles/c3bottles/tags","blobs_url":"https://api.github.com/repos/c3bottles/c3bottles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c3bottles/c3bottles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c3bottles/c3bottles/git/refs{/sha}","trees_url":"https://api.github.com/repos/c3bottles/c3bottles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c3bottles/c3bottles/statuses/{sha}","languages_url":"https://api.github.com/repos/c3bottles/c3bottles/languages","stargazers_url":"https://api.github.com/repos/c3bottles/c3bottles/stargazers","contributors_url":"https://api.github.com/repos/c3bottles/c3bottles/contributors","subscribers_url":"https://api.github.com/repos/c3bottles/c3bottles/subscribers","subscription_url":"https://api.github.com/repos/c3bottles/c3bottles/subscription","commits_url":"https://api.github.com/repos/c3bottles/c3bottles/commits{/sha}","git_commits_url":"https://api.github.com/repos/c3bottles/c3bottles/git/commits{/sha}","comments_url":"https://api.github.com/repos/c3bottles/c3bottles/comments{/number}","issue_comment_url":"https://api.github.com/repos/c3bottles/c3bottles/issues/comments{/number}","contents_url":"https://api.github.com/repos/c3bottles/c3bottles/contents/{+path}","compare_url":"https://api.github.com/repos/c3bottles/c3bottles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c3bottles/c3bottles/merges","archive_url":"https://api.github.com/repos/c3bottles/c3bottles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c3bottles/c3bottles/downloads","issues_url":"https://api.github.com/repos/c3bottles/c3bottles/issues{/number}","pulls_url":"https://api.github.com/repos/c3bottles/c3bottles/pulls{/number}","milestones_url":"https://api.github.com/repos/c3bottles/c3bottles/milestones{/number}","notifications_url":"https://api.github.com/repos/c3bottles/c3bottles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c3bottles/c3bottles/labels{/name}","releases_url":"https://api.github.com/repos/c3bottles/c3bottles/releases{/id}","deployments_url":"https://api.github.com/repos/c3bottles/c3bottles/deployments","created_at":"2015-03-18T09:19:37Z","updated_at":"2018-11-28T20:01:39Z","pushed_at":"2018-11-28T20:12:35Z","git_url":"git://github.com/c3bottles/c3bottles.git","ssh_url":"git@github.com:c3bottles/c3bottles.git","clone_url":"https://github.com/c3bottles/c3bottles.git","svn_url":"https://github.com/c3bottles/c3bottles","homepage":null,"size":25192,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":7,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104"},"html":{"href":"https://github.com/c3bottles/c3bottles/pull/104"},"issue":{"href":"https://api.github.com/repos/c3bottles/c3bottles/issues/104"},"comments":{"href":"https://api.github.com/repos/c3bottles/c3bottles/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/c3bottles/c3bottles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c3bottles/c3bottles/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/c3bottles/c3bottles/statuses/1de23cd2503407022239a462fc9d92922d57dea0"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"J-Ha","id":7397248,"node_id":"MDQ6VXNlcjczOTcyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7397248?v=4","gravatar_id":"","url":"https://api.github.com/users/J-Ha","html_url":"https://github.com/J-Ha","followers_url":"https://api.github.com/users/J-Ha/followers","following_url":"https://api.github.com/users/J-Ha/following{/other_user}","gists_url":"https://api.github.com/users/J-Ha/gists{/gist_id}","starred_url":"https://api.github.com/users/J-Ha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-Ha/subscriptions","organizations_url":"https://api.github.com/users/J-Ha/orgs","repos_url":"https://api.github.com/users/J-Ha/repos","events_url":"https://api.github.com/users/J-Ha/events{/privacy}","received_events_url":"https://api.github.com/users/J-Ha/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":10,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"J-Ha"}}