{"action":"created","issue":{"url":"https://api.github.com/repos/SCons/scons/issues/3099","repository_url":"https://api.github.com/repos/SCons/scons","labels_url":"https://api.github.com/repos/SCons/scons/issues/3099/labels{/name}","comments_url":"https://api.github.com/repos/SCons/scons/issues/3099/comments","events_url":"https://api.github.com/repos/SCons/scons/issues/3099/events","html_url":"https://github.com/SCons/scons/pull/3099","id":296230554,"number":3099,"title":"Windows clang tests","user":{"login":"dmoody256","id":6133964,"avatar_url":"https://avatars2.githubusercontent.com/u/6133964?v=4","gravatar_id":"","url":"https://api.github.com/users/dmoody256","html_url":"https://github.com/dmoody256","followers_url":"https://api.github.com/users/dmoody256/followers","following_url":"https://api.github.com/users/dmoody256/following{/other_user}","gists_url":"https://api.github.com/users/dmoody256/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoody256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoody256/subscriptions","organizations_url":"https://api.github.com/users/dmoody256/orgs","repos_url":"https://api.github.com/users/dmoody256/repos","events_url":"https://api.github.com/users/dmoody256/events{/privacy}","received_events_url":"https://api.github.com/users/dmoody256/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-11T22:06:31Z","updated_at":"2018-02-12T01:59:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SCons/scons/pulls/3099","html_url":"https://github.com/SCons/scons/pull/3099","diff_url":"https://github.com/SCons/scons/pull/3099.diff","patch_url":"https://github.com/SCons/scons/pull/3099.patch"},"body":"On windows, a SCons environment will only include the system32 path, unless default windows environment is used in which case the path is setup from the vcvars batch script.\r\n\r\nThe clang test do not use the msvs environment and therefore do not have the clang or other necessary cygwin binaries in the path when scons goes to build.\r\n\r\nThis pull request updates the test to add the correct binaries to the path, and skips tests that are meant to use the default environment.\r\n\r\n## Contributor Checklist:\r\n\r\n* [x] I have created a new test or updated the unit tests to cover the new/changed functionality.\r\n* [ ] I have updated `master/src/CHANGES.txt` directory (and read the `README.txt` in that directory)\r\n* [ ] I have updated the appropriate documentation"},"comment":{"url":"https://api.github.com/repos/SCons/scons/issues/comments/364813175","html_url":"https://github.com/SCons/scons/pull/3099#issuecomment-364813175","issue_url":"https://api.github.com/repos/SCons/scons/issues/3099","id":364813175,"user":{"login":"dmoody256","id":6133964,"avatar_url":"https://avatars2.githubusercontent.com/u/6133964?v=4","gravatar_id":"","url":"https://api.github.com/users/dmoody256","html_url":"https://github.com/dmoody256","followers_url":"https://api.github.com/users/dmoody256/followers","following_url":"https://api.github.com/users/dmoody256/following{/other_user}","gists_url":"https://api.github.com/users/dmoody256/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoody256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoody256/subscriptions","organizations_url":"https://api.github.com/users/dmoody256/orgs","repos_url":"https://api.github.com/users/dmoody256/repos","events_url":"https://api.github.com/users/dmoody256/events{/privacy}","received_events_url":"https://api.github.com/users/dmoody256/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T01:59:58Z","updated_at":"2018-02-12T01:59:58Z","author_association":"CONTRIBUTOR","body":"That would probably be the better solution. I wasn't sure the scons way to implement this though.\r\n\r\nWould I add some common default paths for clang and cygwin (checking for existence?) or would I look at the current os.environ PATH to find the location of the binaries if they exist, or a combination of both?"}}
{"actor":{"display_login":"dmoody256"}}