{"action":"created","comment":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/180104372","pull_request_review_id":110466444,"id":180104372,"diff_hunk":"@@ -74,37 +62,6 @@ public void testValidQppStream() {\n \t\t//no exception should be thrown, hence explicitly stating the expected exception is None\n \t}\n \n-\t@Test\n-\t@PrepareForTest({Converter.class, QrdaValidator.class})\n-\tpublic void testValidationErrors() throws Exception {","path":"converter/src/test/java/gov/cms/qpp/conversion/ConverterTest.java","position":69,"original_position":69,"commit_id":"6c6cae658e742100634865158d05d97ea9454334","original_commit_id":"6c6cae658e742100634865158d05d97ea9454334","user":{"login":"saquino0827","id":26700499,"avatar_url":"https://avatars3.githubusercontent.com/u/26700499?v=4","gravatar_id":"","url":"https://api.github.com/users/saquino0827","html_url":"https://github.com/saquino0827","followers_url":"https://api.github.com/users/saquino0827/followers","following_url":"https://api.github.com/users/saquino0827/following{/other_user}","gists_url":"https://api.github.com/users/saquino0827/gists{/gist_id}","starred_url":"https://api.github.com/users/saquino0827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquino0827/subscriptions","organizations_url":"https://api.github.com/users/saquino0827/orgs","repos_url":"https://api.github.com/users/saquino0827/repos","events_url":"https://api.github.com/users/saquino0827/events{/privacy}","received_events_url":"https://api.github.com/users/saquino0827/received_events","type":"User","site_admin":false},"body":"Okay. I just flat out removed it as we no longer were using defaults. I can see your point. I'll change this.","created_at":"2018-04-09T14:03:08Z","updated_at":"2018-04-09T14:03:08Z","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/673#discussion_r180104372","pull_request_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/180104372"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/673#discussion_r180104372"},"pull_request":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673"}},"in_reply_to_id":179885160},"pull_request":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673","id":178862512,"html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/673","diff_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/673.diff","patch_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/673.patch","issue_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/673","number":673,"state":"open","locked":false,"title":"Remove Default Decoder","user":{"login":"saquino0827","id":26700499,"avatar_url":"https://avatars3.githubusercontent.com/u/26700499?v=4","gravatar_id":"","url":"https://api.github.com/users/saquino0827","html_url":"https://github.com/saquino0827","followers_url":"https://api.github.com/users/saquino0827/followers","following_url":"https://api.github.com/users/saquino0827/following{/other_user}","gists_url":"https://api.github.com/users/saquino0827/gists{/gist_id}","starred_url":"https://api.github.com/users/saquino0827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquino0827/subscriptions","organizations_url":"https://api.github.com/users/saquino0827/orgs","repos_url":"https://api.github.com/users/saquino0827/repos","events_url":"https://api.github.com/users/saquino0827/events{/privacy}","received_events_url":"https://api.github.com/users/saquino0827/received_events","type":"User","site_admin":false},"body":"### Information\r\n- QPPCT-766\r\n\r\n### Changes proposed in this PR:\r\n- Removes the Default Decoder and tests using it.\r\n\r\n### Checklist \r\n- [x] All JUnit tests pass (`mvn clean verify`).\r\n- [n/a] New unit tests written to cover new functionality.\r\n- [n/a] Added and updated JavaDocs for non-test classes and methods.\r\n- [x] No local design debt. Do you feel that something is \"ugly\" after your changes?\r\n- [n/a] Updated documentation (`README.md`, etc.) depending if the changes require it.\r\n","created_at":"2018-04-02T15:30:39Z","updated_at":"2018-04-09T14:03:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b336945b2e30a931513572b2a2f4aa5cbf696e31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"clydet","id":1957663,"avatar_url":"https://avatars0.githubusercontent.com/u/1957663?v=4","gravatar_id":"","url":"https://api.github.com/users/clydet","html_url":"https://github.com/clydet","followers_url":"https://api.github.com/users/clydet/followers","following_url":"https://api.github.com/users/clydet/following{/other_user}","gists_url":"https://api.github.com/users/clydet/gists{/gist_id}","starred_url":"https://api.github.com/users/clydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clydet/subscriptions","organizations_url":"https://api.github.com/users/clydet/orgs","repos_url":"https://api.github.com/users/clydet/repos","events_url":"https://api.github.com/users/clydet/events{/privacy}","received_events_url":"https://api.github.com/users/clydet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673/commits","review_comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673/comments","review_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/673/comments","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/6c6cae658e742100634865158d05d97ea9454334","head":{"label":"CMSgov:story-766","ref":"story-766","sha":"6c6cae658e742100634865158d05d97ea9454334","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-04-08T14:09:02Z","pushed_at":"2018-04-09T12:32:50Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":23211,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":16,"open_issues":3,"watchers":9,"default_branch":"develop"}},"base":{"label":"CMSgov:develop","ref":"develop","sha":"ef2cee36142db59d2301cb44b31db5b2168acd97","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-04-08T14:09:02Z","pushed_at":"2018-04-09T12:32:50Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":23211,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":16,"open_issues":3,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/673"},"issue":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/673"},"comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/6c6cae658e742100634865158d05d97ea9454334"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saquino0827"}}