{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rviz/issues/186","repository_url":"https://api.github.com/repos/ros2/rviz","labels_url":"https://api.github.com/repos/ros2/rviz/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rviz/issues/186/comments","events_url":"https://api.github.com/repos/ros2/rviz/issues/186/events","html_url":"https://github.com/ros2/rviz/pull/186","id":292706682,"number":186,"title":"[WIP] Fix display tests and enable when possible","user":{"login":"Martin-Idel-SI","id":31658331,"avatar_url":"https://avatars2.githubusercontent.com/u/31658331?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Idel-SI","html_url":"https://github.com/Martin-Idel-SI","followers_url":"https://api.github.com/users/Martin-Idel-SI/followers","following_url":"https://api.github.com/users/Martin-Idel-SI/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Idel-SI/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Idel-SI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Idel-SI/subscriptions","organizations_url":"https://api.github.com/users/Martin-Idel-SI/orgs","repos_url":"https://api.github.com/users/Martin-Idel-SI/repos","events_url":"https://api.github.com/users/Martin-Idel-SI/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Idel-SI/received_events","type":"User","site_admin":false},"labels":[{"id":678701940,"url":"https://api.github.com/repos/ros2/rviz/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":679592199,"url":"https://api.github.com/repos/ros2/rviz/labels/in%20progress","name":"in progress","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-01-30T09:20:03Z","updated_at":"2018-02-12T11:45:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ros2/rviz/pulls/186","html_url":"https://github.com/ros2/rviz/pull/186","diff_url":"https://github.com/ros2/rviz/pull/186.diff","patch_url":"https://github.com/ros2/rviz/pull/186.patch"},"body":"This is a followup for #175 . It aims to fix all display tests and run them when possible.\r\n\r\n- In order to not introduce visibility control in `rviz_default_plugins`, we need to build the library both static and shared. Apparently, includes are handled differently in that way, as the static building generates a lot of OGRE and pluginlib warnings on both Windows and Linux.\r\n- To run tests, we try to decide whether OpenGL exists via CMake."},"comment":{"url":"https://api.github.com/repos/ros2/rviz/issues/comments/364899913","html_url":"https://github.com/ros2/rviz/pull/186#issuecomment-364899913","issue_url":"https://api.github.com/repos/ros2/rviz/issues/186","id":364899913,"user":{"login":"Martin-Idel-SI","id":31658331,"avatar_url":"https://avatars2.githubusercontent.com/u/31658331?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Idel-SI","html_url":"https://github.com/Martin-Idel-SI","followers_url":"https://api.github.com/users/Martin-Idel-SI/followers","following_url":"https://api.github.com/users/Martin-Idel-SI/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Idel-SI/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Idel-SI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Idel-SI/subscriptions","organizations_url":"https://api.github.com/users/Martin-Idel-SI/orgs","repos_url":"https://api.github.com/users/Martin-Idel-SI/repos","events_url":"https://api.github.com/users/Martin-Idel-SI/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Idel-SI/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T11:45:54Z","updated_at":"2018-02-12T11:45:54Z","author_association":"NONE","body":"I can't reproduce the errors locally, whatever I do. That means it's really difficult to debug, so for now, I disabled the tests on Windows. They can be reenabled sending a CMake flag, so one could easily debug the problem when having access to the physical machines.\r\n\r\nCI with display tests disabled on Windows:\r\n* Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=3952)](http://ci.ros2.org/job/ci_linux/3952/)\r\n* Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=1071)](http://ci.ros2.org/job/ci_linux-aarch64/1071/)\r\n* macOS [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_osx&build=3286)](http://ci.ros2.org/job/ci_osx/3286/)\r\n* Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=4055)](http://ci.ros2.org/job/ci_windows/4055/)"}}
{"actor":{"display_login":"Martin-Idel-SI"}}