{"action":"closed","number":17712,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/17712","id":181778133,"html_url":"https://github.com/elastic/kibana/pull/17712","diff_url":"https://github.com/elastic/kibana/pull/17712.diff","patch_url":"https://github.com/elastic/kibana/pull/17712.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/17712","number":17712,"state":"closed","locked":false,"title":"Move ng_mock wrapper to test_utils","user":{"login":"timroes","id":877229,"avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"body":"With the introduction of Inspector (#16387) we'll be able to remove the `dev_mode` core plugin, since there isn't much more in it, than the old spy panel debug spy mode. The only file that would be left in the plugin is the `ng_mock` wrapper we use.\r\n\r\nAfter talking to @spalger I moved this to `test_utils` instead, so that we can remove the `dev_mode` plugin once I am done with the Inspector. Wanted to have this in a separate PR, to not clutter the inspector PR more.","created_at":"2018-04-16T07:50:31Z","updated_at":"2018-04-17T06:14:55Z","closed_at":"2018-04-17T06:14:55Z","merged_at":"2018-04-17T06:14:55Z","merge_commit_sha":"07cf4b6b087190429fa6d2f2da118cb8413c3163","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tylersmalley","id":40265,"avatar_url":"https://avatars2.githubusercontent.com/u/40265?v=4","gravatar_id":"","url":"https://api.github.com/users/tylersmalley","html_url":"https://github.com/tylersmalley","followers_url":"https://api.github.com/users/tylersmalley/followers","following_url":"https://api.github.com/users/tylersmalley/following{/other_user}","gists_url":"https://api.github.com/users/tylersmalley/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersmalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersmalley/subscriptions","organizations_url":"https://api.github.com/users/tylersmalley/orgs","repos_url":"https://api.github.com/users/tylersmalley/repos","events_url":"https://api.github.com/users/tylersmalley/events{/privacy}","received_events_url":"https://api.github.com/users/tylersmalley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":222889424,"url":"https://api.github.com/repos/elastic/kibana/labels/chore","name":"chore","color":"f9d0c4","default":false},{"id":140008186,"url":"https://api.github.com/repos/elastic/kibana/labels/test","name":"test","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/17712/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/17712/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/17712/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/043a208ffa30cdf58f10708e704654bbccfcd1cb","head":{"label":"timroes:move-ng-mock","ref":"move-ng-mock","sha":"043a208ffa30cdf58f10708e704654bbccfcd1cb","user":{"login":"timroes","id":877229,"avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"repo":{"id":30105345,"name":"kibana","full_name":"timroes/kibana","owner":{"login":"timroes","id":877229,"avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timroes/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/timroes/kibana","forks_url":"https://api.github.com/repos/timroes/kibana/forks","keys_url":"https://api.github.com/repos/timroes/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timroes/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timroes/kibana/teams","hooks_url":"https://api.github.com/repos/timroes/kibana/hooks","issue_events_url":"https://api.github.com/repos/timroes/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/timroes/kibana/events","assignees_url":"https://api.github.com/repos/timroes/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/timroes/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/timroes/kibana/tags","blobs_url":"https://api.github.com/repos/timroes/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timroes/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timroes/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/timroes/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timroes/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/timroes/kibana/languages","stargazers_url":"https://api.github.com/repos/timroes/kibana/stargazers","contributors_url":"https://api.github.com/repos/timroes/kibana/contributors","subscribers_url":"https://api.github.com/repos/timroes/kibana/subscribers","subscription_url":"https://api.github.com/repos/timroes/kibana/subscription","commits_url":"https://api.github.com/repos/timroes/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/timroes/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/timroes/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/timroes/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/timroes/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/timroes/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timroes/kibana/merges","archive_url":"https://api.github.com/repos/timroes/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timroes/kibana/downloads","issues_url":"https://api.github.com/repos/timroes/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/timroes/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/timroes/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/timroes/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timroes/kibana/labels{/name}","releases_url":"https://api.github.com/repos/timroes/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/timroes/kibana/deployments","created_at":"2015-01-31T07:05:20Z","updated_at":"2016-12-17T07:34:21Z","pushed_at":"2018-04-16T14:53:02Z","git_url":"git://github.com/timroes/kibana.git","ssh_url":"git@github.com:timroes/kibana.git","clone_url":"https://github.com/timroes/kibana.git","svn_url":"https://github.com/timroes/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":300108,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"33262a7d5a6b2289af65028d810599b686d21a56","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-04-17T03:31:46Z","pushed_at":"2018-04-17T06:14:55Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":320783,"stargazers_count":9179,"watchers_count":9179,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3561,"mirror_url":null,"archived":false,"open_issues_count":2352,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3561,"open_issues":2352,"watchers":9179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/17712"},"html":{"href":"https://github.com/elastic/kibana/pull/17712"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/17712"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/17712/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/17712/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/17712/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/043a208ffa30cdf58f10708e704654bbccfcd1cb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"timroes","id":877229,"avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"timroes"}}