{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/comments/237098962","pull_request_review_id":179311226,"id":237098962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA5ODk2Mg==","diff_hunk":"@@ -175,97 +192,110 @@\n                 <manifestEntries>\n                   <Bundle-ManifestVersion>2</Bundle-ManifestVersion>\n                   <Bundle-Name>${project.name}</Bundle-Name>\n-                  <Bundle-SymbolicName>org.eclipse.jetty.osgi-servlet-api.source</Bundle-SymbolicName>\n+                  <Bundle-SymbolicName>org.eclipse.jetty.osgi-servlet-api.source\n+                  </Bundle-SymbolicName>\n                   <Bundle-Vendor>Eclipse.org - Jetty</Bundle-Vendor>\n                   <Bundle-Version>${parsedVersion.osgiVersion}</Bundle-Version>\n-                  <Eclipse-SourceBundle>org.eclipse.jetty.osgi-servlet-api;version=\"${parsedVersion.osgiVersion}\";roots:=\".\"</Eclipse-SourceBundle>\n+                  <Eclipse-SourceBundle>\n+                    org.eclipse.jetty.osgi-servlet-api;version=\"${parsedVersion.osgiVersion}\";roots:=\".\"\n+                  </Eclipse-SourceBundle>\n                 </manifestEntries>\n               </archive>\n             </configuration>\n           </execution>\n         </executions>\n       </plugin>\n \n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-javadoc-plugin</artifactId>\n+        <version>3.0.1</version>\n+        <executions>\n+          <execution>\n+            <id>attach-javadocs</id>\n+            <goals>\n+              <goal>jar</goal>\n+            </goals>\n+          </execution>\n+        </executions>\n+        <configuration>\n+          <tags>\n+            <tag>\n+              <name>apiNote</name>\n+              <placement>a</placement>\n+              <head>API Note:</head>\n+            </tag>\n+            <tag>\n+              <name>implSpec</name>\n+              <placement>a</placement>\n+              <head>Implementation Requirements:</head>\n+            </tag>\n+            <tag>\n+              <name>implNote</name>\n+              <placement>a</placement>\n+              <head>Implementation Note:</head>\n+            </tag>\n+          </tags>\n+        </configuration>\n+      </plugin>\n \n       <!-- generate the manifest for the classes jar -->\n       <plugin>\n-          <groupId>org.apache.felix</groupId>\n-          <artifactId>maven-bundle-plugin</artifactId>\n-          <version>3.5.1</version>\n-          <extensions>true</extensions>\n-          <executions>\n-              <execution>\n-                  <id>bundle-manifest</id>\n-                  <goals>\n-                      <goal>manifest</goal>\n-                  </goals>\n-              </execution>\n-          </executions>\n-          <configuration>\n-              <instructions>\n-                  <Bundle-SymbolicName>org.eclipse.jetty.osgi-servlet-api</Bundle-SymbolicName>\n-                  <Bundle-Name>Jetty Servlet API and Schemas for OSGi</Bundle-Name>\n-                  <Bundle-Description>Combined servlet api and schemas for use in osgi environments</Bundle-Description>\n-                  <Bundle-RequiredExecutionEnvironment>JavaSE-1.7</Bundle-RequiredExecutionEnvironment>\n-                  <_nouses>true</_nouses>\n-                  <Export-Package>!javax.servlet.jsp.*,javax.servlet.*;version=\"4.0\",*</Export-Package>\n-              </instructions>\n-          </configuration>\n+        <groupId>org.apache.felix</groupId>\n+        <artifactId>maven-bundle-plugin</artifactId>\n+        <version>3.5.1</version>\n+        <extensions>true</extensions>\n+        <executions>\n+          <execution>\n+            <id>bundle-manifest</id>\n+            <goals>\n+              <goal>manifest</goal>\n+            </goals>\n+          </execution>\n+        </executions>\n+        <configuration>\n+          <instructions>\n+            <Automatic-Module-Name>jetty-servlet-api</Automatic-Module-Name>\n+            <Bundle-SymbolicName>org.eclipse.jetty.osgi-servlet-api</Bundle-SymbolicName>\n+            <Bundle-Name>Jetty Servlet API and Schemas for JPMS and OSGi</Bundle-Name>\n+            <Bundle-Description>Combined servlet api and schemas for use in JPMS and OSGi environments\n+            </Bundle-Description>\n+            <Bundle-RequiredExecutionEnvironment>JavaSE-1.7</Bundle-RequiredExecutionEnvironment>","path":"jetty-servlet-api/pom.xml","position":282,"original_position":282,"commit_id":"54688f4748a85352ac96fbf2ddcbd96815fbaffb","original_commit_id":"54688f4748a85352ac96fbf2ddcbd96815fbaffb","user":{"login":"janbartel","id":342406,"node_id":"MDQ6VXNlcjM0MjQwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/342406?v=4","gravatar_id":"","url":"https://api.github.com/users/janbartel","html_url":"https://github.com/janbartel","followers_url":"https://api.github.com/users/janbartel/followers","following_url":"https://api.github.com/users/janbartel/following{/other_user}","gists_url":"https://api.github.com/users/janbartel/gists{/gist_id}","starred_url":"https://api.github.com/users/janbartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janbartel/subscriptions","organizations_url":"https://api.github.com/users/janbartel/orgs","repos_url":"https://api.github.com/users/janbartel/repos","events_url":"https://api.github.com/users/janbartel/events{/privacy}","received_events_url":"https://api.github.com/users/janbartel/received_events","type":"User","site_admin":false},"body":"@joakime  I guess its ok to upgrade to 1.8 for Bundle-RequiredExecutionEnvironment, as that is the default already for jetty-9.4.x, and it only signifies the minimum version.\r\n\r\nBTW, the pom.xml for jetty-10.0.x says JavaSE-1.8 - I assume that should be set to something much higher?","created_at":"2018-11-28T14:13:06Z","updated_at":"2018-11-28T14:13:32Z","html_url":"https://github.com/eclipse/jetty.toolchain/pull/22#discussion_r237098962","pull_request_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/comments/237098962"},"html":{"href":"https://github.com/eclipse/jetty.toolchain/pull/22#discussion_r237098962"},"pull_request":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22"}},"in_reply_to_id":236566709},"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22","id":233654689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjU0Njg5","html_url":"https://github.com/eclipse/jetty.toolchain/pull/22","diff_url":"https://github.com/eclipse/jetty.toolchain/pull/22.diff","patch_url":"https://github.com/eclipse/jetty.toolchain/pull/22.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/22","number":22,"state":"open","locked":false,"title":"Jetty Servlet API 4.0.x - for both JPMS and OSGi","user":{"login":"joakime","id":191721,"node_id":"MDQ6VXNlcjE5MTcyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/191721?v=4","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-26T18:28:58Z","updated_at":"2018-11-28T14:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560cf452056e4d87c6a50ed4142b10e9b44d1dd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/22/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.toolchain/statuses/54688f4748a85352ac96fbf2ddcbd96815fbaffb","head":{"label":"eclipse:jetty-servlet-api-4.0-jpms","ref":"jetty-servlet-api-4.0-jpms","sha":"54688f4748a85352ac96fbf2ddcbd96815fbaffb","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045140,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MTQw","name":"jetty.toolchain","full_name":"eclipse/jetty.toolchain","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/jetty.toolchain","description":"Eclipse Jetty® - Servlet Engine and Http Server project repository (jetty.toolchain)","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.toolchain","forks_url":"https://api.github.com/repos/eclipse/jetty.toolchain/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.toolchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.toolchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.toolchain/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.toolchain/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.toolchain/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.toolchain/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.toolchain/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.toolchain/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.toolchain/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.toolchain/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.toolchain/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.toolchain/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.toolchain/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.toolchain/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.toolchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.toolchain/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.toolchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.toolchain/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.toolchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.toolchain/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.toolchain/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.toolchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.toolchain/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.toolchain/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/deployments","created_at":"2011-07-14T00:53:20Z","updated_at":"2018-11-26T16:29:38Z","pushed_at":"2018-11-26T18:28:58Z","git_url":"git://github.com/eclipse/jetty.toolchain.git","ssh_url":"git@github.com:eclipse/jetty.toolchain.git","clone_url":"https://github.com/eclipse/jetty.toolchain.git","svn_url":"https://github.com/eclipse/jetty.toolchain","homepage":"http://www.eclipse.org/jetty","size":1272,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":8,"open_issues":6,"watchers":7,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"b333b4c788e123338f73bff7f51113a005225abc","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045140,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MTQw","name":"jetty.toolchain","full_name":"eclipse/jetty.toolchain","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/jetty.toolchain","description":"Eclipse Jetty® - Servlet Engine and Http Server project repository (jetty.toolchain)","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.toolchain","forks_url":"https://api.github.com/repos/eclipse/jetty.toolchain/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.toolchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.toolchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.toolchain/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.toolchain/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.toolchain/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.toolchain/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.toolchain/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.toolchain/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.toolchain/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.toolchain/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.toolchain/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.toolchain/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.toolchain/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.toolchain/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.toolchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.toolchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.toolchain/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.toolchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.toolchain/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.toolchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.toolchain/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.toolchain/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.toolchain/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.toolchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.toolchain/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.toolchain/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.toolchain/deployments","created_at":"2011-07-14T00:53:20Z","updated_at":"2018-11-26T16:29:38Z","pushed_at":"2018-11-26T18:28:58Z","git_url":"git://github.com/eclipse/jetty.toolchain.git","ssh_url":"git@github.com:eclipse/jetty.toolchain.git","clone_url":"https://github.com/eclipse/jetty.toolchain.git","svn_url":"https://github.com/eclipse/jetty.toolchain","homepage":"http://www.eclipse.org/jetty","size":1272,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":8,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22"},"html":{"href":"https://github.com/eclipse/jetty.toolchain/pull/22"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/22"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.toolchain/statuses/54688f4748a85352ac96fbf2ddcbd96815fbaffb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"janbartel"}}