{"action":"created","comment":{"url":"https://api.github.com/repos/Workday/warp-core/pulls/comments/213772030","pull_request_review_id":150677754,"id":213772030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzc3MjAzMA==","diff_hunk":"@@ -1,5 +1,20 @@\n group = 'com.workday.warp'\n \n+\n+println project.findProperty(\"scalaVersion\")","path":"versionInfo.gradle","position":4,"original_position":4,"commit_id":"5e1e66b5e2e3324c63864064a2a4f4b3f44f442a","original_commit_id":"5e1e66b5e2e3324c63864064a2a4f4b3f44f442a","user":{"login":"tomnis","id":1219411,"node_id":"MDQ6VXNlcjEyMTk0MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1219411?v=4","gravatar_id":"","url":"https://api.github.com/users/tomnis","html_url":"https://github.com/tomnis","followers_url":"https://api.github.com/users/tomnis/followers","following_url":"https://api.github.com/users/tomnis/following{/other_user}","gists_url":"https://api.github.com/users/tomnis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomnis/subscriptions","organizations_url":"https://api.github.com/users/tomnis/orgs","repos_url":"https://api.github.com/users/tomnis/repos","events_url":"https://api.github.com/users/tomnis/events{/privacy}","received_events_url":"https://api.github.com/users/tomnis/received_events","type":"User","site_admin":false},"body":"ill remove it. just note that the property `scalaVersion` is added by the multiversion plugin i added, and won't be available during buildscript time","created_at":"2018-08-29T17:43:04Z","updated_at":"2018-08-29T17:43:05Z","html_url":"https://github.com/Workday/warp-core/pull/3#discussion_r213772030","pull_request_url":"https://api.github.com/repos/Workday/warp-core/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/comments/213772030"},"html":{"href":"https://github.com/Workday/warp-core/pull/3#discussion_r213772030"},"pull_request":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/3"}},"in_reply_to_id":213755475},"pull_request":{"url":"https://api.github.com/repos/Workday/warp-core/pulls/3","id":211644789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjQ0Nzg5","html_url":"https://github.com/Workday/warp-core/pull/3","diff_url":"https://github.com/Workday/warp-core/pull/3.diff","patch_url":"https://github.com/Workday/warp-core/pull/3.patch","issue_url":"https://api.github.com/repos/Workday/warp-core/issues/3","number":3,"state":"open","locked":false,"title":"Artifact id suffix and cross compilation","user":{"login":"tomnis","id":1219411,"node_id":"MDQ6VXNlcjEyMTk0MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1219411?v=4","gravatar_id":"","url":"https://api.github.com/users/tomnis","html_url":"https://github.com/tomnis","followers_url":"https://api.github.com/users/tomnis/followers","following_url":"https://api.github.com/users/tomnis/following{/other_user}","gists_url":"https://api.github.com/users/tomnis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomnis/subscriptions","organizations_url":"https://api.github.com/users/tomnis/orgs","repos_url":"https://api.github.com/users/tomnis/repos","events_url":"https://api.github.com/users/tomnis/events{/privacy}","received_events_url":"https://api.github.com/users/tomnis/received_events","type":"User","site_admin":false},"body":"- cross-compile and publish `warp-core_2.11` and `warp-core_2.12`. it should be simple to add new scala versions in the future\r\n- this was made a bit more complicated because gatling doesn't suffix their artifacts. 2.2.* is built with scala 2.11, while 2.3.* is built with 2.12. as a workaround, we use 2 different gatling version dependencies based on the scala version\r\n- theres a few more minor things i want to sanity check (pom and some buildscript dependencies) before this gets merged","created_at":"2018-08-29T06:45:14Z","updated_at":"2018-08-29T17:43:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc235af840e98cc13e71e57899bf715a983cc95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Workday/warp-core/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Workday/warp-core/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Workday/warp-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workday/warp-core/issues/3/comments","statuses_url":"https://api.github.com/repos/Workday/warp-core/statuses/5e1e66b5e2e3324c63864064a2a4f4b3f44f442a","head":{"label":"tomnis:artifactId-suffix","ref":"artifactId-suffix","sha":"5e1e66b5e2e3324c63864064a2a4f4b3f44f442a","user":{"login":"tomnis","id":1219411,"node_id":"MDQ6VXNlcjEyMTk0MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1219411?v=4","gravatar_id":"","url":"https://api.github.com/users/tomnis","html_url":"https://github.com/tomnis","followers_url":"https://api.github.com/users/tomnis/followers","following_url":"https://api.github.com/users/tomnis/following{/other_user}","gists_url":"https://api.github.com/users/tomnis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomnis/subscriptions","organizations_url":"https://api.github.com/users/tomnis/orgs","repos_url":"https://api.github.com/users/tomnis/repos","events_url":"https://api.github.com/users/tomnis/events{/privacy}","received_events_url":"https://api.github.com/users/tomnis/received_events","type":"User","site_admin":false},"repo":{"id":143769933,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3Njk5MzM=","name":"warp-core","full_name":"tomnis/warp-core","owner":{"login":"tomnis","id":1219411,"node_id":"MDQ6VXNlcjEyMTk0MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1219411?v=4","gravatar_id":"","url":"https://api.github.com/users/tomnis","html_url":"https://github.com/tomnis","followers_url":"https://api.github.com/users/tomnis/followers","following_url":"https://api.github.com/users/tomnis/following{/other_user}","gists_url":"https://api.github.com/users/tomnis/gists{/gist_id}","starred_url":"https://api.github.com/users/tomnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomnis/subscriptions","organizations_url":"https://api.github.com/users/tomnis/orgs","repos_url":"https://api.github.com/users/tomnis/repos","events_url":"https://api.github.com/users/tomnis/events{/privacy}","received_events_url":"https://api.github.com/users/tomnis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomnis/warp-core","description":"Scala framework for collecting performance metrics and conducting sound experimental benchmarking.","fork":true,"url":"https://api.github.com/repos/tomnis/warp-core","forks_url":"https://api.github.com/repos/tomnis/warp-core/forks","keys_url":"https://api.github.com/repos/tomnis/warp-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomnis/warp-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomnis/warp-core/teams","hooks_url":"https://api.github.com/repos/tomnis/warp-core/hooks","issue_events_url":"https://api.github.com/repos/tomnis/warp-core/issues/events{/number}","events_url":"https://api.github.com/repos/tomnis/warp-core/events","assignees_url":"https://api.github.com/repos/tomnis/warp-core/assignees{/user}","branches_url":"https://api.github.com/repos/tomnis/warp-core/branches{/branch}","tags_url":"https://api.github.com/repos/tomnis/warp-core/tags","blobs_url":"https://api.github.com/repos/tomnis/warp-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomnis/warp-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomnis/warp-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomnis/warp-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomnis/warp-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tomnis/warp-core/languages","stargazers_url":"https://api.github.com/repos/tomnis/warp-core/stargazers","contributors_url":"https://api.github.com/repos/tomnis/warp-core/contributors","subscribers_url":"https://api.github.com/repos/tomnis/warp-core/subscribers","subscription_url":"https://api.github.com/repos/tomnis/warp-core/subscription","commits_url":"https://api.github.com/repos/tomnis/warp-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomnis/warp-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomnis/warp-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomnis/warp-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomnis/warp-core/contents/{+path}","compare_url":"https://api.github.com/repos/tomnis/warp-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomnis/warp-core/merges","archive_url":"https://api.github.com/repos/tomnis/warp-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomnis/warp-core/downloads","issues_url":"https://api.github.com/repos/tomnis/warp-core/issues{/number}","pulls_url":"https://api.github.com/repos/tomnis/warp-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tomnis/warp-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tomnis/warp-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomnis/warp-core/labels{/name}","releases_url":"https://api.github.com/repos/tomnis/warp-core/releases{/id}","deployments_url":"https://api.github.com/repos/tomnis/warp-core/deployments","created_at":"2018-08-06T18:53:09Z","updated_at":"2018-08-20T21:56:16Z","pushed_at":"2018-08-28T08:00:26Z","git_url":"git://github.com/tomnis/warp-core.git","ssh_url":"git@github.com:tomnis/warp-core.git","clone_url":"https://github.com/tomnis/warp-core.git","svn_url":"https://github.com/tomnis/warp-core","homepage":"","size":18538,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Workday:master","ref":"master","sha":"12d09842e6a1cdf18bf61e8ac46c134618c428e8","user":{"login":"Workday","id":328102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/328102?v=4","gravatar_id":"","url":"https://api.github.com/users/Workday","html_url":"https://github.com/Workday","followers_url":"https://api.github.com/users/Workday/followers","following_url":"https://api.github.com/users/Workday/following{/other_user}","gists_url":"https://api.github.com/users/Workday/gists{/gist_id}","starred_url":"https://api.github.com/users/Workday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workday/subscriptions","organizations_url":"https://api.github.com/users/Workday/orgs","repos_url":"https://api.github.com/users/Workday/repos","events_url":"https://api.github.com/users/Workday/events{/privacy}","received_events_url":"https://api.github.com/users/Workday/received_events","type":"Organization","site_admin":false},"repo":{"id":129179180,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNzkxODA=","name":"warp-core","full_name":"Workday/warp-core","owner":{"login":"Workday","id":328102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/328102?v=4","gravatar_id":"","url":"https://api.github.com/users/Workday","html_url":"https://github.com/Workday","followers_url":"https://api.github.com/users/Workday/followers","following_url":"https://api.github.com/users/Workday/following{/other_user}","gists_url":"https://api.github.com/users/Workday/gists{/gist_id}","starred_url":"https://api.github.com/users/Workday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workday/subscriptions","organizations_url":"https://api.github.com/users/Workday/orgs","repos_url":"https://api.github.com/users/Workday/repos","events_url":"https://api.github.com/users/Workday/events{/privacy}","received_events_url":"https://api.github.com/users/Workday/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workday/warp-core","description":"Scala framework for collecting performance metrics and conducting sound experimental benchmarking.","fork":false,"url":"https://api.github.com/repos/Workday/warp-core","forks_url":"https://api.github.com/repos/Workday/warp-core/forks","keys_url":"https://api.github.com/repos/Workday/warp-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workday/warp-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workday/warp-core/teams","hooks_url":"https://api.github.com/repos/Workday/warp-core/hooks","issue_events_url":"https://api.github.com/repos/Workday/warp-core/issues/events{/number}","events_url":"https://api.github.com/repos/Workday/warp-core/events","assignees_url":"https://api.github.com/repos/Workday/warp-core/assignees{/user}","branches_url":"https://api.github.com/repos/Workday/warp-core/branches{/branch}","tags_url":"https://api.github.com/repos/Workday/warp-core/tags","blobs_url":"https://api.github.com/repos/Workday/warp-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workday/warp-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workday/warp-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workday/warp-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workday/warp-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Workday/warp-core/languages","stargazers_url":"https://api.github.com/repos/Workday/warp-core/stargazers","contributors_url":"https://api.github.com/repos/Workday/warp-core/contributors","subscribers_url":"https://api.github.com/repos/Workday/warp-core/subscribers","subscription_url":"https://api.github.com/repos/Workday/warp-core/subscription","commits_url":"https://api.github.com/repos/Workday/warp-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workday/warp-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workday/warp-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workday/warp-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workday/warp-core/contents/{+path}","compare_url":"https://api.github.com/repos/Workday/warp-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workday/warp-core/merges","archive_url":"https://api.github.com/repos/Workday/warp-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workday/warp-core/downloads","issues_url":"https://api.github.com/repos/Workday/warp-core/issues{/number}","pulls_url":"https://api.github.com/repos/Workday/warp-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Workday/warp-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Workday/warp-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workday/warp-core/labels{/name}","releases_url":"https://api.github.com/repos/Workday/warp-core/releases{/id}","deployments_url":"https://api.github.com/repos/Workday/warp-core/deployments","created_at":"2018-04-12T02:09:44Z","updated_at":"2018-08-21T03:24:39Z","pushed_at":"2018-08-29T06:45:15Z","git_url":"git://github.com/Workday/warp-core.git","ssh_url":"git@github.com:Workday/warp-core.git","clone_url":"https://github.com/Workday/warp-core.git","svn_url":"https://github.com/Workday/warp-core","homepage":"","size":18525,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/3"},"html":{"href":"https://github.com/Workday/warp-core/pull/3"},"issue":{"href":"https://api.github.com/repos/Workday/warp-core/issues/3"},"comments":{"href":"https://api.github.com/repos/Workday/warp-core/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workday/warp-core/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Workday/warp-core/statuses/5e1e66b5e2e3324c63864064a2a4f4b3f44f442a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tomnis"}}