{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/7","repository_url":"https://api.github.com/repos/ethereum/pytest-ethereum","labels_url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/7/comments","events_url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/7/events","html_url":"https://github.com/ethereum/pytest-ethereum/issues/7","id":364636071,"node_id":"MDU6SXNzdWUzNjQ2MzYwNzE=","number":7,"title":"Change glob to use a list of extensions","user":{"login":"fubuloubu","id":3859395,"node_id":"MDQ6VXNlcjM4NTkzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3859395?v=4","gravatar_id":"","url":"https://api.github.com/users/fubuloubu","html_url":"https://github.com/fubuloubu","followers_url":"https://api.github.com/users/fubuloubu/followers","following_url":"https://api.github.com/users/fubuloubu/following{/other_user}","gists_url":"https://api.github.com/users/fubuloubu/gists{/gist_id}","starred_url":"https://api.github.com/users/fubuloubu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fubuloubu/subscriptions","organizations_url":"https://api.github.com/users/fubuloubu/orgs","repos_url":"https://api.github.com/users/fubuloubu/repos","events_url":"https://api.github.com/users/fubuloubu/events{/privacy}","received_events_url":"https://api.github.com/users/fubuloubu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-27T20:13:40Z","updated_at":"2018-09-27T20:15:53Z","closed_at":null,"author_association":"NONE","body":"https://github.com/ethereum/pytest-ethereum/blob/c3e2ce124b41d5b0767c75630e22e82061f30c54/pytest_ethereum/plugins.py#L23\r\n\r\nChange this to have the glob reference a list of known extensions that there are deployers for (e.g. `.sol` and `.vy`), so all files are grabbed.\r\n\r\nLet the user specify additional extensions, and the deployer for that extension, which may eventually be an external package wrapping up some particular language (e.g. LLL)\r\n\r\nI don't necessarily think LLL should be a first class citizen, but it should be relatively easy to integrate if necessary."},"comment":{"url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/comments/425228068","html_url":"https://github.com/ethereum/pytest-ethereum/issues/7#issuecomment-425228068","issue_url":"https://api.github.com/repos/ethereum/pytest-ethereum/issues/7","id":425228068,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTIyODA2OA==","user":{"login":"fubuloubu","id":3859395,"node_id":"MDQ6VXNlcjM4NTkzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3859395?v=4","gravatar_id":"","url":"https://api.github.com/users/fubuloubu","html_url":"https://github.com/fubuloubu","followers_url":"https://api.github.com/users/fubuloubu/followers","following_url":"https://api.github.com/users/fubuloubu/following{/other_user}","gists_url":"https://api.github.com/users/fubuloubu/gists{/gist_id}","starred_url":"https://api.github.com/users/fubuloubu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fubuloubu/subscriptions","organizations_url":"https://api.github.com/users/fubuloubu/orgs","repos_url":"https://api.github.com/users/fubuloubu/repos","events_url":"https://api.github.com/users/fubuloubu/events{/privacy}","received_events_url":"https://api.github.com/users/fubuloubu/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T20:15:53Z","updated_at":"2018-09-27T20:15:53Z","author_association":"NONE","body":"https://github.com/ethereum/pytest-ethereum/blob/c3e2ce124b41d5b0767c75630e22e82061f30c54/pytest_ethereum/plugins.py#L90\r\n\r\nSimarilly, I'm not sure I agree with having the Deployer specified per-package. I think it should be per-source file if possible, so it accomodates multiple languages/deployers."}}
{"actor":{"display_login":"fubuloubu"}}