{"action":"closed","number":29995,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995","id":225337993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzM3OTkz","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29995","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29995.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29995.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29995","number":29995,"state":"closed","locked":false,"title":"[react-jsonschema-form] Fix onBlur/onFocus signature for (custom) widgets","user":{"login":"sbusch","id":91866,"node_id":"MDQ6VXNlcjkxODY2","avatar_url":"https://avatars1.githubusercontent.com/u/91866?v=4","gravatar_id":"","url":"https://api.github.com/users/sbusch","html_url":"https://github.com/sbusch","followers_url":"https://api.github.com/users/sbusch/followers","following_url":"https://api.github.com/users/sbusch/following{/other_user}","gists_url":"https://api.github.com/users/sbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/sbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbusch/subscriptions","organizations_url":"https://api.github.com/users/sbusch/orgs","repos_url":"https://api.github.com/users/sbusch/repos","events_url":"https://api.github.com/users/sbusch/events{/privacy}","received_events_url":"https://api.github.com/users/sbusch/received_events","type":"User","site_admin":false},"body":"`react-jsonschema-form` unfortunately uses for its (custom) widgets a custom, non-standard signature for `onBlur` and `onFocus` props which is incompatible with HTMLElement (custom signature is documented [here](https://github.com/mozilla-services/react-jsonschema-form/blob/master/README.md#custom-widget-components))\r\n\r\nMy change fixes the definition just for the two affected props, which still using all other props of HTMLElement.\r\n\r\n---\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/mozilla-services/react-jsonschema-form/blob/master/README.md#custom-widget-components>\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\n","created_at":"2018-10-24T09:56:27Z","updated_at":"2018-10-27T01:45:03Z","closed_at":"2018-10-27T01:45:03Z","merged_at":"2018-10-27T01:45:03Z","merge_commit_sha":"f591d4179da9208b9d375a9254fcb4442967e449","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false},{"id":905334095,"node_id":"MDU6TGFiZWw5MDUzMzQwOTU=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Owner%20Approved","name":"Owner Approved","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29995/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/b8d4168f8416d17e69278214f6bac15d70b65924","head":{"label":"sbusch:react-jsonschema-form--widgetprops-onblur-onfocus-fix","ref":"react-jsonschema-form--widgetprops-onblur-onfocus-fix","sha":"b8d4168f8416d17e69278214f6bac15d70b65924","user":{"login":"sbusch","id":91866,"node_id":"MDQ6VXNlcjkxODY2","avatar_url":"https://avatars1.githubusercontent.com/u/91866?v=4","gravatar_id":"","url":"https://api.github.com/users/sbusch","html_url":"https://github.com/sbusch","followers_url":"https://api.github.com/users/sbusch/followers","following_url":"https://api.github.com/users/sbusch/following{/other_user}","gists_url":"https://api.github.com/users/sbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/sbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbusch/subscriptions","organizations_url":"https://api.github.com/users/sbusch/orgs","repos_url":"https://api.github.com/users/sbusch/repos","events_url":"https://api.github.com/users/sbusch/events{/privacy}","received_events_url":"https://api.github.com/users/sbusch/received_events","type":"User","site_admin":false},"repo":{"id":154472571,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0NzI1NzE=","name":"DefinitelyTyped","full_name":"sbusch/DefinitelyTyped","private":false,"owner":{"login":"sbusch","id":91866,"node_id":"MDQ6VXNlcjkxODY2","avatar_url":"https://avatars1.githubusercontent.com/u/91866?v=4","gravatar_id":"","url":"https://api.github.com/users/sbusch","html_url":"https://github.com/sbusch","followers_url":"https://api.github.com/users/sbusch/followers","following_url":"https://api.github.com/users/sbusch/following{/other_user}","gists_url":"https://api.github.com/users/sbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/sbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbusch/subscriptions","organizations_url":"https://api.github.com/users/sbusch/orgs","repos_url":"https://api.github.com/users/sbusch/repos","events_url":"https://api.github.com/users/sbusch/events{/privacy}","received_events_url":"https://api.github.com/users/sbusch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sbusch/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/sbusch/DefinitelyTyped","forks_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/sbusch/DefinitelyTyped/deployments","created_at":"2018-10-24T09:15:14Z","updated_at":"2018-10-24T09:15:46Z","pushed_at":"2018-10-24T09:56:51Z","git_url":"git://github.com/sbusch/DefinitelyTyped.git","ssh_url":"git@github.com:sbusch/DefinitelyTyped.git","clone_url":"https://github.com/sbusch/DefinitelyTyped.git","svn_url":"https://github.com/sbusch/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":370069,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"3b01bb29b14920095067426b1cd222c2215feb66","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-10-27T01:44:56Z","pushed_at":"2018-10-27T01:45:03Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":370279,"stargazers_count":18174,"watchers_count":18174,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15112,"mirror_url":null,"archived":false,"open_issues_count":2501,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15112,"open_issues":2501,"watchers":18174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29995"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29995"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29995/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29995/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/b8d4168f8416d17e69278214f6bac15d70b65924"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rbuckton","id":3902892,"node_id":"MDQ6VXNlcjM5MDI4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3902892?v=4","gravatar_id":"","url":"https://api.github.com/users/rbuckton","html_url":"https://github.com/rbuckton","followers_url":"https://api.github.com/users/rbuckton/followers","following_url":"https://api.github.com/users/rbuckton/following{/other_user}","gists_url":"https://api.github.com/users/rbuckton/gists{/gist_id}","starred_url":"https://api.github.com/users/rbuckton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbuckton/subscriptions","organizations_url":"https://api.github.com/users/rbuckton/orgs","repos_url":"https://api.github.com/users/rbuckton/repos","events_url":"https://api.github.com/users/rbuckton/events{/privacy}","received_events_url":"https://api.github.com/users/rbuckton/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"rbuckton"}}