{"action":"created","comment":{"url":"https://api.github.com/repos/kontur-courses/testing/pulls/comments/228759566","pull_request_review_id":169103982,"id":228759566,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1OTU2Ng==","diff_hunk":"@@ -28,7 +28,116 @@ public void Test()\n \t\t\tAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber(\"-1.23\"));\n \t\t\tAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber(\"a.sd\"));\n \t\t}\n-\t}\n+\n+\t\t[Test]\n+\t\tpublic void Precision_Should_Be_Positive()\n+\t\t{\n+\t\t\tAssert.Throws<ArgumentException>(() => new NumberValidator(-1, 0, true));\n+\t\t\tAssert.Throws<ArgumentException>(() => new NumberValidator(0, 0, true));\n+\t\t\tAssert.DoesNotThrow(() => new NumberValidator(1, 0, true));\n+\t\t}\n+\n+\t\t[Test]\n+\t\tpublic void Scale_Should_Be_NonNegative()\n+\t\t{\n+\t\t\tAssert.Throws<ArgumentException>(() => new NumberValidator(1, -1, true));\n+\t\t\tAssert.DoesNotThrow(() => new NumberValidator(1, 0, true));\n+\t\t}\n+\n+        [Test]\n+\t\tpublic void Scale_Should_Be_LessThanPrecision()\n+\t\t{\n+\t\t\tAssert.Throws<ArgumentException>(() => new NumberValidator(2, 4, true));\n+\t\t\tAssert.Throws<ArgumentException>(() => new NumberValidator(4, 4, true));\n+\t\t\tAssert.DoesNotThrow(() => new NumberValidator(5, 4, true));\n+\t\t}\n+\n+\t\t[Test]\n+\t\tpublic void Should_Valid_Integer()","path":"cs/HomeExercises/NumberValidatorTests.cs","position":39,"original_position":39,"commit_id":"0cc2672f5c96cf58cca50fbc67e93a3c3d09dd14","original_commit_id":"0cc2672f5c96cf58cca50fbc67e93a3c3d09dd14","user":{"login":"xackill","id":9920311,"node_id":"MDQ6VXNlcjk5MjAzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9920311?v=4","gravatar_id":"","url":"https://api.github.com/users/xackill","html_url":"https://github.com/xackill","followers_url":"https://api.github.com/users/xackill/followers","following_url":"https://api.github.com/users/xackill/following{/other_user}","gists_url":"https://api.github.com/users/xackill/gists{/gist_id}","starred_url":"https://api.github.com/users/xackill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xackill/subscriptions","organizations_url":"https://api.github.com/users/xackill/orgs","repos_url":"https://api.github.com/users/xackill/repos","events_url":"https://api.github.com/users/xackill/events{/privacy}","received_events_url":"https://api.github.com/users/xackill/received_events","type":"User","site_admin":false},"body":"Предлагаю такую итерацию:\r\n1. Переосмыслить часть лекции про \"название тестов=спецификация\" (пример с суперменом в самом начале)\r\n2. Переложить это на NumberValidator\r\n3. Посмотреть, стало ли лучше?","created_at":"2018-10-28T18:37:37Z","updated_at":"2018-10-28T18:37:37Z","html_url":"https://github.com/kontur-courses/testing/pull/31#discussion_r228759566","pull_request_url":"https://api.github.com/repos/kontur-courses/testing/pulls/31","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/comments/228759566"},"html":{"href":"https://github.com/kontur-courses/testing/pull/31#discussion_r228759566"},"pull_request":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/31"}},"in_reply_to_id":228759160},"pull_request":{"url":"https://api.github.com/repos/kontur-courses/testing/pulls/31","id":226349119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzQ5MTE5","html_url":"https://github.com/kontur-courses/testing/pull/31","diff_url":"https://github.com/kontur-courses/testing/pull/31.diff","patch_url":"https://github.com/kontur-courses/testing/pull/31.patch","issue_url":"https://api.github.com/repos/kontur-courses/testing/issues/31","number":31,"state":"open","locked":false,"title":"@xackill Белянин Андрей","user":{"login":"Belianin","id":38618702,"node_id":"MDQ6VXNlcjM4NjE4NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/38618702?v=4","gravatar_id":"","url":"https://api.github.com/users/Belianin","html_url":"https://github.com/Belianin","followers_url":"https://api.github.com/users/Belianin/followers","following_url":"https://api.github.com/users/Belianin/following{/other_user}","gists_url":"https://api.github.com/users/Belianin/gists{/gist_id}","starred_url":"https://api.github.com/users/Belianin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Belianin/subscriptions","organizations_url":"https://api.github.com/users/Belianin/orgs","repos_url":"https://api.github.com/users/Belianin/repos","events_url":"https://api.github.com/users/Belianin/events{/privacy}","received_events_url":"https://api.github.com/users/Belianin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-28T07:40:35Z","updated_at":"2018-10-28T18:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac1e784d14f167601379118e6bc96faf619e5fe9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kontur-courses/testing/pulls/31/commits","review_comments_url":"https://api.github.com/repos/kontur-courses/testing/pulls/31/comments","review_comment_url":"https://api.github.com/repos/kontur-courses/testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontur-courses/testing/issues/31/comments","statuses_url":"https://api.github.com/repos/kontur-courses/testing/statuses/0cc2672f5c96cf58cca50fbc67e93a3c3d09dd14","head":{"label":"Belianin:master","ref":"master","sha":"0cc2672f5c96cf58cca50fbc67e93a3c3d09dd14","user":{"login":"Belianin","id":38618702,"node_id":"MDQ6VXNlcjM4NjE4NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/38618702?v=4","gravatar_id":"","url":"https://api.github.com/users/Belianin","html_url":"https://github.com/Belianin","followers_url":"https://api.github.com/users/Belianin/followers","following_url":"https://api.github.com/users/Belianin/following{/other_user}","gists_url":"https://api.github.com/users/Belianin/gists{/gist_id}","starred_url":"https://api.github.com/users/Belianin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Belianin/subscriptions","organizations_url":"https://api.github.com/users/Belianin/orgs","repos_url":"https://api.github.com/users/Belianin/repos","events_url":"https://api.github.com/users/Belianin/events{/privacy}","received_events_url":"https://api.github.com/users/Belianin/received_events","type":"User","site_admin":false},"repo":{"id":154513180,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MTMxODA=","name":"testing","full_name":"Belianin/testing","private":false,"owner":{"login":"Belianin","id":38618702,"node_id":"MDQ6VXNlcjM4NjE4NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/38618702?v=4","gravatar_id":"","url":"https://api.github.com/users/Belianin","html_url":"https://github.com/Belianin","followers_url":"https://api.github.com/users/Belianin/followers","following_url":"https://api.github.com/users/Belianin/following{/other_user}","gists_url":"https://api.github.com/users/Belianin/gists{/gist_id}","starred_url":"https://api.github.com/users/Belianin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Belianin/subscriptions","organizations_url":"https://api.github.com/users/Belianin/orgs","repos_url":"https://api.github.com/users/Belianin/repos","events_url":"https://api.github.com/users/Belianin/events{/privacy}","received_events_url":"https://api.github.com/users/Belianin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Belianin/testing","description":null,"fork":true,"url":"https://api.github.com/repos/Belianin/testing","forks_url":"https://api.github.com/repos/Belianin/testing/forks","keys_url":"https://api.github.com/repos/Belianin/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Belianin/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Belianin/testing/teams","hooks_url":"https://api.github.com/repos/Belianin/testing/hooks","issue_events_url":"https://api.github.com/repos/Belianin/testing/issues/events{/number}","events_url":"https://api.github.com/repos/Belianin/testing/events","assignees_url":"https://api.github.com/repos/Belianin/testing/assignees{/user}","branches_url":"https://api.github.com/repos/Belianin/testing/branches{/branch}","tags_url":"https://api.github.com/repos/Belianin/testing/tags","blobs_url":"https://api.github.com/repos/Belianin/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Belianin/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Belianin/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Belianin/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Belianin/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/Belianin/testing/languages","stargazers_url":"https://api.github.com/repos/Belianin/testing/stargazers","contributors_url":"https://api.github.com/repos/Belianin/testing/contributors","subscribers_url":"https://api.github.com/repos/Belianin/testing/subscribers","subscription_url":"https://api.github.com/repos/Belianin/testing/subscription","commits_url":"https://api.github.com/repos/Belianin/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Belianin/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Belianin/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Belianin/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Belianin/testing/contents/{+path}","compare_url":"https://api.github.com/repos/Belianin/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Belianin/testing/merges","archive_url":"https://api.github.com/repos/Belianin/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Belianin/testing/downloads","issues_url":"https://api.github.com/repos/Belianin/testing/issues{/number}","pulls_url":"https://api.github.com/repos/Belianin/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/Belianin/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/Belianin/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Belianin/testing/labels{/name}","releases_url":"https://api.github.com/repos/Belianin/testing/releases{/id}","deployments_url":"https://api.github.com/repos/Belianin/testing/deployments","created_at":"2018-10-24T14:13:14Z","updated_at":"2018-10-28T07:39:54Z","pushed_at":"2018-10-28T07:39:53Z","git_url":"git://github.com/Belianin/testing.git","ssh_url":"git@github.com:Belianin/testing.git","clone_url":"https://github.com/Belianin/testing.git","svn_url":"https://github.com/Belianin/testing","homepage":null,"size":2830,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kontur-courses:master","ref":"master","sha":"df0997e8f18b88ab0f181e53e734962b2af59df2","user":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"repo":{"id":70393598,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM5MzU5OA==","name":"testing","full_name":"kontur-courses/testing","private":false,"owner":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kontur-courses/testing","description":null,"fork":false,"url":"https://api.github.com/repos/kontur-courses/testing","forks_url":"https://api.github.com/repos/kontur-courses/testing/forks","keys_url":"https://api.github.com/repos/kontur-courses/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontur-courses/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontur-courses/testing/teams","hooks_url":"https://api.github.com/repos/kontur-courses/testing/hooks","issue_events_url":"https://api.github.com/repos/kontur-courses/testing/issues/events{/number}","events_url":"https://api.github.com/repos/kontur-courses/testing/events","assignees_url":"https://api.github.com/repos/kontur-courses/testing/assignees{/user}","branches_url":"https://api.github.com/repos/kontur-courses/testing/branches{/branch}","tags_url":"https://api.github.com/repos/kontur-courses/testing/tags","blobs_url":"https://api.github.com/repos/kontur-courses/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontur-courses/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontur-courses/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontur-courses/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontur-courses/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/kontur-courses/testing/languages","stargazers_url":"https://api.github.com/repos/kontur-courses/testing/stargazers","contributors_url":"https://api.github.com/repos/kontur-courses/testing/contributors","subscribers_url":"https://api.github.com/repos/kontur-courses/testing/subscribers","subscription_url":"https://api.github.com/repos/kontur-courses/testing/subscription","commits_url":"https://api.github.com/repos/kontur-courses/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontur-courses/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontur-courses/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontur-courses/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontur-courses/testing/contents/{+path}","compare_url":"https://api.github.com/repos/kontur-courses/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontur-courses/testing/merges","archive_url":"https://api.github.com/repos/kontur-courses/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontur-courses/testing/downloads","issues_url":"https://api.github.com/repos/kontur-courses/testing/issues{/number}","pulls_url":"https://api.github.com/repos/kontur-courses/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/kontur-courses/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/kontur-courses/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontur-courses/testing/labels{/name}","releases_url":"https://api.github.com/repos/kontur-courses/testing/releases{/id}","deployments_url":"https://api.github.com/repos/kontur-courses/testing/deployments","created_at":"2016-10-09T09:44:47Z","updated_at":"2018-10-26T13:18:02Z","pushed_at":"2018-10-28T18:33:08Z","git_url":"git://github.com/kontur-courses/testing.git","ssh_url":"git@github.com:kontur-courses/testing.git","clone_url":"https://github.com/kontur-courses/testing.git","svn_url":"https://github.com/kontur-courses/testing","homepage":null,"size":2829,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":75,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/31"},"html":{"href":"https://github.com/kontur-courses/testing/pull/31"},"issue":{"href":"https://api.github.com/repos/kontur-courses/testing/issues/31"},"comments":{"href":"https://api.github.com/repos/kontur-courses/testing/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontur-courses/testing/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/kontur-courses/testing/statuses/0cc2672f5c96cf58cca50fbc67e93a3c3d09dd14"}},"author_association":"NONE"}}
{"actor":{"display_login":"xackill"}}