{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28980","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28980/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28980/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28980/events","html_url":"https://github.com/cockroachdb/cockroach/pull/28980","id":353143167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjc4MDc1","number":28980,"title":"distsqlrun: bugfixes/perf change to joinReader ","user":{"login":"jordanlewis","id":43821,"node_id":"MDQ6VXNlcjQzODIx","avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-08-22T22:04:16Z","updated_at":"2018-08-27T21:14:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28980","html_url":"https://github.com/cockroachdb/cockroach/pull/28980","diff_url":"https://github.com/cockroachdb/cockroach/pull/28980.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28980.patch"},"body":"Previously, joinReader used pretty-printed string keys to correlate its\r\ninput rows with its looked-up rows. This was incorrect and inefficient.\r\n\r\nNow, it uses bytes keys like everything else. Also, fix a bug that\r\ncaused partial key creation from EncDatums on tables with interleaves to\r\npanic and/or return incorrect results.\r\n\r\nCloses #28981.\r\n\r\n```\r\nname                      old time/op    new time/op     delta\r\nJoinReader/rows=16-24        134µs ± 1%       57µs ± 1%   -57.39%  (p=0.000 n=9+10)\r\nJoinReader/rows=256-24      1.54ms ± 1%     0.42ms ± 1%   -72.43%  (p=0.000 n=10+9)\r\nJoinReader/rows=4096-24     45.4ms ± 1%     24.5ms ± 1%   -46.14%  (p=0.000 n=8+10)\r\nJoinReader/rows=65536-24     5.03s ± 1%      4.80s ± 1%    -4.64%  (p=0.000 n=9+10)\r\n\r\nname                      old speed      new speed       delta\r\nJoinReader/rows=16-24     2.87MB/s ± 1%   6.74MB/s ± 1%  +134.76%  (p=0.000 n=7+10)\r\nJoinReader/rows=256-24    4.00MB/s ± 1%  14.52MB/s ± 1%  +262.83%  (p=0.000 n=10+10)\r\nJoinReader/rows=4096-24   2.17MB/s ± 1%   4.02MB/s ± 1%   +85.64%  (p=0.000 n=8+10)\r\nJoinReader/rows=65536-24   310kB/s ± 0%    327kB/s ± 2%    +5.48%  (p=0.000 n=10+10)\r\n\r\nname                      old alloc/op   new alloc/op    delta\r\nJoinReader/rows=16-24       40.4kB ± 1%     18.1kB ± 1%   -55.08%  (p=0.000 n=10+10)\r\nJoinReader/rows=256-24       390kB ± 0%       93kB ± 1%   -76.07%  (p=0.000 n=8+9)\r\nJoinReader/rows=4096-24     5.96MB ± 0%     1.25MB ± 1%   -78.99%  (p=0.000 n=9+9)\r\nJoinReader/rows=65536-24    99.2MB ± 6%     23.2MB ±15%   -76.66%  (p=0.000 n=10+10)\r\n\r\nname                      old allocs/op  new allocs/op   delta\r\nJoinReader/rows=16-24          646 ± 0%        179 ± 0%   -72.37%  (p=0.000 n=10+10)\r\nJoinReader/rows=256-24       8.77k ± 0%      1.33k ± 0%   -84.83%  (p=0.000 n=10+9)\r\nJoinReader/rows=4096-24       139k ± 0%        20k ± 0%   -85.48%  (p=0.000 n=9+9)\r\nJoinReader/rows=65536-24     2.24M ± 1%      0.33M ± 7%   -85.14%  (p=0.000 n=9+9)\r\n```"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/416370924","html_url":"https://github.com/cockroachdb/cockroach/pull/28980#issuecomment-416370924","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28980","id":416370924,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM3MDkyNA==","user":{"login":"jordanlewis","id":43821,"node_id":"MDQ6VXNlcjQzODIx","avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T21:14:13Z","updated_at":"2018-08-27T21:14:13Z","author_association":"MEMBER","body":"bors r+"}}
{"actor":{"display_login":"jordanlewis"}}