{"action":"closed","number":13819,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/13819","id":170970985,"html_url":"https://github.com/magento/magento2/pull/13819","diff_url":"https://github.com/magento/magento2/pull/13819.diff","patch_url":"https://github.com/magento/magento2/pull/13819.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/13819","number":13819,"state":"closed","locked":false,"title":"[Forwardport] Fix bug Magento 2.2.2 password reset strength meter #13429","user":{"login":"serhii-balko","id":23723146,"avatar_url":"https://avatars0.githubusercontent.com/u/23723146?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-balko","html_url":"https://github.com/serhii-balko","followers_url":"https://api.github.com/users/serhii-balko/followers","following_url":"https://api.github.com/users/serhii-balko/following{/other_user}","gists_url":"https://api.github.com/users/serhii-balko/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-balko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-balko/subscriptions","organizations_url":"https://api.github.com/users/serhii-balko/orgs","repos_url":"https://api.github.com/users/serhii-balko/repos","events_url":"https://api.github.com/users/serhii-balko/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-balko/received_events","type":"User","site_admin":false},"body":"### Original Pull Request \r\n https://github.com/magento/magento2/pull/13761\r\nFix bug \"Magento 2.2.2 password reset strength meter\" #13429 by doing the email comparison only if an email field exists. \r\n\r\nThe form email input field selector at the \"password-strength-indicator.js\" is generic enough to match any input field \"email\" in the frontend at that time. This causes the password strength indicator to work in the password reset email screen in the default theme, given that this selector ends up matching the email field of the newsletter subscription form.\r\n\r\nHowever, if you are using a theme in which the newsletter subscription email form is removed, it then causes this password strength validation to break. Moreover, it doesn't make much sense to compare your password with any possible email that is written in the newsletter subscription form.\r\n\r\nThis was done as part of the #MLAU18 contribution day.\r\n\r\n### Description\r\nThis PR simply causes the condition in which the password is compared to the email to be skipped in this situation, removing the Javascript error. Further review of this selector (that populates the this.options.cache.email variable) to narrow it so it only matches the email fields that are part of the same form as the password field should be done in the future.\r\n\r\n### Fixed Issues\r\n1. magento/magento2#13429\r\n\r\n### Manual testing scenarios\r\n1. Test reset password screen with the \"newsletter subscription\" email field in there (default Magento). The password strength indicator already works correctly in this situation.\r\n2. Now remove such newsletter subscription field and test again. A js error will be thrown as per described in the issue. This PR fixes such js error and causes the password strength indicator to work again in this case.\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-02-23T09:44:26Z","updated_at":"2018-02-26T20:32:40Z","closed_at":"2018-02-26T20:32:40Z","merged_at":"2018-02-26T20:32:40Z","merge_commit_sha":"fd5e0b5532b56451cadcc03353bae2ff54838fcc","assignee":{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"assignees":[{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721429227,"url":"https://api.github.com/repos/magento/magento2/labels/2.3-develop","name":"2.3-develop","color":"fbca04","default":false},{"id":164491159,"url":"https://api.github.com/repos/magento/magento2/labels/accept","name":"accept","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/13","html_url":"https://github.com/magento/magento2/milestone/13","labels_url":"https://api.github.com/repos/magento/magento2/milestones/13/labels","id":3080557,"number":13,"title":"February 2018","description":"Pull Requests processed in February 2018","creator":{"login":"orlangur","id":642698,"avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":89,"state":"open","created_at":"2018-02-01T09:58:37Z","updated_at":"2018-02-26T20:32:40Z","due_on":"2018-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/magento/magento2/pulls/13819/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/13819/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/13819/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/fd5e0b5532b56451cadcc03353bae2ff54838fcc","head":{"label":"serhii-balko:2.3-develop-PR-port-13761","ref":"2.3-develop-PR-port-13761","sha":"fd5e0b5532b56451cadcc03353bae2ff54838fcc","user":{"login":"serhii-balko","id":23723146,"avatar_url":"https://avatars0.githubusercontent.com/u/23723146?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-balko","html_url":"https://github.com/serhii-balko","followers_url":"https://api.github.com/users/serhii-balko/followers","following_url":"https://api.github.com/users/serhii-balko/following{/other_user}","gists_url":"https://api.github.com/users/serhii-balko/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-balko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-balko/subscriptions","organizations_url":"https://api.github.com/users/serhii-balko/orgs","repos_url":"https://api.github.com/users/serhii-balko/repos","events_url":"https://api.github.com/users/serhii-balko/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-balko/received_events","type":"User","site_admin":false},"repo":{"id":108097033,"name":"magento2","full_name":"serhii-balko/magento2","owner":{"login":"serhii-balko","id":23723146,"avatar_url":"https://avatars0.githubusercontent.com/u/23723146?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-balko","html_url":"https://github.com/serhii-balko","followers_url":"https://api.github.com/users/serhii-balko/followers","following_url":"https://api.github.com/users/serhii-balko/following{/other_user}","gists_url":"https://api.github.com/users/serhii-balko/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-balko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-balko/subscriptions","organizations_url":"https://api.github.com/users/serhii-balko/orgs","repos_url":"https://api.github.com/users/serhii-balko/repos","events_url":"https://api.github.com/users/serhii-balko/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-balko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serhii-balko/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/serhii-balko/magento2","forks_url":"https://api.github.com/repos/serhii-balko/magento2/forks","keys_url":"https://api.github.com/repos/serhii-balko/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serhii-balko/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serhii-balko/magento2/teams","hooks_url":"https://api.github.com/repos/serhii-balko/magento2/hooks","issue_events_url":"https://api.github.com/repos/serhii-balko/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/serhii-balko/magento2/events","assignees_url":"https://api.github.com/repos/serhii-balko/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/serhii-balko/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/serhii-balko/magento2/tags","blobs_url":"https://api.github.com/repos/serhii-balko/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serhii-balko/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serhii-balko/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/serhii-balko/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serhii-balko/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/serhii-balko/magento2/languages","stargazers_url":"https://api.github.com/repos/serhii-balko/magento2/stargazers","contributors_url":"https://api.github.com/repos/serhii-balko/magento2/contributors","subscribers_url":"https://api.github.com/repos/serhii-balko/magento2/subscribers","subscription_url":"https://api.github.com/repos/serhii-balko/magento2/subscription","commits_url":"https://api.github.com/repos/serhii-balko/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/serhii-balko/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/serhii-balko/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/serhii-balko/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/serhii-balko/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/serhii-balko/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serhii-balko/magento2/merges","archive_url":"https://api.github.com/repos/serhii-balko/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serhii-balko/magento2/downloads","issues_url":"https://api.github.com/repos/serhii-balko/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/serhii-balko/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/serhii-balko/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/serhii-balko/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serhii-balko/magento2/labels{/name}","releases_url":"https://api.github.com/repos/serhii-balko/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/serhii-balko/magento2/deployments","created_at":"2017-10-24T08:14:43Z","updated_at":"2017-10-24T08:15:46Z","pushed_at":"2018-02-23T09:41:18Z","git_url":"git://github.com/serhii-balko/magento2.git","ssh_url":"git@github.com:serhii-balko/magento2.git","clone_url":"https://github.com/serhii-balko/magento2.git","svn_url":"https://github.com/serhii-balko/magento2","homepage":"http://www.magento.com","size":410242,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"a083717504f63fd22748fb42d74b63c2906226ef","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-02-26T19:01:09Z","pushed_at":"2018-02-26T20:32:18Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":422420,"stargazers_count":5285,"watchers_count":5285,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4343,"mirror_url":null,"archived":false,"open_issues_count":1296,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4343,"open_issues":1296,"watchers":5285,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/13819"},"html":{"href":"https://github.com/magento/magento2/pull/13819"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/13819"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/13819/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/13819/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/13819/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/fd5e0b5532b56451cadcc03353bae2ff54838fcc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"magento-engcom-team","id":31669971,"avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"magento-engcom-team"}}