{"action":"created","comment":{"url":"https://api.github.com/repos/molr/molr-remote/pulls/comments/191122528","pull_request_review_id":123635591,"id":191122528,"diff_hunk":"@@ -0,0 +1,30 @@\n+/**\n+ * Copyright (c) 2017 European Organisation for Nuclear Research (CERN), All Rights Reserved.\n+ */\n+\n+package cern.molr.mission.service.custom;\n+\n+import java.util.concurrent.CompletableFuture;\n+\n+import cern.molr.exception.custom.UnsupportedOutputTypeException;\n+import cern.molr.mission.controller.custom.CustomRunMissionController;\n+import cern.molr.mission.controller.custom.CustomStepMissionController;\n+import cern.molr.mission.service.MissionExecutionService;\n+\n+\n+/**\n+ * {@link CustomMissionExecutionService} is a custom service to run/step a mission. It should be implemented as a\n+ * layer upon the default {@link MissionExecutionService}\n+ * \n+ * @author nachivpn\n+ * @author yassine-kr\n+ */\n+public interface CustomMissionExecutionService {\n+\n+    <I,O> CompletableFuture<CustomRunMissionController<O>> runToCompletion(String missionDefnClassName, I args,","path":"api/src/main/java/cern/molr/mission/service/custom/CustomMissionExecutionService.java","position":24,"original_position":24,"commit_id":"633c7e7f0fd22a927d9c0bf5346635ee3b160fa0","original_commit_id":"633c7e7f0fd22a927d9c0bf5346635ee3b160fa0","user":{"login":"timart1n","id":7980551,"avatar_url":"https://avatars2.githubusercontent.com/u/7980551?v=4","gravatar_id":"","url":"https://api.github.com/users/timart1n","html_url":"https://github.com/timart1n","followers_url":"https://api.github.com/users/timart1n/followers","following_url":"https://api.github.com/users/timart1n/following{/other_user}","gists_url":"https://api.github.com/users/timart1n/gists{/gist_id}","starred_url":"https://api.github.com/users/timart1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timart1n/subscriptions","organizations_url":"https://api.github.com/users/timart1n/orgs","repos_url":"https://api.github.com/users/timart1n/repos","events_url":"https://api.github.com/users/timart1n/events{/privacy}","received_events_url":"https://api.github.com/users/timart1n/received_events","type":"User","site_admin":false},"body":"To be discussed in this weeks meeting","created_at":"2018-05-28T06:39:59Z","updated_at":"2018-05-28T06:39:59Z","html_url":"https://github.com/molr/molr-remote/pull/8#discussion_r191122528","pull_request_url":"https://api.github.com/repos/molr/molr-remote/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/comments/191122528"},"html":{"href":"https://github.com/molr/molr-remote/pull/8#discussion_r191122528"},"pull_request":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/8"}},"in_reply_to_id":190802511},"pull_request":{"url":"https://api.github.com/repos/molr/molr-remote/pulls/8","id":185372743,"html_url":"https://github.com/molr/molr-remote/pull/8","diff_url":"https://github.com/molr/molr-remote/pull/8.diff","patch_url":"https://github.com/molr/molr-remote/pull/8.patch","issue_url":"https://api.github.com/repos/molr/molr-remote/issues/8","number":8,"state":"open","locked":false,"title":"Add new client Api and implement communication between client and supervisor","user":{"login":"yassine-kr","id":18330607,"avatar_url":"https://avatars2.githubusercontent.com/u/18330607?v=4","gravatar_id":"","url":"https://api.github.com/users/yassine-kr","html_url":"https://github.com/yassine-kr","followers_url":"https://api.github.com/users/yassine-kr/followers","following_url":"https://api.github.com/users/yassine-kr/following{/other_user}","gists_url":"https://api.github.com/users/yassine-kr/gists{/gist_id}","starred_url":"https://api.github.com/users/yassine-kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassine-kr/subscriptions","organizations_url":"https://api.github.com/users/yassine-kr/orgs","repos_url":"https://api.github.com/users/yassine-kr/repos","events_url":"https://api.github.com/users/yassine-kr/events{/privacy}","received_events_url":"https://api.github.com/users/yassine-kr/received_events","type":"User","site_admin":false},"body":"fixes #7 \r\nUpdate to latest spring 5; fixes #4 ","created_at":"2018-05-02T08:50:32Z","updated_at":"2018-05-28T06:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"064964152f2be18c4ec78af213ed60e9c26763e0","assignee":{"login":"yassine-kr","id":18330607,"avatar_url":"https://avatars2.githubusercontent.com/u/18330607?v=4","gravatar_id":"","url":"https://api.github.com/users/yassine-kr","html_url":"https://github.com/yassine-kr","followers_url":"https://api.github.com/users/yassine-kr/followers","following_url":"https://api.github.com/users/yassine-kr/following{/other_user}","gists_url":"https://api.github.com/users/yassine-kr/gists{/gist_id}","starred_url":"https://api.github.com/users/yassine-kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassine-kr/subscriptions","organizations_url":"https://api.github.com/users/yassine-kr/orgs","repos_url":"https://api.github.com/users/yassine-kr/repos","events_url":"https://api.github.com/users/yassine-kr/events{/privacy}","received_events_url":"https://api.github.com/users/yassine-kr/received_events","type":"User","site_admin":false},"assignees":[{"login":"yassine-kr","id":18330607,"avatar_url":"https://avatars2.githubusercontent.com/u/18330607?v=4","gravatar_id":"","url":"https://api.github.com/users/yassine-kr","html_url":"https://github.com/yassine-kr","followers_url":"https://api.github.com/users/yassine-kr/followers","following_url":"https://api.github.com/users/yassine-kr/following{/other_user}","gists_url":"https://api.github.com/users/yassine-kr/gists{/gist_id}","starred_url":"https://api.github.com/users/yassine-kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassine-kr/subscriptions","organizations_url":"https://api.github.com/users/yassine-kr/orgs","repos_url":"https://api.github.com/users/yassine-kr/repos","events_url":"https://api.github.com/users/yassine-kr/events{/privacy}","received_events_url":"https://api.github.com/users/yassine-kr/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"makemeunsee","id":180648,"avatar_url":"https://avatars0.githubusercontent.com/u/180648?v=4","gravatar_id":"","url":"https://api.github.com/users/makemeunsee","html_url":"https://github.com/makemeunsee","followers_url":"https://api.github.com/users/makemeunsee/followers","following_url":"https://api.github.com/users/makemeunsee/following{/other_user}","gists_url":"https://api.github.com/users/makemeunsee/gists{/gist_id}","starred_url":"https://api.github.com/users/makemeunsee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makemeunsee/subscriptions","organizations_url":"https://api.github.com/users/makemeunsee/orgs","repos_url":"https://api.github.com/users/makemeunsee/repos","events_url":"https://api.github.com/users/makemeunsee/events{/privacy}","received_events_url":"https://api.github.com/users/makemeunsee/received_events","type":"User","site_admin":false},{"login":"kaifox","id":986001,"avatar_url":"https://avatars2.githubusercontent.com/u/986001?v=4","gravatar_id":"","url":"https://api.github.com/users/kaifox","html_url":"https://github.com/kaifox","followers_url":"https://api.github.com/users/kaifox/followers","following_url":"https://api.github.com/users/kaifox/following{/other_user}","gists_url":"https://api.github.com/users/kaifox/gists{/gist_id}","starred_url":"https://api.github.com/users/kaifox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaifox/subscriptions","organizations_url":"https://api.github.com/users/kaifox/orgs","repos_url":"https://api.github.com/users/kaifox/repos","events_url":"https://api.github.com/users/kaifox/events{/privacy}","received_events_url":"https://api.github.com/users/kaifox/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/molr/molr-remote/pulls/8/commits","review_comments_url":"https://api.github.com/repos/molr/molr-remote/pulls/8/comments","review_comment_url":"https://api.github.com/repos/molr/molr-remote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/molr/molr-remote/issues/8/comments","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/633c7e7f0fd22a927d9c0bf5346635ee3b160fa0","head":{"label":"molr:communication_client_supervisor","ref":"communication_client_supervisor","sha":"633c7e7f0fd22a927d9c0bf5346635ee3b160fa0","user":{"login":"molr","id":29492821,"avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"repo":{"id":99821218,"name":"molr-remote","full_name":"molr/molr-remote","owner":{"login":"molr","id":29492821,"avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molr/molr-remote","description":"A delegation framework for accelerator commissioning with remote execution","fork":false,"url":"https://api.github.com/repos/molr/molr-remote","forks_url":"https://api.github.com/repos/molr/molr-remote/forks","keys_url":"https://api.github.com/repos/molr/molr-remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molr/molr-remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molr/molr-remote/teams","hooks_url":"https://api.github.com/repos/molr/molr-remote/hooks","issue_events_url":"https://api.github.com/repos/molr/molr-remote/issues/events{/number}","events_url":"https://api.github.com/repos/molr/molr-remote/events","assignees_url":"https://api.github.com/repos/molr/molr-remote/assignees{/user}","branches_url":"https://api.github.com/repos/molr/molr-remote/branches{/branch}","tags_url":"https://api.github.com/repos/molr/molr-remote/tags","blobs_url":"https://api.github.com/repos/molr/molr-remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molr/molr-remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molr/molr-remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/molr/molr-remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/{sha}","languages_url":"https://api.github.com/repos/molr/molr-remote/languages","stargazers_url":"https://api.github.com/repos/molr/molr-remote/stargazers","contributors_url":"https://api.github.com/repos/molr/molr-remote/contributors","subscribers_url":"https://api.github.com/repos/molr/molr-remote/subscribers","subscription_url":"https://api.github.com/repos/molr/molr-remote/subscription","commits_url":"https://api.github.com/repos/molr/molr-remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/molr/molr-remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/molr/molr-remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/molr/molr-remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/molr/molr-remote/contents/{+path}","compare_url":"https://api.github.com/repos/molr/molr-remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molr/molr-remote/merges","archive_url":"https://api.github.com/repos/molr/molr-remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molr/molr-remote/downloads","issues_url":"https://api.github.com/repos/molr/molr-remote/issues{/number}","pulls_url":"https://api.github.com/repos/molr/molr-remote/pulls{/number}","milestones_url":"https://api.github.com/repos/molr/molr-remote/milestones{/number}","notifications_url":"https://api.github.com/repos/molr/molr-remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molr/molr-remote/labels{/name}","releases_url":"https://api.github.com/repos/molr/molr-remote/releases{/id}","deployments_url":"https://api.github.com/repos/molr/molr-remote/deployments","created_at":"2017-08-09T15:02:43Z","updated_at":"2018-05-17T13:09:42Z","pushed_at":"2018-05-24T09:37:54Z","git_url":"git://github.com/molr/molr-remote.git","ssh_url":"git@github.com:molr/molr-remote.git","clone_url":"https://github.com/molr/molr-remote.git","svn_url":"https://github.com/molr/molr-remote","homepage":"","size":483,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"molr:master","ref":"master","sha":"4eef4cd6e48c82d012804dbf83de4e7c15ecbcfc","user":{"login":"molr","id":29492821,"avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"repo":{"id":99821218,"name":"molr-remote","full_name":"molr/molr-remote","owner":{"login":"molr","id":29492821,"avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molr/molr-remote","description":"A delegation framework for accelerator commissioning with remote execution","fork":false,"url":"https://api.github.com/repos/molr/molr-remote","forks_url":"https://api.github.com/repos/molr/molr-remote/forks","keys_url":"https://api.github.com/repos/molr/molr-remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molr/molr-remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molr/molr-remote/teams","hooks_url":"https://api.github.com/repos/molr/molr-remote/hooks","issue_events_url":"https://api.github.com/repos/molr/molr-remote/issues/events{/number}","events_url":"https://api.github.com/repos/molr/molr-remote/events","assignees_url":"https://api.github.com/repos/molr/molr-remote/assignees{/user}","branches_url":"https://api.github.com/repos/molr/molr-remote/branches{/branch}","tags_url":"https://api.github.com/repos/molr/molr-remote/tags","blobs_url":"https://api.github.com/repos/molr/molr-remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molr/molr-remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molr/molr-remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/molr/molr-remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/{sha}","languages_url":"https://api.github.com/repos/molr/molr-remote/languages","stargazers_url":"https://api.github.com/repos/molr/molr-remote/stargazers","contributors_url":"https://api.github.com/repos/molr/molr-remote/contributors","subscribers_url":"https://api.github.com/repos/molr/molr-remote/subscribers","subscription_url":"https://api.github.com/repos/molr/molr-remote/subscription","commits_url":"https://api.github.com/repos/molr/molr-remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/molr/molr-remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/molr/molr-remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/molr/molr-remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/molr/molr-remote/contents/{+path}","compare_url":"https://api.github.com/repos/molr/molr-remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molr/molr-remote/merges","archive_url":"https://api.github.com/repos/molr/molr-remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molr/molr-remote/downloads","issues_url":"https://api.github.com/repos/molr/molr-remote/issues{/number}","pulls_url":"https://api.github.com/repos/molr/molr-remote/pulls{/number}","milestones_url":"https://api.github.com/repos/molr/molr-remote/milestones{/number}","notifications_url":"https://api.github.com/repos/molr/molr-remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molr/molr-remote/labels{/name}","releases_url":"https://api.github.com/repos/molr/molr-remote/releases{/id}","deployments_url":"https://api.github.com/repos/molr/molr-remote/deployments","created_at":"2017-08-09T15:02:43Z","updated_at":"2018-05-17T13:09:42Z","pushed_at":"2018-05-24T09:37:54Z","git_url":"git://github.com/molr/molr-remote.git","ssh_url":"git@github.com:molr/molr-remote.git","clone_url":"https://github.com/molr/molr-remote.git","svn_url":"https://github.com/molr/molr-remote","homepage":"","size":483,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/8"},"html":{"href":"https://github.com/molr/molr-remote/pull/8"},"issue":{"href":"https://api.github.com/repos/molr/molr-remote/issues/8"},"comments":{"href":"https://api.github.com/repos/molr/molr-remote/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/molr/molr-remote/statuses/633c7e7f0fd22a927d9c0bf5346635ee3b160fa0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timart1n"}}