{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/minigo/pulls/comments/166415417","pull_request_review_id":94473885,"id":166415417,"diff_hunk":"@@ -81,6 +83,8 @@ def bootstrap(self):\n             tf.train.Saver().save(sess, self.save_file)\n \n     def train(self, tf_records, init_from=None, logdir=None, num_steps=None):\n+        def should_log(i):","path":"dual_net.py","position":15,"original_position":15,"commit_id":"76af726f4d58fd445496734a41e22ff36afe3657","original_commit_id":"76af726f4d58fd445496734a41e22ff36afe3657","user":{"login":"amj","id":422841,"avatar_url":"https://avatars3.githubusercontent.com/u/422841?v=4","gravatar_id":"","url":"https://api.github.com/users/amj","html_url":"https://github.com/amj","followers_url":"https://api.github.com/users/amj/followers","following_url":"https://api.github.com/users/amj/following{/other_user}","gists_url":"https://api.github.com/users/amj/gists{/gist_id}","starred_url":"https://api.github.com/users/amj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amj/subscriptions","organizations_url":"https://api.github.com/users/amj/orgs","repos_url":"https://api.github.com/users/amj/repos","events_url":"https://api.github.com/users/amj/events{/privacy}","received_events_url":"https://api.github.com/users/amj/received_events","type":"User","site_admin":false},"body":"we don't want to actually do these computations every step for millions of steps -- it'd be a lot of wasted work.  So what we 'log' are actually the metrics.","created_at":"2018-02-06T19:26:31Z","updated_at":"2018-02-06T19:26:31Z","html_url":"https://github.com/tensorflow/minigo/pull/63#discussion_r166415417","pull_request_url":"https://api.github.com/repos/tensorflow/minigo/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/comments/166415417"},"html":{"href":"https://github.com/tensorflow/minigo/pull/63#discussion_r166415417"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/63"}},"in_reply_to_id":166398479},"pull_request":{"url":"https://api.github.com/repos/tensorflow/minigo/pulls/63","id":167442807,"html_url":"https://github.com/tensorflow/minigo/pull/63","diff_url":"https://github.com/tensorflow/minigo/pull/63.diff","patch_url":"https://github.com/tensorflow/minigo/pull/63.patch","issue_url":"https://api.github.com/repos/tensorflow/minigo/issues/63","number":63,"state":"open","locked":false,"title":"Implement gradient norm logging","user":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T15:19:10Z","updated_at":"2018-02-06T19:26:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"amj","id":422841,"avatar_url":"https://avatars3.githubusercontent.com/u/422841?v=4","gravatar_id":"","url":"https://api.github.com/users/amj","html_url":"https://github.com/amj","followers_url":"https://api.github.com/users/amj/followers","following_url":"https://api.github.com/users/amj/following{/other_user}","gists_url":"https://api.github.com/users/amj/gists{/gist_id}","starred_url":"https://api.github.com/users/amj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amj/subscriptions","organizations_url":"https://api.github.com/users/amj/orgs","repos_url":"https://api.github.com/users/amj/repos","events_url":"https://api.github.com/users/amj/events{/privacy}","received_events_url":"https://api.github.com/users/amj/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/minigo/pulls/63/commits","review_comments_url":"https://api.github.com/repos/tensorflow/minigo/pulls/63/comments","review_comment_url":"https://api.github.com/repos/tensorflow/minigo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/minigo/issues/63/comments","statuses_url":"https://api.github.com/repos/tensorflow/minigo/statuses/76af726f4d58fd445496734a41e22ff36afe3657","head":{"label":"brilee:log_gradient_norms","ref":"log_gradient_norms","sha":"76af726f4d58fd445496734a41e22ff36afe3657","user":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"repo":{"id":120157364,"name":"minigo","full_name":"brilee/minigo","owner":{"login":"brilee","id":1320214,"avatar_url":"https://avatars2.githubusercontent.com/u/1320214?v=4","gravatar_id":"","url":"https://api.github.com/users/brilee","html_url":"https://github.com/brilee","followers_url":"https://api.github.com/users/brilee/followers","following_url":"https://api.github.com/users/brilee/following{/other_user}","gists_url":"https://api.github.com/users/brilee/gists{/gist_id}","starred_url":"https://api.github.com/users/brilee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brilee/subscriptions","organizations_url":"https://api.github.com/users/brilee/orgs","repos_url":"https://api.github.com/users/brilee/repos","events_url":"https://api.github.com/users/brilee/events{/privacy}","received_events_url":"https://api.github.com/users/brilee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brilee/minigo","description":"An open-source implementation of the AlphaGoZero algorithm","fork":true,"url":"https://api.github.com/repos/brilee/minigo","forks_url":"https://api.github.com/repos/brilee/minigo/forks","keys_url":"https://api.github.com/repos/brilee/minigo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brilee/minigo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brilee/minigo/teams","hooks_url":"https://api.github.com/repos/brilee/minigo/hooks","issue_events_url":"https://api.github.com/repos/brilee/minigo/issues/events{/number}","events_url":"https://api.github.com/repos/brilee/minigo/events","assignees_url":"https://api.github.com/repos/brilee/minigo/assignees{/user}","branches_url":"https://api.github.com/repos/brilee/minigo/branches{/branch}","tags_url":"https://api.github.com/repos/brilee/minigo/tags","blobs_url":"https://api.github.com/repos/brilee/minigo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brilee/minigo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brilee/minigo/git/refs{/sha}","trees_url":"https://api.github.com/repos/brilee/minigo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brilee/minigo/statuses/{sha}","languages_url":"https://api.github.com/repos/brilee/minigo/languages","stargazers_url":"https://api.github.com/repos/brilee/minigo/stargazers","contributors_url":"https://api.github.com/repos/brilee/minigo/contributors","subscribers_url":"https://api.github.com/repos/brilee/minigo/subscribers","subscription_url":"https://api.github.com/repos/brilee/minigo/subscription","commits_url":"https://api.github.com/repos/brilee/minigo/commits{/sha}","git_commits_url":"https://api.github.com/repos/brilee/minigo/git/commits{/sha}","comments_url":"https://api.github.com/repos/brilee/minigo/comments{/number}","issue_comment_url":"https://api.github.com/repos/brilee/minigo/issues/comments{/number}","contents_url":"https://api.github.com/repos/brilee/minigo/contents/{+path}","compare_url":"https://api.github.com/repos/brilee/minigo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brilee/minigo/merges","archive_url":"https://api.github.com/repos/brilee/minigo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brilee/minigo/downloads","issues_url":"https://api.github.com/repos/brilee/minigo/issues{/number}","pulls_url":"https://api.github.com/repos/brilee/minigo/pulls{/number}","milestones_url":"https://api.github.com/repos/brilee/minigo/milestones{/number}","notifications_url":"https://api.github.com/repos/brilee/minigo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brilee/minigo/labels{/name}","releases_url":"https://api.github.com/repos/brilee/minigo/releases{/id}","deployments_url":"https://api.github.com/repos/brilee/minigo/deployments","created_at":"2018-02-04T05:19:56Z","updated_at":"2018-02-04T05:19:58Z","pushed_at":"2018-02-06T15:18:08Z","git_url":"git://github.com/brilee/minigo.git","ssh_url":"git@github.com:brilee/minigo.git","clone_url":"https://github.com/brilee/minigo.git","svn_url":"https://github.com/brilee/minigo","homepage":"","size":351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"8c6ffc7a3807614e305f188b0a27b1c5c1cea3ea","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":119455332,"name":"minigo","full_name":"tensorflow/minigo","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/minigo","description":"An open-source implementation of the AlphaGoZero algorithm","fork":false,"url":"https://api.github.com/repos/tensorflow/minigo","forks_url":"https://api.github.com/repos/tensorflow/minigo/forks","keys_url":"https://api.github.com/repos/tensorflow/minigo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/minigo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/minigo/teams","hooks_url":"https://api.github.com/repos/tensorflow/minigo/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/minigo/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/minigo/events","assignees_url":"https://api.github.com/repos/tensorflow/minigo/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/minigo/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/minigo/tags","blobs_url":"https://api.github.com/repos/tensorflow/minigo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/minigo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/minigo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/minigo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/minigo/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/minigo/languages","stargazers_url":"https://api.github.com/repos/tensorflow/minigo/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/minigo/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/minigo/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/minigo/subscription","commits_url":"https://api.github.com/repos/tensorflow/minigo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/minigo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/minigo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/minigo/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/minigo/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/minigo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/minigo/merges","archive_url":"https://api.github.com/repos/tensorflow/minigo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/minigo/downloads","issues_url":"https://api.github.com/repos/tensorflow/minigo/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/minigo/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/minigo/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/minigo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/minigo/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/minigo/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/minigo/deployments","created_at":"2018-01-29T23:29:07Z","updated_at":"2018-02-06T19:19:43Z","pushed_at":"2018-02-06T19:19:48Z","git_url":"git://github.com/tensorflow/minigo.git","ssh_url":"git@github.com:tensorflow/minigo.git","clone_url":"https://github.com/tensorflow/minigo.git","svn_url":"https://github.com/tensorflow/minigo","homepage":"","size":369,"stargazers_count":1361,"watchers_count":1361,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":115,"open_issues":33,"watchers":1361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/63"},"html":{"href":"https://github.com/tensorflow/minigo/pull/63"},"issue":{"href":"https://api.github.com/repos/tensorflow/minigo/issues/63"},"comments":{"href":"https://api.github.com/repos/tensorflow/minigo/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/minigo/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/minigo/statuses/76af726f4d58fd445496734a41e22ff36afe3657"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amj"}}