{"action":"created","issue":{"url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/89","repository_url":"https://api.github.com/repos/mysql-otp/mysql-otp","labels_url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/89/comments","events_url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/89/events","html_url":"https://github.com/mysql-otp/mysql-otp/pull/89","id":359776395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTg5NjY2","number":89,"title":"Fix incorrect assumption regarding lock wait timeout","user":{"login":"emfa","id":553423,"node_id":"MDQ6VXNlcjU1MzQyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/553423?v=4","gravatar_id":"","url":"https://api.github.com/users/emfa","html_url":"https://github.com/emfa","followers_url":"https://api.github.com/users/emfa/followers","following_url":"https://api.github.com/users/emfa/following{/other_user}","gists_url":"https://api.github.com/users/emfa/gists{/gist_id}","starred_url":"https://api.github.com/users/emfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emfa/subscriptions","organizations_url":"https://api.github.com/users/emfa/orgs","repos_url":"https://api.github.com/users/emfa/repos","events_url":"https://api.github.com/users/emfa/events{/privacy}","received_events_url":"https://api.github.com/users/emfa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-09-13T07:34:15Z","updated_at":"2018-09-19T07:45:07Z","closed_at":"2018-09-18T09:10:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mysql-otp/mysql-otp/pulls/89","html_url":"https://github.com/mysql-otp/mysql-otp/pull/89","diff_url":"https://github.com/mysql-otp/mysql-otp/pull/89.diff","patch_url":"https://github.com/mysql-otp/mysql-otp/pull/89.patch"},"body":"According to the documentation this has not been the default behaviour for quite some time. And the default is to not roll back on these errors. I think the problem has been masked by the extra ROLLBACK-statement.\r\n\r\nWe had problems when we got a lot of lock wait timeouts and had high load on the servers. There is a possibility of bad interleaving of processes after we incorrectly assume that the transaction bit is 0/1 and a ping-message arrives before the extra ROLLBACK is sent by the client.\r\n\r\nUnfortunately I've not been able(or had time) to reproduce it since it requires lock waits in the DB and a high load (or the use of concuerror or the like)."},"comment":{"url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/comments/422694339","html_url":"https://github.com/mysql-otp/mysql-otp/pull/89#issuecomment-422694339","issue_url":"https://api.github.com/repos/mysql-otp/mysql-otp/issues/89","id":422694339,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjY5NDMzOQ==","user":{"login":"emfa","id":553423,"node_id":"MDQ6VXNlcjU1MzQyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/553423?v=4","gravatar_id":"","url":"https://api.github.com/users/emfa","html_url":"https://github.com/emfa","followers_url":"https://api.github.com/users/emfa/followers","following_url":"https://api.github.com/users/emfa/following{/other_user}","gists_url":"https://api.github.com/users/emfa/gists{/gist_id}","starred_url":"https://api.github.com/users/emfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emfa/subscriptions","organizations_url":"https://api.github.com/users/emfa/orgs","repos_url":"https://api.github.com/users/emfa/repos","events_url":"https://api.github.com/users/emfa/events{/privacy}","received_events_url":"https://api.github.com/users/emfa/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T07:45:07Z","updated_at":"2018-09-19T07:45:07Z","author_association":"CONTRIBUTOR","body":"Well, a change without reason is stupid(at the very least in critical software) so no problems. :)\r\nThe comments definitely helped. Yeah, sure, add them, the more the merrier!\r\n\r\nYeah, it's kinda wierd behavior if you ask me but we have to live with it.\r\n\r\nIt's been running for a while now and we have not encountered the crashes we had so far, peppar peppar!\r\n\r\nThanks for the quick merge."}}
{"actor":{"display_login":"emfa"}}