{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3/pulls/comments/221038036","pull_request_review_id":159591619,"id":221038036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTAzODAzNg==","diff_hunk":"@@ -257,6 +257,8 @@ func (s *m3storage) Write(\n \tid := query.Tags.ID()\n \t// TODO: Consider caching id -> identID","path":"src/query/storage/m3/storage.go","position":2,"original_position":2,"commit_id":"96f15914d55b3611a0a9f76e2c918495cca5e0ed","original_commit_id":"96f15914d55b3611a0a9f76e2c918495cca5e0ed","user":{"login":"richardartoul","id":9171254,"node_id":"MDQ6VXNlcjkxNzEyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9171254?v=4","gravatar_id":"","url":"https://api.github.com/users/richardartoul","html_url":"https://github.com/richardartoul","followers_url":"https://api.github.com/users/richardartoul/followers","following_url":"https://api.github.com/users/richardartoul/following{/other_user}","gists_url":"https://api.github.com/users/richardartoul/gists{/gist_id}","starred_url":"https://api.github.com/users/richardartoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardartoul/subscriptions","organizations_url":"https://api.github.com/users/richardartoul/orgs","repos_url":"https://api.github.com/users/richardartoul/repos","events_url":"https://api.github.com/users/richardartoul/events{/privacy}","received_events_url":"https://api.github.com/users/richardartoul/received_events","type":"User","site_admin":false},"body":"Caching these in an LRU would actually probably save a ton of allocs unrelated to this P.R","created_at":"2018-09-27T18:53:00Z","updated_at":"2018-09-27T18:53:00Z","html_url":"https://github.com/m3db/m3/pull/956#discussion_r221038036","pull_request_url":"https://api.github.com/repos/m3db/m3/pulls/956","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments/221038036"},"html":{"href":"https://github.com/m3db/m3/pull/956#discussion_r221038036"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3/pulls/956"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3/pulls/956","id":218752294,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzUyMjk0","html_url":"https://github.com/m3db/m3/pull/956","diff_url":"https://github.com/m3db/m3/pull/956.diff","patch_url":"https://github.com/m3db/m3/pull/956.patch","issue_url":"https://api.github.com/repos/m3db/m3/issues/956","number":956,"state":"open","locked":false,"title":"Set namespace and ID as NoFinalize","user":{"login":"arnikola","id":14959893,"node_id":"MDQ6VXNlcjE0OTU5ODkz","avatar_url":"https://avatars0.githubusercontent.com/u/14959893?v=4","gravatar_id":"","url":"https://api.github.com/users/arnikola","html_url":"https://github.com/arnikola","followers_url":"https://api.github.com/users/arnikola/followers","following_url":"https://api.github.com/users/arnikola/following{/other_user}","gists_url":"https://api.github.com/users/arnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/arnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnikola/subscriptions","organizations_url":"https://api.github.com/users/arnikola/orgs","repos_url":"https://api.github.com/users/arnikola/repos","events_url":"https://api.github.com/users/arnikola/events{/privacy}","received_events_url":"https://api.github.com/users/arnikola/received_events","type":"User","site_admin":false},"body":"This allows the session to avoid cloning these on the WriteTagged\r\noperation, which will save two allocations for each datapoint","created_at":"2018-09-27T18:47:09Z","updated_at":"2018-09-27T18:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ccadf716431745264c627e57f4e19e288b868b6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robskillington","id":339615,"node_id":"MDQ6VXNlcjMzOTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},{"login":"nikunjgit","id":1733496,"node_id":"MDQ6VXNlcjE3MzM0OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1733496?v=4","gravatar_id":"","url":"https://api.github.com/users/nikunjgit","html_url":"https://github.com/nikunjgit","followers_url":"https://api.github.com/users/nikunjgit/followers","following_url":"https://api.github.com/users/nikunjgit/following{/other_user}","gists_url":"https://api.github.com/users/nikunjgit/gists{/gist_id}","starred_url":"https://api.github.com/users/nikunjgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikunjgit/subscriptions","organizations_url":"https://api.github.com/users/nikunjgit/orgs","repos_url":"https://api.github.com/users/nikunjgit/repos","events_url":"https://api.github.com/users/nikunjgit/events{/privacy}","received_events_url":"https://api.github.com/users/nikunjgit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3/pulls/956/commits","review_comments_url":"https://api.github.com/repos/m3db/m3/pulls/956/comments","review_comment_url":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3/issues/956/comments","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/96f15914d55b3611a0a9f76e2c918495cca5e0ed","head":{"label":"m3db:arnikola/no-finalize","ref":"arnikola/no-finalize","sha":"96f15914d55b3611a0a9f76e2c918495cca5e0ed","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB and Query Engine, Prometheus Sidecar, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2018-09-27T16:58:21Z","pushed_at":"2018-09-27T18:48:05Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":13999,"stargazers_count":1143,"watchers_count":1143,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":82,"open_issues":148,"watchers":1143,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"835df4da27edd1fd96efba4c197fd7f2b27fcffa","user":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1MzY3Nw==","name":"m3","full_name":"m3db/m3","private":false,"owner":{"login":"m3db","id":19937171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTM3MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/m3db/m3","description":"M3 monorepo - Distributed TSDB and Query Engine, Prometheus Sidecar, Metrics Platform","fork":false,"url":"https://api.github.com/repos/m3db/m3","forks_url":"https://api.github.com/repos/m3db/m3/forks","keys_url":"https://api.github.com/repos/m3db/m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3/teams","hooks_url":"https://api.github.com/repos/m3db/m3/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3/events","assignees_url":"https://api.github.com/repos/m3db/m3/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3/tags","blobs_url":"https://api.github.com/repos/m3db/m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3/languages","stargazers_url":"https://api.github.com/repos/m3db/m3/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3/subscription","commits_url":"https://api.github.com/repos/m3db/m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3/merges","archive_url":"https://api.github.com/repos/m3db/m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3/downloads","issues_url":"https://api.github.com/repos/m3db/m3/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2018-09-27T16:58:21Z","pushed_at":"2018-09-27T18:48:05Z","git_url":"git://github.com/m3db/m3.git","ssh_url":"git@github.com:m3db/m3.git","clone_url":"https://github.com/m3db/m3.git","svn_url":"https://github.com/m3db/m3","homepage":"https://m3db.io/","size":13999,"stargazers_count":1143,"watchers_count":1143,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":82,"open_issues":148,"watchers":1143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3/pulls/956"},"html":{"href":"https://github.com/m3db/m3/pull/956"},"issue":{"href":"https://api.github.com/repos/m3db/m3/issues/956"},"comments":{"href":"https://api.github.com/repos/m3db/m3/issues/956/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3/pulls/956/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3/pulls/956/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3/statuses/96f15914d55b3611a0a9f76e2c918495cca5e0ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"richardartoul"}}