{"action":"created","issue":{"url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/1","repository_url":"https://api.github.com/repos/mit-pdos/distributary-mysql","labels_url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/1/comments","events_url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/1/events","html_url":"https://github.com/mit-pdos/distributary-mysql/pull/1","id":307850176,"number":1,"title":"UPDATE and DELETE support","user":{"login":"ekmartin","id":3536982,"avatar_url":"https://avatars2.githubusercontent.com/u/3536982?v=4","gravatar_id":"","url":"https://api.github.com/users/ekmartin","html_url":"https://github.com/ekmartin","followers_url":"https://api.github.com/users/ekmartin/followers","following_url":"https://api.github.com/users/ekmartin/following{/other_user}","gists_url":"https://api.github.com/users/ekmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmartin/subscriptions","organizations_url":"https://api.github.com/users/ekmartin/orgs","repos_url":"https://api.github.com/users/ekmartin/repos","events_url":"https://api.github.com/users/ekmartin/events{/privacy}","received_events_url":"https://api.github.com/users/ekmartin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-22T23:28:59Z","updated_at":"2018-03-25T18:56:53Z","closed_at":"2018-03-25T18:56:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mit-pdos/distributary-mysql/pulls/1","html_url":"https://github.com/mit-pdos/distributary-mysql/pull/1","diff_url":"https://github.com/mit-pdos/distributary-mysql/pull/1.diff","patch_url":"https://github.com/mit-pdos/distributary-mysql/pull/1.patch"},"body":"This adds support for `UPDATE` and `DELETE` of one or more rows with `WHERE`-clauses on primary keys. It handles a decent amount of edge cases, but definitely far from full coverage.\r\n\r\nProbably went a bit overboard with the tests - hopefully it'll help in the long run though. I can send a separate PR with some tests for the other functions as well.\r\n\r\n~Currently it needs the `PRIMARY KEY` annotation to be on the field type as well, e.g.\r\n`CREATE TABLE T (id int PRIMARY KEY, PRIMARY KEY (id))` and not just `CREATE TABLE T (id int, PRIMARY KEY (id))` but I'll look into fixing that now (`distributary` seems to need the `PRIMARY KEY (id)` constraint, which should probably be fixed too).~"},"comment":{"url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/comments/375994240","html_url":"https://github.com/mit-pdos/distributary-mysql/pull/1#issuecomment-375994240","issue_url":"https://api.github.com/repos/mit-pdos/distributary-mysql/issues/1","id":375994240,"user":{"login":"ekmartin","id":3536982,"avatar_url":"https://avatars2.githubusercontent.com/u/3536982?v=4","gravatar_id":"","url":"https://api.github.com/users/ekmartin","html_url":"https://github.com/ekmartin","followers_url":"https://api.github.com/users/ekmartin/followers","following_url":"https://api.github.com/users/ekmartin/following{/other_user}","gists_url":"https://api.github.com/users/ekmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmartin/subscriptions","organizations_url":"https://api.github.com/users/ekmartin/orgs","repos_url":"https://api.github.com/users/ekmartin/repos","events_url":"https://api.github.com/users/ekmartin/events{/privacy}","received_events_url":"https://api.github.com/users/ekmartin/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T18:56:53Z","updated_at":"2018-03-25T18:56:53Z","author_association":"CONTRIBUTOR","body":"Yep, that'd be a lot nicer indeed."}}
{"actor":{"display_login":"ekmartin"}}