{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7748","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7748/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7748/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7748/events","html_url":"https://github.com/istio/istio/pull/7748","id":348868781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTE5MzY5","number":7748,"title":"ShellCheck: Enable and fix SC1090 and SC1091","user":{"login":"Tahler","id":10715719,"node_id":"MDQ6VXNlcjEwNzE1NzE5","avatar_url":"https://avatars3.githubusercontent.com/u/10715719?v=4","gravatar_id":"","url":"https://api.github.com/users/Tahler","html_url":"https://github.com/Tahler","followers_url":"https://api.github.com/users/Tahler/followers","following_url":"https://api.github.com/users/Tahler/following{/other_user}","gists_url":"https://api.github.com/users/Tahler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tahler/subscriptions","organizations_url":"https://api.github.com/users/Tahler/orgs","repos_url":"https://api.github.com/users/Tahler/repos","events_url":"https://api.github.com/users/Tahler/events{/privacy}","received_events_url":"https://api.github.com/users/Tahler/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-08T19:54:12Z","updated_at":"2018-08-09T04:15:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7748","html_url":"https://github.com/istio/istio/pull/7748","diff_url":"https://github.com/istio/istio/pull/7748.diff","patch_url":"https://github.com/istio/istio/pull/7748.patch"},"body":"Enable and fix [SC1090](https://github.com/koalaman/shellcheck/wiki/SC1090) and [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091). Both are related to verifying how scripts are used as dependencies (through `source` or `.`).\r\n\r\nMany scripts, such as `$HOME/.istiorc` do not exist in the repository so those instances are disabled.\r\n\r\nThese are the final two violated rules for ShellCheck 5.0!\r\n\r\n/cc @mandarjog\r\n/assign @mandarjog"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/411631370","html_url":"https://github.com/istio/istio/pull/7748#issuecomment-411631370","issue_url":"https://api.github.com/repos/istio/istio/issues/7748","id":411631370,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYzMTM3MA==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T04:15:55Z","updated_at":"2018-08-09T04:15:55Z","author_association":"COLLABORATOR","body":"@Tahler: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/e2e-simpleTests.sh | 3ff54a529243bda882f97eb416d9a2a0daa5849f | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/7748/e2e-simpleTests/7309/) | `/test e2e-simple`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}