{"action":"closed","number":94,"pull_request":{"url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94","id":192533106,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTMzMTA2","html_url":"https://github.com/Azure/iothub-manager-java/pull/94","diff_url":"https://github.com/Azure/iothub-manager-java/pull/94.diff","patch_url":"https://github.com/Azure/iothub-manager-java/pull/94.patch","issue_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/94","number":94,"state":"closed","locked":false,"title":"Before build, detect whether secrets are available","user":{"login":"mechaffin","id":16829221,"node_id":"MDQ6VXNlcjE2ODI5MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/16829221?v=4","gravatar_id":"","url":"https://api.github.com/users/mechaffin","html_url":"https://github.com/mechaffin","followers_url":"https://api.github.com/users/mechaffin/followers","following_url":"https://api.github.com/users/mechaffin/following{/other_user}","gists_url":"https://api.github.com/users/mechaffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mechaffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mechaffin/subscriptions","organizations_url":"https://api.github.com/users/mechaffin/orgs","repos_url":"https://api.github.com/users/mechaffin/repos","events_url":"https://api.github.com/users/mechaffin/events{/privacy}","received_events_url":"https://api.github.com/users/mechaffin/received_events","type":"User","site_admin":false},"body":"Before checking all the env vars, detect whether secrets, usually encrypted, are available or not. Secrets are not available when building a pull request, so the script will not check for those.\r\n\r\n# Description and Motivation <!-- Info & Context so we can review your pull request -->\r\n\r\nBefore checking all the env vars, detect whether secrets, usually encrypted, are available or not. Secrets are not available when building a pull request, so the script will not check for those.\r\n\r\nThis change allows the build to run for pull requests, e.g. unit tests can be executed. \r\nFunctional tests requiring secrets won't work.\r\n\r\n# Change type <!-- [x] in all the boxes that apply -->\r\n\r\n- [x] Bug fix\r\n- [ ] New feature\r\n- [ ] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [x] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly","created_at":"2018-06-04T21:26:25Z","updated_at":"2018-06-05T18:52:44Z","closed_at":"2018-06-05T18:52:44Z","merged_at":"2018-06-05T18:52:44Z","merge_commit_sha":"aa314e1c2483f74c8d8b21e26490221ae13bf544","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zhang-hua","id":2011059,"node_id":"MDQ6VXNlcjIwMTEwNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false},{"login":"jillcary","id":3317135,"node_id":"MDQ6VXNlcjMzMTcxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3317135?v=4","gravatar_id":"","url":"https://api.github.com/users/jillcary","html_url":"https://github.com/jillcary","followers_url":"https://api.github.com/users/jillcary/followers","following_url":"https://api.github.com/users/jillcary/following{/other_user}","gists_url":"https://api.github.com/users/jillcary/gists{/gist_id}","starred_url":"https://api.github.com/users/jillcary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jillcary/subscriptions","organizations_url":"https://api.github.com/users/jillcary/orgs","repos_url":"https://api.github.com/users/jillcary/repos","events_url":"https://api.github.com/users/jillcary/events{/privacy}","received_events_url":"https://api.github.com/users/jillcary/received_events","type":"User","site_admin":false},{"login":"timlaverty","id":5084013,"node_id":"MDQ6VXNlcjUwODQwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5084013?v=4","gravatar_id":"","url":"https://api.github.com/users/timlaverty","html_url":"https://github.com/timlaverty","followers_url":"https://api.github.com/users/timlaverty/followers","following_url":"https://api.github.com/users/timlaverty/following{/other_user}","gists_url":"https://api.github.com/users/timlaverty/gists{/gist_id}","starred_url":"https://api.github.com/users/timlaverty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timlaverty/subscriptions","organizations_url":"https://api.github.com/users/timlaverty/orgs","repos_url":"https://api.github.com/users/timlaverty/repos","events_url":"https://api.github.com/users/timlaverty/events{/privacy}","received_events_url":"https://api.github.com/users/timlaverty/received_events","type":"User","site_admin":false},{"login":"ppathan","id":16170750,"node_id":"MDQ6VXNlcjE2MTcwNzUw","avatar_url":"https://avatars2.githubusercontent.com/u/16170750?v=4","gravatar_id":"","url":"https://api.github.com/users/ppathan","html_url":"https://github.com/ppathan","followers_url":"https://api.github.com/users/ppathan/followers","following_url":"https://api.github.com/users/ppathan/following{/other_user}","gists_url":"https://api.github.com/users/ppathan/gists{/gist_id}","starred_url":"https://api.github.com/users/ppathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppathan/subscriptions","organizations_url":"https://api.github.com/users/ppathan/orgs","repos_url":"https://api.github.com/users/ppathan/repos","events_url":"https://api.github.com/users/ppathan/events{/privacy}","received_events_url":"https://api.github.com/users/ppathan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94/commits","review_comments_url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94/comments","review_comment_url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/94/comments","statuses_url":"https://api.github.com/repos/Azure/iothub-manager-java/statuses/725a40e6e17fbb7d2b283e90569a991b738d2b47","head":{"label":"Azure:env-detect-secrets","ref":"env-detect-secrets","sha":"725a40e6e17fbb7d2b283e90569a991b738d2b47","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":88778324,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3ODMyNA==","name":"iothub-manager-java","full_name":"Azure/iothub-manager-java","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/iothub-manager-java","description":"Azure IoT PCS microservice for IoT Hub management","fork":false,"url":"https://api.github.com/repos/Azure/iothub-manager-java","forks_url":"https://api.github.com/repos/Azure/iothub-manager-java/forks","keys_url":"https://api.github.com/repos/Azure/iothub-manager-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iothub-manager-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iothub-manager-java/teams","hooks_url":"https://api.github.com/repos/Azure/iothub-manager-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iothub-manager-java/events","assignees_url":"https://api.github.com/repos/Azure/iothub-manager-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iothub-manager-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iothub-manager-java/tags","blobs_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iothub-manager-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iothub-manager-java/languages","stargazers_url":"https://api.github.com/repos/Azure/iothub-manager-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/iothub-manager-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/iothub-manager-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/iothub-manager-java/subscription","commits_url":"https://api.github.com/repos/Azure/iothub-manager-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iothub-manager-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iothub-manager-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iothub-manager-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iothub-manager-java/merges","archive_url":"https://api.github.com/repos/Azure/iothub-manager-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iothub-manager-java/downloads","issues_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iothub-manager-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iothub-manager-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iothub-manager-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iothub-manager-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iothub-manager-java/deployments","created_at":"2017-04-19T18:36:26Z","updated_at":"2018-05-30T13:57:02Z","pushed_at":"2018-06-05T18:52:44Z","git_url":"git://github.com/Azure/iothub-manager-java.git","ssh_url":"git@github.com:Azure/iothub-manager-java.git","clone_url":"https://github.com/Azure/iothub-manager-java.git","svn_url":"https://github.com/Azure/iothub-manager-java","homepage":"","size":1365,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":7,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"0fe6a4a165ece4d2e5aeed3077d8eddb30374a5a","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":88778324,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3ODMyNA==","name":"iothub-manager-java","full_name":"Azure/iothub-manager-java","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/iothub-manager-java","description":"Azure IoT PCS microservice for IoT Hub management","fork":false,"url":"https://api.github.com/repos/Azure/iothub-manager-java","forks_url":"https://api.github.com/repos/Azure/iothub-manager-java/forks","keys_url":"https://api.github.com/repos/Azure/iothub-manager-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iothub-manager-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iothub-manager-java/teams","hooks_url":"https://api.github.com/repos/Azure/iothub-manager-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iothub-manager-java/events","assignees_url":"https://api.github.com/repos/Azure/iothub-manager-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iothub-manager-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iothub-manager-java/tags","blobs_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iothub-manager-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iothub-manager-java/languages","stargazers_url":"https://api.github.com/repos/Azure/iothub-manager-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/iothub-manager-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/iothub-manager-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/iothub-manager-java/subscription","commits_url":"https://api.github.com/repos/Azure/iothub-manager-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iothub-manager-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iothub-manager-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iothub-manager-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iothub-manager-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iothub-manager-java/merges","archive_url":"https://api.github.com/repos/Azure/iothub-manager-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iothub-manager-java/downloads","issues_url":"https://api.github.com/repos/Azure/iothub-manager-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iothub-manager-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iothub-manager-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iothub-manager-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iothub-manager-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iothub-manager-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iothub-manager-java/deployments","created_at":"2017-04-19T18:36:26Z","updated_at":"2018-05-30T13:57:02Z","pushed_at":"2018-06-05T18:52:44Z","git_url":"git://github.com/Azure/iothub-manager-java.git","ssh_url":"git@github.com:Azure/iothub-manager-java.git","clone_url":"https://github.com/Azure/iothub-manager-java.git","svn_url":"https://github.com/Azure/iothub-manager-java","homepage":"","size":1365,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94"},"html":{"href":"https://github.com/Azure/iothub-manager-java/pull/94"},"issue":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/issues/94"},"comments":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/iothub-manager-java/statuses/725a40e6e17fbb7d2b283e90569a991b738d2b47"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dluc","id":371009,"node_id":"MDQ6VXNlcjM3MTAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/371009?v=4","gravatar_id":"","url":"https://api.github.com/users/dluc","html_url":"https://github.com/dluc","followers_url":"https://api.github.com/users/dluc/followers","following_url":"https://api.github.com/users/dluc/following{/other_user}","gists_url":"https://api.github.com/users/dluc/gists{/gist_id}","starred_url":"https://api.github.com/users/dluc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dluc/subscriptions","organizations_url":"https://api.github.com/users/dluc/orgs","repos_url":"https://api.github.com/users/dluc/repos","events_url":"https://api.github.com/users/dluc/events{/privacy}","received_events_url":"https://api.github.com/users/dluc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"dluc"}}