{"action":"created","comment":{"url":"https://api.github.com/repos/sithmel/iter-tools/pulls/comments/191052709","pull_request_review_id":123560633,"id":191052709,"diff_hunk":"@@ -1,11 +1,27 @@\n {\n-  \"plugins\": [\n-    \"transform-runtime\",\n-    \"transform-async-generator-functions\"\n-  ],\n-  \"presets\": [\n-    [\"env\", {\n-      \"loose\": true\n-    }]\n-  ]\n+  \"env\": {\n+    \"es5\": {\n+      \"plugins\": [\n+        \"add-module-exports\",\n+        \"transform-runtime\",\n+        \"transform-async-generator-functions\"\n+      ],\n+      \"presets\": [\n+        [\"env\", {\n+          \"loose\": true\n+        }]\n+      ]\n+    },\n+    \"es6\": {\n+      \"plugins\": []","path":".babelrc","position":25,"original_position":25,"commit_id":"d51cb14edec3ed4839ee3570443e049b1cbbf808","original_commit_id":"d51cb14edec3ed4839ee3570443e049b1cbbf808","user":{"login":"conartist6","id":540777,"avatar_url":"https://avatars1.githubusercontent.com/u/540777?v=4","gravatar_id":"","url":"https://api.github.com/users/conartist6","html_url":"https://github.com/conartist6","followers_url":"https://api.github.com/users/conartist6/followers","following_url":"https://api.github.com/users/conartist6/following{/other_user}","gists_url":"https://api.github.com/users/conartist6/gists{/gist_id}","starred_url":"https://api.github.com/users/conartist6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conartist6/subscriptions","organizations_url":"https://api.github.com/users/conartist6/orgs","repos_url":"https://api.github.com/users/conartist6/repos","events_url":"https://api.github.com/users/conartist6/events{/privacy}","received_events_url":"https://api.github.com/users/conartist6/received_events","type":"User","site_admin":false},"body":"Actually I think this is wrong. The library shouldn't try to be full native yet because async generators are nonstandard. It needs syntax-async-generators and transform-async-generator-functions here. Then the async generators will just get transpiled down to separate generators and asyncs (vs all the way to es5).\r\n\r\nI guess in the past because it was encouraged not to import the whole library from index there was less of an issue with environments which don't support async generator syntax. That suggests to me that an alternative to transpiling might be to split out a separate async index which is not included in the normal index. Actually, I think that's sensible anyway.","created_at":"2018-05-26T16:07:11Z","updated_at":"2018-05-26T16:54:13Z","html_url":"https://github.com/sithmel/iter-tools/pull/8#discussion_r191052709","pull_request_url":"https://api.github.com/repos/sithmel/iter-tools/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/comments/191052709"},"html":{"href":"https://github.com/sithmel/iter-tools/pull/8#discussion_r191052709"},"pull_request":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/sithmel/iter-tools/pulls/8","id":190709224,"html_url":"https://github.com/sithmel/iter-tools/pull/8","diff_url":"https://github.com/sithmel/iter-tools/pull/8.diff","patch_url":"https://github.com/sithmel/iter-tools/pull/8.patch","issue_url":"https://api.github.com/repos/sithmel/iter-tools/issues/8","number":8,"state":"open","locked":false,"title":"Rework everything to support es6 modules as build target","user":{"login":"conartist6","id":540777,"avatar_url":"https://avatars1.githubusercontent.com/u/540777?v=4","gravatar_id":"","url":"https://api.github.com/users/conartist6","html_url":"https://github.com/conartist6","followers_url":"https://api.github.com/users/conartist6/followers","following_url":"https://api.github.com/users/conartist6/following{/other_user}","gists_url":"https://api.github.com/users/conartist6/gists{/gist_id}","starred_url":"https://api.github.com/users/conartist6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conartist6/subscriptions","organizations_url":"https://api.github.com/users/conartist6/orgs","repos_url":"https://api.github.com/users/conartist6/repos","events_url":"https://api.github.com/users/conartist6/events{/privacy}","received_events_url":"https://api.github.com/users/conartist6/received_events","type":"User","site_admin":false},"body":"The goal of this changeset is to allow simpler and more modern inclusion patterns.\r\n\r\nI have flattened the output so that you now do require('iter-tools/filter') in, say, node. This and other changes are almost certainly breaking so I have bumped the major version number.\r\n\r\nIt should now be possible to do import {filter, map} from 'iter-tools';\r\nand let your packager take care of tree shaking away the rest of the lib.\r\n\r\nI have removed npm-release, as it seems that the npm version command is meant to fulfill\r\nall the same major functions.","created_at":"2018-05-25T22:55:04Z","updated_at":"2018-05-26T16:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a9218aa535b62203d5c10752bcfad0bab7d3fc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sithmel/iter-tools/pulls/8/commits","review_comments_url":"https://api.github.com/repos/sithmel/iter-tools/pulls/8/comments","review_comment_url":"https://api.github.com/repos/sithmel/iter-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sithmel/iter-tools/issues/8/comments","statuses_url":"https://api.github.com/repos/sithmel/iter-tools/statuses/d51cb14edec3ed4839ee3570443e049b1cbbf808","head":{"label":"conartist6:master","ref":"master","sha":"d51cb14edec3ed4839ee3570443e049b1cbbf808","user":{"login":"conartist6","id":540777,"avatar_url":"https://avatars1.githubusercontent.com/u/540777?v=4","gravatar_id":"","url":"https://api.github.com/users/conartist6","html_url":"https://github.com/conartist6","followers_url":"https://api.github.com/users/conartist6/followers","following_url":"https://api.github.com/users/conartist6/following{/other_user}","gists_url":"https://api.github.com/users/conartist6/gists{/gist_id}","starred_url":"https://api.github.com/users/conartist6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conartist6/subscriptions","organizations_url":"https://api.github.com/users/conartist6/orgs","repos_url":"https://api.github.com/users/conartist6/repos","events_url":"https://api.github.com/users/conartist6/events{/privacy}","received_events_url":"https://api.github.com/users/conartist6/received_events","type":"User","site_admin":false},"repo":{"id":134873835,"name":"iter-tools","full_name":"conartist6/iter-tools","owner":{"login":"conartist6","id":540777,"avatar_url":"https://avatars1.githubusercontent.com/u/540777?v=4","gravatar_id":"","url":"https://api.github.com/users/conartist6","html_url":"https://github.com/conartist6","followers_url":"https://api.github.com/users/conartist6/followers","following_url":"https://api.github.com/users/conartist6/following{/other_user}","gists_url":"https://api.github.com/users/conartist6/gists{/gist_id}","starred_url":"https://api.github.com/users/conartist6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conartist6/subscriptions","organizations_url":"https://api.github.com/users/conartist6/orgs","repos_url":"https://api.github.com/users/conartist6/repos","events_url":"https://api.github.com/users/conartist6/events{/privacy}","received_events_url":"https://api.github.com/users/conartist6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/conartist6/iter-tools","description":"The iterator toolbox","fork":true,"url":"https://api.github.com/repos/conartist6/iter-tools","forks_url":"https://api.github.com/repos/conartist6/iter-tools/forks","keys_url":"https://api.github.com/repos/conartist6/iter-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conartist6/iter-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conartist6/iter-tools/teams","hooks_url":"https://api.github.com/repos/conartist6/iter-tools/hooks","issue_events_url":"https://api.github.com/repos/conartist6/iter-tools/issues/events{/number}","events_url":"https://api.github.com/repos/conartist6/iter-tools/events","assignees_url":"https://api.github.com/repos/conartist6/iter-tools/assignees{/user}","branches_url":"https://api.github.com/repos/conartist6/iter-tools/branches{/branch}","tags_url":"https://api.github.com/repos/conartist6/iter-tools/tags","blobs_url":"https://api.github.com/repos/conartist6/iter-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conartist6/iter-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conartist6/iter-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/conartist6/iter-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conartist6/iter-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/conartist6/iter-tools/languages","stargazers_url":"https://api.github.com/repos/conartist6/iter-tools/stargazers","contributors_url":"https://api.github.com/repos/conartist6/iter-tools/contributors","subscribers_url":"https://api.github.com/repos/conartist6/iter-tools/subscribers","subscription_url":"https://api.github.com/repos/conartist6/iter-tools/subscription","commits_url":"https://api.github.com/repos/conartist6/iter-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/conartist6/iter-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/conartist6/iter-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/conartist6/iter-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/conartist6/iter-tools/contents/{+path}","compare_url":"https://api.github.com/repos/conartist6/iter-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conartist6/iter-tools/merges","archive_url":"https://api.github.com/repos/conartist6/iter-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conartist6/iter-tools/downloads","issues_url":"https://api.github.com/repos/conartist6/iter-tools/issues{/number}","pulls_url":"https://api.github.com/repos/conartist6/iter-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/conartist6/iter-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/conartist6/iter-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conartist6/iter-tools/labels{/name}","releases_url":"https://api.github.com/repos/conartist6/iter-tools/releases{/id}","deployments_url":"https://api.github.com/repos/conartist6/iter-tools/deployments","created_at":"2018-05-25T15:27:10Z","updated_at":"2018-05-25T22:52:44Z","pushed_at":"2018-05-25T22:52:42Z","git_url":"git://github.com/conartist6/iter-tools.git","ssh_url":"git@github.com:conartist6/iter-tools.git","clone_url":"https://github.com/conartist6/iter-tools.git","svn_url":"https://github.com/conartist6/iter-tools","homepage":null,"size":361,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sithmel:master","ref":"master","sha":"d1a1ce19a543fed4ff8fca56b5eaf45e26c43cb8","user":{"login":"sithmel","id":460811,"avatar_url":"https://avatars1.githubusercontent.com/u/460811?v=4","gravatar_id":"","url":"https://api.github.com/users/sithmel","html_url":"https://github.com/sithmel","followers_url":"https://api.github.com/users/sithmel/followers","following_url":"https://api.github.com/users/sithmel/following{/other_user}","gists_url":"https://api.github.com/users/sithmel/gists{/gist_id}","starred_url":"https://api.github.com/users/sithmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sithmel/subscriptions","organizations_url":"https://api.github.com/users/sithmel/orgs","repos_url":"https://api.github.com/users/sithmel/repos","events_url":"https://api.github.com/users/sithmel/events{/privacy}","received_events_url":"https://api.github.com/users/sithmel/received_events","type":"User","site_admin":false},"repo":{"id":69821712,"name":"iter-tools","full_name":"sithmel/iter-tools","owner":{"login":"sithmel","id":460811,"avatar_url":"https://avatars1.githubusercontent.com/u/460811?v=4","gravatar_id":"","url":"https://api.github.com/users/sithmel","html_url":"https://github.com/sithmel","followers_url":"https://api.github.com/users/sithmel/followers","following_url":"https://api.github.com/users/sithmel/following{/other_user}","gists_url":"https://api.github.com/users/sithmel/gists{/gist_id}","starred_url":"https://api.github.com/users/sithmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sithmel/subscriptions","organizations_url":"https://api.github.com/users/sithmel/orgs","repos_url":"https://api.github.com/users/sithmel/repos","events_url":"https://api.github.com/users/sithmel/events{/privacy}","received_events_url":"https://api.github.com/users/sithmel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sithmel/iter-tools","description":"The iterator toolbox","fork":false,"url":"https://api.github.com/repos/sithmel/iter-tools","forks_url":"https://api.github.com/repos/sithmel/iter-tools/forks","keys_url":"https://api.github.com/repos/sithmel/iter-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sithmel/iter-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sithmel/iter-tools/teams","hooks_url":"https://api.github.com/repos/sithmel/iter-tools/hooks","issue_events_url":"https://api.github.com/repos/sithmel/iter-tools/issues/events{/number}","events_url":"https://api.github.com/repos/sithmel/iter-tools/events","assignees_url":"https://api.github.com/repos/sithmel/iter-tools/assignees{/user}","branches_url":"https://api.github.com/repos/sithmel/iter-tools/branches{/branch}","tags_url":"https://api.github.com/repos/sithmel/iter-tools/tags","blobs_url":"https://api.github.com/repos/sithmel/iter-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sithmel/iter-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sithmel/iter-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sithmel/iter-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sithmel/iter-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/sithmel/iter-tools/languages","stargazers_url":"https://api.github.com/repos/sithmel/iter-tools/stargazers","contributors_url":"https://api.github.com/repos/sithmel/iter-tools/contributors","subscribers_url":"https://api.github.com/repos/sithmel/iter-tools/subscribers","subscription_url":"https://api.github.com/repos/sithmel/iter-tools/subscription","commits_url":"https://api.github.com/repos/sithmel/iter-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sithmel/iter-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sithmel/iter-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sithmel/iter-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sithmel/iter-tools/contents/{+path}","compare_url":"https://api.github.com/repos/sithmel/iter-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sithmel/iter-tools/merges","archive_url":"https://api.github.com/repos/sithmel/iter-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sithmel/iter-tools/downloads","issues_url":"https://api.github.com/repos/sithmel/iter-tools/issues{/number}","pulls_url":"https://api.github.com/repos/sithmel/iter-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/sithmel/iter-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/sithmel/iter-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sithmel/iter-tools/labels{/name}","releases_url":"https://api.github.com/repos/sithmel/iter-tools/releases{/id}","deployments_url":"https://api.github.com/repos/sithmel/iter-tools/deployments","created_at":"2016-10-02T20:57:40Z","updated_at":"2018-05-24T21:10:22Z","pushed_at":"2018-05-25T22:55:04Z","git_url":"git://github.com/sithmel/iter-tools.git","ssh_url":"git@github.com:sithmel/iter-tools.git","clone_url":"https://github.com/sithmel/iter-tools.git","svn_url":"https://github.com/sithmel/iter-tools","homepage":null,"size":337,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":1,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/8"},"html":{"href":"https://github.com/sithmel/iter-tools/pull/8"},"issue":{"href":"https://api.github.com/repos/sithmel/iter-tools/issues/8"},"comments":{"href":"https://api.github.com/repos/sithmel/iter-tools/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sithmel/iter-tools/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/sithmel/iter-tools/statuses/d51cb14edec3ed4839ee3570443e049b1cbbf808"}},"author_association":"NONE"}}
{"actor":{"display_login":"conartist6"}}