{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/darkskyapp/astro/pulls/10","id":214412337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDEyMzM3","html_url":"https://github.com/darkskyapp/astro/pull/10","diff_url":"https://github.com/darkskyapp/astro/pull/10.diff","patch_url":"https://github.com/darkskyapp/astro/pull/10.patch","issue_url":"https://api.github.com/repos/darkskyapp/astro/issues/10","number":10,"state":"open","locked":false,"title":"Get moon rise and set together","user":{"login":"nonrenewable","id":6455366,"node_id":"MDQ6VXNlcjY0NTUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/6455366?v=4","gravatar_id":"","url":"https://api.github.com/users/nonrenewable","html_url":"https://github.com/nonrenewable","followers_url":"https://api.github.com/users/nonrenewable/followers","following_url":"https://api.github.com/users/nonrenewable/following{/other_user}","gists_url":"https://api.github.com/users/nonrenewable/gists{/gist_id}","starred_url":"https://api.github.com/users/nonrenewable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonrenewable/subscriptions","organizations_url":"https://api.github.com/users/nonrenewable/orgs","repos_url":"https://api.github.com/users/nonrenewable/repos","events_url":"https://api.github.com/users/nonrenewable/events{/privacy}","received_events_url":"https://api.github.com/users/nonrenewable/received_events","type":"User","site_admin":false},"body":"The main thing i just realized was that I could have left the original function standing and just added the new one in, even though it would've looked a lot like the existing function... I still think people will want both moonrise and moonset vs just one or the other but I may be wrong in that assumption!\r\n\r\n@ironwallaby I added a bunch of additional validations from when you looked at this last which I believe are necessary due to not breaking out of the loop sooner (since you pointed out the 24h check bit 🙂 )","created_at":"2018-09-10T19:03:36Z","updated_at":"2018-09-10T19:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/darkskyapp/astro/pulls/10/commits","review_comments_url":"https://api.github.com/repos/darkskyapp/astro/pulls/10/comments","review_comment_url":"https://api.github.com/repos/darkskyapp/astro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darkskyapp/astro/issues/10/comments","statuses_url":"https://api.github.com/repos/darkskyapp/astro/statuses/f1b19bb7a27448ef67a6aec779815d3d29514fde","head":{"label":"darkskyapp:ats/get_moon_rise_and_set_together","ref":"ats/get_moon_rise_and_set_together","sha":"f1b19bb7a27448ef67a6aec779815d3d29514fde","user":{"login":"darkskyapp","id":2413857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTM4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2413857?v=4","gravatar_id":"","url":"https://api.github.com/users/darkskyapp","html_url":"https://github.com/darkskyapp","followers_url":"https://api.github.com/users/darkskyapp/followers","following_url":"https://api.github.com/users/darkskyapp/following{/other_user}","gists_url":"https://api.github.com/users/darkskyapp/gists{/gist_id}","starred_url":"https://api.github.com/users/darkskyapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkskyapp/subscriptions","organizations_url":"https://api.github.com/users/darkskyapp/orgs","repos_url":"https://api.github.com/users/darkskyapp/repos","events_url":"https://api.github.com/users/darkskyapp/events{/privacy}","received_events_url":"https://api.github.com/users/darkskyapp/received_events","type":"Organization","site_admin":false},"repo":{"id":65298421,"node_id":"MDEwOlJlcG9zaXRvcnk2NTI5ODQyMQ==","name":"astro","full_name":"darkskyapp/astro","owner":{"login":"darkskyapp","id":2413857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTM4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2413857?v=4","gravatar_id":"","url":"https://api.github.com/users/darkskyapp","html_url":"https://github.com/darkskyapp","followers_url":"https://api.github.com/users/darkskyapp/followers","following_url":"https://api.github.com/users/darkskyapp/following{/other_user}","gists_url":"https://api.github.com/users/darkskyapp/gists{/gist_id}","starred_url":"https://api.github.com/users/darkskyapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkskyapp/subscriptions","organizations_url":"https://api.github.com/users/darkskyapp/orgs","repos_url":"https://api.github.com/users/darkskyapp/repos","events_url":"https://api.github.com/users/darkskyapp/events{/privacy}","received_events_url":"https://api.github.com/users/darkskyapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darkskyapp/astro","description":null,"fork":false,"url":"https://api.github.com/repos/darkskyapp/astro","forks_url":"https://api.github.com/repos/darkskyapp/astro/forks","keys_url":"https://api.github.com/repos/darkskyapp/astro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkskyapp/astro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkskyapp/astro/teams","hooks_url":"https://api.github.com/repos/darkskyapp/astro/hooks","issue_events_url":"https://api.github.com/repos/darkskyapp/astro/issues/events{/number}","events_url":"https://api.github.com/repos/darkskyapp/astro/events","assignees_url":"https://api.github.com/repos/darkskyapp/astro/assignees{/user}","branches_url":"https://api.github.com/repos/darkskyapp/astro/branches{/branch}","tags_url":"https://api.github.com/repos/darkskyapp/astro/tags","blobs_url":"https://api.github.com/repos/darkskyapp/astro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkskyapp/astro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkskyapp/astro/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkskyapp/astro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkskyapp/astro/statuses/{sha}","languages_url":"https://api.github.com/repos/darkskyapp/astro/languages","stargazers_url":"https://api.github.com/repos/darkskyapp/astro/stargazers","contributors_url":"https://api.github.com/repos/darkskyapp/astro/contributors","subscribers_url":"https://api.github.com/repos/darkskyapp/astro/subscribers","subscription_url":"https://api.github.com/repos/darkskyapp/astro/subscription","commits_url":"https://api.github.com/repos/darkskyapp/astro/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkskyapp/astro/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkskyapp/astro/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkskyapp/astro/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkskyapp/astro/contents/{+path}","compare_url":"https://api.github.com/repos/darkskyapp/astro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkskyapp/astro/merges","archive_url":"https://api.github.com/repos/darkskyapp/astro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkskyapp/astro/downloads","issues_url":"https://api.github.com/repos/darkskyapp/astro/issues{/number}","pulls_url":"https://api.github.com/repos/darkskyapp/astro/pulls{/number}","milestones_url":"https://api.github.com/repos/darkskyapp/astro/milestones{/number}","notifications_url":"https://api.github.com/repos/darkskyapp/astro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkskyapp/astro/labels{/name}","releases_url":"https://api.github.com/repos/darkskyapp/astro/releases{/id}","deployments_url":"https://api.github.com/repos/darkskyapp/astro/deployments","created_at":"2016-08-09T13:45:49Z","updated_at":"2018-09-08T23:03:30Z","pushed_at":"2018-09-10T18:59:24Z","git_url":"git://github.com/darkskyapp/astro.git","ssh_url":"git@github.com:darkskyapp/astro.git","clone_url":"https://github.com/darkskyapp/astro.git","svn_url":"https://github.com/darkskyapp/astro","homepage":null,"size":9,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"darkskyapp:master","ref":"master","sha":"eac407e06a93c39e8092d7b9030bc6c599ed5188","user":{"login":"darkskyapp","id":2413857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTM4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2413857?v=4","gravatar_id":"","url":"https://api.github.com/users/darkskyapp","html_url":"https://github.com/darkskyapp","followers_url":"https://api.github.com/users/darkskyapp/followers","following_url":"https://api.github.com/users/darkskyapp/following{/other_user}","gists_url":"https://api.github.com/users/darkskyapp/gists{/gist_id}","starred_url":"https://api.github.com/users/darkskyapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkskyapp/subscriptions","organizations_url":"https://api.github.com/users/darkskyapp/orgs","repos_url":"https://api.github.com/users/darkskyapp/repos","events_url":"https://api.github.com/users/darkskyapp/events{/privacy}","received_events_url":"https://api.github.com/users/darkskyapp/received_events","type":"Organization","site_admin":false},"repo":{"id":65298421,"node_id":"MDEwOlJlcG9zaXRvcnk2NTI5ODQyMQ==","name":"astro","full_name":"darkskyapp/astro","owner":{"login":"darkskyapp","id":2413857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTM4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2413857?v=4","gravatar_id":"","url":"https://api.github.com/users/darkskyapp","html_url":"https://github.com/darkskyapp","followers_url":"https://api.github.com/users/darkskyapp/followers","following_url":"https://api.github.com/users/darkskyapp/following{/other_user}","gists_url":"https://api.github.com/users/darkskyapp/gists{/gist_id}","starred_url":"https://api.github.com/users/darkskyapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkskyapp/subscriptions","organizations_url":"https://api.github.com/users/darkskyapp/orgs","repos_url":"https://api.github.com/users/darkskyapp/repos","events_url":"https://api.github.com/users/darkskyapp/events{/privacy}","received_events_url":"https://api.github.com/users/darkskyapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darkskyapp/astro","description":null,"fork":false,"url":"https://api.github.com/repos/darkskyapp/astro","forks_url":"https://api.github.com/repos/darkskyapp/astro/forks","keys_url":"https://api.github.com/repos/darkskyapp/astro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkskyapp/astro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkskyapp/astro/teams","hooks_url":"https://api.github.com/repos/darkskyapp/astro/hooks","issue_events_url":"https://api.github.com/repos/darkskyapp/astro/issues/events{/number}","events_url":"https://api.github.com/repos/darkskyapp/astro/events","assignees_url":"https://api.github.com/repos/darkskyapp/astro/assignees{/user}","branches_url":"https://api.github.com/repos/darkskyapp/astro/branches{/branch}","tags_url":"https://api.github.com/repos/darkskyapp/astro/tags","blobs_url":"https://api.github.com/repos/darkskyapp/astro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkskyapp/astro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkskyapp/astro/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkskyapp/astro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkskyapp/astro/statuses/{sha}","languages_url":"https://api.github.com/repos/darkskyapp/astro/languages","stargazers_url":"https://api.github.com/repos/darkskyapp/astro/stargazers","contributors_url":"https://api.github.com/repos/darkskyapp/astro/contributors","subscribers_url":"https://api.github.com/repos/darkskyapp/astro/subscribers","subscription_url":"https://api.github.com/repos/darkskyapp/astro/subscription","commits_url":"https://api.github.com/repos/darkskyapp/astro/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkskyapp/astro/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkskyapp/astro/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkskyapp/astro/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkskyapp/astro/contents/{+path}","compare_url":"https://api.github.com/repos/darkskyapp/astro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkskyapp/astro/merges","archive_url":"https://api.github.com/repos/darkskyapp/astro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkskyapp/astro/downloads","issues_url":"https://api.github.com/repos/darkskyapp/astro/issues{/number}","pulls_url":"https://api.github.com/repos/darkskyapp/astro/pulls{/number}","milestones_url":"https://api.github.com/repos/darkskyapp/astro/milestones{/number}","notifications_url":"https://api.github.com/repos/darkskyapp/astro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkskyapp/astro/labels{/name}","releases_url":"https://api.github.com/repos/darkskyapp/astro/releases{/id}","deployments_url":"https://api.github.com/repos/darkskyapp/astro/deployments","created_at":"2016-08-09T13:45:49Z","updated_at":"2018-09-08T23:03:30Z","pushed_at":"2018-09-10T18:59:24Z","git_url":"git://github.com/darkskyapp/astro.git","ssh_url":"git@github.com:darkskyapp/astro.git","clone_url":"https://github.com/darkskyapp/astro.git","svn_url":"https://github.com/darkskyapp/astro","homepage":null,"size":9,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darkskyapp/astro/pulls/10"},"html":{"href":"https://github.com/darkskyapp/astro/pull/10"},"issue":{"href":"https://api.github.com/repos/darkskyapp/astro/issues/10"},"comments":{"href":"https://api.github.com/repos/darkskyapp/astro/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/darkskyapp/astro/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/darkskyapp/astro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darkskyapp/astro/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/darkskyapp/astro/statuses/f1b19bb7a27448ef67a6aec779815d3d29514fde"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":35,"deletions":20,"changed_files":1}}
{"actor":{"display_login":"nonrenewable"}}