{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments/241916291","pull_request_review_id":185316862,"id":241916291,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkxNjI5MQ==","diff_hunk":"@@ -589,7 +589,7 @@ static int s_increment_read_window(struct aws_channel_handler *handler, struct a\n         aws_channel_slot_increment_read_window(slot, window_update_size);\n     }\n \n-    if (secure_transport_handler->negotiation_finished) {\n+    if (secure_transport_handler->negotiation_finished && secure_transport_handler->read_task.node.next) {","path":"source/darwin/secure_transport_tls_channel_handler.c","position":5,"original_position":5,"commit_id":"5731566fe95396bc2b3b244a23f3527f3c8bdc5b","original_commit_id":"5731566fe95396bc2b3b244a23f3527f3c8bdc5b","user":{"login":"JonathanHenson","id":3926469,"node_id":"MDQ6VXNlcjM5MjY0Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/3926469?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanHenson","html_url":"https://github.com/JonathanHenson","followers_url":"https://api.github.com/users/JonathanHenson/followers","following_url":"https://api.github.com/users/JonathanHenson/following{/other_user}","gists_url":"https://api.github.com/users/JonathanHenson/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanHenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanHenson/subscriptions","organizations_url":"https://api.github.com/users/JonathanHenson/orgs","repos_url":"https://api.github.com/users/JonathanHenson/repos","events_url":"https://api.github.com/users/JonathanHenson/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanHenson/received_events","type":"User","site_admin":false},"body":"Are you certain you didn't mean this?\r\n\r\n! secure_transport_handler->read_task.node.next\r\n\r\n","created_at":"2018-12-14T23:05:29Z","updated_at":"2018-12-14T23:05:34Z","html_url":"https://github.com/awslabs/aws-c-io/pull/71#discussion_r241916291","pull_request_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments/241916291"},"html":{"href":"https://github.com/awslabs/aws-c-io/pull/71#discussion_r241916291"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71","id":238860704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODYwNzA0","html_url":"https://github.com/awslabs/aws-c-io/pull/71","diff_url":"https://github.com/awslabs/aws-c-io/pull/71.diff","patch_url":"https://github.com/awslabs/aws-c-io/pull/71.patch","issue_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/71","number":71,"state":"open","locked":false,"title":"Oops we did it again","user":{"login":"ColdenCullen","id":1354824,"node_id":"MDQ6VXNlcjEzNTQ4MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1354824?v=4","gravatar_id":"","url":"https://api.github.com/users/ColdenCullen","html_url":"https://github.com/ColdenCullen","followers_url":"https://api.github.com/users/ColdenCullen/followers","following_url":"https://api.github.com/users/ColdenCullen/following{/other_user}","gists_url":"https://api.github.com/users/ColdenCullen/gists{/gist_id}","starred_url":"https://api.github.com/users/ColdenCullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColdenCullen/subscriptions","organizations_url":"https://api.github.com/users/ColdenCullen/orgs","repos_url":"https://api.github.com/users/ColdenCullen/repos","events_url":"https://api.github.com/users/ColdenCullen/events{/privacy}","received_events_url":"https://api.github.com/users/ColdenCullen/received_events","type":"User","site_admin":false},"body":"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-12-14T22:34:30Z","updated_at":"2018-12-14T23:05:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18ce78b1db49700011414cd959b12360c1864326","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinboswell","id":3382222,"node_id":"MDQ6VXNlcjMzODIyMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3382222?v=4","gravatar_id":"","url":"https://api.github.com/users/justinboswell","html_url":"https://github.com/justinboswell","followers_url":"https://api.github.com/users/justinboswell/followers","following_url":"https://api.github.com/users/justinboswell/following{/other_user}","gists_url":"https://api.github.com/users/justinboswell/gists{/gist_id}","starred_url":"https://api.github.com/users/justinboswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinboswell/subscriptions","organizations_url":"https://api.github.com/users/justinboswell/orgs","repos_url":"https://api.github.com/users/justinboswell/repos","events_url":"https://api.github.com/users/justinboswell/events{/privacy}","received_events_url":"https://api.github.com/users/justinboswell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/71/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/5731566fe95396bc2b3b244a23f3527f3c8bdc5b","head":{"label":"awslabs:its-brittany","ref":"its-brittany","sha":"5731566fe95396bc2b3b244a23f3527f3c8bdc5b","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123649788,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2NDk3ODg=","name":"aws-c-io","full_name":"awslabs/aws-c-io","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-c-io","description":"This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols. ","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-io","forks_url":"https://api.github.com/repos/awslabs/aws-c-io/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-io/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-io/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-io/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-io/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-io/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-io/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-io/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-io/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-io/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-io/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-io/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-io/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-io/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-io/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-io/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-io/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-io/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-io/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-io/deployments","created_at":"2018-03-03T01:50:50Z","updated_at":"2018-12-14T20:04:36Z","pushed_at":"2018-12-14T22:34:31Z","git_url":"git://github.com/awslabs/aws-c-io.git","ssh_url":"git@github.com:awslabs/aws-c-io.git","clone_url":"https://github.com/awslabs/aws-c-io.git","svn_url":"https://github.com/awslabs/aws-c-io","homepage":null,"size":1975,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"12d882db8b5cabf3b4887006e12efe0704f2c68b","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123649788,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2NDk3ODg=","name":"aws-c-io","full_name":"awslabs/aws-c-io","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-c-io","description":"This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols. ","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-io","forks_url":"https://api.github.com/repos/awslabs/aws-c-io/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-io/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-io/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-io/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-io/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-io/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-io/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-io/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-io/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-io/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-io/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-io/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-io/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-io/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-io/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-io/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-io/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-io/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-io/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-io/deployments","created_at":"2018-03-03T01:50:50Z","updated_at":"2018-12-14T20:04:36Z","pushed_at":"2018-12-14T22:34:31Z","git_url":"git://github.com/awslabs/aws-c-io.git","ssh_url":"git@github.com:awslabs/aws-c-io.git","clone_url":"https://github.com/awslabs/aws-c-io.git","svn_url":"https://github.com/awslabs/aws-c-io","homepage":null,"size":1975,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71"},"html":{"href":"https://github.com/awslabs/aws-c-io/pull/71"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-c-io/issues/71"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-c-io/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-c-io/statuses/5731566fe95396bc2b3b244a23f3527f3c8bdc5b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JonathanHenson"}}