{"action":"created","issue":{"url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/1301","repository_url":"https://api.github.com/repos/sweetalert2/sweetalert2","labels_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/1301/labels{/name}","comments_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/1301/comments","events_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/1301/events","html_url":"https://github.com/sweetalert2/sweetalert2/issues/1301","id":382979808,"node_id":"MDU6SXNzdWUzODI5Nzk4MDg=","number":1301,"title":"Get rid of the `event-stream` devDependency","user":{"login":"limonte","id":6059356,"node_id":"MDQ6VXNlcjYwNTkzNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6059356?v=4","gravatar_id":"","url":"https://api.github.com/users/limonte","html_url":"https://github.com/limonte","followers_url":"https://api.github.com/users/limonte/followers","following_url":"https://api.github.com/users/limonte/following{/other_user}","gists_url":"https://api.github.com/users/limonte/gists{/gist_id}","starred_url":"https://api.github.com/users/limonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limonte/subscriptions","organizations_url":"https://api.github.com/users/limonte/orgs","repos_url":"https://api.github.com/users/limonte/repos","events_url":"https://api.github.com/users/limonte/events{/privacy}","received_events_url":"https://api.github.com/users/limonte/received_events","type":"User","site_admin":false},"labels":[{"id":588866924,"node_id":"MDU6TGFiZWw1ODg4NjY5MjQ=","url":"https://api.github.com/repos/sweetalert2/sweetalert2/labels/domain:%20devel","name":"domain: devel","color":"cfe3f9","default":false},{"id":853845740,"node_id":"MDU6TGFiZWw4NTM4NDU3NDA=","url":"https://api.github.com/repos/sweetalert2/sweetalert2/labels/type:%20chore","name":"type: chore","color":"f0f0f0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-21T06:50:11Z","updated_at":"2018-11-21T22:02:34Z","closed_at":null,"author_association":"MEMBER","body":"Reasons:\r\n\r\n- it's poorly maintained: https://github.com/dominictarr/event-stream/issues/113#issuecomment-423739893\r\n- ⚠️ it's some kind of injection attack: https://github.com/dominictarr/event-stream/issues/116 \r\n\r\nWe're currently using it in one place, `utils/execute.js`: https://github.com/sweetalert2/sweetalert2/blob/13662349768bfdd98cfb91000e55bf2c3cfc3bb9/utils/execute.js#L2"},"comment":{"url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/comments/440824443","html_url":"https://github.com/sweetalert2/sweetalert2/issues/1301#issuecomment-440824443","issue_url":"https://api.github.com/repos/sweetalert2/sweetalert2/issues/1301","id":440824443,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDgyNDQ0Mw==","user":{"login":"zenflow","id":3198597,"node_id":"MDQ6VXNlcjMxOTg1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3198597?v=4","gravatar_id":"","url":"https://api.github.com/users/zenflow","html_url":"https://github.com/zenflow","followers_url":"https://api.github.com/users/zenflow/followers","following_url":"https://api.github.com/users/zenflow/following{/other_user}","gists_url":"https://api.github.com/users/zenflow/gists{/gist_id}","starred_url":"https://api.github.com/users/zenflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenflow/subscriptions","organizations_url":"https://api.github.com/users/zenflow/orgs","repos_url":"https://api.github.com/users/zenflow/repos","events_url":"https://api.github.com/users/zenflow/events{/privacy}","received_events_url":"https://api.github.com/users/zenflow/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T22:02:34Z","updated_at":"2018-11-21T22:02:34Z","author_association":"COLLABORATOR","body":"Looks like the only one of the 3 functions event-stream implements itself (not just exporting an external dependency as-is) is `es.merge()`. For that I think the `merge2` package, which we're already using, should work."}}
{"actor":{"display_login":"zenflow"}}