{"action":"created","comment":{"url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments/169228314","pull_request_review_id":97714634,"id":169228314,"diff_hunk":"@@ -0,0 +1,149 @@\n+// This file was generated by gir (https://github.com/gtk-rs/gir @ 47eb915)\n+// from gir-files (https://github.com/gtk-rs/gir-files @ ???)\n+// DO NOT EDIT\n+\n+use DiscovererInfo;\n+use Error;\n+use ffi;\n+use glib;\n+use glib::object::Downcast;\n+use glib::object::IsA;\n+use glib::signal::SignalHandlerId;\n+use glib::signal::connect;\n+use glib::translate::*;\n+use glib_ffi;\n+use gobject_ffi;\n+use gst;\n+use gst_ffi;\n+use std::boxed::Box as Box_;\n+use std::mem;\n+use std::mem::transmute;\n+use std::ptr;\n+\n+glib_wrapper! {\n+    pub struct Discoverer(Object<ffi::GstDiscoverer, ffi::GstDiscovererClass>);\n+\n+    match fn {\n+        get_type => || ffi::gst_discoverer_get_type(),\n+    }\n+}\n+\n+impl Discoverer {\n+    pub fn new(timeout: gst::ClockTime) -> Result<Discoverer, Error> {\n+        assert_initialized_main_thread!();\n+        unsafe {\n+            let mut error = ptr::null_mut();\n+            let ret = ffi::gst_discoverer_new(timeout.to_glib(), &mut error);\n+            if error.is_null() { Ok(from_glib_full(ret)) } else { Err(from_glib_full(error)) }\n+        }\n+    }\n+}\n+\n+unsafe impl Send for Discoverer {}\n+unsafe impl Sync for Discoverer {}\n+\n+pub trait DiscovererExt {","path":"gstreamer-pbutils/src/auto/discoverer.rs","position":45,"original_position":45,"commit_id":"c8193b974f9302c9348963e63a3a2019306fe1c1","original_commit_id":"c8193b974f9302c9348963e63a3a2019306fe1c1","user":{"login":"sdroege","id":301846,"avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"body":"I believe we don't need the trait here","created_at":"2018-02-20T06:42:54Z","updated_at":"2018-02-20T06:46:28Z","html_url":"https://github.com/sdroege/gstreamer-rs/pull/84#discussion_r169228314","pull_request_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments/169228314"},"html":{"href":"https://github.com/sdroege/gstreamer-rs/pull/84#discussion_r169228314"},"pull_request":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84","id":170075165,"html_url":"https://github.com/sdroege/gstreamer-rs/pull/84","diff_url":"https://github.com/sdroege/gstreamer-rs/pull/84.diff","patch_url":"https://github.com/sdroege/gstreamer-rs/pull/84.patch","issue_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/84","number":84,"state":"open","locked":false,"title":"pbutils: add discoverer APIs","user":{"login":"thiagoss","id":394080,"avatar_url":"https://avatars0.githubusercontent.com/u/394080?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagoss","html_url":"https://github.com/thiagoss","followers_url":"https://api.github.com/users/thiagoss/followers","following_url":"https://api.github.com/users/thiagoss/following{/other_user}","gists_url":"https://api.github.com/users/thiagoss/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagoss/subscriptions","organizations_url":"https://api.github.com/users/thiagoss/orgs","repos_url":"https://api.github.com/users/thiagoss/repos","events_url":"https://api.github.com/users/thiagoss/events{/privacy}","received_events_url":"https://api.github.com/users/thiagoss/received_events","type":"User","site_admin":false},"body":"First part of pbutils wrap, containing discoverer.\r\n\r\nDone in pieces to make it easier to do proper review of the APIs.","created_at":"2018-02-20T00:03:17Z","updated_at":"2018-02-20T06:46:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee6622322fd3fb71c9862a15290baa2e63d03de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84/commits","review_comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84/comments","review_comment_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/84/comments","statuses_url":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/c8193b974f9302c9348963e63a3a2019306fe1c1","head":{"label":"thiagoss:discoverer","ref":"discoverer","sha":"c8193b974f9302c9348963e63a3a2019306fe1c1","user":{"login":"thiagoss","id":394080,"avatar_url":"https://avatars0.githubusercontent.com/u/394080?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagoss","html_url":"https://github.com/thiagoss","followers_url":"https://api.github.com/users/thiagoss/followers","following_url":"https://api.github.com/users/thiagoss/following{/other_user}","gists_url":"https://api.github.com/users/thiagoss/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagoss/subscriptions","organizations_url":"https://api.github.com/users/thiagoss/orgs","repos_url":"https://api.github.com/users/thiagoss/repos","events_url":"https://api.github.com/users/thiagoss/events{/privacy}","received_events_url":"https://api.github.com/users/thiagoss/received_events","type":"User","site_admin":false},"repo":{"id":109287531,"name":"gstreamer-rs","full_name":"thiagoss/gstreamer-rs","owner":{"login":"thiagoss","id":394080,"avatar_url":"https://avatars0.githubusercontent.com/u/394080?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagoss","html_url":"https://github.com/thiagoss","followers_url":"https://api.github.com/users/thiagoss/followers","following_url":"https://api.github.com/users/thiagoss/following{/other_user}","gists_url":"https://api.github.com/users/thiagoss/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagoss/subscriptions","organizations_url":"https://api.github.com/users/thiagoss/orgs","repos_url":"https://api.github.com/users/thiagoss/repos","events_url":"https://api.github.com/users/thiagoss/events{/privacy}","received_events_url":"https://api.github.com/users/thiagoss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thiagoss/gstreamer-rs","description":"GStreamer bindings for Rust","fork":true,"url":"https://api.github.com/repos/thiagoss/gstreamer-rs","forks_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/forks","keys_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/teams","hooks_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/hooks","issue_events_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/issues/events{/number}","events_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/events","assignees_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/assignees{/user}","branches_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/branches{/branch}","tags_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/tags","blobs_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/languages","stargazers_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/stargazers","contributors_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/contributors","subscribers_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/subscribers","subscription_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/subscription","commits_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/contents/{+path}","compare_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/merges","archive_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/downloads","issues_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/issues{/number}","pulls_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/labels{/name}","releases_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/releases{/id}","deployments_url":"https://api.github.com/repos/thiagoss/gstreamer-rs/deployments","created_at":"2017-11-02T16:01:04Z","updated_at":"2017-11-02T16:01:06Z","pushed_at":"2018-02-20T00:02:41Z","git_url":"git://github.com/thiagoss/gstreamer-rs.git","ssh_url":"git@github.com:thiagoss/gstreamer-rs.git","clone_url":"https://github.com/thiagoss/gstreamer-rs.git","svn_url":"https://github.com/thiagoss/gstreamer-rs","homepage":"","size":3086,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sdroege:master","ref":"master","sha":"f92f0a99e8c7642b054125d6bd32e6cbb1b81f72","user":{"login":"sdroege","id":301846,"avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"repo":{"id":91088829,"name":"gstreamer-rs","full_name":"sdroege/gstreamer-rs","owner":{"login":"sdroege","id":301846,"avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdroege/gstreamer-rs","description":"GStreamer bindings for Rust","fork":false,"url":"https://api.github.com/repos/sdroege/gstreamer-rs","forks_url":"https://api.github.com/repos/sdroege/gstreamer-rs/forks","keys_url":"https://api.github.com/repos/sdroege/gstreamer-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdroege/gstreamer-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdroege/gstreamer-rs/teams","hooks_url":"https://api.github.com/repos/sdroege/gstreamer-rs/hooks","issue_events_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/events{/number}","events_url":"https://api.github.com/repos/sdroege/gstreamer-rs/events","assignees_url":"https://api.github.com/repos/sdroege/gstreamer-rs/assignees{/user}","branches_url":"https://api.github.com/repos/sdroege/gstreamer-rs/branches{/branch}","tags_url":"https://api.github.com/repos/sdroege/gstreamer-rs/tags","blobs_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/sdroege/gstreamer-rs/languages","stargazers_url":"https://api.github.com/repos/sdroege/gstreamer-rs/stargazers","contributors_url":"https://api.github.com/repos/sdroege/gstreamer-rs/contributors","subscribers_url":"https://api.github.com/repos/sdroege/gstreamer-rs/subscribers","subscription_url":"https://api.github.com/repos/sdroege/gstreamer-rs/subscription","commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdroege/gstreamer-rs/contents/{+path}","compare_url":"https://api.github.com/repos/sdroege/gstreamer-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdroege/gstreamer-rs/merges","archive_url":"https://api.github.com/repos/sdroege/gstreamer-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdroege/gstreamer-rs/downloads","issues_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues{/number}","pulls_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/sdroege/gstreamer-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/sdroege/gstreamer-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdroege/gstreamer-rs/labels{/name}","releases_url":"https://api.github.com/repos/sdroege/gstreamer-rs/releases{/id}","deployments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/deployments","created_at":"2017-05-12T12:22:18Z","updated_at":"2018-02-16T15:46:08Z","pushed_at":"2018-02-20T00:03:18Z","git_url":"git://github.com/sdroege/gstreamer-rs.git","ssh_url":"git@github.com:sdroege/gstreamer-rs.git","clone_url":"https://github.com/sdroege/gstreamer-rs.git","svn_url":"https://github.com/sdroege/gstreamer-rs","homepage":"","size":3091,"stargazers_count":72,"watchers_count":72,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":23,"open_issues":16,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84"},"html":{"href":"https://github.com/sdroege/gstreamer-rs/pull/84"},"issue":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/84"},"comments":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/c8193b974f9302c9348963e63a3a2019306fe1c1"}},"author_association":"NONE"}}
{"actor":{"display_login":"sdroege"}}