{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/183015218","pull_request_review_id":113933158,"id":183015218,"diff_hunk":"@@ -1276,8 +1320,26 @@ func unlock(ctx *cli.Context) error {\n \t}\n \tfmt.Println()\n \n+\targs := ctx.Args()\n+\n+\t// Parse the optional recovery window if it is specified. By default,\n+\t// the recovery window will be 0, indicating no lookahead should be","path":"cmd/lncli/commands.go","position":88,"original_position":88,"commit_id":"732bcff39b7f5fa9692454f1337ab20d5278127b","original_commit_id":"940a8209d3e25873f6fa6e48a02dbc87cc0a56d1","user":{"login":"halseth","id":3765732,"avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false},"body":"some places it says it should be non-zero, here it says it can be zero. What's correct?","created_at":"2018-04-20T10:54:56Z","updated_at":"2018-04-20T10:58:27Z","html_url":"https://github.com/lightningnetwork/lnd/pull/1005#discussion_r183015218","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/183015218"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/1005#discussion_r183015218"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005"}}},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005","id":178964189,"html_url":"https://github.com/lightningnetwork/lnd/pull/1005","diff_url":"https://github.com/lightningnetwork/lnd/pull/1005.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/1005.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1005","number":1005,"state":"open","locked":false,"title":"[WIP] Wallet Recovery","user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"body":"Adds wallet recovery to lnd! These changes enable aezeeds with funds to be restored into a fresh instance, and recover any **on-chain** balance. Most of the rescan logic is implemented in roasbeef/btcwallet#22, this PR involves most of the scaffolding to recovery configuration options into the wallet itself. I've added an integration test to test the recovery procedure using btcd, and I have manually tested bitcoind and neutrino.\r\n\r\nFixes #900 ","created_at":"2018-04-03T00:17:05Z","updated_at":"2018-04-20T10:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b992d919b79d1ffb83b44b69ff94a07f6452508c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":431222343,"url":"https://api.github.com/repos/lightningnetwork/lnd/labels/crypto","name":"crypto","color":"fbca04","default":false},{"id":814687831,"url":"https://api.github.com/repos/lightningnetwork/lnd/labels/recovery","name":"recovery","color":"ffeac4","default":false},{"id":431221659,"url":"https://api.github.com/repos/lightningnetwork/lnd/labels/wallet","name":"wallet","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1005/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/732bcff39b7f5fa9692454f1337ab20d5278127b","head":{"label":"cfromknecht:wallet-recovery","ref":"wallet-recovery","sha":"732bcff39b7f5fa9692454f1337ab20d5278127b","user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"repo":{"id":98245639,"name":"lnd","full_name":"cfromknecht/lnd","owner":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cfromknecht/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/cfromknecht/lnd","forks_url":"https://api.github.com/repos/cfromknecht/lnd/forks","keys_url":"https://api.github.com/repos/cfromknecht/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfromknecht/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfromknecht/lnd/teams","hooks_url":"https://api.github.com/repos/cfromknecht/lnd/hooks","issue_events_url":"https://api.github.com/repos/cfromknecht/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/cfromknecht/lnd/events","assignees_url":"https://api.github.com/repos/cfromknecht/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/cfromknecht/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/cfromknecht/lnd/tags","blobs_url":"https://api.github.com/repos/cfromknecht/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfromknecht/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfromknecht/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfromknecht/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfromknecht/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/cfromknecht/lnd/languages","stargazers_url":"https://api.github.com/repos/cfromknecht/lnd/stargazers","contributors_url":"https://api.github.com/repos/cfromknecht/lnd/contributors","subscribers_url":"https://api.github.com/repos/cfromknecht/lnd/subscribers","subscription_url":"https://api.github.com/repos/cfromknecht/lnd/subscription","commits_url":"https://api.github.com/repos/cfromknecht/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfromknecht/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfromknecht/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfromknecht/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfromknecht/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/cfromknecht/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfromknecht/lnd/merges","archive_url":"https://api.github.com/repos/cfromknecht/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfromknecht/lnd/downloads","issues_url":"https://api.github.com/repos/cfromknecht/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/cfromknecht/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/cfromknecht/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/cfromknecht/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfromknecht/lnd/labels{/name}","releases_url":"https://api.github.com/repos/cfromknecht/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/cfromknecht/lnd/deployments","created_at":"2017-07-25T00:12:12Z","updated_at":"2018-04-04T18:59:03Z","pushed_at":"2018-04-19T03:41:44Z","git_url":"git://github.com/cfromknecht/lnd.git","ssh_url":"git@github.com:cfromknecht/lnd.git","clone_url":"https://github.com/cfromknecht/lnd.git","svn_url":"https://github.com/cfromknecht/lnd","homepage":"","size":14699,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":0,"watchers":25,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"e2229b74e72b45814f16222a1f32e1eaddac898a","user":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"name":"lnd","full_name":"lightningnetwork/lnd","owner":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2018-04-20T08:11:59Z","pushed_at":"2018-04-20T08:02:48Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":13946,"stargazers_count":2465,"watchers_count":2465,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":547,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":547,"open_issues":138,"watchers":2465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/1005"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/1005"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/1005/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1005/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/732bcff39b7f5fa9692454f1337ab20d5278127b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"halseth"}}