{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63","id":150592583,"html_url":"https://github.com/THK-ADV/lwm-reloaded/pull/63","diff_url":"https://github.com/THK-ADV/lwm-reloaded/pull/63.diff","patch_url":"https://github.com/THK-ADV/lwm-reloaded/pull/63.patch","issue_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/63","number":63,"state":"closed","locked":false,"title":"LWM-UW01 Patch 8","user":{"login":"alexdobry","id":2527034,"avatar_url":"https://avatars3.githubusercontent.com/u/2527034?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdobry","html_url":"https://github.com/alexdobry","followers_url":"https://api.github.com/users/alexdobry/followers","following_url":"https://api.github.com/users/alexdobry/following{/other_user}","gists_url":"https://api.github.com/users/alexdobry/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdobry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdobry/subscriptions","organizations_url":"https://api.github.com/users/alexdobry/orgs","repos_url":"https://api.github.com/users/alexdobry/repos","events_url":"https://api.github.com/users/alexdobry/events{/privacy}","received_events_url":"https://api.github.com/users/alexdobry/received_events","type":"User","site_admin":false},"body":"### ACHTUNG\r\n* `ReportCardEntryTypes` haben jetzt ein Protocol, worin die ID nicht enthalten ist\r\n* Permissions haben wir nicht mehr. Demnach gibt es **keinen PermissionController** mehr\r\n* Ist der EntryTypeController noch notwendig, @umuesse? Den alten habe ich nämlich wegoptimiert\r\n* AnnotationController nach Absprache mit @umuesse implementieren\r\n\r\n### Änderungen\r\n* `CountStrategy` beim `GroupService` überarbeitet\r\n* Gruppen <-> ScheduleEntry Bug beseitigt\r\n* Buddy Requests geben jetzt alle `http Ok` zurück\r\n* Blacklists sind ebenfalls durch ihr `Label` Unique \r\n* Json Form der ReportCardEntryTypes schreibt `null` wenn `bool` `none` ist \r\n* Generieren des Staffelplans *\"läuft nicht mehr ins Leere\"*\r\n* Generieren des Staffelplans nimmt eine weiteren Parameter (Bool) entgegen welcher bestimmt, ob der SemesterIndex berücksichtigt werden soll oder nicht. Der Default ist `true`\r\n* Löschen von ReportCardEvaluations auf Basis vom Studenten oder Labwork\r\n* Code zum Migrieren von lwm_store auf psql verwendet ausschließlich valide (nicht gelöschte) Daten. Demnach werden gelöschte Daten ignoriert\r\n* Einheitliches `lastModified` für LabworkApplications\r\n* Voller Stack für `ReportCardRetry`\r\n* `LdapService` ist nun (korrekter weise) ein Singleton\r\n* `LdapSyncService` auf psql umgestellt ~~**(#46 beachten)**~~\r\n* Eigene Logging Konfiguration erstellt **(#73 beachten)**\r\n* Sehr viele Klassen verschoben/gelöscht. Alle unnötigen Tests wegoptimiert ","created_at":"2017-11-03T17:58:30Z","updated_at":"2018-02-07T10:39:43Z","closed_at":"2018-02-07T10:39:43Z","merged_at":"2018-02-07T10:39:43Z","merge_commit_sha":"8d86b66a27a3db722b114e98c301b80b54054daf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63/commits","review_comments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63/comments","review_comment_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/comments{/number}","comments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/63/comments","statuses_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/statuses/0bb85d5c8cc856b524c68bb9c371726d7087765d","head":{"label":"THK-ADV:LWM-UW01","ref":"LWM-UW01","sha":"0bb85d5c8cc856b524c68bb9c371726d7087765d","user":{"login":"THK-ADV","id":8058101,"avatar_url":"https://avatars0.githubusercontent.com/u/8058101?v=4","gravatar_id":"","url":"https://api.github.com/users/THK-ADV","html_url":"https://github.com/THK-ADV","followers_url":"https://api.github.com/users/THK-ADV/followers","following_url":"https://api.github.com/users/THK-ADV/following{/other_user}","gists_url":"https://api.github.com/users/THK-ADV/gists{/gist_id}","starred_url":"https://api.github.com/users/THK-ADV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THK-ADV/subscriptions","organizations_url":"https://api.github.com/users/THK-ADV/orgs","repos_url":"https://api.github.com/users/THK-ADV/repos","events_url":"https://api.github.com/users/THK-ADV/events{/privacy}","received_events_url":"https://api.github.com/users/THK-ADV/received_events","type":"Organization","site_admin":false},"repo":{"id":99559039,"name":"lwm-reloaded","full_name":"THK-ADV/lwm-reloaded","owner":{"login":"THK-ADV","id":8058101,"avatar_url":"https://avatars0.githubusercontent.com/u/8058101?v=4","gravatar_id":"","url":"https://api.github.com/users/THK-ADV","html_url":"https://github.com/THK-ADV","followers_url":"https://api.github.com/users/THK-ADV/followers","following_url":"https://api.github.com/users/THK-ADV/following{/other_user}","gists_url":"https://api.github.com/users/THK-ADV/gists{/gist_id}","starred_url":"https://api.github.com/users/THK-ADV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THK-ADV/subscriptions","organizations_url":"https://api.github.com/users/THK-ADV/orgs","repos_url":"https://api.github.com/users/THK-ADV/repos","events_url":"https://api.github.com/users/THK-ADV/events{/privacy}","received_events_url":"https://api.github.com/users/THK-ADV/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/THK-ADV/lwm-reloaded","description":"Das offizielle Repository vom Backend des Praktikumstools an der TH-Köln","fork":false,"url":"https://api.github.com/repos/THK-ADV/lwm-reloaded","forks_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/forks","keys_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/teams","hooks_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/hooks","issue_events_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/events","assignees_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/tags","blobs_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/languages","stargazers_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/stargazers","contributors_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/contributors","subscribers_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/subscribers","subscription_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/subscription","commits_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/merges","archive_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/downloads","issues_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/labels{/name}","releases_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/deployments","created_at":"2017-08-07T09:10:17Z","updated_at":"2018-02-06T17:53:26Z","pushed_at":"2018-02-07T10:39:43Z","git_url":"git://github.com/THK-ADV/lwm-reloaded.git","ssh_url":"git@github.com:THK-ADV/lwm-reloaded.git","clone_url":"https://github.com/THK-ADV/lwm-reloaded.git","svn_url":"https://github.com/THK-ADV/lwm-reloaded","homepage":"","size":5581,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":28,"watchers":2,"default_branch":"master"}},"base":{"label":"THK-ADV:LWM-Postgres","ref":"LWM-Postgres","sha":"f7ddf7e6e4a3cdee582a29c3e7865aebb7244db8","user":{"login":"THK-ADV","id":8058101,"avatar_url":"https://avatars0.githubusercontent.com/u/8058101?v=4","gravatar_id":"","url":"https://api.github.com/users/THK-ADV","html_url":"https://github.com/THK-ADV","followers_url":"https://api.github.com/users/THK-ADV/followers","following_url":"https://api.github.com/users/THK-ADV/following{/other_user}","gists_url":"https://api.github.com/users/THK-ADV/gists{/gist_id}","starred_url":"https://api.github.com/users/THK-ADV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THK-ADV/subscriptions","organizations_url":"https://api.github.com/users/THK-ADV/orgs","repos_url":"https://api.github.com/users/THK-ADV/repos","events_url":"https://api.github.com/users/THK-ADV/events{/privacy}","received_events_url":"https://api.github.com/users/THK-ADV/received_events","type":"Organization","site_admin":false},"repo":{"id":99559039,"name":"lwm-reloaded","full_name":"THK-ADV/lwm-reloaded","owner":{"login":"THK-ADV","id":8058101,"avatar_url":"https://avatars0.githubusercontent.com/u/8058101?v=4","gravatar_id":"","url":"https://api.github.com/users/THK-ADV","html_url":"https://github.com/THK-ADV","followers_url":"https://api.github.com/users/THK-ADV/followers","following_url":"https://api.github.com/users/THK-ADV/following{/other_user}","gists_url":"https://api.github.com/users/THK-ADV/gists{/gist_id}","starred_url":"https://api.github.com/users/THK-ADV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THK-ADV/subscriptions","organizations_url":"https://api.github.com/users/THK-ADV/orgs","repos_url":"https://api.github.com/users/THK-ADV/repos","events_url":"https://api.github.com/users/THK-ADV/events{/privacy}","received_events_url":"https://api.github.com/users/THK-ADV/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/THK-ADV/lwm-reloaded","description":"Das offizielle Repository vom Backend des Praktikumstools an der TH-Köln","fork":false,"url":"https://api.github.com/repos/THK-ADV/lwm-reloaded","forks_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/forks","keys_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/teams","hooks_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/hooks","issue_events_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/events","assignees_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/tags","blobs_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/languages","stargazers_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/stargazers","contributors_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/contributors","subscribers_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/subscribers","subscription_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/subscription","commits_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/merges","archive_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/downloads","issues_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/labels{/name}","releases_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/THK-ADV/lwm-reloaded/deployments","created_at":"2017-08-07T09:10:17Z","updated_at":"2018-02-06T17:53:26Z","pushed_at":"2018-02-07T10:39:43Z","git_url":"git://github.com/THK-ADV/lwm-reloaded.git","ssh_url":"git@github.com:THK-ADV/lwm-reloaded.git","clone_url":"https://github.com/THK-ADV/lwm-reloaded.git","svn_url":"https://github.com/THK-ADV/lwm-reloaded","homepage":"","size":5581,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":28,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63"},"html":{"href":"https://github.com/THK-ADV/lwm-reloaded/pull/63"},"issue":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/63"},"comments":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/THK-ADV/lwm-reloaded/statuses/0bb85d5c8cc856b524c68bb9c371726d7087765d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexdobry","id":2527034,"avatar_url":"https://avatars3.githubusercontent.com/u/2527034?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdobry","html_url":"https://github.com/alexdobry","followers_url":"https://api.github.com/users/alexdobry/followers","following_url":"https://api.github.com/users/alexdobry/following{/other_user}","gists_url":"https://api.github.com/users/alexdobry/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdobry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdobry/subscriptions","organizations_url":"https://api.github.com/users/alexdobry/orgs","repos_url":"https://api.github.com/users/alexdobry/repos","events_url":"https://api.github.com/users/alexdobry/events{/privacy}","received_events_url":"https://api.github.com/users/alexdobry/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":21,"additions":2995,"deletions":15750,"changed_files":208}}
{"actor":{"display_login":"alexdobry"}}