{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/comments/230472082","pull_request_review_id":171225421,"id":230472082,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ3MjA4Mg==","diff_hunk":"@@ -83,15 +84,13 @@ data \"aws_iam_policy_document\" \"monitoring_rds_assume_role\" {\n }\n \n resource \"aws_iam_role\" \"rds_enhanced_monitoring\" {\n-  count = \"${var.monitoring_interval > 0 ? 1 : 0}\"\n-\n+  count              = \"${var.create_resources ? var.monitoring_interval > 0 ? 1 : 0 : 0}\"","path":"main.tf","position":32,"original_position":32,"commit_id":"0fe1574a15a1b30085d4071f5887f4c66f1fd5eb","original_commit_id":"0fe1574a15a1b30085d4071f5887f4c66f1fd5eb","user":{"login":"antonbabenko","id":393243,"node_id":"MDQ6VXNlcjM5MzI0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/393243?v=4","gravatar_id":"","url":"https://api.github.com/users/antonbabenko","html_url":"https://github.com/antonbabenko","followers_url":"https://api.github.com/users/antonbabenko/followers","following_url":"https://api.github.com/users/antonbabenko/following{/other_user}","gists_url":"https://api.github.com/users/antonbabenko/gists{/gist_id}","starred_url":"https://api.github.com/users/antonbabenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonbabenko/subscriptions","organizations_url":"https://api.github.com/users/antonbabenko/orgs","repos_url":"https://api.github.com/users/antonbabenko/repos","events_url":"https://api.github.com/users/antonbabenko/events{/privacy}","received_events_url":"https://api.github.com/users/antonbabenko/received_events","type":"User","site_admin":false},"body":"Less comparisons is nicer, I believe:\r\n```suggestion\r\n  count              = \"${var.create_resources && var.monitoring_interval > 0 ? 1 : 0}\"\r\n```","created_at":"2018-11-02T18:43:14Z","updated_at":"2018-11-02T18:47:11Z","html_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7#discussion_r230472082","pull_request_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/comments/230472082"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7#discussion_r230472082"},"pull_request":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7","id":224928817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTI4ODE3","html_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7.patch","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/7","number":7,"state":"open","locked":false,"title":"Conditional creation of cluster and related resources","user":{"login":"max-rocket-internet","id":8859277,"node_id":"MDQ6VXNlcjg4NTkyNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/8859277?v=4","gravatar_id":"","url":"https://api.github.com/users/max-rocket-internet","html_url":"https://github.com/max-rocket-internet","followers_url":"https://api.github.com/users/max-rocket-internet/followers","following_url":"https://api.github.com/users/max-rocket-internet/following{/other_user}","gists_url":"https://api.github.com/users/max-rocket-internet/gists{/gist_id}","starred_url":"https://api.github.com/users/max-rocket-internet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-rocket-internet/subscriptions","organizations_url":"https://api.github.com/users/max-rocket-internet/orgs","repos_url":"https://api.github.com/users/max-rocket-internet/repos","events_url":"https://api.github.com/users/max-rocket-internet/events{/privacy}","received_events_url":"https://api.github.com/users/max-rocket-internet/received_events","type":"User","site_admin":false},"body":"Adding `create_resources` to allow declaring the module without creating any resources. This is mentioned in https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/2","created_at":"2018-10-23T07:42:27Z","updated_at":"2018-11-02T18:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebe92d7cb99015abb80e6fcf8543fee7b89a37f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7/commits","review_comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7/comments","review_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/7/comments","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/statuses/0fe1574a15a1b30085d4071f5887f4c66f1fd5eb","head":{"label":"FutureSharks:conditional_creation","ref":"conditional_creation","sha":"0fe1574a15a1b30085d4071f5887f4c66f1fd5eb","user":{"login":"FutureSharks","id":5198883,"node_id":"MDQ6VXNlcjUxOTg4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5198883?v=4","gravatar_id":"","url":"https://api.github.com/users/FutureSharks","html_url":"https://github.com/FutureSharks","followers_url":"https://api.github.com/users/FutureSharks/followers","following_url":"https://api.github.com/users/FutureSharks/following{/other_user}","gists_url":"https://api.github.com/users/FutureSharks/gists{/gist_id}","starred_url":"https://api.github.com/users/FutureSharks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FutureSharks/subscriptions","organizations_url":"https://api.github.com/users/FutureSharks/orgs","repos_url":"https://api.github.com/users/FutureSharks/repos","events_url":"https://api.github.com/users/FutureSharks/events{/privacy}","received_events_url":"https://api.github.com/users/FutureSharks/received_events","type":"User","site_admin":false},"repo":{"id":143702327,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MDIzMjc=","name":"terraform-aws-rds-aurora","full_name":"FutureSharks/terraform-aws-rds-aurora","private":false,"owner":{"login":"FutureSharks","id":5198883,"node_id":"MDQ6VXNlcjUxOTg4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5198883?v=4","gravatar_id":"","url":"https://api.github.com/users/FutureSharks","html_url":"https://github.com/FutureSharks","followers_url":"https://api.github.com/users/FutureSharks/followers","following_url":"https://api.github.com/users/FutureSharks/following{/other_user}","gists_url":"https://api.github.com/users/FutureSharks/gists{/gist_id}","starred_url":"https://api.github.com/users/FutureSharks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FutureSharks/subscriptions","organizations_url":"https://api.github.com/users/FutureSharks/orgs","repos_url":"https://api.github.com/users/FutureSharks/repos","events_url":"https://api.github.com/users/FutureSharks/events{/privacy}","received_events_url":"https://api.github.com/users/FutureSharks/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FutureSharks/terraform-aws-rds-aurora","description":"Terraform module which creates RDS Aurora resources on AWS","fork":true,"url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora","forks_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/forks","keys_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/teams","hooks_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/hooks","issue_events_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/issues/events{/number}","events_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/events","assignees_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/assignees{/user}","branches_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/branches{/branch}","tags_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/tags","blobs_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/git/refs{/sha}","trees_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/statuses/{sha}","languages_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/languages","stargazers_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/stargazers","contributors_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/contributors","subscribers_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/subscribers","subscription_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/subscription","commits_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/commits{/sha}","git_commits_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/git/commits{/sha}","comments_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/comments{/number}","issue_comment_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/issues/comments{/number}","contents_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/contents/{+path}","compare_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/merges","archive_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/downloads","issues_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/issues{/number}","pulls_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/pulls{/number}","milestones_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/milestones{/number}","notifications_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/labels{/name}","releases_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/releases{/id}","deployments_url":"https://api.github.com/repos/FutureSharks/terraform-aws-rds-aurora/deployments","created_at":"2018-08-06T08:56:09Z","updated_at":"2018-10-11T08:56:14Z","pushed_at":"2018-10-24T09:04:54Z","git_url":"git://github.com/FutureSharks/terraform-aws-rds-aurora.git","ssh_url":"git@github.com:FutureSharks/terraform-aws-rds-aurora.git","clone_url":"https://github.com/FutureSharks/terraform-aws-rds-aurora.git","svn_url":"https://github.com/FutureSharks/terraform-aws-rds-aurora","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-aws-modules:master","ref":"master","sha":"4bfa7d4ac566993705195665b405203aecd7cde6","user":{"login":"terraform-aws-modules","id":31414033,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDE0MDMz","avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":104859501,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4NTk1MDE=","name":"terraform-aws-rds-aurora","full_name":"terraform-aws-modules/terraform-aws-rds-aurora","private":false,"owner":{"login":"terraform-aws-modules","id":31414033,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDE0MDMz","avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora","description":"Terraform module which creates RDS Aurora resources on AWS","fork":false,"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora","forks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/forks","keys_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/teams","hooks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/hooks","issue_events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/events","assignees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/tags","blobs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/languages","stargazers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/stargazers","contributors_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/contributors","subscribers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/subscribers","subscription_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/subscription","commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/merges","archive_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/downloads","issues_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/labels{/name}","releases_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/deployments","created_at":"2017-09-26T08:43:38Z","updated_at":"2018-10-25T10:01:03Z","pushed_at":"2018-10-23T07:42:28Z","git_url":"git://github.com/terraform-aws-modules/terraform-aws-rds-aurora.git","ssh_url":"git@github.com:terraform-aws-modules/terraform-aws-rds-aurora.git","clone_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora.git","svn_url":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora","homepage":null,"size":27,"stargazers_count":11,"watchers_count":11,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/7"},"issue":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/7"},"comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/statuses/0fe1574a15a1b30085d4071f5887f4c66f1fd5eb"}},"author_association":"NONE"}}
{"actor":{"display_login":"antonbabenko"}}