{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/kaunta/gbpl/pulls/24","id":169843187,"html_url":"https://github.com/kaunta/gbpl/pull/24","diff_url":"https://github.com/kaunta/gbpl/pull/24.diff","patch_url":"https://github.com/kaunta/gbpl/pull/24.patch","issue_url":"https://api.github.com/repos/kaunta/gbpl/issues/24","number":24,"state":"closed","locked":false,"title":"refactor run_test.gawk and test_coverage","user":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"body":"Fixes #23 \r\n\r\nI noticed that there was common behavior between run_test.gawk and\r\ntest_coverage: namely, they both \"parsed\" the test files. As I have\r\nmade changes to the regular expressions used to parse the test files,\r\nmy work must be duplicated over both files.\r\n\r\nThis commit introduces a GNU AWK file called \"test.gawk\" that contains\r\nfunctions for parsing\r\n\r\n- lines with comments\r\n- lines with function declarations\r\n- lines with test cases\r\n- lines with require statements\r\n\r\nSo now instead of doing the parsing and the processing in one file, we\r\ncan simply include \"test.gawk\" and then write like\r\n\r\n    comment(data) { next }\r\n\r\n    requirefile(data) { load_file(data[\"filename\"]) }\r\n\r\n    funcdecl(data) {\r\n        f_name = data[\"name\"]\r\n\r\n        delete f_params\r\n        for (i = 1; i <= length(data[\"parameters\"]); ++i) {\r\n            f_params[i] = data[\"parameters\"][i]\r\n        }\r\n    }\r\n\r\nChanges proposed in this pull request:\r\n- single file that manages parsing.\r\n- refactoring test coverage and test running tools to use the single parsing file.\r\n\r\n@kaunta\r\n","created_at":"2018-02-18T18:30:45Z","updated_at":"2018-02-18T18:36:16Z","closed_at":"2018-02-18T18:36:15Z","merged_at":"2018-02-18T18:36:15Z","merge_commit_sha":"7fa3326c9cfce6c5c0642d8335a70f4300ca1591","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaunta/gbpl/pulls/24/commits","review_comments_url":"https://api.github.com/repos/kaunta/gbpl/pulls/24/comments","review_comment_url":"https://api.github.com/repos/kaunta/gbpl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaunta/gbpl/issues/24/comments","statuses_url":"https://api.github.com/repos/kaunta/gbpl/statuses/1d71aa4d56bd1aef2a54ed5ea15af2850dcc6f2c","head":{"label":"kaunta:test","ref":"test","sha":"1d71aa4d56bd1aef2a54ed5ea15af2850dcc6f2c","user":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"repo":{"id":118057509,"name":"gbpl","full_name":"kaunta/gbpl","owner":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaunta/gbpl","description":"GNU BC Probability Library","fork":false,"url":"https://api.github.com/repos/kaunta/gbpl","forks_url":"https://api.github.com/repos/kaunta/gbpl/forks","keys_url":"https://api.github.com/repos/kaunta/gbpl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaunta/gbpl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaunta/gbpl/teams","hooks_url":"https://api.github.com/repos/kaunta/gbpl/hooks","issue_events_url":"https://api.github.com/repos/kaunta/gbpl/issues/events{/number}","events_url":"https://api.github.com/repos/kaunta/gbpl/events","assignees_url":"https://api.github.com/repos/kaunta/gbpl/assignees{/user}","branches_url":"https://api.github.com/repos/kaunta/gbpl/branches{/branch}","tags_url":"https://api.github.com/repos/kaunta/gbpl/tags","blobs_url":"https://api.github.com/repos/kaunta/gbpl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaunta/gbpl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaunta/gbpl/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaunta/gbpl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaunta/gbpl/statuses/{sha}","languages_url":"https://api.github.com/repos/kaunta/gbpl/languages","stargazers_url":"https://api.github.com/repos/kaunta/gbpl/stargazers","contributors_url":"https://api.github.com/repos/kaunta/gbpl/contributors","subscribers_url":"https://api.github.com/repos/kaunta/gbpl/subscribers","subscription_url":"https://api.github.com/repos/kaunta/gbpl/subscription","commits_url":"https://api.github.com/repos/kaunta/gbpl/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaunta/gbpl/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaunta/gbpl/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaunta/gbpl/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaunta/gbpl/contents/{+path}","compare_url":"https://api.github.com/repos/kaunta/gbpl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaunta/gbpl/merges","archive_url":"https://api.github.com/repos/kaunta/gbpl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaunta/gbpl/downloads","issues_url":"https://api.github.com/repos/kaunta/gbpl/issues{/number}","pulls_url":"https://api.github.com/repos/kaunta/gbpl/pulls{/number}","milestones_url":"https://api.github.com/repos/kaunta/gbpl/milestones{/number}","notifications_url":"https://api.github.com/repos/kaunta/gbpl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaunta/gbpl/labels{/name}","releases_url":"https://api.github.com/repos/kaunta/gbpl/releases{/id}","deployments_url":"https://api.github.com/repos/kaunta/gbpl/deployments","created_at":"2018-01-19T00:59:58Z","updated_at":"2018-01-27T01:35:58Z","pushed_at":"2018-02-18T18:36:15Z","git_url":"git://github.com/kaunta/gbpl.git","ssh_url":"git@github.com:kaunta/gbpl.git","clone_url":"https://github.com/kaunta/gbpl.git","svn_url":"https://github.com/kaunta/gbpl","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"Awk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"kaunta:master","ref":"master","sha":"a00f73874ce8603920ea15331ab05431f085e025","user":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"repo":{"id":118057509,"name":"gbpl","full_name":"kaunta/gbpl","owner":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaunta/gbpl","description":"GNU BC Probability Library","fork":false,"url":"https://api.github.com/repos/kaunta/gbpl","forks_url":"https://api.github.com/repos/kaunta/gbpl/forks","keys_url":"https://api.github.com/repos/kaunta/gbpl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaunta/gbpl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaunta/gbpl/teams","hooks_url":"https://api.github.com/repos/kaunta/gbpl/hooks","issue_events_url":"https://api.github.com/repos/kaunta/gbpl/issues/events{/number}","events_url":"https://api.github.com/repos/kaunta/gbpl/events","assignees_url":"https://api.github.com/repos/kaunta/gbpl/assignees{/user}","branches_url":"https://api.github.com/repos/kaunta/gbpl/branches{/branch}","tags_url":"https://api.github.com/repos/kaunta/gbpl/tags","blobs_url":"https://api.github.com/repos/kaunta/gbpl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaunta/gbpl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaunta/gbpl/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaunta/gbpl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaunta/gbpl/statuses/{sha}","languages_url":"https://api.github.com/repos/kaunta/gbpl/languages","stargazers_url":"https://api.github.com/repos/kaunta/gbpl/stargazers","contributors_url":"https://api.github.com/repos/kaunta/gbpl/contributors","subscribers_url":"https://api.github.com/repos/kaunta/gbpl/subscribers","subscription_url":"https://api.github.com/repos/kaunta/gbpl/subscription","commits_url":"https://api.github.com/repos/kaunta/gbpl/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaunta/gbpl/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaunta/gbpl/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaunta/gbpl/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaunta/gbpl/contents/{+path}","compare_url":"https://api.github.com/repos/kaunta/gbpl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaunta/gbpl/merges","archive_url":"https://api.github.com/repos/kaunta/gbpl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaunta/gbpl/downloads","issues_url":"https://api.github.com/repos/kaunta/gbpl/issues{/number}","pulls_url":"https://api.github.com/repos/kaunta/gbpl/pulls{/number}","milestones_url":"https://api.github.com/repos/kaunta/gbpl/milestones{/number}","notifications_url":"https://api.github.com/repos/kaunta/gbpl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaunta/gbpl/labels{/name}","releases_url":"https://api.github.com/repos/kaunta/gbpl/releases{/id}","deployments_url":"https://api.github.com/repos/kaunta/gbpl/deployments","created_at":"2018-01-19T00:59:58Z","updated_at":"2018-01-27T01:35:58Z","pushed_at":"2018-02-18T18:36:15Z","git_url":"git://github.com/kaunta/gbpl.git","ssh_url":"git@github.com:kaunta/gbpl.git","clone_url":"https://github.com/kaunta/gbpl.git","svn_url":"https://github.com/kaunta/gbpl","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"Awk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaunta/gbpl/pulls/24"},"html":{"href":"https://github.com/kaunta/gbpl/pull/24"},"issue":{"href":"https://api.github.com/repos/kaunta/gbpl/issues/24"},"comments":{"href":"https://api.github.com/repos/kaunta/gbpl/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/kaunta/gbpl/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/kaunta/gbpl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaunta/gbpl/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/kaunta/gbpl/statuses/1d71aa4d56bd1aef2a54ed5ea15af2850dcc6f2c"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kaunta","id":9272586,"avatar_url":"https://avatars1.githubusercontent.com/u/9272586?v=4","gravatar_id":"","url":"https://api.github.com/users/kaunta","html_url":"https://github.com/kaunta","followers_url":"https://api.github.com/users/kaunta/followers","following_url":"https://api.github.com/users/kaunta/following{/other_user}","gists_url":"https://api.github.com/users/kaunta/gists{/gist_id}","starred_url":"https://api.github.com/users/kaunta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaunta/subscriptions","organizations_url":"https://api.github.com/users/kaunta/orgs","repos_url":"https://api.github.com/users/kaunta/repos","events_url":"https://api.github.com/users/kaunta/events{/privacy}","received_events_url":"https://api.github.com/users/kaunta/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":152,"deletions":111,"changed_files":3}}
{"actor":{"display_login":"kaunta"}}