{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/207729776","pull_request_review_id":143404364,"id":207729776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzcyOTc3Ng==","diff_hunk":"@@ -38,6 +38,19 @@ LIBSNARK=snark/libsnark.a\n LIBUNIVALUE=univalue/libunivalue.la\n LIBZCASH=libzcash.a\n \n+if ENABLE_ZMQ\n+LIBBITCOIN_ZMQ=libbitcoin_zmq.a\n+endif\n+if ENABLE_PROTON\n+LIBBITCOIN_PROTON=libbitcoin_proton.a\n+endif\n+if BUILD_BITCOIN_LIBS\n+LIBBITCOINCONSENSUS=libbitcoinconsensus.la","path":"src/Makefile.am","position":36,"original_position":36,"commit_id":"b4100839bf6e2f3eb25cfe07e8ea31f9442fae68","original_commit_id":"b4100839bf6e2f3eb25cfe07e8ea31f9442fae68","user":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"body":"Oops, here's the bug. I missed a spot when editing the upstream commit.","created_at":"2018-08-05T08:55:22Z","updated_at":"2018-08-05T08:55:23Z","html_url":"https://github.com/zcash/zcash/pull/3447#discussion_r207729776","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/3447","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/207729776"},"html":{"href":"https://github.com/zcash/zcash/pull/3447#discussion_r207729776"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3447"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3447","id":206163516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTYzNTE2","html_url":"https://github.com/zcash/zcash/pull/3447","diff_url":"https://github.com/zcash/zcash/pull/3447.diff","patch_url":"https://github.com/zcash/zcash/pull/3447.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3447","number":3447,"state":"open","locked":false,"title":"ZIP 32 preparations","user":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"body":"Includes Makefile changes cherry-picked from the following upstream PRs:\r\n\r\n- bitcoin/bitcoin#7689\r\n- bitcoin/bitcoin#10849\r\n\r\nPart of #3380.","created_at":"2018-08-04T00:15:31Z","updated_at":"2018-08-05T08:55:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0ea18bb919744a5c4b72c8c2c5bb87fcb2e7e46","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebfull","id":3794471,"node_id":"MDQ6VXNlcjM3OTQ0NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3794471?v=4","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},{"login":"Eirik0","id":6133620,"node_id":"MDQ6VXNlcjYxMzM2MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6133620?v=4","gravatar_id":"","url":"https://api.github.com/users/Eirik0","html_url":"https://github.com/Eirik0","followers_url":"https://api.github.com/users/Eirik0/followers","following_url":"https://api.github.com/users/Eirik0/following{/other_user}","gists_url":"https://api.github.com/users/Eirik0/gists{/gist_id}","starred_url":"https://api.github.com/users/Eirik0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eirik0/subscriptions","organizations_url":"https://api.github.com/users/Eirik0/orgs","repos_url":"https://api.github.com/users/Eirik0/repos","events_url":"https://api.github.com/users/Eirik0/events{/privacy}","received_events_url":"https://api.github.com/users/Eirik0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":166754268,"node_id":"MDU6TGFiZWwxNjY3NTQyNjg=","url":"https://api.github.com/repos/zcash/zcash/labels/Bitcoin%20Core%20codebase","name":"Bitcoin Core codebase","color":"fbca74","default":false},{"id":442116761,"node_id":"MDU6TGFiZWw0NDIxMTY3NjE=","url":"https://api.github.com/repos/zcash/zcash/labels/dependencies","name":"dependencies","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/73","html_url":"https://github.com/zcash/zcash/milestone/73","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/73/labels","id":3126623,"node_id":"MDk6TWlsZXN0b25lMzEyNjYyMw==","number":73,"title":"v2.0.0","description":"First Sapling-compatible release, containing the main-net activation height.","creator":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":44,"state":"open","created_at":"2018-02-19T11:41:00Z","updated_at":"2018-08-04T00:15:32Z","due_on":"2018-08-13T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/3447/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/3447/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3447/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/b4100839bf6e2f3eb25cfe07e8ea31f9442fae68","head":{"label":"str4d:zip32-prep","ref":"zip32-prep","sha":"b4100839bf6e2f3eb25cfe07e8ea31f9442fae68","user":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"repo":{"id":52462432,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ2MjQzMg==","name":"zcash","full_name":"str4d/zcash","owner":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/str4d/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/str4d/zcash","forks_url":"https://api.github.com/repos/str4d/zcash/forks","keys_url":"https://api.github.com/repos/str4d/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/str4d/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/str4d/zcash/teams","hooks_url":"https://api.github.com/repos/str4d/zcash/hooks","issue_events_url":"https://api.github.com/repos/str4d/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/str4d/zcash/events","assignees_url":"https://api.github.com/repos/str4d/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/str4d/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/str4d/zcash/tags","blobs_url":"https://api.github.com/repos/str4d/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/str4d/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/str4d/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/str4d/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/str4d/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/str4d/zcash/languages","stargazers_url":"https://api.github.com/repos/str4d/zcash/stargazers","contributors_url":"https://api.github.com/repos/str4d/zcash/contributors","subscribers_url":"https://api.github.com/repos/str4d/zcash/subscribers","subscription_url":"https://api.github.com/repos/str4d/zcash/subscription","commits_url":"https://api.github.com/repos/str4d/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/str4d/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/str4d/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/str4d/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/str4d/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/str4d/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/str4d/zcash/merges","archive_url":"https://api.github.com/repos/str4d/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/str4d/zcash/downloads","issues_url":"https://api.github.com/repos/str4d/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/str4d/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/str4d/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/str4d/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/str4d/zcash/labels{/name}","releases_url":"https://api.github.com/repos/str4d/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/str4d/zcash/deployments","created_at":"2016-02-24T17:50:40Z","updated_at":"2018-07-11T04:40:48Z","pushed_at":"2018-08-04T16:45:58Z","git_url":"git://github.com/str4d/zcash.git","ssh_url":"git@github.com:str4d/zcash.git","clone_url":"https://github.com/str4d/zcash.git","svn_url":"https://github.com/str4d/zcash","homepage":"https://z.cash/","size":73984,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":0,"watchers":29,"default_branch":"master"}},"base":{"label":"zcash:master","ref":"master","sha":"aa32786576c069e6a5ee358584b9c5e2dcc2c8b8","user":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"node_id":"MDEwOlJlcG9zaXRvcnkyNjk4NzA0OQ==","name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2018-08-04T19:10:24Z","pushed_at":"2018-08-04T22:50:19Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":64238,"stargazers_count":3777,"watchers_count":3777,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1281,"mirror_url":null,"archived":false,"open_issues_count":811,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1281,"open_issues":811,"watchers":3777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3447"},"html":{"href":"https://github.com/zcash/zcash/pull/3447"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/3447"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/3447/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3447/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3447/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/b4100839bf6e2f3eb25cfe07e8ea31f9442fae68"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"str4d"}}