{"action":"opened","number":219,"pull_request":{"url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219","id":206156854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTU2ODU0","html_url":"https://github.com/redhat-cop/infra-ansible/pull/219","diff_url":"https://github.com/redhat-cop/infra-ansible/pull/219.diff","patch_url":"https://github.com/redhat-cop/infra-ansible/pull/219.patch","issue_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/219","number":219,"state":"open","locked":false,"title":"adding new network type variable","user":{"login":"procrypt","id":11635662,"node_id":"MDQ6VXNlcjExNjM1NjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11635662?v=4","gravatar_id":"","url":"https://api.github.com/users/procrypt","html_url":"https://github.com/procrypt","followers_url":"https://api.github.com/users/procrypt/followers","following_url":"https://api.github.com/users/procrypt/following{/other_user}","gists_url":"https://api.github.com/users/procrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/procrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procrypt/subscriptions","organizations_url":"https://api.github.com/users/procrypt/orgs","repos_url":"https://api.github.com/users/procrypt/repos","events_url":"https://api.github.com/users/procrypt/events{/privacy}","received_events_url":"https://api.github.com/users/procrypt/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nAdds a new variable called `virtinstall_network_type` with default value `direct` as this value created network issues on running the role on CentOS and Fedora.\r\nThe role works fine with `virtinstall_network_type=bridge` in  CentOS and Fedora\r\n\r\n### How should this be tested?\r\n```bash\r\n$ cd /roles/virt-install/tests\r\n$ ansible-playbook -i inventory/ infrahost.yml\r\n```\r\n\r\n### Is there a relevant Issue open for this?\r\nProvide a link to any open issues that describe the problem you are solving.\r\nresolves #36 \r\n\r\n### People to notify\r\ncc: @redhat-cop/infra-ansible @oybed \r\n","created_at":"2018-08-03T23:04:41Z","updated_at":"2018-08-03T23:04:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219/commits","review_comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219/comments","review_comment_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/219/comments","statuses_url":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/b0a25151a52402ebaf93314bd018629980f787db","head":{"label":"procrypt:update-virt-role","ref":"update-virt-role","sha":"b0a25151a52402ebaf93314bd018629980f787db","user":{"login":"procrypt","id":11635662,"node_id":"MDQ6VXNlcjExNjM1NjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11635662?v=4","gravatar_id":"","url":"https://api.github.com/users/procrypt","html_url":"https://github.com/procrypt","followers_url":"https://api.github.com/users/procrypt/followers","following_url":"https://api.github.com/users/procrypt/following{/other_user}","gists_url":"https://api.github.com/users/procrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/procrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procrypt/subscriptions","organizations_url":"https://api.github.com/users/procrypt/orgs","repos_url":"https://api.github.com/users/procrypt/repos","events_url":"https://api.github.com/users/procrypt/events{/privacy}","received_events_url":"https://api.github.com/users/procrypt/received_events","type":"User","site_admin":false},"repo":{"id":138810550,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4MTA1NTA=","name":"infra-ansible","full_name":"procrypt/infra-ansible","owner":{"login":"procrypt","id":11635662,"node_id":"MDQ6VXNlcjExNjM1NjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11635662?v=4","gravatar_id":"","url":"https://api.github.com/users/procrypt","html_url":"https://github.com/procrypt","followers_url":"https://api.github.com/users/procrypt/followers","following_url":"https://api.github.com/users/procrypt/following{/other_user}","gists_url":"https://api.github.com/users/procrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/procrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procrypt/subscriptions","organizations_url":"https://api.github.com/users/procrypt/orgs","repos_url":"https://api.github.com/users/procrypt/repos","events_url":"https://api.github.com/users/procrypt/events{/privacy}","received_events_url":"https://api.github.com/users/procrypt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/procrypt/infra-ansible","description":"Tooling / Ansible to support the many aspects of infrastructure installation, setup and configuration. ","fork":true,"url":"https://api.github.com/repos/procrypt/infra-ansible","forks_url":"https://api.github.com/repos/procrypt/infra-ansible/forks","keys_url":"https://api.github.com/repos/procrypt/infra-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/procrypt/infra-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/procrypt/infra-ansible/teams","hooks_url":"https://api.github.com/repos/procrypt/infra-ansible/hooks","issue_events_url":"https://api.github.com/repos/procrypt/infra-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/procrypt/infra-ansible/events","assignees_url":"https://api.github.com/repos/procrypt/infra-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/procrypt/infra-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/procrypt/infra-ansible/tags","blobs_url":"https://api.github.com/repos/procrypt/infra-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/procrypt/infra-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/procrypt/infra-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/procrypt/infra-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/procrypt/infra-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/procrypt/infra-ansible/languages","stargazers_url":"https://api.github.com/repos/procrypt/infra-ansible/stargazers","contributors_url":"https://api.github.com/repos/procrypt/infra-ansible/contributors","subscribers_url":"https://api.github.com/repos/procrypt/infra-ansible/subscribers","subscription_url":"https://api.github.com/repos/procrypt/infra-ansible/subscription","commits_url":"https://api.github.com/repos/procrypt/infra-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/procrypt/infra-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/procrypt/infra-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/procrypt/infra-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/procrypt/infra-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/procrypt/infra-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/procrypt/infra-ansible/merges","archive_url":"https://api.github.com/repos/procrypt/infra-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/procrypt/infra-ansible/downloads","issues_url":"https://api.github.com/repos/procrypt/infra-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/procrypt/infra-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/procrypt/infra-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/procrypt/infra-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/procrypt/infra-ansible/labels{/name}","releases_url":"https://api.github.com/repos/procrypt/infra-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/procrypt/infra-ansible/deployments","created_at":"2018-06-27T00:53:43Z","updated_at":"2018-08-03T22:36:36Z","pushed_at":"2018-08-03T23:01:13Z","git_url":"git://github.com/procrypt/infra-ansible.git","ssh_url":"git@github.com:procrypt/infra-ansible.git","clone_url":"https://github.com/procrypt/infra-ansible.git","svn_url":"https://github.com/procrypt/infra-ansible","homepage":null,"size":503,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-cop:master","ref":"master","sha":"155dade983c6ce867dac38a9ae62e471ad13437f","user":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"repo":{"id":88211051,"node_id":"MDEwOlJlcG9zaXRvcnk4ODIxMTA1MQ==","name":"infra-ansible","full_name":"redhat-cop/infra-ansible","owner":{"login":"redhat-cop","id":21339385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzM5Mzg1","avatar_url":"https://avatars2.githubusercontent.com/u/21339385?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-cop","html_url":"https://github.com/redhat-cop","followers_url":"https://api.github.com/users/redhat-cop/followers","following_url":"https://api.github.com/users/redhat-cop/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cop/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cop/subscriptions","organizations_url":"https://api.github.com/users/redhat-cop/orgs","repos_url":"https://api.github.com/users/redhat-cop/repos","events_url":"https://api.github.com/users/redhat-cop/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-cop/infra-ansible","description":"Tooling / Ansible to support the many aspects of infrastructure installation, setup and configuration. ","fork":false,"url":"https://api.github.com/repos/redhat-cop/infra-ansible","forks_url":"https://api.github.com/repos/redhat-cop/infra-ansible/forks","keys_url":"https://api.github.com/repos/redhat-cop/infra-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-cop/infra-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-cop/infra-ansible/teams","hooks_url":"https://api.github.com/repos/redhat-cop/infra-ansible/hooks","issue_events_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-cop/infra-ansible/events","assignees_url":"https://api.github.com/repos/redhat-cop/infra-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-cop/infra-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-cop/infra-ansible/tags","blobs_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-cop/infra-ansible/languages","stargazers_url":"https://api.github.com/repos/redhat-cop/infra-ansible/stargazers","contributors_url":"https://api.github.com/repos/redhat-cop/infra-ansible/contributors","subscribers_url":"https://api.github.com/repos/redhat-cop/infra-ansible/subscribers","subscription_url":"https://api.github.com/repos/redhat-cop/infra-ansible/subscription","commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-cop/infra-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-cop/infra-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-cop/infra-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-cop/infra-ansible/merges","archive_url":"https://api.github.com/repos/redhat-cop/infra-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-cop/infra-ansible/downloads","issues_url":"https://api.github.com/repos/redhat-cop/infra-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-cop/infra-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-cop/infra-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-cop/infra-ansible/labels{/name}","releases_url":"https://api.github.com/repos/redhat-cop/infra-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-cop/infra-ansible/deployments","created_at":"2017-04-13T22:20:20Z","updated_at":"2018-08-03T22:20:46Z","pushed_at":"2018-08-03T22:20:43Z","git_url":"git://github.com/redhat-cop/infra-ansible.git","ssh_url":"git@github.com:redhat-cop/infra-ansible.git","clone_url":"https://github.com/redhat-cop/infra-ansible.git","svn_url":"https://github.com/redhat-cop/infra-ansible","homepage":null,"size":467,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":23,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219"},"html":{"href":"https://github.com/redhat-cop/infra-ansible/pull/219"},"issue":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/219"},"comments":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-cop/infra-ansible/statuses/b0a25151a52402ebaf93314bd018629980f787db"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":1,"changed_files":6}}
{"actor":{"display_login":"procrypt"}}