{"action":"created","comment":{"url":"https://api.github.com/repos/napstr/Magma/pulls/comments/228328098","pull_request_review_id":168578283,"id":228328098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMyODA5OA==","diff_hunk":"@@ -56,8 +58,11 @@ public ClosingUndertowWebSocketClient(final XnioWorker worker,\n         final MonoProcessor<Void> completion = MonoProcessor.create();\n         return Mono.fromCallable(\n                 () -> {\n-                    WebSocketClient.ConnectionBuilder builder = this.createConnectionBuilder(url);\n-                    List<String> protocols = this.beforeHandshake(url, headers, handler);\n+                    if (logger.isDebugEnabled()) {\n+                        logger.debug(\"Connecting to \" + url);","path":"src/main/java/space/npstr/magma/connections/hax/ClosingUndertowWebSocketClient.java","position":16,"original_position":16,"commit_id":"df45b459a0743fea1c6ef554259884a2f753d5ee","original_commit_id":"df45b459a0743fea1c6ef554259884a2f753d5ee","user":{"login":"CallMeCodeReview","id":40478533,"node_id":"MDQ6VXNlcjQwNDc4NTMz","avatar_url":"https://avatars0.githubusercontent.com/u/40478533?v=4","gravatar_id":"","url":"https://api.github.com/users/CallMeCodeReview","html_url":"https://github.com/CallMeCodeReview","followers_url":"https://api.github.com/users/CallMeCodeReview/followers","following_url":"https://api.github.com/users/CallMeCodeReview/following{/other_user}","gists_url":"https://api.github.com/users/CallMeCodeReview/gists{/gist_id}","starred_url":"https://api.github.com/users/CallMeCodeReview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CallMeCodeReview/subscriptions","organizations_url":"https://api.github.com/users/CallMeCodeReview/orgs","repos_url":"https://api.github.com/users/CallMeCodeReview/repos","events_url":"https://api.github.com/users/CallMeCodeReview/events{/privacy}","received_events_url":"https://api.github.com/users/CallMeCodeReview/received_events","type":"User","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Format specifiers should be used instead of string concatenation. ([squid:S3457](https://sonarcloud.io/organizations/napstr-github/rules#rule_key=squid%3AS3457))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=space.npstr.magma%3Amagma&pullRequest=14&issues=AWas-MiDFsWw174ZRTe9&open=AWas-MiDFsWw174ZRTe9)\n\n[ISSUE_KEY]: AWas-MiDFsWw174ZRTe9","created_at":"2018-10-25T20:44:40Z","updated_at":"2018-10-25T20:44:40Z","html_url":"https://github.com/napstr/Magma/pull/14#discussion_r228328098","pull_request_url":"https://api.github.com/repos/napstr/Magma/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/napstr/Magma/pulls/comments/228328098"},"html":{"href":"https://github.com/napstr/Magma/pull/14#discussion_r228328098"},"pull_request":{"href":"https://api.github.com/repos/napstr/Magma/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/napstr/Magma/pulls/14","id":225895494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODk1NDk0","html_url":"https://github.com/napstr/Magma/pull/14","diff_url":"https://github.com/napstr/Magma/pull/14.diff","patch_url":"https://github.com/napstr/Magma/pull/14.patch","issue_url":"https://api.github.com/repos/napstr/Magma/issues/14","number":14,"state":"open","locked":false,"title":"Bump dependencies","user":{"login":"napstr","id":6048348,"node_id":"MDQ6VXNlcjYwNDgzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6048348?v=4","gravatar_id":"","url":"https://api.github.com/users/napstr","html_url":"https://github.com/napstr","followers_url":"https://api.github.com/users/napstr/followers","following_url":"https://api.github.com/users/napstr/following{/other_user}","gists_url":"https://api.github.com/users/napstr/gists{/gist_id}","starred_url":"https://api.github.com/users/napstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napstr/subscriptions","organizations_url":"https://api.github.com/users/napstr/orgs","repos_url":"https://api.github.com/users/napstr/repos","events_url":"https://api.github.com/users/napstr/events{/privacy}","received_events_url":"https://api.github.com/users/napstr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-25T20:36:33Z","updated_at":"2018-10-25T20:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c69b91588dd81ff2bff7a455fed50a874a393c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/napstr/Magma/pulls/14/commits","review_comments_url":"https://api.github.com/repos/napstr/Magma/pulls/14/comments","review_comment_url":"https://api.github.com/repos/napstr/Magma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/napstr/Magma/issues/14/comments","statuses_url":"https://api.github.com/repos/napstr/Magma/statuses/df45b459a0743fea1c6ef554259884a2f753d5ee","head":{"label":"napstr:bump-dependencies","ref":"bump-dependencies","sha":"df45b459a0743fea1c6ef554259884a2f753d5ee","user":{"login":"napstr","id":6048348,"node_id":"MDQ6VXNlcjYwNDgzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6048348?v=4","gravatar_id":"","url":"https://api.github.com/users/napstr","html_url":"https://github.com/napstr","followers_url":"https://api.github.com/users/napstr/followers","following_url":"https://api.github.com/users/napstr/following{/other_user}","gists_url":"https://api.github.com/users/napstr/gists{/gist_id}","starred_url":"https://api.github.com/users/napstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napstr/subscriptions","organizations_url":"https://api.github.com/users/napstr/orgs","repos_url":"https://api.github.com/users/napstr/repos","events_url":"https://api.github.com/users/napstr/events{/privacy}","received_events_url":"https://api.github.com/users/napstr/received_events","type":"User","site_admin":false},"repo":{"id":130903315,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5MDMzMTU=","name":"Magma","full_name":"napstr/Magma","private":false,"owner":{"login":"napstr","id":6048348,"node_id":"MDQ6VXNlcjYwNDgzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6048348?v=4","gravatar_id":"","url":"https://api.github.com/users/napstr","html_url":"https://github.com/napstr","followers_url":"https://api.github.com/users/napstr/followers","following_url":"https://api.github.com/users/napstr/following{/other_user}","gists_url":"https://api.github.com/users/napstr/gists{/gist_id}","starred_url":"https://api.github.com/users/napstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napstr/subscriptions","organizations_url":"https://api.github.com/users/napstr/orgs","repos_url":"https://api.github.com/users/napstr/repos","events_url":"https://api.github.com/users/napstr/events{/privacy}","received_events_url":"https://api.github.com/users/napstr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/napstr/Magma","description":"A voice only API for Discord, focused on delivering music at scale.","fork":false,"url":"https://api.github.com/repos/napstr/Magma","forks_url":"https://api.github.com/repos/napstr/Magma/forks","keys_url":"https://api.github.com/repos/napstr/Magma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/napstr/Magma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/napstr/Magma/teams","hooks_url":"https://api.github.com/repos/napstr/Magma/hooks","issue_events_url":"https://api.github.com/repos/napstr/Magma/issues/events{/number}","events_url":"https://api.github.com/repos/napstr/Magma/events","assignees_url":"https://api.github.com/repos/napstr/Magma/assignees{/user}","branches_url":"https://api.github.com/repos/napstr/Magma/branches{/branch}","tags_url":"https://api.github.com/repos/napstr/Magma/tags","blobs_url":"https://api.github.com/repos/napstr/Magma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/napstr/Magma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/napstr/Magma/git/refs{/sha}","trees_url":"https://api.github.com/repos/napstr/Magma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/napstr/Magma/statuses/{sha}","languages_url":"https://api.github.com/repos/napstr/Magma/languages","stargazers_url":"https://api.github.com/repos/napstr/Magma/stargazers","contributors_url":"https://api.github.com/repos/napstr/Magma/contributors","subscribers_url":"https://api.github.com/repos/napstr/Magma/subscribers","subscription_url":"https://api.github.com/repos/napstr/Magma/subscription","commits_url":"https://api.github.com/repos/napstr/Magma/commits{/sha}","git_commits_url":"https://api.github.com/repos/napstr/Magma/git/commits{/sha}","comments_url":"https://api.github.com/repos/napstr/Magma/comments{/number}","issue_comment_url":"https://api.github.com/repos/napstr/Magma/issues/comments{/number}","contents_url":"https://api.github.com/repos/napstr/Magma/contents/{+path}","compare_url":"https://api.github.com/repos/napstr/Magma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/napstr/Magma/merges","archive_url":"https://api.github.com/repos/napstr/Magma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/napstr/Magma/downloads","issues_url":"https://api.github.com/repos/napstr/Magma/issues{/number}","pulls_url":"https://api.github.com/repos/napstr/Magma/pulls{/number}","milestones_url":"https://api.github.com/repos/napstr/Magma/milestones{/number}","notifications_url":"https://api.github.com/repos/napstr/Magma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/napstr/Magma/labels{/name}","releases_url":"https://api.github.com/repos/napstr/Magma/releases{/id}","deployments_url":"https://api.github.com/repos/napstr/Magma/deployments","created_at":"2018-04-24T19:21:42Z","updated_at":"2018-10-17T12:34:59Z","pushed_at":"2018-10-25T20:41:52Z","git_url":"git://github.com/napstr/Magma.git","ssh_url":"git@github.com:napstr/Magma.git","clone_url":"https://github.com/napstr/Magma.git","svn_url":"https://github.com/napstr/Magma","homepage":"","size":2642,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"napstr:master","ref":"master","sha":"5df58aad512b05b0fb4e202b302238106256bf95","user":{"login":"napstr","id":6048348,"node_id":"MDQ6VXNlcjYwNDgzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6048348?v=4","gravatar_id":"","url":"https://api.github.com/users/napstr","html_url":"https://github.com/napstr","followers_url":"https://api.github.com/users/napstr/followers","following_url":"https://api.github.com/users/napstr/following{/other_user}","gists_url":"https://api.github.com/users/napstr/gists{/gist_id}","starred_url":"https://api.github.com/users/napstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napstr/subscriptions","organizations_url":"https://api.github.com/users/napstr/orgs","repos_url":"https://api.github.com/users/napstr/repos","events_url":"https://api.github.com/users/napstr/events{/privacy}","received_events_url":"https://api.github.com/users/napstr/received_events","type":"User","site_admin":false},"repo":{"id":130903315,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5MDMzMTU=","name":"Magma","full_name":"napstr/Magma","private":false,"owner":{"login":"napstr","id":6048348,"node_id":"MDQ6VXNlcjYwNDgzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6048348?v=4","gravatar_id":"","url":"https://api.github.com/users/napstr","html_url":"https://github.com/napstr","followers_url":"https://api.github.com/users/napstr/followers","following_url":"https://api.github.com/users/napstr/following{/other_user}","gists_url":"https://api.github.com/users/napstr/gists{/gist_id}","starred_url":"https://api.github.com/users/napstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napstr/subscriptions","organizations_url":"https://api.github.com/users/napstr/orgs","repos_url":"https://api.github.com/users/napstr/repos","events_url":"https://api.github.com/users/napstr/events{/privacy}","received_events_url":"https://api.github.com/users/napstr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/napstr/Magma","description":"A voice only API for Discord, focused on delivering music at scale.","fork":false,"url":"https://api.github.com/repos/napstr/Magma","forks_url":"https://api.github.com/repos/napstr/Magma/forks","keys_url":"https://api.github.com/repos/napstr/Magma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/napstr/Magma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/napstr/Magma/teams","hooks_url":"https://api.github.com/repos/napstr/Magma/hooks","issue_events_url":"https://api.github.com/repos/napstr/Magma/issues/events{/number}","events_url":"https://api.github.com/repos/napstr/Magma/events","assignees_url":"https://api.github.com/repos/napstr/Magma/assignees{/user}","branches_url":"https://api.github.com/repos/napstr/Magma/branches{/branch}","tags_url":"https://api.github.com/repos/napstr/Magma/tags","blobs_url":"https://api.github.com/repos/napstr/Magma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/napstr/Magma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/napstr/Magma/git/refs{/sha}","trees_url":"https://api.github.com/repos/napstr/Magma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/napstr/Magma/statuses/{sha}","languages_url":"https://api.github.com/repos/napstr/Magma/languages","stargazers_url":"https://api.github.com/repos/napstr/Magma/stargazers","contributors_url":"https://api.github.com/repos/napstr/Magma/contributors","subscribers_url":"https://api.github.com/repos/napstr/Magma/subscribers","subscription_url":"https://api.github.com/repos/napstr/Magma/subscription","commits_url":"https://api.github.com/repos/napstr/Magma/commits{/sha}","git_commits_url":"https://api.github.com/repos/napstr/Magma/git/commits{/sha}","comments_url":"https://api.github.com/repos/napstr/Magma/comments{/number}","issue_comment_url":"https://api.github.com/repos/napstr/Magma/issues/comments{/number}","contents_url":"https://api.github.com/repos/napstr/Magma/contents/{+path}","compare_url":"https://api.github.com/repos/napstr/Magma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/napstr/Magma/merges","archive_url":"https://api.github.com/repos/napstr/Magma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/napstr/Magma/downloads","issues_url":"https://api.github.com/repos/napstr/Magma/issues{/number}","pulls_url":"https://api.github.com/repos/napstr/Magma/pulls{/number}","milestones_url":"https://api.github.com/repos/napstr/Magma/milestones{/number}","notifications_url":"https://api.github.com/repos/napstr/Magma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/napstr/Magma/labels{/name}","releases_url":"https://api.github.com/repos/napstr/Magma/releases{/id}","deployments_url":"https://api.github.com/repos/napstr/Magma/deployments","created_at":"2018-04-24T19:21:42Z","updated_at":"2018-10-17T12:34:59Z","pushed_at":"2018-10-25T20:41:52Z","git_url":"git://github.com/napstr/Magma.git","ssh_url":"git@github.com:napstr/Magma.git","clone_url":"https://github.com/napstr/Magma.git","svn_url":"https://github.com/napstr/Magma","homepage":"","size":2642,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/napstr/Magma/pulls/14"},"html":{"href":"https://github.com/napstr/Magma/pull/14"},"issue":{"href":"https://api.github.com/repos/napstr/Magma/issues/14"},"comments":{"href":"https://api.github.com/repos/napstr/Magma/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/napstr/Magma/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/napstr/Magma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/napstr/Magma/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/napstr/Magma/statuses/df45b459a0743fea1c6ef554259884a2f753d5ee"}},"author_association":"OWNER"}}
{"actor":{"display_login":"CallMeCodeReview"}}