{"action":"closed","number":4033,"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033","id":224534865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTM0ODY1","html_url":"https://github.com/apollographql/apollo-client/pull/4033","diff_url":"https://github.com/apollographql/apollo-client/pull/4033.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/4033.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4033","number":4033,"state":"closed","locked":false,"title":"Fix mocks to pass tsc","user":{"login":"mtsmfm","id":1796864,"node_id":"MDQ6VXNlcjE3OTY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1796864?v=4","gravatar_id":"","url":"https://api.github.com/users/mtsmfm","html_url":"https://github.com/mtsmfm","followers_url":"https://api.github.com/users/mtsmfm/followers","following_url":"https://api.github.com/users/mtsmfm/following{/other_user}","gists_url":"https://api.github.com/users/mtsmfm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtsmfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtsmfm/subscriptions","organizations_url":"https://api.github.com/users/mtsmfm/orgs","repos_url":"https://api.github.com/users/mtsmfm/repos","events_url":"https://api.github.com/users/mtsmfm/events{/privacy}","received_events_url":"https://api.github.com/users/mtsmfm/received_events","type":"User","site_admin":false},"body":"<!--\r\n  Thanks for filing a pull request on Apollo Client!\r\n\r\n  A few automated bots may chime in on your PR. They are here to help\r\n  with reviewing and ensuring Apollo Client is production ready after each\r\n  pull request merge.\r\n\r\n    - meteor-bot will respond asking you to sign the CLA if this is your first PR.\r\n      It may also respond with warnings, messages, or fail the build if something is off.\r\n      Don't worry, it'll help you to fix what is broken!\r\n\r\n    - bundlesize is a status check to keep the footprint of Apollo Client as small as possible.\r\n\r\n    - travis-ci will run tests, checking style of code, and generally make\r\n      sure everything is working as expected\r\n\r\n  Please look at the following checklist to ensure that your PR\r\n  can be accepted quickly:\r\n-->\r\n\r\n### Checklist:\r\n\r\n- [x] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)\r\n- [x] Make sure all of the significant new logic is covered by tests\r\n\r\n----\r\n\r\nref: https://github.com/apollographql/apollo-client/pull/3849/files#r223391261\r\n\r\nAs a first step, I fixed typings for mocks.\r\n\r\ncc @benjamn ","created_at":"2018-10-21T11:33:04Z","updated_at":"2018-11-16T19:19:47Z","closed_at":"2018-11-16T19:19:46Z","merged_at":"2018-11-16T19:19:46Z","merge_commit_sha":"ce7dbaef03290f83dd6d120f77ecea8d1a6e9cc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4033/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/62e250ca3d8742a061166ef688d078bf908f3161","head":{"label":"mtsmfm:mtsmfm/fix-mock-typing","ref":"mtsmfm/fix-mock-typing","sha":"62e250ca3d8742a061166ef688d078bf908f3161","user":{"login":"mtsmfm","id":1796864,"node_id":"MDQ6VXNlcjE3OTY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1796864?v=4","gravatar_id":"","url":"https://api.github.com/users/mtsmfm","html_url":"https://github.com/mtsmfm","followers_url":"https://api.github.com/users/mtsmfm/followers","following_url":"https://api.github.com/users/mtsmfm/following{/other_user}","gists_url":"https://api.github.com/users/mtsmfm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtsmfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtsmfm/subscriptions","organizations_url":"https://api.github.com/users/mtsmfm/orgs","repos_url":"https://api.github.com/users/mtsmfm/repos","events_url":"https://api.github.com/users/mtsmfm/events{/privacy}","received_events_url":"https://api.github.com/users/mtsmfm/received_events","type":"User","site_admin":false},"repo":{"id":146102423,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxMDI0MjM=","name":"apollo-client","full_name":"mtsmfm/apollo-client","private":false,"owner":{"login":"mtsmfm","id":1796864,"node_id":"MDQ6VXNlcjE3OTY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1796864?v=4","gravatar_id":"","url":"https://api.github.com/users/mtsmfm","html_url":"https://github.com/mtsmfm","followers_url":"https://api.github.com/users/mtsmfm/followers","following_url":"https://api.github.com/users/mtsmfm/following{/other_user}","gists_url":"https://api.github.com/users/mtsmfm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtsmfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtsmfm/subscriptions","organizations_url":"https://api.github.com/users/mtsmfm/orgs","repos_url":"https://api.github.com/users/mtsmfm/repos","events_url":"https://api.github.com/users/mtsmfm/events{/privacy}","received_events_url":"https://api.github.com/users/mtsmfm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mtsmfm/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":true,"url":"https://api.github.com/repos/mtsmfm/apollo-client","forks_url":"https://api.github.com/repos/mtsmfm/apollo-client/forks","keys_url":"https://api.github.com/repos/mtsmfm/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtsmfm/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtsmfm/apollo-client/teams","hooks_url":"https://api.github.com/repos/mtsmfm/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/mtsmfm/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/mtsmfm/apollo-client/events","assignees_url":"https://api.github.com/repos/mtsmfm/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/mtsmfm/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/mtsmfm/apollo-client/tags","blobs_url":"https://api.github.com/repos/mtsmfm/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtsmfm/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtsmfm/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtsmfm/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtsmfm/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mtsmfm/apollo-client/languages","stargazers_url":"https://api.github.com/repos/mtsmfm/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/mtsmfm/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/mtsmfm/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/mtsmfm/apollo-client/subscription","commits_url":"https://api.github.com/repos/mtsmfm/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtsmfm/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtsmfm/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtsmfm/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtsmfm/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/mtsmfm/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtsmfm/apollo-client/merges","archive_url":"https://api.github.com/repos/mtsmfm/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtsmfm/apollo-client/downloads","issues_url":"https://api.github.com/repos/mtsmfm/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/mtsmfm/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mtsmfm/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mtsmfm/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtsmfm/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/mtsmfm/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/mtsmfm/apollo-client/deployments","created_at":"2018-08-25T14:32:26Z","updated_at":"2018-08-25T14:32:29Z","pushed_at":"2018-11-16T19:15:52Z","git_url":"git://github.com/mtsmfm/apollo-client.git","ssh_url":"git@github.com:mtsmfm/apollo-client.git","clone_url":"https://github.com/mtsmfm/apollo-client.git","svn_url":"https://github.com/mtsmfm/apollo-client","homepage":"https://www.apollographql.com/client/","size":11877,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"830019683600f7a0c74b312b03a54c2a40c75c1f","user":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYzMDYxNg==","name":"apollo-client","full_name":"apollographql/apollo-client","private":false,"owner":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2018-11-16T19:04:23Z","pushed_at":"2018-11-16T19:19:46Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"https://www.apollographql.com/client/","size":12488,"stargazers_count":9131,"watchers_count":9131,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1036,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1036,"open_issues":220,"watchers":9131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/4033"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4033"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4033/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4033/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-client/statuses/62e250ca3d8742a061166ef688d078bf908f3161"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"benjamn"}}