{"action":"created","comment":{"url":"https://api.github.com/repos/roboll/helmfile/pulls/comments/218836009","pull_request_review_id":156862319,"id":218836009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODgzNjAwOQ==","diff_hunk":"@@ -15,10 +15,15 @@ type Runner interface {\n }\n \n // ShellRunner implemention for shell commands\n-type ShellRunner struct{}\n+type ShellRunner struct {\n+\tDir string\n+}\n \n // Execute a shell command\n func (shell ShellRunner) Execute(cmd string, args []string) ([]byte, error) {\n \tpreparedCmd := exec.Command(cmd, args...)\n+\tif shell.Dir != \"\" {\n+\t\tpreparedCmd.Dir = shell.Dir\n+\t}\n \treturn preparedCmd.CombinedOutput()","path":"helmexec/runner.go","position":15,"original_position":15,"commit_id":"88860385a3abadfb9b5967149a8d0688cdc54520","original_commit_id":"f6a95767d2e86dc43da90aa42c3a433d83e678bf","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"a possible usecase! however helmfile as of today emits too verbose logs, that only differentiating stdout/err here does't make sense. good for another issue though","created_at":"2018-09-19T14:50:37Z","updated_at":"2018-09-19T14:50:37Z","html_url":"https://github.com/roboll/helmfile/pull/349#discussion_r218836009","pull_request_url":"https://api.github.com/repos/roboll/helmfile/pulls/349","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/comments/218836009"},"html":{"href":"https://github.com/roboll/helmfile/pull/349#discussion_r218836009"},"pull_request":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/349"}},"in_reply_to_id":218817355},"pull_request":{"url":"https://api.github.com/repos/roboll/helmfile/pulls/349","id":216578470,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTc4NDcw","html_url":"https://github.com/roboll/helmfile/pull/349","diff_url":"https://github.com/roboll/helmfile/pull/349.diff","patch_url":"https://github.com/roboll/helmfile/pull/349.patch","issue_url":"https://api.github.com/repos/roboll/helmfile/issues/349","number":349,"state":"open","locked":false,"title":"feat: `prepare` and `cleanup` release event hooks","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"Resolves #295\r\nResolves #330\r\nResolves #329 (Supports templating of only `releases[].hooks[].command` and `args` right now\r\nResolves #324","created_at":"2018-09-19T09:50:54Z","updated_at":"2018-09-19T14:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06bab3cb9cbb54e15eec71284fad5420c4af6cb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/roboll/helmfile/pulls/349/commits","review_comments_url":"https://api.github.com/repos/roboll/helmfile/pulls/349/comments","review_comment_url":"https://api.github.com/repos/roboll/helmfile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roboll/helmfile/issues/349/comments","statuses_url":"https://api.github.com/repos/roboll/helmfile/statuses/88860385a3abadfb9b5967149a8d0688cdc54520","head":{"label":"mumoshu:prepare-cleanup-release-evt-hooks","ref":"prepare-cleanup-release-evt-hooks","sha":"88860385a3abadfb9b5967149a8d0688cdc54520","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"repo":{"id":123087387,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwODczODc=","name":"helmfile","full_name":"mumoshu/helmfile","private":false,"owner":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mumoshu/helmfile","description":"Deploy Kubernetes Helm Charts","fork":true,"url":"https://api.github.com/repos/mumoshu/helmfile","forks_url":"https://api.github.com/repos/mumoshu/helmfile/forks","keys_url":"https://api.github.com/repos/mumoshu/helmfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumoshu/helmfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumoshu/helmfile/teams","hooks_url":"https://api.github.com/repos/mumoshu/helmfile/hooks","issue_events_url":"https://api.github.com/repos/mumoshu/helmfile/issues/events{/number}","events_url":"https://api.github.com/repos/mumoshu/helmfile/events","assignees_url":"https://api.github.com/repos/mumoshu/helmfile/assignees{/user}","branches_url":"https://api.github.com/repos/mumoshu/helmfile/branches{/branch}","tags_url":"https://api.github.com/repos/mumoshu/helmfile/tags","blobs_url":"https://api.github.com/repos/mumoshu/helmfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumoshu/helmfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumoshu/helmfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumoshu/helmfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumoshu/helmfile/statuses/{sha}","languages_url":"https://api.github.com/repos/mumoshu/helmfile/languages","stargazers_url":"https://api.github.com/repos/mumoshu/helmfile/stargazers","contributors_url":"https://api.github.com/repos/mumoshu/helmfile/contributors","subscribers_url":"https://api.github.com/repos/mumoshu/helmfile/subscribers","subscription_url":"https://api.github.com/repos/mumoshu/helmfile/subscription","commits_url":"https://api.github.com/repos/mumoshu/helmfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumoshu/helmfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumoshu/helmfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumoshu/helmfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mumoshu/helmfile/contents/{+path}","compare_url":"https://api.github.com/repos/mumoshu/helmfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumoshu/helmfile/merges","archive_url":"https://api.github.com/repos/mumoshu/helmfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumoshu/helmfile/downloads","issues_url":"https://api.github.com/repos/mumoshu/helmfile/issues{/number}","pulls_url":"https://api.github.com/repos/mumoshu/helmfile/pulls{/number}","milestones_url":"https://api.github.com/repos/mumoshu/helmfile/milestones{/number}","notifications_url":"https://api.github.com/repos/mumoshu/helmfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumoshu/helmfile/labels{/name}","releases_url":"https://api.github.com/repos/mumoshu/helmfile/releases{/id}","deployments_url":"https://api.github.com/repos/mumoshu/helmfile/deployments","created_at":"2018-02-27T07:00:56Z","updated_at":"2018-04-09T11:24:59Z","pushed_at":"2018-09-19T14:07:40Z","git_url":"git://github.com/mumoshu/helmfile.git","ssh_url":"git@github.com:mumoshu/helmfile.git","clone_url":"https://github.com/mumoshu/helmfile.git","svn_url":"https://github.com/mumoshu/helmfile","homepage":"","size":688,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roboll:master","ref":"master","sha":"98088499867ed4deab4430e2cdae4776336236e3","user":{"login":"roboll","id":1259631,"node_id":"MDQ6VXNlcjEyNTk2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1259631?v=4","gravatar_id":"","url":"https://api.github.com/users/roboll","html_url":"https://github.com/roboll","followers_url":"https://api.github.com/users/roboll/followers","following_url":"https://api.github.com/users/roboll/following{/other_user}","gists_url":"https://api.github.com/users/roboll/gists{/gist_id}","starred_url":"https://api.github.com/users/roboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboll/subscriptions","organizations_url":"https://api.github.com/users/roboll/orgs","repos_url":"https://api.github.com/users/roboll/repos","events_url":"https://api.github.com/users/roboll/events{/privacy}","received_events_url":"https://api.github.com/users/roboll/received_events","type":"User","site_admin":false},"repo":{"id":74499101,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQ5OTEwMQ==","name":"helmfile","full_name":"roboll/helmfile","private":false,"owner":{"login":"roboll","id":1259631,"node_id":"MDQ6VXNlcjEyNTk2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1259631?v=4","gravatar_id":"","url":"https://api.github.com/users/roboll","html_url":"https://github.com/roboll","followers_url":"https://api.github.com/users/roboll/followers","following_url":"https://api.github.com/users/roboll/following{/other_user}","gists_url":"https://api.github.com/users/roboll/gists{/gist_id}","starred_url":"https://api.github.com/users/roboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboll/subscriptions","organizations_url":"https://api.github.com/users/roboll/orgs","repos_url":"https://api.github.com/users/roboll/repos","events_url":"https://api.github.com/users/roboll/events{/privacy}","received_events_url":"https://api.github.com/users/roboll/received_events","type":"User","site_admin":false},"html_url":"https://github.com/roboll/helmfile","description":"Deploy Kubernetes Helm Charts","fork":false,"url":"https://api.github.com/repos/roboll/helmfile","forks_url":"https://api.github.com/repos/roboll/helmfile/forks","keys_url":"https://api.github.com/repos/roboll/helmfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roboll/helmfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roboll/helmfile/teams","hooks_url":"https://api.github.com/repos/roboll/helmfile/hooks","issue_events_url":"https://api.github.com/repos/roboll/helmfile/issues/events{/number}","events_url":"https://api.github.com/repos/roboll/helmfile/events","assignees_url":"https://api.github.com/repos/roboll/helmfile/assignees{/user}","branches_url":"https://api.github.com/repos/roboll/helmfile/branches{/branch}","tags_url":"https://api.github.com/repos/roboll/helmfile/tags","blobs_url":"https://api.github.com/repos/roboll/helmfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roboll/helmfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roboll/helmfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/roboll/helmfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roboll/helmfile/statuses/{sha}","languages_url":"https://api.github.com/repos/roboll/helmfile/languages","stargazers_url":"https://api.github.com/repos/roboll/helmfile/stargazers","contributors_url":"https://api.github.com/repos/roboll/helmfile/contributors","subscribers_url":"https://api.github.com/repos/roboll/helmfile/subscribers","subscription_url":"https://api.github.com/repos/roboll/helmfile/subscription","commits_url":"https://api.github.com/repos/roboll/helmfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/roboll/helmfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/roboll/helmfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/roboll/helmfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/roboll/helmfile/contents/{+path}","compare_url":"https://api.github.com/repos/roboll/helmfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roboll/helmfile/merges","archive_url":"https://api.github.com/repos/roboll/helmfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roboll/helmfile/downloads","issues_url":"https://api.github.com/repos/roboll/helmfile/issues{/number}","pulls_url":"https://api.github.com/repos/roboll/helmfile/pulls{/number}","milestones_url":"https://api.github.com/repos/roboll/helmfile/milestones{/number}","notifications_url":"https://api.github.com/repos/roboll/helmfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roboll/helmfile/labels{/name}","releases_url":"https://api.github.com/repos/roboll/helmfile/releases{/id}","deployments_url":"https://api.github.com/repos/roboll/helmfile/deployments","created_at":"2016-11-22T17:52:16Z","updated_at":"2018-09-19T13:23:19Z","pushed_at":"2018-09-19T14:07:42Z","git_url":"git://github.com/roboll/helmfile.git","ssh_url":"git@github.com:roboll/helmfile.git","clone_url":"https://github.com/roboll/helmfile.git","svn_url":"https://github.com/roboll/helmfile","homepage":"","size":677,"stargazers_count":498,"watchers_count":498,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":47,"watchers":498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/349"},"html":{"href":"https://github.com/roboll/helmfile/pull/349"},"issue":{"href":"https://api.github.com/repos/roboll/helmfile/issues/349"},"comments":{"href":"https://api.github.com/repos/roboll/helmfile/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roboll/helmfile/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/roboll/helmfile/statuses/88860385a3abadfb9b5967149a8d0688cdc54520"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mumoshu"}}