{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/234907107","pull_request_review_id":176647519,"id":234907107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDkwNzEwNw==","diff_hunk":"@@ -189,7 +189,11 @@ BuildRequires:\tpython%{_python_buildid}-nose\n BuildRequires:\tpython%{_python_buildid}-pecan\n BuildRequires:\tpython%{_python_buildid}-requests\n BuildRequires:\tpython%{_python_buildid}-six\n+%if 0%{?fedora} >= 29\n+BuildRequires:\tpython3-tox","path":"ceph.spec.in","position":5,"original_position":5,"commit_id":"2d62a05b7b57c8dfb8eaaf3356ba122ebf5f6496","original_commit_id":"2d62a05b7b57c8dfb8eaaf3356ba122ebf5f6496","user":{"login":"badone","id":1331115,"node_id":"MDQ6VXNlcjEzMzExMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1331115?v=4","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"body":"I could create a special case in munge_ceph_spec_in for f29?","created_at":"2018-11-20T08:31:46Z","updated_at":"2018-11-20T08:31:46Z","html_url":"https://github.com/ceph/ceph/pull/25168#discussion_r234907107","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25168","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/234907107"},"html":{"href":"https://github.com/ceph/ceph/pull/25168#discussion_r234907107"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25168"}},"in_reply_to_id":234872329},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25168","id":232188755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTg4NzU1","html_url":"https://github.com/ceph/ceph/pull/25168","diff_url":"https://github.com/ceph/ceph/pull/25168.diff","patch_url":"https://github.com/ceph/ceph/pull/25168.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25168","number":25168,"state":"open","locked":false,"title":"rpm: Install python3-tox on >= fedora 29","user":{"login":"badone","id":1331115,"node_id":"MDQ6VXNlcjEzMzExMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1331115?v=4","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"body":"Fix the error \"No matching package to install: 'python-tox'\"\r\n\r\nFixes: http://tracker.ceph.com/issues/37301\r\n\r\nSigned-off-by: Brad Hubbard <bhubbard@redhat.com>\r\n\r\n\r\n<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [x] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-11-20T04:27:04Z","updated_at":"2018-11-20T08:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f0f9b7391ba08b5ea5714323363f8900afcdf62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ktdreyer","id":620295,"node_id":"MDQ6VXNlcjYyMDI5NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/620295?v=4","gravatar_id":"","url":"https://api.github.com/users/ktdreyer","html_url":"https://github.com/ktdreyer","followers_url":"https://api.github.com/users/ktdreyer/followers","following_url":"https://api.github.com/users/ktdreyer/following{/other_user}","gists_url":"https://api.github.com/users/ktdreyer/gists{/gist_id}","starred_url":"https://api.github.com/users/ktdreyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktdreyer/subscriptions","organizations_url":"https://api.github.com/users/ktdreyer/orgs","repos_url":"https://api.github.com/users/ktdreyer/repos","events_url":"https://api.github.com/users/ktdreyer/events{/privacy}","received_events_url":"https://api.github.com/users/ktdreyer/received_events","type":"User","site_admin":false},{"login":"smithfarm","id":3974844,"node_id":"MDQ6VXNlcjM5NzQ4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3974844?v=4","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":199293022,"node_id":"MDU6TGFiZWwxOTkyOTMwMjI=","url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"fcff00","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25168/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25168/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25168/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/2d62a05b7b57c8dfb8eaaf3356ba122ebf5f6496","head":{"label":"badone:wip-python3-tox-install","ref":"wip-python3-tox-install","sha":"2d62a05b7b57c8dfb8eaaf3356ba122ebf5f6496","user":{"login":"badone","id":1331115,"node_id":"MDQ6VXNlcjEzMzExMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1331115?v=4","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"repo":{"id":40397338,"node_id":"MDEwOlJlcG9zaXRvcnk0MDM5NzMzOA==","name":"ceph","full_name":"badone/ceph","private":false,"owner":{"login":"badone","id":1331115,"node_id":"MDQ6VXNlcjEzMzExMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1331115?v=4","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"html_url":"https://github.com/badone/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/badone/ceph","forks_url":"https://api.github.com/repos/badone/ceph/forks","keys_url":"https://api.github.com/repos/badone/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badone/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badone/ceph/teams","hooks_url":"https://api.github.com/repos/badone/ceph/hooks","issue_events_url":"https://api.github.com/repos/badone/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/badone/ceph/events","assignees_url":"https://api.github.com/repos/badone/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/badone/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/badone/ceph/tags","blobs_url":"https://api.github.com/repos/badone/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badone/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badone/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/badone/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badone/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/badone/ceph/languages","stargazers_url":"https://api.github.com/repos/badone/ceph/stargazers","contributors_url":"https://api.github.com/repos/badone/ceph/contributors","subscribers_url":"https://api.github.com/repos/badone/ceph/subscribers","subscription_url":"https://api.github.com/repos/badone/ceph/subscription","commits_url":"https://api.github.com/repos/badone/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/badone/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/badone/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/badone/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/badone/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/badone/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badone/ceph/merges","archive_url":"https://api.github.com/repos/badone/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badone/ceph/downloads","issues_url":"https://api.github.com/repos/badone/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/badone/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/badone/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/badone/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badone/ceph/labels{/name}","releases_url":"https://api.github.com/repos/badone/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/badone/ceph/deployments","created_at":"2015-08-08T08:57:09Z","updated_at":"2017-11-09T00:10:47Z","pushed_at":"2018-11-20T04:48:12Z","git_url":"git://github.com/badone/ceph.git","ssh_url":"git@github.com:badone/ceph.git","clone_url":"https://github.com/badone/ceph.git","svn_url":"https://github.com/badone/ceph","homepage":"http://ceph.com","size":341484,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"38e95b2d8a40df264ea685ad528f89c78e01da0c","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-11-20T07:56:43Z","pushed_at":"2018-11-20T08:21:45Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":333647,"stargazers_count":5289,"watchers_count":5289,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2790,"mirror_url":null,"archived":false,"open_issues_count":638,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2790,"open_issues":638,"watchers":5289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25168"},"html":{"href":"https://github.com/ceph/ceph/pull/25168"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25168"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25168/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25168/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25168/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/2d62a05b7b57c8dfb8eaaf3356ba122ebf5f6496"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"badone"}}