{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14358","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14358/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14358/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14358/events","html_url":"https://github.com/bitcoin/bitcoin/pull/14358","id":365234123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjEwNjUz","number":14358,"title":"[logs] Fix a few log messages related to duration measurement","user":{"login":"romanz","id":9900,"node_id":"MDQ6VXNlcjk5MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9900?v=4","gravatar_id":"","url":"https://api.github.com/users/romanz","html_url":"https://github.com/romanz","followers_url":"https://api.github.com/users/romanz/followers","following_url":"https://api.github.com/users/romanz/following{/other_user}","gists_url":"https://api.github.com/users/romanz/gists{/gist_id}","starred_url":"https://api.github.com/users/romanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanz/subscriptions","organizations_url":"https://api.github.com/users/romanz/orgs","repos_url":"https://api.github.com/users/romanz/repos","events_url":"https://api.github.com/users/romanz/events{/privacy}","received_events_url":"https://api.github.com/users/romanz/received_events","type":"User","site_admin":false},"labels":[{"id":241832923,"node_id":"MDU6TGFiZWwyNDE4MzI5MjM=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils/log/libs","name":"Utils/log/libs","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-30T15:33:14Z","updated_at":"2018-10-05T07:53:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14358","html_url":"https://github.com/bitcoin/bitcoin/pull/14358","diff_url":"https://github.com/bitcoin/bitcoin/pull/14358.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14358.patch"},"body":"- Remove fixed-width formatting for the duration value (`%15d` -> `%d`), for better consistency with other [similar](https://github.com/bitcoin/bitcoin/search?q=dms&unscoped_q=dms) logging statements.\r\n- Correct the logging statement that starts with a space (`\" block index %15dms\\n\"`) to start with a verb. \r\n- Add `\" in \"` between the operation description and the millisecond duration."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/427277835","html_url":"https://github.com/bitcoin/bitcoin/pull/14358#issuecomment-427277835","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14358","id":427277835,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzI3NzgzNQ==","user":{"login":"romanz","id":9900,"node_id":"MDQ6VXNlcjk5MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9900?v=4","gravatar_id":"","url":"https://api.github.com/users/romanz","html_url":"https://github.com/romanz","followers_url":"https://api.github.com/users/romanz/followers","following_url":"https://api.github.com/users/romanz/following{/other_user}","gists_url":"https://api.github.com/users/romanz/gists{/gist_id}","starred_url":"https://api.github.com/users/romanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanz/subscriptions","organizations_url":"https://api.github.com/users/romanz/orgs","repos_url":"https://api.github.com/users/romanz/repos","events_url":"https://api.github.com/users/romanz/events{/privacy}","received_events_url":"https://api.github.com/users/romanz/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T07:53:23Z","updated_at":"2018-10-05T07:53:23Z","author_association":"CONTRIBUTOR","body":"I have updated (most) the benchmarking-related code in this PR to be consistent with the format used at [src/validation.cpp](https://github.com/bitcoin/bitcoin/blob/1e8f88e071019907785b260477bd359bef6f9a8f/src/validation.cpp#L2312), except the code at [src/wallet/wallet.cpp](https://github.com/bitcoin/bitcoin/pull/14358/files#diff-b2bb174788c7409b671c46ccc86034bd) (since it uses [CWallet::WalletLogPrintf()](https://github.com/bitcoin/bitcoin/blob/7990bb5b61cb343e47a0333dfc0dd9f0cd4ae5a8/src/wallet/wallet.h#L1123))."}}
{"actor":{"display_login":"romanz"}}