{"action":"created","issue":{"url":"https://api.github.com/repos/rchain/rchain/issues/945","repository_url":"https://api.github.com/repos/rchain/rchain","labels_url":"https://api.github.com/repos/rchain/rchain/issues/945/labels{/name}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/945/comments","events_url":"https://api.github.com/repos/rchain/rchain/issues/945/events","html_url":"https://github.com/rchain/rchain/pull/945","id":331571556,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjY3NTM4","number":945,"title":"Refactor history package","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-12T12:44:57Z","updated_at":"2018-06-12T12:58:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/945","html_url":"https://github.com/rchain/rchain/pull/945","diff_url":"https://github.com/rchain/rchain/pull/945.diff","patch_url":"https://github.com/rchain/rchain/pull/945.patch"},"body":"## Overview\r\nRefactor history package\r\n\r\n* Change methods' arguments and return types from Node to more general Trie[K,V]\r\nThis will be needed when introducing a new element 'Skip' to our Trie\r\nADT\r\n* Refactor getParents - create inner recursive method which doesn't\r\n  take invariants as parameters\r\n\r\n### Does this PR relate to an RChain JIRA issue? \r\nhttps://rchain.atlassian.net/browse/CORE-596\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [ ] You have someone in mind to assign for review. Make this assignment after submitting the PR.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n"},"comment":{"url":"https://api.github.com/repos/rchain/rchain/issues/comments/396579921","html_url":"https://github.com/rchain/rchain/pull/945#issuecomment-396579921","issue_url":"https://api.github.com/repos/rchain/rchain/issues/945","id":396579921,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjU3OTkyMQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-12T12:58:28Z","updated_at":"2018-06-12T12:58:28Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=h1) Report\n> Merging [#945](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=desc) into [dev](https://codecov.io/gh/rchain/rchain/commit/327ead48e0dee02f0ce101dad391f51f8b66193e?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `90%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/rchain/rchain/pull/945/graphs/tree.svg?height=150&width=650&token=MnvcTlDgD0&src=pr)](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##              dev     #945      +/-   ##\n==========================================\n+ Coverage   57.89%   57.89%   +<.01%     \n==========================================\n  Files         123      123              \n  Lines        4854     4852       -2     \n  Branches      311      311              \n==========================================\n- Hits         2810     2809       -1     \n+ Misses       2044     2043       -1\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #casper | `87.8% <ø> (ø)` | :arrow_up: |\n| #comm | `28.89% <ø> (ø)` | :arrow_up: |\n| #crypto | `97.36% <ø> (ø)` | :arrow_up: |\n| #node | `0% <ø> (ø)` | :arrow_up: |\n| #rholang | `70.19% <ø> (ø)` | :arrow_up: |\n| #roscala | `60.07% <ø> (ø)` | :arrow_up: |\n| #rspace | `81.29% <90%> (+0.09%)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...ain/scala/coop/rchain/rspace/history/package.scala](https://codecov.io/gh/rchain/rchain/pull/945/diff?src=pr&el=tree#diff-cnNwYWNlL3NyYy9tYWluL3NjYWxhL2Nvb3AvcmNoYWluL3JzcGFjZS9oaXN0b3J5L3BhY2thZ2Uuc2NhbGE=) | `91.89% <90%> (+0.74%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=footer). Last update [327ead4...f735195](https://codecov.io/gh/rchain/rchain/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}