{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/462","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/462/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/462/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/462/events","html_url":"https://github.com/stripe/veneur/pull/462","id":316984148,"number":462,"title":"Fix hardcoded, accidental status failure in DD SC sink","user":{"login":"cory-stripe","id":23101296,"avatar_url":"https://avatars3.githubusercontent.com/u/23101296?v=4","gravatar_id":"","url":"https://api.github.com/users/cory-stripe","html_url":"https://github.com/cory-stripe","followers_url":"https://api.github.com/users/cory-stripe/followers","following_url":"https://api.github.com/users/cory-stripe/following{/other_user}","gists_url":"https://api.github.com/users/cory-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/cory-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cory-stripe/subscriptions","organizations_url":"https://api.github.com/users/cory-stripe/orgs","repos_url":"https://api.github.com/users/cory-stripe/repos","events_url":"https://api.github.com/users/cory-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/cory-stripe/received_events","type":"User","site_admin":false},"labels":[{"id":379316375,"url":"https://api.github.com/repos/stripe/veneur/labels/approved","name":"approved","color":"2DA239","default":false}],"state":"open","locked":false,"assignee":{"login":"cory-stripe","id":23101296,"avatar_url":"https://avatars3.githubusercontent.com/u/23101296?v=4","gravatar_id":"","url":"https://api.github.com/users/cory-stripe","html_url":"https://github.com/cory-stripe","followers_url":"https://api.github.com/users/cory-stripe/followers","following_url":"https://api.github.com/users/cory-stripe/following{/other_user}","gists_url":"https://api.github.com/users/cory-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/cory-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cory-stripe/subscriptions","organizations_url":"https://api.github.com/users/cory-stripe/orgs","repos_url":"https://api.github.com/users/cory-stripe/repos","events_url":"https://api.github.com/users/cory-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/cory-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"cory-stripe","id":23101296,"avatar_url":"https://avatars3.githubusercontent.com/u/23101296?v=4","gravatar_id":"","url":"https://api.github.com/users/cory-stripe","html_url":"https://github.com/cory-stripe","followers_url":"https://api.github.com/users/cory-stripe/followers","following_url":"https://api.github.com/users/cory-stripe/following{/other_user}","gists_url":"https://api.github.com/users/cory-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/cory-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cory-stripe/subscriptions","organizations_url":"https://api.github.com/users/cory-stripe/orgs","repos_url":"https://api.github.com/users/cory-stripe/repos","events_url":"https://api.github.com/users/cory-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/cory-stripe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-23T21:09:36Z","updated_at":"2018-04-24T14:09:19Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/462","html_url":"https://github.com/stripe/veneur/pull/462","diff_url":"https://github.com/stripe/veneur/pull/462.diff","patch_url":"https://github.com/stripe/veneur/pull/462.patch"},"body":"#### Summary\r\nFix leftover `TODO` wondering how to set the status to an integer.\r\n\r\n#### Motivation\r\nWhen I wrote this code I left this in here and we never noticed it. Service checks going into veneur have been set to `0` which is `OK`, meaning they never looked broken. Oops.\r\n\r\n#### Test plan\r\nChanged unit test to use a non-default value.\r\n\r\nr? @stripe/observability \r\ncc @evan-stripe \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/383945327","html_url":"https://github.com/stripe/veneur/pull/462#issuecomment-383945327","issue_url":"https://api.github.com/repos/stripe/veneur/issues/462","id":383945327,"user":{"login":"cory-stripe","id":23101296,"avatar_url":"https://avatars3.githubusercontent.com/u/23101296?v=4","gravatar_id":"","url":"https://api.github.com/users/cory-stripe","html_url":"https://github.com/cory-stripe","followers_url":"https://api.github.com/users/cory-stripe/followers","following_url":"https://api.github.com/users/cory-stripe/following{/other_user}","gists_url":"https://api.github.com/users/cory-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/cory-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cory-stripe/subscriptions","organizations_url":"https://api.github.com/users/cory-stripe/orgs","repos_url":"https://api.github.com/users/cory-stripe/repos","events_url":"https://api.github.com/users/cory-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/cory-stripe/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T14:09:19Z","updated_at":"2018-04-24T14:09:19Z","author_association":"COLLABORATOR","body":"Reapproving post-rebase."}}
{"actor":{"display_login":"cory-stripe"}}