{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/211852333","pull_request_review_id":148359286,"id":211852333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTg1MjMzMw==","diff_hunk":"@@ -118,6 +119,32 @@ class NetworkPacket\n \tNetworkPacket &operator>>(video::SColor &dst);\n \tNetworkPacket &operator<<(video::SColor src);\n \n+\ttemplate<typename T> NetworkPacket &operator >> (std::vector<T> &dst)\n+\t{\n+\t\tu16 count;","path":"src/network/networkpacket.h","position":14,"original_position":14,"commit_id":"3f1711d54fc559092b3957fd1a2a476a815d26b4","original_commit_id":"3f1711d54fc559092b3957fd1a2a476a815d26b4","user":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"C99 ensures that `size_t` must be at least a `u16`.\r\nhttp://irc.minetest.net/minetest-dev/2018-08-21#i_5382824","created_at":"2018-08-22T07:25:51Z","updated_at":"2018-08-22T07:25:51Z","html_url":"https://github.com/minetest/minetest/pull/7657#discussion_r211852333","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7657","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/211852333"},"html":{"href":"https://github.com/minetest/minetest/pull/7657#discussion_r211852333"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7657"}},"in_reply_to_id":211644964},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7657","id":209348714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzQ4NzE0","html_url":"https://github.com/minetest/minetest/pull/7657","diff_url":"https://github.com/minetest/minetest/pull/7657.diff","patch_url":"https://github.com/minetest/minetest/pull/7657.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7657","number":7657,"state":"open","locked":false,"title":"Load translations after media download, add fallback translations","user":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"~`gettext(\"LANG_CODE\")` returned an empty string, so this PR will now use the `setlocale` output which does not seem to follow any C standard. If you find something more reliable, please add a comment.~\r\nNote to myself: Update the `locale` directory next time when working with gettext.\r\n\r\n**What this PR does**\r\n * ~Now detects the language correctly in most cases~\r\n * `.en.tr` as fallback for mods which aren't translated entirely (or in another language)\r\n * Language loading priorities, first `en`, then `pt` and `pt_BR` for the final overwrite if such translations were found. This language priority list may be extended to 255 entries for a custom fallback order\r\n * Improved documentation\r\n\r\n**Testing**\r\n[Here's](https://github.com/SmallJoker/upgrade_packs) a rather simple mod with a few translated strings. Copy&paste the files (or rename) for your language code.\r\n\r\n\r\nImplements #7171\r\nReplaces PR #7182 ","created_at":"2018-08-19T08:17:45Z","updated_at":"2018-08-22T07:25:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4e2ada02b7077e73d97fc82ce397c3361c32d69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":128009404,"node_id":"MDU6TGFiZWwxMjgwMDk0MDQ=","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Translation","name":"@ Translation","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7657/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7657/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7657/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/3f1711d54fc559092b3957fd1a2a476a815d26b4","head":{"label":"SmallJoker:fallback_language","ref":"fallback_language","sha":"3f1711d54fc559092b3957fd1a2a476a815d26b4","user":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"repo":{"id":44455467,"node_id":"MDEwOlJlcG9zaXRvcnk0NDQ1NTQ2Nw==","name":"minetest","full_name":"SmallJoker/minetest","owner":{"login":"SmallJoker","id":1497498,"node_id":"MDQ6VXNlcjE0OTc0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SmallJoker/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/SmallJoker/minetest","forks_url":"https://api.github.com/repos/SmallJoker/minetest/forks","keys_url":"https://api.github.com/repos/SmallJoker/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmallJoker/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmallJoker/minetest/teams","hooks_url":"https://api.github.com/repos/SmallJoker/minetest/hooks","issue_events_url":"https://api.github.com/repos/SmallJoker/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/SmallJoker/minetest/events","assignees_url":"https://api.github.com/repos/SmallJoker/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/SmallJoker/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/SmallJoker/minetest/tags","blobs_url":"https://api.github.com/repos/SmallJoker/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmallJoker/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmallJoker/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmallJoker/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmallJoker/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/SmallJoker/minetest/languages","stargazers_url":"https://api.github.com/repos/SmallJoker/minetest/stargazers","contributors_url":"https://api.github.com/repos/SmallJoker/minetest/contributors","subscribers_url":"https://api.github.com/repos/SmallJoker/minetest/subscribers","subscription_url":"https://api.github.com/repos/SmallJoker/minetest/subscription","commits_url":"https://api.github.com/repos/SmallJoker/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmallJoker/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmallJoker/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmallJoker/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmallJoker/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/SmallJoker/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmallJoker/minetest/merges","archive_url":"https://api.github.com/repos/SmallJoker/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmallJoker/minetest/downloads","issues_url":"https://api.github.com/repos/SmallJoker/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/SmallJoker/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/SmallJoker/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/SmallJoker/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmallJoker/minetest/labels{/name}","releases_url":"https://api.github.com/repos/SmallJoker/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/SmallJoker/minetest/deployments","created_at":"2015-10-17T21:33:55Z","updated_at":"2016-06-15T16:09:34Z","pushed_at":"2018-08-21T13:59:09Z","git_url":"git://github.com/SmallJoker/minetest.git","ssh_url":"git@github.com:SmallJoker/minetest.git","clone_url":"https://github.com/SmallJoker/minetest.git","svn_url":"https://github.com/SmallJoker/minetest","homepage":"http://minetest.net/","size":58961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"1ec5028e5a0eeedb90993a430b0e9bbf3bfd14d2","user":{"login":"minetest","id":2624745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjQ3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY4Nzgw","name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjQ3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine with support for survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-08-21T14:46:07Z","pushed_at":"2018-08-21T21:36:16Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":58974,"stargazers_count":3395,"watchers_count":3395,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":932,"mirror_url":null,"archived":false,"open_issues_count":879,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":932,"open_issues":879,"watchers":3395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7657"},"html":{"href":"https://github.com/minetest/minetest/pull/7657"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7657"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7657/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7657/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7657/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/3f1711d54fc559092b3957fd1a2a476a815d26b4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SmallJoker"}}