{"action":"created","comment":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments/235946358","pull_request_review_id":177933848,"id":235946358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk0NjM1OA==","diff_hunk":"@@ -358,7 +358,12 @@ export class StarkSessionServiceImpl implements StarkSessionService {\n \t\t\tthis._devAuthenticationHeaders = new Map<string, string>();\n \t\t}\n \n-\t\tdevAuthenticationHeaders.forEach((value: string, key: string) => this._devAuthenticationHeaders.set(key, value));\n+\t\tdevAuthenticationHeaders.forEach((value: string, key: string) => {","path":"packages/stark-core/src/modules/session/services/session.service.ts","position":5,"original_position":5,"commit_id":"2c1c826fbb64bbcf4fd86e3ef4e1688bc054ea22","original_commit_id":"2c1c826fbb64bbcf4fd86e3ef4e1688bc054ea22","user":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"body":"Indeed, I'll fix this","created_at":"2018-11-23T13:51:49Z","updated_at":"2018-11-23T13:51:50Z","html_url":"https://github.com/NationalBankBelgium/stark/pull/881#discussion_r235946358","pull_request_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments/235946358"},"html":{"href":"https://github.com/NationalBankBelgium/stark/pull/881#discussion_r235946358"},"pull_request":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881"}},"in_reply_to_id":235916960},"pull_request":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881","id":233138443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTM4NDQz","html_url":"https://github.com/NationalBankBelgium/stark/pull/881","diff_url":"https://github.com/NationalBankBelgium/stark/pull/881.diff","patch_url":"https://github.com/NationalBankBelgium/stark/pull/881.patch","issue_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/881","number":881,"state":"open","locked":false,"title":"fix(stark-core): refactor Http headers related API to prevent undefined and null header values to be added to Angular Http headers","user":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"body":"ISSUES CLOSED: #856\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[X] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: #856\r\n\r\n\r\n## What is the new behavior?\r\nThe correlationId Http header is not added in case the correlation id is not defined (which is the case when the `loggingFlushDisabled` is true).\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[X] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->","created_at":"2018-11-23T09:06:35Z","updated_at":"2018-11-23T13:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4713b99d4420a1931b9a86484dcb393ff13438f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":851283123,"node_id":"MDU6TGFiZWw4NTEyODMxMjM=","url":"https://api.github.com/repos/NationalBankBelgium/stark/labels/comp:%20stark-core","name":"comp: stark-core","color":"1d76db","default":false},{"id":705501430,"node_id":"MDU6TGFiZWw3MDU1MDE0MzA=","url":"https://api.github.com/repos/NationalBankBelgium/stark/labels/type:%20bug","name":"type: bug","color":"ee0701","default":false},{"id":705501432,"node_id":"MDU6TGFiZWw3MDU1MDE0MzI=","url":"https://api.github.com/repos/NationalBankBelgium/stark/labels/type:%20enhancement","name":"type: enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/12","html_url":"https://github.com/NationalBankBelgium/stark/milestone/12","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/12/labels","id":3690742,"node_id":"MDk6TWlsZXN0b25lMzY5MDc0Mg==","number":12,"title":"10.0.0-beta.2","description":"","creator":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":20,"state":"open","created_at":"2018-09-26T15:27:49Z","updated_at":"2018-11-23T09:06:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881/commits","review_comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881/comments","review_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/881/comments","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/2c1c826fbb64bbcf4fd86e3ef4e1688bc054ea22","head":{"label":"christophercr:feature/fix-http-undefined-correlation-id","ref":"feature/fix-http-undefined-correlation-id","sha":"2c1c826fbb64bbcf4fd86e3ef4e1688bc054ea22","user":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"repo":{"id":121400392,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MDAzOTI=","name":"stark","full_name":"christophercr/stark","private":false,"owner":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/christophercr/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":true,"url":"https://api.github.com/repos/christophercr/stark","forks_url":"https://api.github.com/repos/christophercr/stark/forks","keys_url":"https://api.github.com/repos/christophercr/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christophercr/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christophercr/stark/teams","hooks_url":"https://api.github.com/repos/christophercr/stark/hooks","issue_events_url":"https://api.github.com/repos/christophercr/stark/issues/events{/number}","events_url":"https://api.github.com/repos/christophercr/stark/events","assignees_url":"https://api.github.com/repos/christophercr/stark/assignees{/user}","branches_url":"https://api.github.com/repos/christophercr/stark/branches{/branch}","tags_url":"https://api.github.com/repos/christophercr/stark/tags","blobs_url":"https://api.github.com/repos/christophercr/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christophercr/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christophercr/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/christophercr/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christophercr/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/christophercr/stark/languages","stargazers_url":"https://api.github.com/repos/christophercr/stark/stargazers","contributors_url":"https://api.github.com/repos/christophercr/stark/contributors","subscribers_url":"https://api.github.com/repos/christophercr/stark/subscribers","subscription_url":"https://api.github.com/repos/christophercr/stark/subscription","commits_url":"https://api.github.com/repos/christophercr/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/christophercr/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/christophercr/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/christophercr/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/christophercr/stark/contents/{+path}","compare_url":"https://api.github.com/repos/christophercr/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christophercr/stark/merges","archive_url":"https://api.github.com/repos/christophercr/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christophercr/stark/downloads","issues_url":"https://api.github.com/repos/christophercr/stark/issues{/number}","pulls_url":"https://api.github.com/repos/christophercr/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/christophercr/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/christophercr/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christophercr/stark/labels{/name}","releases_url":"https://api.github.com/repos/christophercr/stark/releases{/id}","deployments_url":"https://api.github.com/repos/christophercr/stark/deployments","created_at":"2018-02-13T15:38:02Z","updated_at":"2018-11-22T16:24:34Z","pushed_at":"2018-11-23T10:42:36Z","git_url":"git://github.com/christophercr/stark.git","ssh_url":"git@github.com:christophercr/stark.git","clone_url":"https://github.com/christophercr/stark.git","svn_url":"https://github.com/christophercr/stark","homepage":"","size":23830,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NationalBankBelgium:master","ref":"master","sha":"b84f8e5ef25ef2b31cca80f218f85419068c0594","user":{"login":"NationalBankBelgium","id":22069913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDY5OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"repo":{"id":105157749,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxNTc3NDk=","name":"stark","full_name":"NationalBankBelgium/stark","private":false,"owner":{"login":"NationalBankBelgium","id":22069913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDY5OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NationalBankBelgium/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":false,"url":"https://api.github.com/repos/NationalBankBelgium/stark","forks_url":"https://api.github.com/repos/NationalBankBelgium/stark/forks","keys_url":"https://api.github.com/repos/NationalBankBelgium/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalBankBelgium/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalBankBelgium/stark/teams","hooks_url":"https://api.github.com/repos/NationalBankBelgium/stark/hooks","issue_events_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/events{/number}","events_url":"https://api.github.com/repos/NationalBankBelgium/stark/events","assignees_url":"https://api.github.com/repos/NationalBankBelgium/stark/assignees{/user}","branches_url":"https://api.github.com/repos/NationalBankBelgium/stark/branches{/branch}","tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/tags","blobs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalBankBelgium/stark/languages","stargazers_url":"https://api.github.com/repos/NationalBankBelgium/stark/stargazers","contributors_url":"https://api.github.com/repos/NationalBankBelgium/stark/contributors","subscribers_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscribers","subscription_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscription","commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalBankBelgium/stark/contents/{+path}","compare_url":"https://api.github.com/repos/NationalBankBelgium/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalBankBelgium/stark/merges","archive_url":"https://api.github.com/repos/NationalBankBelgium/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalBankBelgium/stark/downloads","issues_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues{/number}","pulls_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalBankBelgium/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/labels{/name}","releases_url":"https://api.github.com/repos/NationalBankBelgium/stark/releases{/id}","deployments_url":"https://api.github.com/repos/NationalBankBelgium/stark/deployments","created_at":"2017-09-28T14:20:05Z","updated_at":"2018-11-22T15:12:46Z","pushed_at":"2018-11-23T12:01:40Z","git_url":"git://github.com/NationalBankBelgium/stark.git","ssh_url":"git@github.com:NationalBankBelgium/stark.git","clone_url":"https://github.com/NationalBankBelgium/stark.git","svn_url":"https://github.com/NationalBankBelgium/stark","homepage":"","size":45840,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":199,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881"},"html":{"href":"https://github.com/NationalBankBelgium/stark/pull/881"},"issue":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/881"},"comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/881/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/881/commits"},"statuses":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/2c1c826fbb64bbcf4fd86e3ef4e1688bc054ea22"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"christophercr"}}