{"action":"created","comment":{"url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/comments/178408937","pull_request_review_id":108469275,"id":178408937,"diff_hunk":"@@ -160,6 +177,66 @@ public synchronized void paintComponent(Graphics g)\n \t\t\tgetWidth() - fm.stringWidth(version) - 2,\r\n \t\t\timage.getHeight(this) - fm.getDescent());\r\n \t\tnotify();\r\n+\r\n+\t\tboolean isAboveProgressBar;\r\n+\t\tint y = scrollPosition;\r\n+\t\tfor(String member: groupMembers)\r\n+\t\t{\r\n+\t\t    isAboveProgressBar = y < (INITIAL_SCROLL_HEIGHT - PROGRESS_HEIGHT + 10);\r\n+\t\t    if (isAboveProgressBar)\r\n+\t\t\t\tg.drawString(member, (maxWidth - fm.stringWidth(member)) / 2, y);\r","path":"asn3/jEdit/org/gjt/sp/jedit/gui/SplashScreen.java","position":54,"original_position":54,"commit_id":"0cfdba4f79838ca73af5d5c1c9775c008aa78b38","original_commit_id":"0cfdba4f79838ca73af5d5c1c9775c008aa78b38","user":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"body":"It was clashing with the progress-bar and looked gross. This is a hack so it prints only those who are fully above the bar.","created_at":"2018-03-30T23:46:29Z","updated_at":"2018-03-30T23:46:30Z","html_url":"https://github.com/benjvictor/cmpt470/pull/4#discussion_r178408937","pull_request_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/comments/178408937"},"html":{"href":"https://github.com/benjvictor/cmpt470/pull/4#discussion_r178408937"},"pull_request":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4","id":177294474,"html_url":"https://github.com/benjvictor/cmpt470/pull/4","diff_url":"https://github.com/benjvictor/cmpt470/pull/4.diff","patch_url":"https://github.com/benjvictor/cmpt470/pull/4.patch","issue_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/4","number":4,"state":"open","locked":false,"title":"modify splash window","user":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"body":"\"Currently the splash window of jEdit is a static picture. Add the names and emails of your group members to it. And add moving text as the same effect shown in “About jEdit” dialog. Adjust the scrolling speed so that all text can be shown.\"\r\n\r\nTODO:\r\n- [x] add our names\r\n- [ ] scrolling text\r\n\r\nIssues: trouble getting animation thread to work","created_at":"2018-03-25T15:15:56Z","updated_at":"2018-03-30T23:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b38b30081aabc3ba5858733f784ed9873225ac3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4/commits","review_comments_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4/comments","review_comment_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/4/comments","statuses_url":"https://api.github.com/repos/benjvictor/cmpt470/statuses/0cfdba4f79838ca73af5d5c1c9775c008aa78b38","head":{"label":"benjvictor:splash-win","ref":"splash-win","sha":"0cfdba4f79838ca73af5d5c1c9775c008aa78b38","user":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"repo":{"id":118985309,"name":"cmpt470","full_name":"benjvictor/cmpt470","owner":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjvictor/cmpt470","description":null,"fork":false,"url":"https://api.github.com/repos/benjvictor/cmpt470","forks_url":"https://api.github.com/repos/benjvictor/cmpt470/forks","keys_url":"https://api.github.com/repos/benjvictor/cmpt470/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjvictor/cmpt470/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjvictor/cmpt470/teams","hooks_url":"https://api.github.com/repos/benjvictor/cmpt470/hooks","issue_events_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/events{/number}","events_url":"https://api.github.com/repos/benjvictor/cmpt470/events","assignees_url":"https://api.github.com/repos/benjvictor/cmpt470/assignees{/user}","branches_url":"https://api.github.com/repos/benjvictor/cmpt470/branches{/branch}","tags_url":"https://api.github.com/repos/benjvictor/cmpt470/tags","blobs_url":"https://api.github.com/repos/benjvictor/cmpt470/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjvictor/cmpt470/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjvictor/cmpt470/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjvictor/cmpt470/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjvictor/cmpt470/statuses/{sha}","languages_url":"https://api.github.com/repos/benjvictor/cmpt470/languages","stargazers_url":"https://api.github.com/repos/benjvictor/cmpt470/stargazers","contributors_url":"https://api.github.com/repos/benjvictor/cmpt470/contributors","subscribers_url":"https://api.github.com/repos/benjvictor/cmpt470/subscribers","subscription_url":"https://api.github.com/repos/benjvictor/cmpt470/subscription","commits_url":"https://api.github.com/repos/benjvictor/cmpt470/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjvictor/cmpt470/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjvictor/cmpt470/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjvictor/cmpt470/contents/{+path}","compare_url":"https://api.github.com/repos/benjvictor/cmpt470/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjvictor/cmpt470/merges","archive_url":"https://api.github.com/repos/benjvictor/cmpt470/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjvictor/cmpt470/downloads","issues_url":"https://api.github.com/repos/benjvictor/cmpt470/issues{/number}","pulls_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls{/number}","milestones_url":"https://api.github.com/repos/benjvictor/cmpt470/milestones{/number}","notifications_url":"https://api.github.com/repos/benjvictor/cmpt470/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjvictor/cmpt470/labels{/name}","releases_url":"https://api.github.com/repos/benjvictor/cmpt470/releases{/id}","deployments_url":"https://api.github.com/repos/benjvictor/cmpt470/deployments","created_at":"2018-01-26T00:42:20Z","updated_at":"2018-03-13T16:29:45Z","pushed_at":"2018-03-30T23:43:30Z","git_url":"git://github.com/benjvictor/cmpt470.git","ssh_url":"git@github.com:benjvictor/cmpt470.git","clone_url":"https://github.com/benjvictor/cmpt470.git","svn_url":"https://github.com/benjvictor/cmpt470","homepage":null,"size":5091,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"benjvictor:assignment-3","ref":"assignment-3","sha":"818bbf736694ee2708cc1a545a95059f24f2f788","user":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"repo":{"id":118985309,"name":"cmpt470","full_name":"benjvictor/cmpt470","owner":{"login":"benjvictor","id":8967090,"avatar_url":"https://avatars3.githubusercontent.com/u/8967090?v=4","gravatar_id":"","url":"https://api.github.com/users/benjvictor","html_url":"https://github.com/benjvictor","followers_url":"https://api.github.com/users/benjvictor/followers","following_url":"https://api.github.com/users/benjvictor/following{/other_user}","gists_url":"https://api.github.com/users/benjvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/benjvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjvictor/subscriptions","organizations_url":"https://api.github.com/users/benjvictor/orgs","repos_url":"https://api.github.com/users/benjvictor/repos","events_url":"https://api.github.com/users/benjvictor/events{/privacy}","received_events_url":"https://api.github.com/users/benjvictor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjvictor/cmpt470","description":null,"fork":false,"url":"https://api.github.com/repos/benjvictor/cmpt470","forks_url":"https://api.github.com/repos/benjvictor/cmpt470/forks","keys_url":"https://api.github.com/repos/benjvictor/cmpt470/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjvictor/cmpt470/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjvictor/cmpt470/teams","hooks_url":"https://api.github.com/repos/benjvictor/cmpt470/hooks","issue_events_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/events{/number}","events_url":"https://api.github.com/repos/benjvictor/cmpt470/events","assignees_url":"https://api.github.com/repos/benjvictor/cmpt470/assignees{/user}","branches_url":"https://api.github.com/repos/benjvictor/cmpt470/branches{/branch}","tags_url":"https://api.github.com/repos/benjvictor/cmpt470/tags","blobs_url":"https://api.github.com/repos/benjvictor/cmpt470/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjvictor/cmpt470/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjvictor/cmpt470/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjvictor/cmpt470/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjvictor/cmpt470/statuses/{sha}","languages_url":"https://api.github.com/repos/benjvictor/cmpt470/languages","stargazers_url":"https://api.github.com/repos/benjvictor/cmpt470/stargazers","contributors_url":"https://api.github.com/repos/benjvictor/cmpt470/contributors","subscribers_url":"https://api.github.com/repos/benjvictor/cmpt470/subscribers","subscription_url":"https://api.github.com/repos/benjvictor/cmpt470/subscription","commits_url":"https://api.github.com/repos/benjvictor/cmpt470/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjvictor/cmpt470/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjvictor/cmpt470/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjvictor/cmpt470/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjvictor/cmpt470/contents/{+path}","compare_url":"https://api.github.com/repos/benjvictor/cmpt470/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjvictor/cmpt470/merges","archive_url":"https://api.github.com/repos/benjvictor/cmpt470/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjvictor/cmpt470/downloads","issues_url":"https://api.github.com/repos/benjvictor/cmpt470/issues{/number}","pulls_url":"https://api.github.com/repos/benjvictor/cmpt470/pulls{/number}","milestones_url":"https://api.github.com/repos/benjvictor/cmpt470/milestones{/number}","notifications_url":"https://api.github.com/repos/benjvictor/cmpt470/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjvictor/cmpt470/labels{/name}","releases_url":"https://api.github.com/repos/benjvictor/cmpt470/releases{/id}","deployments_url":"https://api.github.com/repos/benjvictor/cmpt470/deployments","created_at":"2018-01-26T00:42:20Z","updated_at":"2018-03-13T16:29:45Z","pushed_at":"2018-03-30T23:43:30Z","git_url":"git://github.com/benjvictor/cmpt470.git","ssh_url":"git@github.com:benjvictor/cmpt470.git","clone_url":"https://github.com/benjvictor/cmpt470.git","svn_url":"https://github.com/benjvictor/cmpt470","homepage":null,"size":5091,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4"},"html":{"href":"https://github.com/benjvictor/cmpt470/pull/4"},"issue":{"href":"https://api.github.com/repos/benjvictor/cmpt470/issues/4"},"comments":{"href":"https://api.github.com/repos/benjvictor/cmpt470/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benjvictor/cmpt470/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/benjvictor/cmpt470/statuses/0cfdba4f79838ca73af5d5c1c9775c008aa78b38"}},"author_association":"OWNER"}}
{"actor":{"display_login":"benjvictor"}}