{"action":"created","comment":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/236389717","pull_request_review_id":178454551,"id":236389717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjM4OTcxNw==","diff_hunk":"@@ -834,14 +848,26 @@ void KubernetesReader::WatchMaster(\n           if (ec != boost::asio::error::operation_aborted) {\n             watch_service->stop();\n           }\n+          });\n+      }\n+      std::unique_ptr<DelayTimer> staleness_timer;\n+      if (config_.KubernetesUpdaterWatchReconnectMaxStalenessSeconds() > 0) {\n+        staleness_timer = delay_timer_factory_->CreateTimer(*watch_service);","path":"src/kubernetes.cc","position":49,"original_position":49,"commit_id":"6fb95d132182ae865c4673300167723357a6678e","original_commit_id":"6fb95d132182ae865c4673300167723357a6678e","user":{"login":"igorpeshansky","id":7594381,"node_id":"MDQ6VXNlcjc1OTQzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7594381?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpeshansky","html_url":"https://github.com/igorpeshansky","followers_url":"https://api.github.com/users/igorpeshansky/followers","following_url":"https://api.github.com/users/igorpeshansky/following{/other_user}","gists_url":"https://api.github.com/users/igorpeshansky/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpeshansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpeshansky/subscriptions","organizations_url":"https://api.github.com/users/igorpeshansky/orgs","repos_url":"https://api.github.com/users/igorpeshansky/repos","events_url":"https://api.github.com/users/igorpeshansky/events{/privacy}","received_events_url":"https://api.github.com/users/igorpeshansky/received_events","type":"User","site_admin":false},"body":"Never mind, I've misread the code. See above.","created_at":"2018-11-26T19:14:29Z","updated_at":"2018-11-26T19:14:44Z","html_url":"https://github.com/Stackdriver/metadata-agent/pull/211#discussion_r236389717","pull_request_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/236389717"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/211#discussion_r236389717"},"pull_request":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211"}},"in_reply_to_id":236376452},"pull_request":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211","id":233633200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjMzMjAw","html_url":"https://github.com/Stackdriver/metadata-agent/pull/211","diff_url":"https://github.com/Stackdriver/metadata-agent/pull/211.diff","patch_url":"https://github.com/Stackdriver/metadata-agent/pull/211.patch","issue_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/211","number":211,"state":"open","locked":false,"title":"Reconnect watch stream when data has not been reported in a while.","user":{"login":"bmoyles0117","id":264816,"node_id":"MDQ6VXNlcjI2NDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/264816?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoyles0117","html_url":"https://github.com/bmoyles0117","followers_url":"https://api.github.com/users/bmoyles0117/followers","following_url":"https://api.github.com/users/bmoyles0117/following{/other_user}","gists_url":"https://api.github.com/users/bmoyles0117/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoyles0117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoyles0117/subscriptions","organizations_url":"https://api.github.com/users/bmoyles0117/orgs","repos_url":"https://api.github.com/users/bmoyles0117/repos","events_url":"https://api.github.com/users/bmoyles0117/events{/privacy}","received_events_url":"https://api.github.com/users/bmoyles0117/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-26T17:11:09Z","updated_at":"2018-11-26T19:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc58cb1b3938de0a732bda5c3ee533e2a74472f4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"StevenYCChou","id":3055688,"node_id":"MDQ6VXNlcjMwNTU2ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3055688?v=4","gravatar_id":"","url":"https://api.github.com/users/StevenYCChou","html_url":"https://github.com/StevenYCChou","followers_url":"https://api.github.com/users/StevenYCChou/followers","following_url":"https://api.github.com/users/StevenYCChou/following{/other_user}","gists_url":"https://api.github.com/users/StevenYCChou/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenYCChou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenYCChou/subscriptions","organizations_url":"https://api.github.com/users/StevenYCChou/orgs","repos_url":"https://api.github.com/users/StevenYCChou/repos","events_url":"https://api.github.com/users/StevenYCChou/events{/privacy}","received_events_url":"https://api.github.com/users/StevenYCChou/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211/commits","review_comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211/comments","review_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/211/comments","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/6fb95d132182ae865c4673300167723357a6678e","head":{"label":"Stackdriver:davidbtucker-watch-reconnect-staleness","ref":"davidbtucker-watch-reconnect-staleness","sha":"6fb95d132182ae865c4673300167723357a6678e","user":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM5NjMxMA==","name":"metadata-agent","full_name":"Stackdriver/metadata-agent","private":false,"owner":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-11-25T06:24:59Z","pushed_at":"2018-11-26T17:11:10Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"git@github.com:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":683,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":7,"watchers":14,"default_branch":"master"}},"base":{"label":"Stackdriver:master","ref":"master","sha":"d0e989eff2064f5177b862f68c8449b336d24bdd","user":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM5NjMxMA==","name":"metadata-agent","full_name":"Stackdriver/metadata-agent","private":false,"owner":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-11-25T06:24:59Z","pushed_at":"2018-11-26T17:11:10Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"git@github.com:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":683,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/211"},"issue":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/211"},"comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/6fb95d132182ae865c4673300167723357a6678e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"igorpeshansky"}}