{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27","id":41425067,"html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/27","diff_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/27.diff","patch_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/27.patch","issue_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/27","number":27,"state":"closed","locked":false,"title":"Refactored","user":{"login":"amirahaile","id":6953115,"avatar_url":"https://avatars3.githubusercontent.com/u/6953115?v=4","gravatar_id":"","url":"https://api.github.com/users/amirahaile","html_url":"https://github.com/amirahaile","followers_url":"https://api.github.com/users/amirahaile/followers","following_url":"https://api.github.com/users/amirahaile/following{/other_user}","gists_url":"https://api.github.com/users/amirahaile/gists{/gist_id}","starred_url":"https://api.github.com/users/amirahaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirahaile/subscriptions","organizations_url":"https://api.github.com/users/amirahaile/orgs","repos_url":"https://api.github.com/users/amirahaile/repos","events_url":"https://api.github.com/users/amirahaile/events{/privacy}","received_events_url":"https://api.github.com/users/amirahaile/received_events","type":"User","site_admin":false},"body":"Soooo… I kind of refactored this project before we were assigned the refactoring homework. Here's my 5 refactors (including work done before the assignment): \n\n1 - Moved #upvote in all controllers to their respective models.\n2 - Polymorphic paths on my details partial.\n3 - Moved scope logic from my controllers to their models (commit 6e7b119). \n4 - Refactored a loop in my specs for my model shared example (commit 3bda39e).\n5 - Made a partial of my media :index view (commit 6821018).\n","created_at":"2015-08-02T21:41:58Z","updated_at":"2018-02-15T16:54:44Z","closed_at":"2018-02-15T16:54:44Z","merged_at":null,"merge_commit_sha":"6f6b86ff8bc6631afb1701cce46f762879b0b9a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/27/comments","statuses_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/statuses/838ccc1bab40213db8677dc6fea56e9c30bd8f67","head":{"label":"amirahaile:adh/master","ref":"adh/master","sha":"838ccc1bab40213db8677dc6fea56e9c30bd8f67","user":{"login":"amirahaile","id":6953115,"avatar_url":"https://avatars3.githubusercontent.com/u/6953115?v=4","gravatar_id":"","url":"https://api.github.com/users/amirahaile","html_url":"https://github.com/amirahaile","followers_url":"https://api.github.com/users/amirahaile/followers","following_url":"https://api.github.com/users/amirahaile/following{/other_user}","gists_url":"https://api.github.com/users/amirahaile/gists{/gist_id}","starred_url":"https://api.github.com/users/amirahaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirahaile/subscriptions","organizations_url":"https://api.github.com/users/amirahaile/orgs","repos_url":"https://api.github.com/users/amirahaile/repos","events_url":"https://api.github.com/users/amirahaile/events{/privacy}","received_events_url":"https://api.github.com/users/amirahaile/received_events","type":"User","site_admin":false},"repo":{"id":38648856,"name":"C3Projects--MediaRanker","full_name":"amirahaile/C3Projects--MediaRanker","owner":{"login":"amirahaile","id":6953115,"avatar_url":"https://avatars3.githubusercontent.com/u/6953115?v=4","gravatar_id":"","url":"https://api.github.com/users/amirahaile","html_url":"https://github.com/amirahaile","followers_url":"https://api.github.com/users/amirahaile/followers","following_url":"https://api.github.com/users/amirahaile/following{/other_user}","gists_url":"https://api.github.com/users/amirahaile/gists{/gist_id}","starred_url":"https://api.github.com/users/amirahaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirahaile/subscriptions","organizations_url":"https://api.github.com/users/amirahaile/orgs","repos_url":"https://api.github.com/users/amirahaile/repos","events_url":"https://api.github.com/users/amirahaile/events{/privacy}","received_events_url":"https://api.github.com/users/amirahaile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amirahaile/C3Projects--MediaRanker","description":null,"fork":true,"url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker","forks_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/forks","keys_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/teams","hooks_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/hooks","issue_events_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/issues/events{/number}","events_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/events","assignees_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/assignees{/user}","branches_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/branches{/branch}","tags_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/tags","blobs_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/git/refs{/sha}","trees_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/statuses/{sha}","languages_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/languages","stargazers_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/stargazers","contributors_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/contributors","subscribers_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/subscribers","subscription_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/subscription","commits_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/commits{/sha}","git_commits_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/git/commits{/sha}","comments_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/comments{/number}","issue_comment_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/issues/comments{/number}","contents_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/contents/{+path}","compare_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/merges","archive_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/downloads","issues_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/issues{/number}","pulls_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/pulls{/number}","milestones_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/milestones{/number}","notifications_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/labels{/name}","releases_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/releases{/id}","deployments_url":"https://api.github.com/repos/amirahaile/C3Projects--MediaRanker/deployments","created_at":"2015-07-06T22:04:33Z","updated_at":"2015-06-30T20:51:55Z","pushed_at":"2015-08-02T21:39:34Z","git_url":"git://github.com/amirahaile/C3Projects--MediaRanker.git","ssh_url":"git@github.com:amirahaile/C3Projects--MediaRanker.git","clone_url":"https://github.com/amirahaile/C3Projects--MediaRanker.git","svn_url":"https://github.com/amirahaile/C3Projects--MediaRanker","homepage":null,"size":186,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-Developers-Academy:adh/master","ref":"adh/master","sha":"061949dc942e604ca5af757f506cad8ee32296df","user":{"login":"Ada-Developers-Academy","id":4689715,"avatar_url":"https://avatars2.githubusercontent.com/u/4689715?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-Developers-Academy","html_url":"https://github.com/Ada-Developers-Academy","followers_url":"https://api.github.com/users/Ada-Developers-Academy/followers","following_url":"https://api.github.com/users/Ada-Developers-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Ada-Developers-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-Developers-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-Developers-Academy/subscriptions","organizations_url":"https://api.github.com/users/Ada-Developers-Academy/orgs","repos_url":"https://api.github.com/users/Ada-Developers-Academy/repos","events_url":"https://api.github.com/users/Ada-Developers-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-Developers-Academy/received_events","type":"Organization","site_admin":false},"repo":{"id":38332554,"name":"C3Projects--MediaRanker","full_name":"Ada-Developers-Academy/C3Projects--MediaRanker","owner":{"login":"Ada-Developers-Academy","id":4689715,"avatar_url":"https://avatars2.githubusercontent.com/u/4689715?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-Developers-Academy","html_url":"https://github.com/Ada-Developers-Academy","followers_url":"https://api.github.com/users/Ada-Developers-Academy/followers","following_url":"https://api.github.com/users/Ada-Developers-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Ada-Developers-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-Developers-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-Developers-Academy/subscriptions","organizations_url":"https://api.github.com/users/Ada-Developers-Academy/orgs","repos_url":"https://api.github.com/users/Ada-Developers-Academy/repos","events_url":"https://api.github.com/users/Ada-Developers-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-Developers-Academy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker","description":null,"fork":false,"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker","forks_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/forks","keys_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/teams","hooks_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/hooks","issue_events_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/events","assignees_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/tags","blobs_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/languages","stargazers_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/stargazers","contributors_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/contributors","subscribers_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/subscribers","subscription_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/subscription","commits_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/merges","archive_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/downloads","issues_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/labels{/name}","releases_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/deployments","created_at":"2015-06-30T20:51:55Z","updated_at":"2017-07-02T22:25:18Z","pushed_at":"2016-01-12T22:02:46Z","git_url":"git://github.com/Ada-Developers-Academy/C3Projects--MediaRanker.git","ssh_url":"git@github.com:Ada-Developers-Academy/C3Projects--MediaRanker.git","clone_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker.git","svn_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker","homepage":null,"size":15658,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":27,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27"},"html":{"href":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/27"},"issue":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/27"},"comments":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/statuses/838ccc1bab40213db8677dc6fea56e9c30bd8f67"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":10,"changed_files":7}}
{"actor":{"display_login":"amirahaile"}}