{"action":"opened","number":599,"pull_request":{"url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599","id":238999382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTk5Mzgy","html_url":"https://github.com/lucyparsons/OpenOversight/pull/599","diff_url":"https://github.com/lucyparsons/OpenOversight/pull/599.diff","patch_url":"https://github.com/lucyparsons/OpenOversight/pull/599.patch","issue_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/599","number":599,"state":"open","locked":false,"title":"fix bug preventing incident edit form submission","user":{"login":"asabine","id":7596335,"node_id":"MDQ6VXNlcjc1OTYzMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7596335?v=4","gravatar_id":"","url":"https://api.github.com/users/asabine","html_url":"https://github.com/asabine","followers_url":"https://api.github.com/users/asabine/followers","following_url":"https://api.github.com/users/asabine/following{/other_user}","gists_url":"https://api.github.com/users/asabine/gists{/gist_id}","starred_url":"https://api.github.com/users/asabine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asabine/subscriptions","organizations_url":"https://api.github.com/users/asabine/orgs","repos_url":"https://api.github.com/users/asabine/repos","events_url":"https://api.github.com/users/asabine/events{/privacy}","received_events_url":"https://api.github.com/users/asabine/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\nReady for review\r\n\r\n## Description of Changes\r\n\r\nIn the model view edit form, where the `creator_id` is set on the form, the check for whether or not the object has one attempts to set `obj.creator_id` *only* if `obj.creator_id` returned None, which then prevented setting the current user's id instead. This prevented editing incidents, so I fixed the if statement to work as the comment above that line describes.\r\n\r\n## Tests and linting\r\n\r\n - [x] I have rebased my changes on current `develop`\r\n\r\n - [x] pytests pass in the development environment on my local machine\r\n\r\n - [x] `flake8` checks pass\r\n","created_at":"2018-12-16T23:55:18Z","updated_at":"2018-12-16T23:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599/commits","review_comments_url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599/comments","review_comment_url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/599/comments","statuses_url":"https://api.github.com/repos/lucyparsons/OpenOversight/statuses/2b9232cc815461ab717a14740fcfaeb1941f1d3f","head":{"label":"asabine:develop","ref":"develop","sha":"2b9232cc815461ab717a14740fcfaeb1941f1d3f","user":{"login":"asabine","id":7596335,"node_id":"MDQ6VXNlcjc1OTYzMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7596335?v=4","gravatar_id":"","url":"https://api.github.com/users/asabine","html_url":"https://github.com/asabine","followers_url":"https://api.github.com/users/asabine/followers","following_url":"https://api.github.com/users/asabine/following{/other_user}","gists_url":"https://api.github.com/users/asabine/gists{/gist_id}","starred_url":"https://api.github.com/users/asabine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asabine/subscriptions","organizations_url":"https://api.github.com/users/asabine/orgs","repos_url":"https://api.github.com/users/asabine/repos","events_url":"https://api.github.com/users/asabine/events{/privacy}","received_events_url":"https://api.github.com/users/asabine/received_events","type":"User","site_admin":false},"repo":{"id":162050559,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIwNTA1NTk=","name":"OpenOversight","full_name":"asabine/OpenOversight","private":false,"owner":{"login":"asabine","id":7596335,"node_id":"MDQ6VXNlcjc1OTYzMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/7596335?v=4","gravatar_id":"","url":"https://api.github.com/users/asabine","html_url":"https://github.com/asabine","followers_url":"https://api.github.com/users/asabine/followers","following_url":"https://api.github.com/users/asabine/following{/other_user}","gists_url":"https://api.github.com/users/asabine/gists{/gist_id}","starred_url":"https://api.github.com/users/asabine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asabine/subscriptions","organizations_url":"https://api.github.com/users/asabine/orgs","repos_url":"https://api.github.com/users/asabine/repos","events_url":"https://api.github.com/users/asabine/events{/privacy}","received_events_url":"https://api.github.com/users/asabine/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asabine/OpenOversight","description":"Police oversight and accountability through public data 👮","fork":true,"url":"https://api.github.com/repos/asabine/OpenOversight","forks_url":"https://api.github.com/repos/asabine/OpenOversight/forks","keys_url":"https://api.github.com/repos/asabine/OpenOversight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asabine/OpenOversight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asabine/OpenOversight/teams","hooks_url":"https://api.github.com/repos/asabine/OpenOversight/hooks","issue_events_url":"https://api.github.com/repos/asabine/OpenOversight/issues/events{/number}","events_url":"https://api.github.com/repos/asabine/OpenOversight/events","assignees_url":"https://api.github.com/repos/asabine/OpenOversight/assignees{/user}","branches_url":"https://api.github.com/repos/asabine/OpenOversight/branches{/branch}","tags_url":"https://api.github.com/repos/asabine/OpenOversight/tags","blobs_url":"https://api.github.com/repos/asabine/OpenOversight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asabine/OpenOversight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asabine/OpenOversight/git/refs{/sha}","trees_url":"https://api.github.com/repos/asabine/OpenOversight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asabine/OpenOversight/statuses/{sha}","languages_url":"https://api.github.com/repos/asabine/OpenOversight/languages","stargazers_url":"https://api.github.com/repos/asabine/OpenOversight/stargazers","contributors_url":"https://api.github.com/repos/asabine/OpenOversight/contributors","subscribers_url":"https://api.github.com/repos/asabine/OpenOversight/subscribers","subscription_url":"https://api.github.com/repos/asabine/OpenOversight/subscription","commits_url":"https://api.github.com/repos/asabine/OpenOversight/commits{/sha}","git_commits_url":"https://api.github.com/repos/asabine/OpenOversight/git/commits{/sha}","comments_url":"https://api.github.com/repos/asabine/OpenOversight/comments{/number}","issue_comment_url":"https://api.github.com/repos/asabine/OpenOversight/issues/comments{/number}","contents_url":"https://api.github.com/repos/asabine/OpenOversight/contents/{+path}","compare_url":"https://api.github.com/repos/asabine/OpenOversight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asabine/OpenOversight/merges","archive_url":"https://api.github.com/repos/asabine/OpenOversight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asabine/OpenOversight/downloads","issues_url":"https://api.github.com/repos/asabine/OpenOversight/issues{/number}","pulls_url":"https://api.github.com/repos/asabine/OpenOversight/pulls{/number}","milestones_url":"https://api.github.com/repos/asabine/OpenOversight/milestones{/number}","notifications_url":"https://api.github.com/repos/asabine/OpenOversight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asabine/OpenOversight/labels{/name}","releases_url":"https://api.github.com/repos/asabine/OpenOversight/releases{/id}","deployments_url":"https://api.github.com/repos/asabine/OpenOversight/deployments","created_at":"2018-12-16T23:28:38Z","updated_at":"2018-12-16T23:30:44Z","pushed_at":"2018-12-16T23:30:42Z","git_url":"git://github.com/asabine/OpenOversight.git","ssh_url":"git@github.com:asabine/OpenOversight.git","clone_url":"https://github.com/asabine/OpenOversight.git","svn_url":"https://github.com/asabine/OpenOversight","homepage":"https://openoversight.com","size":10675,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"lucyparsons:develop","ref":"develop","sha":"d09fe0cd7a588f30844a699b0819cebdd1287c4c","user":{"login":"lucyparsons","id":14915368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTE1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/14915368?v=4","gravatar_id":"","url":"https://api.github.com/users/lucyparsons","html_url":"https://github.com/lucyparsons","followers_url":"https://api.github.com/users/lucyparsons/followers","following_url":"https://api.github.com/users/lucyparsons/following{/other_user}","gists_url":"https://api.github.com/users/lucyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyparsons/subscriptions","organizations_url":"https://api.github.com/users/lucyparsons/orgs","repos_url":"https://api.github.com/users/lucyparsons/repos","events_url":"https://api.github.com/users/lucyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/lucyparsons/received_events","type":"Organization","site_admin":false},"repo":{"id":55662896,"node_id":"MDEwOlJlcG9zaXRvcnk1NTY2Mjg5Ng==","name":"OpenOversight","full_name":"lucyparsons/OpenOversight","private":false,"owner":{"login":"lucyparsons","id":14915368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTE1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/14915368?v=4","gravatar_id":"","url":"https://api.github.com/users/lucyparsons","html_url":"https://github.com/lucyparsons","followers_url":"https://api.github.com/users/lucyparsons/followers","following_url":"https://api.github.com/users/lucyparsons/following{/other_user}","gists_url":"https://api.github.com/users/lucyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyparsons/subscriptions","organizations_url":"https://api.github.com/users/lucyparsons/orgs","repos_url":"https://api.github.com/users/lucyparsons/repos","events_url":"https://api.github.com/users/lucyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/lucyparsons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lucyparsons/OpenOversight","description":"Police oversight and accountability through public data 👮","fork":false,"url":"https://api.github.com/repos/lucyparsons/OpenOversight","forks_url":"https://api.github.com/repos/lucyparsons/OpenOversight/forks","keys_url":"https://api.github.com/repos/lucyparsons/OpenOversight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucyparsons/OpenOversight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucyparsons/OpenOversight/teams","hooks_url":"https://api.github.com/repos/lucyparsons/OpenOversight/hooks","issue_events_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/events{/number}","events_url":"https://api.github.com/repos/lucyparsons/OpenOversight/events","assignees_url":"https://api.github.com/repos/lucyparsons/OpenOversight/assignees{/user}","branches_url":"https://api.github.com/repos/lucyparsons/OpenOversight/branches{/branch}","tags_url":"https://api.github.com/repos/lucyparsons/OpenOversight/tags","blobs_url":"https://api.github.com/repos/lucyparsons/OpenOversight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucyparsons/OpenOversight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucyparsons/OpenOversight/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucyparsons/OpenOversight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucyparsons/OpenOversight/statuses/{sha}","languages_url":"https://api.github.com/repos/lucyparsons/OpenOversight/languages","stargazers_url":"https://api.github.com/repos/lucyparsons/OpenOversight/stargazers","contributors_url":"https://api.github.com/repos/lucyparsons/OpenOversight/contributors","subscribers_url":"https://api.github.com/repos/lucyparsons/OpenOversight/subscribers","subscription_url":"https://api.github.com/repos/lucyparsons/OpenOversight/subscription","commits_url":"https://api.github.com/repos/lucyparsons/OpenOversight/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucyparsons/OpenOversight/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucyparsons/OpenOversight/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucyparsons/OpenOversight/contents/{+path}","compare_url":"https://api.github.com/repos/lucyparsons/OpenOversight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucyparsons/OpenOversight/merges","archive_url":"https://api.github.com/repos/lucyparsons/OpenOversight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucyparsons/OpenOversight/downloads","issues_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues{/number}","pulls_url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls{/number}","milestones_url":"https://api.github.com/repos/lucyparsons/OpenOversight/milestones{/number}","notifications_url":"https://api.github.com/repos/lucyparsons/OpenOversight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucyparsons/OpenOversight/labels{/name}","releases_url":"https://api.github.com/repos/lucyparsons/OpenOversight/releases{/id}","deployments_url":"https://api.github.com/repos/lucyparsons/OpenOversight/deployments","created_at":"2016-04-07T04:10:42Z","updated_at":"2018-12-16T22:42:05Z","pushed_at":"2018-12-16T22:42:02Z","git_url":"git://github.com/lucyparsons/OpenOversight.git","ssh_url":"git@github.com:lucyparsons/OpenOversight.git","clone_url":"https://github.com/lucyparsons/OpenOversight.git","svn_url":"https://github.com/lucyparsons/OpenOversight","homepage":"https://openoversight.com","size":10675,"stargazers_count":104,"watchers_count":104,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":38,"open_issues":147,"watchers":104,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599"},"html":{"href":"https://github.com/lucyparsons/OpenOversight/pull/599"},"issue":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/599"},"comments":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/599/comments"},"review_comments":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599/comments"},"review_comment":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/599/commits"},"statuses":{"href":"https://api.github.com/repos/lucyparsons/OpenOversight/statuses/2b9232cc815461ab717a14740fcfaeb1941f1d3f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"asabine"}}