{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/buildah/pulls/comments/193514625","pull_request_review_id":126500991,"id":193514625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzUxNDYyNQ==","diff_hunk":"@@ -168,7 +168,7 @@ func resolveImage(ctx context.Context, systemContext *types.SystemContext, store\n \t\tif options.PullPolicy == PullAlways {\n \t\t\tpulledImg, pulledReference, err := pullAndFindImage(ctx, store, image, options, systemContext)\n \t\t\tif err != nil {\n-\t\t\t\tlogrus.Debugf(\"error pulling and reading image %q: %v\", image, err)\n+\t\t\t\tlogrus.Debugf(\"unable to pull and read image %q: %v\", image, err)","path":"new.go","position":5,"original_position":5,"commit_id":"043fd2e3005890186b304e03f6b8ffdf9f55a5b7","original_commit_id":"043fd2e3005890186b304e03f6b8ffdf9f55a5b7","user":{"login":"TomSweeneyRedHat","id":25613829,"node_id":"MDQ6VXNlcjI1NjEzODI5","avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"body":"@rhatdan, just wanted to note that the errors that are now thrown in the new code in pull.go and util.go below are caught here and thrown out to debug only, not shown to the user directly.  I tried sending it out to the user directly, but that error gets generated for each registry in the list in registries.conf until it is resolved and/or fails looking for the image on localhost.  I thought in the case where it failed looking in a registry and then worked in a second was very misleading so I left the debug here rather than showing the error all the time.\r\n\r\n","created_at":"2018-06-06T18:30:35Z","updated_at":"2018-06-06T18:30:36Z","html_url":"https://github.com/projectatomic/buildah/pull/747#discussion_r193514625","pull_request_url":"https://api.github.com/repos/projectatomic/buildah/pulls/747","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/comments/193514625"},"html":{"href":"https://github.com/projectatomic/buildah/pull/747#discussion_r193514625"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/747"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/buildah/pulls/747","id":192212870,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjEyODcw","html_url":"https://github.com/projectatomic/buildah/pull/747","diff_url":"https://github.com/projectatomic/buildah/pull/747.diff","patch_url":"https://github.com/projectatomic/buildah/pull/747.patch","issue_url":"https://api.github.com/repos/projectatomic/buildah/issues/747","number":747,"state":"open","locked":false,"title":"Add registry errors for pull","user":{"login":"TomSweeneyRedHat","id":25613829,"node_id":"MDQ6VXNlcjI1NjEzODI5","avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"body":"Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>\r\n\r\nBuffs up the registry errors on pull.  Based on https://github.com/projectatomic/libpod/pull/84 by @baude.","created_at":"2018-06-02T19:00:42Z","updated_at":"2018-06-06T18:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e31a8119d8c068f88965a5ace627dc7238250857","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/buildah/pulls/747/commits","review_comments_url":"https://api.github.com/repos/projectatomic/buildah/pulls/747/comments","review_comment_url":"https://api.github.com/repos/projectatomic/buildah/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/buildah/issues/747/comments","statuses_url":"https://api.github.com/repos/projectatomic/buildah/statuses/043fd2e3005890186b304e03f6b8ffdf9f55a5b7","head":{"label":"TomSweeneyRedHat:dev/tsweeney/pullfix2","ref":"dev/tsweeney/pullfix2","sha":"043fd2e3005890186b304e03f6b8ffdf9f55a5b7","user":{"login":"TomSweeneyRedHat","id":25613829,"node_id":"MDQ6VXNlcjI1NjEzODI5","avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"repo":{"id":85838433,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgzODQzMw==","name":"buildah","full_name":"TomSweeneyRedHat/buildah","owner":{"login":"TomSweeneyRedHat","id":25613829,"node_id":"MDQ6VXNlcjI1NjEzODI5","avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomSweeneyRedHat/buildah","description":"A tool which facilitates building OCI images","fork":true,"url":"https://api.github.com/repos/TomSweeneyRedHat/buildah","forks_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/forks","keys_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/teams","hooks_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/hooks","issue_events_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues/events{/number}","events_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/events","assignees_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/assignees{/user}","branches_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/branches{/branch}","tags_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/tags","blobs_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/statuses/{sha}","languages_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/languages","stargazers_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/stargazers","contributors_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/contributors","subscribers_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/subscribers","subscription_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/subscription","commits_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/contents/{+path}","compare_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/merges","archive_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/downloads","issues_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues{/number}","pulls_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/pulls{/number}","milestones_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/milestones{/number}","notifications_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/labels{/name}","releases_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/releases{/id}","deployments_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/deployments","created_at":"2017-03-22T14:34:57Z","updated_at":"2018-05-31T16:50:49Z","pushed_at":"2018-06-06T17:07:45Z","git_url":"git://github.com/TomSweeneyRedHat/buildah.git","ssh_url":"git@github.com:TomSweeneyRedHat/buildah.git","clone_url":"https://github.com/TomSweeneyRedHat/buildah.git","svn_url":"https://github.com/TomSweeneyRedHat/buildah","homepage":"","size":10655,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"69b0a82b77e85783c1508e54836eb489df4c3117","user":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":80134675,"node_id":"MDEwOlJlcG9zaXRvcnk4MDEzNDY3NQ==","name":"buildah","full_name":"projectatomic/buildah","owner":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/buildah","description":"A tool that facilitates building OCI images","fork":false,"url":"https://api.github.com/repos/projectatomic/buildah","forks_url":"https://api.github.com/repos/projectatomic/buildah/forks","keys_url":"https://api.github.com/repos/projectatomic/buildah/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/buildah/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/buildah/teams","hooks_url":"https://api.github.com/repos/projectatomic/buildah/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/buildah/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/buildah/events","assignees_url":"https://api.github.com/repos/projectatomic/buildah/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/buildah/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/buildah/tags","blobs_url":"https://api.github.com/repos/projectatomic/buildah/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/buildah/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/buildah/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/buildah/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/buildah/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/buildah/languages","stargazers_url":"https://api.github.com/repos/projectatomic/buildah/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/buildah/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/buildah/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/buildah/subscription","commits_url":"https://api.github.com/repos/projectatomic/buildah/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/buildah/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/buildah/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/buildah/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/buildah/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/buildah/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/buildah/merges","archive_url":"https://api.github.com/repos/projectatomic/buildah/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/buildah/downloads","issues_url":"https://api.github.com/repos/projectatomic/buildah/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/buildah/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/buildah/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/buildah/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/buildah/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/buildah/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/buildah/deployments","created_at":"2017-01-26T16:59:13Z","updated_at":"2018-06-06T18:24:09Z","pushed_at":"2018-06-06T18:15:19Z","git_url":"git://github.com/projectatomic/buildah.git","ssh_url":"git@github.com:projectatomic/buildah.git","clone_url":"https://github.com/projectatomic/buildah.git","svn_url":"https://github.com/projectatomic/buildah","homepage":"","size":15863,"stargazers_count":642,"watchers_count":642,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":46,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/747"},"html":{"href":"https://github.com/projectatomic/buildah/pull/747"},"issue":{"href":"https://api.github.com/repos/projectatomic/buildah/issues/747"},"comments":{"href":"https://api.github.com/repos/projectatomic/buildah/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/buildah/statuses/043fd2e3005890186b304e03f6b8ffdf9f55a5b7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"TomSweeneyRedHat"}}