{"action":"created","issue":{"url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/88","repository_url":"https://api.github.com/repos/facundoolano/app-store-scraper","labels_url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/88/comments","events_url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/88/events","html_url":"https://github.com/facundoolano/app-store-scraper/pull/88","id":391435214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTQ2NTQ3","number":88,"title":"check for case where single review object is returned","user":{"login":"twalling","id":4907,"node_id":"MDQ6VXNlcjQ5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4907?v=4","gravatar_id":"","url":"https://api.github.com/users/twalling","html_url":"https://github.com/twalling","followers_url":"https://api.github.com/users/twalling/followers","following_url":"https://api.github.com/users/twalling/following{/other_user}","gists_url":"https://api.github.com/users/twalling/gists{/gist_id}","starred_url":"https://api.github.com/users/twalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalling/subscriptions","organizations_url":"https://api.github.com/users/twalling/orgs","repos_url":"https://api.github.com/users/twalling/repos","events_url":"https://api.github.com/users/twalling/events{/privacy}","received_events_url":"https://api.github.com/users/twalling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-16T04:46:39Z","updated_at":"2018-12-16T05:05:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facundoolano/app-store-scraper/pulls/88","html_url":"https://github.com/facundoolano/app-store-scraper/pull/88","diff_url":"https://github.com/facundoolano/app-store-scraper/pull/88.diff","patch_url":"https://github.com/facundoolano/app-store-scraper/pull/88.patch"},"body":"I ran into a case where one review was being returned for an app and I think the xml2js ends up returning a single object for `results.feed.entry` vs an array. This adds a check for it.\r\n\r\nI'd add a test for this but it looks like these tests are hitting live apps vs mocked responses using `sinon` or `nock`. That seems brittle as the responses could change over time. I'd be happy to switch the tests over to using mocked responses if that's ok with the module owner."},"comment":{"url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/comments/447618318","html_url":"https://github.com/facundoolano/app-store-scraper/pull/88#issuecomment-447618318","issue_url":"https://api.github.com/repos/facundoolano/app-store-scraper/issues/88","id":447618318,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzYxODMxOA==","user":{"login":"twalling","id":4907,"node_id":"MDQ6VXNlcjQ5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/4907?v=4","gravatar_id":"","url":"https://api.github.com/users/twalling","html_url":"https://github.com/twalling","followers_url":"https://api.github.com/users/twalling/followers","following_url":"https://api.github.com/users/twalling/following{/other_user}","gists_url":"https://api.github.com/users/twalling/gists{/gist_id}","starred_url":"https://api.github.com/users/twalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalling/subscriptions","organizations_url":"https://api.github.com/users/twalling/orgs","repos_url":"https://api.github.com/users/twalling/repos","events_url":"https://api.github.com/users/twalling/events{/privacy}","received_events_url":"https://api.github.com/users/twalling/received_events","type":"User","site_admin":false},"created_at":"2018-12-16T05:05:54Z","updated_at":"2018-12-16T05:05:54Z","author_association":"NONE","body":"It's late and I didn't even bother to check if there were other PRs for this. I guess you can take your pick. I think we all ended up using `Array.isArray` but I'll stand by my offer about making these tests use mocked responses as I think that will ensure the tests are consistent when run."}}
{"actor":{"display_login":"twalling"}}