{"action":"closed","number":20051,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/20051","id":199490730,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDkwNzMw","html_url":"https://github.com/facebook/react-native/pull/20051","diff_url":"https://github.com/facebook/react-native/pull/20051.diff","patch_url":"https://github.com/facebook/react-native/pull/20051.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/20051","number":20051,"state":"closed","locked":false,"title":"Add devDependencies.json to ignorePaths","user":{"login":"TomAtterton","id":5540723,"node_id":"MDQ6VXNlcjU1NDA3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5540723?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAtterton","html_url":"https://github.com/TomAtterton","followers_url":"https://api.github.com/users/TomAtterton/followers","following_url":"https://api.github.com/users/TomAtterton/following{/other_user}","gists_url":"https://api.github.com/users/TomAtterton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAtterton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAtterton/subscriptions","organizations_url":"https://api.github.com/users/TomAtterton/orgs","repos_url":"https://api.github.com/users/TomAtterton/repos","events_url":"https://api.github.com/users/TomAtterton/events{/privacy}","received_events_url":"https://api.github.com/users/TomAtterton/received_events","type":"User","site_admin":false},"body":"Regarding [Add devDependenices support for templates](https://github.com/facebook/react-native/commit/c4ab03a18e75e6ed55444b5d86f3ceee435b9a78).\r\n\r\nOnce a project is created using the custom template command with devDependencies inside, the devDependenices.json file is also copied to the new projects directory. \r\n\r\nBy adding this to the ignore paths we stop the devDependenices being copied into the new projects directory.\r\n\r\nTest Plan:\r\n----------\r\nIn [react-native-cli/index.js] i updated the CLI_MODULE_PATH to direct to: \"../local-cli/cli.js\" Then ran `node react-native/react-native-cli init <ProjectName> --template https://github.com/mediamonks/react-native-template-mediamonks `\r\n\r\nRelease Notes:\r\n--------------\r\nHelp reviewers and the release process by writing your own release notes. See below for an example.\r\n\r\n [CLI] [MINOR] [local-cli/generator/templates.js] - Add devDependencies.json to ignorePaths\r\n\r\n<!--\r\n  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**\r\n\r\n    CATEGORY\r\n  [----------]      TYPE\r\n  [ CLI      ] [-------------]    LOCATION\r\n  [ DOCS     ] [ BREAKING    ] [-------------]\r\n  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]\r\n  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]\r\n  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|\r\n  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |\r\n  [----------] [-------------] [-------------]   |-----------|\r\n\r\n EXAMPLES:\r\n\r\n [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things\r\n [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput\r\n [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word\r\n [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position\r\n [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see\r\n-->\r\n","created_at":"2018-07-05T14:33:51Z","updated_at":"2018-08-06T07:25:15Z","closed_at":"2018-08-06T07:25:15Z","merged_at":null,"merge_commit_sha":"6c379c124628e75d3a945455d0651e8fcdadeecc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shergin","id":22032,"node_id":"MDQ6VXNlcjIyMDMy","avatar_url":"https://avatars3.githubusercontent.com/u/22032?v=4","gravatar_id":"","url":"https://api.github.com/users/shergin","html_url":"https://github.com/shergin","followers_url":"https://api.github.com/users/shergin/followers","following_url":"https://api.github.com/users/shergin/following{/other_user}","gists_url":"https://api.github.com/users/shergin/gists{/gist_id}","starred_url":"https://api.github.com/users/shergin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shergin/subscriptions","organizations_url":"https://api.github.com/users/shergin/orgs","repos_url":"https://api.github.com/users/shergin/repos","events_url":"https://api.github.com/users/shergin/events{/privacy}","received_events_url":"https://api.github.com/users/shergin/received_events","type":"User","site_admin":false},{"login":"hramos","id":165856,"node_id":"MDQ6VXNlcjE2NTg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/165856?v=4","gravatar_id":"","url":"https://api.github.com/users/hramos","html_url":"https://github.com/hramos","followers_url":"https://api.github.com/users/hramos/followers","following_url":"https://api.github.com/users/hramos/following{/other_user}","gists_url":"https://api.github.com/users/hramos/gists{/gist_id}","starred_url":"https://api.github.com/users/hramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hramos/subscriptions","organizations_url":"https://api.github.com/users/hramos/orgs","repos_url":"https://api.github.com/users/hramos/repos","events_url":"https://api.github.com/users/hramos/events{/privacy}","received_events_url":"https://api.github.com/users/hramos/received_events","type":"User","site_admin":false},{"login":"mhorowitz","id":290225,"node_id":"MDQ6VXNlcjI5MDIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/290225?v=4","gravatar_id":"","url":"https://api.github.com/users/mhorowitz","html_url":"https://github.com/mhorowitz","followers_url":"https://api.github.com/users/mhorowitz/followers","following_url":"https://api.github.com/users/mhorowitz/following{/other_user}","gists_url":"https://api.github.com/users/mhorowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/mhorowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhorowitz/subscriptions","organizations_url":"https://api.github.com/users/mhorowitz/orgs","repos_url":"https://api.github.com/users/mhorowitz/repos","events_url":"https://api.github.com/users/mhorowitz/events{/privacy}","received_events_url":"https://api.github.com/users/mhorowitz/received_events","type":"User","site_admin":false},{"login":"Kureev","id":2273613,"node_id":"MDQ6VXNlcjIyNzM2MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2273613?v=4","gravatar_id":"","url":"https://api.github.com/users/Kureev","html_url":"https://github.com/Kureev","followers_url":"https://api.github.com/users/Kureev/followers","following_url":"https://api.github.com/users/Kureev/following{/other_user}","gists_url":"https://api.github.com/users/Kureev/gists{/gist_id}","starred_url":"https://api.github.com/users/Kureev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kureev/subscriptions","organizations_url":"https://api.github.com/users/Kureev/orgs","repos_url":"https://api.github.com/users/Kureev/repos","events_url":"https://api.github.com/users/Kureev/events{/privacy}","received_events_url":"https://api.github.com/users/Kureev/received_events","type":"User","site_admin":false},{"login":"grabbou","id":2464966,"node_id":"MDQ6VXNlcjI0NjQ5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2464966?v=4","gravatar_id":"","url":"https://api.github.com/users/grabbou","html_url":"https://github.com/grabbou","followers_url":"https://api.github.com/users/grabbou/followers","following_url":"https://api.github.com/users/grabbou/following{/other_user}","gists_url":"https://api.github.com/users/grabbou/gists{/gist_id}","starred_url":"https://api.github.com/users/grabbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabbou/subscriptions","organizations_url":"https://api.github.com/users/grabbou/orgs","repos_url":"https://api.github.com/users/grabbou/repos","events_url":"https://api.github.com/users/grabbou/events{/privacy}","received_events_url":"https://api.github.com/users/grabbou/received_events","type":"User","site_admin":false},{"login":"janicduplessis","id":2677334,"node_id":"MDQ6VXNlcjI2NzczMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":869759799,"node_id":"MDU6TGFiZWw4Njk3NTk3OTk=","url":"https://api.github.com/repos/facebook/react-native/labels/:white_check_mark:Release%20Notes","name":":white_check_mark:Release Notes","color":"0e8a16","default":false},{"id":934239421,"node_id":"MDU6TGFiZWw5MzQyMzk0MjE=","url":"https://api.github.com/repos/facebook/react-native/labels/:white_check_mark:Test%20Plan","name":":white_check_mark:Test Plan","color":"0e8a16","default":false},{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/20051/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/20051/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/20051/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/83ccaffbed7d387798ae340ab947503c6bf24aee","head":{"label":"TomAtterton:update-ignore-paths-template","ref":"update-ignore-paths-template","sha":"83ccaffbed7d387798ae340ab947503c6bf24aee","user":{"login":"TomAtterton","id":5540723,"node_id":"MDQ6VXNlcjU1NDA3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5540723?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAtterton","html_url":"https://github.com/TomAtterton","followers_url":"https://api.github.com/users/TomAtterton/followers","following_url":"https://api.github.com/users/TomAtterton/following{/other_user}","gists_url":"https://api.github.com/users/TomAtterton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAtterton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAtterton/subscriptions","organizations_url":"https://api.github.com/users/TomAtterton/orgs","repos_url":"https://api.github.com/users/TomAtterton/repos","events_url":"https://api.github.com/users/TomAtterton/events{/privacy}","received_events_url":"https://api.github.com/users/TomAtterton/received_events","type":"User","site_admin":false},"repo":{"id":138872341,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NzIzNDE=","name":"react-native","full_name":"TomAtterton/react-native","owner":{"login":"TomAtterton","id":5540723,"node_id":"MDQ6VXNlcjU1NDA3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5540723?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAtterton","html_url":"https://github.com/TomAtterton","followers_url":"https://api.github.com/users/TomAtterton/followers","following_url":"https://api.github.com/users/TomAtterton/following{/other_user}","gists_url":"https://api.github.com/users/TomAtterton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAtterton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAtterton/subscriptions","organizations_url":"https://api.github.com/users/TomAtterton/orgs","repos_url":"https://api.github.com/users/TomAtterton/repos","events_url":"https://api.github.com/users/TomAtterton/events{/privacy}","received_events_url":"https://api.github.com/users/TomAtterton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomAtterton/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/TomAtterton/react-native","forks_url":"https://api.github.com/repos/TomAtterton/react-native/forks","keys_url":"https://api.github.com/repos/TomAtterton/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomAtterton/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomAtterton/react-native/teams","hooks_url":"https://api.github.com/repos/TomAtterton/react-native/hooks","issue_events_url":"https://api.github.com/repos/TomAtterton/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/TomAtterton/react-native/events","assignees_url":"https://api.github.com/repos/TomAtterton/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/TomAtterton/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/TomAtterton/react-native/tags","blobs_url":"https://api.github.com/repos/TomAtterton/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomAtterton/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomAtterton/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomAtterton/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomAtterton/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/TomAtterton/react-native/languages","stargazers_url":"https://api.github.com/repos/TomAtterton/react-native/stargazers","contributors_url":"https://api.github.com/repos/TomAtterton/react-native/contributors","subscribers_url":"https://api.github.com/repos/TomAtterton/react-native/subscribers","subscription_url":"https://api.github.com/repos/TomAtterton/react-native/subscription","commits_url":"https://api.github.com/repos/TomAtterton/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomAtterton/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomAtterton/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomAtterton/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomAtterton/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/TomAtterton/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomAtterton/react-native/merges","archive_url":"https://api.github.com/repos/TomAtterton/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomAtterton/react-native/downloads","issues_url":"https://api.github.com/repos/TomAtterton/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/TomAtterton/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/TomAtterton/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/TomAtterton/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomAtterton/react-native/labels{/name}","releases_url":"https://api.github.com/repos/TomAtterton/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/TomAtterton/react-native/deployments","created_at":"2018-06-27T11:27:58Z","updated_at":"2018-08-06T07:12:01Z","pushed_at":"2018-08-06T07:15:30Z","git_url":"git://github.com/TomAtterton/react-native.git","ssh_url":"git@github.com:TomAtterton/react-native.git","clone_url":"https://github.com/TomAtterton/react-native.git","svn_url":"https://github.com/TomAtterton/react-native","homepage":"https://facebook.github.io/react-native/","size":246217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"50675404873c1ffac0deedc51fe745168051148b","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"node_id":"MDEwOlJlcG9zaXRvcnkyOTAyODc3NQ==","name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-08-06T07:06:59Z","pushed_at":"2018-08-06T07:15:35Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"https://facebook.github.io/react-native/","size":252648,"stargazers_count":67152,"watchers_count":67152,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15104,"mirror_url":null,"archived":false,"open_issues_count":906,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15104,"open_issues":906,"watchers":67152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20051"},"html":{"href":"https://github.com/facebook/react-native/pull/20051"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/20051"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/20051/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20051/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20051/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/83ccaffbed7d387798ae340ab947503c6bf24aee"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":250,"additions":20063,"deletions":13368,"changed_files":515}}
{"actor":{"display_login":"TomAtterton"}}