{"action":"closed","issue":{"url":"https://api.github.com/repos/tarantool/tarantool/issues/3433","repository_url":"https://api.github.com/repos/tarantool/tarantool","labels_url":"https://api.github.com/repos/tarantool/tarantool/issues/3433/labels{/name}","comments_url":"https://api.github.com/repos/tarantool/tarantool/issues/3433/comments","events_url":"https://api.github.com/repos/tarantool/tarantool/issues/3433/events","html_url":"https://github.com/tarantool/tarantool/issues/3433","id":327656630,"node_id":"MDU6SXNzdWUzMjc2NTY2MzA=","number":3433,"title":"C say(): fix arguments","user":{"login":"sorc1","id":6263448,"node_id":"MDQ6VXNlcjYyNjM0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6263448?v=4","gravatar_id":"","url":"https://api.github.com/users/sorc1","html_url":"https://github.com/sorc1","followers_url":"https://api.github.com/users/sorc1/followers","following_url":"https://api.github.com/users/sorc1/following{/other_user}","gists_url":"https://api.github.com/users/sorc1/gists{/gist_id}","starred_url":"https://api.github.com/users/sorc1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorc1/subscriptions","organizations_url":"https://api.github.com/users/sorc1/orgs","repos_url":"https://api.github.com/users/sorc1/repos","events_url":"https://api.github.com/users/sorc1/events{/privacy}","received_events_url":"https://api.github.com/users/sorc1/received_events","type":"User","site_admin":false},"labels":[{"id":55629184,"node_id":"MDU6TGFiZWw1NTYyOTE4NA==","url":"https://api.github.com/repos/tarantool/tarantool/labels/bug","name":"bug","color":"eb6420","default":true}],"state":"closed","locked":false,"assignee":{"login":"kshcherbatov","id":9724311,"node_id":"MDQ6VXNlcjk3MjQzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9724311?v=4","gravatar_id":"","url":"https://api.github.com/users/kshcherbatov","html_url":"https://github.com/kshcherbatov","followers_url":"https://api.github.com/users/kshcherbatov/followers","following_url":"https://api.github.com/users/kshcherbatov/following{/other_user}","gists_url":"https://api.github.com/users/kshcherbatov/gists{/gist_id}","starred_url":"https://api.github.com/users/kshcherbatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshcherbatov/subscriptions","organizations_url":"https://api.github.com/users/kshcherbatov/orgs","repos_url":"https://api.github.com/users/kshcherbatov/repos","events_url":"https://api.github.com/users/kshcherbatov/events{/privacy}","received_events_url":"https://api.github.com/users/kshcherbatov/received_events","type":"User","site_admin":false},"assignees":[{"login":"kshcherbatov","id":9724311,"node_id":"MDQ6VXNlcjk3MjQzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9724311?v=4","gravatar_id":"","url":"https://api.github.com/users/kshcherbatov","html_url":"https://github.com/kshcherbatov","followers_url":"https://api.github.com/users/kshcherbatov/followers","following_url":"https://api.github.com/users/kshcherbatov/following{/other_user}","gists_url":"https://api.github.com/users/kshcherbatov/gists{/gist_id}","starred_url":"https://api.github.com/users/kshcherbatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshcherbatov/subscriptions","organizations_url":"https://api.github.com/users/kshcherbatov/orgs","repos_url":"https://api.github.com/users/kshcherbatov/repos","events_url":"https://api.github.com/users/kshcherbatov/events{/privacy}","received_events_url":"https://api.github.com/users/kshcherbatov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tarantool/tarantool/milestones/32","html_url":"https://github.com/tarantool/tarantool/milestone/32","labels_url":"https://api.github.com/repos/tarantool/tarantool/milestones/32/labels","id":3342146,"node_id":"MDk6TWlsZXN0b25lMzM0MjE0Ng==","number":32,"title":"1.9.2","description":"Next minor in 1.9 series - bug fixes only","creator":{"login":"kostja","id":482910,"node_id":"MDQ6VXNlcjQ4MjkxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/482910?v=4","gravatar_id":"","url":"https://api.github.com/users/kostja","html_url":"https://github.com/kostja","followers_url":"https://api.github.com/users/kostja/followers","following_url":"https://api.github.com/users/kostja/following{/other_user}","gists_url":"https://api.github.com/users/kostja/gists{/gist_id}","starred_url":"https://api.github.com/users/kostja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostja/subscriptions","organizations_url":"https://api.github.com/users/kostja/orgs","repos_url":"https://api.github.com/users/kostja/repos","events_url":"https://api.github.com/users/kostja/events{/privacy}","received_events_url":"https://api.github.com/users/kostja/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":27,"state":"open","created_at":"2018-05-13T18:04:16Z","updated_at":"2018-07-19T16:09:24Z","due_on":"2018-08-01T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-05-30T09:51:58Z","updated_at":"2018-07-19T16:09:24Z","closed_at":"2018-07-19T16:09:24Z","author_association":"NONE","body":"C say() macro has has invalid arguments.\r\n```\r\n#define say(level, format, ...) ({ \\\r\n\tif (say_log_level_is_enabled(level)) \\\r\n\t\t_say(level, __FILE__, __LINE__, format, ##__VA_ARGS__); })\r\n```\r\nBut _say is of sayfunc_t which is declared as:\r\n```\r\ntypedef void (*sayfunc_t)(int, const char *, int, const char *,\r\n\t\t    const char *, ...);\r\n```\r\nNote that say_*() macroses pass NULL as an extra (const char \\*) argument:\r\n```\r\n#define say_error(format, ...) say(S_ERROR, NULL, format, ##__VA_ARGS__)\r\n```\r\n\r\nSo, my suggestion is to add an extra 'error' argument before 'format' one to say(). That doesn't break API & ABI so it can be done for v1.7."}}
{"actor":{"display_login":"kyukhin"}}