{"action":"opened","number":750,"pull_request":{"url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750","id":210884480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODg0NDgw","html_url":"https://github.com/rustwasm/wasm-bindgen/pull/750","diff_url":"https://github.com/rustwasm/wasm-bindgen/pull/750.diff","patch_url":"https://github.com/rustwasm/wasm-bindgen/pull/750.patch","issue_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/750","number":750,"state":"open","locked":false,"title":"Add support for modules importing memory","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"The default of Rust wasm binaries is to export the memory that they contain, but\r\nLLD also supports an `--import-memory` option where memory is imported into a\r\nmodule instead. It's looking like importing memory is along the lines of how\r\nshared memory wasm modules will work (they'll all import the same memory).\r\n\r\nThis commit adds support to wasm-bindgen to support modules which import memory.\r\nMemory accessors are tweaked to no longer always assume that the wasm module\r\nexports its memory. Additionally JS bindings will create a `memory` option\r\nautomatically because LLD always imports memory from an `env` module which won't\r\nactually exist.","created_at":"2018-08-25T04:12:24Z","updated_at":"2018-08-25T04:12:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750/commits","review_comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750/comments","review_comment_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/750/comments","statuses_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/d3430b37e002410a8895be274458acd8b5561209","head":{"label":"alexcrichton:import-memory","ref":"import-memory","sha":"d3430b37e002410a8895be274458acd8b5561209","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":139736728,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MzY3Mjg=","name":"wasm-bindgen","full_name":"alexcrichton/wasm-bindgen","owner":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/wasm-bindgen","description":"Repository has moved","fork":true,"url":"https://api.github.com/repos/alexcrichton/wasm-bindgen","forks_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/forks","keys_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/teams","hooks_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/events","assignees_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/tags","blobs_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/subscription","commits_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/merges","archive_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/downloads","issues_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/deployments","created_at":"2018-07-04T15:04:06Z","updated_at":"2018-07-05T16:38:14Z","pushed_at":"2018-08-25T04:12:08Z","git_url":"git://github.com/alexcrichton/wasm-bindgen.git","ssh_url":"git@github.com:alexcrichton/wasm-bindgen.git","clone_url":"https://github.com/alexcrichton/wasm-bindgen.git","svn_url":"https://github.com/alexcrichton/wasm-bindgen","homepage":"https://github.com/rustwasm/wasm-bindgen","size":3168,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustwasm:master","ref":"master","sha":"8ce7465bbac8215074f196a3f2afe853efc35f92","user":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"repo":{"id":114685405,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2ODU0MDU=","name":"wasm-bindgen","full_name":"rustwasm/wasm-bindgen","owner":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rustwasm/wasm-bindgen","description":"Facilitating high-level interactions between wasm modules and JavaScript","fork":false,"url":"https://api.github.com/repos/rustwasm/wasm-bindgen","forks_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/forks","keys_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/teams","hooks_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/hooks","issue_events_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/events","assignees_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/tags","blobs_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/languages","stargazers_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/stargazers","contributors_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/contributors","subscribers_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/subscribers","subscription_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/subscription","commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/merges","archive_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/downloads","issues_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/deployments","created_at":"2017-12-18T20:38:44Z","updated_at":"2018-08-24T18:17:19Z","pushed_at":"2018-08-25T03:50:06Z","git_url":"git://github.com/rustwasm/wasm-bindgen.git","ssh_url":"git@github.com:rustwasm/wasm-bindgen.git","clone_url":"https://github.com/rustwasm/wasm-bindgen.git","svn_url":"https://github.com/rustwasm/wasm-bindgen","homepage":"https://rustwasm.github.io/wasm-bindgen/","size":8899,"stargazers_count":1244,"watchers_count":1244,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":137,"open_issues":72,"watchers":1244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750"},"html":{"href":"https://github.com/rustwasm/wasm-bindgen/pull/750"},"issue":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/750"},"comments":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/d3430b37e002410a8895be274458acd8b5561209"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":53,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"alexcrichton"}}