{"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70","id":215921957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTIxOTU3","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/70","diff_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/70.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/70.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/70","number":70,"state":"closed","locked":false,"title":"BASW-222: Add Membership Line to Standard Multi-line Membership Order - Next Period","user":{"login":"16kilobyte","id":10977550,"node_id":"MDQ6VXNlcjEwOTc3NTUw","avatar_url":"https://avatars1.githubusercontent.com/u/10977550?v=4","gravatar_id":"","url":"https://api.github.com/users/16kilobyte","html_url":"https://github.com/16kilobyte","followers_url":"https://api.github.com/users/16kilobyte/followers","following_url":"https://api.github.com/users/16kilobyte/following{/other_user}","gists_url":"https://api.github.com/users/16kilobyte/gists{/gist_id}","starred_url":"https://api.github.com/users/16kilobyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/16kilobyte/subscriptions","organizations_url":"https://api.github.com/users/16kilobyte/orgs","repos_url":"https://api.github.com/users/16kilobyte/repos","events_url":"https://api.github.com/users/16kilobyte/events{/privacy}","received_events_url":"https://api.github.com/users/16kilobyte/received_events","type":"User","site_admin":false},"body":"# Overiew\r\nIn the \"View/Modify Future Instalments\" next period tab, user can use \"Add Membership\" and \"Add Other Amount\" buttons to add line items to the current order.\r\nOnce the \"Add Membership\" is clicked, a new row should appear in next period tab with the following information:\r\n- Item - required - a dropdown contains all membership types which are not belong to any of the membership organisation for the existing lines\r\n- Financial type - text showing the financial type of the selected membership\r\n- Tax - text showing the tax percentage of the financial type, show N/A if there is no tax account in the financial type\r\n- Amount - required - a money input box defaulted to the minimum_fee of the membership type divided by number_of_instalments.\r\n- cross icon - cancel action\r\n- check icon - confirm action\r\n\r\nWhen a row is added but not yet confirmed/ cancelled, any parts of the modal popup other then the row itself should be made unclickable. If the user tries to click on any other parts, the row should flash to remind the user an item is yet to be completed.\r\n\r\nIf user clicked on cross icon, the row should be cancelled and no change is made.\r\n\r\nWhen user clicked on the check icon, a dialog with title \"Add LINE_ITEM_LABEL ?\" should appear with the following components:\r\n- dialog body text - \"Please note the changes should take effect immediately after \"Apply\".\"\r\n- Cancel button\r\n- Apply button\r\n\r\nIf user click on \"Apply\" button:\r\n- a line item with empty contribution_id should be created according to the information user inputted. Note that the tax_amount will calculated by multiplying amount with tax rate.\r\n- a *membershipextras_subscription_line* should be created linking the line item and the recurring contribution. It's start date and end date should be empty.\r\n- a notice should appear with text \"LINE_ITEM_LABEL will now be continued in the next period.\"\r\n- the content of \"Manage Instalments\" modal should be reloaded.\r\n\r\nIf user clicked on \"Cancel\", the action should be cancelled and no change is made.\r\n\r\nUser can also check \"Renew automatically\" field for any of membership lines in \"Current period\" tab to perform the same action. A notice with warning sign will appear with text \"This membership type is already enrolled in next period.\" when there is another *membershipextras_subscription_line*:\r\n- linked to a line item with same membership type and *membershipextras_subscription_line*\r\n- end date is empty\r\n- auto-renew is TRUE\r\n\r\nIf user checks the \"Renew automatically\" field for any of membership lines in \"Current period\" tab and the scenario in point 8 does not apply, point 5-7 should apply here.\r\n\r\n# Before\r\nAction did not exist\r\n\r\n# After\r\nAction was added only to offline manual payment recurring contributions.\r\n![Recurring Contribution's Next Period Tab](https://raw.githubusercontent.com/katorjames-compucorp/screenshots/master/AddMembership.gif \"Recurring Contribution's Next Period Tab\")\r\n\r\n![Recurring Contribution's Next Period Tab](https://raw.githubusercontent.com/katorjames-compucorp/screenshots/master/RemoveLineItemAndReAdd.gif \"Recurring Contribution's Next Period Tab\")\r\n\r\n","created_at":"2018-09-17T09:37:02Z","updated_at":"2018-09-17T17:44:29Z","closed_at":"2018-09-17T17:44:29Z","merged_at":"2018-09-17T17:44:29Z","merge_commit_sha":"22940014a909f407f8fdd3fb06324fbb53c98fd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/70/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/443f0638ab0a13690304f5dd82331f98b34ca700","head":{"label":"compucorp:BASW-222-add-membership-line-to-standard-multi-line-membership-order-next-period","ref":"BASW-222-add-membership-line-to-standard-multi-line-membership-order-next-period","sha":"443f0638ab0a13690304f5dd82331f98b34ca700","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1NDMyODM=","name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-09-17T09:07:31Z","pushed_at":"2018-09-17T17:44:29Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":377,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"compucorp:workstream-BASW-112-pp-phase-3","ref":"workstream-BASW-112-pp-phase-3","sha":"9ea402001ab285650dd5b6511d639bc37a7c336d","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1NDMyODM=","name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-09-17T09:07:31Z","pushed_at":"2018-09-17T17:44:29Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":377,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/70"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/70"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/443f0638ab0a13690304f5dd82331f98b34ca700"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"16kilobyte","id":10977550,"node_id":"MDQ6VXNlcjEwOTc3NTUw","avatar_url":"https://avatars1.githubusercontent.com/u/10977550?v=4","gravatar_id":"","url":"https://api.github.com/users/16kilobyte","html_url":"https://github.com/16kilobyte","followers_url":"https://api.github.com/users/16kilobyte/followers","following_url":"https://api.github.com/users/16kilobyte/following{/other_user}","gists_url":"https://api.github.com/users/16kilobyte/gists{/gist_id}","starred_url":"https://api.github.com/users/16kilobyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/16kilobyte/subscriptions","organizations_url":"https://api.github.com/users/16kilobyte/orgs","repos_url":"https://api.github.com/users/16kilobyte/repos","events_url":"https://api.github.com/users/16kilobyte/events{/privacy}","received_events_url":"https://api.github.com/users/16kilobyte/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":7,"additions":300,"deletions":216,"changed_files":5}}
{"actor":{"display_login":"16kilobyte"}}