{"action":"created","issue":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/565","repository_url":"https://api.github.com/repos/lightningnetwork/lnd","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/565/labels{/name}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/565/comments","events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/565/events","html_url":"https://github.com/lightningnetwork/lnd/pull/565","id":286499721,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYxNDg2OTg1","number":565,"title":"Add pagination options to listchaintxns","user":{"login":"34ro","id":2033895,"node_id":"MDQ6VXNlcjIwMzM4OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2033895?v=4","gravatar_id":"","url":"https://api.github.com/users/34ro","html_url":"https://github.com/34ro","followers_url":"https://api.github.com/users/34ro/followers","following_url":"https://api.github.com/users/34ro/following{/other_user}","gists_url":"https://api.github.com/users/34ro/gists{/gist_id}","starred_url":"https://api.github.com/users/34ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/34ro/subscriptions","organizations_url":"https://api.github.com/users/34ro/orgs","repos_url":"https://api.github.com/users/34ro/repos","events_url":"https://api.github.com/users/34ro/events{/privacy}","received_events_url":"https://api.github.com/users/34ro/received_events","type":"User","site_admin":false},"labels":[{"id":990013523,"node_id":"MDU6TGFiZWw5OTAwMTM1MjM=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/P3","name":"P3","color":"0e8a16","default":false},{"id":827124220,"node_id":"MDU6TGFiZWw4MjcxMjQyMjA=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/cli","name":"cli","color":"b5741b","default":false},{"id":990064593,"node_id":"MDU6TGFiZWw5OTAwNjQ1OTM=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/first%20pass%20review%20done","name":"first pass review done","color":"bf333c","default":false},{"id":990066698,"node_id":"MDU6TGFiZWw5OTAwNjY2OTg=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/needs%20rebase","name":"needs rebase","color":"1cc605","default":false},{"id":990064318,"node_id":"MDU6TGFiZWw5OTAwNjQzMTg=","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/needs%20testing","name":"needs testing","color":"a4f963","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/7","html_url":"https://github.com/lightningnetwork/lnd/milestone/7","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/7/labels","id":3246846,"node_id":"MDk6TWlsZXN0b25lMzI0Njg0Ng==","number":7,"title":"0.5","description":null,"creator":{"login":"Roasbeef","id":998190,"node_id":"MDQ6VXNlcjk5ODE5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/998190?v=4","gravatar_id":"","url":"https://api.github.com/users/Roasbeef","html_url":"https://github.com/Roasbeef","followers_url":"https://api.github.com/users/Roasbeef/followers","following_url":"https://api.github.com/users/Roasbeef/following{/other_user}","gists_url":"https://api.github.com/users/Roasbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/Roasbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roasbeef/subscriptions","organizations_url":"https://api.github.com/users/Roasbeef/orgs","repos_url":"https://api.github.com/users/Roasbeef/repos","events_url":"https://api.github.com/users/Roasbeef/events{/privacy}","received_events_url":"https://api.github.com/users/Roasbeef/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":31,"state":"open","created_at":"2018-04-06T04:09:02Z","updated_at":"2018-07-24T00:46:38Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-01-06T16:57:59Z","updated_at":"2018-07-24T07:37:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/565","html_url":"https://github.com/lightningnetwork/lnd/pull/565","diff_url":"https://github.com/lightningnetwork/lnd/pull/565.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/565.patch"},"body":"This PR adds pagination to listchaintxns.\r\nIt prevents client application from out of memory when the number of transactions increases.\r\n\r\nThe new options are `offset` and `limit`.\r\nOffset is the numer of transactions to skip.\r\nLimit is max numer of transactions.\r\nRPC also has same request field.\r\n\r\n```\r\n./lncli listchaintxns --offset=100 --limit=50\r\n```\r\n\r\nAll merged transactions and unmerged transactions are sort by timestamp.\r\nI think sorting by timestamp is the best because it makes order invariable. "},"comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments/407311398","html_url":"https://github.com/lightningnetwork/lnd/pull/565#issuecomment-407311398","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/565","id":407311398,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzMxMTM5OA==","user":{"login":"halseth","id":3765732,"node_id":"MDQ6VXNlcjM3NjU3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T07:37:59Z","updated_at":"2018-07-24T07:37:59Z","author_association":"COLLABORATOR","body":"@34ro Check if your account has been flagged on Travis. if it has you'll have to e-mail them to un-flag it :/ "}}
{"actor":{"display_login":"halseth"}}