{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/6312","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/6312/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6312/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/6312/events","html_url":"https://github.com/status-im/status-react/pull/6312","id":370110176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODY1MzE3","number":6312,"title":"WIP feature #6297 - wallet on desktop","user":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"labels":[{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false},{"id":903584960,"node_id":"MDU6TGFiZWw5MDM1ODQ5NjA=","url":"https://api.github.com/repos/status-im/status-react/labels/security","name":"security","color":"ab08d3","default":false},{"id":691030971,"node_id":"MDU6TGFiZWw2OTEwMzA5NzE=","url":"https://api.github.com/repos/status-im/status-react/labels/wallet","name":"wallet","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"assignees":[{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2018-10-15T11:02:51Z","updated_at":"2018-11-28T14:39:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6312","html_url":"https://github.com/status-im/status-react/pull/6312","diff_url":"https://github.com/status-im/status-react/pull/6312.diff","patch_url":"https://github.com/status-im/status-react/pull/6312.patch"},"body":"fixes #6297\r\n\r\n### Summary:\r\n\r\nWallet on Desktop. Added a tab, which displays main wallet screen in main area. Sidebar is empty.\r\nBasic wallet functionality is also there, with some noted exceptions.\r\n\r\nWhat works:\r\n- signing phrase onboarding\r\n- display of balance and tokens in main wallet screen\r\n- adding/removing enabled tokens\r\n- send transaction to contact or by address\r\n- show own address qr in receive transaction\r\n- set custom gas settings\r\n\r\nWhat does not work:\r\n- send a transaction request (we have no chat commands on desktop yet)\r\n- transaction history (http calls don't work on desktop, at least not on linux) - status-im/react-native-desktop#373\r\n- set recipient by scanning qr (camera on desktop not supported)\r\n- generally this PR does only main Wallet tab, not chat commands and not dapp transactions.\r\n- network switching, only mainnet\r\n- offline detection - always says it's offline on linux, so it's being ignored by wallet when on desktop\r\n\r\nNotable responsiveness issues:\r\n- missing title in Assets selection screen (the one where you enable/disable tokens)\r\n- blue area below token list in main wallet screen\r\n- missing component that displays menu popups - using dialog as a short term solution\r\n- checkbox component is weird on desktop\r\n\r\n## Testing notes (optional):\r\n\r\nAll platforms should be tested - shared code was affected.\r\n\r\n#### Platforms (optional)\r\n- Android\r\n- iOS\r\n- macOS\r\n- Linux\r\n\r\n#### Areas that maybe impacted (optional)\r\n**Functional**\r\n- wallet / transactions\r\n\r\nstatus: ready "},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/442469403","html_url":"https://github.com/status-im/status-react/pull/6312#issuecomment-442469403","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6312","id":442469403,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjQ2OTQwMw==","user":{"login":"chadyj","id":116099,"node_id":"MDQ6VXNlcjExNjA5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/116099?v=4","gravatar_id":"","url":"https://api.github.com/users/chadyj","html_url":"https://github.com/chadyj","followers_url":"https://api.github.com/users/chadyj/followers","following_url":"https://api.github.com/users/chadyj/following{/other_user}","gists_url":"https://api.github.com/users/chadyj/gists{/gist_id}","starred_url":"https://api.github.com/users/chadyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadyj/subscriptions","organizations_url":"https://api.github.com/users/chadyj/orgs","repos_url":"https://api.github.com/users/chadyj/repos","events_url":"https://api.github.com/users/chadyj/events{/privacy}","received_events_url":"https://api.github.com/users/chadyj/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T14:39:27Z","updated_at":"2018-11-28T14:39:27Z","author_association":"MEMBER","body":"Pro of 2 pane is it's compatible with mobile implementation and doesn't require a dedicated redesign.\r\n\r\nCon? No designs. Double implementation?"}}
{"actor":{"display_login":"chadyj"}}