{"action":"created","issue":{"url":"https://api.github.com/repos/wprig/wprig/issues/176","repository_url":"https://api.github.com/repos/wprig/wprig","labels_url":"https://api.github.com/repos/wprig/wprig/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/wprig/wprig/issues/176/comments","events_url":"https://api.github.com/repos/wprig/wprig/issues/176/events","html_url":"https://github.com/wprig/wprig/pull/176","id":381673902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTg4NDUz","number":176,"title":"Get the theme version from theme object","user":{"login":"benoitchantre","id":1521015,"node_id":"MDQ6VXNlcjE1MjEwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1521015?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitchantre","html_url":"https://github.com/benoitchantre","followers_url":"https://api.github.com/users/benoitchantre/followers","following_url":"https://api.github.com/users/benoitchantre/following{/other_user}","gists_url":"https://api.github.com/users/benoitchantre/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitchantre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitchantre/subscriptions","organizations_url":"https://api.github.com/users/benoitchantre/orgs","repos_url":"https://api.github.com/users/benoitchantre/repos","events_url":"https://api.github.com/users/benoitchantre/events{/privacy}","received_events_url":"https://api.github.com/users/benoitchantre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"felixarntz","id":3531426,"node_id":"MDQ6VXNlcjM1MzE0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3531426?v=4","gravatar_id":"","url":"https://api.github.com/users/felixarntz","html_url":"https://github.com/felixarntz","followers_url":"https://api.github.com/users/felixarntz/followers","following_url":"https://api.github.com/users/felixarntz/following{/other_user}","gists_url":"https://api.github.com/users/felixarntz/gists{/gist_id}","starred_url":"https://api.github.com/users/felixarntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixarntz/subscriptions","organizations_url":"https://api.github.com/users/felixarntz/orgs","repos_url":"https://api.github.com/users/felixarntz/repos","events_url":"https://api.github.com/users/felixarntz/events{/privacy}","received_events_url":"https://api.github.com/users/felixarntz/received_events","type":"User","site_admin":false},"assignees":[{"login":"felixarntz","id":3531426,"node_id":"MDQ6VXNlcjM1MzE0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3531426?v=4","gravatar_id":"","url":"https://api.github.com/users/felixarntz","html_url":"https://github.com/felixarntz","followers_url":"https://api.github.com/users/felixarntz/followers","following_url":"https://api.github.com/users/felixarntz/following{/other_user}","gists_url":"https://api.github.com/users/felixarntz/gists{/gist_id}","starred_url":"https://api.github.com/users/felixarntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixarntz/subscriptions","organizations_url":"https://api.github.com/users/felixarntz/orgs","repos_url":"https://api.github.com/users/felixarntz/repos","events_url":"https://api.github.com/users/felixarntz/events{/privacy}","received_events_url":"https://api.github.com/users/felixarntz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-16T16:36:33Z","updated_at":"2018-11-20T18:50:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wprig/wprig/pulls/176","html_url":"https://github.com/wprig/wprig/pull/176","diff_url":"https://github.com/wprig/wprig/pull/176.diff","patch_url":"https://github.com/wprig/wprig/pull/176.patch"},"body":"<!-- Thank you for submitting a pull request to these course assets. Please provide information about the changes: What issue they fix, how they solve the issue, and why the solution works. -->\r\n\r\n## Description\r\n<!-- Add the issue number this pull request addresses: -->\r\nIteration on PR #164.\r\n\r\n<!-- Please describe your pull request. -->\r\nGet the theme version dynamically instead of having to update it manually. Related to comments in #39.\r\n\r\n## List of changes\r\n<!-- Please describe what was changed/added. -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n- [ ] This pull request relates to a ticket.\r\n- [x] My code is tested.\r\n- [x] I want my code added to WP Rig.\r\n"},"comment":{"url":"https://api.github.com/repos/wprig/wprig/issues/comments/440388564","html_url":"https://github.com/wprig/wprig/pull/176#issuecomment-440388564","issue_url":"https://api.github.com/repos/wprig/wprig/issues/176","id":440388564,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDM4ODU2NA==","user":{"login":"felixarntz","id":3531426,"node_id":"MDQ6VXNlcjM1MzE0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3531426?v=4","gravatar_id":"","url":"https://api.github.com/users/felixarntz","html_url":"https://github.com/felixarntz","followers_url":"https://api.github.com/users/felixarntz/followers","following_url":"https://api.github.com/users/felixarntz/following{/other_user}","gists_url":"https://api.github.com/users/felixarntz/gists{/gist_id}","starred_url":"https://api.github.com/users/felixarntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixarntz/subscriptions","organizations_url":"https://api.github.com/users/felixarntz/orgs","repos_url":"https://api.github.com/users/felixarntz/repos","events_url":"https://api.github.com/users/felixarntz/events{/privacy}","received_events_url":"https://api.github.com/users/felixarntz/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T18:50:08Z","updated_at":"2018-11-20T18:50:08Z","author_association":"MEMBER","body":"I like this approach because it allows us to not define the theme version anywhere else, good call!\r\n\r\nOne thing that we should consider though is how often `wp_rig_get_asset_version()` is called. We should internally cache the call to `wp_get_theme( get_template() )->get( 'Version' )` in a static variable or something, just to ensure it's only called once. It will provide the same value on every call anyway."}}
{"actor":{"display_login":"felixarntz"}}