{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/benhoyt/goawk/pulls/4","id":209394523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mzk0NTIz","html_url":"https://github.com/benhoyt/goawk/pull/4","diff_url":"https://github.com/benhoyt/goawk/pull/4.diff","patch_url":"https://github.com/benhoyt/goawk/pull/4.patch","issue_url":"https://api.github.com/repos/benhoyt/goawk/issues/4","number":4,"state":"open","locked":false,"title":"interpret sprintf args in types-base #3","user":{"login":"u5surf","id":14180225,"node_id":"MDQ6VXNlcjE0MTgwMjI1","avatar_url":"https://avatars1.githubusercontent.com/u/14180225?v=4","gravatar_id":"","url":"https://api.github.com/users/u5surf","html_url":"https://github.com/u5surf","followers_url":"https://api.github.com/users/u5surf/followers","following_url":"https://api.github.com/users/u5surf/following{/other_user}","gists_url":"https://api.github.com/users/u5surf/gists{/gist_id}","starred_url":"https://api.github.com/users/u5surf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u5surf/subscriptions","organizations_url":"https://api.github.com/users/u5surf/orgs","repos_url":"https://api.github.com/users/u5surf/repos","events_url":"https://api.github.com/users/u5surf/events{/privacy}","received_events_url":"https://api.github.com/users/u5surf/received_events","type":"User","site_admin":false},"body":"#3 \r\nOriginal-awk accepts extra arguments. \r\nAnd I found sprintf in interp.go is argment-based interpret, so I fix types-based(array which format specifiers) interpret.\r\nIf the number of format specifiers is more than the num of argments, it shows format error message and exit 1.\r\n```\r\n[yugo-horie@goawk 10:53:06]$go run goawk.go 'BEGIN { sprintf(\"%d \", 1, 2) }'\r\n[yugo-horie@goawk 10:54:17]$go run goawk.go 'BEGIN { sprintf(\"%d %d\", 1, 2) }'\r\n[yugo-horie@goawk 10:54:22]$go run goawk.go 'BEGIN { sprintf(\"%d %d %d\", 1, 2) }'\r\nformat error: got 2 args, expected 3\r\nexit status 1\r\n```\r\nIf it's looks good for you please merge it.","created_at":"2018-08-20T02:00:43Z","updated_at":"2018-08-20T02:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/benhoyt/goawk/pulls/4/commits","review_comments_url":"https://api.github.com/repos/benhoyt/goawk/pulls/4/comments","review_comment_url":"https://api.github.com/repos/benhoyt/goawk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benhoyt/goawk/issues/4/comments","statuses_url":"https://api.github.com/repos/benhoyt/goawk/statuses/34c9ad7d8023a5673109775b1b84b9e5857f0a2c","head":{"label":"u5surf:interp_sprintf_typesbase","ref":"interp_sprintf_typesbase","sha":"34c9ad7d8023a5673109775b1b84b9e5857f0a2c","user":{"login":"u5surf","id":14180225,"node_id":"MDQ6VXNlcjE0MTgwMjI1","avatar_url":"https://avatars1.githubusercontent.com/u/14180225?v=4","gravatar_id":"","url":"https://api.github.com/users/u5surf","html_url":"https://github.com/u5surf","followers_url":"https://api.github.com/users/u5surf/followers","following_url":"https://api.github.com/users/u5surf/following{/other_user}","gists_url":"https://api.github.com/users/u5surf/gists{/gist_id}","starred_url":"https://api.github.com/users/u5surf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u5surf/subscriptions","organizations_url":"https://api.github.com/users/u5surf/orgs","repos_url":"https://api.github.com/users/u5surf/repos","events_url":"https://api.github.com/users/u5surf/events{/privacy}","received_events_url":"https://api.github.com/users/u5surf/received_events","type":"User","site_admin":false},"repo":{"id":145351832,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzNTE4MzI=","name":"goawk","full_name":"u5surf/goawk","owner":{"login":"u5surf","id":14180225,"node_id":"MDQ6VXNlcjE0MTgwMjI1","avatar_url":"https://avatars1.githubusercontent.com/u/14180225?v=4","gravatar_id":"","url":"https://api.github.com/users/u5surf","html_url":"https://github.com/u5surf","followers_url":"https://api.github.com/users/u5surf/followers","following_url":"https://api.github.com/users/u5surf/following{/other_user}","gists_url":"https://api.github.com/users/u5surf/gists{/gist_id}","starred_url":"https://api.github.com/users/u5surf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u5surf/subscriptions","organizations_url":"https://api.github.com/users/u5surf/orgs","repos_url":"https://api.github.com/users/u5surf/repos","events_url":"https://api.github.com/users/u5surf/events{/privacy}","received_events_url":"https://api.github.com/users/u5surf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/u5surf/goawk","description":"GoAWK: an AWK interpreter written in Go","fork":true,"url":"https://api.github.com/repos/u5surf/goawk","forks_url":"https://api.github.com/repos/u5surf/goawk/forks","keys_url":"https://api.github.com/repos/u5surf/goawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u5surf/goawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u5surf/goawk/teams","hooks_url":"https://api.github.com/repos/u5surf/goawk/hooks","issue_events_url":"https://api.github.com/repos/u5surf/goawk/issues/events{/number}","events_url":"https://api.github.com/repos/u5surf/goawk/events","assignees_url":"https://api.github.com/repos/u5surf/goawk/assignees{/user}","branches_url":"https://api.github.com/repos/u5surf/goawk/branches{/branch}","tags_url":"https://api.github.com/repos/u5surf/goawk/tags","blobs_url":"https://api.github.com/repos/u5surf/goawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u5surf/goawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u5surf/goawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/u5surf/goawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u5surf/goawk/statuses/{sha}","languages_url":"https://api.github.com/repos/u5surf/goawk/languages","stargazers_url":"https://api.github.com/repos/u5surf/goawk/stargazers","contributors_url":"https://api.github.com/repos/u5surf/goawk/contributors","subscribers_url":"https://api.github.com/repos/u5surf/goawk/subscribers","subscription_url":"https://api.github.com/repos/u5surf/goawk/subscription","commits_url":"https://api.github.com/repos/u5surf/goawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/u5surf/goawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/u5surf/goawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/u5surf/goawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/u5surf/goawk/contents/{+path}","compare_url":"https://api.github.com/repos/u5surf/goawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u5surf/goawk/merges","archive_url":"https://api.github.com/repos/u5surf/goawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u5surf/goawk/downloads","issues_url":"https://api.github.com/repos/u5surf/goawk/issues{/number}","pulls_url":"https://api.github.com/repos/u5surf/goawk/pulls{/number}","milestones_url":"https://api.github.com/repos/u5surf/goawk/milestones{/number}","notifications_url":"https://api.github.com/repos/u5surf/goawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u5surf/goawk/labels{/name}","releases_url":"https://api.github.com/repos/u5surf/goawk/releases{/id}","deployments_url":"https://api.github.com/repos/u5surf/goawk/deployments","created_at":"2018-08-20T01:34:05Z","updated_at":"2018-08-20T01:34:07Z","pushed_at":"2018-08-20T01:46:55Z","git_url":"git://github.com/u5surf/goawk.git","ssh_url":"git@github.com:u5surf/goawk.git","clone_url":"https://github.com/u5surf/goawk.git","svn_url":"https://github.com/u5surf/goawk","homepage":"","size":419,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benhoyt:master","ref":"master","sha":"408d972561ee9da2b1bda4121e129f5b18b5b5f1","user":{"login":"benhoyt","id":999033,"node_id":"MDQ6VXNlcjk5OTAzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/999033?v=4","gravatar_id":"","url":"https://api.github.com/users/benhoyt","html_url":"https://github.com/benhoyt","followers_url":"https://api.github.com/users/benhoyt/followers","following_url":"https://api.github.com/users/benhoyt/following{/other_user}","gists_url":"https://api.github.com/users/benhoyt/gists{/gist_id}","starred_url":"https://api.github.com/users/benhoyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhoyt/subscriptions","organizations_url":"https://api.github.com/users/benhoyt/orgs","repos_url":"https://api.github.com/users/benhoyt/repos","events_url":"https://api.github.com/users/benhoyt/events{/privacy}","received_events_url":"https://api.github.com/users/benhoyt/received_events","type":"User","site_admin":false},"repo":{"id":136558084,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1NTgwODQ=","name":"goawk","full_name":"benhoyt/goawk","owner":{"login":"benhoyt","id":999033,"node_id":"MDQ6VXNlcjk5OTAzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/999033?v=4","gravatar_id":"","url":"https://api.github.com/users/benhoyt","html_url":"https://github.com/benhoyt","followers_url":"https://api.github.com/users/benhoyt/followers","following_url":"https://api.github.com/users/benhoyt/following{/other_user}","gists_url":"https://api.github.com/users/benhoyt/gists{/gist_id}","starred_url":"https://api.github.com/users/benhoyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhoyt/subscriptions","organizations_url":"https://api.github.com/users/benhoyt/orgs","repos_url":"https://api.github.com/users/benhoyt/repos","events_url":"https://api.github.com/users/benhoyt/events{/privacy}","received_events_url":"https://api.github.com/users/benhoyt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benhoyt/goawk","description":"GoAWK: an AWK interpreter written in Go","fork":false,"url":"https://api.github.com/repos/benhoyt/goawk","forks_url":"https://api.github.com/repos/benhoyt/goawk/forks","keys_url":"https://api.github.com/repos/benhoyt/goawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benhoyt/goawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benhoyt/goawk/teams","hooks_url":"https://api.github.com/repos/benhoyt/goawk/hooks","issue_events_url":"https://api.github.com/repos/benhoyt/goawk/issues/events{/number}","events_url":"https://api.github.com/repos/benhoyt/goawk/events","assignees_url":"https://api.github.com/repos/benhoyt/goawk/assignees{/user}","branches_url":"https://api.github.com/repos/benhoyt/goawk/branches{/branch}","tags_url":"https://api.github.com/repos/benhoyt/goawk/tags","blobs_url":"https://api.github.com/repos/benhoyt/goawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benhoyt/goawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benhoyt/goawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/benhoyt/goawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benhoyt/goawk/statuses/{sha}","languages_url":"https://api.github.com/repos/benhoyt/goawk/languages","stargazers_url":"https://api.github.com/repos/benhoyt/goawk/stargazers","contributors_url":"https://api.github.com/repos/benhoyt/goawk/contributors","subscribers_url":"https://api.github.com/repos/benhoyt/goawk/subscribers","subscription_url":"https://api.github.com/repos/benhoyt/goawk/subscription","commits_url":"https://api.github.com/repos/benhoyt/goawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/benhoyt/goawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/benhoyt/goawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/benhoyt/goawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/benhoyt/goawk/contents/{+path}","compare_url":"https://api.github.com/repos/benhoyt/goawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benhoyt/goawk/merges","archive_url":"https://api.github.com/repos/benhoyt/goawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benhoyt/goawk/downloads","issues_url":"https://api.github.com/repos/benhoyt/goawk/issues{/number}","pulls_url":"https://api.github.com/repos/benhoyt/goawk/pulls{/number}","milestones_url":"https://api.github.com/repos/benhoyt/goawk/milestones{/number}","notifications_url":"https://api.github.com/repos/benhoyt/goawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benhoyt/goawk/labels{/name}","releases_url":"https://api.github.com/repos/benhoyt/goawk/releases{/id}","deployments_url":"https://api.github.com/repos/benhoyt/goawk/deployments","created_at":"2018-06-08T02:53:23Z","updated_at":"2018-08-20T02:00:42Z","pushed_at":"2018-08-19T01:51:40Z","git_url":"git://github.com/benhoyt/goawk.git","ssh_url":"git@github.com:benhoyt/goawk.git","clone_url":"https://github.com/benhoyt/goawk.git","svn_url":"https://github.com/benhoyt/goawk","homepage":"","size":419,"stargazers_count":259,"watchers_count":259,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":4,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benhoyt/goawk/pulls/4"},"html":{"href":"https://github.com/benhoyt/goawk/pull/4"},"issue":{"href":"https://api.github.com/repos/benhoyt/goawk/issues/4"},"comments":{"href":"https://api.github.com/repos/benhoyt/goawk/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/benhoyt/goawk/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/benhoyt/goawk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benhoyt/goawk/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/benhoyt/goawk/statuses/34c9ad7d8023a5673109775b1b84b9e5857f0a2c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"u5surf"}}