{"action":"created","comment":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/comments/221459540","pull_request_review_id":160114738,"id":221459540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ1OTU0MA==","diff_hunk":"@@ -4,29 +4,48 @@ PortSystem       1.0\n \n name             openjdk10\n version          10.0.2\n+set              openjdk_version 10\n+\n+subport openjdk11 {\n+    version      11\n+    set          openjdk_version 11\n+    set          build 28\n+}\n \n categories       java devel\n maintainers      {breun.nl:nils @breun} openmaintainer\n platforms        darwin\n license          GPL-2\n supported_archs  x86_64\n \n-description      Open Java Development Kit 10\n+description      Open Java Development Kit ${openjdk_version}\n \n long_description Production-ready, free and open-source build of the Java \\\n                  Development Kit, an implementation of the Java Standard \\\n-                 Edition (SE) 10 Platform. OpenJDK is the official reference \\\n+                 Edition (SE) ${openjdk_version} Platform. OpenJDK is the official reference \\\n                  implementation of Java SE. Included components are the \\\n                  HotSpot virtual machine, the Java class library and the Java \\\n                  compiler. \n \n-homepage         http://jdk.java.net/10/\n-master_sites     https://download.java.net/java/GA/jdk10/${version}/19aef61b38124481863b1413dce1855f/13/\n-distname         openjdk-${version}_osx-x64_bin\n+homepage         http://jdk.java.net/${openjdk_version}/","path":"java/openjdk10/Portfile","position":32,"original_position":32,"commit_id":"4b23862c1752a2dfd649c6b1734d756d2ffe7e40","original_commit_id":"4b23862c1752a2dfd649c6b1734d756d2ffe7e40","user":{"login":"breun","id":102921,"node_id":"MDQ6VXNlcjEwMjkyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/102921?v=4","gravatar_id":"","url":"https://api.github.com/users/breun","html_url":"https://github.com/breun","followers_url":"https://api.github.com/users/breun/followers","following_url":"https://api.github.com/users/breun/following{/other_user}","gists_url":"https://api.github.com/users/breun/gists{/gist_id}","starred_url":"https://api.github.com/users/breun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breun/subscriptions","organizations_url":"https://api.github.com/users/breun/orgs","repos_url":"https://api.github.com/users/breun/repos","events_url":"https://api.github.com/users/breun/events{/privacy}","received_events_url":"https://api.github.com/users/breun/received_events","type":"User","site_admin":false},"body":"OpenJDK 10.0.2 this URL should be http://jdk.java.net/10/, but this resolves to http://jdk.java.net/10.0.2/ which doesn't not exist. Maybe we need a separate `major_version` variable for this? Or we set it separately per port?\r\n\r\nWould also be good to use the HTTPS version of this URL while we're at it.","created_at":"2018-09-30T13:34:38Z","updated_at":"2018-09-30T13:34:38Z","html_url":"https://github.com/macports/macports-ports/pull/2666#discussion_r221459540","pull_request_url":"https://api.github.com/repos/macports/macports-ports/pulls/2666","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/comments/221459540"},"html":{"href":"https://github.com/macports/macports-ports/pull/2666#discussion_r221459540"},"pull_request":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2666"}}},"pull_request":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/2666","id":219061879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDYxODc5","html_url":"https://github.com/macports/macports-ports/pull/2666","diff_url":"https://github.com/macports/macports-ports/pull/2666.diff","patch_url":"https://github.com/macports/macports-ports/pull/2666.patch","issue_url":"https://api.github.com/repos/macports/macports-ports/issues/2666","number":2666,"state":"open","locked":false,"title":"openjdk10: Add openjdk11 sub-port","user":{"login":"mf2k","id":22960744,"node_id":"MDQ6VXNlcjIyOTYwNzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/22960744?v=4","gravatar_id":"","url":"https://api.github.com/users/mf2k","html_url":"https://github.com/mf2k","followers_url":"https://api.github.com/users/mf2k/followers","following_url":"https://api.github.com/users/mf2k/following{/other_user}","gists_url":"https://api.github.com/users/mf2k/gists{/gist_id}","starred_url":"https://api.github.com/users/mf2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mf2k/subscriptions","organizations_url":"https://api.github.com/users/mf2k/orgs","repos_url":"https://api.github.com/users/mf2k/repos","events_url":"https://api.github.com/users/mf2k/events{/privacy}","received_events_url":"https://api.github.com/users/mf2k/received_events","type":"User","site_admin":false},"body":"#### Description\r\n\r\nopenjdk10: Add openjdk11 sub-port\r\n\r\n###### Type(s)\r\n<!-- update (title contains \": U(u)pdate to\"), submission (new Portfile) and CVE Identifiers are auto-detected, replace [ ] with [x] to select -->\r\n\r\n- [ ] bugfix\r\n- [X] enhancement\r\n- [ ] security fix\r\n\r\n###### Tested on\r\n<!-- Generate version information with this command in shell:\r\n    echo \"macOS $(sw_vers -productVersion) $(sw_vers -buildVersion)\"; echo \"Xcode $(xcodebuild -version | awk '{print $NF}' | tr '\\n' ' ')\"\r\n-->\r\nmacOS 10.13.6 17G65\r\nXcode 10.0 10A255 \r\n\r\n###### Verification <!-- (delete not applicable items) -->\r\nHave you\r\n\r\n- [X] followed our [Commit Message Guidelines](https://trac.macports.org/wiki/CommitMessages)?\r\n- [X] squashed and [minimized your commits](https://guide.macports.org/#project.github)?\r\n- [ ] checked that there aren't other open [pull requests](https://github.com/macports/macports-ports/pulls) for the same change?\r\n- [ ] referenced existing tickets on [Trac](https://trac.macports.org/wiki/Tickets) with full URL?\r\n<!-- Please don't open a new Trac ticket if you are submitting a pull request. -->\r\n- [X] checked your Portfile with `port lint`?\r\n- [ ] tried existing tests with `sudo port test`?\r\n- [X] tried a full install with `sudo port -vst install`?\r\n- [X] tested basic functionality of all binary files?\r\n\r\n<!-- Use \"skip notification\" (surrounded with []) to avoid notifying maintainers -->","created_at":"2018-09-28T19:18:31Z","updated_at":"2018-09-30T13:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57cf7fc10fbfa3c13b09e3fe8e7fa71e91bfe688","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":656296790,"node_id":"MDU6TGFiZWw2NTYyOTY3OTA=","url":"https://api.github.com/repos/macports/macports-ports/labels/by:%20member","name":"by: member","color":"c5def5","default":false},{"id":615645858,"node_id":"MDU6TGFiZWw2MTU2NDU4NTg=","url":"https://api.github.com/repos/macports/macports-ports/labels/maintainer:%20open","name":"maintainer: open","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/macports/macports-ports/pulls/2666/commits","review_comments_url":"https://api.github.com/repos/macports/macports-ports/pulls/2666/comments","review_comment_url":"https://api.github.com/repos/macports/macports-ports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/macports/macports-ports/issues/2666/comments","statuses_url":"https://api.github.com/repos/macports/macports-ports/statuses/4b23862c1752a2dfd649c6b1734d756d2ffe7e40","head":{"label":"mf2k:openjdk11","ref":"openjdk11","sha":"4b23862c1752a2dfd649c6b1734d756d2ffe7e40","user":{"login":"mf2k","id":22960744,"node_id":"MDQ6VXNlcjIyOTYwNzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/22960744?v=4","gravatar_id":"","url":"https://api.github.com/users/mf2k","html_url":"https://github.com/mf2k","followers_url":"https://api.github.com/users/mf2k/followers","following_url":"https://api.github.com/users/mf2k/following{/other_user}","gists_url":"https://api.github.com/users/mf2k/gists{/gist_id}","starred_url":"https://api.github.com/users/mf2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mf2k/subscriptions","organizations_url":"https://api.github.com/users/mf2k/orgs","repos_url":"https://api.github.com/users/mf2k/repos","events_url":"https://api.github.com/users/mf2k/events{/privacy}","received_events_url":"https://api.github.com/users/mf2k/received_events","type":"User","site_admin":false},"repo":{"id":150783732,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3ODM3MzI=","name":"macports-ports","full_name":"mf2k/macports-ports","private":false,"owner":{"login":"mf2k","id":22960744,"node_id":"MDQ6VXNlcjIyOTYwNzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/22960744?v=4","gravatar_id":"","url":"https://api.github.com/users/mf2k","html_url":"https://github.com/mf2k","followers_url":"https://api.github.com/users/mf2k/followers","following_url":"https://api.github.com/users/mf2k/following{/other_user}","gists_url":"https://api.github.com/users/mf2k/gists{/gist_id}","starred_url":"https://api.github.com/users/mf2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mf2k/subscriptions","organizations_url":"https://api.github.com/users/mf2k/orgs","repos_url":"https://api.github.com/users/mf2k/repos","events_url":"https://api.github.com/users/mf2k/events{/privacy}","received_events_url":"https://api.github.com/users/mf2k/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mf2k/macports-ports","description":"The MacPorts ports tree","fork":true,"url":"https://api.github.com/repos/mf2k/macports-ports","forks_url":"https://api.github.com/repos/mf2k/macports-ports/forks","keys_url":"https://api.github.com/repos/mf2k/macports-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mf2k/macports-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mf2k/macports-ports/teams","hooks_url":"https://api.github.com/repos/mf2k/macports-ports/hooks","issue_events_url":"https://api.github.com/repos/mf2k/macports-ports/issues/events{/number}","events_url":"https://api.github.com/repos/mf2k/macports-ports/events","assignees_url":"https://api.github.com/repos/mf2k/macports-ports/assignees{/user}","branches_url":"https://api.github.com/repos/mf2k/macports-ports/branches{/branch}","tags_url":"https://api.github.com/repos/mf2k/macports-ports/tags","blobs_url":"https://api.github.com/repos/mf2k/macports-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mf2k/macports-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mf2k/macports-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/mf2k/macports-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mf2k/macports-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/mf2k/macports-ports/languages","stargazers_url":"https://api.github.com/repos/mf2k/macports-ports/stargazers","contributors_url":"https://api.github.com/repos/mf2k/macports-ports/contributors","subscribers_url":"https://api.github.com/repos/mf2k/macports-ports/subscribers","subscription_url":"https://api.github.com/repos/mf2k/macports-ports/subscription","commits_url":"https://api.github.com/repos/mf2k/macports-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/mf2k/macports-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/mf2k/macports-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/mf2k/macports-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/mf2k/macports-ports/contents/{+path}","compare_url":"https://api.github.com/repos/mf2k/macports-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mf2k/macports-ports/merges","archive_url":"https://api.github.com/repos/mf2k/macports-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mf2k/macports-ports/downloads","issues_url":"https://api.github.com/repos/mf2k/macports-ports/issues{/number}","pulls_url":"https://api.github.com/repos/mf2k/macports-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/mf2k/macports-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/mf2k/macports-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mf2k/macports-ports/labels{/name}","releases_url":"https://api.github.com/repos/mf2k/macports-ports/releases{/id}","deployments_url":"https://api.github.com/repos/mf2k/macports-ports/deployments","created_at":"2018-09-28T19:04:42Z","updated_at":"2018-09-28T19:05:17Z","pushed_at":"2018-09-28T19:16:12Z","git_url":"git://github.com/mf2k/macports-ports.git","ssh_url":"git@github.com:mf2k/macports-ports.git","clone_url":"https://github.com/mf2k/macports-ports.git","svn_url":"https://github.com/mf2k/macports-ports","homepage":"https://trac.macports.org","size":165720,"stargazers_count":0,"watchers_count":0,"language":"Tcl","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"macports:master","ref":"master","sha":"8ff68f455d5ad18474da649951edda01e48b3a1c","user":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"repo":{"id":70365100,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM2NTEwMA==","name":"macports-ports","full_name":"macports/macports-ports","private":false,"owner":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/macports/macports-ports","description":"The MacPorts ports tree","fork":false,"url":"https://api.github.com/repos/macports/macports-ports","forks_url":"https://api.github.com/repos/macports/macports-ports/forks","keys_url":"https://api.github.com/repos/macports/macports-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macports/macports-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macports/macports-ports/teams","hooks_url":"https://api.github.com/repos/macports/macports-ports/hooks","issue_events_url":"https://api.github.com/repos/macports/macports-ports/issues/events{/number}","events_url":"https://api.github.com/repos/macports/macports-ports/events","assignees_url":"https://api.github.com/repos/macports/macports-ports/assignees{/user}","branches_url":"https://api.github.com/repos/macports/macports-ports/branches{/branch}","tags_url":"https://api.github.com/repos/macports/macports-ports/tags","blobs_url":"https://api.github.com/repos/macports/macports-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macports/macports-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macports/macports-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/macports/macports-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macports/macports-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/macports/macports-ports/languages","stargazers_url":"https://api.github.com/repos/macports/macports-ports/stargazers","contributors_url":"https://api.github.com/repos/macports/macports-ports/contributors","subscribers_url":"https://api.github.com/repos/macports/macports-ports/subscribers","subscription_url":"https://api.github.com/repos/macports/macports-ports/subscription","commits_url":"https://api.github.com/repos/macports/macports-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/macports/macports-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/macports/macports-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/macports/macports-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/macports/macports-ports/contents/{+path}","compare_url":"https://api.github.com/repos/macports/macports-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macports/macports-ports/merges","archive_url":"https://api.github.com/repos/macports/macports-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macports/macports-ports/downloads","issues_url":"https://api.github.com/repos/macports/macports-ports/issues{/number}","pulls_url":"https://api.github.com/repos/macports/macports-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/macports/macports-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/macports/macports-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macports/macports-ports/labels{/name}","releases_url":"https://api.github.com/repos/macports/macports-ports/releases{/id}","deployments_url":"https://api.github.com/repos/macports/macports-ports/deployments","created_at":"2016-10-09T00:31:44Z","updated_at":"2018-09-30T13:29:22Z","pushed_at":"2018-09-30T13:29:17Z","git_url":"git://github.com/macports/macports-ports.git","ssh_url":"git@github.com:macports/macports-ports.git","clone_url":"https://github.com/macports/macports-ports.git","svn_url":"https://github.com/macports/macports-ports","homepage":"https://trac.macports.org","size":165758,"stargazers_count":427,"watchers_count":427,"language":"Tcl","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":415,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":415,"open_issues":18,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2666"},"html":{"href":"https://github.com/macports/macports-ports/pull/2666"},"issue":{"href":"https://api.github.com/repos/macports/macports-ports/issues/2666"},"comments":{"href":"https://api.github.com/repos/macports/macports-ports/issues/2666/comments"},"review_comments":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2666/comments"},"review_comment":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2666/commits"},"statuses":{"href":"https://api.github.com/repos/macports/macports-ports/statuses/4b23862c1752a2dfd649c6b1734d756d2ffe7e40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"breun"}}