{"action":"closed","number":149,"pull_request":{"url":"https://api.github.com/repos/statgen/locuszoom/pulls/149","id":222008672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDA4Njcy","html_url":"https://github.com/statgen/locuszoom/pull/149","diff_url":"https://github.com/statgen/locuszoom/pull/149.diff","patch_url":"https://github.com/statgen/locuszoom/pull/149.patch","issue_url":"https://api.github.com/repos/statgen/locuszoom/issues/149","number":149,"state":"closed","locked":false,"title":"Datasources for grch38","user":{"login":"abought","id":2957073,"node_id":"MDQ6VXNlcjI5NTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2957073?v=4","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"# Purpose\r\nLZ.js should offer support for grch38 builds. This adds new datasources, as well as global config options to control genome build consistently via a single parameter across all requests.\r\n\r\n# How to test this\r\nAn LZ plot requires 4 core pieces of data. New API services allow us to support each of them.\r\n- Assoc\r\n- LD\r\n- Genes\r\n- Recomb\r\n\r\nCompare old and new demo pages for differences. The LD data should largely be a drop in replacement. The following index.html region requires 2 pages of LD data, so verify that all points are colored (pages fill from left to right side of plot):\r\n`index.html?chrom=10&start=114306616&end=114823842`\r\n\r\nGenes track may show more or slightly different gene annotations after the version upgrade. Existing deployments often specify a source explicitly, and so they will continue to use the old gencode dataset version.\r\n\r\nIf the current portal public datasets do not provide build 38 association studies, I can further evaluate via using locuszoom-tabix locally.\r\n\r\n# TODO\r\n- [x] Standardize mechanisms for querying build across all new and existing data sources\r\n- [x] Add support for dynamically selecting which LD population or build to render\r\n- [x] Update LD source based on API feedback/ discussion with Daniel\r\n- [x] Evaluate impact of changing default gene source / build, incl wrt ExAC \"constraint\" info.\r\n- [x] Upgrade PheWAS source and make build param consistent\r\n","created_at":"2018-10-11T05:13:51Z","updated_at":"2018-11-21T21:15:15Z","closed_at":"2018-11-21T21:15:15Z","merged_at":"2018-11-21T21:15:15Z","merge_commit_sha":"170d81ecc1113645c42408079473b51ea5837e3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":316317719,"node_id":"MDU6TGFiZWwzMTYzMTc3MTk=","url":"https://api.github.com/repos/statgen/locuszoom/labels/development%20complete","name":"development complete","color":"009800","default":false},{"id":313008824,"node_id":"MDU6TGFiZWwzMTMwMDg4MjQ=","url":"https://api.github.com/repos/statgen/locuszoom/labels/feature%20(medium)","name":"feature (medium)","color":"35978f","default":false},{"id":313017735,"node_id":"MDU6TGFiZWwzMTMwMTc3MzU=","url":"https://api.github.com/repos/statgen/locuszoom/labels/priority%20medium","name":"priority medium","color":"bf812d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/statgen/locuszoom/pulls/149/commits","review_comments_url":"https://api.github.com/repos/statgen/locuszoom/pulls/149/comments","review_comment_url":"https://api.github.com/repos/statgen/locuszoom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/statgen/locuszoom/issues/149/comments","statuses_url":"https://api.github.com/repos/statgen/locuszoom/statuses/732b9a140d5c9049682c1aabfb453558fe813d01","head":{"label":"abought:feature/gh149-h38support","ref":"feature/gh149-h38support","sha":"732b9a140d5c9049682c1aabfb453558fe813d01","user":{"login":"abought","id":2957073,"node_id":"MDQ6VXNlcjI5NTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2957073?v=4","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"repo":{"id":85776587,"node_id":"MDEwOlJlcG9zaXRvcnk4NTc3NjU4Nw==","name":"locuszoom","full_name":"abought/locuszoom","private":false,"owner":{"login":"abought","id":2957073,"node_id":"MDQ6VXNlcjI5NTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2957073?v=4","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abought/locuszoom","description":"A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.","fork":true,"url":"https://api.github.com/repos/abought/locuszoom","forks_url":"https://api.github.com/repos/abought/locuszoom/forks","keys_url":"https://api.github.com/repos/abought/locuszoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abought/locuszoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abought/locuszoom/teams","hooks_url":"https://api.github.com/repos/abought/locuszoom/hooks","issue_events_url":"https://api.github.com/repos/abought/locuszoom/issues/events{/number}","events_url":"https://api.github.com/repos/abought/locuszoom/events","assignees_url":"https://api.github.com/repos/abought/locuszoom/assignees{/user}","branches_url":"https://api.github.com/repos/abought/locuszoom/branches{/branch}","tags_url":"https://api.github.com/repos/abought/locuszoom/tags","blobs_url":"https://api.github.com/repos/abought/locuszoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abought/locuszoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abought/locuszoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/abought/locuszoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abought/locuszoom/statuses/{sha}","languages_url":"https://api.github.com/repos/abought/locuszoom/languages","stargazers_url":"https://api.github.com/repos/abought/locuszoom/stargazers","contributors_url":"https://api.github.com/repos/abought/locuszoom/contributors","subscribers_url":"https://api.github.com/repos/abought/locuszoom/subscribers","subscription_url":"https://api.github.com/repos/abought/locuszoom/subscription","commits_url":"https://api.github.com/repos/abought/locuszoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/abought/locuszoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/abought/locuszoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/abought/locuszoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/abought/locuszoom/contents/{+path}","compare_url":"https://api.github.com/repos/abought/locuszoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abought/locuszoom/merges","archive_url":"https://api.github.com/repos/abought/locuszoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abought/locuszoom/downloads","issues_url":"https://api.github.com/repos/abought/locuszoom/issues{/number}","pulls_url":"https://api.github.com/repos/abought/locuszoom/pulls{/number}","milestones_url":"https://api.github.com/repos/abought/locuszoom/milestones{/number}","notifications_url":"https://api.github.com/repos/abought/locuszoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abought/locuszoom/labels{/name}","releases_url":"https://api.github.com/repos/abought/locuszoom/releases{/id}","deployments_url":"https://api.github.com/repos/abought/locuszoom/deployments","created_at":"2017-03-22T02:34:48Z","updated_at":"2017-03-22T02:34:50Z","pushed_at":"2018-11-21T21:10:30Z","git_url":"git://github.com/abought/locuszoom.git","ssh_url":"git@github.com:abought/locuszoom.git","clone_url":"https://github.com/abought/locuszoom.git","svn_url":"https://github.com/abought/locuszoom","homepage":"","size":5419,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"statgen:develop","ref":"develop","sha":"c3007e1cb4b2fce4e888241396562512a8aeb90c","user":{"login":"statgen","id":651584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTU4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/651584?v=4","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"repo":{"id":41318680,"node_id":"MDEwOlJlcG9zaXRvcnk0MTMxODY4MA==","name":"locuszoom","full_name":"statgen/locuszoom","private":false,"owner":{"login":"statgen","id":651584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTU4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/651584?v=4","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/statgen/locuszoom","description":"A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.","fork":false,"url":"https://api.github.com/repos/statgen/locuszoom","forks_url":"https://api.github.com/repos/statgen/locuszoom/forks","keys_url":"https://api.github.com/repos/statgen/locuszoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statgen/locuszoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statgen/locuszoom/teams","hooks_url":"https://api.github.com/repos/statgen/locuszoom/hooks","issue_events_url":"https://api.github.com/repos/statgen/locuszoom/issues/events{/number}","events_url":"https://api.github.com/repos/statgen/locuszoom/events","assignees_url":"https://api.github.com/repos/statgen/locuszoom/assignees{/user}","branches_url":"https://api.github.com/repos/statgen/locuszoom/branches{/branch}","tags_url":"https://api.github.com/repos/statgen/locuszoom/tags","blobs_url":"https://api.github.com/repos/statgen/locuszoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statgen/locuszoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statgen/locuszoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/statgen/locuszoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statgen/locuszoom/statuses/{sha}","languages_url":"https://api.github.com/repos/statgen/locuszoom/languages","stargazers_url":"https://api.github.com/repos/statgen/locuszoom/stargazers","contributors_url":"https://api.github.com/repos/statgen/locuszoom/contributors","subscribers_url":"https://api.github.com/repos/statgen/locuszoom/subscribers","subscription_url":"https://api.github.com/repos/statgen/locuszoom/subscription","commits_url":"https://api.github.com/repos/statgen/locuszoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/statgen/locuszoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/statgen/locuszoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/statgen/locuszoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/statgen/locuszoom/contents/{+path}","compare_url":"https://api.github.com/repos/statgen/locuszoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statgen/locuszoom/merges","archive_url":"https://api.github.com/repos/statgen/locuszoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statgen/locuszoom/downloads","issues_url":"https://api.github.com/repos/statgen/locuszoom/issues{/number}","pulls_url":"https://api.github.com/repos/statgen/locuszoom/pulls{/number}","milestones_url":"https://api.github.com/repos/statgen/locuszoom/milestones{/number}","notifications_url":"https://api.github.com/repos/statgen/locuszoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statgen/locuszoom/labels{/name}","releases_url":"https://api.github.com/repos/statgen/locuszoom/releases{/id}","deployments_url":"https://api.github.com/repos/statgen/locuszoom/deployments","created_at":"2015-08-24T18:01:44Z","updated_at":"2018-11-13T21:43:00Z","pushed_at":"2018-11-21T21:15:15Z","git_url":"git://github.com/statgen/locuszoom.git","ssh_url":"git@github.com:statgen/locuszoom.git","clone_url":"https://github.com/statgen/locuszoom.git","svn_url":"https://github.com/statgen/locuszoom","homepage":"https://statgen.github.io/locuszoom/","size":5284,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":19,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/149"},"html":{"href":"https://github.com/statgen/locuszoom/pull/149"},"issue":{"href":"https://api.github.com/repos/statgen/locuszoom/issues/149"},"comments":{"href":"https://api.github.com/repos/statgen/locuszoom/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/statgen/locuszoom/statuses/732b9a140d5c9049682c1aabfb453558fe813d01"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"abought","id":2957073,"node_id":"MDQ6VXNlcjI5NTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2957073?v=4","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":237,"deletions":80,"changed_files":17}}
{"actor":{"display_login":"abought"}}