{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/23530","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/23530/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23530/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/23530/events","html_url":"https://github.com/mantidproject/mantid/pull/23530","id":361227901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjUwNjky","number":23530,"title":"D2B normalisation fix","user":{"login":"gvardany","id":16865759,"node_id":"MDQ6VXNlcjE2ODY1NzU5","avatar_url":"https://avatars2.githubusercontent.com/u/16865759?v=4","gravatar_id":"","url":"https://api.github.com/users/gvardany","html_url":"https://github.com/gvardany","followers_url":"https://api.github.com/users/gvardany/followers","following_url":"https://api.github.com/users/gvardany/following{/other_user}","gists_url":"https://api.github.com/users/gvardany/gists{/gist_id}","starred_url":"https://api.github.com/users/gvardany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvardany/subscriptions","organizations_url":"https://api.github.com/users/gvardany/orgs","repos_url":"https://api.github.com/users/gvardany/repos","events_url":"https://api.github.com/users/gvardany/events{/privacy}","received_events_url":"https://api.github.com/users/gvardany/received_events","type":"User","site_admin":false},"labels":[{"id":40046181,"node_id":"MDU6TGFiZWw0MDA0NjE4MQ==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Diffraction","name":"Component: Diffraction","color":"009800","default":false},{"id":40046083,"node_id":"MDU6TGFiZWw0MDA0NjA4Mw==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9","default":false},{"id":35408850,"node_id":"MDU6TGFiZWwzNTQwODg1MA==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21","default":false},{"id":194052956,"node_id":"MDU6TGFiZWwxOTQwNTI5NTY=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20System%20Tests","name":"Quality: System Tests","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"reimundILL","id":19187274,"node_id":"MDQ6VXNlcjE5MTg3Mjc0","avatar_url":"https://avatars0.githubusercontent.com/u/19187274?v=4","gravatar_id":"","url":"https://api.github.com/users/reimundILL","html_url":"https://github.com/reimundILL","followers_url":"https://api.github.com/users/reimundILL/followers","following_url":"https://api.github.com/users/reimundILL/following{/other_user}","gists_url":"https://api.github.com/users/reimundILL/gists{/gist_id}","starred_url":"https://api.github.com/users/reimundILL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reimundILL/subscriptions","organizations_url":"https://api.github.com/users/reimundILL/orgs","repos_url":"https://api.github.com/users/reimundILL/repos","events_url":"https://api.github.com/users/reimundILL/events{/privacy}","received_events_url":"https://api.github.com/users/reimundILL/received_events","type":"User","site_admin":false},"assignees":[{"login":"reimundILL","id":19187274,"node_id":"MDQ6VXNlcjE5MTg3Mjc0","avatar_url":"https://avatars0.githubusercontent.com/u/19187274?v=4","gravatar_id":"","url":"https://api.github.com/users/reimundILL","html_url":"https://github.com/reimundILL","followers_url":"https://api.github.com/users/reimundILL/followers","following_url":"https://api.github.com/users/reimundILL/following{/other_user}","gists_url":"https://api.github.com/users/reimundILL/gists{/gist_id}","starred_url":"https://api.github.com/users/reimundILL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reimundILL/subscriptions","organizations_url":"https://api.github.com/users/reimundILL/orgs","repos_url":"https://api.github.com/users/reimundILL/repos","events_url":"https://api.github.com/users/reimundILL/events{/privacy}","received_events_url":"https://api.github.com/users/reimundILL/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-18T10:01:57Z","updated_at":"2018-09-26T13:52:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23530","html_url":"https://github.com/mantidproject/mantid/pull/23530","diff_url":"https://github.com/mantidproject/mantid/pull/23530.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23530.patch"},"body":"**Description of work.**\r\n\r\nThe normalisation in `SumOverlappingTubes` got broken (see the issue).\r\nThis was not captured since the tests were using data with sufficiently high counts.\r\nThe bug was revealed in a recent short measurement, where many pixels counted 0.\r\n\r\nThis PR fixes the bug, and adds more rigor to the tests.\r\n\r\n**Report to:** G. Cuello.\r\n <!--If the original issue was raised by a user they should be named here. Do not leak email addresses-->\r\n\r\n**To test:**\r\n\r\n- [ ] ```red = PowderDiffILLDetScanReduction(Run='540162')```\r\n Plot and confirm by eye, that the ratio of the highest peak and the background is about 10. The test run should be in system test data under ILL/D2B.\r\n\r\n- [ ] ```./systemtest -R ILLPowderDiffDetScanReduction``` \r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #23521 . <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n<!-- alternative\r\n*There is no associated issue.*\r\n-->\r\n\r\n<!-- delete this if you added release notes\r\n*This does not require release notes* because **fill in an explanation of why**\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://developer.mantidproject.org/IndividualTicketTesting/)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/424723451","html_url":"https://github.com/mantidproject/mantid/pull/23530#issuecomment-424723451","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23530","id":424723451,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDcyMzQ1MQ==","user":{"login":"gvardany","id":16865759,"node_id":"MDQ6VXNlcjE2ODY1NzU5","avatar_url":"https://avatars2.githubusercontent.com/u/16865759?v=4","gravatar_id":"","url":"https://api.github.com/users/gvardany","html_url":"https://github.com/gvardany","followers_url":"https://api.github.com/users/gvardany/followers","following_url":"https://api.github.com/users/gvardany/following{/other_user}","gists_url":"https://api.github.com/users/gvardany/gists{/gist_id}","starred_url":"https://api.github.com/users/gvardany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvardany/subscriptions","organizations_url":"https://api.github.com/users/gvardany/orgs","repos_url":"https://api.github.com/users/gvardany/repos","events_url":"https://api.github.com/users/gvardany/events{/privacy}","received_events_url":"https://api.github.com/users/gvardany/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T13:52:41Z","updated_at":"2018-09-26T13:52:41Z","author_association":"MEMBER","body":"Should be sorted now. Please make sure that the system test do run and pass on the server and locally:\r\n`./systemtest -R ILLPowderDiff`\r\n`./systemtest -R D2B_DetEffCorr`"}}
{"actor":{"display_login":"gvardany"}}