{"action":"created","comment":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/169864060","pull_request_review_id":98458261,"id":169864060,"diff_hunk":"@@ -44,10 +44,10 @@ public function testCanCreateRoleService(): void\n             ],\n         ]);\n \n-        $container = $this->getMockBuilder(ContainerInterface::class)->getMock();\n-\n-        $container->expects($this->at(0))->method('get')->with(ModuleOptions::class)->willReturn($options);\n-        $container->expects($this->at(1))->method('get')->with(RoleProviderPluginManager::class)->willReturn(new RoleProviderPluginManager($this->getMockBuilder(ContainerInterface::class)->getMock()));\n+        $container = new ServiceManager(['services' => [","path":"test/Container/RoleServiceFactoryTest.php","position":24,"original_position":24,"commit_id":"e79f08bec8c90c9e0bff6aab780dcc9e72d9a0dd","original_commit_id":"e79f08bec8c90c9e0bff6aab780dcc9e72d9a0dd","user":{"login":"svycka","id":1270782,"avatar_url":"https://avatars0.githubusercontent.com/u/1270782?v=4","gravatar_id":"","url":"https://api.github.com/users/svycka","html_url":"https://github.com/svycka","followers_url":"https://api.github.com/users/svycka/followers","following_url":"https://api.github.com/users/svycka/following{/other_user}","gists_url":"https://api.github.com/users/svycka/gists{/gist_id}","starred_url":"https://api.github.com/users/svycka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svycka/subscriptions","organizations_url":"https://api.github.com/users/svycka/orgs","repos_url":"https://api.github.com/users/svycka/repos","events_url":"https://api.github.com/users/svycka/events{/privacy}","received_events_url":"https://api.github.com/users/svycka/received_events","type":"User","site_admin":false},"body":"this PR is not about removing service manager but it brings an ability to use something else if needed. If we would decide to remove it we can do it in separate PR I guess.","created_at":"2018-02-22T06:24:56Z","updated_at":"2018-02-22T06:24:56Z","html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/380#discussion_r169864060","pull_request_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/169864060"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/380#discussion_r169864060"},"pull_request":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380"}},"in_reply_to_id":169759140},"pull_request":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380","id":170474878,"html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/380","diff_url":"https://github.com/ZF-Commons/zfc-rbac/pull/380.diff","patch_url":"https://github.com/ZF-Commons/zfc-rbac/pull/380.patch","issue_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/380","number":380,"state":"open","locked":false,"title":"[WIP] Plugin managers refactor","user":{"login":"svycka","id":1270782,"avatar_url":"https://avatars0.githubusercontent.com/u/1270782?v=4","gravatar_id":"","url":"https://api.github.com/users/svycka","html_url":"https://github.com/svycka","followers_url":"https://api.github.com/users/svycka/followers","following_url":"https://api.github.com/users/svycka/following{/other_user}","gists_url":"https://api.github.com/users/svycka/gists{/gist_id}","starred_url":"https://api.github.com/users/svycka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svycka/subscriptions","organizations_url":"https://api.github.com/users/svycka/orgs","repos_url":"https://api.github.com/users/svycka/repos","events_url":"https://api.github.com/users/svycka/events{/privacy}","received_events_url":"https://api.github.com/users/svycka/received_events","type":"User","site_admin":false},"body":"this way we could make another step to decouple from Zend service-manager and fully support any PSR-11 implementation. If everyone agrees I will continue with `RoleProviderPluginManager` maybe more don't remember if we have more :D\r\n\r\nI guess would be a good idea to change config\r\n````php\r\nZfcRbac\\Assertion\\AssertionPluginManager::class => ZfcRbac\\Container\\AssertionPluginManagerFactory::class,\r\n// to\r\nZfcRbac\\Assertion\\AssertionContainerInterface::class => ZfcRbac\\Container\\AssertionPluginManagerFactory::class,\r\n````\r\n\r\nAlso not sure about naming maybe `ZfcRbac\\Assertion\\ContainerInterface` or `ZfcRbac\\Container\\AssertionContainerInterface`\r\n\r\nwhat do you think? @prolic @basz","created_at":"2018-02-21T13:50:07Z","updated_at":"2018-02-22T06:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc61b9dbf4db5013d721e6e9f75bcbdfc0db9751","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380/commits","review_comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380/comments","review_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/380/comments","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/e79f08bec8c90c9e0bff6aab780dcc9e72d9a0dd","head":{"label":"svycka:plugin-managers-refactor","ref":"plugin-managers-refactor","sha":"e79f08bec8c90c9e0bff6aab780dcc9e72d9a0dd","user":{"login":"svycka","id":1270782,"avatar_url":"https://avatars0.githubusercontent.com/u/1270782?v=4","gravatar_id":"","url":"https://api.github.com/users/svycka","html_url":"https://github.com/svycka","followers_url":"https://api.github.com/users/svycka/followers","following_url":"https://api.github.com/users/svycka/following{/other_user}","gists_url":"https://api.github.com/users/svycka/gists{/gist_id}","starred_url":"https://api.github.com/users/svycka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svycka/subscriptions","organizations_url":"https://api.github.com/users/svycka/orgs","repos_url":"https://api.github.com/users/svycka/repos","events_url":"https://api.github.com/users/svycka/events{/privacy}","received_events_url":"https://api.github.com/users/svycka/received_events","type":"User","site_admin":false},"repo":{"id":20098936,"name":"zfc-rbac","full_name":"svycka/zfc-rbac","owner":{"login":"svycka","id":1270782,"avatar_url":"https://avatars0.githubusercontent.com/u/1270782?v=4","gravatar_id":"","url":"https://api.github.com/users/svycka","html_url":"https://github.com/svycka","followers_url":"https://api.github.com/users/svycka/followers","following_url":"https://api.github.com/users/svycka/following{/other_user}","gists_url":"https://api.github.com/users/svycka/gists{/gist_id}","starred_url":"https://api.github.com/users/svycka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svycka/subscriptions","organizations_url":"https://api.github.com/users/svycka/orgs","repos_url":"https://api.github.com/users/svycka/repos","events_url":"https://api.github.com/users/svycka/events{/privacy}","received_events_url":"https://api.github.com/users/svycka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svycka/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":true,"url":"https://api.github.com/repos/svycka/zfc-rbac","forks_url":"https://api.github.com/repos/svycka/zfc-rbac/forks","keys_url":"https://api.github.com/repos/svycka/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svycka/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svycka/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/svycka/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/svycka/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/svycka/zfc-rbac/events","assignees_url":"https://api.github.com/repos/svycka/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/svycka/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/svycka/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/svycka/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svycka/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svycka/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/svycka/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svycka/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/svycka/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/svycka/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/svycka/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/svycka/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/svycka/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/svycka/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/svycka/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/svycka/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/svycka/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/svycka/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/svycka/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svycka/zfc-rbac/merges","archive_url":"https://api.github.com/repos/svycka/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svycka/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/svycka/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/svycka/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/svycka/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/svycka/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svycka/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/svycka/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/svycka/zfc-rbac/deployments","created_at":"2014-05-23T12:37:15Z","updated_at":"2016-10-26T12:18:59Z","pushed_at":"2018-02-21T16:21:34Z","git_url":"git://github.com/svycka/zfc-rbac.git","ssh_url":"git@github.com:svycka/zfc-rbac.git","clone_url":"https://github.com/svycka/zfc-rbac.git","svn_url":"https://github.com/svycka/zfc-rbac","homepage":"","size":1585,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZF-Commons:develop","ref":"develop","sha":"c0bf5cb29bdb1eb7672addb50542c568f36d0329","user":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars0.githubusercontent.com/u/1313211?v=4","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"repo":{"id":6282379,"name":"zfc-rbac","full_name":"ZF-Commons/zfc-rbac","owner":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars0.githubusercontent.com/u/1313211?v=4","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZF-Commons/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":false,"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac","forks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/forks","keys_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/events","assignees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/merges","archive_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/deployments","created_at":"2012-10-18T17:07:13Z","updated_at":"2018-01-22T16:19:05Z","pushed_at":"2018-02-21T16:21:35Z","git_url":"git://github.com/ZF-Commons/zfc-rbac.git","ssh_url":"git@github.com:ZF-Commons/zfc-rbac.git","clone_url":"https://github.com/ZF-Commons/zfc-rbac.git","svn_url":"https://github.com/ZF-Commons/zfc-rbac","homepage":"","size":1613,"stargazers_count":188,"watchers_count":188,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":127,"open_issues":32,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/380"},"issue":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/380"},"comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/e79f08bec8c90c9e0bff6aab780dcc9e72d9a0dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"svycka"}}