{"action":"created","comment":{"url":"https://api.github.com/repos/gcuisinier/jenv/pulls/comments/237054947","pull_request_review_id":179258877,"id":237054947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA1NDk0Nw==","diff_hunk":"@@ -46,10 +46,10 @@ Verified on :\n \n \t_Same as in previous step, use `~/.profile` on Ubuntu, `~/.zshrc` for Zsh._\n \n-    **Fish note**: Instead, copy `~/.jenv/fish/jenv.fish` to `~/.conf/fish/function/jenv.fish`. If you don't have the `export` function, also copy `export.fish`\n+    **Fish note**: Instead, copy `jenv.fish` to yor fish functions folder. If you don't have the `export` function, also copy `export.fish`\n     ~~~ sh\n-        cp ~/.jenv/fish/jenv.fish ~/.conf/fish/function/jenv.fish\n-        cp ~/.jenv/fish/export.fish ~/.conf/fish/function/export.fish\n+        cp /usr/local/Cellar/jenv/0.4.4/libexec/fish/jenv.fish ~/.config/fish/functions/jenv.fish\n+        cp /usr/local/Cellar/jenv/0.4.4/libexec/fish/export.fish ~/.config/fish/functions/export.fish","path":"README.md","position":10,"original_position":10,"commit_id":"aff204e9339d07d23bb3f3513cf4fe2ebd6f284c","original_commit_id":"aff204e9339d07d23bb3f3513cf4fe2ebd6f284c","user":{"login":"vrcca","id":1920397,"node_id":"MDQ6VXNlcjE5MjAzOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1920397?v=4","gravatar_id":"","url":"https://api.github.com/users/vrcca","html_url":"https://github.com/vrcca","followers_url":"https://api.github.com/users/vrcca/followers","following_url":"https://api.github.com/users/vrcca/following{/other_user}","gists_url":"https://api.github.com/users/vrcca/gists{/gist_id}","starred_url":"https://api.github.com/users/vrcca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrcca/subscriptions","organizations_url":"https://api.github.com/users/vrcca/orgs","repos_url":"https://api.github.com/users/vrcca/repos","events_url":"https://api.github.com/users/vrcca/events{/privacy}","received_events_url":"https://api.github.com/users/vrcca/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        cp ~/.jenv/fish/export.fish ~/.config/fish/functions/export.fish\r\n```","created_at":"2018-11-28T12:05:00Z","updated_at":"2018-11-28T12:06:10Z","html_url":"https://github.com/gcuisinier/jenv/pull/221#discussion_r237054947","pull_request_url":"https://api.github.com/repos/gcuisinier/jenv/pulls/221","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/comments/237054947"},"html":{"href":"https://github.com/gcuisinier/jenv/pull/221#discussion_r237054947"},"pull_request":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/gcuisinier/jenv/pulls/221","id":233542911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTQyOTEx","html_url":"https://github.com/gcuisinier/jenv/pull/221","diff_url":"https://github.com/gcuisinier/jenv/pull/221.diff","patch_url":"https://github.com/gcuisinier/jenv/pull/221.patch","issue_url":"https://api.github.com/repos/gcuisinier/jenv/issues/221","number":221,"state":"open","locked":false,"title":"Update getting started fish instructions","user":{"login":"Tmarty","id":443865,"node_id":"MDQ6VXNlcjQ0Mzg2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/443865?v=4","gravatar_id":"","url":"https://api.github.com/users/Tmarty","html_url":"https://github.com/Tmarty","followers_url":"https://api.github.com/users/Tmarty/followers","following_url":"https://api.github.com/users/Tmarty/following{/other_user}","gists_url":"https://api.github.com/users/Tmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/Tmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tmarty/subscriptions","organizations_url":"https://api.github.com/users/Tmarty/orgs","repos_url":"https://api.github.com/users/Tmarty/repos","events_url":"https://api.github.com/users/Tmarty/events{/privacy}","received_events_url":"https://api.github.com/users/Tmarty/received_events","type":"User","site_admin":false},"body":"For me both sides of the copy function differed from my Mac OS Mojave setup with jenv installed via Brew. Possible issues with this PR:\r\n\r\n- It's brew specific \r\n  - Anyone know why my ~/.jenv/ folder didn't include a fish folder?\r\n- It's tied to the current jenv version\r\n- The paths may be brew and Mac specific","created_at":"2018-11-26T12:37:06Z","updated_at":"2018-11-28T12:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d98812d6c95cf994e2d05d10690b4740628e96a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcuisinier/jenv/pulls/221/commits","review_comments_url":"https://api.github.com/repos/gcuisinier/jenv/pulls/221/comments","review_comment_url":"https://api.github.com/repos/gcuisinier/jenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcuisinier/jenv/issues/221/comments","statuses_url":"https://api.github.com/repos/gcuisinier/jenv/statuses/aff204e9339d07d23bb3f3513cf4fe2ebd6f284c","head":{"label":"Tmarty:patch-1","ref":"patch-1","sha":"aff204e9339d07d23bb3f3513cf4fe2ebd6f284c","user":{"login":"Tmarty","id":443865,"node_id":"MDQ6VXNlcjQ0Mzg2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/443865?v=4","gravatar_id":"","url":"https://api.github.com/users/Tmarty","html_url":"https://github.com/Tmarty","followers_url":"https://api.github.com/users/Tmarty/followers","following_url":"https://api.github.com/users/Tmarty/following{/other_user}","gists_url":"https://api.github.com/users/Tmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/Tmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tmarty/subscriptions","organizations_url":"https://api.github.com/users/Tmarty/orgs","repos_url":"https://api.github.com/users/Tmarty/repos","events_url":"https://api.github.com/users/Tmarty/events{/privacy}","received_events_url":"https://api.github.com/users/Tmarty/received_events","type":"User","site_admin":false},"repo":{"id":159165558,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNjU1NTg=","name":"jenv","full_name":"Tmarty/jenv","private":false,"owner":{"login":"Tmarty","id":443865,"node_id":"MDQ6VXNlcjQ0Mzg2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/443865?v=4","gravatar_id":"","url":"https://api.github.com/users/Tmarty","html_url":"https://github.com/Tmarty","followers_url":"https://api.github.com/users/Tmarty/followers","following_url":"https://api.github.com/users/Tmarty/following{/other_user}","gists_url":"https://api.github.com/users/Tmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/Tmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tmarty/subscriptions","organizations_url":"https://api.github.com/users/Tmarty/orgs","repos_url":"https://api.github.com/users/Tmarty/repos","events_url":"https://api.github.com/users/Tmarty/events{/privacy}","received_events_url":"https://api.github.com/users/Tmarty/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tmarty/jenv","description":"Manage your Java environment ","fork":true,"url":"https://api.github.com/repos/Tmarty/jenv","forks_url":"https://api.github.com/repos/Tmarty/jenv/forks","keys_url":"https://api.github.com/repos/Tmarty/jenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tmarty/jenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tmarty/jenv/teams","hooks_url":"https://api.github.com/repos/Tmarty/jenv/hooks","issue_events_url":"https://api.github.com/repos/Tmarty/jenv/issues/events{/number}","events_url":"https://api.github.com/repos/Tmarty/jenv/events","assignees_url":"https://api.github.com/repos/Tmarty/jenv/assignees{/user}","branches_url":"https://api.github.com/repos/Tmarty/jenv/branches{/branch}","tags_url":"https://api.github.com/repos/Tmarty/jenv/tags","blobs_url":"https://api.github.com/repos/Tmarty/jenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tmarty/jenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tmarty/jenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tmarty/jenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tmarty/jenv/statuses/{sha}","languages_url":"https://api.github.com/repos/Tmarty/jenv/languages","stargazers_url":"https://api.github.com/repos/Tmarty/jenv/stargazers","contributors_url":"https://api.github.com/repos/Tmarty/jenv/contributors","subscribers_url":"https://api.github.com/repos/Tmarty/jenv/subscribers","subscription_url":"https://api.github.com/repos/Tmarty/jenv/subscription","commits_url":"https://api.github.com/repos/Tmarty/jenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tmarty/jenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tmarty/jenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tmarty/jenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tmarty/jenv/contents/{+path}","compare_url":"https://api.github.com/repos/Tmarty/jenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tmarty/jenv/merges","archive_url":"https://api.github.com/repos/Tmarty/jenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tmarty/jenv/downloads","issues_url":"https://api.github.com/repos/Tmarty/jenv/issues{/number}","pulls_url":"https://api.github.com/repos/Tmarty/jenv/pulls{/number}","milestones_url":"https://api.github.com/repos/Tmarty/jenv/milestones{/number}","notifications_url":"https://api.github.com/repos/Tmarty/jenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tmarty/jenv/labels{/name}","releases_url":"https://api.github.com/repos/Tmarty/jenv/releases{/id}","deployments_url":"https://api.github.com/repos/Tmarty/jenv/deployments","created_at":"2018-11-26T12:24:40Z","updated_at":"2018-11-26T12:24:42Z","pushed_at":"2018-11-26T12:36:31Z","git_url":"git://github.com/Tmarty/jenv.git","ssh_url":"git@github.com:Tmarty/jenv.git","clone_url":"https://github.com/Tmarty/jenv.git","svn_url":"https://github.com/Tmarty/jenv","homepage":"http://www.jenv.be","size":371,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gcuisinier:master","ref":"master","sha":"e253e3654e624f0161aed21745a4e1a796d554b2","user":{"login":"gcuisinier","id":135300,"node_id":"MDQ6VXNlcjEzNTMwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/135300?v=4","gravatar_id":"","url":"https://api.github.com/users/gcuisinier","html_url":"https://github.com/gcuisinier","followers_url":"https://api.github.com/users/gcuisinier/followers","following_url":"https://api.github.com/users/gcuisinier/following{/other_user}","gists_url":"https://api.github.com/users/gcuisinier/gists{/gist_id}","starred_url":"https://api.github.com/users/gcuisinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcuisinier/subscriptions","organizations_url":"https://api.github.com/users/gcuisinier/orgs","repos_url":"https://api.github.com/users/gcuisinier/repos","events_url":"https://api.github.com/users/gcuisinier/events{/privacy}","received_events_url":"https://api.github.com/users/gcuisinier/received_events","type":"User","site_admin":false},"repo":{"id":7808903,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4OTAz","name":"jenv","full_name":"gcuisinier/jenv","private":false,"owner":{"login":"gcuisinier","id":135300,"node_id":"MDQ6VXNlcjEzNTMwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/135300?v=4","gravatar_id":"","url":"https://api.github.com/users/gcuisinier","html_url":"https://github.com/gcuisinier","followers_url":"https://api.github.com/users/gcuisinier/followers","following_url":"https://api.github.com/users/gcuisinier/following{/other_user}","gists_url":"https://api.github.com/users/gcuisinier/gists{/gist_id}","starred_url":"https://api.github.com/users/gcuisinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcuisinier/subscriptions","organizations_url":"https://api.github.com/users/gcuisinier/orgs","repos_url":"https://api.github.com/users/gcuisinier/repos","events_url":"https://api.github.com/users/gcuisinier/events{/privacy}","received_events_url":"https://api.github.com/users/gcuisinier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gcuisinier/jenv","description":"Manage your Java environment ","fork":false,"url":"https://api.github.com/repos/gcuisinier/jenv","forks_url":"https://api.github.com/repos/gcuisinier/jenv/forks","keys_url":"https://api.github.com/repos/gcuisinier/jenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcuisinier/jenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcuisinier/jenv/teams","hooks_url":"https://api.github.com/repos/gcuisinier/jenv/hooks","issue_events_url":"https://api.github.com/repos/gcuisinier/jenv/issues/events{/number}","events_url":"https://api.github.com/repos/gcuisinier/jenv/events","assignees_url":"https://api.github.com/repos/gcuisinier/jenv/assignees{/user}","branches_url":"https://api.github.com/repos/gcuisinier/jenv/branches{/branch}","tags_url":"https://api.github.com/repos/gcuisinier/jenv/tags","blobs_url":"https://api.github.com/repos/gcuisinier/jenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcuisinier/jenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcuisinier/jenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcuisinier/jenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcuisinier/jenv/statuses/{sha}","languages_url":"https://api.github.com/repos/gcuisinier/jenv/languages","stargazers_url":"https://api.github.com/repos/gcuisinier/jenv/stargazers","contributors_url":"https://api.github.com/repos/gcuisinier/jenv/contributors","subscribers_url":"https://api.github.com/repos/gcuisinier/jenv/subscribers","subscription_url":"https://api.github.com/repos/gcuisinier/jenv/subscription","commits_url":"https://api.github.com/repos/gcuisinier/jenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcuisinier/jenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcuisinier/jenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcuisinier/jenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcuisinier/jenv/contents/{+path}","compare_url":"https://api.github.com/repos/gcuisinier/jenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcuisinier/jenv/merges","archive_url":"https://api.github.com/repos/gcuisinier/jenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcuisinier/jenv/downloads","issues_url":"https://api.github.com/repos/gcuisinier/jenv/issues{/number}","pulls_url":"https://api.github.com/repos/gcuisinier/jenv/pulls{/number}","milestones_url":"https://api.github.com/repos/gcuisinier/jenv/milestones{/number}","notifications_url":"https://api.github.com/repos/gcuisinier/jenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcuisinier/jenv/labels{/name}","releases_url":"https://api.github.com/repos/gcuisinier/jenv/releases{/id}","deployments_url":"https://api.github.com/repos/gcuisinier/jenv/deployments","created_at":"2013-01-24T22:43:30Z","updated_at":"2018-11-27T14:02:13Z","pushed_at":"2018-11-26T12:37:07Z","git_url":"git://github.com/gcuisinier/jenv.git","ssh_url":"git@github.com:gcuisinier/jenv.git","clone_url":"https://github.com/gcuisinier/jenv.git","svn_url":"https://github.com/gcuisinier/jenv","homepage":"http://www.jenv.be","size":365,"stargazers_count":2165,"watchers_count":2165,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":165,"open_issues":110,"watchers":2165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/221"},"html":{"href":"https://github.com/gcuisinier/jenv/pull/221"},"issue":{"href":"https://api.github.com/repos/gcuisinier/jenv/issues/221"},"comments":{"href":"https://api.github.com/repos/gcuisinier/jenv/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcuisinier/jenv/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/gcuisinier/jenv/statuses/aff204e9339d07d23bb3f3513cf4fe2ebd6f284c"}},"author_association":"NONE"}}
{"actor":{"display_login":"vrcca"}}