{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/233795626","pull_request_review_id":175291359,"id":233795626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzc5NTYyNg==","diff_hunk":"@@ -1,19 +1,13 @@\n # frozen_string_literal: true\n \n require 'common/models/form'\n-require 'common/models/attribute_types/httpdate'\n \n module MHVAC\n   class UpgradeForm < Common::Form\n     include ActiveModel::Validations\n \n     attribute :user_id, Integer\n-    attribute :form_signed_date_time, Common::HTTPDate\n-    attribute :form_upgrade_manual_date, Common::HTTPDate\n-    attribute :form_upgrade_online_date, Common::HTTPDate","path":"lib/mhv_ac/upgrade_form.rb","position":13,"original_position":13,"commit_id":"a4c2648c3982f3141dbb14e08d023c457f1d2dd3","original_commit_id":"a4c2648c3982f3141dbb14e08d023c457f1d2dd3","user":{"login":"U-DON","id":1067024,"node_id":"MDQ6VXNlcjEwNjcwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1067024?v=4","gravatar_id":"","url":"https://api.github.com/users/U-DON","html_url":"https://github.com/U-DON","followers_url":"https://api.github.com/users/U-DON/followers","following_url":"https://api.github.com/users/U-DON/following{/other_user}","gists_url":"https://api.github.com/users/U-DON/gists{/gist_id}","starred_url":"https://api.github.com/users/U-DON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/U-DON/subscriptions","organizations_url":"https://api.github.com/users/U-DON/orgs","repos_url":"https://api.github.com/users/U-DON/repos","events_url":"https://api.github.com/users/U-DON/events{/privacy}","received_events_url":"https://api.github.com/users/U-DON/received_events","type":"User","site_admin":false},"body":"I think they may still requirement. From a local test, I'm getting a \"data integrity issue\" from the upgrade request. Should we just use the current date or work with MHV to remove the requirement?","created_at":"2018-11-15T10:52:09Z","updated_at":"2018-11-15T10:52:09Z","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453#discussion_r233795626","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/233795626"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453#discussion_r233795626"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453"}},"in_reply_to_id":233675865},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453","id":229863533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODYzNTMz","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2453","number":2453,"state":"open","locked":false,"title":"Removed MHV terms and conditions requirement for account creation","user":{"login":"U-DON","id":1067024,"node_id":"MDQ6VXNlcjEwNjcwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1067024?v=4","gravatar_id":"","url":"https://api.github.com/users/U-DON","html_url":"https://github.com/U-DON","followers_url":"https://api.github.com/users/U-DON/followers","following_url":"https://api.github.com/users/U-DON/following{/other_user}","gists_url":"https://api.github.com/users/U-DON/gists{/gist_id}","starred_url":"https://api.github.com/users/U-DON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/U-DON/subscriptions","organizations_url":"https://api.github.com/users/U-DON/orgs","repos_url":"https://api.github.com/users/U-DON/repos","events_url":"https://api.github.com/users/U-DON/events{/privacy}","received_events_url":"https://api.github.com/users/U-DON/received_events","type":"User","site_admin":false},"body":"## Description of change\r\nMHV account state should no longer go through the `needs_terms_acceptance` state as it's no longer required for account creation. T&C status is no longer being serialized for `GET /mhv_account`. T&C data is no longer passed in the payload to MHV for the account creation request.\r\n\r\nFE PR: department-of-veterans-affairs/vets-website#9110\r\n\r\n## Testing done\r\nLocal testing on user vets.gov.user+1 comparing what happens with and without changes on both BE and FE. Without the changes, clicking the button to create an account will redirect to T&C (due to the account state being `needs_terms_acceptance`). With the changes, clicking it will start a `POST /mhv_account` request (due to the account state being `no_account`).\r\n\r\n## Testing planned\r\nShould test the account upgrade flow on Staging. Perhaps after removing (unless we decide not to) the VA patient requirement as well.\r\n\r\n## Acceptance Criteria (Definition of Done)\r\n- [x] Users eligible for MHV account creation should not have to accept T&C in order to proceed with account creation.\r\n\r\n#### Applies to all PRs\r\n\r\n- [x] Appropriate logging\r\n- [x] Swagger docs have been updated, if applicable\r\n- [x] Provide link to originating GitHub issue, or connected to it via ZenHub\r\n- [x] Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)\r\n- [x] Provide which alerts would indicate a problem with this functionality (if applicable)\r\n","created_at":"2018-11-10T02:13:09Z","updated_at":"2018-11-15T10:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d270011ee1b72fceeeb03014121d9a9e6ee344bc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"annaswims","id":19188,"node_id":"MDQ6VXNlcjE5MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/19188?v=4","gravatar_id":"","url":"https://api.github.com/users/annaswims","html_url":"https://github.com/annaswims","followers_url":"https://api.github.com/users/annaswims/followers","following_url":"https://api.github.com/users/annaswims/following{/other_user}","gists_url":"https://api.github.com/users/annaswims/gists{/gist_id}","starred_url":"https://api.github.com/users/annaswims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annaswims/subscriptions","organizations_url":"https://api.github.com/users/annaswims/orgs","repos_url":"https://api.github.com/users/annaswims/repos","events_url":"https://api.github.com/users/annaswims/events{/privacy}","received_events_url":"https://api.github.com/users/annaswims/received_events","type":"User","site_admin":false},{"login":"dhall","id":299180,"node_id":"MDQ6VXNlcjI5OTE4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/299180?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall","html_url":"https://github.com/dhall","followers_url":"https://api.github.com/users/dhall/followers","following_url":"https://api.github.com/users/dhall/following{/other_user}","gists_url":"https://api.github.com/users/dhall/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall/subscriptions","organizations_url":"https://api.github.com/users/dhall/orgs","repos_url":"https://api.github.com/users/dhall/repos","events_url":"https://api.github.com/users/dhall/events{/privacy}","received_events_url":"https://api.github.com/users/dhall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2453/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/a4c2648c3982f3141dbb14e08d023c457f1d2dd3","head":{"label":"department-of-veterans-affairs:remove_terms_and_conditions","ref":"remove_terms_and_conditions","sha":"a4c2648c3982f3141dbb14e08d023c457f1d2dd3","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQwOTQxNw==","name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2018-11-14T22:56:04Z","pushed_at":"2018-11-15T01:18:56Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":87834,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":32,"watchers":43,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"de01aeb9f71edd915d961b1959b42400ddfffe2a","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQwOTQxNw==","name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2018-11-14T22:56:04Z","pushed_at":"2018-11-15T01:18:56Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":87834,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":32,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/2453"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2453"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/2453/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/2453/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/a4c2648c3982f3141dbb14e08d023c457f1d2dd3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"U-DON"}}