{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/samples-is/pulls/comments/239320791","pull_request_review_id":182074769,"id":239320791,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTMyMDc5MQ==","diff_hunk":"@@ -49,18 +52,22 @@ class Profile extends Component {\n \n     logoutClick() {\n         // Execute OIDC end session (logout) requests against WSO2 IS server\n-        this.application.makeLogoutRequest();\n+        this.appLogout.makeLogoutRequest();\n     }\n \n     componentWillMount() {\n \n         // Redirect completion callback method execution for authorization completion callback and end session (logout) completion callabck.\n-        this.application.checkForAuthorizationResponse().then(this.checkUserLoggedIn(this));\n+        if (this.app.getConfiguration().flowType == FLOW_TYPE_IMPLICIT) {","path":"oidc-client-app-samples/browser-client-app-sample/SPA_React_app/app/Profile.js","position":45,"original_position":45,"commit_id":"3247e7f5aa505edc550e3af5a4932fbbed0d6b2a","original_commit_id":"3247e7f5aa505edc550e3af5a4932fbbed0d6b2a","user":{"login":"thanujalk","id":1498339,"node_id":"MDQ6VXNlcjE0OTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1498339?v=4","gravatar_id":"","url":"https://api.github.com/users/thanujalk","html_url":"https://github.com/thanujalk","followers_url":"https://api.github.com/users/thanujalk/followers","following_url":"https://api.github.com/users/thanujalk/following{/other_user}","gists_url":"https://api.github.com/users/thanujalk/gists{/gist_id}","starred_url":"https://api.github.com/users/thanujalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanujalk/subscriptions","organizations_url":"https://api.github.com/users/thanujalk/orgs","repos_url":"https://api.github.com/users/thanujalk/repos","events_url":"https://api.github.com/users/thanujalk/events{/privacy}","received_events_url":"https://api.github.com/users/thanujalk/received_events","type":"User","site_admin":false},"body":"bring the static value to the front","created_at":"2018-12-06T03:50:19Z","updated_at":"2018-12-06T03:50:20Z","html_url":"https://github.com/wso2/samples-is/pull/137#discussion_r239320791","pull_request_url":"https://api.github.com/repos/wso2/samples-is/pulls/137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/comments/239320791"},"html":{"href":"https://github.com/wso2/samples-is/pull/137#discussion_r239320791"},"pull_request":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/samples-is/pulls/137","id":235330488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzMwNDg4","html_url":"https://github.com/wso2/samples-is/pull/137","diff_url":"https://github.com/wso2/samples-is/pull/137.diff","patch_url":"https://github.com/wso2/samples-is/pull/137.patch","issue_url":"https://api.github.com/repos/wso2/samples-is/issues/137","number":137,"state":"open","locked":false,"title":"Sample SPA HTML app with 3 libraries: AppAuth logout, PKCE, userInfo and AppAuth-JS","user":{"login":"ChinthakaSenanayaka","id":2564122,"node_id":"MDQ6VXNlcjI1NjQxMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2564122?v=4","gravatar_id":"","url":"https://api.github.com/users/ChinthakaSenanayaka","html_url":"https://github.com/ChinthakaSenanayaka","followers_url":"https://api.github.com/users/ChinthakaSenanayaka/followers","following_url":"https://api.github.com/users/ChinthakaSenanayaka/following{/other_user}","gists_url":"https://api.github.com/users/ChinthakaSenanayaka/gists{/gist_id}","starred_url":"https://api.github.com/users/ChinthakaSenanayaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChinthakaSenanayaka/subscriptions","organizations_url":"https://api.github.com/users/ChinthakaSenanayaka/orgs","repos_url":"https://api.github.com/users/ChinthakaSenanayaka/repos","events_url":"https://api.github.com/users/ChinthakaSenanayaka/events{/privacy}","received_events_url":"https://api.github.com/users/ChinthakaSenanayaka/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n> This PR contains 3 libraries: AppAuth logout, PKCE, userInfo and AppAuth-JS custom code after testing against SPA HTML app. React App support will be added later.\r\n\r\n## Goals\r\n> 3 libraries support for SPA HTML app and adding AppAuth-JS cutom code library location\r\n\r\n## Approach\r\n> 3 libraries approach\r\n\r\n## User stories\r\n> N/A\r\n\r\n## Release note\r\n> N/A\r\n\r\n## Documentation\r\n> N/A\r\n\r\n## Training\r\n> N/A\r\n\r\n## Certification\r\n> N/A\r\n\r\n## Marketing\r\n> N/A\r\n\r\n## Automation tests\r\n - Unit tests \r\n   > Code coverage information N/A\r\n - Integration tests\r\n   > Details about the test cases and coverage N/A\r\n\r\n## Security checks\r\n - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? N/A\r\n - Ran FindSecurityBugs plugin and verified report? N/A\r\n - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? N/A\r\n\r\n## Samples\r\n> https://github.com/wso2/samples-is/tree/master/oidc-client-app-samples/browser-client-app-sample\r\n\r\n## Related PRs\r\n> N/A\r\n\r\n## Migrations (if applicable)\r\n> N/A\r\n\r\n## Test environment\r\n> N/Atested\r\n \r\n## Learning\r\n> Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.","created_at":"2018-12-03T05:29:39Z","updated_at":"2018-12-06T03:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feaca1ffc34fbb3be54a1f2a3d710c4970da93a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/samples-is/pulls/137/commits","review_comments_url":"https://api.github.com/repos/wso2/samples-is/pulls/137/comments","review_comment_url":"https://api.github.com/repos/wso2/samples-is/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/samples-is/issues/137/comments","statuses_url":"https://api.github.com/repos/wso2/samples-is/statuses/3247e7f5aa505edc550e3af5a4932fbbed0d6b2a","head":{"label":"ChinthakaSenanayaka:master","ref":"master","sha":"3247e7f5aa505edc550e3af5a4932fbbed0d6b2a","user":{"login":"ChinthakaSenanayaka","id":2564122,"node_id":"MDQ6VXNlcjI1NjQxMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2564122?v=4","gravatar_id":"","url":"https://api.github.com/users/ChinthakaSenanayaka","html_url":"https://github.com/ChinthakaSenanayaka","followers_url":"https://api.github.com/users/ChinthakaSenanayaka/followers","following_url":"https://api.github.com/users/ChinthakaSenanayaka/following{/other_user}","gists_url":"https://api.github.com/users/ChinthakaSenanayaka/gists{/gist_id}","starred_url":"https://api.github.com/users/ChinthakaSenanayaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChinthakaSenanayaka/subscriptions","organizations_url":"https://api.github.com/users/ChinthakaSenanayaka/orgs","repos_url":"https://api.github.com/users/ChinthakaSenanayaka/repos","events_url":"https://api.github.com/users/ChinthakaSenanayaka/events{/privacy}","received_events_url":"https://api.github.com/users/ChinthakaSenanayaka/received_events","type":"User","site_admin":false},"repo":{"id":144107774,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxMDc3NzQ=","name":"samples-is","full_name":"ChinthakaSenanayaka/samples-is","private":false,"owner":{"login":"ChinthakaSenanayaka","id":2564122,"node_id":"MDQ6VXNlcjI1NjQxMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2564122?v=4","gravatar_id":"","url":"https://api.github.com/users/ChinthakaSenanayaka","html_url":"https://github.com/ChinthakaSenanayaka","followers_url":"https://api.github.com/users/ChinthakaSenanayaka/followers","following_url":"https://api.github.com/users/ChinthakaSenanayaka/following{/other_user}","gists_url":"https://api.github.com/users/ChinthakaSenanayaka/gists{/gist_id}","starred_url":"https://api.github.com/users/ChinthakaSenanayaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChinthakaSenanayaka/subscriptions","organizations_url":"https://api.github.com/users/ChinthakaSenanayaka/orgs","repos_url":"https://api.github.com/users/ChinthakaSenanayaka/repos","events_url":"https://api.github.com/users/ChinthakaSenanayaka/events{/privacy}","received_events_url":"https://api.github.com/users/ChinthakaSenanayaka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ChinthakaSenanayaka/samples-is","description":null,"fork":true,"url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is","forks_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/forks","keys_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/teams","hooks_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/hooks","issue_events_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/issues/events{/number}","events_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/events","assignees_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/assignees{/user}","branches_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/branches{/branch}","tags_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/tags","blobs_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/statuses/{sha}","languages_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/languages","stargazers_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/stargazers","contributors_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/contributors","subscribers_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/subscribers","subscription_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/subscription","commits_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/contents/{+path}","compare_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/merges","archive_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/downloads","issues_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/issues{/number}","pulls_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/pulls{/number}","milestones_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/milestones{/number}","notifications_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/labels{/name}","releases_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/releases{/id}","deployments_url":"https://api.github.com/repos/ChinthakaSenanayaka/samples-is/deployments","created_at":"2018-08-09T06:05:04Z","updated_at":"2018-12-05T19:01:37Z","pushed_at":"2018-12-05T19:01:34Z","git_url":"git://github.com/ChinthakaSenanayaka/samples-is.git","ssh_url":"git@github.com:ChinthakaSenanayaka/samples-is.git","clone_url":"https://github.com/ChinthakaSenanayaka/samples-is.git","svn_url":"https://github.com/ChinthakaSenanayaka/samples-is","homepage":null,"size":57693,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"761bb55811950fe781db479c9a2c59f1c00d4146","user":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":113807615,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4MDc2MTU=","name":"samples-is","full_name":"wso2/samples-is","private":false,"owner":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2/samples-is","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/samples-is","forks_url":"https://api.github.com/repos/wso2/samples-is/forks","keys_url":"https://api.github.com/repos/wso2/samples-is/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/samples-is/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/samples-is/teams","hooks_url":"https://api.github.com/repos/wso2/samples-is/hooks","issue_events_url":"https://api.github.com/repos/wso2/samples-is/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/samples-is/events","assignees_url":"https://api.github.com/repos/wso2/samples-is/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/samples-is/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/samples-is/tags","blobs_url":"https://api.github.com/repos/wso2/samples-is/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/samples-is/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/samples-is/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/samples-is/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/samples-is/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/samples-is/languages","stargazers_url":"https://api.github.com/repos/wso2/samples-is/stargazers","contributors_url":"https://api.github.com/repos/wso2/samples-is/contributors","subscribers_url":"https://api.github.com/repos/wso2/samples-is/subscribers","subscription_url":"https://api.github.com/repos/wso2/samples-is/subscription","commits_url":"https://api.github.com/repos/wso2/samples-is/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/samples-is/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/samples-is/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/samples-is/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/samples-is/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/samples-is/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/samples-is/merges","archive_url":"https://api.github.com/repos/wso2/samples-is/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/samples-is/downloads","issues_url":"https://api.github.com/repos/wso2/samples-is/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/samples-is/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/samples-is/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/samples-is/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/samples-is/labels{/name}","releases_url":"https://api.github.com/repos/wso2/samples-is/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/samples-is/deployments","created_at":"2017-12-11T03:27:41Z","updated_at":"2018-12-03T20:39:53Z","pushed_at":"2018-12-05T19:01:36Z","git_url":"git://github.com/wso2/samples-is.git","ssh_url":"git@github.com:wso2/samples-is.git","clone_url":"https://github.com/wso2/samples-is.git","svn_url":"https://github.com/wso2/samples-is","homepage":null,"size":57556,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/137"},"html":{"href":"https://github.com/wso2/samples-is/pull/137"},"issue":{"href":"https://api.github.com/repos/wso2/samples-is/issues/137"},"comments":{"href":"https://api.github.com/repos/wso2/samples-is/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/samples-is/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/samples-is/statuses/3247e7f5aa505edc550e3af5a4932fbbed0d6b2a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thanujalk"}}