{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/10485","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/10485/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/10485/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/10485/events","html_url":"https://github.com/Automattic/jetpack/issues/10485","id":375503942,"node_id":"MDU6SXNzdWUzNzU1MDM5NDI=","number":10485,"title":"Recipe Shortcode + Twenty Nineteen: Margin Issues","user":{"login":"kraftbj","id":88897,"node_id":"MDQ6VXNlcjg4ODk3","avatar_url":"https://avatars0.githubusercontent.com/u/88897?v=4","gravatar_id":"","url":"https://api.github.com/users/kraftbj","html_url":"https://github.com/kraftbj","followers_url":"https://api.github.com/users/kraftbj/followers","following_url":"https://api.github.com/users/kraftbj/following{/other_user}","gists_url":"https://api.github.com/users/kraftbj/gists{/gist_id}","starred_url":"https://api.github.com/users/kraftbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraftbj/subscriptions","organizations_url":"https://api.github.com/users/kraftbj/orgs","repos_url":"https://api.github.com/users/kraftbj/repos","events_url":"https://api.github.com/users/kraftbj/events{/privacy}","received_events_url":"https://api.github.com/users/kraftbj/received_events","type":"User","site_admin":false},"labels":[{"id":70993243,"node_id":"MDU6TGFiZWw3MDk5MzI0Mw==","url":"https://api.github.com/repos/Automattic/jetpack/labels/Shortcodes","name":"Shortcodes","color":"006b75","default":false},{"id":70896532,"node_id":"MDU6TGFiZWw3MDg5NjUzMg==","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Bug","name":"[Type] Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/114","html_url":"https://github.com/Automattic/jetpack/milestone/114","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/114/labels","id":3771343,"node_id":"MDk6TWlsZXN0b25lMzc3MTM0Mw==","number":114,"title":"6.8","description":"Mid-month release focussing on compatibility with WordPress 5.0.\r\n\r\nCode freeze on the 9th, release on the 14th.","creator":{"login":"jeherve","id":426388,"node_id":"MDQ6VXNlcjQyNjM4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/426388?v=4","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":1,"state":"open","created_at":"2018-10-26T11:18:20Z","updated_at":"2018-10-30T22:15:33Z","due_on":"2018-11-09T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-10-30T13:59:39Z","updated_at":"2018-10-30T23:11:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"With the legacy shortcode on Twenty Nineteen, the defined margins make things look poor.\r\n\r\n#### Steps to reproduce the issue\r\n\r\n1. Add a recipe shortcode on Twenty Nineteen\r\n\r\n#### What I expected\r\nSomething like this:\r\n![2018-10-30 at 08 57](https://user-images.githubusercontent.com/88897/47723121-db88b080-dc21-11e8-8f06-e24934418bfd.jpg)\r\n\r\n#### What happened instead\r\n\r\n![2018-10-30 at 08 57](https://user-images.githubusercontent.com/88897/47723158-ed6a5380-dc21-11e8-8191-0709812e1b6f.jpg)\r\n\r\nThis is due to the margin set for the `.jetpack-recipe` class `margin: 1.5em 1%`. I'm not terribly sure if this is something we should report and patch in Twenty Nineteen or in Jetpack. Thoughts?\r\n\r\ncc: @allancole "},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/434503738","html_url":"https://github.com/Automattic/jetpack/issues/10485#issuecomment-434503738","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/10485","id":434503738,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDUwMzczOA==","user":{"login":"crunnells","id":4297811,"node_id":"MDQ6VXNlcjQyOTc4MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4297811?v=4","gravatar_id":"","url":"https://api.github.com/users/crunnells","html_url":"https://github.com/crunnells","followers_url":"https://api.github.com/users/crunnells/followers","following_url":"https://api.github.com/users/crunnells/following{/other_user}","gists_url":"https://api.github.com/users/crunnells/gists{/gist_id}","starred_url":"https://api.github.com/users/crunnells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunnells/subscriptions","organizations_url":"https://api.github.com/users/crunnells/orgs","repos_url":"https://api.github.com/users/crunnells/repos","events_url":"https://api.github.com/users/crunnells/events{/privacy}","received_events_url":"https://api.github.com/users/crunnells/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T23:11:46Z","updated_at":"2018-10-30T23:11:46Z","author_association":"NONE","body":"This is going to be an issue with most Gutenberg themes moving forward. The implementation Twenty Nineteen uses to support wide and full-width images is one we're using for many of our new Gutenberg themes. As long as we're aware of which shortcodes need to have their margins overridden, we can make sure they're addressed in the theme CSS.\r\n\r\nAlternatively, we could take out the margins for some of these blocks, so that we have _less_ work moving forward."}}
{"actor":{"display_login":"crunnells"}}