{"action":"created","comment":{"url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/comments/165496182","pull_request_review_id":93447796,"id":165496182,"diff_hunk":"@@ -0,0 +1,18 @@\n+//\n+//  CompositionModel.swift\n+//  ArmonicSkeleton\n+//\n+//  Created by Miguel Santiago Rodríguez on 1/2/18.\n+//  Copyright © 2018 Miguel Santiago Rodríguez. All rights reserved.\n+//\n+\n+import Foundation\n+import ArmonicSkeletonMojo\n+\n+struct CompositionModel: Codable {","path":"ArmonicSkeleton/Model/CompositionModel.swift","position":12,"original_position":12,"commit_id":"72421e3cc11068ef2ae60057168071ad8cf04c50","original_commit_id":"72421e3cc11068ef2ae60057168071ad8cf04c50","user":{"login":"MarcosSorribas","id":6518337,"avatar_url":"https://avatars1.githubusercontent.com/u/6518337?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcosSorribas","html_url":"https://github.com/MarcosSorribas","followers_url":"https://api.github.com/users/MarcosSorribas/followers","following_url":"https://api.github.com/users/MarcosSorribas/following{/other_user}","gists_url":"https://api.github.com/users/MarcosSorribas/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcosSorribas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcosSorribas/subscriptions","organizations_url":"https://api.github.com/users/MarcosSorribas/orgs","repos_url":"https://api.github.com/users/MarcosSorribas/repos","events_url":"https://api.github.com/users/MarcosSorribas/events{/privacy}","received_events_url":"https://api.github.com/users/MarcosSorribas/received_events","type":"User","site_admin":false},"body":"pffff No me gusta tener Composition y Composition Model. \r\n\r\n¿Podemos unirlos? Yo creo que con el refactor que he hecho al mojo ya podemos persistir Composition directamente. De hecho habra que sacarla del Mojo como bien dijiste tu. \r\n\r\n¿Como ves este finde una sesion de pair programming remoto para refactorizar y poder seguir avanzando?\r\nTengo practicamente todo el finde libre, me adapto a tus horarios jajaja\r\n\r\n","created_at":"2018-02-01T21:41:03Z","updated_at":"2018-02-01T21:41:03Z","html_url":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6#discussion_r165496182","pull_request_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/comments/165496182"},"html":{"href":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6#discussion_r165496182"},"pull_request":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6","id":166656773,"html_url":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6","diff_url":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6.diff","patch_url":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6.patch","issue_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/6","number":6,"state":"open","locked":false,"title":"Persistence & Little refactor","user":{"login":"GaDaXaRa","id":1818514,"avatar_url":"https://avatars3.githubusercontent.com/u/1818514?v=4","gravatar_id":"","url":"https://api.github.com/users/GaDaXaRa","html_url":"https://github.com/GaDaXaRa","followers_url":"https://api.github.com/users/GaDaXaRa/followers","following_url":"https://api.github.com/users/GaDaXaRa/following{/other_user}","gists_url":"https://api.github.com/users/GaDaXaRa/gists{/gist_id}","starred_url":"https://api.github.com/users/GaDaXaRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaDaXaRa/subscriptions","organizations_url":"https://api.github.com/users/GaDaXaRa/orgs","repos_url":"https://api.github.com/users/GaDaXaRa/repos","events_url":"https://api.github.com/users/GaDaXaRa/events{/privacy}","received_events_url":"https://api.github.com/users/GaDaXaRa/received_events","type":"User","site_admin":false},"body":"Todo montado pero sin funcionar :P\n\nCreada la persistencia, sin matarse la verdad, y dándole más responsabilidad al presenter.\n\nDe momento sólo guarda el usar input, pero se puede hacer para que guarde el resultado también, lo veremos cuando se pueda cargar una composición.","created_at":"2018-02-01T21:29:22Z","updated_at":"2018-02-01T21:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f7287efe6cfc8c4319e9e4f72066cf96e0b0b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6/commits","review_comments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6/comments","review_comment_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/6/comments","statuses_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/statuses/72421e3cc11068ef2ae60057168071ad8cf04c50","head":{"label":"GaDaXaRa:refactor","ref":"refactor","sha":"72421e3cc11068ef2ae60057168071ad8cf04c50","user":{"login":"GaDaXaRa","id":1818514,"avatar_url":"https://avatars3.githubusercontent.com/u/1818514?v=4","gravatar_id":"","url":"https://api.github.com/users/GaDaXaRa","html_url":"https://github.com/GaDaXaRa","followers_url":"https://api.github.com/users/GaDaXaRa/followers","following_url":"https://api.github.com/users/GaDaXaRa/following{/other_user}","gists_url":"https://api.github.com/users/GaDaXaRa/gists{/gist_id}","starred_url":"https://api.github.com/users/GaDaXaRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaDaXaRa/subscriptions","organizations_url":"https://api.github.com/users/GaDaXaRa/orgs","repos_url":"https://api.github.com/users/GaDaXaRa/repos","events_url":"https://api.github.com/users/GaDaXaRa/events{/privacy}","received_events_url":"https://api.github.com/users/GaDaXaRa/received_events","type":"User","site_admin":false},"repo":{"id":118161855,"name":"ArmonicSkeleton","full_name":"GaDaXaRa/ArmonicSkeleton","owner":{"login":"GaDaXaRa","id":1818514,"avatar_url":"https://avatars3.githubusercontent.com/u/1818514?v=4","gravatar_id":"","url":"https://api.github.com/users/GaDaXaRa","html_url":"https://github.com/GaDaXaRa","followers_url":"https://api.github.com/users/GaDaXaRa/followers","following_url":"https://api.github.com/users/GaDaXaRa/following{/other_user}","gists_url":"https://api.github.com/users/GaDaXaRa/gists{/gist_id}","starred_url":"https://api.github.com/users/GaDaXaRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaDaXaRa/subscriptions","organizations_url":"https://api.github.com/users/GaDaXaRa/orgs","repos_url":"https://api.github.com/users/GaDaXaRa/repos","events_url":"https://api.github.com/users/GaDaXaRa/events{/privacy}","received_events_url":"https://api.github.com/users/GaDaXaRa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaDaXaRa/ArmonicSkeleton","description":null,"fork":false,"url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton","forks_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/forks","keys_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/teams","hooks_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/hooks","issue_events_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/events{/number}","events_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/events","assignees_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/assignees{/user}","branches_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/branches{/branch}","tags_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/tags","blobs_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/languages","stargazers_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/stargazers","contributors_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/contributors","subscribers_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/subscribers","subscription_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/subscription","commits_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/contents/{+path}","compare_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/merges","archive_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/downloads","issues_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues{/number}","pulls_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/labels{/name}","releases_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/releases{/id}","deployments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/deployments","created_at":"2018-01-19T18:21:02Z","updated_at":"2018-01-19T20:16:34Z","pushed_at":"2018-02-01T21:29:22Z","git_url":"git://github.com/GaDaXaRa/ArmonicSkeleton.git","ssh_url":"git@github.com:GaDaXaRa/ArmonicSkeleton.git","clone_url":"https://github.com/GaDaXaRa/ArmonicSkeleton.git","svn_url":"https://github.com/GaDaXaRa/ArmonicSkeleton","homepage":null,"size":12445,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GaDaXaRa:develop","ref":"develop","sha":"c1a795e90165c112d52c5cef5f8ca4287d955b52","user":{"login":"GaDaXaRa","id":1818514,"avatar_url":"https://avatars3.githubusercontent.com/u/1818514?v=4","gravatar_id":"","url":"https://api.github.com/users/GaDaXaRa","html_url":"https://github.com/GaDaXaRa","followers_url":"https://api.github.com/users/GaDaXaRa/followers","following_url":"https://api.github.com/users/GaDaXaRa/following{/other_user}","gists_url":"https://api.github.com/users/GaDaXaRa/gists{/gist_id}","starred_url":"https://api.github.com/users/GaDaXaRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaDaXaRa/subscriptions","organizations_url":"https://api.github.com/users/GaDaXaRa/orgs","repos_url":"https://api.github.com/users/GaDaXaRa/repos","events_url":"https://api.github.com/users/GaDaXaRa/events{/privacy}","received_events_url":"https://api.github.com/users/GaDaXaRa/received_events","type":"User","site_admin":false},"repo":{"id":118161855,"name":"ArmonicSkeleton","full_name":"GaDaXaRa/ArmonicSkeleton","owner":{"login":"GaDaXaRa","id":1818514,"avatar_url":"https://avatars3.githubusercontent.com/u/1818514?v=4","gravatar_id":"","url":"https://api.github.com/users/GaDaXaRa","html_url":"https://github.com/GaDaXaRa","followers_url":"https://api.github.com/users/GaDaXaRa/followers","following_url":"https://api.github.com/users/GaDaXaRa/following{/other_user}","gists_url":"https://api.github.com/users/GaDaXaRa/gists{/gist_id}","starred_url":"https://api.github.com/users/GaDaXaRa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaDaXaRa/subscriptions","organizations_url":"https://api.github.com/users/GaDaXaRa/orgs","repos_url":"https://api.github.com/users/GaDaXaRa/repos","events_url":"https://api.github.com/users/GaDaXaRa/events{/privacy}","received_events_url":"https://api.github.com/users/GaDaXaRa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaDaXaRa/ArmonicSkeleton","description":null,"fork":false,"url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton","forks_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/forks","keys_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/teams","hooks_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/hooks","issue_events_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/events{/number}","events_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/events","assignees_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/assignees{/user}","branches_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/branches{/branch}","tags_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/tags","blobs_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/languages","stargazers_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/stargazers","contributors_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/contributors","subscribers_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/subscribers","subscription_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/subscription","commits_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/contents/{+path}","compare_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/merges","archive_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/downloads","issues_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues{/number}","pulls_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/labels{/name}","releases_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/releases{/id}","deployments_url":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/deployments","created_at":"2018-01-19T18:21:02Z","updated_at":"2018-01-19T20:16:34Z","pushed_at":"2018-02-01T21:29:22Z","git_url":"git://github.com/GaDaXaRa/ArmonicSkeleton.git","ssh_url":"git@github.com:GaDaXaRa/ArmonicSkeleton.git","clone_url":"https://github.com/GaDaXaRa/ArmonicSkeleton.git","svn_url":"https://github.com/GaDaXaRa/ArmonicSkeleton","homepage":null,"size":12445,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6"},"html":{"href":"https://github.com/GaDaXaRa/ArmonicSkeleton/pull/6"},"issue":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/6"},"comments":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/GaDaXaRa/ArmonicSkeleton/statuses/72421e3cc11068ef2ae60057168071ad8cf04c50"}},"author_association":"OWNER"}}
{"actor":{"display_login":"MarcosSorribas"}}