{"action":"created","comment":{"url":"https://api.github.com/repos/roks0n/core/pulls/comments/208803815","pull_request_review_id":144687619,"id":208803815,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODgwMzgxNQ==","diff_hunk":"@@ -18,7 +18,8 @@ exports.setUp = async () => {\n     exclude: [\n       '@arkecosystem/core-p2p',\n       '@arkecosystem/core-transaction-pool',\n-      '@arkecosystem/core-transaction-pool-redis'\n+      '@arkecosystem/core-transaction-pool-redis',","path":"packages/core-database-sequelize/__tests__/__support__/setup.js","position":5,"original_position":5,"commit_id":"a9901acccb54416e3fb3702805d8eb74b8fec905","original_commit_id":"a9901acccb54416e3fb3702805d8eb74b8fec905","user":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"body":"You should remove the redis pool as it otherwise will get bootstraped and then overwritten by your pool which is unnecessary.","created_at":"2018-08-09T04:33:48Z","updated_at":"2018-08-09T04:33:48Z","html_url":"https://github.com/roks0n/core/pull/1#discussion_r208803815","pull_request_url":"https://api.github.com/repos/roks0n/core/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/roks0n/core/pulls/comments/208803815"},"html":{"href":"https://github.com/roks0n/core/pull/1#discussion_r208803815"},"pull_request":{"href":"https://api.github.com/repos/roks0n/core/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/roks0n/core/pulls/1","id":206246630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQ2NjMw","html_url":"https://github.com/roks0n/core/pull/1","diff_url":"https://github.com/roks0n/core/pull/1.diff","patch_url":"https://github.com/roks0n/core/pull/1.patch","issue_url":"https://api.github.com/repos/roks0n/core/issues/1","number":1,"state":"open","locked":false,"title":"Create core-transaction-pool-sequalize","user":{"login":"roks0n","id":889696,"node_id":"MDQ6VXNlcjg4OTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/889696?v=4","gravatar_id":"","url":"https://api.github.com/users/roks0n","html_url":"https://github.com/roks0n","followers_url":"https://api.github.com/users/roks0n/followers","following_url":"https://api.github.com/users/roks0n/following{/other_user}","gists_url":"https://api.github.com/users/roks0n/gists{/gist_id}","starred_url":"https://api.github.com/users/roks0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roks0n/subscriptions","organizations_url":"https://api.github.com/users/roks0n/orgs","repos_url":"https://api.github.com/users/roks0n/repos","events_url":"https://api.github.com/users/roks0n/events{/privacy}","received_events_url":"https://api.github.com/users/roks0n/received_events","type":"User","site_admin":false},"body":"Created a plugin to replace Redis with sequalize (SQLite, PostgreSQL) for the tx pool.\r\n\r\nI'd also like to take this opportunity to say thank you to Sir ninja for all the moral support.\r\n\r\n**Todo:**\r\n- [x] Running Testnet locally and sending transfers via `core-tester-cli` results in an error which occurs when `await transactionPool.guard.validate(request.payload.transactions)` is reached \r\n- [x]  I also need to look around if there’s an additional check anywhere in the codebase where we prevent already expired transactions to get in a block because if it isn’t my current implementation could cause this issue and I’d change that bit of code","created_at":"2018-08-05T16:19:39Z","updated_at":"2018-08-09T04:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f950ee9548b5f37225af5fd0e4e2cd5ed3bebbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/roks0n/core/pulls/1/commits","review_comments_url":"https://api.github.com/repos/roks0n/core/pulls/1/comments","review_comment_url":"https://api.github.com/repos/roks0n/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roks0n/core/issues/1/comments","statuses_url":"https://api.github.com/repos/roks0n/core/statuses/a9901acccb54416e3fb3702805d8eb74b8fec905","head":{"label":"roks0n:new-tx-pool","ref":"new-tx-pool","sha":"a9901acccb54416e3fb3702805d8eb74b8fec905","user":{"login":"roks0n","id":889696,"node_id":"MDQ6VXNlcjg4OTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/889696?v=4","gravatar_id":"","url":"https://api.github.com/users/roks0n","html_url":"https://github.com/roks0n","followers_url":"https://api.github.com/users/roks0n/followers","following_url":"https://api.github.com/users/roks0n/following{/other_user}","gists_url":"https://api.github.com/users/roks0n/gists{/gist_id}","starred_url":"https://api.github.com/users/roks0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roks0n/subscriptions","organizations_url":"https://api.github.com/users/roks0n/orgs","repos_url":"https://api.github.com/users/roks0n/repos","events_url":"https://api.github.com/users/roks0n/events{/privacy}","received_events_url":"https://api.github.com/users/roks0n/received_events","type":"User","site_admin":false},"repo":{"id":137323740,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMjM3NDA=","name":"core","full_name":"roks0n/core","owner":{"login":"roks0n","id":889696,"node_id":"MDQ6VXNlcjg4OTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/889696?v=4","gravatar_id":"","url":"https://api.github.com/users/roks0n","html_url":"https://github.com/roks0n","followers_url":"https://api.github.com/users/roks0n/followers","following_url":"https://api.github.com/users/roks0n/following{/other_user}","gists_url":"https://api.github.com/users/roks0n/gists{/gist_id}","starred_url":"https://api.github.com/users/roks0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roks0n/subscriptions","organizations_url":"https://api.github.com/users/roks0n/orgs","repos_url":"https://api.github.com/users/roks0n/repos","events_url":"https://api.github.com/users/roks0n/events{/privacy}","received_events_url":"https://api.github.com/users/roks0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roks0n/core","description":"complete rewrite of ark-node","fork":true,"url":"https://api.github.com/repos/roks0n/core","forks_url":"https://api.github.com/repos/roks0n/core/forks","keys_url":"https://api.github.com/repos/roks0n/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roks0n/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roks0n/core/teams","hooks_url":"https://api.github.com/repos/roks0n/core/hooks","issue_events_url":"https://api.github.com/repos/roks0n/core/issues/events{/number}","events_url":"https://api.github.com/repos/roks0n/core/events","assignees_url":"https://api.github.com/repos/roks0n/core/assignees{/user}","branches_url":"https://api.github.com/repos/roks0n/core/branches{/branch}","tags_url":"https://api.github.com/repos/roks0n/core/tags","blobs_url":"https://api.github.com/repos/roks0n/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roks0n/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roks0n/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/roks0n/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roks0n/core/statuses/{sha}","languages_url":"https://api.github.com/repos/roks0n/core/languages","stargazers_url":"https://api.github.com/repos/roks0n/core/stargazers","contributors_url":"https://api.github.com/repos/roks0n/core/contributors","subscribers_url":"https://api.github.com/repos/roks0n/core/subscribers","subscription_url":"https://api.github.com/repos/roks0n/core/subscription","commits_url":"https://api.github.com/repos/roks0n/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/roks0n/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/roks0n/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/roks0n/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/roks0n/core/contents/{+path}","compare_url":"https://api.github.com/repos/roks0n/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roks0n/core/merges","archive_url":"https://api.github.com/repos/roks0n/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roks0n/core/downloads","issues_url":"https://api.github.com/repos/roks0n/core/issues{/number}","pulls_url":"https://api.github.com/repos/roks0n/core/pulls{/number}","milestones_url":"https://api.github.com/repos/roks0n/core/milestones{/number}","notifications_url":"https://api.github.com/repos/roks0n/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roks0n/core/labels{/name}","releases_url":"https://api.github.com/repos/roks0n/core/releases{/id}","deployments_url":"https://api.github.com/repos/roks0n/core/deployments","created_at":"2018-06-14T07:41:05Z","updated_at":"2018-08-08T20:34:26Z","pushed_at":"2018-08-08T20:35:15Z","git_url":"git://github.com/roks0n/core.git","ssh_url":"git@github.com:roks0n/core.git","clone_url":"https://github.com/roks0n/core.git","svn_url":"https://github.com/roks0n/core","homepage":null,"size":7290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"roks0n:master","ref":"master","sha":"826190a334d8d84ecbcfa2518ee7897c08ecebfe","user":{"login":"roks0n","id":889696,"node_id":"MDQ6VXNlcjg4OTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/889696?v=4","gravatar_id":"","url":"https://api.github.com/users/roks0n","html_url":"https://github.com/roks0n","followers_url":"https://api.github.com/users/roks0n/followers","following_url":"https://api.github.com/users/roks0n/following{/other_user}","gists_url":"https://api.github.com/users/roks0n/gists{/gist_id}","starred_url":"https://api.github.com/users/roks0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roks0n/subscriptions","organizations_url":"https://api.github.com/users/roks0n/orgs","repos_url":"https://api.github.com/users/roks0n/repos","events_url":"https://api.github.com/users/roks0n/events{/privacy}","received_events_url":"https://api.github.com/users/roks0n/received_events","type":"User","site_admin":false},"repo":{"id":137323740,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMjM3NDA=","name":"core","full_name":"roks0n/core","owner":{"login":"roks0n","id":889696,"node_id":"MDQ6VXNlcjg4OTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/889696?v=4","gravatar_id":"","url":"https://api.github.com/users/roks0n","html_url":"https://github.com/roks0n","followers_url":"https://api.github.com/users/roks0n/followers","following_url":"https://api.github.com/users/roks0n/following{/other_user}","gists_url":"https://api.github.com/users/roks0n/gists{/gist_id}","starred_url":"https://api.github.com/users/roks0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roks0n/subscriptions","organizations_url":"https://api.github.com/users/roks0n/orgs","repos_url":"https://api.github.com/users/roks0n/repos","events_url":"https://api.github.com/users/roks0n/events{/privacy}","received_events_url":"https://api.github.com/users/roks0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roks0n/core","description":"complete rewrite of ark-node","fork":true,"url":"https://api.github.com/repos/roks0n/core","forks_url":"https://api.github.com/repos/roks0n/core/forks","keys_url":"https://api.github.com/repos/roks0n/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roks0n/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roks0n/core/teams","hooks_url":"https://api.github.com/repos/roks0n/core/hooks","issue_events_url":"https://api.github.com/repos/roks0n/core/issues/events{/number}","events_url":"https://api.github.com/repos/roks0n/core/events","assignees_url":"https://api.github.com/repos/roks0n/core/assignees{/user}","branches_url":"https://api.github.com/repos/roks0n/core/branches{/branch}","tags_url":"https://api.github.com/repos/roks0n/core/tags","blobs_url":"https://api.github.com/repos/roks0n/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roks0n/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roks0n/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/roks0n/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roks0n/core/statuses/{sha}","languages_url":"https://api.github.com/repos/roks0n/core/languages","stargazers_url":"https://api.github.com/repos/roks0n/core/stargazers","contributors_url":"https://api.github.com/repos/roks0n/core/contributors","subscribers_url":"https://api.github.com/repos/roks0n/core/subscribers","subscription_url":"https://api.github.com/repos/roks0n/core/subscription","commits_url":"https://api.github.com/repos/roks0n/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/roks0n/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/roks0n/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/roks0n/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/roks0n/core/contents/{+path}","compare_url":"https://api.github.com/repos/roks0n/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roks0n/core/merges","archive_url":"https://api.github.com/repos/roks0n/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roks0n/core/downloads","issues_url":"https://api.github.com/repos/roks0n/core/issues{/number}","pulls_url":"https://api.github.com/repos/roks0n/core/pulls{/number}","milestones_url":"https://api.github.com/repos/roks0n/core/milestones{/number}","notifications_url":"https://api.github.com/repos/roks0n/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roks0n/core/labels{/name}","releases_url":"https://api.github.com/repos/roks0n/core/releases{/id}","deployments_url":"https://api.github.com/repos/roks0n/core/deployments","created_at":"2018-06-14T07:41:05Z","updated_at":"2018-08-08T20:34:26Z","pushed_at":"2018-08-08T20:35:15Z","git_url":"git://github.com/roks0n/core.git","ssh_url":"git@github.com:roks0n/core.git","clone_url":"https://github.com/roks0n/core.git","svn_url":"https://github.com/roks0n/core","homepage":null,"size":7290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roks0n/core/pulls/1"},"html":{"href":"https://github.com/roks0n/core/pull/1"},"issue":{"href":"https://api.github.com/repos/roks0n/core/issues/1"},"comments":{"href":"https://api.github.com/repos/roks0n/core/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/roks0n/core/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/roks0n/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roks0n/core/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/roks0n/core/statuses/a9901acccb54416e3fb3702805d8eb74b8fec905"}},"author_association":"OWNER"}}
{"actor":{"display_login":"faustbrian"}}