{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/178648120","pull_request_review_id":108739939,"id":178648120,"diff_hunk":"@@ -2129,8 +2129,15 @@ namespace Js\n                 {\n                     JavascriptError::ThrowTypeError(scriptContext, JSERR_This_NeedFunction, _u(\"construct\"));\n                 }\n-                newThisObject = JavascriptOperators::NewScObjectNoCtor(targetObj, scriptContext);\n-                args.Values[0] = newThisObject;\n+                if (!isCtorSuperCall)\n+                {\n+                    newThisObject = JavascriptOperators::NewScObjectNoCtor(targetObj, scriptContext);\n+                    args.Values[0] = newThisObject;\n+                }\n+                else","path":"lib/Runtime/Library/JavascriptProxy.cpp","position":11,"original_position":11,"commit_id":"fcfcb74d92112940834c6bb800c3084e60e35f59","original_commit_id":"fcfcb74d92112940834c6bb800c3084e60e35f59","user":{"login":"boingoing","id":1569843,"avatar_url":"https://avatars3.githubusercontent.com/u/1569843?v=4","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},"body":"Oh thanks for pointing this out. I searched for this name but it didn't highlight that one on line 2187. I see no problems with this code, then.","created_at":"2018-04-02T20:56:06Z","updated_at":"2018-04-02T20:56:07Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/4908#discussion_r178648120","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/178648120"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4908#discussion_r178648120"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908"}},"in_reply_to_id":178616915},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908","id":178454732,"html_url":"https://github.com/Microsoft/ChakraCore/pull/4908","diff_url":"https://github.com/Microsoft/ChakraCore/pull/4908.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/4908.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4908","number":4908,"state":"open","locked":false,"title":"Class extension of proxy without construct trap fix #4729","user":{"login":"rhuanjl","id":30090552,"avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"body":"Proxy trap function when there's no construct trap was always making a new object as the \"this\" to use - in the case of a super call this would break the class inheritance chain.\r\n\r\nCurrently CC's behaviour on this differers from jsc, v8 and sm. This fix brings CC into line with the others.\r\n\r\nShould fix #4729 ","created_at":"2018-03-29T22:13:42Z","updated_at":"2018-04-02T20:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9275faefc120b2530bc98de9b1a6ba1b68c38ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4908/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/fcfcb74d92112940834c6bb800c3084e60e35f59","head":{"label":"rhuanjl:proxySuper","ref":"proxySuper","sha":"fcfcb74d92112940834c6bb800c3084e60e35f59","user":{"login":"rhuanjl","id":30090552,"avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"repo":{"id":117721683,"name":"ChakraCore","full_name":"rhuanjl/ChakraCore","owner":{"login":"rhuanjl","id":30090552,"avatar_url":"https://avatars3.githubusercontent.com/u/30090552?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuanjl","html_url":"https://github.com/rhuanjl","followers_url":"https://api.github.com/users/rhuanjl/followers","following_url":"https://api.github.com/users/rhuanjl/following{/other_user}","gists_url":"https://api.github.com/users/rhuanjl/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuanjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuanjl/subscriptions","organizations_url":"https://api.github.com/users/rhuanjl/orgs","repos_url":"https://api.github.com/users/rhuanjl/repos","events_url":"https://api.github.com/users/rhuanjl/events{/privacy}","received_events_url":"https://api.github.com/users/rhuanjl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhuanjl/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/rhuanjl/ChakraCore","forks_url":"https://api.github.com/repos/rhuanjl/ChakraCore/forks","keys_url":"https://api.github.com/repos/rhuanjl/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhuanjl/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhuanjl/ChakraCore/teams","hooks_url":"https://api.github.com/repos/rhuanjl/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/rhuanjl/ChakraCore/events","assignees_url":"https://api.github.com/repos/rhuanjl/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/rhuanjl/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/rhuanjl/ChakraCore/tags","blobs_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhuanjl/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/rhuanjl/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/rhuanjl/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/rhuanjl/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/rhuanjl/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/rhuanjl/ChakraCore/subscription","commits_url":"https://api.github.com/repos/rhuanjl/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhuanjl/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhuanjl/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhuanjl/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/rhuanjl/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhuanjl/ChakraCore/merges","archive_url":"https://api.github.com/repos/rhuanjl/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhuanjl/ChakraCore/downloads","issues_url":"https://api.github.com/repos/rhuanjl/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/rhuanjl/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/rhuanjl/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/rhuanjl/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhuanjl/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/rhuanjl/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/rhuanjl/ChakraCore/deployments","created_at":"2018-01-16T18:11:05Z","updated_at":"2018-03-30T19:49:55Z","pushed_at":"2018-03-31T11:12:32Z","git_url":"git://github.com/rhuanjl/ChakraCore.git","ssh_url":"git@github.com:rhuanjl/ChakraCore.git","clone_url":"https://github.com/rhuanjl/ChakraCore.git","svn_url":"https://github.com/rhuanjl/ChakraCore","homepage":"","size":116399,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"18e7cced8c64300e33b7f49288eb83c60bec75c0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2018-04-02T20:38:31Z","pushed_at":"2018-04-02T20:54:24Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":121777,"stargazers_count":6869,"watchers_count":6869,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":895,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":895,"open_issues":324,"watchers":6869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4908"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4908"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4908/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4908/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/fcfcb74d92112940834c6bb800c3084e60e35f59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"boingoing"}}