{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/207864179","pull_request_review_id":143558682,"id":207864179,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg2NDE3OQ==","diff_hunk":"@@ -282,6 +288,57 @@\n \n     static final ObjectTypeAttributeDefinition CERTIFICATE_REVOCATION_LIST = new ObjectTypeAttributeDefinition.Builder(ElytronDescriptionConstants.CERTIFICATE_REVOCATION_LIST, PATH, RELATIVE_TO, MAXIMUM_CERT_PATH)\n             .setRequired(false)\n+            .setAlternatives(ElytronDescriptionConstants.ONLINE_CERTIFICATE_STATUS)\n+            .setRestartAllServices()\n+            .build();\n+\n+    private static final SimpleAttributeDefinition RESPONDER = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.RESPONDER, ModelType.STRING, true)\n+            .setAllowExpression(true)\n+            .setRestartAllServices()\n+            .build();\n+\n+    private static final SimpleAttributeDefinition OCSP_TRUSTSTORE = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.KEY_STORE, ModelType.STRING, true)\n+            .setAllowExpression(true)\n+            .setCapabilityReference(KEY_STORE_CAPABILITY, TRUST_MANAGER_CAPABILITY)\n+            .setRestartAllServices()\n+            .build();\n+\n+    private static final SimpleAttributeDefinition ACCEPT_UNKNOWN = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.ACCEPT_UNKNOWN, ModelType.BOOLEAN, true)\n+            .setAllowExpression(true)\n+            .setDefaultValue(new ModelNode(false))\n+            .setRestartAllServices()\n+            .build();\n+\n+    private static final SimpleAttributeDefinition ACCEPT_WHEN_STATUS_UNAVAILABLE = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.ACCEPT_WHEN_STATUS_UNAVAILABLE, ModelType.BOOLEAN, true)\n+            .setAllowExpression(true)\n+            .setDefaultValue(new ModelNode(false))\n+            .setRestartAllServices()\n+            .build();\n+\n+    private static final SimpleAttributeDefinition CONNECTION_TIMEOUT = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.CONNECTION_TIMEOUT, ModelType.INT, true)\n+            .setAllowExpression(true)\n+            .setRestartAllServices()\n+            .build();","path":"elytron/src/main/java/org/wildfly/extension/elytron/SSLDefinitions.java","position":null,"original_position":66,"commit_id":"c65a60ad8c1c6dd132e048864a5910b15f7e0a1b","original_commit_id":"98ed4400c6c703f112396779fd1f58ef134dfb3b","user":{"login":"hkalina","id":3178122,"node_id":"MDQ6VXNlcjMxNzgxMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3178122?v=4","gravatar_id":"","url":"https://api.github.com/users/hkalina","html_url":"https://github.com/hkalina","followers_url":"https://api.github.com/users/hkalina/followers","following_url":"https://api.github.com/users/hkalina/following{/other_user}","gists_url":"https://api.github.com/users/hkalina/gists{/gist_id}","starred_url":"https://api.github.com/users/hkalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkalina/subscriptions","organizations_url":"https://api.github.com/users/hkalina/orgs","repos_url":"https://api.github.com/users/hkalina/repos","events_url":"https://api.github.com/users/hkalina/events{/privacy}","received_events_url":"https://api.github.com/users/hkalina/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-08-06T11:51:55Z","updated_at":"2018-08-06T11:51:55Z","html_url":"https://github.com/wildfly/wildfly-core/pull/3402#discussion_r207864179","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/207864179"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3402#discussion_r207864179"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402"}},"in_reply_to_id":207526562},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402","id":204182647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTgyNjQ3","html_url":"https://github.com/wildfly/wildfly-core/pull/3402","diff_url":"https://github.com/wildfly/wildfly-core/pull/3402.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/3402.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3402","number":3402,"state":"open","locked":false,"title":"[WFCORE-3947] OCSP into elytron trustmanager","user":{"login":"hkalina","id":3178122,"node_id":"MDQ6VXNlcjMxNzgxMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3178122?v=4","gravatar_id":"","url":"https://api.github.com/users/hkalina","html_url":"https://github.com/hkalina","followers_url":"https://api.github.com/users/hkalina/followers","following_url":"https://api.github.com/users/hkalina/following{/other_user}","gists_url":"https://api.github.com/users/hkalina/gists{/gist_id}","starred_url":"https://api.github.com/users/hkalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkalina/subscriptions","organizations_url":"https://api.github.com/users/hkalina/orgs","repos_url":"https://api.github.com/users/hkalina/repos","events_url":"https://api.github.com/users/hkalina/events{/privacy}","received_events_url":"https://api.github.com/users/hkalina/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/WFCORE-3947\r\nhttps://issues.jboss.org/browse/EAP7-715\r\n\r\n**depends on https://github.com/wildfly-security/wildfly-elytron/pull/1161**\r\n\r\nanalysis document: https://github.com/wildfly/wildfly-proposals/pull/104","created_at":"2018-07-26T15:34:02Z","updated_at":"2018-08-06T11:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fdcff53c83d7da123fbee7865ef9110c230489d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3402/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/c65a60ad8c1c6dd132e048864a5910b15f7e0a1b","head":{"label":"hkalina:WFCORE-3947","ref":"WFCORE-3947","sha":"c65a60ad8c1c6dd132e048864a5910b15f7e0a1b","user":{"login":"hkalina","id":3178122,"node_id":"MDQ6VXNlcjMxNzgxMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3178122?v=4","gravatar_id":"","url":"https://api.github.com/users/hkalina","html_url":"https://github.com/hkalina","followers_url":"https://api.github.com/users/hkalina/followers","following_url":"https://api.github.com/users/hkalina/following{/other_user}","gists_url":"https://api.github.com/users/hkalina/gists{/gist_id}","starred_url":"https://api.github.com/users/hkalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkalina/subscriptions","organizations_url":"https://api.github.com/users/hkalina/orgs","repos_url":"https://api.github.com/users/hkalina/repos","events_url":"https://api.github.com/users/hkalina/events{/privacy}","received_events_url":"https://api.github.com/users/hkalina/received_events","type":"User","site_admin":false},"repo":{"id":68276391,"node_id":"MDEwOlJlcG9zaXRvcnk2ODI3NjM5MQ==","name":"wildfly-core","full_name":"hkalina/wildfly-core","owner":{"login":"hkalina","id":3178122,"node_id":"MDQ6VXNlcjMxNzgxMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3178122?v=4","gravatar_id":"","url":"https://api.github.com/users/hkalina","html_url":"https://github.com/hkalina","followers_url":"https://api.github.com/users/hkalina/followers","following_url":"https://api.github.com/users/hkalina/following{/other_user}","gists_url":"https://api.github.com/users/hkalina/gists{/gist_id}","starred_url":"https://api.github.com/users/hkalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkalina/subscriptions","organizations_url":"https://api.github.com/users/hkalina/orgs","repos_url":"https://api.github.com/users/hkalina/repos","events_url":"https://api.github.com/users/hkalina/events{/privacy}","received_events_url":"https://api.github.com/users/hkalina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkalina/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/hkalina/wildfly-core","forks_url":"https://api.github.com/repos/hkalina/wildfly-core/forks","keys_url":"https://api.github.com/repos/hkalina/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkalina/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkalina/wildfly-core/teams","hooks_url":"https://api.github.com/repos/hkalina/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/hkalina/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/hkalina/wildfly-core/events","assignees_url":"https://api.github.com/repos/hkalina/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/hkalina/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/hkalina/wildfly-core/tags","blobs_url":"https://api.github.com/repos/hkalina/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkalina/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkalina/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkalina/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkalina/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hkalina/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/hkalina/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/hkalina/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/hkalina/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/hkalina/wildfly-core/subscription","commits_url":"https://api.github.com/repos/hkalina/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkalina/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkalina/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkalina/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkalina/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/hkalina/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkalina/wildfly-core/merges","archive_url":"https://api.github.com/repos/hkalina/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkalina/wildfly-core/downloads","issues_url":"https://api.github.com/repos/hkalina/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/hkalina/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hkalina/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hkalina/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkalina/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/hkalina/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/hkalina/wildfly-core/deployments","created_at":"2016-09-15T07:59:14Z","updated_at":"2016-09-15T07:59:30Z","pushed_at":"2018-08-06T11:22:30Z","git_url":"git://github.com/hkalina/wildfly-core.git","ssh_url":"git@github.com:hkalina/wildfly-core.git","clone_url":"https://github.com/hkalina/wildfly-core.git","svn_url":"https://github.com/hkalina/wildfly-core","homepage":null,"size":68121,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"cb10de0cba036fe89886b54ac1111f2a29bde7ae","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM5NDk1NA==","name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2018-08-05T12:27:39Z","pushed_at":"2018-08-06T11:22:31Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":71975,"stargazers_count":98,"watchers_count":98,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":323,"open_issues":37,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3402"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3402"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3402/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3402/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/c65a60ad8c1c6dd132e048864a5910b15f7e0a1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hkalina"}}