{"action":"created","issue":{"url":"https://api.github.com/repos/r0adkll/DeckBox/issues/6","repository_url":"https://api.github.com/repos/r0adkll/DeckBox","labels_url":"https://api.github.com/repos/r0adkll/DeckBox/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/r0adkll/DeckBox/issues/6/comments","events_url":"https://api.github.com/repos/r0adkll/DeckBox/issues/6/events","html_url":"https://github.com/r0adkll/DeckBox/issues/6","id":318413317,"node_id":"MDU6SXNzdWUzMTg0MTMzMTc=","number":6,"title":"Full Offline Capability","user":{"login":"r0adkll","id":1237372,"node_id":"MDQ6VXNlcjEyMzczNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1237372?v=4","gravatar_id":"","url":"https://api.github.com/users/r0adkll","html_url":"https://github.com/r0adkll","followers_url":"https://api.github.com/users/r0adkll/followers","following_url":"https://api.github.com/users/r0adkll/following{/other_user}","gists_url":"https://api.github.com/users/r0adkll/gists{/gist_id}","starred_url":"https://api.github.com/users/r0adkll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0adkll/subscriptions","organizations_url":"https://api.github.com/users/r0adkll/orgs","repos_url":"https://api.github.com/users/r0adkll/repos","events_url":"https://api.github.com/users/r0adkll/events{/privacy}","received_events_url":"https://api.github.com/users/r0adkll/received_events","type":"User","site_admin":false},"labels":[{"id":915079896,"node_id":"MDU6TGFiZWw5MTUwNzk4OTY=","url":"https://api.github.com/repos/r0adkll/DeckBox/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":915079897,"node_id":"MDU6TGFiZWw5MTUwNzk4OTc=","url":"https://api.github.com/repos/r0adkll/DeckBox/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":{"login":"r0adkll","id":1237372,"node_id":"MDQ6VXNlcjEyMzczNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1237372?v=4","gravatar_id":"","url":"https://api.github.com/users/r0adkll","html_url":"https://github.com/r0adkll","followers_url":"https://api.github.com/users/r0adkll/followers","following_url":"https://api.github.com/users/r0adkll/following{/other_user}","gists_url":"https://api.github.com/users/r0adkll/gists{/gist_id}","starred_url":"https://api.github.com/users/r0adkll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0adkll/subscriptions","organizations_url":"https://api.github.com/users/r0adkll/orgs","repos_url":"https://api.github.com/users/r0adkll/repos","events_url":"https://api.github.com/users/r0adkll/events{/privacy}","received_events_url":"https://api.github.com/users/r0adkll/received_events","type":"User","site_admin":false},"assignees":[{"login":"r0adkll","id":1237372,"node_id":"MDQ6VXNlcjEyMzczNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1237372?v=4","gravatar_id":"","url":"https://api.github.com/users/r0adkll","html_url":"https://github.com/r0adkll","followers_url":"https://api.github.com/users/r0adkll/followers","following_url":"https://api.github.com/users/r0adkll/following{/other_user}","gists_url":"https://api.github.com/users/r0adkll/gists{/gist_id}","starred_url":"https://api.github.com/users/r0adkll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0adkll/subscriptions","organizations_url":"https://api.github.com/users/r0adkll/orgs","repos_url":"https://api.github.com/users/r0adkll/repos","events_url":"https://api.github.com/users/r0adkll/events{/privacy}","received_events_url":"https://api.github.com/users/r0adkll/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-27T13:39:03Z","updated_at":"2018-09-13T21:55:19Z","closed_at":null,"author_association":"OWNER","body":"Expand the caching features in the application.\r\n\r\nThere is already a subsystem in place to download and cache the card data from [pokemontcg.io](https://pokemontcg.io) which you can find here: [DefaultCardManager](https://github.com/r0adkll/DeckBox/blob/development/app/src/main/java/com/r0adkll/deckbuilder/arch/data/features/cards/DefaultCacheManager.kt) and here [CacheService](https://github.com/r0adkll/DeckBox/blob/development/app/src/main/java/com/r0adkll/deckbuilder/arch/data/features/cards/service/CacheService.kt)\r\n\r\nThis now works when searching for cards, but image cache still needs to be implemented for a truly offline experience. My intention was to leverage [Glide's built in caching mechanism].(https://bumptech.github.io/glide/doc/configuration.html#disk-cache) to cache card images one set at a time (as caching EVERY SINGLE CARD would be too expensive) so that they will automatically work without too much effort"},"comment":{"url":"https://api.github.com/repos/r0adkll/DeckBox/issues/comments/421165781","html_url":"https://github.com/r0adkll/DeckBox/issues/6#issuecomment-421165781","issue_url":"https://api.github.com/repos/r0adkll/DeckBox/issues/6","id":421165781,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTE2NTc4MQ==","user":{"login":"r0adkll","id":1237372,"node_id":"MDQ6VXNlcjEyMzczNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1237372?v=4","gravatar_id":"","url":"https://api.github.com/users/r0adkll","html_url":"https://github.com/r0adkll","followers_url":"https://api.github.com/users/r0adkll/followers","following_url":"https://api.github.com/users/r0adkll/following{/other_user}","gists_url":"https://api.github.com/users/r0adkll/gists{/gist_id}","starred_url":"https://api.github.com/users/r0adkll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0adkll/subscriptions","organizations_url":"https://api.github.com/users/r0adkll/orgs","repos_url":"https://api.github.com/users/r0adkll/repos","events_url":"https://api.github.com/users/r0adkll/events{/privacy}","received_events_url":"https://api.github.com/users/r0adkll/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T21:55:19Z","updated_at":"2018-09-13T21:55:19Z","author_association":"OWNER","body":"Expanding this issue to cover a broader scope. \r\n\r\nThe current \"anonymous/offline\" user implementation needs to be sunsetted to help streamline the onboarding experience for users. Ideally, I would like to remove the Login screen in favor of an offline-first implementation where the user can later link their device to Google account and switch over to using Firestore instead of local SQLite.\r\n\r\nIn combination with the aforementioned caching feature, this would enable a fully offline experience for users that want it, while maintaining the current online implementation for those that link their Google account."}}
{"actor":{"display_login":"r0adkll"}}