{"action":"created","issue":{"url":"https://api.github.com/repos/MessageKit/MessageKit/issues/400","repository_url":"https://api.github.com/repos/MessageKit/MessageKit","labels_url":"https://api.github.com/repos/MessageKit/MessageKit/issues/400/labels{/name}","comments_url":"https://api.github.com/repos/MessageKit/MessageKit/issues/400/comments","events_url":"https://api.github.com/repos/MessageKit/MessageKit/issues/400/events","html_url":"https://github.com/MessageKit/MessageKit/issues/400","id":281751227,"node_id":"MDU6SXNzdWUyODE3NTEyMjc=","number":400,"title":"collectionView's didSelectItemAt: not call when touching Cells","user":{"login":"jdriselvato","id":950825,"node_id":"MDQ6VXNlcjk1MDgyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/950825?v=4","gravatar_id":"","url":"https://api.github.com/users/jdriselvato","html_url":"https://github.com/jdriselvato","followers_url":"https://api.github.com/users/jdriselvato/followers","following_url":"https://api.github.com/users/jdriselvato/following{/other_user}","gists_url":"https://api.github.com/users/jdriselvato/gists{/gist_id}","starred_url":"https://api.github.com/users/jdriselvato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdriselvato/subscriptions","organizations_url":"https://api.github.com/users/jdriselvato/orgs","repos_url":"https://api.github.com/users/jdriselvato/repos","events_url":"https://api.github.com/users/jdriselvato/events{/privacy}","received_events_url":"https://api.github.com/users/jdriselvato/received_events","type":"User","site_admin":false},"labels":[{"id":649037378,"node_id":"MDU6TGFiZWw2NDkwMzczNzg=","url":"https://api.github.com/repos/MessageKit/MessageKit/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":703564473,"node_id":"MDU6TGFiZWw3MDM1NjQ0NzM=","url":"https://api.github.com/repos/MessageKit/MessageKit/labels/feature%20request","name":"feature request","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MessageKit/MessageKit/milestones/17","html_url":"https://github.com/MessageKit/MessageKit/milestone/17","labels_url":"https://api.github.com/repos/MessageKit/MessageKit/milestones/17/labels","id":3225026,"node_id":"MDk6TWlsZXN0b25lMzIyNTAyNg==","number":17,"title":"2.1","description":"","creator":{"login":"SD10","id":7445580,"node_id":"MDQ6VXNlcjc0NDU1ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/7445580?v=4","gravatar_id":"","url":"https://api.github.com/users/SD10","html_url":"https://github.com/SD10","followers_url":"https://api.github.com/users/SD10/followers","following_url":"https://api.github.com/users/SD10/following{/other_user}","gists_url":"https://api.github.com/users/SD10/gists{/gist_id}","starred_url":"https://api.github.com/users/SD10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SD10/subscriptions","organizations_url":"https://api.github.com/users/SD10/orgs","repos_url":"https://api.github.com/users/SD10/repos","events_url":"https://api.github.com/users/SD10/events{/privacy}","received_events_url":"https://api.github.com/users/SD10/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2018-03-28T11:44:35Z","updated_at":"2018-12-10T00:15:16Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2017-12-13T13:34:26Z","updated_at":"2018-12-11T05:19:20Z","closed_at":null,"author_association":"NONE","body":"## General Information\r\n\r\n* MessageKit Version: v0.11.0 (Pods)\r\n\r\n* iOS Version(s): 11.1\r\n\r\n* Swift Version: 4.0\r\n\r\n* Devices/Simulators: Both\r\n \r\n* Reproducible in ChatExample? (Yes/No):  YES\r\n\r\n\r\n\r\n##  What happened?\r\n\r\n- I tap a bubble, avatar, date, title and the respective MessageCellDelegate are called. \r\n- I tap a bubble, avatar, date, title and collectionView's `didSelectItemAt:` does not get called\r\n- I tap outside of any of those items (the white space around it) `didSelectItemAt:` gets called.\r\n\r\n\r\n## What did you expect to happen?\r\n\r\n- I tap any part of a cell and collectionView's `didSelectItemAt:` should be called\r\n\r\n\r\n## Why?\r\nI need to identify the MessageType for selected cell.\r\n\r\nI did find this: https://github.com/MessageKit/MessageKit/issues/154, which works if you do this:\r\n\r\n```\r\nfunc didTapMessage<T>(in cell: MessageCollectionViewCell<T>) {\r\n        let indexPath = self.messagesCollectionView.indexPath(for: cell)\r\n}\r\n```\r\nIs this the only expected way to get the index?\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MessageKit/MessageKit/issues/comments/446075931","html_url":"https://github.com/MessageKit/MessageKit/issues/400#issuecomment-446075931","issue_url":"https://api.github.com/repos/MessageKit/MessageKit/issues/400","id":446075931,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjA3NTkzMQ==","user":{"login":"funct7","id":12147008,"node_id":"MDQ6VXNlcjEyMTQ3MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/12147008?v=4","gravatar_id":"","url":"https://api.github.com/users/funct7","html_url":"https://github.com/funct7","followers_url":"https://api.github.com/users/funct7/followers","following_url":"https://api.github.com/users/funct7/following{/other_user}","gists_url":"https://api.github.com/users/funct7/gists{/gist_id}","starred_url":"https://api.github.com/users/funct7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funct7/subscriptions","organizations_url":"https://api.github.com/users/funct7/orgs","repos_url":"https://api.github.com/users/funct7/repos","events_url":"https://api.github.com/users/funct7/events{/privacy}","received_events_url":"https://api.github.com/users/funct7/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T05:19:20Z","updated_at":"2018-12-11T05:19:20Z","author_association":"NONE","body":"@nathantannar4 I apologize for being rather harsh. On a tight schedule here, so I lost my patience. Still, not a good reason for being rude. I'm sorry for that.\r\n\r\nNevertheless, I still think you guys are making bad decisions.\r\n\r\n> we are not breaking the parent class behaviour\r\n\r\nIf this were true, `collectionView(_:didSelectItemsAt:)` would be called when selecting a cell, regardless of the cell type. I just checked out the code on `development.` **This is still not fixed.**\r\n\r\n> We are not disabling tap gesture, we are adding ones.\r\n\r\nThis is exactly what I mean. You guys add a tap gesture that's not necessary, while doing so, breaking the parent class behavior.\r\n\r\nFor me, \"breaking the parent class behavior\" means \"a class claims to be a subtype of some type, but doesn't work like the super type does.\" \"`MessagesCollectionView` claims to be a subtype of `UICollectionView` but doesn't work like the `UICollectionView` does.\"\r\n\r\nA `UICollectionView` subclass is supposed to call delegate methods when a cell is selected. I tap on `MessagesCollectionView`, nothing happens. The reason is the cell is not a subclass of `MessageCollectionViewCell`. The `UICollectionView` never stipulated that.\r\n\r\nIf you go back to my comments I say `people should not be punished for not using MessageContentCell.` If you can't see why that's a bad thing, I really have no hope here.\r\n\r\nSame goes for the input bar issue. `contentInset` is there for a reason. If you want to override it, you must override it in a way that supports all that `UICollectionView` supports. Otherwise, people have no idea why things don't work."}}
{"actor":{"display_login":"funct7"}}