{"action":"created","comment":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/comments/237372646","pull_request_review_id":179651746,"id":237372646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM3MjY0Ng==","diff_hunk":"@@ -311,45 +328,54 @@ public void report() throws InvalidSyntaxException {\n \n \t/**\n \t * Show the installed bundles\n+\t * \n+\t * @param out the output destination\n+\t * @throws IllegalArgumentException if specified argument is {@code null}\n \t */\n \tpublic void reportBundles(Appendable out) {\n+\t\tcheckNonNullArgument(out, \"Output destination instance cannot be null\");\n \t\ttry (Formatter f = new Formatter(out)) {\n \t\t\tStream.of(framework.getBundleContext()\n \t\t\t\t.getBundles())\n-\t\t\t\t.forEach(bb -> {\n-\t\t\t\t\tf.format(\"%4s %s\\n\", bundleStateToString(bb.getState()), bb);\n-\t\t\t\t});\n+\t\t\t\t.forEach(bb -> f.format(\"%4s %s%n\", bundleStateToString(bb.getState()), bb));\n \t\t}\n \t}\n \n \t/**\n \t * Show the registered service\n+\t * \n+\t * @param out the output destination\n+\t * @throws IllegalArgumentException if specified argument is {@code null}\n \t */\n \tpublic void reportServices(Appendable out) throws InvalidSyntaxException {\n+\t\tcheckNonNullArgument(out, \"Output destination instance cannot be null\");\n \t\ttry (Formatter f = new Formatter(out)) {\n \t\t\tStream.of(framework.getBundleContext()\n-\t\t\t\t.getAllServiceReferences(null, null))\n-\t\t\t\t.forEach(sref -> {\n-\t\t\t\t\tf.format(\"%s\\n\", sref);\n-\t\t\t\t});\n+\t\t\t\t.getServiceReferences((String) null, null))\n+\t\t\t\t.forEach(sref -> f.format(\"%s%n\", sref));\n \t\t\tf.flush();\n \t\t}\n \t}\n \n \t/**\n \t * Wait for a Service Reference to be registered\n \t * \n-\t * @param class1 the name of the service\n-\t * @param timeoutInMs the time to wait\n+\t * @param clazz the name of the service\n+\t * @param timeout the time to wait\n \t * @return a service reference\n \t * @throws InterruptedException\n+\t * @throws IllegalArgumentException if any of the specified arguments is\n+\t *             {@code null}\n \t */\n-\tpublic <T> Optional<ServiceReference<T>> waitForServiceReference(Class<T> class1, long timeoutInMs)\n+\tpublic <T> Optional<ServiceReference<T>> waitForServiceReference(Class<T> clazz, Duration timeout)","path":"biz.aQute.bnd.remote.junit/src/aQute/bnd/remote/junit/JUnitFramework.java","position":226,"original_position":226,"commit_id":"3cdbf2af88aa0ccac8df4935adf708bc3d4f30bc","original_commit_id":"3cdbf2af88aa0ccac8df4935adf708bc3d4f30bc","user":{"login":"amitjoy","id":13380182,"node_id":"MDQ6VXNlcjEzMzgwMTgy","avatar_url":"https://avatars0.githubusercontent.com/u/13380182?v=4","gravatar_id":"","url":"https://api.github.com/users/amitjoy","html_url":"https://github.com/amitjoy","followers_url":"https://api.github.com/users/amitjoy/followers","following_url":"https://api.github.com/users/amitjoy/following{/other_user}","gists_url":"https://api.github.com/users/amitjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjoy/subscriptions","organizations_url":"https://api.github.com/users/amitjoy/orgs","repos_url":"https://api.github.com/users/amitjoy/repos","events_url":"https://api.github.com/users/amitjoy/events{/privacy}","received_events_url":"https://api.github.com/users/amitjoy/received_events","type":"User","site_admin":false},"body":"From the provider perspective, I agree with you but from consumer perspective, it is more flexible to use duration in their code and pass it directly to the methods accepting `Duration` as argument. As a consumer, you have the flexibility to use any type of duration and don't have to consider about millis at all.","created_at":"2018-11-29T07:08:35Z","updated_at":"2018-11-29T07:08:35Z","html_url":"https://github.com/bndtools/bnd/pull/2754#discussion_r237372646","pull_request_url":"https://api.github.com/repos/bndtools/bnd/pulls/2754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments/237372646"},"html":{"href":"https://github.com/bndtools/bnd/pull/2754#discussion_r237372646"},"pull_request":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2754"}},"in_reply_to_id":237262674},"pull_request":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/2754","id":234099749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDk5NzQ5","html_url":"https://github.com/bndtools/bnd/pull/2754","diff_url":"https://github.com/bndtools/bnd/pull/2754.diff","patch_url":"https://github.com/bndtools/bnd/pull/2754.patch","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/2754","number":2754,"state":"open","locked":false,"title":"Added functionality to use Remote JUnit in older versions of OSGi","user":{"login":"amitjoy","id":13380182,"node_id":"MDQ6VXNlcjEzMzgwMTgy","avatar_url":"https://avatars0.githubusercontent.com/u/13380182?v=4","gravatar_id":"","url":"https://api.github.com/users/amitjoy","html_url":"https://github.com/amitjoy","followers_url":"https://api.github.com/users/amitjoy/followers","following_url":"https://api.github.com/users/amitjoy/following{/other_user}","gists_url":"https://api.github.com/users/amitjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjoy/subscriptions","organizations_url":"https://api.github.com/users/amitjoy/orgs","repos_url":"https://api.github.com/users/amitjoy/repos","events_url":"https://api.github.com/users/amitjoy/events{/privacy}","received_events_url":"https://api.github.com/users/amitjoy/received_events","type":"User","site_admin":false},"body":"1. Added Invariants\r\n2. Code Cleanup\r\n\r\nSigned-off-by: Amit Kumar Mondal <admin@amitinside.com>","created_at":"2018-11-27T23:41:04Z","updated_at":"2018-11-29T07:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5194f45f714e884456cf865449d40ddfc73f06c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bndtools/bnd/pulls/2754/commits","review_comments_url":"https://api.github.com/repos/bndtools/bnd/pulls/2754/comments","review_comment_url":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/2754/comments","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/3cdbf2af88aa0ccac8df4935adf708bc3d4f30bc","head":{"label":"amitjoy:fix/remote-junit-cleanups","ref":"fix/remote-junit-cleanups","sha":"3cdbf2af88aa0ccac8df4935adf708bc3d4f30bc","user":{"login":"amitjoy","id":13380182,"node_id":"MDQ6VXNlcjEzMzgwMTgy","avatar_url":"https://avatars0.githubusercontent.com/u/13380182?v=4","gravatar_id":"","url":"https://api.github.com/users/amitjoy","html_url":"https://github.com/amitjoy","followers_url":"https://api.github.com/users/amitjoy/followers","following_url":"https://api.github.com/users/amitjoy/following{/other_user}","gists_url":"https://api.github.com/users/amitjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjoy/subscriptions","organizations_url":"https://api.github.com/users/amitjoy/orgs","repos_url":"https://api.github.com/users/amitjoy/repos","events_url":"https://api.github.com/users/amitjoy/events{/privacy}","received_events_url":"https://api.github.com/users/amitjoy/received_events","type":"User","site_admin":false},"repo":{"id":144073361,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwNzMzNjE=","name":"bnd","full_name":"amitjoy/bnd","private":false,"owner":{"login":"amitjoy","id":13380182,"node_id":"MDQ6VXNlcjEzMzgwMTgy","avatar_url":"https://avatars0.githubusercontent.com/u/13380182?v=4","gravatar_id":"","url":"https://api.github.com/users/amitjoy","html_url":"https://github.com/amitjoy","followers_url":"https://api.github.com/users/amitjoy/followers","following_url":"https://api.github.com/users/amitjoy/following{/other_user}","gists_url":"https://api.github.com/users/amitjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjoy/subscriptions","organizations_url":"https://api.github.com/users/amitjoy/orgs","repos_url":"https://api.github.com/users/amitjoy/repos","events_url":"https://api.github.com/users/amitjoy/events{/privacy}","received_events_url":"https://api.github.com/users/amitjoy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amitjoy/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":true,"url":"https://api.github.com/repos/amitjoy/bnd","forks_url":"https://api.github.com/repos/amitjoy/bnd/forks","keys_url":"https://api.github.com/repos/amitjoy/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitjoy/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitjoy/bnd/teams","hooks_url":"https://api.github.com/repos/amitjoy/bnd/hooks","issue_events_url":"https://api.github.com/repos/amitjoy/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/amitjoy/bnd/events","assignees_url":"https://api.github.com/repos/amitjoy/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/amitjoy/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/amitjoy/bnd/tags","blobs_url":"https://api.github.com/repos/amitjoy/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitjoy/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitjoy/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitjoy/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitjoy/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/amitjoy/bnd/languages","stargazers_url":"https://api.github.com/repos/amitjoy/bnd/stargazers","contributors_url":"https://api.github.com/repos/amitjoy/bnd/contributors","subscribers_url":"https://api.github.com/repos/amitjoy/bnd/subscribers","subscription_url":"https://api.github.com/repos/amitjoy/bnd/subscription","commits_url":"https://api.github.com/repos/amitjoy/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitjoy/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitjoy/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitjoy/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitjoy/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/amitjoy/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitjoy/bnd/merges","archive_url":"https://api.github.com/repos/amitjoy/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitjoy/bnd/downloads","issues_url":"https://api.github.com/repos/amitjoy/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/amitjoy/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/amitjoy/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/amitjoy/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitjoy/bnd/labels{/name}","releases_url":"https://api.github.com/repos/amitjoy/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/amitjoy/bnd/deployments","created_at":"2018-08-08T22:17:18Z","updated_at":"2018-11-27T19:17:15Z","pushed_at":"2018-11-28T09:59:27Z","git_url":"git://github.com/amitjoy/bnd.git","ssh_url":"git@github.com:amitjoy/bnd.git","clone_url":"https://github.com/amitjoy/bnd.git","svn_url":"https://github.com/amitjoy/bnd","homepage":"https://bnd.bndtools.org","size":312031,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"82822deee69453df66bd68f67f9cbf431e33e76f","user":{"login":"bndtools","id":1130828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzA4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":606956,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY5NTY=","name":"bnd","full_name":"bndtools/bnd","private":false,"owner":{"login":"bndtools","id":1130828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzA4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bndtools/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":false,"url":"https://api.github.com/repos/bndtools/bnd","forks_url":"https://api.github.com/repos/bndtools/bnd/forks","keys_url":"https://api.github.com/repos/bndtools/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bnd/teams","hooks_url":"https://api.github.com/repos/bndtools/bnd/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bnd/events","assignees_url":"https://api.github.com/repos/bndtools/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bnd/tags","blobs_url":"https://api.github.com/repos/bndtools/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bnd/languages","stargazers_url":"https://api.github.com/repos/bndtools/bnd/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bnd/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bnd/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bnd/subscription","commits_url":"https://api.github.com/repos/bndtools/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bndtools/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bnd/merges","archive_url":"https://api.github.com/repos/bndtools/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bnd/downloads","issues_url":"https://api.github.com/repos/bndtools/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bnd/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/bndtools/bnd/deployments","created_at":"2010-04-12T17:30:15Z","updated_at":"2018-11-28T21:16:42Z","pushed_at":"2018-11-29T01:30:55Z","git_url":"git://github.com/bndtools/bnd.git","ssh_url":"git@github.com:bndtools/bnd.git","clone_url":"https://github.com/bndtools/bnd.git","svn_url":"https://github.com/bndtools/bnd","homepage":"https://bnd.bndtools.org","size":312034,"stargazers_count":327,"watchers_count":327,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":213,"open_issues":89,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2754"},"html":{"href":"https://github.com/bndtools/bnd/pull/2754"},"issue":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2754"},"comments":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2754/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2754/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2754/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bnd/statuses/3cdbf2af88aa0ccac8df4935adf708bc3d4f30bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amitjoy"}}