{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/196900385","pull_request_review_id":130537987,"id":196900385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkwMDM4NQ==","diff_hunk":"@@ -202,53 +206,59 @@ func (task *Task) PostUnmarshalTask(cfg *config.Config,\n \t\t\treturn apierrors.NewResourceInitError(task.Arn, err)\n \t\t}\n \t}\n-\ttask.initializeEmptyVolumes()\n+\terr := task.initializeDockerLocalVolumes(dockerClient, ctx)\n+\tif err != nil {\n+\t\treturn apierrors.NewResourceInitError(task.Arn, err)\n+\t}\n \ttask.initializeCredentialsEndpoint(credentialsManager)\n \ttask.addNetworkResourceProvisioningDependency(cfg)\n \treturn nil\n }\n \n-func (task *Task) initializeEmptyVolumes() {\n-\trequiredEmptyVolumes := []string{}\n+func (task *Task) initializeDockerLocalVolumes(dockerClient dockerapi.DockerClient, ctx context.Context) error {\n+\trequiredLocalVolumes := []string{}","path":"agent/api/task/task.go","position":63,"original_position":63,"commit_id":"f7fcb16ff86b3113e0e5c6b94511a9477820ad9a","original_commit_id":"f7fcb16ff86b3113e0e5c6b94511a9477820ad9a","user":{"login":"aaithal","id":1183359,"node_id":"MDQ6VXNlcjExODMzNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1183359?v=4","gravatar_id":"","url":"https://api.github.com/users/aaithal","html_url":"https://github.com/aaithal","followers_url":"https://api.github.com/users/aaithal/followers","following_url":"https://api.github.com/users/aaithal/following{/other_user}","gists_url":"https://api.github.com/users/aaithal/gists{/gist_id}","starred_url":"https://api.github.com/users/aaithal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaithal/subscriptions","organizations_url":"https://api.github.com/users/aaithal/orgs","repos_url":"https://api.github.com/users/aaithal/repos","events_url":"https://api.github.com/users/aaithal/events{/privacy}","received_events_url":"https://api.github.com/users/aaithal/received_events","type":"User","site_admin":false},"body":"nit: `var requiredLocalVolumes []string` is the idiomatic way of doing this i think","created_at":"2018-06-20T18:39:00Z","updated_at":"2018-06-20T18:44:54Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1406#discussion_r196900385","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/196900385"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1406#discussion_r196900385"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406","id":192786149,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzg2MTQ5","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1406","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1406.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1406.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1406","number":1406,"state":"open","locked":false,"title":"Replace the empty container with a local volume","user":{"login":"richardpen","id":17835576,"node_id":"MDQ6VXNlcjE3ODM1NTc2","avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\n<!-- What does this pull request do? -->\r\n\r\n### Implementation details\r\n<!-- How are the changes implemented? -->\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [x] Builds on Linux (`make release`)\r\n- [x] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [x] Unit tests on Linux (`make test`) pass\r\n- [x] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [x] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [x] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [x] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [x] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\nyes\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-06-05T17:45:54Z","updated_at":"2018-06-20T18:44:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b33a959fb5494690f2efd9ee14826e171089a4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones/25","html_url":"https://github.com/aws/amazon-ecs-agent/milestone/25","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones/25/labels","id":3334643,"node_id":"MDk6TWlsZXN0b25lMzMzNDY0Mw==","number":25,"title":"1.19.0","description":null,"creator":{"login":"sharanyad","id":14119911,"node_id":"MDQ6VXNlcjE0MTE5OTEx","avatar_url":"https://avatars1.githubusercontent.com/u/14119911?v=4","gravatar_id":"","url":"https://api.github.com/users/sharanyad","html_url":"https://github.com/sharanyad","followers_url":"https://api.github.com/users/sharanyad/followers","following_url":"https://api.github.com/users/sharanyad/following{/other_user}","gists_url":"https://api.github.com/users/sharanyad/gists{/gist_id}","starred_url":"https://api.github.com/users/sharanyad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharanyad/subscriptions","organizations_url":"https://api.github.com/users/sharanyad/orgs","repos_url":"https://api.github.com/users/sharanyad/repos","events_url":"https://api.github.com/users/sharanyad/events{/privacy}","received_events_url":"https://api.github.com/users/sharanyad/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":19,"state":"open","created_at":"2018-05-09T22:52:24Z","updated_at":"2018-06-13T18:58:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1406/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/f7fcb16ff86b3113e0e5c6b94511a9477820ad9a","head":{"label":"richardpen:taskresource-y","ref":"taskresource-y","sha":"f7fcb16ff86b3113e0e5c6b94511a9477820ad9a","user":{"login":"richardpen","id":17835576,"node_id":"MDQ6VXNlcjE3ODM1NTc2","avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"repo":{"id":55100421,"node_id":"MDEwOlJlcG9zaXRvcnk1NTEwMDQyMQ==","name":"amazon-ecs-agent","full_name":"richardpen/amazon-ecs-agent","owner":{"login":"richardpen","id":17835576,"node_id":"MDQ6VXNlcjE3ODM1NTc2","avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardpen/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/richardpen/amazon-ecs-agent","forks_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/deployments","created_at":"2016-03-30T21:52:59Z","updated_at":"2018-04-06T18:50:36Z","pushed_at":"2018-06-19T17:08:51Z","git_url":"git://github.com/richardpen/amazon-ecs-agent.git","ssh_url":"git@github.com:richardpen/amazon-ecs-agent.git","clone_url":"https://github.com/richardpen/amazon-ecs-agent.git","svn_url":"https://github.com/richardpen/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":30797,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"8dae73394282df16570d41c067fa364652db4e31","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"node_id":"MDEwOlJlcG9zaXRvcnkyNzU1MTc3NA==","name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon Elastic Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2018-06-20T17:32:28Z","pushed_at":"2018-06-19T18:30:01Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":30597,"stargazers_count":1247,"watchers_count":1247,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":331,"open_issues":115,"watchers":1247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1406"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1406"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1406/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1406/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/f7fcb16ff86b3113e0e5c6b94511a9477820ad9a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aaithal"}}