{"action":"created","issue":{"url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/4","repository_url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker","labels_url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/4/comments","events_url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/4/events","html_url":"https://github.com/simonkeng/rdkit-jupyter-docker/pull/4","id":367419618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODYyMzM2","number":4,"title":"Changes for jupyter/notebook 5.7.0","user":{"login":"Deric4","id":5762138,"node_id":"MDQ6VXNlcjU3NjIxMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5762138?v=4","gravatar_id":"","url":"https://api.github.com/users/Deric4","html_url":"https://github.com/Deric4","followers_url":"https://api.github.com/users/Deric4/followers","following_url":"https://api.github.com/users/Deric4/following{/other_user}","gists_url":"https://api.github.com/users/Deric4/gists{/gist_id}","starred_url":"https://api.github.com/users/Deric4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deric4/subscriptions","organizations_url":"https://api.github.com/users/Deric4/orgs","repos_url":"https://api.github.com/users/Deric4/repos","events_url":"https://api.github.com/users/Deric4/events{/privacy}","received_events_url":"https://api.github.com/users/Deric4/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-06T03:38:59Z","updated_at":"2018-10-06T20:37:16Z","closed_at":"2018-10-06T20:19:25Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/pulls/4","html_url":"https://github.com/simonkeng/rdkit-jupyter-docker/pull/4","diff_url":"https://github.com/simonkeng/rdkit-jupyter-docker/pull/4.diff","patch_url":"https://github.com/simonkeng/rdkit-jupyter-docker/pull/4.patch"},"body":"There's a breaking change jupyter/notebooks which only affects users pulling/building a new image introduced in:\r\n\r\n```bash\r\n$ jupyter notebook --version\r\n5.7.0\r\n```\r\n\r\nchange the *ip* option to the `jupyter notebook` command because of\r\nerror at image build time.\r\n\r\nFixes: Issue #3\r\n\r\nReference: jupyter/notebook#3946\r\nThis basically is broken in "},"comment":{"url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/comments/427604456","html_url":"https://github.com/simonkeng/rdkit-jupyter-docker/pull/4#issuecomment-427604456","issue_url":"https://api.github.com/repos/simonkeng/rdkit-jupyter-docker/issues/4","id":427604456,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzYwNDQ1Ng==","user":{"login":"simonkeng","id":17607183,"node_id":"MDQ6VXNlcjE3NjA3MTgz","avatar_url":"https://avatars3.githubusercontent.com/u/17607183?v=4","gravatar_id":"","url":"https://api.github.com/users/simonkeng","html_url":"https://github.com/simonkeng","followers_url":"https://api.github.com/users/simonkeng/followers","following_url":"https://api.github.com/users/simonkeng/following{/other_user}","gists_url":"https://api.github.com/users/simonkeng/gists{/gist_id}","starred_url":"https://api.github.com/users/simonkeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonkeng/subscriptions","organizations_url":"https://api.github.com/users/simonkeng/orgs","repos_url":"https://api.github.com/users/simonkeng/repos","events_url":"https://api.github.com/users/simonkeng/events{/privacy}","received_events_url":"https://api.github.com/users/simonkeng/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T20:37:16Z","updated_at":"2018-10-06T20:37:16Z","author_association":"OWNER","body":"> @simonkeng you may also want to update the docker-compose file in that other repo: https://github.com/rdkit/rdkit_containers/blob/e1a8f7dd8cee6f59731bf107998d8b079596fa64/docker/run_conda3/docker-compose.yml#L5\r\n> \r\n> The image name in docker-compose.yml doesn't match the name of the image used in the readme.\r\n\r\nIt looks like in the readme we are building the image and naming it `run_rdkit_conda` but the docker-compose file is pointing to this repo (`simonkeng/rdkit-jupyter-docker`). Is this what you were referring to @Deric4? I don't think so actually lol, sorry. \r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"simonkeng"}}