{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments/233234291","pull_request_review_id":174602705,"id":233234291,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIzNDI5MQ==","diff_hunk":"@@ -73,14 +73,20 @@ func (c *CacheReader) Get(_ context.Context, key client.ObjectKey, out runtime.O\n \t// TODO(directxman12): revisit the decision to always deepcopy\n \tobj = obj.(runtime.Object).DeepCopyObject()\n \n-\t// Copy the value of the item in the cache to the returned value\n-\t// TODO(directxman12): this is a terrible hack, pls fix (we should have deepcopyinto)\n-\toutVal := reflect.ValueOf(out)\n-\tobjVal := reflect.ValueOf(obj)\n-\tif !objVal.Type().AssignableTo(outVal.Type()) {\n-\t\treturn fmt.Errorf(\"cache had type %s, but %s was asked for\", objVal.Type(), outVal.Type())\n+\toType := reflect.TypeOf(obj)","path":"pkg/cache/internal/cache_reader.go","position":10,"original_position":10,"commit_id":"4c4492971dede4a9578289abc34c19c843906bf9","original_commit_id":"4c4492971dede4a9578289abc34c19c843906bf9","user":{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"Is there not an interface for `DeepCopyInto`?","created_at":"2018-11-13T21:47:18Z","updated_at":"2018-11-13T21:47:18Z","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/203#discussion_r233234291","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments/233234291"},"html":{"href":"https://github.com/kubernetes-sigs/controller-runtime/pull/203#discussion_r233234291"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203"}},"in_reply_to_id":232324633},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203","id":229723449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzIzNDQ5","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/203","diff_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/203.diff","patch_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/203.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/203","number":203,"state":"open","locked":false,"title":"Set GVK when getting the object from the cache.","user":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"body":"* Fixing up a TODO around DeepCopyInto\r\n\r\nfixes #202 ","created_at":"2018-11-09T15:11:20Z","updated_at":"2018-11-13T21:47:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cb766a3a612f941250a4a6e4a05c3b26a50716d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},{"login":"droot","id":172029,"node_id":"MDQ6VXNlcjE3MjAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":957854387,"node_id":"MDU6TGFiZWw5NTc4NTQzODc=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":957926585,"node_id":"MDU6TGFiZWw5NTc5MjY1ODU=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/203/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/4c4492971dede4a9578289abc34c19c843906bf9","head":{"label":"shawn-hurley:issue/202","ref":"issue/202","sha":"4c4492971dede4a9578289abc34c19c843906bf9","user":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"repo":{"id":143052281,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNTIyODE=","name":"controller-runtime","full_name":"shawn-hurley/controller-runtime","private":false,"owner":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shawn-hurley/controller-runtime","description":"Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)","fork":true,"url":"https://api.github.com/repos/shawn-hurley/controller-runtime","forks_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/forks","keys_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/teams","hooks_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/hooks","issue_events_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/events","assignees_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/tags","blobs_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/languages","stargazers_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/stargazers","contributors_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/contributors","subscribers_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/subscribers","subscription_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/subscription","commits_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/merges","archive_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/downloads","issues_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/labels{/name}","releases_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/shawn-hurley/controller-runtime/deployments","created_at":"2018-07-31T18:28:41Z","updated_at":"2018-07-31T18:28:44Z","pushed_at":"2018-11-09T15:10:36Z","git_url":"git://github.com/shawn-hurley/controller-runtime.git","ssh_url":"git@github.com:shawn-hurley/controller-runtime.git","clone_url":"https://github.com/shawn-hurley/controller-runtime.git","svn_url":"https://github.com/shawn-hurley/controller-runtime","homepage":null,"size":32342,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"81f67a05853ea208098ffb64ad2862a8892771ba","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":136494223,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0OTQyMjM=","name":"controller-runtime","full_name":"kubernetes-sigs/controller-runtime","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/controller-runtime","description":"Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime","forks_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/deployments","created_at":"2018-06-07T15:08:03Z","updated_at":"2018-11-13T04:04:27Z","pushed_at":"2018-11-13T04:04:24Z","git_url":"git://github.com/kubernetes-sigs/controller-runtime.git","ssh_url":"git@github.com:kubernetes-sigs/controller-runtime.git","clone_url":"https://github.com/kubernetes-sigs/controller-runtime.git","svn_url":"https://github.com/kubernetes-sigs/controller-runtime","homepage":null,"size":32375,"stargazers_count":53,"watchers_count":53,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":43,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203"},"html":{"href":"https://github.com/kubernetes-sigs/controller-runtime/pull/203"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/203"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/statuses/4c4492971dede4a9578289abc34c19c843906bf9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DirectXMan12"}}