{"action":"created","issue":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1694","repository_url":"https://api.github.com/repos/AvaloniaUI/Avalonia","labels_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1694/labels{/name}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1694/comments","events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1694/events","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/1694","id":335296210,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDI4ODIw","number":1694,"title":"Don't use rx for ExpressionNodes.","user":{"login":"grokys","id":1775141,"node_id":"MDQ6VXNlcjE3NzUxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-25T07:52:01Z","updated_at":"2018-06-25T17:31:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1694","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/1694","diff_url":"https://github.com/AvaloniaUI/Avalonia/pull/1694.diff","patch_url":"https://github.com/AvaloniaUI/Avalonia/pull/1694.patch"},"body":"Following on from #1690, another PR to reduce memory allocations. This makes `ExpressionNode`s no longer `ISubject<>`s and instead transitions them to using an explicit `Subscribe`/`Unsubscribe` model.\r\n\r\n`ExpressionNode`s were always single-subscriber and making them use `IObservable<>` meant that we had to have extra allocations in order to return `IDisposable`s. \r\n\r\nThis saves a bunch more memory.\r\n\r\n## Memory Usage\r\n\r\nMemory usage was measured via the VS2017 diagnostic tools by running ControlCatalog in Release mode, opening all pages and then taking a memory snapshot:\r\n\r\nOn master (after #1690):\r\n\r\n|Objects|Heap Size (KB)|\r\n|-----|------|\r\n|1,478,158|79,936|\r\n\r\nThis PR:\r\n\r\n|Objects|Heap Size (KB)|\r\n|-----|------|\r\n|1,381,936|76,310|\r\n"},"comment":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/comments/400032523","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/1694#issuecomment-400032523","issue_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1694","id":400032523,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDAzMjUyMw==","user":{"login":"wieslawsoltes","id":2297442,"node_id":"MDQ6VXNlcjIyOTc0NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2297442?v=4","gravatar_id":"","url":"https://api.github.com/users/wieslawsoltes","html_url":"https://github.com/wieslawsoltes","followers_url":"https://api.github.com/users/wieslawsoltes/followers","following_url":"https://api.github.com/users/wieslawsoltes/following{/other_user}","gists_url":"https://api.github.com/users/wieslawsoltes/gists{/gist_id}","starred_url":"https://api.github.com/users/wieslawsoltes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wieslawsoltes/subscriptions","organizations_url":"https://api.github.com/users/wieslawsoltes/orgs","repos_url":"https://api.github.com/users/wieslawsoltes/repos","events_url":"https://api.github.com/users/wieslawsoltes/events{/privacy}","received_events_url":"https://api.github.com/users/wieslawsoltes/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T17:31:25Z","updated_at":"2018-06-25T17:31:25Z","author_association":"CONTRIBUTOR","body":"Before:\r\n![build5521](https://user-images.githubusercontent.com/2297442/41865748-4efcbc5a-78ae-11e8-9f07-7673248443c9.png)\r\nAfter:\r\n![build5528](https://user-images.githubusercontent.com/2297442/41865754-52860df4-78ae-11e8-8f76-ce9046b8064f.png)\r\n"}}
{"actor":{"display_login":"wieslawsoltes"}}