{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/165580388","pull_request_review_id":93544426,"id":165580388,"diff_hunk":"@@ -634,9 +634,11 @@ extern (C++) final class Module : Package\n         {\n             if (!strcmp(srcfile.toChars(), \"object.d\"))\n             {\n-                .error(loc, \"cannot find source code for runtime library file 'object.d'\");\n-                errorSupplemental(loc, \"dmd might not be correctly installed. Run 'dmd -man' for installation instructions.\");\n-                errorSupplemental(loc, \"config file: %s\", FileName.canonicalName(global.inifilename));\n+                // object.d is automatically imported.  If object.d doesn't exist, it's not necessarily an error.\n+                // For example, the user could be creating a library in D that is intened to be called from\n+                // another language and, therefore, does not wish to use features of the D runtime.  We\n+                // return `false` here and rely on future semantic processing to catch any errors.\n+                return false;","path":"src/dmd/dmodule.d","position":11,"original_position":11,"commit_id":"c8ab10831f8dbd7157706f50d401573fcdfb15b9","original_commit_id":"c8ab10831f8dbd7157706f50d401573fcdfb15b9","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars3.githubusercontent.com/u/702284?v=4","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"body":"I suspect this will make bad installations less obvious, especially to newcomers, that don't know anything about what's to be expected in object.d.\r\n\r\nAlso, in combination with optional TypeInfo, ModuleInfo and Throwable, this might silently and advertently build unexpected code due to missing import paths.\r\n\r\nIf someone is actually starting the adventure of porting to another platform, adding a switch or even creating an empty object.d should not be that much of an issue.","created_at":"2018-02-02T08:15:10Z","updated_at":"2018-02-02T08:15:10Z","html_url":"https://github.com/dlang/dmd/pull/7825#discussion_r165580388","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/7825","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/165580388"},"html":{"href":"https://github.com/dlang/dmd/pull/7825#discussion_r165580388"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7825"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7825","id":166589412,"html_url":"https://github.com/dlang/dmd/pull/7825","diff_url":"https://github.com/dlang/dmd/pull/7825.diff","patch_url":"https://github.com/dlang/dmd/pull/7825.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7825","number":7825,"state":"open","locked":false,"title":"Don't require object.d for -lib if code does not utilize runtime features","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"body":"This is a followup to the following PRs\r\n\r\n * #7395 and #7768 for `ModuleInfo`\r\n * #7786 for `Throwable`\r\n * #7799 for `TypeInfo`\r\n\r\nCurrently, if one wants to create a library in D, that doesn't utilize any runtime features, and use said library from another language, they will need to create an empty `object.d` file to get a build.  \r\n\r\nThis PR removes that limitation, so users will only need the .d source files relevant to their library to get a build.\r\n","created_at":"2018-02-01T16:39:45Z","updated_at":"2018-02-02T08:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff31848b7a31e41a0ec35826aee38cae74249e40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/7825/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/7825/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7825/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/c8ab10831f8dbd7157706f50d401573fcdfb15b9","head":{"label":"JinShil:no_object_d","ref":"no_object_d","sha":"c8ab10831f8dbd7157706f50d401573fcdfb15b9","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"repo":{"id":100016446,"name":"dmd","full_name":"JinShil/dmd","owner":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JinShil/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/JinShil/dmd","forks_url":"https://api.github.com/repos/JinShil/dmd/forks","keys_url":"https://api.github.com/repos/JinShil/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JinShil/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JinShil/dmd/teams","hooks_url":"https://api.github.com/repos/JinShil/dmd/hooks","issue_events_url":"https://api.github.com/repos/JinShil/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/JinShil/dmd/events","assignees_url":"https://api.github.com/repos/JinShil/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/JinShil/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/JinShil/dmd/tags","blobs_url":"https://api.github.com/repos/JinShil/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JinShil/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JinShil/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/JinShil/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JinShil/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/JinShil/dmd/languages","stargazers_url":"https://api.github.com/repos/JinShil/dmd/stargazers","contributors_url":"https://api.github.com/repos/JinShil/dmd/contributors","subscribers_url":"https://api.github.com/repos/JinShil/dmd/subscribers","subscription_url":"https://api.github.com/repos/JinShil/dmd/subscription","commits_url":"https://api.github.com/repos/JinShil/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/JinShil/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/JinShil/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/JinShil/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/JinShil/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/JinShil/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JinShil/dmd/merges","archive_url":"https://api.github.com/repos/JinShil/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JinShil/dmd/downloads","issues_url":"https://api.github.com/repos/JinShil/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/JinShil/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/JinShil/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/JinShil/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JinShil/dmd/labels{/name}","releases_url":"https://api.github.com/repos/JinShil/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/JinShil/dmd/deployments","created_at":"2017-08-11T09:36:15Z","updated_at":"2017-08-11T09:36:23Z","pushed_at":"2018-02-02T05:35:52Z","git_url":"git://github.com/JinShil/dmd.git","ssh_url":"git@github.com:JinShil/dmd.git","clone_url":"https://github.com/JinShil/dmd.git","svn_url":"https://github.com/JinShil/dmd","homepage":"dlang.org","size":84322,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"c7052642009da16b2b3e81ed850a125bc2b74a7d","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-02-01T14:57:46Z","pushed_at":"2018-02-02T07:54:27Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":85070,"stargazers_count":1739,"watchers_count":1739,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":436,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":436,"open_issues":137,"watchers":1739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7825"},"html":{"href":"https://github.com/dlang/dmd/pull/7825"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/7825"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/7825/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7825/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7825/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/c8ab10831f8dbd7157706f50d401573fcdfb15b9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rainers"}}