{"action":"created","comment":{"url":"https://api.github.com/repos/callstack/haul/pulls/comments/173740655","pull_request_review_id":102977199,"id":173740655,"diff_hunk":"@@ -57,14 +34,48 @@ function testPlatform(platform, done) {\n \n     if (message.match(/ERROR/g)) {\n       done.fail(message);\n-      haul.kill();\n     }\n \n-    if (message.match('bundling your React Native app')) {\n-      const stdout = messageBuffer.join('\\n');\n-      expect(stdout).toMatch('INFO  Ready at http://localhost:8081');\n+    if (message.match('running')) {\n       done();\n-      haul.kill();\n     }\n   });\n+});\n+beforeEach(() => cleanup(TEMP_DIR));\n+afterEach(() => cleanup(TEMP_DIR));\n+afterAll(() => {\n+  haul.kill();\n+});\n+\n+test('starts server and bundling iOS platform', done => {\n+  testPlatform('ios', done);\n+});\n+\n+test('starts server and bundling Android platform', done => {\n+  testPlatform('android', done);\n+});\n+\n+test('starts server and bundling all platforms', done => {\n+  let calledTimes = 0;\n+  function _done() {\n+    calledTimes++;\n+    if (calledTimes === 2) {\n+      done();\n+    }\n+  }\n+  _done.fail = done.fail;\n+\n+  testPlatform('ios', _done);\n+  testPlatform('android', _done);\n+});\n+\n+async function testPlatform(platform, done) {","path":"integration_tests/__tests__/start.test.js","position":99,"original_position":99,"commit_id":"ce57f2320d7beaa8cd925a109177bd641ed100c6","original_commit_id":"cc86caad9e13037186af9031da28cff61dc29993","user":{"login":"thymikee","id":5106466,"avatar_url":"https://avatars2.githubusercontent.com/u/5106466?v=4","gravatar_id":"","url":"https://api.github.com/users/thymikee","html_url":"https://github.com/thymikee","followers_url":"https://api.github.com/users/thymikee/followers","following_url":"https://api.github.com/users/thymikee/following{/other_user}","gists_url":"https://api.github.com/users/thymikee/gists{/gist_id}","starred_url":"https://api.github.com/users/thymikee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thymikee/subscriptions","organizations_url":"https://api.github.com/users/thymikee/orgs","repos_url":"https://api.github.com/users/thymikee/repos","events_url":"https://api.github.com/users/thymikee/events{/privacy}","received_events_url":"https://api.github.com/users/thymikee/received_events","type":"User","site_admin":false},"body":"@zamotany obviously, looks like I missed that 🤦‍♂️ ","created_at":"2018-03-12T09:56:46Z","updated_at":"2018-03-12T09:56:46Z","html_url":"https://github.com/callstack/haul/pull/339#discussion_r173740655","pull_request_url":"https://api.github.com/repos/callstack/haul/pulls/339","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/callstack/haul/pulls/comments/173740655"},"html":{"href":"https://github.com/callstack/haul/pull/339#discussion_r173740655"},"pull_request":{"href":"https://api.github.com/repos/callstack/haul/pulls/339"}},"in_reply_to_id":173660422},"pull_request":{"url":"https://api.github.com/repos/callstack/haul/pulls/339","id":164235305,"html_url":"https://github.com/callstack/haul/pull/339","diff_url":"https://github.com/callstack/haul/pull/339.diff","patch_url":"https://github.com/callstack/haul/pull/339.patch","issue_url":"https://api.github.com/repos/callstack/haul/issues/339","number":339,"state":"open","locked":false,"title":"Node worker usage","user":{"login":"Krizzu","id":6444719,"avatar_url":"https://avatars2.githubusercontent.com/u/6444719?v=4","gravatar_id":"","url":"https://api.github.com/users/Krizzu","html_url":"https://github.com/Krizzu","followers_url":"https://api.github.com/users/Krizzu/followers","following_url":"https://api.github.com/users/Krizzu/following{/other_user}","gists_url":"https://api.github.com/users/Krizzu/gists{/gist_id}","starred_url":"https://api.github.com/users/Krizzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krizzu/subscriptions","organizations_url":"https://api.github.com/users/Krizzu/orgs","repos_url":"https://api.github.com/users/Krizzu/repos","events_url":"https://api.github.com/users/Krizzu/events{/privacy}","received_events_url":"https://api.github.com/users/Krizzu/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [x] tests are passing\r\n- [x] `bundle` command is working\r\n- [x] HMR is working\r\n- [x] symbolicate is working\r\n- [x] workers are not clogging system when something unexpected happens\r\n- [x] redirect progress events from forks to parent process\r\n- [x] document what the heck is going on there\r\n- [x] fix crazy things happening with 2 compilations and express logging","created_at":"2018-01-22T07:01:18Z","updated_at":"2018-03-12T09:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d2f476bd894d833d6d4db0f9af8776db92da67f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/callstack/haul/pulls/339/commits","review_comments_url":"https://api.github.com/repos/callstack/haul/pulls/339/comments","review_comment_url":"https://api.github.com/repos/callstack/haul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callstack/haul/issues/339/comments","statuses_url":"https://api.github.com/repos/callstack/haul/statuses/ce57f2320d7beaa8cd925a109177bd641ed100c6","head":{"label":"callstack:krizzu/webpack_node_workers","ref":"krizzu/webpack_node_workers","sha":"ce57f2320d7beaa8cd925a109177bd641ed100c6","user":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":85622333,"name":"haul","full_name":"callstack/haul","owner":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack/haul","description":"Haul is a command line tool for developing React Native apps","fork":false,"url":"https://api.github.com/repos/callstack/haul","forks_url":"https://api.github.com/repos/callstack/haul/forks","keys_url":"https://api.github.com/repos/callstack/haul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/haul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/haul/teams","hooks_url":"https://api.github.com/repos/callstack/haul/hooks","issue_events_url":"https://api.github.com/repos/callstack/haul/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/haul/events","assignees_url":"https://api.github.com/repos/callstack/haul/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/haul/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/haul/tags","blobs_url":"https://api.github.com/repos/callstack/haul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/haul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/haul/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/haul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/haul/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/haul/languages","stargazers_url":"https://api.github.com/repos/callstack/haul/stargazers","contributors_url":"https://api.github.com/repos/callstack/haul/contributors","subscribers_url":"https://api.github.com/repos/callstack/haul/subscribers","subscription_url":"https://api.github.com/repos/callstack/haul/subscription","commits_url":"https://api.github.com/repos/callstack/haul/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/haul/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/haul/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/haul/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/haul/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/haul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/haul/merges","archive_url":"https://api.github.com/repos/callstack/haul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/haul/downloads","issues_url":"https://api.github.com/repos/callstack/haul/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/haul/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/haul/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/haul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/haul/labels{/name}","releases_url":"https://api.github.com/repos/callstack/haul/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/haul/deployments","created_at":"2017-03-20T20:23:31Z","updated_at":"2018-03-12T06:51:38Z","pushed_at":"2018-03-11T18:15:20Z","git_url":"git://github.com/callstack/haul.git","ssh_url":"git@github.com:callstack/haul.git","clone_url":"https://github.com/callstack/haul.git","svn_url":"https://github.com/callstack/haul","homepage":"","size":1402,"stargazers_count":2215,"watchers_count":2215,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":105,"open_issues":50,"watchers":2215,"default_branch":"master"}},"base":{"label":"callstack:master","ref":"master","sha":"6e6444b523ff90392a80b53785fac5c48e71cad3","user":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":85622333,"name":"haul","full_name":"callstack/haul","owner":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack/haul","description":"Haul is a command line tool for developing React Native apps","fork":false,"url":"https://api.github.com/repos/callstack/haul","forks_url":"https://api.github.com/repos/callstack/haul/forks","keys_url":"https://api.github.com/repos/callstack/haul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/haul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/haul/teams","hooks_url":"https://api.github.com/repos/callstack/haul/hooks","issue_events_url":"https://api.github.com/repos/callstack/haul/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/haul/events","assignees_url":"https://api.github.com/repos/callstack/haul/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/haul/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/haul/tags","blobs_url":"https://api.github.com/repos/callstack/haul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/haul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/haul/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/haul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/haul/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/haul/languages","stargazers_url":"https://api.github.com/repos/callstack/haul/stargazers","contributors_url":"https://api.github.com/repos/callstack/haul/contributors","subscribers_url":"https://api.github.com/repos/callstack/haul/subscribers","subscription_url":"https://api.github.com/repos/callstack/haul/subscription","commits_url":"https://api.github.com/repos/callstack/haul/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/haul/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/haul/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/haul/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/haul/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/haul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/haul/merges","archive_url":"https://api.github.com/repos/callstack/haul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/haul/downloads","issues_url":"https://api.github.com/repos/callstack/haul/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/haul/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/haul/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/haul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/haul/labels{/name}","releases_url":"https://api.github.com/repos/callstack/haul/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/haul/deployments","created_at":"2017-03-20T20:23:31Z","updated_at":"2018-03-12T06:51:38Z","pushed_at":"2018-03-11T18:15:20Z","git_url":"git://github.com/callstack/haul.git","ssh_url":"git@github.com:callstack/haul.git","clone_url":"https://github.com/callstack/haul.git","svn_url":"https://github.com/callstack/haul","homepage":"","size":1402,"stargazers_count":2215,"watchers_count":2215,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":105,"open_issues":50,"watchers":2215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callstack/haul/pulls/339"},"html":{"href":"https://github.com/callstack/haul/pull/339"},"issue":{"href":"https://api.github.com/repos/callstack/haul/issues/339"},"comments":{"href":"https://api.github.com/repos/callstack/haul/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/callstack/haul/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/callstack/haul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callstack/haul/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/callstack/haul/statuses/ce57f2320d7beaa8cd925a109177bd641ed100c6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thymikee"}}