{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/230825036","pull_request_review_id":171650136,"id":230825036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgyNTAzNg==","diff_hunk":"@@ -248,3 +248,47 @@ def generate_ip_address(source_ip:, network_cidr:)\n \n   (host_network | host_id).to_s\n end\n+\n+# take an IPAddress cidr object and break it up into /24 chunks","path":"chef/cookbooks/bcpc/libraries/utils.rb","position":5,"original_position":5,"commit_id":"6152d7edc4c19d9c767aa18af696530352e0e65f","original_commit_id":"6152d7edc4c19d9c767aa18af696530352e0e65f","user":{"login":"justinjpacheco","id":146161,"node_id":"MDQ6VXNlcjE0NjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/146161?v=4","gravatar_id":"","url":"https://api.github.com/users/justinjpacheco","html_url":"https://github.com/justinjpacheco","followers_url":"https://api.github.com/users/justinjpacheco/followers","following_url":"https://api.github.com/users/justinjpacheco/following{/other_user}","gists_url":"https://api.github.com/users/justinjpacheco/gists{/gist_id}","starred_url":"https://api.github.com/users/justinjpacheco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinjpacheco/subscriptions","organizations_url":"https://api.github.com/users/justinjpacheco/orgs","repos_url":"https://api.github.com/users/justinjpacheco/repos","events_url":"https://api.github.com/users/justinjpacheco/events{/privacy}","received_events_url":"https://api.github.com/users/justinjpacheco/received_events","type":"User","site_admin":false},"body":"all class boundaries are supported (/8 and /16) everything else is split into /24 ","created_at":"2018-11-05T16:46:17Z","updated_at":"2018-11-05T16:46:18Z","html_url":"https://github.com/bloomberg/chef-bcpc/pull/1443#discussion_r230825036","pull_request_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments/230825036"},"html":{"href":"https://github.com/bloomberg/chef-bcpc/pull/1443#discussion_r230825036"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443"}},"in_reply_to_id":230809868},"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443","id":228084213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDg0MjEz","html_url":"https://github.com/bloomberg/chef-bcpc/pull/1443","diff_url":"https://github.com/bloomberg/chef-bcpc/pull/1443.diff","patch_url":"https://github.com/bloomberg/chef-bcpc/pull/1443.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/1443","number":1443,"state":"open","locked":false,"title":"updated dns zone creation/management","user":{"login":"justinjpacheco","id":146161,"node_id":"MDQ6VXNlcjE0NjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/146161?v=4","gravatar_id":"","url":"https://api.github.com/users/justinjpacheco","html_url":"https://github.com/justinjpacheco","followers_url":"https://api.github.com/users/justinjpacheco/followers","following_url":"https://api.github.com/users/justinjpacheco/following{/other_user}","gists_url":"https://api.github.com/users/justinjpacheco/gists{/gist_id}","starred_url":"https://api.github.com/users/justinjpacheco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinjpacheco/subscriptions","organizations_url":"https://api.github.com/users/justinjpacheco/orgs","repos_url":"https://api.github.com/users/justinjpacheco/repos","events_url":"https://api.github.com/users/justinjpacheco/events{/privacy}","received_events_url":"https://api.github.com/users/justinjpacheco/received_events","type":"User","site_admin":false},"body":"  - neutron\r\n    - improved 'networks' data structure\r\n      - less redundant\r\n      - added explicit keys for zone creation and fqdn prefix\r\n      - put network subnets into their own array of hashes\r\n  - powerdns\r\n    - added 'also-notify' to notify dns slaves of updates to zone files\r\n    - added configuration support for dns nameservers\r\n    - added cloud fqdn to zone recordset\r\n    - added new zone: catalog\r\n      - contains a list of all the zones currently configured in pdns\r\n      - used by bind-dns slaves to know which zones to sync\r\n    - zone serial time is now current epoch\r\n    - split network cidr into /24 chunks when creating reverse zones\r\n    - added catalog-zone-manage python script\r\n      - creates/updates catalog zone with zones listed in pdns","created_at":"2018-11-02T23:48:55Z","updated_at":"2018-11-05T16:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64b1656a05b82e0bb5f9e82494ab6ced17ee51dd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mihalis68","id":4429072,"node_id":"MDQ6VXNlcjQ0MjkwNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4429072?v=4","gravatar_id":"","url":"https://api.github.com/users/mihalis68","html_url":"https://github.com/mihalis68","followers_url":"https://api.github.com/users/mihalis68/followers","following_url":"https://api.github.com/users/mihalis68/following{/other_user}","gists_url":"https://api.github.com/users/mihalis68/gists{/gist_id}","starred_url":"https://api.github.com/users/mihalis68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihalis68/subscriptions","organizations_url":"https://api.github.com/users/mihalis68/orgs","repos_url":"https://api.github.com/users/mihalis68/repos","events_url":"https://api.github.com/users/mihalis68/events{/privacy}","received_events_url":"https://api.github.com/users/mihalis68/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/1443/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/6152d7edc4c19d9c767aa18af696530352e0e65f","head":{"label":"justinjpacheco:dns-zone-creation","ref":"dns-zone-creation","sha":"6152d7edc4c19d9c767aa18af696530352e0e65f","user":{"login":"justinjpacheco","id":146161,"node_id":"MDQ6VXNlcjE0NjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/146161?v=4","gravatar_id":"","url":"https://api.github.com/users/justinjpacheco","html_url":"https://github.com/justinjpacheco","followers_url":"https://api.github.com/users/justinjpacheco/followers","following_url":"https://api.github.com/users/justinjpacheco/following{/other_user}","gists_url":"https://api.github.com/users/justinjpacheco/gists{/gist_id}","starred_url":"https://api.github.com/users/justinjpacheco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinjpacheco/subscriptions","organizations_url":"https://api.github.com/users/justinjpacheco/orgs","repos_url":"https://api.github.com/users/justinjpacheco/repos","events_url":"https://api.github.com/users/justinjpacheco/events{/privacy}","received_events_url":"https://api.github.com/users/justinjpacheco/received_events","type":"User","site_admin":false},"repo":{"id":114787427,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3ODc0Mjc=","name":"chef-bcpc","full_name":"justinjpacheco/chef-bcpc","private":false,"owner":{"login":"justinjpacheco","id":146161,"node_id":"MDQ6VXNlcjE0NjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/146161?v=4","gravatar_id":"","url":"https://api.github.com/users/justinjpacheco","html_url":"https://github.com/justinjpacheco","followers_url":"https://api.github.com/users/justinjpacheco/followers","following_url":"https://api.github.com/users/justinjpacheco/following{/other_user}","gists_url":"https://api.github.com/users/justinjpacheco/gists{/gist_id}","starred_url":"https://api.github.com/users/justinjpacheco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinjpacheco/subscriptions","organizations_url":"https://api.github.com/users/justinjpacheco/orgs","repos_url":"https://api.github.com/users/justinjpacheco/repos","events_url":"https://api.github.com/users/justinjpacheco/events{/privacy}","received_events_url":"https://api.github.com/users/justinjpacheco/received_events","type":"User","site_admin":false},"html_url":"https://github.com/justinjpacheco/chef-bcpc","description":"Bloomberg Clustered Private Cloud distribution","fork":true,"url":"https://api.github.com/repos/justinjpacheco/chef-bcpc","forks_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/forks","keys_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/teams","hooks_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/hooks","issue_events_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/issues/events{/number}","events_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/events","assignees_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/assignees{/user}","branches_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/branches{/branch}","tags_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/tags","blobs_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/statuses/{sha}","languages_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/languages","stargazers_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/stargazers","contributors_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/contributors","subscribers_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/subscribers","subscription_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/subscription","commits_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/contents/{+path}","compare_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/merges","archive_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/downloads","issues_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/issues{/number}","pulls_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/pulls{/number}","milestones_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/milestones{/number}","notifications_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/labels{/name}","releases_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/releases{/id}","deployments_url":"https://api.github.com/repos/justinjpacheco/chef-bcpc/deployments","created_at":"2017-12-19T16:28:50Z","updated_at":"2018-10-24T16:37:14Z","pushed_at":"2018-11-05T15:25:53Z","git_url":"git://github.com/justinjpacheco/chef-bcpc.git","ssh_url":"git@github.com:justinjpacheco/chef-bcpc.git","clone_url":"https://github.com/justinjpacheco/chef-bcpc.git","svn_url":"https://github.com/justinjpacheco/chef-bcpc","homepage":"","size":5653,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:feature/v8-bionic","ref":"feature/v8-bionic","sha":"5f15bc8a92e9a0aa3c430e12e875c38d0eeae7f9","user":{"login":"bloomberg","id":1416818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":9452427,"node_id":"MDEwOlJlcG9zaXRvcnk5NDUyNDI3","name":"chef-bcpc","full_name":"bloomberg/chef-bcpc","private":false,"owner":{"login":"bloomberg","id":1416818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bloomberg/chef-bcpc","description":"Bloomberg Clustered Private Cloud distribution","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bcpc","forks_url":"https://api.github.com/repos/bloomberg/chef-bcpc/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bcpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bcpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bcpc/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bcpc/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bcpc/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bcpc/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bcpc/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bcpc/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bcpc/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bcpc/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bcpc/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bcpc/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bcpc/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bcpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bcpc/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bcpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bcpc/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bcpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bcpc/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bcpc/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bcpc/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bcpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bcpc/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bcpc/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/chef-bcpc/deployments","created_at":"2013-04-15T15:56:32Z","updated_at":"2018-10-13T02:59:22Z","pushed_at":"2018-11-05T15:25:55Z","git_url":"git://github.com/bloomberg/chef-bcpc.git","ssh_url":"git@github.com:bloomberg/chef-bcpc.git","clone_url":"https://github.com/bloomberg/chef-bcpc.git","svn_url":"https://github.com/bloomberg/chef-bcpc","homepage":"","size":5586,"stargazers_count":188,"watchers_count":188,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":82,"open_issues":51,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443"},"html":{"href":"https://github.com/bloomberg/chef-bcpc/pull/1443"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/1443"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/issues/1443/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/pulls/1443/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bcpc/statuses/6152d7edc4c19d9c767aa18af696530352e0e65f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"justinjpacheco"}}