{"action":"created","comment":{"url":"https://api.github.com/repos/ammolytics/cartridges/pulls/comments/213096126","pull_request_review_id":149860918,"id":213096126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzA5NjEyNg==","diff_hunk":"@@ -123,3 +123,377 @@\n 8mm Remington Magnum\n 9.3 x 62\n ```\n+\n+##CIP","path":"data/rifle/README.md","position":5,"original_position":5,"commit_id":"d36f6595dd861c16b46e0dad672d0983128da2d7","original_commit_id":"d36f6595dd861c16b46e0dad672d0983128da2d7","user":{"login":"GAO8A","id":8060908,"node_id":"MDQ6VXNlcjgwNjA5MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8060908?v=4","gravatar_id":"","url":"https://api.github.com/users/GAO8A","html_url":"https://github.com/GAO8A","followers_url":"https://api.github.com/users/GAO8A/followers","following_url":"https://api.github.com/users/GAO8A/following{/other_user}","gists_url":"https://api.github.com/users/GAO8A/gists{/gist_id}","starred_url":"https://api.github.com/users/GAO8A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAO8A/subscriptions","organizations_url":"https://api.github.com/users/GAO8A/orgs","repos_url":"https://api.github.com/users/GAO8A/repos","events_url":"https://api.github.com/users/GAO8A/events{/privacy}","received_events_url":"https://api.github.com/users/GAO8A/received_events","type":"User","site_admin":false},"body":"👍","created_at":"2018-08-27T19:59:54Z","updated_at":"2018-08-27T19:59:56Z","html_url":"https://github.com/ammolytics/cartridges/pull/8#discussion_r213096126","pull_request_url":"https://api.github.com/repos/ammolytics/cartridges/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/comments/213096126"},"html":{"href":"https://github.com/ammolytics/cartridges/pull/8#discussion_r213096126"},"pull_request":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/8"}},"in_reply_to_id":213012120},"pull_request":{"url":"https://api.github.com/repos/ammolytics/cartridges/pulls/8","id":210473920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDczOTIw","html_url":"https://github.com/ammolytics/cartridges/pull/8","diff_url":"https://github.com/ammolytics/cartridges/pull/8.diff","patch_url":"https://github.com/ammolytics/cartridges/pull/8.patch","issue_url":"https://api.github.com/repos/ammolytics/cartridges/issues/8","number":8,"state":"open","locked":false,"title":"Add CIP cartridge JSON data","user":{"login":"GAO8A","id":8060908,"node_id":"MDQ6VXNlcjgwNjA5MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8060908?v=4","gravatar_id":"","url":"https://api.github.com/users/GAO8A","html_url":"https://github.com/GAO8A","followers_url":"https://api.github.com/users/GAO8A/followers","following_url":"https://api.github.com/users/GAO8A/following{/other_user}","gists_url":"https://api.github.com/users/GAO8A/gists{/gist_id}","starred_url":"https://api.github.com/users/GAO8A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAO8A/subscriptions","organizations_url":"https://api.github.com/users/GAO8A/orgs","repos_url":"https://api.github.com/users/GAO8A/repos","events_url":"https://api.github.com/users/GAO8A/events{/privacy}","received_events_url":"https://api.github.com/users/GAO8A/received_events","type":"User","site_admin":false},"body":"Added JSON data for CIP cartridges.\r\n\r\n- Names contain comma decimal separator. Should we standardize to dot?\r\n\r\n- `data/rifle/cip.json` contains combined data of:\r\n\r\n1. Rimless cartridges \r\n2. Rimmed cartridges \r\n3. Magnum cartridges\r\n\r\nIt contains escape character `\\\"` (eg. `450 N.E. 3\\\" 1/4\"`) but also `“` (eg. `475 N° 2 N.E. 3“1/2 Jeffery`). Should we standardize?\r\n\r\n- CIP's classification is more specific than the current 4 types of data, but for less conventional/common cartridge types. Should we expand?\r\n\r\nThanks!\r\n\r\nClose https://github.com/ammolytics/cartridges/issues/7","created_at":"2018-08-23T14:46:09Z","updated_at":"2018-08-27T19:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec8b81cbc33d9416e2b8e42658493dafe4b81e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ammolytics/cartridges/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ammolytics/cartridges/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ammolytics/cartridges/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ammolytics/cartridges/issues/8/comments","statuses_url":"https://api.github.com/repos/ammolytics/cartridges/statuses/d36f6595dd861c16b46e0dad672d0983128da2d7","head":{"label":"GAO8A:issue-7","ref":"issue-7","sha":"d36f6595dd861c16b46e0dad672d0983128da2d7","user":{"login":"GAO8A","id":8060908,"node_id":"MDQ6VXNlcjgwNjA5MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8060908?v=4","gravatar_id":"","url":"https://api.github.com/users/GAO8A","html_url":"https://github.com/GAO8A","followers_url":"https://api.github.com/users/GAO8A/followers","following_url":"https://api.github.com/users/GAO8A/following{/other_user}","gists_url":"https://api.github.com/users/GAO8A/gists{/gist_id}","starred_url":"https://api.github.com/users/GAO8A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAO8A/subscriptions","organizations_url":"https://api.github.com/users/GAO8A/orgs","repos_url":"https://api.github.com/users/GAO8A/repos","events_url":"https://api.github.com/users/GAO8A/events{/privacy}","received_events_url":"https://api.github.com/users/GAO8A/received_events","type":"User","site_admin":false},"repo":{"id":145859625,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NTk2MjU=","name":"cartridges","full_name":"GAO8A/cartridges","owner":{"login":"GAO8A","id":8060908,"node_id":"MDQ6VXNlcjgwNjA5MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8060908?v=4","gravatar_id":"","url":"https://api.github.com/users/GAO8A","html_url":"https://github.com/GAO8A","followers_url":"https://api.github.com/users/GAO8A/followers","following_url":"https://api.github.com/users/GAO8A/following{/other_user}","gists_url":"https://api.github.com/users/GAO8A/gists{/gist_id}","starred_url":"https://api.github.com/users/GAO8A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAO8A/subscriptions","organizations_url":"https://api.github.com/users/GAO8A/orgs","repos_url":"https://api.github.com/users/GAO8A/repos","events_url":"https://api.github.com/users/GAO8A/events{/privacy}","received_events_url":"https://api.github.com/users/GAO8A/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GAO8A/cartridges","description":"An open-source dataset of ammunition cartridge information from SAAMI, CIP, and NATO STANAG","fork":true,"url":"https://api.github.com/repos/GAO8A/cartridges","forks_url":"https://api.github.com/repos/GAO8A/cartridges/forks","keys_url":"https://api.github.com/repos/GAO8A/cartridges/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GAO8A/cartridges/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GAO8A/cartridges/teams","hooks_url":"https://api.github.com/repos/GAO8A/cartridges/hooks","issue_events_url":"https://api.github.com/repos/GAO8A/cartridges/issues/events{/number}","events_url":"https://api.github.com/repos/GAO8A/cartridges/events","assignees_url":"https://api.github.com/repos/GAO8A/cartridges/assignees{/user}","branches_url":"https://api.github.com/repos/GAO8A/cartridges/branches{/branch}","tags_url":"https://api.github.com/repos/GAO8A/cartridges/tags","blobs_url":"https://api.github.com/repos/GAO8A/cartridges/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GAO8A/cartridges/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GAO8A/cartridges/git/refs{/sha}","trees_url":"https://api.github.com/repos/GAO8A/cartridges/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GAO8A/cartridges/statuses/{sha}","languages_url":"https://api.github.com/repos/GAO8A/cartridges/languages","stargazers_url":"https://api.github.com/repos/GAO8A/cartridges/stargazers","contributors_url":"https://api.github.com/repos/GAO8A/cartridges/contributors","subscribers_url":"https://api.github.com/repos/GAO8A/cartridges/subscribers","subscription_url":"https://api.github.com/repos/GAO8A/cartridges/subscription","commits_url":"https://api.github.com/repos/GAO8A/cartridges/commits{/sha}","git_commits_url":"https://api.github.com/repos/GAO8A/cartridges/git/commits{/sha}","comments_url":"https://api.github.com/repos/GAO8A/cartridges/comments{/number}","issue_comment_url":"https://api.github.com/repos/GAO8A/cartridges/issues/comments{/number}","contents_url":"https://api.github.com/repos/GAO8A/cartridges/contents/{+path}","compare_url":"https://api.github.com/repos/GAO8A/cartridges/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GAO8A/cartridges/merges","archive_url":"https://api.github.com/repos/GAO8A/cartridges/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GAO8A/cartridges/downloads","issues_url":"https://api.github.com/repos/GAO8A/cartridges/issues{/number}","pulls_url":"https://api.github.com/repos/GAO8A/cartridges/pulls{/number}","milestones_url":"https://api.github.com/repos/GAO8A/cartridges/milestones{/number}","notifications_url":"https://api.github.com/repos/GAO8A/cartridges/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GAO8A/cartridges/labels{/name}","releases_url":"https://api.github.com/repos/GAO8A/cartridges/releases{/id}","deployments_url":"https://api.github.com/repos/GAO8A/cartridges/deployments","created_at":"2018-08-23T13:45:49Z","updated_at":"2018-08-23T13:45:52Z","pushed_at":"2018-08-24T22:03:04Z","git_url":"git://github.com/GAO8A/cartridges.git","ssh_url":"git@github.com:GAO8A/cartridges.git","clone_url":"https://github.com/GAO8A/cartridges.git","svn_url":"https://github.com/GAO8A/cartridges","homepage":"","size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ammolytics:develop","ref":"develop","sha":"dd42c18b6c9bd6a620d5fd400bd619db84253762","user":{"login":"ammolytics","id":34223066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjIzMDY2","avatar_url":"https://avatars3.githubusercontent.com/u/34223066?v=4","gravatar_id":"","url":"https://api.github.com/users/ammolytics","html_url":"https://github.com/ammolytics","followers_url":"https://api.github.com/users/ammolytics/followers","following_url":"https://api.github.com/users/ammolytics/following{/other_user}","gists_url":"https://api.github.com/users/ammolytics/gists{/gist_id}","starred_url":"https://api.github.com/users/ammolytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammolytics/subscriptions","organizations_url":"https://api.github.com/users/ammolytics/orgs","repos_url":"https://api.github.com/users/ammolytics/repos","events_url":"https://api.github.com/users/ammolytics/events{/privacy}","received_events_url":"https://api.github.com/users/ammolytics/received_events","type":"Organization","site_admin":false},"repo":{"id":121540918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1NDA5MTg=","name":"cartridges","full_name":"ammolytics/cartridges","owner":{"login":"ammolytics","id":34223066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjIzMDY2","avatar_url":"https://avatars3.githubusercontent.com/u/34223066?v=4","gravatar_id":"","url":"https://api.github.com/users/ammolytics","html_url":"https://github.com/ammolytics","followers_url":"https://api.github.com/users/ammolytics/followers","following_url":"https://api.github.com/users/ammolytics/following{/other_user}","gists_url":"https://api.github.com/users/ammolytics/gists{/gist_id}","starred_url":"https://api.github.com/users/ammolytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammolytics/subscriptions","organizations_url":"https://api.github.com/users/ammolytics/orgs","repos_url":"https://api.github.com/users/ammolytics/repos","events_url":"https://api.github.com/users/ammolytics/events{/privacy}","received_events_url":"https://api.github.com/users/ammolytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ammolytics/cartridges","description":"An open-source dataset of ammunition cartridge information from SAAMI, CIP, and NATO STANAG","fork":false,"url":"https://api.github.com/repos/ammolytics/cartridges","forks_url":"https://api.github.com/repos/ammolytics/cartridges/forks","keys_url":"https://api.github.com/repos/ammolytics/cartridges/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ammolytics/cartridges/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ammolytics/cartridges/teams","hooks_url":"https://api.github.com/repos/ammolytics/cartridges/hooks","issue_events_url":"https://api.github.com/repos/ammolytics/cartridges/issues/events{/number}","events_url":"https://api.github.com/repos/ammolytics/cartridges/events","assignees_url":"https://api.github.com/repos/ammolytics/cartridges/assignees{/user}","branches_url":"https://api.github.com/repos/ammolytics/cartridges/branches{/branch}","tags_url":"https://api.github.com/repos/ammolytics/cartridges/tags","blobs_url":"https://api.github.com/repos/ammolytics/cartridges/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ammolytics/cartridges/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ammolytics/cartridges/git/refs{/sha}","trees_url":"https://api.github.com/repos/ammolytics/cartridges/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ammolytics/cartridges/statuses/{sha}","languages_url":"https://api.github.com/repos/ammolytics/cartridges/languages","stargazers_url":"https://api.github.com/repos/ammolytics/cartridges/stargazers","contributors_url":"https://api.github.com/repos/ammolytics/cartridges/contributors","subscribers_url":"https://api.github.com/repos/ammolytics/cartridges/subscribers","subscription_url":"https://api.github.com/repos/ammolytics/cartridges/subscription","commits_url":"https://api.github.com/repos/ammolytics/cartridges/commits{/sha}","git_commits_url":"https://api.github.com/repos/ammolytics/cartridges/git/commits{/sha}","comments_url":"https://api.github.com/repos/ammolytics/cartridges/comments{/number}","issue_comment_url":"https://api.github.com/repos/ammolytics/cartridges/issues/comments{/number}","contents_url":"https://api.github.com/repos/ammolytics/cartridges/contents/{+path}","compare_url":"https://api.github.com/repos/ammolytics/cartridges/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ammolytics/cartridges/merges","archive_url":"https://api.github.com/repos/ammolytics/cartridges/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ammolytics/cartridges/downloads","issues_url":"https://api.github.com/repos/ammolytics/cartridges/issues{/number}","pulls_url":"https://api.github.com/repos/ammolytics/cartridges/pulls{/number}","milestones_url":"https://api.github.com/repos/ammolytics/cartridges/milestones{/number}","notifications_url":"https://api.github.com/repos/ammolytics/cartridges/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ammolytics/cartridges/labels{/name}","releases_url":"https://api.github.com/repos/ammolytics/cartridges/releases{/id}","deployments_url":"https://api.github.com/repos/ammolytics/cartridges/deployments","created_at":"2018-02-14T17:40:49Z","updated_at":"2018-03-01T05:26:27Z","pushed_at":"2018-08-24T22:03:05Z","git_url":"git://github.com/ammolytics/cartridges.git","ssh_url":"git@github.com:ammolytics/cartridges.git","clone_url":"https://github.com/ammolytics/cartridges.git","svn_url":"https://github.com/ammolytics/cartridges","homepage":"","size":26,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/8"},"html":{"href":"https://github.com/ammolytics/cartridges/pull/8"},"issue":{"href":"https://api.github.com/repos/ammolytics/cartridges/issues/8"},"comments":{"href":"https://api.github.com/repos/ammolytics/cartridges/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ammolytics/cartridges/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ammolytics/cartridges/statuses/d36f6595dd861c16b46e0dad672d0983128da2d7"}},"author_association":"NONE"}}
{"actor":{"display_login":"GAO8A"}}