{"action":"created","issue":{"url":"https://api.github.com/repos/geopandas/geopandas/issues/878","repository_url":"https://api.github.com/repos/geopandas/geopandas","labels_url":"https://api.github.com/repos/geopandas/geopandas/issues/878/labels{/name}","comments_url":"https://api.github.com/repos/geopandas/geopandas/issues/878/comments","events_url":"https://api.github.com/repos/geopandas/geopandas/issues/878/events","html_url":"https://github.com/geopandas/geopandas/pull/878","id":389790349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Njk5Mzkx","number":878,"title":"BUG: Ignore NaN in setting mn and mx (#877)","user":{"login":"martinfleis","id":36797143,"node_id":"MDQ6VXNlcjM2Nzk3MTQz","avatar_url":"https://avatars2.githubusercontent.com/u/36797143?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfleis","html_url":"https://github.com/martinfleis","followers_url":"https://api.github.com/users/martinfleis/followers","following_url":"https://api.github.com/users/martinfleis/following{/other_user}","gists_url":"https://api.github.com/users/martinfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfleis/subscriptions","organizations_url":"https://api.github.com/users/martinfleis/orgs","repos_url":"https://api.github.com/users/martinfleis/repos","events_url":"https://api.github.com/users/martinfleis/events{/privacy}","received_events_url":"https://api.github.com/users/martinfleis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-11T14:28:44Z","updated_at":"2018-12-12T12:19:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/geopandas/geopandas/pulls/878","html_url":"https://github.com/geopandas/geopandas/pull/878","diff_url":"https://github.com/geopandas/geopandas/pull/878.diff","patch_url":"https://github.com/geopandas/geopandas/pull/878.patch"},"body":"Changes in #770 wrong behaviour of `mn = values.min() if vmin is None else vmin` and `mx = values.max() if vmax is None else vmax` which lead to wrong colours during plotting. \r\n\r\nPrevious version was passing Series, which ignores NaNs in min() and max(). Now it is passing numpy array which returns NaN for min() and max() (if there are any).\r\n\r\nResolves #877 "},"comment":{"url":"https://api.github.com/repos/geopandas/geopandas/issues/comments/446568564","html_url":"https://github.com/geopandas/geopandas/pull/878#issuecomment-446568564","issue_url":"https://api.github.com/repos/geopandas/geopandas/issues/878","id":446568564,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjU2ODU2NA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-12T12:19:53Z","updated_at":"2018-12-12T12:19:53Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=h1) Report\n> Merging [#878](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=desc) into [master](https://codecov.io/gh/geopandas/geopandas/commit/fab445abd12aa02112cec3736c4c88523ac46da9?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/geopandas/geopandas/pull/878/graphs/tree.svg?width=650&token=6TOPMcCBhB&height=150&src=pr)](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master     #878   +/-   ##\n=======================================\n  Coverage   89.58%   89.58%           \n=======================================\n  Files          15       15           \n  Lines        1325     1325           \n=======================================\n  Hits         1187     1187           \n  Misses        138      138\n```\n\n\n| [Impacted Files](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [geopandas/plotting.py](https://codecov.io/gh/geopandas/geopandas/pull/878/diff?src=pr&el=tree#diff-Z2VvcGFuZGFzL3Bsb3R0aW5nLnB5) | `93.02% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=footer). Last update [fab445a...7e9e037](https://codecov.io/gh/geopandas/geopandas/pull/878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}