{"action":"created","comment":{"url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments/234742084","pull_request_review_id":176449055,"id":234742084,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc0MjA4NA==","diff_hunk":"@@ -62,6 +62,7 @@ class WiFiClientSecure : public WiFiClient\n     bool loadCertificate(Stream& stream, size_t size);\n     bool loadPrivateKey(Stream& stream, size_t size);\n     bool verify(const char* fingerprint, const char* domain_name);\n+    void setHandshakeTimeout(unsigned long handshake_timeout);","path":"libraries/WiFiClientSecure/src/WiFiClientSecure.h","position":4,"original_position":4,"commit_id":"decf8268664e6257bb59c562486afa355b56f0ff","original_commit_id":"decf8268664e6257bb59c562486afa355b56f0ff","user":{"login":"atanisoft","id":6457044,"node_id":"MDQ6VXNlcjY0NTcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6457044?v=4","gravatar_id":"","url":"https://api.github.com/users/atanisoft","html_url":"https://github.com/atanisoft","followers_url":"https://api.github.com/users/atanisoft/followers","following_url":"https://api.github.com/users/atanisoft/following{/other_user}","gists_url":"https://api.github.com/users/atanisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/atanisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanisoft/subscriptions","organizations_url":"https://api.github.com/users/atanisoft/orgs","repos_url":"https://api.github.com/users/atanisoft/repos","events_url":"https://api.github.com/users/atanisoft/events{/privacy}","received_events_url":"https://api.github.com/users/atanisoft/received_events","type":"User","site_admin":false},"body":"It probably should be noted that this is expected to be seconds and not milliseconds.","created_at":"2018-11-19T19:01:01Z","updated_at":"2018-11-19T19:01:01Z","html_url":"https://github.com/espressif/arduino-esp32/pull/2044#discussion_r234742084","pull_request_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments/234742084"},"html":{"href":"https://github.com/espressif/arduino-esp32/pull/2044#discussion_r234742084"},"pull_request":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044"}}},"pull_request":{"url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044","id":229875714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODc1NzE0","html_url":"https://github.com/espressif/arduino-esp32/pull/2044","diff_url":"https://github.com/espressif/arduino-esp32/pull/2044.diff","patch_url":"https://github.com/espressif/arduino-esp32/pull/2044.patch","issue_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/2044","number":2044,"state":"open","locked":false,"title":"handshake in ssl_client.cpp","user":{"login":"a-c-sreedhar-reddy","id":16081083,"node_id":"MDQ6VXNlcjE2MDgxMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/16081083?v=4","gravatar_id":"","url":"https://api.github.com/users/a-c-sreedhar-reddy","html_url":"https://github.com/a-c-sreedhar-reddy","followers_url":"https://api.github.com/users/a-c-sreedhar-reddy/followers","following_url":"https://api.github.com/users/a-c-sreedhar-reddy/following{/other_user}","gists_url":"https://api.github.com/users/a-c-sreedhar-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/a-c-sreedhar-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-c-sreedhar-reddy/subscriptions","organizations_url":"https://api.github.com/users/a-c-sreedhar-reddy/orgs","repos_url":"https://api.github.com/users/a-c-sreedhar-reddy/repos","events_url":"https://api.github.com/users/a-c-sreedhar-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/a-c-sreedhar-reddy/received_events","type":"User","site_admin":false},"body":"issue #2041","created_at":"2018-11-10T07:21:31Z","updated_at":"2018-11-19T19:01:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41cf3c93d668a34b7f7fd8063a7adcc9d4d4f8b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044/commits","review_comments_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044/comments","review_comment_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/2044/comments","statuses_url":"https://api.github.com/repos/espressif/arduino-esp32/statuses/decf8268664e6257bb59c562486afa355b56f0ff","head":{"label":"a-c-sreedhar-reddy:master","ref":"master","sha":"decf8268664e6257bb59c562486afa355b56f0ff","user":{"login":"a-c-sreedhar-reddy","id":16081083,"node_id":"MDQ6VXNlcjE2MDgxMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/16081083?v=4","gravatar_id":"","url":"https://api.github.com/users/a-c-sreedhar-reddy","html_url":"https://github.com/a-c-sreedhar-reddy","followers_url":"https://api.github.com/users/a-c-sreedhar-reddy/followers","following_url":"https://api.github.com/users/a-c-sreedhar-reddy/following{/other_user}","gists_url":"https://api.github.com/users/a-c-sreedhar-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/a-c-sreedhar-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-c-sreedhar-reddy/subscriptions","organizations_url":"https://api.github.com/users/a-c-sreedhar-reddy/orgs","repos_url":"https://api.github.com/users/a-c-sreedhar-reddy/repos","events_url":"https://api.github.com/users/a-c-sreedhar-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/a-c-sreedhar-reddy/received_events","type":"User","site_admin":false},"repo":{"id":156956722,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5NTY3MjI=","name":"arduino-esp32","full_name":"a-c-sreedhar-reddy/arduino-esp32","private":false,"owner":{"login":"a-c-sreedhar-reddy","id":16081083,"node_id":"MDQ6VXNlcjE2MDgxMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/16081083?v=4","gravatar_id":"","url":"https://api.github.com/users/a-c-sreedhar-reddy","html_url":"https://github.com/a-c-sreedhar-reddy","followers_url":"https://api.github.com/users/a-c-sreedhar-reddy/followers","following_url":"https://api.github.com/users/a-c-sreedhar-reddy/following{/other_user}","gists_url":"https://api.github.com/users/a-c-sreedhar-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/a-c-sreedhar-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-c-sreedhar-reddy/subscriptions","organizations_url":"https://api.github.com/users/a-c-sreedhar-reddy/orgs","repos_url":"https://api.github.com/users/a-c-sreedhar-reddy/repos","events_url":"https://api.github.com/users/a-c-sreedhar-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/a-c-sreedhar-reddy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a-c-sreedhar-reddy/arduino-esp32","description":"Arduino core for the ESP32","fork":true,"url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32","forks_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/forks","keys_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/teams","hooks_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/hooks","issue_events_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/issues/events{/number}","events_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/events","assignees_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/assignees{/user}","branches_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/branches{/branch}","tags_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/tags","blobs_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/statuses/{sha}","languages_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/languages","stargazers_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/stargazers","contributors_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/contributors","subscribers_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/subscribers","subscription_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/subscription","commits_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/contents/{+path}","compare_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/merges","archive_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/downloads","issues_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/issues{/number}","pulls_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/pulls{/number}","milestones_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/milestones{/number}","notifications_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/labels{/name}","releases_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/releases{/id}","deployments_url":"https://api.github.com/repos/a-c-sreedhar-reddy/arduino-esp32/deployments","created_at":"2018-11-10T07:04:08Z","updated_at":"2018-11-19T18:42:08Z","pushed_at":"2018-11-19T18:42:05Z","git_url":"git://github.com/a-c-sreedhar-reddy/arduino-esp32.git","ssh_url":"git@github.com:a-c-sreedhar-reddy/arduino-esp32.git","clone_url":"https://github.com/a-c-sreedhar-reddy/arduino-esp32.git","svn_url":"https://github.com/a-c-sreedhar-reddy/arduino-esp32","homepage":null,"size":144813,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressif:master","ref":"master","sha":"acefd4bf2e34609b5a02ca0be903cd2fc23c8de3","user":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"repo":{"id":70127218,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEyNzIxOA==","name":"arduino-esp32","full_name":"espressif/arduino-esp32","private":false,"owner":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espressif/arduino-esp32","description":"Arduino core for the ESP32","fork":false,"url":"https://api.github.com/repos/espressif/arduino-esp32","forks_url":"https://api.github.com/repos/espressif/arduino-esp32/forks","keys_url":"https://api.github.com/repos/espressif/arduino-esp32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressif/arduino-esp32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressif/arduino-esp32/teams","hooks_url":"https://api.github.com/repos/espressif/arduino-esp32/hooks","issue_events_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/events{/number}","events_url":"https://api.github.com/repos/espressif/arduino-esp32/events","assignees_url":"https://api.github.com/repos/espressif/arduino-esp32/assignees{/user}","branches_url":"https://api.github.com/repos/espressif/arduino-esp32/branches{/branch}","tags_url":"https://api.github.com/repos/espressif/arduino-esp32/tags","blobs_url":"https://api.github.com/repos/espressif/arduino-esp32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressif/arduino-esp32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressif/arduino-esp32/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressif/arduino-esp32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressif/arduino-esp32/statuses/{sha}","languages_url":"https://api.github.com/repos/espressif/arduino-esp32/languages","stargazers_url":"https://api.github.com/repos/espressif/arduino-esp32/stargazers","contributors_url":"https://api.github.com/repos/espressif/arduino-esp32/contributors","subscribers_url":"https://api.github.com/repos/espressif/arduino-esp32/subscribers","subscription_url":"https://api.github.com/repos/espressif/arduino-esp32/subscription","commits_url":"https://api.github.com/repos/espressif/arduino-esp32/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressif/arduino-esp32/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressif/arduino-esp32/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressif/arduino-esp32/contents/{+path}","compare_url":"https://api.github.com/repos/espressif/arduino-esp32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressif/arduino-esp32/merges","archive_url":"https://api.github.com/repos/espressif/arduino-esp32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressif/arduino-esp32/downloads","issues_url":"https://api.github.com/repos/espressif/arduino-esp32/issues{/number}","pulls_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls{/number}","milestones_url":"https://api.github.com/repos/espressif/arduino-esp32/milestones{/number}","notifications_url":"https://api.github.com/repos/espressif/arduino-esp32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressif/arduino-esp32/labels{/name}","releases_url":"https://api.github.com/repos/espressif/arduino-esp32/releases{/id}","deployments_url":"https://api.github.com/repos/espressif/arduino-esp32/deployments","created_at":"2016-10-06T06:04:20Z","updated_at":"2018-11-19T18:30:33Z","pushed_at":"2018-11-19T18:42:07Z","git_url":"git://github.com/espressif/arduino-esp32.git","ssh_url":"git@github.com:espressif/arduino-esp32.git","clone_url":"https://github.com/espressif/arduino-esp32.git","svn_url":"https://github.com/espressif/arduino-esp32","homepage":null,"size":144883,"stargazers_count":2526,"watchers_count":2526,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"open_issues_count":592,"license":null,"forks":1200,"open_issues":592,"watchers":2526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044"},"html":{"href":"https://github.com/espressif/arduino-esp32/pull/2044"},"issue":{"href":"https://api.github.com/repos/espressif/arduino-esp32/issues/2044"},"comments":{"href":"https://api.github.com/repos/espressif/arduino-esp32/issues/2044/comments"},"review_comments":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044/comments"},"review_comment":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/2044/commits"},"statuses":{"href":"https://api.github.com/repos/espressif/arduino-esp32/statuses/decf8268664e6257bb59c562486afa355b56f0ff"}},"author_association":"NONE"}}
{"actor":{"display_login":"atanisoft"}}