{"action":"created","comment":{"url":"https://api.github.com/repos/garden-io/garden/pulls/comments/240381444","pull_request_review_id":183400333,"id":240381444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDM4MTQ0NA==","diff_hunk":"@@ -232,8 +232,9 @@ export async function createDeployment(\n     deployment.spec.strategy = {\n       type: \"RollingUpdate\",\n       rollingUpdate: {\n-        maxUnavailable: \"34%\",\n-        maxSurge: \"34%\",\n+        // This is optimized for fast re-deployment.\n+        maxUnavailable: \"100%\",","path":"garden-service/src/plugins/kubernetes/deployment.ts","position":7,"original_position":7,"commit_id":"dd0265177d87b1638e0b4b1abc5919073cb16159","original_commit_id":"dd0265177d87b1638e0b4b1abc5919073cb16159","user":{"login":"edvald","id":155684,"node_id":"MDQ6VXNlcjE1NTY4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/155684?v=4","gravatar_id":"","url":"https://api.github.com/users/edvald","html_url":"https://github.com/edvald","followers_url":"https://api.github.com/users/edvald/followers","following_url":"https://api.github.com/users/edvald/following{/other_user}","gists_url":"https://api.github.com/users/edvald/gists{/gist_id}","starred_url":"https://api.github.com/users/edvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvald/subscriptions","organizations_url":"https://api.github.com/users/edvald/orgs","repos_url":"https://api.github.com/users/edvald/repos","events_url":"https://api.github.com/users/edvald/events{/privacy}","received_events_url":"https://api.github.com/users/edvald/received_events","type":"User","site_admin":false},"body":"Good idea. And yea, I think the main thing is to surface problems quickly. Any more ideas on how to do that would be great, for now I'll update with the suggestions above.","created_at":"2018-12-10T21:11:19Z","updated_at":"2018-12-10T21:11:19Z","html_url":"https://github.com/garden-io/garden/pull/430#discussion_r240381444","pull_request_url":"https://api.github.com/repos/garden-io/garden/pulls/430","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/garden-io/garden/pulls/comments/240381444"},"html":{"href":"https://github.com/garden-io/garden/pull/430#discussion_r240381444"},"pull_request":{"href":"https://api.github.com/repos/garden-io/garden/pulls/430"}},"in_reply_to_id":240126048},"pull_request":{"url":"https://api.github.com/repos/garden-io/garden/pulls/430","id":237228341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjI4MzQx","html_url":"https://github.com/garden-io/garden/pull/430","diff_url":"https://github.com/garden-io/garden/pull/430.diff","patch_url":"https://github.com/garden-io/garden/pull/430.patch","issue_url":"https://api.github.com/repos/garden-io/garden/issues/430","number":430,"state":"open","locked":false,"title":"refactor(k8s): minor change to speed up container deploys","user":{"login":"edvald","id":155684,"node_id":"MDQ6VXNlcjE1NTY4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/155684?v=4","gravatar_id":"","url":"https://api.github.com/users/edvald","html_url":"https://github.com/edvald","followers_url":"https://api.github.com/users/edvald/followers","following_url":"https://api.github.com/users/edvald/following{/other_user}","gists_url":"https://api.github.com/users/edvald/gists{/gist_id}","starred_url":"https://api.github.com/users/edvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvald/subscriptions","organizations_url":"https://api.github.com/users/edvald/orgs","repos_url":"https://api.github.com/users/edvald/repos","events_url":"https://api.github.com/users/edvald/events{/privacy}","received_events_url":"https://api.github.com/users/edvald/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-10T08:01:37Z","updated_at":"2018-12-10T21:11:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebdf3eda20a3d1dc812f600425fd758e9c71f522","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/garden-io/garden/pulls/430/commits","review_comments_url":"https://api.github.com/repos/garden-io/garden/pulls/430/comments","review_comment_url":"https://api.github.com/repos/garden-io/garden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/garden-io/garden/issues/430/comments","statuses_url":"https://api.github.com/repos/garden-io/garden/statuses/dd0265177d87b1638e0b4b1abc5919073cb16159","head":{"label":"garden-io:faster-redeploy","ref":"faster-redeploy","sha":"dd0265177d87b1638e0b4b1abc5919073cb16159","user":{"login":"garden-io","id":34721769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIxNzY5","avatar_url":"https://avatars1.githubusercontent.com/u/34721769?v=4","gravatar_id":"","url":"https://api.github.com/users/garden-io","html_url":"https://github.com/garden-io","followers_url":"https://api.github.com/users/garden-io/followers","following_url":"https://api.github.com/users/garden-io/following{/other_user}","gists_url":"https://api.github.com/users/garden-io/gists{/gist_id}","starred_url":"https://api.github.com/users/garden-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garden-io/subscriptions","organizations_url":"https://api.github.com/users/garden-io/orgs","repos_url":"https://api.github.com/users/garden-io/repos","events_url":"https://api.github.com/users/garden-io/events{/privacy}","received_events_url":"https://api.github.com/users/garden-io/received_events","type":"Organization","site_admin":false},"repo":{"id":112892985,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4OTI5ODU=","name":"garden","full_name":"garden-io/garden","private":false,"owner":{"login":"garden-io","id":34721769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIxNzY5","avatar_url":"https://avatars1.githubusercontent.com/u/34721769?v=4","gravatar_id":"","url":"https://api.github.com/users/garden-io","html_url":"https://github.com/garden-io","followers_url":"https://api.github.com/users/garden-io/followers","following_url":"https://api.github.com/users/garden-io/following{/other_user}","gists_url":"https://api.github.com/users/garden-io/gists{/gist_id}","starred_url":"https://api.github.com/users/garden-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garden-io/subscriptions","organizations_url":"https://api.github.com/users/garden-io/orgs","repos_url":"https://api.github.com/users/garden-io/repos","events_url":"https://api.github.com/users/garden-io/events{/privacy}","received_events_url":"https://api.github.com/users/garden-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/garden-io/garden","description":"Development engine for Kubernetes, containers and serverless functions.","fork":false,"url":"https://api.github.com/repos/garden-io/garden","forks_url":"https://api.github.com/repos/garden-io/garden/forks","keys_url":"https://api.github.com/repos/garden-io/garden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garden-io/garden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garden-io/garden/teams","hooks_url":"https://api.github.com/repos/garden-io/garden/hooks","issue_events_url":"https://api.github.com/repos/garden-io/garden/issues/events{/number}","events_url":"https://api.github.com/repos/garden-io/garden/events","assignees_url":"https://api.github.com/repos/garden-io/garden/assignees{/user}","branches_url":"https://api.github.com/repos/garden-io/garden/branches{/branch}","tags_url":"https://api.github.com/repos/garden-io/garden/tags","blobs_url":"https://api.github.com/repos/garden-io/garden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garden-io/garden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garden-io/garden/git/refs{/sha}","trees_url":"https://api.github.com/repos/garden-io/garden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garden-io/garden/statuses/{sha}","languages_url":"https://api.github.com/repos/garden-io/garden/languages","stargazers_url":"https://api.github.com/repos/garden-io/garden/stargazers","contributors_url":"https://api.github.com/repos/garden-io/garden/contributors","subscribers_url":"https://api.github.com/repos/garden-io/garden/subscribers","subscription_url":"https://api.github.com/repos/garden-io/garden/subscription","commits_url":"https://api.github.com/repos/garden-io/garden/commits{/sha}","git_commits_url":"https://api.github.com/repos/garden-io/garden/git/commits{/sha}","comments_url":"https://api.github.com/repos/garden-io/garden/comments{/number}","issue_comment_url":"https://api.github.com/repos/garden-io/garden/issues/comments{/number}","contents_url":"https://api.github.com/repos/garden-io/garden/contents/{+path}","compare_url":"https://api.github.com/repos/garden-io/garden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garden-io/garden/merges","archive_url":"https://api.github.com/repos/garden-io/garden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garden-io/garden/downloads","issues_url":"https://api.github.com/repos/garden-io/garden/issues{/number}","pulls_url":"https://api.github.com/repos/garden-io/garden/pulls{/number}","milestones_url":"https://api.github.com/repos/garden-io/garden/milestones{/number}","notifications_url":"https://api.github.com/repos/garden-io/garden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garden-io/garden/labels{/name}","releases_url":"https://api.github.com/repos/garden-io/garden/releases{/id}","deployments_url":"https://api.github.com/repos/garden-io/garden/deployments","created_at":"2017-12-03T02:10:59Z","updated_at":"2018-12-10T18:36:11Z","pushed_at":"2018-12-10T21:08:57Z","git_url":"git://github.com/garden-io/garden.git","ssh_url":"git@github.com:garden-io/garden.git","clone_url":"https://github.com/garden-io/garden.git","svn_url":"https://github.com/garden-io/garden","homepage":"https://garden.io","size":7388,"stargazers_count":79,"watchers_count":79,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":6,"open_issues":44,"watchers":79,"default_branch":"master"}},"base":{"label":"garden-io:master","ref":"master","sha":"39f1c42ef4ac3a2eeeb60672abe9a2afb552177f","user":{"login":"garden-io","id":34721769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIxNzY5","avatar_url":"https://avatars1.githubusercontent.com/u/34721769?v=4","gravatar_id":"","url":"https://api.github.com/users/garden-io","html_url":"https://github.com/garden-io","followers_url":"https://api.github.com/users/garden-io/followers","following_url":"https://api.github.com/users/garden-io/following{/other_user}","gists_url":"https://api.github.com/users/garden-io/gists{/gist_id}","starred_url":"https://api.github.com/users/garden-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garden-io/subscriptions","organizations_url":"https://api.github.com/users/garden-io/orgs","repos_url":"https://api.github.com/users/garden-io/repos","events_url":"https://api.github.com/users/garden-io/events{/privacy}","received_events_url":"https://api.github.com/users/garden-io/received_events","type":"Organization","site_admin":false},"repo":{"id":112892985,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4OTI5ODU=","name":"garden","full_name":"garden-io/garden","private":false,"owner":{"login":"garden-io","id":34721769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIxNzY5","avatar_url":"https://avatars1.githubusercontent.com/u/34721769?v=4","gravatar_id":"","url":"https://api.github.com/users/garden-io","html_url":"https://github.com/garden-io","followers_url":"https://api.github.com/users/garden-io/followers","following_url":"https://api.github.com/users/garden-io/following{/other_user}","gists_url":"https://api.github.com/users/garden-io/gists{/gist_id}","starred_url":"https://api.github.com/users/garden-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garden-io/subscriptions","organizations_url":"https://api.github.com/users/garden-io/orgs","repos_url":"https://api.github.com/users/garden-io/repos","events_url":"https://api.github.com/users/garden-io/events{/privacy}","received_events_url":"https://api.github.com/users/garden-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/garden-io/garden","description":"Development engine for Kubernetes, containers and serverless functions.","fork":false,"url":"https://api.github.com/repos/garden-io/garden","forks_url":"https://api.github.com/repos/garden-io/garden/forks","keys_url":"https://api.github.com/repos/garden-io/garden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garden-io/garden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garden-io/garden/teams","hooks_url":"https://api.github.com/repos/garden-io/garden/hooks","issue_events_url":"https://api.github.com/repos/garden-io/garden/issues/events{/number}","events_url":"https://api.github.com/repos/garden-io/garden/events","assignees_url":"https://api.github.com/repos/garden-io/garden/assignees{/user}","branches_url":"https://api.github.com/repos/garden-io/garden/branches{/branch}","tags_url":"https://api.github.com/repos/garden-io/garden/tags","blobs_url":"https://api.github.com/repos/garden-io/garden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garden-io/garden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garden-io/garden/git/refs{/sha}","trees_url":"https://api.github.com/repos/garden-io/garden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garden-io/garden/statuses/{sha}","languages_url":"https://api.github.com/repos/garden-io/garden/languages","stargazers_url":"https://api.github.com/repos/garden-io/garden/stargazers","contributors_url":"https://api.github.com/repos/garden-io/garden/contributors","subscribers_url":"https://api.github.com/repos/garden-io/garden/subscribers","subscription_url":"https://api.github.com/repos/garden-io/garden/subscription","commits_url":"https://api.github.com/repos/garden-io/garden/commits{/sha}","git_commits_url":"https://api.github.com/repos/garden-io/garden/git/commits{/sha}","comments_url":"https://api.github.com/repos/garden-io/garden/comments{/number}","issue_comment_url":"https://api.github.com/repos/garden-io/garden/issues/comments{/number}","contents_url":"https://api.github.com/repos/garden-io/garden/contents/{+path}","compare_url":"https://api.github.com/repos/garden-io/garden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garden-io/garden/merges","archive_url":"https://api.github.com/repos/garden-io/garden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garden-io/garden/downloads","issues_url":"https://api.github.com/repos/garden-io/garden/issues{/number}","pulls_url":"https://api.github.com/repos/garden-io/garden/pulls{/number}","milestones_url":"https://api.github.com/repos/garden-io/garden/milestones{/number}","notifications_url":"https://api.github.com/repos/garden-io/garden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garden-io/garden/labels{/name}","releases_url":"https://api.github.com/repos/garden-io/garden/releases{/id}","deployments_url":"https://api.github.com/repos/garden-io/garden/deployments","created_at":"2017-12-03T02:10:59Z","updated_at":"2018-12-10T18:36:11Z","pushed_at":"2018-12-10T21:08:57Z","git_url":"git://github.com/garden-io/garden.git","ssh_url":"git@github.com:garden-io/garden.git","clone_url":"https://github.com/garden-io/garden.git","svn_url":"https://github.com/garden-io/garden","homepage":"https://garden.io","size":7388,"stargazers_count":79,"watchers_count":79,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":6,"open_issues":44,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/garden-io/garden/pulls/430"},"html":{"href":"https://github.com/garden-io/garden/pull/430"},"issue":{"href":"https://api.github.com/repos/garden-io/garden/issues/430"},"comments":{"href":"https://api.github.com/repos/garden-io/garden/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/garden-io/garden/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/garden-io/garden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/garden-io/garden/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/garden-io/garden/statuses/dd0265177d87b1638e0b4b1abc5919073cb16159"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"edvald"}}