{"action":"closed","number":20837,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20837","id":189195124,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MTk1MTI0","html_url":"https://github.com/nodejs/node/pull/20837","diff_url":"https://github.com/nodejs/node/pull/20837.diff","patch_url":"https://github.com/nodejs/node/pull/20837.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20837","number":20837,"state":"closed","locked":false,"title":"doc: discourage util.inspect.defaultOptions usage","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"Changing the default options is often a bad idea because it has\r\nimpact on the whole application and not only on a specific controlled\r\npart.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-05-19T16:18:11Z","updated_at":"2018-06-25T00:36:54Z","closed_at":"2018-06-25T00:36:54Z","merged_at":null,"merge_commit_sha":"c6a11124a61b6708d90effedb1332cecb8761260","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":155267446,"node_id":"MDU6TGFiZWwxNTUyNjc0NDY=","url":"https://api.github.com/repos/nodejs/node/labels/util","name":"util","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20837/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20837/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20837/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ba82580980a4ab338cfaa9058d9effa28cab533f","head":{"label":"BridgeAR:discourage-default-options","ref":"discourage-default-options","sha":"ba82580980a4ab338cfaa9058d9effa28cab533f","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":51107611,"node_id":"MDEwOlJlcG9zaXRvcnk1MTEwNzYxMQ==","name":"node","full_name":"BridgeAR/node","owner":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BridgeAR/node","forks_url":"https://api.github.com/repos/BridgeAR/node/forks","keys_url":"https://api.github.com/repos/BridgeAR/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/node/teams","hooks_url":"https://api.github.com/repos/BridgeAR/node/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/node/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/node/events","assignees_url":"https://api.github.com/repos/BridgeAR/node/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/node/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/node/tags","blobs_url":"https://api.github.com/repos/BridgeAR/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/node/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/node/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/node/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/node/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/node/subscription","commits_url":"https://api.github.com/repos/BridgeAR/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/node/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/node/merges","archive_url":"https://api.github.com/repos/BridgeAR/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/node/downloads","issues_url":"https://api.github.com/repos/BridgeAR/node/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/node/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/node/releases{/id}","deployments_url":"https://api.github.com/repos/BridgeAR/node/deployments","created_at":"2016-02-04T21:41:27Z","updated_at":"2018-06-11T01:32:11Z","pushed_at":"2018-06-25T00:23:21Z","git_url":"git://github.com/BridgeAR/node.git","ssh_url":"git@github.com:BridgeAR/node.git","clone_url":"https://github.com/BridgeAR/node.git","svn_url":"https://github.com/BridgeAR/node","homepage":"https://nodejs.org","size":364981,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"baadc7ade3184560c5fbffe0be6c2446541936f5","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-06-24T23:39:19Z","pushed_at":"2018-06-25T00:25:47Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":387758,"stargazers_count":50663,"watchers_count":50663,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10623,"mirror_url":null,"archived":false,"open_issues_count":770,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10623,"open_issues":770,"watchers":50663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20837"},"html":{"href":"https://github.com/nodejs/node/pull/20837"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20837"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20837/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20837/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20837/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ba82580980a4ab338cfaa9058d9effa28cab533f"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"BridgeAR"}}