{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/212663061","pull_request_review_id":149346794,"id":212663061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY2MzA2MQ==","diff_hunk":"@@ -283,6 +284,22 @@ protected QueryTransformer groupReplacementText(String ... text) {\n             return this;\n         }\n \n+        /** Specifies whether or not, when replacing groups within the whole\n+         *  match (see \"groupReplacementText\" above), to replace all instances\n+         *  of each group, rather than just the first instance of each group;\n+         *  default is <b>false</b>. */\n+        protected QueryTransformer groupReplaceAll(boolean groupReplaceAll) {\n+            this.m_groupReplaceAll = groupReplaceAll;","path":"src/frontend/org/voltdb/NonVoltDBBackend.java","position":17,"original_position":17,"commit_id":"206a31d4fae75c1ce8773af52ebba603034bda59","original_commit_id":"206a31d4fae75c1ce8773af52ebba603034bda59","user":{"login":"johnTcrawford","id":8029298,"node_id":"MDQ6VXNlcjgwMjkyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8029298?v=4","gravatar_id":"","url":"https://api.github.com/users/johnTcrawford","html_url":"https://github.com/johnTcrawford","followers_url":"https://api.github.com/users/johnTcrawford/followers","following_url":"https://api.github.com/users/johnTcrawford/following{/other_user}","gists_url":"https://api.github.com/users/johnTcrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/johnTcrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnTcrawford/subscriptions","organizations_url":"https://api.github.com/users/johnTcrawford/orgs","repos_url":"https://api.github.com/users/johnTcrawford/repos","events_url":"https://api.github.com/users/johnTcrawford/events{/privacy}","received_events_url":"https://api.github.com/users/johnTcrawford/received_events","type":"User","site_admin":false},"body":"Thanks. 'this.' is indeed redundant, but seems clearer to me. As for NonVoltDBBackend.java (& its subclasses), Chris used to say that I probably ought to replace all this Regex stuff with ANTLR (or something similar), which is probably true, but a big job. Perhaps some Innovation Week I'll take a crack at it.","created_at":"2018-08-24T15:18:12Z","updated_at":"2018-08-24T15:18:13Z","html_url":"https://github.com/VoltDB/voltdb/pull/5553#discussion_r212663061","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/212663061"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/5553#discussion_r212663061"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553"}},"in_reply_to_id":212425512},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553","id":210241521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjQxNTIx","html_url":"https://github.com/VoltDB/voltdb/pull/5553","diff_url":"https://github.com/VoltDB/voltdb/pull/5553.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/5553.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/5553","number":5553,"state":"open","locked":false,"title":"Eng 14166 sqlcov starts w","user":{"login":"johnTcrawford","id":8029298,"node_id":"MDQ6VXNlcjgwMjkyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8029298?v=4","gravatar_id":"","url":"https://api.github.com/users/johnTcrawford","html_url":"https://github.com/johnTcrawford","followers_url":"https://api.github.com/users/johnTcrawford/followers","following_url":"https://api.github.com/users/johnTcrawford/following{/other_user}","gists_url":"https://api.github.com/users/johnTcrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/johnTcrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnTcrawford/subscriptions","organizations_url":"https://api.github.com/users/johnTcrawford/orgs","repos_url":"https://api.github.com/users/johnTcrawford/repos","events_url":"https://api.github.com/users/johnTcrawford/events{/privacy}","received_events_url":"https://api.github.com/users/johnTcrawford/received_events","type":"User","site_admin":false},"body":"ENG-14166: added tests of STARTS WITH to SqlCoverage (in the existing advanced-strings and new advanced-starts-with test suites, the latter running only against PostgreSQL); and a new QueryTransformer that converts VoltDB STARTS WITH clauses into equivalent PostgreSQL LIKE clauses; also improved LIKE tests; improved debugging of QueryTransformers, added a new groupReplaceAll (boolean) parameter, tweaked the handling of special characters like '\\' and '$', and the handling of group name substitutions; and tweaked start_postgresql.sh to ensure that PostgreSQL uses UTF-8 encoding (which it already was on Jenkins machines, but not on my Mac).","created_at":"2018-08-22T19:36:20Z","updated_at":"2018-08-24T15:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"966bd06d70e2e73dd339ade43ddcf99322c56b93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":999183728,"node_id":"MDU6TGFiZWw5OTkxODM3Mjg=","url":"https://api.github.com/repos/VoltDB/voltdb/labels/SQL%20team","name":"SQL team","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/5553/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/206a31d4fae75c1ce8773af52ebba603034bda59","head":{"label":"VoltDB:ENG-14166-sqlcov-starts-w","ref":"ENG-14166-sqlcov-starts-w","sha":"206a31d4fae75c1ce8773af52ebba603034bda59","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2018-08-24T12:08:21Z","pushed_at":"2018-08-24T15:09:29Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":529344,"stargazers_count":1214,"watchers_count":1214,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":335,"open_issues":75,"watchers":1214,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"547abca25497d4fe1d98a0845bcd1fd3cf051627","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2018-08-24T12:08:21Z","pushed_at":"2018-08-24T15:09:29Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":529344,"stargazers_count":1214,"watchers_count":1214,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":335,"open_issues":75,"watchers":1214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/5553"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/5553"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/5553/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/5553/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/206a31d4fae75c1ce8773af52ebba603034bda59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnTcrawford"}}