{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/6964","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/6964/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/6964/comments","events_url":"https://api.github.com/repos/helm/charts/issues/6964/events","html_url":"https://github.com/helm/charts/pull/6964","id":347157918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODQ4Mjcz","number":6964,"title":"[stable/cockroachdb] Make chart work with --wait flag on helm install","user":{"login":"a-robinson","id":7085343,"node_id":"MDQ6VXNlcjcwODUzNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/helm/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-02T20:14:02Z","updated_at":"2018-08-03T16:14:41Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6964","html_url":"https://github.com/helm/charts/pull/6964","diff_url":"https://github.com/helm/charts/pull/6964.diff","patch_url":"https://github.com/helm/charts/pull/6964.patch"},"body":"We had a deadlock of sorts. --wait waits until all pods are ready.\r\npostinstall hooks don't run until after --wait is done waiting. The pods\r\nwon't be ready until the `init` job runs, which was a postinstall hook.\r\n\r\nThis gets around that by making the init command run as part of the\r\nchart rather than as a postinstall hook. I added a bash retry loop for\r\nthe init command to get around the lack of ability to configure pod\r\nrestart backoffs in Kubernetes.\r\n\r\n----------------\r\n\r\nI expect this to fix the CI failures that have been blocking cockroachdb chart PRs lately (e.g. https://github.com/helm/charts/pull/6099)."},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/410302721","html_url":"https://github.com/helm/charts/pull/6964#issuecomment-410302721","issue_url":"https://api.github.com/repos/helm/charts/issues/6964","id":410302721,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDMwMjcyMQ==","user":{"login":"a-robinson","id":7085343,"node_id":"MDQ6VXNlcjcwODUzNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T16:14:41Z","updated_at":"2018-08-03T16:14:41Z","author_association":"COLLABORATOR","body":"And indeed this has fixed the CI tests."}}
{"actor":{"display_login":"a-robinson"}}