{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/390","repository_url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion","labels_url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/390/comments","events_url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/390/events","html_url":"https://github.com/ipfs-shipyard/ipfs-companion/issues/390","id":298936837,"number":390,"title":"Issue with standard --fix","user":{"login":"alanshaw","id":152863,"avatar_url":"https://avatars1.githubusercontent.com/u/152863?v=4","gravatar_id":"","url":"https://api.github.com/users/alanshaw","html_url":"https://github.com/alanshaw","followers_url":"https://api.github.com/users/alanshaw/followers","following_url":"https://api.github.com/users/alanshaw/following{/other_user}","gists_url":"https://api.github.com/users/alanshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/alanshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanshaw/subscriptions","organizations_url":"https://api.github.com/users/alanshaw/orgs","repos_url":"https://api.github.com/users/alanshaw/repos","events_url":"https://api.github.com/users/alanshaw/events{/privacy}","received_events_url":"https://api.github.com/users/alanshaw/received_events","type":"User","site_admin":false},"labels":[{"id":190642370,"url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/labels/discussion","name":"discussion","color":"eeeeee","default":false},{"id":193343054,"url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/labels/maintenance","name":"maintenance","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-21T11:38:14Z","updated_at":"2018-02-22T12:10:58Z","closed_at":null,"author_association":"MEMBER","body":"`npm run lint:standard` calls `standard --fix`. This is surprising when the pre-push hook runs this, pushes to your branch and leaves your workspace with changes.\r\n\r\nI vote we just run `standard` without `--fix` in `npm run lint:standard` and leave it to the developer to call `npx standard --fix` if they want standard to auto fix the errors."},"comment":{"url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/comments/367661858","html_url":"https://github.com/ipfs-shipyard/ipfs-companion/issues/390#issuecomment-367661858","issue_url":"https://api.github.com/repos/ipfs-shipyard/ipfs-companion/issues/390","id":367661858,"user":{"login":"alanshaw","id":152863,"avatar_url":"https://avatars1.githubusercontent.com/u/152863?v=4","gravatar_id":"","url":"https://api.github.com/users/alanshaw","html_url":"https://github.com/alanshaw","followers_url":"https://api.github.com/users/alanshaw/followers","following_url":"https://api.github.com/users/alanshaw/following{/other_user}","gists_url":"https://api.github.com/users/alanshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/alanshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanshaw/subscriptions","organizations_url":"https://api.github.com/users/alanshaw/orgs","repos_url":"https://api.github.com/users/alanshaw/repos","events_url":"https://api.github.com/users/alanshaw/events{/privacy}","received_events_url":"https://api.github.com/users/alanshaw/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T12:10:58Z","updated_at":"2018-02-22T12:10:58Z","author_association":"MEMBER","body":"I think it's still surprising. If I `npm run lint`, I have to know in advance that the \"fix\" feature exists and that it might alter my files when the command is run.\r\n\r\nI'd be ok with adding a `lint:standard:fix` script that doesn't get run by the `lint` script by default?\r\n\r\nTyping `npm run lint:standard:fix` is more verbose than `npx standard --fix` so I didn't originally suggest it."}}
{"actor":{"display_login":"alanshaw"}}