{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/242646776","pull_request_review_id":186208835,"id":242646776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY0Njc3Ng==","diff_hunk":"@@ -6,7 +6,7 @@\n         \"name\": \"exit\",\n         \"image\": \"127.0.0.1:51670/ubuntu:latest\",\n         \"cpu\": 100,\n-        \"command\":  [ \"sh\", \"-c\", \"hostname | grep \\\"ip-[0-9]*-[0-9]*-[0-9]*-[0-9]*.*.compute.internal\\\"; if [ $? -eq 0 ]; then exit 0; else exit 1; fi\" ],\n+        \"command\":  [ \"sh\", \"-c\", \"hostname | grep \\\"ip-[0-9]*-[0-9]*-[0-9]*-[0-9]*.*.internal\\\"; if [ $? -eq 0 ]; then exit 0; else exit 1; fi\" ],","path":"agent/functional_tests/testdata/taskdefinitions/hostname-awsvpc/task-definition.json","position":5,"original_position":5,"commit_id":"5a527c758e54c7126ccb772be2c437311a1e6bbf","original_commit_id":"5a527c758e54c7126ccb772be2c437311a1e6bbf","user":{"login":"jahkeup","id":1139752,"node_id":"MDQ6VXNlcjExMzk3NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1139752?v=4","gravatar_id":"","url":"https://api.github.com/users/jahkeup","html_url":"https://github.com/jahkeup","followers_url":"https://api.github.com/users/jahkeup/followers","following_url":"https://api.github.com/users/jahkeup/following{/other_user}","gists_url":"https://api.github.com/users/jahkeup/gists{/gist_id}","starred_url":"https://api.github.com/users/jahkeup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahkeup/subscriptions","organizations_url":"https://api.github.com/users/jahkeup/orgs","repos_url":"https://api.github.com/users/jahkeup/repos","events_url":"https://api.github.com/users/jahkeup/events{/privacy}","received_events_url":"https://api.github.com/users/jahkeup/received_events","type":"User","site_admin":false},"body":"You could use single quotes here to avoid having to escape the double quote.","created_at":"2018-12-18T18:12:12Z","updated_at":"2018-12-18T18:12:12Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1748#discussion_r242646776","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/242646776"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1748#discussion_r242646776"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748","id":239338057,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzM4MDU3","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1748","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1748.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1748.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1748","number":1748,"state":"open","locked":false,"title":"Updating a functional test","user":{"login":"petderek","id":1487156,"node_id":"MDQ6VXNlcjE0ODcxNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false},"body":"Its possible to get an internal IP address that looks like this:\r\n\r\n```\r\nip-10-0-1-1.ec2.internal\r\n```\r\n\r\n... which will completely fill the old regex check.\r\n\r\n### Licensing\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-12-18T01:35:39Z","updated_at":"2018-12-18T18:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1567f70f8e8e495429118b664a7f3f4145e7276","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1748/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/5a527c758e54c7126ccb772be2c437311a1e6bbf","head":{"label":"aws:petderek-fix-functional-test","ref":"petderek-fix-functional-test","sha":"5a527c758e54c7126ccb772be2c437311a1e6bbf","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"node_id":"MDEwOlJlcG9zaXRvcnkyNzU1MTc3NA==","name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon Elastic Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2018-12-16T12:57:55Z","pushed_at":"2018-12-18T01:59:02Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":32871,"stargazers_count":1399,"watchers_count":1399,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":370,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":370,"open_issues":113,"watchers":1399,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"421da2b75e9a958820d9e66bc1e865b4fd854f9f","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"node_id":"MDEwOlJlcG9zaXRvcnkyNzU1MTc3NA==","name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon Elastic Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2018-12-16T12:57:55Z","pushed_at":"2018-12-18T01:59:02Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":32871,"stargazers_count":1399,"watchers_count":1399,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":370,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":370,"open_issues":113,"watchers":1399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1748"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1748"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1748/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1748/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/5a527c758e54c7126ccb772be2c437311a1e6bbf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jahkeup"}}