{"action":"closed","issue":{"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/2286","repository_url":"https://api.github.com/repos/thewca/worldcubeassociation.org","labels_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/2286/labels{/name}","comments_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/2286/comments","events_url":"https://api.github.com/repos/thewca/worldcubeassociation.org/issues/2286/events","html_url":"https://github.com/thewca/worldcubeassociation.org/issues/2286","id":282238133,"number":2286,"title":"import_persons.php basically only uses names when importing data","user":{"login":"jfly","id":277474,"avatar_url":"https://avatars1.githubusercontent.com/u/277474?v=4","gravatar_id":"","url":"https://api.github.com/users/jfly","html_url":"https://github.com/jfly","followers_url":"https://api.github.com/users/jfly/followers","following_url":"https://api.github.com/users/jfly/following{/other_user}","gists_url":"https://api.github.com/users/jfly/gists{/gist_id}","starred_url":"https://api.github.com/users/jfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfly/subscriptions","organizations_url":"https://api.github.com/users/jfly/orgs","repos_url":"https://api.github.com/users/jfly/repos","events_url":"https://api.github.com/users/jfly/events{/privacy}","received_events_url":"https://api.github.com/users/jfly/received_events","type":"User","site_admin":false},"labels":[{"id":201145927,"url":"https://api.github.com/repos/thewca/worldcubeassociation.org/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"Baiqiang","id":2390434,"avatar_url":"https://avatars3.githubusercontent.com/u/2390434?v=4","gravatar_id":"","url":"https://api.github.com/users/Baiqiang","html_url":"https://github.com/Baiqiang","followers_url":"https://api.github.com/users/Baiqiang/followers","following_url":"https://api.github.com/users/Baiqiang/following{/other_user}","gists_url":"https://api.github.com/users/Baiqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/Baiqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baiqiang/subscriptions","organizations_url":"https://api.github.com/users/Baiqiang/orgs","repos_url":"https://api.github.com/users/Baiqiang/repos","events_url":"https://api.github.com/users/Baiqiang/events{/privacy}","received_events_url":"https://api.github.com/users/Baiqiang/received_events","type":"User","site_admin":false},"assignees":[{"login":"Baiqiang","id":2390434,"avatar_url":"https://avatars3.githubusercontent.com/u/2390434?v=4","gravatar_id":"","url":"https://api.github.com/users/Baiqiang","html_url":"https://github.com/Baiqiang","followers_url":"https://api.github.com/users/Baiqiang/followers","following_url":"https://api.github.com/users/Baiqiang/following{/other_user}","gists_url":"https://api.github.com/users/Baiqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/Baiqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baiqiang/subscriptions","organizations_url":"https://api.github.com/users/Baiqiang/orgs","repos_url":"https://api.github.com/users/Baiqiang/repos","events_url":"https://api.github.com/users/Baiqiang/events{/privacy}","received_events_url":"https://api.github.com/users/Baiqiang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-12-14T21:03:50Z","updated_at":"2018-02-08T11:36:41Z","closed_at":"2018-02-08T11:36:41Z","author_association":"OWNER","body":"See the where condition here: https://github.com/thewca/worldcubeassociation.org/blob/abc382dbcd338bd83c599b1640a8e005ac042305/webroot/results/admin/scripts/import_persons.php#L33-L34\r\n\r\nIt's only matching on `name`, `countryId`, and is restricting the search to people who competed in this particular competition.\r\n\r\nWe run `import_persons.php` *after* running `persons_finish_unfinished.php`, so it should be possible to match on WCA ID here. In order for this to be possible, we'll need to update `persons_finish_unfinished` to update the `InboxPersons` as well as the `Persons` and `Results` tables here:\r\n\r\nhttps://github.com/thewca/worldcubeassociation.org/blob/abc382dbcd338bd83c599b1640a8e005ac042305/webroot/results/admin/persons_finish_unfinished_ACTION.php#L58-L62"}}
{"actor":{"display_login":"Baiqiang"}}