{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57","id":217464192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDY0MTky","html_url":"https://github.com/Borvik/vscode-postgres/pull/57","diff_url":"https://github.com/Borvik/vscode-postgres/pull/57.diff","patch_url":"https://github.com/Borvik/vscode-postgres/pull/57.patch","issue_url":"https://api.github.com/repos/Borvik/vscode-postgres/issues/57","number":57,"state":"open","locked":false,"title":"only query keytar if the connection has a password","user":{"login":"SWW13","id":1280142,"node_id":"MDQ6VXNlcjEyODAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1280142?v=4","gravatar_id":"","url":"https://api.github.com/users/SWW13","html_url":"https://github.com/SWW13","followers_url":"https://api.github.com/users/SWW13/followers","following_url":"https://api.github.com/users/SWW13/following{/other_user}","gists_url":"https://api.github.com/users/SWW13/gists{/gist_id}","starred_url":"https://api.github.com/users/SWW13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SWW13/subscriptions","organizations_url":"https://api.github.com/users/SWW13/orgs","repos_url":"https://api.github.com/users/SWW13/repos","events_url":"https://api.github.com/users/SWW13/events{/privacy}","received_events_url":"https://api.github.com/users/SWW13/received_events","type":"User","site_admin":false},"body":"I'm connecting without a password with my user and ran in the same problem as #38.\r\n\r\n`keytar` is queried for every connection even when there was no password set.\r\nSo this PR removes the need for a working `keytar` service when no password is set without storing plain passwords.","created_at":"2018-09-22T15:56:22Z","updated_at":"2018-09-22T15:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57/commits","review_comments_url":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57/comments","review_comment_url":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Borvik/vscode-postgres/issues/57/comments","statuses_url":"https://api.github.com/repos/Borvik/vscode-postgres/statuses/01571ce36430f738d630fc252eebd2419702b862","head":{"label":"SWW13:keytar_optional","ref":"keytar_optional","sha":"01571ce36430f738d630fc252eebd2419702b862","user":{"login":"SWW13","id":1280142,"node_id":"MDQ6VXNlcjEyODAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1280142?v=4","gravatar_id":"","url":"https://api.github.com/users/SWW13","html_url":"https://github.com/SWW13","followers_url":"https://api.github.com/users/SWW13/followers","following_url":"https://api.github.com/users/SWW13/following{/other_user}","gists_url":"https://api.github.com/users/SWW13/gists{/gist_id}","starred_url":"https://api.github.com/users/SWW13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SWW13/subscriptions","organizations_url":"https://api.github.com/users/SWW13/orgs","repos_url":"https://api.github.com/users/SWW13/repos","events_url":"https://api.github.com/users/SWW13/events{/privacy}","received_events_url":"https://api.github.com/users/SWW13/received_events","type":"User","site_admin":false},"repo":{"id":149891616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4OTE2MTY=","name":"vscode-postgres","full_name":"SWW13/vscode-postgres","private":false,"owner":{"login":"SWW13","id":1280142,"node_id":"MDQ6VXNlcjEyODAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1280142?v=4","gravatar_id":"","url":"https://api.github.com/users/SWW13","html_url":"https://github.com/SWW13","followers_url":"https://api.github.com/users/SWW13/followers","following_url":"https://api.github.com/users/SWW13/following{/other_user}","gists_url":"https://api.github.com/users/SWW13/gists{/gist_id}","starred_url":"https://api.github.com/users/SWW13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SWW13/subscriptions","organizations_url":"https://api.github.com/users/SWW13/orgs","repos_url":"https://api.github.com/users/SWW13/repos","events_url":"https://api.github.com/users/SWW13/events{/privacy}","received_events_url":"https://api.github.com/users/SWW13/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SWW13/vscode-postgres","description":"PostgreSQL extension for vscode providing explorer, highlighting, diagnostics, and intellisense","fork":true,"url":"https://api.github.com/repos/SWW13/vscode-postgres","forks_url":"https://api.github.com/repos/SWW13/vscode-postgres/forks","keys_url":"https://api.github.com/repos/SWW13/vscode-postgres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SWW13/vscode-postgres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SWW13/vscode-postgres/teams","hooks_url":"https://api.github.com/repos/SWW13/vscode-postgres/hooks","issue_events_url":"https://api.github.com/repos/SWW13/vscode-postgres/issues/events{/number}","events_url":"https://api.github.com/repos/SWW13/vscode-postgres/events","assignees_url":"https://api.github.com/repos/SWW13/vscode-postgres/assignees{/user}","branches_url":"https://api.github.com/repos/SWW13/vscode-postgres/branches{/branch}","tags_url":"https://api.github.com/repos/SWW13/vscode-postgres/tags","blobs_url":"https://api.github.com/repos/SWW13/vscode-postgres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SWW13/vscode-postgres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SWW13/vscode-postgres/git/refs{/sha}","trees_url":"https://api.github.com/repos/SWW13/vscode-postgres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SWW13/vscode-postgres/statuses/{sha}","languages_url":"https://api.github.com/repos/SWW13/vscode-postgres/languages","stargazers_url":"https://api.github.com/repos/SWW13/vscode-postgres/stargazers","contributors_url":"https://api.github.com/repos/SWW13/vscode-postgres/contributors","subscribers_url":"https://api.github.com/repos/SWW13/vscode-postgres/subscribers","subscription_url":"https://api.github.com/repos/SWW13/vscode-postgres/subscription","commits_url":"https://api.github.com/repos/SWW13/vscode-postgres/commits{/sha}","git_commits_url":"https://api.github.com/repos/SWW13/vscode-postgres/git/commits{/sha}","comments_url":"https://api.github.com/repos/SWW13/vscode-postgres/comments{/number}","issue_comment_url":"https://api.github.com/repos/SWW13/vscode-postgres/issues/comments{/number}","contents_url":"https://api.github.com/repos/SWW13/vscode-postgres/contents/{+path}","compare_url":"https://api.github.com/repos/SWW13/vscode-postgres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SWW13/vscode-postgres/merges","archive_url":"https://api.github.com/repos/SWW13/vscode-postgres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SWW13/vscode-postgres/downloads","issues_url":"https://api.github.com/repos/SWW13/vscode-postgres/issues{/number}","pulls_url":"https://api.github.com/repos/SWW13/vscode-postgres/pulls{/number}","milestones_url":"https://api.github.com/repos/SWW13/vscode-postgres/milestones{/number}","notifications_url":"https://api.github.com/repos/SWW13/vscode-postgres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SWW13/vscode-postgres/labels{/name}","releases_url":"https://api.github.com/repos/SWW13/vscode-postgres/releases{/id}","deployments_url":"https://api.github.com/repos/SWW13/vscode-postgres/deployments","created_at":"2018-09-22T15:50:04Z","updated_at":"2018-09-22T15:50:07Z","pushed_at":"2018-09-22T15:52:13Z","git_url":"git://github.com/SWW13/vscode-postgres.git","ssh_url":"git@github.com:SWW13/vscode-postgres.git","clone_url":"https://github.com/SWW13/vscode-postgres.git","svn_url":"https://github.com/SWW13/vscode-postgres","homepage":"","size":1714,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Borvik:master","ref":"master","sha":"d5065fc474a6d0529b53c52bc6c6e98db9288dd7","user":{"login":"Borvik","id":1764750,"node_id":"MDQ6VXNlcjE3NjQ3NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1764750?v=4","gravatar_id":"","url":"https://api.github.com/users/Borvik","html_url":"https://github.com/Borvik","followers_url":"https://api.github.com/users/Borvik/followers","following_url":"https://api.github.com/users/Borvik/following{/other_user}","gists_url":"https://api.github.com/users/Borvik/gists{/gist_id}","starred_url":"https://api.github.com/users/Borvik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Borvik/subscriptions","organizations_url":"https://api.github.com/users/Borvik/orgs","repos_url":"https://api.github.com/users/Borvik/repos","events_url":"https://api.github.com/users/Borvik/events{/privacy}","received_events_url":"https://api.github.com/users/Borvik/received_events","type":"User","site_admin":false},"repo":{"id":131491904,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0OTE5MDQ=","name":"vscode-postgres","full_name":"Borvik/vscode-postgres","private":false,"owner":{"login":"Borvik","id":1764750,"node_id":"MDQ6VXNlcjE3NjQ3NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1764750?v=4","gravatar_id":"","url":"https://api.github.com/users/Borvik","html_url":"https://github.com/Borvik","followers_url":"https://api.github.com/users/Borvik/followers","following_url":"https://api.github.com/users/Borvik/following{/other_user}","gists_url":"https://api.github.com/users/Borvik/gists{/gist_id}","starred_url":"https://api.github.com/users/Borvik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Borvik/subscriptions","organizations_url":"https://api.github.com/users/Borvik/orgs","repos_url":"https://api.github.com/users/Borvik/repos","events_url":"https://api.github.com/users/Borvik/events{/privacy}","received_events_url":"https://api.github.com/users/Borvik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Borvik/vscode-postgres","description":"PostgreSQL extension for vscode providing explorer, highlighting, diagnostics, and intellisense","fork":false,"url":"https://api.github.com/repos/Borvik/vscode-postgres","forks_url":"https://api.github.com/repos/Borvik/vscode-postgres/forks","keys_url":"https://api.github.com/repos/Borvik/vscode-postgres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Borvik/vscode-postgres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Borvik/vscode-postgres/teams","hooks_url":"https://api.github.com/repos/Borvik/vscode-postgres/hooks","issue_events_url":"https://api.github.com/repos/Borvik/vscode-postgres/issues/events{/number}","events_url":"https://api.github.com/repos/Borvik/vscode-postgres/events","assignees_url":"https://api.github.com/repos/Borvik/vscode-postgres/assignees{/user}","branches_url":"https://api.github.com/repos/Borvik/vscode-postgres/branches{/branch}","tags_url":"https://api.github.com/repos/Borvik/vscode-postgres/tags","blobs_url":"https://api.github.com/repos/Borvik/vscode-postgres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Borvik/vscode-postgres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Borvik/vscode-postgres/git/refs{/sha}","trees_url":"https://api.github.com/repos/Borvik/vscode-postgres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Borvik/vscode-postgres/statuses/{sha}","languages_url":"https://api.github.com/repos/Borvik/vscode-postgres/languages","stargazers_url":"https://api.github.com/repos/Borvik/vscode-postgres/stargazers","contributors_url":"https://api.github.com/repos/Borvik/vscode-postgres/contributors","subscribers_url":"https://api.github.com/repos/Borvik/vscode-postgres/subscribers","subscription_url":"https://api.github.com/repos/Borvik/vscode-postgres/subscription","commits_url":"https://api.github.com/repos/Borvik/vscode-postgres/commits{/sha}","git_commits_url":"https://api.github.com/repos/Borvik/vscode-postgres/git/commits{/sha}","comments_url":"https://api.github.com/repos/Borvik/vscode-postgres/comments{/number}","issue_comment_url":"https://api.github.com/repos/Borvik/vscode-postgres/issues/comments{/number}","contents_url":"https://api.github.com/repos/Borvik/vscode-postgres/contents/{+path}","compare_url":"https://api.github.com/repos/Borvik/vscode-postgres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Borvik/vscode-postgres/merges","archive_url":"https://api.github.com/repos/Borvik/vscode-postgres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Borvik/vscode-postgres/downloads","issues_url":"https://api.github.com/repos/Borvik/vscode-postgres/issues{/number}","pulls_url":"https://api.github.com/repos/Borvik/vscode-postgres/pulls{/number}","milestones_url":"https://api.github.com/repos/Borvik/vscode-postgres/milestones{/number}","notifications_url":"https://api.github.com/repos/Borvik/vscode-postgres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Borvik/vscode-postgres/labels{/name}","releases_url":"https://api.github.com/repos/Borvik/vscode-postgres/releases{/id}","deployments_url":"https://api.github.com/repos/Borvik/vscode-postgres/deployments","created_at":"2018-04-29T12:16:44Z","updated_at":"2018-09-21T05:24:22Z","pushed_at":"2018-09-10T23:14:25Z","git_url":"git://github.com/Borvik/vscode-postgres.git","ssh_url":"git@github.com:Borvik/vscode-postgres.git","clone_url":"https://github.com/Borvik/vscode-postgres.git","svn_url":"https://github.com/Borvik/vscode-postgres","homepage":"","size":1714,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":10,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57"},"html":{"href":"https://github.com/Borvik/vscode-postgres/pull/57"},"issue":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/issues/57"},"comments":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/Borvik/vscode-postgres/statuses/01571ce36430f738d630fc252eebd2419702b862"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"SWW13"}}