{"action":"created","comment":{"url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/comments/234380564","pull_request_review_id":176021535,"id":234380564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDM4MDU2NA==","diff_hunk":"@@ -243,4 +243,70 @@ public void testDrawerPreferencesHideCurrentElement() {\n         assertEquals(1, hidden.size());\n         assertTrue(hidden.contains(DownloadsFragment.TAG));\n     }\n+\n+    @Test\n+    public void testBackButtonBehaviorGoToPage() {\n+        openNavDrawer();\n+        solo.clickOnText(solo.getString(R.string.settings_label));\n+        solo.clickOnText(solo.getString(R.string.user_interface_label));\n+        solo.clickOnText(solo.getString(R.string.pref_back_button_behavior_title));\n+        solo.clickOnText(solo.getString(R.string.back_button_go_to_page));\n+        solo.waitForDialogToOpen();\n+        solo.clickOnText(solo.getString(R.string.subscriptions_label));\n+        solo.clickOnText(solo.getString(R.string.confirm_label));\n+        solo.goBackToActivity(MainActivity.class.getSimpleName());\n+        solo.goBack();\n+        assertEquals(solo.getString(R.string.subscriptions_label), getActionbarTitle());\n+    }\n+\n+    @Test\n+    public void testBackButtonBehaviorOpenDrawer() {\n+        openNavDrawer();\n+        solo.clickOnText(solo.getString(R.string.settings_label));\n+        solo.clickOnText(solo.getString(R.string.user_interface_label));\n+        solo.clickOnText(solo.getString(R.string.pref_back_button_behavior_title));\n+        solo.clickOnText(solo.getString(R.string.back_button_open_drawer));\n+        solo.goBackToActivity(MainActivity.class.getSimpleName());\n+        solo.goBack();\n+        assertTrue(((MainActivity)solo.getCurrentActivity()).isDrawerOpen());\n+    }\n+\n+    @Test\n+    public void testBackButtonBehaviorDoubleTap() {","path":"app/src/androidTest/java/de/test/antennapod/ui/MainActivityTest.java","position":33,"original_position":33,"commit_id":"c2f543ffe4a8f0ceae9ab0b832f055ee023e9637","original_commit_id":"c2f543ffe4a8f0ceae9ab0b832f055ee023e9637","user":{"login":"ByteHamster","id":5811634,"node_id":"MDQ6VXNlcjU4MTE2MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5811634?v=4","gravatar_id":"","url":"https://api.github.com/users/ByteHamster","html_url":"https://github.com/ByteHamster","followers_url":"https://api.github.com/users/ByteHamster/followers","following_url":"https://api.github.com/users/ByteHamster/following{/other_user}","gists_url":"https://api.github.com/users/ByteHamster/gists{/gist_id}","starred_url":"https://api.github.com/users/ByteHamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ByteHamster/subscriptions","organizations_url":"https://api.github.com/users/ByteHamster/orgs","repos_url":"https://api.github.com/users/ByteHamster/repos","events_url":"https://api.github.com/users/ByteHamster/events{/privacy}","received_events_url":"https://api.github.com/users/ByteHamster/received_events","type":"User","site_admin":false},"body":"Nice to see that you have added tests! ","created_at":"2018-11-16T23:53:14Z","updated_at":"2018-11-16T23:54:24Z","html_url":"https://github.com/AntennaPod/AntennaPod/pull/2904#discussion_r234380564","pull_request_url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/comments/234380564"},"html":{"href":"https://github.com/AntennaPod/AntennaPod/pull/2904#discussion_r234380564"},"pull_request":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904"}}},"pull_request":{"url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904","id":230880268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODgwMjY4","html_url":"https://github.com/AntennaPod/AntennaPod/pull/2904","diff_url":"https://github.com/AntennaPod/AntennaPod/pull/2904.diff","patch_url":"https://github.com/AntennaPod/AntennaPod/pull/2904.patch","issue_url":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/2904","number":2904,"state":"open","locked":false,"title":"Add configurable behavior of the back button","user":{"login":"qkolj","id":6667105,"node_id":"MDQ6VXNlcjY2NjcxMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6667105?v=4","gravatar_id":"","url":"https://api.github.com/users/qkolj","html_url":"https://github.com/qkolj","followers_url":"https://api.github.com/users/qkolj/followers","following_url":"https://api.github.com/users/qkolj/following{/other_user}","gists_url":"https://api.github.com/users/qkolj/gists{/gist_id}","starred_url":"https://api.github.com/users/qkolj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkolj/subscriptions","organizations_url":"https://api.github.com/users/qkolj/orgs","repos_url":"https://api.github.com/users/qkolj/repos","events_url":"https://api.github.com/users/qkolj/events{/privacy}","received_events_url":"https://api.github.com/users/qkolj/received_events","type":"User","site_admin":false},"body":"This PR allows users to change how the back button functions. Closes #2196\r\n\r\nPossible choices are following:\r\n\r\n - **Default** - back button functions how it currently functions (closes the app if there is nowhere to go back to)\r\n\r\n- **Go to page** - back button opens chosen page (Queue, Episodes or Subscriptions) and closes the app if you're already on that page\r\n\r\n - **Open navigation drawer** - back button always opens the navigation drawer instead of closing the app\r\n\r\n - **Double tap to exit** - like default, but requires two taps to close the app\r\n\r\n - **Confirm to exit** - like default, but prompts user if they really want to exit\r\n\r\n---\r\n\r\n<img src=\"https://user-images.githubusercontent.com/6667105/48578378-b67e8800-e919-11e8-94fe-436473af4efd.png\" width=128> <img src=\"https://user-images.githubusercontent.com/6667105/48578439-e9288080-e919-11e8-91d3-354f9f081464.png\" width=128> <img src=\"https://user-images.githubusercontent.com/6667105/48578468-fc3b5080-e919-11e8-9fdd-ac030b79fdf6.png\" width=128> <img src=\"https://user-images.githubusercontent.com/6667105/48578485-078e7c00-e91a-11e8-83ad-7ccac03fafba.png\" width=128> <img src=\"https://user-images.githubusercontent.com/6667105/48578512-19701f00-e91a-11e8-9190-f767ead1705c.png\" width=128>\r\n\r\n\r\n","created_at":"2018-11-14T15:38:33Z","updated_at":"2018-11-16T23:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbdb150df5a2c3591f7d75d7a2db7535947823d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904/commits","review_comments_url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904/comments","review_comment_url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/2904/comments","statuses_url":"https://api.github.com/repos/AntennaPod/AntennaPod/statuses/c2f543ffe4a8f0ceae9ab0b832f055ee023e9637","head":{"label":"qkolj:back-button","ref":"back-button","sha":"c2f543ffe4a8f0ceae9ab0b832f055ee023e9637","user":{"login":"qkolj","id":6667105,"node_id":"MDQ6VXNlcjY2NjcxMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6667105?v=4","gravatar_id":"","url":"https://api.github.com/users/qkolj","html_url":"https://github.com/qkolj","followers_url":"https://api.github.com/users/qkolj/followers","following_url":"https://api.github.com/users/qkolj/following{/other_user}","gists_url":"https://api.github.com/users/qkolj/gists{/gist_id}","starred_url":"https://api.github.com/users/qkolj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkolj/subscriptions","organizations_url":"https://api.github.com/users/qkolj/orgs","repos_url":"https://api.github.com/users/qkolj/repos","events_url":"https://api.github.com/users/qkolj/events{/privacy}","received_events_url":"https://api.github.com/users/qkolj/received_events","type":"User","site_admin":false},"repo":{"id":157446984,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0NDY5ODQ=","name":"AntennaPod","full_name":"qkolj/AntennaPod","private":false,"owner":{"login":"qkolj","id":6667105,"node_id":"MDQ6VXNlcjY2NjcxMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6667105?v=4","gravatar_id":"","url":"https://api.github.com/users/qkolj","html_url":"https://github.com/qkolj","followers_url":"https://api.github.com/users/qkolj/followers","following_url":"https://api.github.com/users/qkolj/following{/other_user}","gists_url":"https://api.github.com/users/qkolj/gists{/gist_id}","starred_url":"https://api.github.com/users/qkolj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qkolj/subscriptions","organizations_url":"https://api.github.com/users/qkolj/orgs","repos_url":"https://api.github.com/users/qkolj/repos","events_url":"https://api.github.com/users/qkolj/events{/privacy}","received_events_url":"https://api.github.com/users/qkolj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qkolj/AntennaPod","description":"A podcast manager for Android","fork":true,"url":"https://api.github.com/repos/qkolj/AntennaPod","forks_url":"https://api.github.com/repos/qkolj/AntennaPod/forks","keys_url":"https://api.github.com/repos/qkolj/AntennaPod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qkolj/AntennaPod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qkolj/AntennaPod/teams","hooks_url":"https://api.github.com/repos/qkolj/AntennaPod/hooks","issue_events_url":"https://api.github.com/repos/qkolj/AntennaPod/issues/events{/number}","events_url":"https://api.github.com/repos/qkolj/AntennaPod/events","assignees_url":"https://api.github.com/repos/qkolj/AntennaPod/assignees{/user}","branches_url":"https://api.github.com/repos/qkolj/AntennaPod/branches{/branch}","tags_url":"https://api.github.com/repos/qkolj/AntennaPod/tags","blobs_url":"https://api.github.com/repos/qkolj/AntennaPod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qkolj/AntennaPod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qkolj/AntennaPod/git/refs{/sha}","trees_url":"https://api.github.com/repos/qkolj/AntennaPod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qkolj/AntennaPod/statuses/{sha}","languages_url":"https://api.github.com/repos/qkolj/AntennaPod/languages","stargazers_url":"https://api.github.com/repos/qkolj/AntennaPod/stargazers","contributors_url":"https://api.github.com/repos/qkolj/AntennaPod/contributors","subscribers_url":"https://api.github.com/repos/qkolj/AntennaPod/subscribers","subscription_url":"https://api.github.com/repos/qkolj/AntennaPod/subscription","commits_url":"https://api.github.com/repos/qkolj/AntennaPod/commits{/sha}","git_commits_url":"https://api.github.com/repos/qkolj/AntennaPod/git/commits{/sha}","comments_url":"https://api.github.com/repos/qkolj/AntennaPod/comments{/number}","issue_comment_url":"https://api.github.com/repos/qkolj/AntennaPod/issues/comments{/number}","contents_url":"https://api.github.com/repos/qkolj/AntennaPod/contents/{+path}","compare_url":"https://api.github.com/repos/qkolj/AntennaPod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qkolj/AntennaPod/merges","archive_url":"https://api.github.com/repos/qkolj/AntennaPod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qkolj/AntennaPod/downloads","issues_url":"https://api.github.com/repos/qkolj/AntennaPod/issues{/number}","pulls_url":"https://api.github.com/repos/qkolj/AntennaPod/pulls{/number}","milestones_url":"https://api.github.com/repos/qkolj/AntennaPod/milestones{/number}","notifications_url":"https://api.github.com/repos/qkolj/AntennaPod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qkolj/AntennaPod/labels{/name}","releases_url":"https://api.github.com/repos/qkolj/AntennaPod/releases{/id}","deployments_url":"https://api.github.com/repos/qkolj/AntennaPod/deployments","created_at":"2018-11-13T21:08:01Z","updated_at":"2018-11-13T21:08:06Z","pushed_at":"2018-11-16T17:24:35Z","git_url":"git://github.com/qkolj/AntennaPod.git","ssh_url":"git@github.com:qkolj/AntennaPod.git","clone_url":"https://github.com/qkolj/AntennaPod.git","svn_url":"https://github.com/qkolj/AntennaPod","homepage":"","size":31534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"AntennaPod:develop","ref":"develop","sha":"68b245701e2ff11f23d2bdf1145e8189dc3709ac","user":{"login":"AntennaPod","id":10713470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzEzNDcw","avatar_url":"https://avatars1.githubusercontent.com/u/10713470?v=4","gravatar_id":"","url":"https://api.github.com/users/AntennaPod","html_url":"https://github.com/AntennaPod","followers_url":"https://api.github.com/users/AntennaPod/followers","following_url":"https://api.github.com/users/AntennaPod/following{/other_user}","gists_url":"https://api.github.com/users/AntennaPod/gists{/gist_id}","starred_url":"https://api.github.com/users/AntennaPod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntennaPod/subscriptions","organizations_url":"https://api.github.com/users/AntennaPod/orgs","repos_url":"https://api.github.com/users/AntennaPod/repos","events_url":"https://api.github.com/users/AntennaPod/events{/privacy}","received_events_url":"https://api.github.com/users/AntennaPod/received_events","type":"Organization","site_admin":false},"repo":{"id":5244445,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ0NDQ1","name":"AntennaPod","full_name":"AntennaPod/AntennaPod","private":false,"owner":{"login":"AntennaPod","id":10713470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzEzNDcw","avatar_url":"https://avatars1.githubusercontent.com/u/10713470?v=4","gravatar_id":"","url":"https://api.github.com/users/AntennaPod","html_url":"https://github.com/AntennaPod","followers_url":"https://api.github.com/users/AntennaPod/followers","following_url":"https://api.github.com/users/AntennaPod/following{/other_user}","gists_url":"https://api.github.com/users/AntennaPod/gists{/gist_id}","starred_url":"https://api.github.com/users/AntennaPod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntennaPod/subscriptions","organizations_url":"https://api.github.com/users/AntennaPod/orgs","repos_url":"https://api.github.com/users/AntennaPod/repos","events_url":"https://api.github.com/users/AntennaPod/events{/privacy}","received_events_url":"https://api.github.com/users/AntennaPod/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AntennaPod/AntennaPod","description":"A podcast manager for Android","fork":false,"url":"https://api.github.com/repos/AntennaPod/AntennaPod","forks_url":"https://api.github.com/repos/AntennaPod/AntennaPod/forks","keys_url":"https://api.github.com/repos/AntennaPod/AntennaPod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntennaPod/AntennaPod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntennaPod/AntennaPod/teams","hooks_url":"https://api.github.com/repos/AntennaPod/AntennaPod/hooks","issue_events_url":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/events{/number}","events_url":"https://api.github.com/repos/AntennaPod/AntennaPod/events","assignees_url":"https://api.github.com/repos/AntennaPod/AntennaPod/assignees{/user}","branches_url":"https://api.github.com/repos/AntennaPod/AntennaPod/branches{/branch}","tags_url":"https://api.github.com/repos/AntennaPod/AntennaPod/tags","blobs_url":"https://api.github.com/repos/AntennaPod/AntennaPod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntennaPod/AntennaPod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntennaPod/AntennaPod/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntennaPod/AntennaPod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntennaPod/AntennaPod/statuses/{sha}","languages_url":"https://api.github.com/repos/AntennaPod/AntennaPod/languages","stargazers_url":"https://api.github.com/repos/AntennaPod/AntennaPod/stargazers","contributors_url":"https://api.github.com/repos/AntennaPod/AntennaPod/contributors","subscribers_url":"https://api.github.com/repos/AntennaPod/AntennaPod/subscribers","subscription_url":"https://api.github.com/repos/AntennaPod/AntennaPod/subscription","commits_url":"https://api.github.com/repos/AntennaPod/AntennaPod/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntennaPod/AntennaPod/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntennaPod/AntennaPod/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/comments{/number}","contents_url":"https://api.github.com/repos/AntennaPod/AntennaPod/contents/{+path}","compare_url":"https://api.github.com/repos/AntennaPod/AntennaPod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntennaPod/AntennaPod/merges","archive_url":"https://api.github.com/repos/AntennaPod/AntennaPod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntennaPod/AntennaPod/downloads","issues_url":"https://api.github.com/repos/AntennaPod/AntennaPod/issues{/number}","pulls_url":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls{/number}","milestones_url":"https://api.github.com/repos/AntennaPod/AntennaPod/milestones{/number}","notifications_url":"https://api.github.com/repos/AntennaPod/AntennaPod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntennaPod/AntennaPod/labels{/name}","releases_url":"https://api.github.com/repos/AntennaPod/AntennaPod/releases{/id}","deployments_url":"https://api.github.com/repos/AntennaPod/AntennaPod/deployments","created_at":"2012-07-31T10:25:08Z","updated_at":"2018-11-16T18:26:31Z","pushed_at":"2018-11-16T21:45:24Z","git_url":"git://github.com/AntennaPod/AntennaPod.git","ssh_url":"git@github.com:AntennaPod/AntennaPod.git","clone_url":"https://github.com/AntennaPod/AntennaPod.git","svn_url":"https://github.com/AntennaPod/AntennaPod","homepage":"","size":31653,"stargazers_count":2117,"watchers_count":2117,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":672,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":672,"open_issues":354,"watchers":2117,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904"},"html":{"href":"https://github.com/AntennaPod/AntennaPod/pull/2904"},"issue":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/2904"},"comments":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/issues/2904/comments"},"review_comments":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904/comments"},"review_comment":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/pulls/2904/commits"},"statuses":{"href":"https://api.github.com/repos/AntennaPod/AntennaPod/statuses/c2f543ffe4a8f0ceae9ab0b832f055ee023e9637"}},"author_association":"NONE"}}
{"actor":{"display_login":"ByteHamster"}}