{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/243376634","pull_request_review_id":187131478,"id":243376634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM3NjYzNA==","diff_hunk":"@@ -17,10 +17,12 @@ const std::string CBaseChainParams::REGTEST = \"regtest\";\n \n void SetupChainParamsBaseOptions()\n {\n+    gArgs.AddArg(\"-chain=<chain>\", \"Use the chain <chain> (default: main). Reserved values: main, test, regtest\", false, OptionsCategory::CHAINPARAMS);","path":"src/chainparamsbase.cpp","position":4,"original_position":4,"commit_id":"daf6b9036e7b5f32811e77e5ffebef180a628e08","original_commit_id":"daf6b9036e7b5f32811e77e5ffebef180a628e08","user":{"login":"jtimon","id":1008458,"node_id":"MDQ6VXNlcjEwMDg0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008458?v=4","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"body":"@flack That seems simple and reasonable. @MarcoFalke would that solve your concern?","created_at":"2018-12-20T18:40:14Z","updated_at":"2018-12-20T18:40:15Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8994#discussion_r243376634","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/243376634"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8994#discussion_r243376634"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994"}},"in_reply_to_id":230200450},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994","id":90467073,"node_id":"MDExOlB1bGxSZXF1ZXN0OTA0NjcwNzM=","html_url":"https://github.com/bitcoin/bitcoin/pull/8994","diff_url":"https://github.com/bitcoin/bitcoin/pull/8994.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8994.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8994","number":8994,"state":"open","locked":false,"title":"Testchains: Introduce custom chain whose constructor... ","user":{"login":"jtimon","id":1008458,"node_id":"MDQ6VXNlcjEwMDg0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008458?v=4","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"body":"...reads from runtime params and simplify the creation of partitioned chains by simply generating different gensis block hashes from a given custom name.\r\nDatadir now depends on -chain except for the reserved values.\r\n\r\nDependencies:\r\n\r\n- [x] Use a proper factory for creating chainparams #8855\r\n~~- [ ] Really don't validate genesis block #9102~~\r\n- [x] Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs #9494\r\n- [x] QA: segwit.py: s/find_unspent/find_spendable_utxo/ #11869\r\n- [x] Refactor: One CBaseChainParams should be enough #12128\r\n\r\n Other features:\r\n- [x] Uses a custom chain for all python tests.\r\n- [X] Create new testchains with different genesis hashes at will.\r\n- [X] Load chainparams from ~~separated~~ file or command line. (file left for later, see https://github.com/jtimon/bitcoin/tree/b16-new-testnet-file )\r\n- [X] New chains are neither orange, blue nor green: they're purple and have your custom chain petname shown in the GUI.\r\n- Extra context: some people asked for signed blocks but that's way more disruptive and this is already review-thirsty (see #9177 ).\r\n  ","created_at":"2016-10-22T02:25:25Z","updated_at":"2018-12-20T18:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35fe7e8c15d3f78f092acf9feac80ac7815538f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":192202000,"node_id":"MDU6TGFiZWwxOTIyMDIwMDA=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Consensus","name":"Consensus","color":"009800","default":false},{"id":955867938,"node_id":"MDU6TGFiZWw5NTU4Njc5Mzg=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Needs%20rebase","name":"Needs rebase","color":"cccccc","default":false},{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8994/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/daf6b9036e7b5f32811e77e5ffebef180a628e08","head":{"label":"jtimon:0.13-new-testchain","ref":"0.13-new-testchain","sha":"daf6b9036e7b5f32811e77e5ffebef180a628e08","user":{"login":"jtimon","id":1008458,"node_id":"MDQ6VXNlcjEwMDg0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008458?v=4","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"repo":{"id":17504501,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUwNDUwMQ==","name":"bitcoin","full_name":"jtimon/bitcoin","private":false,"owner":{"login":"jtimon","id":1008458,"node_id":"MDQ6VXNlcjEwMDg0NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008458?v=4","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jtimon/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jtimon/bitcoin","forks_url":"https://api.github.com/repos/jtimon/bitcoin/forks","keys_url":"https://api.github.com/repos/jtimon/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtimon/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtimon/bitcoin/teams","hooks_url":"https://api.github.com/repos/jtimon/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jtimon/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jtimon/bitcoin/events","assignees_url":"https://api.github.com/repos/jtimon/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jtimon/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jtimon/bitcoin/tags","blobs_url":"https://api.github.com/repos/jtimon/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtimon/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtimon/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtimon/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtimon/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jtimon/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jtimon/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jtimon/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jtimon/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jtimon/bitcoin/subscription","commits_url":"https://api.github.com/repos/jtimon/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtimon/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtimon/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtimon/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtimon/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jtimon/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtimon/bitcoin/merges","archive_url":"https://api.github.com/repos/jtimon/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtimon/bitcoin/downloads","issues_url":"https://api.github.com/repos/jtimon/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jtimon/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jtimon/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jtimon/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtimon/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jtimon/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jtimon/bitcoin/deployments","created_at":"2014-03-07T06:02:15Z","updated_at":"2018-12-18T04:51:22Z","pushed_at":"2018-10-17T00:08:52Z","git_url":"git://github.com/jtimon/bitcoin.git","ssh_url":"git@github.com:jtimon/bitcoin.git","clone_url":"https://github.com/jtimon/bitcoin.git","svn_url":"https://github.com/jtimon/bitcoin","homepage":"https://bitcoin.org/en/download","size":106970,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":6,"watchers":3,"default_branch":"0.13-new-testchain"}},"base":{"label":"bitcoin:master","ref":"master","sha":"23419e4c4939fe557e37ec9d17c15c6eb73febc6","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-12-20T17:10:17Z","pushed_at":"2018-12-20T17:02:07Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":117379,"stargazers_count":36444,"watchers_count":36444,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21733,"mirror_url":null,"archived":false,"open_issues_count":879,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21733,"open_issues":879,"watchers":36444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8994"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8994"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8994/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8994/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/daf6b9036e7b5f32811e77e5ffebef180a628e08"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jtimon"}}