{"action":"created","comment":{"url":"https://api.github.com/repos/prebid/prebid-server/pulls/comments/176590592","pull_request_review_id":106319561,"id":176590592,"diff_hunk":"@@ -793,24 +797,6 @@ func main() {\n \t}\n }\n \n-func setupExchanges(cfg *config.Configuration) {\n-\texchanges = newExchangeMap(cfg)","path":"pbs_light.go","position":226,"original_position":226,"commit_id":"3f1a00a3ed0803f585169279131434be0abaf7f1","original_commit_id":"3f1a00a3ed0803f585169279131434be0abaf7f1","user":{"login":"dbemiller","id":27972385,"avatar_url":"https://avatars2.githubusercontent.com/u/27972385?v=4","gravatar_id":"","url":"https://api.github.com/users/dbemiller","html_url":"https://github.com/dbemiller","followers_url":"https://api.github.com/users/dbemiller/followers","following_url":"https://api.github.com/users/dbemiller/following{/other_user}","gists_url":"https://api.github.com/users/dbemiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dbemiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbemiller/subscriptions","organizations_url":"https://api.github.com/users/dbemiller/orgs","repos_url":"https://api.github.com/users/dbemiller/repos","events_url":"https://api.github.com/users/dbemiller/events{/privacy}","received_events_url":"https://api.github.com/users/dbemiller/received_events","type":"User","site_admin":false},"body":"Now that these have been removed, there's a _lot_ of dead code which can be deleted from this file.\r\n\r\nStart out with `makeExchangeMetrics` and try out the \"find all references\" feature in Visual Studio Code. You'll find a bunch of stuff which you can get rid of.","created_at":"2018-03-22T22:26:13Z","updated_at":"2018-03-22T22:39:04Z","html_url":"https://github.com/prebid/prebid-server/pull/384#discussion_r176590592","pull_request_url":"https://api.github.com/repos/prebid/prebid-server/pulls/384","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/comments/176590592"},"html":{"href":"https://github.com/prebid/prebid-server/pull/384#discussion_r176590592"},"pull_request":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/prebid/prebid-server/pulls/384","id":173289680,"html_url":"https://github.com/prebid/prebid-server/pull/384","diff_url":"https://github.com/prebid/prebid-server/pull/384.diff","patch_url":"https://github.com/prebid/prebid-server/pull/384.patch","issue_url":"https://api.github.com/repos/prebid/prebid-server/issues/384","number":384,"state":"open","locked":false,"title":"Abstract the metrics support","user":{"login":"hhhjort","id":31041505,"avatar_url":"https://avatars1.githubusercontent.com/u/31041505?v=4","gravatar_id":"","url":"https://api.github.com/users/hhhjort","html_url":"https://github.com/hhhjort","followers_url":"https://api.github.com/users/hhhjort/followers","following_url":"https://api.github.com/users/hhhjort/following{/other_user}","gists_url":"https://api.github.com/users/hhhjort/gists{/gist_id}","starred_url":"https://api.github.com/users/hhhjort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhhjort/subscriptions","organizations_url":"https://api.github.com/users/hhhjort/orgs","repos_url":"https://api.github.com/users/hhhjort/repos","events_url":"https://api.github.com/users/hhhjort/events{/privacy}","received_events_url":"https://api.github.com/users/hhhjort/received_events","type":"User","site_admin":false},"body":"This abstracts and standardizes the metrics support. The abstraction layer will make it easier to add new metrics databases in the future. The abstraction layer was designed with tag support in mind.\r\n\r\nFixes #363 ","created_at":"2018-03-06T21:42:15Z","updated_at":"2018-03-22T22:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81043aa21f1258537028b32e978d9e331017f176","assignee":{"login":"cindyhere33","id":11478095,"avatar_url":"https://avatars1.githubusercontent.com/u/11478095?v=4","gravatar_id":"","url":"https://api.github.com/users/cindyhere33","html_url":"https://github.com/cindyhere33","followers_url":"https://api.github.com/users/cindyhere33/followers","following_url":"https://api.github.com/users/cindyhere33/following{/other_user}","gists_url":"https://api.github.com/users/cindyhere33/gists{/gist_id}","starred_url":"https://api.github.com/users/cindyhere33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cindyhere33/subscriptions","organizations_url":"https://api.github.com/users/cindyhere33/orgs","repos_url":"https://api.github.com/users/cindyhere33/repos","events_url":"https://api.github.com/users/cindyhere33/events{/privacy}","received_events_url":"https://api.github.com/users/cindyhere33/received_events","type":"User","site_admin":false},"assignees":[{"login":"cindyhere33","id":11478095,"avatar_url":"https://avatars1.githubusercontent.com/u/11478095?v=4","gravatar_id":"","url":"https://api.github.com/users/cindyhere33","html_url":"https://github.com/cindyhere33","followers_url":"https://api.github.com/users/cindyhere33/followers","following_url":"https://api.github.com/users/cindyhere33/following{/other_user}","gists_url":"https://api.github.com/users/cindyhere33/gists{/gist_id}","starred_url":"https://api.github.com/users/cindyhere33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cindyhere33/subscriptions","organizations_url":"https://api.github.com/users/cindyhere33/orgs","repos_url":"https://api.github.com/users/cindyhere33/repos","events_url":"https://api.github.com/users/cindyhere33/events{/privacy}","received_events_url":"https://api.github.com/users/cindyhere33/received_events","type":"User","site_admin":false},{"login":"ndhimehta","id":26911109,"avatar_url":"https://avatars2.githubusercontent.com/u/26911109?v=4","gravatar_id":"","url":"https://api.github.com/users/ndhimehta","html_url":"https://github.com/ndhimehta","followers_url":"https://api.github.com/users/ndhimehta/followers","following_url":"https://api.github.com/users/ndhimehta/following{/other_user}","gists_url":"https://api.github.com/users/ndhimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhimehta/subscriptions","organizations_url":"https://api.github.com/users/ndhimehta/orgs","repos_url":"https://api.github.com/users/ndhimehta/repos","events_url":"https://api.github.com/users/ndhimehta/events{/privacy}","received_events_url":"https://api.github.com/users/ndhimehta/received_events","type":"User","site_admin":false},{"login":"dbemiller","id":27972385,"avatar_url":"https://avatars2.githubusercontent.com/u/27972385?v=4","gravatar_id":"","url":"https://api.github.com/users/dbemiller","html_url":"https://github.com/dbemiller","followers_url":"https://api.github.com/users/dbemiller/followers","following_url":"https://api.github.com/users/dbemiller/following{/other_user}","gists_url":"https://api.github.com/users/dbemiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dbemiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbemiller/subscriptions","organizations_url":"https://api.github.com/users/dbemiller/orgs","repos_url":"https://api.github.com/users/dbemiller/repos","events_url":"https://api.github.com/users/dbemiller/events{/privacy}","received_events_url":"https://api.github.com/users/dbemiller/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/prebid-server/pulls/384/commits","review_comments_url":"https://api.github.com/repos/prebid/prebid-server/pulls/384/comments","review_comment_url":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/prebid-server/issues/384/comments","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/3f1a00a3ed0803f585169279131434be0abaf7f1","head":{"label":"prebid:metricsengine","ref":"metricsengine","sha":"3f1a00a3ed0803f585169279131434be0abaf7f1","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-03-22T22:04:10Z","pushed_at":"2018-03-22T22:04:08Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7159,"stargazers_count":61,"watchers_count":61,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":60,"open_issues":50,"watchers":61,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"0d1f152d06b340c9893b657504a84e881040a856","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-03-22T22:04:10Z","pushed_at":"2018-03-22T22:04:08Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7159,"stargazers_count":61,"watchers_count":61,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":60,"open_issues":50,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/384"},"html":{"href":"https://github.com/prebid/prebid-server/pull/384"},"issue":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/384"},"comments":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/prebid-server/statuses/3f1a00a3ed0803f585169279131434be0abaf7f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbemiller"}}