{"action":"created","comment":{"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/comments/188930218","pull_request_review_id":121005049,"id":188930218,"diff_hunk":"@@ -71,15 +71,22 @@ exports['eslint-plugin-zapier'] = {\n     assert.doesNotThrow(() => linter.executeOnText(''));\n   },\n \n-  'exposes a prettier config': () => {\n-    const linter = makeLinter('prettier');\n+  'exposes a node config': () => {\n+    const linter = makeLinter('node');","path":"test/config/tests.js","position":7,"original_position":7,"commit_id":"5b7073bf637b1fa34408faa2e2dde46a26254a7c","original_commit_id":"5b7073bf637b1fa34408faa2e2dde46a26254a7c","user":{"login":"vitorbal","id":626038,"avatar_url":"https://avatars2.githubusercontent.com/u/626038?v=4","gravatar_id":"","url":"https://api.github.com/users/vitorbal","html_url":"https://github.com/vitorbal","followers_url":"https://api.github.com/users/vitorbal/followers","following_url":"https://api.github.com/users/vitorbal/following{/other_user}","gists_url":"https://api.github.com/users/vitorbal/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorbal/subscriptions","organizations_url":"https://api.github.com/users/vitorbal/orgs","repos_url":"https://api.github.com/users/vitorbal/repos","events_url":"https://api.github.com/users/vitorbal/events{/privacy}","received_events_url":"https://api.github.com/users/vitorbal/received_events","type":"User","site_admin":false},"body":"could you add a couple of extra tests here that assert that the `node` config doesn't set the `browser` env and it does set the `node` env?","created_at":"2018-05-17T11:51:29Z","updated_at":"2018-05-17T11:53:37Z","html_url":"https://github.com/zapier/eslint-plugin-zapier/pull/38#discussion_r188930218","pull_request_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/comments/188930218"},"html":{"href":"https://github.com/zapier/eslint-plugin-zapier/pull/38#discussion_r188930218"},"pull_request":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38","id":187498013,"html_url":"https://github.com/zapier/eslint-plugin-zapier/pull/38","diff_url":"https://github.com/zapier/eslint-plugin-zapier/pull/38.diff","patch_url":"https://github.com/zapier/eslint-plugin-zapier/pull/38.patch","issue_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/38","number":38,"state":"open","locked":false,"title":"[WIP] Add eslint-plugin-compat","user":{"login":"ngryman","id":892048,"avatar_url":"https://avatars2.githubusercontent.com/u/892048?v=4","gravatar_id":"","url":"https://api.github.com/users/ngryman","html_url":"https://github.com/ngryman","followers_url":"https://api.github.com/users/ngryman/followers","following_url":"https://api.github.com/users/ngryman/following{/other_user}","gists_url":"https://api.github.com/users/ngryman/gists{/gist_id}","starred_url":"https://api.github.com/users/ngryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngryman/subscriptions","organizations_url":"https://api.github.com/users/ngryman/orgs","repos_url":"https://api.github.com/users/ngryman/repos","events_url":"https://api.github.com/users/ngryman/events{/privacy}","received_events_url":"https://api.github.com/users/ngryman/received_events","type":"User","site_admin":false},"body":"This PR adds [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat).\r\n\r\nAs discussed in Slack @vitorbal, I've added a `browser` config and refactored the existing one (cf. commit messages).\r\n\r\nI still need to test that with the `zapier` codebase to see if everything is fine. Meanwhile feel free to give me your feedback.","created_at":"2018-05-11T15:34:14Z","updated_at":"2018-05-17T11:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44fd4685a405b421b903d0f50ec02cd90ec2e955","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706413732,"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/labels/Breaking%20change","name":"Breaking change","color":"d93f0b","default":false},{"id":395711519,"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38/commits","review_comments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38/comments","review_comment_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/38/comments","statuses_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/statuses/5b7073bf637b1fa34408faa2e2dde46a26254a7c","head":{"label":"zapier:feat/eslint-plugin-compat","ref":"feat/eslint-plugin-compat","sha":"5b7073bf637b1fa34408faa2e2dde46a26254a7c","user":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"repo":{"id":61570434,"name":"eslint-plugin-zapier","full_name":"zapier/eslint-plugin-zapier","owner":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zapier/eslint-plugin-zapier","description":":shower: A shareable version of the .eslintrc file used internally at Zapier.","fork":false,"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier","forks_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/forks","keys_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/teams","hooks_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/hooks","issue_events_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/events{/number}","events_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/events","assignees_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/assignees{/user}","branches_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/branches{/branch}","tags_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/tags","blobs_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/refs{/sha}","trees_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/statuses/{sha}","languages_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/languages","stargazers_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/stargazers","contributors_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/contributors","subscribers_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/subscribers","subscription_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/subscription","commits_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/commits{/sha}","git_commits_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/commits{/sha}","comments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/comments{/number}","issue_comment_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/comments{/number}","contents_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/contents/{+path}","compare_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/merges","archive_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/downloads","issues_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues{/number}","pulls_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls{/number}","milestones_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/milestones{/number}","notifications_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/labels{/name}","releases_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/releases{/id}","deployments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/deployments","created_at":"2016-06-20T18:23:12Z","updated_at":"2018-05-08T15:55:21Z","pushed_at":"2018-05-11T15:35:21Z","git_url":"git://github.com/zapier/eslint-plugin-zapier.git","ssh_url":"git@github.com:zapier/eslint-plugin-zapier.git","clone_url":"https://github.com/zapier/eslint-plugin-zapier.git","svn_url":"https://github.com/zapier/eslint-plugin-zapier","homepage":"","size":91,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"zapier:master","ref":"master","sha":"940ff28d51c6dd0d24f1baf29ce6afb014543452","user":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"repo":{"id":61570434,"name":"eslint-plugin-zapier","full_name":"zapier/eslint-plugin-zapier","owner":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zapier/eslint-plugin-zapier","description":":shower: A shareable version of the .eslintrc file used internally at Zapier.","fork":false,"url":"https://api.github.com/repos/zapier/eslint-plugin-zapier","forks_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/forks","keys_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/teams","hooks_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/hooks","issue_events_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/events{/number}","events_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/events","assignees_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/assignees{/user}","branches_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/branches{/branch}","tags_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/tags","blobs_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/refs{/sha}","trees_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/statuses/{sha}","languages_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/languages","stargazers_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/stargazers","contributors_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/contributors","subscribers_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/subscribers","subscription_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/subscription","commits_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/commits{/sha}","git_commits_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/git/commits{/sha}","comments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/comments{/number}","issue_comment_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/comments{/number}","contents_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/contents/{+path}","compare_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/merges","archive_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/downloads","issues_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues{/number}","pulls_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls{/number}","milestones_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/milestones{/number}","notifications_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/labels{/name}","releases_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/releases{/id}","deployments_url":"https://api.github.com/repos/zapier/eslint-plugin-zapier/deployments","created_at":"2016-06-20T18:23:12Z","updated_at":"2018-05-08T15:55:21Z","pushed_at":"2018-05-11T15:35:21Z","git_url":"git://github.com/zapier/eslint-plugin-zapier.git","ssh_url":"git@github.com:zapier/eslint-plugin-zapier.git","clone_url":"https://github.com/zapier/eslint-plugin-zapier.git","svn_url":"https://github.com/zapier/eslint-plugin-zapier","homepage":"","size":91,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38"},"html":{"href":"https://github.com/zapier/eslint-plugin-zapier/pull/38"},"issue":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/38"},"comments":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/zapier/eslint-plugin-zapier/statuses/5b7073bf637b1fa34408faa2e2dde46a26254a7c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vitorbal"}}