{"action":"created","comment":{"url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments/170022675","pull_request_review_id":98643742,"id":170022675,"diff_hunk":"@@ -303,14 +310,39 @@ def getTimeBaseNum(self, sampleTimeS):\n         timebase = int(timebase)\n         return timebase\n \n-    def getTimestepFromTimebase(self, timebase):\n+    def getTimestepFromTimebase4000(self, timebase):\n         \"\"\"Return timebase to sampletime as seconds.\"\"\"\n         if timebase < 3:\n             dt = 2. ** timebase / 8e7\n         else:\n             dt = (timebase - 1) / 2e7\n         return dt\n \n+    def getTimestepFromTimebase4262(self, timebase):\n+        \"\"\"Return timebase to sampletime as seconds for ps4262.\"\"\"\n+        someConstant = 10000000.0\n+        return (timebase+1) / someConstant\n+\n+    def getTimeBaseNum4262(self, sampleTimeS):","path":"picoscope/ps4000.py","position":41,"original_position":41,"commit_id":"f1cf08a09e73faa824b6a56b4137894879cc8490","original_commit_id":"f1cf08a09e73faa824b6a56b4137894879cc8490","user":{"login":"hmaarrfk","id":90008,"avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"body":"ditto on the `_`","created_at":"2018-02-22T16:50:56Z","updated_at":"2018-02-22T16:52:59Z","html_url":"https://github.com/colinoflynn/pico-python/pull/118#discussion_r170022675","pull_request_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments/170022675"},"html":{"href":"https://github.com/colinoflynn/pico-python/pull/118#discussion_r170022675"},"pull_request":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118","id":170565826,"html_url":"https://github.com/colinoflynn/pico-python/pull/118","diff_url":"https://github.com/colinoflynn/pico-python/pull/118.diff","patch_url":"https://github.com/colinoflynn/pico-python/pull/118.patch","issue_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/118","number":118,"state":"open","locked":false,"title":"add some timebase calculations unique to ps4262","user":{"login":"greyltc","id":16778174,"avatar_url":"https://avatars1.githubusercontent.com/u/16778174?v=4","gravatar_id":"","url":"https://api.github.com/users/greyltc","html_url":"https://github.com/greyltc","followers_url":"https://api.github.com/users/greyltc/followers","following_url":"https://api.github.com/users/greyltc/following{/other_user}","gists_url":"https://api.github.com/users/greyltc/gists{/gist_id}","starred_url":"https://api.github.com/users/greyltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyltc/subscriptions","organizations_url":"https://api.github.com/users/greyltc/orgs","repos_url":"https://api.github.com/users/greyltc/repos","events_url":"https://api.github.com/users/greyltc/events{/privacy}","received_events_url":"https://api.github.com/users/greyltc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-21T19:30:03Z","updated_at":"2018-02-22T16:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd2952177a4ce3fa694e459633a427cdc8476d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118/commits","review_comments_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118/comments","review_comment_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/118/comments","statuses_url":"https://api.github.com/repos/colinoflynn/pico-python/statuses/f1cf08a09e73faa824b6a56b4137894879cc8490","head":{"label":"greyltc:ps4262-timebase-calcs","ref":"ps4262-timebase-calcs","sha":"f1cf08a09e73faa824b6a56b4137894879cc8490","user":{"login":"greyltc","id":16778174,"avatar_url":"https://avatars1.githubusercontent.com/u/16778174?v=4","gravatar_id":"","url":"https://api.github.com/users/greyltc","html_url":"https://github.com/greyltc","followers_url":"https://api.github.com/users/greyltc/followers","following_url":"https://api.github.com/users/greyltc/following{/other_user}","gists_url":"https://api.github.com/users/greyltc/gists{/gist_id}","starred_url":"https://api.github.com/users/greyltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyltc/subscriptions","organizations_url":"https://api.github.com/users/greyltc/orgs","repos_url":"https://api.github.com/users/greyltc/repos","events_url":"https://api.github.com/users/greyltc/events{/privacy}","received_events_url":"https://api.github.com/users/greyltc/received_events","type":"User","site_admin":false},"repo":{"id":122381866,"name":"pico-python","full_name":"greyltc/pico-python","owner":{"login":"greyltc","id":16778174,"avatar_url":"https://avatars1.githubusercontent.com/u/16778174?v=4","gravatar_id":"","url":"https://api.github.com/users/greyltc","html_url":"https://github.com/greyltc","followers_url":"https://api.github.com/users/greyltc/followers","following_url":"https://api.github.com/users/greyltc/following{/other_user}","gists_url":"https://api.github.com/users/greyltc/gists{/gist_id}","starred_url":"https://api.github.com/users/greyltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyltc/subscriptions","organizations_url":"https://api.github.com/users/greyltc/orgs","repos_url":"https://api.github.com/users/greyltc/repos","events_url":"https://api.github.com/users/greyltc/events{/privacy}","received_events_url":"https://api.github.com/users/greyltc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greyltc/pico-python","description":"PicoScope Python Interface","fork":true,"url":"https://api.github.com/repos/greyltc/pico-python","forks_url":"https://api.github.com/repos/greyltc/pico-python/forks","keys_url":"https://api.github.com/repos/greyltc/pico-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greyltc/pico-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greyltc/pico-python/teams","hooks_url":"https://api.github.com/repos/greyltc/pico-python/hooks","issue_events_url":"https://api.github.com/repos/greyltc/pico-python/issues/events{/number}","events_url":"https://api.github.com/repos/greyltc/pico-python/events","assignees_url":"https://api.github.com/repos/greyltc/pico-python/assignees{/user}","branches_url":"https://api.github.com/repos/greyltc/pico-python/branches{/branch}","tags_url":"https://api.github.com/repos/greyltc/pico-python/tags","blobs_url":"https://api.github.com/repos/greyltc/pico-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greyltc/pico-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greyltc/pico-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/greyltc/pico-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greyltc/pico-python/statuses/{sha}","languages_url":"https://api.github.com/repos/greyltc/pico-python/languages","stargazers_url":"https://api.github.com/repos/greyltc/pico-python/stargazers","contributors_url":"https://api.github.com/repos/greyltc/pico-python/contributors","subscribers_url":"https://api.github.com/repos/greyltc/pico-python/subscribers","subscription_url":"https://api.github.com/repos/greyltc/pico-python/subscription","commits_url":"https://api.github.com/repos/greyltc/pico-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/greyltc/pico-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/greyltc/pico-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/greyltc/pico-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/greyltc/pico-python/contents/{+path}","compare_url":"https://api.github.com/repos/greyltc/pico-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greyltc/pico-python/merges","archive_url":"https://api.github.com/repos/greyltc/pico-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greyltc/pico-python/downloads","issues_url":"https://api.github.com/repos/greyltc/pico-python/issues{/number}","pulls_url":"https://api.github.com/repos/greyltc/pico-python/pulls{/number}","milestones_url":"https://api.github.com/repos/greyltc/pico-python/milestones{/number}","notifications_url":"https://api.github.com/repos/greyltc/pico-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greyltc/pico-python/labels{/name}","releases_url":"https://api.github.com/repos/greyltc/pico-python/releases{/id}","deployments_url":"https://api.github.com/repos/greyltc/pico-python/deployments","created_at":"2018-02-21T19:19:52Z","updated_at":"2018-02-21T19:19:53Z","pushed_at":"2018-02-22T15:57:58Z","git_url":"git://github.com/greyltc/pico-python.git","ssh_url":"git@github.com:greyltc/pico-python.git","clone_url":"https://github.com/greyltc/pico-python.git","svn_url":"https://github.com/greyltc/pico-python","homepage":null,"size":1079,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colinoflynn:master","ref":"master","sha":"887d4767f9b06157e3a2c991af5edef94fb0daab","user":{"login":"colinoflynn","id":6100154,"avatar_url":"https://avatars1.githubusercontent.com/u/6100154?v=4","gravatar_id":"","url":"https://api.github.com/users/colinoflynn","html_url":"https://github.com/colinoflynn","followers_url":"https://api.github.com/users/colinoflynn/followers","following_url":"https://api.github.com/users/colinoflynn/following{/other_user}","gists_url":"https://api.github.com/users/colinoflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/colinoflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinoflynn/subscriptions","organizations_url":"https://api.github.com/users/colinoflynn/orgs","repos_url":"https://api.github.com/users/colinoflynn/repos","events_url":"https://api.github.com/users/colinoflynn/events{/privacy}","received_events_url":"https://api.github.com/users/colinoflynn/received_events","type":"User","site_admin":false},"repo":{"id":15211810,"name":"pico-python","full_name":"colinoflynn/pico-python","owner":{"login":"colinoflynn","id":6100154,"avatar_url":"https://avatars1.githubusercontent.com/u/6100154?v=4","gravatar_id":"","url":"https://api.github.com/users/colinoflynn","html_url":"https://github.com/colinoflynn","followers_url":"https://api.github.com/users/colinoflynn/followers","following_url":"https://api.github.com/users/colinoflynn/following{/other_user}","gists_url":"https://api.github.com/users/colinoflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/colinoflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinoflynn/subscriptions","organizations_url":"https://api.github.com/users/colinoflynn/orgs","repos_url":"https://api.github.com/users/colinoflynn/repos","events_url":"https://api.github.com/users/colinoflynn/events{/privacy}","received_events_url":"https://api.github.com/users/colinoflynn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colinoflynn/pico-python","description":"PicoScope Python Interface","fork":false,"url":"https://api.github.com/repos/colinoflynn/pico-python","forks_url":"https://api.github.com/repos/colinoflynn/pico-python/forks","keys_url":"https://api.github.com/repos/colinoflynn/pico-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinoflynn/pico-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinoflynn/pico-python/teams","hooks_url":"https://api.github.com/repos/colinoflynn/pico-python/hooks","issue_events_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/events{/number}","events_url":"https://api.github.com/repos/colinoflynn/pico-python/events","assignees_url":"https://api.github.com/repos/colinoflynn/pico-python/assignees{/user}","branches_url":"https://api.github.com/repos/colinoflynn/pico-python/branches{/branch}","tags_url":"https://api.github.com/repos/colinoflynn/pico-python/tags","blobs_url":"https://api.github.com/repos/colinoflynn/pico-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinoflynn/pico-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinoflynn/pico-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinoflynn/pico-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinoflynn/pico-python/statuses/{sha}","languages_url":"https://api.github.com/repos/colinoflynn/pico-python/languages","stargazers_url":"https://api.github.com/repos/colinoflynn/pico-python/stargazers","contributors_url":"https://api.github.com/repos/colinoflynn/pico-python/contributors","subscribers_url":"https://api.github.com/repos/colinoflynn/pico-python/subscribers","subscription_url":"https://api.github.com/repos/colinoflynn/pico-python/subscription","commits_url":"https://api.github.com/repos/colinoflynn/pico-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinoflynn/pico-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinoflynn/pico-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/colinoflynn/pico-python/contents/{+path}","compare_url":"https://api.github.com/repos/colinoflynn/pico-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinoflynn/pico-python/merges","archive_url":"https://api.github.com/repos/colinoflynn/pico-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinoflynn/pico-python/downloads","issues_url":"https://api.github.com/repos/colinoflynn/pico-python/issues{/number}","pulls_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls{/number}","milestones_url":"https://api.github.com/repos/colinoflynn/pico-python/milestones{/number}","notifications_url":"https://api.github.com/repos/colinoflynn/pico-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinoflynn/pico-python/labels{/name}","releases_url":"https://api.github.com/repos/colinoflynn/pico-python/releases{/id}","deployments_url":"https://api.github.com/repos/colinoflynn/pico-python/deployments","created_at":"2013-12-15T22:14:17Z","updated_at":"2017-12-26T07:31:21Z","pushed_at":"2018-02-22T15:57:59Z","git_url":"git://github.com/colinoflynn/pico-python.git","ssh_url":"git@github.com:colinoflynn/pico-python.git","clone_url":"https://github.com/colinoflynn/pico-python.git","svn_url":"https://github.com/colinoflynn/pico-python","homepage":null,"size":1048,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":43,"open_issues":14,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118"},"html":{"href":"https://github.com/colinoflynn/pico-python/pull/118"},"issue":{"href":"https://api.github.com/repos/colinoflynn/pico-python/issues/118"},"comments":{"href":"https://api.github.com/repos/colinoflynn/pico-python/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/colinoflynn/pico-python/statuses/f1cf08a09e73faa824b6a56b4137894879cc8490"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hmaarrfk"}}