{"action":"created","comment":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/231243551","pull_request_review_id":172164572,"id":231243551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI0MzU1MQ==","diff_hunk":"@@ -305,18 +317,42 @@ def create_model(self, model_server_workers=None, role=None, vpc_config_override\n                 Default: use subnets and security groups from this Estimator.\n                 * 'Subnets' (list[str]): List of subnet ids.\n                 * 'SecurityGroupIds' (list[str]): List of security group ids.\n+            endpoint_type: Optional. Selects the software stack used by the inference server.\n+                If  not specified, the model will be configured to use the default SageMaker model server.\n+                If 'tfs', the model will be configured to use the SageMaker Tensorflow Serving container.\n \n         Returns:\n             sagemaker.tensorflow.model.TensorFlowModel: A SageMaker ``TensorFlowModel`` object.\n                 See :func:`~sagemaker.tensorflow.model.TensorFlowModel` for full details.\n         \"\"\"\n-        env = {'SAGEMAKER_REQUIREMENTS': self.requirements_file}\n+\n         role = role or self.role\n-        return TensorFlowModel(self.model_data, role, self.entry_point, source_dir=self._model_source_dir(),\n-                               enable_cloudwatch_metrics=self.enable_cloudwatch_metrics, env=env, image=self.image_name,\n-                               name=self._current_job_name, container_log_level=self.container_log_level,\n+        if endpoint_type == 'tfs':\n+            return self._create_tfs_model(role=role, vpc_config_override=vpc_config_override)\n+\n+        return self._create_default_model(model_server_workers=model_server_workers, role=role,\n+                                          vpc_config_override=vpc_config_override)\n+\n+    def _create_tfs_model(self, role=None, vpc_config_override=VPC_CONFIG_DEFAULT):\n+        return TFSModel(model_data=self.model_data,\n+                        role=role,\n+                        image=self.image_name,\n+                        name=self._current_job_name,\n+                        framework_version=self.framework_version,\n+                        sagemaker_session=self.sagemaker_session,\n+                        vpc_config=self.get_vpc_config(vpc_config_override))","path":"src/sagemaker/tensorflow/estimator.py","position":148,"original_position":148,"commit_id":"75bf8936ef71446d2597fc77f4ab2966f9c0b742","original_commit_id":"75bf8936ef71446d2597fc77f4ab2966f9c0b742","user":{"login":"mvsusp","id":142074,"node_id":"MDQ6VXNlcjE0MjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/142074?v=4","gravatar_id":"","url":"https://api.github.com/users/mvsusp","html_url":"https://github.com/mvsusp","followers_url":"https://api.github.com/users/mvsusp/followers","following_url":"https://api.github.com/users/mvsusp/following{/other_user}","gists_url":"https://api.github.com/users/mvsusp/gists{/gist_id}","starred_url":"https://api.github.com/users/mvsusp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvsusp/subscriptions","organizations_url":"https://api.github.com/users/mvsusp/orgs","repos_url":"https://api.github.com/users/mvsusp/repos","events_url":"https://api.github.com/users/mvsusp/events{/privacy}","received_events_url":"https://api.github.com/users/mvsusp/received_events","type":"User","site_admin":false},"body":"Are you missing container_log_level?","created_at":"2018-11-06T18:42:28Z","updated_at":"2018-11-06T18:45:01Z","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/460#discussion_r231243551","pull_request_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/231243551"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/460#discussion_r231243551"},"pull_request":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460","id":228750591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzUwNTkx","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/460","diff_url":"https://github.com/aws/sagemaker-python-sdk/pull/460.diff","patch_url":"https://github.com/aws/sagemaker-python-sdk/pull/460.patch","issue_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/460","number":460,"state":"open","locked":false,"title":"add tfs container support","user":{"login":"jesterhazy","id":505258,"node_id":"MDQ6VXNlcjUwNTI1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/505258?v=4","gravatar_id":"","url":"https://api.github.com/users/jesterhazy","html_url":"https://github.com/jesterhazy","followers_url":"https://api.github.com/users/jesterhazy/followers","following_url":"https://api.github.com/users/jesterhazy/following{/other_user}","gists_url":"https://api.github.com/users/jesterhazy/gists{/gist_id}","starred_url":"https://api.github.com/users/jesterhazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesterhazy/subscriptions","organizations_url":"https://api.github.com/users/jesterhazy/orgs","repos_url":"https://api.github.com/users/jesterhazy/repos","events_url":"https://api.github.com/users/jesterhazy/events{/privacy}","received_events_url":"https://api.github.com/users/jesterhazy/received_events","type":"User","site_admin":false},"body":"*Description of changes:*\r\n\r\nadd support for sagemaker-tfs inference container\r\n\r\n## Merge Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)\r\n- [x] I have updated the [changelog](https://github.com/aws/sagemaker-python-sdk/blob/master/CHANGELOG.rst) with a description of my changes (if appropriate)\r\n- [ ] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-06T16:19:58Z","updated_at":"2018-11-06T18:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d94374e8dedb314348a78641fd0cd3902d70697","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nadiaya","id":32335935,"node_id":"MDQ6VXNlcjMyMzM1OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/32335935?v=4","gravatar_id":"","url":"https://api.github.com/users/nadiaya","html_url":"https://github.com/nadiaya","followers_url":"https://api.github.com/users/nadiaya/followers","following_url":"https://api.github.com/users/nadiaya/following{/other_user}","gists_url":"https://api.github.com/users/nadiaya/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiaya/subscriptions","organizations_url":"https://api.github.com/users/nadiaya/orgs","repos_url":"https://api.github.com/users/nadiaya/repos","events_url":"https://api.github.com/users/nadiaya/events{/privacy}","received_events_url":"https://api.github.com/users/nadiaya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460/commits","review_comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460/comments","review_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/460/comments","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/75bf8936ef71446d2597fc77f4ab2966f9c0b742","head":{"label":"jesterhazy:je-tfs","ref":"je-tfs","sha":"75bf8936ef71446d2597fc77f4ab2966f9c0b742","user":{"login":"jesterhazy","id":505258,"node_id":"MDQ6VXNlcjUwNTI1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/505258?v=4","gravatar_id":"","url":"https://api.github.com/users/jesterhazy","html_url":"https://github.com/jesterhazy","followers_url":"https://api.github.com/users/jesterhazy/followers","following_url":"https://api.github.com/users/jesterhazy/following{/other_user}","gists_url":"https://api.github.com/users/jesterhazy/gists{/gist_id}","starred_url":"https://api.github.com/users/jesterhazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesterhazy/subscriptions","organizations_url":"https://api.github.com/users/jesterhazy/orgs","repos_url":"https://api.github.com/users/jesterhazy/repos","events_url":"https://api.github.com/users/jesterhazy/events{/privacy}","received_events_url":"https://api.github.com/users/jesterhazy/received_events","type":"User","site_admin":false},"repo":{"id":153482656,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0ODI2NTY=","name":"sagemaker-python-sdk","full_name":"jesterhazy/sagemaker-python-sdk","private":false,"owner":{"login":"jesterhazy","id":505258,"node_id":"MDQ6VXNlcjUwNTI1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/505258?v=4","gravatar_id":"","url":"https://api.github.com/users/jesterhazy","html_url":"https://github.com/jesterhazy","followers_url":"https://api.github.com/users/jesterhazy/followers","following_url":"https://api.github.com/users/jesterhazy/following{/other_user}","gists_url":"https://api.github.com/users/jesterhazy/gists{/gist_id}","starred_url":"https://api.github.com/users/jesterhazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesterhazy/subscriptions","organizations_url":"https://api.github.com/users/jesterhazy/orgs","repos_url":"https://api.github.com/users/jesterhazy/repos","events_url":"https://api.github.com/users/jesterhazy/events{/privacy}","received_events_url":"https://api.github.com/users/jesterhazy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jesterhazy/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":true,"url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/jesterhazy/sagemaker-python-sdk/deployments","created_at":"2018-10-17T15:43:43Z","updated_at":"2018-11-04T20:21:32Z","pushed_at":"2018-11-06T17:10:42Z","git_url":"git://github.com/jesterhazy/sagemaker-python-sdk.git","ssh_url":"git@github.com:jesterhazy/sagemaker-python-sdk.git","clone_url":"https://github.com/jesterhazy/sagemaker-python-sdk.git","svn_url":"https://github.com/jesterhazy/sagemaker-python-sdk","homepage":"","size":52130,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"868f81b78b9b6907030944e4f1fdbe04832de956","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":110621895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MjE4OTU=","name":"sagemaker-python-sdk","full_name":"aws/sagemaker-python-sdk","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":false,"url":"https://api.github.com/repos/aws/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/deployments","created_at":"2017-11-14T01:03:33Z","updated_at":"2018-11-05T21:34:36Z","pushed_at":"2018-11-06T17:10:43Z","git_url":"git://github.com/aws/sagemaker-python-sdk.git","ssh_url":"git@github.com:aws/sagemaker-python-sdk.git","clone_url":"https://github.com/aws/sagemaker-python-sdk.git","svn_url":"https://github.com/aws/sagemaker-python-sdk","homepage":"","size":52118,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":165,"open_issues":60,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/460"},"issue":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/460"},"comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/75bf8936ef71446d2597fc77f4ab2966f9c0b742"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mvsusp"}}