{"action":"created","comment":{"url":"https://api.github.com/repos/pysmt/pysmt/pulls/comments/192075651","pull_request_review_id":124775760,"id":192075651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjA3NTY1MQ==","diff_hunk":"@@ -86,7 +86,7 @@ def serialize(self, outstream=None, printer=None, daggify=True):\n \n         elif self.name in [smtcmd.CHECK_SAT, smtcmd.EXIT,\n                            smtcmd.RESET_ASSERTIONS, smtcmd.GET_UNSAT_CORE,\n-                           smtcmd.GET_ASSIGNMENT]:\n+                           smtcmd.GET_ASSIGNMENT, smtcmd.GET_MODEL]:","path":"pysmt/smtlib/script.py","position":5,"original_position":5,"commit_id":"a6944b96ecc5820db7ad2c8e09cf241dca7b7a2f","original_commit_id":"a6944b96ecc5820db7ad2c8e09cf241dca7b7a2f","user":{"login":"mikand","id":2255972,"node_id":"MDQ6VXNlcjIyNTU5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2255972?v=4","gravatar_id":"","url":"https://api.github.com/users/mikand","html_url":"https://github.com/mikand","followers_url":"https://api.github.com/users/mikand/followers","following_url":"https://api.github.com/users/mikand/following{/other_user}","gists_url":"https://api.github.com/users/mikand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikand/subscriptions","organizations_url":"https://api.github.com/users/mikand/orgs","repos_url":"https://api.github.com/users/mikand/repos","events_url":"https://api.github.com/users/mikand/events{/privacy}","received_events_url":"https://api.github.com/users/mikand/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2018-05-31T12:02:16Z","updated_at":"2018-05-31T12:03:11Z","html_url":"https://github.com/pysmt/pysmt/pull/489#discussion_r192075651","pull_request_url":"https://api.github.com/repos/pysmt/pysmt/pulls/489","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/comments/192075651"},"html":{"href":"https://github.com/pysmt/pysmt/pull/489#discussion_r192075651"},"pull_request":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/489"}},"in_reply_to_id":191973807},"pull_request":{"url":"https://api.github.com/repos/pysmt/pysmt/pulls/489","id":191626683,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjI2Njgz","html_url":"https://github.com/pysmt/pysmt/pull/489","diff_url":"https://github.com/pysmt/pysmt/pull/489.diff","patch_url":"https://github.com/pysmt/pysmt/pull/489.patch","issue_url":"https://api.github.com/repos/pysmt/pysmt/issues/489","number":489,"state":"open","locked":false,"title":"Fix/doublequote escaping","user":{"login":"Lukas-Dresel","id":13377119,"node_id":"MDQ6VXNlcjEzMzc3MTE5","avatar_url":"https://avatars1.githubusercontent.com/u/13377119?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukas-Dresel","html_url":"https://github.com/Lukas-Dresel","followers_url":"https://api.github.com/users/Lukas-Dresel/followers","following_url":"https://api.github.com/users/Lukas-Dresel/following{/other_user}","gists_url":"https://api.github.com/users/Lukas-Dresel/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukas-Dresel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukas-Dresel/subscriptions","organizations_url":"https://api.github.com/users/Lukas-Dresel/orgs","repos_url":"https://api.github.com/users/Lukas-Dresel/repos","events_url":"https://api.github.com/users/Lukas-Dresel/events{/privacy}","received_events_url":"https://api.github.com/users/Lukas-Dresel/received_events","type":"User","site_admin":false},"body":"As discussed in PR #478 this is the fix for the double-quote parsing and printing of smt string constants.\r\nRegression tests have been added that should currently fail on master but succeed using these changes.\r\n\r\nWhile writing the testcases I noticed other places that had the issue, hopefully this should fix all of them!","created_at":"2018-05-31T02:16:28Z","updated_at":"2018-05-31T12:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e998d468ffccb788b070930f09a5da3e8283462a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pysmt/pysmt/pulls/489/commits","review_comments_url":"https://api.github.com/repos/pysmt/pysmt/pulls/489/comments","review_comment_url":"https://api.github.com/repos/pysmt/pysmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pysmt/pysmt/issues/489/comments","statuses_url":"https://api.github.com/repos/pysmt/pysmt/statuses/a6944b96ecc5820db7ad2c8e09cf241dca7b7a2f","head":{"label":"Phat3:fix/doublequote_escaping","ref":"fix/doublequote_escaping","sha":"a6944b96ecc5820db7ad2c8e09cf241dca7b7a2f","user":{"login":"Phat3","id":3390748,"node_id":"MDQ6VXNlcjMzOTA3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3390748?v=4","gravatar_id":"","url":"https://api.github.com/users/Phat3","html_url":"https://github.com/Phat3","followers_url":"https://api.github.com/users/Phat3/followers","following_url":"https://api.github.com/users/Phat3/following{/other_user}","gists_url":"https://api.github.com/users/Phat3/gists{/gist_id}","starred_url":"https://api.github.com/users/Phat3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phat3/subscriptions","organizations_url":"https://api.github.com/users/Phat3/orgs","repos_url":"https://api.github.com/users/Phat3/repos","events_url":"https://api.github.com/users/Phat3/events{/privacy}","received_events_url":"https://api.github.com/users/Phat3/received_events","type":"User","site_admin":false},"repo":{"id":128487612,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0ODc2MTI=","name":"pysmt","full_name":"Phat3/pysmt","owner":{"login":"Phat3","id":3390748,"node_id":"MDQ6VXNlcjMzOTA3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3390748?v=4","gravatar_id":"","url":"https://api.github.com/users/Phat3","html_url":"https://github.com/Phat3","followers_url":"https://api.github.com/users/Phat3/followers","following_url":"https://api.github.com/users/Phat3/following{/other_user}","gists_url":"https://api.github.com/users/Phat3/gists{/gist_id}","starred_url":"https://api.github.com/users/Phat3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phat3/subscriptions","organizations_url":"https://api.github.com/users/Phat3/orgs","repos_url":"https://api.github.com/users/Phat3/repos","events_url":"https://api.github.com/users/Phat3/events{/privacy}","received_events_url":"https://api.github.com/users/Phat3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Phat3/pysmt","description":"pySMT: A library for SMT formulae manipulation and solving","fork":true,"url":"https://api.github.com/repos/Phat3/pysmt","forks_url":"https://api.github.com/repos/Phat3/pysmt/forks","keys_url":"https://api.github.com/repos/Phat3/pysmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phat3/pysmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phat3/pysmt/teams","hooks_url":"https://api.github.com/repos/Phat3/pysmt/hooks","issue_events_url":"https://api.github.com/repos/Phat3/pysmt/issues/events{/number}","events_url":"https://api.github.com/repos/Phat3/pysmt/events","assignees_url":"https://api.github.com/repos/Phat3/pysmt/assignees{/user}","branches_url":"https://api.github.com/repos/Phat3/pysmt/branches{/branch}","tags_url":"https://api.github.com/repos/Phat3/pysmt/tags","blobs_url":"https://api.github.com/repos/Phat3/pysmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phat3/pysmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phat3/pysmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phat3/pysmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phat3/pysmt/statuses/{sha}","languages_url":"https://api.github.com/repos/Phat3/pysmt/languages","stargazers_url":"https://api.github.com/repos/Phat3/pysmt/stargazers","contributors_url":"https://api.github.com/repos/Phat3/pysmt/contributors","subscribers_url":"https://api.github.com/repos/Phat3/pysmt/subscribers","subscription_url":"https://api.github.com/repos/Phat3/pysmt/subscription","commits_url":"https://api.github.com/repos/Phat3/pysmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phat3/pysmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phat3/pysmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phat3/pysmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Phat3/pysmt/contents/{+path}","compare_url":"https://api.github.com/repos/Phat3/pysmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phat3/pysmt/merges","archive_url":"https://api.github.com/repos/Phat3/pysmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phat3/pysmt/downloads","issues_url":"https://api.github.com/repos/Phat3/pysmt/issues{/number}","pulls_url":"https://api.github.com/repos/Phat3/pysmt/pulls{/number}","milestones_url":"https://api.github.com/repos/Phat3/pysmt/milestones{/number}","notifications_url":"https://api.github.com/repos/Phat3/pysmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phat3/pysmt/labels{/name}","releases_url":"https://api.github.com/repos/Phat3/pysmt/releases{/id}","deployments_url":"https://api.github.com/repos/Phat3/pysmt/deployments","created_at":"2018-04-07T01:54:39Z","updated_at":"2018-05-31T00:15:37Z","pushed_at":"2018-05-31T02:06:53Z","git_url":"git://github.com/Phat3/pysmt.git","ssh_url":"git@github.com:Phat3/pysmt.git","clone_url":"https://github.com/Phat3/pysmt.git","svn_url":"https://github.com/Phat3/pysmt","homepage":"http://www.pysmt.org","size":3740,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pysmt:master","ref":"master","sha":"91b44401b49dd7466d27f56ce247a4ee54ed5473","user":{"login":"pysmt","id":10014498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE0NDk4","avatar_url":"https://avatars0.githubusercontent.com/u/10014498?v=4","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"repo":{"id":27359780,"node_id":"MDEwOlJlcG9zaXRvcnkyNzM1OTc4MA==","name":"pysmt","full_name":"pysmt/pysmt","owner":{"login":"pysmt","id":10014498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE0NDk4","avatar_url":"https://avatars0.githubusercontent.com/u/10014498?v=4","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pysmt/pysmt","description":"pySMT: A library for SMT formulae manipulation and solving","fork":false,"url":"https://api.github.com/repos/pysmt/pysmt","forks_url":"https://api.github.com/repos/pysmt/pysmt/forks","keys_url":"https://api.github.com/repos/pysmt/pysmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pysmt/pysmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pysmt/pysmt/teams","hooks_url":"https://api.github.com/repos/pysmt/pysmt/hooks","issue_events_url":"https://api.github.com/repos/pysmt/pysmt/issues/events{/number}","events_url":"https://api.github.com/repos/pysmt/pysmt/events","assignees_url":"https://api.github.com/repos/pysmt/pysmt/assignees{/user}","branches_url":"https://api.github.com/repos/pysmt/pysmt/branches{/branch}","tags_url":"https://api.github.com/repos/pysmt/pysmt/tags","blobs_url":"https://api.github.com/repos/pysmt/pysmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pysmt/pysmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pysmt/pysmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pysmt/pysmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pysmt/pysmt/statuses/{sha}","languages_url":"https://api.github.com/repos/pysmt/pysmt/languages","stargazers_url":"https://api.github.com/repos/pysmt/pysmt/stargazers","contributors_url":"https://api.github.com/repos/pysmt/pysmt/contributors","subscribers_url":"https://api.github.com/repos/pysmt/pysmt/subscribers","subscription_url":"https://api.github.com/repos/pysmt/pysmt/subscription","commits_url":"https://api.github.com/repos/pysmt/pysmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pysmt/pysmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pysmt/pysmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pysmt/pysmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pysmt/pysmt/contents/{+path}","compare_url":"https://api.github.com/repos/pysmt/pysmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pysmt/pysmt/merges","archive_url":"https://api.github.com/repos/pysmt/pysmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pysmt/pysmt/downloads","issues_url":"https://api.github.com/repos/pysmt/pysmt/issues{/number}","pulls_url":"https://api.github.com/repos/pysmt/pysmt/pulls{/number}","milestones_url":"https://api.github.com/repos/pysmt/pysmt/milestones{/number}","notifications_url":"https://api.github.com/repos/pysmt/pysmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pysmt/pysmt/labels{/name}","releases_url":"https://api.github.com/repos/pysmt/pysmt/releases{/id}","deployments_url":"https://api.github.com/repos/pysmt/pysmt/deployments","created_at":"2014-12-01T02:52:26Z","updated_at":"2018-05-30T02:35:36Z","pushed_at":"2018-05-31T09:10:02Z","git_url":"git://github.com/pysmt/pysmt.git","ssh_url":"git@github.com:pysmt/pysmt.git","clone_url":"https://github.com/pysmt/pysmt.git","svn_url":"https://github.com/pysmt/pysmt","homepage":"http://www.pysmt.org","size":3720,"stargazers_count":149,"watchers_count":149,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":49,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/489"},"html":{"href":"https://github.com/pysmt/pysmt/pull/489"},"issue":{"href":"https://api.github.com/repos/pysmt/pysmt/issues/489"},"comments":{"href":"https://api.github.com/repos/pysmt/pysmt/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/pysmt/pysmt/statuses/a6944b96ecc5820db7ad2c8e09cf241dca7b7a2f"}},"author_association":"NONE"}}
{"actor":{"display_login":"mikand"}}