{"action":"created","comment":{"url":"https://api.github.com/repos/ros/resource_retriever/pulls/comments/173087538","pull_request_review_id":102214719,"id":173087538,"diff_hunk":"@@ -30,6 +30,7 @@ endif()\n # message(STATUS \"CURL_INCLUDE_DIRS: ${CURL_INCLUDE_DIRS}\")\n \n set(libcurl_vendor_LIBRARIES)\n+set(libcurl_abs ${CURL_LIBRARY_DIRS})","path":"libcurl_vendor/libcurl_vendor-extras.cmake.in","position":4,"original_position":4,"commit_id":"edbcb73e89743ac8b5ca2c3a4fd326b2d2fcd9de","original_commit_id":"edbcb73e89743ac8b5ca2c3a4fd326b2d2fcd9de","user":{"login":"davidhuziji","id":31985963,"avatar_url":"https://avatars0.githubusercontent.com/u/31985963?v=4","gravatar_id":"","url":"https://api.github.com/users/davidhuziji","html_url":"https://github.com/davidhuziji","followers_url":"https://api.github.com/users/davidhuziji/followers","following_url":"https://api.github.com/users/davidhuziji/following{/other_user}","gists_url":"https://api.github.com/users/davidhuziji/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhuziji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhuziji/subscriptions","organizations_url":"https://api.github.com/users/davidhuziji/orgs","repos_url":"https://api.github.com/users/davidhuziji/repos","events_url":"https://api.github.com/users/davidhuziji/events{/privacy}","received_events_url":"https://api.github.com/users/davidhuziji/received_events","type":"User","site_admin":false},"body":"Hi @amar-laksh, I guess it should be `library_abs` instead of `libcurl_abs`.","created_at":"2018-03-08T08:09:27Z","updated_at":"2018-03-08T08:14:42Z","html_url":"https://github.com/ros/resource_retriever/pull/17#discussion_r173087538","pull_request_url":"https://api.github.com/repos/ros/resource_retriever/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/comments/173087538"},"html":{"href":"https://github.com/ros/resource_retriever/pull/17#discussion_r173087538"},"pull_request":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/ros/resource_retriever/pulls/17","id":165505000,"html_url":"https://github.com/ros/resource_retriever/pull/17","diff_url":"https://github.com/ros/resource_retriever/pull/17.diff","patch_url":"https://github.com/ros/resource_retriever/pull/17.patch","issue_url":"https://api.github.com/repos/ros/resource_retriever/issues/17","number":17,"state":"open","locked":false,"title":"fix library_abs set to NOTFOUND; issue #15","user":{"login":"amar-laksh","id":12481356,"avatar_url":"https://avatars0.githubusercontent.com/u/12481356?v=4","gravatar_id":"","url":"https://api.github.com/users/amar-laksh","html_url":"https://github.com/amar-laksh","followers_url":"https://api.github.com/users/amar-laksh/followers","following_url":"https://api.github.com/users/amar-laksh/following{/other_user}","gists_url":"https://api.github.com/users/amar-laksh/gists{/gist_id}","starred_url":"https://api.github.com/users/amar-laksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amar-laksh/subscriptions","organizations_url":"https://api.github.com/users/amar-laksh/orgs","repos_url":"https://api.github.com/users/amar-laksh/repos","events_url":"https://api.github.com/users/amar-laksh/events{/privacy}","received_events_url":"https://api.github.com/users/amar-laksh/received_events","type":"User","site_admin":false},"body":"Here we go, Sorry for the earlier one.","created_at":"2018-01-27T06:01:02Z","updated_at":"2018-03-08T08:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6acab67bec8b5cf85ca408e2f9925591525e76b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/resource_retriever/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ros/resource_retriever/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ros/resource_retriever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/resource_retriever/issues/17/comments","statuses_url":"https://api.github.com/repos/ros/resource_retriever/statuses/edbcb73e89743ac8b5ca2c3a4fd326b2d2fcd9de","head":{"label":"amar-laksh:abs_library","ref":"abs_library","sha":"edbcb73e89743ac8b5ca2c3a4fd326b2d2fcd9de","user":{"login":"amar-laksh","id":12481356,"avatar_url":"https://avatars0.githubusercontent.com/u/12481356?v=4","gravatar_id":"","url":"https://api.github.com/users/amar-laksh","html_url":"https://github.com/amar-laksh","followers_url":"https://api.github.com/users/amar-laksh/followers","following_url":"https://api.github.com/users/amar-laksh/following{/other_user}","gists_url":"https://api.github.com/users/amar-laksh/gists{/gist_id}","starred_url":"https://api.github.com/users/amar-laksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amar-laksh/subscriptions","organizations_url":"https://api.github.com/users/amar-laksh/orgs","repos_url":"https://api.github.com/users/amar-laksh/repos","events_url":"https://api.github.com/users/amar-laksh/events{/privacy}","received_events_url":"https://api.github.com/users/amar-laksh/received_events","type":"User","site_admin":false},"repo":{"id":119137705,"name":"resource_retriever","full_name":"amar-laksh/resource_retriever","owner":{"login":"amar-laksh","id":12481356,"avatar_url":"https://avatars0.githubusercontent.com/u/12481356?v=4","gravatar_id":"","url":"https://api.github.com/users/amar-laksh","html_url":"https://github.com/amar-laksh","followers_url":"https://api.github.com/users/amar-laksh/followers","following_url":"https://api.github.com/users/amar-laksh/following{/other_user}","gists_url":"https://api.github.com/users/amar-laksh/gists{/gist_id}","starred_url":"https://api.github.com/users/amar-laksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amar-laksh/subscriptions","organizations_url":"https://api.github.com/users/amar-laksh/orgs","repos_url":"https://api.github.com/users/amar-laksh/repos","events_url":"https://api.github.com/users/amar-laksh/events{/privacy}","received_events_url":"https://api.github.com/users/amar-laksh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amar-laksh/resource_retriever","description":"Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.","fork":true,"url":"https://api.github.com/repos/amar-laksh/resource_retriever","forks_url":"https://api.github.com/repos/amar-laksh/resource_retriever/forks","keys_url":"https://api.github.com/repos/amar-laksh/resource_retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amar-laksh/resource_retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amar-laksh/resource_retriever/teams","hooks_url":"https://api.github.com/repos/amar-laksh/resource_retriever/hooks","issue_events_url":"https://api.github.com/repos/amar-laksh/resource_retriever/issues/events{/number}","events_url":"https://api.github.com/repos/amar-laksh/resource_retriever/events","assignees_url":"https://api.github.com/repos/amar-laksh/resource_retriever/assignees{/user}","branches_url":"https://api.github.com/repos/amar-laksh/resource_retriever/branches{/branch}","tags_url":"https://api.github.com/repos/amar-laksh/resource_retriever/tags","blobs_url":"https://api.github.com/repos/amar-laksh/resource_retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amar-laksh/resource_retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amar-laksh/resource_retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/amar-laksh/resource_retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amar-laksh/resource_retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/amar-laksh/resource_retriever/languages","stargazers_url":"https://api.github.com/repos/amar-laksh/resource_retriever/stargazers","contributors_url":"https://api.github.com/repos/amar-laksh/resource_retriever/contributors","subscribers_url":"https://api.github.com/repos/amar-laksh/resource_retriever/subscribers","subscription_url":"https://api.github.com/repos/amar-laksh/resource_retriever/subscription","commits_url":"https://api.github.com/repos/amar-laksh/resource_retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/amar-laksh/resource_retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/amar-laksh/resource_retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/amar-laksh/resource_retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/amar-laksh/resource_retriever/contents/{+path}","compare_url":"https://api.github.com/repos/amar-laksh/resource_retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amar-laksh/resource_retriever/merges","archive_url":"https://api.github.com/repos/amar-laksh/resource_retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amar-laksh/resource_retriever/downloads","issues_url":"https://api.github.com/repos/amar-laksh/resource_retriever/issues{/number}","pulls_url":"https://api.github.com/repos/amar-laksh/resource_retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/amar-laksh/resource_retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/amar-laksh/resource_retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amar-laksh/resource_retriever/labels{/name}","releases_url":"https://api.github.com/repos/amar-laksh/resource_retriever/releases{/id}","deployments_url":"https://api.github.com/repos/amar-laksh/resource_retriever/deployments","created_at":"2018-01-27T05:59:08Z","updated_at":"2018-01-27T05:59:10Z","pushed_at":"2018-01-27T06:00:00Z","git_url":"git://github.com/amar-laksh/resource_retriever.git","ssh_url":"git@github.com:amar-laksh/resource_retriever.git","clone_url":"https://github.com/amar-laksh/resource_retriever.git","svn_url":"https://github.com/amar-laksh/resource_retriever","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros:ros2","ref":"ros2","sha":"48193d38ce446cd2417a9c1fd5b43f665bd942fd","user":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":34307331,"name":"resource_retriever","full_name":"ros/resource_retriever","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/resource_retriever","description":"Package used to retrieve resources of different kinds, e.g. http://, file://, the ROS specific package://, etc.","fork":false,"url":"https://api.github.com/repos/ros/resource_retriever","forks_url":"https://api.github.com/repos/ros/resource_retriever/forks","keys_url":"https://api.github.com/repos/ros/resource_retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/resource_retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/resource_retriever/teams","hooks_url":"https://api.github.com/repos/ros/resource_retriever/hooks","issue_events_url":"https://api.github.com/repos/ros/resource_retriever/issues/events{/number}","events_url":"https://api.github.com/repos/ros/resource_retriever/events","assignees_url":"https://api.github.com/repos/ros/resource_retriever/assignees{/user}","branches_url":"https://api.github.com/repos/ros/resource_retriever/branches{/branch}","tags_url":"https://api.github.com/repos/ros/resource_retriever/tags","blobs_url":"https://api.github.com/repos/ros/resource_retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/resource_retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/resource_retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/resource_retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/resource_retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/resource_retriever/languages","stargazers_url":"https://api.github.com/repos/ros/resource_retriever/stargazers","contributors_url":"https://api.github.com/repos/ros/resource_retriever/contributors","subscribers_url":"https://api.github.com/repos/ros/resource_retriever/subscribers","subscription_url":"https://api.github.com/repos/ros/resource_retriever/subscription","commits_url":"https://api.github.com/repos/ros/resource_retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/resource_retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/resource_retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/resource_retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/resource_retriever/contents/{+path}","compare_url":"https://api.github.com/repos/ros/resource_retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/resource_retriever/merges","archive_url":"https://api.github.com/repos/ros/resource_retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/resource_retriever/downloads","issues_url":"https://api.github.com/repos/ros/resource_retriever/issues{/number}","pulls_url":"https://api.github.com/repos/ros/resource_retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/resource_retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/resource_retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/resource_retriever/labels{/name}","releases_url":"https://api.github.com/repos/ros/resource_retriever/releases{/id}","deployments_url":"https://api.github.com/repos/ros/resource_retriever/deployments","created_at":"2015-04-21T05:53:52Z","updated_at":"2016-12-09T15:13:21Z","pushed_at":"2018-02-08T17:06:47Z","git_url":"git://github.com/ros/resource_retriever.git","ssh_url":"git@github.com:ros/resource_retriever.git","clone_url":"https://github.com/ros/resource_retriever.git","svn_url":"https://github.com/ros/resource_retriever","homepage":null,"size":71,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":12,"open_issues":3,"watchers":2,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/17"},"html":{"href":"https://github.com/ros/resource_retriever/pull/17"},"issue":{"href":"https://api.github.com/repos/ros/resource_retriever/issues/17"},"comments":{"href":"https://api.github.com/repos/ros/resource_retriever/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/resource_retriever/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ros/resource_retriever/statuses/edbcb73e89743ac8b5ca2c3a4fd326b2d2fcd9de"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidhuziji"}}