{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/184927661","pull_request_review_id":116216222,"id":184927661,"diff_hunk":"@@ -23,7 +23,19 @@ s3_clean() {\n         '\n }\n \n+bootstrap_cleanup() {\n+    rm /etc/systemd/system/multi-user.target.wants/tectonic.path\n+    rm /etc/systemd/system/multi-user.target.wants/bootkube.path\n+    rm /etc/systemd/system/multi-user.target.wants/rm-assets.path\n+    rm /etc/systemd/system/tectonic.{path,service}\n+    rm /etc/systemd/system/bootkube.{path,service}\n+    rm /etc/systemd/system/rm-assets.{path,service}\n+    rm -rf /opt/tectonic","path":"steps/assets/resources/rm-assets.sh","position":11,"original_position":11,"commit_id":"443cc176a4806a90afaf7cebaf6c91750a13c7c3","original_commit_id":"443cc176a4806a90afaf7cebaf6c91750a13c7c3","user":{"login":"enxebre","id":1230698,"avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"body":"The tests look for /opt/tectonic/init_tectonic.done and /opt/tectonic/init_bootkube.done to determine the services were run successfully, this might be introducing a race?","created_at":"2018-04-30T07:58:24Z","updated_at":"2018-04-30T07:58:25Z","html_url":"https://github.com/coreos/tectonic-installer/pull/3211#discussion_r184927661","pull_request_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/184927661"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/3211#discussion_r184927661"},"pull_request":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211","id":184601032,"html_url":"https://github.com/coreos/tectonic-installer/pull/3211","diff_url":"https://github.com/coreos/tectonic-installer/pull/3211.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/3211.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/3211","number":3211,"state":"open","locked":false,"title":"steps: bootstrap cleanup","user":{"login":"squat","id":20484159,"avatar_url":"https://avatars1.githubusercontent.com/u/20484159?v=4","gravatar_id":"","url":"https://api.github.com/users/squat","html_url":"https://github.com/squat","followers_url":"https://api.github.com/users/squat/followers","following_url":"https://api.github.com/users/squat/following{/other_user}","gists_url":"https://api.github.com/users/squat/gists{/gist_id}","starred_url":"https://api.github.com/users/squat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squat/subscriptions","organizations_url":"https://api.github.com/users/squat/orgs","repos_url":"https://api.github.com/users/squat/repos","events_url":"https://api.github.com/users/squat/events{/privacy}","received_events_url":"https://api.github.com/users/squat/received_events","type":"User","site_admin":false},"body":"Cleanup bootstrap node\r\nFixes: INST-956\r\n\r\ncc @enxebre @squeed ","created_at":"2018-04-27T11:54:19Z","updated_at":"2018-04-30T07:58:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec56455cf4f3c2cc550933119efffaaa3d7c3cd1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":557217031,"url":"https://api.github.com/repos/coreos/tectonic-installer/labels/platform/aws","name":"platform/aws","color":"f9d0c4","default":false},{"id":666829262,"url":"https://api.github.com/repos/coreos/tectonic-installer/labels/run-smoke-tests","name":"run-smoke-tests","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/3211/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/443cc176a4806a90afaf7cebaf6c91750a13c7c3","head":{"label":"squat:cleanup","ref":"cleanup","sha":"443cc176a4806a90afaf7cebaf6c91750a13c7c3","user":{"login":"squat","id":20484159,"avatar_url":"https://avatars1.githubusercontent.com/u/20484159?v=4","gravatar_id":"","url":"https://api.github.com/users/squat","html_url":"https://github.com/squat","followers_url":"https://api.github.com/users/squat/followers","following_url":"https://api.github.com/users/squat/following{/other_user}","gists_url":"https://api.github.com/users/squat/gists{/gist_id}","starred_url":"https://api.github.com/users/squat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squat/subscriptions","organizations_url":"https://api.github.com/users/squat/orgs","repos_url":"https://api.github.com/users/squat/repos","events_url":"https://api.github.com/users/squat/events{/privacy}","received_events_url":"https://api.github.com/users/squat/received_events","type":"User","site_admin":false},"repo":{"id":86737556,"name":"tectonic-installer","full_name":"squat/tectonic-installer","owner":{"login":"squat","id":20484159,"avatar_url":"https://avatars1.githubusercontent.com/u/20484159?v=4","gravatar_id":"","url":"https://api.github.com/users/squat","html_url":"https://github.com/squat","followers_url":"https://api.github.com/users/squat/followers","following_url":"https://api.github.com/users/squat/following{/other_user}","gists_url":"https://api.github.com/users/squat/gists{/gist_id}","starred_url":"https://api.github.com/users/squat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squat/subscriptions","organizations_url":"https://api.github.com/users/squat/orgs","repos_url":"https://api.github.com/users/squat/repos","events_url":"https://api.github.com/users/squat/events{/privacy}","received_events_url":"https://api.github.com/users/squat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squat/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":true,"url":"https://api.github.com/repos/squat/tectonic-installer","forks_url":"https://api.github.com/repos/squat/tectonic-installer/forks","keys_url":"https://api.github.com/repos/squat/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squat/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squat/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/squat/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/squat/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/squat/tectonic-installer/events","assignees_url":"https://api.github.com/repos/squat/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/squat/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/squat/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/squat/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squat/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squat/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/squat/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squat/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/squat/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/squat/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/squat/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/squat/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/squat/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/squat/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/squat/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/squat/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/squat/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/squat/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/squat/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squat/tectonic-installer/merges","archive_url":"https://api.github.com/repos/squat/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squat/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/squat/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/squat/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/squat/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/squat/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squat/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/squat/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/squat/tectonic-installer/deployments","created_at":"2017-03-30T18:51:46Z","updated_at":"2018-03-13T09:57:36Z","pushed_at":"2018-04-27T11:52:39Z","git_url":"git://github.com/squat/tectonic-installer.git","ssh_url":"git@github.com:squat/tectonic-installer.git","clone_url":"https://github.com/squat/tectonic-installer.git","svn_url":"https://github.com/squat/tectonic-installer","homepage":"","size":35591,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"bd3c81bababebdf9fae5ba66a0c6581ed275d32e","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":81620471,"name":"tectonic-installer","full_name":"coreos/tectonic-installer","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-installer","forks_url":"https://api.github.com/repos/coreos/tectonic-installer/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-installer/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-installer/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-installer/deployments","created_at":"2017-02-11T00:52:23Z","updated_at":"2018-04-29T00:36:19Z","pushed_at":"2018-04-28T00:20:19Z","git_url":"git://github.com/coreos/tectonic-installer.git","ssh_url":"git@github.com:coreos/tectonic-installer.git","clone_url":"https://github.com/coreos/tectonic-installer.git","svn_url":"https://github.com/coreos/tectonic-installer","homepage":"","size":35889,"stargazers_count":495,"watchers_count":495,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":183,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":276,"open_issues":183,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/3211"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/3211"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/3211/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/3211/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-installer/statuses/443cc176a4806a90afaf7cebaf6c91750a13c7c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"enxebre"}}