{"action":"opened","number":241,"pull_request":{"url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241","id":220052736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDUyNzM2","html_url":"https://github.com/juju-solutions/kubernetes-jenkins/pull/241","diff_url":"https://github.com/juju-solutions/kubernetes-jenkins/pull/241.diff","patch_url":"https://github.com/juju-solutions/kubernetes-jenkins/pull/241.patch","issue_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/241","number":241,"state":"open","locked":false,"title":"Fix validate_rbac not waiting for all apiservers to restart","user":{"login":"Cynerva","id":2251600,"node_id":"MDQ6VXNlcjIyNTE2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2251600?v=4","gravatar_id":"","url":"https://api.github.com/users/Cynerva","html_url":"https://github.com/Cynerva","followers_url":"https://api.github.com/users/Cynerva/followers","following_url":"https://api.github.com/users/Cynerva/following{/other_user}","gists_url":"https://api.github.com/users/Cynerva/gists{/gist_id}","starred_url":"https://api.github.com/users/Cynerva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cynerva/subscriptions","organizations_url":"https://api.github.com/users/Cynerva/orgs","repos_url":"https://api.github.com/users/Cynerva/repos","events_url":"https://api.github.com/users/Cynerva/events{/privacy}","received_events_url":"https://api.github.com/users/Cynerva/received_events","type":"User","site_admin":false},"body":"This hopefully fixes the following error seen in CI:\r\n\r\n```\r\n[2018-10-02 23:22:24] RAISE validation.validate_rbac <juju.model.Model object at 0x7fe0d8931fd0>\r\n     async def validate_rbac(model):\r\n         ''' Validate RBAC is actually on '''\r\n         app = model.applications['kubernetes-master']\r\n         await app.set_config({'authorization-mode': 'RBAC,Node'})\r\n         await wait_for_process(model, 'RBAC')\r\n         cmd = \"/snap/bin/kubectl --kubeconfig /root/cdk/kubeconfig get clusterroles\"\r\n         worker = model.applications['kubernetes-worker'].units[0]\r\n         output = await worker.run(cmd)\r\n         assert output.status == 'completed'\r\n         assert \"forbidden\" in output.data['results']['Stderr'].lower()\r\n         await app.set_config({'authorization-mode': 'AlwaysAllow'})\r\n         await wait_for_process(model, 'AlwaysAllow')\r\n         output = await worker.run(cmd)\r\n         assert output.status == 'completed'\r\n >       assert \"forbidden\" not in output.data['results']['Stderr']\r\n E       AssertionError\r\n```\r\n\r\nIt looks like `api_server_with_arg` (which is invoked via `wait_for_process`) is only waiting for the apiserver on the first unit, not all of them. I suspect the `forbidden` response came from an apiserver that had not restarted yet.\r\n\r\nThis fixes `api_server_with_arg` to wait for all units, not just the first one.","created_at":"2018-10-03T14:12:26Z","updated_at":"2018-10-03T14:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241/commits","review_comments_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241/comments","review_comment_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/241/comments","statuses_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/statuses/55e0f83cbb1020edb7a9e4a2fad46f33f4d3941c","head":{"label":"Cynerva:gkk/fix-validate-rbac-not-waiting-all-masters","ref":"gkk/fix-validate-rbac-not-waiting-all-masters","sha":"55e0f83cbb1020edb7a9e4a2fad46f33f4d3941c","user":{"login":"Cynerva","id":2251600,"node_id":"MDQ6VXNlcjIyNTE2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2251600?v=4","gravatar_id":"","url":"https://api.github.com/users/Cynerva","html_url":"https://github.com/Cynerva","followers_url":"https://api.github.com/users/Cynerva/followers","following_url":"https://api.github.com/users/Cynerva/following{/other_user}","gists_url":"https://api.github.com/users/Cynerva/gists{/gist_id}","starred_url":"https://api.github.com/users/Cynerva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cynerva/subscriptions","organizations_url":"https://api.github.com/users/Cynerva/orgs","repos_url":"https://api.github.com/users/Cynerva/repos","events_url":"https://api.github.com/users/Cynerva/events{/privacy}","received_events_url":"https://api.github.com/users/Cynerva/received_events","type":"User","site_admin":false},"repo":{"id":148226894,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMjY4OTQ=","name":"kubernetes-jenkins","full_name":"Cynerva/kubernetes-jenkins","private":false,"owner":{"login":"Cynerva","id":2251600,"node_id":"MDQ6VXNlcjIyNTE2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2251600?v=4","gravatar_id":"","url":"https://api.github.com/users/Cynerva","html_url":"https://github.com/Cynerva","followers_url":"https://api.github.com/users/Cynerva/followers","following_url":"https://api.github.com/users/Cynerva/following{/other_user}","gists_url":"https://api.github.com/users/Cynerva/gists{/gist_id}","starred_url":"https://api.github.com/users/Cynerva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cynerva/subscriptions","organizations_url":"https://api.github.com/users/Cynerva/orgs","repos_url":"https://api.github.com/users/Cynerva/repos","events_url":"https://api.github.com/users/Cynerva/events{/privacy}","received_events_url":"https://api.github.com/users/Cynerva/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Cynerva/kubernetes-jenkins","description":"The scripts to build and test kubernetes in jenkins.","fork":true,"url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins","forks_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/forks","keys_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/teams","hooks_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/hooks","issue_events_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/events","assignees_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/tags","blobs_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/languages","stargazers_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/stargazers","contributors_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/contributors","subscribers_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/subscribers","subscription_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/subscription","commits_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/merges","archive_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/downloads","issues_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/Cynerva/kubernetes-jenkins/deployments","created_at":"2018-09-10T22:27:28Z","updated_at":"2018-09-10T22:27:30Z","pushed_at":"2018-10-03T14:04:47Z","git_url":"git://github.com/Cynerva/kubernetes-jenkins.git","ssh_url":"git@github.com:Cynerva/kubernetes-jenkins.git","clone_url":"https://github.com/Cynerva/kubernetes-jenkins.git","svn_url":"https://github.com/Cynerva/kubernetes-jenkins","homepage":null,"size":476,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju-solutions:master","ref":"master","sha":"678ff0f2711fab105001b5fa9ec338bed268824c","user":{"login":"juju-solutions","id":8684561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODQ1NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8684561?v=4","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":75317284,"node_id":"MDEwOlJlcG9zaXRvcnk3NTMxNzI4NA==","name":"kubernetes-jenkins","full_name":"juju-solutions/kubernetes-jenkins","private":false,"owner":{"login":"juju-solutions","id":8684561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODQ1NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8684561?v=4","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/juju-solutions/kubernetes-jenkins","description":"The scripts to build and test kubernetes in jenkins.","fork":false,"url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins","forks_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/forks","keys_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/teams","hooks_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/events","assignees_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/tags","blobs_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/subscription","commits_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/merges","archive_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/downloads","issues_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/deployments","created_at":"2016-12-01T17:44:24Z","updated_at":"2018-09-20T20:28:41Z","pushed_at":"2018-10-03T08:08:00Z","git_url":"git://github.com/juju-solutions/kubernetes-jenkins.git","ssh_url":"git@github.com:juju-solutions/kubernetes-jenkins.git","clone_url":"https://github.com/juju-solutions/kubernetes-jenkins.git","svn_url":"https://github.com/juju-solutions/kubernetes-jenkins","homepage":null,"size":502,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":9,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241"},"html":{"href":"https://github.com/juju-solutions/kubernetes-jenkins/pull/241"},"issue":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/241"},"comments":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/juju-solutions/kubernetes-jenkins/statuses/55e0f83cbb1020edb7a9e4a2fad46f33f4d3941c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Cynerva"}}