{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments/223214708","pull_request_review_id":162291379,"id":223214708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIxNDcwOA==","diff_hunk":"@@ -62,6 +62,57 @@ extension RxTest {\n         XCTAssertTrue(comparer(initialValue, lastReturnedPropertyValue), \"last property value (\\(lastReturnedPropertyValue)) does not match initial value (\\(initialValue))\", file: file, line: line)\n     }\n \n+    func ensurePropertyDeallocated<C, T: Equatable>(_ createControl: () -> C,\n+                                                    _ initialValue: T,\n+                                                    timeout seconds: TimeInterval,\n+                                                    file: StaticString = #file,\n+                                                    line: UInt = #line,\n+                                                    _ propertySelector: (C) -> ControlProperty<T>) where C: NSObject {\n+\n+        ensurePropertyDeallocated(createControl, initialValue, timeout: seconds, comparer: ==, file: file, line: line, propertySelector)\n+    }\n+\n+    func ensurePropertyDeallocated<C, T>(_ createControl: () -> C,\n+                                         _ initialValue: T,\n+                                         timeout seconds: TimeInterval,\n+                                         comparer: (T, T) -> Bool,\n+                                         file: StaticString = #file,\n+                                         line: UInt = #line,\n+                                         _ propertySelector: (C) -> ControlProperty<T>) where C: NSObject  {\n+\n+        let variable = Variable(initialValue)\n+\n+        let completeExpectation = XCTestExpectation(description: \"completion\")\n+        let deallocateExpectation = XCTestExpectation(description: \"deallocation\")\n+        var lastReturnedPropertyValue: T!\n+\n+        autoreleasepool {\n+            var control: C! = createControl()\n+\n+            let property = propertySelector(control)\n+\n+            let disposable = variable.asObservable().bind(to: property)\n+\n+            _ = property.subscribe(onNext: { n in\n+                lastReturnedPropertyValue = n\n+            }, onCompleted: {\n+                completeExpectation.fulfill()\n+                disposable.dispose()\n+            })\n+\n+\n+            _ = (control as NSObject).rx.deallocated.subscribe(onNext: { _ in\n+                deallocateExpectation.fulfill()\n+            })\n+\n+            control = nil\n+        }\n+\n+        wait(for: [completeExpectation, deallocateExpectation], timeout: seconds, enforceOrder: true)","path":"Tests/RxCocoaTests/RxTest+Controls.swift","position":50,"original_position":50,"commit_id":"8daff0648b3ec356015a2d10332af89d6248e3e1","original_commit_id":"8f493cc61656a0eb77ac022c7267bf2da11f2db8","user":{"login":"kzaher","id":1641148,"node_id":"MDQ6VXNlcjE2NDExNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1641148?v=4","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"body":"> Seems that wait(for:timeout:enforceOrder:) function doesn't have file and line parameters.\r\n\r\nMaybe I'm overlooking something, why is this important?","created_at":"2018-10-07T14:00:40Z","updated_at":"2018-10-07T14:00:40Z","html_url":"https://github.com/ReactiveX/RxSwift/pull/1713#discussion_r223214708","pull_request_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments/223214708"},"html":{"href":"https://github.com/ReactiveX/RxSwift/pull/1713#discussion_r223214708"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713"}},"in_reply_to_id":222397398},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713","id":206276755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mjc2NzU1","html_url":"https://github.com/ReactiveX/RxSwift/pull/1713","diff_url":"https://github.com/ReactiveX/RxSwift/pull/1713.diff","patch_url":"https://github.com/ReactiveX/RxSwift/pull/1713.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1713","number":1713,"state":"open","locked":false,"title":"Add `string` to `NSTextView`","user":{"login":"Cee","id":5436953,"node_id":"MDQ6VXNlcjU0MzY5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5436953?v=4","gravatar_id":"","url":"https://api.github.com/users/Cee","html_url":"https://github.com/Cee","followers_url":"https://api.github.com/users/Cee/followers","following_url":"https://api.github.com/users/Cee/following{/other_user}","gists_url":"https://api.github.com/users/Cee/gists{/gist_id}","starred_url":"https://api.github.com/users/Cee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cee/subscriptions","organizations_url":"https://api.github.com/users/Cee/orgs","repos_url":"https://api.github.com/users/Cee/repos","events_url":"https://api.github.com/users/Cee/events{/privacy}","received_events_url":"https://api.github.com/users/Cee/received_events","type":"User","site_admin":false},"body":"**TL;DR**: Add an Rx `string` property to `NSTextView`.\r\n\r\nMainly did several things to this pr:\r\n- Added an extension to `NSTextView` called `NSTextView+Rx.swift`.\r\n- Wrote a test for `NSTextView+Rx.swift`.\r\n- Made `<->` two-way binding operator exposed to both iOS and macOS.\r\n- Completed the macOS example of synchronizing text between two different `NSTextView`s.\r\n\r\n![untitled](https://user-images.githubusercontent.com/5436953/43694471-8693dc66-9901-11e8-94e5-9d98ca10aff3.gif)\r\n","created_at":"2018-08-06T02:47:36Z","updated_at":"2018-10-07T14:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf0f3eb0bc12039cd5248b547962e1044ea90f5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1713/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/8daff0648b3ec356015a2d10332af89d6248e3e1","head":{"label":"Cee:cee/NSTextView","ref":"cee/NSTextView","sha":"8daff0648b3ec356015a2d10332af89d6248e3e1","user":{"login":"Cee","id":5436953,"node_id":"MDQ6VXNlcjU0MzY5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5436953?v=4","gravatar_id":"","url":"https://api.github.com/users/Cee","html_url":"https://github.com/Cee","followers_url":"https://api.github.com/users/Cee/followers","following_url":"https://api.github.com/users/Cee/following{/other_user}","gists_url":"https://api.github.com/users/Cee/gists{/gist_id}","starred_url":"https://api.github.com/users/Cee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cee/subscriptions","organizations_url":"https://api.github.com/users/Cee/orgs","repos_url":"https://api.github.com/users/Cee/repos","events_url":"https://api.github.com/users/Cee/events{/privacy}","received_events_url":"https://api.github.com/users/Cee/received_events","type":"User","site_admin":false},"repo":{"id":143046332,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDYzMzI=","name":"RxSwift","full_name":"Cee/RxSwift","private":false,"owner":{"login":"Cee","id":5436953,"node_id":"MDQ6VXNlcjU0MzY5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5436953?v=4","gravatar_id":"","url":"https://api.github.com/users/Cee","html_url":"https://github.com/Cee","followers_url":"https://api.github.com/users/Cee/followers","following_url":"https://api.github.com/users/Cee/following{/other_user}","gists_url":"https://api.github.com/users/Cee/gists{/gist_id}","starred_url":"https://api.github.com/users/Cee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cee/subscriptions","organizations_url":"https://api.github.com/users/Cee/orgs","repos_url":"https://api.github.com/users/Cee/repos","events_url":"https://api.github.com/users/Cee/events{/privacy}","received_events_url":"https://api.github.com/users/Cee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Cee/RxSwift","description":"Reactive Programming in Swift","fork":true,"url":"https://api.github.com/repos/Cee/RxSwift","forks_url":"https://api.github.com/repos/Cee/RxSwift/forks","keys_url":"https://api.github.com/repos/Cee/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cee/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cee/RxSwift/teams","hooks_url":"https://api.github.com/repos/Cee/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/Cee/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/Cee/RxSwift/events","assignees_url":"https://api.github.com/repos/Cee/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/Cee/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/Cee/RxSwift/tags","blobs_url":"https://api.github.com/repos/Cee/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cee/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cee/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cee/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cee/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/Cee/RxSwift/languages","stargazers_url":"https://api.github.com/repos/Cee/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/Cee/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/Cee/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/Cee/RxSwift/subscription","commits_url":"https://api.github.com/repos/Cee/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cee/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cee/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cee/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cee/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/Cee/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cee/RxSwift/merges","archive_url":"https://api.github.com/repos/Cee/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cee/RxSwift/downloads","issues_url":"https://api.github.com/repos/Cee/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/Cee/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/Cee/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/Cee/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cee/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/Cee/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/Cee/RxSwift/deployments","created_at":"2018-07-31T17:32:39Z","updated_at":"2018-09-04T13:09:41Z","pushed_at":"2018-10-04T05:26:58Z","git_url":"git://github.com/Cee/RxSwift.git","ssh_url":"git@github.com:Cee/RxSwift.git","clone_url":"https://github.com/Cee/RxSwift.git","svn_url":"https://github.com/Cee/RxSwift","homepage":"","size":12664,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:develop","ref":"develop","sha":"16ea4bde86b386e5758aaf14c3f229f315f275bf","user":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":33569135,"node_id":"MDEwOlJlcG9zaXRvcnkzMzU2OTEzNQ==","name":"RxSwift","full_name":"ReactiveX/RxSwift","private":false,"owner":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ReactiveX/RxSwift","description":"Reactive Programming in Swift","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxSwift","forks_url":"https://api.github.com/repos/ReactiveX/RxSwift/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxSwift/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxSwift/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxSwift/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxSwift/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxSwift/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/RxSwift/deployments","created_at":"2015-04-07T21:25:17Z","updated_at":"2018-10-07T12:02:47Z","pushed_at":"2018-10-06T18:09:40Z","git_url":"git://github.com/ReactiveX/RxSwift.git","ssh_url":"git@github.com:ReactiveX/RxSwift.git","clone_url":"https://github.com/ReactiveX/RxSwift.git","svn_url":"https://github.com/ReactiveX/RxSwift","homepage":"","size":12605,"stargazers_count":14610,"watchers_count":14610,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2366,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2366,"open_issues":36,"watchers":14610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713"},"html":{"href":"https://github.com/ReactiveX/RxSwift/pull/1713"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1713"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1713/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1713/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/8daff0648b3ec356015a2d10332af89d6248e3e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kzaher"}}