{"action":"created","issue":{"url":"https://api.github.com/repos/poanetwork/poa-popa/issues/116","repository_url":"https://api.github.com/repos/poanetwork/poa-popa","labels_url":"https://api.github.com/repos/poanetwork/poa-popa/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/poanetwork/poa-popa/issues/116/comments","events_url":"https://api.github.com/repos/poanetwork/poa-popa/issues/116/events","html_url":"https://github.com/poanetwork/poa-popa/pull/116","id":316889652,"number":116,"title":"(Feature) Show spinner when confirming and removing addresses","user":{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false},"labels":[{"id":829302353,"url":"https://api.github.com/repos/poanetwork/poa-popa/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false},"assignees":[{"login":"fvictorio","id":417134,"avatar_url":"https://avatars1.githubusercontent.com/u/417134?v=4","gravatar_id":"","url":"https://api.github.com/users/fvictorio","html_url":"https://github.com/fvictorio","followers_url":"https://api.github.com/users/fvictorio/followers","following_url":"https://api.github.com/users/fvictorio/following{/other_user}","gists_url":"https://api.github.com/users/fvictorio/gists{/gist_id}","starred_url":"https://api.github.com/users/fvictorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvictorio/subscriptions","organizations_url":"https://api.github.com/users/fvictorio/orgs","repos_url":"https://api.github.com/users/fvictorio/repos","events_url":"https://api.github.com/users/fvictorio/events{/privacy}","received_events_url":"https://api.github.com/users/fvictorio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-23T16:33:17Z","updated_at":"2018-04-23T16:40:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/poanetwork/poa-popa/pulls/116","html_url":"https://github.com/poanetwork/poa-popa/pull/116","diff_url":"https://github.com/poanetwork/poa-popa/pull/116.diff","patch_url":"https://github.com/poanetwork/poa-popa/pull/116.patch"},"body":"After confirming or removing an address, wait for the transaction to be mined before hiding the spinner.\r\n\r\nThis is not a big change, but it seems to add some level of async that made a lot of test fail. I added a bunch of `setTimeout`s to make them pass (so that the expects are called after every async funtion was called), but I'm not a fan of this solution. Please let me know if you know a better way to do this."},"comment":{"url":"https://api.github.com/repos/poanetwork/poa-popa/issues/comments/383641746","html_url":"https://github.com/poanetwork/poa-popa/pull/116#issuecomment-383641746","issue_url":"https://api.github.com/repos/poanetwork/poa-popa/issues/116","id":383641746,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T16:40:39Z","updated_at":"2018-04-23T16:40:39Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 368](https://coveralls.io/builds/16653263)\n\n* **29** of **34**  **(85.29%)** changed or added relevant lines in **2** files are covered.\n* No unchanged relevant lines lost coverage.\n* Overall coverage decreased (**-0.05%**) to **74.206%**\n\n---\n\n|  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |\n| :-----|--------------|--------|---: |\n| [web-dapp/src/components/MyAddressesPage.js](https://coveralls.io/builds/16653263/source?filename=web-dapp%2Fsrc%2Fcomponents%2FMyAddressesPage.js#L125) | 3 | 5 | 60.0%\n| [web-dapp/src/components/ConfirmationPage.js](https://coveralls.io/builds/16653263/source?filename=web-dapp%2Fsrc%2Fcomponents%2FConfirmationPage.js#L137) | 26 | 29 | 89.66%\n<!-- | **Total:** | **29** | **34** | **85.29%** | -->\n\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/16653263/badge)](https://coveralls.io/builds/16653263) |\n| :-- | --: |\n| Change from base [Build 366](https://coveralls.io/builds/16651805): |  -0.05% |\n| Covered Lines: | 881 |\n| Relevant Lines: | 1136 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}