{"push_id":3165273793,"size":1,"distinct_size":1,"ref":"refs/heads/18.05.x","head":"e2cfc2615c119252e5c317059312c0d020f2924f","before":"b89e7f3a2741390ca1acf7f254f058883d7b957c","commits":[{"sha":"e2cfc2615c119252e5c317059312c0d020f2924f","author":{"name":"Jonathan Druart","email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org"},"message":"Bug 21986: Do not escape quotation marks when cataloguing\n\nIn several places we escape quotation marks using\n  $value =~ s/\"/&quot;/g;\nAll the occurrences are wrong and must be removed.\nMost of them are leftover of bug 11638 (Remove HTML from\naddbiblio.pl), which removes the construction of html from pl scripts.\n\nThe problem has been highlighted by bug 13618, I did not track down why\nthe issue did not exist before (?)\n\nTest plan:\n0/ Use strings with quotation marks, like:\n'Fiddle tune history : \"bad\" tunes'\nYou can also use other html characters to make the tests more complete,\nlike 'Fiddle tune history : <\"bad\" tunes>'\n1/ authorities/authorities.pl\na. Edit an authority filling different fields with quotation marks\nb. Edit it again\n=> The display (inputs' values) is wrong, if you save the escaped quotes\nwill be inserted\n2/ cataloguing/addbiblio.pl\nSame editing a bibliographic record\n3/ cataloguing/additem.pl\nSame editing items\n4/ members/memberentry.pl\nEdit a patron's record and fill some fields with quotation marks\n+ fields borrowernotes and opacnotes\n=> The quotes are inserted directly in DB (escape is done before the\ninsert!)\n5/ opac/opac-review.pl\nFor QA only: $js_ok_review is never used\n6/ tools/batchMod.pl\nFor QA only: $value is always undefined at that point\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\n(cherry picked from commit d561273ef84f4bc2534ac63d0f8793c9eb2a7fb9)\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\n(cherry picked from commit 305729fdc04c723b2eb372441500d3151e1a62d3)\n\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/e2cfc2615c119252e5c317059312c0d020f2924f"}]}
{"actor":{"display_login":"gmcharlt"}}