{"action":"created","comment":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/243141302","pull_request_review_id":186830233,"id":243141302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE0MTMwMg==","diff_hunk":"@@ -131,6 +134,13 @@ public PendingTransactions getPendingTransactions() {\n       return basicValidationResult;\n     }\n \n+    String sender = transaction.getSender().toString();\n+    if (!checkIfAccountIsWhitelisted(sender)) {","path":"ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/core/TransactionPool.java","position":null,"original_position":28,"commit_id":"26f83ed51c5b21a14a3ee90757afa51c7a9167dc","original_commit_id":"1e5704965e9c995b72d14709ff62c241f1c24771","user":{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false},"body":"actioned","created_at":"2018-12-20T02:38:16Z","updated_at":"2018-12-20T02:38:16Z","html_url":"https://github.com/PegaSysEng/pantheon/pull/460#discussion_r243141302","pull_request_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/243141302"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/460#discussion_r243141302"},"pull_request":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460"}},"in_reply_to_id":243135265},"pull_request":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460","id":239724051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzI0MDUx","html_url":"https://github.com/PegaSysEng/pantheon/pull/460","diff_url":"https://github.com/PegaSysEng/pantheon/pull/460.diff","patch_url":"https://github.com/PegaSysEng/pantheon/pull/460.patch","issue_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/460","number":460,"state":"open","locked":false,"title":"Nc 1942 Add account whitelisting and refactor into permissioning package","user":{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->\r\n<!-- https://github.com/PegaSysEng/pantheon/blob/master/CONTRIBUTING.md -->\r\n\r\n## PR description\r\nCreate account whitelisting serving as the groundwork for role based permissioning system for transactions\r\n\r\nInclude:\r\n- \"--accounts-whitelisting\" config on startup\r\n- logic to reject transaction on validation when using account whitelist is active\r\n- Unit testing\r\n- refactor account whitelisting from p2p to permissioning package\r\n\r\n## Fixed Issue(s)\r\n<!-- Please link to fixed issue(s) here using format: Added Account whitelisting #<NC-1942> -->\r\n<!-- Example: \"fixes #2\" -->\r\n","created_at":"2018-12-19T06:19:29Z","updated_at":"2018-12-20T02:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad4e98e7189df4825e6c6cc92f758c1cc456dd5","assignee":{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460/commits","review_comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460/comments","review_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/460/comments","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/26f83ed51c5b21a14a3ee90757afa51c7a9167dc","head":{"label":"Shinabyss:NC-1942","ref":"NC-1942","sha":"26f83ed51c5b21a14a3ee90757afa51c7a9167dc","user":{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false},"repo":{"id":154825160,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MjUxNjA=","name":"pantheon","full_name":"Shinabyss/pantheon","private":false,"owner":{"login":"Shinabyss","id":8305976,"node_id":"MDQ6VXNlcjgzMDU5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8305976?v=4","gravatar_id":"","url":"https://api.github.com/users/Shinabyss","html_url":"https://github.com/Shinabyss","followers_url":"https://api.github.com/users/Shinabyss/followers","following_url":"https://api.github.com/users/Shinabyss/following{/other_user}","gists_url":"https://api.github.com/users/Shinabyss/gists{/gist_id}","starred_url":"https://api.github.com/users/Shinabyss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shinabyss/subscriptions","organizations_url":"https://api.github.com/users/Shinabyss/orgs","repos_url":"https://api.github.com/users/Shinabyss/repos","events_url":"https://api.github.com/users/Shinabyss/events{/privacy}","received_events_url":"https://api.github.com/users/Shinabyss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shinabyss/pantheon","description":"PegaSys' Enterprise Blockchain Client","fork":true,"url":"https://api.github.com/repos/Shinabyss/pantheon","forks_url":"https://api.github.com/repos/Shinabyss/pantheon/forks","keys_url":"https://api.github.com/repos/Shinabyss/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shinabyss/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shinabyss/pantheon/teams","hooks_url":"https://api.github.com/repos/Shinabyss/pantheon/hooks","issue_events_url":"https://api.github.com/repos/Shinabyss/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/Shinabyss/pantheon/events","assignees_url":"https://api.github.com/repos/Shinabyss/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/Shinabyss/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/Shinabyss/pantheon/tags","blobs_url":"https://api.github.com/repos/Shinabyss/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shinabyss/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shinabyss/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shinabyss/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shinabyss/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/Shinabyss/pantheon/languages","stargazers_url":"https://api.github.com/repos/Shinabyss/pantheon/stargazers","contributors_url":"https://api.github.com/repos/Shinabyss/pantheon/contributors","subscribers_url":"https://api.github.com/repos/Shinabyss/pantheon/subscribers","subscription_url":"https://api.github.com/repos/Shinabyss/pantheon/subscription","commits_url":"https://api.github.com/repos/Shinabyss/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shinabyss/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shinabyss/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shinabyss/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shinabyss/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/Shinabyss/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shinabyss/pantheon/merges","archive_url":"https://api.github.com/repos/Shinabyss/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shinabyss/pantheon/downloads","issues_url":"https://api.github.com/repos/Shinabyss/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/Shinabyss/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/Shinabyss/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/Shinabyss/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shinabyss/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/Shinabyss/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/Shinabyss/pantheon/deployments","created_at":"2018-10-26T11:38:30Z","updated_at":"2018-10-29T17:49:48Z","pushed_at":"2018-12-20T02:37:27Z","git_url":"git://github.com/Shinabyss/pantheon.git","ssh_url":"git@github.com:Shinabyss/pantheon.git","clone_url":"https://github.com/Shinabyss/pantheon.git","svn_url":"https://github.com/Shinabyss/pantheon","homepage":"","size":7817,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PegaSysEng:master","ref":"master","sha":"2722aca1af21046401c05f61be98c211468aa188","user":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"repo":{"id":152270344,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNzAzNDQ=","name":"pantheon","full_name":"PegaSysEng/pantheon","private":false,"owner":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PegaSysEng/pantheon","description":"An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client","fork":false,"url":"https://api.github.com/repos/PegaSysEng/pantheon","forks_url":"https://api.github.com/repos/PegaSysEng/pantheon/forks","keys_url":"https://api.github.com/repos/PegaSysEng/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PegaSysEng/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PegaSysEng/pantheon/teams","hooks_url":"https://api.github.com/repos/PegaSysEng/pantheon/hooks","issue_events_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/PegaSysEng/pantheon/events","assignees_url":"https://api.github.com/repos/PegaSysEng/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/PegaSysEng/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/tags","blobs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/PegaSysEng/pantheon/languages","stargazers_url":"https://api.github.com/repos/PegaSysEng/pantheon/stargazers","contributors_url":"https://api.github.com/repos/PegaSysEng/pantheon/contributors","subscribers_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscribers","subscription_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscription","commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/PegaSysEng/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/PegaSysEng/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PegaSysEng/pantheon/merges","archive_url":"https://api.github.com/repos/PegaSysEng/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PegaSysEng/pantheon/downloads","issues_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/PegaSysEng/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/PegaSysEng/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PegaSysEng/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/PegaSysEng/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/PegaSysEng/pantheon/deployments","created_at":"2018-10-09T14:54:59Z","updated_at":"2018-12-20T02:19:07Z","pushed_at":"2018-12-20T02:37:28Z","git_url":"git://github.com/PegaSysEng/pantheon.git","ssh_url":"git@github.com:PegaSysEng/pantheon.git","clone_url":"https://github.com/PegaSysEng/pantheon.git","svn_url":"https://github.com/PegaSysEng/pantheon","homepage":"","size":7688,"stargazers_count":206,"watchers_count":206,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":46,"open_issues":63,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/460"},"issue":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/460"},"comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/26f83ed51c5b21a14a3ee90757afa51c7a9167dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Shinabyss"}}