{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/166977004","pull_request_review_id":95124167,"id":166977004,"diff_hunk":"@@ -0,0 +1,78 @@\n+/*\n+ * Copyright 2018 Google LLC\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     https://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.google.cloud.bigtable.data.v2.stub;\n+\n+import com.google.api.core.InternalApi;\n+import com.google.api.gax.rpc.ClientContext;\n+import com.google.cloud.bigtable.data.v2.internal.RequestContext;\n+import java.io.IOException;\n+\n+/**\n+ * The core client that converts method calls to RPCs.\n+ *\n+ * <p>This class consists of a set of Callable chains that represent RPC methods. There is a chain\n+ * for each RPC method. Each chain starts with a transformation that takes a protobuf wrapper and\n+ * terminates in a Callable from {@link GrpcBigtableStub}. This class is meant to be a semantically\n+ * complete facade for the Bigtable data API. However it is not meant to be consumed directly,\n+ * please use {@link com.google.cloud.bigtable.data.v2.BigtableDataClient}.\n+ *\n+ * <p>This class is considered an internal implementation detail and not meant to be used by\n+ * applications.\n+ */\n+@InternalApi\n+public class EnhancedBigtableStub implements AutoCloseable {\n+  private final EnhancedBigtableStubSettings settings;\n+  private final GrpcBigtableStub stub;\n+  private final ClientContext clientContext;\n+  private final RequestContext requestContext;","path":"google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java","position":40,"original_position":40,"commit_id":"c5828d401e6e0be3686adf624ddc2652b1e5fc60","original_commit_id":"c5828d401e6e0be3686adf624ddc2652b1e5fc60","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'requestContext'.](https://app.codacy.com/app/mziccard/google-cloud-java/pullRequest?prid=1298179)","created_at":"2018-02-08T15:49:37Z","updated_at":"2018-02-08T15:49:37Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842#discussion_r166977004","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/166977004"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842#discussion_r166977004"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842","id":166923092,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2842","number":2842,"state":"open","locked":false,"title":"Bigtable: 01. Surface: Base structure","user":{"login":"igorbernstein2","id":23526194,"avatar_url":"https://avatars3.githubusercontent.com/u/23526194?v=4","gravatar_id":"","url":"https://api.github.com/users/igorbernstein2","html_url":"https://github.com/igorbernstein2","followers_url":"https://api.github.com/users/igorbernstein2/followers","following_url":"https://api.github.com/users/igorbernstein2/following{/other_user}","gists_url":"https://api.github.com/users/igorbernstein2/gists{/gist_id}","starred_url":"https://api.github.com/users/igorbernstein2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorbernstein2/subscriptions","organizations_url":"https://api.github.com/users/igorbernstein2/orgs","repos_url":"https://api.github.com/users/igorbernstein2/repos","events_url":"https://api.github.com/users/igorbernstein2/events{/privacy}","received_events_url":"https://api.github.com/users/igorbernstein2/received_events","type":"User","site_admin":false},"body":"Layout the base structure to overlay the Bigtable GAPIC client. The general idea is for EnhancedBigtableStub to wrap the GAPIC GrpcBigtableStub\r\nand for it to construct Callable chains on top of the generated chains.\r\n\r\nThis has been reviewed Kevin. However some things have changed since the original review:\r\n- With the introduction of StubSettings all of the configuration has been moved to a new `EnhancedBigtableStubSettings`\r\n- `BigtableDataSettings` has been updated to just delegate to `EnhancedBigtableStubSettings`\r\n- `EnhancedBigtableStub` used to be called `BigtableDataStub`, but was renamed to avoid ambiguity \r\n","created_at":"2018-02-02T23:00:36Z","updated_at":"2018-02-08T15:49:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e75c1a40349b091833ee4a3173846ab9becd0a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2842/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/c5828d401e6e0be3686adf624ddc2652b1e5fc60","head":{"label":"igorbernstein2:01-base-structure","ref":"01-base-structure","sha":"c5828d401e6e0be3686adf624ddc2652b1e5fc60","user":{"login":"igorbernstein2","id":23526194,"avatar_url":"https://avatars3.githubusercontent.com/u/23526194?v=4","gravatar_id":"","url":"https://api.github.com/users/igorbernstein2","html_url":"https://github.com/igorbernstein2","followers_url":"https://api.github.com/users/igorbernstein2/followers","following_url":"https://api.github.com/users/igorbernstein2/following{/other_user}","gists_url":"https://api.github.com/users/igorbernstein2/gists{/gist_id}","starred_url":"https://api.github.com/users/igorbernstein2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorbernstein2/subscriptions","organizations_url":"https://api.github.com/users/igorbernstein2/orgs","repos_url":"https://api.github.com/users/igorbernstein2/repos","events_url":"https://api.github.com/users/igorbernstein2/events{/privacy}","received_events_url":"https://api.github.com/users/igorbernstein2/received_events","type":"User","site_admin":false},"repo":{"id":115758265,"name":"google-cloud-java","full_name":"igorbernstein2/google-cloud-java","owner":{"login":"igorbernstein2","id":23526194,"avatar_url":"https://avatars3.githubusercontent.com/u/23526194?v=4","gravatar_id":"","url":"https://api.github.com/users/igorbernstein2","html_url":"https://github.com/igorbernstein2","followers_url":"https://api.github.com/users/igorbernstein2/followers","following_url":"https://api.github.com/users/igorbernstein2/following{/other_user}","gists_url":"https://api.github.com/users/igorbernstein2/gists{/gist_id}","starred_url":"https://api.github.com/users/igorbernstein2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorbernstein2/subscriptions","organizations_url":"https://api.github.com/users/igorbernstein2/orgs","repos_url":"https://api.github.com/users/igorbernstein2/repos","events_url":"https://api.github.com/users/igorbernstein2/events{/privacy}","received_events_url":"https://api.github.com/users/igorbernstein2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igorbernstein2/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/igorbernstein2/google-cloud-java","forks_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/forks","keys_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/events","assignees_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/merges","archive_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/igorbernstein2/google-cloud-java/deployments","created_at":"2017-12-29T22:26:47Z","updated_at":"2017-12-29T22:26:54Z","pushed_at":"2018-02-08T15:38:01Z","git_url":"git://github.com/igorbernstein2/google-cloud-java.git","ssh_url":"git@github.com:igorbernstein2/google-cloud-java.git","clone_url":"https://github.com/igorbernstein2/google-cloud-java.git","svn_url":"https://github.com/igorbernstein2/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":238630,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f20eafcb41828e028369c1f894252961ce6f4796","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2018-02-08T11:48:05Z","pushed_at":"2018-02-08T15:38:03Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":249558,"stargazers_count":550,"watchers_count":550,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":365,"open_issues":62,"watchers":550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2842"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2842"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2842/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2842/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/c5828d401e6e0be3686adf624ddc2652b1e5fc60"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codacy-bot"}}