{"action":"created","issue":{"url":"https://api.github.com/repos/trezor/trezor-crypto/issues/184","repository_url":"https://api.github.com/repos/trezor/trezor-crypto","labels_url":"https://api.github.com/repos/trezor/trezor-crypto/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/trezor/trezor-crypto/issues/184/comments","events_url":"https://api.github.com/repos/trezor/trezor-crypto/issues/184/events","html_url":"https://github.com/trezor/trezor-crypto/pull/184","id":375536125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTU4NTIw","number":184,"title":"Optionally pad the bip39 wordlist.","user":{"login":"keepkeyjon","id":35975617,"node_id":"MDQ6VXNlcjM1OTc1NjE3","avatar_url":"https://avatars2.githubusercontent.com/u/35975617?v=4","gravatar_id":"","url":"https://api.github.com/users/keepkeyjon","html_url":"https://github.com/keepkeyjon","followers_url":"https://api.github.com/users/keepkeyjon/followers","following_url":"https://api.github.com/users/keepkeyjon/following{/other_user}","gists_url":"https://api.github.com/users/keepkeyjon/gists{/gist_id}","starred_url":"https://api.github.com/users/keepkeyjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepkeyjon/subscriptions","organizations_url":"https://api.github.com/users/keepkeyjon/orgs","repos_url":"https://api.github.com/users/keepkeyjon/repos","events_url":"https://api.github.com/users/keepkeyjon/events{/privacy}","received_events_url":"https://api.github.com/users/keepkeyjon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T15:01:46Z","updated_at":"2018-10-30T15:41:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/trezor/trezor-crypto/pulls/184","html_url":"https://github.com/trezor/trezor-crypto/pull/184","diff_url":"https://github.com/trezor/trezor-crypto/pull/184.diff","patch_url":"https://github.com/trezor/trezor-crypto/pull/184.patch"},"body":"This allows constant time word matching, without exercising UB.\r\n\r\nSubsumes trezor/trezor-crypto #182."},"comment":{"url":"https://api.github.com/repos/trezor/trezor-crypto/issues/comments/434352836","html_url":"https://github.com/trezor/trezor-crypto/pull/184#issuecomment-434352836","issue_url":"https://api.github.com/repos/trezor/trezor-crypto/issues/184","id":434352836,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDM1MjgzNg==","user":{"login":"jhoenicke","id":897826,"node_id":"MDQ6VXNlcjg5NzgyNg==","avatar_url":"https://avatars1.githubusercontent.com/u/897826?v=4","gravatar_id":"","url":"https://api.github.com/users/jhoenicke","html_url":"https://github.com/jhoenicke","followers_url":"https://api.github.com/users/jhoenicke/followers","following_url":"https://api.github.com/users/jhoenicke/following{/other_user}","gists_url":"https://api.github.com/users/jhoenicke/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoenicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoenicke/subscriptions","organizations_url":"https://api.github.com/users/jhoenicke/orgs","repos_url":"https://api.github.com/users/jhoenicke/repos","events_url":"https://api.github.com/users/jhoenicke/events{/privacy}","received_events_url":"https://api.github.com/users/jhoenicke/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T15:41:42Z","updated_at":"2018-10-30T15:41:42Z","author_association":"CONTRIBUTOR","body":"Question: can we just change the declaration to `const char wordlist[][8]`  or `...[9]` (for NUL-terminators) to pad the words and allow using memcpy/memcmp with fixed length.  This should also use less extra memory.  With `[8]` all strcpy/strcmp must be fixed, `[9]` would be backwards compatible, but unalignedness would cause more non-constant timing.\r\n\r\nIn the end you cannot get around non-constant timing.  We cannot pad the words in the final seed, or we would violate bip39."}}
{"actor":{"display_login":"jhoenicke"}}