{"action":"created","comment":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/195769987","pull_request_review_id":129204592,"id":195769987,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTc2OTk4Nw==","diff_hunk":"@@ -0,0 +1,6 @@\n+#!/bin/bash\n+# from: github:wdes/account-manager scripts/ci\n+cd $(dirname $0)/../\n+echo \"Running in : $(pwd)\"\n+# 1G is a litte high, should use < 512M\n+./vendor/bin/phpstan analyse ./ --configuration=phpstan.neon --level=max --memory-limit=1G","path":"scripts/ci-phpstan.sh","position":6,"original_position":6,"commit_id":"44350541205a414274bce2fb807ab3f3265536e7","original_commit_id":"44350541205a414274bce2fb807ab3f3265536e7","user":{"login":"mauriciofauth","id":120970,"node_id":"MDQ6VXNlcjEyMDk3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/120970?v=4","gravatar_id":"","url":"https://api.github.com/users/mauriciofauth","html_url":"https://github.com/mauriciofauth","followers_url":"https://api.github.com/users/mauriciofauth/followers","following_url":"https://api.github.com/users/mauriciofauth/following{/other_user}","gists_url":"https://api.github.com/users/mauriciofauth/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciofauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciofauth/subscriptions","organizations_url":"https://api.github.com/users/mauriciofauth/orgs","repos_url":"https://api.github.com/users/mauriciofauth/repos","events_url":"https://api.github.com/users/mauriciofauth/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciofauth/received_events","type":"User","site_admin":false},"body":"I'm not very convinced about the location of this file. Would not it be better to put it in the test directory along with the other ci files? And would it be interesting to put it on Travis CI?","created_at":"2018-06-15T15:03:40Z","updated_at":"2018-06-15T15:03:41Z","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14347#discussion_r195769987","pull_request_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/195769987"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/14347#discussion_r195769987"},"pull_request":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347"}},"in_reply_to_id":195221109},"pull_request":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347","id":192218451,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjE4NDUx","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14347","diff_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14347.diff","patch_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14347.patch","issue_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14347","number":14347,"state":"open","locked":false,"title":"[PROPOSAL] phpstan / finding errors in php code","user":{"login":"williamdes","id":7784660,"node_id":"MDQ6VXNlcjc3ODQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7784660?v=4","gravatar_id":"","url":"https://api.github.com/users/williamdes","html_url":"https://github.com/williamdes","followers_url":"https://api.github.com/users/williamdes/followers","following_url":"https://api.github.com/users/williamdes/following{/other_user}","gists_url":"https://api.github.com/users/williamdes/gists{/gist_id}","starred_url":"https://api.github.com/users/williamdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamdes/subscriptions","organizations_url":"https://api.github.com/users/williamdes/orgs","repos_url":"https://api.github.com/users/williamdes/repos","events_url":"https://api.github.com/users/williamdes/events{/privacy}","received_events_url":"https://api.github.com/users/williamdes/received_events","type":"User","site_admin":false},"body":"# This PR is a proposal\r\n\r\nUsing `phpstan/phpstan` would help solving issues since strict mode is now enabled.\r\n\r\nI intentionally put `--level=max` to show all errors, this mode goes very far in analysis.\r\n\r\nTry levels from 0 to 7 or max.\r\n\r\nMany errors found by `phpstan` can be fixed (IMO).\r\n\r\nOther can be hidden :)\r\n\r\n## Manual launch\r\n`./vendor/bin/phpstan analyse ./ --level=max --memory-limit=1G --configuration=phpstan.neon`\r\n\r\n`./` can be `./libraries ./test ./*.php` ...\r\n\r\n`bootstrap.php` file is needed, otherwise `phpstan` will crash (no time to find why, maybe constants).\r\n\r\n`PhpMyAdmin\\MoTranslator\\Loader::loadFunctions()` is required to avoid having errors for undefined function with code like: `__(\"blablabla\");`\r\n\r\nSee : https://github.com/phpstan/phpstan","created_at":"2018-06-02T21:22:48Z","updated_at":"2018-06-15T15:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f430eb6b439c1287505f04af13f201f9315cdc27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347/commits","review_comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347/comments","review_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14347/comments","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/44350541205a414274bce2fb807ab3f3265536e7","head":{"label":"williamdes:phpstan","ref":"phpstan","sha":"44350541205a414274bce2fb807ab3f3265536e7","user":{"login":"williamdes","id":7784660,"node_id":"MDQ6VXNlcjc3ODQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7784660?v=4","gravatar_id":"","url":"https://api.github.com/users/williamdes","html_url":"https://github.com/williamdes","followers_url":"https://api.github.com/users/williamdes/followers","following_url":"https://api.github.com/users/williamdes/following{/other_user}","gists_url":"https://api.github.com/users/williamdes/gists{/gist_id}","starred_url":"https://api.github.com/users/williamdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamdes/subscriptions","organizations_url":"https://api.github.com/users/williamdes/orgs","repos_url":"https://api.github.com/users/williamdes/repos","events_url":"https://api.github.com/users/williamdes/events{/privacy}","received_events_url":"https://api.github.com/users/williamdes/received_events","type":"User","site_admin":false},"repo":{"id":115422788,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MjI3ODg=","name":"phpmyadmintest","full_name":"williamdes/phpmyadmintest","owner":{"login":"williamdes","id":7784660,"node_id":"MDQ6VXNlcjc3ODQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7784660?v=4","gravatar_id":"","url":"https://api.github.com/users/williamdes","html_url":"https://github.com/williamdes","followers_url":"https://api.github.com/users/williamdes/followers","following_url":"https://api.github.com/users/williamdes/following{/other_user}","gists_url":"https://api.github.com/users/williamdes/gists{/gist_id}","starred_url":"https://api.github.com/users/williamdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamdes/subscriptions","organizations_url":"https://api.github.com/users/williamdes/orgs","repos_url":"https://api.github.com/users/williamdes/repos","events_url":"https://api.github.com/users/williamdes/events{/privacy}","received_events_url":"https://api.github.com/users/williamdes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/williamdes/phpmyadmintest","description":"Fork of phpmyadmin","fork":true,"url":"https://api.github.com/repos/williamdes/phpmyadmintest","forks_url":"https://api.github.com/repos/williamdes/phpmyadmintest/forks","keys_url":"https://api.github.com/repos/williamdes/phpmyadmintest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/williamdes/phpmyadmintest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/williamdes/phpmyadmintest/teams","hooks_url":"https://api.github.com/repos/williamdes/phpmyadmintest/hooks","issue_events_url":"https://api.github.com/repos/williamdes/phpmyadmintest/issues/events{/number}","events_url":"https://api.github.com/repos/williamdes/phpmyadmintest/events","assignees_url":"https://api.github.com/repos/williamdes/phpmyadmintest/assignees{/user}","branches_url":"https://api.github.com/repos/williamdes/phpmyadmintest/branches{/branch}","tags_url":"https://api.github.com/repos/williamdes/phpmyadmintest/tags","blobs_url":"https://api.github.com/repos/williamdes/phpmyadmintest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/williamdes/phpmyadmintest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/williamdes/phpmyadmintest/git/refs{/sha}","trees_url":"https://api.github.com/repos/williamdes/phpmyadmintest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/williamdes/phpmyadmintest/statuses/{sha}","languages_url":"https://api.github.com/repos/williamdes/phpmyadmintest/languages","stargazers_url":"https://api.github.com/repos/williamdes/phpmyadmintest/stargazers","contributors_url":"https://api.github.com/repos/williamdes/phpmyadmintest/contributors","subscribers_url":"https://api.github.com/repos/williamdes/phpmyadmintest/subscribers","subscription_url":"https://api.github.com/repos/williamdes/phpmyadmintest/subscription","commits_url":"https://api.github.com/repos/williamdes/phpmyadmintest/commits{/sha}","git_commits_url":"https://api.github.com/repos/williamdes/phpmyadmintest/git/commits{/sha}","comments_url":"https://api.github.com/repos/williamdes/phpmyadmintest/comments{/number}","issue_comment_url":"https://api.github.com/repos/williamdes/phpmyadmintest/issues/comments{/number}","contents_url":"https://api.github.com/repos/williamdes/phpmyadmintest/contents/{+path}","compare_url":"https://api.github.com/repos/williamdes/phpmyadmintest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/williamdes/phpmyadmintest/merges","archive_url":"https://api.github.com/repos/williamdes/phpmyadmintest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/williamdes/phpmyadmintest/downloads","issues_url":"https://api.github.com/repos/williamdes/phpmyadmintest/issues{/number}","pulls_url":"https://api.github.com/repos/williamdes/phpmyadmintest/pulls{/number}","milestones_url":"https://api.github.com/repos/williamdes/phpmyadmintest/milestones{/number}","notifications_url":"https://api.github.com/repos/williamdes/phpmyadmintest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/williamdes/phpmyadmintest/labels{/name}","releases_url":"https://api.github.com/repos/williamdes/phpmyadmintest/releases{/id}","deployments_url":"https://api.github.com/repos/williamdes/phpmyadmintest/deployments","created_at":"2017-12-26T13:04:53Z","updated_at":"2018-06-12T18:28:03Z","pushed_at":"2018-06-14T12:49:12Z","git_url":"git://github.com/williamdes/phpmyadmintest.git","ssh_url":"git@github.com:williamdes/phpmyadmintest.git","clone_url":"https://github.com/williamdes/phpmyadmintest.git","svn_url":"https://github.com/williamdes/phpmyadmintest","homepage":"https://www.phpmyadmin.net/","size":553041,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpmyadmin:master","ref":"master","sha":"2a34c018633764ab0149d453dd2c8bfc8e79396f","user":{"login":"phpmyadmin","id":1351977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1351977?v=4","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":3217621,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE3NjIx","name":"phpmyadmin","full_name":"phpmyadmin/phpmyadmin","owner":{"login":"phpmyadmin","id":1351977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1351977?v=4","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpmyadmin/phpmyadmin","description":"A web interface for MySQL and MariaDB","fork":false,"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin","forks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/forks","keys_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/events","assignees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/merges","archive_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/releases{/id}","deployments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/deployments","created_at":"2012-01-19T13:21:52Z","updated_at":"2018-06-15T14:51:44Z","pushed_at":"2018-06-15T13:39:06Z","git_url":"git://github.com/phpmyadmin/phpmyadmin.git","ssh_url":"git@github.com:phpmyadmin/phpmyadmin.git","clone_url":"https://github.com/phpmyadmin/phpmyadmin.git","svn_url":"https://github.com/phpmyadmin/phpmyadmin","homepage":"https://www.phpmyadmin.net/","size":553175,"stargazers_count":3136,"watchers_count":3136,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1803,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1803,"open_issues":421,"watchers":3136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/14347"},"issue":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14347"},"comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14347/comments"},"review_comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347/comments"},"review_comment":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14347/commits"},"statuses":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/44350541205a414274bce2fb807ab3f3265536e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mauriciofauth"}}