{"action":"created","comment":{"url":"https://api.github.com/repos/education/classroom/pulls/comments/226015827","pull_request_review_id":165737662,"id":226015827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjAxNTgyNw==","diff_hunk":"@@ -1,12 +1,17 @@\n-<iframe id=\"js-hidden-iframe\" src=\"about:blank\" style=\"display:none\"></iframe>\n+<% unless disabled %>\n+  <iframe id=\"js-hidden-iframe\" src=\"about:blank\" style=\"display:none\"></iframe>\n+<% end %>\n <div class=\"mt-3 pr-2\">\n   <details class=\"dropdown details-reset details-overlay d-inline-block\">\n-    <summary id=\"js-download-repos-btn\" class=\"btn\" aria-haspopup=\"true\">\n+    <summary <%=  disabled ? \"\" : \"id=\\\"js-download-repos-btn\\\"\" %> class=\"btn <%= disabled ? \"disabled\" : \"\" %>\" aria-haspopup=\"true\">","path":"app/views/shared/_open_on_assistant_modal.html.erb","position":8,"original_position":8,"commit_id":"6d453cf0e8085e11caae5485f0c5932c81387fdf","original_commit_id":"6d453cf0e8085e11caae5485f0c5932c81387fdf","user":{"login":"srinjoym","id":7866060,"node_id":"MDQ6VXNlcjc4NjYwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7866060?v=4","gravatar_id":"","url":"https://api.github.com/users/srinjoym","html_url":"https://github.com/srinjoym","followers_url":"https://api.github.com/users/srinjoym/followers","following_url":"https://api.github.com/users/srinjoym/following{/other_user}","gists_url":"https://api.github.com/users/srinjoym/gists{/gist_id}","starred_url":"https://api.github.com/users/srinjoym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinjoym/subscriptions","organizations_url":"https://api.github.com/users/srinjoym/orgs","repos_url":"https://api.github.com/users/srinjoym/repos","events_url":"https://api.github.com/users/srinjoym/events{/privacy}","received_events_url":"https://api.github.com/users/srinjoym/received_events","type":"User","site_admin":false},"body":"Ah good catch! The quotes around the `id` are showing up as redundant on my inspector though and it's causing the modal to not reset after the app is launched when there are assignments:\r\n\r\nWhat's happening right now:\r\n![image](https://user-images.githubusercontent.com/7866060/47102629-d7609a00-d202-11e8-9b6b-f7479f515db8.gif)\r\nWhat should happen:\r\n![image](https://user-images.githubusercontent.com/7866060/47103016-e3009080-d203-11e8-975f-4ff7057941b4.gif)\r\n\r\nHere's another fix, haven't seen the `undefined` error with this one:\r\n```suggestion\r\n    <summary id=<%=  disabled ? \"\" : \"js-download-repos-btn\" %> class=\"btn <%= disabled ? \"disabled\" : \"\" %>\" aria-haspopup=\"true\">\r\n```","created_at":"2018-10-17T17:00:37Z","updated_at":"2018-10-17T17:00:38Z","html_url":"https://github.com/education/classroom/pull/1657#discussion_r226015827","pull_request_url":"https://api.github.com/repos/education/classroom/pulls/1657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/education/classroom/pulls/comments/226015827"},"html":{"href":"https://github.com/education/classroom/pull/1657#discussion_r226015827"},"pull_request":{"href":"https://api.github.com/repos/education/classroom/pulls/1657"}},"in_reply_to_id":225949792},"pull_request":{"url":"https://api.github.com/repos/education/classroom/pulls/1657","id":223379446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzc5NDQ2","html_url":"https://github.com/education/classroom/pull/1657","diff_url":"https://github.com/education/classroom/pull/1657.diff","patch_url":"https://github.com/education/classroom/pull/1657.patch","issue_url":"https://api.github.com/repos/education/classroom/issues/1657","number":1657,"state":"open","locked":false,"title":"Disable assignment download button","user":{"login":"BenEmdon","id":11095731,"node_id":"MDQ6VXNlcjExMDk1NzMx","avatar_url":"https://avatars0.githubusercontent.com/u/11095731?v=4","gravatar_id":"","url":"https://api.github.com/users/BenEmdon","html_url":"https://github.com/BenEmdon","followers_url":"https://api.github.com/users/BenEmdon/followers","following_url":"https://api.github.com/users/BenEmdon/following{/other_user}","gists_url":"https://api.github.com/users/BenEmdon/gists{/gist_id}","starred_url":"https://api.github.com/users/BenEmdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenEmdon/subscriptions","organizations_url":"https://api.github.com/users/BenEmdon/orgs","repos_url":"https://api.github.com/users/BenEmdon/repos","events_url":"https://api.github.com/users/BenEmdon/events{/privacy}","received_events_url":"https://api.github.com/users/BenEmdon/received_events","type":"User","site_admin":false},"body":"## What\r\nThis PR proposes we disable the \"Download Repositories\" button when there are no `assignment_repos`.\r\n\r\n## Screenshots\r\n![screen shot 2018-10-16 at 16 04 02](https://user-images.githubusercontent.com/11095731/47044101-54d1cf00-d15d-11e8-987e-253621d99ad4.png)\r\n\r\n\r\nCloses #1637, Closes  #1589","created_at":"2018-10-16T20:07:13Z","updated_at":"2018-10-17T17:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6867752cf1f027ba57fabb83c651118e84f4f885","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1074708782,"node_id":"MDU6TGFiZWwxMDc0NzA4Nzgy","url":"https://api.github.com/repos/education/classroom/labels/Hacktoberfest","name":"Hacktoberfest","color":"FF8800","default":false},{"id":1024344882,"node_id":"MDU6TGFiZWwxMDI0MzQ0ODgy","url":"https://api.github.com/repos/education/classroom/labels/classroom%20assistant%20:desktop_computer:","name":"classroom assistant :desktop_computer:","color":"93ffb7","default":false},{"id":997863528,"node_id":"MDU6TGFiZWw5OTc4NjM1Mjg=","url":"https://api.github.com/repos/education/classroom/labels/fix%20:hammer_and_wrench:","name":"fix :hammer_and_wrench:","color":"63d877","default":false},{"id":307505416,"node_id":"MDU6TGFiZWwzMDc1MDU0MTY=","url":"https://api.github.com/repos/education/classroom/labels/ready%20for%20review%20:writing_hand:","name":"ready for review :writing_hand:","color":"30cc83","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/education/classroom/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/education/classroom/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/education/classroom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/education/classroom/issues/1657/comments","statuses_url":"https://api.github.com/repos/education/classroom/statuses/6d453cf0e8085e11caae5485f0c5932c81387fdf","head":{"label":"education:disable_assignment_download","ref":"disable_assignment_download","sha":"6d453cf0e8085e11caae5485f0c5932c81387fdf","user":{"login":"education","id":6667880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2Njc4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/6667880?v=4","gravatar_id":"","url":"https://api.github.com/users/education","html_url":"https://github.com/education","followers_url":"https://api.github.com/users/education/followers","following_url":"https://api.github.com/users/education/following{/other_user}","gists_url":"https://api.github.com/users/education/gists{/gist_id}","starred_url":"https://api.github.com/users/education/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/education/subscriptions","organizations_url":"https://api.github.com/users/education/orgs","repos_url":"https://api.github.com/users/education/repos","events_url":"https://api.github.com/users/education/events{/privacy}","received_events_url":"https://api.github.com/users/education/received_events","type":"Organization","site_admin":false},"repo":{"id":35079964,"node_id":"MDEwOlJlcG9zaXRvcnkzNTA3OTk2NA==","name":"classroom","full_name":"education/classroom","private":false,"owner":{"login":"education","id":6667880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2Njc4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/6667880?v=4","gravatar_id":"","url":"https://api.github.com/users/education","html_url":"https://github.com/education","followers_url":"https://api.github.com/users/education/followers","following_url":"https://api.github.com/users/education/following{/other_user}","gists_url":"https://api.github.com/users/education/gists{/gist_id}","starred_url":"https://api.github.com/users/education/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/education/subscriptions","organizations_url":"https://api.github.com/users/education/orgs","repos_url":"https://api.github.com/users/education/repos","events_url":"https://api.github.com/users/education/events{/privacy}","received_events_url":"https://api.github.com/users/education/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/education/classroom","description":"GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.","fork":false,"url":"https://api.github.com/repos/education/classroom","forks_url":"https://api.github.com/repos/education/classroom/forks","keys_url":"https://api.github.com/repos/education/classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/education/classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/education/classroom/teams","hooks_url":"https://api.github.com/repos/education/classroom/hooks","issue_events_url":"https://api.github.com/repos/education/classroom/issues/events{/number}","events_url":"https://api.github.com/repos/education/classroom/events","assignees_url":"https://api.github.com/repos/education/classroom/assignees{/user}","branches_url":"https://api.github.com/repos/education/classroom/branches{/branch}","tags_url":"https://api.github.com/repos/education/classroom/tags","blobs_url":"https://api.github.com/repos/education/classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/education/classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/education/classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/education/classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/education/classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/education/classroom/languages","stargazers_url":"https://api.github.com/repos/education/classroom/stargazers","contributors_url":"https://api.github.com/repos/education/classroom/contributors","subscribers_url":"https://api.github.com/repos/education/classroom/subscribers","subscription_url":"https://api.github.com/repos/education/classroom/subscription","commits_url":"https://api.github.com/repos/education/classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/education/classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/education/classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/education/classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/education/classroom/contents/{+path}","compare_url":"https://api.github.com/repos/education/classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/education/classroom/merges","archive_url":"https://api.github.com/repos/education/classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/education/classroom/downloads","issues_url":"https://api.github.com/repos/education/classroom/issues{/number}","pulls_url":"https://api.github.com/repos/education/classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/education/classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/education/classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/education/classroom/labels{/name}","releases_url":"https://api.github.com/repos/education/classroom/releases{/id}","deployments_url":"https://api.github.com/repos/education/classroom/deployments","created_at":"2015-05-05T05:33:50Z","updated_at":"2018-10-17T15:29:44Z","pushed_at":"2018-10-17T15:01:12Z","git_url":"git://github.com/education/classroom.git","ssh_url":"git@github.com:education/classroom.git","clone_url":"https://github.com/education/classroom.git","svn_url":"https://github.com/education/classroom","homepage":"https://classroom.github.com","size":45918,"stargazers_count":875,"watchers_count":875,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":103,"license":null,"forks":270,"open_issues":103,"watchers":875,"default_branch":"master"}},"base":{"label":"education:master","ref":"master","sha":"b3160071793e08abcb499888101cff1beb07ec30","user":{"login":"education","id":6667880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2Njc4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/6667880?v=4","gravatar_id":"","url":"https://api.github.com/users/education","html_url":"https://github.com/education","followers_url":"https://api.github.com/users/education/followers","following_url":"https://api.github.com/users/education/following{/other_user}","gists_url":"https://api.github.com/users/education/gists{/gist_id}","starred_url":"https://api.github.com/users/education/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/education/subscriptions","organizations_url":"https://api.github.com/users/education/orgs","repos_url":"https://api.github.com/users/education/repos","events_url":"https://api.github.com/users/education/events{/privacy}","received_events_url":"https://api.github.com/users/education/received_events","type":"Organization","site_admin":false},"repo":{"id":35079964,"node_id":"MDEwOlJlcG9zaXRvcnkzNTA3OTk2NA==","name":"classroom","full_name":"education/classroom","private":false,"owner":{"login":"education","id":6667880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2Njc4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/6667880?v=4","gravatar_id":"","url":"https://api.github.com/users/education","html_url":"https://github.com/education","followers_url":"https://api.github.com/users/education/followers","following_url":"https://api.github.com/users/education/following{/other_user}","gists_url":"https://api.github.com/users/education/gists{/gist_id}","starred_url":"https://api.github.com/users/education/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/education/subscriptions","organizations_url":"https://api.github.com/users/education/orgs","repos_url":"https://api.github.com/users/education/repos","events_url":"https://api.github.com/users/education/events{/privacy}","received_events_url":"https://api.github.com/users/education/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/education/classroom","description":"GitHub Classroom automates repository creation and access control, making it easy for teachers to distribute starter code and collect assignments on GitHub.","fork":false,"url":"https://api.github.com/repos/education/classroom","forks_url":"https://api.github.com/repos/education/classroom/forks","keys_url":"https://api.github.com/repos/education/classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/education/classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/education/classroom/teams","hooks_url":"https://api.github.com/repos/education/classroom/hooks","issue_events_url":"https://api.github.com/repos/education/classroom/issues/events{/number}","events_url":"https://api.github.com/repos/education/classroom/events","assignees_url":"https://api.github.com/repos/education/classroom/assignees{/user}","branches_url":"https://api.github.com/repos/education/classroom/branches{/branch}","tags_url":"https://api.github.com/repos/education/classroom/tags","blobs_url":"https://api.github.com/repos/education/classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/education/classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/education/classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/education/classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/education/classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/education/classroom/languages","stargazers_url":"https://api.github.com/repos/education/classroom/stargazers","contributors_url":"https://api.github.com/repos/education/classroom/contributors","subscribers_url":"https://api.github.com/repos/education/classroom/subscribers","subscription_url":"https://api.github.com/repos/education/classroom/subscription","commits_url":"https://api.github.com/repos/education/classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/education/classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/education/classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/education/classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/education/classroom/contents/{+path}","compare_url":"https://api.github.com/repos/education/classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/education/classroom/merges","archive_url":"https://api.github.com/repos/education/classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/education/classroom/downloads","issues_url":"https://api.github.com/repos/education/classroom/issues{/number}","pulls_url":"https://api.github.com/repos/education/classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/education/classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/education/classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/education/classroom/labels{/name}","releases_url":"https://api.github.com/repos/education/classroom/releases{/id}","deployments_url":"https://api.github.com/repos/education/classroom/deployments","created_at":"2015-05-05T05:33:50Z","updated_at":"2018-10-17T15:29:44Z","pushed_at":"2018-10-17T15:01:12Z","git_url":"git://github.com/education/classroom.git","ssh_url":"git@github.com:education/classroom.git","clone_url":"https://github.com/education/classroom.git","svn_url":"https://github.com/education/classroom","homepage":"https://classroom.github.com","size":45918,"stargazers_count":875,"watchers_count":875,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":103,"license":null,"forks":270,"open_issues":103,"watchers":875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/education/classroom/pulls/1657"},"html":{"href":"https://github.com/education/classroom/pull/1657"},"issue":{"href":"https://api.github.com/repos/education/classroom/issues/1657"},"comments":{"href":"https://api.github.com/repos/education/classroom/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/education/classroom/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/education/classroom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/education/classroom/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/education/classroom/statuses/6d453cf0e8085e11caae5485f0c5932c81387fdf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"srinjoym"}}