{"action":"created","comment":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/197012645","pull_request_review_id":130666539,"id":197012645,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzAxMjY0NQ==","diff_hunk":"@@ -506,4 +503,8 @@ namespace Archives\n \t\t}\n \t\tm_NumberOfPackedFiles = packedFileCount;\n \t}\n+\n+\tVolFile::SectionHeader::SectionHeader() {}\n+\tVolFile::SectionHeader::SectionHeader(std::array<char, 4> tag, uint32_t length, VolPadding padding) \n+\t\t: tag(tag), length(length), padding(padding) {}","path":"Archives/VolFile.cpp","position":158,"original_position":158,"commit_id":"a7dc91bee3c28b980dd13a8c0fdaf6d15cdb38d1","original_commit_id":"a7dc91bee3c28b980dd13a8c0fdaf6d15cdb38d1","user":{"login":"DanRStevens","id":16793474,"node_id":"MDQ6VXNlcjE2NzkzNDc0","avatar_url":"https://avatars2.githubusercontent.com/u/16793474?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRStevens","html_url":"https://github.com/DanRStevens","followers_url":"https://api.github.com/users/DanRStevens/followers","following_url":"https://api.github.com/users/DanRStevens/following{/other_user}","gists_url":"https://api.github.com/users/DanRStevens/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRStevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRStevens/subscriptions","organizations_url":"https://api.github.com/users/DanRStevens/orgs","repos_url":"https://api.github.com/users/DanRStevens/repos","events_url":"https://api.github.com/users/DanRStevens/events{/privacy}","received_events_url":"https://api.github.com/users/DanRStevens/received_events","type":"User","site_admin":false},"body":"Good, though I'm not sure if this needs to be explicit. Public struct fields can be initialized with brace syntax. There may be some benefits to using constructor notation though. Maybe experiment with using `= default`, at least for the empty constructor.","created_at":"2018-06-21T05:12:14Z","updated_at":"2018-06-21T05:53:00Z","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/70#discussion_r197012645","pull_request_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/197012645"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/70#discussion_r197012645"},"pull_request":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70","id":196332870,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzMyODcw","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/70","diff_url":"https://github.com/OutpostUniverse/OP2Utility/pull/70.diff","patch_url":"https://github.com/OutpostUniverse/OP2Utility/pull/70.patch","issue_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/70","number":70,"state":"open","locked":false,"title":"Improve section tag constants in archives","user":{"login":"Brett208","id":15183337,"node_id":"MDQ6VXNlcjE1MTgzMzM3","avatar_url":"https://avatars3.githubusercontent.com/u/15183337?v=4","gravatar_id":"","url":"https://api.github.com/users/Brett208","html_url":"https://github.com/Brett208","followers_url":"https://api.github.com/users/Brett208/followers","following_url":"https://api.github.com/users/Brett208/following{/other_user}","gists_url":"https://api.github.com/users/Brett208/gists{/gist_id}","starred_url":"https://api.github.com/users/Brett208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brett208/subscriptions","organizations_url":"https://api.github.com/users/Brett208/orgs","repos_url":"https://api.github.com/users/Brett208/repos","events_url":"https://api.github.com/users/Brett208/events{/privacy}","received_events_url":"https://api.github.com/users/Brett208/received_events","type":"User","site_admin":false},"body":"See commit messages for details. This should close out issue #58. \r\n\r\nTested by listing contents of a volume, and packing a new clm file.","created_at":"2018-06-21T04:26:56Z","updated_at":"2018-06-21T05:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f4ab7e6103d1722e323656d5bf71b50cb2a4b0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":905974588,"node_id":"MDU6TGFiZWw5MDU5NzQ1ODg=","url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels/Code%20Cleaning","name":"Code Cleaning","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70/commits","review_comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70/comments","review_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/70/comments","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/a7dc91bee3c28b980dd13a8c0fdaf6d15cdb38d1","head":{"label":"OutpostUniverse:Improve-section-tag-constants-in-Archives","ref":"Improve-section-tag-constants-in-Archives","sha":"a7dc91bee3c28b980dd13a8c0fdaf6d15cdb38d1","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-06-20T08:30:28Z","pushed_at":"2018-06-21T05:20:01Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":409,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"OutpostUniverse:master","ref":"master","sha":"01be345cd20f0abad0f8c40d031981079c8ec413","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-06-20T08:30:28Z","pushed_at":"2018-06-21T05:20:01Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":409,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/70"},"issue":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/70"},"comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/a7dc91bee3c28b980dd13a8c0fdaf6d15cdb38d1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DanRStevens"}}