{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/11709","repository_url":"https://api.github.com/repos/chapel-lang/chapel","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11709/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11709/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11709/events","html_url":"https://github.com/chapel-lang/chapel/pull/11709","id":385024168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDkwMjcx","number":11709,"title":"Cleanup util/chplenv/third-party-pkgs","user":{"login":"ronawho","id":1588337,"node_id":"MDQ6VXNlcjE1ODgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1588337?v=4","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-27T22:55:24Z","updated_at":"2018-11-28T17:51:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11709","html_url":"https://github.com/chapel-lang/chapel/pull/11709","diff_url":"https://github.com/chapel-lang/chapel/pull/11709.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/11709.patch"},"body":"Make it more pythonic and cleanup implementation:\r\n - don't hardcode '/', use os.path.join\r\n - don't use file open/close, use with stmt\r\n - don't manually look at sys.argv, use optparse\r\n - use list comprehension to cleanup compiler/runtime filtering\r\n - `list.count(val)` => `val in list`\r\n - don't recompute chpl_home/third-party, use chpl_home_utils\r\n - split code into functions\r\n - use run_command instead of subprocess+decode\r\n - better var names, and avoid using builtin names like \"dir\""},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/442541622","html_url":"https://github.com/chapel-lang/chapel/pull/11709#issuecomment-442541622","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11709","id":442541622,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjU0MTYyMg==","user":{"login":"ronawho","id":1588337,"node_id":"MDQ6VXNlcjE1ODgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1588337?v=4","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T17:51:46Z","updated_at":"2018-11-28T17:51:46Z","author_association":"CONTRIBUTOR","body":"Sounds good to me. For now I just added `--compiler` to the printchplenv command for now and verified that we don't print out `llvm` for non-compiler runs of third-party-pkgs. I thought about just removing `third-party-pkgs --compiler` support, but I'll save that or any other refactoring for a later day."}}
{"actor":{"display_login":"ronawho"}}