{"action":"created","comment":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/175288908","pull_request_review_id":104796989,"id":175288908,"diff_hunk":"@@ -365,17 +365,16 @@ def fetch(self, url, method='GET', headers=None, body=None):\n             self.raise_error(ExchangeError, url, method, e)\n \n         except HTTPError as e:\n-            self.handle_errors(response.status_code, response.reason, url, method, self.last_response_headers, self.last_http_response)\n-            self.handle_rest_errors(e, response.status_code, self.last_http_response, url, method)\n-            self.raise_error(ExchangeError, url, method, e, self.last_http_response)\n+            self.handle_errors(response.status_code, response.reason, url, method, response.headers, response.text)","path":"python/ccxt/base/exchange.py","position":null,"original_position":32,"commit_id":"f961d62ea305e1740cdff3abf36c6e229d70d059","original_commit_id":"ca3df93e914cd92f40ce08ac45d6193f5eab3782","user":{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"body":"@frosty00 yep, I think it should do what we want, exactly","created_at":"2018-03-18T13:17:08Z","updated_at":"2018-03-18T13:17:08Z","html_url":"https://github.com/ccxt/ccxt/pull/2296#discussion_r175288908","pull_request_url":"https://api.github.com/repos/ccxt/ccxt/pulls/2296","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/175288908"},"html":{"href":"https://github.com/ccxt/ccxt/pull/2296#discussion_r175288908"},"pull_request":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/2296"}},"in_reply_to_id":175287675},"pull_request":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/2296","id":175746975,"html_url":"https://github.com/ccxt/ccxt/pull/2296","diff_url":"https://github.com/ccxt/ccxt/pull/2296.diff","patch_url":"https://github.com/ccxt/ccxt/pull/2296.patch","issue_url":"https://api.github.com/repos/ccxt/ccxt/issues/2296","number":2296,"state":"open","locked":false,"title":"Python json","user":{"login":"frosty00","id":14319357,"avatar_url":"https://avatars0.githubusercontent.com/u/14319357?v=4","gravatar_id":"","url":"https://api.github.com/users/frosty00","html_url":"https://github.com/frosty00","followers_url":"https://api.github.com/users/frosty00/followers","following_url":"https://api.github.com/users/frosty00/following{/other_user}","gists_url":"https://api.github.com/users/frosty00/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty00/subscriptions","organizations_url":"https://api.github.com/users/frosty00/orgs","repos_url":"https://api.github.com/users/frosty00/repos","events_url":"https://api.github.com/users/frosty00/events{/privacy}","received_events_url":"https://api.github.com/users/frosty00/received_events","type":"User","site_admin":false},"body":"I'm doing a quite a bit more testing this time. Obviously all subclass need to be changed as well and I will continue to test. Let me know your initial thoughts.","created_at":"2018-03-18T11:45:43Z","updated_at":"2018-03-18T13:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c4077d4dde5c1d0cecadcd5df3f8fd0bead5d7","assignee":{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ccxt/ccxt/pulls/2296/commits","review_comments_url":"https://api.github.com/repos/ccxt/ccxt/pulls/2296/comments","review_comment_url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccxt/ccxt/issues/2296/comments","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/f961d62ea305e1740cdff3abf36c6e229d70d059","head":{"label":"frosty00:pythonJSON","ref":"pythonJSON","sha":"f961d62ea305e1740cdff3abf36c6e229d70d059","user":{"login":"frosty00","id":14319357,"avatar_url":"https://avatars0.githubusercontent.com/u/14319357?v=4","gravatar_id":"","url":"https://api.github.com/users/frosty00","html_url":"https://github.com/frosty00","followers_url":"https://api.github.com/users/frosty00/followers","following_url":"https://api.github.com/users/frosty00/following{/other_user}","gists_url":"https://api.github.com/users/frosty00/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty00/subscriptions","organizations_url":"https://api.github.com/users/frosty00/orgs","repos_url":"https://api.github.com/users/frosty00/repos","events_url":"https://api.github.com/users/frosty00/events{/privacy}","received_events_url":"https://api.github.com/users/frosty00/received_events","type":"User","site_admin":false},"repo":{"id":118924331,"name":"ccxt","full_name":"frosty00/ccxt","owner":{"login":"frosty00","id":14319357,"avatar_url":"https://avatars0.githubusercontent.com/u/14319357?v=4","gravatar_id":"","url":"https://api.github.com/users/frosty00","html_url":"https://github.com/frosty00","followers_url":"https://api.github.com/users/frosty00/followers","following_url":"https://api.github.com/users/frosty00/following{/other_user}","gists_url":"https://api.github.com/users/frosty00/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty00/subscriptions","organizations_url":"https://api.github.com/users/frosty00/orgs","repos_url":"https://api.github.com/users/frosty00/repos","events_url":"https://api.github.com/users/frosty00/events{/privacy}","received_events_url":"https://api.github.com/users/frosty00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frosty00/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 90 bitcoin/altcoin exchanges","fork":true,"url":"https://api.github.com/repos/frosty00/ccxt","forks_url":"https://api.github.com/repos/frosty00/ccxt/forks","keys_url":"https://api.github.com/repos/frosty00/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frosty00/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frosty00/ccxt/teams","hooks_url":"https://api.github.com/repos/frosty00/ccxt/hooks","issue_events_url":"https://api.github.com/repos/frosty00/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/frosty00/ccxt/events","assignees_url":"https://api.github.com/repos/frosty00/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/frosty00/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/frosty00/ccxt/tags","blobs_url":"https://api.github.com/repos/frosty00/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frosty00/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frosty00/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/frosty00/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frosty00/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/frosty00/ccxt/languages","stargazers_url":"https://api.github.com/repos/frosty00/ccxt/stargazers","contributors_url":"https://api.github.com/repos/frosty00/ccxt/contributors","subscribers_url":"https://api.github.com/repos/frosty00/ccxt/subscribers","subscription_url":"https://api.github.com/repos/frosty00/ccxt/subscription","commits_url":"https://api.github.com/repos/frosty00/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/frosty00/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/frosty00/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/frosty00/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/frosty00/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/frosty00/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frosty00/ccxt/merges","archive_url":"https://api.github.com/repos/frosty00/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frosty00/ccxt/downloads","issues_url":"https://api.github.com/repos/frosty00/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/frosty00/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/frosty00/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/frosty00/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frosty00/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/frosty00/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/frosty00/ccxt/deployments","created_at":"2018-01-25T14:37:48Z","updated_at":"2018-01-25T14:37:54Z","pushed_at":"2018-03-18T13:11:23Z","git_url":"git://github.com/frosty00/ccxt.git","ssh_url":"git@github.com:frosty00/ccxt.git","clone_url":"https://github.com/frosty00/ccxt.git","svn_url":"https://github.com/frosty00/ccxt","homepage":"","size":468549,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ccxt:master","ref":"master","sha":"b1cf529caa02a55aadf71583e8e6e10c97e92a03","user":{"login":"ccxt","id":31901609,"avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"repo":{"id":91253698,"name":"ccxt","full_name":"ccxt/ccxt","owner":{"login":"ccxt","id":31901609,"avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ccxt/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 90 bitcoin/altcoin exchanges","fork":false,"url":"https://api.github.com/repos/ccxt/ccxt","forks_url":"https://api.github.com/repos/ccxt/ccxt/forks","keys_url":"https://api.github.com/repos/ccxt/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccxt/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccxt/ccxt/teams","hooks_url":"https://api.github.com/repos/ccxt/ccxt/hooks","issue_events_url":"https://api.github.com/repos/ccxt/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/ccxt/ccxt/events","assignees_url":"https://api.github.com/repos/ccxt/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/ccxt/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/ccxt/ccxt/tags","blobs_url":"https://api.github.com/repos/ccxt/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccxt/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccxt/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccxt/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/ccxt/ccxt/languages","stargazers_url":"https://api.github.com/repos/ccxt/ccxt/stargazers","contributors_url":"https://api.github.com/repos/ccxt/ccxt/contributors","subscribers_url":"https://api.github.com/repos/ccxt/ccxt/subscribers","subscription_url":"https://api.github.com/repos/ccxt/ccxt/subscription","commits_url":"https://api.github.com/repos/ccxt/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccxt/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccxt/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccxt/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccxt/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/ccxt/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccxt/ccxt/merges","archive_url":"https://api.github.com/repos/ccxt/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccxt/ccxt/downloads","issues_url":"https://api.github.com/repos/ccxt/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/ccxt/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/ccxt/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/ccxt/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccxt/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/ccxt/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/ccxt/ccxt/deployments","created_at":"2017-05-14T15:41:56Z","updated_at":"2018-03-18T12:56:55Z","pushed_at":"2018-03-18T13:11:24Z","git_url":"git://github.com/ccxt/ccxt.git","ssh_url":"git@github.com:ccxt/ccxt.git","clone_url":"https://github.com/ccxt/ccxt.git","svn_url":"https://github.com/ccxt/ccxt","homepage":"","size":470946,"stargazers_count":5163,"watchers_count":5163,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1301,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1301,"open_issues":162,"watchers":5163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/2296"},"html":{"href":"https://github.com/ccxt/ccxt/pull/2296"},"issue":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/2296"},"comments":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/2296/comments"},"review_comments":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/2296/comments"},"review_comment":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/2296/commits"},"statuses":{"href":"https://api.github.com/repos/ccxt/ccxt/statuses/f961d62ea305e1740cdff3abf36c6e229d70d059"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kroitor"}}