{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/comments/191225207","pull_request_review_id":123757391,"id":191225207,"diff_hunk":"@@ -0,0 +1,47 @@\n+# frozen_string_literal: true\n+require 'savon'\n+require 'json'\n+\n+require_relative 'transporter_exporter'\n+\n+class OrderExporter < TransporterExporter\n+  def run\n+    orders_for(required_env_vars['MAGENTO_STORE_ID']).each do |order|\n+      next if skip?(order)\n+\n+      puts JSON.pretty_generate(order.merge('items' => items_for(order)))","path":"sample_scripts/third_party_platform_exporting/magento/v1.9/soap_api/orders.rb","position":12,"original_position":12,"commit_id":"15a2c8fd3fd9118301ed70d5fac82b82bef8ea1c","original_commit_id":"15a2c8fd3fd9118301ed70d5fac82b82bef8ea1c","user":{"login":"surajreddy","id":80290,"avatar_url":"https://avatars3.githubusercontent.com/u/80290?v=4","gravatar_id":"","url":"https://api.github.com/users/surajreddy","html_url":"https://github.com/surajreddy","followers_url":"https://api.github.com/users/surajreddy/followers","following_url":"https://api.github.com/users/surajreddy/following{/other_user}","gists_url":"https://api.github.com/users/surajreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/surajreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajreddy/subscriptions","organizations_url":"https://api.github.com/users/surajreddy/orgs","repos_url":"https://api.github.com/users/surajreddy/repos","events_url":"https://api.github.com/users/surajreddy/events{/privacy}","received_events_url":"https://api.github.com/users/surajreddy/received_events","type":"User","site_admin":false},"body":"@ariens-shopify yes.\r\n\r\nI'm worried about the soap call for these causing an exception that could fail the whole process/ we won't be able to recover from issues retrieving the rest of the orders if a single one fails. \r\n\r\nHowever, I'm content with adding an issue for this and dealing with this in the future - we don't have a recovery strategy if retrieving an order fails (ex: do we store the ids of all the orders and output them at the end, or do we retry, etc.)","created_at":"2018-05-28T14:49:20Z","updated_at":"2018-05-28T14:49:21Z","html_url":"https://github.com/Shopify/shopify_transporter/pull/7#discussion_r191225207","pull_request_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/comments/191225207"},"html":{"href":"https://github.com/Shopify/shopify_transporter/pull/7#discussion_r191225207"},"pull_request":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7"}},"in_reply_to_id":190927054},"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7","id":190403414,"html_url":"https://github.com/Shopify/shopify_transporter/pull/7","diff_url":"https://github.com/Shopify/shopify_transporter/pull/7.diff","patch_url":"https://github.com/Shopify/shopify_transporter/pull/7.patch","issue_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/7","number":7,"state":"open","locked":false,"title":"Magento v1.x SOAP Customer and Order export","user":{"login":"ariens-shopify","id":23177515,"avatar_url":"https://avatars2.githubusercontent.com/u/23177515?v=4","gravatar_id":"","url":"https://api.github.com/users/ariens-shopify","html_url":"https://github.com/ariens-shopify","followers_url":"https://api.github.com/users/ariens-shopify/followers","following_url":"https://api.github.com/users/ariens-shopify/following{/other_user}","gists_url":"https://api.github.com/users/ariens-shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/ariens-shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariens-shopify/subscriptions","organizations_url":"https://api.github.com/users/ariens-shopify/orgs","repos_url":"https://api.github.com/users/ariens-shopify/repos","events_url":"https://api.github.com/users/ariens-shopify/events{/privacy}","received_events_url":"https://api.github.com/users/ariens-shopify/received_events","type":"User","site_admin":false},"body":"### What it does and why:\r\nProvides sample scripts for exporting Magento v1.x customers and orders through the SOAP API.\r\n### Checklist:\r\n\r\n- [ ] Testing & QA: Passes tests and linting.\r\n- [ ] :tophat:: I have manually tested these changes.\r\n\r\n---\r\n\r\n### Related issues:\r\nCloses:\r\n","created_at":"2018-05-24T19:59:44Z","updated_at":"2018-05-28T14:49:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3f99786dbb7ad8cf7de88626d64cc3d95eb0d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/7/comments","statuses_url":"https://api.github.com/repos/Shopify/shopify_transporter/statuses/15a2c8fd3fd9118301ed70d5fac82b82bef8ea1c","head":{"label":"Shopify:extraction-scripts","ref":"extraction-scripts","sha":"15a2c8fd3fd9118301ed70d5fac82b82bef8ea1c","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":131181428,"name":"shopify_transporter","full_name":"Shopify/shopify_transporter","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_transporter","description":"The Transporter tool allows you to convert data from a third-party platform into a format that can be imported into Shopify.","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_transporter","forks_url":"https://api.github.com/repos/Shopify/shopify_transporter/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_transporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_transporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_transporter/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_transporter/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_transporter/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_transporter/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_transporter/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_transporter/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_transporter/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_transporter/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_transporter/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_transporter/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_transporter/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_transporter/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_transporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_transporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_transporter/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_transporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_transporter/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_transporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_transporter/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_transporter/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_transporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_transporter/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_transporter/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_transporter/deployments","created_at":"2018-04-26T16:16:03Z","updated_at":"2018-05-20T03:58:07Z","pushed_at":"2018-05-25T03:22:15Z","git_url":"git://github.com/Shopify/shopify_transporter.git","ssh_url":"git@github.com:Shopify/shopify_transporter.git","clone_url":"https://github.com/Shopify/shopify_transporter.git","svn_url":"https://github.com/Shopify/shopify_transporter","homepage":null,"size":58,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"de9b8a8e098c2048a6ca42edbfc298da5a62cfa1","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":131181428,"name":"shopify_transporter","full_name":"Shopify/shopify_transporter","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_transporter","description":"The Transporter tool allows you to convert data from a third-party platform into a format that can be imported into Shopify.","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_transporter","forks_url":"https://api.github.com/repos/Shopify/shopify_transporter/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_transporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_transporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_transporter/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_transporter/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_transporter/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_transporter/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_transporter/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_transporter/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_transporter/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_transporter/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_transporter/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_transporter/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_transporter/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_transporter/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_transporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_transporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_transporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_transporter/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_transporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_transporter/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_transporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_transporter/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_transporter/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_transporter/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_transporter/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_transporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_transporter/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_transporter/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_transporter/deployments","created_at":"2018-04-26T16:16:03Z","updated_at":"2018-05-20T03:58:07Z","pushed_at":"2018-05-25T03:22:15Z","git_url":"git://github.com/Shopify/shopify_transporter.git","ssh_url":"git@github.com:Shopify/shopify_transporter.git","clone_url":"https://github.com/Shopify/shopify_transporter.git","svn_url":"https://github.com/Shopify/shopify_transporter","homepage":null,"size":58,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7"},"html":{"href":"https://github.com/Shopify/shopify_transporter/pull/7"},"issue":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/issues/7"},"comments":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shopify_transporter/statuses/15a2c8fd3fd9118301ed70d5fac82b82bef8ea1c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"surajreddy"}}