{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/244624091","pull_request_review_id":188542794,"id":244624091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYyNDA5MQ==","diff_hunk":"@@ -0,0 +1,51 @@\n+import numpy as np\n+import pytest\n+\n+from pandas import Series\n+import pandas.util.testing as tm\n+\n+_all_indices = [tm.makeBoolIndex(10, name='a'),\n+                tm.makeIntIndex(10, name='a'),\n+                tm.makeFloatIndex(10, name='a'),\n+                tm.makeDateIndex(10, name='a'),\n+                tm.makeDateIndex(10, name='a').tz_localize(tz='US/Eastern'),\n+                tm.makePeriodIndex(10, name='a'),\n+                tm.makeStringIndex(10, name='a'),\n+                tm.makeUnicodeIndex(10, name='a')]\n+\n+_arr = np.random.randn(10)","path":"pandas/tests/conftest.py","position":16,"original_position":16,"commit_id":"74e0d39271dcf6a158525ec9e32b768cb0922a59","original_commit_id":"74e0d39271dcf6a158525ec9e32b768cb0922a59","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"hmm, let's just make it ``np.arange(10)`` then","created_at":"2018-12-31T23:36:53Z","updated_at":"2018-12-31T23:36:53Z","html_url":"https://github.com/pandas-dev/pandas/pull/23943#discussion_r244624091","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/244624091"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23943#discussion_r244624091"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943"}},"in_reply_to_id":244544006},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943","id":233802067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODAyMDY3","html_url":"https://github.com/pandas-dev/pandas/pull/23943","diff_url":"https://github.com/pandas-dev/pandas/pull/23943.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23943.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23943","number":23943,"state":"open","locked":false,"title":"CLN: Fixturize test_base.py","user":{"login":"nixphix","id":4676330,"node_id":"MDQ6VXNlcjQ2NzYzMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4676330?v=4","gravatar_id":"","url":"https://api.github.com/users/nixphix","html_url":"https://github.com/nixphix","followers_url":"https://api.github.com/users/nixphix/followers","following_url":"https://api.github.com/users/nixphix/following{/other_user}","gists_url":"https://api.github.com/users/nixphix/gists{/gist_id}","starred_url":"https://api.github.com/users/nixphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixphix/subscriptions","organizations_url":"https://api.github.com/users/nixphix/orgs","repos_url":"https://api.github.com/users/nixphix/repos","events_url":"https://api.github.com/users/nixphix/events{/privacy}","received_events_url":"https://api.github.com/users/nixphix/received_events","type":"User","site_admin":false},"body":"Partially Fixes #23877\r\n\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n\r\n@jreback Could you please review the fixtures, I haven't replaced all the `indexes` if the changes are correct I would fixturize other test cases ","created_at":"2018-11-27T07:10:52Z","updated_at":"2018-12-31T23:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"659cf2e77d4fdbc75c325371f5006c1a5a33a15c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":127685,"node_id":"MDU6TGFiZWwxMjc2ODU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23943/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/74e0d39271dcf6a158525ec9e32b768cb0922a59","head":{"label":"nixphix:cleanup/fixturize-test-base","ref":"cleanup/fixturize-test-base","sha":"74e0d39271dcf6a158525ec9e32b768cb0922a59","user":{"login":"nixphix","id":4676330,"node_id":"MDQ6VXNlcjQ2NzYzMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4676330?v=4","gravatar_id":"","url":"https://api.github.com/users/nixphix","html_url":"https://github.com/nixphix","followers_url":"https://api.github.com/users/nixphix/followers","following_url":"https://api.github.com/users/nixphix/following{/other_user}","gists_url":"https://api.github.com/users/nixphix/gists{/gist_id}","starred_url":"https://api.github.com/users/nixphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixphix/subscriptions","organizations_url":"https://api.github.com/users/nixphix/orgs","repos_url":"https://api.github.com/users/nixphix/repos","events_url":"https://api.github.com/users/nixphix/events{/privacy}","received_events_url":"https://api.github.com/users/nixphix/received_events","type":"User","site_admin":false},"repo":{"id":157252063,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNTIwNjM=","name":"pandas","full_name":"nixphix/pandas","private":false,"owner":{"login":"nixphix","id":4676330,"node_id":"MDQ6VXNlcjQ2NzYzMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4676330?v=4","gravatar_id":"","url":"https://api.github.com/users/nixphix","html_url":"https://github.com/nixphix","followers_url":"https://api.github.com/users/nixphix/followers","following_url":"https://api.github.com/users/nixphix/following{/other_user}","gists_url":"https://api.github.com/users/nixphix/gists{/gist_id}","starred_url":"https://api.github.com/users/nixphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixphix/subscriptions","organizations_url":"https://api.github.com/users/nixphix/orgs","repos_url":"https://api.github.com/users/nixphix/repos","events_url":"https://api.github.com/users/nixphix/events{/privacy}","received_events_url":"https://api.github.com/users/nixphix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nixphix/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/nixphix/pandas","forks_url":"https://api.github.com/repos/nixphix/pandas/forks","keys_url":"https://api.github.com/repos/nixphix/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nixphix/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nixphix/pandas/teams","hooks_url":"https://api.github.com/repos/nixphix/pandas/hooks","issue_events_url":"https://api.github.com/repos/nixphix/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/nixphix/pandas/events","assignees_url":"https://api.github.com/repos/nixphix/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/nixphix/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/nixphix/pandas/tags","blobs_url":"https://api.github.com/repos/nixphix/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nixphix/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nixphix/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/nixphix/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nixphix/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/nixphix/pandas/languages","stargazers_url":"https://api.github.com/repos/nixphix/pandas/stargazers","contributors_url":"https://api.github.com/repos/nixphix/pandas/contributors","subscribers_url":"https://api.github.com/repos/nixphix/pandas/subscribers","subscription_url":"https://api.github.com/repos/nixphix/pandas/subscription","commits_url":"https://api.github.com/repos/nixphix/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/nixphix/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/nixphix/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/nixphix/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/nixphix/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/nixphix/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nixphix/pandas/merges","archive_url":"https://api.github.com/repos/nixphix/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nixphix/pandas/downloads","issues_url":"https://api.github.com/repos/nixphix/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/nixphix/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/nixphix/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/nixphix/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nixphix/pandas/labels{/name}","releases_url":"https://api.github.com/repos/nixphix/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/nixphix/pandas/deployments","created_at":"2018-11-12T17:40:12Z","updated_at":"2018-11-12T17:40:19Z","pushed_at":"2018-12-30T03:45:14Z","git_url":"git://github.com/nixphix/pandas.git","ssh_url":"git@github.com:nixphix/pandas.git","clone_url":"https://github.com/nixphix/pandas.git","svn_url":"https://github.com/nixphix/pandas","homepage":"https://pandas.pydata.org","size":141694,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"02a97c0a150377fab02fa22580d232c8242b5baa","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-12-31T23:36:30Z","pushed_at":"2018-12-31T23:33:57Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":142050,"stargazers_count":17610,"watchers_count":17610,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7050,"mirror_url":null,"archived":false,"open_issues_count":2785,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":7050,"open_issues":2785,"watchers":17610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23943"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23943"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23943/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23943/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/74e0d39271dcf6a158525ec9e32b768cb0922a59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}