{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/227592189","pull_request_review_id":167670204,"id":227592189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzU5MjE4OQ==","diff_hunk":"@@ -249,10 +249,13 @@ def test_prologue_hook_does_not_execute_twice_on_pbsdsh(self):\n \n         j = Job(TEST_USER, {'Resource_List.select': '2:ncpus=1',\n                             'Resource_List.place': 'scatter'})\n-        j.create_script('pbsdsh -n 1 hostname')\n+        j.set_sleep_time(\"5\")","path":"test/tests/functional/pbs_hook_execjob_prologue.py","position":5,"original_position":5,"commit_id":"965b449a1a3ca97a6d2c87a1b394af8a055fe3ec","original_commit_id":"965b449a1a3ca97a6d2c87a1b394af8a055fe3ec","user":{"login":"anamikau","id":17330444,"node_id":"MDQ6VXNlcjE3MzMwNDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/17330444?v=4","gravatar_id":"","url":"https://api.github.com/users/anamikau","html_url":"https://github.com/anamikau","followers_url":"https://api.github.com/users/anamikau/followers","following_url":"https://api.github.com/users/anamikau/following{/other_user}","gists_url":"https://api.github.com/users/anamikau/gists{/gist_id}","starred_url":"https://api.github.com/users/anamikau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anamikau/subscriptions","organizations_url":"https://api.github.com/users/anamikau/orgs","repos_url":"https://api.github.com/users/anamikau/repos","events_url":"https://api.github.com/users/anamikau/events{/privacy}","received_events_url":"https://api.github.com/users/anamikau/received_events","type":"User","site_admin":false},"body":"however I have learnt that it is not mandatory to have pbsdsh for exec job_prologue hook now to run prologue hook on sister moms, but this test is about running pbsdsh.\r\n\r\nYour changes are fine but not testing what this test was supposed to do. instead of reading from exec_vnode read from the job output file. update the job script to have \"pbsdsh hostname\" and submit a 2 chunk job. Read the output file and get the hostnames on which this job has run. for example,\r\n\r\nanamika@testdev-01-s11p2:~> cat job1.sh.o9\r\nx40-64-centos64.pbspro.com\r\ntestdev-01-s11p2\r\n\r\nand then look for the \"Job;9.testdev-01-s11p2;executed prologue hook\" in mom_logs of both the hosts.","created_at":"2018-10-23T22:50:38Z","updated_at":"2018-10-23T22:51:38Z","html_url":"https://github.com/PBSPro/pbspro/pull/851#discussion_r227592189","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/851","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/227592189"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/851#discussion_r227592189"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/851"}}},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/851","id":224990781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTkwNzgx","html_url":"https://github.com/PBSPro/pbspro/pull/851","diff_url":"https://github.com/PBSPro/pbspro/pull/851.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/851.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/851","number":851,"state":"open","locked":false,"title":"test_prologue_hook_does_not_execute_twice is failing due to incorrect mom in log_match","user":{"login":"VishrutArora","id":22411058,"node_id":"MDQ6VXNlcjIyNDExMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22411058?v=4","gravatar_id":"","url":"https://api.github.com/users/VishrutArora","html_url":"https://github.com/VishrutArora","followers_url":"https://api.github.com/users/VishrutArora/followers","following_url":"https://api.github.com/users/VishrutArora/following{/other_user}","gists_url":"https://api.github.com/users/VishrutArora/gists{/gist_id}","starred_url":"https://api.github.com/users/VishrutArora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishrutArora/subscriptions","organizations_url":"https://api.github.com/users/VishrutArora/orgs","repos_url":"https://api.github.com/users/VishrutArora/repos","events_url":"https://api.github.com/users/VishrutArora/events{/privacy}","received_events_url":"https://api.github.com/users/VishrutArora/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\n* *Clearly and concisely describe the problem/feature as it affects the customer (this cannot be empty)*\r\n* *Bugs: clearly describe the steps to easily reproduce the problem; you can include short illustrative excerpts from log files or terminal sessions*\r\n* *Bugs: if the issue is intermittent and not easily reproducible, describe the situation/scenarios/configurations where it was likely triggered*\r\n* *If there is an issue ID, link to it: [PP-XXXX](https://pbspro.atlassian.net/browse/PP-XXXX)*\r\n\r\n#### Affected Platform(s)\r\n* *Platform (for example CentOS 7.2)*\r\n\r\n#### Cause / Analysis / Design\r\n* test_prologue_hook_does_not_execute_twice is failing due to incorrect mom being specified for the log_match function\r\n\r\n#### Solution Description\r\n* Changed the mom object of the log_match function using exec_vnode attribute from the job.\r\n\r\n#### Testing logs/output\r\n* *Please attach your test log output from running the test you added (or from existing tests that cover your changes)*\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n   - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n   - [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [ ] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-10-23T10:56:12Z","updated_at":"2018-10-23T22:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2970875f0019c787eb7866cc650410655f85c535","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/851/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/851/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/851/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/965b449a1a3ca97a6d2c87a1b394af8a055fe3ec","head":{"label":"VishrutArora:PBS-20456","ref":"PBS-20456","sha":"965b449a1a3ca97a6d2c87a1b394af8a055fe3ec","user":{"login":"VishrutArora","id":22411058,"node_id":"MDQ6VXNlcjIyNDExMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22411058?v=4","gravatar_id":"","url":"https://api.github.com/users/VishrutArora","html_url":"https://github.com/VishrutArora","followers_url":"https://api.github.com/users/VishrutArora/followers","following_url":"https://api.github.com/users/VishrutArora/following{/other_user}","gists_url":"https://api.github.com/users/VishrutArora/gists{/gist_id}","starred_url":"https://api.github.com/users/VishrutArora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishrutArora/subscriptions","organizations_url":"https://api.github.com/users/VishrutArora/orgs","repos_url":"https://api.github.com/users/VishrutArora/repos","events_url":"https://api.github.com/users/VishrutArora/events{/privacy}","received_events_url":"https://api.github.com/users/VishrutArora/received_events","type":"User","site_admin":false},"repo":{"id":97695889,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY5NTg4OQ==","name":"pbspro","full_name":"VishrutArora/pbspro","private":false,"owner":{"login":"VishrutArora","id":22411058,"node_id":"MDQ6VXNlcjIyNDExMDU4","avatar_url":"https://avatars3.githubusercontent.com/u/22411058?v=4","gravatar_id":"","url":"https://api.github.com/users/VishrutArora","html_url":"https://github.com/VishrutArora","followers_url":"https://api.github.com/users/VishrutArora/followers","following_url":"https://api.github.com/users/VishrutArora/following{/other_user}","gists_url":"https://api.github.com/users/VishrutArora/gists{/gist_id}","starred_url":"https://api.github.com/users/VishrutArora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishrutArora/subscriptions","organizations_url":"https://api.github.com/users/VishrutArora/orgs","repos_url":"https://api.github.com/users/VishrutArora/repos","events_url":"https://api.github.com/users/VishrutArora/events{/privacy}","received_events_url":"https://api.github.com/users/VishrutArora/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VishrutArora/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/VishrutArora/pbspro","forks_url":"https://api.github.com/repos/VishrutArora/pbspro/forks","keys_url":"https://api.github.com/repos/VishrutArora/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VishrutArora/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VishrutArora/pbspro/teams","hooks_url":"https://api.github.com/repos/VishrutArora/pbspro/hooks","issue_events_url":"https://api.github.com/repos/VishrutArora/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/VishrutArora/pbspro/events","assignees_url":"https://api.github.com/repos/VishrutArora/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/VishrutArora/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/VishrutArora/pbspro/tags","blobs_url":"https://api.github.com/repos/VishrutArora/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VishrutArora/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VishrutArora/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/VishrutArora/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VishrutArora/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/VishrutArora/pbspro/languages","stargazers_url":"https://api.github.com/repos/VishrutArora/pbspro/stargazers","contributors_url":"https://api.github.com/repos/VishrutArora/pbspro/contributors","subscribers_url":"https://api.github.com/repos/VishrutArora/pbspro/subscribers","subscription_url":"https://api.github.com/repos/VishrutArora/pbspro/subscription","commits_url":"https://api.github.com/repos/VishrutArora/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/VishrutArora/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/VishrutArora/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/VishrutArora/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/VishrutArora/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/VishrutArora/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VishrutArora/pbspro/merges","archive_url":"https://api.github.com/repos/VishrutArora/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VishrutArora/pbspro/downloads","issues_url":"https://api.github.com/repos/VishrutArora/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/VishrutArora/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/VishrutArora/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/VishrutArora/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VishrutArora/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/VishrutArora/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/VishrutArora/pbspro/deployments","created_at":"2017-07-19T09:02:58Z","updated_at":"2018-10-23T10:44:42Z","pushed_at":"2018-10-23T13:59:45Z","git_url":"git://github.com/VishrutArora/pbspro.git","ssh_url":"git@github.com:VishrutArora/pbspro.git","clone_url":"https://github.com/VishrutArora/pbspro.git","svn_url":"https://github.com/VishrutArora/pbspro","homepage":"www.pbspro.org","size":16294,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"13af16df6dde5edc922d84aaf3aa3449e0365fca","user":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA4MjA3Mg==","name":"pbspro","full_name":"PBSPro/pbspro","private":false,"owner":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-10-23T10:04:32Z","pushed_at":"2018-10-23T22:13:50Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":16317,"stargazers_count":212,"watchers_count":212,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":161,"open_issues":22,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/851"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/851"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/851"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/851/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/851/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/851/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/965b449a1a3ca97a6d2c87a1b394af8a055fe3ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anamikau"}}