{"action":"created","issue":{"url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/683","repository_url":"https://api.github.com/repos/drewbrokke/liferay-portal","labels_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/683/comments","events_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/683/events","html_url":"https://github.com/drewbrokke/liferay-portal/pull/683","id":387409228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTA0MzEx","number":683,"title":"LPS-81837","user":{"login":"ChrisKian","id":10406971,"node_id":"MDQ6VXNlcjEwNDA2OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/10406971?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"labels":[{"id":928104812,"node_id":"MDU6TGFiZWw5MjgxMDQ4MTI=","url":"https://api.github.com/repos/drewbrokke/liferay-portal/labels/ci:test:relevant%20-%20pending","name":"ci:test:relevant - pending","color":"fff4c9","default":false},{"id":926911007,"node_id":"MDU6TGFiZWw5MjY5MTEwMDc=","url":"https://api.github.com/repos/drewbrokke/liferay-portal/labels/ci:test:sf%20-%20failure","name":"ci:test:sf - failure","color":"fccdcc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-04T17:56:51Z","updated_at":"2018-12-04T18:06:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/drewbrokke/liferay-portal/pulls/683","html_url":"https://github.com/drewbrokke/liferay-portal/pull/683","diff_url":"https://github.com/drewbrokke/liferay-portal/pull/683.diff","patch_url":"https://github.com/drewbrokke/liferay-portal/pull/683.patch"},"body":"https://issues.liferay.com/browse/LPS-81837\r\n\r\nThe difference between how we store org logos is between 62x and 7010, in which we add the \"logoId\" column to the Organization_ table.  So, 62x and lower, we are actually storing the logoId in the LayoutSet table, under both the public and private pages (it's a different logoId for each, but it points to the same image).  And in 7010 and up, we store it in the Organization_ table under the \"logoId\" column.\r\n\r\nI chose to only include this fix as a 7.0 upgrade process because once the DB has been upgraded to 7000 and up, there is no way to know for sure if the user intended to set a logo for their org or for the layoutSet of their org.  This is because post 7000, the logoId field in the layoutSet table (which was previously used for the org's logo), is now used for the public/private layoutSet's logo.  In the off chance a user wants their layoutSets to have logos but not their org, we would mess that up.\r\n\r\nThe fix itself is pretty straight-forward.  We grab the logoId and groupId from the layoutSet table whenever the logoId is present and we are dealing with a public layoutSet (to avoid duplication).  Next, we match that groupId to the classPK (or organizationId) from the Group_ table, and lastly we take the classPK match it to the Organization_ table, and insert the logoId.  After that, the logo is successfully found.\r\n\r\nPlease let me know if you have any questions."},"comment":{"url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/comments/444198475","html_url":"https://github.com/drewbrokke/liferay-portal/pull/683#issuecomment-444198475","issue_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/683","id":444198475,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDE5ODQ3NQ==","user":{"login":"ChrisKian","id":10406971,"node_id":"MDQ6VXNlcjEwNDA2OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/10406971?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T18:06:06Z","updated_at":"2018-12-04T18:06:06Z","author_association":"NONE","body":"ci:test:sf"}}
{"actor":{"display_login":"ChrisKian"}}