{"action":"created","issue":{"url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/22","repository_url":"https://api.github.com/repos/svpcom/wifibroadcast","labels_url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/22/comments","events_url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/22/events","html_url":"https://github.com/svpcom/wifibroadcast/issues/22","id":380042501,"node_id":"MDU6SXNzdWUzODAwNDI1MDE=","number":22,"title":"security issue","user":{"login":"dposea","id":2893999,"node_id":"MDQ6VXNlcjI4OTM5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2893999?v=4","gravatar_id":"","url":"https://api.github.com/users/dposea","html_url":"https://github.com/dposea","followers_url":"https://api.github.com/users/dposea/followers","following_url":"https://api.github.com/users/dposea/following{/other_user}","gists_url":"https://api.github.com/users/dposea/gists{/gist_id}","starred_url":"https://api.github.com/users/dposea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposea/subscriptions","organizations_url":"https://api.github.com/users/dposea/orgs","repos_url":"https://api.github.com/users/dposea/repos","events_url":"https://api.github.com/users/dposea/events{/privacy}","received_events_url":"https://api.github.com/users/dposea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-13T03:23:24Z","updated_at":"2018-11-13T06:35:31Z","closed_at":null,"author_association":"NONE","body":"The following warning points to a security issue with printf in linux. Google printf exploit for details.\r\n\r\nwifibroadcast.hpp: In instantiation of ‘std::__cxx11::string string_format(const char*, Args ...) [with Args = {}; std::__cxx11::string = std::__cxx11::basic_string<char>]’:\r\ntx.cpp:137:68:   required from here\r\nwifibroadcast.hpp:46:27: warning: format not a string literal and no format arguments [-Wformat-security]\r\n     size_t size = snprintf(nullptr, 0, format, args ...) + 1; // Extra space fo\r\n                           ^\r\nwifibroadcast.hpp:46:27: warning: format not a string literal and no format arguments [-Wformat-security]\r\nwifibroadcast.hpp:48:13: warning: format not a string literal and no format arguments [-Wformat-security]\r\n     snprintf(buf.get(), size, format, args ...);\r\n             ^\r\nwifibroadcast.hpp:48:13: warning: format not a string literal and no format arguments [-Wformat-security]\r\n"},"comment":{"url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/comments/438154015","html_url":"https://github.com/svpcom/wifibroadcast/issues/22#issuecomment-438154015","issue_url":"https://api.github.com/repos/svpcom/wifibroadcast/issues/22","id":438154015,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODE1NDAxNQ==","user":{"login":"svpcom","id":503830,"node_id":"MDQ6VXNlcjUwMzgzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/503830?v=4","gravatar_id":"","url":"https://api.github.com/users/svpcom","html_url":"https://github.com/svpcom","followers_url":"https://api.github.com/users/svpcom/followers","following_url":"https://api.github.com/users/svpcom/following{/other_user}","gists_url":"https://api.github.com/users/svpcom/gists{/gist_id}","starred_url":"https://api.github.com/users/svpcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svpcom/subscriptions","organizations_url":"https://api.github.com/users/svpcom/orgs","repos_url":"https://api.github.com/users/svpcom/repos","events_url":"https://api.github.com/users/svpcom/events{/privacy}","received_events_url":"https://api.github.com/users/svpcom/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T06:35:31Z","updated_at":"2018-11-13T06:35:31Z","author_association":"OWNER","body":"This is not a bug but a compiler warning. `string_format` function is line `snprintf` but outputs to a STL string. Old gcc is not smart enough and generate a warning due to non-literal format string and varargs as argument list"}}
{"actor":{"display_login":"svpcom"}}