{"action":"created","comment":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/comments/196556177","pull_request_review_id":130128916,"id":196556177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU1NjE3Nw==","diff_hunk":"@@ -91,18 +93,67 @@ runPayload c@Command{..} = do\n         _ -> return $ jsonResult mode (cmdToRequestKey c) $ CommandError \"Private\" Nothing\n     Nothing -> runRpc _pPayload\n \n-\n-\n applyExec :: RequestKey -> ExecMsg ParsedCode -> Command a -> CommandM p CommandResult\n applyExec rk (ExecMsg parsedCode edata) Command{..} = do\n   CommandEnv {..} <- ask\n   when (null (_pcExps parsedCode)) $ throwCmdEx \"No expressions found\"\n-  (CommandState refStore) <- liftIO $ readMVar _ceState\n-  let evalEnv = setupEvalEnv _ceDbEnv _ceEntity _ceMode\n-                (MsgData (userSigsToPactKeySet _cmdSigs) edata Nothing _cmdHash) refStore\n-  pr <- liftIO $ evalExec evalEnv parsedCode\n-  void $ liftIO $ swapMVar _ceState $ CommandState (erRefStore pr)\n-  return $ jsonResult _ceMode rk $ CommandSuccess (last (erOutput pr))\n-\n-applyContinuation :: ContMsg -> [UserSig] -> CommandM p CommandResult\n-applyContinuation _ _ = throwCmdEx \"Continuation not supported\"\n+  CommandState {..} <- liftIO $ readMVar _ceState\n+  let sigs = userSigsToPactKeySet _cmdSigs\n+      evalEnv = setupEvalEnv _ceDbEnv _ceEntity _ceMode\n+                (MsgData sigs edata Nothing _cmdHash) _csRefStore\n+  EvalResult{..} <- liftIO $ evalExec evalEnv parsedCode\n+  newPact <- join <$> mapM (handleYield erInput _cmdSigs) erExec\n+  let newState = CommandState erRefStore $ case newPact of\n+        Nothing -> _csPacts\n+        Just (cp@CommandPact{..}) -> M.insert _cpTxId cp _csPacts\n+  void $ liftIO $ swapMVar _ceState newState\n+  return $ jsonResult _ceMode rk $ CommandSuccess (last erOutput)\n+\n+-- Better name?","path":"src-ghc/Pact/Server/PactService.hs","position":83,"original_position":83,"commit_id":"fdd42b26148d9550a4799acf91c2ba46377fe040","original_commit_id":"fdd42b26148d9550a4799acf91c2ba46377fe040","user":{"login":"slpopejoy","id":8353613,"node_id":"MDQ6VXNlcjgzNTM2MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8353613?v=4","gravatar_id":"","url":"https://api.github.com/users/slpopejoy","html_url":"https://github.com/slpopejoy","followers_url":"https://api.github.com/users/slpopejoy/followers","following_url":"https://api.github.com/users/slpopejoy/following{/other_user}","gists_url":"https://api.github.com/users/slpopejoy/gists{/gist_id}","starred_url":"https://api.github.com/users/slpopejoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slpopejoy/subscriptions","organizations_url":"https://api.github.com/users/slpopejoy/orgs","repos_url":"https://api.github.com/users/slpopejoy/repos","events_url":"https://api.github.com/users/slpopejoy/events{/privacy}","received_events_url":"https://api.github.com/users/slpopejoy/received_events","type":"User","site_admin":false},"body":"sure, handlePactExec or whatever","created_at":"2018-06-19T19:52:20Z","updated_at":"2018-06-19T19:58:34Z","html_url":"https://github.com/kadena-io/pact/pull/128#discussion_r196556177","pull_request_url":"https://api.github.com/repos/kadena-io/pact/pulls/128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments/196556177"},"html":{"href":"https://github.com/kadena-io/pact/pull/128#discussion_r196556177"},"pull_request":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/128","id":195935830,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTM1ODMw","html_url":"https://github.com/kadena-io/pact/pull/128","diff_url":"https://github.com/kadena-io/pact/pull/128.diff","patch_url":"https://github.com/kadena-io/pact/pull/128.patch","issue_url":"https://api.github.com/repos/kadena-io/pact/issues/128","number":128,"state":"open","locked":false,"title":"Pact resume server (review-only PR)","user":{"login":"slpopejoy","id":8353613,"node_id":"MDQ6VXNlcjgzNTM2MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8353613?v=4","gravatar_id":"","url":"https://api.github.com/users/slpopejoy","html_url":"https://github.com/slpopejoy","followers_url":"https://api.github.com/users/slpopejoy/followers","following_url":"https://api.github.com/users/slpopejoy/following{/other_user}","gists_url":"https://api.github.com/users/slpopejoy/gists{/gist_id}","starred_url":"https://api.github.com/users/slpopejoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slpopejoy/subscriptions","organizations_url":"https://api.github.com/users/slpopejoy/orgs","repos_url":"https://api.github.com/users/slpopejoy/repos","events_url":"https://api.github.com/users/slpopejoy/events{/privacy}","received_events_url":"https://api.github.com/users/slpopejoy/received_events","type":"User","site_admin":false},"body":"This is to allow ongoing review of Linda's work on resume","created_at":"2018-06-19T19:38:52Z","updated_at":"2018-06-19T19:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9278920db542817d35fb454f54c6534117de985","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kadena-io/pact/pulls/128/commits","review_comments_url":"https://api.github.com/repos/kadena-io/pact/pulls/128/comments","review_comment_url":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kadena-io/pact/issues/128/comments","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/fdd42b26148d9550a4799acf91c2ba46377fe040","head":{"label":"kadena-io:pact-resume-server","ref":"pact-resume-server","sha":"fdd42b26148d9550a4799acf91c2ba46377fe040","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-06-19T18:31:50Z","pushed_at":"2018-06-19T19:38:53Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":2080,"stargazers_count":202,"watchers_count":202,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":21,"open_issues":41,"watchers":202,"default_branch":"master"}},"base":{"label":"kadena-io:master","ref":"master","sha":"b7dcd2f8e7117a7731b1973d4665ec246de62f14","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-06-19T18:31:50Z","pushed_at":"2018-06-19T19:38:53Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":2080,"stargazers_count":202,"watchers_count":202,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":21,"open_issues":41,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/128"},"html":{"href":"https://github.com/kadena-io/pact/pull/128"},"issue":{"href":"https://api.github.com/repos/kadena-io/pact/issues/128"},"comments":{"href":"https://api.github.com/repos/kadena-io/pact/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/kadena-io/pact/statuses/fdd42b26148d9550a4799acf91c2ba46377fe040"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slpopejoy"}}