{"action":"created","issue":{"url":"https://api.github.com/repos/secdev/scapy/issues/1505","repository_url":"https://api.github.com/repos/secdev/scapy","labels_url":"https://api.github.com/repos/secdev/scapy/issues/1505/labels{/name}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1505/comments","events_url":"https://api.github.com/repos/secdev/scapy/issues/1505/events","html_url":"https://github.com/secdev/scapy/issues/1505","id":337003227,"node_id":"MDU6SXNzdWUzMzcwMDMyMjc=","number":1505,"title":"Provide stop for sniff even when no packets received","user":{"login":"robgom","id":38496047,"node_id":"MDQ6VXNlcjM4NDk2MDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/38496047?v=4","gravatar_id":"","url":"https://api.github.com/users/robgom","html_url":"https://github.com/robgom","followers_url":"https://api.github.com/users/robgom/followers","following_url":"https://api.github.com/users/robgom/following{/other_user}","gists_url":"https://api.github.com/users/robgom/gists{/gist_id}","starred_url":"https://api.github.com/users/robgom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgom/subscriptions","organizations_url":"https://api.github.com/users/robgom/orgs","repos_url":"https://api.github.com/users/robgom/repos","events_url":"https://api.github.com/users/robgom/events{/privacy}","received_events_url":"https://api.github.com/users/robgom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-29T13:40:36Z","updated_at":"2018-07-15T14:29:31Z","closed_at":null,"author_association":"NONE","body":"Hi there,\r\nthis is a request to reopen #989 - I haven't received any feedback to my recent question.\r\nMissing the functionality affects our code.\r\n\r\nQuoting myself:\r\n\r\nCan it be reopened?\r\nWe observe the problem on Windows.\r\nWith scapy 2.3.1 we distributed local version of scapy, which used the following pattern:\r\n\r\np = None\r\nwhile stop_filter and stop_filter(p):\r\n... the loop as normal\r\n\r\nOn Windows it works, because there's PcapTimeout exception raised in case of no packets, which allows the condition to be checked.\r\nIt breaks backward compatibility, because it requires stop_filter to be aware of possible \"None\" as packet.\r\n\r\nWhat about the mentioned stop_sniff additional parameter to sniff as alternative? On Windows it would work, as indicated before, even if stop wouldn't occur immediately. I don't know about other platforms, though.\r\n\r\nWhat's your opinion?\r\n\r\nRegards,\r\nRobert"},"comment":{"url":"https://api.github.com/repos/secdev/scapy/issues/comments/405095792","html_url":"https://github.com/secdev/scapy/issues/1505#issuecomment-405095792","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1505","id":405095792,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTA5NTc5Mg==","user":{"login":"gpotter2","id":10530980,"node_id":"MDQ6VXNlcjEwNTMwOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T14:29:31Z","updated_at":"2018-07-15T14:29:31Z","author_association":"MEMBER","body":"Hi & sorry for the delay.\r\n\r\nWould a thing such as https://github.com/secdev/scapy/pull/1523 fits your needs ?"}}
{"actor":{"display_login":"gpotter2"}}