{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/21289","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/21289/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21289/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/21289/events","html_url":"https://github.com/dotnet/coreclr/pull/21289","id":385983056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODMwODE0","number":21289,"title":"Adding perf tests for some of the new math functions that are implemented as FCALLs","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-30T00:14:38Z","updated_at":"2018-12-04T21:31:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21289","html_url":"https://github.com/dotnet/coreclr/pull/21289","diff_url":"https://github.com/dotnet/coreclr/pull/21289.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21289.patch"},"body":"This fixes up an issue with the existing perf tests, in that they were off by one and many produced NaN rather than the actual result.\r\n\r\nThis also adds perf tests to cover all the new Math/MathF functions that were added recently and that are implemented as FCALLs in the runtime (the non FCALL functions that were added should be covered as perf tests in CoreFX)."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/444266138","html_url":"https://github.com/dotnet/coreclr/pull/21289#issuecomment-444266138","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21289","id":444266138,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDI2NjEzOA==","user":{"login":"adamsitnik","id":6011991,"node_id":"MDQ6VXNlcjYwMTE5OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6011991?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsitnik","html_url":"https://github.com/adamsitnik","followers_url":"https://api.github.com/users/adamsitnik/followers","following_url":"https://api.github.com/users/adamsitnik/following{/other_user}","gists_url":"https://api.github.com/users/adamsitnik/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsitnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsitnik/subscriptions","organizations_url":"https://api.github.com/users/adamsitnik/orgs","repos_url":"https://api.github.com/users/adamsitnik/repos","events_url":"https://api.github.com/users/adamsitnik/events{/privacy}","received_events_url":"https://api.github.com/users/adamsitnik/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T21:31:37Z","updated_at":"2018-12-04T21:31:37Z","author_association":"MEMBER","body":"> @adamsitnik can you point @tannergooding to instructions on how to do this?\r\n\r\nsure! I even have docs for that!\r\n\r\n@tannergooding  after reading https://github.com/dotnet/performance/blob/master/docs/porting-to-benchmarkdotnet.md you should be able to port those benchmarks and add them to https://github.com/dotnet/performance/tree/master/src/benchmarks/micro/coreclr/Math/Functions\r\n\r\nplease let me know if something is not clear or outdated"}}
{"actor":{"display_login":"adamsitnik"}}