{"action":"created","issue":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/2241","repository_url":"https://api.github.com/repos/diffblue/cbmc","labels_url":"https://api.github.com/repos/diffblue/cbmc/issues/2241/labels{/name}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/2241/comments","events_url":"https://api.github.com/repos/diffblue/cbmc/issues/2241/events","html_url":"https://github.com/diffblue/cbmc/pull/2241","id":326735259,"number":2241,"title":"goto-cc: add separate path for ld","user":{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false},"labels":[{"id":526654365,"url":"https://api.github.com/repos/diffblue/cbmc/labels/cleanup","name":"cleanup","color":"1d76db","default":false},{"id":945002283,"url":"https://api.github.com/repos/diffblue/cbmc/labels/work%20in%20progress","name":"work in progress","color":"2a63ea","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-26T12:38:39Z","updated_at":"2018-05-27T14:33:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/2241","html_url":"https://github.com/diffblue/cbmc/pull/2241","diff_url":"https://github.com/diffblue/cbmc/pull/2241.diff","patch_url":"https://github.com/diffblue/cbmc/pull/2241.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/comments/392335326","html_url":"https://github.com/diffblue/cbmc/pull/2241#issuecomment-392335326","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/2241","id":392335326,"user":{"login":"karkhaz","id":2887605,"avatar_url":"https://avatars1.githubusercontent.com/u/2887605?v=4","gravatar_id":"","url":"https://api.github.com/users/karkhaz","html_url":"https://github.com/karkhaz","followers_url":"https://api.github.com/users/karkhaz/followers","following_url":"https://api.github.com/users/karkhaz/following{/other_user}","gists_url":"https://api.github.com/users/karkhaz/gists{/gist_id}","starred_url":"https://api.github.com/users/karkhaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karkhaz/subscriptions","organizations_url":"https://api.github.com/users/karkhaz/orgs","repos_url":"https://api.github.com/users/karkhaz/repos","events_url":"https://api.github.com/users/karkhaz/events{/privacy}","received_events_url":"https://api.github.com/users/karkhaz/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T14:33:03Z","updated_at":"2018-05-27T14:33:03Z","author_association":"CONTRIBUTOR","body":"@kroening Thanks for sorting out the `const` qualifiers!\r\n\r\nAnswering some off-line questions:\r\n\r\n- I've never seen anybody passing `-Xlinker -T` to the compiler, probably because `gcc` already has its own `-T` flag and people just use that to pass a script to the linker. I suppose it doesn't hurt to support this though.\r\n\r\n- However, I think the linker +should+ have its own `-T` flag, in case somebody calls it standalone. I don't see a `-T` flag in the patch you posted above.\r\n\r\n- I don't think the linker script merging code needs to consider more than one output file/goto-binary pair. As far as I know, for any build, you would only pass `-T` to the final link (i.e. the final `gcc` invocation that you pass `-o` to instead of `-c`). In fact, [this line](https://github.com/diffblue/cbmc/blob/develop/src/goto-cc/linker_script_merge.cpp#L30) of the linker script code bails out early if either `-T` is not given or if there are more than one output binaries."}}
{"actor":{"display_login":"karkhaz"}}