{"action":"closed","number":258,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-rails/pulls/258","id":184804859,"html_url":"https://github.com/zurb/foundation-rails/pull/258","diff_url":"https://github.com/zurb/foundation-rails/pull/258.diff","patch_url":"https://github.com/zurb/foundation-rails/pull/258.patch","issue_url":"https://api.github.com/repos/zurb/foundation-rails/issues/258","number":258,"state":"closed","locked":false,"title":"chore: add support for multiple import solutions of JavaScript assets","user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"body":"This PR improve the way the sprockets file `foundation.js` is handled and make JavaScript assets importable by two differents ways according to the needs:\r\n* By the main Foundation file `foundation.js` (or `foundation.min.js`)\r\n* By all or some plugins `foundation.[plugin].js` (or `foundation.[plugin].min.js`)\r\n\r\n### Changes:\r\n* Make `foundation.js` a static asset and rename it to `foundation.sprockets.js`\r\n  As a precise import order must be kept, \"foundation.js\" sprocket file cannot be dynamically generated.\r\n* Add warning message on assets update to manually update `foundation.sprockets.js`\r\n* Move plugins files to \"vendor/assets/js/plugins\"\r\n* Add main Foundation distribution file `foundation.js` to assets\r\n* Add main and plugins minified files `*.min.js` to assets\r\nSee commits descriptions for more informations.\r\n\r\n### Others changes:\r\n* Import responsive menus in last in `foundation.sprockets.js` as they require others menus.\r\n\r\nSee https://github.com/zurb/foundation-rails/pull/257 (@patricklindsay)","created_at":"2018-04-28T20:48:28Z","updated_at":"2018-05-08T21:07:46Z","closed_at":"2018-05-08T21:07:45Z","merged_at":"2018-05-08T21:07:45Z","merge_commit_sha":"f95b876c22774cdfcc3c4fa7a75140a18178f91e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation-rails/pulls/258/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation-rails/pulls/258/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/foundation-rails/issues/258/comments","statuses_url":"https://api.github.com/repos/zurb/foundation-rails/statuses/32b34443b88b2e7efd5b31df507f0722317704e1","head":{"label":"ncoden:chore/multiple-js-import-solutions","ref":"chore/multiple-js-import-solutions","sha":"32b34443b88b2e7efd5b31df507f0722317704e1","user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"repo":{"id":124698956,"name":"foundation-rails","full_name":"ncoden/foundation-rails","owner":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncoden/foundation-rails","description":"Foundation for Rails","fork":true,"url":"https://api.github.com/repos/ncoden/foundation-rails","forks_url":"https://api.github.com/repos/ncoden/foundation-rails/forks","keys_url":"https://api.github.com/repos/ncoden/foundation-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncoden/foundation-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncoden/foundation-rails/teams","hooks_url":"https://api.github.com/repos/ncoden/foundation-rails/hooks","issue_events_url":"https://api.github.com/repos/ncoden/foundation-rails/issues/events{/number}","events_url":"https://api.github.com/repos/ncoden/foundation-rails/events","assignees_url":"https://api.github.com/repos/ncoden/foundation-rails/assignees{/user}","branches_url":"https://api.github.com/repos/ncoden/foundation-rails/branches{/branch}","tags_url":"https://api.github.com/repos/ncoden/foundation-rails/tags","blobs_url":"https://api.github.com/repos/ncoden/foundation-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncoden/foundation-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncoden/foundation-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncoden/foundation-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncoden/foundation-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/ncoden/foundation-rails/languages","stargazers_url":"https://api.github.com/repos/ncoden/foundation-rails/stargazers","contributors_url":"https://api.github.com/repos/ncoden/foundation-rails/contributors","subscribers_url":"https://api.github.com/repos/ncoden/foundation-rails/subscribers","subscription_url":"https://api.github.com/repos/ncoden/foundation-rails/subscription","commits_url":"https://api.github.com/repos/ncoden/foundation-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncoden/foundation-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncoden/foundation-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncoden/foundation-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncoden/foundation-rails/contents/{+path}","compare_url":"https://api.github.com/repos/ncoden/foundation-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncoden/foundation-rails/merges","archive_url":"https://api.github.com/repos/ncoden/foundation-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncoden/foundation-rails/downloads","issues_url":"https://api.github.com/repos/ncoden/foundation-rails/issues{/number}","pulls_url":"https://api.github.com/repos/ncoden/foundation-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/ncoden/foundation-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/ncoden/foundation-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncoden/foundation-rails/labels{/name}","releases_url":"https://api.github.com/repos/ncoden/foundation-rails/releases{/id}","deployments_url":"https://api.github.com/repos/ncoden/foundation-rails/deployments","created_at":"2018-03-10T21:14:06Z","updated_at":"2018-03-10T21:14:08Z","pushed_at":"2018-04-28T20:39:24Z","git_url":"git://github.com/ncoden/foundation-rails.git","ssh_url":"git@github.com:ncoden/foundation-rails.git","clone_url":"https://github.com/ncoden/foundation-rails.git","svn_url":"https://github.com/ncoden/foundation-rails","homepage":"foundation.zurb.com","size":2249,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zurb:develop","ref":"develop","sha":"e5e2eed59097f9af81a4902b3ff958ff7bbe4c88","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars2.githubusercontent.com/u/156122?v=4","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2368749,"name":"foundation-rails","full_name":"zurb/foundation-rails","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars2.githubusercontent.com/u/156122?v=4","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-rails","description":"Foundation for Rails","fork":false,"url":"https://api.github.com/repos/zurb/foundation-rails","forks_url":"https://api.github.com/repos/zurb/foundation-rails/forks","keys_url":"https://api.github.com/repos/zurb/foundation-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-rails/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-rails/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-rails/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-rails/events","assignees_url":"https://api.github.com/repos/zurb/foundation-rails/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-rails/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-rails/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-rails/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-rails/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-rails/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-rails/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-rails/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-rails/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-rails/merges","archive_url":"https://api.github.com/repos/zurb/foundation-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-rails/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-rails/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-rails/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-rails/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-rails/deployments","created_at":"2011-09-12T02:25:19Z","updated_at":"2018-05-01T04:51:53Z","pushed_at":"2018-05-08T21:07:45Z","git_url":"git://github.com/zurb/foundation-rails.git","ssh_url":"git@github.com:zurb/foundation-rails.git","clone_url":"https://github.com/zurb/foundation-rails.git","svn_url":"https://github.com/zurb/foundation-rails","homepage":"foundation.zurb.com","size":2074,"stargazers_count":965,"watchers_count":965,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":375,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":375,"open_issues":34,"watchers":965,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-rails/pulls/258"},"html":{"href":"https://github.com/zurb/foundation-rails/pull/258"},"issue":{"href":"https://api.github.com/repos/zurb/foundation-rails/issues/258"},"comments":{"href":"https://api.github.com/repos/zurb/foundation-rails/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation-rails/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation-rails/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation-rails/statuses/32b34443b88b2e7efd5b31df507f0722317704e1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":12227,"deletions":41,"changed_files":70}}
{"actor":{"display_login":"ncoden"}}