{"action":"created","comment":{"url":"https://api.github.com/repos/stsp/dosemu2/pulls/comments/206713281","pull_request_review_id":142180375,"id":206713281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcxMzI4MQ==","diff_hunk":"@@ -1929,100 +1927,25 @@ static void redirect_devices(void)\n \n static int redir_it(void)\n {\n-    uint16_t lol_lo, lol_hi, sda_lo, sda_hi, sda_size, redver, mosver;\n-    uint8_t major, minor;\n-    int is_MOS;\n-    int is_cf;\n-\n     if (redir_state)\n \treturn 0;\n     redir_state++;\n \n-    /*\n-     * To start up the redirector we need\n-     * (1) the list of list,\n-     * (2) the DOS version and\n-     * (3) the swappable data area.\n-     */\n     pre_msdos();\n \n-    LWORD(eax) = 0x1100;\n-    do_int_call_back(0x2f);\n-    if (LO(ax) != 0xff) {\n-\terror(\"Redirector unavailable\\n\");\n-\tpost_msdos();\n-\treturn 0;\n-    }\n-\n-    LWORD(eax) = 0x5200;\n-    call_msdos();\n-    ds_printf\n-\t(\"INT21 +1 at %04x:%04x: AX=%04x, BX=%04x, CX=%04x, DX=%04x, DS=%04x, ES=%04x\\n\",\n-\t SREG(cs), LWORD(eip), LWORD(eax), LWORD(ebx),\n-\t LWORD(ecx), LWORD(edx), SREG(ds), SREG(es));\n-    lol_lo = LWORD(ebx);\n-    lol_hi = SREG(es);\n-\n-    LWORD(eax) = LWORD(ebx) = LWORD(ecx) = LWORD(edx) = 0x3099; // MOS version trigger\n-    call_msdos();\n-    ds_printf\n-\t(\"INT21 +2b at %04x:%04x: AX=%04x, BX=%04x, CX=%04x, DX=%04x, DS=%04x, ES=%04x\\n\",\n-\t SREG(cs), LWORD(eip), LWORD(eax), LWORD(ebx),\n-\t LWORD(ecx), LWORD(edx), SREG(ds), SREG(es));\n-    mosver = LWORD(eax);\n-    LWORD(eax) = 0x3000;                                        // DOS version std request\n-    call_msdos();\n-    ds_printf\n-\t(\"INT21 +2 at %04x:%04x: AX=%04x, BX=%04x, CX=%04x, DX=%04x, DS=%04x, ES=%04x\\n\",\n-\t  SREG(cs), LWORD(eip), LWORD(eax), LWORD(ebx),\n-\t LWORD(ecx), LWORD(edx), SREG(ds), SREG(es));\n-    major = LO(ax);\n-    minor = HI(ax);\n-    is_MOS = (LWORD(eax) != mosver); // different result!\n+    LWORD(eax) = DOS_HELPER_MFS_HELPER;\n+    LWORD(ebx) = DOS_SUBHELPER_MFS_REDIR_INIT;\n+    mfs_inte6();\n \n-    LWORD(eax) = 0x5d06;\n-    call_msdos();\n-    ds_printf\n-\t(\"INT21 +3 at %04x:%04x: AX=%04x, BX=%04x, CX=%04x, DX=%04x, DS=%04x, ES=%04x\\n\",\n-\t SREG(cs), LWORD(eip), LWORD(eax), LWORD(ebx),\n-\t LWORD(ecx), LWORD(edx), SREG(ds), SREG(es));\n-    sda_lo = LWORD(esi);\n-    sda_hi = SREG(ds);\n-    sda_size = LWORD(ecx);\n-\n-    ds_printf(\"INT21: lol = 0x%04x\\n\", (lol_hi << 4) + lol_lo);\n-    ds_printf(\"INT21: sda = 0x%04x, size = 0x%04x\\n\",\n-\t      (sda_hi << 4) + sda_lo, sda_size);\n-    ds_printf(\"INT21: ver = 0x%02x, 0x%02x\\n\", major, minor);\n-\n-    /* Figure out the redirector version */\n-    if (is_MOS) {\n-        redver = REDVER_NONE;\n+    if (!isset_CF()) {\t/* We have a functioning redirector so use it */\n+      LWORD(eax) = DOS_HELPER_MFS_HELPER;\n+      LWORD(ebx) = DOS_SUBHELPER_MFS_REDIR_CLONE;","path":"src/base/async/int.c","position":103,"original_position":103,"commit_id":"0be7063cd1137c0e8cb79278ad05151edfe536c0","original_commit_id":"0be7063cd1137c0e8cb79278ad05151edfe536c0","user":{"login":"stsp","id":3295627,"node_id":"MDQ6VXNlcjMyOTU2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3295627?v=4","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"body":"Clone? What does it mean?\r\nAlso its a bit strange that you call\r\ninit and then immediately this \"clone\",\r\nmaybe it should be a single call then?","created_at":"2018-07-31T23:18:12Z","updated_at":"2018-07-31T23:18:12Z","html_url":"https://github.com/stsp/dosemu2/pull/658#discussion_r206713281","pull_request_url":"https://api.github.com/repos/stsp/dosemu2/pulls/658","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/comments/206713281"},"html":{"href":"https://github.com/stsp/dosemu2/pull/658#discussion_r206713281"},"pull_request":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/658"}}},"pull_request":{"url":"https://api.github.com/repos/stsp/dosemu2/pulls/658","id":205263213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjYzMjEz","html_url":"https://github.com/stsp/dosemu2/pull/658","diff_url":"https://github.com/stsp/dosemu2/pull/658.diff","patch_url":"https://github.com/stsp/dosemu2/pull/658.patch","issue_url":"https://api.github.com/repos/stsp/dosemu2/issues/658","number":658,"state":"open","locked":false,"title":"MFS: Move redirector version logic","user":{"login":"andrewbird","id":220835,"node_id":"MDQ6VXNlcjIyMDgzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220835?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewbird","html_url":"https://github.com/andrewbird","followers_url":"https://api.github.com/users/andrewbird/followers","following_url":"https://api.github.com/users/andrewbird/following{/other_user}","gists_url":"https://api.github.com/users/andrewbird/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbird/subscriptions","organizations_url":"https://api.github.com/users/andrewbird/orgs","repos_url":"https://api.github.com/users/andrewbird/repos","events_url":"https://api.github.com/users/andrewbird/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbird/received_events","type":"User","site_admin":false},"body":"Establish the redirector version and the lol & sda values in one place.\r\n\r\nAdvantages:\r\n   1/ Remove duplicate logic\r\n   2/ Shrinks the emufs.sys by around 120 bytes.","created_at":"2018-07-31T22:44:37Z","updated_at":"2018-07-31T23:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ccd7958d95b14c0d2f99a2ef72f7f01c848b729","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stsp/dosemu2/pulls/658/commits","review_comments_url":"https://api.github.com/repos/stsp/dosemu2/pulls/658/comments","review_comment_url":"https://api.github.com/repos/stsp/dosemu2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stsp/dosemu2/issues/658/comments","statuses_url":"https://api.github.com/repos/stsp/dosemu2/statuses/0be7063cd1137c0e8cb79278ad05151edfe536c0","head":{"label":"andrewbird:mfs-fixes01g","ref":"mfs-fixes01g","sha":"0be7063cd1137c0e8cb79278ad05151edfe536c0","user":{"login":"andrewbird","id":220835,"node_id":"MDQ6VXNlcjIyMDgzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220835?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewbird","html_url":"https://github.com/andrewbird","followers_url":"https://api.github.com/users/andrewbird/followers","following_url":"https://api.github.com/users/andrewbird/following{/other_user}","gists_url":"https://api.github.com/users/andrewbird/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbird/subscriptions","organizations_url":"https://api.github.com/users/andrewbird/orgs","repos_url":"https://api.github.com/users/andrewbird/repos","events_url":"https://api.github.com/users/andrewbird/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbird/received_events","type":"User","site_admin":false},"repo":{"id":35490929,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ5MDkyOQ==","name":"dosemu2","full_name":"andrewbird/dosemu2","owner":{"login":"andrewbird","id":220835,"node_id":"MDQ6VXNlcjIyMDgzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220835?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewbird","html_url":"https://github.com/andrewbird","followers_url":"https://api.github.com/users/andrewbird/followers","following_url":"https://api.github.com/users/andrewbird/following{/other_user}","gists_url":"https://api.github.com/users/andrewbird/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbird/subscriptions","organizations_url":"https://api.github.com/users/andrewbird/orgs","repos_url":"https://api.github.com/users/andrewbird/repos","events_url":"https://api.github.com/users/andrewbird/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewbird/dosemu2","description":"Run DOS programs under linux:","fork":true,"url":"https://api.github.com/repos/andrewbird/dosemu2","forks_url":"https://api.github.com/repos/andrewbird/dosemu2/forks","keys_url":"https://api.github.com/repos/andrewbird/dosemu2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewbird/dosemu2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewbird/dosemu2/teams","hooks_url":"https://api.github.com/repos/andrewbird/dosemu2/hooks","issue_events_url":"https://api.github.com/repos/andrewbird/dosemu2/issues/events{/number}","events_url":"https://api.github.com/repos/andrewbird/dosemu2/events","assignees_url":"https://api.github.com/repos/andrewbird/dosemu2/assignees{/user}","branches_url":"https://api.github.com/repos/andrewbird/dosemu2/branches{/branch}","tags_url":"https://api.github.com/repos/andrewbird/dosemu2/tags","blobs_url":"https://api.github.com/repos/andrewbird/dosemu2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewbird/dosemu2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewbird/dosemu2/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewbird/dosemu2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewbird/dosemu2/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewbird/dosemu2/languages","stargazers_url":"https://api.github.com/repos/andrewbird/dosemu2/stargazers","contributors_url":"https://api.github.com/repos/andrewbird/dosemu2/contributors","subscribers_url":"https://api.github.com/repos/andrewbird/dosemu2/subscribers","subscription_url":"https://api.github.com/repos/andrewbird/dosemu2/subscription","commits_url":"https://api.github.com/repos/andrewbird/dosemu2/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewbird/dosemu2/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewbird/dosemu2/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewbird/dosemu2/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewbird/dosemu2/contents/{+path}","compare_url":"https://api.github.com/repos/andrewbird/dosemu2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewbird/dosemu2/merges","archive_url":"https://api.github.com/repos/andrewbird/dosemu2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewbird/dosemu2/downloads","issues_url":"https://api.github.com/repos/andrewbird/dosemu2/issues{/number}","pulls_url":"https://api.github.com/repos/andrewbird/dosemu2/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewbird/dosemu2/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewbird/dosemu2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewbird/dosemu2/labels{/name}","releases_url":"https://api.github.com/repos/andrewbird/dosemu2/releases{/id}","deployments_url":"https://api.github.com/repos/andrewbird/dosemu2/deployments","created_at":"2015-05-12T13:52:28Z","updated_at":"2018-07-30T10:14:30Z","pushed_at":"2018-07-31T22:57:51Z","git_url":"git://github.com/andrewbird/dosemu2.git","ssh_url":"git@github.com:andrewbird/dosemu2.git","clone_url":"https://github.com/andrewbird/dosemu2.git","svn_url":"https://github.com/andrewbird/dosemu2","homepage":"http://stsp.github.io/dosemu2/","size":14387,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"stsp:devel","ref":"devel","sha":"b35861a2e0f1e9dcc4679f5b413000dd974db526","user":{"login":"stsp","id":3295627,"node_id":"MDQ6VXNlcjMyOTU2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3295627?v=4","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"repo":{"id":24825619,"node_id":"MDEwOlJlcG9zaXRvcnkyNDgyNTYxOQ==","name":"dosemu2","full_name":"stsp/dosemu2","owner":{"login":"stsp","id":3295627,"node_id":"MDQ6VXNlcjMyOTU2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3295627?v=4","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stsp/dosemu2","description":"Run DOS programs under linux:","fork":false,"url":"https://api.github.com/repos/stsp/dosemu2","forks_url":"https://api.github.com/repos/stsp/dosemu2/forks","keys_url":"https://api.github.com/repos/stsp/dosemu2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stsp/dosemu2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stsp/dosemu2/teams","hooks_url":"https://api.github.com/repos/stsp/dosemu2/hooks","issue_events_url":"https://api.github.com/repos/stsp/dosemu2/issues/events{/number}","events_url":"https://api.github.com/repos/stsp/dosemu2/events","assignees_url":"https://api.github.com/repos/stsp/dosemu2/assignees{/user}","branches_url":"https://api.github.com/repos/stsp/dosemu2/branches{/branch}","tags_url":"https://api.github.com/repos/stsp/dosemu2/tags","blobs_url":"https://api.github.com/repos/stsp/dosemu2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stsp/dosemu2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stsp/dosemu2/git/refs{/sha}","trees_url":"https://api.github.com/repos/stsp/dosemu2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stsp/dosemu2/statuses/{sha}","languages_url":"https://api.github.com/repos/stsp/dosemu2/languages","stargazers_url":"https://api.github.com/repos/stsp/dosemu2/stargazers","contributors_url":"https://api.github.com/repos/stsp/dosemu2/contributors","subscribers_url":"https://api.github.com/repos/stsp/dosemu2/subscribers","subscription_url":"https://api.github.com/repos/stsp/dosemu2/subscription","commits_url":"https://api.github.com/repos/stsp/dosemu2/commits{/sha}","git_commits_url":"https://api.github.com/repos/stsp/dosemu2/git/commits{/sha}","comments_url":"https://api.github.com/repos/stsp/dosemu2/comments{/number}","issue_comment_url":"https://api.github.com/repos/stsp/dosemu2/issues/comments{/number}","contents_url":"https://api.github.com/repos/stsp/dosemu2/contents/{+path}","compare_url":"https://api.github.com/repos/stsp/dosemu2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stsp/dosemu2/merges","archive_url":"https://api.github.com/repos/stsp/dosemu2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stsp/dosemu2/downloads","issues_url":"https://api.github.com/repos/stsp/dosemu2/issues{/number}","pulls_url":"https://api.github.com/repos/stsp/dosemu2/pulls{/number}","milestones_url":"https://api.github.com/repos/stsp/dosemu2/milestones{/number}","notifications_url":"https://api.github.com/repos/stsp/dosemu2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stsp/dosemu2/labels{/name}","releases_url":"https://api.github.com/repos/stsp/dosemu2/releases{/id}","deployments_url":"https://api.github.com/repos/stsp/dosemu2/deployments","created_at":"2014-10-05T20:33:23Z","updated_at":"2018-07-31T21:20:27Z","pushed_at":"2018-07-31T22:44:38Z","git_url":"git://github.com/stsp/dosemu2.git","ssh_url":"git@github.com:stsp/dosemu2.git","clone_url":"https://github.com/stsp/dosemu2.git","svn_url":"https://github.com/stsp/dosemu2","homepage":"http://stsp.github.io/dosemu2/","size":23331,"stargazers_count":88,"watchers_count":88,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":76,"watchers":88,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/658"},"html":{"href":"https://github.com/stsp/dosemu2/pull/658"},"issue":{"href":"https://api.github.com/repos/stsp/dosemu2/issues/658"},"comments":{"href":"https://api.github.com/repos/stsp/dosemu2/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stsp/dosemu2/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/stsp/dosemu2/statuses/0be7063cd1137c0e8cb79278ad05151edfe536c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stsp"}}