{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/186889794","pull_request_review_id":118560138,"id":186889794,"diff_hunk":"@@ -11,64 +11,56 @@ internal sealed class AssemblyResolver : IDisposable\n     {\n         public AssemblyResolver()\n         {\n-            AppDomain.CurrentDomain.AssemblyResolve += OnAssemblyResolve;\n+            // Use the setup API to find the VS install Dir, then build paths to the Private and Public Assemblies folders\n+            var installPath = GetVSInstallDir();\n+            var ideFolder = Path.Combine(installPath, \"Common7\", \"IDE\");\n+            this.probePaths = new[] {","path":"Nodejs/Product/TestAdapter/AssemblyResolver.cs","position":8,"original_position":8,"commit_id":"57b64739ae5192910eadf10dd631fe20755295ec","original_commit_id":"57b64739ae5192910eadf10dd631fe20755295ec","user":{"login":"amcasey","id":10508071,"avatar_url":"https://avatars2.githubusercontent.com/u/10508071?v=4","gravatar_id":"","url":"https://api.github.com/users/amcasey","html_url":"https://github.com/amcasey","followers_url":"https://api.github.com/users/amcasey/followers","following_url":"https://api.github.com/users/amcasey/following{/other_user}","gists_url":"https://api.github.com/users/amcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/amcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcasey/subscriptions","organizations_url":"https://api.github.com/users/amcasey/orgs","repos_url":"https://api.github.com/users/amcasey/repos","events_url":"https://api.github.com/users/amcasey/events{/privacy}","received_events_url":"https://api.github.com/users/amcasey/received_events","type":"User","site_admin":false},"body":">probePaths [](start = 17, length = 10)\r\n\r\nThis worries me.  VS doesn't already have a probe path?","created_at":"2018-05-08T22:48:03Z","updated_at":"2018-05-08T22:48:03Z","html_url":"https://github.com/Microsoft/nodejstools/pull/1937#discussion_r186889794","pull_request_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/186889794"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/1937#discussion_r186889794"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937","id":183138846,"html_url":"https://github.com/Microsoft/nodejstools/pull/1937","diff_url":"https://github.com/Microsoft/nodejstools/pull/1937.diff","patch_url":"https://github.com/Microsoft/nodejstools/pull/1937.patch","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1937","number":1937,"state":"open","locked":false,"title":"Add support for using javascript unit tests in other project types","user":{"login":"paulvanbrenk","id":5273975,"avatar_url":"https://avatars1.githubusercontent.com/u/5273975?v=4","gravatar_id":"","url":"https://api.github.com/users/paulvanbrenk","html_url":"https://github.com/paulvanbrenk","followers_url":"https://api.github.com/users/paulvanbrenk/followers","following_url":"https://api.github.com/users/paulvanbrenk/following{/other_user}","gists_url":"https://api.github.com/users/paulvanbrenk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulvanbrenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulvanbrenk/subscriptions","organizations_url":"https://api.github.com/users/paulvanbrenk/orgs","repos_url":"https://api.github.com/users/paulvanbrenk/repos","events_url":"https://api.github.com/users/paulvanbrenk/events{/privacy}","received_events_url":"https://api.github.com/users/paulvanbrenk/received_events","type":"User","site_admin":false},"body":"This enables the javascript unit test components to work with other\r\nproject types than njsproj.\r\n\r\nIf a project has a TestRoot and a TestFramework specified, we use those\r\nto locate the files containing the unit tests. This also includes changes\r\nto the node project system to make those 2 properties accessible.\r\n","created_at":"2018-04-20T18:34:47Z","updated_at":"2018-05-08T22:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb428a41015f54ad8b1c366d01baaec0c89bd4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"minestarks","id":16928427,"avatar_url":"https://avatars1.githubusercontent.com/u/16928427?v=4","gravatar_id":"","url":"https://api.github.com/users/minestarks","html_url":"https://github.com/minestarks","followers_url":"https://api.github.com/users/minestarks/followers","following_url":"https://api.github.com/users/minestarks/following{/other_user}","gists_url":"https://api.github.com/users/minestarks/gists{/gist_id}","starred_url":"https://api.github.com/users/minestarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minestarks/subscriptions","organizations_url":"https://api.github.com/users/minestarks/orgs","repos_url":"https://api.github.com/users/minestarks/repos","events_url":"https://api.github.com/users/minestarks/events{/privacy}","received_events_url":"https://api.github.com/users/minestarks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1937/comments","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/57b64739ae5192910eadf10dd631fe20755295ec","head":{"label":"paulvanbrenk:UnitTestJavaScriptPhase1","ref":"UnitTestJavaScriptPhase1","sha":"57b64739ae5192910eadf10dd631fe20755295ec","user":{"login":"paulvanbrenk","id":5273975,"avatar_url":"https://avatars1.githubusercontent.com/u/5273975?v=4","gravatar_id":"","url":"https://api.github.com/users/paulvanbrenk","html_url":"https://github.com/paulvanbrenk","followers_url":"https://api.github.com/users/paulvanbrenk/followers","following_url":"https://api.github.com/users/paulvanbrenk/following{/other_user}","gists_url":"https://api.github.com/users/paulvanbrenk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulvanbrenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulvanbrenk/subscriptions","organizations_url":"https://api.github.com/users/paulvanbrenk/orgs","repos_url":"https://api.github.com/users/paulvanbrenk/repos","events_url":"https://api.github.com/users/paulvanbrenk/events{/privacy}","received_events_url":"https://api.github.com/users/paulvanbrenk/received_events","type":"User","site_admin":false},"repo":{"id":76287337,"name":"nodejstools","full_name":"paulvanbrenk/nodejstools","owner":{"login":"paulvanbrenk","id":5273975,"avatar_url":"https://avatars1.githubusercontent.com/u/5273975?v=4","gravatar_id":"","url":"https://api.github.com/users/paulvanbrenk","html_url":"https://github.com/paulvanbrenk","followers_url":"https://api.github.com/users/paulvanbrenk/followers","following_url":"https://api.github.com/users/paulvanbrenk/following{/other_user}","gists_url":"https://api.github.com/users/paulvanbrenk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulvanbrenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulvanbrenk/subscriptions","organizations_url":"https://api.github.com/users/paulvanbrenk/orgs","repos_url":"https://api.github.com/users/paulvanbrenk/repos","events_url":"https://api.github.com/users/paulvanbrenk/events{/privacy}","received_events_url":"https://api.github.com/users/paulvanbrenk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulvanbrenk/nodejstools","description":"Node.js Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/paulvanbrenk/nodejstools","forks_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/forks","keys_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/teams","hooks_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/events","assignees_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/tags","blobs_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/languages","stargazers_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/subscription","commits_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/merges","archive_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/downloads","issues_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/paulvanbrenk/nodejstools/deployments","created_at":"2016-12-12T19:14:48Z","updated_at":"2018-05-02T22:58:51Z","pushed_at":"2018-05-08T17:59:42Z","git_url":"git://github.com/paulvanbrenk/nodejstools.git","ssh_url":"git@github.com:paulvanbrenk/nodejstools.git","clone_url":"https://github.com/paulvanbrenk/nodejstools.git","svn_url":"https://github.com/paulvanbrenk/nodejstools","homepage":"http://aka.ms/explorentvs","size":110232,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5c440ee9a25e28de157e22571c548f6d063406f8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33017149,"name":"nodejstools","full_name":"Microsoft/nodejstools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/nodejstools","description":"Node.js Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/nodejstools","forks_url":"https://api.github.com/repos/Microsoft/nodejstools/forks","keys_url":"https://api.github.com/repos/Microsoft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nodejstools/teams","hooks_url":"https://api.github.com/repos/Microsoft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nodejstools/events","assignees_url":"https://api.github.com/repos/Microsoft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nodejstools/tags","blobs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nodejstools/subscription","commits_url":"https://api.github.com/repos/Microsoft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nodejstools/merges","archive_url":"https://api.github.com/repos/Microsoft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nodejstools/downloads","issues_url":"https://api.github.com/repos/Microsoft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/nodejstools/deployments","created_at":"2015-03-28T01:37:20Z","updated_at":"2018-05-06T00:01:05Z","pushed_at":"2018-05-08T17:59:43Z","git_url":"git://github.com/Microsoft/nodejstools.git","ssh_url":"git@github.com:Microsoft/nodejstools.git","clone_url":"https://github.com/Microsoft/nodejstools.git","svn_url":"https://github.com/Microsoft/nodejstools","homepage":"http://aka.ms/explorentvs","size":110145,"stargazers_count":1664,"watchers_count":1664,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":314,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":314,"open_issues":85,"watchers":1664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/1937"},"issue":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/1937"},"comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/1937/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/1937/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nodejstools/statuses/57b64739ae5192910eadf10dd631fe20755295ec"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amcasey"}}