{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/228111674","pull_request_review_id":168302889,"id":228111674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODExMTY3NA==","diff_hunk":"@@ -239,8 +239,10 @@ def check_boot_description_exists(self):\n         image_types_supporting_custom_boot_description = ['oem', 'pxe']\n         build_type = self.xml_state.get_build_type_name()\n         initrd_system = self.xml_state.get_initrd_system()\n-        if (initrd_system == 'kiwi' and\n-                build_type in image_types_supporting_custom_boot_description):\n+        if (\n+            initrd_system == 'kiwi' and build_type in\n+            image_types_supporting_custom_boot_description\n+        ):","path":"kiwi/runtime_checker.py","position":9,"original_position":9,"commit_id":"36d8fedf7e593ab5c88799de4d669fc35235ec14","original_commit_id":"bf708f91f0dfe5ccc5ab136afc39a6c6438c2d91","user":{"login":"aplanas","id":645701,"node_id":"MDQ6VXNlcjY0NTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/645701?v=4","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},"body":"The long line is a fair complain, but now there are usually two options to fix the complain (not counting the ones that will create new variables for subexpressions of the condition, as you did in some cases, that is OK).\r\n\r\n* use parens and split, and indent one char to the left to avoid confusion (optional)\r\n\r\n```python\r\ndef xx():\r\n    initrd_system = ''\r\n    build_type = ''\r\n    image_types_supporting_custom_boot_description = []\r\n    if True:\r\n        if (initrd_system == 'kiwi' and\r\n           build_type in image_types_supporting_custom_boot_description):\r\n            pass\r\n```\r\n\r\n* no use parens but use backslash:\r\n\r\n```python\r\ndef xx():\r\n    initrd_system = ''\r\n    build_type = ''\r\n    image_types_supporting_custom_boot_description = []\r\n    if True:\r\n        if initrd_system == 'kiwi' and \\\r\n           build_type in image_types_supporting_custom_boot_description:\r\n            pass\r\n```\r\n\r\nBoth snippets have 0 complains in the same setup with the last version.","created_at":"2018-10-25T10:04:20Z","updated_at":"2018-10-25T10:04:20Z","html_url":"https://github.com/SUSE/kiwi/pull/861#discussion_r228111674","pull_request_url":"https://api.github.com/repos/SUSE/kiwi/pulls/861","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/228111674"},"html":{"href":"https://github.com/SUSE/kiwi/pull/861#discussion_r228111674"},"pull_request":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/861"}},"in_reply_to_id":228103668},"pull_request":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/861","id":225683992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjgzOTky","html_url":"https://github.com/SUSE/kiwi/pull/861","diff_url":"https://github.com/SUSE/kiwi/pull/861.diff","patch_url":"https://github.com/SUSE/kiwi/pull/861.patch","issue_url":"https://api.github.com/repos/SUSE/kiwi/issues/861","number":861,"state":"open","locked":false,"title":"Cleanup code to make flake8 happy","user":{"login":"schaefi","id":912234,"node_id":"MDQ6VXNlcjkxMjIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/912234?v=4","gravatar_id":"","url":"https://api.github.com/users/schaefi","html_url":"https://github.com/schaefi","followers_url":"https://api.github.com/users/schaefi/followers","following_url":"https://api.github.com/users/schaefi/following{/other_user}","gists_url":"https://api.github.com/users/schaefi/gists{/gist_id}","starred_url":"https://api.github.com/users/schaefi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schaefi/subscriptions","organizations_url":"https://api.github.com/users/schaefi/orgs","repos_url":"https://api.github.com/users/schaefi/repos","events_url":"https://api.github.com/users/schaefi/events{/privacy}","received_events_url":"https://api.github.com/users/schaefi/received_events","type":"User","site_admin":false},"body":"The new version of flake8 is more strict on code checking and\r\ncomplained at several places. This commit fixes the code smells\r\nsuch that flake8 is happy again\r\n\r\n\r\n","created_at":"2018-10-25T09:24:27Z","updated_at":"2018-10-25T10:04:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a5e30e729b855cbca8b857917e0d0f19be1ba41","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidcassany","id":6428768,"node_id":"MDQ6VXNlcjY0Mjg3Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/6428768?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcassany","html_url":"https://github.com/davidcassany","followers_url":"https://api.github.com/users/davidcassany/followers","following_url":"https://api.github.com/users/davidcassany/following{/other_user}","gists_url":"https://api.github.com/users/davidcassany/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcassany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcassany/subscriptions","organizations_url":"https://api.github.com/users/davidcassany/orgs","repos_url":"https://api.github.com/users/davidcassany/repos","events_url":"https://api.github.com/users/davidcassany/events{/privacy}","received_events_url":"https://api.github.com/users/davidcassany/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/kiwi/pulls/861/commits","review_comments_url":"https://api.github.com/repos/SUSE/kiwi/pulls/861/comments","review_comment_url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/kiwi/issues/861/comments","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/36d8fedf7e593ab5c88799de4d669fc35235ec14","head":{"label":"SUSE:flake_cleanup","ref":"flake_cleanup","sha":"36d8fedf7e593ab5c88799de4d669fc35235ec14","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":47460440,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ2MDQ0MA==","name":"kiwi","full_name":"SUSE/kiwi","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/kiwi","description":"KIWI—Appliance Builder Next Generation","fork":false,"url":"https://api.github.com/repos/SUSE/kiwi","forks_url":"https://api.github.com/repos/SUSE/kiwi/forks","keys_url":"https://api.github.com/repos/SUSE/kiwi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/kiwi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/kiwi/teams","hooks_url":"https://api.github.com/repos/SUSE/kiwi/hooks","issue_events_url":"https://api.github.com/repos/SUSE/kiwi/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/kiwi/events","assignees_url":"https://api.github.com/repos/SUSE/kiwi/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/kiwi/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/kiwi/tags","blobs_url":"https://api.github.com/repos/SUSE/kiwi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/kiwi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/kiwi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/kiwi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/kiwi/languages","stargazers_url":"https://api.github.com/repos/SUSE/kiwi/stargazers","contributors_url":"https://api.github.com/repos/SUSE/kiwi/contributors","subscribers_url":"https://api.github.com/repos/SUSE/kiwi/subscribers","subscription_url":"https://api.github.com/repos/SUSE/kiwi/subscription","commits_url":"https://api.github.com/repos/SUSE/kiwi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/kiwi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/kiwi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/kiwi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/kiwi/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/kiwi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/kiwi/merges","archive_url":"https://api.github.com/repos/SUSE/kiwi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/kiwi/downloads","issues_url":"https://api.github.com/repos/SUSE/kiwi/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/kiwi/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/kiwi/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/kiwi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/kiwi/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/kiwi/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/kiwi/deployments","created_at":"2015-12-05T15:11:01Z","updated_at":"2018-10-19T12:26:46Z","pushed_at":"2018-10-25T09:45:33Z","git_url":"git://github.com/SUSE/kiwi.git","ssh_url":"git@github.com:SUSE/kiwi.git","clone_url":"https://github.com/SUSE/kiwi.git","svn_url":"https://github.com/SUSE/kiwi","homepage":"https://suse.github.io/kiwi","size":83731,"stargazers_count":71,"watchers_count":71,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":33,"open_issues":18,"watchers":71,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"7343787f871305eaf378ccffc1e9028600eca928","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":47460440,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ2MDQ0MA==","name":"kiwi","full_name":"SUSE/kiwi","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/kiwi","description":"KIWI—Appliance Builder Next Generation","fork":false,"url":"https://api.github.com/repos/SUSE/kiwi","forks_url":"https://api.github.com/repos/SUSE/kiwi/forks","keys_url":"https://api.github.com/repos/SUSE/kiwi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/kiwi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/kiwi/teams","hooks_url":"https://api.github.com/repos/SUSE/kiwi/hooks","issue_events_url":"https://api.github.com/repos/SUSE/kiwi/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/kiwi/events","assignees_url":"https://api.github.com/repos/SUSE/kiwi/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/kiwi/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/kiwi/tags","blobs_url":"https://api.github.com/repos/SUSE/kiwi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/kiwi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/kiwi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/kiwi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/kiwi/languages","stargazers_url":"https://api.github.com/repos/SUSE/kiwi/stargazers","contributors_url":"https://api.github.com/repos/SUSE/kiwi/contributors","subscribers_url":"https://api.github.com/repos/SUSE/kiwi/subscribers","subscription_url":"https://api.github.com/repos/SUSE/kiwi/subscription","commits_url":"https://api.github.com/repos/SUSE/kiwi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/kiwi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/kiwi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/kiwi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/kiwi/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/kiwi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/kiwi/merges","archive_url":"https://api.github.com/repos/SUSE/kiwi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/kiwi/downloads","issues_url":"https://api.github.com/repos/SUSE/kiwi/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/kiwi/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/kiwi/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/kiwi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/kiwi/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/kiwi/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/kiwi/deployments","created_at":"2015-12-05T15:11:01Z","updated_at":"2018-10-19T12:26:46Z","pushed_at":"2018-10-25T09:45:33Z","git_url":"git://github.com/SUSE/kiwi.git","ssh_url":"git@github.com:SUSE/kiwi.git","clone_url":"https://github.com/SUSE/kiwi.git","svn_url":"https://github.com/SUSE/kiwi","homepage":"https://suse.github.io/kiwi","size":83731,"stargazers_count":71,"watchers_count":71,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":33,"open_issues":18,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/861"},"html":{"href":"https://github.com/SUSE/kiwi/pull/861"},"issue":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/861"},"comments":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/kiwi/statuses/36d8fedf7e593ab5c88799de4d669fc35235ec14"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aplanas"}}