{"action":"created","issue":{"url":"https://api.github.com/repos/docker-library/official-images/issues/4404","repository_url":"https://api.github.com/repos/docker-library/official-images","labels_url":"https://api.github.com/repos/docker-library/official-images/issues/4404/labels{/name}","comments_url":"https://api.github.com/repos/docker-library/official-images/issues/4404/comments","events_url":"https://api.github.com/repos/docker-library/official-images/issues/4404/events","html_url":"https://github.com/docker-library/official-images/pull/4404","id":327413476,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjE0ODc5","number":4404,"title":"Add varnish","user":{"login":"teohhanhui","id":548843,"node_id":"MDQ6VXNlcjU0ODg0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/548843?v=4","gravatar_id":"","url":"https://api.github.com/users/teohhanhui","html_url":"https://github.com/teohhanhui","followers_url":"https://api.github.com/users/teohhanhui/followers","following_url":"https://api.github.com/users/teohhanhui/following{/other_user}","gists_url":"https://api.github.com/users/teohhanhui/gists{/gist_id}","starred_url":"https://api.github.com/users/teohhanhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teohhanhui/subscriptions","organizations_url":"https://api.github.com/users/teohhanhui/orgs","repos_url":"https://api.github.com/users/teohhanhui/repos","events_url":"https://api.github.com/users/teohhanhui/events{/privacy}","received_events_url":"https://api.github.com/users/teohhanhui/received_events","type":"User","site_admin":false},"labels":[{"id":302381666,"node_id":"MDU6TGFiZWwzMDIzODE2NjY=","url":"https://api.github.com/repos/docker-library/official-images/labels/library/varnish","name":"library/varnish","color":"ededed","default":false},{"id":455746659,"node_id":"MDU6TGFiZWw0NTU3NDY2NTk=","url":"https://api.github.com/repos/docker-library/official-images/labels/new-image","name":"new-image","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-05-29T17:16:57Z","updated_at":"2018-08-12T20:00:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/docker-library/official-images/pulls/4404","html_url":"https://github.com/docker-library/official-images/pull/4404","diff_url":"https://github.com/docker-library/official-images/pull/4404.diff","patch_url":"https://github.com/docker-library/official-images/pull/4404.patch"},"body":"Reviving #1294.\r\n\r\nVarnish Cache is a widely used caching HTTP reverse proxy.\r\n\r\nAs we've seen in #1294 (which remained open for a long time) upstream has not shown any interest.\r\n\r\nI believe all the best practices have been sufficiently adhered to, including the [Official Images Test Suite](https://github.com/docker-library/official-images/tree/master/test), `update.sh` and `generate-stackbrew-library.sh`.\r\n\r\nDocs PR: https://github.com/docker-library/docs/pull/1241\r\n\r\n# Checklist for Review\r\n\r\n**NOTE:** This checklist is intended for the use of the Official Images maintainers both to track the status of your PR and to help inform you and others of where we're at. As such, please leave the \"checking\" of items to the repository maintainers. If there is a point below for which you would like to provide additional information or note completion, please do so by commenting on the PR. Thanks! (and thanks for staying patient with us :heart:)\r\n\r\n-\t[ ] associated with or contacted upstream?\r\n-\t[ ] does it fit into one of the common categories? (\"service\", \"language stack\", \"base distribution\")\r\n-\t[ ] is it reasonably popular, or does it solve a particular use case well?\r\n-\t[ ] does a [documentation](https://github.com/docker-library/docs/blob/master/README.md) PR exist? (should be reviewed and merged at roughly the same time so that we don't have an empty image page on the Hub for very long)\r\n-\t[ ] dockerization review for best practices and cache gotchas/improvements (ala [the official review guidelines](https://github.com/docker-library/official-images/blob/master/README.md#review-guidelines))?\r\n-\t[ ] 2+ dockerization review?\r\n-\t[ ] existing official images have been considered as a base? (ie, if `foobar` needs Node.js, has `FROM node:...` instead of grabbing `node` via other means been considered?)\r\n-\t[ ] if `FROM scratch`, tarballs only exist in a single commit within the associated history?\r\n-\t[ ] passes current tests? any simple new tests that might be appropriate to add? (https://github.com/docker-library/official-images/tree/master/test)\r\n"},"comment":{"url":"https://api.github.com/repos/docker-library/official-images/issues/comments/412367926","html_url":"https://github.com/docker-library/official-images/pull/4404#issuecomment-412367926","issue_url":"https://api.github.com/repos/docker-library/official-images/issues/4404","id":412367926,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjM2NzkyNg==","user":{"login":"teohhanhui","id":548843,"node_id":"MDQ6VXNlcjU0ODg0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/548843?v=4","gravatar_id":"","url":"https://api.github.com/users/teohhanhui","html_url":"https://github.com/teohhanhui","followers_url":"https://api.github.com/users/teohhanhui/followers","following_url":"https://api.github.com/users/teohhanhui/following{/other_user}","gists_url":"https://api.github.com/users/teohhanhui/gists{/gist_id}","starred_url":"https://api.github.com/users/teohhanhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teohhanhui/subscriptions","organizations_url":"https://api.github.com/users/teohhanhui/orgs","repos_url":"https://api.github.com/users/teohhanhui/repos","events_url":"https://api.github.com/users/teohhanhui/events{/privacy}","received_events_url":"https://api.github.com/users/teohhanhui/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T20:00:37Z","updated_at":"2018-08-12T20:00:37Z","author_association":"CONTRIBUTOR","body":"> put them in CMD [] instead so that users can use docker inspect to determine the default set of arguments (using environment variables to change arguments to the application is a bit odd, we don't have many official images currently which do so)\r\n\r\nBut wouldn't that make for very bad DX?"}}
{"actor":{"display_login":"teohhanhui"}}