{"action":"created","comment":{"url":"https://api.github.com/repos/flathub/flathub/pulls/comments/214150674","pull_request_review_id":151144302,"id":214150674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE1MDY3NA==","diff_hunk":"@@ -0,0 +1,211 @@\n+{\n+    \"app-id\": \"org.freedesktop.fwupd\",\n+    \"runtime\": \"org.gnome.Platform\",\n+    \"runtime-version\": \"3.28\",\n+    \"branch\": \"master\",\n+    \"sdk\": \"org.gnome.Sdk\",\n+    \"command\": \"/app/libexec/fwupd/fwupdtool\",\n+    \"tags\": [],\n+    \"finish-args\": [\n+        \"--device=all\",\n+        \"--filesystem=/boot\",","path":"org.freedesktop.fwupd.json","position":11,"original_position":11,"commit_id":"153f6a90a63f5d08c5c2e67b049738e193abca9c","original_commit_id":"153f6a90a63f5d08c5c2e67b049738e193abca9c","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"Yes, it does need root to set things like efivars.","created_at":"2018-08-30T19:18:54Z","updated_at":"2018-08-30T19:18:54Z","html_url":"https://github.com/flathub/flathub/pull/595#discussion_r214150674","pull_request_url":"https://api.github.com/repos/flathub/flathub/pulls/595","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments/214150674"},"html":{"href":"https://github.com/flathub/flathub/pull/595#discussion_r214150674"},"pull_request":{"href":"https://api.github.com/repos/flathub/flathub/pulls/595"}},"in_reply_to_id":214102725},"pull_request":{"url":"https://api.github.com/repos/flathub/flathub/pulls/595","id":212138957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTM4OTU3","html_url":"https://github.com/flathub/flathub/pull/595","diff_url":"https://github.com/flathub/flathub/pull/595.diff","patch_url":"https://github.com/flathub/flathub/pull/595.patch","issue_url":"https://api.github.com/repos/flathub/flathub/issues/595","number":595,"state":"open","locked":false,"title":"Initial version based on fwupd CI","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"Note! **This isn't a desktop application**, and hence has no desktop file or icon. I've been asked by a few different OEMs to \"host\" a flatpak version of fwupd so they can update firmware on devices when the system version of fwupd is too old. The logical, trusted, place to host this was flathub, rather than throwing an ostree up on fwupd.org -- which is only supposed to be for OEMs and ODMs to use.\r\n\r\nIf this PR gets rejected, or is subject to vicious fighting between various flathub maintainers that's okay! I'm not going to get upset as it's probably the first non-desktop app that's been submitted :)\r\n\r\nI'm happy to answer questions as required. Thanks for reviewing!","created_at":"2018-08-30T16:28:42Z","updated_at":"2018-08-30T19:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6efad29568e266d59dcae42b00a473fadd99c72b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flathub/flathub/pulls/595/commits","review_comments_url":"https://api.github.com/repos/flathub/flathub/pulls/595/comments","review_comment_url":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flathub/flathub/issues/595/comments","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/153f6a90a63f5d08c5c2e67b049738e193abca9c","head":{"label":"hughsie:org.freedesktop.fwupd","ref":"org.freedesktop.fwupd","sha":"153f6a90a63f5d08c5c2e67b049738e193abca9c","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":146775500,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3NzU1MDA=","name":"flathub","full_name":"hughsie/flathub","owner":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/flathub","description":"Pull requests for new applications to be added","fork":true,"url":"https://api.github.com/repos/hughsie/flathub","forks_url":"https://api.github.com/repos/hughsie/flathub/forks","keys_url":"https://api.github.com/repos/hughsie/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/flathub/teams","hooks_url":"https://api.github.com/repos/hughsie/flathub/hooks","issue_events_url":"https://api.github.com/repos/hughsie/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/flathub/events","assignees_url":"https://api.github.com/repos/hughsie/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/flathub/tags","blobs_url":"https://api.github.com/repos/hughsie/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/flathub/languages","stargazers_url":"https://api.github.com/repos/hughsie/flathub/stargazers","contributors_url":"https://api.github.com/repos/hughsie/flathub/contributors","subscribers_url":"https://api.github.com/repos/hughsie/flathub/subscribers","subscription_url":"https://api.github.com/repos/hughsie/flathub/subscription","commits_url":"https://api.github.com/repos/hughsie/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/flathub/merges","archive_url":"https://api.github.com/repos/hughsie/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/flathub/downloads","issues_url":"https://api.github.com/repos/hughsie/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/flathub/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/flathub/deployments","created_at":"2018-08-30T16:15:48Z","updated_at":"2018-08-30T16:15:50Z","pushed_at":"2018-08-30T16:37:03Z","git_url":"git://github.com/hughsie/flathub.git","ssh_url":"git@github.com:hughsie/flathub.git","clone_url":"https://github.com/hughsie/flathub.git","svn_url":"https://github.com/hughsie/flathub","homepage":"https://flathub.org","size":28,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flathub:new-pr","ref":"new-pr","sha":"746ea89cc4ff85ad2dbc05fb47efde23de4062f8","user":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"repo":{"id":88860262,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg2MDI2Mg==","name":"flathub","full_name":"flathub/flathub","owner":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flathub/flathub","description":"Pull requests for new applications to be added","fork":false,"url":"https://api.github.com/repos/flathub/flathub","forks_url":"https://api.github.com/repos/flathub/flathub/forks","keys_url":"https://api.github.com/repos/flathub/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flathub/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flathub/flathub/teams","hooks_url":"https://api.github.com/repos/flathub/flathub/hooks","issue_events_url":"https://api.github.com/repos/flathub/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/flathub/flathub/events","assignees_url":"https://api.github.com/repos/flathub/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/flathub/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/flathub/flathub/tags","blobs_url":"https://api.github.com/repos/flathub/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flathub/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flathub/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/flathub/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/flathub/flathub/languages","stargazers_url":"https://api.github.com/repos/flathub/flathub/stargazers","contributors_url":"https://api.github.com/repos/flathub/flathub/contributors","subscribers_url":"https://api.github.com/repos/flathub/flathub/subscribers","subscription_url":"https://api.github.com/repos/flathub/flathub/subscription","commits_url":"https://api.github.com/repos/flathub/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/flathub/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/flathub/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/flathub/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/flathub/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/flathub/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flathub/flathub/merges","archive_url":"https://api.github.com/repos/flathub/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flathub/flathub/downloads","issues_url":"https://api.github.com/repos/flathub/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/flathub/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/flathub/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/flathub/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flathub/flathub/labels{/name}","releases_url":"https://api.github.com/repos/flathub/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/flathub/flathub/deployments","created_at":"2017-04-20T11:55:49Z","updated_at":"2018-08-29T22:21:23Z","pushed_at":"2018-08-30T16:37:04Z","git_url":"git://github.com/flathub/flathub.git","ssh_url":"git@github.com:flathub/flathub.git","clone_url":"https://github.com/flathub/flathub.git","svn_url":"https://github.com/flathub/flathub","homepage":"https://flathub.org","size":25,"stargazers_count":174,"watchers_count":174,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":202,"open_issues":89,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/595"},"html":{"href":"https://github.com/flathub/flathub/pull/595"},"issue":{"href":"https://api.github.com/repos/flathub/flathub/issues/595"},"comments":{"href":"https://api.github.com/repos/flathub/flathub/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/flathub/flathub/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flathub/flathub/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/flathub/flathub/statuses/153f6a90a63f5d08c5c2e67b049738e193abca9c"}},"author_association":"NONE"}}
{"actor":{"display_login":"hughsie"}}