{"action":"opened","number":32691,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/32691","id":183297131,"html_url":"https://github.com/rails/rails/pull/32691","diff_url":"https://github.com/rails/rails/pull/32691.diff","patch_url":"https://github.com/rails/rails/pull/32691.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/32691","number":32691,"state":"open","locked":false,"title":"Allow disabling of authentication token for `button_to`, fix bug for `form_with`","user":{"login":"ordinaryzelig","id":41839,"avatar_url":"https://avatars0.githubusercontent.com/u/41839?v=4","gravatar_id":"","url":"https://api.github.com/users/ordinaryzelig","html_url":"https://github.com/ordinaryzelig","followers_url":"https://api.github.com/users/ordinaryzelig/followers","following_url":"https://api.github.com/users/ordinaryzelig/following{/other_user}","gists_url":"https://api.github.com/users/ordinaryzelig/gists{/gist_id}","starred_url":"https://api.github.com/users/ordinaryzelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordinaryzelig/subscriptions","organizations_url":"https://api.github.com/users/ordinaryzelig/orgs","repos_url":"https://api.github.com/users/ordinaryzelig/repos","events_url":"https://api.github.com/users/ordinaryzelig/events{/privacy}","received_events_url":"https://api.github.com/users/ordinaryzelig/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\n`button_to` should allow authenticity token to be disabled. After digging, I assumed that it probably was meant to be allowed in the same way it is allowed for [`form_with`](https://github.com/rails/rails/blob/76acaf6eb9ef3635e4c6f2ca9dba34edb50f541d/actionview/lib/action_view/helpers/form_helper.rb#L601). Then I discovered that it was broken for `form_for`. So I fixed that as well as added/fixed the functionality for `button_to`. And for good measure, I added tests to ensure it works for `form_for`.\r\n\r\n### Other Information\r\n\r\nI was using version 5.1.6 when I discovered the issue. I tested it in 5.2.0. I merged it into master also confirming that it is still an issue there too.","created_at":"2018-04-22T22:10:39Z","updated_at":"2018-04-22T22:10:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/32691/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/32691/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/32691/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e74f84a8aa8be0d07e32b04b35efb778b67a6c98","head":{"label":"ordinaryzelig:master","ref":"master","sha":"e74f84a8aa8be0d07e32b04b35efb778b67a6c98","user":{"login":"ordinaryzelig","id":41839,"avatar_url":"https://avatars0.githubusercontent.com/u/41839?v=4","gravatar_id":"","url":"https://api.github.com/users/ordinaryzelig","html_url":"https://github.com/ordinaryzelig","followers_url":"https://api.github.com/users/ordinaryzelig/followers","following_url":"https://api.github.com/users/ordinaryzelig/following{/other_user}","gists_url":"https://api.github.com/users/ordinaryzelig/gists{/gist_id}","starred_url":"https://api.github.com/users/ordinaryzelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordinaryzelig/subscriptions","organizations_url":"https://api.github.com/users/ordinaryzelig/orgs","repos_url":"https://api.github.com/users/ordinaryzelig/repos","events_url":"https://api.github.com/users/ordinaryzelig/events{/privacy}","received_events_url":"https://api.github.com/users/ordinaryzelig/received_events","type":"User","site_admin":false},"repo":{"id":60435002,"name":"rails","full_name":"ordinaryzelig/rails","owner":{"login":"ordinaryzelig","id":41839,"avatar_url":"https://avatars0.githubusercontent.com/u/41839?v=4","gravatar_id":"","url":"https://api.github.com/users/ordinaryzelig","html_url":"https://github.com/ordinaryzelig","followers_url":"https://api.github.com/users/ordinaryzelig/followers","following_url":"https://api.github.com/users/ordinaryzelig/following{/other_user}","gists_url":"https://api.github.com/users/ordinaryzelig/gists{/gist_id}","starred_url":"https://api.github.com/users/ordinaryzelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordinaryzelig/subscriptions","organizations_url":"https://api.github.com/users/ordinaryzelig/orgs","repos_url":"https://api.github.com/users/ordinaryzelig/repos","events_url":"https://api.github.com/users/ordinaryzelig/events{/privacy}","received_events_url":"https://api.github.com/users/ordinaryzelig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ordinaryzelig/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/ordinaryzelig/rails","forks_url":"https://api.github.com/repos/ordinaryzelig/rails/forks","keys_url":"https://api.github.com/repos/ordinaryzelig/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordinaryzelig/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordinaryzelig/rails/teams","hooks_url":"https://api.github.com/repos/ordinaryzelig/rails/hooks","issue_events_url":"https://api.github.com/repos/ordinaryzelig/rails/issues/events{/number}","events_url":"https://api.github.com/repos/ordinaryzelig/rails/events","assignees_url":"https://api.github.com/repos/ordinaryzelig/rails/assignees{/user}","branches_url":"https://api.github.com/repos/ordinaryzelig/rails/branches{/branch}","tags_url":"https://api.github.com/repos/ordinaryzelig/rails/tags","blobs_url":"https://api.github.com/repos/ordinaryzelig/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordinaryzelig/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordinaryzelig/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordinaryzelig/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordinaryzelig/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/ordinaryzelig/rails/languages","stargazers_url":"https://api.github.com/repos/ordinaryzelig/rails/stargazers","contributors_url":"https://api.github.com/repos/ordinaryzelig/rails/contributors","subscribers_url":"https://api.github.com/repos/ordinaryzelig/rails/subscribers","subscription_url":"https://api.github.com/repos/ordinaryzelig/rails/subscription","commits_url":"https://api.github.com/repos/ordinaryzelig/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordinaryzelig/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordinaryzelig/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordinaryzelig/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordinaryzelig/rails/contents/{+path}","compare_url":"https://api.github.com/repos/ordinaryzelig/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordinaryzelig/rails/merges","archive_url":"https://api.github.com/repos/ordinaryzelig/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordinaryzelig/rails/downloads","issues_url":"https://api.github.com/repos/ordinaryzelig/rails/issues{/number}","pulls_url":"https://api.github.com/repos/ordinaryzelig/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/ordinaryzelig/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/ordinaryzelig/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordinaryzelig/rails/labels{/name}","releases_url":"https://api.github.com/repos/ordinaryzelig/rails/releases{/id}","deployments_url":"https://api.github.com/repos/ordinaryzelig/rails/deployments","created_at":"2016-06-04T23:41:24Z","updated_at":"2018-04-22T21:57:30Z","pushed_at":"2018-04-22T21:57:26Z","git_url":"git://github.com/ordinaryzelig/rails.git","ssh_url":"git@github.com:ordinaryzelig/rails.git","clone_url":"https://github.com/ordinaryzelig/rails.git","svn_url":"https://github.com/ordinaryzelig/rails","homepage":"http://rubyonrails.org","size":156406,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"76acaf6eb9ef3635e4c6f2ca9dba34edb50f541d","user":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-04-22T21:32:23Z","pushed_at":"2018-04-22T21:44:26Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":161375,"stargazers_count":39389,"watchers_count":39389,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15931,"mirror_url":null,"archived":false,"open_issues_count":1070,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15931,"open_issues":1070,"watchers":39389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/32691"},"html":{"href":"https://github.com/rails/rails/pull/32691"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/32691"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/32691/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/32691/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/32691/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e74f84a8aa8be0d07e32b04b35efb778b67a6c98"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":53,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"ordinaryzelig"}}