{"action":"created","issue":{"url":"https://api.github.com/repos/sky-uk/toolkit/issues/424","repository_url":"https://api.github.com/repos/sky-uk/toolkit","labels_url":"https://api.github.com/repos/sky-uk/toolkit/issues/424/labels{/name}","comments_url":"https://api.github.com/repos/sky-uk/toolkit/issues/424/comments","events_url":"https://api.github.com/repos/sky-uk/toolkit/issues/424/events","html_url":"https://github.com/sky-uk/toolkit/issues/424","id":324932746,"number":424,"title":"Should we rename the `-all` suffix in our spacing utilities?","user":{"login":"joebell93","id":7349341,"avatar_url":"https://avatars3.githubusercontent.com/u/7349341?v=4","gravatar_id":"","url":"https://api.github.com/users/joebell93","html_url":"https://github.com/joebell93","followers_url":"https://api.github.com/users/joebell93/followers","following_url":"https://api.github.com/users/joebell93/following{/other_user}","gists_url":"https://api.github.com/users/joebell93/gists{/gist_id}","starred_url":"https://api.github.com/users/joebell93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebell93/subscriptions","organizations_url":"https://api.github.com/users/joebell93/orgs","repos_url":"https://api.github.com/users/joebell93/repos","events_url":"https://api.github.com/users/joebell93/events{/privacy}","received_events_url":"https://api.github.com/users/joebell93/received_events","type":"User","site_admin":false},"labels":[{"id":723503657,"url":"https://api.github.com/repos/sky-uk/toolkit/labels/3.0","name":"3.0","color":"d93f0b","default":false},{"id":321966440,"url":"https://api.github.com/repos/sky-uk/toolkit/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":321966443,"url":"https://api.github.com/repos/sky-uk/toolkit/labels/question","name":"question","color":"d4c5f9","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-21T14:17:32Z","updated_at":"2018-05-22T07:46:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--\r\n  TITLE:\r\n    Provide a general summary of your changes in the Title above.\r\n\r\n  LABELS:\r\n    Please add appropriate labels to your PR.\r\n    If you've made changes to a specific package, please make sure to select\r\n    the corresponding label.\r\n-->\r\n\r\n## Description\r\n\r\nTo keep things short and sweet, should we remove the `-all` suffix and rename to:\r\n\r\n```css\r\n\r\n/* previously `.u-padding-all` */\r\n.u-padding {\r\n  padding-top: 20px;\r\n  padding-right: 20px;\r\n  padding-bottom: 20px;\r\n  padding-left: 20px;\r\n}\r\n```\r\nI think this is much tidier but I'm aware it's a breaking change. What do people think?\r\n\r\n## Context\r\n<!--\r\n  How has this issue affected you?\r\n  Why is this change required?\r\n  What problem does it solve?\r\n  What program is it supporting? e.g. Toolkit evolution / Sky Mobile.\r\n-->\r\nEnhance Toolkit developer experience\r\n"},"comment":{"url":"https://api.github.com/repos/sky-uk/toolkit/issues/comments/390895221","html_url":"https://github.com/sky-uk/toolkit/issues/424#issuecomment-390895221","issue_url":"https://api.github.com/repos/sky-uk/toolkit/issues/424","id":390895221,"user":{"login":"MrDinsdale","id":2472440,"avatar_url":"https://avatars1.githubusercontent.com/u/2472440?v=4","gravatar_id":"","url":"https://api.github.com/users/MrDinsdale","html_url":"https://github.com/MrDinsdale","followers_url":"https://api.github.com/users/MrDinsdale/followers","following_url":"https://api.github.com/users/MrDinsdale/following{/other_user}","gists_url":"https://api.github.com/users/MrDinsdale/gists{/gist_id}","starred_url":"https://api.github.com/users/MrDinsdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrDinsdale/subscriptions","organizations_url":"https://api.github.com/users/MrDinsdale/orgs","repos_url":"https://api.github.com/users/MrDinsdale/repos","events_url":"https://api.github.com/users/MrDinsdale/events{/privacy}","received_events_url":"https://api.github.com/users/MrDinsdale/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T07:46:51Z","updated_at":"2018-05-22T07:46:51Z","author_association":"CONTRIBUTOR","body":"I approve, could always do a soft rollout of this with:\r\n\r\n```\r\n.u-padding,\r\n.u-padding-all {...}\r\n```\r\n\r\nThat way we can introduce it and start transitioning over straight away rather than going full breaking change at 3.0."}}
{"actor":{"display_login":"MrDinsdale"}}