{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/WhereHows/pulls/comments/181243645","pull_request_review_id":111823429,"id":181243645,"diff_hunk":"@@ -54,6 +54,7 @@\n   private static final Boolean IS_INTERNAL = Play.application().configuration().getBoolean(\"linkedin.internal\", false);\n   private static final String JIT_ACL_WHITELIST =\n       Play.application().configuration().getString(\"linkedin.jit.acl.whitelist\", \"\");\n+  private static final String WHZ_DS_OWNERSHIP_TAB = System.getenv(\"WHZ_DS_OWNERSHIP_TAB\");","path":"wherehows-frontend/app/controllers/Application.java","position":4,"original_position":4,"commit_id":"8baee7d8540f9caa20b2448fb9a9160f5c6a9455","original_commit_id":"8baee7d8540f9caa20b2448fb9a9160f5c6a9455","user":{"login":"alyiwang","id":1462654,"avatar_url":"https://avatars3.githubusercontent.com/u/1462654?v=4","gravatar_id":"","url":"https://api.github.com/users/alyiwang","html_url":"https://github.com/alyiwang","followers_url":"https://api.github.com/users/alyiwang/followers","following_url":"https://api.github.com/users/alyiwang/following{/other_user}","gists_url":"https://api.github.com/users/alyiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/alyiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyiwang/subscriptions","organizations_url":"https://api.github.com/users/alyiwang/orgs","repos_url":"https://api.github.com/users/alyiwang/repos","events_url":"https://api.github.com/users/alyiwang/events{/privacy}","received_events_url":"https://api.github.com/users/alyiwang/received_events","type":"User","site_admin":false},"body":"Normally we get configs for Play application.conf file. You can set the conf file to take env var instead, (or fix a value in testing). Easier to test and more friendly to Open source","created_at":"2018-04-12T22:42:32Z","updated_at":"2018-04-12T22:42:36Z","html_url":"https://github.com/linkedin/WhereHows/pull/1090#discussion_r181243645","pull_request_url":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/comments/181243645"},"html":{"href":"https://github.com/linkedin/WhereHows/pull/1090#discussion_r181243645"},"pull_request":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090","id":181341779,"html_url":"https://github.com/linkedin/WhereHows/pull/1090","diff_url":"https://github.com/linkedin/WhereHows/pull/1090.diff","patch_url":"https://github.com/linkedin/WhereHows/pull/1090.patch","issue_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1090","number":1090,"state":"open","locked":false,"title":"add a config for showing the ownership tab revamp feature only on stg","user":{"login":"cptran777","id":16459843,"avatar_url":"https://avatars3.githubusercontent.com/u/16459843?v=4","gravatar_id":"","url":"https://api.github.com/users/cptran777","html_url":"https://github.com/cptran777","followers_url":"https://api.github.com/users/cptran777/followers","following_url":"https://api.github.com/users/cptran777/following{/other_user}","gists_url":"https://api.github.com/users/cptran777/gists{/gist_id}","starred_url":"https://api.github.com/users/cptran777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptran777/subscriptions","organizations_url":"https://api.github.com/users/cptran777/orgs","repos_url":"https://api.github.com/users/cptran777/repos","events_url":"https://api.github.com/users/cptran777/events{/privacy}","received_events_url":"https://api.github.com/users/cptran777/received_events","type":"User","site_admin":false},"body":"Purpose is to show revamped features only in staging environment while overall feature is still in development.","created_at":"2018-04-12T22:25:30Z","updated_at":"2018-04-12T22:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78d64ea98068019893a266285edbdd353b1e9d2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/linkedin/WhereHows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/WhereHows/issues/1090/comments","statuses_url":"https://api.github.com/repos/linkedin/WhereHows/statuses/8baee7d8540f9caa20b2448fb9a9160f5c6a9455","head":{"label":"cptran777:ownership-tab-config","ref":"ownership-tab-config","sha":"8baee7d8540f9caa20b2448fb9a9160f5c6a9455","user":{"login":"cptran777","id":16459843,"avatar_url":"https://avatars3.githubusercontent.com/u/16459843?v=4","gravatar_id":"","url":"https://api.github.com/users/cptran777","html_url":"https://github.com/cptran777","followers_url":"https://api.github.com/users/cptran777/followers","following_url":"https://api.github.com/users/cptran777/following{/other_user}","gists_url":"https://api.github.com/users/cptran777/gists{/gist_id}","starred_url":"https://api.github.com/users/cptran777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptran777/subscriptions","organizations_url":"https://api.github.com/users/cptran777/orgs","repos_url":"https://api.github.com/users/cptran777/repos","events_url":"https://api.github.com/users/cptran777/events{/privacy}","received_events_url":"https://api.github.com/users/cptran777/received_events","type":"User","site_admin":false},"repo":{"id":127059978,"name":"WhereHows","full_name":"cptran777/WhereHows","owner":{"login":"cptran777","id":16459843,"avatar_url":"https://avatars3.githubusercontent.com/u/16459843?v=4","gravatar_id":"","url":"https://api.github.com/users/cptran777","html_url":"https://github.com/cptran777","followers_url":"https://api.github.com/users/cptran777/followers","following_url":"https://api.github.com/users/cptran777/following{/other_user}","gists_url":"https://api.github.com/users/cptran777/gists{/gist_id}","starred_url":"https://api.github.com/users/cptran777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptran777/subscriptions","organizations_url":"https://api.github.com/users/cptran777/orgs","repos_url":"https://api.github.com/users/cptran777/repos","events_url":"https://api.github.com/users/cptran777/events{/privacy}","received_events_url":"https://api.github.com/users/cptran777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cptran777/WhereHows","description":"Data Discovery and Lineage for Big Data Ecosystem","fork":true,"url":"https://api.github.com/repos/cptran777/WhereHows","forks_url":"https://api.github.com/repos/cptran777/WhereHows/forks","keys_url":"https://api.github.com/repos/cptran777/WhereHows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cptran777/WhereHows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cptran777/WhereHows/teams","hooks_url":"https://api.github.com/repos/cptran777/WhereHows/hooks","issue_events_url":"https://api.github.com/repos/cptran777/WhereHows/issues/events{/number}","events_url":"https://api.github.com/repos/cptran777/WhereHows/events","assignees_url":"https://api.github.com/repos/cptran777/WhereHows/assignees{/user}","branches_url":"https://api.github.com/repos/cptran777/WhereHows/branches{/branch}","tags_url":"https://api.github.com/repos/cptran777/WhereHows/tags","blobs_url":"https://api.github.com/repos/cptran777/WhereHows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cptran777/WhereHows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cptran777/WhereHows/git/refs{/sha}","trees_url":"https://api.github.com/repos/cptran777/WhereHows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cptran777/WhereHows/statuses/{sha}","languages_url":"https://api.github.com/repos/cptran777/WhereHows/languages","stargazers_url":"https://api.github.com/repos/cptran777/WhereHows/stargazers","contributors_url":"https://api.github.com/repos/cptran777/WhereHows/contributors","subscribers_url":"https://api.github.com/repos/cptran777/WhereHows/subscribers","subscription_url":"https://api.github.com/repos/cptran777/WhereHows/subscription","commits_url":"https://api.github.com/repos/cptran777/WhereHows/commits{/sha}","git_commits_url":"https://api.github.com/repos/cptran777/WhereHows/git/commits{/sha}","comments_url":"https://api.github.com/repos/cptran777/WhereHows/comments{/number}","issue_comment_url":"https://api.github.com/repos/cptran777/WhereHows/issues/comments{/number}","contents_url":"https://api.github.com/repos/cptran777/WhereHows/contents/{+path}","compare_url":"https://api.github.com/repos/cptran777/WhereHows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cptran777/WhereHows/merges","archive_url":"https://api.github.com/repos/cptran777/WhereHows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cptran777/WhereHows/downloads","issues_url":"https://api.github.com/repos/cptran777/WhereHows/issues{/number}","pulls_url":"https://api.github.com/repos/cptran777/WhereHows/pulls{/number}","milestones_url":"https://api.github.com/repos/cptran777/WhereHows/milestones{/number}","notifications_url":"https://api.github.com/repos/cptran777/WhereHows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cptran777/WhereHows/labels{/name}","releases_url":"https://api.github.com/repos/cptran777/WhereHows/releases{/id}","deployments_url":"https://api.github.com/repos/cptran777/WhereHows/deployments","created_at":"2018-03-28T00:07:12Z","updated_at":"2018-03-29T20:36:49Z","pushed_at":"2018-04-12T22:30:34Z","git_url":"git://github.com/cptran777/WhereHows.git","ssh_url":"git@github.com:cptran777/WhereHows.git","clone_url":"https://github.com/cptran777/WhereHows.git","svn_url":"https://github.com/cptran777/WhereHows","homepage":"https://github.com/linkedin/WhereHows/wiki","size":13505,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"7c1d1e0ee5f7c3ef8cbb875e368e904182e51c6b","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":46398090,"name":"WhereHows","full_name":"linkedin/WhereHows","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/WhereHows","description":"Data Discovery and Lineage for Big Data Ecosystem","fork":false,"url":"https://api.github.com/repos/linkedin/WhereHows","forks_url":"https://api.github.com/repos/linkedin/WhereHows/forks","keys_url":"https://api.github.com/repos/linkedin/WhereHows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/WhereHows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/WhereHows/teams","hooks_url":"https://api.github.com/repos/linkedin/WhereHows/hooks","issue_events_url":"https://api.github.com/repos/linkedin/WhereHows/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/WhereHows/events","assignees_url":"https://api.github.com/repos/linkedin/WhereHows/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/WhereHows/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/WhereHows/tags","blobs_url":"https://api.github.com/repos/linkedin/WhereHows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/WhereHows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/WhereHows/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/WhereHows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/WhereHows/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/WhereHows/languages","stargazers_url":"https://api.github.com/repos/linkedin/WhereHows/stargazers","contributors_url":"https://api.github.com/repos/linkedin/WhereHows/contributors","subscribers_url":"https://api.github.com/repos/linkedin/WhereHows/subscribers","subscription_url":"https://api.github.com/repos/linkedin/WhereHows/subscription","commits_url":"https://api.github.com/repos/linkedin/WhereHows/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/WhereHows/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/WhereHows/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/WhereHows/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/WhereHows/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/WhereHows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/WhereHows/merges","archive_url":"https://api.github.com/repos/linkedin/WhereHows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/WhereHows/downloads","issues_url":"https://api.github.com/repos/linkedin/WhereHows/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/WhereHows/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/WhereHows/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/WhereHows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/WhereHows/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/WhereHows/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/WhereHows/deployments","created_at":"2015-11-18T05:47:40Z","updated_at":"2018-04-12T18:29:41Z","pushed_at":"2018-04-12T22:30:35Z","git_url":"git://github.com/linkedin/WhereHows.git","ssh_url":"git@github.com:linkedin/WhereHows.git","clone_url":"https://github.com/linkedin/WhereHows.git","svn_url":"https://github.com/linkedin/WhereHows","homepage":"https://github.com/linkedin/WhereHows/wiki","size":13586,"stargazers_count":780,"watchers_count":780,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":289,"open_issues":82,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090"},"html":{"href":"https://github.com/linkedin/WhereHows/pull/1090"},"issue":{"href":"https://api.github.com/repos/linkedin/WhereHows/issues/1090"},"comments":{"href":"https://api.github.com/repos/linkedin/WhereHows/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/WhereHows/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/WhereHows/statuses/8baee7d8540f9caa20b2448fb9a9160f5c6a9455"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alyiwang"}}