{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/3605","repository_url":"https://api.github.com/repos/palantir/atlasdb","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/3605/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3605/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/3605/events","html_url":"https://github.com/palantir/atlasdb/pull/3605","id":373102518,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTE2MDE4","number":3605,"title":"Remove the Schema Metadata Service","user":{"login":"jeremyk-91","id":5955510,"node_id":"MDQ6VXNlcjU5NTU1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5955510?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyk-91","html_url":"https://github.com/jeremyk-91","followers_url":"https://api.github.com/users/jeremyk-91/followers","following_url":"https://api.github.com/users/jeremyk-91/following{/other_user}","gists_url":"https://api.github.com/users/jeremyk-91/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyk-91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyk-91/subscriptions","organizations_url":"https://api.github.com/users/jeremyk-91/orgs","repos_url":"https://api.github.com/users/jeremyk-91/repos","events_url":"https://api.github.com/users/jeremyk-91/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyk-91/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T17:01:37Z","updated_at":"2018-10-25T10:53:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3605","html_url":"https://github.com/palantir/atlasdb/pull/3605","diff_url":"https://github.com/palantir/atlasdb/pull/3605.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3605.patch"},"body":"**Goals (and why)**:\r\n- Disable the schema metadata service, as it was causing support issues like PDS-76193.\r\n\r\n**Implementation Description (bullets)**:\r\n- Remove the code for SMS.\r\n- Leave the schema metadata table in AtlasDbConstants as a hidden table; this must remain since it was atomic and attempts to BG sweep it will likely explode.\r\n\r\n**Testing (What was existing testing like?  What have you done to improve it?)**:\r\nNothing in particular. The service was producing schema metadata, but this metadata was never consumed.\r\n\r\n**Concerns (what feedback would you like?)**:\r\n- Is this the right decision, as opposed to merely disabling registering the SMS in TransactionManagers.create()? I think so as we aren't pursuing this short term and it is easily recoverable if we want to get some of this stuff back.\r\n- Did I miss anything?\r\n\r\n**Where should we start reviewing?**: `TransactionManagersInitializer`\r\n\r\n**Priority (whenever / two weeks / yesterday)**: whenever\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/3605)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/433005814","html_url":"https://github.com/palantir/atlasdb/pull/3605#issuecomment-433005814","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3605","id":433005814,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzAwNTgxNA==","user":{"login":"gmaretic","id":23168027,"node_id":"MDQ6VXNlcjIzMTY4MDI3","avatar_url":"https://avatars0.githubusercontent.com/u/23168027?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaretic","html_url":"https://github.com/gmaretic","followers_url":"https://api.github.com/users/gmaretic/followers","following_url":"https://api.github.com/users/gmaretic/following{/other_user}","gists_url":"https://api.github.com/users/gmaretic/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaretic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaretic/subscriptions","organizations_url":"https://api.github.com/users/gmaretic/orgs","repos_url":"https://api.github.com/users/gmaretic/repos","events_url":"https://api.github.com/users/gmaretic/events{/privacy}","received_events_url":"https://api.github.com/users/gmaretic/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T10:53:43Z","updated_at":"2018-10-25T10:53:43Z","author_association":"CONTRIBUTOR","body":"The flake you got should be fixed on develop"}}
{"actor":{"display_login":"gmaretic"}}