{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/176852089","pull_request_review_id":106634750,"id":176852089,"diff_hunk":"@@ -751,7 +752,11 @@ export class Bar<X, Y> extends XYPlot<X, Y> {\n     const thicknessF = attrToProjector[Bar._BAR_THICKNESS_KEY];\n     const gapF = attrToProjector[\"gap\"];\n     const thicknessMinusGap = gapF == null ? thicknessF : (d: any, i: number, dataset: Dataset) => {\n-      return thicknessF(d, i, dataset) - gapF(d, i, dataset);\n+      const thick = thicknessF(d, i, dataset);\n+      // only subtract gap if bars are at least 2 pixels wide, otherwise canvas\n+      // interpolation can cause bars to become invisible due to subpixel\n+      // sampling","path":"src/plots/barPlot.ts","position":16,"original_position":16,"commit_id":"0c02bba1fcd7537e67d5aae0e1bddc2eeeb80766","original_commit_id":"0c02bba1fcd7537e67d5aae0e1bddc2eeeb80766","user":{"login":"themadcreator","id":569364,"avatar_url":"https://avatars2.githubusercontent.com/u/569364?v=4","gravatar_id":"","url":"https://api.github.com/users/themadcreator","html_url":"https://github.com/themadcreator","followers_url":"https://api.github.com/users/themadcreator/followers","following_url":"https://api.github.com/users/themadcreator/following{/other_user}","gists_url":"https://api.github.com/users/themadcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/themadcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themadcreator/subscriptions","organizations_url":"https://api.github.com/users/themadcreator/orgs","repos_url":"https://api.github.com/users/themadcreator/repos","events_url":"https://api.github.com/users/themadcreator/events{/privacy}","received_events_url":"https://api.github.com/users/themadcreator/received_events","type":"User","site_admin":false},"body":"i autowrap comments to 80 chars for readability","created_at":"2018-03-23T20:14:36Z","updated_at":"2018-03-23T20:14:36Z","html_url":"https://github.com/palantir/plottable/pull/3450#discussion_r176852089","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/3450","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/176852089"},"html":{"href":"https://github.com/palantir/plottable/pull/3450#discussion_r176852089"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/3450"}},"in_reply_to_id":176851563},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/3450","id":177171766,"html_url":"https://github.com/palantir/plottable/pull/3450","diff_url":"https://github.com/palantir/plottable/pull/3450.diff","patch_url":"https://github.com/palantir/plottable/pull/3450.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/3450","number":3450,"state":"open","locked":false,"title":"Remove gap from bar thickness if width of bar is below threshold","user":{"login":"themadcreator","id":569364,"avatar_url":"https://avatars2.githubusercontent.com/u/569364?v=4","gravatar_id":"","url":"https://api.github.com/users/themadcreator","html_url":"https://github.com/themadcreator","followers_url":"https://api.github.com/users/themadcreator/followers","following_url":"https://api.github.com/users/themadcreator/following{/other_user}","gists_url":"https://api.github.com/users/themadcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/themadcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themadcreator/subscriptions","organizations_url":"https://api.github.com/users/themadcreator/orgs","repos_url":"https://api.github.com/users/themadcreator/repos","events_url":"https://api.github.com/users/themadcreator/events{/privacy}","received_events_url":"https://api.github.com/users/themadcreator/received_events","type":"User","site_admin":false},"body":"This prevents bars from dissappearing at just the right\r\nresolution and zoom level due to pixel sampling moire","created_at":"2018-03-23T20:05:09Z","updated_at":"2018-03-23T20:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ef13a7bb73bcf464ac378c08c4732013cede71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/3450/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/3450/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/3450/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/0c02bba1fcd7537e67d5aae0e1bddc2eeeb80766","head":{"label":"palantir:bd/no-gap-thin-bars","ref":"bd/no-gap-thin-bars","sha":"0c02bba1fcd7537e67d5aae0e1bddc2eeeb80766","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":":bar_chart: A library of modular chart components built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/plottable/deployments","created_at":"2014-01-22T19:29:19Z","updated_at":"2018-03-23T18:56:47Z","pushed_at":"2018-03-23T20:05:10Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"http://plottablejs.org/","size":75166,"stargazers_count":2348,"watchers_count":2348,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":296,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":296,"watchers":2348,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"0fbce8e37dd4413859d5d00e1ef3291ebbdec24c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":":bar_chart: A library of modular chart components built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/plottable/deployments","created_at":"2014-01-22T19:29:19Z","updated_at":"2018-03-23T18:56:47Z","pushed_at":"2018-03-23T20:05:10Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"http://plottablejs.org/","size":75166,"stargazers_count":2348,"watchers_count":2348,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":296,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":296,"watchers":2348,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/3450"},"html":{"href":"https://github.com/palantir/plottable/pull/3450"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/3450"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/3450/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/3450/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/3450/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/0c02bba1fcd7537e67d5aae0e1bddc2eeeb80766"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"themadcreator"}}