{"action":"created","comment":{"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/comments/165391557","pull_request_review_id":93321796,"id":165391557,"diff_hunk":"@@ -11,19 +14,28 @@\n \n \n class ScanCommand:\n-    def __init__(self, scanner, scanstore):\n+    def __init__(self, scanner, scanstore, compress=True):","path":"scanomaticd/scanning.py","position":15,"original_position":15,"commit_id":"6b2ff6ac7de178de4c7adeec9d8b628bf03aef60","original_commit_id":"6b2ff6ac7de178de4c7adeec9d8b628bf03aef60","user":{"login":"gdetrez","id":38019,"avatar_url":"https://avatars2.githubusercontent.com/u/38019?v=4","gravatar_id":"","url":"https://api.github.com/users/gdetrez","html_url":"https://github.com/gdetrez","followers_url":"https://api.github.com/users/gdetrez/followers","following_url":"https://api.github.com/users/gdetrez/following{/other_user}","gists_url":"https://api.github.com/users/gdetrez/gists{/gist_id}","starred_url":"https://api.github.com/users/gdetrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdetrez/subscriptions","organizations_url":"https://api.github.com/users/gdetrez/orgs","repos_url":"https://api.github.com/users/gdetrez/repos","events_url":"https://api.github.com/users/gdetrez/events{/privacy}","received_events_url":"https://api.github.com/users/gdetrez/received_events","type":"User","site_admin":false},"body":"Why is this an argument? Who/what needs to set `compress` to `False`?","created_at":"2018-02-01T15:32:19Z","updated_at":"2018-02-01T15:37:05Z","html_url":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4#discussion_r165391557","pull_request_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/comments/165391557"},"html":{"href":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4#discussion_r165391557"},"pull_request":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4","id":163940233,"html_url":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4","diff_url":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4.diff","patch_url":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4.patch","issue_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/4","number":4,"state":"open","locked":false,"title":"Using convert to compress tiffs","user":{"login":"skymandr","id":358614,"avatar_url":"https://avatars1.githubusercontent.com/u/358614?v=4","gravatar_id":"","url":"https://api.github.com/users/skymandr","html_url":"https://github.com/skymandr","followers_url":"https://api.github.com/users/skymandr/followers","following_url":"https://api.github.com/users/skymandr/following{/other_user}","gists_url":"https://api.github.com/users/skymandr/gists{/gist_id}","starred_url":"https://api.github.com/users/skymandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skymandr/subscriptions","organizations_url":"https://api.github.com/users/skymandr/orgs","repos_url":"https://api.github.com/users/skymandr/repos","events_url":"https://api.github.com/users/skymandr/events{/privacy}","received_events_url":"https://api.github.com/users/skymandr/received_events","type":"User","site_admin":false},"body":"Compress tiffs before save by piping to convert. Works, but a little ugly perhaps?","created_at":"2018-01-19T10:56:29Z","updated_at":"2018-02-01T15:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c7eac08ed4ac20f2d35ad6e19c188f75a70dcf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/4/comments","statuses_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/statuses/6b2ff6ac7de178de4c7adeec9d8b628bf03aef60","head":{"label":"Scan-o-Matic:compress_tiffs","ref":"compress_tiffs","sha":"6b2ff6ac7de178de4c7adeec9d8b628bf03aef60","user":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"repo":{"id":116676112,"name":"scanomatic-scanner","full_name":"Scan-o-Matic/scanomatic-scanner","owner":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scan-o-Matic/scanomatic-scanner","description":"Scanner daemon for scan-o-matic","fork":false,"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner","forks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/forks","keys_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/teams","hooks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/hooks","issue_events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/events","assignees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/tags","blobs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/languages","stargazers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/stargazers","contributors_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/contributors","subscribers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/subscribers","subscription_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/subscription","commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/merges","archive_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/downloads","issues_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/labels{/name}","releases_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/deployments","created_at":"2018-01-08T12:51:12Z","updated_at":"2018-01-10T12:12:23Z","pushed_at":"2018-02-01T14:52:00Z","git_url":"git://github.com/Scan-o-Matic/scanomatic-scanner.git","ssh_url":"git@github.com:Scan-o-Matic/scanomatic-scanner.git","clone_url":"https://github.com/Scan-o-Matic/scanomatic-scanner.git","svn_url":"https://github.com/Scan-o-Matic/scanomatic-scanner","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Scan-o-Matic:master","ref":"master","sha":"257a74b85a71a175d215f44d07b832f1ebeab025","user":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"repo":{"id":116676112,"name":"scanomatic-scanner","full_name":"Scan-o-Matic/scanomatic-scanner","owner":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scan-o-Matic/scanomatic-scanner","description":"Scanner daemon for scan-o-matic","fork":false,"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner","forks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/forks","keys_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/teams","hooks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/hooks","issue_events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/events","assignees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/tags","blobs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/languages","stargazers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/stargazers","contributors_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/contributors","subscribers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/subscribers","subscription_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/subscription","commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/merges","archive_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/downloads","issues_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/labels{/name}","releases_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/deployments","created_at":"2018-01-08T12:51:12Z","updated_at":"2018-01-10T12:12:23Z","pushed_at":"2018-02-01T14:52:00Z","git_url":"git://github.com/Scan-o-Matic/scanomatic-scanner.git","ssh_url":"git@github.com:Scan-o-Matic/scanomatic-scanner.git","clone_url":"https://github.com/Scan-o-Matic/scanomatic-scanner.git","svn_url":"https://github.com/Scan-o-Matic/scanomatic-scanner","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4"},"html":{"href":"https://github.com/Scan-o-Matic/scanomatic-scanner/pull/4"},"issue":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/4"},"comments":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic-scanner/statuses/6b2ff6ac7de178de4c7adeec9d8b628bf03aef60"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gdetrez"}}