{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/comments/191169998","pull_request_review_id":123691024,"id":191169998,"diff_hunk":"@@ -31,14 +31,14 @@ router.route('/')\n     .get(param.jobQuery, jobController.list)\n \n     /** POST /api/v1/jobs - Update job */\n-    .post(tokenConfig.check, param.validate(jobConfig.schema), jobController.init, jobController.update);\n+    .post(tokenConfig.check, param.validate(jobConfig.schema), param.checkKillAllOnCompletedTaskNumber, jobController.init, jobController.update);","path":"rest-server/src/routes/job.js","position":5,"original_position":5,"commit_id":"f012bdde163e7e525792d7f1043cc89472c0991a","original_commit_id":"f012bdde163e7e525792d7f1043cc89472c0991a","user":{"login":"fanyangCS","id":5820832,"avatar_url":"https://avatars2.githubusercontent.com/u/5820832?v=4","gravatar_id":"","url":"https://api.github.com/users/fanyangCS","html_url":"https://github.com/fanyangCS","followers_url":"https://api.github.com/users/fanyangCS/followers","following_url":"https://api.github.com/users/fanyangCS/following{/other_user}","gists_url":"https://api.github.com/users/fanyangCS/gists{/gist_id}","starred_url":"https://api.github.com/users/fanyangCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanyangCS/subscriptions","organizations_url":"https://api.github.com/users/fanyangCS/orgs","repos_url":"https://api.github.com/users/fanyangCS/repos","events_url":"https://api.github.com/users/fanyangCS/events{/privacy}","received_events_url":"https://api.github.com/users/fanyangCS/received_events","type":"User","site_admin":false},"body":"it doens't seem to scale by defining a new function to check just one value\r\n\r\n---\r\nIn reply to: [191151374](https://github.com/Microsoft/pai/pull/625#discussion_r191151374) [](ancestors = 191151374)","created_at":"2018-05-28T10:17:00Z","updated_at":"2018-05-28T10:17:01Z","html_url":"https://github.com/Microsoft/pai/pull/625#discussion_r191169998","pull_request_url":"https://api.github.com/repos/Microsoft/pai/pulls/625","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments/191169998"},"html":{"href":"https://github.com/Microsoft/pai/pull/625#discussion_r191169998"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/625"}},"in_reply_to_id":191146683},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pai/pulls/625","id":190840016,"html_url":"https://github.com/Microsoft/pai/pull/625","diff_url":"https://github.com/Microsoft/pai/pull/625.diff","patch_url":"https://github.com/Microsoft/pai/pull/625.patch","issue_url":"https://api.github.com/repos/Microsoft/pai/issues/625","number":625,"state":"open","locked":false,"title":"[Rest Server] Check killAllOnCompletedTaskNumber in configuration","user":{"login":"abuccts","id":13360214,"avatar_url":"https://avatars3.githubusercontent.com/u/13360214?v=4","gravatar_id":"","url":"https://api.github.com/users/abuccts","html_url":"https://github.com/abuccts","followers_url":"https://api.github.com/users/abuccts/followers","following_url":"https://api.github.com/users/abuccts/following{/other_user}","gists_url":"https://api.github.com/users/abuccts/gists{/gist_id}","starred_url":"https://api.github.com/users/abuccts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abuccts/subscriptions","organizations_url":"https://api.github.com/users/abuccts/orgs","repos_url":"https://api.github.com/users/abuccts/repos","events_url":"https://api.github.com/users/abuccts/events{/privacy}","received_events_url":"https://api.github.com/users/abuccts/received_events","type":"User","site_admin":false},"body":"Check killAllOnCompletedTaskNumber in configuration.\r\n\r\nFixes #622 ","created_at":"2018-05-28T05:43:49Z","updated_at":"2018-05-28T10:17:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f14c71ca6504a3e5333deff07ec49cece90b72e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hwuu","id":7257612,"avatar_url":"https://avatars0.githubusercontent.com/u/7257612?v=4","gravatar_id":"","url":"https://api.github.com/users/hwuu","html_url":"https://github.com/hwuu","followers_url":"https://api.github.com/users/hwuu/followers","following_url":"https://api.github.com/users/hwuu/following{/other_user}","gists_url":"https://api.github.com/users/hwuu/gists{/gist_id}","starred_url":"https://api.github.com/users/hwuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwuu/subscriptions","organizations_url":"https://api.github.com/users/hwuu/orgs","repos_url":"https://api.github.com/users/hwuu/repos","events_url":"https://api.github.com/users/hwuu/events{/privacy}","received_events_url":"https://api.github.com/users/hwuu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pai/pulls/625/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pai/pulls/625/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pai/issues/625/comments","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/f012bdde163e7e525792d7f1043cc89472c0991a","head":{"label":"Microsoft:xiongyf/rest-server-patch-0","ref":"xiongyf/rest-server-patch-0","sha":"f012bdde163e7e525792d7f1043cc89472c0991a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"name":"pai","full_name":"Microsoft/pai","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-05-28T08:25:04Z","pushed_at":"2018-05-28T10:15:13Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":2982,"stargazers_count":253,"watchers_count":253,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":63,"open_issues":61,"watchers":253,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"14cd30972ee19141c439dab933f4e0dad0ea477d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104741169,"name":"pai","full_name":"Microsoft/pai","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pai","description":"Resource scheduling and cluster management for AI","fork":false,"url":"https://api.github.com/repos/Microsoft/pai","forks_url":"https://api.github.com/repos/Microsoft/pai/forks","keys_url":"https://api.github.com/repos/Microsoft/pai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pai/teams","hooks_url":"https://api.github.com/repos/Microsoft/pai/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pai/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pai/events","assignees_url":"https://api.github.com/repos/Microsoft/pai/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pai/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pai/tags","blobs_url":"https://api.github.com/repos/Microsoft/pai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pai/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pai/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pai/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pai/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pai/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pai/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pai/subscription","commits_url":"https://api.github.com/repos/Microsoft/pai/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pai/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pai/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pai/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pai/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pai/merges","archive_url":"https://api.github.com/repos/Microsoft/pai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pai/downloads","issues_url":"https://api.github.com/repos/Microsoft/pai/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pai/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pai/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pai/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pai/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pai/deployments","created_at":"2017-09-25T11:24:51Z","updated_at":"2018-05-28T08:25:04Z","pushed_at":"2018-05-28T10:15:13Z","git_url":"git://github.com/Microsoft/pai.git","ssh_url":"git@github.com:Microsoft/pai.git","clone_url":"https://github.com/Microsoft/pai.git","svn_url":"https://github.com/Microsoft/pai","homepage":"","size":2982,"stargazers_count":253,"watchers_count":253,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":63,"open_issues":61,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/625"},"html":{"href":"https://github.com/Microsoft/pai/pull/625"},"issue":{"href":"https://api.github.com/repos/Microsoft/pai/issues/625"},"comments":{"href":"https://api.github.com/repos/Microsoft/pai/issues/625/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/625/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pai/pulls/625/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pai/statuses/f012bdde163e7e525792d7f1043cc89472c0991a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fanyangCS"}}