{"push_id":2403494100,"size":83,"distinct_size":24,"ref":"refs/heads/op_datasigverify","head":"60f1f6115ec4f4259f800c6407da17e4d3e83ab7","before":"a48397293178219f143d6754e6a714134ac9d3bc","commits":[{"sha":"35fe97dad30aa9aa932dddb899481c22a0e741c9","author":{"name":"Andrea Suisani","email":"b096ecbe37122d2499fa3df287b4c552a8eb99ae@gmail.com"},"message":"Add BUcash 1.2.0.1 release notes","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/35fe97dad30aa9aa932dddb899481c22a0e741c9"},{"sha":"af255b75d366399590deb2c683240a597b739b55","author":{"name":"Andrea Suisani","email":"b096ecbe37122d2499fa3df287b4c552a8eb99ae@gmail.com"},"message":"Merge pull request #947 from sickpig/relnotes-bucash-1.2.0.1","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/af255b75d366399590deb2c683240a597b739b55"},{"sha":"4164aa386581c5a54955379297f2393d46029d64","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Remove duplicate section of code\n\nNot sure how this got in here, perhaps a bad merge of some\nkind.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/4164aa386581c5a54955379297f2393d46029d64"},{"sha":"49243d0be6f5724e53484c02e8ef6fbc38f32b04","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Replace BOOST_FOREACH and NULL, in SendMessages, with C++11 notation","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/49243d0be6f5724e53484c02e8ef6fbc38f32b04"},{"sha":"6663c69c7aed8dd9e11ca1d9b37da0e2ae6b7402","author":{"name":"Andrew Stone","email":"07b5e79c52053536c016b7d69aeb13d80e6ba03f@gmail.com"},"message":"Merge pull request #916 from gandrewstone/dev\n\nchange mempool to use a non-recursive shared lock.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/6663c69c7aed8dd9e11ca1d9b37da0e2ae6b7402"},{"sha":"c2f41c97d15dc3d4a662bfb5a98c5a6466fba386","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Prevent potential integer underflow of nTrimHeight","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/c2f41c97d15dc3d4a662bfb5a98c5a6466fba386"},{"sha":"466d14aeff3e1e5807cac0756d8fd6103ea6064a","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"If there is nothing to trim then do not continue\n\nIf the nTrimHeight has already been walked back to zero and\nthere is no possibility of trimming then just return. There is\nno need to continue through this section of code and since this\nwill be the most common occurrence when the chain is sync'd then\nwe'll have a small performance improvement here.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/466d14aeff3e1e5807cac0756d8fd6103ea6064a"},{"sha":"7e6db68102817a3954a1a2ddf7dd08684e3ac7ed","author":{"name":"Cory Fields","email":"80cca0c8bbad51aef68248f52801a988298782fe@coryfields.com"},"message":"net: initialize socket to avoid closing random fd's","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/7e6db68102817a3954a1a2ddf7dd08684e3ac7ed"},{"sha":"9d38d55c852e6e6bf387d138cdb557a4c78e9279","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Change log message from LogPrintf to LOG(NET, ...","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/9d38d55c852e6e6bf387d138cdb557a4c78e9279"},{"sha":"b3ca26c441cb168e8a94610912f3975fc4609025","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Only run data gathering  code if BENCH logging is enabled.\n\nAt the end of ProcessNewBlock there are several pieces of data\nthat are gathered for logging however they do not need to be\ngenerated unless BENCH logging is turned on.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/b3ca26c441cb168e8a94610912f3975fc4609025"},{"sha":"e8e1d02e8469163c7fa44aeac7ba6ff05e503cba","author":{"name":"Andrea Suisani","email":"b096ecbe37122d2499fa3df287b4c552a8eb99ae@gmail.com"},"message":"Fix warnings on ReadOrderPos and WriteOrderPos\n\nRemove static from ReadOrderPos and WriteOrderPos declaration\ncause there's no other place in the code same functions defined\nwith the same signature.\n\nAdd inline to lower the overhead of executing this functions and\nto make possible to define those in the header without the linker\ncomplaining when you include wallet.h header in other compilation\nunits.\n\nThose are the kind of warnings produced on an amd64 Ubuntu machine\nrunning gcc 7.2.0:\n\nIn file included from init.cpp:49:0:\nwallet/wallet.h:145:13: warning: ‘void WriteOrderPos(const int64_t&, mapValue_t&)’ defined but not used [-Wunused-function]\n static void WriteOrderPos(const int64_t &nOrderPos, mapValue_t &mapValue)\n             ^~~~~~~~~~~~~\nwallet/wallet.h:134:13: warning: ‘void ReadOrderPos(int64_t&, mapValue_t&)’ defined but not used [-Wunused-function]\n static void ReadOrderPos(int64_t &nOrderPos, mapValue_t &mapValue)\n             ^~~~~~~~~~~~","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/e8e1d02e8469163c7fa44aeac7ba6ff05e503cba"},{"sha":"c08e038d594b1d976776151b797030310bd732d4","author":{"name":"Andrew Stone","email":"07b5e79c52053536c016b7d69aeb13d80e6ba03f@gmail.com"},"message":"WIP: convert CBlock to a shared pointer to limit copying of a block, which is a terrible waste of memory given 0GB block sizes","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/c08e038d594b1d976776151b797030310bd732d4"},{"sha":"dcf43cf9d4310fae1fe1b91422897908c04e660c","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"change to pointer type","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/dcf43cf9d4310fae1fe1b91422897908c04e660c"},{"sha":"aa0b9dab098733e1ec1cff05bd1f525768f81e39","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"formatting","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/aa0b9dab098733e1ec1cff05bd1f525768f81e39"},{"sha":"fe425dc63432110b867c1ac83654cc5e72f02360","author":{"name":"Andrea Suisani","email":"b096ecbe37122d2499fa3df287b4c552a8eb99ae@gmail.com"},"message":"Explicitly mark fall-through cases\n\nExplicitly mark a case branch as fall-through when it is the\nintended behaviour. When using gcc 7.2 all fall-through branhces\nthat are not marked produce a warning like this one:\n\nhash.cpp: In function 'unsigned int MurmurHash3(unsigned int, const std::vector<unsigned char>&)':\nhash.cpp:50:16: warning: this statement may fall through [-Wimplicit-fallthrough=]\n             k1 ^= tail[2] << 16;\n             ~~~^~~~~~~~~~~~~~~~\nhash.cpp:51:9: note: here\n         case 2:\n         ^~~~\nMore info about the matter at hand could be found here:\n\nhttps://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/\n\nThis change set is not taking care of external project code imported\nvia subtree (e.g. leveldb, univalue, etc. etc.)\n\nI wanted to thanks freetrader for pointing out similar work done\nin BitcoinABC back in July 2017.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/fe425dc63432110b867c1ac83654cc5e72f02360"},{"sha":"a28ee85d34fb7e1059e7cc7e1aa2227f4e3a8753","author":{"name":"Justaphf","email":"ed3b214199ce7dca5d3f27f4debf1582d3158486@users.noreply.github.com"},"message":"Scripts to help automate first-time setup of the mingw dev environment on Windows. (#85)\n\n* Inital scripts to setup mingw build env\r\n\r\nThese are the initial scripts that allow setup of the MinGW build\r\nenvironment  on Windows.  After some initial manual steps, will\r\ndownload, extract, and build all Bitcoin dependnencies, then build the\r\nBitcoin client with those dependencies statically linked.\r\n\r\n* Add args to skip some build steps if not needed.\r\n\r\n1. Added \"--strip\" argument.  Now this script will only run the strip\r\ncommand on the generated bitcoin binaries if this argument is provided.\r\n2. Added “--no-autogen” argument.  If provided, this argument will skip\r\nexecution of “./autogen.sh” to reduce build times (convenience feature\r\nfor Windows developers).\r\n3. Added “--no-configure” argument.  If provided, this argument will\r\nskip execution of “./configure” to reduce build times (convenience\r\nfeature for Windows developers).  If specified, this argument also\r\nautomatically applies the “—no-autogen” argument as well.\r\n\r\nNOTE: The “--no-autogen” and “--no-configure” options should only be\r\nused if a successful build of the bitcoin binaries has already been\r\ncompleted in this build directory, and no configuration changes have\r\nbeen made.  Currently the script doesn't have a safety check these\r\ncommands have run successfully, and if you have not previously run\r\n“./autogen.sh” and/or “./configure” successfully, the script will\r\nblow-up if you run with these arguments.\r\n\r\n* Update Qt download URL\r\n\r\nQt dowload has changed from official_releases to archive.\r\nREVISIT: Check to see if it is OK to upgrade to a newer version.\r\n\r\n* Allow building with tests enabled\r\n\r\nAdded the \"--check\" argument to allow building with tests enabled.\r\nNOTE: Not all tests can be run successfully on Windows, but the \"make\r\ncheck\" and some of the pull-tester RPC tests should work provided that\r\nPython has been installed and the development environment configured\r\ncorrectly to access it.\r\n\r\n1. Update dependencies to install wahern's Hexdump.exe by building from\r\nsource.  This is required for tests to be able to run.\r\n2. Update the dependencies configuration script to build Boost with\r\ntests enabled, if a specific setting is enabled in the header of the\r\nfile.  This is required for the bitcoin executables to build with tests\r\nenabled.\r\n3. Added \"--check\" argument to the bitcoin build script to dynamically\r\nturn tests on or off when running ./configure.\r\n4. The \"--check\" argument is also intended to run \"make check\" after\r\ncompletion of the build, however due to some recent configuration issues\r\nI haven't solved yet, this is currently commented out as the tests fail\r\ndue to python errors on Windows.\r\n\r\n* Prevent redownload/extraction of dependency files\r\n\r\nMostly to speed up testing, if the files are already downloaded and/or\r\nextracted, then don't redownload/extract them.\r\n\r\n* Deal with paths with whitespace\r\n\r\nUpdate scripts to try to handle whitespace in path names.  Currently\r\nonly works completely for the bitcoin build directory, many of the\r\ndependency builds are not whitespace safe, external to these scripts, so\r\nwill have build failures.\r\n\r\n* Enabled mingw 64-bit building\r\n\r\nUpdated the configuration scripts to support the 64-bit build toolchain\r\nin addition to the already working 32-bit build chain.  Scripts will now\r\nallow from-scratch download, unpack, and build of the entire toolchain,\r\nall dependencies, and the bitcoin executables for just 32-bit, just\r\n64-bit, or both in one go.\r\n\r\n1. Added user configuration flags to indicate if the 32-bit and/or\r\n64-bit versions should be configured and built.\r\n2. Restructured main configuration script to selectively run the full\r\nconfiguration and build process based on flag settings.\r\n3. Extract and build all dependencies in target specific sub-directories\r\nof x86 or x64.\r\n4. Added a section to copy the just built bitcoin executables to an\r\nalternate output location, \"build-output/x86\" or \"build-output/x64\".\r\nThis way if both 32 and 64 bit configuration is done in one go, the\r\nfinal statically linked bitcoin outputs for both will be available.\r\n5. Updated toolchain installation script to be able to correctly\r\ndownload and extract the 32-bit or 64-bit toolchain packages.\r\n6. Updated dependency build script to support pulling the correct\r\nversion of libz.a from the toolchain (32 or 64 bit version).  This is\r\nnecessary for qrencode.\r\n7. Updated openssl to use the proper Configure switch (mingw or mingw64)\r\nbased on toolchain.\r\n8. Updated bitcoin build script to support \"--clean\" flag to allow\r\nperforming a full clean prior to build.\r\n\r\n* Restructure mingw build scripts\r\n\r\nScripts have been restructured to use a single configuration file so the\r\nuser only needs to edit one file for any of the helper scripts that can\r\nbe run.  This provides:\r\n\r\n1. SET_ENV_VARS.bat is the only file that needs to be edited by the user\r\nThe same settings coming from SET_ENV_VARS are used by all other scripts\r\n2. Eliminate command line argument processing for bash scripts as all\r\nvalues now come from SET_ENV_VARS.bat\r\n3. Eliminate the need for the user to double enter paths in both Windows\r\nand POSIX formats.  Bash scripts will now automatically convert to POSIX\r\nfrom Windows.\r\n4. Create parity between config-mingw.bat and rebuild-bitcoin.bat in\r\nterms of initalization and timing log messages.\r\n\r\n* Enable make -jN configurable from evn vars\r\n\r\n* Refactor flag to enable tests in ENV_VARS\r\n\r\nInstead of passing build flags, just do a check for set.  Makes the user\r\nedit portion less complex.\r\n\r\n* Correct PATH init causing 64-bit Qt build failure\r\n\r\nBuild of Qt on 64-bit toolchain has errors if MSYS bin directory is in\r\nthe path during build.\r\nTo correct, moved PATH initialization to each individual bash script as\r\nwell as reset in the main configuration script where necessary.\r\n\r\n* Prevent double download of dependencies\r\n\r\nIf building both 32-bit and 64-bit versions, don't download the\r\ndependencies twice.\r\nNOTE: Still extracts twice.\r\n\r\n* Add option to \"install\" python and git\r\n\r\nSince mingw doesn't come with git or python, we can use the Windows\r\nexecutables installed for these utilities by creating a wrapper script\r\nin /usr/bin/ folder which simply calls the executable and passes in any\r\nparameters that were passed to the script.  These wrappers are\r\n\"installed\" as part of the main dependency configuration script.\r\n\r\n* Add validation/error checking\r\n\r\n1. Add in checks to ensure that required environment variables have been\r\nset in SET_ENV_VARS.bat.\r\n2. Add checks to ensure paths that were set are valid and the\r\nfiles/directories they point to exist.\r\n3. Add checks to catch errors that occur during build and abort further\r\nexecution until errors are fixed.\r\n4. Add checks to bitcoin build script to ensure dependencies have been\r\nbuilt for the current toolchain.\r\n\r\n* Update documentation\r\n\r\nAdded more in-depth readme files and reference the automation scripts in\r\nthe main windows build doc.\r\n\r\n* Add step to upgrade wget\r\n\r\nThe version of wget (v1.12) which comes from the MinGW package manager is so out of date that it does not support TLSv1.2.  This has started causing some dependency downloads to fail where TLSv1.2 is now the only supported secure channel.\r\n\r\nAdded a step to upgrade to wget v1.19.1 which uses OpenSSL 1.1.0e and supports TLSv1.2 connections.\r\n\r\n* Use minimal base PATH when building dependencies\r\n\r\nThis is because the default PATH value on Windows may have paths that\r\ncause conflicts.\r\nSpecifically after installing Visual Studio 2017 with the R Python\r\nplugin, Anaconda3 was installed and included in the PATH which causes Qt\r\nbuilds to fail.\r\n\r\n* Add ability to specify --enable-debug when building bitcoin\r\n\r\n* Add helper scripts for performing full clean of bitcoin\r\n\r\nDoes not clean dependencies.\r\n\r\n* Update miniupnpc dependency to v2.0.20170509\r\n\r\nThis is for CVE-2017-8798, merged in as part of 5d61cd4\r\nAlso updates documentation for building on native windows.\r\n\r\n* Update file downloads to verify file hash\r\n\r\nConfiguration will error out if the sha256 checksums do not match.\r\n\r\n* Correct URL & checksum for wget\r\n\r\nUpdated to match changes on download website.  Using the same version\r\n1.19.1, 32-bit.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/a28ee85d34fb7e1059e7cc7e1aa2227f4e3a8753"},{"sha":"0394fc695d3e5163d3a628636858602b5e20138b","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Create block method GetBlockSize()\n\nThis calculates and returns the serialized block size which is\nthen stored in memory for future reference, thereby, preventing\nthe need to serialize the block every time the block size is needed\nelsewhere.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/0394fc695d3e5163d3a628636858602b5e20138b"},{"sha":"9c4414d20ee553496ce9695b4776e65c2181d431","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Use GetBlockSize() in place of ::GetSerializedSize","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/9c4414d20ee553496ce9695b4776e65c2181d431"},{"sha":"b39dd57eddb27457564bda9a85fdda12e0a3547e","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Remove the redundantblocksize argument from HandBlockMessage\n\nand HandleBlockMessageThread.","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/b39dd57eddb27457564bda9a85fdda12e0a3547e"},{"sha":"fcfa327c7d356eb4ca720b56557a5be391338b13","author":{"name":"Peter Tschipper","email":"5bc2e013e37725a6a5e4190e30f99348bd870a31@gmail.com"},"message":"Fix commented out test code","distinct":false,"url":"https://api.github.com/repos/gandrewstone/BitcoinUnlimited/commits/fcfa327c7d356eb4ca720b56557a5be391338b13"}]}
{"actor":{"display_login":"gandrewstone"}}