{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/224263059","pull_request_review_id":163588080,"id":224263059,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI2MzA1OQ==","diff_hunk":"@@ -49,6 +49,46 @@ void bind_datavector() {\n       .def(bp::self += bp::other<double>{})\n       // Need to do math explicitly converting to DataVector because we don't\n       // want to represent all the possible expression template types\n+      .def(\"abs\", +[](const DataVector& t) { return DataVector{abs(t)}; })\n+      .def(\"acos\", +[](const DataVector& t) { return DataVector{acos(t)}; })\n+      .def(\"acosh\", +[](const DataVector& t) { return DataVector{acosh(t)}; })\n+      .def(\"asin\", +[](const DataVector& t) { return DataVector{asin(t)}; })\n+      .def(\"asinh\", +[](const DataVector& t) { return DataVector{asinh(t)}; })\n+      .def(\"atan\", +[](const DataVector& t) { return DataVector{atan(t)}; })\n+      .def(\"atan2\", +[](const DataVector& t,","path":"src/DataStructures/Python/DataVector.cpp","position":58,"original_position":10,"commit_id":"5e2479bd6d156b18dce4c185b9a4425c9543e1fc","original_commit_id":"5e2479bd6d156b18dce4c185b9a4425c9543e1fc","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"naming `t, v` `y, x` will make it easier to figure out which is which in the future. For single arg functions the name is not so important for these type of forwarding functions.","created_at":"2018-10-10T22:32:26Z","updated_at":"2018-10-10T22:38:15Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/1021#discussion_r224263059","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/224263059"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1021#discussion_r224263059"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021","id":219813216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODEzMjE2","html_url":"https://github.com/sxs-collaboration/spectre/pull/1021","diff_url":"https://github.com/sxs-collaboration/spectre/pull/1021.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/1021.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1021","number":1021,"state":"open","locked":false,"title":"Finish Boost python support for DataVector","user":{"login":"isaaclegred","id":36135409,"node_id":"MDQ6VXNlcjM2MTM1NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/36135409?v=4","gravatar_id":"","url":"https://api.github.com/users/isaaclegred","html_url":"https://github.com/isaaclegred","followers_url":"https://api.github.com/users/isaaclegred/followers","following_url":"https://api.github.com/users/isaaclegred/following{/other_user}","gists_url":"https://api.github.com/users/isaaclegred/gists{/gist_id}","starred_url":"https://api.github.com/users/isaaclegred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaaclegred/subscriptions","organizations_url":"https://api.github.com/users/isaaclegred/orgs","repos_url":"https://api.github.com/users/isaaclegred/repos","events_url":"https://api.github.com/users/isaaclegred/events{/privacy}","received_events_url":"https://api.github.com/users/isaaclegred/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nThis Pull Request includes inserting the necessary files to add Boost functionality to SpECTRE, which will allow us to wrap SpECTRE's C++ classes in Python.    In particular it includes a wrapper class for DataVector, which will allow for the use of the DataVector class, and all of its member functions, in Python.   \r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [x] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\n \r\n-->\r\n","created_at":"2018-10-02T19:10:04Z","updated_at":"2018-10-10T22:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"053a730b3466ad2c39ab428ea315411cd4b2507f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":825159059,"node_id":"MDU6TGFiZWw4MjUxNTkwNTk=","url":"https://api.github.com/repos/sxs-collaboration/spectre/labels/in%20progress","name":"in progress","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1021/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/5e2479bd6d156b18dce4c185b9a4425c9543e1fc","head":{"label":"isaaclegred:boost_python","ref":"boost_python","sha":"5e2479bd6d156b18dce4c185b9a4425c9543e1fc","user":{"login":"isaaclegred","id":36135409,"node_id":"MDQ6VXNlcjM2MTM1NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/36135409?v=4","gravatar_id":"","url":"https://api.github.com/users/isaaclegred","html_url":"https://github.com/isaaclegred","followers_url":"https://api.github.com/users/isaaclegred/followers","following_url":"https://api.github.com/users/isaaclegred/following{/other_user}","gists_url":"https://api.github.com/users/isaaclegred/gists{/gist_id}","starred_url":"https://api.github.com/users/isaaclegred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaaclegred/subscriptions","organizations_url":"https://api.github.com/users/isaaclegred/orgs","repos_url":"https://api.github.com/users/isaaclegred/repos","events_url":"https://api.github.com/users/isaaclegred/events{/privacy}","received_events_url":"https://api.github.com/users/isaaclegred/received_events","type":"User","site_admin":false},"repo":{"id":140722639,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3MjI2Mzk=","name":"spectre","full_name":"isaaclegred/spectre","private":false,"owner":{"login":"isaaclegred","id":36135409,"node_id":"MDQ6VXNlcjM2MTM1NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/36135409?v=4","gravatar_id":"","url":"https://api.github.com/users/isaaclegred","html_url":"https://github.com/isaaclegred","followers_url":"https://api.github.com/users/isaaclegred/followers","following_url":"https://api.github.com/users/isaaclegred/following{/other_user}","gists_url":"https://api.github.com/users/isaaclegred/gists{/gist_id}","starred_url":"https://api.github.com/users/isaaclegred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaaclegred/subscriptions","organizations_url":"https://api.github.com/users/isaaclegred/orgs","repos_url":"https://api.github.com/users/isaaclegred/repos","events_url":"https://api.github.com/users/isaaclegred/events{/privacy}","received_events_url":"https://api.github.com/users/isaaclegred/received_events","type":"User","site_admin":false},"html_url":"https://github.com/isaaclegred/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/isaaclegred/spectre","forks_url":"https://api.github.com/repos/isaaclegred/spectre/forks","keys_url":"https://api.github.com/repos/isaaclegred/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaaclegred/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaaclegred/spectre/teams","hooks_url":"https://api.github.com/repos/isaaclegred/spectre/hooks","issue_events_url":"https://api.github.com/repos/isaaclegred/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/isaaclegred/spectre/events","assignees_url":"https://api.github.com/repos/isaaclegred/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/isaaclegred/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/isaaclegred/spectre/tags","blobs_url":"https://api.github.com/repos/isaaclegred/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaaclegred/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaaclegred/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaaclegred/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaaclegred/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/isaaclegred/spectre/languages","stargazers_url":"https://api.github.com/repos/isaaclegred/spectre/stargazers","contributors_url":"https://api.github.com/repos/isaaclegred/spectre/contributors","subscribers_url":"https://api.github.com/repos/isaaclegred/spectre/subscribers","subscription_url":"https://api.github.com/repos/isaaclegred/spectre/subscription","commits_url":"https://api.github.com/repos/isaaclegred/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaaclegred/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaaclegred/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaaclegred/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaaclegred/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/isaaclegred/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaaclegred/spectre/merges","archive_url":"https://api.github.com/repos/isaaclegred/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaaclegred/spectre/downloads","issues_url":"https://api.github.com/repos/isaaclegred/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/isaaclegred/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/isaaclegred/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/isaaclegred/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaaclegred/spectre/labels{/name}","releases_url":"https://api.github.com/repos/isaaclegred/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/isaaclegred/spectre/deployments","created_at":"2018-07-12T14:15:20Z","updated_at":"2018-07-17T15:07:18Z","pushed_at":"2018-10-09T19:33:30Z","git_url":"git://github.com/isaaclegred/spectre.git","ssh_url":"git@github.com:isaaclegred/spectre.git","clone_url":"https://github.com/isaaclegred/spectre.git","svn_url":"https://github.com/isaaclegred/spectre","homepage":"","size":13768,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"b1238159c3c765fe3f810cb74f42e60ec9ea9ec8","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-10-10T22:12:01Z","pushed_at":"2018-10-10T22:12:50Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":11870,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":142,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1021"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1021"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1021/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1021/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/5e2479bd6d156b18dce4c185b9a4425c9543e1fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"nilsdeppe"}}