{"action":"closed","number":19044,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19044","id":202690855,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjkwODU1","html_url":"https://github.com/dotnet/coreclr/pull/19044","diff_url":"https://github.com/dotnet/coreclr/pull/19044.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19044.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19044","number":19044,"state":"closed","locked":false,"title":"Sdk test projects","user":{"login":"chsienki","id":16246502,"node_id":"MDQ6VXNlcjE2MjQ2NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/16246502?v=4","gravatar_id":"","url":"https://api.github.com/users/chsienki","html_url":"https://github.com/chsienki","followers_url":"https://api.github.com/users/chsienki/followers","following_url":"https://api.github.com/users/chsienki/following{/other_user}","gists_url":"https://api.github.com/users/chsienki/gists{/gist_id}","starred_url":"https://api.github.com/users/chsienki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chsienki/subscriptions","organizations_url":"https://api.github.com/users/chsienki/orgs","repos_url":"https://api.github.com/users/chsienki/repos","events_url":"https://api.github.com/users/chsienki/events{/privacy}","received_events_url":"https://api.github.com/users/chsienki/received_events","type":"User","site_admin":false},"body":"New PR replacing #18810 rebased on top of #18695:\r\n___\r\nThis change updates the associated targets and props files in the test directory to allow the test csproj's to be built as SDK style projects alongside traditional style projects.\r\n\r\nIt does not yet upgrade any of the projects, I'll submit a seperate batch of PRs for that, so that these changes aren't lost in a ton of mechanical refactoring.\r\n\r\nWhile these changes allow the csproj's to be upgraded, there is still work to be done to allow depproj and ilproj's to be converted over to the new style. By allowing a mix of projects styles this change allows us to upgrade piece-meal rather than in a single big bang, hopefully allowing us to easier figure out bugs if they arise. \r\n\r\n- Remove CodeTaskFactory:\r\n  - Allows the projects to be built using the core version of msbuild/dotnet build\r\n  - Converted to using msbuild property expansion instead\r\n- Add directory.build.{props,targets}:\r\n  - Currently we just import the dirs.props and targets, but means SDK style projects don't need to explicitly include these files\r\n   - We probably want to move all projects over to using these in the future, but this keeps the changes smaller for now\r\n- Specific code for SDK projects:\r\n  - There are a several changes required to build an SDK project. This change guards them behind conditionals so that only the new style projects see them. When we get to the point that there are only new projects, we can remove the guards (probably at the same time as ditching the dir.props)\r\n- Reordered build targets:\r\n  - Because SDK projects implicitly import the build targets, we can no longer re-define the build targets unconditionally knowing they will likely be overwritten. \r\n  - Instead we move the overwritten targets to seperate files, and include these conditionally based on properties. In this way there is always a build defined for SDK projects, which can then be overwritten to do nothing as needed.","created_at":"2018-07-19T21:37:09Z","updated_at":"2018-07-25T18:13:28Z","closed_at":"2018-07-25T18:13:28Z","merged_at":"2018-07-25T18:13:28Z","merge_commit_sha":"eddc1a621b66d63ac9feda289f08fc0e9f67f850","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sbomer","id":787361,"node_id":"MDQ6VXNlcjc4NzM2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/787361?v=4","gravatar_id":"","url":"https://api.github.com/users/sbomer","html_url":"https://github.com/sbomer","followers_url":"https://api.github.com/users/sbomer/followers","following_url":"https://api.github.com/users/sbomer/following{/other_user}","gists_url":"https://api.github.com/users/sbomer/gists{/gist_id}","starred_url":"https://api.github.com/users/sbomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbomer/subscriptions","organizations_url":"https://api.github.com/users/sbomer/orgs","repos_url":"https://api.github.com/users/sbomer/repos","events_url":"https://api.github.com/users/sbomer/events{/privacy}","received_events_url":"https://api.github.com/users/sbomer/received_events","type":"User","site_admin":false},{"login":"jashook","id":2723327,"node_id":"MDQ6VXNlcjI3MjMzMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2723327?v=4","gravatar_id":"","url":"https://api.github.com/users/jashook","html_url":"https://github.com/jashook","followers_url":"https://api.github.com/users/jashook/followers","following_url":"https://api.github.com/users/jashook/following{/other_user}","gists_url":"https://api.github.com/users/jashook/gists{/gist_id}","starred_url":"https://api.github.com/users/jashook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashook/subscriptions","organizations_url":"https://api.github.com/users/jashook/orgs","repos_url":"https://api.github.com/users/jashook/repos","events_url":"https://api.github.com/users/jashook/events{/privacy}","received_events_url":"https://api.github.com/users/jashook/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19044/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19044/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19044/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/6ff88b70162f1008c54011f6c85cc457b91d0c5f","head":{"label":"chsienki:sdk_test_projects","ref":"sdk_test_projects","sha":"6ff88b70162f1008c54011f6c85cc457b91d0c5f","user":{"login":"chsienki","id":16246502,"node_id":"MDQ6VXNlcjE2MjQ2NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/16246502?v=4","gravatar_id":"","url":"https://api.github.com/users/chsienki","html_url":"https://github.com/chsienki","followers_url":"https://api.github.com/users/chsienki/followers","following_url":"https://api.github.com/users/chsienki/following{/other_user}","gists_url":"https://api.github.com/users/chsienki/gists{/gist_id}","starred_url":"https://api.github.com/users/chsienki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chsienki/subscriptions","organizations_url":"https://api.github.com/users/chsienki/orgs","repos_url":"https://api.github.com/users/chsienki/repos","events_url":"https://api.github.com/users/chsienki/events{/privacy}","received_events_url":"https://api.github.com/users/chsienki/received_events","type":"User","site_admin":false},"repo":{"id":111008285,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwMDgyODU=","name":"coreclr","full_name":"chsienki/coreclr","owner":{"login":"chsienki","id":16246502,"node_id":"MDQ6VXNlcjE2MjQ2NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/16246502?v=4","gravatar_id":"","url":"https://api.github.com/users/chsienki","html_url":"https://github.com/chsienki","followers_url":"https://api.github.com/users/chsienki/followers","following_url":"https://api.github.com/users/chsienki/following{/other_user}","gists_url":"https://api.github.com/users/chsienki/gists{/gist_id}","starred_url":"https://api.github.com/users/chsienki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chsienki/subscriptions","organizations_url":"https://api.github.com/users/chsienki/orgs","repos_url":"https://api.github.com/users/chsienki/repos","events_url":"https://api.github.com/users/chsienki/events{/privacy}","received_events_url":"https://api.github.com/users/chsienki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chsienki/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/chsienki/coreclr","forks_url":"https://api.github.com/repos/chsienki/coreclr/forks","keys_url":"https://api.github.com/repos/chsienki/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chsienki/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chsienki/coreclr/teams","hooks_url":"https://api.github.com/repos/chsienki/coreclr/hooks","issue_events_url":"https://api.github.com/repos/chsienki/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/chsienki/coreclr/events","assignees_url":"https://api.github.com/repos/chsienki/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/chsienki/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/chsienki/coreclr/tags","blobs_url":"https://api.github.com/repos/chsienki/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chsienki/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chsienki/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/chsienki/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chsienki/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/chsienki/coreclr/languages","stargazers_url":"https://api.github.com/repos/chsienki/coreclr/stargazers","contributors_url":"https://api.github.com/repos/chsienki/coreclr/contributors","subscribers_url":"https://api.github.com/repos/chsienki/coreclr/subscribers","subscription_url":"https://api.github.com/repos/chsienki/coreclr/subscription","commits_url":"https://api.github.com/repos/chsienki/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/chsienki/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/chsienki/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/chsienki/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/chsienki/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/chsienki/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chsienki/coreclr/merges","archive_url":"https://api.github.com/repos/chsienki/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chsienki/coreclr/downloads","issues_url":"https://api.github.com/repos/chsienki/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/chsienki/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/chsienki/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/chsienki/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chsienki/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/chsienki/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/chsienki/coreclr/deployments","created_at":"2017-11-16T18:38:06Z","updated_at":"2018-07-19T20:55:55Z","pushed_at":"2018-07-19T21:26:16Z","git_url":"git://github.com/chsienki/coreclr.git","ssh_url":"git@github.com:chsienki/coreclr.git","clone_url":"https://github.com/chsienki/coreclr.git","svn_url":"https://github.com/chsienki/coreclr","homepage":"https://github.com/dotnet/core","size":230597,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6d05402d6017aa754a8ce216b05d9f40cb8d6643","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-07-25T16:30:55Z","pushed_at":"2018-07-25T18:13:28Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":231836,"stargazers_count":9560,"watchers_count":9560,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2391,"mirror_url":null,"archived":false,"open_issues_count":1746,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2391,"open_issues":1746,"watchers":9560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19044"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19044"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19044"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19044/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19044/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19044/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/6ff88b70162f1008c54011f6c85cc457b91d0c5f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chsienki","id":16246502,"node_id":"MDQ6VXNlcjE2MjQ2NTAy","avatar_url":"https://avatars1.githubusercontent.com/u/16246502?v=4","gravatar_id":"","url":"https://api.github.com/users/chsienki","html_url":"https://github.com/chsienki","followers_url":"https://api.github.com/users/chsienki/followers","following_url":"https://api.github.com/users/chsienki/following{/other_user}","gists_url":"https://api.github.com/users/chsienki/gists{/gist_id}","starred_url":"https://api.github.com/users/chsienki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chsienki/subscriptions","organizations_url":"https://api.github.com/users/chsienki/orgs","repos_url":"https://api.github.com/users/chsienki/repos","events_url":"https://api.github.com/users/chsienki/events{/privacy}","received_events_url":"https://api.github.com/users/chsienki/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":19,"additions":84,"deletions":62,"changed_files":15}}
{"actor":{"display_login":"chsienki"}}