{"action":"created","issue":{"url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/275","repository_url":"https://api.github.com/repos/jrief/djangocms-cascade","labels_url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/275/labels{/name}","comments_url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/275/comments","events_url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/275/events","html_url":"https://github.com/jrief/djangocms-cascade/issues/275","id":298621386,"number":275,"title":"feature request: \"Container\" without bootstrap class \"container\"","user":{"login":"vleo","id":171272,"avatar_url":"https://avatars3.githubusercontent.com/u/171272?v=4","gravatar_id":"","url":"https://api.github.com/users/vleo","html_url":"https://github.com/vleo","followers_url":"https://api.github.com/users/vleo/followers","following_url":"https://api.github.com/users/vleo/following{/other_user}","gists_url":"https://api.github.com/users/vleo/gists{/gist_id}","starred_url":"https://api.github.com/users/vleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vleo/subscriptions","organizations_url":"https://api.github.com/users/vleo/orgs","repos_url":"https://api.github.com/users/vleo/repos","events_url":"https://api.github.com/users/vleo/events{/privacy}","received_events_url":"https://api.github.com/users/vleo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-20T14:49:50Z","updated_at":"2018-02-21T02:40:47Z","closed_at":null,"author_association":"NONE","body":"Bootstrap3 containers should not be nested.\r\nBut if I use the template that provides it's own top level bootstrap \"container\", for example in order to combine dynamic and static djangocms placeholders:\r\n```html\r\n{% block content %}\r\n  <div class=\"container\">\r\n  <div class=\"row\">\r\n    <span class=\"about\">\r\n      <div class=\"col-md-2\">\r\n        {% static_placeholder \"about\" %}\r\n      </div>\r\n    </span>\r\n    <span class=\"maincontent\">\r\n      <div class=\"col-md-10\">\r\n        {% placeholder \"content\" %}\r\n      </div>\r\n</span>\r\n  </div>\r\n  </div>\r\n{% endblock content %}\r\n```\r\nthe required toplevel placeholder cmsplugin_cascase \"Container\" ends up nested in top level bootstrap container that is coded in the template.\r\n\r\nIs there some already existing setting or workarouond I'm missing, or BootstrapContainerPlugin has to be patched in order to maybe add a flag that will replace css_classes.append('container') in its get_css_classes method? I.e. it would have not only 'fluid' / 'non-fluid', flag but also 'cascade only'  flag?\r\n\r\nI patched cmsplugin_cascade/bootstrap3/container.py to that effect and in case it's the right way to solve this problem I've also created a pull request.\r\n "},"comment":{"url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/comments/367195184","html_url":"https://github.com/jrief/djangocms-cascade/issues/275#issuecomment-367195184","issue_url":"https://api.github.com/repos/jrief/djangocms-cascade/issues/275","id":367195184,"user":{"login":"vleo","id":171272,"avatar_url":"https://avatars3.githubusercontent.com/u/171272?v=4","gravatar_id":"","url":"https://api.github.com/users/vleo","html_url":"https://github.com/vleo","followers_url":"https://api.github.com/users/vleo/followers","following_url":"https://api.github.com/users/vleo/following{/other_user}","gists_url":"https://api.github.com/users/vleo/gists{/gist_id}","starred_url":"https://api.github.com/users/vleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vleo/subscriptions","organizations_url":"https://api.github.com/users/vleo/orgs","repos_url":"https://api.github.com/users/vleo/repos","events_url":"https://api.github.com/users/vleo/events{/privacy}","received_events_url":"https://api.github.com/users/vleo/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T02:40:47Z","updated_at":"2018-02-21T02:40:47Z","author_association":"NONE","body":">why not? This is one of the many cool features of BS3.\r\n\r\nFrom https://getbootstrap.com/docs/3.3/css/:\r\n>Containers: Bootstrap requires a containing element to wrap site contents and house our grid system. You may choose one of two containers to use in your projects. Note that, due to padding and more, **neither container is nestable.**\r\n\r\nSpeaking of your approach to handling the issue addressed by the proposed patch - \r\n\r\n> Please refer to the section Adding Plugins into a hard coded grid in the docs.\r\n>> Hence we must tell `djangocms-cascade` which breakpoints shall be allowed and what the containers extensions shall be. This must be hard-coded inside your `setting.py`\r\n\r\nIt seems to me that checking couple/three checkboxes is much easier then patching `settings.py` for the project and can be done by a content editor person, as opposed to a python coder.\r\n\r\nAnother question I wanted to ask - why is it the` BootstrapContainerPlugin` and not the `BootstrapColumnPlugin` where the breakpoints are set - you still have to set column widths there, why not enable/disable` xs/sm/md/lg` for a given column there as well, like it is done in bs3 html code?"}}
{"actor":{"display_login":"vleo"}}