{"action":"created","issue":{"url":"https://api.github.com/repos/boris-kz/CogAlg/issues/14","repository_url":"https://api.github.com/repos/boris-kz/CogAlg","labels_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/14/comments","events_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/14/events","html_url":"https://github.com/boris-kz/CogAlg/issues/14","id":368035045,"node_id":"MDU6SXNzdWUzNjgwMzUwNDU=","number":14,"title":"Assignment by reference may cause overwritten values from aliased copies","user":{"login":"Twenkid","id":23367640,"node_id":"MDQ6VXNlcjIzMzY3NjQw","avatar_url":"https://avatars2.githubusercontent.com/u/23367640?v=4","gravatar_id":"","url":"https://api.github.com/users/Twenkid","html_url":"https://github.com/Twenkid","followers_url":"https://api.github.com/users/Twenkid/followers","following_url":"https://api.github.com/users/Twenkid/following{/other_user}","gists_url":"https://api.github.com/users/Twenkid/gists{/gist_id}","starred_url":"https://api.github.com/users/Twenkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twenkid/subscriptions","organizations_url":"https://api.github.com/users/Twenkid/orgs","repos_url":"https://api.github.com/users/Twenkid/repos","events_url":"https://api.github.com/users/Twenkid/events{/privacy}","received_events_url":"https://api.github.com/users/Twenkid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":61,"created_at":"2018-10-09T04:19:44Z","updated_at":"2018-10-19T15:53:58Z","closed_at":null,"author_association":"COLLABORATOR","body":"https://github.com/boris-kz/CogAlg/blob/527a66491b03067cc194795d8e476ed33f417b3c/frame_dblobs.py#L146\r\n\r\nI can't run or track it now and don't know if that's the case but that's a common source of  bugs. The initial value that is correct may be overwritten by an aliased  copy of the same reference by  reassignments. \r\n"},"comment":{"url":"https://api.github.com/repos/boris-kz/CogAlg/issues/comments/431410604","html_url":"https://github.com/boris-kz/CogAlg/issues/14#issuecomment-431410604","issue_url":"https://api.github.com/repos/boris-kz/CogAlg/issues/14","id":431410604,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQxMDYwNA==","user":{"login":"Twenkid","id":23367640,"node_id":"MDQ6VXNlcjIzMzY3NjQw","avatar_url":"https://avatars2.githubusercontent.com/u/23367640?v=4","gravatar_id":"","url":"https://api.github.com/users/Twenkid","html_url":"https://github.com/Twenkid","followers_url":"https://api.github.com/users/Twenkid/followers","following_url":"https://api.github.com/users/Twenkid/following{/other_user}","gists_url":"https://api.github.com/users/Twenkid/gists{/gist_id}","starred_url":"https://api.github.com/users/Twenkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twenkid/subscriptions","organizations_url":"https://api.github.com/users/Twenkid/orgs","repos_url":"https://api.github.com/users/Twenkid/repos","events_url":"https://api.github.com/users/Twenkid/events{/privacy}","received_events_url":"https://api.github.com/users/Twenkid/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T15:53:58Z","updated_at":"2018-10-19T15:53:58Z","author_association":"COLLABORATOR","body":"Several times I missed to say something important, though, that I've been\nbored to death.\n\nНа пт, 19.10.2018 г., 15:51 Boris Kazachenko <notifications@github.com>\nнаписа:\n\n> >\n> > OK, then hese speculations were right:\n> >\n> > Is this image correctly drawn by the code - that's another thing that has\n> > to be verified first by checking and possibly drawing the patterns.\n> > Now you say \"fork and roots should be...\" but\n> > have you verified that the other variables have all correct values, too?\n> >\n> >\n> The first part is pointless, the second is a platitude. You say a lot of\n> things, doing them is another matter.\n>\n>\n> > I couldn't know precisely (maybe besides finding a way to stop these\n> > errors) how they are supposed to be, it's \"fully overlapped\" either if\n> the\n> > coordinates match completely (I noticed a lot of macthing coordinates in\n> > the ERROR) or if there's one pixel difference (from one side, from both\n> > sides...).\n> >\n> > That has to be more precisely defined, and if there are no other\n> > specifications, the ground truth is your code.\n> >\n> >\n> Of course you could, the meaning of vertically \"fully overlapped\" is\n> obvious: all x values of one are present in x values of another.\n> My pixel comps are vertical and lateral, not diagonal. And that's separate\n> from determining x of initial pixel of a pattern.\n>\n> >\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/boris-kz/CogAlg/issues/14#issuecomment-431352494>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AWSP2FVWHqzBvKReBG1X44cwKGB37V39ks5umcrWgaJpZM4XQktA>\n> .\n>\n"}}
{"actor":{"display_login":"Twenkid"}}