{"action":"created","issue":{"url":"https://api.github.com/repos/espnet/espnet/issues/488","repository_url":"https://api.github.com/repos/espnet/espnet","labels_url":"https://api.github.com/repos/espnet/espnet/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/espnet/espnet/issues/488/comments","events_url":"https://api.github.com/repos/espnet/espnet/issues/488/events","html_url":"https://github.com/espnet/espnet/issues/488","id":386136627,"node_id":"MDU6SXNzdWUzODYxMzY2Mjc=","number":488,"title":"Why batch-beam search is different from non batch-beam search","user":{"login":"ShigekiKarita","id":6745326,"node_id":"MDQ6VXNlcjY3NDUzMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6745326?v=4","gravatar_id":"","url":"https://api.github.com/users/ShigekiKarita","html_url":"https://github.com/ShigekiKarita","followers_url":"https://api.github.com/users/ShigekiKarita/followers","following_url":"https://api.github.com/users/ShigekiKarita/following{/other_user}","gists_url":"https://api.github.com/users/ShigekiKarita/gists{/gist_id}","starred_url":"https://api.github.com/users/ShigekiKarita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShigekiKarita/subscriptions","organizations_url":"https://api.github.com/users/ShigekiKarita/orgs","repos_url":"https://api.github.com/users/ShigekiKarita/repos","events_url":"https://api.github.com/users/ShigekiKarita/events{/privacy}","received_events_url":"https://api.github.com/users/ShigekiKarita/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-30T10:52:03Z","updated_at":"2018-12-02T06:38:13Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"@mn5k @takaaki-hori @sw005320 \r\nFirst, I apologize my late catchup (not reviewed). Because I am trying to refactor the beam search implementation for various models like transformer now, I want to understand this change between them.\r\n\r\n## prunning (topk)\r\n\r\nnon-batch implementation does prunning (topk) before ctc and lm scoring\r\nhttps://github.com/espnet/espnet/blob/60682e8823d8fb44bf54ef157ddf7ae2c8797fc0/espnet/nets/e2e_asr_th.py#L2205-L2218\r\n\r\nbatch implementation does prunning after ctc and lm scoring\r\nhttps://github.com/espnet/espnet/blob/60682e8823d8fb44bf54ef157ddf7ae2c8797fc0/espnet/nets/e2e_asr_th.py#L2373-L2391\r\n\r\nIsn't this make difference?\r\n\r\n(EDIT: several questions I deleted here was solved by myself)"},"comment":{"url":"https://api.github.com/repos/espnet/espnet/issues/comments/443485547","html_url":"https://github.com/espnet/espnet/issues/488#issuecomment-443485547","issue_url":"https://api.github.com/repos/espnet/espnet/issues/488","id":443485547,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ4NTU0Nw==","user":{"login":"ShigekiKarita","id":6745326,"node_id":"MDQ6VXNlcjY3NDUzMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6745326?v=4","gravatar_id":"","url":"https://api.github.com/users/ShigekiKarita","html_url":"https://github.com/ShigekiKarita","followers_url":"https://api.github.com/users/ShigekiKarita/followers","following_url":"https://api.github.com/users/ShigekiKarita/following{/other_user}","gists_url":"https://api.github.com/users/ShigekiKarita/gists{/gist_id}","starred_url":"https://api.github.com/users/ShigekiKarita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShigekiKarita/subscriptions","organizations_url":"https://api.github.com/users/ShigekiKarita/orgs","repos_url":"https://api.github.com/users/ShigekiKarita/repos","events_url":"https://api.github.com/users/ShigekiKarita/events{/privacy}","received_events_url":"https://api.github.com/users/ShigekiKarita/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T06:38:13Z","updated_at":"2018-12-02T06:38:13Z","author_association":"CONTRIBUTOR","body":"OK, maybe I will also investigate it in next implementation. Thanks!"}}
{"actor":{"display_login":"ShigekiKarita"}}