{"action":"created","comment":{"url":"https://api.github.com/repos/swaywm/wlroots/pulls/comments/176528758","pull_request_review_id":106249115,"id":176528758,"diff_hunk":"@@ -186,6 +186,11 @@ static void wlr_wl_output_destroy(struct wlr_output *wlr_output) {\n \t\twl_callback_destroy(output->frame_callback);\n \t}\n \n+\tstruct wlr_wl_pointer *pointer = output->backend->wlr_wl_pointer;\n+\tif (pointer && pointer->current_output == output) {\n+\t\tpointer->current_output = NULL;\n+\t}","path":"backend/wayland/output.c","position":7,"original_position":7,"commit_id":"1f34ca6a16e9c1d5bd3777ae787eb9aa202bf140","original_commit_id":"ce4a3c941a1f0a8e2acffdb1f59386cabd514346","user":{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false},"body":"You only need a listener for whatever output `current_output` points to.","created_at":"2018-03-22T18:32:22Z","updated_at":"2018-03-22T18:32:22Z","html_url":"https://github.com/swaywm/wlroots/pull/727#discussion_r176528758","pull_request_url":"https://api.github.com/repos/swaywm/wlroots/pulls/727","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/comments/176528758"},"html":{"href":"https://github.com/swaywm/wlroots/pull/727#discussion_r176528758"},"pull_request":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/727"}},"in_reply_to_id":175265687},"pull_request":{"url":"https://api.github.com/repos/swaywm/wlroots/pulls/727","id":175713405,"html_url":"https://github.com/swaywm/wlroots/pull/727","diff_url":"https://github.com/swaywm/wlroots/pull/727.diff","patch_url":"https://github.com/swaywm/wlroots/pull/727.patch","issue_url":"https://api.github.com/repos/swaywm/wlroots/issues/727","number":727,"state":"open","locked":false,"title":"Address sanitizer fixes","user":{"login":"martinetd","id":1729331,"avatar_url":"https://avatars0.githubusercontent.com/u/1729331?v=4","gravatar_id":"","url":"https://api.github.com/users/martinetd","html_url":"https://github.com/martinetd","followers_url":"https://api.github.com/users/martinetd/followers","following_url":"https://api.github.com/users/martinetd/following{/other_user}","gists_url":"https://api.github.com/users/martinetd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinetd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinetd/subscriptions","organizations_url":"https://api.github.com/users/martinetd/orgs","repos_url":"https://api.github.com/users/martinetd/repos","events_url":"https://api.github.com/users/martinetd/events{/privacy}","received_events_url":"https://api.github.com/users/martinetd/received_events","type":"User","site_admin":false},"body":"- Some memory leaks in xdg shells, rootston output and x11 backend\r\n- A use after free in wayland backend.\r\n\r\nI'm not 100% happy with my use-after-free fix, if someone has a better idea to access the wlr_wl_pointer from the output destroy handler. At first I wanted to add another output event handler listener to the pointer itself but since the wayland backend can have many outputs and a single pointer (at least with the current design, how does it handle being started from a rootston with multiple seats?) it was more straight-forward to cleanup from output, but I'm sure this can be done better.","created_at":"2018-03-17T18:08:48Z","updated_at":"2018-03-22T18:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ab9b883f61e6f4bd6a973e9e97fe2b13f622118","assignee":{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false},"assignees":[{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaywm/wlroots/pulls/727/commits","review_comments_url":"https://api.github.com/repos/swaywm/wlroots/pulls/727/comments","review_comment_url":"https://api.github.com/repos/swaywm/wlroots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaywm/wlroots/issues/727/comments","statuses_url":"https://api.github.com/repos/swaywm/wlroots/statuses/1f34ca6a16e9c1d5bd3777ae787eb9aa202bf140","head":{"label":"martinetd:x11_wl_backend_fixes","ref":"x11_wl_backend_fixes","sha":"1f34ca6a16e9c1d5bd3777ae787eb9aa202bf140","user":{"login":"martinetd","id":1729331,"avatar_url":"https://avatars0.githubusercontent.com/u/1729331?v=4","gravatar_id":"","url":"https://api.github.com/users/martinetd","html_url":"https://github.com/martinetd","followers_url":"https://api.github.com/users/martinetd/followers","following_url":"https://api.github.com/users/martinetd/following{/other_user}","gists_url":"https://api.github.com/users/martinetd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinetd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinetd/subscriptions","organizations_url":"https://api.github.com/users/martinetd/orgs","repos_url":"https://api.github.com/users/martinetd/repos","events_url":"https://api.github.com/users/martinetd/events{/privacy}","received_events_url":"https://api.github.com/users/martinetd/received_events","type":"User","site_admin":false},"repo":{"id":100055654,"name":"wlroots","full_name":"martinetd/wlroots","owner":{"login":"martinetd","id":1729331,"avatar_url":"https://avatars0.githubusercontent.com/u/1729331?v=4","gravatar_id":"","url":"https://api.github.com/users/martinetd","html_url":"https://github.com/martinetd","followers_url":"https://api.github.com/users/martinetd/followers","following_url":"https://api.github.com/users/martinetd/following{/other_user}","gists_url":"https://api.github.com/users/martinetd/gists{/gist_id}","starred_url":"https://api.github.com/users/martinetd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinetd/subscriptions","organizations_url":"https://api.github.com/users/martinetd/orgs","repos_url":"https://api.github.com/users/martinetd/repos","events_url":"https://api.github.com/users/martinetd/events{/privacy}","received_events_url":"https://api.github.com/users/martinetd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinetd/wlroots","description":"A collection of libraries for wayland compositors","fork":true,"url":"https://api.github.com/repos/martinetd/wlroots","forks_url":"https://api.github.com/repos/martinetd/wlroots/forks","keys_url":"https://api.github.com/repos/martinetd/wlroots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinetd/wlroots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinetd/wlroots/teams","hooks_url":"https://api.github.com/repos/martinetd/wlroots/hooks","issue_events_url":"https://api.github.com/repos/martinetd/wlroots/issues/events{/number}","events_url":"https://api.github.com/repos/martinetd/wlroots/events","assignees_url":"https://api.github.com/repos/martinetd/wlroots/assignees{/user}","branches_url":"https://api.github.com/repos/martinetd/wlroots/branches{/branch}","tags_url":"https://api.github.com/repos/martinetd/wlroots/tags","blobs_url":"https://api.github.com/repos/martinetd/wlroots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinetd/wlroots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinetd/wlroots/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinetd/wlroots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinetd/wlroots/statuses/{sha}","languages_url":"https://api.github.com/repos/martinetd/wlroots/languages","stargazers_url":"https://api.github.com/repos/martinetd/wlroots/stargazers","contributors_url":"https://api.github.com/repos/martinetd/wlroots/contributors","subscribers_url":"https://api.github.com/repos/martinetd/wlroots/subscribers","subscription_url":"https://api.github.com/repos/martinetd/wlroots/subscription","commits_url":"https://api.github.com/repos/martinetd/wlroots/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinetd/wlroots/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinetd/wlroots/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinetd/wlroots/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinetd/wlroots/contents/{+path}","compare_url":"https://api.github.com/repos/martinetd/wlroots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinetd/wlroots/merges","archive_url":"https://api.github.com/repos/martinetd/wlroots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinetd/wlroots/downloads","issues_url":"https://api.github.com/repos/martinetd/wlroots/issues{/number}","pulls_url":"https://api.github.com/repos/martinetd/wlroots/pulls{/number}","milestones_url":"https://api.github.com/repos/martinetd/wlroots/milestones{/number}","notifications_url":"https://api.github.com/repos/martinetd/wlroots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinetd/wlroots/labels{/name}","releases_url":"https://api.github.com/repos/martinetd/wlroots/releases{/id}","deployments_url":"https://api.github.com/repos/martinetd/wlroots/deployments","created_at":"2017-08-11T17:25:41Z","updated_at":"2017-08-11T17:25:42Z","pushed_at":"2018-03-19T19:43:42Z","git_url":"git://github.com/martinetd/wlroots.git","ssh_url":"git@github.com:martinetd/wlroots.git","clone_url":"https://github.com/martinetd/wlroots.git","svn_url":"https://github.com/martinetd/wlroots","homepage":null,"size":3402,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swaywm:master","ref":"master","sha":"09413aa7f1eab176c12675217a17ebe367fa7d8f","user":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"repo":{"id":89377392,"name":"wlroots","full_name":"swaywm/wlroots","owner":{"login":"swaywm","id":32400794,"avatar_url":"https://avatars1.githubusercontent.com/u/32400794?v=4","gravatar_id":"","url":"https://api.github.com/users/swaywm","html_url":"https://github.com/swaywm","followers_url":"https://api.github.com/users/swaywm/followers","following_url":"https://api.github.com/users/swaywm/following{/other_user}","gists_url":"https://api.github.com/users/swaywm/gists{/gist_id}","starred_url":"https://api.github.com/users/swaywm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaywm/subscriptions","organizations_url":"https://api.github.com/users/swaywm/orgs","repos_url":"https://api.github.com/users/swaywm/repos","events_url":"https://api.github.com/users/swaywm/events{/privacy}","received_events_url":"https://api.github.com/users/swaywm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swaywm/wlroots","description":"A modular Wayland compositor library","fork":false,"url":"https://api.github.com/repos/swaywm/wlroots","forks_url":"https://api.github.com/repos/swaywm/wlroots/forks","keys_url":"https://api.github.com/repos/swaywm/wlroots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaywm/wlroots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaywm/wlroots/teams","hooks_url":"https://api.github.com/repos/swaywm/wlroots/hooks","issue_events_url":"https://api.github.com/repos/swaywm/wlroots/issues/events{/number}","events_url":"https://api.github.com/repos/swaywm/wlroots/events","assignees_url":"https://api.github.com/repos/swaywm/wlroots/assignees{/user}","branches_url":"https://api.github.com/repos/swaywm/wlroots/branches{/branch}","tags_url":"https://api.github.com/repos/swaywm/wlroots/tags","blobs_url":"https://api.github.com/repos/swaywm/wlroots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaywm/wlroots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaywm/wlroots/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaywm/wlroots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaywm/wlroots/statuses/{sha}","languages_url":"https://api.github.com/repos/swaywm/wlroots/languages","stargazers_url":"https://api.github.com/repos/swaywm/wlroots/stargazers","contributors_url":"https://api.github.com/repos/swaywm/wlroots/contributors","subscribers_url":"https://api.github.com/repos/swaywm/wlroots/subscribers","subscription_url":"https://api.github.com/repos/swaywm/wlroots/subscription","commits_url":"https://api.github.com/repos/swaywm/wlroots/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaywm/wlroots/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaywm/wlroots/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaywm/wlroots/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaywm/wlroots/contents/{+path}","compare_url":"https://api.github.com/repos/swaywm/wlroots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaywm/wlroots/merges","archive_url":"https://api.github.com/repos/swaywm/wlroots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaywm/wlroots/downloads","issues_url":"https://api.github.com/repos/swaywm/wlroots/issues{/number}","pulls_url":"https://api.github.com/repos/swaywm/wlroots/pulls{/number}","milestones_url":"https://api.github.com/repos/swaywm/wlroots/milestones{/number}","notifications_url":"https://api.github.com/repos/swaywm/wlroots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaywm/wlroots/labels{/name}","releases_url":"https://api.github.com/repos/swaywm/wlroots/releases{/id}","deployments_url":"https://api.github.com/repos/swaywm/wlroots/deployments","created_at":"2017-04-25T15:33:43Z","updated_at":"2018-03-21T05:20:13Z","pushed_at":"2018-03-21T19:12:14Z","git_url":"git://github.com/swaywm/wlroots.git","ssh_url":"git@github.com:swaywm/wlroots.git","clone_url":"https://github.com/swaywm/wlroots.git","svn_url":"https://github.com/swaywm/wlroots","homepage":"http://swaywm.org","size":3503,"stargazers_count":297,"watchers_count":297,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":49,"open_issues":89,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/727"},"html":{"href":"https://github.com/swaywm/wlroots/pull/727"},"issue":{"href":"https://api.github.com/repos/swaywm/wlroots/issues/727"},"comments":{"href":"https://api.github.com/repos/swaywm/wlroots/issues/727/comments"},"review_comments":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/727/comments"},"review_comment":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaywm/wlroots/pulls/727/commits"},"statuses":{"href":"https://api.github.com/repos/swaywm/wlroots/statuses/1f34ca6a16e9c1d5bd3777ae787eb9aa202bf140"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"acrisci"}}