{"action":"created","issue":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/593","repository_url":"https://api.github.com/repos/jprichardson/node-fs-extra","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/593/labels{/name}","comments_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/593/comments","events_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/593/events","html_url":"https://github.com/jprichardson/node-fs-extra/issues/593","id":330798692,"node_id":"MDU6SXNzdWUzMzA3OTg2OTI=","number":593,"title":"fs.readFileSync error for .md markdown files","user":{"login":"quinton-ashley","id":20031683,"node_id":"MDQ6VXNlcjIwMDMxNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/20031683?v=4","gravatar_id":"","url":"https://api.github.com/users/quinton-ashley","html_url":"https://github.com/quinton-ashley","followers_url":"https://api.github.com/users/quinton-ashley/followers","following_url":"https://api.github.com/users/quinton-ashley/following{/other_user}","gists_url":"https://api.github.com/users/quinton-ashley/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-ashley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-ashley/subscriptions","organizations_url":"https://api.github.com/users/quinton-ashley/orgs","repos_url":"https://api.github.com/users/quinton-ashley/repos","events_url":"https://api.github.com/users/quinton-ashley/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-ashley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-08T20:50:49Z","updated_at":"2018-06-10T07:01:26Z","closed_at":null,"author_association":"NONE","body":"- **Operating System:macOS 10.14 Developer Beta**\r\n- **Node.js version:8.11.1**\r\n- **`fs-extra` version: 4.0.3**\r\n\r\nUpon reading a markdown file with fs.readFileSync() I get an JSON parsing error.  This markdown file does not contain JSON.\r\n```\r\nUncaught SyntaxError: /Users/qashto/Documents/dev/lib/qodemate-test-files/jsTestFolder/lesson.md: Unexpected token # in JSON at position 0\r\n    at JSON.parse (<anonymous>)\r\n    at Object.readFileSync (/Users/qashto/Documents/dev/apps/qodemate/node_modules/jsonfile/index.js:63)\r\n    at module.exports.open (/Users/qashto/Documents/dev/apps/qodemate-core/index.js:84)\r\n    at chooseFile (/Users/qashto/Documents/dev/apps/qodemate-desktop/views/js/renderer.js:49)\r\n    at HTMLButtonElement.bigButtonClicked (/Users/qashto/Documents/dev/apps/qodemate-desktop/views/js/renderer.js:58)\r\n    at HTMLButtonElement.dispatch (/Users/qashto/Documents/dev/apps/qodemate/node_modules/jquery/dist/jquery.js:5183)\r\n    at HTMLButtonElement.elemData.handle (/Users/qashto/Documents/dev/apps/qodemate/node_modules/jquery/dist/jquery.js:4991)\r\n```"},"comment":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/comments/396026166","html_url":"https://github.com/jprichardson/node-fs-extra/issues/593#issuecomment-396026166","issue_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/593","id":396026166,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjAyNjE2Ng==","user":{"login":"quinton-ashley","id":20031683,"node_id":"MDQ6VXNlcjIwMDMxNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/20031683?v=4","gravatar_id":"","url":"https://api.github.com/users/quinton-ashley","html_url":"https://github.com/quinton-ashley","followers_url":"https://api.github.com/users/quinton-ashley/followers","following_url":"https://api.github.com/users/quinton-ashley/following{/other_user}","gists_url":"https://api.github.com/users/quinton-ashley/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-ashley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-ashley/subscriptions","organizations_url":"https://api.github.com/users/quinton-ashley/orgs","repos_url":"https://api.github.com/users/quinton-ashley/repos","events_url":"https://api.github.com/users/quinton-ashley/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-ashley/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T07:01:26Z","updated_at":"2018-06-10T07:01:26Z","author_association":"NONE","body":"Nevermind, this was not an issue with fs-extra.  I'm working on a package called [sidecar](https://github.com/quinton-ashley/sidecar) that overrides require to allow packages to be required outside node_modules, \"sidecarred\", during development. I made an error that allowed './fs' in the index.js of fs-extra to refer to the native fs module I think.   I fixed it by not allowing strings to start with './' for sidecarred packages.  Fixed in [1.0.7](https://github.com/quinton-ashley/sidecar/commit/f61be46d3e0e7d389849a98152012fa73badfe85#diff-168726dbe96b3ce427e7fedce31bb0bc)"}}
{"actor":{"display_login":"quinton-ashley"}}