{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/874","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/874/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/874/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/874/events","html_url":"https://github.com/kubevirt/kubevirt/issues/874","id":311996021,"number":874,"title":"vm.yaml has invalid image name","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"labels":[{"id":502265367,"url":"https://api.github.com/repos/kubevirt/kubevirt/labels/kind/enhancement","name":"kind/enhancement","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-06T14:24:47Z","updated_at":"2018-04-09T07:45:36Z","closed_at":null,"author_association":"NONE","body":"In https://github.com/cockpit-project/cockpit/pull/8947 I'm trying to rebuild Cockpit's openshift image which includes the current release (v0.3.0) of kubevirt. This tries to deploy iscsi-demo-target.yaml (which works, or at least does not fail), and then [vm.yaml](https://github.com/kubevirt/kubevirt/blob/master/cluster/vm.yaml). But this specifies `image: kubevirt/cirros-registry-disk-demo:devel` which [does not exist](https://hub.docker.com/r/kubevirt/cirros-registry-disk-demo/tags/). I figure it should match the released version, so maybe it should use `{{ docker_tag }}` like the [iscsi demo](https://github.com/kubevirt/kubevirt/blob/master/manifests/testing/iscsi-demo-target.yaml.in)?\r\n\r\nSo I pulled kubevirt/cirros-registry-disk-demo:v0.3.0 and changed the file to use the `:v0.3.0` tag. \r\n\r\n~But then it still fails:~ **Update**: All good, I just forgot the setup steps.\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/379664174","html_url":"https://github.com/kubevirt/kubevirt/issues/874#issuecomment-379664174","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/874","id":379664174,"user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T07:45:36Z","updated_at":"2018-04-09T07:45:36Z","author_association":"OWNER","body":"@martinpitt looking at https://github.com/cockpit-project/cockpit/pull/8947/files#diff-3db8a96aef3a0ad8fd60930f6774d271R47, we use in all our examples the `devel` tag which we do intentionally not publish. That helps us to ensure that we can tie or examples to the exact repo content. If you would run `make cluster-up && make cluster-sync` followed by a `cluster/kubectl.sh create -f cluster/vm.yaml` the manifests would work.\r\n\r\nWe could probably rethink that, since registry disks themselves never changed since they got implemented."}}
{"actor":{"display_login":"rmohr"}}