{"action":"closed","number":1511,"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1511","id":194156463,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTU2NDYz","html_url":"https://github.com/alibaba/pouch/pull/1511","diff_url":"https://github.com/alibaba/pouch/pull/1511.diff","patch_url":"https://github.com/alibaba/pouch/pull/1511.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1511","number":1511,"state":"closed","locked":false,"title":"feature: UpdateContainerResources of CRI Manager","user":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Starnop <starnop@163.com>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nadd feature: UpdateContainerResources of CRI Manager\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\nNone\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n```\r\n# pouch run -d -m 20m --name cri-update-test registry.hub.docker.com/library/nginx:latest\r\nWARNING: Current Kernel does not support memory swap, discard --memory-swap \r\nbd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5\r\n\r\n# cat /sys/fs/cgroup/memory/default/bd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5/memory.limit_in_bytes \r\n20971520\r\n\r\n# crictl update --memory 31457280 bd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5\r\nDEBU[0000] UpdateContainerResourcesRequest: &UpdateContainerResourcesRequest{ContainerId:bd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5,Linux:&LinuxContainerResources{CpuPeriod:0,CpuQuota:0,CpuShares:0,MemoryLimitInBytes:31457280,OomScoreAdj:0,CpusetCpus:,CpusetMems:,},} \r\nDEBU[0000] UpdateContainerResourcesResponse: &UpdateContainerResourcesResponse{} \r\nbd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5\r\n\r\n# cat /sys/fs/cgroup/memory/default/bd6c5b9de4874f6703961ed543a9056a9762279433c6cad0fd8b63f42f636ff5/memory.limit_in_bytes \r\n31457280\r\n```\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-06-12T03:23:06Z","updated_at":"2018-06-14T04:28:31Z","closed_at":"2018-06-14T04:28:31Z","merged_at":"2018-06-14T04:28:31Z","merge_commit_sha":"1b35c2a6db622a2a761adb95d2c78dcf143b6294","assignee":{"login":"YaoZengzeng","id":8636562,"node_id":"MDQ6VXNlcjg2MzY1NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"assignees":[{"login":"YaoZengzeng","id":8636562,"node_id":"MDQ6VXNlcjg2MzY1NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722352215,"node_id":"MDU6TGFiZWw3MjIzNTIyMTU=","url":"https://api.github.com/repos/alibaba/pouch/labels/LGTM","name":"LGTM","color":"88f486","default":false},{"id":722348097,"node_id":"MDU6TGFiZWw3MjIzNDgwOTc=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/feature","name":"kind/feature","color":"1d76db","default":false},{"id":729586101,"node_id":"MDU6TGFiZWw3Mjk1ODYxMDE=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/M","name":"size/M","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/1511/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/1511/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1511/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/985234c6d7c753cc6cda33ce446118f67d68840b","head":{"label":"Starnop:cri-update","ref":"cri-update","sha":"985234c6d7c753cc6cda33ce446118f67d68840b","user":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"repo":{"id":128589385,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1ODkzODU=","name":"pouch","full_name":"Starnop/pouch","owner":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Starnop/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/Starnop/pouch","forks_url":"https://api.github.com/repos/Starnop/pouch/forks","keys_url":"https://api.github.com/repos/Starnop/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starnop/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starnop/pouch/teams","hooks_url":"https://api.github.com/repos/Starnop/pouch/hooks","issue_events_url":"https://api.github.com/repos/Starnop/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/Starnop/pouch/events","assignees_url":"https://api.github.com/repos/Starnop/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/Starnop/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/Starnop/pouch/tags","blobs_url":"https://api.github.com/repos/Starnop/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starnop/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starnop/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starnop/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starnop/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/Starnop/pouch/languages","stargazers_url":"https://api.github.com/repos/Starnop/pouch/stargazers","contributors_url":"https://api.github.com/repos/Starnop/pouch/contributors","subscribers_url":"https://api.github.com/repos/Starnop/pouch/subscribers","subscription_url":"https://api.github.com/repos/Starnop/pouch/subscription","commits_url":"https://api.github.com/repos/Starnop/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starnop/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starnop/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starnop/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starnop/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/Starnop/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starnop/pouch/merges","archive_url":"https://api.github.com/repos/Starnop/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starnop/pouch/downloads","issues_url":"https://api.github.com/repos/Starnop/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/Starnop/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/Starnop/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/Starnop/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starnop/pouch/labels{/name}","releases_url":"https://api.github.com/repos/Starnop/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/Starnop/pouch/deployments","created_at":"2018-04-08T02:38:51Z","updated_at":"2018-06-12T05:14:13Z","pushed_at":"2018-06-14T02:03:46Z","git_url":"git://github.com/Starnop/pouch.git","ssh_url":"git@github.com:Starnop/pouch.git","clone_url":"https://github.com/Starnop/pouch.git","svn_url":"https://github.com/Starnop/pouch","homepage":"","size":11762,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"3f0c62f324c0fbcd4a648f561973bb9a4334847e","user":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NTU5NjU=","name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"PouchContainer is an open-source project created to promote the container technology movement.","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-06-14T04:14:54Z","pushed_at":"2018-06-14T04:28:31Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"","size":11639,"stargazers_count":2711,"watchers_count":2711,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":494,"open_issues":142,"watchers":2711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1511"},"html":{"href":"https://github.com/alibaba/pouch/pull/1511"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1511"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1511/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1511/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1511/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/985234c6d7c753cc6cda33ce446118f67d68840b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"allencloud","id":9465626,"node_id":"MDQ6VXNlcjk0NjU2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9465626?v=4","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"comments":3,"review_comments":9,"maintainer_can_modify":false,"commits":1,"additions":64,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"allencloud"}}