{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/comments/237828210","pull_request_review_id":180223666,"id":237828210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgyODIxMA==","diff_hunk":"@@ -0,0 +1,28 @@\n+resource \"aws_s3_bucket\" \"jenkins_logs_bucket\" {\n+  bucket        = \"${var.name}-${var.dns_name}-logs-bucket\"\n+  force_destroy = true\n+\n+  policy = <<POLICY\n+{\n+    \"Version\": \"2012-10-17\",","path":"terraform/modules/jenkins/s3_bucket.tf","position":7,"original_position":7,"commit_id":"17b8f45983ffec4223b92c085abff6851c93b41f","original_commit_id":"17b8f45983ffec4223b92c085abff6851c93b41f","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"body":"Reading The Fine Documentation reveals that if we don't specify a version, we lose out on newer features... 🤷‍♀️ ","created_at":"2018-11-30T11:21:48Z","updated_at":"2018-11-30T11:21:48Z","html_url":"https://github.com/alphagov/digitalmarketplace-aws/pull/474#discussion_r237828210","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/comments/237828210"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-aws/pull/474#discussion_r237828210"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474"}},"in_reply_to_id":237827550},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474","id":234950557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTUwNTU3","html_url":"https://github.com/alphagov/digitalmarketplace-aws/pull/474","diff_url":"https://github.com/alphagov/digitalmarketplace-aws/pull/474.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-aws/pull/474.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/474","number":474,"state":"open","locked":false,"title":"Enable access logging on Jenkins load balancers","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"body":"We want to be able to audit who is accessing our Jenkins build server, and when.\n\nThis PR enables access logging on the Elastic Load Balancer that sits in front of our Jenkins box; this means that all SSH and HTTPS access will be logged.\n\nThe logs are stored hourly in an S3 bucket, in a compressed format.\n\nFor more details on how this works, see the [Trello ticket][ticket].\n\nThe Terraform for these changes have already been tested and applied, and the logging is now taking place.\n\n[ticket]: https://trello.com/c/S7iFoAU8/253-configure-jenkins-box-ssh-access-logging","created_at":"2018-11-30T11:03:34Z","updated_at":"2018-11-30T11:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47985bc258f59ec5d4fbfea0b9b85299d47bfae4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/474/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/statuses/17b8f45983ffec4223b92c085abff6851c93b41f","head":{"label":"alphagov:ldeb-add-jenkins-elb-access-logging","ref":"ldeb-add-jenkins-elb-access-logging","sha":"17b8f45983ffec4223b92c085abff6851c93b41f","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31316356,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMxNjM1Ng==","name":"digitalmarketplace-aws","full_name":"alphagov/digitalmarketplace-aws","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/digitalmarketplace-aws","description":"Infrastructure for the Digital Marketplace service","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/deployments","created_at":"2015-02-25T14:07:07Z","updated_at":"2018-11-29T13:23:04Z","pushed_at":"2018-11-30T11:04:12Z","git_url":"git://github.com/alphagov/digitalmarketplace-aws.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-aws.git","clone_url":"https://github.com/alphagov/digitalmarketplace-aws.git","svn_url":"https://github.com/alphagov/digitalmarketplace-aws","homepage":"","size":1125,"stargazers_count":8,"watchers_count":8,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"2fecfe7aec713592fe2a12deef9c3995f2f0b20f","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31316356,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMxNjM1Ng==","name":"digitalmarketplace-aws","full_name":"alphagov/digitalmarketplace-aws","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/digitalmarketplace-aws","description":"Infrastructure for the Digital Marketplace service","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/deployments","created_at":"2015-02-25T14:07:07Z","updated_at":"2018-11-29T13:23:04Z","pushed_at":"2018-11-30T11:04:12Z","git_url":"git://github.com/alphagov/digitalmarketplace-aws.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-aws.git","clone_url":"https://github.com/alphagov/digitalmarketplace-aws.git","svn_url":"https://github.com/alphagov/digitalmarketplace-aws","homepage":"","size":1125,"stargazers_count":8,"watchers_count":8,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-aws/pull/474"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/474"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-aws/statuses/17b8f45983ffec4223b92c085abff6851c93b41f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lfdebrux"}}