{"action":"closed","number":1691,"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1691","id":197654781,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjU0Nzgx","html_url":"https://github.com/shopware/shopware/pull/1691","diff_url":"https://github.com/shopware/shopware/pull/1691.diff","patch_url":"https://github.com/shopware/shopware/pull/1691.patch","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1691","number":1691,"state":"closed","locked":false,"title":"account orders unrelated to showEsd setting","user":{"login":"dneustadt","id":9033214,"node_id":"MDQ6VXNlcjkwMzMyMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9033214?v=4","gravatar_id":"","url":"https://api.github.com/users/dneustadt","html_url":"https://github.com/dneustadt","followers_url":"https://api.github.com/users/dneustadt/followers","following_url":"https://api.github.com/users/dneustadt/following{/other_user}","gists_url":"https://api.github.com/users/dneustadt/gists{/gist_id}","starred_url":"https://api.github.com/users/dneustadt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneustadt/subscriptions","organizations_url":"https://api.github.com/users/dneustadt/orgs","repos_url":"https://api.github.com/users/dneustadt/repos","events_url":"https://api.github.com/users/dneustadt/events{/privacy}","received_events_url":"https://api.github.com/users/dneustadt/received_events","type":"User","site_admin":false},"body":"sorry, if there already is a pr, just to be sure... \r\n\r\n### 1. Why is this change necessary?\r\n\r\nThe showEsd config setting affects whether or not the link to both, esd downloads AND regular orders\r\nare shown in the account sidebar. Previously it would only affect whether the link to the downloads would be shown in the account sidebar, which is the expected behavior.\r\n\r\n### 2. What does this change do, exactly?\r\n\r\nRemove the condition on showEsd in the template for the account orders menu entry.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n\r\nEnable showEsd, try to access previous orders in storefront account.\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them.","created_at":"2018-06-27T08:33:10Z","updated_at":"2018-07-04T06:19:32Z","closed_at":"2018-07-04T06:19:32Z","merged_at":null,"merge_commit_sha":"e5b6d6a627857394ea925656c4d89af2561d328e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":288945008,"node_id":"MDU6TGFiZWwyODg5NDUwMDg=","url":"https://api.github.com/repos/shopware/shopware/labels/Quick-Pick","name":"Quick-Pick","color":"0052cc","default":false},{"id":318046718,"node_id":"MDU6TGFiZWwzMTgwNDY3MTg=","url":"https://api.github.com/repos/shopware/shopware/labels/Scheduled","name":"Scheduled","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/shopware/pulls/1691/commits","review_comments_url":"https://api.github.com/repos/shopware/shopware/pulls/1691/comments","review_comment_url":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1691/comments","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/9470a0b600f20c7108e0b89d99f850784b3a25e9","head":{"label":"dneustadt:patch-2","ref":"patch-2","sha":"9470a0b600f20c7108e0b89d99f850784b3a25e9","user":{"login":"dneustadt","id":9033214,"node_id":"MDQ6VXNlcjkwMzMyMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9033214?v=4","gravatar_id":"","url":"https://api.github.com/users/dneustadt","html_url":"https://github.com/dneustadt","followers_url":"https://api.github.com/users/dneustadt/followers","following_url":"https://api.github.com/users/dneustadt/following{/other_user}","gists_url":"https://api.github.com/users/dneustadt/gists{/gist_id}","starred_url":"https://api.github.com/users/dneustadt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneustadt/subscriptions","organizations_url":"https://api.github.com/users/dneustadt/orgs","repos_url":"https://api.github.com/users/dneustadt/repos","events_url":"https://api.github.com/users/dneustadt/events{/privacy}","received_events_url":"https://api.github.com/users/dneustadt/received_events","type":"User","site_admin":false},"repo":{"id":67612773,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYxMjc3Mw==","name":"shopware","full_name":"dneustadt/shopware","owner":{"login":"dneustadt","id":9033214,"node_id":"MDQ6VXNlcjkwMzMyMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9033214?v=4","gravatar_id":"","url":"https://api.github.com/users/dneustadt","html_url":"https://github.com/dneustadt","followers_url":"https://api.github.com/users/dneustadt/followers","following_url":"https://api.github.com/users/dneustadt/following{/other_user}","gists_url":"https://api.github.com/users/dneustadt/gists{/gist_id}","starred_url":"https://api.github.com/users/dneustadt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneustadt/subscriptions","organizations_url":"https://api.github.com/users/dneustadt/orgs","repos_url":"https://api.github.com/users/dneustadt/repos","events_url":"https://api.github.com/users/dneustadt/events{/privacy}","received_events_url":"https://api.github.com/users/dneustadt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dneustadt/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/dneustadt/shopware","forks_url":"https://api.github.com/repos/dneustadt/shopware/forks","keys_url":"https://api.github.com/repos/dneustadt/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneustadt/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneustadt/shopware/teams","hooks_url":"https://api.github.com/repos/dneustadt/shopware/hooks","issue_events_url":"https://api.github.com/repos/dneustadt/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/dneustadt/shopware/events","assignees_url":"https://api.github.com/repos/dneustadt/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/dneustadt/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/dneustadt/shopware/tags","blobs_url":"https://api.github.com/repos/dneustadt/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneustadt/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneustadt/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneustadt/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneustadt/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/dneustadt/shopware/languages","stargazers_url":"https://api.github.com/repos/dneustadt/shopware/stargazers","contributors_url":"https://api.github.com/repos/dneustadt/shopware/contributors","subscribers_url":"https://api.github.com/repos/dneustadt/shopware/subscribers","subscription_url":"https://api.github.com/repos/dneustadt/shopware/subscription","commits_url":"https://api.github.com/repos/dneustadt/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneustadt/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneustadt/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneustadt/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneustadt/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/dneustadt/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneustadt/shopware/merges","archive_url":"https://api.github.com/repos/dneustadt/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneustadt/shopware/downloads","issues_url":"https://api.github.com/repos/dneustadt/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/dneustadt/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/dneustadt/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/dneustadt/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneustadt/shopware/labels{/name}","releases_url":"https://api.github.com/repos/dneustadt/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/dneustadt/shopware/deployments","created_at":"2016-09-07T14:12:07Z","updated_at":"2018-03-17T15:31:44Z","pushed_at":"2018-06-27T08:25:22Z","git_url":"git://github.com/dneustadt/shopware.git","ssh_url":"git@github.com:dneustadt/shopware.git","clone_url":"https://github.com/dneustadt/shopware.git","svn_url":"https://github.com/dneustadt/shopware","homepage":"http://www.shopware.com","size":180868,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.3"}},"base":{"label":"shopware:5.4","ref":"5.4","sha":"aac0e5c964ac58b33cb95a6583285df2042d2ade","user":{"login":"shopware","id":612628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjYyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":5682970,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgyOTcw","name":"shopware","full_name":"shopware/shopware","owner":{"login":"shopware","id":612628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjYyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/shopware","description":"Shopware Repository","fork":false,"url":"https://api.github.com/repos/shopware/shopware","forks_url":"https://api.github.com/repos/shopware/shopware/forks","keys_url":"https://api.github.com/repos/shopware/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/shopware/teams","hooks_url":"https://api.github.com/repos/shopware/shopware/hooks","issue_events_url":"https://api.github.com/repos/shopware/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/shopware/events","assignees_url":"https://api.github.com/repos/shopware/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/shopware/tags","blobs_url":"https://api.github.com/repos/shopware/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/shopware/languages","stargazers_url":"https://api.github.com/repos/shopware/shopware/stargazers","contributors_url":"https://api.github.com/repos/shopware/shopware/contributors","subscribers_url":"https://api.github.com/repos/shopware/shopware/subscribers","subscription_url":"https://api.github.com/repos/shopware/shopware/subscription","commits_url":"https://api.github.com/repos/shopware/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/shopware/merges","archive_url":"https://api.github.com/repos/shopware/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/shopware/downloads","issues_url":"https://api.github.com/repos/shopware/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopware/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/shopware/deployments","created_at":"2012-09-05T05:32:50Z","updated_at":"2018-07-04T06:01:17Z","pushed_at":"2018-07-04T06:19:18Z","git_url":"git://github.com/shopware/shopware.git","ssh_url":"git@github.com:shopware/shopware.git","clone_url":"https://github.com/shopware/shopware.git","svn_url":"https://github.com/shopware/shopware","homepage":"http://www.shopware.com","size":214181,"stargazers_count":869,"watchers_count":869,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":624,"mirror_url":null,"archived":false,"open_issues_count":229,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":624,"open_issues":229,"watchers":869,"default_branch":"5.4"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1691"},"html":{"href":"https://github.com/shopware/shopware/pull/1691"},"issue":{"href":"https://api.github.com/repos/shopware/shopware/issues/1691"},"comments":{"href":"https://api.github.com/repos/shopware/shopware/issues/1691/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1691/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/shopware/pulls/1691/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/shopware/statuses/9470a0b600f20c7108e0b89d99f850784b3a25e9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"shopwareBot"}}