{"action":"closed","number":674,"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/674","id":232964228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTY0MjI4","html_url":"https://github.com/kiali/kiali/pull/674","diff_url":"https://github.com/kiali/kiali/pull/674.diff","patch_url":"https://github.com/kiali/kiali/pull/674.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/674","number":674,"state":"closed","locked":false,"title":"KIALI-1984 Refactor Kiali model to include metadata/spec in Istio config","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"** Describe the change **\r\n\r\nIstio Objects mapped in Kiali that will be editable need to bring explicit metadata/spec fields.\r\n\r\n** Issue reference **\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1984\r\n\r\n** Backwards incompatible? **\r\n\r\nYes, this requires changes in e2e test and also a PR in the UI to map the changes.\r\n\r\n","created_at":"2018-11-22T12:33:46Z","updated_at":"2018-11-27T15:49:15Z","closed_at":"2018-11-27T15:49:14Z","merged_at":"2018-11-27T15:49:14Z","merge_commit_sha":"ea620d0a9ed5be262f3db24f6e69dc2350906ffe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1032879058,"node_id":"MDU6TGFiZWwxMDMyODc5MDU4","url":"https://api.github.com/repos/kiali/kiali/labels/UI%20changes%20required","name":"UI changes required","color":"7c68c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/674/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/674/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/674/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/b358acf9bf57ed911d475ba4ef192aa5d7783943","head":{"label":"lucasponce:refactor-istio-object","ref":"refactor-istio-object","sha":"b358acf9bf57ed911d475ba4ef192aa5d7783943","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":120277582,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzc1ODI=","name":"kiali","full_name":"lucasponce/kiali","private":false,"owner":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lucasponce/kiali","description":null,"fork":true,"url":"https://api.github.com/repos/lucasponce/kiali","forks_url":"https://api.github.com/repos/lucasponce/kiali/forks","keys_url":"https://api.github.com/repos/lucasponce/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/kiali/teams","hooks_url":"https://api.github.com/repos/lucasponce/kiali/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/kiali/events","assignees_url":"https://api.github.com/repos/lucasponce/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/kiali/tags","blobs_url":"https://api.github.com/repos/lucasponce/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/kiali/languages","stargazers_url":"https://api.github.com/repos/lucasponce/kiali/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/kiali/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/kiali/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/kiali/subscription","commits_url":"https://api.github.com/repos/lucasponce/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/kiali/merges","archive_url":"https://api.github.com/repos/lucasponce/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/kiali/downloads","issues_url":"https://api.github.com/repos/lucasponce/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/kiali/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/lucasponce/kiali/deployments","created_at":"2018-02-05T08:42:11Z","updated_at":"2018-11-27T08:01:22Z","pushed_at":"2018-11-27T08:01:20Z","git_url":"git://github.com/lucasponce/kiali.git","ssh_url":"git@github.com:lucasponce/kiali.git","clone_url":"https://github.com/lucasponce/kiali.git","svn_url":"https://github.com/lucasponce/kiali","homepage":null,"size":16391,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"f76f6f0dfb87d77594b572a0ddf5324b73306ddd","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-11-27T14:51:48Z","pushed_at":"2018-11-27T15:49:14Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://www.kiali.io","size":16343,"stargazers_count":532,"watchers_count":532,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":32,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/674"},"html":{"href":"https://github.com/kiali/kiali/pull/674"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/674"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/b358acf9bf57ed911d475ba4ef192aa5d7783943"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":619,"deletions":481,"changed_files":12}}
{"actor":{"display_login":"xeviknal"}}