{"action":"closed","number":514,"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/514","id":200835556,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODM1NTU2","html_url":"https://github.com/kiali/kiali-ui/pull/514","diff_url":"https://github.com/kiali/kiali-ui/pull/514.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/514.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/514","number":514,"state":"closed","locked":false,"title":"KIALI-1058 Present an error view if the CytoscapeGraph fails","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":"This won't block the controls, allowing the user to select a different layout if needed\r\n\r\nBonus:\r\nSimplified the refit operation and this maybe fixed the \"all nodes appearing on top of each other\".\r\nIt was a mix of [KIALI-1166](https://issues.jboss.org/browse/KIALI-1166) and the graph not doing an updateLayout as the first operation (only doing the refit)\r\n\r\n![kiali-1058](https://user-images.githubusercontent.com/3845764/42601222-88eb865c-852a-11e8-8132-328edf99422d.png)\r\n","created_at":"2018-07-11T21:50:59Z","updated_at":"2018-07-16T18:28:38Z","closed_at":"2018-07-16T18:28:38Z","merged_at":null,"merge_commit_sha":"bc26d91d8a4eadb7bcac6d5f271f76f8f0f76821","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/514/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/514/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/514/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/e0be8e17e4a8ce5c9ae8aadf99ce5ba79f00c86f","head":{"label":"josejulio:jira/KIALI-1058","ref":"jira/KIALI-1058","sha":"e0be8e17e4a8ce5c9ae8aadf99ce5ba79f00c86f","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"repo":{"id":122094098,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwOTQwOTg=","name":"swsui","full_name":"josejulio/swsui","owner":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josejulio/swsui","description":null,"fork":true,"url":"https://api.github.com/repos/josejulio/swsui","forks_url":"https://api.github.com/repos/josejulio/swsui/forks","keys_url":"https://api.github.com/repos/josejulio/swsui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josejulio/swsui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josejulio/swsui/teams","hooks_url":"https://api.github.com/repos/josejulio/swsui/hooks","issue_events_url":"https://api.github.com/repos/josejulio/swsui/issues/events{/number}","events_url":"https://api.github.com/repos/josejulio/swsui/events","assignees_url":"https://api.github.com/repos/josejulio/swsui/assignees{/user}","branches_url":"https://api.github.com/repos/josejulio/swsui/branches{/branch}","tags_url":"https://api.github.com/repos/josejulio/swsui/tags","blobs_url":"https://api.github.com/repos/josejulio/swsui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josejulio/swsui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josejulio/swsui/git/refs{/sha}","trees_url":"https://api.github.com/repos/josejulio/swsui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josejulio/swsui/statuses/{sha}","languages_url":"https://api.github.com/repos/josejulio/swsui/languages","stargazers_url":"https://api.github.com/repos/josejulio/swsui/stargazers","contributors_url":"https://api.github.com/repos/josejulio/swsui/contributors","subscribers_url":"https://api.github.com/repos/josejulio/swsui/subscribers","subscription_url":"https://api.github.com/repos/josejulio/swsui/subscription","commits_url":"https://api.github.com/repos/josejulio/swsui/commits{/sha}","git_commits_url":"https://api.github.com/repos/josejulio/swsui/git/commits{/sha}","comments_url":"https://api.github.com/repos/josejulio/swsui/comments{/number}","issue_comment_url":"https://api.github.com/repos/josejulio/swsui/issues/comments{/number}","contents_url":"https://api.github.com/repos/josejulio/swsui/contents/{+path}","compare_url":"https://api.github.com/repos/josejulio/swsui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josejulio/swsui/merges","archive_url":"https://api.github.com/repos/josejulio/swsui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josejulio/swsui/downloads","issues_url":"https://api.github.com/repos/josejulio/swsui/issues{/number}","pulls_url":"https://api.github.com/repos/josejulio/swsui/pulls{/number}","milestones_url":"https://api.github.com/repos/josejulio/swsui/milestones{/number}","notifications_url":"https://api.github.com/repos/josejulio/swsui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josejulio/swsui/labels{/name}","releases_url":"https://api.github.com/repos/josejulio/swsui/releases{/id}","deployments_url":"https://api.github.com/repos/josejulio/swsui/deployments","created_at":"2018-02-19T17:04:46Z","updated_at":"2018-07-16T14:26:35Z","pushed_at":"2018-07-16T17:01:35Z","git_url":"git://github.com/josejulio/swsui.git","ssh_url":"git@github.com:josejulio/swsui.git","clone_url":"https://github.com/josejulio/swsui.git","svn_url":"https://github.com/josejulio/swsui","homepage":null,"size":2350,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"83aa48c2d87b60fbc07e486fb81078da76616d85","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDgyNjQ=","name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali (use kiali/kial to report issues)","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-07-16T18:27:27Z","pushed_at":"2018-07-16T18:27:24Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"https://kiali.org/","size":2341,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":2,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/514"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/514"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/514"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/e0be8e17e4a8ce5c9ae8aadf99ce5ba79f00c86f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":94,"deletions":33,"changed_files":6}}
{"actor":{"display_login":"mwringe"}}