{"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28","id":175746851,"html_url":"https://github.com/HotCL/P4-HCL/pull/28","diff_url":"https://github.com/HotCL/P4-HCL/pull/28.diff","patch_url":"https://github.com/HotCL/P4-HCL/pull/28.patch","issue_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/28","number":28,"state":"open","locked":false,"title":"Hcl 37: added class diagrams and decisions for lexer","user":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"body":"### Description\r\nAdded class diagram as a PNG for the tokens, as well as a txt document with the thoughts and decisions (basically notes) for creating the lexer, to misc. as well as some simple sample code for the design of the lexer.\r\n\r\n\r\n### Changelog\r\n - added image to misc\r\n - added notes regarding design of lexer and parts of the parser\r\n\r\n### Issues solved \r\n - HCLANG-37\r\n\r\n## FOR REVIEWER [Do not remove]\r\nA small checklist of things to note when you are doing a review. Make sure these things apply before going into master.\r\n - Did the PR actually fix the issue\r\n - Comment anything that doesn't make sense or anything you want clarified. Many comments are always ok\r\n - Make sure this is ready for exams if this is going into master\r\n - It's always a good idea having another reviewer look at a PR as well, if it's major. get a buddy.\r\n\r\n### Regarding filenames\r\n- all .tex files use pascal case\r\n- all other files [except in /code/] use snake case\r\n\r\n\r\n### Regarding code [if applicable]\r\n- Check [coding conventions](https://kotlinlang.org/docs/reference/coding-conventions.html)\r\n- Are public methods documented? \r\n- Are there testcases for new features / methods?\r\n- Have you tried running the source and tested things that cannot be test-cased?\r\n\r\n### Regarding Report [if applicable]\r\n- Does each line have a linechange in the sourcecode?\r\n- Does sentences make sense?\r\n- Did you do spellchecking?\r\n- Citations?\r\n","created_at":"2018-03-18T11:42:15Z","updated_at":"2018-03-18T11:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28/commits","review_comments_url":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28/comments","review_comment_url":"https://api.github.com/repos/HotCL/P4-HCL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/28/comments","statuses_url":"https://api.github.com/repos/HotCL/P4-HCL/statuses/ab749fce707282c883e2fcf9a9c1e59eacc04f4b","head":{"label":"HotCL:HCL-37","ref":"HCL-37","sha":"ab749fce707282c883e2fcf9a9c1e59eacc04f4b","user":{"login":"HotCL","id":36265232,"avatar_url":"https://avatars3.githubusercontent.com/u/36265232?v=4","gravatar_id":"","url":"https://api.github.com/users/HotCL","html_url":"https://github.com/HotCL","followers_url":"https://api.github.com/users/HotCL/followers","following_url":"https://api.github.com/users/HotCL/following{/other_user}","gists_url":"https://api.github.com/users/HotCL/gists{/gist_id}","starred_url":"https://api.github.com/users/HotCL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotCL/subscriptions","organizations_url":"https://api.github.com/users/HotCL/orgs","repos_url":"https://api.github.com/users/HotCL/repos","events_url":"https://api.github.com/users/HotCL/events{/privacy}","received_events_url":"https://api.github.com/users/HotCL/received_events","type":"Organization","site_admin":false},"repo":{"id":120297748,"name":"P4-HCL","full_name":"HotCL/P4-HCL","owner":{"login":"HotCL","id":36265232,"avatar_url":"https://avatars3.githubusercontent.com/u/36265232?v=4","gravatar_id":"","url":"https://api.github.com/users/HotCL","html_url":"https://github.com/HotCL","followers_url":"https://api.github.com/users/HotCL/followers","following_url":"https://api.github.com/users/HotCL/following{/other_user}","gists_url":"https://api.github.com/users/HotCL/gists{/gist_id}","starred_url":"https://api.github.com/users/HotCL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotCL/subscriptions","organizations_url":"https://api.github.com/users/HotCL/orgs","repos_url":"https://api.github.com/users/HotCL/repos","events_url":"https://api.github.com/users/HotCL/events{/privacy}","received_events_url":"https://api.github.com/users/HotCL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HotCL/P4-HCL","description":"P4 project on university: HCL Compiled Language.","fork":false,"url":"https://api.github.com/repos/HotCL/P4-HCL","forks_url":"https://api.github.com/repos/HotCL/P4-HCL/forks","keys_url":"https://api.github.com/repos/HotCL/P4-HCL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotCL/P4-HCL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotCL/P4-HCL/teams","hooks_url":"https://api.github.com/repos/HotCL/P4-HCL/hooks","issue_events_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/events{/number}","events_url":"https://api.github.com/repos/HotCL/P4-HCL/events","assignees_url":"https://api.github.com/repos/HotCL/P4-HCL/assignees{/user}","branches_url":"https://api.github.com/repos/HotCL/P4-HCL/branches{/branch}","tags_url":"https://api.github.com/repos/HotCL/P4-HCL/tags","blobs_url":"https://api.github.com/repos/HotCL/P4-HCL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotCL/P4-HCL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotCL/P4-HCL/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotCL/P4-HCL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotCL/P4-HCL/statuses/{sha}","languages_url":"https://api.github.com/repos/HotCL/P4-HCL/languages","stargazers_url":"https://api.github.com/repos/HotCL/P4-HCL/stargazers","contributors_url":"https://api.github.com/repos/HotCL/P4-HCL/contributors","subscribers_url":"https://api.github.com/repos/HotCL/P4-HCL/subscribers","subscription_url":"https://api.github.com/repos/HotCL/P4-HCL/subscription","commits_url":"https://api.github.com/repos/HotCL/P4-HCL/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotCL/P4-HCL/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotCL/P4-HCL/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotCL/P4-HCL/contents/{+path}","compare_url":"https://api.github.com/repos/HotCL/P4-HCL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotCL/P4-HCL/merges","archive_url":"https://api.github.com/repos/HotCL/P4-HCL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotCL/P4-HCL/downloads","issues_url":"https://api.github.com/repos/HotCL/P4-HCL/issues{/number}","pulls_url":"https://api.github.com/repos/HotCL/P4-HCL/pulls{/number}","milestones_url":"https://api.github.com/repos/HotCL/P4-HCL/milestones{/number}","notifications_url":"https://api.github.com/repos/HotCL/P4-HCL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotCL/P4-HCL/labels{/name}","releases_url":"https://api.github.com/repos/HotCL/P4-HCL/releases{/id}","deployments_url":"https://api.github.com/repos/HotCL/P4-HCL/deployments","created_at":"2018-02-05T11:46:59Z","updated_at":"2018-02-17T07:27:23Z","pushed_at":"2018-03-18T11:38:06Z","git_url":"git://github.com/HotCL/P4-HCL.git","ssh_url":"git@github.com:HotCL/P4-HCL.git","clone_url":"https://github.com/HotCL/P4-HCL.git","svn_url":"https://github.com/HotCL/P4-HCL","homepage":"http://hcl.codes","size":1440,"stargazers_count":2,"watchers_count":2,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"HotCL:develop","ref":"develop","sha":"e039da429c6fe04db58cc53a13c742da01a56429","user":{"login":"HotCL","id":36265232,"avatar_url":"https://avatars3.githubusercontent.com/u/36265232?v=4","gravatar_id":"","url":"https://api.github.com/users/HotCL","html_url":"https://github.com/HotCL","followers_url":"https://api.github.com/users/HotCL/followers","following_url":"https://api.github.com/users/HotCL/following{/other_user}","gists_url":"https://api.github.com/users/HotCL/gists{/gist_id}","starred_url":"https://api.github.com/users/HotCL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotCL/subscriptions","organizations_url":"https://api.github.com/users/HotCL/orgs","repos_url":"https://api.github.com/users/HotCL/repos","events_url":"https://api.github.com/users/HotCL/events{/privacy}","received_events_url":"https://api.github.com/users/HotCL/received_events","type":"Organization","site_admin":false},"repo":{"id":120297748,"name":"P4-HCL","full_name":"HotCL/P4-HCL","owner":{"login":"HotCL","id":36265232,"avatar_url":"https://avatars3.githubusercontent.com/u/36265232?v=4","gravatar_id":"","url":"https://api.github.com/users/HotCL","html_url":"https://github.com/HotCL","followers_url":"https://api.github.com/users/HotCL/followers","following_url":"https://api.github.com/users/HotCL/following{/other_user}","gists_url":"https://api.github.com/users/HotCL/gists{/gist_id}","starred_url":"https://api.github.com/users/HotCL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotCL/subscriptions","organizations_url":"https://api.github.com/users/HotCL/orgs","repos_url":"https://api.github.com/users/HotCL/repos","events_url":"https://api.github.com/users/HotCL/events{/privacy}","received_events_url":"https://api.github.com/users/HotCL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HotCL/P4-HCL","description":"P4 project on university: HCL Compiled Language.","fork":false,"url":"https://api.github.com/repos/HotCL/P4-HCL","forks_url":"https://api.github.com/repos/HotCL/P4-HCL/forks","keys_url":"https://api.github.com/repos/HotCL/P4-HCL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotCL/P4-HCL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotCL/P4-HCL/teams","hooks_url":"https://api.github.com/repos/HotCL/P4-HCL/hooks","issue_events_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/events{/number}","events_url":"https://api.github.com/repos/HotCL/P4-HCL/events","assignees_url":"https://api.github.com/repos/HotCL/P4-HCL/assignees{/user}","branches_url":"https://api.github.com/repos/HotCL/P4-HCL/branches{/branch}","tags_url":"https://api.github.com/repos/HotCL/P4-HCL/tags","blobs_url":"https://api.github.com/repos/HotCL/P4-HCL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotCL/P4-HCL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotCL/P4-HCL/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotCL/P4-HCL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotCL/P4-HCL/statuses/{sha}","languages_url":"https://api.github.com/repos/HotCL/P4-HCL/languages","stargazers_url":"https://api.github.com/repos/HotCL/P4-HCL/stargazers","contributors_url":"https://api.github.com/repos/HotCL/P4-HCL/contributors","subscribers_url":"https://api.github.com/repos/HotCL/P4-HCL/subscribers","subscription_url":"https://api.github.com/repos/HotCL/P4-HCL/subscription","commits_url":"https://api.github.com/repos/HotCL/P4-HCL/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotCL/P4-HCL/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotCL/P4-HCL/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotCL/P4-HCL/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotCL/P4-HCL/contents/{+path}","compare_url":"https://api.github.com/repos/HotCL/P4-HCL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotCL/P4-HCL/merges","archive_url":"https://api.github.com/repos/HotCL/P4-HCL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotCL/P4-HCL/downloads","issues_url":"https://api.github.com/repos/HotCL/P4-HCL/issues{/number}","pulls_url":"https://api.github.com/repos/HotCL/P4-HCL/pulls{/number}","milestones_url":"https://api.github.com/repos/HotCL/P4-HCL/milestones{/number}","notifications_url":"https://api.github.com/repos/HotCL/P4-HCL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotCL/P4-HCL/labels{/name}","releases_url":"https://api.github.com/repos/HotCL/P4-HCL/releases{/id}","deployments_url":"https://api.github.com/repos/HotCL/P4-HCL/deployments","created_at":"2018-02-05T11:46:59Z","updated_at":"2018-02-17T07:27:23Z","pushed_at":"2018-03-18T11:38:06Z","git_url":"git://github.com/HotCL/P4-HCL.git","ssh_url":"git@github.com:HotCL/P4-HCL.git","clone_url":"https://github.com/HotCL/P4-HCL.git","svn_url":"https://github.com/HotCL/P4-HCL","homepage":"http://hcl.codes","size":1440,"stargazers_count":2,"watchers_count":2,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28"},"html":{"href":"https://github.com/HotCL/P4-HCL/pull/28"},"issue":{"href":"https://api.github.com/repos/HotCL/P4-HCL/issues/28"},"comments":{"href":"https://api.github.com/repos/HotCL/P4-HCL/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/HotCL/P4-HCL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HotCL/P4-HCL/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/HotCL/P4-HCL/statuses/ab749fce707282c883e2fcf9a9c1e59eacc04f4b"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":301,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"C0DK"}}