{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/comments/219979198","pull_request_review_id":158283188,"id":219979198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk3OTE5OA==","diff_hunk":"@@ -12,18 +12,20 @@ public interface IRateLimiting\n         long GetPauseForNextTwinWrite();\n         long GetPauseForNextMessage();\n         double GetThroughputForMessages();\n+        Models.Simulation.SimulationRateLimits GetRateLimits();","path":"Services/Concurrency/RateLimiting.cs","position":4,"original_position":4,"commit_id":"38ccdc2c5cf6315872283003c85e0d798cdeb720","original_commit_id":"38ccdc2c5cf6315872283003c85e0d798cdeb720","user":{"login":"avanikp","id":32693971,"node_id":"MDQ6VXNlcjMyNjkzOTcx","avatar_url":"https://avatars1.githubusercontent.com/u/32693971?v=4","gravatar_id":"","url":"https://api.github.com/users/avanikp","html_url":"https://github.com/avanikp","followers_url":"https://api.github.com/users/avanikp/followers","following_url":"https://api.github.com/users/avanikp/following{/other_user}","gists_url":"https://api.github.com/users/avanikp/gists{/gist_id}","starred_url":"https://api.github.com/users/avanikp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avanikp/subscriptions","organizations_url":"https://api.github.com/users/avanikp/orgs","repos_url":"https://api.github.com/users/avanikp/repos","events_url":"https://api.github.com/users/avanikp/events{/privacy}","received_events_url":"https://api.github.com/users/avanikp/received_events","type":"User","site_admin":false},"body":"nit: remove Models.Simulation.","created_at":"2018-09-24T20:33:48Z","updated_at":"2018-09-24T20:56:28Z","html_url":"https://github.com/Azure/device-simulation-dotnet/pull/259#discussion_r219979198","pull_request_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/comments/219979198"},"html":{"href":"https://github.com/Azure/device-simulation-dotnet/pull/259#discussion_r219979198"},"pull_request":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259","id":217113503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTEzNTAz","html_url":"https://github.com/Azure/device-simulation-dotnet/pull/259","diff_url":"https://github.com/Azure/device-simulation-dotnet/pull/259.diff","patch_url":"https://github.com/Azure/device-simulation-dotnet/pull/259.patch","issue_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/259","number":259,"state":"open","locked":false,"title":"Updates for exposing throttling setting to user for changes","user":{"login":"hathind-ms","id":39630244,"node_id":"MDQ6VXNlcjM5NjMwMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/39630244?v=4","gravatar_id":"","url":"https://api.github.com/users/hathind-ms","html_url":"https://github.com/hathind-ms","followers_url":"https://api.github.com/users/hathind-ms/followers","following_url":"https://api.github.com/users/hathind-ms/following{/other_user}","gists_url":"https://api.github.com/users/hathind-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/hathind-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hathind-ms/subscriptions","organizations_url":"https://api.github.com/users/hathind-ms/orgs","repos_url":"https://api.github.com/users/hathind-ms/repos","events_url":"https://api.github.com/users/hathind-ms/events{/privacy}","received_events_url":"https://api.github.com/users/hathind-ms/received_events","type":"User","site_admin":false},"body":"# Description and Motivation <!-- Info & Context so we can review your pull request -->\r\nWe would use default settings from appsettings if the user doesn't provide these values.\r\n+ Adding bug fix around ETag, property was not set in response\r\n\r\nAPI schema: \r\n\r\n```json\r\n{\r\n    \"ETag\": \"\\\"0300c13b-0000-0000-0000-5ba2b98b0000\\\"\",\r\n    \"Id\": \"8be03642-be6a-48fc-9dd1-3332c3a60ce6\",\r\n    \"Name\": \"Test Simulation - I\",\r\n    \"Description\": \"\",\r\n    \"Enabled\": false,\r\n    \"Running\": false,\r\n    \"IoTHubs\": [\r\n        {\r\n            \"ConnectionString\": \"default\",\r\n            \"PreprovisionedIoTHubInUse\": false,\r\n            \"PreprovisionedIoTHubMetricsUrl\": null\r\n        }\r\n    ],\r\n    \"StartTime\": \"2018-10-30T19:19:02+00:00\",\r\n    \"EndTime\": \"2018-10-30T19:22:48+00:00\",\r\n    \"StoppedTime\": \"\",\r\n    \"DeviceModels\": [\r\n        {\r\n            \"Id\": \"chiller-01\",\r\n            \"Count\": 10,\r\n            \"Override\": {\r\n                \"Simulation\": {\r\n                    \"Interval\": \"00:00:10\"\r\n                },\r\n                \"Telemetry\": [\r\n                    {\r\n                        \"Interval\": \"00:00:10\"\r\n                    }\r\n                ]\r\n            }\r\n        }\r\n    ],\r\n    \"Statistics\": {\r\n        \"TotalMessagesSent\": 0,\r\n        \"AverageMessagesPerSecond\": 0,\r\n        \"FailedMessagesCount\": 0,\r\n        \"ActiveDevicesCount\": 0,\r\n        \"FailedDeviceConnectionsCount\": 0,\r\n        \"FailedDeviceTwinUpdatesCount\": 0,\r\n        \"SimulationErrorsCount\": 0\r\n    },\r\n    \"RateLimits\": {\r\n        \"ConnectionsPerSecond\": 110,\r\n        \"RegistryOperationsPerMinute\": 100,\r\n        \"TwinReadsPerSecond\": 10,\r\n        \"TwinWritesPerSecond\": 10,\r\n        \"DeviceMessagesPerSecond\": 120\r\n    },\r\n    \"$metadata\": {\r\n        \"$type\": \"Simulation;1\",\r\n        \"$uri\": \"/v1/simulations/8be03642-be6a-48fc-9dd1-3332c3a60ce6\",\r\n        \"$created\": \"2018-09-20T21:16:56+00:00\",\r\n        \"$modified\": \"2018-09-20T21:17:00+00:00\"\r\n    }\r\n}\r\n```\r\n\r\n...\r\n\r\n# Change type <!-- [x] in all the boxes that apply -->\r\n\r\n- [ ] Bug fix\r\n- [ ] New feature\r\n- [x] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [x] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/device-simulation-dotnet/259)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-09-20T21:33:37Z","updated_at":"2018-09-24T20:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"826187533fe1814018fb554aa9bf2d3567d309f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259/commits","review_comments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259/comments","review_comment_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/259/comments","statuses_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/statuses/38ccdc2c5cf6315872283003c85e0d798cdeb720","head":{"label":"Azure:hathind/throttling-settings","ref":"hathind/throttling-settings","sha":"38ccdc2c5cf6315872283003c85e0d798cdeb720","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89741887,"node_id":"MDEwOlJlcG9zaXRvcnk4OTc0MTg4Nw==","name":"device-simulation-dotnet","full_name":"Azure/device-simulation-dotnet","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/device-simulation-dotnet","description":"IoT Simulation service","fork":false,"url":"https://api.github.com/repos/Azure/device-simulation-dotnet","forks_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/deployments","created_at":"2017-04-28T20:20:08Z","updated_at":"2018-09-24T11:09:55Z","pushed_at":"2018-09-24T17:03:08Z","git_url":"git://github.com/Azure/device-simulation-dotnet.git","ssh_url":"git@github.com:Azure/device-simulation-dotnet.git","clone_url":"https://github.com/Azure/device-simulation-dotnet.git","svn_url":"https://github.com/Azure/device-simulation-dotnet","homepage":"","size":1907,"stargazers_count":29,"watchers_count":29,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":79,"watchers":29,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"2abcd73c33200ce7dce4b3fbe9440853ba758142","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89741887,"node_id":"MDEwOlJlcG9zaXRvcnk4OTc0MTg4Nw==","name":"device-simulation-dotnet","full_name":"Azure/device-simulation-dotnet","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/device-simulation-dotnet","description":"IoT Simulation service","fork":false,"url":"https://api.github.com/repos/Azure/device-simulation-dotnet","forks_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/device-simulation-dotnet/deployments","created_at":"2017-04-28T20:20:08Z","updated_at":"2018-09-24T11:09:55Z","pushed_at":"2018-09-24T17:03:08Z","git_url":"git://github.com/Azure/device-simulation-dotnet.git","ssh_url":"git@github.com:Azure/device-simulation-dotnet.git","clone_url":"https://github.com/Azure/device-simulation-dotnet.git","svn_url":"https://github.com/Azure/device-simulation-dotnet","homepage":"","size":1907,"stargazers_count":29,"watchers_count":29,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":79,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259"},"html":{"href":"https://github.com/Azure/device-simulation-dotnet/pull/259"},"issue":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/259"},"comments":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/device-simulation-dotnet/statuses/38ccdc2c5cf6315872283003c85e0d798cdeb720"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"avanikp"}}