{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/hub.js/pulls/comments/200667648","pull_request_review_id":135026869,"id":200667648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDY2NzY0OA==","diff_hunk":"@@ -81,7 +81,11 @@ describe(\"searchAnnotations\", () => {\n         \"begin:https://services.arcgis.com/uCXeTVveQzP4IIcx/arcgis/rest/services/Hub Annotations/FeatureServer/0/query\"\n       );\n       expect(options.method).toBe(\"GET\");","path":"packages/annotations/test/annotations.test.ts","position":3,"original_position":3,"commit_id":"3b33b69beda4f49b70b55420858c91bc2d841b74","original_commit_id":"3b33b69beda4f49b70b55420858c91bc2d841b74","user":{"login":"tomwayson","id":662944,"node_id":"MDQ6VXNlcjY2Mjk0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/662944?v=4","gravatar_id":"","url":"https://api.github.com/users/tomwayson","html_url":"https://github.com/tomwayson","followers_url":"https://api.github.com/users/tomwayson/followers","following_url":"https://api.github.com/users/tomwayson/following{/other_user}","gists_url":"https://api.github.com/users/tomwayson/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwayson/subscriptions","organizations_url":"https://api.github.com/users/tomwayson/orgs","repos_url":"https://api.github.com/users/tomwayson/repos","events_url":"https://api.github.com/users/tomwayson/events{/privacy}","received_events_url":"https://api.github.com/users/tomwayson/received_events","type":"User","site_admin":false},"body":"we should now be able to use spies instead of `fetchMock` here too.","created_at":"2018-07-06T14:19:07Z","updated_at":"2018-07-06T14:21:37Z","html_url":"https://github.com/Esri/hub.js/pull/34#discussion_r200667648","pull_request_url":"https://api.github.com/repos/Esri/hub.js/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/comments/200667648"},"html":{"href":"https://github.com/Esri/hub.js/pull/34#discussion_r200667648"},"pull_request":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/hub.js/pulls/34","id":199093780,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDkzNzgw","html_url":"https://github.com/Esri/hub.js/pull/34","diff_url":"https://github.com/Esri/hub.js/pull/34.diff","patch_url":"https://github.com/Esri/hub.js/pull/34.patch","issue_url":"https://api.github.com/repos/Esri/hub.js/issues/34","number":34,"state":"open","locked":false,"title":"JSON API response signature for query annotation response","user":{"login":"jgravois","id":3011734,"node_id":"MDQ6VXNlcjMwMTE3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3011734?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"body":"@dmfenton @akharris:\r\ncan you two let me know what you think of the proposed signature above?\r\nwould it be more convenient if i opened an issue in hub-indexer?\r\n\r\n```js\r\nsearchAnnotations({ url: `https://services.arcgis.com/bkrWlSKcjUDFDtgw/arcgis/rest/services/Hub%20Annotations/FeatureServer/0` })\r\n\r\n{\r\n  data: [ // features from the hub annotations query response\r\n    {\r\n      attributes: {\r\n        OBJECTID: 1,\r\n        author: \"casey\",\r\n        description: \"this is where the comments go\",\r\n        created_at: 1349395200000,\r\n        dataset_id: \"sgj432\"\r\n        // Shape__Area: 1, \r\n        // Shape__Length: 1\r\n      }\r\n    },\r\n    {\r\n      attributes: {\r\n        OBJECTID: 2,\r\n        author: \"casey\",\r\n        description: \"this is where the comments go\",\r\n        created_at: 1349395200001,\r\n        dataset_id: \"xds466\"\r\n        // Shape__Area: 1, // removed\r\n        // Shape__Length: 1 // removed\r\n      }\r\n    }\r\n  ],\r\n  included: [ // filtered list of metadata associated with users that posted a comment\r\n    {\r\n      id: \"casey\",\r\n      type: \"user\",\r\n      attributes: {\r\n        fullName: \"Casey Jones\",\r\n        firstName: \"Casey\",\r\n        lastName: \"Jones\",\r\n        description: \"Neogeographer and purveyor of personal storytelling.\",\r\n        thumbnail: \"Andrew_Turner_-_DC_Social_Meetup_-_Square.jpg\",\r\n        // etc.\r\n      }\r\n    }\r\n  ],\r\n  /*meta: { // query response without the features\r\n    objectIdFieldName: \"OBJECTID\",\r\n    globalIdFieldName: \"\",\r\n    geometryType: \"esriGeometryPolygon\",\r\n    spatialReference: {\r\n      wkid: 4326,\r\n      latestWkid: 4326\r\n    }\r\n  }*/\r\n}\r\n```","created_at":"2018-07-03T22:01:18Z","updated_at":"2018-07-06T14:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"200998c2ccdc24695f231cc20ba9daff2b11b44e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"akharris","id":5504772,"node_id":"MDQ6VXNlcjU1MDQ3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/5504772?v=4","gravatar_id":"","url":"https://api.github.com/users/akharris","html_url":"https://github.com/akharris","followers_url":"https://api.github.com/users/akharris/followers","following_url":"https://api.github.com/users/akharris/following{/other_user}","gists_url":"https://api.github.com/users/akharris/gists{/gist_id}","starred_url":"https://api.github.com/users/akharris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akharris/subscriptions","organizations_url":"https://api.github.com/users/akharris/orgs","repos_url":"https://api.github.com/users/akharris/repos","events_url":"https://api.github.com/users/akharris/events{/privacy}","received_events_url":"https://api.github.com/users/akharris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/hub.js/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Esri/hub.js/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Esri/hub.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/hub.js/issues/34/comments","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/3b33b69beda4f49b70b55420858c91bc2d841b74","head":{"label":"Esri:json-api","ref":"json-api","sha":"3b33b69beda4f49b70b55420858c91bc2d841b74","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":126880567,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODA1Njc=","name":"hub.js","full_name":"Esri/hub.js","owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/hub.js","description":"JavaScript wrappers for talking to ArcGIS Hub","fork":false,"url":"https://api.github.com/repos/Esri/hub.js","forks_url":"https://api.github.com/repos/Esri/hub.js/forks","keys_url":"https://api.github.com/repos/Esri/hub.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/hub.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/hub.js/teams","hooks_url":"https://api.github.com/repos/Esri/hub.js/hooks","issue_events_url":"https://api.github.com/repos/Esri/hub.js/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/hub.js/events","assignees_url":"https://api.github.com/repos/Esri/hub.js/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/hub.js/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/hub.js/tags","blobs_url":"https://api.github.com/repos/Esri/hub.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/hub.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/hub.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/hub.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/hub.js/languages","stargazers_url":"https://api.github.com/repos/Esri/hub.js/stargazers","contributors_url":"https://api.github.com/repos/Esri/hub.js/contributors","subscribers_url":"https://api.github.com/repos/Esri/hub.js/subscribers","subscription_url":"https://api.github.com/repos/Esri/hub.js/subscription","commits_url":"https://api.github.com/repos/Esri/hub.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/hub.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/hub.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/hub.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/hub.js/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/hub.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/hub.js/merges","archive_url":"https://api.github.com/repos/Esri/hub.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/hub.js/downloads","issues_url":"https://api.github.com/repos/Esri/hub.js/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/hub.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/hub.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/hub.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/hub.js/labels{/name}","releases_url":"https://api.github.com/repos/Esri/hub.js/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/hub.js/deployments","created_at":"2018-03-26T19:38:34Z","updated_at":"2018-07-03T01:18:24Z","pushed_at":"2018-07-06T06:07:09Z","git_url":"git://github.com/Esri/hub.js.git","ssh_url":"git@github.com:Esri/hub.js.git","clone_url":"https://github.com/Esri/hub.js.git","svn_url":"https://github.com/Esri/hub.js","homepage":"https://esri.github.io/hub.js/","size":369,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"132c7eb756206a495130f1a2b716051da765b83f","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":126880567,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODA1Njc=","name":"hub.js","full_name":"Esri/hub.js","owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/hub.js","description":"JavaScript wrappers for talking to ArcGIS Hub","fork":false,"url":"https://api.github.com/repos/Esri/hub.js","forks_url":"https://api.github.com/repos/Esri/hub.js/forks","keys_url":"https://api.github.com/repos/Esri/hub.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/hub.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/hub.js/teams","hooks_url":"https://api.github.com/repos/Esri/hub.js/hooks","issue_events_url":"https://api.github.com/repos/Esri/hub.js/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/hub.js/events","assignees_url":"https://api.github.com/repos/Esri/hub.js/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/hub.js/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/hub.js/tags","blobs_url":"https://api.github.com/repos/Esri/hub.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/hub.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/hub.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/hub.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/hub.js/languages","stargazers_url":"https://api.github.com/repos/Esri/hub.js/stargazers","contributors_url":"https://api.github.com/repos/Esri/hub.js/contributors","subscribers_url":"https://api.github.com/repos/Esri/hub.js/subscribers","subscription_url":"https://api.github.com/repos/Esri/hub.js/subscription","commits_url":"https://api.github.com/repos/Esri/hub.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/hub.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/hub.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/hub.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/hub.js/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/hub.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/hub.js/merges","archive_url":"https://api.github.com/repos/Esri/hub.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/hub.js/downloads","issues_url":"https://api.github.com/repos/Esri/hub.js/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/hub.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/hub.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/hub.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/hub.js/labels{/name}","releases_url":"https://api.github.com/repos/Esri/hub.js/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/hub.js/deployments","created_at":"2018-03-26T19:38:34Z","updated_at":"2018-07-03T01:18:24Z","pushed_at":"2018-07-06T06:07:09Z","git_url":"git://github.com/Esri/hub.js.git","ssh_url":"git@github.com:Esri/hub.js.git","clone_url":"https://github.com/Esri/hub.js.git","svn_url":"https://github.com/Esri/hub.js","homepage":"https://esri.github.io/hub.js/","size":369,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/34"},"html":{"href":"https://github.com/Esri/hub.js/pull/34"},"issue":{"href":"https://api.github.com/repos/Esri/hub.js/issues/34"},"comments":{"href":"https://api.github.com/repos/Esri/hub.js/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/hub.js/statuses/3b33b69beda4f49b70b55420858c91bc2d841b74"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tomwayson"}}