{"action":"created","comment":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/205013978","pull_request_review_id":140198403,"id":205013978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTAxMzk3OA==","diff_hunk":"@@ -12,6 +12,7 @@ import type { AppleWallet as Pkpasses } from './__generated__/AppleWallet.graphq\n \n type Props = {|\n   +data: Pkpasses,\n+  +legId: ?string,","path":"app/MMB/src/scenes/tickets/boardingPasses/appleWallet/AppleWallet.js","position":4,"original_position":4,"commit_id":"55b9e0831bd86e2b9a4bae0b5c8a1a1bec64cb62","original_commit_id":"55b9e0831bd86e2b9a4bae0b5c8a1a1bec64cb62","user":{"login":"RobinCsl","id":22741774,"node_id":"MDQ6VXNlcjIyNzQxNzc0","avatar_url":"https://avatars3.githubusercontent.com/u/22741774?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinCsl","html_url":"https://github.com/RobinCsl","followers_url":"https://api.github.com/users/RobinCsl/followers","following_url":"https://api.github.com/users/RobinCsl/following{/other_user}","gists_url":"https://api.github.com/users/RobinCsl/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinCsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinCsl/subscriptions","organizations_url":"https://api.github.com/users/RobinCsl/orgs","repos_url":"https://api.github.com/users/RobinCsl/repos","events_url":"https://api.github.com/users/RobinCsl/events{/privacy}","received_events_url":"https://api.github.com/users/RobinCsl/received_events","type":"User","site_admin":false},"body":"Shall we start renaming these with `segmentId`? Since you are already using the (correct) word _segment_ for your context.","created_at":"2018-07-25T07:55:00Z","updated_at":"2018-07-25T07:55:00Z","html_url":"https://github.com/kiwicom/mobile/pull/918#discussion_r205013978","pull_request_url":"https://api.github.com/repos/kiwicom/mobile/pulls/918","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/205013978"},"html":{"href":"https://github.com/kiwicom/mobile/pull/918#discussion_r205013978"},"pull_request":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/918","id":203740493,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzQwNDkz","html_url":"https://github.com/kiwicom/mobile/pull/918","diff_url":"https://github.com/kiwicom/mobile/pull/918.diff","patch_url":"https://github.com/kiwicom/mobile/pull/918.patch","issue_url":"https://api.github.com/repos/kiwicom/mobile/issues/918","number":918,"state":"open","locked":false,"title":"MMB: Prepare data for apple wallet screen","user":{"login":"tbergq","id":7705041,"node_id":"MDQ6VXNlcjc3MDUwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7705041?v=4","gravatar_id":"","url":"https://api.github.com/users/tbergq","html_url":"https://github.com/tbergq","followers_url":"https://api.github.com/users/tbergq/followers","following_url":"https://api.github.com/users/tbergq/following{/other_user}","gists_url":"https://api.github.com/users/tbergq/gists{/gist_id}","starred_url":"https://api.github.com/users/tbergq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbergq/subscriptions","organizations_url":"https://api.github.com/users/tbergq/orgs","repos_url":"https://api.github.com/users/tbergq/repos","events_url":"https://api.github.com/users/tbergq/events{/privacy}","received_events_url":"https://api.github.com/users/tbergq/received_events","type":"User","site_admin":false},"body":"I considered two approaches to get data for the apple wallet screen. \r\n\r\nA: Use query renderer\r\n• I would have to pass legId and passengerId the new screen\r\n• Query the booking for all legs, loop all legs to find my leg, loop pkpasses to find my passenger\r\n• This does not sound optimal\r\n\r\nB: The chosen approach. \r\n• Prepare data in context and set the selected one when clicking on the passenger\r\n• I would then be able to get all needed data on the apple wallet screen from the context through the selectedSegment. \r\n• I do have to prop drill legId down to the click handler, but I would have had to do that with approach A also. \r\n\r\nC: Could be an approach I did not consider, so please let me know if you see another way 😄 ","created_at":"2018-07-25T07:05:41Z","updated_at":"2018-07-25T07:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c855fe4d40f45c0f57b1a99269e8282af09a8a51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwicom/mobile/pulls/918/commits","review_comments_url":"https://api.github.com/repos/kiwicom/mobile/pulls/918/comments","review_comment_url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwicom/mobile/issues/918/comments","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/55b9e0831bd86e2b9a4bae0b5c8a1a1bec64cb62","head":{"label":"kiwicom:apple-wallet-query","ref":"apple-wallet-query","sha":"55b9e0831bd86e2b9a4bae0b5c8a1a1bec64cb62","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-07-24T14:31:06Z","pushed_at":"2018-07-25T07:05:41Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":14294,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":23,"watchers":35,"default_branch":"master"}},"base":{"label":"kiwicom:master","ref":"master","sha":"07f9bb683e3aad5302c73698d478eab5cf8f46c4","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-07-24T14:31:06Z","pushed_at":"2018-07-25T07:05:41Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":14294,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":23,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/918"},"html":{"href":"https://github.com/kiwicom/mobile/pull/918"},"issue":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/918"},"comments":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/kiwicom/mobile/statuses/55b9e0831bd86e2b9a4bae0b5c8a1a1bec64cb62"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"RobinCsl"}}