{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/168066877","pull_request_review_id":96373740,"id":168066877,"diff_hunk":"@@ -349,12 +349,22 @@ func CreateEndpoints(serverAddr string, args ...string) (string, EndpointList, S\n \t\t\t\t\terr = fmt.Errorf(\"path '%s' can not be served by different port on same address\", endpoint.Path)\n \t\t\t\t\treturn serverAddr, endpoints, setupType, err\n \t\t\t\t}\n-\n \t\t\t\tpathIPMap[endpoint.Path] = IPSet.Union(hostIPSet)\n \t\t\t} else {\n \t\t\t\tpathIPMap[endpoint.Path] = hostIPSet\n \t\t\t}\n \t\t}\n+\n+\t\t// Check if all IPs in the path IP map are local, we do not allow more than\n+\t\t// one IPs on same server to serve same disk paths.\n+\t\tfor _, endpoint := range endpoints {\n+\t\t\tif IPSet, ok := pathIPMap[endpoint.Path]; ok {\n+\t\t\t\tif len(localIP4.Intersection(IPSet).ToSlice()) > 1 {","path":"cmd/endpoint.go","position":15,"original_position":15,"commit_id":"4652155488aea1ed96e0086160e71fb0e1ce0bc1","original_commit_id":"4652155488aea1ed96e0086160e71fb0e1ce0bc1","user":{"login":"balamurugana","id":629407,"avatar_url":"https://avatars2.githubusercontent.com/u/629407?v=4","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"body":"1. You could move this check in https://github.com/minio/minio/blob/master/cmd/endpoint.go#L352 to avoid one more looping.\r\n2. You would need to use like https://github.com/minio/minio/blob/master/cmd/net.go#L296","created_at":"2018-02-14T02:59:05Z","updated_at":"2018-02-14T03:01:41Z","html_url":"https://github.com/minio/minio/pull/5523#discussion_r168066877","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/5523","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/168066877"},"html":{"href":"https://github.com/minio/minio/pull/5523#discussion_r168066877"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/5523"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5523","id":168920965,"html_url":"https://github.com/minio/minio/pull/5523","diff_url":"https://github.com/minio/minio/pull/5523.diff","patch_url":"https://github.com/minio/minio/pull/5523.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/5523","number":5523,"state":"open","locked":false,"title":"fail when endpoints point to same path locally","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nfail when endpoints point to same path locally\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\ninput validation\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\nmanually using following steps\r\n\r\nCreate a set of local endpoints using virtual nics. \r\n```\r\nsudo modprobe dummy\r\nsudo ip link set name eth1 dev dummy0\r\nsudo ip link show eth1\r\nsudo ip addr add 192.168.100.199/24 brd + dev eth1 label eth1:0\r\nsudo ip addr add 192.168.100.200/24 brd + dev eth1 label eth1:1\r\nsudo ip addr add 192.168.100.201/24 brd + dev eth1 label eth1:3\r\nsudo ip addr add 192.168.100.202/24 brd + dev eth1 label eth1:4\r\n```\r\n\r\nEdit your `/etc/hosts` file to make following entries.\r\n```\r\ngrep node /etc/hosts\r\n192.168.100.199 node1\r\n192.168.100.200 node2\r\n192.168.100.201 node3\r\n192.168.100.202 node4\r\n```\r\n\r\nNow test with following commands\r\n\r\nBoth of these should fail which doesn't on the master\r\n```\r\n$ minio server http://node1/tmp/t/sda1 http://node2/tmp/t/sda1 http://node3/tmp/t/sda1 http://node4/tmp/t/sda1\r\n```\r\n```\r\n$ minio server http://node{1..4}/tmp/disk{1..4}\r\n```\r\n\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-02-13T18:25:21Z","updated_at":"2018-02-14T03:01:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"064c5fa9b4fa591538bf3ca40c729b601b0f0b7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/5523/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/5523/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/5523/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/4652155488aea1ed96e0086160e71fb0e1ce0bc1","head":{"label":"harshavardhana:fix-endpoints","ref":"fix-endpoints","sha":"4652155488aea1ed96e0086160e71fb0e1ce0bc1","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"repo":{"id":29261868,"name":"minio","full_name":"harshavardhana/minio","owner":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshavardhana/minio","description":"Minio is open source Object Storage inspired from Amazon S3 API and Haystack Object Format","fork":true,"url":"https://api.github.com/repos/harshavardhana/minio","forks_url":"https://api.github.com/repos/harshavardhana/minio/forks","keys_url":"https://api.github.com/repos/harshavardhana/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshavardhana/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshavardhana/minio/teams","hooks_url":"https://api.github.com/repos/harshavardhana/minio/hooks","issue_events_url":"https://api.github.com/repos/harshavardhana/minio/issues/events{/number}","events_url":"https://api.github.com/repos/harshavardhana/minio/events","assignees_url":"https://api.github.com/repos/harshavardhana/minio/assignees{/user}","branches_url":"https://api.github.com/repos/harshavardhana/minio/branches{/branch}","tags_url":"https://api.github.com/repos/harshavardhana/minio/tags","blobs_url":"https://api.github.com/repos/harshavardhana/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshavardhana/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshavardhana/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshavardhana/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshavardhana/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/harshavardhana/minio/languages","stargazers_url":"https://api.github.com/repos/harshavardhana/minio/stargazers","contributors_url":"https://api.github.com/repos/harshavardhana/minio/contributors","subscribers_url":"https://api.github.com/repos/harshavardhana/minio/subscribers","subscription_url":"https://api.github.com/repos/harshavardhana/minio/subscription","commits_url":"https://api.github.com/repos/harshavardhana/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshavardhana/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshavardhana/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshavardhana/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshavardhana/minio/contents/{+path}","compare_url":"https://api.github.com/repos/harshavardhana/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshavardhana/minio/merges","archive_url":"https://api.github.com/repos/harshavardhana/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshavardhana/minio/downloads","issues_url":"https://api.github.com/repos/harshavardhana/minio/issues{/number}","pulls_url":"https://api.github.com/repos/harshavardhana/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/harshavardhana/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/harshavardhana/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshavardhana/minio/labels{/name}","releases_url":"https://api.github.com/repos/harshavardhana/minio/releases{/id}","deployments_url":"https://api.github.com/repos/harshavardhana/minio/deployments","created_at":"2015-01-14T19:32:24Z","updated_at":"2016-12-15T12:35:45Z","pushed_at":"2018-02-14T02:39:44Z","git_url":"git://github.com/harshavardhana/minio.git","ssh_url":"git@github.com:harshavardhana/minio.git","clone_url":"https://github.com/harshavardhana/minio.git","svn_url":"https://github.com/harshavardhana/minio","homepage":"http://minio.io","size":33018,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"pr_out_minio_dl_minio_io_changes_do_not_merge_until_webcli"}},"base":{"label":"minio:master","ref":"master","sha":"994fe53669df10cf73550cd851a71866590c1b14","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-02-14T01:39:26Z","pushed_at":"2018-02-14T02:39:46Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":31372,"stargazers_count":10052,"watchers_count":10052,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":839,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":839,"open_issues":120,"watchers":10052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/5523"},"html":{"href":"https://github.com/minio/minio/pull/5523"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/5523"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/5523/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/5523/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/5523/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/4652155488aea1ed96e0086160e71fb0e1ce0bc1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"balamurugana"}}