{"action":"created","comment":{"url":"https://api.github.com/repos/kelda/kelda/pulls/comments/166418205","pull_request_review_id":94447039,"id":166418205,"diff_hunk":"@@ -13,6 +13,8 @@ this feature should query their public IP at runtime using a service such as\n checkip.amazon.com, or pass containers a floating IP (or DNS name backed by a\n floating IP) and use placement rules to ensure the container is scheduled at\n that floating IP.\n+- Remove the `.q` TLD for Kelda hostnames. Kubernetes doesn't support hostnames","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"d119f200c0c2dd74b1f8b1e509dae3a9c398bd17","original_commit_id":"d119f200c0c2dd74b1f8b1e509dae3a9c398bd17","user":{"login":"luise","id":10263364,"avatar_url":"https://avatars3.githubusercontent.com/u/10263364?v=4","gravatar_id":"","url":"https://api.github.com/users/luise","html_url":"https://github.com/luise","followers_url":"https://api.github.com/users/luise/followers","following_url":"https://api.github.com/users/luise/following{/other_user}","gists_url":"https://api.github.com/users/luise/gists{/gist_id}","starred_url":"https://api.github.com/users/luise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luise/subscriptions","organizations_url":"https://api.github.com/users/luise/orgs","repos_url":"https://api.github.com/users/luise/repos","events_url":"https://api.github.com/users/luise/events{/privacy}","received_events_url":"https://api.github.com/users/luise/received_events","type":"User","site_admin":false},"body":"This will break the HAProxy unit test sthat checks the config: https://github.com/kelda/haproxy/blob/master/test/haproxy-test.js and https://github.com/kelda/haproxy_auto_https/blob/master/test/haproxy-test.js. Not sure if it should work with master or latest release.","created_at":"2018-02-06T19:34:10Z","updated_at":"2018-02-06T19:42:02Z","html_url":"https://github.com/kelda/kelda/pull/1374#discussion_r166418205","pull_request_url":"https://api.github.com/repos/kelda/kelda/pulls/1374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kelda/kelda/pulls/comments/166418205"},"html":{"href":"https://github.com/kelda/kelda/pull/1374#discussion_r166418205"},"pull_request":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1374"}}},"pull_request":{"url":"https://api.github.com/repos/kelda/kelda/pulls/1374","id":166894233,"html_url":"https://github.com/kelda/kelda/pull/1374","diff_url":"https://github.com/kelda/kelda/pull/1374.diff","patch_url":"https://github.com/kelda/kelda/pull/1374.patch","issue_url":"https://api.github.com/repos/kelda/kelda/issues/1374","number":1374,"state":"open","locked":false,"title":"dns: Remove .q TLD from Kelda hostnames","user":{"login":"kklin","id":1811185,"avatar_url":"https://avatars3.githubusercontent.com/u/1811185?v=4","gravatar_id":"","url":"https://api.github.com/users/kklin","html_url":"https://github.com/kklin","followers_url":"https://api.github.com/users/kklin/followers","following_url":"https://api.github.com/users/kklin/following{/other_user}","gists_url":"https://api.github.com/users/kklin/gists{/gist_id}","starred_url":"https://api.github.com/users/kklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklin/subscriptions","organizations_url":"https://api.github.com/users/kklin/orgs","repos_url":"https://api.github.com/users/kklin/repos","events_url":"https://api.github.com/users/kklin/events{/privacy}","received_events_url":"https://api.github.com/users/kklin/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-02-02T20:18:04Z","updated_at":"2018-02-06T19:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4266e90faffda60cf37674e56fe7dc6d9a64169","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kelda/kelda/pulls/1374/commits","review_comments_url":"https://api.github.com/repos/kelda/kelda/pulls/1374/comments","review_comment_url":"https://api.github.com/repos/kelda/kelda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kelda/kelda/issues/1374/comments","statuses_url":"https://api.github.com/repos/kelda/kelda/statuses/d119f200c0c2dd74b1f8b1e509dae3a9c398bd17","head":{"label":"kklin:rm-hostname-tld","ref":"rm-hostname-tld","sha":"d119f200c0c2dd74b1f8b1e509dae3a9c398bd17","user":{"login":"kklin","id":1811185,"avatar_url":"https://avatars3.githubusercontent.com/u/1811185?v=4","gravatar_id":"","url":"https://api.github.com/users/kklin","html_url":"https://github.com/kklin","followers_url":"https://api.github.com/users/kklin/followers","following_url":"https://api.github.com/users/kklin/following{/other_user}","gists_url":"https://api.github.com/users/kklin/gists{/gist_id}","starred_url":"https://api.github.com/users/kklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklin/subscriptions","organizations_url":"https://api.github.com/users/kklin/orgs","repos_url":"https://api.github.com/users/kklin/repos","events_url":"https://api.github.com/users/kklin/events{/privacy}","received_events_url":"https://api.github.com/users/kklin/received_events","type":"User","site_admin":false},"repo":{"id":59677107,"name":"kelda","full_name":"kklin/kelda","owner":{"login":"kklin","id":1811185,"avatar_url":"https://avatars3.githubusercontent.com/u/1811185?v=4","gravatar_id":"","url":"https://api.github.com/users/kklin","html_url":"https://github.com/kklin","followers_url":"https://api.github.com/users/kklin/followers","following_url":"https://api.github.com/users/kklin/following{/other_user}","gists_url":"https://api.github.com/users/kklin/gists{/gist_id}","starred_url":"https://api.github.com/users/kklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklin/subscriptions","organizations_url":"https://api.github.com/users/kklin/orgs","repos_url":"https://api.github.com/users/kklin/repos","events_url":"https://api.github.com/users/kklin/events{/privacy}","received_events_url":"https://api.github.com/users/kklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kklin/kelda","description":"Quilt","fork":true,"url":"https://api.github.com/repos/kklin/kelda","forks_url":"https://api.github.com/repos/kklin/kelda/forks","keys_url":"https://api.github.com/repos/kklin/kelda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kklin/kelda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kklin/kelda/teams","hooks_url":"https://api.github.com/repos/kklin/kelda/hooks","issue_events_url":"https://api.github.com/repos/kklin/kelda/issues/events{/number}","events_url":"https://api.github.com/repos/kklin/kelda/events","assignees_url":"https://api.github.com/repos/kklin/kelda/assignees{/user}","branches_url":"https://api.github.com/repos/kklin/kelda/branches{/branch}","tags_url":"https://api.github.com/repos/kklin/kelda/tags","blobs_url":"https://api.github.com/repos/kklin/kelda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kklin/kelda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kklin/kelda/git/refs{/sha}","trees_url":"https://api.github.com/repos/kklin/kelda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kklin/kelda/statuses/{sha}","languages_url":"https://api.github.com/repos/kklin/kelda/languages","stargazers_url":"https://api.github.com/repos/kklin/kelda/stargazers","contributors_url":"https://api.github.com/repos/kklin/kelda/contributors","subscribers_url":"https://api.github.com/repos/kklin/kelda/subscribers","subscription_url":"https://api.github.com/repos/kklin/kelda/subscription","commits_url":"https://api.github.com/repos/kklin/kelda/commits{/sha}","git_commits_url":"https://api.github.com/repos/kklin/kelda/git/commits{/sha}","comments_url":"https://api.github.com/repos/kklin/kelda/comments{/number}","issue_comment_url":"https://api.github.com/repos/kklin/kelda/issues/comments{/number}","contents_url":"https://api.github.com/repos/kklin/kelda/contents/{+path}","compare_url":"https://api.github.com/repos/kklin/kelda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kklin/kelda/merges","archive_url":"https://api.github.com/repos/kklin/kelda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kklin/kelda/downloads","issues_url":"https://api.github.com/repos/kklin/kelda/issues{/number}","pulls_url":"https://api.github.com/repos/kklin/kelda/pulls{/number}","milestones_url":"https://api.github.com/repos/kklin/kelda/milestones{/number}","notifications_url":"https://api.github.com/repos/kklin/kelda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kklin/kelda/labels{/name}","releases_url":"https://api.github.com/repos/kklin/kelda/releases{/id}","deployments_url":"https://api.github.com/repos/kklin/kelda/deployments","created_at":"2016-05-25T15:54:49Z","updated_at":"2017-10-13T19:18:35Z","pushed_at":"2018-02-06T07:29:44Z","git_url":"git://github.com/kklin/kelda.git","ssh_url":"git@github.com:kklin/kelda.git","clone_url":"https://github.com/kklin/kelda.git","svn_url":"https://github.com/kklin/kelda","homepage":"","size":25188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kelda:master","ref":"master","sha":"f8a9ad2174691e360a4efedb1109a6b7238f5e0e","user":{"login":"kelda","id":25753912,"avatar_url":"https://avatars2.githubusercontent.com/u/25753912?v=4","gravatar_id":"","url":"https://api.github.com/users/kelda","html_url":"https://github.com/kelda","followers_url":"https://api.github.com/users/kelda/followers","following_url":"https://api.github.com/users/kelda/following{/other_user}","gists_url":"https://api.github.com/users/kelda/gists{/gist_id}","starred_url":"https://api.github.com/users/kelda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelda/subscriptions","organizations_url":"https://api.github.com/users/kelda/orgs","repos_url":"https://api.github.com/users/kelda/repos","events_url":"https://api.github.com/users/kelda/events{/privacy}","received_events_url":"https://api.github.com/users/kelda/received_events","type":"Organization","site_admin":false},"repo":{"id":43390663,"name":"kelda","full_name":"kelda/kelda","owner":{"login":"kelda","id":25753912,"avatar_url":"https://avatars2.githubusercontent.com/u/25753912?v=4","gravatar_id":"","url":"https://api.github.com/users/kelda","html_url":"https://github.com/kelda","followers_url":"https://api.github.com/users/kelda/followers","following_url":"https://api.github.com/users/kelda/following{/other_user}","gists_url":"https://api.github.com/users/kelda/gists{/gist_id}","starred_url":"https://api.github.com/users/kelda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelda/subscriptions","organizations_url":"https://api.github.com/users/kelda/orgs","repos_url":"https://api.github.com/users/kelda/repos","events_url":"https://api.github.com/users/kelda/events{/privacy}","received_events_url":"https://api.github.com/users/kelda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kelda/kelda","description":"Kelda, formerly Quilt, is an approachable way to deploy to the cloud.","fork":false,"url":"https://api.github.com/repos/kelda/kelda","forks_url":"https://api.github.com/repos/kelda/kelda/forks","keys_url":"https://api.github.com/repos/kelda/kelda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelda/kelda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelda/kelda/teams","hooks_url":"https://api.github.com/repos/kelda/kelda/hooks","issue_events_url":"https://api.github.com/repos/kelda/kelda/issues/events{/number}","events_url":"https://api.github.com/repos/kelda/kelda/events","assignees_url":"https://api.github.com/repos/kelda/kelda/assignees{/user}","branches_url":"https://api.github.com/repos/kelda/kelda/branches{/branch}","tags_url":"https://api.github.com/repos/kelda/kelda/tags","blobs_url":"https://api.github.com/repos/kelda/kelda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelda/kelda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelda/kelda/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelda/kelda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelda/kelda/statuses/{sha}","languages_url":"https://api.github.com/repos/kelda/kelda/languages","stargazers_url":"https://api.github.com/repos/kelda/kelda/stargazers","contributors_url":"https://api.github.com/repos/kelda/kelda/contributors","subscribers_url":"https://api.github.com/repos/kelda/kelda/subscribers","subscription_url":"https://api.github.com/repos/kelda/kelda/subscription","commits_url":"https://api.github.com/repos/kelda/kelda/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelda/kelda/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelda/kelda/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelda/kelda/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelda/kelda/contents/{+path}","compare_url":"https://api.github.com/repos/kelda/kelda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelda/kelda/merges","archive_url":"https://api.github.com/repos/kelda/kelda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelda/kelda/downloads","issues_url":"https://api.github.com/repos/kelda/kelda/issues{/number}","pulls_url":"https://api.github.com/repos/kelda/kelda/pulls{/number}","milestones_url":"https://api.github.com/repos/kelda/kelda/milestones{/number}","notifications_url":"https://api.github.com/repos/kelda/kelda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelda/kelda/labels{/name}","releases_url":"https://api.github.com/repos/kelda/kelda/releases{/id}","deployments_url":"https://api.github.com/repos/kelda/kelda/deployments","created_at":"2015-09-29T19:52:32Z","updated_at":"2018-02-06T01:38:31Z","pushed_at":"2018-02-06T18:33:56Z","git_url":"git://github.com/kelda/kelda.git","ssh_url":"git@github.com:kelda/kelda.git","clone_url":"https://github.com/kelda/kelda.git","svn_url":"https://github.com/kelda/kelda","homepage":"http://kelda.io","size":24833,"stargazers_count":432,"watchers_count":432,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":41,"open_issues":14,"watchers":432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1374"},"html":{"href":"https://github.com/kelda/kelda/pull/1374"},"issue":{"href":"https://api.github.com/repos/kelda/kelda/issues/1374"},"comments":{"href":"https://api.github.com/repos/kelda/kelda/issues/1374/comments"},"review_comments":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1374/comments"},"review_comment":{"href":"https://api.github.com/repos/kelda/kelda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kelda/kelda/pulls/1374/commits"},"statuses":{"href":"https://api.github.com/repos/kelda/kelda/statuses/d119f200c0c2dd74b1f8b1e509dae3a9c398bd17"}},"author_association":"OWNER"}}
{"actor":{"display_login":"luise"}}