{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/168621122","pull_request_review_id":97020962,"id":168621122,"diff_hunk":"@@ -96,8 +99,32 @@ def listen(self, grpc_port):\n         interactive_debugger_server_lib.InteractiveDebuggerDataServer(\n             self._grpc_port))\n \n-    threading.Thread(target=self._debugger_data_server.\n-                     start_the_debugger_data_receiving_server).start()\n+    self._server_thread = threading.Thread(\n+        target=self._debugger_data_server.\n+        start_the_debugger_data_receiving_server)\n+    self._server_thread.start()\n+\n+    signal.signal(signal.SIGINT, self.signal_handler)\n+\n+  def signal_handler(self, unused_signal, unused_frame):\n+    if self._debugger_data_server and self._server_thread:\n+      print('Stopping InteractiveDebuggerPlugin...')\n+      # Enqueue a number of messages to the incoming message queue to try to\n+      # let the debugged tensorflow runtime proceed past the current Session.run\n+      # in the C++ layer and return to the Python layer, so the SIGINT handler\n+      # registered there may be triggered.\n+      for _ in xrange(len(self._debugger_data_server.breakpoints) +  1):\n+        self._debugger_data_server.put_incoming_message(True)\n+      # while True:  # DEBUG","path":"tensorboard/plugins/debugger/interactive_debugger_plugin.py","position":42,"original_position":42,"commit_id":"d54451d18d1bfc8f531c7f8df85f03ef485b332f","original_commit_id":"d54451d18d1bfc8f531c7f8df85f03ef485b332f","user":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"body":"Done. ","created_at":"2018-02-15T21:58:26Z","updated_at":"2018-02-15T21:58:45Z","html_url":"https://github.com/tensorflow/tensorboard/pull/975#discussion_r168621122","pull_request_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/168621122"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/975#discussion_r168621122"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975"}},"in_reply_to_id":168605815},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975","id":169445858,"html_url":"https://github.com/tensorflow/tensorboard/pull/975","diff_url":"https://github.com/tensorflow/tensorboard/pull/975.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/975.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/975","number":975,"state":"open","locked":false,"title":"[Debugger Plugin] Exit TensorBoard on SIGINT even with debugger enabled","user":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-15T18:11:13Z","updated_at":"2018-02-15T21:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe44dcd8b02d9ec1a9d057657521dbcff8391e81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685702960,"url":"https://api.github.com/repos/tensorflow/tensorboard/labels/plugin:debugger","name":"plugin:debugger","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/975/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/d54451d18d1bfc8f531c7f8df85f03ef485b332f","head":{"label":"caisq:sigint","ref":"sigint","sha":"d54451d18d1bfc8f531c7f8df85f03ef485b332f","user":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"repo":{"id":98921142,"name":"tensorboard","full_name":"caisq/tensorboard","owner":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caisq/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":true,"url":"https://api.github.com/repos/caisq/tensorboard","forks_url":"https://api.github.com/repos/caisq/tensorboard/forks","keys_url":"https://api.github.com/repos/caisq/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caisq/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caisq/tensorboard/teams","hooks_url":"https://api.github.com/repos/caisq/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/caisq/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/caisq/tensorboard/events","assignees_url":"https://api.github.com/repos/caisq/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/caisq/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/caisq/tensorboard/tags","blobs_url":"https://api.github.com/repos/caisq/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caisq/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caisq/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/caisq/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caisq/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/caisq/tensorboard/languages","stargazers_url":"https://api.github.com/repos/caisq/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/caisq/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/caisq/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/caisq/tensorboard/subscription","commits_url":"https://api.github.com/repos/caisq/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/caisq/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/caisq/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/caisq/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/caisq/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/caisq/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caisq/tensorboard/merges","archive_url":"https://api.github.com/repos/caisq/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caisq/tensorboard/downloads","issues_url":"https://api.github.com/repos/caisq/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/caisq/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/caisq/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/caisq/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caisq/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/caisq/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/caisq/tensorboard/deployments","created_at":"2017-07-31T19:12:11Z","updated_at":"2017-10-02T18:22:07Z","pushed_at":"2018-02-15T18:50:13Z","git_url":"git://github.com/caisq/tensorboard.git","ssh_url":"git@github.com:caisq/tensorboard.git","clone_url":"https://github.com/caisq/tensorboard.git","svn_url":"https://github.com/caisq/tensorboard","homepage":null,"size":10793,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"abef3f6dff6c122abfb315bd62da22aa03611f45","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2018-02-15T17:23:08Z","pushed_at":"2018-02-15T21:41:39Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"git@github.com:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":10864,"stargazers_count":1245,"watchers_count":1245,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":303,"open_issues":187,"watchers":1245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/975"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/975"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/975/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/975/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/d54451d18d1bfc8f531c7f8df85f03ef485b332f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"caisq"}}