{"action":"created","comment":{"url":"https://api.github.com/repos/brave/muon/pulls/comments/199579014","pull_request_review_id":133726212,"id":199579014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU3OTAxNA==","diff_hunk":"@@ -84,7 +88,7 @@ grit(\"brave_resources\") {\n   ]\n \n   deps = [\n-    \"app:brave_content_manifest_overlays\",\n+    \"//chrome/app:chrome_content_manifest_overlays\",","path":"BUILD.gn","position":25,"original_position":25,"commit_id":"cf215a01ffefe550b5933216571a3e715e6e2242","original_commit_id":"cf215a01ffefe550b5933216571a3e715e6e2242","user":{"login":"darkdh","id":11330831,"node_id":"MDQ6VXNlcjExMzMwODMx","avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"body":"original `app:brave_content_manifest_overlays` doesn't work at all.\r\nIt supposed to package `//chrome/utility:profile_import_manifest` but it never does. ","created_at":"2018-07-02T18:10:21Z","updated_at":"2018-07-02T18:10:21Z","html_url":"https://github.com/brave/muon/pull/473#discussion_r199579014","pull_request_url":"https://api.github.com/repos/brave/muon/pulls/473","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/muon/pulls/comments/199579014"},"html":{"href":"https://github.com/brave/muon/pull/473#discussion_r199579014"},"pull_request":{"href":"https://api.github.com/repos/brave/muon/pulls/473"}},"in_reply_to_id":199577733},"pull_request":{"url":"https://api.github.com/repos/brave/muon/pulls/473","id":166669324,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY2NjY5MzI0","html_url":"https://github.com/brave/muon/pull/473","diff_url":"https://github.com/brave/muon/pull/473.diff","patch_url":"https://github.com/brave/muon/pull/473.patch","issue_url":"https://api.github.com/repos/brave/muon/issues/473","number":473,"state":"open","locked":false,"title":"Tor browser context","user":{"login":"darkdh","id":11330831,"node_id":"MDQ6VXNlcjExMzMwODMx","avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"body":"1. context creating options: \"isolated_storage\", \"tor_proxy\"\r\n2. setTorNewIdentity API\r\n3. automatically launch tor when tor browser context created and tear it\r\ndown when tor browser context destroyed\r\n\r\nfix #468\r\nfix #464\r\nfix #509\r\n\r\nbrowser-laptop changes: https://github.com/brave/browser-laptop/tree/feature/tor\r\n\r\nAuditors: @bridiver, @riastradh-brave, @diracdeltas","created_at":"2018-02-01T22:26:49Z","updated_at":"2018-07-02T18:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0241ed822d651aa29de5b52e420890c691a8fb3","assignee":{"login":"jumde","id":1903815,"node_id":"MDQ6VXNlcjE5MDM4MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1903815?v=4","gravatar_id":"","url":"https://api.github.com/users/jumde","html_url":"https://github.com/jumde","followers_url":"https://api.github.com/users/jumde/followers","following_url":"https://api.github.com/users/jumde/following{/other_user}","gists_url":"https://api.github.com/users/jumde/gists{/gist_id}","starred_url":"https://api.github.com/users/jumde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumde/subscriptions","organizations_url":"https://api.github.com/users/jumde/orgs","repos_url":"https://api.github.com/users/jumde/repos","events_url":"https://api.github.com/users/jumde/events{/privacy}","received_events_url":"https://api.github.com/users/jumde/received_events","type":"User","site_admin":false},"assignees":[{"login":"jumde","id":1903815,"node_id":"MDQ6VXNlcjE5MDM4MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1903815?v=4","gravatar_id":"","url":"https://api.github.com/users/jumde","html_url":"https://github.com/jumde","followers_url":"https://api.github.com/users/jumde/followers","following_url":"https://api.github.com/users/jumde/following{/other_user}","gists_url":"https://api.github.com/users/jumde/gists{/gist_id}","starred_url":"https://api.github.com/users/jumde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumde/subscriptions","organizations_url":"https://api.github.com/users/jumde/orgs","repos_url":"https://api.github.com/users/jumde/repos","events_url":"https://api.github.com/users/jumde/events{/privacy}","received_events_url":"https://api.github.com/users/jumde/received_events","type":"User","site_admin":false},{"login":"darkdh","id":11330831,"node_id":"MDQ6VXNlcjExMzMwODMx","avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":821598356,"node_id":"MDU6TGFiZWw4MjE1OTgzNTY=","url":"https://api.github.com/repos/brave/muon/labels/feature/tor","name":"feature/tor","color":"7512bc","default":false}],"milestone":{"url":"https://api.github.com/repos/brave/muon/milestones/107","html_url":"https://github.com/brave/muon/milestone/107","labels_url":"https://api.github.com/repos/brave/muon/milestones/107/labels","id":3271501,"node_id":"MDk6TWlsZXN0b25lMzI3MTUwMQ==","number":107,"title":"6.1.0","description":null,"creator":{"login":"darkdh","id":11330831,"node_id":"MDQ6VXNlcjExMzMwODMx","avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2018-04-16T17:02:57Z","updated_at":"2018-04-20T03:26:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/muon/pulls/473/commits","review_comments_url":"https://api.github.com/repos/brave/muon/pulls/473/comments","review_comment_url":"https://api.github.com/repos/brave/muon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/muon/issues/473/comments","statuses_url":"https://api.github.com/repos/brave/muon/statuses/cf215a01ffefe550b5933216571a3e715e6e2242","head":{"label":"brave:tor_browser_context","ref":"tor_browser_context","sha":"cf215a01ffefe550b5933216571a3e715e6e2242","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":47076719,"node_id":"MDEwOlJlcG9zaXRvcnk0NzA3NjcxOQ==","name":"muon","full_name":"brave/muon","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/muon","description":"Build browsers and browser like applications with HTML, CSS, and JavaScript","fork":false,"url":"https://api.github.com/repos/brave/muon","forks_url":"https://api.github.com/repos/brave/muon/forks","keys_url":"https://api.github.com/repos/brave/muon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/muon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/muon/teams","hooks_url":"https://api.github.com/repos/brave/muon/hooks","issue_events_url":"https://api.github.com/repos/brave/muon/issues/events{/number}","events_url":"https://api.github.com/repos/brave/muon/events","assignees_url":"https://api.github.com/repos/brave/muon/assignees{/user}","branches_url":"https://api.github.com/repos/brave/muon/branches{/branch}","tags_url":"https://api.github.com/repos/brave/muon/tags","blobs_url":"https://api.github.com/repos/brave/muon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/muon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/muon/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/muon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/muon/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/muon/languages","stargazers_url":"https://api.github.com/repos/brave/muon/stargazers","contributors_url":"https://api.github.com/repos/brave/muon/contributors","subscribers_url":"https://api.github.com/repos/brave/muon/subscribers","subscription_url":"https://api.github.com/repos/brave/muon/subscription","commits_url":"https://api.github.com/repos/brave/muon/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/muon/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/muon/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/muon/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/muon/contents/{+path}","compare_url":"https://api.github.com/repos/brave/muon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/muon/merges","archive_url":"https://api.github.com/repos/brave/muon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/muon/downloads","issues_url":"https://api.github.com/repos/brave/muon/issues{/number}","pulls_url":"https://api.github.com/repos/brave/muon/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/muon/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/muon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/muon/labels{/name}","releases_url":"https://api.github.com/repos/brave/muon/releases{/id}","deployments_url":"https://api.github.com/repos/brave/muon/deployments","created_at":"2015-11-29T19:21:25Z","updated_at":"2018-07-02T12:43:38Z","pushed_at":"2018-07-01T20:41:27Z","git_url":"git://github.com/brave/muon.git","ssh_url":"git@github.com:brave/muon.git","clone_url":"https://github.com/brave/muon.git","svn_url":"https://github.com/brave/muon","homepage":"https://discord.gg/TcT5tX2","size":41526,"stargazers_count":788,"watchers_count":788,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":96,"open_issues":136,"watchers":788,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"cf518ef089f22163b67a52f5b34c90a841572e4b","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":47076719,"node_id":"MDEwOlJlcG9zaXRvcnk0NzA3NjcxOQ==","name":"muon","full_name":"brave/muon","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/muon","description":"Build browsers and browser like applications with HTML, CSS, and JavaScript","fork":false,"url":"https://api.github.com/repos/brave/muon","forks_url":"https://api.github.com/repos/brave/muon/forks","keys_url":"https://api.github.com/repos/brave/muon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/muon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/muon/teams","hooks_url":"https://api.github.com/repos/brave/muon/hooks","issue_events_url":"https://api.github.com/repos/brave/muon/issues/events{/number}","events_url":"https://api.github.com/repos/brave/muon/events","assignees_url":"https://api.github.com/repos/brave/muon/assignees{/user}","branches_url":"https://api.github.com/repos/brave/muon/branches{/branch}","tags_url":"https://api.github.com/repos/brave/muon/tags","blobs_url":"https://api.github.com/repos/brave/muon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/muon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/muon/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/muon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/muon/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/muon/languages","stargazers_url":"https://api.github.com/repos/brave/muon/stargazers","contributors_url":"https://api.github.com/repos/brave/muon/contributors","subscribers_url":"https://api.github.com/repos/brave/muon/subscribers","subscription_url":"https://api.github.com/repos/brave/muon/subscription","commits_url":"https://api.github.com/repos/brave/muon/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/muon/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/muon/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/muon/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/muon/contents/{+path}","compare_url":"https://api.github.com/repos/brave/muon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/muon/merges","archive_url":"https://api.github.com/repos/brave/muon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/muon/downloads","issues_url":"https://api.github.com/repos/brave/muon/issues{/number}","pulls_url":"https://api.github.com/repos/brave/muon/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/muon/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/muon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/muon/labels{/name}","releases_url":"https://api.github.com/repos/brave/muon/releases{/id}","deployments_url":"https://api.github.com/repos/brave/muon/deployments","created_at":"2015-11-29T19:21:25Z","updated_at":"2018-07-02T12:43:38Z","pushed_at":"2018-07-01T20:41:27Z","git_url":"git://github.com/brave/muon.git","ssh_url":"git@github.com:brave/muon.git","clone_url":"https://github.com/brave/muon.git","svn_url":"https://github.com/brave/muon","homepage":"https://discord.gg/TcT5tX2","size":41526,"stargazers_count":788,"watchers_count":788,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":96,"open_issues":136,"watchers":788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/muon/pulls/473"},"html":{"href":"https://github.com/brave/muon/pull/473"},"issue":{"href":"https://api.github.com/repos/brave/muon/issues/473"},"comments":{"href":"https://api.github.com/repos/brave/muon/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/muon/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/muon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/muon/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/brave/muon/statuses/cf215a01ffefe550b5933216571a3e715e6e2242"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"darkdh"}}