{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/244544609","pull_request_review_id":188450016,"id":244544609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU0NDYwOQ==","diff_hunk":"@@ -8,25 +8,19 @@ metadata:\n     release: {{ .Release.Name }}\n     heritage: {{ .Release.Service }}\n spec:\n-  strategy:\n-    type: Recreate\n+  updateStrategy:\n+    type: RollingUpdate","path":"stable/graphite/templates/statefulset.yaml","position":15,"original_position":15,"commit_id":"0031ed7e9366205bd5a86898414f426318e296dd","original_commit_id":"0b278c520fc620af92d2363a43fd474606af42b4","user":{"login":"AaronFriel","id":788800,"node_id":"MDQ6VXNlcjc4ODgwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/788800?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronFriel","html_url":"https://github.com/AaronFriel","followers_url":"https://api.github.com/users/AaronFriel/followers","following_url":"https://api.github.com/users/AaronFriel/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriel/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriel/subscriptions","organizations_url":"https://api.github.com/users/AaronFriel/orgs","repos_url":"https://api.github.com/users/AaronFriel/repos","events_url":"https://api.github.com/users/AaronFriel/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriel/received_events","type":"User","site_admin":false},"body":"Recreate isn't an option for stateful sets.","created_at":"2018-12-30T20:36:36Z","updated_at":"2018-12-30T20:36:36Z","html_url":"https://github.com/helm/charts/pull/10309#discussion_r244544609","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/10309","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/244544609"},"html":{"href":"https://github.com/helm/charts/pull/10309#discussion_r244544609"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/10309"}},"in_reply_to_id":244543420},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/10309","id":241479578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDc5NTc4","html_url":"https://github.com/helm/charts/pull/10309","diff_url":"https://github.com/helm/charts/pull/10309.diff","patch_url":"https://github.com/helm/charts/pull/10309.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/10309","number":10309,"state":"open","locked":false,"title":"[stable/graphite] Graphite statefulset","user":{"login":"AaronFriel","id":788800,"node_id":"MDQ6VXNlcjc4ODgwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/788800?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronFriel","html_url":"https://github.com/AaronFriel","followers_url":"https://api.github.com/users/AaronFriel/followers","following_url":"https://api.github.com/users/AaronFriel/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriel/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriel/subscriptions","organizations_url":"https://api.github.com/users/AaronFriel/orgs","repos_url":"https://api.github.com/users/AaronFriel/repos","events_url":"https://api.github.com/users/AaronFriel/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriel/received_events","type":"User","site_admin":false},"body":"#### What this PR does / why we need it:\r\n\r\nGraphite has some weird performance glitches with 1.1.4-10, the prior version, and this resulted in metrics being delayed or not appearing at all for over half an hour (tested with persistence enabled and disabled).\r\n\r\nThe init container is no longer necessary in 1.1.5, simplifying implementation, something I missed in #10305.\r\n\r\nThe StatefulSet better models how Graphite considers its individual components. In my testing I noticed that when restarting pods, the Graphite UI would be littered with old pod names. It looks like Graphite is sensitive to the identities of the different services - it is designed to be clustered after all.\r\n\r\n#### Special notes for your reviewer:\r\n\r\nIf this is merged, #10305 is not necessary.\r\n\r\n#### Checklist\r\n- [X] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [X] Chart Version bumped\r\n- [X] Variables are documented in the README.md\r\n","created_at":"2018-12-30T07:24:35Z","updated_at":"2018-12-30T20:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07f98af3de18f7361c49717f270e73d1759fad4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676009699,"node_id":"MDU6TGFiZWw2NzYwMDk2OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/10309/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/10309/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/10309/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/0031ed7e9366205bd5a86898414f426318e296dd","head":{"label":"AaronFriel:graphite-statefulset","ref":"graphite-statefulset","sha":"0031ed7e9366205bd5a86898414f426318e296dd","user":{"login":"AaronFriel","id":788800,"node_id":"MDQ6VXNlcjc4ODgwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/788800?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronFriel","html_url":"https://github.com/AaronFriel","followers_url":"https://api.github.com/users/AaronFriel/followers","following_url":"https://api.github.com/users/AaronFriel/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriel/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriel/subscriptions","organizations_url":"https://api.github.com/users/AaronFriel/orgs","repos_url":"https://api.github.com/users/AaronFriel/repos","events_url":"https://api.github.com/users/AaronFriel/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriel/received_events","type":"User","site_admin":false},"repo":{"id":163549346,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM1NDkzNDY=","name":"charts","full_name":"AaronFriel/charts","private":false,"owner":{"login":"AaronFriel","id":788800,"node_id":"MDQ6VXNlcjc4ODgwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/788800?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronFriel","html_url":"https://github.com/AaronFriel","followers_url":"https://api.github.com/users/AaronFriel/followers","following_url":"https://api.github.com/users/AaronFriel/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriel/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriel/subscriptions","organizations_url":"https://api.github.com/users/AaronFriel/orgs","repos_url":"https://api.github.com/users/AaronFriel/repos","events_url":"https://api.github.com/users/AaronFriel/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AaronFriel/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/AaronFriel/charts","forks_url":"https://api.github.com/repos/AaronFriel/charts/forks","keys_url":"https://api.github.com/repos/AaronFriel/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AaronFriel/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AaronFriel/charts/teams","hooks_url":"https://api.github.com/repos/AaronFriel/charts/hooks","issue_events_url":"https://api.github.com/repos/AaronFriel/charts/issues/events{/number}","events_url":"https://api.github.com/repos/AaronFriel/charts/events","assignees_url":"https://api.github.com/repos/AaronFriel/charts/assignees{/user}","branches_url":"https://api.github.com/repos/AaronFriel/charts/branches{/branch}","tags_url":"https://api.github.com/repos/AaronFriel/charts/tags","blobs_url":"https://api.github.com/repos/AaronFriel/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AaronFriel/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AaronFriel/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/AaronFriel/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AaronFriel/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/AaronFriel/charts/languages","stargazers_url":"https://api.github.com/repos/AaronFriel/charts/stargazers","contributors_url":"https://api.github.com/repos/AaronFriel/charts/contributors","subscribers_url":"https://api.github.com/repos/AaronFriel/charts/subscribers","subscription_url":"https://api.github.com/repos/AaronFriel/charts/subscription","commits_url":"https://api.github.com/repos/AaronFriel/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/AaronFriel/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/AaronFriel/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/AaronFriel/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/AaronFriel/charts/contents/{+path}","compare_url":"https://api.github.com/repos/AaronFriel/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AaronFriel/charts/merges","archive_url":"https://api.github.com/repos/AaronFriel/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AaronFriel/charts/downloads","issues_url":"https://api.github.com/repos/AaronFriel/charts/issues{/number}","pulls_url":"https://api.github.com/repos/AaronFriel/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/AaronFriel/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/AaronFriel/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AaronFriel/charts/labels{/name}","releases_url":"https://api.github.com/repos/AaronFriel/charts/releases{/id}","deployments_url":"https://api.github.com/repos/AaronFriel/charts/deployments","created_at":"2018-12-29T23:59:08Z","updated_at":"2018-12-30T17:25:43Z","pushed_at":"2018-12-30T19:47:00Z","git_url":"git://github.com/AaronFriel/charts.git","ssh_url":"git@github.com:AaronFriel/charts.git","clone_url":"https://github.com/AaronFriel/charts.git","svn_url":"https://github.com/AaronFriel/charts","homepage":"","size":15171,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"56a30eca9e0ddfb6bd4fdd71d98e004978627095","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-12-30T19:51:07Z","pushed_at":"2018-12-30T19:47:02Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":15221,"stargazers_count":6200,"watchers_count":6200,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5684,"mirror_url":null,"archived":false,"open_issues_count":629,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5684,"open_issues":629,"watchers":6200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/10309"},"html":{"href":"https://github.com/helm/charts/pull/10309"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/10309"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/10309/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/10309/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/10309/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/0031ed7e9366205bd5a86898414f426318e296dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"AaronFriel"}}