{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/222467589","pull_request_review_id":161362259,"id":222467589,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ2NzU4OQ==","diff_hunk":"@@ -155,9 +155,15 @@ def rank_error(msg):\n               or str(response.currentState) == 'JOB_STATE_UPDATED'\n               or str(response.currentState) == 'JOB_STATE_DRAINED'):\n             break\n-          # The job has failed; ensure we see any final error messages.\n-          sleep_secs = 1.0      # poll faster during the final countdown\n-          final_countdown_timer_secs -= sleep_secs\n+\n+          # Check that job is in a post-preparation state before starting the\n+          # final countdown.\n+          if (str(response.currentState) != 'JOB_STATE_PENDING'\n+              and str(response.currentState) != 'JOB_STATE_QUEUED'):","path":"sdks/python/apache_beam/runners/dataflow/dataflow_runner.py","position":11,"original_position":11,"commit_id":"3ae91b33c6386173f3e038e4d027fde9626dc80b","original_commit_id":"3ae91b33c6386173f3e038e4d027fde9626dc80b","user":{"login":"charlesccychen","id":1055135,"node_id":"MDQ6VXNlcjEwNTUxMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1055135?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesccychen","html_url":"https://github.com/charlesccychen","followers_url":"https://api.github.com/users/charlesccychen/followers","following_url":"https://api.github.com/users/charlesccychen/following{/other_user}","gists_url":"https://api.github.com/users/charlesccychen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesccychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesccychen/subscriptions","organizations_url":"https://api.github.com/users/charlesccychen/orgs","repos_url":"https://api.github.com/users/charlesccychen/repos","events_url":"https://api.github.com/users/charlesccychen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesccychen/received_events","type":"User","site_admin":false},"body":"How about `if str(response.currentState) not in ('JOB_STATE_PENDING', 'JOB_STATE_QUEUED'):`?","created_at":"2018-10-03T21:05:40Z","updated_at":"2018-10-03T21:05:52Z","html_url":"https://github.com/apache/beam/pull/6535#discussion_r222467589","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6535","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/222467589"},"html":{"href":"https://github.com/apache/beam/pull/6535#discussion_r222467589"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6535"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6535","id":219549306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTQ5MzA2","html_url":"https://github.com/apache/beam/pull/6535","diff_url":"https://github.com/apache/beam/pull/6535.diff","patch_url":"https://github.com/apache/beam/pull/6535.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6535","number":6535,"state":"open","locked":false,"title":"[BEAM-5529] Before starting the final countdown, check that job is not in pre-running state","user":{"login":"aaltay","id":696638,"node_id":"MDQ6VXNlcjY5NjYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/696638?v=4","gravatar_id":"","url":"https://api.github.com/users/aaltay","html_url":"https://github.com/aaltay","followers_url":"https://api.github.com/users/aaltay/followers","following_url":"https://api.github.com/users/aaltay/following{/other_user}","gists_url":"https://api.github.com/users/aaltay/gists{/gist_id}","starred_url":"https://api.github.com/users/aaltay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaltay/subscriptions","organizations_url":"https://api.github.com/users/aaltay/orgs","repos_url":"https://api.github.com/users/aaltay/repos","events_url":"https://api.github.com/users/aaltay/events{/privacy}","received_events_url":"https://api.github.com/users/aaltay/received_events","type":"User","site_admin":false},"body":"Before starting the final countdown, check that job is not in pre-running state\r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-10-01T23:55:31Z","updated_at":"2018-10-03T21:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"795bb43dd80e21e6e19ff8e126c0cdd4b0da5d3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6535/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6535/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6535/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/3ae91b33c6386173f3e038e4d027fde9626dc80b","head":{"label":"aaltay:pend","ref":"pend","sha":"3ae91b33c6386173f3e038e4d027fde9626dc80b","user":{"login":"aaltay","id":696638,"node_id":"MDQ6VXNlcjY5NjYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/696638?v=4","gravatar_id":"","url":"https://api.github.com/users/aaltay","html_url":"https://github.com/aaltay","followers_url":"https://api.github.com/users/aaltay/followers","following_url":"https://api.github.com/users/aaltay/following{/other_user}","gists_url":"https://api.github.com/users/aaltay/gists{/gist_id}","starred_url":"https://api.github.com/users/aaltay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaltay/subscriptions","organizations_url":"https://api.github.com/users/aaltay/orgs","repos_url":"https://api.github.com/users/aaltay/repos","events_url":"https://api.github.com/users/aaltay/events{/privacy}","received_events_url":"https://api.github.com/users/aaltay/received_events","type":"User","site_admin":false},"repo":{"id":61246731,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0NjczMQ==","name":"beam","full_name":"aaltay/beam","private":false,"owner":{"login":"aaltay","id":696638,"node_id":"MDQ6VXNlcjY5NjYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/696638?v=4","gravatar_id":"","url":"https://api.github.com/users/aaltay","html_url":"https://github.com/aaltay","followers_url":"https://api.github.com/users/aaltay/followers","following_url":"https://api.github.com/users/aaltay/following{/other_user}","gists_url":"https://api.github.com/users/aaltay/gists{/gist_id}","starred_url":"https://api.github.com/users/aaltay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaltay/subscriptions","organizations_url":"https://api.github.com/users/aaltay/orgs","repos_url":"https://api.github.com/users/aaltay/repos","events_url":"https://api.github.com/users/aaltay/events{/privacy}","received_events_url":"https://api.github.com/users/aaltay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aaltay/beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/aaltay/beam","forks_url":"https://api.github.com/repos/aaltay/beam/forks","keys_url":"https://api.github.com/repos/aaltay/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaltay/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaltay/beam/teams","hooks_url":"https://api.github.com/repos/aaltay/beam/hooks","issue_events_url":"https://api.github.com/repos/aaltay/beam/issues/events{/number}","events_url":"https://api.github.com/repos/aaltay/beam/events","assignees_url":"https://api.github.com/repos/aaltay/beam/assignees{/user}","branches_url":"https://api.github.com/repos/aaltay/beam/branches{/branch}","tags_url":"https://api.github.com/repos/aaltay/beam/tags","blobs_url":"https://api.github.com/repos/aaltay/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaltay/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaltay/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaltay/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaltay/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/aaltay/beam/languages","stargazers_url":"https://api.github.com/repos/aaltay/beam/stargazers","contributors_url":"https://api.github.com/repos/aaltay/beam/contributors","subscribers_url":"https://api.github.com/repos/aaltay/beam/subscribers","subscription_url":"https://api.github.com/repos/aaltay/beam/subscription","commits_url":"https://api.github.com/repos/aaltay/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaltay/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaltay/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaltay/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaltay/beam/contents/{+path}","compare_url":"https://api.github.com/repos/aaltay/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaltay/beam/merges","archive_url":"https://api.github.com/repos/aaltay/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaltay/beam/downloads","issues_url":"https://api.github.com/repos/aaltay/beam/issues{/number}","pulls_url":"https://api.github.com/repos/aaltay/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/aaltay/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/aaltay/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaltay/beam/labels{/name}","releases_url":"https://api.github.com/repos/aaltay/beam/releases{/id}","deployments_url":"https://api.github.com/repos/aaltay/beam/deployments","created_at":"2016-06-15T23:05:25Z","updated_at":"2018-04-20T20:43:34Z","pushed_at":"2018-10-02T00:43:10Z","git_url":"git://github.com/aaltay/beam.git","ssh_url":"git@github.com:aaltay/beam.git","clone_url":"https://github.com/aaltay/beam.git","svn_url":"https://github.com/aaltay/beam","homepage":null,"size":99168,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f219bb175ea014dff4dea40a4986c81d2856b5ec","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-10-03T20:56:36Z","pushed_at":"2018-10-03T21:05:13Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":105752,"stargazers_count":2202,"watchers_count":2202,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1365,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1365,"open_issues":86,"watchers":2202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6535"},"html":{"href":"https://github.com/apache/beam/pull/6535"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6535"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6535/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6535/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6535/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/3ae91b33c6386173f3e038e4d027fde9626dc80b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charlesccychen"}}