{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/188814892","pull_request_review_id":120869089,"id":188814892,"diff_hunk":"@@ -1284,7 +1284,7 @@ func NewTokenProvider(\n }\n \n func (as *authStore) WithRoot(ctx context.Context) context.Context {\n-\tif !as.IsAuthEnabled() {\n+\tif tt := tokenProviderType(as); tt != \"simple\" || !as.IsAuthEnabled() {","path":"auth/store.go","position":5,"original_position":5,"commit_id":"042033fdc9eb4a3d1203faddb9fe6c823c39181c","original_commit_id":"042033fdc9eb4a3d1203faddb9fe6c823c39181c","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars0.githubusercontent.com/u/4479947?v=4","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"we probably should define \"simple\" as a const.","created_at":"2018-05-17T01:09:14Z","updated_at":"2018-05-17T01:09:15Z","html_url":"https://github.com/coreos/etcd/pull/9698#discussion_r188814892","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/9698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/188814892"},"html":{"href":"https://github.com/coreos/etcd/pull/9698#discussion_r188814892"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9698"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/9698","id":186091540,"html_url":"https://github.com/coreos/etcd/pull/9698","diff_url":"https://github.com/coreos/etcd/pull/9698.diff","patch_url":"https://github.com/coreos/etcd/pull/9698.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/9698","number":9698,"state":"open","locked":false,"title":"auth: add type checking of tokenProvider","user":{"login":"hexfusion","id":1249749,"avatar_url":"https://avatars0.githubusercontent.com/u/1249749?v=4","gravatar_id":"","url":"https://api.github.com/users/hexfusion","html_url":"https://github.com/hexfusion","followers_url":"https://api.github.com/users/hexfusion/followers","following_url":"https://api.github.com/users/hexfusion/following{/other_user}","gists_url":"https://api.github.com/users/hexfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfusion/subscriptions","organizations_url":"https://api.github.com/users/hexfusion/orgs","repos_url":"https://api.github.com/users/hexfusion/repos","events_url":"https://api.github.com/users/hexfusion/events{/privacy}","received_events_url":"https://api.github.com/users/hexfusion/received_events","type":"User","site_admin":false},"body":"ref: https://github.com/coreos/etcd/issues/9695","created_at":"2018-05-04T20:18:14Z","updated_at":"2018-05-17T01:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8355baa5c40c83cdcce124c98c2bdd2d64b4e6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/9698/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/9698/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/9698/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/042033fdc9eb4a3d1203faddb9fe6c823c39181c","head":{"label":"hexfusion:fx_auth","ref":"fx_auth","sha":"042033fdc9eb4a3d1203faddb9fe6c823c39181c","user":{"login":"hexfusion","id":1249749,"avatar_url":"https://avatars0.githubusercontent.com/u/1249749?v=4","gravatar_id":"","url":"https://api.github.com/users/hexfusion","html_url":"https://github.com/hexfusion","followers_url":"https://api.github.com/users/hexfusion/followers","following_url":"https://api.github.com/users/hexfusion/following{/other_user}","gists_url":"https://api.github.com/users/hexfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfusion/subscriptions","organizations_url":"https://api.github.com/users/hexfusion/orgs","repos_url":"https://api.github.com/users/hexfusion/repos","events_url":"https://api.github.com/users/hexfusion/events{/privacy}","received_events_url":"https://api.github.com/users/hexfusion/received_events","type":"User","site_admin":false},"repo":{"id":87868847,"name":"etcd","full_name":"hexfusion/etcd","owner":{"login":"hexfusion","id":1249749,"avatar_url":"https://avatars0.githubusercontent.com/u/1249749?v=4","gravatar_id":"","url":"https://api.github.com/users/hexfusion","html_url":"https://github.com/hexfusion","followers_url":"https://api.github.com/users/hexfusion/followers","following_url":"https://api.github.com/users/hexfusion/following{/other_user}","gists_url":"https://api.github.com/users/hexfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfusion/subscriptions","organizations_url":"https://api.github.com/users/hexfusion/orgs","repos_url":"https://api.github.com/users/hexfusion/repos","events_url":"https://api.github.com/users/hexfusion/events{/privacy}","received_events_url":"https://api.github.com/users/hexfusion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hexfusion/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/hexfusion/etcd","forks_url":"https://api.github.com/repos/hexfusion/etcd/forks","keys_url":"https://api.github.com/repos/hexfusion/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexfusion/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexfusion/etcd/teams","hooks_url":"https://api.github.com/repos/hexfusion/etcd/hooks","issue_events_url":"https://api.github.com/repos/hexfusion/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/hexfusion/etcd/events","assignees_url":"https://api.github.com/repos/hexfusion/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/hexfusion/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/hexfusion/etcd/tags","blobs_url":"https://api.github.com/repos/hexfusion/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexfusion/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexfusion/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexfusion/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexfusion/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/hexfusion/etcd/languages","stargazers_url":"https://api.github.com/repos/hexfusion/etcd/stargazers","contributors_url":"https://api.github.com/repos/hexfusion/etcd/contributors","subscribers_url":"https://api.github.com/repos/hexfusion/etcd/subscribers","subscription_url":"https://api.github.com/repos/hexfusion/etcd/subscription","commits_url":"https://api.github.com/repos/hexfusion/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexfusion/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexfusion/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexfusion/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexfusion/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/hexfusion/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexfusion/etcd/merges","archive_url":"https://api.github.com/repos/hexfusion/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexfusion/etcd/downloads","issues_url":"https://api.github.com/repos/hexfusion/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/hexfusion/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/hexfusion/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/hexfusion/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexfusion/etcd/labels{/name}","releases_url":"https://api.github.com/repos/hexfusion/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/hexfusion/etcd/deployments","created_at":"2017-04-11T00:05:12Z","updated_at":"2018-05-15T21:46:14Z","pushed_at":"2018-05-16T02:53:30Z","git_url":"git://github.com/hexfusion/etcd.git","ssh_url":"git@github.com:hexfusion/etcd.git","clone_url":"https://github.com/hexfusion/etcd.git","svn_url":"https://github.com/hexfusion/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":38362,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"4a4be9275c033505555f75c61890498099a895c6","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2018-05-17T00:12:06Z","pushed_at":"2018-05-17T00:11:53Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":38994,"stargazers_count":18362,"watchers_count":18362,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3630,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3630,"open_issues":252,"watchers":18362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9698"},"html":{"href":"https://github.com/coreos/etcd/pull/9698"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/9698"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/9698/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9698/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9698/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/042033fdc9eb4a3d1203faddb9fe6c823c39181c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xiang90"}}