{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/169688617","pull_request_review_id":98255451,"id":169688617,"diff_hunk":"@@ -106,38 +106,68 @@ Various types for common financial concepts like day roll conventions, fixes, et\n \n WARNING: NOT API STABLE.\n \n-# net.corda.finance.contracts.asset\n+# Package net.corda.finance.contracts.asset\n \n Cash states, obligations and commodities. \n \n WARNING: NOT API STABLE. \n \n-# net.corda.finance.contracts.asset.cash.selection\n+# Package net.corda.finance.contracts.asset.cash.selection\n \n Provisional support for pluggable cash selectors, needed for different database backends. \n \n WARNING: NOT API STABLE. \n \n-# net.corda.finance.contracts.math\n+# Package net.corda.finance.contracts.math\n \n Splines and interpolation.\n \n WARNING: NOT API STABLE. \n \n-# net.corda.finance.flows\n+# Package net.corda.finance.flows\n \n Cash payments and issuances. Two party \"delivery vs payment\" atomic asset swaps.\n \n WARNING: NOT API STABLE. \n \n-# net.corda.finance.plugin\n+# Package net.corda.finance.plugin\n \n JSON/Jackson plugin for business calendars.\n \n WARNING: NOT API STABLE.\n \n-# net.corda.finance.schemas\n+# Package net.corda.finance.schemas\n \n JPA (Java Persistence Architecture) schemas for the financial state types.\n \n+WARNING: NOT API STABLE.\n+\n+# Package net.corda.testing.core\n+\n+Generic test utilities for contracts and flows\n+\n+# Package net.corda.testing.node\n+\n+Test utilites to help running nodes programmatically for tests\n+\n+# Package net.corda.testing.driver\n+\n+Test utilites to help running nodes programmatically for tests\n+\n+# Package net.corda.testing.dsl\n+\n+A simple DSL for building pseudo-transactions (not the same as the wire protocol) for testing purposes\n+ \n+# Package net.corda.testing.contracts\n+\n+Dummy state and contracts for testing purposes\n+\n+# Package net.corda.testing.services\n+\n+Mock service implementations for testing purposes\n+\n+# Package net.corda.testing.http","path":"docs/packages.md","position":70,"original_position":70,"commit_id":"a4da2af7dc3bfe66292e2798e94fd583cdd21ec7","original_commit_id":"a4da2af7dc3bfe66292e2798e94fd583cdd21ec7","user":{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false},"body":"We had a discussion about this on another PR: https://github.com/corda/corda/pull/2335#discussion-diff-162009731R52\r\nThe end decision was to leave as is for now, as they are used by a lot of the samples, which is why I've left them as 'unstable api'.","created_at":"2018-02-21T16:09:12Z","updated_at":"2018-02-21T16:09:12Z","html_url":"https://github.com/corda/corda/pull/2584#discussion_r169688617","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2584","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/169688617"},"html":{"href":"https://github.com/corda/corda/pull/2584#discussion_r169688617"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2584"}},"in_reply_to_id":169448553},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2584","id":170262714,"html_url":"https://github.com/corda/corda/pull/2584","diff_url":"https://github.com/corda/corda/pull/2584.diff","patch_url":"https://github.com/corda/corda/pull/2584.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2584","number":2584,"state":"open","locked":false,"title":"[CORDA-1035] Testing api KDoc Updates","user":{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false},"body":"A first stab at updating missing KDocs for testing api.","created_at":"2018-02-20T17:45:50Z","updated_at":"2018-02-21T16:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"321c663e66d06381b7cb3b742002beb51c361603","assignee":{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mikehearn","id":971089,"avatar_url":"https://avatars2.githubusercontent.com/u/971089?v=4","gravatar_id":"","url":"https://api.github.com/users/mikehearn","html_url":"https://github.com/mikehearn","followers_url":"https://api.github.com/users/mikehearn/followers","following_url":"https://api.github.com/users/mikehearn/following{/other_user}","gists_url":"https://api.github.com/users/mikehearn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehearn/subscriptions","organizations_url":"https://api.github.com/users/mikehearn/orgs","repos_url":"https://api.github.com/users/mikehearn/repos","events_url":"https://api.github.com/users/mikehearn/events{/privacy}","received_events_url":"https://api.github.com/users/mikehearn/received_events","type":"User","site_admin":false},{"login":"andr3ej","id":26927791,"avatar_url":"https://avatars3.githubusercontent.com/u/26927791?v=4","gravatar_id":"","url":"https://api.github.com/users/andr3ej","html_url":"https://github.com/andr3ej","followers_url":"https://api.github.com/users/andr3ej/followers","following_url":"https://api.github.com/users/andr3ej/following{/other_user}","gists_url":"https://api.github.com/users/andr3ej/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3ej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3ej/subscriptions","organizations_url":"https://api.github.com/users/andr3ej/orgs","repos_url":"https://api.github.com/users/andr3ej/repos","events_url":"https://api.github.com/users/andr3ej/events{/privacy}","received_events_url":"https://api.github.com/users/andr3ej/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2584/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2584/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2584/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/a4da2af7dc3bfe66292e2798e94fd583cdd21ec7","head":{"label":"corda:anthony-testing-api-kdocs","ref":"anthony-testing-api-kdocs","sha":"a4da2af7dc3bfe66292e2798e94fd583cdd21ec7","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-21T11:02:45Z","pushed_at":"2018-02-21T16:07:32Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":108713,"stargazers_count":1491,"watchers_count":1491,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":400,"open_issues":132,"watchers":1491,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"2cf2fdbc060c0d1455b3cb269c3dabc6bea54894","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-21T11:02:45Z","pushed_at":"2018-02-21T16:07:32Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":108713,"stargazers_count":1491,"watchers_count":1491,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":400,"open_issues":132,"watchers":1491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2584"},"html":{"href":"https://github.com/corda/corda/pull/2584"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2584"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2584/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2584/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2584/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/a4da2af7dc3bfe66292e2798e94fd583cdd21ec7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anthonykr3"}}