{"action":"created","issue":{"url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12399","repository_url":"https://api.github.com/repos/web-platform-tests/wpt","labels_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12399/labels{/name}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12399/comments","events_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12399/events","html_url":"https://github.com/web-platform-tests/wpt/pull/12399","id":349389958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTE3MDQy","number":12399,"title":"fix(resources/testdriver): wait for a document.body","user":{"login":"marcoscaceres","id":870154,"node_id":"MDQ6VXNlcjg3MDE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"labels":[{"id":45230790,"node_id":"MDU6TGFiZWw0NTIzMDc5MA==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/infra","name":"infra","color":"fbca04","default":false},{"id":744682968,"node_id":"MDU6TGFiZWw3NDQ2ODI5Njg=","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/testdriver.js","name":"testdriver.js","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-10T06:20:39Z","updated_at":"2018-08-10T16:17:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/12399","html_url":"https://github.com/web-platform-tests/wpt/pull/12399","diff_url":"https://github.com/web-platform-tests/wpt/pull/12399.diff","patch_url":"https://github.com/web-platform-tests/wpt/pull/12399.patch"},"body":"`bless()` is racy with document.body. It should actually wait for there to be a body."},"comment":{"url":"https://api.github.com/repos/web-platform-tests/wpt/issues/comments/412132138","html_url":"https://github.com/web-platform-tests/wpt/pull/12399#issuecomment-412132138","issue_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/12399","id":412132138,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjEzMjEzOA==","user":{"login":"gsnedders","id":176218,"node_id":"MDQ6VXNlcjE3NjIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/176218?v=4","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T16:17:00Z","updated_at":"2018-08-10T16:17:00Z","author_association":"CONTRIBUTOR","body":"> This patch introduces ES2017 syntax which bucks the trend in the testdriver.js utility and in the resources/ directory at large. I don't think that's necessary; is that right?\r\n\r\nOh that's true, and as long as https://github.com/servo/servo/issues/20585 is yet to land it'll break it on Servo (though AFAIK there's no Servo support for it), so idk how much that matters.\r\n\r\n> What do you think about waiting for a test to require support for that?\r\n\r\nFWIW, I know we've had previous cases where people have avoided features because \"oh that doesn't work unless you're HTML\" before without telling us for a long time, so I'd rather have a small workaround for it (`(document.body || document.documentElement)` should do).\r\n\r\n> Can you say more?\r\n\r\nNormally tests start running before DOMContentLoaded, so this would be a subtle difference when using `bless`, which doesn't seem ideal."}}
{"actor":{"display_login":"gsnedders"}}