{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/202221776","pull_request_review_id":136880143,"id":202221776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIyMTc3Ng==","diff_hunk":"@@ -684,7 +683,7 @@ def scalar_search_armijo(phi, phi0, derphi0, c1=1e-4, alpha0=1, amin=0):\n \n     # Otherwise compute the minimizer of a quadratic interpolant:\n \n-    alpha1 = -(derphi0) * alpha0**2 / 2.0 / (phi_a0 - phi0 - derphi0 * alpha0)\n+    alpha1 = _quadmin(0, phi0, derphi0, alpha0, phi_a0)","path":"scipy/optimize/linesearch.py","position":40,"original_position":40,"commit_id":"035b021352d7c26fa9443f3ed225bbfdaf0400fd","original_commit_id":"f0a15f6e3b4e002b47da90117985c0ff43096f3c","user":{"login":"Watesoyan","id":31439027,"node_id":"MDQ6VXNlcjMxNDM5MDI3","avatar_url":"https://avatars3.githubusercontent.com/u/31439027?v=4","gravatar_id":"","url":"https://api.github.com/users/Watesoyan","html_url":"https://github.com/Watesoyan","followers_url":"https://api.github.com/users/Watesoyan/followers","following_url":"https://api.github.com/users/Watesoyan/following{/other_user}","gists_url":"https://api.github.com/users/Watesoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/Watesoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watesoyan/subscriptions","organizations_url":"https://api.github.com/users/Watesoyan/orgs","repos_url":"https://api.github.com/users/Watesoyan/repos","events_url":"https://api.github.com/users/Watesoyan/events{/privacy}","received_events_url":"https://api.github.com/users/Watesoyan/received_events","type":"User","site_admin":false},"body":"I add code to handle this case.","created_at":"2018-07-13T01:16:45Z","updated_at":"2018-07-13T01:16:45Z","html_url":"https://github.com/scipy/scipy/pull/9019#discussion_r202221776","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/9019","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/202221776"},"html":{"href":"https://github.com/scipy/scipy/pull/9019#discussion_r202221776"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9019"}},"in_reply_to_id":202061525},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/9019","id":200670837,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjcwODM3","html_url":"https://github.com/scipy/scipy/pull/9019","diff_url":"https://github.com/scipy/scipy/pull/9019.diff","patch_url":"https://github.com/scipy/scipy/pull/9019.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/9019","number":9019,"state":"open","locked":false,"title":"MAINT: code cleanup in optimize/linesearch","user":{"login":"Watesoyan","id":31439027,"node_id":"MDQ6VXNlcjMxNDM5MDI3","avatar_url":"https://avatars3.githubusercontent.com/u/31439027?v=4","gravatar_id":"","url":"https://api.github.com/users/Watesoyan","html_url":"https://github.com/Watesoyan","followers_url":"https://api.github.com/users/Watesoyan/followers","following_url":"https://api.github.com/users/Watesoyan/following{/other_user}","gists_url":"https://api.github.com/users/Watesoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/Watesoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watesoyan/subscriptions","organizations_url":"https://api.github.com/users/Watesoyan/orgs","repos_url":"https://api.github.com/users/Watesoyan/repos","events_url":"https://api.github.com/users/Watesoyan/events{/privacy}","received_events_url":"https://api.github.com/users/Watesoyan/received_events","type":"User","site_admin":false},"body":"simplify codes and reuse the functions, like `_quadmin` and `_cubicmin`","created_at":"2018-07-11T11:36:59Z","updated_at":"2018-07-13T01:16:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdce17609a564dec234ec6ecd255b7a806bcbadc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":108549863,"node_id":"MDU6TGFiZWwxMDg1NDk4NjM=","url":"https://api.github.com/repos/scipy/scipy/labels/maintenance","name":"maintenance","color":"fef2c0","default":false},{"id":37341011,"node_id":"MDU6TGFiZWwzNzM0MTAxMQ==","url":"https://api.github.com/repos/scipy/scipy/labels/scipy.optimize","name":"scipy.optimize","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/9019/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/9019/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/9019/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/035b021352d7c26fa9443f3ed225bbfdaf0400fd","head":{"label":"Watesoyan:master","ref":"master","sha":"035b021352d7c26fa9443f3ed225bbfdaf0400fd","user":{"login":"Watesoyan","id":31439027,"node_id":"MDQ6VXNlcjMxNDM5MDI3","avatar_url":"https://avatars3.githubusercontent.com/u/31439027?v=4","gravatar_id":"","url":"https://api.github.com/users/Watesoyan","html_url":"https://github.com/Watesoyan","followers_url":"https://api.github.com/users/Watesoyan/followers","following_url":"https://api.github.com/users/Watesoyan/following{/other_user}","gists_url":"https://api.github.com/users/Watesoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/Watesoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watesoyan/subscriptions","organizations_url":"https://api.github.com/users/Watesoyan/orgs","repos_url":"https://api.github.com/users/Watesoyan/repos","events_url":"https://api.github.com/users/Watesoyan/events{/privacy}","received_events_url":"https://api.github.com/users/Watesoyan/received_events","type":"User","site_admin":false},"repo":{"id":137180860,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxODA4NjA=","name":"scipy","full_name":"Watesoyan/scipy","owner":{"login":"Watesoyan","id":31439027,"node_id":"MDQ6VXNlcjMxNDM5MDI3","avatar_url":"https://avatars3.githubusercontent.com/u/31439027?v=4","gravatar_id":"","url":"https://api.github.com/users/Watesoyan","html_url":"https://github.com/Watesoyan","followers_url":"https://api.github.com/users/Watesoyan/followers","following_url":"https://api.github.com/users/Watesoyan/following{/other_user}","gists_url":"https://api.github.com/users/Watesoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/Watesoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watesoyan/subscriptions","organizations_url":"https://api.github.com/users/Watesoyan/orgs","repos_url":"https://api.github.com/users/Watesoyan/repos","events_url":"https://api.github.com/users/Watesoyan/events{/privacy}","received_events_url":"https://api.github.com/users/Watesoyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Watesoyan/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/Watesoyan/scipy","forks_url":"https://api.github.com/repos/Watesoyan/scipy/forks","keys_url":"https://api.github.com/repos/Watesoyan/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Watesoyan/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Watesoyan/scipy/teams","hooks_url":"https://api.github.com/repos/Watesoyan/scipy/hooks","issue_events_url":"https://api.github.com/repos/Watesoyan/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/Watesoyan/scipy/events","assignees_url":"https://api.github.com/repos/Watesoyan/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/Watesoyan/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/Watesoyan/scipy/tags","blobs_url":"https://api.github.com/repos/Watesoyan/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Watesoyan/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Watesoyan/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Watesoyan/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Watesoyan/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/Watesoyan/scipy/languages","stargazers_url":"https://api.github.com/repos/Watesoyan/scipy/stargazers","contributors_url":"https://api.github.com/repos/Watesoyan/scipy/contributors","subscribers_url":"https://api.github.com/repos/Watesoyan/scipy/subscribers","subscription_url":"https://api.github.com/repos/Watesoyan/scipy/subscription","commits_url":"https://api.github.com/repos/Watesoyan/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Watesoyan/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Watesoyan/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Watesoyan/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Watesoyan/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/Watesoyan/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Watesoyan/scipy/merges","archive_url":"https://api.github.com/repos/Watesoyan/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Watesoyan/scipy/downloads","issues_url":"https://api.github.com/repos/Watesoyan/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/Watesoyan/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/Watesoyan/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/Watesoyan/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Watesoyan/scipy/labels{/name}","releases_url":"https://api.github.com/repos/Watesoyan/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/Watesoyan/scipy/deployments","created_at":"2018-06-13T07:44:33Z","updated_at":"2018-07-13T01:12:36Z","pushed_at":"2018-07-13T01:12:32Z","git_url":"git://github.com/Watesoyan/scipy.git","ssh_url":"git@github.com:Watesoyan/scipy.git","clone_url":"https://github.com/Watesoyan/scipy.git","svn_url":"https://github.com/Watesoyan/scipy","homepage":"http://scipy.org/scipylib/","size":78197,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"ac516baa243a20b5ebe056be6e2cf4c698ccfa7d","user":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzg1","name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-07-12T19:05:22Z","pushed_at":"2018-07-13T01:12:33Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"https://scipy.org/scipylib/","size":81006,"stargazers_count":4632,"watchers_count":4632,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2405,"mirror_url":null,"archived":false,"open_issues_count":1280,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2405,"open_issues":1280,"watchers":4632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9019"},"html":{"href":"https://github.com/scipy/scipy/pull/9019"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/9019"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/9019/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9019/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9019/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/035b021352d7c26fa9443f3ed225bbfdaf0400fd"}},"author_association":"NONE"}}
{"actor":{"display_login":"Watesoyan"}}