{"action":"created","comment":{"url":"https://api.github.com/repos/eos/eos/pulls/comments/177054541","pull_request_review_id":106859679,"id":177054541,"diff_hunk":"@@ -1081,43 +1090,36 @@ namespace eos\n \n             virtual double sample(gsl_rng * rng) const\n             {\n-                // Holds the samples in n dimensions\n-                std::array<double, n_> random_samples;\n+                auto k = _mean->size;\n \n-                // generate standard normals\n-                std::generate(random_samples.begin(), random_samples.end(), std::bind(gsl_ran_ugaussian, rng));\n+                // generate standard normals in observables\n+                for (auto i = 0u ; i < k ; ++i)\n+                {\n+                    gsl_vector_set(_observables, i, gsl_ran_ugaussian(rng));\n+                }\n \n-                // transform\n-                random_samples = chol * random_samples;\n+                // transform: observables2 <- _chol * observables\n+                gsl_blas_dgemv(CblasNoTrans, 1.0, _chol, _observables, 0.0, _observables_2);","path":"eos/statistics/log-likelihood.cc","position":346,"original_position":346,"commit_id":"9ca1cc8bffb55ab4a68412ba6dcaf9fbc8474456","original_commit_id":"9ca1cc8bffb55ab4a68412ba6dcaf9fbc8474456","user":{"login":"dvandyk","id":42914,"avatar_url":"https://avatars1.githubusercontent.com/u/42914?v=4","gravatar_id":"","url":"https://api.github.com/users/dvandyk","html_url":"https://github.com/dvandyk","followers_url":"https://api.github.com/users/dvandyk/followers","following_url":"https://api.github.com/users/dvandyk/following{/other_user}","gists_url":"https://api.github.com/users/dvandyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dvandyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvandyk/subscriptions","organizations_url":"https://api.github.com/users/dvandyk/orgs","repos_url":"https://api.github.com/users/dvandyk/repos","events_url":"https://api.github.com/users/dvandyk/events{/privacy}","received_events_url":"https://api.github.com/users/dvandyk/received_events","type":"User","site_admin":false},"body":"In principal a good idea. However, present GSL deprecated the ```gsl_linalg_cholesky_decomp``` function, and I cannot find out easily right now what the correct output is (upper/lower diagonal).\r\nMight be a good idea to open a new issue to keep track of this #70.","created_at":"2018-03-26T11:13:51Z","updated_at":"2018-03-26T11:13:51Z","html_url":"https://github.com/eos/eos/pull/66#discussion_r177054541","pull_request_url":"https://api.github.com/repos/eos/eos/pulls/66","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eos/eos/pulls/comments/177054541"},"html":{"href":"https://github.com/eos/eos/pull/66#discussion_r177054541"},"pull_request":{"href":"https://api.github.com/repos/eos/eos/pulls/66"}},"in_reply_to_id":177003342},"pull_request":{"url":"https://api.github.com/repos/eos/eos/pulls/66","id":177246795,"html_url":"https://github.com/eos/eos/pull/66","diff_url":"https://github.com/eos/eos/pull/66.diff","patch_url":"https://github.com/eos/eos/pull/66.patch","issue_url":"https://api.github.com/repos/eos/eos/issues/66","number":66,"state":"open","locked":false,"title":"Get rid of templated MultivariateGaussianBlock","user":{"login":"dvandyk","id":42914,"avatar_url":"https://avatars1.githubusercontent.com/u/42914?v=4","gravatar_id":"","url":"https://api.github.com/users/dvandyk","html_url":"https://github.com/dvandyk","followers_url":"https://api.github.com/users/dvandyk/followers","following_url":"https://api.github.com/users/dvandyk/following{/other_user}","gists_url":"https://api.github.com/users/dvandyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dvandyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvandyk/subscriptions","organizations_url":"https://api.github.com/users/dvandyk/orgs","repos_url":"https://api.github.com/users/dvandyk/repos","events_url":"https://api.github.com/users/dvandyk/events{/privacy}","received_events_url":"https://api.github.com/users/dvandyk/received_events","type":"User","site_admin":false},"body":"@fredRos I would love if you could review these two commits. Tests are passing locally.","created_at":"2018-03-24T16:52:16Z","updated_at":"2018-03-26T11:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"170bad81fb52b778654abc8443f52c3c6fe45ea0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eos/eos/pulls/66/commits","review_comments_url":"https://api.github.com/repos/eos/eos/pulls/66/comments","review_comment_url":"https://api.github.com/repos/eos/eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eos/eos/issues/66/comments","statuses_url":"https://api.github.com/repos/eos/eos/statuses/9ca1cc8bffb55ab4a68412ba6dcaf9fbc8474456","head":{"label":"dvandyk:statistics","ref":"statistics","sha":"9ca1cc8bffb55ab4a68412ba6dcaf9fbc8474456","user":{"login":"dvandyk","id":42914,"avatar_url":"https://avatars1.githubusercontent.com/u/42914?v=4","gravatar_id":"","url":"https://api.github.com/users/dvandyk","html_url":"https://github.com/dvandyk","followers_url":"https://api.github.com/users/dvandyk/followers","following_url":"https://api.github.com/users/dvandyk/following{/other_user}","gists_url":"https://api.github.com/users/dvandyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dvandyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvandyk/subscriptions","organizations_url":"https://api.github.com/users/dvandyk/orgs","repos_url":"https://api.github.com/users/dvandyk/repos","events_url":"https://api.github.com/users/dvandyk/events{/privacy}","received_events_url":"https://api.github.com/users/dvandyk/received_events","type":"User","site_admin":false},"repo":{"id":46611195,"name":"eos","full_name":"dvandyk/eos","owner":{"login":"dvandyk","id":42914,"avatar_url":"https://avatars1.githubusercontent.com/u/42914?v=4","gravatar_id":"","url":"https://api.github.com/users/dvandyk","html_url":"https://github.com/dvandyk","followers_url":"https://api.github.com/users/dvandyk/followers","following_url":"https://api.github.com/users/dvandyk/following{/other_user}","gists_url":"https://api.github.com/users/dvandyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dvandyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvandyk/subscriptions","organizations_url":"https://api.github.com/users/dvandyk/orgs","repos_url":"https://api.github.com/users/dvandyk/repos","events_url":"https://api.github.com/users/dvandyk/events{/privacy}","received_events_url":"https://api.github.com/users/dvandyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvandyk/eos","description":null,"fork":true,"url":"https://api.github.com/repos/dvandyk/eos","forks_url":"https://api.github.com/repos/dvandyk/eos/forks","keys_url":"https://api.github.com/repos/dvandyk/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvandyk/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvandyk/eos/teams","hooks_url":"https://api.github.com/repos/dvandyk/eos/hooks","issue_events_url":"https://api.github.com/repos/dvandyk/eos/issues/events{/number}","events_url":"https://api.github.com/repos/dvandyk/eos/events","assignees_url":"https://api.github.com/repos/dvandyk/eos/assignees{/user}","branches_url":"https://api.github.com/repos/dvandyk/eos/branches{/branch}","tags_url":"https://api.github.com/repos/dvandyk/eos/tags","blobs_url":"https://api.github.com/repos/dvandyk/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvandyk/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvandyk/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvandyk/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvandyk/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/dvandyk/eos/languages","stargazers_url":"https://api.github.com/repos/dvandyk/eos/stargazers","contributors_url":"https://api.github.com/repos/dvandyk/eos/contributors","subscribers_url":"https://api.github.com/repos/dvandyk/eos/subscribers","subscription_url":"https://api.github.com/repos/dvandyk/eos/subscription","commits_url":"https://api.github.com/repos/dvandyk/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvandyk/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvandyk/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvandyk/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvandyk/eos/contents/{+path}","compare_url":"https://api.github.com/repos/dvandyk/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvandyk/eos/merges","archive_url":"https://api.github.com/repos/dvandyk/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvandyk/eos/downloads","issues_url":"https://api.github.com/repos/dvandyk/eos/issues{/number}","pulls_url":"https://api.github.com/repos/dvandyk/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/dvandyk/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/dvandyk/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvandyk/eos/labels{/name}","releases_url":"https://api.github.com/repos/dvandyk/eos/releases{/id}","deployments_url":"https://api.github.com/repos/dvandyk/eos/deployments","created_at":"2015-11-21T10:39:59Z","updated_at":"2016-03-02T15:56:38Z","pushed_at":"2018-03-24T21:03:19Z","git_url":"git://github.com/dvandyk/eos.git","ssh_url":"git@github.com:dvandyk/eos.git","clone_url":"https://github.com/dvandyk/eos.git","svn_url":"https://github.com/dvandyk/eos","homepage":null,"size":26470,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eos:master","ref":"master","sha":"6fe886fe39b55a3825aae111393c90b2dabc9f3a","user":{"login":"eos","id":15954791,"avatar_url":"https://avatars0.githubusercontent.com/u/15954791?v=4","gravatar_id":"","url":"https://api.github.com/users/eos","html_url":"https://github.com/eos","followers_url":"https://api.github.com/users/eos/followers","following_url":"https://api.github.com/users/eos/following{/other_user}","gists_url":"https://api.github.com/users/eos/gists{/gist_id}","starred_url":"https://api.github.com/users/eos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eos/subscriptions","organizations_url":"https://api.github.com/users/eos/orgs","repos_url":"https://api.github.com/users/eos/repos","events_url":"https://api.github.com/users/eos/events{/privacy}","received_events_url":"https://api.github.com/users/eos/received_events","type":"Organization","site_admin":false},"repo":{"id":46610880,"name":"eos","full_name":"eos/eos","owner":{"login":"eos","id":15954791,"avatar_url":"https://avatars0.githubusercontent.com/u/15954791?v=4","gravatar_id":"","url":"https://api.github.com/users/eos","html_url":"https://github.com/eos","followers_url":"https://api.github.com/users/eos/followers","following_url":"https://api.github.com/users/eos/following{/other_user}","gists_url":"https://api.github.com/users/eos/gists{/gist_id}","starred_url":"https://api.github.com/users/eos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eos/subscriptions","organizations_url":"https://api.github.com/users/eos/orgs","repos_url":"https://api.github.com/users/eos/repos","events_url":"https://api.github.com/users/eos/events{/privacy}","received_events_url":"https://api.github.com/users/eos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eos/eos","description":"A HEP Program for Flavor Observables","fork":false,"url":"https://api.github.com/repos/eos/eos","forks_url":"https://api.github.com/repos/eos/eos/forks","keys_url":"https://api.github.com/repos/eos/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eos/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eos/eos/teams","hooks_url":"https://api.github.com/repos/eos/eos/hooks","issue_events_url":"https://api.github.com/repos/eos/eos/issues/events{/number}","events_url":"https://api.github.com/repos/eos/eos/events","assignees_url":"https://api.github.com/repos/eos/eos/assignees{/user}","branches_url":"https://api.github.com/repos/eos/eos/branches{/branch}","tags_url":"https://api.github.com/repos/eos/eos/tags","blobs_url":"https://api.github.com/repos/eos/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eos/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eos/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/eos/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eos/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/eos/eos/languages","stargazers_url":"https://api.github.com/repos/eos/eos/stargazers","contributors_url":"https://api.github.com/repos/eos/eos/contributors","subscribers_url":"https://api.github.com/repos/eos/eos/subscribers","subscription_url":"https://api.github.com/repos/eos/eos/subscription","commits_url":"https://api.github.com/repos/eos/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/eos/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/eos/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/eos/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/eos/eos/contents/{+path}","compare_url":"https://api.github.com/repos/eos/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eos/eos/merges","archive_url":"https://api.github.com/repos/eos/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eos/eos/downloads","issues_url":"https://api.github.com/repos/eos/eos/issues{/number}","pulls_url":"https://api.github.com/repos/eos/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/eos/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/eos/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eos/eos/labels{/name}","releases_url":"https://api.github.com/repos/eos/eos/releases{/id}","deployments_url":"https://api.github.com/repos/eos/eos/deployments","created_at":"2015-11-21T10:27:58Z","updated_at":"2018-03-26T09:42:11Z","pushed_at":"2018-03-26T09:42:09Z","git_url":"git://github.com/eos/eos.git","ssh_url":"git@github.com:eos/eos.git","clone_url":"https://github.com/eos/eos.git","svn_url":"https://github.com/eos/eos","homepage":"https://eos.github.io/","size":26360,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":13,"open_issues":34,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eos/eos/pulls/66"},"html":{"href":"https://github.com/eos/eos/pull/66"},"issue":{"href":"https://api.github.com/repos/eos/eos/issues/66"},"comments":{"href":"https://api.github.com/repos/eos/eos/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/eos/eos/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/eos/eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eos/eos/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/eos/eos/statuses/9ca1cc8bffb55ab4a68412ba6dcaf9fbc8474456"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dvandyk"}}