{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/234100105","pull_request_review_id":175669808,"id":234100105,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDEwMDEwNQ==","diff_hunk":"@@ -17,7 +17,7 @@\n _range = range\n \n \n-def _hist_bin_sqrt(x):\n+def _hist_bin_sqrt(x, _):","path":"numpy/lib/histograms.py","position":5,"original_position":5,"commit_id":"3c024c865b45f0d424f61094cd7674c85c7fcd46","original_commit_id":"5cbc81705472f185230fc126c787b58d7406d6ce","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"body":"Did you see this comment?","created_at":"2018-11-16T06:20:06Z","updated_at":"2018-11-16T06:20:06Z","html_url":"https://github.com/numpy/numpy/pull/8923#discussion_r234100105","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/8923","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/234100105"},"html":{"href":"https://github.com/numpy/numpy/pull/8923#discussion_r234100105"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8923"}},"in_reply_to_id":233241014},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/8923","id":115193437,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE1MTkzNDM3","html_url":"https://github.com/numpy/numpy/pull/8923","diff_url":"https://github.com/numpy/numpy/pull/8923.diff","patch_url":"https://github.com/numpy/numpy/pull/8923.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/8923","number":8923,"state":"open","locked":false,"title":"ENH: Add 'ise' estimator to np.histogram","user":{"login":"guoci","id":1260178,"node_id":"MDQ6VXNlcjEyNjAxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1260178?v=4","gravatar_id":"","url":"https://api.github.com/users/guoci","html_url":"https://github.com/guoci","followers_url":"https://api.github.com/users/guoci/followers","following_url":"https://api.github.com/users/guoci/following{/other_user}","gists_url":"https://api.github.com/users/guoci/gists{/gist_id}","starred_url":"https://api.github.com/users/guoci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoci/subscriptions","organizations_url":"https://api.github.com/users/guoci/orgs","repos_url":"https://api.github.com/users/guoci/repos","events_url":"https://api.github.com/users/guoci/events{/privacy}","received_events_url":"https://api.github.com/users/guoci/received_events","type":"User","site_admin":false},"body":"I have been using an estimator based on minimizing the estimated integrated squared error (ISE), and is a generalization of Scott's rule.\r\n\r\nhttps://en.wikipedia.org/wiki/Histogram\r\n\r\nUnlike most other methods, this estimation does not depend on the dataset size but depends on the nature of the observed distribution.\r\n","created_at":"2017-04-10T21:11:42Z","updated_at":"2018-11-16T06:20:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"767a8ba8f5e509cb4a30918e288fb61a73fdafa6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359239,"node_id":"MDU6TGFiZWw2MzU5MjM5","url":"https://api.github.com/repos/numpy/numpy/labels/01%20-%20Enhancement","name":"01 - Enhancement","color":"fef2c0","default":false},{"id":16917082,"node_id":"MDU6TGFiZWwxNjkxNzA4Mg==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.lib","name":"component: numpy.lib","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/58","html_url":"https://github.com/numpy/numpy/milestone/58","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/58/labels","id":3353003,"node_id":"MDk6TWlsZXN0b25lMzM1MzAwMw==","number":58,"title":"1.16.0 release","description":"","creator":{"login":"charris","id":77272,"node_id":"MDQ6VXNlcjc3Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":62,"state":"open","created_at":"2018-05-16T21:13:27Z","updated_at":"2018-11-15T20:22:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/8923/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/8923/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/8923/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/3c024c865b45f0d424f61094cd7674c85c7fcd46","head":{"label":"guoci:histo_ise","ref":"histo_ise","sha":"3c024c865b45f0d424f61094cd7674c85c7fcd46","user":{"login":"guoci","id":1260178,"node_id":"MDQ6VXNlcjEyNjAxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1260178?v=4","gravatar_id":"","url":"https://api.github.com/users/guoci","html_url":"https://github.com/guoci","followers_url":"https://api.github.com/users/guoci/followers","following_url":"https://api.github.com/users/guoci/following{/other_user}","gists_url":"https://api.github.com/users/guoci/gists{/gist_id}","starred_url":"https://api.github.com/users/guoci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoci/subscriptions","organizations_url":"https://api.github.com/users/guoci/orgs","repos_url":"https://api.github.com/users/guoci/repos","events_url":"https://api.github.com/users/guoci/events{/privacy}","received_events_url":"https://api.github.com/users/guoci/received_events","type":"User","site_admin":false},"repo":{"id":87853687,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzg1MzY4Nw==","name":"numpy","full_name":"guoci/numpy","private":false,"owner":{"login":"guoci","id":1260178,"node_id":"MDQ6VXNlcjEyNjAxNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1260178?v=4","gravatar_id":"","url":"https://api.github.com/users/guoci","html_url":"https://github.com/guoci","followers_url":"https://api.github.com/users/guoci/followers","following_url":"https://api.github.com/users/guoci/following{/other_user}","gists_url":"https://api.github.com/users/guoci/gists{/gist_id}","starred_url":"https://api.github.com/users/guoci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoci/subscriptions","organizations_url":"https://api.github.com/users/guoci/orgs","repos_url":"https://api.github.com/users/guoci/repos","events_url":"https://api.github.com/users/guoci/events{/privacy}","received_events_url":"https://api.github.com/users/guoci/received_events","type":"User","site_admin":false},"html_url":"https://github.com/guoci/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/guoci/numpy","forks_url":"https://api.github.com/repos/guoci/numpy/forks","keys_url":"https://api.github.com/repos/guoci/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guoci/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guoci/numpy/teams","hooks_url":"https://api.github.com/repos/guoci/numpy/hooks","issue_events_url":"https://api.github.com/repos/guoci/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/guoci/numpy/events","assignees_url":"https://api.github.com/repos/guoci/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/guoci/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/guoci/numpy/tags","blobs_url":"https://api.github.com/repos/guoci/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guoci/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guoci/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/guoci/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guoci/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/guoci/numpy/languages","stargazers_url":"https://api.github.com/repos/guoci/numpy/stargazers","contributors_url":"https://api.github.com/repos/guoci/numpy/contributors","subscribers_url":"https://api.github.com/repos/guoci/numpy/subscribers","subscription_url":"https://api.github.com/repos/guoci/numpy/subscription","commits_url":"https://api.github.com/repos/guoci/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/guoci/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/guoci/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/guoci/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/guoci/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/guoci/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guoci/numpy/merges","archive_url":"https://api.github.com/repos/guoci/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guoci/numpy/downloads","issues_url":"https://api.github.com/repos/guoci/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/guoci/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/guoci/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/guoci/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guoci/numpy/labels{/name}","releases_url":"https://api.github.com/repos/guoci/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/guoci/numpy/deployments","created_at":"2017-04-10T20:16:51Z","updated_at":"2018-10-26T15:46:36Z","pushed_at":"2018-11-15T18:49:16Z","git_url":"git://github.com/guoci/numpy.git","ssh_url":"git@github.com:guoci/numpy.git","clone_url":"https://github.com/guoci/numpy.git","svn_url":"https://github.com/guoci/numpy","homepage":"http://www.numpy.org/","size":60398,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"ff8b0b21e0f17dbcc94fc87ba1194dcbbbe15432","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-11-16T05:48:19Z","pushed_at":"2018-11-16T00:20:22Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":62271,"stargazers_count":8666,"watchers_count":8666,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3124,"mirror_url":null,"archived":false,"open_issues_count":2018,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3124,"open_issues":2018,"watchers":8666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8923"},"html":{"href":"https://github.com/numpy/numpy/pull/8923"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/8923"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/8923/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8923/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/8923/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/3c024c865b45f0d424f61094cd7674c85c7fcd46"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shoyer"}}