{"action":"created","issue":{"url":"https://api.github.com/repos/cherrypy/cheroot/issues/146","repository_url":"https://api.github.com/repos/cherrypy/cheroot","labels_url":"https://api.github.com/repos/cherrypy/cheroot/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/cherrypy/cheroot/issues/146/comments","events_url":"https://api.github.com/repos/cherrypy/cheroot/issues/146/events","html_url":"https://github.com/cherrypy/cheroot/pull/146","id":387150845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NzAzMDY4","number":146,"title":"[WIP] Fix Circle CI builds","user":{"login":"duper51","id":1069320,"node_id":"MDQ6VXNlcjEwNjkzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1069320?v=4","gravatar_id":"","url":"https://api.github.com/users/duper51","html_url":"https://github.com/duper51","followers_url":"https://api.github.com/users/duper51/followers","following_url":"https://api.github.com/users/duper51/following{/other_user}","gists_url":"https://api.github.com/users/duper51/gists{/gist_id}","starred_url":"https://api.github.com/users/duper51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duper51/subscriptions","organizations_url":"https://api.github.com/users/duper51/orgs","repos_url":"https://api.github.com/users/duper51/repos","events_url":"https://api.github.com/users/duper51/events{/privacy}","received_events_url":"https://api.github.com/users/duper51/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-04T07:17:06Z","updated_at":"2018-12-04T21:56:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cherrypy/cheroot/pulls/146","html_url":"https://github.com/cherrypy/cheroot/pull/146","diff_url":"https://github.com/cherrypy/cheroot/pull/146.diff","patch_url":"https://github.com/cherrypy/cheroot/pull/146.patch"},"body":"❓ **What kind of change does this PR introduce?**\r\n  - [ ] 🐞 bug fix\r\n  - [ ] 🐣 feature\r\n  - [ ] 📋 docs update\r\n  - [ ] 📋 tests/coverage improvement\r\n  - [X] 📋 refactoring\r\n  - [ ] 💥 other\r\n\r\n📋 **What is the related issue number (starting with `#`)**\r\n\r\nFix up the tests failing on Travis.\r\n\r\n❓ **What is the current behavior?** (You can also link to an open issue here)\r\n\r\nTravis builds fail due to a PEP compliance error.\r\n\r\n❓ **What is the new behavior (if this is a feature change)?**\r\n\r\nThey no longer fail.\r\n\r\n📋 **Other information**:\r\n\r\nCircleCI builds as well as `pre-commit-failing` builds fail due to an underlying issue with Asteroid. They currently have no builds that work with both Python 2.7 and Python 3.7. As such we might need to rework our testing strategy on that front, as it seems they don't have a build for Python 3.7 yet either.\r\n\r\n📋 **Checklist**:\r\n\r\n  - [X] I think the code is well written\r\n  - [X] I wrote [good commit messages][1]\r\n  - [X] I have [squashed related commits together][2] after the changes have been approved\r\n  - [ ] Unit tests for the changes exist\r\n  - [ ] Integration tests for the changes exist (if applicable)\r\n  - [X] I used the same coding conventions as the rest of the project\r\n  - [X] The new code doesn't generate linter offenses\r\n  - [ ] Documentation reflects the changes\r\n  - [X] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/\r\n[2]: https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cherrypy/cheroot/146)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cherrypy/cheroot/issues/comments/444273985","html_url":"https://github.com/cherrypy/cheroot/pull/146#issuecomment-444273985","issue_url":"https://api.github.com/repos/cherrypy/cheroot/issues/146","id":444273985,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDI3Mzk4NQ==","user":{"login":"webknjaz","id":578543,"node_id":"MDQ6VXNlcjU3ODU0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/578543?v=4","gravatar_id":"","url":"https://api.github.com/users/webknjaz","html_url":"https://github.com/webknjaz","followers_url":"https://api.github.com/users/webknjaz/followers","following_url":"https://api.github.com/users/webknjaz/following{/other_user}","gists_url":"https://api.github.com/users/webknjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/webknjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webknjaz/subscriptions","organizations_url":"https://api.github.com/users/webknjaz/orgs","repos_url":"https://api.github.com/users/webknjaz/repos","events_url":"https://api.github.com/users/webknjaz/events{/privacy}","received_events_url":"https://api.github.com/users/webknjaz/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T21:56:03Z","updated_at":"2018-12-04T21:56:03Z","author_association":"MEMBER","body":"@duper51 it's a new and already known bug in pytest: https://github.com/pytest-dev/pytest/issues/4344\r\n\r\nPossible workaround for us: we could add `grep -v '__init__.py' |` before `xargs` as a temporary fix."}}
{"actor":{"display_login":"webknjaz"}}