{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/244697363","pull_request_review_id":188621538,"id":244697363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY5NzM2Mw==","diff_hunk":"@@ -156,7 +155,7 @@ public ChargeEntityFixture withCorporateSurcharge(Long corporateSurcharge) {\n     }\n     \n     public ChargeEntityFixture withWalletType(WalletType walletType) {\n-        this.walletType = walletType;\n+        WalletType walletType1 = walletType;","path":"src/test/java/uk/gov/pay/connector/model/domain/ChargeEntityFixture.java","position":32,"original_position":32,"commit_id":"c46f0bcd2cccdd60f794da2d8c63a5b57068516e","original_commit_id":"2a12cfc71d2cdf3eee56a71d9e3297f165031dfc","user":{"login":"alexbishop1","id":24316348,"node_id":"MDQ6VXNlcjI0MzE2MzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/24316348?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbishop1","html_url":"https://github.com/alexbishop1","followers_url":"https://api.github.com/users/alexbishop1/followers","following_url":"https://api.github.com/users/alexbishop1/following{/other_user}","gists_url":"https://api.github.com/users/alexbishop1/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbishop1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbishop1/subscriptions","organizations_url":"https://api.github.com/users/alexbishop1/orgs","repos_url":"https://api.github.com/users/alexbishop1/repos","events_url":"https://api.github.com/users/alexbishop1/events{/privacy}","received_events_url":"https://api.github.com/users/alexbishop1/received_events","type":"User","site_admin":false},"body":"It looks like this method is actually useless as it currently stands","created_at":"2019-01-02T10:07:47Z","updated_at":"2019-01-02T10:17:19Z","html_url":"https://github.com/alphagov/pay-connector/pull/932#discussion_r244697363","pull_request_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/932","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/244697363"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/932#discussion_r244697363"},"pull_request":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/932"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/932","id":241688167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjg4MTY3","html_url":"https://github.com/alphagov/pay-connector/pull/932","diff_url":"https://github.com/alphagov/pay-connector/pull/932.diff","patch_url":"https://github.com/alphagov/pay-connector/pull/932.patch","issue_url":"https://api.github.com/repos/alphagov/pay-connector/issues/932","number":932,"state":"open","locked":false,"title":"BAU: IntelliJ-inspired code cleanups","user":{"login":"rhowe-gds","id":23742767,"node_id":"MDQ6VXNlcjIzNzQyNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/23742767?v=4","gravatar_id":"","url":"https://api.github.com/users/rhowe-gds","html_url":"https://github.com/rhowe-gds","followers_url":"https://api.github.com/users/rhowe-gds/followers","following_url":"https://api.github.com/users/rhowe-gds/following{/other_user}","gists_url":"https://api.github.com/users/rhowe-gds/gists{/gist_id}","starred_url":"https://api.github.com/users/rhowe-gds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhowe-gds/subscriptions","organizations_url":"https://api.github.com/users/rhowe-gds/orgs","repos_url":"https://api.github.com/users/rhowe-gds/repos","events_url":"https://api.github.com/users/rhowe-gds/events{/privacy}","received_events_url":"https://api.github.com/users/rhowe-gds/received_events","type":"User","site_admin":false},"body":"## WHAT\r\nAddress some rather dull issues identified by IntelliJ\r\n\r\n* Unnecessary variables\r\n* Static things accessed via instances\r\n* Times when primitive types are more appropriate\r\n* Suppress some warnings about our unchecked use of Optionals in tests\r\n\r\n## HOW \r\nSee if the changes look sensible\r\nSee if CI passes\r\n\r\n\r\n","created_at":"2019-01-02T07:54:54Z","updated_at":"2019-01-02T10:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3802bbb7e52bd3d3feb9c4fa2746a4d87bfe53","assignee":{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false},"assignees":[{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/932/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/932/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/issues/932/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/c46f0bcd2cccdd60f794da2d8c63a5b57068516e","head":{"label":"alphagov:bau_intellij_appeasements","ref":"bau_intellij_appeasements","sha":"c46f0bcd2cccdd60f794da2d8c63a5b57068516e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-12-31T12:08:23Z","pushed_at":"2019-01-02T10:12:07Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":18616,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"ca82938ad7279490f09c6e195c2ad0603afdf7df","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-12-31T12:08:23Z","pushed_at":"2019-01-02T10:12:07Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":18616,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/932"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/932"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/932"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/932/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/932/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/932/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-connector/statuses/c46f0bcd2cccdd60f794da2d8c63a5b57068516e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexbishop1"}}