{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/230188790","pull_request_review_id":170869347,"id":230188790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDE4ODc5MA==","diff_hunk":"@@ -681,6 +686,21 @@ public void shouldNotIncludeSslPropertiesInListPropertiesOutput() {\n         not(hasItems(KsqlConfig.SSL_CONFIG_NAMES.toArray(new String[0]))));\n   }\n \n+  // Todo: Same style test for the other request handlers.\n+  @Test\n+  public void shouldUpdateTheLastRequestTime() {","path":"ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/resources/KsqlResourceTest.java","position":36,"original_position":36,"commit_id":"3eabd2a27695272794e95f8d8f5ec7a5b901571b","original_commit_id":"3eabd2a27695272794e95f8d8f5ec7a5b901571b","user":{"login":"big-andy-coates","id":8012398,"node_id":"MDQ6VXNlcjgwMTIzOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8012398?v=4","gravatar_id":"","url":"https://api.github.com/users/big-andy-coates","html_url":"https://github.com/big-andy-coates","followers_url":"https://api.github.com/users/big-andy-coates/followers","following_url":"https://api.github.com/users/big-andy-coates/following{/other_user}","gists_url":"https://api.github.com/users/big-andy-coates/gists{/gist_id}","starred_url":"https://api.github.com/users/big-andy-coates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-andy-coates/subscriptions","organizations_url":"https://api.github.com/users/big-andy-coates/orgs","repos_url":"https://api.github.com/users/big-andy-coates/repos","events_url":"https://api.github.com/users/big-andy-coates/events{/privacy}","received_events_url":"https://api.github.com/users/big-andy-coates/received_events","type":"User","site_admin":false},"body":"An easy to read test - yay!! :D","created_at":"2018-11-01T20:36:14Z","updated_at":"2018-11-01T20:43:19Z","html_url":"https://github.com/confluentinc/ksql/pull/2020#discussion_r230188790","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2020","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/230188790"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2020#discussion_r230188790"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2020"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/2020","id":220962804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTYyODA0","html_url":"https://github.com/confluentinc/ksql/pull/2020","diff_url":"https://github.com/confluentinc/ksql/pull/2020.diff","patch_url":"https://github.com/confluentinc/ksql/pull/2020.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/2020","number":2020,"state":"open","locked":false,"title":"Version checker improvement","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"### Description \r\nThis is an improvement to our existing version checker. We add a new field, `isActive` to the version checker message indicating if there was any interaction with the server in the last 24 hour or there is any running query in the engine.\r\n\r\nThe activity check is implemented using `ActiveChecker` interface with two methods: \r\n\r\n- `void onRequest(long requestTime, boolean hasActiveQuery)` which is called whenever there is any interaction with the server. It will register the request time and if there is any active queries in the engine.\r\n\r\n- `boolean isActive()` which is called to see of the server was active.\r\n\r\n\r\n\r\n### Testing done \r\nUnit test was added.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-10-07T17:57:11Z","updated_at":"2018-11-01T20:43:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d545c9fbfba8d6362442e22ce49f07038c579b01","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dguy","id":54829,"node_id":"MDQ6VXNlcjU0ODI5","avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},{"login":"apurvam","id":830220,"node_id":"MDQ6VXNlcjgzMDIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},{"login":"rodesai","id":2610028,"node_id":"MDQ6VXNlcjI2MTAwMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/2610028?v=4","gravatar_id":"","url":"https://api.github.com/users/rodesai","html_url":"https://github.com/rodesai","followers_url":"https://api.github.com/users/rodesai/followers","following_url":"https://api.github.com/users/rodesai/following{/other_user}","gists_url":"https://api.github.com/users/rodesai/gists{/gist_id}","starred_url":"https://api.github.com/users/rodesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodesai/subscriptions","organizations_url":"https://api.github.com/users/rodesai/orgs","repos_url":"https://api.github.com/users/rodesai/repos","events_url":"https://api.github.com/users/rodesai/events{/privacy}","received_events_url":"https://api.github.com/users/rodesai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2020/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2020/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/2020/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/3eabd2a27695272794e95f8d8f5ec7a5b901571b","head":{"label":"hjafarpour:Version-Checker-Improvement","ref":"Version-Checker-Improvement","sha":"3eabd2a27695272794e95f8d8f5ec7a5b901571b","user":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"repo":{"id":102027996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwMjc5OTY=","name":"ksql","full_name":"hjafarpour/ksql","private":false,"owner":{"login":"hjafarpour","id":16784742,"node_id":"MDQ6VXNlcjE2Nzg0NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hjafarpour/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/hjafarpour/ksql","forks_url":"https://api.github.com/repos/hjafarpour/ksql/forks","keys_url":"https://api.github.com/repos/hjafarpour/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjafarpour/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjafarpour/ksql/teams","hooks_url":"https://api.github.com/repos/hjafarpour/ksql/hooks","issue_events_url":"https://api.github.com/repos/hjafarpour/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/hjafarpour/ksql/events","assignees_url":"https://api.github.com/repos/hjafarpour/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/hjafarpour/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/hjafarpour/ksql/tags","blobs_url":"https://api.github.com/repos/hjafarpour/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjafarpour/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjafarpour/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjafarpour/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjafarpour/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/hjafarpour/ksql/languages","stargazers_url":"https://api.github.com/repos/hjafarpour/ksql/stargazers","contributors_url":"https://api.github.com/repos/hjafarpour/ksql/contributors","subscribers_url":"https://api.github.com/repos/hjafarpour/ksql/subscribers","subscription_url":"https://api.github.com/repos/hjafarpour/ksql/subscription","commits_url":"https://api.github.com/repos/hjafarpour/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjafarpour/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjafarpour/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjafarpour/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjafarpour/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/hjafarpour/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjafarpour/ksql/merges","archive_url":"https://api.github.com/repos/hjafarpour/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjafarpour/ksql/downloads","issues_url":"https://api.github.com/repos/hjafarpour/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/hjafarpour/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/hjafarpour/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/hjafarpour/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjafarpour/ksql/labels{/name}","releases_url":"https://api.github.com/repos/hjafarpour/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/hjafarpour/ksql/deployments","created_at":"2017-08-31T17:43:25Z","updated_at":"2017-08-31T18:12:01Z","pushed_at":"2018-11-01T18:11:31Z","git_url":"git://github.com/hjafarpour/ksql.git","ssh_url":"git@github.com:hjafarpour/ksql.git","clone_url":"https://github.com/hjafarpour/ksql.git","svn_url":"https://github.com/hjafarpour/ksql","homepage":"","size":12740,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:master","ref":"master","sha":"3b1bd7d419b8c460a70ad6c4a77fae814a6b4f0b","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-11-01T15:49:54Z","pushed_at":"2018-11-01T18:11:35Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":11889,"stargazers_count":1990,"watchers_count":1990,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":373,"mirror_url":null,"archived":false,"open_issues_count":384,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":373,"open_issues":384,"watchers":1990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2020"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2020"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2020"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2020/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2020/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2020/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/3eabd2a27695272794e95f8d8f5ec7a5b901571b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"big-andy-coates"}}