{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/21601","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/21601/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21601/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/21601/events","html_url":"https://github.com/dotnet/coreclr/pull/21601","id":392763279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTYzMjY2","number":21601,"title":"Ensure that the S.N.Vector methods are marked as [Intrinsic] and that the attribute is respected by the runtime","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-19T20:22:16Z","updated_at":"2018-12-19T20:22:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21601","html_url":"https://github.com/dotnet/coreclr/pull/21601","diff_url":"https://github.com/dotnet/coreclr/pull/21601.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21601.patch"},"body":"As noted here: https://github.com/dotnet/coreclr/pull/21518#issuecomment-448375887 and here: https://github.com/dotnet/corefx/issues/31425#issuecomment-448390800...\r\n\r\nMany of the S.N.Vector methds were marked as `[Intrinsic]`. However, for the S.N.Vector methods, the runtime was not actually checking for the `[Intrinsic]` attribute and instead just looked at all methods in the types marked `[Intrinsic]`. There were indeed several methods not marked as `[Intrinsic]` that were being handled as intrinsics, there were also some methods marked as `[Intrinsic]` that were not appropriately hooked up in the runtime. This put us in a scenario where:\r\n* You could not determine if a method could be treated as intrinsic or not by looking at the source code in CoreFX\r\n* You could not locally disable intrinsic recognition of a method by removing the attribute (making investigations around https://github.com/dotnet/corefx/issues/31425 difficult)\r\n\r\nThis fixes up the runtime to start checking for the `[Intrinsic]` attribute. It also ensures that all methods we were already treating as intrinsic are appropriately marked as such."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/448731482","html_url":"https://github.com/dotnet/coreclr/pull/21601#issuecomment-448731482","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21601","id":448731482,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODczMTQ4Mg==","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T20:22:44Z","updated_at":"2018-12-19T20:22:44Z","author_association":"MEMBER","body":"CC. @CarolEidt, @fiigii "}}
{"actor":{"display_login":"tannergooding"}}