{"action":"created","issue":{"url":"https://api.github.com/repos/TatianaJin/csci5570/issues/4","repository_url":"https://api.github.com/repos/TatianaJin/csci5570","labels_url":"https://api.github.com/repos/TatianaJin/csci5570/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/TatianaJin/csci5570/issues/4/comments","events_url":"https://api.github.com/repos/TatianaJin/csci5570/issues/4/events","html_url":"https://github.com/TatianaJin/csci5570/issues/4","id":361722193,"node_id":"MDU6SXNzdWUzNjE3MjIxOTM=","number":4,"title":"kv_client_table_test should init KVClientTable<Val> with type double","user":{"login":"RickAi","id":8215775,"node_id":"MDQ6VXNlcjgyMTU3NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8215775?v=4","gravatar_id":"","url":"https://api.github.com/users/RickAi","html_url":"https://github.com/RickAi","followers_url":"https://api.github.com/users/RickAi/followers","following_url":"https://api.github.com/users/RickAi/following{/other_user}","gists_url":"https://api.github.com/users/RickAi/gists{/gist_id}","starred_url":"https://api.github.com/users/RickAi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickAi/subscriptions","organizations_url":"https://api.github.com/users/RickAi/orgs","repos_url":"https://api.github.com/users/RickAi/repos","events_url":"https://api.github.com/users/RickAi/events{/privacy}","received_events_url":"https://api.github.com/users/RickAi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-19T12:21:51Z","updated_at":"2018-09-20T01:57:09Z","closed_at":null,"author_association":"NONE","body":"In the base/abstract_partition_manager.hpp, KVPairs was defined as `std::pair<third_party::SArray<Key>, third_party::SArray<double>>`, where the value is a SArray contains double type values.\r\n\r\nIn the worker/kv_client_table_test.cpp, the Add test init KVClientTable<Val> with type float, during the runtime, when kv_client_table try to call `partition_manager_->Slice(std::make_pair(keys, vals), &sliced);`, it will cause error because there will be a conflit between the float and double type value."},"comment":{"url":"https://api.github.com/repos/TatianaJin/csci5570/issues/comments/423014228","html_url":"https://github.com/TatianaJin/csci5570/issues/4#issuecomment-423014228","issue_url":"https://api.github.com/repos/TatianaJin/csci5570/issues/4","id":423014228,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzAxNDIyOA==","user":{"login":"RickAi","id":8215775,"node_id":"MDQ6VXNlcjgyMTU3NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8215775?v=4","gravatar_id":"","url":"https://api.github.com/users/RickAi","html_url":"https://github.com/RickAi","followers_url":"https://api.github.com/users/RickAi/followers","following_url":"https://api.github.com/users/RickAi/following{/other_user}","gists_url":"https://api.github.com/users/RickAi/gists{/gist_id}","starred_url":"https://api.github.com/users/RickAi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickAi/subscriptions","organizations_url":"https://api.github.com/users/RickAi/orgs","repos_url":"https://api.github.com/users/RickAi/repos","events_url":"https://api.github.com/users/RickAi/events{/privacy}","received_events_url":"https://api.github.com/users/RickAi/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T01:57:09Z","updated_at":"2018-09-20T01:57:09Z","author_association":"NONE","body":"Personally, I think simply change the float to double while initialize kv_client_table will be better,  it will not cause lots of change in the project, and enough to satisfy the current training requirement. \r\n\r\nIn the future when kv_client_table need support different type of values, we can change the KVPairs to a general pair type.\r\n\r\nI will send a pull request if you agree too."}}
{"actor":{"display_login":"RickAi"}}