{"action":"created","comment":{"url":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments/238029550","pull_request_review_id":180484163,"id":238029550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAyOTU1MA==","diff_hunk":"@@ -32,7 +32,7 @@\n     \"\"\"),\n     description='Introduces method for choosing PCA dimensionality '\n                 'automatically')\n-def run_svd(data):\n+def run_svd(data, mle=True):","path":"tedana/decomposition/eigendecomp.py","position":5,"original_position":5,"commit_id":"ddb307b17f89128eb7abeec0b3647c65cd7ffdf2","original_commit_id":"ddb307b17f89128eb7abeec0b3647c65cd7ffdf2","user":{"login":"tsalo","id":8228902,"node_id":"MDQ6VXNlcjgyMjg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"body":"We'll need to split this somehow so that the MLE paper is only cited when MLE is used, but I'm not sure what the best way to do that is.","created_at":"2018-11-30T23:07:22Z","updated_at":"2018-11-30T23:07:22Z","html_url":"https://github.com/ME-ICA/tedana/pull/164#discussion_r238029550","pull_request_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/164","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments/238029550"},"html":{"href":"https://github.com/ME-ICA/tedana/pull/164#discussion_r238029550"},"pull_request":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/ME-ICA/tedana/pulls/164","id":234851036,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODUxMDM2","html_url":"https://github.com/ME-ICA/tedana/pull/164","diff_url":"https://github.com/ME-ICA/tedana/pull/164.diff","patch_url":"https://github.com/ME-ICA/tedana/pull/164.patch","issue_url":"https://api.github.com/repos/ME-ICA/tedana/issues/164","number":164,"state":"open","locked":false,"title":"[ENH] Split automatic dimensionality detection from decision tree in TEDPCA","user":{"login":"tsalo","id":8228902,"node_id":"MDQ6VXNlcjgyMjg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"body":"<!---\r\nThis is a suggested pull request template for tedana.\r\nIt's designed to capture information we've found to be useful in reviewing pull requests.\r\n\r\nIf there is other information that would be helpful to include, please don't hesitate to add it!\r\n\r\nPlease also label your pull request with the relevant tags.\r\nSee here for more information and a list of available options:\r\nhttps://github.com/ME-ICA/tedana/blob/master/CONTRIBUTING.md#pull-requests\r\n-->\r\n\r\n<!-- Please indicate after the # which issue you're closing with this PR.\r\nThis is helpful for the maintainers AND will magically close the issue when this\r\npull request is merged!\r\nhttps://help.github.com/articles/closing-issues-using-keywords -->\r\nRef. #101.\r\n\r\nWe can also revisit `kdaw` and `rdaw` if the decision tree is no longer going to be the default, since that's the only case in which they're used.\r\n\r\n<!-- Please give a brief overview of what has changed in the PR.\r\nIf you're not sure what to write, consider it a note to the maintainers to indicate\r\nwhat they should be looking for when they review the pull request. -->\r\nChanges proposed in this pull request:\r\n\r\n- Add argument (`tedpca`) to CLI that specifies method for PCA component selection. Current options are `'mle'` (uses MLE to automatically detect dimensionality of data), `'kundu'` (decomposes data into standard number of components, then uses decision tree to select components), and `'kundu-stabilize'` (same as `'kundu'`, but uses the additional steps from the `stabilize` argument). The default is `'mle'`.\r\n- Remove `stabilize` argument.","created_at":"2018-11-30T02:25:12Z","updated_at":"2018-11-30T23:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8d933af6fc1d235a9199d88ae3d1ddcb73efa32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/164/commits","review_comments_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/164/comments","review_comment_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ME-ICA/tedana/issues/164/comments","statuses_url":"https://api.github.com/repos/ME-ICA/tedana/statuses/ddb307b17f89128eb7abeec0b3647c65cd7ffdf2","head":{"label":"tsalo:tedpca","ref":"tedpca","sha":"ddb307b17f89128eb7abeec0b3647c65cd7ffdf2","user":{"login":"tsalo","id":8228902,"node_id":"MDQ6VXNlcjgyMjg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"repo":{"id":131185627,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExODU2Mjc=","name":"tedana","full_name":"tsalo/tedana","private":false,"owner":{"login":"tsalo","id":8228902,"node_id":"MDQ6VXNlcjgyMjg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tsalo/tedana","description":"TE-dependent analysis of multi-echo fMRI","fork":true,"url":"https://api.github.com/repos/tsalo/tedana","forks_url":"https://api.github.com/repos/tsalo/tedana/forks","keys_url":"https://api.github.com/repos/tsalo/tedana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsalo/tedana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsalo/tedana/teams","hooks_url":"https://api.github.com/repos/tsalo/tedana/hooks","issue_events_url":"https://api.github.com/repos/tsalo/tedana/issues/events{/number}","events_url":"https://api.github.com/repos/tsalo/tedana/events","assignees_url":"https://api.github.com/repos/tsalo/tedana/assignees{/user}","branches_url":"https://api.github.com/repos/tsalo/tedana/branches{/branch}","tags_url":"https://api.github.com/repos/tsalo/tedana/tags","blobs_url":"https://api.github.com/repos/tsalo/tedana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsalo/tedana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsalo/tedana/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsalo/tedana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsalo/tedana/statuses/{sha}","languages_url":"https://api.github.com/repos/tsalo/tedana/languages","stargazers_url":"https://api.github.com/repos/tsalo/tedana/stargazers","contributors_url":"https://api.github.com/repos/tsalo/tedana/contributors","subscribers_url":"https://api.github.com/repos/tsalo/tedana/subscribers","subscription_url":"https://api.github.com/repos/tsalo/tedana/subscription","commits_url":"https://api.github.com/repos/tsalo/tedana/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsalo/tedana/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsalo/tedana/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsalo/tedana/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsalo/tedana/contents/{+path}","compare_url":"https://api.github.com/repos/tsalo/tedana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsalo/tedana/merges","archive_url":"https://api.github.com/repos/tsalo/tedana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsalo/tedana/downloads","issues_url":"https://api.github.com/repos/tsalo/tedana/issues{/number}","pulls_url":"https://api.github.com/repos/tsalo/tedana/pulls{/number}","milestones_url":"https://api.github.com/repos/tsalo/tedana/milestones{/number}","notifications_url":"https://api.github.com/repos/tsalo/tedana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsalo/tedana/labels{/name}","releases_url":"https://api.github.com/repos/tsalo/tedana/releases{/id}","deployments_url":"https://api.github.com/repos/tsalo/tedana/deployments","created_at":"2018-04-26T16:54:42Z","updated_at":"2018-11-28T23:42:40Z","pushed_at":"2018-11-30T02:42:59Z","git_url":"git://github.com/tsalo/tedana.git","ssh_url":"git@github.com:tsalo/tedana.git","clone_url":"https://github.com/tsalo/tedana.git","svn_url":"https://github.com/tsalo/tedana","homepage":"https://tedana.readthedocs.io/","size":27116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ME-ICA:master","ref":"master","sha":"6e21c5de51b5cd0b1b11cc1c63fe91bed3ba97a0","user":{"login":"ME-ICA","id":30531571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMxNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/30531571?v=4","gravatar_id":"","url":"https://api.github.com/users/ME-ICA","html_url":"https://github.com/ME-ICA","followers_url":"https://api.github.com/users/ME-ICA/followers","following_url":"https://api.github.com/users/ME-ICA/following{/other_user}","gists_url":"https://api.github.com/users/ME-ICA/gists{/gist_id}","starred_url":"https://api.github.com/users/ME-ICA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ME-ICA/subscriptions","organizations_url":"https://api.github.com/users/ME-ICA/orgs","repos_url":"https://api.github.com/users/ME-ICA/repos","events_url":"https://api.github.com/users/ME-ICA/events{/privacy}","received_events_url":"https://api.github.com/users/ME-ICA/received_events","type":"Organization","site_admin":false},"repo":{"id":110845855,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4NDU4NTU=","name":"tedana","full_name":"ME-ICA/tedana","private":false,"owner":{"login":"ME-ICA","id":30531571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMxNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/30531571?v=4","gravatar_id":"","url":"https://api.github.com/users/ME-ICA","html_url":"https://github.com/ME-ICA","followers_url":"https://api.github.com/users/ME-ICA/followers","following_url":"https://api.github.com/users/ME-ICA/following{/other_user}","gists_url":"https://api.github.com/users/ME-ICA/gists{/gist_id}","starred_url":"https://api.github.com/users/ME-ICA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ME-ICA/subscriptions","organizations_url":"https://api.github.com/users/ME-ICA/orgs","repos_url":"https://api.github.com/users/ME-ICA/repos","events_url":"https://api.github.com/users/ME-ICA/events{/privacy}","received_events_url":"https://api.github.com/users/ME-ICA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ME-ICA/tedana","description":"TE-dependent analysis of multi-echo fMRI","fork":false,"url":"https://api.github.com/repos/ME-ICA/tedana","forks_url":"https://api.github.com/repos/ME-ICA/tedana/forks","keys_url":"https://api.github.com/repos/ME-ICA/tedana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ME-ICA/tedana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ME-ICA/tedana/teams","hooks_url":"https://api.github.com/repos/ME-ICA/tedana/hooks","issue_events_url":"https://api.github.com/repos/ME-ICA/tedana/issues/events{/number}","events_url":"https://api.github.com/repos/ME-ICA/tedana/events","assignees_url":"https://api.github.com/repos/ME-ICA/tedana/assignees{/user}","branches_url":"https://api.github.com/repos/ME-ICA/tedana/branches{/branch}","tags_url":"https://api.github.com/repos/ME-ICA/tedana/tags","blobs_url":"https://api.github.com/repos/ME-ICA/tedana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ME-ICA/tedana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ME-ICA/tedana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ME-ICA/tedana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ME-ICA/tedana/statuses/{sha}","languages_url":"https://api.github.com/repos/ME-ICA/tedana/languages","stargazers_url":"https://api.github.com/repos/ME-ICA/tedana/stargazers","contributors_url":"https://api.github.com/repos/ME-ICA/tedana/contributors","subscribers_url":"https://api.github.com/repos/ME-ICA/tedana/subscribers","subscription_url":"https://api.github.com/repos/ME-ICA/tedana/subscription","commits_url":"https://api.github.com/repos/ME-ICA/tedana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ME-ICA/tedana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ME-ICA/tedana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ME-ICA/tedana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ME-ICA/tedana/contents/{+path}","compare_url":"https://api.github.com/repos/ME-ICA/tedana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ME-ICA/tedana/merges","archive_url":"https://api.github.com/repos/ME-ICA/tedana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ME-ICA/tedana/downloads","issues_url":"https://api.github.com/repos/ME-ICA/tedana/issues{/number}","pulls_url":"https://api.github.com/repos/ME-ICA/tedana/pulls{/number}","milestones_url":"https://api.github.com/repos/ME-ICA/tedana/milestones{/number}","notifications_url":"https://api.github.com/repos/ME-ICA/tedana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ME-ICA/tedana/labels{/name}","releases_url":"https://api.github.com/repos/ME-ICA/tedana/releases{/id}","deployments_url":"https://api.github.com/repos/ME-ICA/tedana/deployments","created_at":"2017-11-15T14:45:02Z","updated_at":"2018-11-28T22:32:57Z","pushed_at":"2018-11-30T02:43:01Z","git_url":"git://github.com/ME-ICA/tedana.git","ssh_url":"git@github.com:ME-ICA/tedana.git","clone_url":"https://github.com/ME-ICA/tedana.git","svn_url":"https://github.com/ME-ICA/tedana","homepage":"https://tedana.readthedocs.io/","size":26916,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":23,"open_issues":38,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/164"},"html":{"href":"https://github.com/ME-ICA/tedana/pull/164"},"issue":{"href":"https://api.github.com/repos/ME-ICA/tedana/issues/164"},"comments":{"href":"https://api.github.com/repos/ME-ICA/tedana/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/ME-ICA/tedana/statuses/ddb307b17f89128eb7abeec0b3647c65cd7ffdf2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tsalo"}}